From xen-devel-bounces@lists.xenproject.org Tue Mar 01 01:19:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 01:19:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.280783.478837 (Exim 4.92) (envelope-from ) id 1nOrAH-0002By-BG; Tue, 01 Mar 2022 01:18:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 280783.478837; Tue, 01 Mar 2022 01:18:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOrAH-0002Br-7a; Tue, 01 Mar 2022 01:18:57 +0000 Received: by outflank-mailman (input) for mailman id 280783; Tue, 01 Mar 2022 01:18:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOrAE-0002Bk-Nt for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 01:18:55 +0000 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8be197fd-98fd-11ec-8539-5f4723681683; Tue, 01 Mar 2022 02:18:51 +0100 (CET) Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 21SLkxb7009931; Tue, 1 Mar 2022 01:18:25 GMT Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by mx0b-00069f02.pphosted.com with ESMTP id 3eh14bsb68-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 01 Mar 2022 01:18:25 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 22111ICX172697; Tue, 1 Mar 2022 01:18:24 GMT Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2175.outbound.protection.outlook.com [104.47.56.175]) by userp3020.oracle.com with ESMTP id 3efdnkq9m7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 01 Mar 2022 01:18:24 +0000 Received: from BYAPR10MB2663.namprd10.prod.outlook.com (2603:10b6:a02:a9::20) by SA2PR10MB4668.namprd10.prod.outlook.com (2603:10b6:806:117::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.23; Tue, 1 Mar 2022 01:18:21 +0000 Received: from BYAPR10MB2663.namprd10.prod.outlook.com ([fe80::a0d5:610d:bcf:9b47]) by BYAPR10MB2663.namprd10.prod.outlook.com ([fe80::a0d5:610d:bcf:9b47%4]) with mapi id 15.20.5017.027; Tue, 1 Mar 2022 01:18:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8be197fd-98fd-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=78X/H5zf90bXeuGJATSx0g0BM4dbFOBb56DOWNT6poM=; b=vj4y2GLKHWy81FJz36bhh/UVuVbTktjpQk/GipJ8030YUrPbDFFnXAuLkp81pFinaVA8 QlfOVTf/8iJY0ifl0H4tjLlp1neLnYBIO8pWIWeAYks/xTuUFBNyU1D7RxjrvZLYdtP2 FYfzlyLb5qjhUqu/vnZWt3Z+Q0tpMS9kmqt3R7QRXp3/6XTWKP2pvnAHbSaAVs1ql7KO rmb4jWKzCsutKEjRrSKmrvnx4Qgi5J7mDo/UcDio+2CEhlsLUyZUOSYohJQ7wz+qrh/B cdXq8IrkkR53wwE8D2ZpxgX62/0merFgqWHvliUMJL4nVecPpv5VxiIWXQu98+91dEW6 zQ== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XXlyH51NZgdK5KZaemroAOne0FGq38YGpd+k1eZ0q13+3jHwkDU+vys24zSHMtHPXZYW/sRyq8xvODGm9aCxaf8zt9J++UlLXLKhHU3ZJLwq5Jp8zCuEuo5SPzaYareOSr4TePEPhLkRCuQA6NdUBvdQ8N65zqKWVyA2yynaH9pw21x6YafPn56CC+GPRDX/XJbz2aGfzI4kq2FUdCkElPCPYw35aUeXq49jgbE7x+BYb+G0pMmT3+l9SNflSt0o9jCvNU7G88Nw3kPQrgcf6Oj6jOl0hzgNO3p8RCDLPN1R+MjKxmHjH6sR3JwJ2eV/St/zLCNXyIF1BvHycpiihg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=78X/H5zf90bXeuGJATSx0g0BM4dbFOBb56DOWNT6poM=; b=OEaQyMXyU4aNN05K0kCc3JblpEEtw6wADCUdRail+gitWE8MzXqdo2IsYoPP1AA1K7cx+IrtU476KNXYhZubp0FzAzt147ZrhB2j2ZKWnsklJxgud3qhLcCZwwJP0XpzgDecT4VOVGmrvMP6q2BGymGvPHmbh09CNRF5DHS2un1LCOL8a35S2MkXLIhSimnFJj1AZM7NwVHYPdihUn/4ceAW+Ygi7vBmz2rrlTKMb3bkAF0R1UDYmpdc7EtmTnaD5cWw20MX7jIOaaWm5t0S3HwzJ6H05d6cnHmpHJYKJzKx34kZiGDXTWbZpZCuAQf3IXrZmLbRxnUUqBeGLzaWmg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=78X/H5zf90bXeuGJATSx0g0BM4dbFOBb56DOWNT6poM=; b=pOhkbwi7ujYP+dwVimCD9/W5xMVwO94nF0m/i148CgtBW/w5iqK7KblqoX9sMJW+aAM8uU1ZP+AdrKdGNAp8AtW1QJMgxcHq5AYO/lJGGzelvXG4bz2QCEM4DZ778hgVRt4y4s8Kasa9+G6NKdBjxGjVqocLFyHrdxLiosnASWE= Subject: Re: [PATCH v3 0/1] xen: fix HVM kexec kernel panic To: Boris Ostrovsky , xen-devel@lists.xenproject.org, x86@kernel.org Cc: linux-kernel@vger.kernel.org, jgross@suse.com, sstabellini@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, joe.jin@oracle.com References: <20220224215049.2845-1-dongli.zhang@oracle.com> <9de1059b-6b48-e2c8-60bc-f29b42b217f7@oracle.com> <36014dbd-e63c-cf49-dafd-2d7a8b84db5d@oracle.com> <8e3e4716-22e7-8684-394c-b5a457906975@oracle.com> From: Dongli Zhang Message-ID: Date: Mon, 28 Feb 2022 17:18:17 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 In-Reply-To: <8e3e4716-22e7-8684-394c-b5a457906975@oracle.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SN4PR0501CA0065.namprd05.prod.outlook.com (2603:10b6:803:41::42) To BYAPR10MB2663.namprd10.prod.outlook.com (2603:10b6:a02:a9::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 218b4bb7-e483-4edd-36d2-08d9fb215fb2 X-MS-TrafficTypeDiagnostic: SA2PR10MB4668:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: l2LTV73bT59bOkRP7wM/mfyHzFCM+XGfXNPI+epPYSs1qCf3jGmUUM8SVBsNJnd5CGOVuIqnXVFjzjE1Mm5FZOnuSxxTao8LLf16ZPFNkFRT0cLIm+bzXu2wC/vj5tC6BFbDQd79ssLX3KWO74xxJ+oHbqgarWkwSBAgS1xSPEqZWEdVgIc6T1hx0p10z2SlI7feyJGlOJvlUE5vL3i1duNTPPHNwUie/ey1eh8fvh/tChpIc/kjEmV9vNZ1Vjco79QZMOGOzzZUT9oqXHROyOjXN/PMTcAXdu916jgr0CL02ZNqHGe+Ydzbo3RcTiy7/q2X0cNIbX1KaG4O3zAiYoAHWMNB0+D8g6TEJr9sZ1UYK+L8E9J0smceOuHHPVAMsvft1N+OEkERzXsyghF3DuJrrMoOTP+Wc9EI0KG2bzzvfDi56bc/uHPjFJ/L6C2G8Ax2QJaiIQoRFV2COcwPYrcOrsKqw4Aj12XXk9K/yXeiRCo3y1oTL3AZ5MFqF6PM0vmRVuzInd8wdQiUizGx+G5gWSZgYU/WLKGhkF1QSxver6I5F5CcSFcNTmthfgYowUCfD8NcbN5VCn0U4zqCx1OY7MHdOYzh+akA6EPryRLOAQTfWO/1URRDcJqd5Vi9ENhdZzJGukDj6FedQXOrZ9Psc/2vkOQT+kVKHsfm5RiEmXuzsLtVkqIyfNgbiqa30aaUPXJfGHnwvcYCFeDpgySWpXsh5kwbz+N30ktuh68= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB2663.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(508600001)(6486002)(36756003)(53546011)(6506007)(316002)(6666004)(66476007)(4326008)(8936002)(66556008)(38100700002)(66946007)(6512007)(107886003)(186003)(31686004)(44832011)(7416002)(31696002)(86362001)(2616005)(2906002)(83380400001)(5660300002)(8676002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bG1YRXNVNTdoMGlQS1Yvb3lsYTJnZEV1UXZHekFFT0lLYkdlekR5bEYxcjQ2?= =?utf-8?B?Y3pxTjVlci9zSS9qRkg1aUl4NW1rUUgycEpnSlVyRFJZMmFyNTY0SGxYd1ZI?= =?utf-8?B?dmdoMk5wL01kSFRUYVpyZ09iRkxwWVFtQXpRYm9tZTB4ck0xdVJucHJJQTQw?= =?utf-8?B?bXhFdVd1YW1DMVpuNW84RjFsQi9OVnpjR2NRSWhRUmZZNXVlSVptdm1ScWRa?= =?utf-8?B?VXNvRWlzdGdXeUR1Z3VqdmFmMzIzUWlFUDZ5eUovcFpPcFd6aWhOWXFnODRJ?= =?utf-8?B?UVBCbUVDRmlWclFNS0lXd1FsUSt0MlNPblViY1lNUURmRGdkZmRzSUR0K1dM?= =?utf-8?B?ZzcxamlJc01tQ3huWHRHUkhsY2dOQlVhWW04SU9IbDVUZE5oZUZmWlpZZnFZ?= =?utf-8?B?SWN6VkVYaCtZc3pDd3FnRVdTQXo4OEhKOGdZS3Z0R3cwRDBGczhXd0ZhQ0ps?= =?utf-8?B?SWpjM1QvUzRSNzB0alMwVlYwMk51R2s4NDJlZlZualRXVVBUQkZVVmgvdXZw?= =?utf-8?B?WHNGamlLWXRrSUR6YWdTdm5rZkR5a3B4OXdqTlA2blNRb0JrbjJBcFF2cUxQ?= =?utf-8?B?elY3UVJ5S2xXQ1pEZ3NlOHRFNmt0ZFp2UDJ4VVBlb1BzcVdHeDE4dGI2ZW05?= =?utf-8?B?TzRvMEdLZDNMK2FiZTdDRy8xMlVXbjQ2ZFVPZmVQSmZBVmNtVVhSUDg3akF5?= =?utf-8?B?ejRTd0JSdHBhQ0x1WklKa0MreEloa2QrUkl0Q01qdlc2RVhCcFVTaEF2akll?= =?utf-8?B?QnR4cFZOUmloS2lxdmVYNGs4K3pGWHZpbUgxNFl3dWVMZkxucVlDUzVqT08y?= =?utf-8?B?MGM4MHp5dHdib1kyWkZuazM5ZzJNakZpYzRtRlNtYy92OUJFMG1iY1lReGRY?= =?utf-8?B?VFJPMktUL054YWFuTS82VjZvM1V3QTNiUmptaXBhUXhBQ1REcmpmcm52VEJx?= =?utf-8?B?eGl3Q0VhMzJjSTRmd2djN1JYaE9CQk12cnBoOElNZTM1L0ZiM0pLc3I5TmM3?= =?utf-8?B?Rm9SaENlYVpwMTB5K29IT3VCYU9ZTDZxeHF3cUt2bit0eG9nTXlMblJ1QTZz?= =?utf-8?B?c0hjZHFsbTQ5UDJRbmNDRFdWSHowbG1FNXdkUEo2d1R4U3loRGhmeWxwdXl3?= =?utf-8?B?NGlSSUFscTZRZTJRZ29yQW43eHhLaVlNU1h4NnQwVjlEYkwrai9mbHVGRThM?= =?utf-8?B?WDBGRytGK3FUQWNTZUhpeVNQcXA3Y3doaEY3YmJPeUxYMHIwbU5OMThYV041?= =?utf-8?B?SDQxOHpzWXl2U2dDenpJcTE5bXpLOHJXQmt5ZnZsSUpZZXpxV3JEUHl6WUh2?= =?utf-8?B?U0Y0MWdBU3AxdU1GMUIxa1Nod2FXOUVrKzkrb1I3MGFGOFpEMXNjaG9SeVU3?= =?utf-8?B?TVVnaS9GcC9CQXJhMzZCdXU0N3VCQnUzNDNGM0ovL3ZsZEVLVWJoa1RFUytu?= =?utf-8?B?cGFsWERmNUdIa3FOUVB0U05TZ0ltaHlRUHgySElWT1ZHL3VBUmN6UUd4ZHAx?= =?utf-8?B?QmJwYjUzN1pvbEhMdHRXVkRsOVd5ZUxlOTlsUjJrdUF5N1pjVnJtNC8vSlRu?= =?utf-8?B?YWNCRzZRTVZRVEEvUkI4WDNXZEFmcVpkc21Xd0FXMC9JTG9WbmlnRXhBRUph?= =?utf-8?B?UXluMWE0amp1MjhlZnVwVVB3SWNIWXJuWGEyMnhWdmhrQk03V2ZCWXNYVDFW?= =?utf-8?B?TjAycU5mMEMzRzVpcjB1aytTSDJ4QUN0eXVlalhRL21RWGRlQWF2TlJPZ0Rm?= =?utf-8?B?czl5Ty9JR2ZIVE5KTnd4OTBWdHJHUFBJK1U5YnVrZFZ3SWhJSUlmdHRyQzlO?= =?utf-8?B?ckdIZ0I2OFhjOFgza0F1NzFsa2dEcEdHaUwxcE1wSW5mbmFySVA1SnhLWkI5?= =?utf-8?B?V254dWxDdUdSMWh1MFVjZUNFcXpJTVZ5K2hMZ0RMTFM0NjI3Yml1OFFaY01R?= =?utf-8?B?c0c1alN6Zk5FUzR6M3NoZjVRRGhNenhYU2J5MHRHdVZGWVFPT0pQcnVUSFh1?= =?utf-8?B?ZkQ5VmhuK3NOUm9uMGszYWlNQ21Mb2tVb3pVQU9hQjNlcFlCaDFsQXNhbkQz?= =?utf-8?B?ZmViSUZIZHNFYndhNjNqYkI3RFNjSGVPOGtvYUpHSzJxZ3dCUllXOExTeVpL?= =?utf-8?B?RlEyem5wZldxUmRYSDFMUGNiQmdoc2FjVlNUcU1LenhQRWxTRUw2NzNCWjZI?= =?utf-8?Q?oEaEdrV83vA78ICePxSs3fQfR5NfeuYYsZ/6JMzFVwgN?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 218b4bb7-e483-4edd-36d2-08d9fb215fb2 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2663.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2022 01:18:20.9830 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6DCWVz1lP4ZFydBrgWksfL/fsd2QPZEOY8EUt4lo5olFCqF/JD3+NkRjnn1XPsg71A3Y9bxAzymihL7/mMu0/Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR10MB4668 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10272 signatures=684655 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 bulkscore=0 adultscore=0 phishscore=0 spamscore=0 suspectscore=0 malwarescore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000 definitions=main-2203010004 X-Proofpoint-GUID: o5g6Jbc0krjkzoho8xAWDaq4ZliYCjiN X-Proofpoint-ORIG-GUID: o5g6Jbc0krjkzoho8xAWDaq4ZliYCjiN Hi Boris, On 2/28/22 12:45 PM, Boris Ostrovsky wrote: > > > On 2/25/22 8:17 PM, Dongli Zhang wrote: >> Hi Boris, >> >> On 2/25/22 2:39 PM, Boris Ostrovsky wrote: >>> >>> On 2/24/22 4:50 PM, Dongli Zhang wrote: >>>> This is the v3 of the patch to fix xen kexec kernel panic issue when the >>>> kexec is triggered on VCPU >= 32. >>>> >>>> PANIC: early exception 0x0e IP 10:ffffffffa96679b6 error 0 cr2 0x20 >>>> [    0.000000] CPU: 0 PID: 0 Comm: swapper Not tainted >>>> 5.17.0-rc4xen-00054-gf71077a4d84b-dirty #1 >>>> [    0.000000] Hardware name: Xen HVM domU, BIOS 4.4.4OVM 12/15/2020 >>>> [    0.000000] RIP: 0010:pvclock_clocksource_read+0x6/0xb0 >>>> ... ... >>>> [    0.000000] RSP: 0000:ffffffffaae03e10 EFLAGS: 00010082 ORIG_RAX: >>>> 0000000000000000 >>>> [    0.000000] RAX: 0000000000000000 RBX: 0000000000010000 RCX: >>>> 0000000000000002 >>>> [    0.000000] RDX: 0000000000000003 RSI: ffffffffaac37515 RDI: >>>> 0000000000000020 >>>> [    0.000000] RBP: 0000000000011000 R08: 0000000000000000 R09: >>>> 0000000000000001 >>>> [    0.000000] R10: ffffffffaae03df8 R11: ffffffffaae03c68 R12: >>>> 0000000040000004 >>>> [    0.000000] R13: ffffffffaae03e50 R14: 0000000000000000 R15: >>>> 0000000000000000 >>>> [    0.000000] FS:  0000000000000000(0000) GS:ffffffffab588000(0000) >>>> knlGS:0000000000000000 >>>> [    0.000000] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033 >>>> [    0.000000] CR2: 0000000000000020 CR3: 00000000ea410000 CR4: >>>> 00000000000406a0 >>>> [    0.000000] DR0: 0000000000000000 DR1: 0000000000000000 DR2: >>>> 0000000000000000 >>>> [    0.000000] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: >>>> 0000000000000400 >>>> [    0.000000] Call Trace: >>>> [    0.000000]  >>>> [    0.000000]  ? xen_clocksource_read+0x24/0x40 >>> >>> >>> This is done to set xen_sched_clock_offset which I think will not be used for a >>> while, until sched_clock is called (and the other two uses are for >>> suspend/resume) >>> >>> >>> Can we simply defer 'xen_sched_clock_offset = xen_clocksource_read();' until >>> after all vcpu areas are properly set? Or are there other uses of >>> xen_clocksource_read() before ? >>> >> >> I have tested that below patch will panic kdump kernel. >> > > > > Oh well, so much for that then. Yes, sched_clock() is at least called from > printk path. > > > I guess we will have to go with v2 then, we don't want to start seeing time > going back, even if only with older hypervisors. The only thing I might ask is > that you roll the logic inside xen_hvm_init_time_ops(). Something like > > > xen_hvm_init_time_ops() > { >     /* >      * Wait until per_cpu(xen_vcpu, 0) is initialized which may happen >      * later (e.g. when kdump kernel runs on >=MAX_VIRT_CPUS vcpu) >      */ >     if (__this_cpu_read(xen_vcpu_nr(0)) == NULL) >         return; > I think you meant __this_cpu_read(xen_vcpu). I will call xen_hvm_init_time_ops() at both places, and move the logic into xen_hvm_init_time_ops(). Thank you very much! Dongli Zhang From xen-devel-bounces@lists.xenproject.org Tue Mar 01 02:11:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 02:11:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.280792.478848 (Exim 4.92) (envelope-from ) id 1nOrz0-00082B-DR; Tue, 01 Mar 2022 02:11:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 280792.478848; Tue, 01 Mar 2022 02:11:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOrz0-000824-9S; Tue, 01 Mar 2022 02:11:22 +0000 Received: by outflank-mailman (input) for mailman id 280792; Tue, 01 Mar 2022 02:11:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOryz-00081w-9y for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 02:11:21 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on061d.outbound.protection.outlook.com [2a01:111:f400:fe0c::61d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e13ab0c3-9904-11ec-8eba-a37418f5ba1a; Tue, 01 Mar 2022 03:11:20 +0100 (CET) Received: from AS8PR05CA0024.eurprd05.prod.outlook.com (2603:10a6:20b:311::29) by AM0PR08MB4977.eurprd08.prod.outlook.com (2603:10a6:208:163::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Tue, 1 Mar 2022 02:11:15 +0000 Received: from VE1EUR03FT045.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:311:cafe::1d) by AS8PR05CA0024.outlook.office365.com (2603:10a6:20b:311::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.26 via Frontend Transport; Tue, 1 Mar 2022 02:11:15 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT045.mail.protection.outlook.com (10.152.19.51) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22 via Frontend Transport; Tue, 1 Mar 2022 02:11:14 +0000 Received: ("Tessian outbound 341d209a0e52:v113"); Tue, 01 Mar 2022 02:11:14 +0000 Received: from e10361762603.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id CCC3FD07-384E-4587-84B1-5CA6A48FBC65.1; Tue, 01 Mar 2022 02:11:03 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e10361762603.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 01 Mar 2022 02:11:03 +0000 Received: from PA4PR08MB6253.eurprd08.prod.outlook.com (2603:10a6:102:e4::8) by AM6PR08MB3542.eurprd08.prod.outlook.com (2603:10a6:20b:4b::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.26; Tue, 1 Mar 2022 02:11:02 +0000 Received: from PA4PR08MB6253.eurprd08.prod.outlook.com ([fe80::41e8:ebec:d794:38aa]) by PA4PR08MB6253.eurprd08.prod.outlook.com ([fe80::41e8:ebec:d794:38aa%3]) with mapi id 15.20.5017.027; Tue, 1 Mar 2022 02:11:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e13ab0c3-9904-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a1M0ztFQTIMrYG4qXh093u/gOQoSpWuTTq08M3JdIO4=; b=bQtm0we41TxzxY0PZBWRvBGmaQ5jQl9uJQ8C4QShxtoF1HamP6WkmupuVzFTqszKlv3hEQY0ckw/2rHb8cT9FMbOwkBN+TdgVb46IJxtJPt/kOyCGlwbJUq6mQKExlwxPZhn/aKUw/wcovIC3GLMKjctQ8qAK29n5Xxi26jMhuI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WVROYPzukAoSRBIqR/dsUYshNl/B7yIiq1fq0YbeTHut9zYfuYi8TaZVxFsTgBzndmLPXiRARKxswG4T3KOPmAbsCmMgNFYsZbZv4CuHtFgLj4tpfaEcA6NDRXQEUelmC3t/UlN7kIoZvNfMVx8SnKPfiDAWuguTIh4BpU8SJk8z1lxTjYpL4/i0YCPqgXKdyGWq9KQSEXk8RM8M4FrBJZ7mdHZtfWy5p0CBygy9hsv//HWdjcndDJSYw13Bk6gvhIP7uyCwmPGqzwaHv2xRT2P5+i3XGu0S9OVRcaNr9+2ZrfUGTA4DhyAeZGZ7uWtzgOzL2R5rSHn4clRluEOQoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a1M0ztFQTIMrYG4qXh093u/gOQoSpWuTTq08M3JdIO4=; b=C8SzN9ZEfFVTtOdOg0oaVxrM2c8D4WW5BCC+ozirU4QOQkjK3Cb3K3HZYRdYCbSiaYFFXDtLUWQOP7Z1I/5x58H5+lrMDo/diUvEhWy12r5aSLNImJtaBMsMJ7PQeKEpVmCxkRDoNnLuQ9aNv99vWJs25C4OBEu6gY4w0+oXgVeNSieubYmtYSlURt1Tb1soLlYX9Km8Ih1/UVfqmHRLcq8f/NnBI6elteuLtOBwnip87RcIVZy7yZfcEyOiG4gMLl5WXaHOos2bNZBbM0YaGn0LVxv57E1irQ0dwg1Sz+Fi6yvtahstcHq7l98W6eVpjHvvkfTQJYLOFZ9JbeV8vA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a1M0ztFQTIMrYG4qXh093u/gOQoSpWuTTq08M3JdIO4=; b=bQtm0we41TxzxY0PZBWRvBGmaQ5jQl9uJQ8C4QShxtoF1HamP6WkmupuVzFTqszKlv3hEQY0ckw/2rHb8cT9FMbOwkBN+TdgVb46IJxtJPt/kOyCGlwbJUq6mQKExlwxPZhn/aKUw/wcovIC3GLMKjctQ8qAK29n5Xxi26jMhuI= From: Henry Wang To: Julien Grall , "xen-devel@lists.xenproject.org" , "sstabellini@kernel.org" CC: Bertrand Marquis , Wei Chen , Penny Zheng Subject: RE: [RFC PATCH 0/2] Introduce reserved Xenheap Thread-Topic: [RFC PATCH 0/2] Introduce reserved Xenheap Thread-Index: AQHYKR4hoR5C+vQhgEqBFutamuKD06yktMKAgAPYnoCAAMi0gIAAcnyQ Date: Tue, 1 Mar 2022 02:11:00 +0000 Message-ID: References: <20220224013023.50920-1-Henry.Wang@arm.com> <6269ec3d-039e-d68f-771d-c5e088631410@xen.org> <48a0712c-eff8-dfc1-2136-59317f22321f@xen.org> In-Reply-To: <48a0712c-eff8-dfc1-2136-59317f22321f@xen.org> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 246FB3B4631C3149BD9E89E7691D8904.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: a5b55eb6-df59-4d2f-e80e-08d9fb28c395 x-ms-traffictypediagnostic: AM6PR08MB3542:EE_|VE1EUR03FT045:EE_|AM0PR08MB4977:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: djP+4P/jrjr2962OUuU6B/ey/pW3tZpZuUOd3nnKGXE7CsthXLQ7zT3YMy2mntrdY10q7ZhGUuQdK6kZGiSBMi9WdEYFkTFfbgogeRGhXexBV49dCjPK1nHY5QDvIWoUN2L0ak5VBgkcI/JywkDcvpE/zy8j/a2n8RxAx+ak/g7HzpjBIjUr9hWrdTSeyGT47PsJfSTGZxOAnYuOxsOYIhFTydPGyLTOf5MaxgwpOw2G0c8NvuOju5AR0t8KUBbwFRAefjIIYWw7oylXh1XSLRqGIU3CxCLLp2xceoil6Hs6OpKNynX3om+iJFgmvFzm58rgSHVZmO43z/rQnhmD7TgbIIqipYTBRriM+EUiJ+etLzrmUbQ4xM/ftGp7hK/fgKYpnxp/oZTJOvz1w/b8UYlBfWGcgaORdZSLPHXDct1v6SGyX1NYzO8Wj3Vpkgzx29UCIczZXnIBZCPR9fz8uJxCcHGo2a9p3HM+Zz4Yc9EyIKAct+JKWXLm0LakpPyAeSYeBTh2itKycSwUYjy+Csf0CZxjSYm3NAhdHr5jtqwrnW27EfxTfs6PsJzl0ZDpcK4V9JaAWecHMthIVZ366yDN5YvNloLKLj2wMgyedB9i7ccaq7f2eph0t2YPosz3itJTuy60I5k1tEMfyqrVv5lNj1dwD+TiJIS8Uu0TFUFssiwstg1BPHcK7u8s+WROPg3IaPCbl/bblMdPe8kGoA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR08MB6253.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(55016003)(71200400001)(33656002)(316002)(83380400001)(508600001)(38070700005)(86362001)(6506007)(7696005)(54906003)(110136005)(64756008)(66446008)(53546011)(76116006)(8676002)(66946007)(4326008)(66556008)(186003)(66476007)(26005)(9686003)(122000001)(38100700002)(2906002)(5660300002)(52536014)(8936002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3542 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT045.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 1c20fdce-515c-43ef-9527-08d9fb28bc17 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pufZlOQGZKNpqsmbPWczj3LLcCQTs/zR0rAb7kjfQn83R4ejLzHcW8HOPADS5yBzOjG0thRCwNHRkKEdBD36ZszY1d2zIeHhL6+5LDXWHE5GzEGTF1X20ETxTTPMAFHBH+Ew9DSrwh/7Rp0ahL4V+GrxlKAb1BQip4lY8AkInaIJzZTnVCNS/cM3ZFVDcPd++wxSsUZQYlqFzcWzGcXMkWY/wGEMZfiOG9Pa6G1fzyXE/qAp1xzbJY9/4ueTbXLes/i/qaRUC1INccWt+2bWB2+i9hQ5CNVmoWIxo16Ng4Bx5tJ7nAj6LMyGPuYtGkU41zJjfBAJMt6gdlpmp7RpmV9GaGdjHv9/KzFykWzZFQgjKEjY7mqkx4AozuJhoAlxgbGXnegpqbRxL30YiY6fyjvogDCZWuk0yO7kkG7PEAQyVl6lkL93Lw0cueYLj+QPco/JP5lQ8kIS+h7gugeBJXFtRYUYrPiFPGaTb0d4fn9hTFidOHoWakV5+7SoREfLk8ZFMcPCJ0Sg9upscqB8ZKM4C96bJAczvE9iMyJQJTR176xbpcZpsSeFF81rpz2C3ReGj3Y+OZtpNpWtqbm5xIuWO2UZIeirpzXu0H4CBflXfcFFEGYAk7nJyzlc0jYXB+k4Dk6rnZY0CllJesihp8f4VCqs1tvZBszKxpUH8X0UpnVINA6FSFB7v2aI35ON X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(82310400004)(4326008)(8676002)(2906002)(70586007)(33656002)(5660300002)(53546011)(6506007)(70206006)(8936002)(7696005)(52536014)(9686003)(36860700001)(86362001)(40460700003)(336012)(316002)(81166007)(110136005)(356005)(55016003)(26005)(47076005)(186003)(54906003)(508600001)(83380400001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2022 02:11:14.6874 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a5b55eb6-df59-4d2f-e80e-08d9fb28c395 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT045.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4977 SGkgSnVsaWVuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEp1bGll biBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+IE9uIDI4LzAyLzIwMjIgMDc6MTIsIEhlbnJ5IFdh bmcgd3JvdGU6DQo+ID4gSGkgSnVsaWVuLA0KPiANCj4gSGkgSGVucnksDQo+IA0KPiA+PiAtLS0t LU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiA+PiBGcm9tOiBKdWxpZW4gR3JhbGwgPGp1bGllbkB4 ZW4ub3JnPg0KPiA+PiBIaSBIZW5yeSwNCj4gPj4NCj4gPj4gT24gMjQvMDIvMjAyMiAwMTozMCwg SGVucnkgV2FuZyB3cm90ZToNCj4gPj4+IFRoZSByZXNlcnZlZCBYZW5oZWFwLCBvciBzdGF0aWNh bGx5IGNvbmZpZ3VyZWQgWGVuaGVhcCwgcmVmZXJzIHRvIHBhcnRzDQo+ID4+PiBvZiBSQU0gcmVz ZXJ2ZWQgaW4gdGhlIGJlZ2lubmluZyBmb3IgWGVuaGVhcC4gTGlrZSB0aGUgc3RhdGljIG1lbW9y eQ0KPiA+Pj4gYWxsb2NhdGlvbiwgc3VjaCByZXNlcnZlZCBYZW5oZWFwIHJlZ2lvbnMgYXJlIHJl c2VydmVkIGJ5IGNvbmZpZ3VyYXRpb24NCj4gPj4+IGluIHRoZSBkZXZpY2UgdHJlZSB1c2luZyBw aHlzaWNhbCBhZGRyZXNzIHJhbmdlcy4NCj4gPj4NCj4gPj4gSW4gWGVuLCB3ZSBoYXZlIHRoZSBj b25jZXB0IG9mIGRvbWhlYXAgYW5kIHhlbmhlYXAuIEZvciBBcm02NCBhbmQNCj4geDg2DQo+ID4+ IHRoZXkgd291bGQgYmUgdGhlIHNhbWUuIEJ1dCBmb3IgQXJtMzIsIHRoZXkgd291bGQgYmUgZGlm ZmVyZW50OiB4ZW5oZWFwDQo+ID4+IGlzIGFsd2F5cyBtYXBwZWQgd2hlcmVhcyBkb21oZWFwIGlz IHNlcGFyYXRlLg0KPiA+Pg0KPiA+PiBTa2ltbWluZyB0aHJvdWdoIHRoZSBzZXJpZXMsIEkgdGhp bmsgeW91IHdhbnQgdG8gdXNlIHRoZSByZWdpb24gZm9yIGJvdGgNCj4gPj4gZG9taGVhcCBhbmQg eGVuaGVhcC4gSXMgdGhhdCBjb3JyZWN0Pw0KPiA+DQo+ID4gWWVzIEkgdGhpbmsgdGhhdCB3b3Vs ZCBiZSBjb3JyZWN0LCBmb3IgQXJtMzIsIGluc3RlYWQgb2YgdXNpbmcgdGhlIGZ1bGwNCj4gPiBg cmFtX3BhZ2VzYCBhcyB0aGUgaW5pdGlhbCB2YWx1ZSBvZiBgaGVhcF9wYWdlc2AsIHdlIHdhbnQg dG8gdXNlIHRoZQ0KPiA+IHJlZ2lvbiBzcGVjaWZpZWQgaW4gdGhlIGRldmljZSB0cmVlLiBCdXQg d2UgYXJlIGNvbmZ1c2VkIGlmIHRoaXMgaXMgdGhlDQo+ID4gY29ycmVjdCAob3IgcHJlZmVycmVk KSB3YXkgZm9yIEFybTMyLCBzbyBpbiB0aGlzIHNlcmllcyB3ZSBvbmx5DQo+ID4gaW1wbGVtZW50 ZWQgdGhlIHJlc2VydmVkIGhlYXAgZm9yIEFybTY0Lg0KPiANCj4gVGhhdCdzIGFuIGludGVyZXN0 aW5nIHBvaW50LiBXaGVuIEkgc2tpbW1lZCB0aHJvdWdoIHRoZSBzZXJpZXMgb24NCj4gRnJpZGF5 LCBteSBmaXJzdCB0aG91Z2h0IHdhcyB0aGF0IGZvciBhcm0zMiBpdCB3b3VsZCBiZSBvbmx5IHhl bmhlYXAgKHNvDQo+IGFsbCB0aGUgcmVzdCBvZiBtZW1vcnkgaXMgZG9taGVhcCkuDQo+IA0KPiBI b3dldmVyLCBYZW4gY2FuIGFsbG9jYXRlIG1lbW9yeSBmcm9tIGRvbWhlYXAgZm9yIGl0cyBvd24g cHVycG9zZSAoZS5nLg0KPiB3ZSBkb24ndCBuZWVkIGNvbnRpZ3VvdXMgbWVtb3J5LCBvciBmb3Ig cGFnZS10YWJsZXMpLg0KPiANCj4gSW4gYSBmdWxseSBzdGF0aWMgZW52aXJvbm1lbnQsIHRoZSBk b21oZWFwIGFuZCB4ZW5oZWFwIGFyZSBib3RoIGdvaW5nIHRvDQo+IGJlIHF1aXRlIHNtYWxsLiBJ dCB3b3VsZCBhbHNvIGJlIHNvbWV3aGF0IGRpZmZpY3VsdCBmb3IgYSB1c2VyIHRvIHNpemUNCj4g aXQuIFNvIEkgdGhpbmssIGl0IHdvdWxkIGJlIGVhc2llciB0byB1c2UgdGhlIHJlZ2lvbiB5b3Ug aW50cm9kdWNlIGZvcg0KPiBib3RoIGRvbWhlYXAgYW5kIHhlbmhlYXAuDQo+IA0KPiBTdGVmYW5v LCBCZXJ0cmFuZCwgYW55IG9waW9uaW9ucz8NCj4gDQo+IE9uIGEgc2VwYXJhdGUgdG9waWMsIEkg dGhpbmsgd2UgbmVlZCBzb21lIGRvY3VtZW50YXRpb24gZXhwbGFpbmluZyBob3cgYQ0KPiB1c2Vy IGNhbiBzaXplIHRoZSB4ZW5oZWFwLiBIb3cgZGlkIHlvdSBmaWd1cmUgb3V0IGZvciB5b3VyIHNl dHVwPw0KDQpOb3Qgc3VyZSBpZiBJIGZ1bGx5IHVuZGVyc3RhbmQgdGhlIHF1ZXN0aW9uLiBJIHdp bGwgZXhwbGFpbiBpbiB0d28gcGFydHM6IEkgdGVzdGVkDQp0aGlzIHNlcmllcyBvbiBhIGRvbTBs ZXNzIChzdGF0aWMgbWVtKSBzeXN0ZW0gb24gRlZQX0Jhc2UuDQooMSkgRm9yIGNvbmZpZ3VyaW5n IHRoZSBzeXN0ZW0sIEkgZm9sbG93ZWQgdGhlIGRvY3VtZW50YXRpb24gSSBhZGRlZCBpbiB0aGUN CmZpcnN0IHBhdGNoIGluIHRoaXMgc2VyaWVzIChkb2NzL21pc2MvYXJtL2RldmljZS10cmVlL2Jv b3RpbmcudHh0KS4gVGhlIGlkZWEgaXMNCmFkZGluZyBzb21lIHN0YXRpYyBtZW0gcmVnaW9ucyB1 bmRlciB0aGUgY2hvc2VuIG5vZGUuDQoNCiAgICAgY2hvc2VuIHsNCisgICAgICAgICN4ZW4sc3Rh dGljLW1lbS1hZGRyZXNzLWNlbGxzID0gPDB4Mj47DQorICAgICAgICAjeGVuLHN0YXRpYy1tZW0t c2l6ZS1jZWxscyA9IDwweDI+Ow0KKyAgICAgICAgeGVuLHN0YXRpYy1tZW0gPSA8MHg4IDB4ODAw MDAwMDAgMHgwIDB4MDAxMDAwMDAgMHg4IDB4OTAwMDAwMDAgMHgwIDB4MDgwMDAwMDA+Ow0KICAg ICBbLi4uXQ0KICAgICB9DQoNCigyKSBGb3IgdmVyaWZ5aW5nIHRoaXMgc2VyaWVzLCB3aGF0IEkg ZGlkIHdhcyBiYXNpY2FsbHkgcGxheWluZyB3aXRoIHRoZSByZWdpb24gc2l6ZQ0KYW5kIG51bWJl ciBvZiB0aGUgcmVnaW9ucywgYWRkaW5nIHByaW50a3MgYW5kIGFsc28gc2VlIGlmIHRoZSBndWVz dHMgY2FuIGJvb3QNCmFzIGV4cGVjdGVkIHdoZW4gSSBjaGFuZ2UgdGhlIHhlbmhlYXAgc2l6ZS4N Cg0KPiANCj4gPj4NCj4gPj4gRnVydGhlbW9yZSwgbm93IHRoYXQgd2UgYXJlIGludHJvZHVjaW5n IG1vcmUgc3RhdGljIHJlZ2lvbiwgaXQgd2lsbCBnZXQNCj4gPj4gZWFzaWVyIHRvIG92ZXJsYXAg dGhlIHJlZ2lvbnMgYnkgbWlzdGFrZXMuIEkgdGhpbmsgd2Ugd2FudCB0byBoYXZlIHNvbWUNCj4g Pj4gbG9naWMgaW4gWGVuIChvciBvdXRzaWRlKSB0byBlbnN1cmUgdGhhdCBub25lIG9mIHRoZW0g b3ZlcmxhcHMuIERvIHlvdQ0KPiA+PiBoYXZlIGFueSBwbGFuIGZvciB0aGF0Pw0KPiA+DQo+ID4g VG90YWxseSBhZ3JlZSB3aXRoIHRoaXMgaWRlYSwgYnV0IGJlZm9yZSB3ZSBhY3R1YWxseSBpbXBs ZW1lbnQgdGhlIGNvZGUsDQo+ID4gd2Ugd291bGQgbGlrZSB0byBmaXJzdGx5IHNoYXJlIG91ciB0 aG91Z2h0cyBvbiB0aGlzOiBPbmUgb3B0aW9uIGNvdWxkIGJlIHRvDQo+ID4gYWRkIGRhdGEgc3Ry dWN0dXJlcyB0byBub3RlcyBkb3duIHRoZXNlIHN0YXRpYyBtZW1vcnkgcmVnaW9ucyB3aGVuIHRo ZQ0KPiA+IGRldmljZSB0cmVlIGlzIHBhcnNlZCwgYW5kIHRoZW4gd2UgY2FuIGNoZWNrIGlmIHRo ZXkgYXJlIG92ZXJsYXBwZWQuDQo+IA0KPiBUaGlzIHNob3VsZCB3b3JrLg0KDQpBY2suDQoNCj4g DQo+ID4gT3Zlcg0KPiA+IHRoZSBsb25nIHRlcm0gKGFuZCB0aGlzIGxvbmcgdGVybSBvcHRpb24g aXMgY3VycmVudGx5IG5vdCBpbiBvdXIgcGxhbiksDQo+ID4gbWF5YmUgd2UgY2FuIGFkZCBzb21l dGhpbmcgaW4gdGhlIFhlbiB0b29sc3RhY2sgZm9yIHRoaXMgdXNhZ2U/DQo+IA0KPiBXaGVuIEkg cmVhZCAiWGVuIHRvb2xzdGFjayIsIEkgcmVhZCB0aGUgdG9vbHMgdGhhdCB3aWxsIHJ1biBpbiBk b20wLiBJcw0KPiBpdCB3aGF0IHlvdSBtZWFudD8NCg0KTm9ub25vLCBzb3JyeSBmb3IgdGhlIG1p c2xlYWRpbmcuIEkgbWVhbiBhIGJ1aWxkIHRpbWUgdG9vbCB0aGF0IGNhbiBydW4NCm9uIGhvc3Qg KGJ1aWxkIG1hY2hpbmUpIHRvIGdlbmVyYXRlL2NvbmZpZ3VyZSB0aGUgWGVuIERUUyBmb3Igc3Rh dGljDQphbGxvY2F0ZWQgbWVtb3J5LiBCdXQgbWF5YmUgdGhpcyB0b29sIGNhbiBiZSBwbGFjZWQg aW4gWGVuIHRvb2wgb3IgaXQgY2FuDQpiZSBhIHNlcGFyYXRlIHRvb2wgdGhhdCBvdXQgb2YgWGVu J3Mgc2NvcGUuDQoNCkFueXdheSwgdGhpcyBpcyBqdXN0IGFuIGlkZWEgYXMgd2UgZmluZCBpdCBp cyBub3QgZWFzeSBmb3IgdXNlcnMgdG8gY29uZmlndXJlDQpzbyBtYW55IHN0YXRpYyBpdGVtcyBt YW51YWxseS4NCg0KPiANCj4gPg0KPiA+IEFsc28sIEkgYW0gd29uZGVyaW5nIGlmIHRoZSBvdmVy bGFwcGluZyBjaGVjayBsb2dpYyBzaG91bGQgYmUgaW50cm9kdWNlZA0KPiA+IGluIHRoaXMgc2Vy aWVzLiBXRFlUPw0KPiANCj4gSSB3b3VsZCBkbyB0aGF0IGluIGEgc2VwYXJhdGUgc2VyaWVzLg0K DQpBY2suDQoNCktpbmQgcmVnYXJkcywNCg0KSGVucnkNCg0KPiANCj4gQ2hlZXJzLA0KPiANCj4g LS0NCj4gSnVsaWVuIEdyYWxsDQo= From xen-devel-bounces@lists.xenproject.org Tue Mar 01 02:23:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 02:23:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.280801.478859 (Exim 4.92) (envelope-from ) id 1nOsAy-0001FD-Gq; Tue, 01 Mar 2022 02:23:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 280801.478859; Tue, 01 Mar 2022 02:23:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOsAy-0001F6-Db; Tue, 01 Mar 2022 02:23:44 +0000 Received: by outflank-mailman (input) for mailman id 280801; Tue, 01 Mar 2022 02:23:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOsAw-0001F0-In for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 02:23:42 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-he1eur02on0624.outbound.protection.outlook.com [2a01:111:f400:fe05::624]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9b40ea7b-9906-11ec-8539-5f4723681683; Tue, 01 Mar 2022 03:23:40 +0100 (CET) Received: from AM6P194CA0007.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:90::20) by VE1PR08MB4943.eurprd08.prod.outlook.com (2603:10a6:803:115::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.25; Tue, 1 Mar 2022 02:23:36 +0000 Received: from AM5EUR03FT056.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:90:cafe::64) by AM6P194CA0007.outlook.office365.com (2603:10a6:209:90::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.23 via Frontend Transport; Tue, 1 Mar 2022 02:23:35 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT056.mail.protection.outlook.com (10.152.17.224) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22 via Frontend Transport; Tue, 1 Mar 2022 02:23:35 +0000 Received: ("Tessian outbound 31aeb3346a45:v113"); Tue, 01 Mar 2022 02:23:35 +0000 Received: from 5388833892eb.3 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 1F910AAE-1F4F-4469-B130-AC55B6892B8C.1; Tue, 01 Mar 2022 02:23:29 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 5388833892eb.3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 01 Mar 2022 02:23:29 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by AS8PR08MB6792.eurprd08.prod.outlook.com (2603:10a6:20b:39b::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Tue, 1 Mar 2022 02:23:27 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::89b3:80a2:2b58:f1aa]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::89b3:80a2:2b58:f1aa%4]) with mapi id 15.20.5017.026; Tue, 1 Mar 2022 02:23:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9b40ea7b-9906-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CTGQd/P50vO2uv8yJoK90CmmYZ3D80zXhuQbGwfKZBQ=; b=5ABs9MtgT0BiQH7piAaXijpw+6AUONrMapZjjPdbaIjWXUtIFmyYy5GVOtE9AiiBevEN7aLd+udzopk6x+CCcYdiNpDC4pqkdtt+Bdbb6WFvJXl9bfzIWPwTFQqLthi410v7ap9ym/lbNkEXYo6oCcxnUijib09FtGpsAr2bkzY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UzH4vME1n3ww2MMCtHNBK1VRy9mtoTjCekKk/6wVuu0GB9MAPdNiEqFALIVmT4TCPAMZkqsMb7PJjvKspad6jzq6r7U4lN/ZqwRvt+ekZk/Dr+bb9wF7huFWffQMWTnTHa3XjY84k0N9BzUScQ/xOtpuyhkhSXjNLYa7WmShrnhQgpSKAlv1Q1I8LQewbm8Nbp+yfpKziWL2tbkokIZGMX9+4QKqre48sbczWK39Z7GTJstb/l5JogQapWHteIOraT2X+wyKxHasJ0DoFjHfM8lWl9kEDE4VU00IwmXs4uY/XVWkAsxRrO725UxKA6jDo70UT6q9v27aKqQml/2UYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CTGQd/P50vO2uv8yJoK90CmmYZ3D80zXhuQbGwfKZBQ=; b=fLiUowsOaoBslgoTJNGNfJRNO/H8Ce1pneI6sKjcLPxyFMdz/OQzungzmX+ufdV3KhCZfAMPETYCCIzf+r5lwW3ajcUucE19E2QUCq+4gZd/X/mSIkss2yBMwKuaD4rhSwG/49hbwu8fAzqTU1sXHYJUZPhS81L+bgEY7taTFELV9NctKjjx+uBITO9ySFkbDa8pZIneCfh1XsOsPmm8htvW0CfQAiHwBAglVx6Pq0MrludGE+7oVI28w8eCnyeSjIotTIpVJbf0JyRRjfujDQXyGWzoAtVrBoYG5aF7+WbXAhB3hgGQNu4RgOeoD/umuZOet2h+oeawuREdUnJ9xQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CTGQd/P50vO2uv8yJoK90CmmYZ3D80zXhuQbGwfKZBQ=; b=5ABs9MtgT0BiQH7piAaXijpw+6AUONrMapZjjPdbaIjWXUtIFmyYy5GVOtE9AiiBevEN7aLd+udzopk6x+CCcYdiNpDC4pqkdtt+Bdbb6WFvJXl9bfzIWPwTFQqLthi410v7ap9ym/lbNkEXYo6oCcxnUijib09FtGpsAr2bkzY= From: Wei Chen To: Henry Wang , Julien Grall , "xen-devel@lists.xenproject.org" , "sstabellini@kernel.org" CC: Bertrand Marquis , Penny Zheng Subject: RE: [RFC PATCH 0/2] Introduce reserved Xenheap Thread-Topic: [RFC PATCH 0/2] Introduce reserved Xenheap Thread-Index: AQHYKR4hPwI7Daj3QEOqkq/IPeuzHKyktMKAgAPeNACAAMMegIAAeuAAgAABW5A= Date: Tue, 1 Mar 2022 02:23:27 +0000 Message-ID: References: <20220224013023.50920-1-Henry.Wang@arm.com> <6269ec3d-039e-d68f-771d-c5e088631410@xen.org> <48a0712c-eff8-dfc1-2136-59317f22321f@xen.org> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: CF11C91518773143A1341BB17D76728D.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 1e427ce8-6566-417e-5405-08d9fb2a7d0c x-ms-traffictypediagnostic: AS8PR08MB6792:EE_|AM5EUR03FT056:EE_|VE1PR08MB4943:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: et7x8vCIWWOGCbpNbQxcCTCMGVDrFy01rtTMrmUSoZAZCYYybEb5EQJhGaOvyqNgsATN+2JMd1uiwyBhVtoFTW0jGFp81E6N6kzW1fwvlsW+XoLw9kIzCpADNsK2ZnN3Izuz4kZ0U/yS4i13ZJFZtrdXXPeWozZoptIIUHvt6I/Y24D+7cPDZYCnhzt2o+EN/4A62t3+CPhuxhQFd2thqJlecQKuVUD6J7XmT34prGgIr10nFbhuUl80oelub/pY1iMCKsHwqgniHTSxxzK+yk3PZ+uqMfwpcA1FUIbe3Qagb9r4IWSDQeX3UMG8YjphILbNs+KwlwVXjz3Mjl2Lzevxoq9zam3GS+R3aYqCIuI5rtGwf0Y7oOUc3ihV5dIKoGOIt80M7yD+GKAoLgyBHR45NjPuvcnsuQr4hEEO21F5p/y7jOiXdSzxeBi3yqomIqP89fU44+jTezibnpfiFkZimCi1mrL/xGRD+qGWrDk8Ei7IXD0itxUreWqYGCfbzNyxD2xdpr/xY2Bcy+c9/LGpVVX9U6lxp7C8n9pC5z0B+sCbu+sX1Ee9Aj+V36zmzUDutRbm2JTv0FslFlh95muCSUCo6gYxQvNUeQb18yqS0LvmIjSBCo0VqPTif9MwTbKyYvTW7xPC1LruzbyH4Ez3yaaBOq6+ZzMR1LPyryMGxg/3F47S/Bp+pr8tLtR3POQ60JHxSwptAcfZBb8L+Q== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(71200400001)(52536014)(38100700002)(6506007)(53546011)(4326008)(9686003)(508600001)(83380400001)(55016003)(122000001)(54906003)(110136005)(7696005)(316002)(8936002)(86362001)(38070700005)(5660300002)(2906002)(33656002)(186003)(66476007)(66556008)(66946007)(64756008)(76116006)(66446008)(8676002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6792 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT056.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: bbe948fe-504e-4953-0b26-08d9fb2a7815 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nkSSU1XXcpLu26OnLYvL8ZhgXEDjnvxwjZxY4Hjno2pMeyQ0Nv1alkJOtPnoWytXiDOopjWzqngO7dTg+zteV4PXIGX1WgikqHEgiguz3GsecFrTyLf1r+4RHBZtu4+P2PGXxY6m5kW+cc3OtXpD5Cze8+rDdKqyP+V00Jinj1I8QkJFzbTFiCxR4yVl6QXA5BOuZ+Ej6gf71LkKtwU/0M9TJh5Naujrr6Y+WnTvAwcDFCDpWK0Q+F4adnfQ52/cwd+B9F30PZBn2GaLZiWii8W0xpnd+8OUhy7UNJipDkFSAavCrtouw2KngpWnxj6jFR5DZWNrlf/g3UB6VgYRUHHhzyNrXYNZkZako02tfT7DTJgMjDs+XhikBsg60HCW3nsfammDJIAHmtbGGSYMz6OHxJ+clqjI0HiWWKYOsRr5EpMXgdsvrZIWbjhth9aM/vaPcvJvEiLEW7+D8AzWI820ya33VYcAFe7bSJh4aUmfhsgwcj9wtTKPqO4xWelSWbmapR6SQQj8RmWPCsQK4kTqMuesjNnW2yiZd2Ma7KRmwqs6CHpXpR4JsCMAF1QFlRHSV7fGJ/4hp+Xt/99sK7Bo7rb8kjcrxMK52APLvUL3OFnhH08hXr8K5v6cjBgB4VXlErfcil8wO0M/2S+AgqvK7BY3mXl4kInrnzSqcDRbbFhRhhliheOc8Yyn4zRu X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(356005)(86362001)(5660300002)(9686003)(81166007)(53546011)(55016003)(6506007)(336012)(4326008)(7696005)(26005)(8936002)(40460700003)(2906002)(83380400001)(8676002)(110136005)(47076005)(52536014)(54906003)(70586007)(70206006)(316002)(82310400004)(33656002)(186003)(508600001)(36860700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2022 02:23:35.4012 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1e427ce8-6566-417e-5405-08d9fb2a7d0c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT056.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4943 SGkgSnVsaWVuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEhlbnJ5 IFdhbmcgPEhlbnJ5LldhbmdAYXJtLmNvbT4NCj4gU2VudDogMjAyMuW5tDPmnIgx5pelIDEwOjEx DQo+IFRvOiBKdWxpZW4gR3JhbGwgPGp1bGllbkB4ZW4ub3JnPjsgeGVuLWRldmVsQGxpc3RzLnhl bnByb2plY3Qub3JnOw0KPiBzc3RhYmVsbGluaUBrZXJuZWwub3JnDQo+IENjOiBCZXJ0cmFuZCBN YXJxdWlzIDxCZXJ0cmFuZC5NYXJxdWlzQGFybS5jb20+OyBXZWkgQ2hlbg0KPiA8V2VpLkNoZW5A YXJtLmNvbT47IFBlbm55IFpoZW5nIDxQZW5ueS5aaGVuZ0Bhcm0uY29tPg0KPiBTdWJqZWN0OiBS RTogW1JGQyBQQVRDSCAwLzJdIEludHJvZHVjZSByZXNlcnZlZCBYZW5oZWFwDQo+IA0KPiBIaSBK dWxpZW4sDQo+IA0KPiA+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+ID4gRnJvbTogSnVs aWVuIEdyYWxsIDxqdWxpZW5AeGVuLm9yZz4NCj4gPiBPbiAyOC8wMi8yMDIyIDA3OjEyLCBIZW5y eSBXYW5nIHdyb3RlOg0KPiA+ID4gSGkgSnVsaWVuLA0KPiA+DQo+ID4gSGkgSGVucnksDQo+ID4N Cj4gPiA+PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiA+ID4+IEZyb206IEp1bGllbiBH cmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+ID4gPj4gSGkgSGVucnksDQo+ID4gPj4NCj4gPiA+PiBP biAyNC8wMi8yMDIyIDAxOjMwLCBIZW5yeSBXYW5nIHdyb3RlOg0KPiA+ID4+PiBUaGUgcmVzZXJ2 ZWQgWGVuaGVhcCwgb3Igc3RhdGljYWxseSBjb25maWd1cmVkIFhlbmhlYXAsIHJlZmVycyB0bw0K PiBwYXJ0cw0KPiA+ID4+PiBvZiBSQU0gcmVzZXJ2ZWQgaW4gdGhlIGJlZ2lubmluZyBmb3IgWGVu aGVhcC4gTGlrZSB0aGUgc3RhdGljIG1lbW9yeQ0KPiA+ID4+PiBhbGxvY2F0aW9uLCBzdWNoIHJl c2VydmVkIFhlbmhlYXAgcmVnaW9ucyBhcmUgcmVzZXJ2ZWQgYnkNCj4gY29uZmlndXJhdGlvbg0K PiA+ID4+PiBpbiB0aGUgZGV2aWNlIHRyZWUgdXNpbmcgcGh5c2ljYWwgYWRkcmVzcyByYW5nZXMu DQo+ID4gPj4NCj4gPiA+PiBJbiBYZW4sIHdlIGhhdmUgdGhlIGNvbmNlcHQgb2YgZG9taGVhcCBh bmQgeGVuaGVhcC4gRm9yIEFybTY0IGFuZA0KPiA+IHg4Ng0KPiA+ID4+IHRoZXkgd291bGQgYmUg dGhlIHNhbWUuIEJ1dCBmb3IgQXJtMzIsIHRoZXkgd291bGQgYmUgZGlmZmVyZW50Og0KPiB4ZW5o ZWFwDQo+ID4gPj4gaXMgYWx3YXlzIG1hcHBlZCB3aGVyZWFzIGRvbWhlYXAgaXMgc2VwYXJhdGUu DQo+ID4gPj4NCj4gPiA+PiBTa2ltbWluZyB0aHJvdWdoIHRoZSBzZXJpZXMsIEkgdGhpbmsgeW91 IHdhbnQgdG8gdXNlIHRoZSByZWdpb24gZm9yDQo+IGJvdGgNCj4gPiA+PiBkb21oZWFwIGFuZCB4 ZW5oZWFwLiBJcyB0aGF0IGNvcnJlY3Q/DQo+ID4gPg0KPiA+ID4gWWVzIEkgdGhpbmsgdGhhdCB3 b3VsZCBiZSBjb3JyZWN0LCBmb3IgQXJtMzIsIGluc3RlYWQgb2YgdXNpbmcgdGhlDQo+IGZ1bGwN Cj4gPiA+IGByYW1fcGFnZXNgIGFzIHRoZSBpbml0aWFsIHZhbHVlIG9mIGBoZWFwX3BhZ2VzYCwg d2Ugd2FudCB0byB1c2UgdGhlDQo+ID4gPiByZWdpb24gc3BlY2lmaWVkIGluIHRoZSBkZXZpY2Ug dHJlZS4gQnV0IHdlIGFyZSBjb25mdXNlZCBpZiB0aGlzIGlzDQo+IHRoZQ0KPiA+ID4gY29ycmVj dCAob3IgcHJlZmVycmVkKSB3YXkgZm9yIEFybTMyLCBzbyBpbiB0aGlzIHNlcmllcyB3ZSBvbmx5 DQo+ID4gPiBpbXBsZW1lbnRlZCB0aGUgcmVzZXJ2ZWQgaGVhcCBmb3IgQXJtNjQuDQo+ID4NCj4g PiBUaGF0J3MgYW4gaW50ZXJlc3RpbmcgcG9pbnQuIFdoZW4gSSBza2ltbWVkIHRocm91Z2ggdGhl IHNlcmllcyBvbg0KPiA+IEZyaWRheSwgbXkgZmlyc3QgdGhvdWdodCB3YXMgdGhhdCBmb3IgYXJt MzIgaXQgd291bGQgYmUgb25seSB4ZW5oZWFwIChzbw0KPiA+IGFsbCB0aGUgcmVzdCBvZiBtZW1v cnkgaXMgZG9taGVhcCkuDQo+ID4NCj4gPiBIb3dldmVyLCBYZW4gY2FuIGFsbG9jYXRlIG1lbW9y eSBmcm9tIGRvbWhlYXAgZm9yIGl0cyBvd24gcHVycG9zZSAoZS5nLg0KPiA+IHdlIGRvbid0IG5l ZWQgY29udGlndW91cyBtZW1vcnksIG9yIGZvciBwYWdlLXRhYmxlcykuDQo+ID4NCj4gPiBJbiBh IGZ1bGx5IHN0YXRpYyBlbnZpcm9ubWVudCwgdGhlIGRvbWhlYXAgYW5kIHhlbmhlYXAgYXJlIGJv dGggZ29pbmcgdG8NCj4gPiBiZSBxdWl0ZSBzbWFsbC4gSXQgd291bGQgYWxzbyBiZSBzb21ld2hh dCBkaWZmaWN1bHQgZm9yIGEgdXNlciB0byBzaXplDQo+ID4gaXQuIFNvIEkgdGhpbmssIGl0IHdv dWxkIGJlIGVhc2llciB0byB1c2UgdGhlIHJlZ2lvbiB5b3UgaW50cm9kdWNlIGZvcg0KPiA+IGJv dGggZG9taGVhcCBhbmQgeGVuaGVhcC4NCj4gPg0KPiA+IFN0ZWZhbm8sIEJlcnRyYW5kLCBhbnkg b3Bpb25pb25zPw0KPiA+DQo+ID4gT24gYSBzZXBhcmF0ZSB0b3BpYywgSSB0aGluayB3ZSBuZWVk IHNvbWUgZG9jdW1lbnRhdGlvbiBleHBsYWluaW5nIGhvdyBhDQo+ID4gdXNlciBjYW4gc2l6ZSB0 aGUgeGVuaGVhcC4gSG93IGRpZCB5b3UgZmlndXJlIG91dCBmb3IgeW91ciBzZXR1cD8NCj4gDQo+ IE5vdCBzdXJlIGlmIEkgZnVsbHkgdW5kZXJzdGFuZCB0aGUgcXVlc3Rpb24uIEkgd2lsbCBleHBs YWluIGluIHR3byBwYXJ0czoNCj4gSSB0ZXN0ZWQNCj4gdGhpcyBzZXJpZXMgb24gYSBkb20wbGVz cyAoc3RhdGljIG1lbSkgc3lzdGVtIG9uIEZWUF9CYXNlLg0KPiAoMSkgRm9yIGNvbmZpZ3VyaW5n IHRoZSBzeXN0ZW0sIEkgZm9sbG93ZWQgdGhlIGRvY3VtZW50YXRpb24gSSBhZGRlZCBpbg0KPiB0 aGUNCj4gZmlyc3QgcGF0Y2ggaW4gdGhpcyBzZXJpZXMgKGRvY3MvbWlzYy9hcm0vZGV2aWNlLXRy ZWUvYm9vdGluZy50eHQpLiBUaGUNCj4gaWRlYSBpcw0KPiBhZGRpbmcgc29tZSBzdGF0aWMgbWVt IHJlZ2lvbnMgdW5kZXIgdGhlIGNob3NlbiBub2RlLg0KPiANCj4gICAgICBjaG9zZW4gew0KPiAr ICAgICAgICAjeGVuLHN0YXRpYy1tZW0tYWRkcmVzcy1jZWxscyA9IDwweDI+Ow0KPiArICAgICAg ICAjeGVuLHN0YXRpYy1tZW0tc2l6ZS1jZWxscyA9IDwweDI+Ow0KPiArICAgICAgICB4ZW4sc3Rh dGljLW1lbSA9IDwweDggMHg4MDAwMDAwMCAweDAgMHgwMDEwMDAwMCAweDggMHg5MDAwMDAwMA0K PiAweDAgMHgwODAwMDAwMD47DQo+ICAgICAgWy4uLl0NCj4gICAgICB9DQo+IA0KPiAoMikgRm9y IHZlcmlmeWluZyB0aGlzIHNlcmllcywgd2hhdCBJIGRpZCB3YXMgYmFzaWNhbGx5IHBsYXlpbmcg d2l0aCB0aGUNCj4gcmVnaW9uIHNpemUNCj4gYW5kIG51bWJlciBvZiB0aGUgcmVnaW9ucywgYWRk aW5nIHByaW50a3MgYW5kIGFsc28gc2VlIGlmIHRoZSBndWVzdHMgY2FuDQo+IGJvb3QNCj4gYXMg ZXhwZWN0ZWQgd2hlbiBJIGNoYW5nZSB0aGUgeGVuaGVhcCBzaXplLg0KPiANCj4gPg0KPiA+ID4+ DQo+ID4gPj4gRnVydGhlbW9yZSwgbm93IHRoYXQgd2UgYXJlIGludHJvZHVjaW5nIG1vcmUgc3Rh dGljIHJlZ2lvbiwgaXQgd2lsbA0KPiBnZXQNCj4gPiA+PiBlYXNpZXIgdG8gb3ZlcmxhcCB0aGUg cmVnaW9ucyBieSBtaXN0YWtlcy4gSSB0aGluayB3ZSB3YW50IHRvIGhhdmUNCj4gc29tZQ0KPiA+ ID4+IGxvZ2ljIGluIFhlbiAob3Igb3V0c2lkZSkgdG8gZW5zdXJlIHRoYXQgbm9uZSBvZiB0aGVt IG92ZXJsYXBzLiBEbw0KPiB5b3UNCj4gPiA+PiBoYXZlIGFueSBwbGFuIGZvciB0aGF0Pw0KPiA+ ID4NCj4gPiA+IFRvdGFsbHkgYWdyZWUgd2l0aCB0aGlzIGlkZWEsIGJ1dCBiZWZvcmUgd2UgYWN0 dWFsbHkgaW1wbGVtZW50IHRoZQ0KPiBjb2RlLA0KPiA+ID4gd2Ugd291bGQgbGlrZSB0byBmaXJz dGx5IHNoYXJlIG91ciB0aG91Z2h0cyBvbiB0aGlzOiBPbmUgb3B0aW9uIGNvdWxkDQo+IGJlIHRv DQo+ID4gPiBhZGQgZGF0YSBzdHJ1Y3R1cmVzIHRvIG5vdGVzIGRvd24gdGhlc2Ugc3RhdGljIG1l bW9yeSByZWdpb25zIHdoZW4gdGhlDQo+ID4gPiBkZXZpY2UgdHJlZSBpcyBwYXJzZWQsIGFuZCB0 aGVuIHdlIGNhbiBjaGVjayBpZiB0aGV5IGFyZSBvdmVybGFwcGVkLg0KPiA+DQo+ID4gVGhpcyBz aG91bGQgd29yay4NCj4gDQo+IEFjay4NCj4gDQo+ID4NCj4gPiA+IE92ZXINCj4gPiA+IHRoZSBs b25nIHRlcm0gKGFuZCB0aGlzIGxvbmcgdGVybSBvcHRpb24gaXMgY3VycmVudGx5IG5vdCBpbiBv dXIgcGxhbiksDQo+ID4gPiBtYXliZSB3ZSBjYW4gYWRkIHNvbWV0aGluZyBpbiB0aGUgWGVuIHRv b2xzdGFjayBmb3IgdGhpcyB1c2FnZT8NCj4gPg0KPiA+IFdoZW4gSSByZWFkICJYZW4gdG9vbHN0 YWNrIiwgSSByZWFkIHRoZSB0b29scyB0aGF0IHdpbGwgcnVuIGluIGRvbTAuIElzDQo+ID4gaXQg d2hhdCB5b3UgbWVhbnQ/DQo+IA0KPiBOb25vbm8sIHNvcnJ5IGZvciB0aGUgbWlzbGVhZGluZy4g SSBtZWFuIGEgYnVpbGQgdGltZSB0b29sIHRoYXQgY2FuIHJ1bg0KPiBvbiBob3N0IChidWlsZCBt YWNoaW5lKSB0byBnZW5lcmF0ZS9jb25maWd1cmUgdGhlIFhlbiBEVFMgZm9yIHN0YXRpYw0KPiBh bGxvY2F0ZWQgbWVtb3J5LiBCdXQgbWF5YmUgdGhpcyB0b29sIGNhbiBiZSBwbGFjZWQgaW4gWGVu IHRvb2wgb3IgaXQgY2FuDQo+IGJlIGEgc2VwYXJhdGUgdG9vbCB0aGF0IG91dCBvZiBYZW4ncyBz Y29wZS4NCj4gDQo+IEFueXdheSwgdGhpcyBpcyBqdXN0IGFuIGlkZWEgYXMgd2UgZmluZCBpdCBp cyBub3QgZWFzeSBmb3IgdXNlcnMgdG8NCj4gY29uZmlndXJlDQo+IHNvIG1hbnkgc3RhdGljIGl0 ZW1zIG1hbnVhbGx5Lg0KDQpOb3Qgb25seSBmb3IgdGhpcyBvbmUuIEFzIHY4UjY0IHN1cHBvcnQg Y29kZSBhbHNvIGluY2x1ZGVzIGxvdHMgb2Ygc3RhdGljDQphbGxvY2F0ZWQgaXRlbXMsIGl0IHdp bGwgYWxzbyBlbmNvdW50ZXIgdGhpcyB1c2VyIGNvbmZpZ3VyYXRpb24gaXNzdWUuDQpTbyB0aGlz IHdvdWxkIGJlIGEgbG9uZyB0ZXJtIGNvbnNpZGVyYXRpb24uIFdlIGNhbiBkaXNjdXNzIHRoaXMg dG9waWMNCmFmdGVyIFhlbiBWOFI2NCBzdXBwb3J0IGNvZGUgdXBzdHJlYW0gd29yayBiZSBkb25l Lg0KDQpBbmQgdGhpcyB0b29sIGRvZXMgbm90IG5lY2Vzc2FyaWx5IG5lZWQgdG8gYmUgcHJvdmlk ZWQgYnkgdGhlIGNvbW11bml0eS4NClZlbmRvcnMgdGhhdCB3YW50IHRvIHVzZSBYZW4gYWxzbyBj YW4gZG8gaXQuIElNTywgaXQgd291bGQgYmUgYmV0dGVyIGlmDQpjb21tdW5pdHkgY291bGQgcHJv dmlkZSBpdC4gQW55d2F5IGxldCdzIGRlZmVyIHRoaXMgdG9waWMgOiApIA0KDQpUaGFua3MsDQpX ZWkgQ2hlbg0KDQo+IA0KPiA+DQo+ID4gPg0KPiA+ID4gQWxzbywgSSBhbSB3b25kZXJpbmcgaWYg dGhlIG92ZXJsYXBwaW5nIGNoZWNrIGxvZ2ljIHNob3VsZCBiZQ0KPiBpbnRyb2R1Y2VkDQo+ID4g PiBpbiB0aGlzIHNlcmllcy4gV0RZVD8NCj4gPg0KPiA+IEkgd291bGQgZG8gdGhhdCBpbiBhIHNl cGFyYXRlIHNlcmllcy4NCj4gDQo+IEFjay4NCj4gDQo+IEtpbmQgcmVnYXJkcywNCj4gDQo+IEhl bnJ5DQo+IA0KPiA+DQo+ID4gQ2hlZXJzLA0KPiA+DQo+ID4gLS0NCj4gPiBKdWxpZW4gR3JhbGwN Cg0K From xen-devel-bounces@lists.xenproject.org Tue Mar 01 03:40:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 03:40:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.280808.478870 (Exim 4.92) (envelope-from ) id 1nOtMq-0000lz-47; Tue, 01 Mar 2022 03:40:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 280808.478870; Tue, 01 Mar 2022 03:40:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOtMp-0000ls-VW; Tue, 01 Mar 2022 03:40:03 +0000 Received: by outflank-mailman (input) for mailman id 280808; Tue, 01 Mar 2022 03:40:02 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOtMo-0000WN-E4; Tue, 01 Mar 2022 03:40:02 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOtMo-0003dv-Az; Tue, 01 Mar 2022 03:40:02 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOtMn-00065l-Ne; Tue, 01 Mar 2022 03:40:01 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nOtMn-0005Zk-Mw; Tue, 01 Mar 2022 03:40:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ysQq6W+ZO60PKvPrsbEBQQ30CRqdu/wzHNptwTwsfIk=; b=O46T5VoevAAq+B50rRVINr0ydG EBL+QtRV9ygGE8qZPLawZrbMAnooAsodVeMa2gyDExKlIj3QL0k5/NQZ/r98YdrrDMxja/5rMKkV4 yfc7HMD8H4+IwOazEgPemXZEIEBMFfQip2MVrkNiIesBZs5NhkK5h9Xpx3+PKJLpl/iY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 168258: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=6a890db161cd6d378bec3499a1e774db3f5a27a7 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 01 Mar 2022 03:40:01 +0000 flight 168258 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/168258/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 6a890db161cd6d378bec3499a1e774db3f5a27a7 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 0 days Testing same since 168258 2022-03-01 01:55:31 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jason Jason Lou jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 6a890db161cd6d378bec3499a1e774db3f5a27a7 Author: Jason Date: Mon Jan 10 22:30:29 2022 +0800 BaseTools: Upgrade the version of NASM tool REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Upgrade the version of NASM tool to avoid compilation errors when compiling NASM code change. Signed-off-by: Jason Lou Cc: Bob Feng Cc: Liming Gao Reviewed-by: Yuwei Chen commit bbaa00dd01ed0df30e43a5a89fd2b0433d858b73 Author: Jason Date: Mon Jan 10 22:05:47 2022 +0800 MdePkg: Remove the macro definitions regarding Opcode. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Remove the macro definitions regarding Opcode because new version of NASM tool(e.g. v2.15.05) supports the corresponding instructions. Note: This patch need to be merged after other NASM code change to avoid compilation errors. Signed-off-by: Jason Lou Cc: Michael D Kinney Reviewed-by: Liming Gao Cc: Zhiguang Liu commit 2aa107c0aa2e1375651867c8df1b81ff64b67fce Author: Jason Date: Mon Jan 10 22:01:18 2022 +0800 UefiCpuPkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Reviewed-by: Ray Ni Cc: Eric Dong Cc: Laszlo Ersek Cc: Rahul Kumar commit 7bc8b1d9f412507d579f21ea9af56fced81e7827 Author: Jason Date: Mon Jan 10 21:52:52 2022 +0800 SourceLevelDebugPkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Reviewed-by: Hao A Wu commit d3febfd9ade35dc552df6b3607c2b15d26b82867 Author: Jason Date: Mon Jan 10 21:46:27 2022 +0800 MdePkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Cc: Michael D Kinney Reviewed-by: Liming Gao Cc: Zhiguang Liu commit 84338c0d498555f860a480693ee8647a1795fba3 Author: Jason Date: Mon Jan 10 21:04:09 2022 +0800 MdeModulePkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Reviewed-by: Ray Ni Cc: Dandan Bi Reviewed-by: Liming Gao From xen-devel-bounces@lists.xenproject.org Tue Mar 01 04:57:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 04:57:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.280824.478896 (Exim 4.92) (envelope-from ) id 1nOuZJ-0000WV-1M; Tue, 01 Mar 2022 04:57:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 280824.478896; Tue, 01 Mar 2022 04:57:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOuZI-0000WO-Ud; Tue, 01 Mar 2022 04:57:00 +0000 Received: by outflank-mailman (input) for mailman id 280824; Tue, 01 Mar 2022 04:57:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOuZH-0000W2-7D for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 04:57:00 +0000 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 03eb090a-991c-11ec-8539-5f4723681683; Tue, 01 Mar 2022 05:56:55 +0100 (CET) Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 2213QXoj024489; Tue, 1 Mar 2022 04:56:35 GMT Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by mx0b-00069f02.pphosted.com with ESMTP id 3ehbk983tc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 01 Mar 2022 04:56:35 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 2214u05q089896; Tue, 1 Mar 2022 04:56:34 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2168.outbound.protection.outlook.com [104.47.55.168]) by userp3030.oracle.com with ESMTP id 3ef9awgufy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 01 Mar 2022 04:56:34 +0000 Received: from BYAPR10MB2663.namprd10.prod.outlook.com (2603:10b6:a02:a9::20) by BN6PR10MB1330.namprd10.prod.outlook.com (2603:10b6:404:43::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Tue, 1 Mar 2022 04:56:31 +0000 Received: from BYAPR10MB2663.namprd10.prod.outlook.com ([fe80::a0d5:610d:bcf:9b47]) by BYAPR10MB2663.namprd10.prod.outlook.com ([fe80::a0d5:610d:bcf:9b47%4]) with mapi id 15.20.5017.027; Tue, 1 Mar 2022 04:56:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 03eb090a-991c-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : from : to : cc : references : message-id : date : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=LJao+ms5p15QT1W5aB9NeYZncCwkzWmTSSzyACuGHiI=; b=PbuXiGoZz8h1l3byel+CBWGfpLUPztic5h1Ib3lR5Wj+XDhXuBsLMgCVepj1aKKBxIHS NINGzlbXXPZ2kEljo4B4QW/CABfxwfYlTa0IlfgiWkbd8KXBPY85vQmcMMwm4jd3k98n XtuBKYpdWfvooHYxixPyCI+2Us7bQXFuH0J4KYHLVM0m+Xgcl2RHCMRt1aOqsS1tl2JV uVogqCQ3DvJq8M9YsWGW7sFC8IEpD23eI7uSQa+TW8KrQQtGd9GUkn228SBxqQ0AUX2N 9LDb6OzkN7X4BPqVLikMwDEI1EdUznUrhXVBFUK37Vn5Fosz0MglDeP1gINj6ukR80XL +w== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KRAzGOL40RX5LFXlESdGAPECtSZEJlvKqEPq4lsHkHDuLAEWCUD/JHNlojquJaEJdNpunIj01Jf4dy+hgNuHDi9fTZs/4CRFQIBgbvZRcY8bAaGkbIGtTE46KyvDqFQOXTCOCYYKQiwgXAZfhteZDxPw3gaT/V6yyQVIQgJUqBxtuHTZZmkF3Wpu4OtMKM9Sv26CoyZ3BCrKItu+Z3qOOl+RBUEjR7V/3PlH0QMhC2DEYkeTeU6aSUDQ/fhiHA18RhY2WJn/a6XW2tVGxqka+4OWwipEaEIDF9qxgpLjple4wCpcBjvgGUvuWNDsObpvyM8A5+zBkUOsRnIeRLLbGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LJao+ms5p15QT1W5aB9NeYZncCwkzWmTSSzyACuGHiI=; b=gUMUYIdZt/WdCjZArcvPOlc0yZsEF6rGo2JYfKf7GDmfPEfKsXdfKOjzz2otQk18l61nG0+RQMCqPozJ4jQ8f2angoA3BWQMxF7HGJd/dxqxRXCmOwGEyw9hlx0FmG4AVSVEuN7dpQ4BaxGnKejhyJpP9FkLdO1wvnwJBQNFAkVYngXJ2eLoN0puOdF9xDgN8Bp/TpY+QhQ4EE6pxCyIluKwtO7y7949ZfKcrl/7xrNI2keGZo5qHJJE9smMmOiFjld5AJJdK71SoMfl0kMqs5kmu8h2e/jaA0Y7KBZwbo4kilsHiNQSg8XOFPmtO7JLrpRbEx9LS0mEzqBlkZs+bQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LJao+ms5p15QT1W5aB9NeYZncCwkzWmTSSzyACuGHiI=; b=RPn3rG3xw88Y2YBO5uUg9GcnrYYNNFkGHLfVB/Dluw+avIwX1zcfu3PxicM5gjKZi0uwa7TURxrYyc8DNFaMkJTJTWoWWob6FOsnt0cGXkkkx5i5GnD1Rrbbz67krKswikDUSfvD1395pbWtCI21ywIOo/EO07NFFXVAA9wVcA8= Subject: Re: [PATCH v3 0/1] xen: fix HVM kexec kernel panic From: Dongli Zhang To: Boris Ostrovsky Cc: linux-kernel@vger.kernel.org, jgross@suse.com, sstabellini@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, joe.jin@oracle.com, xen-devel@lists.xenproject.org, x86@kernel.org References: <20220224215049.2845-1-dongli.zhang@oracle.com> <9de1059b-6b48-e2c8-60bc-f29b42b217f7@oracle.com> <36014dbd-e63c-cf49-dafd-2d7a8b84db5d@oracle.com> <8e3e4716-22e7-8684-394c-b5a457906975@oracle.com> Message-ID: <1a5a683d-17c8-9730-d2f5-745262430569@oracle.com> Date: Mon, 28 Feb 2022 20:56:26 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SN6PR05CA0006.namprd05.prod.outlook.com (2603:10b6:805:de::19) To BYAPR10MB2663.namprd10.prod.outlook.com (2603:10b6:a02:a9::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b2b3718f-4061-48f6-351c-08d9fb3fda2e X-MS-TrafficTypeDiagnostic: BN6PR10MB1330:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: reT2WMd8lIHmfGqISUnN8+VkDfxRI99BkO7ah4Cn8tcR04AqUDKpY/6XirloKVPFrRSXpPts8SwK9iYOu8EeB3A1gEdfeCOLgcNVytrKLl5u5mrPVOgtXKteoVv2uNbWMwVi2qTktUHc4SrLW4h/dBBA9nFt5gLldeGXfJbVqfUFTU1k+tDP335otuOloO/fqF5T1uguV1gALFBs+XWBGTyPlm03AyORzum3+cu7K6+FjNPyNWZZfCvJEi8qFyXgLbmd0aerKII/Of4pjMYN7yZWMfkrR+Vr0aIlSz+zXJht51vjEmEb8954TeCF3NQ0tkmvEprm9xFOAxyFQr2xIAWJbfZK9I5sFmCufw/nEBdqEifo6DcBSpIj5Er75diF/z9o/bqT1sWgBUMT3eIrXjwPFpt7jyGstaxrhL/Z517eiRQUOAORPgBWrIqyy8QFqJuknSqWGVdVplJg0p6mlXP2SSg7THEX5a5cVQj9D6NE0l7elu03NQnJy5qwrQhNmr2ZVB2k+B7h8JDH87x5gpgu5VFryoBGh574IkJHoF2iDbzyYFpdXceewThyqxjQEHIYdNX9FrFBxibS7FZb/f5kWzm3pPNvI2sc45VOF2K6iTotIvoIAkLNnXblFqgr5dzoL2/Rv4pMrBh67+T8EAP6YEpjPC6xe6XX1Ldr0qNDXGjRp9d0yOp2vxqokMa6ZlCLMBGU8ujdbspeywXdM2+M8u4ePlgwpcA4BJeB2qM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB2663.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66476007)(5660300002)(4326008)(2906002)(6862004)(2616005)(66946007)(66556008)(8676002)(8936002)(44832011)(31696002)(7416002)(86362001)(36756003)(31686004)(38100700002)(316002)(186003)(83380400001)(6486002)(508600001)(37006003)(6636002)(53546011)(6506007)(6512007)(6666004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c2ZGUWplNUd6ZjBmM2VIb1JXb1NXVGNVSUwySG9ZTGdYc2l5MUZCVG5TWk9w?= =?utf-8?B?STA2Vm9tcFppK0N3d2Nud05xZ1dkbnhhTXZmQThOOWE2ckZjSFcyV2Qrc09Q?= =?utf-8?B?MEhYRDFYWmFxYmZNM3piNnVMK2ROL3lTWXlVMjZ0Wm9pTGRRSldIOXFQQ29v?= =?utf-8?B?L1hyMHZPcmg1SXJBaUtPTXJuRW5QcHc0TjFoZnNsV0swR2RWbVA2QlhPNXF0?= =?utf-8?B?Z29GeEpXRnhIY2ZOVG1zOE9Ecm1UUkp3TXgvTEQvdzBEWS95SDIxWmg4UTBk?= =?utf-8?B?Y3RKa0xBTGY4UzlTanZSV09uc1hDOUtkRisrTC9FL3psOFFkdi8rbW03OGNX?= =?utf-8?B?OG1JeVNiQytabDJNTGM2MjdFWGhFY25MZlFUSmZpbVRmdXZQRjRyYmF3NWJL?= =?utf-8?B?VG5LeDJ2cFV4WkhsaDdnd1V1RHg5eDdqRnV0S1lJVzNaNlJVeTNpelFtTERY?= =?utf-8?B?QlZLZHBlWFF1ekh4Q1pwR1Ixb0xlYS9YQ2JZcXVXU0pRZVUwWTBQV1hNSlZ1?= =?utf-8?B?UmFDRlRZR09BMUtyWUdkUk03OGVLRC9UODVJUXZOb2FhKzlwRFdwOHV0MkVE?= =?utf-8?B?a1VURWc2R1RWWjFhSTJQV1JyY2N4YXNzcGc0b3Q0RGJPZkFVVStiMXpRakNR?= =?utf-8?B?cXVySzU4QlBIU1crbmhaUGFmOVNVbVFlS3ByUEtEUlhZVGtGak1nRHZFK3Ra?= =?utf-8?B?UTVUM3pPZGFmOXp2YXBkNC9XWjRIaUkwRUZmUnhzYWlDb3FxSjErdjJSOVpp?= =?utf-8?B?aW45ZDZrNW90Y3U1c1ZoYzJWcVkyNkM5eUNkYnJKWDN6aVpMOXFqTk9tTjh3?= =?utf-8?B?NHJvcXEzU09JVkhURVdpMWoyekdGMmt2cXZ3MVhZNXZHNFI0OTMrUHVLeURE?= =?utf-8?B?Um1FUC9BTlJQQStOVWxLRDR2SkRRU2hpNU5FaGhkODhsaEpRZFhudndtUEhJ?= =?utf-8?B?dUF5aFZzYjNXYzMxMkpBYVFJWXlGbHg0YS8yci9OSkcvZk1YbVZvemtyRHE0?= =?utf-8?B?eUk2VkR6cC9XNjNXLzJaaGphMWQzT0RGUXZTYk1xVm0wSDIwemNZTlB6TlRl?= =?utf-8?B?LzNpREhTVkw1a0JsRGc1U1FIMUJyZVYwZWlxc2pkdk56UFJETEFOcmN6bVdu?= =?utf-8?B?RzhnT3JGNHl1VDd2WTcwOVdTRElIQ1FSd3pzVWo5ZWc3Uzk1Zi95bVZFdFNx?= =?utf-8?B?Zlo1T0JpSmNSZ2lnVWYwcDFUMVFOREpuV2RkdGVTeGFlYXVtTjlxcFBTQlo5?= =?utf-8?B?bUxUa0RsYk8xZVVuRE0rZFFqcm82dmZUYjVvMnUwWVRVSjJ4d1pkYlI4RTlo?= =?utf-8?B?WkFxUG5LTVhYNUxrVGgzSi9kOW9Zc3Z1WGFqWVZwZmNNcXBoVHlTdEF3NUp4?= =?utf-8?B?R0JpV3NqQnBVK2tvUEY0VkxlbWVtTHZyd3Y4WjYwazloZVh6dmVZdnB3NElo?= =?utf-8?B?MGhhbEM5QVNKNzBxdU1NSlRPZS9lVmNkaGRVeFM5SStFOUZKZDJISWUvaCtF?= =?utf-8?B?OFQwNzhjSzVnb29ZNExoRnFRS3FPallVQkFIWGphVEY1STVlU2g2aE9HSXpV?= =?utf-8?B?Z2JEUENYTXE0cTVmbElOai91TzRpV3gxNGV1bEFnTTNRbmZ3RFYzdXhOYkJD?= =?utf-8?B?L0JUWGM5cmVzZ3FCbDhlVFh6SlVwVHpyN1lMeVFJa1FHYzlwdHF0T2ZPVU9R?= =?utf-8?B?M3VKUkVwcEdEUFkvbTZDaFVIZmZVSjVidkxPWFNUWXMvelpYcUxFVytCVFVZ?= =?utf-8?B?OHBUTUtIcUtETnFDci9iWG1JUytKbkZjWWQ4em9LRlJEWnhDTzMzOGxnNkk5?= =?utf-8?B?OEtZMmxuV1dRVTAxOHpjVVlHVHJudTRXUmZRdzRQUmhjcnJLQnJUUUNQU2gv?= =?utf-8?B?R3I4cytMUXREbzlUNVp6bDIvZGdMT0xxSGxYL3ZKZFlPd0dQUFo4aEp6UUNB?= =?utf-8?B?eFl4ZTN1UHMxQ0R5Mnh0Unh3T2RFNmZsS0QzbEF2N1ZQR2RQMyt3U1MzRUNn?= =?utf-8?B?dTA1aTB0azkyTHB6Sk8xcTlaQ3U0TnNiZXN6QzdNVHl0NEl2ZjlGejJhc2Vt?= =?utf-8?B?NnZDYVVRKzA2dFRXZTRHTFdINlp6aVJubTMrMFE5NzgrWndzSVFNQlp0YnYz?= =?utf-8?B?S0Q0Snk1bG1aK01Jb0o1RHE4VFJCZWRWZXVRZjN6YXppUTVXZnJTZVptN1Va?= =?utf-8?Q?HTU38d7Sy7ye60KVUzVMQn3ZClOroy8mkY1yJWke0Qqc?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: b2b3718f-4061-48f6-351c-08d9fb3fda2e X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2663.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2022 04:56:31.4577 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SLixfZwBD75iN3cQKSuFDxkz1JO0Jz4EmgtE4Ezbo3yREhDVG9xWz8fAZAanNoKSwXbTJneJVFIf6mZ2JXaajw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR10MB1330 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10272 signatures=684655 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 malwarescore=0 mlxscore=0 phishscore=0 suspectscore=0 adultscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000 definitions=main-2203010022 X-Proofpoint-GUID: atJlFL40Xc3s-F2DQCPngG5HZCqmuX1l X-Proofpoint-ORIG-GUID: atJlFL40Xc3s-F2DQCPngG5HZCqmuX1l Hi Boris, On 2/28/22 5:18 PM, Dongli Zhang wrote: > Hi Boris, > > On 2/28/22 12:45 PM, Boris Ostrovsky wrote: >> >> >> On 2/25/22 8:17 PM, Dongli Zhang wrote: >>> Hi Boris, >>> >>> On 2/25/22 2:39 PM, Boris Ostrovsky wrote: >>>> >>>> On 2/24/22 4:50 PM, Dongli Zhang wrote: >>>>> This is the v3 of the patch to fix xen kexec kernel panic issue when the >>>>> kexec is triggered on VCPU >= 32. >>>>> >>>>> PANIC: early exception 0x0e IP 10:ffffffffa96679b6 error 0 cr2 0x20 >>>>> [    0.000000] CPU: 0 PID: 0 Comm: swapper Not tainted >>>>> 5.17.0-rc4xen-00054-gf71077a4d84b-dirty #1 >>>>> [    0.000000] Hardware name: Xen HVM domU, BIOS 4.4.4OVM 12/15/2020 >>>>> [    0.000000] RIP: 0010:pvclock_clocksource_read+0x6/0xb0 >>>>> ... ... >>>>> [    0.000000] RSP: 0000:ffffffffaae03e10 EFLAGS: 00010082 ORIG_RAX: >>>>> 0000000000000000 >>>>> [    0.000000] RAX: 0000000000000000 RBX: 0000000000010000 RCX: >>>>> 0000000000000002 >>>>> [    0.000000] RDX: 0000000000000003 RSI: ffffffffaac37515 RDI: >>>>> 0000000000000020 >>>>> [    0.000000] RBP: 0000000000011000 R08: 0000000000000000 R09: >>>>> 0000000000000001 >>>>> [    0.000000] R10: ffffffffaae03df8 R11: ffffffffaae03c68 R12: >>>>> 0000000040000004 >>>>> [    0.000000] R13: ffffffffaae03e50 R14: 0000000000000000 R15: >>>>> 0000000000000000 >>>>> [    0.000000] FS:  0000000000000000(0000) GS:ffffffffab588000(0000) >>>>> knlGS:0000000000000000 >>>>> [    0.000000] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033 >>>>> [    0.000000] CR2: 0000000000000020 CR3: 00000000ea410000 CR4: >>>>> 00000000000406a0 >>>>> [    0.000000] DR0: 0000000000000000 DR1: 0000000000000000 DR2: >>>>> 0000000000000000 >>>>> [    0.000000] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: >>>>> 0000000000000400 >>>>> [    0.000000] Call Trace: >>>>> [    0.000000]  >>>>> [    0.000000]  ? xen_clocksource_read+0x24/0x40 >>>> >>>> >>>> This is done to set xen_sched_clock_offset which I think will not be used for a >>>> while, until sched_clock is called (and the other two uses are for >>>> suspend/resume) >>>> >>>> >>>> Can we simply defer 'xen_sched_clock_offset = xen_clocksource_read();' until >>>> after all vcpu areas are properly set? Or are there other uses of >>>> xen_clocksource_read() before ? >>>> >>> >>> I have tested that below patch will panic kdump kernel. >>> >> >> >> >> Oh well, so much for that then. Yes, sched_clock() is at least called from >> printk path. >> >> >> I guess we will have to go with v2 then, we don't want to start seeing time >> going back, even if only with older hypervisors. The only thing I might ask is >> that you roll the logic inside xen_hvm_init_time_ops(). Something like >> >> >> xen_hvm_init_time_ops() >> { >>     /* >>      * Wait until per_cpu(xen_vcpu, 0) is initialized which may happen >>      * later (e.g. when kdump kernel runs on >=MAX_VIRT_CPUS vcpu) >>      */ >>     if (__this_cpu_read(xen_vcpu_nr(0)) == NULL) >>         return; >> > > I think you meant __this_cpu_read(xen_vcpu). > > I will call xen_hvm_init_time_ops() at both places, and move the logic into > xen_hvm_init_time_ops(). > > Thank you very much! > > Dongli Zhang > How about we do not move the logic into xen_hvm_init_time_ops()? Suppose we move the logic into xen_hvm_init_time_ops() line 573, the line line 570 might be printed twice. 559 void __init xen_hvm_init_time_ops(void) 560 { 561 /* 562 * vector callback is needed otherwise we cannot receive interrupts 563 * on cpu > 0 and at this point we don't know how many cpus are 564 * available. 565 */ 566 if (!xen_have_vector_callback) 567 return; 568 569 if (!xen_feature(XENFEAT_hvm_safe_pvclock)) { 570 pr_info("Xen doesn't support pvclock on HVM, disable pv timer"); 571 return; 572 } 573 574 xen_init_time_common(); 575 576 x86_init.timers.setup_percpu_clockev = xen_time_init; 577 x86_cpuinit.setup_percpu_clockev = xen_hvm_setup_cpu_clockevents; 578 579 x86_platform.set_wallclock = xen_set_wallclock; 580 } I feel the code looks better if we keep the logic at caller side. Would you mind letting me know your feedback? Thank you very much! Dongli Zhang From xen-devel-bounces@lists.xenproject.org Tue Mar 01 05:27:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 05:27:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.280837.478918 (Exim 4.92) (envelope-from ) id 1nOv2j-0004R2-M3; Tue, 01 Mar 2022 05:27:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 280837.478918; Tue, 01 Mar 2022 05:27:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOv2j-0004Qv-Iy; Tue, 01 Mar 2022 05:27:25 +0000 Received: by outflank-mailman (input) for mailman id 280837; Tue, 01 Mar 2022 05:27:24 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOv2i-0004Ql-85; Tue, 01 Mar 2022 05:27:24 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOv2i-0005xS-3V; Tue, 01 Mar 2022 05:27:24 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOv2h-0002rL-P6; Tue, 01 Mar 2022 05:27:23 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nOv2h-00053e-Od; Tue, 01 Mar 2022 05:27:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=3kE8N+j9reqVw4k6HFEVx6ZsdO2Pzy4RRPzb0qvMUoM=; b=XjFDtD6yURNI5R1nvfS98GXE8y vjSj9nTW8vbseuyaTOk8H8ivS4KysRPQhkOLcqM5vyDBLMTEmwxVDIvcGQzd0a30eTHFJqAZfXLo/ T5MLpBmOjkDJgmhR2XSP5t4oruSmUtExDFDmQJDIakghcuuftdvLSuwnSTJTfgyhzTNM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 168262: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=497ac7b6d7f9750f48f137db244931a5728b1968 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 01 Mar 2022 05:27:23 +0000 flight 168262 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/168262/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 497ac7b6d7f9750f48f137db244931a5728b1968 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 0 days Failing since 168258 2022-03-01 01:55:31 Z 0 days 2 attempts Testing same since 168262 2022-03-01 04:10:26 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Guomin Jiang Jason Jason Lou jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 497ac7b6d7f9750f48f137db244931a5728b1968 Author: Guomin Jiang Date: Sat Jan 29 16:28:02 2022 +0800 UefiPayloadPkg/PayloadLoaderPeim: Use INT64 as input parameter REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3818 It will have some potential issue when memory larger than 2G because the high memory address will be fill with 0xFFFFFFFF when do the operation of INTN + INT64 but it is 32 bit normal data in fact. Should use same data type INT64 + INT64. V3: 1. Use INT64 as input parameter because all date type is 64 bit V2: 1. Force the data type to UINTN to avoid high dword be filled with 0xFFFFFFFF 2. Keep INTN because the offset may postive or negative. Reviewed-by: Guo Dong Reviewed-by: Ray Ni Signed-off-by: Guomin Jiang commit 6a890db161cd6d378bec3499a1e774db3f5a27a7 Author: Jason Date: Mon Jan 10 22:30:29 2022 +0800 BaseTools: Upgrade the version of NASM tool REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Upgrade the version of NASM tool to avoid compilation errors when compiling NASM code change. Signed-off-by: Jason Lou Cc: Bob Feng Cc: Liming Gao Reviewed-by: Yuwei Chen commit bbaa00dd01ed0df30e43a5a89fd2b0433d858b73 Author: Jason Date: Mon Jan 10 22:05:47 2022 +0800 MdePkg: Remove the macro definitions regarding Opcode. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Remove the macro definitions regarding Opcode because new version of NASM tool(e.g. v2.15.05) supports the corresponding instructions. Note: This patch need to be merged after other NASM code change to avoid compilation errors. Signed-off-by: Jason Lou Cc: Michael D Kinney Reviewed-by: Liming Gao Cc: Zhiguang Liu commit 2aa107c0aa2e1375651867c8df1b81ff64b67fce Author: Jason Date: Mon Jan 10 22:01:18 2022 +0800 UefiCpuPkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Reviewed-by: Ray Ni Cc: Eric Dong Cc: Laszlo Ersek Cc: Rahul Kumar commit 7bc8b1d9f412507d579f21ea9af56fced81e7827 Author: Jason Date: Mon Jan 10 21:52:52 2022 +0800 SourceLevelDebugPkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Reviewed-by: Hao A Wu commit d3febfd9ade35dc552df6b3607c2b15d26b82867 Author: Jason Date: Mon Jan 10 21:46:27 2022 +0800 MdePkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Cc: Michael D Kinney Reviewed-by: Liming Gao Cc: Zhiguang Liu commit 84338c0d498555f860a480693ee8647a1795fba3 Author: Jason Date: Mon Jan 10 21:04:09 2022 +0800 MdeModulePkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Reviewed-by: Ray Ni Cc: Dandan Bi Reviewed-by: Liming Gao From xen-devel-bounces@lists.xenproject.org Tue Mar 01 06:05:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 06:05:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.280850.478936 (Exim 4.92) (envelope-from ) id 1nOvcf-0000Po-OX; Tue, 01 Mar 2022 06:04:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 280850.478936; Tue, 01 Mar 2022 06:04:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOvcf-0000Ph-Kd; Tue, 01 Mar 2022 06:04:33 +0000 Received: by outflank-mailman (input) for mailman id 280850; Tue, 01 Mar 2022 06:04:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOvce-0000PX-Ii; Tue, 01 Mar 2022 06:04:32 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOvce-0006db-Fd; Tue, 01 Mar 2022 06:04:32 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOvce-0004YH-1g; Tue, 01 Mar 2022 06:04:32 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nOvcd-0005vl-Vx; Tue, 01 Mar 2022 06:04:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=GUjq5DS0H8ZWN+GCgXzb0mB9+LP9ZuRWPeQ2YTKaPRU=; b=hFG4CwhkSrTqWgKYvYe1GcZCXo Re2JaFxsi0QkCkNEqeHHuU4lXjJ3Na3kChCQuri6XNCmJ/szcISY/2Y0PY6hBJAWOjk++Xpq4K5MX mORDrGWQqfRg5AkvbeJSMRFKWemdmUh+dIO6N3ukcdm3JuteVhgM2D06LCMjoF/2RXqw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 168256: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-freebsd12-amd64:guest-localmigrate/x10:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=719fce7539cd3e186598e2aed36325fe892150cf X-Osstest-Versions-That: linux=7e57714cd0ad2d5bb90e50b5096a0e671dec1ef3 From: osstest service owner Date: Tue, 01 Mar 2022 06:04:31 +0000 flight 168256 linux-linus real [real] flight 168261 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/168256/ http://logs.test-lab.xenproject.org/osstest/logs/168261/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-freebsd12-amd64 19 guest-localmigrate/x10 fail pass in 168261-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 168250 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 168250 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 168250 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 168250 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 168250 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 168250 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 168250 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168250 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: linux 719fce7539cd3e186598e2aed36325fe892150cf baseline version: linux 7e57714cd0ad2d5bb90e50b5096a0e671dec1ef3 Last test of basis 168250 2022-02-28 03:45:58 Z 1 days Testing same since 168256 2022-02-28 21:11:14 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adam Ford Alyssa Ross Andy Shevchenko Anthoine Bourgeois Ard Biesheuvel Arnd Bergmann Brian Norris Christophe JAILLET Claudiu Beznea Corentin Labbe Dinh Nguyen Frank Wunderlich Heiko Stuebner Jakob Unterwurzacher Jann Horn Jason Wang Jens Wiklander Jiasheng Jiang Krzysztof Kozlowski Laurent Pinchart Li Yang Linus Torvalds Liviu Dudau Ludovic Desroches Michael Riesch Nicolas Ferre Peng Fan Peter Geis Quentin Schulz Rob Herring Robin Murphy Sascha Hauer Shawn Guo Sudeep Holla Sunil V L Thierry Reding Tony Lindgren Yang Yingliang jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 7e57714cd0ad..719fce7539cd 719fce7539cd3e186598e2aed36325fe892150cf -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Tue Mar 01 06:27:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 06:27:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.280865.478953 (Exim 4.92) (envelope-from ) id 1nOvyr-0003By-PK; Tue, 01 Mar 2022 06:27:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 280865.478953; Tue, 01 Mar 2022 06:27:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOvyr-0003Bo-MF; Tue, 01 Mar 2022 06:27:29 +0000 Received: by outflank-mailman (input) for mailman id 280865; Tue, 01 Mar 2022 06:27:28 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOvyq-0003Bc-6T; Tue, 01 Mar 2022 06:27:28 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOvyq-00070o-3q; Tue, 01 Mar 2022 06:27:28 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOvyp-0005n9-RK; Tue, 01 Mar 2022 06:27:27 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nOvyp-0007fF-Qr; Tue, 01 Mar 2022 06:27:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=7VnbeE2zxxy6ly0ZJp/U+J/Xm0VyvoH4HWvXZbtUYX0=; b=29CUsWpMm1TaE293EPxEKd5EUa Qi1atBTDq/IRLdmh/2uzdacgd6CfGwVWKtim5inMI6MIXjTA8tv4CAPtfbm/ZUCsk1kyUoWexygOM eV9WSgRAf4b8euWkCYIoEsOkivlwm8iTTHHf+MOBuvS3OAfck5E44eED463hVaudnlqE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 168267: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=497ac7b6d7f9750f48f137db244931a5728b1968 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 01 Mar 2022 06:27:27 +0000 flight 168267 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/168267/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 497ac7b6d7f9750f48f137db244931a5728b1968 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 0 days Failing since 168258 2022-03-01 01:55:31 Z 0 days 3 attempts Testing same since 168262 2022-03-01 04:10:26 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Guomin Jiang Jason Jason Lou jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 497ac7b6d7f9750f48f137db244931a5728b1968 Author: Guomin Jiang Date: Sat Jan 29 16:28:02 2022 +0800 UefiPayloadPkg/PayloadLoaderPeim: Use INT64 as input parameter REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3818 It will have some potential issue when memory larger than 2G because the high memory address will be fill with 0xFFFFFFFF when do the operation of INTN + INT64 but it is 32 bit normal data in fact. Should use same data type INT64 + INT64. V3: 1. Use INT64 as input parameter because all date type is 64 bit V2: 1. Force the data type to UINTN to avoid high dword be filled with 0xFFFFFFFF 2. Keep INTN because the offset may postive or negative. Reviewed-by: Guo Dong Reviewed-by: Ray Ni Signed-off-by: Guomin Jiang commit 6a890db161cd6d378bec3499a1e774db3f5a27a7 Author: Jason Date: Mon Jan 10 22:30:29 2022 +0800 BaseTools: Upgrade the version of NASM tool REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Upgrade the version of NASM tool to avoid compilation errors when compiling NASM code change. Signed-off-by: Jason Lou Cc: Bob Feng Cc: Liming Gao Reviewed-by: Yuwei Chen commit bbaa00dd01ed0df30e43a5a89fd2b0433d858b73 Author: Jason Date: Mon Jan 10 22:05:47 2022 +0800 MdePkg: Remove the macro definitions regarding Opcode. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Remove the macro definitions regarding Opcode because new version of NASM tool(e.g. v2.15.05) supports the corresponding instructions. Note: This patch need to be merged after other NASM code change to avoid compilation errors. Signed-off-by: Jason Lou Cc: Michael D Kinney Reviewed-by: Liming Gao Cc: Zhiguang Liu commit 2aa107c0aa2e1375651867c8df1b81ff64b67fce Author: Jason Date: Mon Jan 10 22:01:18 2022 +0800 UefiCpuPkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Reviewed-by: Ray Ni Cc: Eric Dong Cc: Laszlo Ersek Cc: Rahul Kumar commit 7bc8b1d9f412507d579f21ea9af56fced81e7827 Author: Jason Date: Mon Jan 10 21:52:52 2022 +0800 SourceLevelDebugPkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Reviewed-by: Hao A Wu commit d3febfd9ade35dc552df6b3607c2b15d26b82867 Author: Jason Date: Mon Jan 10 21:46:27 2022 +0800 MdePkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Cc: Michael D Kinney Reviewed-by: Liming Gao Cc: Zhiguang Liu commit 84338c0d498555f860a480693ee8647a1795fba3 Author: Jason Date: Mon Jan 10 21:04:09 2022 +0800 MdeModulePkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Reviewed-by: Ray Ni Cc: Dandan Bi Reviewed-by: Liming Gao From xen-devel-bounces@lists.xenproject.org Tue Mar 01 06:30:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 06:30:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.280876.478964 (Exim 4.92) (envelope-from ) id 1nOw1I-0003nC-8S; Tue, 01 Mar 2022 06:30:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 280876.478964; Tue, 01 Mar 2022 06:30:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOw1I-0003n5-4c; Tue, 01 Mar 2022 06:30:00 +0000 Received: by outflank-mailman (input) for mailman id 280876; Tue, 01 Mar 2022 06:29:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOw1G-0003mx-Op for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 06:29:58 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on0613.outbound.protection.outlook.com [2a01:111:f400:fe0d::613]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 02e5577f-9929-11ec-8539-5f4723681683; Tue, 01 Mar 2022 07:29:56 +0100 (CET) Received: from DB7PR03CA0101.eurprd03.prod.outlook.com (2603:10a6:10:72::42) by AM8PR08MB6322.eurprd08.prod.outlook.com (2603:10a6:20b:361::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Tue, 1 Mar 2022 06:29:55 +0000 Received: from DB5EUR03FT064.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:72:cafe::46) by DB7PR03CA0101.outlook.office365.com (2603:10a6:10:72::42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.26 via Frontend Transport; Tue, 1 Mar 2022 06:29:55 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT064.mail.protection.outlook.com (10.152.21.199) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22 via Frontend Transport; Tue, 1 Mar 2022 06:29:54 +0000 Received: ("Tessian outbound 1f399c739551:v113"); Tue, 01 Mar 2022 06:29:54 +0000 Received: from 75cbe0c61b86.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 860FB1B7-6B12-4777-A6AE-3E08BE806D5C.1; Tue, 01 Mar 2022 06:29:48 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 75cbe0c61b86.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 01 Mar 2022 06:29:48 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by AM8PR08MB6611.eurprd08.prod.outlook.com (2603:10a6:20b:36b::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.24; Tue, 1 Mar 2022 06:29:36 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::89b3:80a2:2b58:f1aa]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::89b3:80a2:2b58:f1aa%4]) with mapi id 15.20.5017.026; Tue, 1 Mar 2022 06:29:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 02e5577f-9929-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=569+K7VJtERt2TIYl+OHCZ9vzeGA5TWw0XVMsfKP690=; b=m5ixOASo2NsqKF5wrjjlVa9eoLG8c55zCzA1pxw9buASedo8dYVCQ6QVQaU4tPXLsXZXRzsN1/afAMDuwyqcO4MQ3N4qHhu70kq1yXcQ7M4+0L7mVLIRpWNKshIwPHYkjin00sLBKKzaPXSN2BTPAqhmAAa5y0/fEu48v9bXE58= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fIcf+jGPgI4us+TiBWqTBxS2tFvAO4KkTAKgxhq8N1bo+6PIik9VdJNbatIWD7XgK00dF4ZqXaIokXRvODbSgWdJL/6SASGmERVwMwRJoQVxQXEOh7xO4KUV8w2micIBaQdur6WY3YjMgxATMExKLYVtugZL5haru3TOVNkUEMl0G19lvTyHfFMKi9L5cHpk8qTFM3mBgUioFLdDdglTq/6kEuByVFWe0ETd8Wd2YgdhBA+evwXT1bpfLVa9ufDTUqBu9TLz5s5iF90Z4ZEw26O5m8tB/55cemouKkCLn/ej6wF9tv4rZd33tbMv6ZGu+jEATjIMLlhGAmltDv7Vrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=569+K7VJtERt2TIYl+OHCZ9vzeGA5TWw0XVMsfKP690=; b=eQUPs3Jw+uaaOtjrqGlcw8VjpbmtpPIcuXzKDzY1y/YoMbVkq9KJlFMZpQ+x/+/cJbnL5DFnshtd9d9YvBNu9VH4O99KFAV82AODrDSFCTLo7Z4MyTw3tzj7hVKD/51UK2hDI8unQfb8HeZSzTp2mcUCTWlyOAGobpxxph5fo4f2bYlERAyQYERM4i9F0JMvHT36NjbIOe+s5C820fR70oNRIfVwUlv9bQwNgqh6eXDskrFIkDoD2PlzTfvctinsIC5E+XIVEn+SB4fYrFhIqvIwLVXa8otfcHwRdEqA6WJjeQYb+zls8S0OQbo1IgBC2iN83GDoGkzBJkgKb5UCwg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=569+K7VJtERt2TIYl+OHCZ9vzeGA5TWw0XVMsfKP690=; b=m5ixOASo2NsqKF5wrjjlVa9eoLG8c55zCzA1pxw9buASedo8dYVCQ6QVQaU4tPXLsXZXRzsN1/afAMDuwyqcO4MQ3N4qHhu70kq1yXcQ7M4+0L7mVLIRpWNKshIwPHYkjin00sLBKKzaPXSN2BTPAqhmAAa5y0/fEu48v9bXE58= From: Wei Chen To: Julien Grall , Stefano Stabellini CC: "xen-devel@lists.xenproject.org" , Bertrand Marquis , Penny Zheng , Henry Wang , nd Subject: RE: Proposal for Porting Xen to Armv8-R64 - DraftA Thread-Topic: Proposal for Porting Xen to Armv8-R64 - DraftA Thread-Index: AdgpQxtXwh7LkfydTgiYk9bhMgU+ogAn0mUAABEK2UAAF1ylAACsO9Yw Date: Tue, 1 Mar 2022 06:29:36 +0000 Message-ID: References: <4c558f8f-56d4-0445-32d4-169bc5d0a3bc@xen.org> In-Reply-To: <4c558f8f-56d4-0445-32d4-169bc5d0a3bc@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: AEAD95AB30517741B057DA32500378FD.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 86ebe9b8-4430-4631-d23d-08d9fb4ce63d x-ms-traffictypediagnostic: AM8PR08MB6611:EE_|DB5EUR03FT064:EE_|AM8PR08MB6322:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: sHxs9RTY5VY/gN5WFa2ed22E7XNPWYwduLoT3I2NLGGBYDZ4lwcP26i92rlhA3mVu42qG7GaOvcxyBCdca+6PDT6pBywXdoc1/Jx9bPR3lbRakgJ67c4rSK90K4DJ1dEMmdF2RPUgLkebEXQYizzp5lmO7JwJYMjFCui8V/UnJXFNafA0mAN/8xUoUj1pKZWyqAjo/UQ3sOEyW00NkSqzFAWXDOGlCdvz/Nux/iG/HdScfNoWTseNBLB4Y7lI2O7OBCUxpGUOwkVeQT+E4a1Y85bteH4msalhWkMu4CZEUp1WObAk20JdxJgS8NOop48S2hjsAANf5zykUoLF6jBisXhU0i8lteRdaYRu9g9WVikhG414ZUARCgDfrQW3lx1xHkCUh7piABGoIfiPDTQ36Qvg5UkDYOgrFrGePSjLx22y1g77PdRk+4XZNVzVhA9r6yNH7bD+nyyKpcf511MnyU4YIcoGkDq8LfoDhegkzChuLM4Lb7SE+ROKD+T9Z+AaweBjL06fQM+RJJ9hmCQ/Wkw3WPhfUSNoQ/kGof4X963RpIRRVdl9pQlSrDBUpJWCLgPc/fsVNLKbQKtNOsuBofn+IJu6XRbTGwkkzwmX7JjZAqary2FuRg3pCnx192ZToyjAdQoIZ+CXwLyoXkHGb4rtiF3YUTRVxKqjGzCWyAPJh3YA/Y5l/kIcQFJE1phpCG/gK+2ixdpg14dIgv7dQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(110136005)(52536014)(86362001)(55016003)(66446008)(8676002)(64756008)(33656002)(4326008)(186003)(26005)(66946007)(76116006)(66556008)(66476007)(83380400001)(316002)(6506007)(9686003)(122000001)(53546011)(7696005)(508600001)(38100700002)(8936002)(71200400001)(38070700005)(54906003)(5660300002)(2906002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6611 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT064.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 0589c3a8-88ab-4ab0-67df-08d9fb4cdb2f X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7XrtFoT8jl90XPuPhv41et1t7di1eYZmb8ZBPoBqVZn0NCsBoqhdOPUPNlzaO340r1sRK9H+uf6ClXpZ/ojYq0CEdxBlpa28HUgre1oBatlATTSqm9VPVKGY1BfZCVLcRiqc5Qi8R17OBqBjounuSH8EvynFQtRBbAEmvHvxeKif6SPT0MdreZZgF6PxPWaCa8uvNFlC6UvXeV3DuEhbmpQim+Z7S9jSIeDk26/hhMjA3ZRVnhU4OvIQtKaBLTkKM3f2XpUYalk8slq+wvP9x2Nv+1c9s9/M8ckaeiwDtWQVnN4p3jf7i5o9MRxm/XTcjW8sX2RrzYXnn9YHvpnOkitbcSVJN9ZIEclZ10/9PC7BFb1Cd9ZVzbK/8au8juIeeYJwlDndCGr3xb9Ph7gBG+SgVUcwArpHcdD5YhElvTR3KmLJFfyLb/mOvEQRdinKM0Xh6kA+4Azl6Cf2xWCtvGnLHJr0NmrCDJ/B1j1g8y5DZWM99lcmq2qr+0K+cuJ01pvhURj6z7Pg6IHeFS1sO29OHcpnupfRyR6/3EFsXp9Fhew/qcuBzVtRs+QCBMiFrGrruzW8vkBUDPeEht2FbPNZM/hwCg6MhQtEgUGOZ5kDaMSVPVO1UMACpgvpWZkQKWMcMnofPjulT4r/iyC+jRVx+Xy11NTo2BNjB4VIrXr2XaE913JCNePEXkBsmLc5 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(54906003)(8676002)(70586007)(70206006)(316002)(110136005)(8936002)(508600001)(36860700001)(52536014)(40460700003)(4326008)(81166007)(7696005)(53546011)(9686003)(5660300002)(47076005)(2906002)(6506007)(356005)(33656002)(55016003)(336012)(82310400004)(83380400001)(86362001)(186003)(26005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2022 06:29:54.8533 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 86ebe9b8-4430-4631-d23d-08d9fb4ce63d X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT064.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6322 SGkgSnVsaWVuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEp1bGll biBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+IFNlbnQ6IDIwMjLlubQy5pyIMjbml6UgNDoxMg0K PiBUbzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+OyBTdGVmYW5vIFN0YWJlbGxpbmkNCj4g PHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+DQo+IENjOiB4ZW4tZGV2ZWxAbGlzdHMueGVucHJvamVj dC5vcmc7IEJlcnRyYW5kIE1hcnF1aXMNCj4gPEJlcnRyYW5kLk1hcnF1aXNAYXJtLmNvbT47IFBl bm55IFpoZW5nIDxQZW5ueS5aaGVuZ0Bhcm0uY29tPjsgSGVucnkgV2FuZw0KPiA8SGVucnkuV2Fu Z0Bhcm0uY29tPjsgbmQgPG5kQGFybS5jb20+DQo+IFN1YmplY3Q6IFJlOiBQcm9wb3NhbCBmb3Ig UG9ydGluZyBYZW4gdG8gQXJtdjgtUjY0IC0gRHJhZnRBDQo+IA0KPiBIaSBXZWksDQo+IA0KPiBP biAyNS8wMi8yMDIyIDEwOjQ4LCBXZWkgQ2hlbiB3cm90ZToNCj4gPj4gPsKgwqDCoMKgIEFybXY4 LVI2NCBjYW4gc3VwcG9ydCBtYXggdG8gMjU2IE1QVSByZWdpb25zLiBCdXQgdGhhdCdzIGp1c3QN Cj4gPj4gdGhlb3JldGljYWwuDQo+ID4+ID7CoMKgwqDCoCBTbyB3ZSBkb24ndCB3YW50IHRvIGRl ZmluZSBgcHJfdCBtcHVfcmVnaW9uc1syNTZdYCwgdGhpcyBpcyBhDQo+IG1lbW9yeQ0KPiA+PiB3 YXN0ZQ0KPiA+PiA+wqDCoMKgwqAgaW4gbW9zdCBvZiB0aW1lLiBTbyB3ZSBkZWNpZGVkIHRvIGxl dCB0aGUgdXNlciBzcGVjaWZ5IHRocm91Z2ggYQ0KPiA+PiBLY29uZmlnDQo+ID4+ID7CoMKgwqDC oCBvcHRpb24uIGBDT05GSUdfQVJNX01QVV9FTDFfUFJPVEVDVElPTl9SRUdJT05TYCBkZWZhdWx0 IHZhbHVlIGNhbg0KPiBiZQ0KPiA+PiBgMzJgLA0KPiA+PiA+wqDCoMKgwqAgaXQncyBhIHR5cGlj YWwgaW1wbGVtZW50YXRpb24gb24gQXJtdjgtUjY0LiBVc2VycyB3aWxsIHJlY29tcGlsZQ0KPiBY ZW4NCj4gPj4gd2hlbg0KPiA+PiA+wqDCoMKgwqAgdGhlaXIgcGxhdGZvcm0gY2hhbmdlcy4gU28g d2hlbiB0aGUgTVBVIGNoYW5nZXMsIHJlc3BlY2lmeWluZyB0aGUNCj4gPj4gTVBVDQo+ID4+ID7C oMKgwqDCoCBwcm90ZWN0aW9uIHJlZ2lvbnMgbnVtYmVyIHdpbGwgbm90IGNhdXNlIGFkZGl0aW9u YWwgcHJvYmxlbXMuDQo+ID4+DQo+ID4+IEkgd29uZGVyIGlmIHdlIGNvdWxkIHByb2JlIHRoZSBu dW1iZXIgb2YgTVBVIHJlZ2lvbnMgYXQgcnVudGltZSBhbmQNCj4gPj4gZHluYW1pY2FsbHkgYWxs b2NhdGUgdGhlIG1lbW9yeSBuZWVkZWQgdG8gc3RvcmUgdGhlbSBpbiBhcmNoX3ZjcHUuDQo+ID4+ DQo+ID4NCj4gPiBXZSBoYXZlIGNvbnNpZGVyZWQgdG8gdXNlZCBhIHByX3QgbXB1X3JlZ2lvbnNb MF0gaW4gYXJjaF92Y3B1LiBCdXQgaXQNCj4gc2VlbXMNCj4gPiB3ZSB3aWxsIGVuY291bnRlciBz b21lIHN0YXRpYyBhbGxvY2F0ZWQgYXJjaF92Y3B1IHByb2JsZW1zIGFuZCBzaXplb2YNCj4gaXNz dWUuDQo+IA0KPiBEb2VzIGl0IG5lZWQgdG8gYmUgZW1iZWRkZWQgaW4gYXJjaF92Y3B1PyBJZiBu b3QsIHRoZW4gd2UgY291bGQgYWxsb2NhdGUNCj4gbWVtb3J5IG91dHNpZGUgYW5kIGFkZCBhIHBv aW50ZXIgaW4gYXJjaF92Y3B1Lg0KPiANCg0KV2UgaGFkIHRob3VnaHQgdG8gdXNlIGEgcG9pbnRl ciBpbiBhcmNoX3ZjcHUgaW5zdGVhZCBvZiBlbWJlZGRpbmcgbXB1X3JlZ2lvbnMNCmludG8gYXJj aF92Y3B1LiBCdXQgd2Ugbm90aWNlZCB0aGF0IGFyY2hfdmNwdSBoYXMgYSBfX2NhY2hlbGluZV9h bGlnbmVkDQphdHRyaWJ1dGUsIHRoaXMgbWF5IGJlIGJlY2F1c2Ugb2YgYXJjaF92Y3B1IHdpbGwg YmUgdXNlZCB2ZXJ5IGZyZXF1ZW50bHkNCmluIHNvbWUgY3JpdGljYWwgcGF0aC4gU28gaWYgd2Ug dXNlIHRoZSBwb2ludGVyIGZvciBtcHVfcmVnaW9ucywgbWF5IGNhdXNlDQpzb21lIGNhY2hlIG1p c3MgaW4gdGhlc2UgY3JpdGljYWwgcGF0aCwgZm9yIGV4YW1wbGUsIGluIGNvbnRleHRfc3d0aWNo Lg0KDQo+IENoZWVycywNCj4gDQo+IC0tDQo+IEp1bGllbiBHcmFsbA0K From xen-devel-bounces@lists.xenproject.org Tue Mar 01 07:38:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 07:38:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.280891.478999 (Exim 4.92) (envelope-from ) id 1nOx4x-0003Ni-HJ; Tue, 01 Mar 2022 07:37:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 280891.478999; Tue, 01 Mar 2022 07:37:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOx4x-0003Nb-Dy; Tue, 01 Mar 2022 07:37:51 +0000 Received: by outflank-mailman (input) for mailman id 280891; Tue, 01 Mar 2022 07:37:50 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOx4w-0003NR-Jb; Tue, 01 Mar 2022 07:37:50 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOx4w-0008F5-GN; Tue, 01 Mar 2022 07:37:50 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOx4w-0008Tq-AG; Tue, 01 Mar 2022 07:37:50 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nOx4w-0005D5-9n; Tue, 01 Mar 2022 07:37:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Message-Id:Subject:To; bh=cJFYca+8qQgwK28LMsYF5pBUqgNZoRvd9AkLD9JKL5Y=; b=ZS1pBwg1uL+VO/iXCP2NgRl8Zr DAePsWkfAGJOcCZ3CaK1UjgcwNrxuKRwxm0ygw2aggGf9x83ErbNdfWOljTJ1hggo6uHtehn+SO1I Q4FfjzDraqmt3FIBQR4+wAmTjWjvuswD0wrIgNknE7zV7iRrat/MSC1Y+CKlXVGS2V18=; To: xen-devel@lists.xenproject.org Subject: [ovmf bisection] complete build-amd64-xsm Message-Id: From: osstest service owner Date: Tue, 01 Mar 2022 07:37:50 +0000 branch xen-unstable xenbranch xen-unstable job build-amd64-xsm testid xen-build Tree: ovmf https://github.com/tianocore/edk2.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: seabios git://xenbits.xen.org/osstest/seabios.git Tree: xen git://xenbits.xen.org/xen.git *** Found and reproduced problem changeset *** Bug is in tree: ovmf https://github.com/tianocore/edk2.git Bug introduced: d3febfd9ade35dc552df6b3607c2b15d26b82867 Bug not present: 84338c0d498555f860a480693ee8647a1795fba3 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/168274/ commit d3febfd9ade35dc552df6b3607c2b15d26b82867 Author: Jason Date: Mon Jan 10 21:46:27 2022 +0800 MdePkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Cc: Michael D Kinney Reviewed-by: Liming Gao Cc: Zhiguang Liu For bisection revision-tuple graph see: http://logs.test-lab.xenproject.org/osstest/results/bisect/ovmf/build-amd64-xsm.xen-build.html Revision IDs in each graph node refer, respectively, to the Trees above. ---------------------------------------- Running cs-bisection-step --graph-out=/home/logs/results/bisect/ovmf/build-amd64-xsm.xen-build --summary-out=tmp/168274.bisection-summary --basis-template=168254 --blessings=real,real-bisect,real-retry ovmf build-amd64-xsm xen-build Searching for failure / basis pass: 168267 fail [host=himrod1] / 168254 [host=himrod2] 168249 [host=himrod2] 168232 ok. Failure / basis pass flights: 168267 / 168232 (tree with no url: minios) Tree: ovmf https://github.com/tianocore/edk2.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: seabios git://xenbits.xen.org/osstest/seabios.git Tree: xen git://xenbits.xen.org/xen.git Latest 497ac7b6d7f9750f48f137db244931a5728b1968 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 Basis pass 54cddc3ad4b3a317985ce5f491f9b1f31ab10dd8 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 9ba4c529985a1773852069889a5b53f2ed26c408 Generating revisions with ./adhoc-revtuple-generator https://github.com/tianocore/edk2.git#54cddc3ad4b3a317985ce5f491f9b1f31ab10dd8-497ac7b6d7f9750f48f137db244931a5728b1968 git://xenbits.xen.org/qemu-xen-traditional.git#3d273dd05e51e5a1ffba3d98c7437ee84e8f8764-3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 git://xenbits.xen.org/qemu-xen.git#a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42-a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 git://xenbits.xen.org/osstest/seabios.git#829b0f1a7cda1bccdf44a379fb3a96e519a7e8\ cd-829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd git://xenbits.xen.org/xen.git#9ba4c529985a1773852069889a5b53f2ed26c408-4388144c44c4dd9e9b7df97938ef08ffa85eec07 Loaded 10001 nodes in revision graph Searching for test results: 168232 pass 54cddc3ad4b3a317985ce5f491f9b1f31ab10dd8 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 9ba4c529985a1773852069889a5b53f2ed26c408 168249 [host=himrod2] 168254 [host=himrod2] 168258 fail 6a890db161cd6d378bec3499a1e774db3f5a27a7 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 168259 pass 54cddc3ad4b3a317985ce5f491f9b1f31ab10dd8 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 9ba4c529985a1773852069889a5b53f2ed26c408 168260 fail 6a890db161cd6d378bec3499a1e774db3f5a27a7 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 168263 pass 54cddc3ad4b3a317985ce5f491f9b1f31ab10dd8 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 1449f6873d7dd477ba110b415ca08a3c2553451e 168265 pass de463163d9f6d3c5dc6b55ff35d1e5676e0e1b9f 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 168262 fail 497ac7b6d7f9750f48f137db244931a5728b1968 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 168266 pass 84338c0d498555f860a480693ee8647a1795fba3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 168268 fail 7bc8b1d9f412507d579f21ea9af56fced81e7827 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 168267 fail 497ac7b6d7f9750f48f137db244931a5728b1968 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 168269 fail d3febfd9ade35dc552df6b3607c2b15d26b82867 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 168270 pass 84338c0d498555f860a480693ee8647a1795fba3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 168272 fail d3febfd9ade35dc552df6b3607c2b15d26b82867 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 168273 pass 84338c0d498555f860a480693ee8647a1795fba3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 168274 fail d3febfd9ade35dc552df6b3607c2b15d26b82867 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 Searching for interesting versions Result found: flight 168232 (pass), for basis pass For basis failure, parent search stopping at 84338c0d498555f860a480693ee8647a1795fba3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07, results HASH(0x55de963d98b0) HASH(0x55de963e9dc0) HASH(0x55de963ecb70) For basis failure, parent search stopping at de463163d9f6d3c5dc6b55ff35d1e5676e0e1b9f 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7\ cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07, results HASH(0x55de963dd8c0) For basis failure, parent search stopping at 54cddc3ad4b3a317985ce5f491f9b1f31ab10dd8 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 1449f6873d7dd477ba110b415ca08a3c2553451e, results HASH(0x55de963ca7a8) For basis failure, parent search stopping at 54cddc3ad4b3a317985ce5f491f9b1f31ab10dd8 3d273dd05e51e5a1ffba3d98c7437ee\ 84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 9ba4c529985a1773852069889a5b53f2ed26c408, results HASH(0x55de963d2670) HASH(0x55de963d78a8) Result found: flight 168258 (fail), for basis failure (at ancestor ~5258) Repro found: flight 168259 (pass), for basis pass Repro found: flight 168262 (fail), for basis failure 0 revisions at 84338c0d498555f860a480693ee8647a1795fba3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 No revisions left to test, checking graph state. Result found: flight 168266 (pass), for last pass Result found: flight 168269 (fail), for first failure Repro found: flight 168270 (pass), for last pass Repro found: flight 168272 (fail), for first failure Repro found: flight 168273 (pass), for last pass Repro found: flight 168274 (fail), for first failure *** Found and reproduced problem changeset *** Bug is in tree: ovmf https://github.com/tianocore/edk2.git Bug introduced: d3febfd9ade35dc552df6b3607c2b15d26b82867 Bug not present: 84338c0d498555f860a480693ee8647a1795fba3 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/168274/ commit d3febfd9ade35dc552df6b3607c2b15d26b82867 Author: Jason Date: Mon Jan 10 21:46:27 2022 +0800 MdePkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Cc: Michael D Kinney Reviewed-by: Liming Gao Cc: Zhiguang Liu Revision graph left in /home/logs/results/bisect/ovmf/build-amd64-xsm.xen-build.{dot,ps,png,html,svg}. ---------------------------------------- 168274: tolerable ALL FAIL flight 168274 ovmf real-bisect [real] http://logs.test-lab.xenproject.org/osstest/logs/168274/ Failures :-/ but no regressions. Tests which did not succeed, including tests which could not be run: build-amd64-xsm 6 xen-build fail baseline untested jobs: build-amd64-xsm fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary From xen-devel-bounces@lists.xenproject.org Tue Mar 01 07:43:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 07:43:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.280905.479012 (Exim 4.92) (envelope-from ) id 1nOxA9-0004r2-Ag; Tue, 01 Mar 2022 07:43:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 280905.479012; Tue, 01 Mar 2022 07:43:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOxA9-0004qv-7U; Tue, 01 Mar 2022 07:43:13 +0000 Received: by outflank-mailman (input) for mailman id 280905; Tue, 01 Mar 2022 07:43:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOxA7-0004qp-Sw for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 07:43:11 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3df022c4-9933-11ec-8eba-a37418f5ba1a; Tue, 01 Mar 2022 08:43:10 +0100 (CET) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05lp2113.outbound.protection.outlook.com [104.47.18.113]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-22-j-vCEuMeNjuw-6_NMlmtOA-1; Tue, 01 Mar 2022 08:43:09 +0100 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by AM0PR04MB4900.eurprd04.prod.outlook.com (2603:10a6:208:c9::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.25; Tue, 1 Mar 2022 07:43:08 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.027; Tue, 1 Mar 2022 07:43:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3df022c4-9933-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1646120590; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=w5DX0udg4woY/xz8lzpN0tu8Ytb/rhBWFqUXG783oug=; b=hJOrupEBY80+m9q4DUwkS4oT91NOiY4DqeIF17XaRPU+eNmMIUgEG1ESEfsvVqFeaLkHaD zfx5FFelvMJOospqgMNcx/U/uTwX2VkkOWpBExq8cbKMlOSWkmkYzZHmcVyYq/eqPyt5Ac azIaU+Id+mmWS+kSimOmWFmunL31pQQ= X-MC-Unique: j-vCEuMeNjuw-6_NMlmtOA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DZUMm/tST9bd9eWlDck8VsycV/xbT6PPKlJvWvUPRZuKY2QPteJMeR9Pu15uperTJ+lxt1F4cafxgjEd9489RCDo9o3d91PKD1onc14WWVRshLF9XoCvvmrCwqrUx470R4QoRh2o6KQoN3jj2idzAXQYMLXqCz7nnaKYV7gVhBGAp9aqUCtaWUIFbrqHemqt+xtYaWZz4nRTTgIC6nL4zfBabHWrZkiDQe4Z/umtSvOW3+2qBN9opm8eQ5SQl9/3/YSwXR9hTktXYRLynIOhkdZgKA95J8Xw/0M3npbp94/movyPy26QNubCVfS6TT3EbvC5st/3gQTxT3wYvZB4ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w5DX0udg4woY/xz8lzpN0tu8Ytb/rhBWFqUXG783oug=; b=aytmH14XCewHVyZnE5wvnbRDzWfurqgCQEZeCVvu1vLugg+ilkBvam5oAWAx9qG2pxFN5vhxAacOPLxgWhHEg/+fzsgEAFSHUFLYR98tLTnCevt4gUJL6iG7qib8dyBs9xYGNmqGKDF4zWmmB5tfziUiE+pkuGxgSNANfVku9o0rofaoApfOFo3UCtUpPTvQtqErkY1hdeXFKAtVjdfRSFz8EhPg/JRNvmki46FfwbX53tit/u34lBygUV7T07GGm0KDWnEK1BVUFKoUiJbGfPylk/H4wH2iVR8LpMtiJu1DCnKBPrxRh45vSIBiPjpN2g8VxUBcyiPALVX43aTJng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 1 Mar 2022 08:43:06 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH v2 2/2] vpci/msix: fix PBA accesses Content-Language: en-US To: Alex Olson Cc: xen-devel@lists.xenproject.org, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <20220225153956.1078-1-roger.pau@citrix.com> <20220225153956.1078-3-roger.pau@citrix.com> <3986c91f62cb1bf3a042f669c40b900653f1ab51.camel@gmail.com> From: Jan Beulich In-Reply-To: <3986c91f62cb1bf3a042f669c40b900653f1ab51.camel@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6P195CA0005.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:81::18) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9c81a05d-8e24-4ef7-cae7-08d9fb5720c8 X-MS-TrafficTypeDiagnostic: AM0PR04MB4900:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qNCKIsJkI2ZkjXAn/F2UnUqz9neBnOHvZ20JqpMRYkcSvUMk5VZBTjaF8XxoE9e0zfOgO+E1yWeBI1cRJUw1x5h3I+5xuZdqxXs51sEqKsrhDIF6eOVyBr+SI/U3xPgRGf8ibjPBR0x7SEcMygXpMzFlS7ifKCqGkXC2iSc2m478NlY1MFxr9SEd8qBOwRybWPxnFt3QyAPCQF5rWZMO3PccuJa5BdDWf5te6vvlL3KqjdjlEhYoTT0kpVdk9nUbuLIhBOKTisyYmQL4Qv6rP2+ecRvP2Ye3XqU9PiThIGQOA4PxKpDev2WCSIDjb7SJ33EP4RBUyRKJg9hlm/XWF5Y4+MlOiBiPmby13zUvXT+amz1x7suz8iuxiQt4Mqr1FyB+wWk7sH1QSBNpAQHNWmxhf/UWMtw8q+6TLQsJavKHzmwwBRi8OeUDVpVJFZWkd22FCKpOQ5F/D+jEh6cITKWOtw+sM8rcngXa1/Gvm+9Kyc0FknYMZpbgzeb8mdD+4eaOgEPH67tx2AMaBmaXergcrpJQNvSsnbz+36dD/g1zaZnLXnGhA6AJGfUW62O+UAOhd36rlfBSoCEas+KkTdlrNC6KQnajuhY57eTVXd5PhttqdhIg3v2UjhIEgjDD/9HFwp3VzEW0L/dM/LtdCckPt4NLVkExl2ruj0ZjiFPr1e71vthwyRlX1U5+u/lI04tv8sb3H3tghVCurUeA5WjLJmtjmzg0dNxgt+jeitzMMKkh7NstoJAdID9AIUoE X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6486002)(36756003)(53546011)(31696002)(2616005)(6506007)(86362001)(508600001)(26005)(186003)(66556008)(6916009)(8676002)(4326008)(66946007)(66476007)(38100700002)(5660300002)(31686004)(8936002)(6512007)(316002)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZnJqRXdoUFdLWHN5NTkway9KRGJoeHhFV3JESGhSZFRiQlNHdFVYT2gybGZn?= =?utf-8?B?b3BvZDc0RDZVN0pIckVQbmJTZG9scm82WnpJNzZ3aXVxeUtheFEzL0JMTG52?= =?utf-8?B?Qno2U2lLRGVQZXNVZ3VXQlJFdjd6aUdWUWNxNFdOMEFRVVdoS1dyODA4V0Rl?= =?utf-8?B?amM5OVNRMUwwaHNLbk5wdXlBQmhzYStzOE5DTDZ0TmZjMG5zZXB2T1Q5Uncr?= =?utf-8?B?RDdCcDNLcFI4L0tYa1FCOUV2QzZqQmRoeEdiZmxqK0prSEhmc1hKekx0eDBt?= =?utf-8?B?SWJvRFB4VWhjUmZQZnc0dlBJSldDQVBQN3ZjbVFSU1RBdWZTK2VuRmdRTGps?= =?utf-8?B?bjhiZU1XOC80UnE3M2lmdS9NN0tTcHBjemdJeENHZThwSTJ4RmdmMGROakFu?= =?utf-8?B?Sk1JOGNwN3g1VzdjSEw2cVhsQjZveUJJOEFIanBxcUxOK0NzdUlaUlRsS1ls?= =?utf-8?B?eG14UCt1d3pubHQvZHk3Znpka1plVzg1WlYzaWtlVUR1bXhiN3MrV25mMVlP?= =?utf-8?B?b2V1cFBmTVpDYW1OOUZOdXlLc1hkRTlrTzBycGtNaktrcCtEMGk2OUR1RVJa?= =?utf-8?B?YitlL0NmcFdHL05xTEQydU9UdUtQTi9Vd3prRWg5dlJjQS9vQTNDTVFxUmFH?= =?utf-8?B?Z01MRlpLOHgyQUdiZTRiYVZsZHRHS09lM053OUVvV3hrbmFuSlRVaHU5cUlO?= =?utf-8?B?dTIzUG43K25OZ0UwL1V2QWd2eUxtZFVWRUFmU2lDZHZwZTJLWjlHenRFMmdh?= =?utf-8?B?ZVVKSkZ3cmNrM0VzN1NyQTE5WXlURTZkNERkWGR0MkhlakI2eExJOUY4WFpC?= =?utf-8?B?elV6TFdTNjBnanh0RzdvdFArUUdDQzNRaTd5N2h0TFppa3ViUVJEcmxnMzNj?= =?utf-8?B?a0p0SkdLTWpUdUxsNDU0ekZQNG9uQWdJUUZlRVlIWTB1bEh6RlhRSzIxUFhx?= =?utf-8?B?Mmk1L2JzL1dRdkhXQmZpY0tYbktKRktzQkVEYzV0WU9oeDhvZGNabDFHN1ZJ?= =?utf-8?B?Und6N0VYaFZ5YUZIckthQ1pxeVE4SlJ3QTFRMXBraWJEOS9OSEpjeGFtakhx?= =?utf-8?B?VllqSDhwWFpkUW90SS9Oc2JkanRvbUxkaHZVR3F1WTNvMjB1N3BmWjR1b21X?= =?utf-8?B?ZzFMMTZKMGhyVlkySXErRWc3akdleVBlOGlQb0RqT0RDTjQ5UCs0MDhPc1pn?= =?utf-8?B?OUNjclZycU05MkhZeDFYZVdwNnZ6VlVHcFc0dDFKb1BJajI5Mzdja3FUMW42?= =?utf-8?B?UGQ1ME4vQ3pqTHlYalUyU3dnbnlKSnRDcmRXdzZoYU9FYmw1V1dlSVBYeTN6?= =?utf-8?B?ejBKOVJRdjVuZUlsdzBYYTJFZHRKbEFTOFJROVdodTdSY0d2dlFTbXV4bmEx?= =?utf-8?B?RFVHMHorblJXVkR6ZXczTVpZcytNODB0RDAwbWE5Mm1SOW9GbTh1V2hFMmRK?= =?utf-8?B?cmE0cU5ZSXJHU2lsZXlWN1hzM2JsQlFlWjJoZ1NkcTJxZTRSY1NMVWUzMUhk?= =?utf-8?B?T2lJYkwwRDhyMFBYRGNpUWxJTDhRNXE0RnhyNTR5Uk1BZzFORVdrWHdiWHdk?= =?utf-8?B?cHQyK3BseVBrc2NrUS9aZWJPOTJqNlFiZElXM2RQSVAvMU96YncxVks3dUt5?= =?utf-8?B?ZXdkMlpsZlJaS3pQMGhJeGtJQ3Y3R0c2Y1hTNVgvSUIyOVUxekdpcy9XU291?= =?utf-8?B?Wkx2NENDTUpUdUVlZ2Y2ZGNPcHkzV0dwWlcycS9acW43eEE4ZDlIdUZJd2ps?= =?utf-8?B?c3VHcVFPSHlyMVZFTmFqUk81MGpBZTdMSEdTQ2FyTUJ4YWFxRmYwdHoyb1Zm?= =?utf-8?B?bXplVGFjK3RMak12WVQzYWNVTm5GbW1YTzNVVCtGNVY5SDFya0FhN0tqWXV3?= =?utf-8?B?THpaVkhXU0NvR2lkSWN4UFJ2V2I5RlRSSHpITUJLZlBRYlY1K1crb1VvN2dY?= =?utf-8?B?T2lvQlZCaUVka3FWSlp3eFNHS3lvZnJKTWU1TjlEZHBaQ3E4Vi9UM3phR3dr?= =?utf-8?B?Sk1CUUhuTnpoTWd5Z1pLRHJtb0VuZW1CL3owMjV3YU5JYllWRUI3cm9TL2sy?= =?utf-8?B?cjJHU3FQd040UVdjZ2hCV0k4Z0VjWGtyNzF6U3NsNForVzEwMlBuZXh5V1hW?= =?utf-8?B?VEVCUWJtUTB5YTd4Z3pCVE9ON3EwQklRdXVKNFBLOFBwdWhUQnpBb2RaZmNq?= =?utf-8?Q?NdvruEjPNmaxPcxKVBAX3ag=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9c81a05d-8e24-4ef7-cae7-08d9fb5720c8 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2022 07:43:08.1954 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: J9Jm2vABpuFPMWAfg7ecOsbIU871L5o9z8jYee2CxTDm8Fsuni7jSxYsvUXeH9B5u9Jk2NgoX+rxJHRdPHBIyA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4900 On 28.02.2022 19:19, Alex Olson wrote: > FYI, with this patch, I was seeing msix_read() and msix_write() being called > during the driver's self-test on physical address 0xfbc01800, corresponding to > the beginning of the PBA (lspci excerpt below): > > > 02:00.0 System peripheral: Intel Corporation Xeon Processor D Family QuickData Technology Register DMA Channel 0 > ... > Region 0: Memory at fbc06000 (64-bit, non-prefetchable) [size=8K] > ... > Capabilities: [ac] MSI-X: Enable+ Count=1 Masked- > Vector table: BAR=0 offset=00001000 > PBA: BAR=0 offset=00001800 > ... > Kernel modules: ioatdma > > > > The functions involved on the Linux kernel side are: > > ioat_probe() > -> ioat3_dma_self_test() > -> ioat_dma_self_test() > -> ioat_free_chan_resources() > -> ioat_reset_hw() > > drivers/dma/ioat/dma.c: ioat_reset_hw() > ... > ioat_dma->msixpba = readq(ioat_dma->reg_base + 0x1800); > ... > writeq(ioat_dma->msixpba, ioat_dma->reg_base + 0x1800); Wow, a clear and apparently intentional violation of the PCI spec. There was a workaround for a reset issue introduced by commit 8a52b9ff1154, which was then revised by c997e30e7f65 to take the present shape. However, both commits claim this only affects certain Atoms, albeit the latter less explicitly by having "CB3.3" in the subject. Yet you're seeing this on a Xeon D ... Jan From xen-devel-bounces@lists.xenproject.org Tue Mar 01 07:51:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 07:51:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.280912.479024 (Exim 4.92) (envelope-from ) id 1nOxIW-0006Ot-5D; Tue, 01 Mar 2022 07:51:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 280912.479024; Tue, 01 Mar 2022 07:51:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOxIW-0006Om-1u; Tue, 01 Mar 2022 07:51:52 +0000 Received: by outflank-mailman (input) for mailman id 280912; Tue, 01 Mar 2022 07:51:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOxIV-0006Oe-EE for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 07:51:51 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0614.outbound.protection.outlook.com [2a01:111:f400:fe1e::614]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 72c21693-9934-11ec-8539-5f4723681683; Tue, 01 Mar 2022 08:51:48 +0100 (CET) Received: from DB8PR06CA0023.eurprd06.prod.outlook.com (2603:10a6:10:100::36) by AM0PR08MB3668.eurprd08.prod.outlook.com (2603:10a6:208:d8::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Tue, 1 Mar 2022 07:51:45 +0000 Received: from DB5EUR03FT044.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:100:cafe::6e) by DB8PR06CA0023.outlook.office365.com (2603:10a6:10:100::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22 via Frontend Transport; Tue, 1 Mar 2022 07:51:45 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT044.mail.protection.outlook.com (10.152.21.167) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22 via Frontend Transport; Tue, 1 Mar 2022 07:51:45 +0000 Received: ("Tessian outbound 2877e54fe176:v113"); Tue, 01 Mar 2022 07:51:45 +0000 Received: from 2aaf19191ac2.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 1D1EA542-7B9F-456D-8F5B-D1850E50406A.1; Tue, 01 Mar 2022 07:51:40 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 2aaf19191ac2.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 01 Mar 2022 07:51:40 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by AM6PR08MB4915.eurprd08.prod.outlook.com (2603:10a6:20b:d1::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Tue, 1 Mar 2022 07:51:37 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::89b3:80a2:2b58:f1aa]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::89b3:80a2:2b58:f1aa%4]) with mapi id 15.20.5017.026; Tue, 1 Mar 2022 07:51:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 72c21693-9934-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1k7x/cYgaPUySUmfzVK0xBj/MVX1hPGBYj1VLlHEIO8=; b=UOKl23gPV4ppJNLHBNdmq+OjxoRPRWVR1xsjt9XLfUZN7sKdTzqL3WGCLqHdLei6Q4V2Zmq/o/zsGe1yIp++wF+kiE8yK0cmPQRASebB7PcOI25HxnftbNUgbrAJtNs4YwG5nrZGOP4l69/BBA76FRu3vLitJppplBxD45k1CPU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gmETMUQjSewEEA3HEzGaebLeRPlYYga3eOFeeSJNJViVZ1fRQp6Z8vxK9qLWmXS71QA1FhIpzfxXeon0SI89IxJkKfXfN2V5WVPU8EiwcHI8pRLsxYfUMCPk/6anZBwpkPniSnAD2UaYujGK3FXaZLOeE0z5P9XS6NuNZYCNl2vN39mqg0U8eyWm86y+Nr3szsSwZV0yPY1X5S6gMLuQH06GfMvfQyfpLwtEMK+aP12E/kMOtmZs/JcU3FCyrfsvnc1WU+kmu3GaEw2zeoxuKHDd15eyXPlF8OVWY0Rxo28e2bvZcWpBOoHb5Z8a9T0cbKtYOkSL4qncQfy7fQ6wNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1k7x/cYgaPUySUmfzVK0xBj/MVX1hPGBYj1VLlHEIO8=; b=EKVSld7n4iAcV4902r7w9H9OpYkkLTxHfENE4bEMmk1qRXF6jWysvpRYLNUGWJsQUBtkQFa4aT5g8WlY29YUDvhXX0UcafJkxHavAavCiEpEF+S7yxQkbMvzRAFFuGk6RiEooxcrUGYEuXrZxhBqFz/T8mf1id0WUgskqJGwwoEJM2dTeCUOavJseqDMZnCEWDNS0apTn0jvp+pokY3DQV8RQuMYZ//D4ROekeyh4aT14ARDdPiWge4mpycbl4lpb7VEmHqJl+finDvVGQamZ19zaTVopUuyB075viDtfDebpaFWmA4dOeRPddTUWT/bTlCeUAotEPxWSqUCJKgW+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1k7x/cYgaPUySUmfzVK0xBj/MVX1hPGBYj1VLlHEIO8=; b=UOKl23gPV4ppJNLHBNdmq+OjxoRPRWVR1xsjt9XLfUZN7sKdTzqL3WGCLqHdLei6Q4V2Zmq/o/zsGe1yIp++wF+kiE8yK0cmPQRASebB7PcOI25HxnftbNUgbrAJtNs4YwG5nrZGOP4l69/BBA76FRu3vLitJppplBxD45k1CPU= From: Wei Chen To: Julien Grall , "xen-devel@lists.xenproject.org" , Stefano Stabellini CC: Bertrand Marquis , Penny Zheng , Henry Wang , nd Subject: RE: Proposal for Porting Xen to Armv8-R64 - DraftA Thread-Topic: Proposal for Porting Xen to Armv8-R64 - DraftA Thread-Index: AdgpQxtXwh7LkfydTgiYk9bhMgU+ogBRt1sAAKse4VA= Date: Tue, 1 Mar 2022 07:51:36 +0000 Message-ID: References: <04db7e8b-2f04-41d7-1deb-d8bda3625c04@xen.org> In-Reply-To: <04db7e8b-2f04-41d7-1deb-d8bda3625c04@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 20E8AC47A67ABE478EB4DE472D17A861.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 5ece9a0a-eb84-4f01-9ee6-08d9fb585536 x-ms-traffictypediagnostic: AM6PR08MB4915:EE_|DB5EUR03FT044:EE_|AM0PR08MB3668:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: c7GAjmy9T9JiOXejFHJp1kwmEXptHJWBbdWoheMCO5RSg0mqZ841Wtu+IXBgoMOampaAJOx6IgwwOkqKaKOQr483zX6aVqNrg9eOyiDo3S1Pqta1ITqcAhv6xj2ILb6SvC9ju+Mg29TJjwWrhXUZVZDLwg5MfBGAfNMwsJNCVfbWg+VNP4VKQ7kLBaaGwBcAGybLnxg71p5pOwkThU5l8USn8tqlQMXKcxhKm6wR+jrGziT9erkyJM39wzERFIdWOJhSyIexYVWK+lFoNZBdjwQ27v/7tJlaiAOYBqgIE3xhlkR5hQ3UvJVKSqc8OHQLtF20qZK3Tdy2K3rreTY6aP0vO9BEWtVebEOeEYvny4jB2zgguEZJt5Hhp1LxNFB43ugzNm3vMiU74didsigiZE4gP8SV3m439PB1Kyvud+40Z8q8Lu72OVvlbpoC18JuhYoy6blFuEKBeDUnIi5vzJY2BAeMOsE3/KPJFzhqBLr8JCLO391AVfzMe64QjOtPpxbmRXJOgurUMnVBfEoMQIzK+OrUNSXAwLmx20BLWKUW2emt0PXrWEX2o+a4zoz0UxGgWBaVBZDSKjpnukaeWq6akm/9LihPiHZMRLZqkFhQroF83ywZkVoWMgd7fflS/wvzldaXmSz+bbwQe91QktuF5Miua3qmFXgBwzdp7oRafYDFyGsCpXrUTaDsKVuChUvUTERykmT4UxK9VC/mgJhJfIUVdX/gXmPj1g322Ro1p/vsUBsyERfahjk5btMLi4XJuzkgD94GVmcnK8/c/b6FWKFWio22OQbkWUxREUw= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(83380400001)(186003)(26005)(9686003)(7696005)(6506007)(53546011)(71200400001)(508600001)(110136005)(54906003)(66446008)(55016003)(8676002)(76116006)(30864003)(5660300002)(8936002)(66476007)(64756008)(52536014)(4326008)(66946007)(2906002)(122000001)(66556008)(316002)(33656002)(86362001)(38070700005)(38100700002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4915 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT044.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: edce8ab5-ac02-417d-723c-08d9fb585024 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3i9dSxNRSQrNbIvoMY/SvDqS+r6Oob+rnkCmLrLUe9j+SDKRxcOtKV5X82t8jwZarM8PVt14NStb+mwbcAnG38FQ87iIbE5FSVK7H/pbupvANugR90wI51CaAXCHCXbUMk9KSdOZaMr/ZZjJTW2JrjY+p8YEJlprmAq3WuqaObYsQKzc5QMm5YX94ZnXpNR3MBe9D8GYroH3heQm7L73bdgMwFdLUtO+I9VC+AUVnOAO2dhEFLbA3yzbsi7BKIYWCTA/ZBrAcNEqzqrTpf0IVP/e+IUZ84VPrl2gZUEHUzQ9m1Y+WTydUbe9loPTISks7kwfZTHHY5XVVA9/4heUKu6dRka2UpdejBSd+vPYZ1U4ewY/G+ZkgmU3ECU8t3uDQx9f6wPpTMkIl3hI2b5QslcszqywMe3mYKT9xfxMf9kOVl7FADd3OFQ8WT7RYuHiTlfKtKGN3aWlf1yIDZv2O2FqUo2PHJftJ8llCO/JFPhra4kAjhMQk0f449MB/0cOFkIorRCjRwoKJ/fKCz+fC47risDs6lz7vnkF/YD8DrGnnhWw2MrzK7dddodkODBIl2tEu0ZcNRZQMxL9iI2cMbTfu2dLitsxc9wMLJHygn5YV1+Yjob95jDUzAt8d4FHU73BodUDbd4jOe7UH8pmmqkeGfGT57oi74KjfJ5y4EZ51zVtQ9MGdpDFhGwo8jHx6fRVSgSSOOM/i6unshW4Tq33KdXpJy0dcpRiUIhaneRzaQcFCOZ3VpdM9IWnGXZ028uvqrl5wOOswIBM93hmAg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(55016003)(36860700001)(8936002)(40460700003)(33656002)(52536014)(70206006)(70586007)(8676002)(4326008)(316002)(54906003)(53546011)(508600001)(86362001)(9686003)(6506007)(7696005)(110136005)(83380400001)(356005)(81166007)(336012)(26005)(186003)(5660300002)(2906002)(30864003)(82310400004)(47076005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2022 07:51:45.4816 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5ece9a0a-eb84-4f01-9ee6-08d9fb585536 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT044.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3668 SGkgSnVsaWVuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEp1bGll biBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+IFNlbnQ6IDIwMjLlubQy5pyIMjbml6UgNDo1NQ0K PiBUbzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+OyB4ZW4tZGV2ZWxAbGlzdHMueGVucHJv amVjdC5vcmc7IFN0ZWZhbm8NCj4gU3RhYmVsbGluaSA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz4N Cj4gQ2M6IEJlcnRyYW5kIE1hcnF1aXMgPEJlcnRyYW5kLk1hcnF1aXNAYXJtLmNvbT47IFBlbm55 IFpoZW5nDQo+IDxQZW5ueS5aaGVuZ0Bhcm0uY29tPjsgSGVucnkgV2FuZyA8SGVucnkuV2FuZ0Bh cm0uY29tPjsgbmQgPG5kQGFybS5jb20+DQo+IFN1YmplY3Q6IFJlOiBQcm9wb3NhbCBmb3IgUG9y dGluZyBYZW4gdG8gQXJtdjgtUjY0IC0gRHJhZnRBDQo+IA0KPiBIaSBXZWksDQo+IA0KPiBUaGFu ayB5b3UgZm9yIHNlbmRpbmcgdGhlIHByb3Bvc2FsLiBQbGVhc2UgZmluZCBzb21lIGNvbW1lbnRz IGJlbG93Lg0KPiANCj4gT24gMjQvMDIvMjAyMiAwNjowMSwgV2VpIENoZW4gd3JvdGU6DQo+ID4g IyBQcm9wb3NhbCBmb3IgUG9ydGluZyBYZW4gdG8gQXJtdjgtUjY0DQo+ID4NCj4gPiBUaGlzIHBy b3Bvc2FsIHdpbGwgaW50cm9kdWNlIHRoZSBQb0Mgd29yayBvZiBwb3J0aW5nIFhlbiB0byBBcm12 OC1SNjQsDQo+ID4gd2hpY2ggaW5jbHVkZXM6DQo+ID4gLSBUaGUgY2hhbmdlcyBvZiBjdXJyZW50 IFhlbiBjYXBhYmlsaXR5LCBsaWtlIFhlbiBidWlsZCBzeXN0ZW0sIG1lbW9yeQ0KPiA+ICAgIG1h bmFnZW1lbnQsIGRvbWFpbiBtYW5hZ2VtZW50LCB2Q1BVIGNvbnRleHQgc3dpdGNoLg0KPiA+IC0g VGhlIGV4cGFuZGVkIFhlbiBjYXBhYmlsaXR5LCBsaWtlIHN0YXRpYy1hbGxvY2F0aW9uIGFuZCBk aXJlY3QtbWFwLg0KPiA+DQo+ID4gKioqTm90ZXM6KioqDQo+ID4gMS4gKioqVGhpcyBwcm9wb3Nh bCBvbmx5IGNvdmVycyB0aGUgd29yayBvZiBwb3J0aW5nIFhlbiB0byBBcm12OC1SNjQqKioNCj4g PiAgICAgKioqc2luZ2xlIENQVS4gWGVuIFNNUCBzdXBwb3J0IG9uIEFybXY4LVI2NCByZWxhdGVz IHRvIEFybXY4LVIqKioNCj4gPiAgICAgKioqVHJ1c3RlZC1Gcmltd2FyZSAoVEYtUikuIFRoaXMg aXMgYW4gZXh0ZXJuYWwgZGVwZW5kZW5jeSwqKioNCj4gPiAgICAgKioqc28gd2UgdGhpbmsgdGhl IGRpc2N1c3Npb24gb2YgWGVuIFNNUCBzdXBwb3J0IG9uIEFybXY4LVI2NCoqKg0KPiA+ICAgICAq KipzaG91bGQgYmUgc3RhcnRlZCB3aGVuIHNpbmdsZS1DUFUgc3VwcG9ydCBpcyBjb21wbGV0ZS4q KioNCj4gDQo+IEkgYWdyZWUgdGhhdCB3ZSBzaG91bGQgZmlyc3QgZm9jdXMgb24gc2luZ2xlLUNQ VSBzdXBwb3J0Lg0KPiANCg0KYWNrLg0KDQo+ID4gMi4gKioqVGhpcyBwcm9wb3NhbCB3aWxsIG5v dCB0b3VjaCB4ZW4tdG9vbHMuIEluIGN1cnJlbnQgc3RhZ2UsKioqDQo+ID4gICAgICoqKlhlbiBv biBBcm12OC1SNjQgb25seSBzdXBwb3J0IGRvbTBsZXNzLCBhbGwgZ3Vlc3RzIHNob3VsZCoqKg0K PiA+ICAgICAqKipiZSBib290ZWQgZnJvbSBkZXZpY2UgdHJlZS4qKioNCj4gDQo+IE1ha2Ugc2Vu c2UuIEkgYWN0dWFsbHkgZXhwZWN0IHNvbWUgaXNzdWVzIGluIHRoZSB3YXkgeGVuLXRvb2xzIHdv dWxkDQo+IG5lZWQgdG8gYWNjZXNzIG1lbW9yeSBvZiB0aGUgZG9tYWluIHRoYXQgaXMgYmVlbiBj cmVhdGVkLg0KPiANCg0KWWVzLCB3ZSBhbHNvIGZlZWwgdGhhdCBjaGFuZ2VzIHRvIHhlbi10b29s cyBjb3VsZCBiZSBhIGJpZyBqb2IgaW4gdGhlDQpmdXR1cmUgKGJvdGggeGVuIGNvbW1vbiBpbXBs ZW1lbnRhdGlvbiBhbmQgdG9vbHMgbmVlZCBjaGFuZ2VzKS4gIA0KDQo+IFsuLi5dDQo+IA0KPiA+ ICMjIyAxLjIuIFhlbiBDaGFsbGVuZ2VzIHdpdGggUE1TQSBWaXJ0dWFsaXphdGlvbg0KPiA+IFhl biBpcyBQTVNBIHVuYXdhcmUgVHlwZS0xIEh5cGVydmlzb3IsIGl0IHdpbGwgbmVlZCBtb2RpZmlj YXRpb25zIHRvIHJ1bg0KPiA+IHdpdGggYW4gTVBVIGFuZCBob3N0IG11bHRpcGxlIGd1ZXN0IE9T ZXMuDQo+ID4NCj4gPiAtIE5vIE1NVSBhdCBFTDI6DQo+ID4gICAgICAtIE5vIEVMMiBTdGFnZSAx IGFkZHJlc3MgdHJhbnNsYXRpb24NCj4gPiAgICAgICAgICAtIFhlbiBwcm92aWRlcyBmaXhlZCBB Uk02NCB2aXJ0dWFsIG1lbW9yeSBsYXlvdXQgYXMgYmFzaXMgb2YNCj4gRUwyDQo+ID4gICAgICAg ICAgICBzdGFnZSAxIGFkZHJlc3MgdHJhbnNsYXRpb24sIHdoaWNoIGlzIG5vdCBhcHBsaWNhYmxl IG9uIE1QVQ0KPiBzeXN0ZW0sDQo+ID4gICAgICAgICAgICB3aGVyZSB0aGVyZSBpcyBubyB2aXJ0 dWFsIGFkZHJlc3NpbmcuIEFzIGEgcmVzdWx0LCBhbnkNCj4gb3BlcmF0aW9uDQo+ID4gICAgICAg ICAgICBpbnZvbHZpbmcgdHJhbnNpdGlvbiBmcm9tIFBBIHRvIFZBLCBsaWtlIGlvcmVtYXAsIG5l ZWRzDQo+IG1vZGlmaWNhdGlvbg0KPiA+ICAgICAgICAgICAgb24gTVBVIHN5c3RlbS4NCj4gPiAg ICAgIC0gWGVuJ3MgcnVuLXRpbWUgYWRkcmVzc2VzIGFyZSB0aGUgc2FtZSBhcyB0aGUgbGluayB0 aW1lIGFkZHJlc3Nlcy4NCj4gPiAgICAgICAgICAtIEVuYWJsZSBQSUMgKHBvc2l0aW9uLWluZGVw ZW5kZW50IGNvZGUpIG9uIGEgcmVhbC10aW1lIHRhcmdldA0KPiA+ICAgICAgICAgICAgcHJvY2Vz c29yIHByb2JhYmx5IHZlcnkgcmFyZS4NCj4gDQo+IEFzaWRlIHRoZSBhc3NlbWJseSBib290IGNv ZGUgYW5kIFVFRkkgc3R1YiwgWGVuIGFscmVhZHkgcnVucyBhdCB0aGUgc2FtZQ0KPiBhZGRyZXNz IGFzIGl0IHdhcyBsaW5rZWQuDQo+IA0KDQpCdXQgdGhlIGRpZmZlcmVuY2UgaXMgdGhhdCwgYmFz ZSBvbiBNTVUsIHdlIGNhbiB1c2UgdGhlIHNhbWUgbGluayBhZGRyZXNzDQpmb3IgYWxsIHBsYXRm b3Jtcy4gQnV0IG9uIE1QVSBzeXN0ZW0sIHdlIGNhbid0IGRvIGl0IGluIHRoZSBzYW1lIHdheS4N Cg0KPiA+ICAgICAgLSBYZW4gd2lsbCBuZWVkIHRvIHVzZSB0aGUgRUwyIE1QVSBtZW1vcnkgcmVn aW9uIGRlc2NyaXB0b3JzIHRvDQo+IG1hbmFnZQ0KPiA+ICAgICAgICBhY2Nlc3MgcGVybWlzc2lv bnMgYW5kIGF0dHJpYnV0ZXMgZm9yIGFjY2Vzc2VzIG1hZGUgYnkgVk1zIGF0DQo+IEVMMS8wLg0K PiA+ICAgICAgICAgIC0gWGVuIGN1cnJlbnRseSByZWxpZXMgb24gTU1VIEVMMSBzdGFnZSAyIHRh YmxlIHRvIG1hbmFnZSB0aGVzZQ0KPiA+ICAgICAgICAgICAgYWNjZXNzZXMuDQo+ID4gLSBObyBN TVUgU3RhZ2UgMiB0cmFuc2xhdGlvbiBhdCBFTDE6DQo+ID4gICAgICAtIEEgZ3Vlc3QgZG9lc24n dCBoYXZlIGFuIGluZGVwZW5kZW50IGd1ZXN0IHBoeXNpY2FsIGFkZHJlc3Mgc3BhY2UNCj4gPiAg ICAgIC0gQSBndWVzdCBjYW4gbm90IHJldXNlIHRoZSBjdXJyZW50IEludGVybWVkaWF0ZSBQaHlz aWNhbCBBZGRyZXNzDQo+ID4gICAgICAgIG1lbW9yeSBsYXlvdXQNCj4gPiAgICAgIC0gQSBndWVz dCB1c2VzIHBoeXNpY2FsIGFkZHJlc3NlcyB0byBhY2Nlc3MgbWVtb3J5IGFuZCBkZXZpY2VzDQo+ ID4gICAgICAtIFRoZSBNUFUgYXQgRUwyIG1hbmFnZXMgRUwxIHN0YWdlIDIgYWNjZXNzIHBlcm1p c3Npb25zIGFuZA0KPiBhdHRyaWJ1dGVzDQo+ID4gLSBUaGVyZSBhcmUgYSBsaW1pdGVkIG51bWJl ciBvZiBNUFUgcHJvdGVjdGlvbiByZWdpb25zIGF0IGJvdGggRUwyIGFuZA0KPiBFTDE6DQo+ID4g ICAgICAtIEFyY2hpdGVjdHVyYWxseSwgdGhlIG1heGltdW0gbnVtYmVyIG9mIHByb3RlY3Rpb24g cmVnaW9ucyBpcyAyNTYsDQo+ID4gICAgICAgIHR5cGljYWwgaW1wbGVtZW50YXRpb25zIGhhdmUg MzIuDQo+ID4gICAgICAtIEJ5IGNvbnRyYXN0LCBYZW4gZG9lcyBub3QgbmVlZCB0byBjb25zaWRl ciB0aGUgbnVtYmVyIG9mIHBhZ2UNCj4gdGFibGUNCj4gPiAgICAgICAgZW50cmllcyBpbiB0aGVv cnkgd2hlbiB1c2luZyBNTVUuDQo+ID4gLSBUaGUgTVBVIHByb3RlY3Rpb24gcmVnaW9ucyBhdCBF TDIgbmVlZCB0byBiZSBzaGFyZWQgYmV0d2VlbiB0aGUNCj4gaHlwZXJ2aXNvcg0KPiA+ICAgIGFu ZCB0aGUgZ3Vlc3Qgc3RhZ2UgMi4NCj4gPiAgICAgIC0gUmVxdWlyZXMgY2FyZWZ1bCBjb25zaWRl cmF0aW9uIC0gbWF5IGltcGFjdCBmZWF0dXJlICdmdWxsbmVzcycgb2YNCj4gYm90aA0KPiA+ICAg ICAgICB0aGUgaHlwZXJ2aXNvciBhbmQgdGhlIGd1ZXN0DQo+ID4gICAgICAtIEJ5IGNvbnRyYXN0 LCB3aGVuIHVzaW5nIE1NVSwgWGVuIGhhcyBzdGFuZGFsb25lIFAyTSB0YWJsZSBmb3INCj4gZ3Vl c3QNCj4gPiAgICAgICAgc3RhZ2UgMiBhY2Nlc3Nlcy4NCj4gDQo+IFsuLi5dDQo+IA0KPiA+IC0g KioqRGVmaW5lIG5ldyBzeXN0ZW0gcmVnaXN0ZXJzIGZvciBjb21waWxlcnMqKio6DQo+ID4gICAg QXJtdjgtUjY0IGlzIGJhc2VkIG9uIEFybXY4LjQuIFRoYXQgbWVhbnMgd2Ugd2lsbCB1c2Ugc29t ZSBBcm12OC40DQo+ID4gICAgc3BlY2lmaWMgc3lzdGVtIHJlZ2lzdGVycy4gQXMgQXJtdjgtUjY0 IG9ubHkgaGF2ZSBzZWN1cmUgc3RhdGUsIHNvDQo+ID4gICAgYXQgbGVhc3QsIGBWU1RDUl9FTDJg IGFuZCBgVlNDVExSX0VMMmAgd2lsbCBiZSB1c2VkIGZvciBYZW4uIEFuZCB0aGUNCj4gPiAgICBm aXJzdCBHQ0MgdmVyc2lvbiB0aGF0IHN1cHBvcnRzIEFybXY4LjQgaXMgR0NDIDguMS4gSW4gYWRk aXRpb24gdG8NCj4gPiAgICB0aGVzZSwgUE1TQSBvZiBBcm12OC1SNjQgaW50cm9kdWNlZCBsb3Rz IG9mIE1QVSByZWxhdGVkIHN5c3RlbQ0KPiByZWdpc3RlcnM6DQo+ID4gICAgYFBSQkFSX0VMeGAs IGBQUkJBUnhfRUx4YCwgYFBSTEFSX0VMeGAsIGBQUkxBUnhfRUx4YCwgYFBSRU5SX0VMeGAgYW5k DQo+ID4gICAgYE1QVUlSX0VMeGAuIEJ1dCB0aGUgZmlyc3QgR0NDIHZlcnNpb24gdG8gc3VwcG9y dCB0aGVzZSBzeXN0ZW0NCj4gcmVnaXN0ZXJzDQo+ID4gICAgaXMgR0NDIDExLiBTbyB3ZSBoYXZl IHR3byB3YXlzIHRvIG1ha2UgY29tcGlsZXJzIHRvIHdvcmsgcHJvcGVybHkNCj4gd2l0aA0KPiA+ ICAgIHRoZXNlIHN5c3RlbSByZWdpc3RlcnMuDQo+ID4gICAgMS4gQnVtcCBHQ0MgdmVyc2lvbiB0 byBHQ0MgMTEuDQo+ID4gICAgICAgVGhlIHByb3Mgb2YgdGhpcyBtZXRob2QgaXMgdGhhdCwgd2Ug ZG9uJ3QgbmVlZCB0byBlbmNvZGUgdGhlc2UNCj4gPiAgICAgICBzeXN0ZW0gcmVnaXN0ZXJzIGlu IG1hY3JvcyBieSBvdXJzZWx2ZXMuIEJ1dCB0aGUgY29ucyBhcmUgdGhhdCwNCj4gPiAgICAgICB3 ZSBoYXZlIHRvIHVwZGF0ZSBNYWtlZmlsZXMgdG8gc3VwcG9ydCBHQ0MgMTEgZm9yIEFybXY4LVI2 NC4NCj4gPiAgICAgICAxLjEuIENoZWNrIHRoZSBHQ0MgdmVyc2lvbiAxMSBmb3IgQXJtdjgtUjY0 Lg0KPiA+ICAgICAgIDEuMi4gQWRkIG1hcmNoPWFybXY4ciB0byBDRkxBR1MgZm9yIEFybXY4LVI2 NC4NCj4gPiAgICAgICAxLjMuIFNvbHZlIHRoZSBjb25mbGljdGlvbiBvZiBtYXJjaD1hcm12OHIg YW5kIG1jcHU9Z2VuZXJpYw0KPiA+ICAgICAgVGhlc2UgY2hhbmdlcyB3aWxsIGFmZmVjdCBjb21t b24gTWFrZWZpbGVzLCBub3Qgb25seSBBcm0gTWFrZWZpbGVzLg0KPiA+ICAgICAgQW5kIEdDQyAx MSBpcyBuZXcsIGxvdHMgb2YgdG9vbGNoYWlucyBhbmQgRGlzdHJvIGhhdmVuJ3Qgc3VwcG9ydGVk DQo+IGl0Lg0KPiANCj4gSSBhZ3JlZSB0aGF0IGZvcmNpbmcgdG8gdXNlIEdDQzExIGlzIG5vdCBh IGdvb2QgaWRlYS4gQnV0IEkgYW0gbm90IHN1cmUNCj4gdG8gdW5kZXJzdGFuZCB0aGUgcHJvYmxl bSB3aXRoIHRoZSAtbWFyY2g9Li4uLiBVbHRpbWF0ZWx5LCBzaG91bGRuJ3Qgd2UNCj4gYWltIHRv IGJ1aWxkIFhlbiBBUk12OC1SIHdpdGggLW1hcmNoPWFybXY4cj8NCj4gDQoNCkFjdHVhbGx5LCB3 ZSBoYWQgZG9uZSwgYnV0IHdlIHJldmVydGVkIGl0IGZyb20gUkZDIHBhdGNoIHNlcmllcy4gVGhl IHJlYXNvbg0KaGFzIGJlZW4gbGlzdGVkIGFib3ZlLiBCdXQgdGhhdCBpcyBub3QgdGhlIG1ham9y IHJlYXNvbi4gVGhlIG1haW4gcmVhc29uDQppcyB0aGF0Og0KQXJtdjgtUiBBQXJjaDY0IHN1cHBv cnRzIHRoZSBBNjQgSVNBIGluc3RydWN0aW9uIHNldCB3aXRoIHNvbWUgbW9kaWZpY2F0aW9uczoN ClJlZGVmaW5lcyBETUIsIERTQiwgYW5kIGFkZHMgYW4gREZCLiBCdXQgYWN0dWFsbHksIHRoZSBl bmNvZGluZ3Mgb2YgRE1CIGFuZA0KRFNCIGFyZSBzdGlsbCB0aGUgc2FtZSB3aXRoIEE2NC4gQW5k IERGQiBpcyBhIGFsaWFzIG9mIERTQiAjMTIuDQoNCkluIHRoaXMgY2FzZSwgd2UgZG9uJ3QgdGhp bmsgd2UgbmVlZCBhIG5ldyBhcmNoIGZsYWcgdG8gZ2VuZXJhdGUgbmV3DQppbnN0cnVjdGlvbnMg Zm9yIEFybXY4LVIuIEFuZCB3ZSBoYXZlIGRpc2N1c3NlZCB3aXRoIEFybSBrZXJuZWwgZ3V5cywg dGhleQ0Kd2lsbCBub3QgdXBkYXRlIHRoZSBidWlsZCBzeXN0ZW0gdG8gYnVpbGQgTGludXggdGhh dCB3aWxsIGJlIHJ1bm5pbmcgb24NCkFybXY4LVI2NCBFTDEgZWl0aGVyLg0KDQoNCj4gWy4uLl0N Cj4gDQo+ID4gIyMjICoqMi4yLiBDaGFuZ2VzIG9mIHRoZSBpbml0aWFsaXphdGlvbiBwcm9jZXNz KioNCj4gPiBJbiBnZW5lcmFsLCB3ZSBzdGlsbCBleHBlY3QgQXJtdjgtUjY0IGFuZCBBcm12OC1B NjQgdG8gaGF2ZSBhIGNvbnNpc3RlbnQNCj4gPiBpbml0aWFsaXphdGlvbiBwcm9jZXNzLiBJbiBh ZGRpdGlvbiB0byBzb21lIGFyY2hpdGVjdHVyZSBkaWZmZXJlbmNlcywNCj4gdGhlcmUNCj4gPiBp cyBubyBtb3JlIHRoYW4gcmV1c2FibGUgY29kZSB0aGF0IHdlIHdpbGwgZGlzdGluZ3Vpc2ggdGhy b3VnaA0KPiBDT05GSUdfQVJNX01QVQ0KPiA+IG9yIENPTkZJR19BUk02NF9WOFIuIFdlIHdhbnQg bW9zdCBvZiB0aGUgaW5pdGlhbGl6YXRpb24gY29kZSB0byBiZQ0KPiByZXVzYWJsZQ0KPiA+IGJl dHdlZW4gQXJtdjgtUjY0IGFuZCBBcm12OC1BNjQuDQo+ID4NCj4gPiAtIFdlIHdpbGwgcmV1c2Ug dGhlIG9yaWdpbmFsIGhlYWQucyBhbmQgc2V0dXAuYyBvZiBBcm0uIEJ1dCByZXBsYWNlIHRoZQ0K PiA+ICAgIE1NVSBhbmQgcGFnZSB0YWJsZSBvcGVyYXRpb25zIGluIHRoZXNlIGZpbGVzIHdpdGgg Y29uZmlndXJhdGlvbg0KPiBvcGVyYXRpb25zDQo+ID4gICAgZm9yIE1QVSBhbmQgTVBVIHJlZ2lv bnMuDQo+ID4NCj4gPiAtIFdlIHByb3ZpZGUgYSBib290LXRpbWUgTVBVIGNvbmZpZ3VyYXRpb24u IFRoaXMgTVBVIGNvbmZpZ3VyYXRpb24gd2lsbA0KPiA+ICAgIHN1cHBvcnQgWGVuIHRvIGZpbmlz aCBpdHMgaW5pdGlhbGl6YXRpb24uIEFuZCB0aGlzIGJvb3QtdGltZSBNUFUNCj4gPiAgICBjb25m aWd1cmF0aW9uIHdpbGwgcmVjb3JkIHRoZSBtZW1vcnkgcmVnaW9ucyB0aGF0IHdpbGwgYmUgcGFy c2VkIGZyb20NCj4gPiAgICBkZXZpY2UgdHJlZS4NCj4gPg0KPiA+ICAgIEluIHRoZSBlbmQgb2Yg WGVuIGluaXRpYWxpemF0aW9uLCB3ZSB3aWxsIHVzZSBhIHJ1bnRpbWUgTVBVDQo+IGNvbmZpZ3Vy YXRpb24NCj4gPiAgICB0byByZXBsYWNlIGJvb3QtdGltZSBNUFUgY29uZmlndXJhdGlvbi4gVGhl IHJ1bnRpbWUgTVBVIGNvbmZpZ3VyYXRpb24NCj4gd2lsbA0KPiA+ICAgIG1lcmdlIGFuZCByZW9y ZGVyIG1lbW9yeSByZWdpb25zIHRvIHNhdmUgbW9yZSBNUFUgcmVnaW9ucyBmb3IgZ3Vlc3RzLg0K PiA+ICAgICFbaW1nXShodHRwczovL2RyaXZlLmdvb2dsZS5jb20vdWM/ZXhwb3J0PXZpZXcmaWQ9 MXdURnlLMlhmVTNsVGxIMVBxUg0KPiBEb2FjUVZUd1V0V0lHVSkNCj4gPg0KPiA+IC0gRGVmZXIg c3lzdGVtIHVucGF1c2luZyBkb21haW4uDQo+ID4gICAgV2hlbiBYZW4gaW5pdGlhbGl6YXRpb24g aXMgYWJvdXQgdG8gZW5kLCBYZW4gdW5wYXVzZSBndWVzdHMgY3JlYXRlZA0KPiA+ICAgIGR1cmlu ZyBpbml0aWFsaXphdGlvbi4gQnV0IHRoaXMgd2lsbCBjYXVzZSBzb21lIGlzc3Vlcy4gVGhlIHVu cGF1c2UNCj4gPiAgICBhY3Rpb24gb2NjdXJzIGJlZm9yZSBmcmVlX2luaXRfbWVtb3J5LCBob3dl dmVyIHRoZSBydW50aW1lIE1QVQ0KPiBjb25maWd1cmF0aW9uDQo+ID4gICAgaXMgYnVpbHQgYWZ0 ZXIgZnJlZV9pbml0X21lbW9yeS4NCj4gDQo+IEkgd2FzIGhhbGYgZXhwZWN0aW5nIHRoYXQgZnJl ZV9pbml0X21lbW9yeSgpIHdvdWxkIG5vdCBiZSBjYWxsZWQgZm9yIFhlbg0KPiBBcm12OFIuDQo+ DQoNCldlIGhhZCBjYWxsZWQgZnJlZV9pbml0X21lbW9yeSBmb3IgWGVuIEFybXY4UiwgYnV0IGl0 IGRvZXNuJ3QgcmVhbGx5IG1lYW4NCm11Y2guIEFzIHdlIGhhdmUgc3RhdGljIGhlYXAsIHNvIHdl IGRvbid0IHJlY2xhaW0gaW5pdCBtZW1vcnkgdG8gaGVhcC4gQW5kDQp0aGlzIHJlY2xhaW1lZCBt ZW1vcnkgY291bGQgbm90IGJlIHVzZWQgYnkgWGVuIGRhdGEgYW5kIGJzcyBlaXRoZXIuIEJ1dA0K ZnJvbSB0aGUgc2VjdXJpdHkgcGVyc3BlY3RpdmUsIGZyZWVfaW5pdF9tZW1vcnkgd2lsbCBkcm9w IHRoZSBYZW4gaW5pdA0KY29kZSAmIGRhdGEsIHRoaXMgd2lsbCByZWR1Y2UgdGhlIGNvZGUgYW4g YXR0YWNrZXIgY2FuIGV4cGxvaXQuDQoNCj4gPg0KPiA+ICAgIFNvIGlmIHRoZSB1bnBhdXNlZCBn dWVzdHMgc3RhcnQgZXhlY3V0aW5nIHRoZSBjb250ZXh0IHN3aXRjaCBhdCB0aGlzDQo+ID4gICAg cG9pbnQsIHRoZW4gaXRzIE1QVSBjb250ZXh0IHdpbGwgYmFzZSBvbiB0aGUgYm9vdC10aW1lIE1Q VQ0KPiBjb25maWd1cmF0aW9uLg0KPiANCj4gQ2FuIHlvdSBleHBsYWluIHdoeSB5b3Ugd2FudCB0 byBzd2l0Y2ggdGhlIE1QVSBjb25maWd1cmF0aW9uIHRoYXQgbGF0ZT8NCj4gDQoNCkluIHRoZSBi b290IHN0YWdlLCBYZW4gaXMgdGhlIG9ubHkgdXNlciBvZiBNUFUuIEl0IG1heSBhZGQgc29tZSBt ZW1vcnkNCm5vZGVzIG9yIGRldmljZSBtZW1vcnkgdG8gTVBVIHJlZ2lvbnMgZm9yIHRlbXBvcmFy eSB1c2FnZS4gQWZ0ZXIgZnJlZQ0KaW5pdCBtZW1vcnksIHdlIHdhbnQgdG8gcmVjbGFpbSB0aGVz ZSBNUFUgcmVnaW9ucyB0byBnaXZlIG1vcmUgTVBVIHJlZ2lvbnMNCmNhbiBiZSB1c2VkIGZvciBn dWVzdHMuIEFsc28gd2Ugd2lsbCBkbyBzb21lIG1lcmdlIGFuZCByZW9yZGVyIHdvcmsuIFRoaXMN CndvcmsgY2FuIG1ha2UgTVBVIHJlZ2lvbnMgdG8gYmUgZWFzaWVyIG1hbmFnZWQgaW4gZ3Vlc3Qg Y29udGV4dCBzd2l0Y2guDQoNCj4gPiAgICBQcm9iYWJseSBpdCB3aWxsIGJlIGluY29uc2lzdGVu dCB3aXRoIHJ1bnRpbWUgTVBVIGNvbmZpZ3VyYXRpb24sIHRoaXMNCj4gPiAgICB3aWxsIGNhdXNl IHVuZXhwZWN0ZWQgcHJvYmxlbXMgKFRoaXMgbWF5IG5vdCBoYXBwZW4gaW4gYSBzaW5nbGUgY29y ZQ0KPiA+ICAgIHN5c3RlbSwgYnV0IG9uIFNNUCBzeXN0ZW1zLCB0aGlzIHByb2JsZW0gaXMgZm9y ZXNlZWFibGUsIHNvIHdlIGhvcGUNCj4gdG8NCj4gPiAgICBzb2x2ZSBpdCBhdCB0aGUgYmVnaW5u aW5nKS4NCj4gDQo+IFsuLi5dDQo+IA0KPiA+ICMjIyAqKjIuNC4gQ2hhbmdlcyBvZiBtZW1vcnkg bWFuYWdlbWVudCoqDQo+ID4gWGVuIGlzIGNvdXBsZWQgd2l0aCBWTVNBLCBpbiBvcmRlciB0byBw b3J0IFhlbiB0byBBcm12OC1SNjQsIHdlIGhhdmUgdG8NCj4gPiBkZWNvdXBsZSBYZW4gZnJvbSBW TVNBLiBBbmQgZ2l2ZSBYZW4gdGhlIGFiaWxpdHkgdG8gbWFuYWdlIG1lbW9yeSBpbg0KPiBQTVNB Lg0KPiA+DQo+ID4gMS4gKioqVXNlIGJ1ZGR5IGFsbG9jYXRvciB0byBtYW5hZ2UgcGh5c2ljYWwg cGFnZXMgZm9yIFBNU0EqKioNCj4gPiAgICAgRnJvbSB0aGUgdmlldyBvZiBwaHlzaWNhbCBwYWdl LCBQTVNBIGFuZCBWTVNBIGRvbid0IGhhdmUgYW55DQo+IGRpZmZlcmVuY2UuDQo+ID4gICAgIFNv IHdlIGNhbiByZXVzZSBidWRkeSBhbGxvY2F0b3Igb24gQXJtdjgtUjY0IHRvIG1hbmFnZSBwaHlz aWNhbA0KPiBwYWdlcy4NCj4gPiAgICAgVGhlIGRpZmZlcmVuY2UgaXMgdGhhdCwgaW4gVk1TQSwg WGVuIHdpbGwgbWFwIGFsbG9jYXRlZCBwYWdlcyB0bw0KPiB2aXJ0dWFsDQo+ID4gICAgIGFkZHJl c3Nlcy4gQnV0IGluIFBNU0EsIFhlbiBqdXN0IGNvbnZlcnQgdGhlIHBhZ2VzIHRvIHBoeXNpY2Fs DQo+IGFkZHJlc3MuDQo+ID4NCj4gPiAyLiAqKipDYW4gbm90IHVzZSB2aXJ0dWFsIGFkZHJlc3Mg Zm9yIG1lbW9yeSBtYW5hZ2VtZW50KioqDQo+ID4gICAgIEFzIEFybXY4LVI2NCBvbmx5IGhhcyBQ TVNBIGluIEVMMiwgWGVuIGxvc2VzIHRoZSBhYmlsaXR5IG9mIHVzaW5nDQo+IHZpcnR1YWwNCj4g PiAgICAgYWRkcmVzcyB0byBtYW5hZ2UgbWVtb3J5LiBUaGlzIGJyaW5ncyBzb21lIHByb2JsZW1z LCBzb21lIHZpcnR1YWwNCj4gYWRkcmVzcw0KPiA+ICAgICBiYXNlZCBmZWF0dXJlcyBjb3VsZCBu b3Qgd29yayB3ZWxsIG9uIEFybXY4LVI2NCwgbGlrZSBgRklYTUFQYCwNCj4gYHZtYXAvdnVtYXBg LA0KPiA+ICAgICBgaW9yZW1hcGAgYW5kIGBhbHRlcm5hdGl2ZWAuDQo+ID4NCj4gPiAgICAgQnV0 IHRoZSBmdW5jdGlvbnMgb3IgbWFjcm9zIG9mIHRoZXNlIGZlYXR1cmVzIGFyZSB1c2VkIGluIGxv dHMgb2YNCj4gY29tbW9uDQo+ID4gICAgIGNvZGUuIFNvIGl0J3Mgbm90IGdvb2QgdG8gdXNlIGAj aWZkZWYgQ09ORklHX0FSTV9NUFVgIHRvIGdhdGUgcmVsYXRlDQo+IGNvZGUNCj4gPiAgICAgZXZl cnl3aGVyZS4gSW4gdGhpcyBjYXNlLCB3ZSBwcm9wb3NlIHRvIHVzZSBzdHViIGhlbHBlcnMgdG8g bWFrZSB0aGUNCj4gY2hhbmdlcw0KPiA+ICAgICB0cmFuc3BhcmVudGx5IHRvIGNvbW1vbiBjb2Rl Lg0KPiA+ICAgICAxLiBGb3IgYEZJWE1BUGAsIHdlIHdpbGwgdXNlIGAwYCBpbiBgRklYTUFQX0FE RFJgIGZvciBhbGwgZml4bWFwDQo+IG9wZXJhdGlvbnMuDQo+ID4gICAgICAgIFRoaXMgd2lsbCBy ZXR1cm4gcGh5c2ljYWwgYWRkcmVzcyBkaXJlY3RseSBvZiBmaXhtYXBwZWQgaXRlbS4NCj4gPiAg ICAgMi4gRm9yIGB2bWFwL3Z1bWFwYCwgd2Ugd2lsbCB1c2Ugc29tZSBlbXB0eSBpbmxpbmUgc3R1 YiBoZWxwZXJzOg0KPiA+ICAgICAgICAgIGBgYA0KPiA+ICAgICAgICAgIHN0YXRpYyBpbmxpbmUg dm9pZCB2bV9pbml0X3R5cGUoLi4uKSB7fQ0KPiA+ICAgICAgICAgIHN0YXRpYyBpbmxpbmUgdm9p ZCAqX192bWFwKC4uLikNCj4gPiAgICAgICAgICB7DQo+ID4gICAgICAgICAgICAgIHJldHVybiBO VUxMOw0KPiA+ICAgICAgICAgIH0NCj4gPiAgICAgICAgICBzdGF0aWMgaW5saW5lIHZvaWQgdnVu bWFwKGNvbnN0IHZvaWQgKnZhKSB7fQ0KPiA+ICAgICAgICAgIHN0YXRpYyBpbmxpbmUgdm9pZCAq dm1hbGxvYyhzaXplX3Qgc2l6ZSkNCj4gPiAgICAgICAgICB7DQo+ID4gICAgICAgICAgICAgIHJl dHVybiBOVUxMOw0KPiA+ICAgICAgICAgIH0NCj4gPiAgICAgICAgICBzdGF0aWMgaW5saW5lIHZv aWQgKnZtYWxsb2NfeGVuKHNpemVfdCBzaXplKQ0KPiA+ICAgICAgICAgIHsNCj4gPiAgICAgICAg ICAgICAgcmV0dXJuIE5VTEw7DQo+ID4gICAgICAgICAgfQ0KPiA+ICAgICAgICAgIHN0YXRpYyBp bmxpbmUgdm9pZCB2ZnJlZSh2b2lkICp2YSkge30NCj4gPiAgICAgICAgICBgYGANCj4gPg0KPiA+ ICAgICAzLiBGb3IgYGlvcmVtYXBgLCBpdCBkZXBlbmRzIG9uIGB2bWFwYC4gQXMgd2UgaGF2ZSBt YWtlIGB2bWFwYCB0bw0KPiBhbHdheXMNCj4gPiAgICAgICAgcmV0dXJuIGBOVUxMYCwgdGhleSBj b3VsZCBub3Qgd29yayB3ZWxsIG9uIEFybXY4LVI2NCB3aXRob3V0DQo+IGNoYW5nZXMuDQo+ID4g ICAgICAgIGBpb3JlbWFwYCB3aWxsIHJldHVybiBpbnB1dCBhZGRyZXNzIGRpcmVjdGx5Lg0KPiA+ ICAgICAgICAgIGBgYA0KPiA+ICAgICAgICAgIHN0YXRpYyBpbmxpbmUgdm9pZCAqaW9yZW1hcF9h dHRyKC4uLikNCj4gPiAgICAgICAgICB7DQo+ID4gICAgICAgICAgICAgIC8qIFdlIGRvbid0IGhh dmUgdGhlIGFiaWxpdHkgdG8gY2hhbmdlIGlucHV0IFBBIGNhY2hlDQo+IGF0dHJpYnV0ZXMgKi8N Cj4gT09JLCB3aG8gd2lsbCBzZXQgdGhlbT8NCg0KU29tZSBjYWxsZXJzIHRoYXQgd2FudCB0byBj aGFuZ2UgYSBtZW1vcnkncyBhdHRyaWJ1dGUgd2lsbCBzZXQgdGhlbS4gU29tZXRoaW5nIGxpa2UN CmlvcmVtYXBfbm9jYWNoZS4gSSBhbSBub3Qgc3VyZSBpcyB0aGlzIHdoYXQgeW91IGhhZCBhc2tl ZCA6ICkNCg0KPiANCj4gPiAgICAgICAgICAgICAgaWYgKCBDQUNIRV9BVFRSX25lZWRfY2hhbmdl ICkNCj4gPiAgICAgICAgICAgICAgICAgIHJldHVybiBOVUxMOw0KPiA+ICAgICAgICAgICAgICBy ZXR1cm4gKHZvaWQgKilwYTsNCj4gPiAgICAgICAgICB9DQo+ID4gICAgICAgICAgc3RhdGljIGlu bGluZSB2b2lkIF9faW9tZW0gKmlvcmVtYXBfbm9jYWNoZSguLi4pDQo+ID4gICAgICAgICAgew0K PiA+ICAgICAgICAgICAgICByZXR1cm4gaW9yZW1hcF9hdHRyKHN0YXJ0LCBsZW4sIFBBR0VfSFlQ RVJWSVNPUl9OT0NBQ0hFKTsNCj4gPiAgICAgICAgICB9DQo+ID4gICAgICAgICAgc3RhdGljIGlu bGluZSB2b2lkIF9faW9tZW0gKmlvcmVtYXBfY2FjaGUoLi4uKQ0KPiA+ICAgICAgICAgIHsNCj4g PiAgICAgICAgICAgICAgcmV0dXJuIGlvcmVtYXBfYXR0cihzdGFydCwgbGVuLCBQQUdFX0hZUEVS VklTT1IpOw0KPiA+ICAgICAgICAgIH0NCj4gPiAgICAgICAgICBzdGF0aWMgaW5saW5lIHZvaWQg X19pb21lbSAqaW9yZW1hcF93YyguLi4pDQo+ID4gICAgICAgICAgew0KPiA+ICAgICAgICAgICAg ICByZXR1cm4gaW9yZW1hcF9hdHRyKHN0YXJ0LCBsZW4sIFBBR0VfSFlQRVJWSVNPUl9XQyk7DQo+ ID4gICAgICAgICAgfQ0KPiA+ICAgICAgICAgIHZvaWQgKmlvcmVtYXAoLi4uKQ0KPiA+ICAgICAg ICAgIHsNCj4gPiAgICAgICAgICAgICAgcmV0dXJuIGlvcmVtYXBfYXR0cihwYSwgbGVuLCBQQUdF X0hZUEVSVklTT1JfTk9DQUNIRSk7DQo+ID4gICAgICAgICAgfQ0KPiA+DQo+ID4gICAgICAgICAg YGBgDQo+ID4gICAgICA0LiBGb3IgYGFsdGVybmF0aXZlYCwgaXQgZGVwZW5kcyBvbiBgdm1hcGAg dG9vLg0KPiANCj4gVGhlIG9ubHkgcmVhc29uIHdlIGRlcGVuZCBvbiB2bWFwKCkgaXMgYmVjYXVz ZSB0aGUgbWFwIHRoZSBzZWN0aW9ucw0KPiAqdGV4dCByZWFkLW9ubHkgYW5kIHdlIGVuZm9yY2Ug V25YLiBGb3IgVk1TQSwgaXQgd291bGQgYmUgcG9zc2libGUgdG8NCj4gYXZvaWQgdm1hcCgpIHdp dGggc29tZSByZXdvcmsuIEkgZG9uJ3Qga25vdyBmb3IgUE1TQS4NCj4gDQoNCkZvciBQTVNBLCB3 ZSBzdGlsbCBlbmZvcmNlIFduWC4gRm9yIHlvdXIgdXNlIGNhc2UsIEkgYXNzdW1lIGl0J3MgYWx0 ZXJuYXRpdmUuDQpJdCBzdGlsbCBtYXkgaGF2ZSBzb21lIHBvc3NpYmlsaXR5IHRvIGF2b2lkIHZt YXAoKS4gQnV0IHRoZXJlIG1heSBiZSBzb21lDQpzZWN1cml0eSBpc3N1ZXMuIFdlIGhhZCB0aG91 Z2h0IHRvIGRpc2FibGUgTVBVIC0+IHVwZGF0ZSB4ZW4gdGV4dCAtPiBlbmFibGUNCk1QVSB0byBj b3B5IFZNU0EgYWx0ZXJuYXRpdmUncyBiZWhhdmlvci4gVGhlIHByb2JsZW0gd2l0aCB0aGlzLCBo b3dldmVyLA0KaXMgdGhhdCBhdCBzb21lIHBvaW50LCBhbGwgbWVtb3J5IGlzIFJXWC4gVGhlcmUg bWF5YmUgc29tZSBzZWN1cml0eSByaXNrLg0KQnV0IGJlY2F1c2UgaXQncyBpbiBpbml0IHN0YWdl LCBpdCBwcm9iYWJseSBkb2Vzbid0IG1hdHRlciBhcyBtdWNoIGFzIEkgdGhvdWdodC4NCg0KPiA+ IFdlIHdpbGwgc2ltcGx5IGRpc2FibGUNCj4gPiAgICAgICAgIGl0IG9uIEFybXY4LVI2NCBpbiBj dXJyZW50IHN0YWdlLiBIb3cgdG8gaW1wbGVtZW50IGBhbHRlcm5hdGl2ZWANCj4gPiAgICAgICAg IG9uIEFybXY4LVI2NCBpcyBiZXR0ZXIgdG8gYmUgZGlzY3Vzc2VkIGFmdGVyIGJhc2ljIGZ1bmN0 aW9ucyBvZg0KPiBYZW4NCj4gPiAgICAgICAgIG9uIEFybXY4LVI2NCB3b3JrIHdlbGwuDQo+IGFs dGVybmF0aXZlIGFyZSBtb3N0bHkgaGVscGZ1bCB0byBoYW5kbGUgZXJyYXRhIG9yIGVuYWJsZSBm ZWF0dXJlcyB0aGF0DQo+IGFyZSBub3QgcHJlc2VudCBvbiBhbGwgQ1BVcy4gSSB3b3VsZG4ndCBl eHBlY3QgdGhpcyB0byBiZSBuZWNlc3NhcnkgYXQNCj4gdGhlIGJlZ2lubmluZy4gSW4gZmFjdCwg b24gQXJtLCBpdCB3YXMgaW50cm9kdWNlZCA+IDQgeWVhcnMgYWZ0ZXIgdGhlDQo+IGluaXRpYWwg cG9ydCA6KS4NCg0KSSBob3BlIGl0IHdvbid0IHRha2UgdXMgc28gbG9uZywgdGhpcyB0aW1lIDog KQ0KDQo+IA0KPiBbLi4uXQ0KPiANCj4gPiAjIyMgKioyLjUuIENoYW5nZXMgb2YgZGV2aWNlIGRy aXZlcioqDQo+ID4gMS4gQmVjYXVzZSBBcm12OC1SNjQgb25seSBoYXMgc2luZ2xlIHNlY3VyZSBz dGF0ZSwgdGhpcyB3aWxsIGFmZmVjdCBzb21lDQo+ID4gZGV2aWNlcyB0aGF0IGhhdmUgdHdvIHNl Y3VyZSBzdGF0ZSwgbGlrZSBHSUMuIEJ1dCBmb3J0dW5hdGVseSwgbW9zdA0KPiA+IHZlbmRvcnMg d2lsbCBub3QgbGluayBhIHR3byBzZWN1cmUgc3RhdGUgR0lDIHRvIEFybXY4LVI2NCBwcm9jZXNz b3JzLg0KPiA+IEN1cnJlbnQgR0lDIGRyaXZlciBjYW4gd29yayB3ZWxsIHdpdGggc2luZ2xlIHNl Y3VyZSBzdGF0ZSBHSUMgZm9yIEFybXY4LQ0KPiBSNjQuDQo+ID4gMi4gWGVuIHNob3VsZCB1c2Ug c2VjdXJlIGh5cGVydmlzb3IgdGltZXIgaW4gU2VjdXJlIEVMMi4gV2Ugd2lsbA0KPiBpbnRyb2R1 Y2UNCj4gPiBhIENPTkZJR19BUk1fU0VDVVJFX1NUQVRFIHRvIG1ha2UgWGVuIHRvIHVzZSBzZWN1 cmUgcmVnaXN0ZXJzIGZvciB0aW1lci4NCj4gPg0KPiA+ICMjIyAqKjIuNy4gQ2hhbmdlcyBvZiB2 aXJ0dWFsIGRldmljZSoqDQo+ID4gQ3VycmVudGx5LCB3ZSBvbmx5IHN1cHBvcnQgcGFzcy10aHJv dWdoIGRldmljZXMgaW4gZ3Vlc3QuIEJlY2F1c2UgZXZlbnQNCj4gPiBjaGFubmVsLCB4ZW4tYnVz LCB4ZW4tc3RvcmFnZSBhbmQgb3RoZXIgYWR2YW5jZWQgWGVuIGZlYXR1cmVzIGhhdmVuJ3QNCj4g YmVlbg0KPiA+IGVuYWJsZWQgaW4gQXJtdjgtUjY0Lg0KPiANCj4gVGhhdCdzIGZpbmUuIEkgZXhw ZWN0IHRvIHJlcXVpcmUgcXVpdGUgYSBiaXQgb2Ygd29yayB0byBtb3ZlIGZyb20gWGVuDQo+IHNo YXJpbmcgdGhlIHBhZ2VzIChlLmcuIGxpa2UgZm9yIGdyYW50LXRhYmxlcykgdG8gdGhlIGd1ZXN0 IHNoYXJpbmcgcGFnZXMuDQo+IA0KDQpZZXMuDQoNCj4gQ2hlZXJzLA0KPiANCj4gLS0NCj4gSnVs aWVuIEdyYWxsDQo= From xen-devel-bounces@lists.xenproject.org Tue Mar 01 07:52:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 07:52:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.280913.479035 (Exim 4.92) (envelope-from ) id 1nOxIm-0006mT-I9; Tue, 01 Mar 2022 07:52:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 280913.479035; Tue, 01 Mar 2022 07:52:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOxIm-0006mM-DU; Tue, 01 Mar 2022 07:52:08 +0000 Received: by outflank-mailman (input) for mailman id 280913; Tue, 01 Mar 2022 07:52:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOxIl-0006ld-8i for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 07:52:07 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7d272ff7-9934-11ec-8eba-a37418f5ba1a; Tue, 01 Mar 2022 08:52:06 +0100 (CET) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05lp2176.outbound.protection.outlook.com [104.47.17.176]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-3-htxtqibZOoq286GUjLQHMA-1; Tue, 01 Mar 2022 08:52:04 +0100 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by HE1PR04MB3291.eurprd04.prod.outlook.com (2603:10a6:7:18::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.25; Tue, 1 Mar 2022 07:52:02 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.027; Tue, 1 Mar 2022 07:52:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7d272ff7-9934-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1646121125; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VLudaqPC+mCohs93HfhPPRfaG0gLzOtM22zh6VYWIkg=; b=TMrZNbVeat9gfkvuId9PjB7xTZ9LRFJdrhLugCwcVq/R3Rj2m52L097GZ+vOIdtOKmj9uf gLFVmvH+BrLcFqbhuklurX8K72mBGQHuaYqLjlKU1tglkvrP2Us4mM+xyUdLpWt9WHxtvK 5InHwgyhNW+Z+DEEkZcKH0bxF2rWxzk= X-MC-Unique: htxtqibZOoq286GUjLQHMA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AUwYcfMPFSPe5WxHopN9BPGSwUmi92vgdGAg3v3nBwbMNpIes2l3d5bdc1qRGJ279QLFXgW9tA+ZUnNF5kw48LxWZtKkeMb4034KeuGfhZZV/ggDdIqyXvYCCzibUumSjwulVM+E5W2jEeneqtwveKnFAMPzSbeWW//YjGky5a7+26sc4tHNa/D4sfDERGI6hxFyXJKYb3a8AyVf9aP+LBqUvrvzBJOYtN1uzbIviC/uIBfdjykjia1m43xN0zLvucClMxPtriWUabRNXR7Sehe/s38fRZIBankUHi5eFMhDLORPEi44H/wKKtrO7S3hcnm3O6pMkb1iQgNcTUKxvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tuidF6oeap9VolvoBduf0nkrdW2xCpxFD1bQiL7eRuY=; b=KtxbB3h9/dNccqlAN6W7ME9sL6yymQruaER2Fzs8H/09UGGfsap8tw9wE9ArIjgK9xK7fxb6orkDj6njClJt9UgmNilKoc7AfhpBczbIc4wmTDdpaVr6nVt16dsSKgcA/FeQe/2U6iRhyRRIjltRQp0JPXz1FDgCQr1NEIUerLgUSKWfdl8KcR9LquAZVMtfTuUQQw85y34xlxoDLHWI90il+BAYdcLLTl6Iyg0adTRRoz7Qw3mTxgp1vMf+hMhsIaoT2ro+ErXUZcBIyMSuDqxqleg1V0oS6p+/8imTl0zNviJKsAK8jcCfyaUiS8uiKYnpV5Ag36hE6MUFgb9hMA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <60bcd74d-5686-9813-e3a6-b28c15b66a22@suse.com> Date: Tue, 1 Mar 2022 08:51:59 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH v3 1/2] xen+tools: Report Interrupt Controller Virtualization capabilities on x86 Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: Jane Malalane , Wei Liu , Anthony PERARD , Juergen Gross , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis , Jun Nakajima , Kevin Tian , Xen-devel References: <20220218172943.12182-1-jane.malalane@citrix.com> <20220218172943.12182-2-jane.malalane@citrix.com> <0a31970c-c0f8-c995-ce04-67523a4a830a@suse.com> <9aff51c2-0e8c-685c-7bff-0ed7ff7347c7@suse.com> <6b59e3ea-01ff-e26c-02d4-3b11594fd7f0@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM5PR0701CA0072.eurprd07.prod.outlook.com (2603:10a6:203:2::34) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 996a3506-f20d-4be0-a4cb-08d9fb585f0d X-MS-TrafficTypeDiagnostic: HE1PR04MB3291:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0hRDOuerqSf+FqZxk31qvNN62t4Wfy3xfixX1Lqhsj+/zAUgJ92bqZ2tRvJeAua0naoBW3c3lcsV4lBB7uRGWS+lv8ErV8VaqugRZzB13KiJV8imZq0QnlTuV7WExjBbtpIt3ydcVWusedY1qxUeGwudXvJQFlMYnPxtVtfMTnOpTBAq1Ht/0fnOiYw8AcPbAwxg9RE+8ylGY3xvRFdFZqSgXdbQByPrnjG6Rabh2+dODhW6obZ3pwECsH8ZdUqd1OxuXWQAx7xRsgMoI8YFSZFT7FL2lNg5cnOf32i8WY+cTSx8dEBbD0RmMpmGkR322vhPBaWePeGawNSoxv5KzqA0ovmb09Bo1GLZQ6T7qPLykjliy9+5vGyHfV4D5KeCO6jZL9HQGfyO0afkBm/0EsKY4lzvr3C+dBVVqofVFx/AR1XAG9O/6wttGZ0fdp/6IG0q/wpSShbmopwgs5FQLNR0pI11TW4XySW1xd1koj6xdA0/+iumnbYJFmf7WFvQsB1E7oyi3gaeiRaf52NgKnJkcrv/eWfW6lcoTxU+pGrn6I0Zy1RZMmWLfJWkHjMWgVmsweR8uMwUtnHnthFBYirF3HZO+lR0kQCJubaAU2hKt2rnl7YEzCihl3Ol1vXV/fI3QZJBhRb+q1dhDUkNy3kEgIh6n/pO3MGr8WEBcCZ2n8LvWUPHVAav9tgYV69QFKzZM6Bj2TvjE8fySQeKX7vqRpDVimgaj5fDIsxAEMbB6slI3MNvubq6m5EpX0ch X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(4326008)(6486002)(2906002)(6506007)(6666004)(53546011)(508600001)(31686004)(38100700002)(36756003)(31696002)(86362001)(54906003)(8676002)(66556008)(66946007)(66476007)(6916009)(316002)(83380400001)(26005)(2616005)(186003)(6512007)(7416002)(5660300002)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?mtkle632iM2Px8QdpmpPaYQ8sEEVz5SxsCMG1rqh8vz2Lqi+lue9u52N+6+V?= =?us-ascii?Q?NisKF6LQOSBWXkVfB7+FAoNYyT1SI8IYZIhD5HUA7IePteBXTO8vuefJX05b?= =?us-ascii?Q?hkPs1tB371oj4PG1IYHGgkSI3DGVWShQ8DGrKGdxMViVNMDIO8QEax7hbetr?= =?us-ascii?Q?nf1kfD7x08I1D/048MSDBFZUKT4EA+n+uR7VBV8ABbeLd+bA5chNsmgXl6Hi?= =?us-ascii?Q?ahaXCNoMLaVHACYY1dHPFt1GUYf2TtxMucUEFgqme/eGWjp1jQ3BYYgtxJuT?= =?us-ascii?Q?shuq4AWKhO7gZ3l1xIj2NWpkCwUbJiKK0nokeVQUoOPTh4uJKchSzrh4bqI2?= =?us-ascii?Q?7QxBdjLcDXUnWV47qvlDPNC6Vt1NunzPr5X1l+FPJupDTMPGkDmCuAEP9vmI?= =?us-ascii?Q?sY1/VejCWqP5+AvRJDGk5mb2GWI+DAKlsVYRGuFhmTdwSt5jyDmoyojiIaeQ?= =?us-ascii?Q?96C3X3CBs0WTbePkmiVtRpjYdZtBW+O4XSq4YWQu/UMojDiUWlMtql9RKolv?= =?us-ascii?Q?Dg4Zek2dYfCWLCe/kTeCR8daSTIGNO71ITf4kOWso4hUDv9Jy2u77382WAUB?= =?us-ascii?Q?9FuAADpjeq36PZPaB+OQye+eQ0vCeulNdlUqrcVZ7CVfhNTGrIxdHPp0Yq2r?= =?us-ascii?Q?YtKn3HcRjrZaHzGJiY+XwMG255NyCw3frxHT7ym4vc1l9E4CL8Sqf2MQQRnW?= =?us-ascii?Q?BMY+APy0t48WJpI2HUBkth1ZxqWh0zMGBtbJ7Lofxx3uCBM0SBlFptNPVEMr?= =?us-ascii?Q?uwi7zoW/ktSC1i9WJhOXEACamIrgAszcuJJJZ7C3OZ+G3ONj9dCLnmliRYBZ?= =?us-ascii?Q?WiD5g+X/Xo2pWxzuHHszNaXJOU+xUaNToIqaiZvXVVWdHmE63EXL/Etayd5X?= =?us-ascii?Q?AoRh9Yj+p+Op6KNMn21CWGfh5eBJJMWGrO2UQvyrNfihc2TAAYsTAyk9eLvM?= =?us-ascii?Q?JImp7O7P5xs1k0wfStoBjbh+fRTwzbYClrSG/Fje9j9DkCK4D3MwBlDgQDoY?= =?us-ascii?Q?Qa1dLfzEQJMwF8K/6UzS/i3ji6SxqSsIaGAH8sqQ38MwCAEJdMPxkmlOpAzQ?= =?us-ascii?Q?5H3B8rcv082+XHmEOmqCbxDVu4G38moLXgibsXVRFCcLn5IjU6AyfOoZ7HEr?= =?us-ascii?Q?6B4HQlZYSDfn9rtKUccJLO1uVFjYvdNdAdQIr7gFOwpCs6LkSbJSK7fs5tCd?= =?us-ascii?Q?uWYpD1DQFFirfrAQtQlwGnwHxW2eJd+lLfVYFu1sx7lpQ4QXgKm7bmEICVIX?= =?us-ascii?Q?jVzZG7oL+bv77A/9ag9lqH7FPPtzl2gVViGJb/E0IKBkMsQtL0UBS0FkJyv8?= =?us-ascii?Q?Y4VWcn7wwSJ9Pl7eQk2clDWoeOOHgo9MWMz1Emqu4r6So75I10c5uuEwhwO5?= =?us-ascii?Q?SHFebXRVAF5lHutnDLifjYMXgFYUh7GKxrD9GPtrwLqW8oRXIMQyvJX9audL?= =?us-ascii?Q?iAdlggjxH7XC30sK8mexhScBnSqu78uK8AoZw7Z4CGKizaxyWtEoo8ljVzhO?= =?us-ascii?Q?DPLzA3jjIDNDxIORlFgkRwKli0PC6DSsXEuUZJno3LOnLuN7QSJs3DspzaPJ?= =?us-ascii?Q?9fui53bMqnlwO2zEovSwzFYRgeLmzWvcmkylzIGi2NdmTw/04RTdAX7xC+2I?= =?us-ascii?Q?m95hRciN5BFes7zIR31oFA4=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 996a3506-f20d-4be0-a4cb-08d9fb585f0d X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2022 07:52:02.1777 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bLOmp4H0Pn3ZP2aUuQXOfanPW1NMfmXQRlPAh4t4A+UNvmc+VxjD+g2fyUsw1jgphzceyBHwl0IgDjjLM6Cjaw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR04MB3291 On 28.02.2022 17:31, Roger Pau Monn=C3=A9 wrote: > On Mon, Feb 28, 2022 at 05:14:26PM +0100, Jan Beulich wrote: >> On 28.02.2022 16:36, Roger Pau Monn=C3=A9 wrote: >>> On Mon, Feb 28, 2022 at 02:11:04PM +0100, Jan Beulich wrote: >>>> On 28.02.2022 11:59, Roger Pau Monn=C3=A9 wrote: >>>>> On Thu, Feb 24, 2022 at 03:08:41PM +0100, Jan Beulich wrote: >>>>>> On 18.02.2022 18:29, Jane Malalane wrote: >>>>>>> Add XEN_SYSCTL_PHYSCAP_ARCH_ASSISTED_xapic and >>>>>>> XEN_SYSCTL_PHYSCAP_ARCH_ASSISTED_x2apic to report accelerated xapic >>>>>>> and x2apic, on x86 hardware. >>>>>>> No such features are currently implemented on AMD hardware. >>>>>>> >>>>>>> For that purpose, also add an arch-specific "capabilities" paramete= r >>>>>>> to struct xen_sysctl_physinfo. >>>>>>> >>>>>>> Suggested-by: Andrew Cooper >>>>>>> Signed-off-by: Jane Malalane >>>>>>> --- >>>>>>> v3: >>>>>>> * Define XEN_SYSCTL_PHYSCAP_ARCH_MAX for ABI checking and actually >>>>>>> set arch_capbilities, via a call to c_bitmap_to_ocaml_list() >>>>>>> * Have assisted_x2apic_available only depend on >>>>>>> cpu_has_vmx_virtualize_x2apic_mode >>>>>> >>>>>> I understand this was the result from previous discussion, but this >>>>>> needs justifying in the description. Not the least because it differ= s >>>>>> from when XEN_HVM_CPUID_X2APIC_VIRT would be set as well as from wha= t >>>>>> vmx_vlapic_msr_changed() does. The difference between those two is >>>>>> probably intended (judging from a comment there), but the further >>>>>> difference to what you add isn't obvious. >>>>>> >>>>>> Which raises another thought: If that hypervisor leaf was part of th= e >>>>>> HVM feature set, the tool stack could be able to obtain the wanted >>>>>> information without altering sysctl (assuming the conditions to set >>>>>> the respective bits were the same). And I would view it as generally >>>>>> reasonable for there to be a way for tool stacks to know what >>>>>> hypervisor leaves guests are going to get to see (at the maximum and >>>>>> by default). >>>>> >>>>> I'm not sure using CPUID would be appropriate for this. Those fields >>>>> are supposed to be used by a guest to decide whether it should prefer >>>>> the x{2}APIC over PV alternatives for certain operations (ie: IPIs fo= r >>>>> example), but the level of control we can provide with the sysctl is >>>>> more fine grained. >>>>> >>>>> The current proposal is limited to the exposure and control of the >>>>> usage of APIC virtualization, but we could also expose availability >>>>> and per-domain enablement of APIC register virtualization and posted >>>>> interrupts. >>>> >>>> But then I would still like to avoid duplication of information >>>> exposure and expose through the featureset what can be exposed there >>>> and limit sysctl to what cannot be expressed otherwise. >>> >>> So you would rather prefer to expose this information in a synthetic >>> CPUID leaf? >> >> Depends on what you mean by "synthetic leaf". We already have a leaf. >> What I'm suggesting to consider to the give that hypervisor leaf a >> representation in the featureset. >=20 > Hm, but then we won't be able to expose more fine grained controls, > ie: separate between basic APIC virtualization support, APIC register > virtualization and interrupt virtualization. We would need to keep the > meaning of XEN_HVM_CPUID_APIC_ACCESS_VIRT / XEN_HVM_CPUID_X2APIC_VIRT > (and exposing more fine grained features to guests make no sense). I did say before that once (if ever) finer grained controls are wanted, a sysctl like suggested would indeed look to be the way to report the capability. But we aren't at that point. Jan From xen-devel-bounces@lists.xenproject.org Tue Mar 01 07:54:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 07:54:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.280928.479046 (Exim 4.92) (envelope-from ) id 1nOxLF-0007eV-UV; Tue, 01 Mar 2022 07:54:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 280928.479046; Tue, 01 Mar 2022 07:54:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOxLF-0007eO-R8; Tue, 01 Mar 2022 07:54:41 +0000 Received: by outflank-mailman (input) for mailman id 280928; Tue, 01 Mar 2022 07:54:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOxLD-0007eI-Uq for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 07:54:39 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d832865a-9934-11ec-8eba-a37418f5ba1a; Tue, 01 Mar 2022 08:54:38 +0100 (CET) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05lp2113.outbound.protection.outlook.com [104.47.17.113]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-19-uFMk8q9lMB-gREREpdHU8g-1; Tue, 01 Mar 2022 08:54:37 +0100 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by AM0PR04MB5428.eurprd04.prod.outlook.com (2603:10a6:208:113::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.25; Tue, 1 Mar 2022 07:54:35 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.027; Tue, 1 Mar 2022 07:54:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d832865a-9934-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1646121278; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tuferMufzsFXQYa+KiVEBJBP1Epvsmt/w+PiT8wjslI=; b=N/lHd41j2GTQG655ns94leGQXE2SAdpypYl3kokx3ZEprRmuDXFiXxj3rB0UMqmIe7adR+ o+Vp9q6a+MMAbpElw5uSpiLVMbIXgqBnbb42VECjBaETuPG0WBRBurhoijua/HqW2fUG6s JI29t8ELNGR38FShcJ0m1h35KFceAiU= X-MC-Unique: uFMk8q9lMB-gREREpdHU8g-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nPBuhtADskuH12y8qsdJF4IAUCy6xUfswfKTDGXQALyOPOIjH5HbrBz6SYvbMtsO+i8jTexo9lqkwV/mAImSsCq+yxPcmkBiXHBRSOrJQ5/YyiwO4PyyUr5YVNb0ht8xX7FkhUcbvnbQreAHSdOk8MwJWTRbPwTshaewESIWnwc9aI0/t0rbSXh2/pIkZ1LI/ACvemscyRs00GsWCY3lY5Cs33g4UXkDi5X+fWhNrYQ/WHB6eHL4xdHmmzSBbOyv2oLJrNbThwDQ4/tmFRBfhf+gGzvUX7tju1I/slA1LhiQ/R1ugc/+cMS3ZkyCCaIU83Tb3PC+YL97St02cOs7Nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wgwG/7GAukzSMCZIXw062wDuDQ86sS0ae0m92b8+naw=; b=RZXVO53kvY+J07rQ1Lq2mTyNvPVHARpk/nkfb03gAeBYaGIDDrhYKmoBMY+6YMJq7213N4AEGFRjohi1NkWpMfDMS2jWWbpBn2XtMcHlXvTZROw07YEONRjwTCQ449636ZYUs/oJ9u+TpOOkNRE3PdqKPP1/tHGQVEauXRce9NlrFCZRREI1GEFy1K6/CP0b+DPe7ZITQOfb5UE4TUOPdTkJoEh0IU1RoatHCKp9zy34plZK+AX+39cqTOhdUcMAjFJnLQ/fid+ydxIIOqphArffhIB0Wi6i3kV7Tu8ZswCvordujU/J1ZNvDtsi8fVm7GRco68KOfaiEzS5izvpgw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <713a8237-6f50-c764-e572-b914cbfa1616@suse.com> Date: Tue, 1 Mar 2022 08:54:32 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH v3 2/2] x86/xen: Allow per-domain usage of hardware virtualized APIC Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: Jane Malalane , Wei Liu , Anthony PERARD , Juergen Gross , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Christian Lindig , David Scott , Volodymyr Babchuk , Xen-devel References: <20220218172943.12182-1-jane.malalane@citrix.com> <20220218172943.12182-3-jane.malalane@citrix.com> <7ad79609-bd67-aa44-56e0-1070f3ee88f7@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM6P194CA0044.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:84::21) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6795d9d6-977c-49ca-d3d2-08d9fb58ba4e X-MS-TrafficTypeDiagnostic: AM0PR04MB5428:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gVT4ysDUvFb8rnZeLwStwrJFSguYo4sbpSo1seHklqtW9694p4Z1H82xmmuoxiepErkjljngoXcaxNde47pJpxtVMQx+pHo8Mc9TbrM2Klz9IhnCl7gFWFC5buc54h4vtq3yIESG55SAQ3BytJfP8JP8BY9kpfx9n585LCLjNZfPzOWd/508k7gUoy9mPkd7/xnGD8qc9nbXM9t27GmuDlXRQo6NAMNfK5odFJ0YYTauACnS2L/u1sokjjfLnphCvrfs6CDaKyHn0R1z3vLQnp6pj71z+JOe36gxd8/3uxABzNh201dFF/HhCxythpzu5iMrkm3QXpJfqUhGlRKY65PcgDR+Rrct1Sw++VLZYM67Hwfn9dELTAL0MavVZv0V6jV8ejE1iq5kbpfkJ45rSAVtphcOSc2M4+XAF+9GuycpSlt9VVIp5Mn+ZPwGg+HN5L0GlkQ+ryoj4k0Y/3RGAYp6vOYKQ9Wkn15XwLlHjCoUD85cvdpvamQp+hIbM3ZaFchkIP2c9rZR4LU+EnXErJMPg+0G3z5URoNv2D/hKTrVr649HP3FdTq1JFquFHbgMOU2M+8tmFK8aCKo2MAMy1gYYRU6zx84EgbBB5tFpJMRhHZXCyakkfZY7QrwObC+2j6oxWa6Q11DsIa/3hSLVeGDYFs6g8z2sRPiu006CHI0fwDBI+WRQO8lQwhCC53lcXsSn97qLPeOgtt3MKpFnrPv6diAP8Rwl+rJCCs43IE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6506007)(6512007)(53546011)(508600001)(6916009)(6486002)(54906003)(31686004)(38100700002)(66556008)(66946007)(66476007)(2906002)(316002)(6666004)(83380400001)(86362001)(8676002)(26005)(186003)(4326008)(2616005)(7416002)(8936002)(31696002)(5660300002)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?QOUpVH5Ok1O6vHBTXH9c9mO7ZGga4DV3jn2yWylUBPgpJAUTzJf6++A/h0ec?= =?us-ascii?Q?II4/3/F3jig54HwQbUAIPRVUMgovsBPs8pwBzsdSOMflhN5KRNIG0qnhu4rk?= =?us-ascii?Q?vmr6uAJ16nlFVnz7Bqu1kCbKV/EBAf9DykHvCEM1F2zQPaTiqIUzHzmY5PKt?= =?us-ascii?Q?JUJEZjMwbWyF0LE+a0Zq3bQGv1MQtGUGfNnr1s8sylSR1DxaJGXDhpXVX7qf?= =?us-ascii?Q?3Jx3FoopLDON39l/BgBPuJzx8YDsWdJerszMj8W1HEZjFNGgbAkH0axOhq9i?= =?us-ascii?Q?4tpJA4ChdGwu/OavWW7oS1xqg9YMZvpzVylB29htWdGURwC780MaWR0zCKPX?= =?us-ascii?Q?gyA6GqgwHoKLHtdqcNkE4+9UVhlCWfqTpt6/Tsir9vS3IBOjABnz0TEe0o9N?= =?us-ascii?Q?7uDC0BTgStkAZGULQLWP24ZBPonvK64h7Ixr2HoP2DpQxUO3b5UbLiw7/WAE?= =?us-ascii?Q?d/jvSQW4FwDcRlgupd8dAjOUXGh7Ib9sJwNQAySNri9q6NyCP0iP/4hV/Cqh?= =?us-ascii?Q?G2qCoq/K+3+yTLFmpodgXo+pjVPFNMKT+YwlNyQJaIyFwu+ZexwmAD7LOvDA?= =?us-ascii?Q?qQvj45fE+TDheGU1lBdxMo0Dfuyy4uizzNQFWokCcGtBtkntsr55t6p8NwjS?= =?us-ascii?Q?AkSO7hpzyBxTYSTvBmNiXqM7hRxnlIfE+nPuVAKAqm/W3n4DZmabphgKaGrG?= =?us-ascii?Q?h5n23dsRbzJtuJ3FkwOoCxSbkcjCWRq7yfxJT0Q6zsbf4d9sn0VstKfpupVI?= =?us-ascii?Q?WKHCDiyC7dgDUv8r1/HtTntA+3jKEk02i5lhOXwtS3puNDWz4JpGtuBjgSGr?= =?us-ascii?Q?HU+DXJvaOu/9m3eJkCSNnOHvfyZDwEJMtAMOraViMqHN2vpf381IwmHE1WMz?= =?us-ascii?Q?bjUVslR4ofvkKabkHLCdUfFfnEXCe1QoLFs6knA1zCpTUHNUKNRfSvY+OmsD?= =?us-ascii?Q?5KEyYAAbfnixewpFzVtpbYFImEJdYxy3goie7S20p9TGQn3DKtFblCe8Bw9k?= =?us-ascii?Q?jbvx6mKvXgYGlNLP7zUUynxcbMk3oGbXdsBocRenrWil39RYLA/zjoAC+4TG?= =?us-ascii?Q?kgsguO/NVbumyk6YwO2lmNLHfOIoTTcJRqcah4P1Z/cjk4sQgU+Z+FnrpCP/?= =?us-ascii?Q?BS82wKb7joci+7YQrUpOQc6S0tdeikrV89Jv+tAarg5WpCiJKBGAFE7nACSs?= =?us-ascii?Q?Rq/2iHnPd90nwqbLWyjFryrl/3xw/9j3LvnF82VpvOTD7e6IqaVlUv8aRoYH?= =?us-ascii?Q?cUuumURhDdJg/JiKS55BIkhX9Q9qF8va7kiYA/z0CSHZDrVUq7G2QaLx/uMP?= =?us-ascii?Q?vLPYtOIZi9EEk4k6Dp8UuIsjgRpQKi3QhKFIo/DjtBtzKH7Cb+SkCRymLAHA?= =?us-ascii?Q?4AiTZrxA3tC6FtpxjZG+LxOd0s+J/1EILvS1GwgyBTr/cSJVIc5PAuuLu7Nd?= =?us-ascii?Q?qh/iqRacZAWjPEwGoZueXb4LhB8BZUJO5CMCC4BSDig2IKCxu/F8+zk2QU2F?= =?us-ascii?Q?CFm7ZCMBM4R5jcoZyuGf7tDX4c9Xy0SP57wGmLVUJlsPW95/B9v8PANyD2GS?= =?us-ascii?Q?fD0qAw1xLoxVY0w4YEUa3FzHkSZEdpQyXA0m9yk2dL1aZusgIa6m69C3RQzH?= =?us-ascii?Q?MG1nycjRlMsheQcMT4UnWr0=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6795d9d6-977c-49ca-d3d2-08d9fb58ba4e X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2022 07:54:35.2776 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bQoNrCx4bYe/UDjMPCGSDZduPorl3ahwTjMG8jSt+/bng3vHCw8Hu6WihlOyZRA5JFzcROyuEjj40aUJwt7fqA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5428 On 28.02.2022 16:48, Roger Pau Monn=C3=A9 wrote: > On Mon, Feb 28, 2022 at 02:14:26PM +0100, Jan Beulich wrote: >> On 28.02.2022 12:20, Roger Pau Monn=C3=A9 wrote: >>> On Thu, Feb 24, 2022 at 03:16:08PM +0100, Jan Beulich wrote: >>>> On 18.02.2022 18:29, Jane Malalane wrote: >>>>> --- a/xen/arch/x86/hvm/vmx/vmx.c >>>>> +++ b/xen/arch/x86/hvm/vmx/vmx.c >>>>> @@ -3333,15 +3333,15 @@ static void vmx_install_vlapic_mapping(struct= vcpu *v) >>>>> =20 >>>>> void vmx_vlapic_msr_changed(struct vcpu *v) >>>>> { >>>>> - int virtualize_x2apic_mode; >>>>> + bool virtualize_x2apic_mode; >>>>> struct vlapic *vlapic =3D vcpu_vlapic(v); >>>>> unsigned int msr; >>>>> =20 >>>>> virtualize_x2apic_mode =3D ( (cpu_has_vmx_apic_reg_virt || >>>>> cpu_has_vmx_virtual_intr_delivery) &= & >>>>> - cpu_has_vmx_virtualize_x2apic_mode ); >>>>> + v->domain->arch.hvm.assisted_x2apic )= ; >>>> >>>> Following from my comment on patch 1, I'd expect this to become a simp= le >>>> assignment of v->domain->arch.hvm.assisted_x2apic (at which point the >>>> local variable could go away), just like ... >>> >>> I think we want to keep assisted_x{2}apic mapped to >>> SECONDARY_EXEC_VIRTUALIZE_APIC_ACCESSES and >>> SECONDARY_EXEC_VIRTUALIZE_X2APIC_MODE respectively, so that in the >>> future we could add further controls for >>> SECONDARY_EXEC_APIC_REGISTER_VIRT and interrupt delivery. >> >> If we want to be able to control more (most?) VMX sub-features, it >> would seem to me as if this would better be modeled accordingly >> right away. At that point there would likely need to be VMX and SVM >> specific controls rather than general HVM ones. >=20 > I would have to check the AMD interface for hardware APIC > virtualization support, I'm not sure how different the control values > are there. >=20 >> Plus then it might >> make sense to match bit assignments in our interface with that in >> the VT-x spec. >=20 > That could work for things in secondary_exec_control, but posted > interrupts are controlled in pin based exec control, so we would need > to expose two different fields? Not sure it's worth the extra effort > to match bit positions with the spec (or maybe I'm not understanding > this correctly). >=20 > Are you suggesting a (VMX) generic interface where the hypervisor > exposes the raw vmx_secondary_exec_control and possibly > vmx_pin_based_exec_control and let the toolstack play with it, setting > in the VMCS what it gets back from the toolstack? Not necessarily all of them, but on a case by case basis. But _where_ a control bit would appear (if supported) would be well known up front. This wouldn't be very different from VMX'es "supports the 1-setting of" information provided via MSRs. The hypervisor would indicate which of the bits can be controlled on a per-guest basis. Jan From xen-devel-bounces@lists.xenproject.org Tue Mar 01 08:00:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 08:00:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.280935.479057 (Exim 4.92) (envelope-from ) id 1nOxQM-0008P1-HZ; Tue, 01 Mar 2022 07:59:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 280935.479057; Tue, 01 Mar 2022 07:59:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOxQM-0008Ou-EP; Tue, 01 Mar 2022 07:59:58 +0000 Received: by outflank-mailman (input) for mailman id 280935; Tue, 01 Mar 2022 07:59:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOxQK-0008Om-JX for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 07:59:56 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 94ccb4d3-9935-11ec-8eba-a37418f5ba1a; Tue, 01 Mar 2022 08:59:55 +0100 (CET) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04lp2051.outbound.protection.outlook.com [104.47.14.51]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-24-uavKTY3TOYCWMSoI3YLkiw-1; Tue, 01 Mar 2022 08:59:54 +0100 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by AM5PR0402MB2820.eurprd04.prod.outlook.com (2603:10a6:203:97::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.24; Tue, 1 Mar 2022 07:59:53 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.027; Tue, 1 Mar 2022 07:59:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 94ccb4d3-9935-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1646121594; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bmZljKsuipJZNrFyF0W6Vga6KwbGVTf3g9zbiLcGc2Q=; b=Ab1RZx17TP8keATLOnrx+M3lAP2h0KIdmVecOnmSNWca57Q7mqJkBzYR4OU43wm/yc5UOK nWPgpirLAx1TQ1+BP0geMtPVFywupOLRxVjmwFE4JjaStfWp1cZR4leZlXodnz9YAvxkpN tJuD4cRDqYfwePGaFzsGEHEJtgMBzWo= X-MC-Unique: uavKTY3TOYCWMSoI3YLkiw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lieZF3Dm9vzlwmrhF+63sDTj6vVWllum6zIu+/s+fMbj+MIIXZiTvCUWkjrB3DywqijDtHPTr4O3V8q4SoLEEt9b/IIFxneS9nGwIf2m+NGytsYIZY3CbasU9O09WpAA0AsQ+zkH4lGcdXNBJcyrLMqljdfxjA1PNy9G0qGtIbSztZubuQZzr1kPExIf9MQtXQzHuhIp7Xg2YHSOgHuqdK1xHTXSOIguNmPf4OWjMSpynGarkqjwuNvS9938hOg6HrObpL/Df1AeKZhT7IKN+UPX8k36POmNTbaEgN9YEHsHl0z8IWsrjW3SI0+N4dknjlxmN/FqWF7gyKIsTYUh7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bmZljKsuipJZNrFyF0W6Vga6KwbGVTf3g9zbiLcGc2Q=; b=JyISvSO8Q8/vSU3NIT8MMpgvxR1EbF+gkJDOfELotm4fd3lozKhaaxEQxq9cTrc6UYhGLs1QKebVRy2tr4HI2AlQ7NjBMtqTSnZLzhxK3P++sw5xcy5F4JfOoNXnTAcYSNB/a4g21lIykWEoxMzGnMVm1+exbsm2dYhq4mD/o7q6XTxIlz1WWDZMuqE083LxHLpHNGwAMCjfDDXwvI4zZV1WoX2tmSEI3OUR/yhwlwMGnEu6QjE+wUd2M54RTYulphTitogTGucmRaS2+tWduq1321hLo87xu+hVVvgO0xcs0nZmpZ+tZnhX3Kek3+dlw4OIFTViJFSPpRH8KWafbw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 1 Mar 2022 08:59:47 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH] x86/spec-ctrl: Disable retpolines with CET-IBT Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20220228225117.14327-1-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20220228225117.14327-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0098.eurprd06.prod.outlook.com (2603:10a6:20b:465::13) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 76efe257-18ae-431f-7585-08d9fb5977a9 X-MS-TrafficTypeDiagnostic: AM5PR0402MB2820:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cehzoZpAjW+CxNqT0Yfk1mgmm30mkVsIV+9ZgQe8F70esOZlxU3qxDk1yNZTLunOlbIJZDZWsoxZGL0wlTjsbDUoflnLd+wLHp6xn2K4vVziFcoC1hTMMvX7lo0fBIWYFrs0I82uyfw9RLp9+6qhz6REHmbsjv9B5l7Zh32ty9H5MTAUiOo52q8/Bw91gUv0kfM7ZIS+8mhMXy26rrqHuZubFlCBPntceUe3yju24CpnVS+PMH/Um8M7jBNMh2E+mQC48RgMbRSkObveiWc9g+ApXCuf5RSNhudIvgdaYVjGoGcAyP5ZonQcCB2YvkvXD7K/k1OChcp0gMpdj4vEjPD6GEPHgsfUR5j1CDMGuGLGTD2Oehun50xAaGE4PMoiIcjSlhW3FR8rXW6n19042oTBQeU8xSFiaIv3HKYEThJ+7a9Fv6pcioPjhSzxbmuRl+U8+YhKMxngTk4quUvs5/AuDpx1rSeXzMf95TpWnuyuony2cKSTs/BTtQD4jXbC0XIu0IiUpxH57tGUOxQLFXrCVqAtG51ogmQZCFfbFLwqg93Xsl1xyveWnaNw7wZLUNY4Y5XLWsPJ9zTwe2PykafhrIcJ/bSSTXfqwU7FcnZ2qTPCvP4AatuJxyvr2X0uslJ8E3dXwsnLe66U+U1r8nnpq0zSBvemAY7tyGBiAeY/S7zloAXcQ7YC4OeCcYPuiCmQiKr2rNT9uxaJUgoKGX2aCJ6RFrRlzxAozr/WBgSZO4ugalsq6COrvRDrSNch X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8936002)(6486002)(31686004)(2906002)(38100700002)(5660300002)(53546011)(2616005)(6512007)(508600001)(6666004)(6506007)(4326008)(36756003)(186003)(26005)(66946007)(66476007)(66556008)(8676002)(316002)(86362001)(6916009)(31696002)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MmNHR3dGN2dPOXdmRUhyNlpRNTFOajRXcU54ZnV1L0xHUzMvUzV1MHpYZVI5?= =?utf-8?B?VnlWaGhtdm9zSlZ5N3BqWUNUMUhFNUtsL1NjZlo1NXVtN1RBWE1GVFhjWkpi?= =?utf-8?B?cUc4ZzhqWUtEdjVtdkZVN2hHN2hOakMvbDQxRmlubHg4d0FaK2VpeWxiamJ3?= =?utf-8?B?dnFYaDVGSnlQdDdqcUpZUUtwMmUya01oVE95U2s4cDVnUWZaVGIraWlXVFA5?= =?utf-8?B?YVdmTVB6WmN5WE5obU50dS8yaXNRbCtxdkEzK1lmVkNBa1dDdkVFWnQvN3Nj?= =?utf-8?B?dlNFSytvL3orMWVneVZpZnNWUWZFVDNpRGR1MzFuVEVnUTM5VTE3dkZWYjFY?= =?utf-8?B?bmRJVTdzUW44bldOQ05aQVFSVkRnczQzWi9MeStQTVNKekZQNjR1VnNzWDcy?= =?utf-8?B?NnpiMEZHRlVMSk1HUDJlSWNSMmNwaFYwb2VMNHlySU1Oc1RXWHgrSS9pMTlw?= =?utf-8?B?K25lYUQyYTV0RlNyc2h1dzBtSWNueW9GMmxQTVY1VW52WStLVGR6Y3RqYzNG?= =?utf-8?B?dFNiTEVJb0UyNGU1RTREeGRLN3hrQU0za1pnbXVvWVg0eCthTDZVMjhKTnhq?= =?utf-8?B?VWtsbGovNDlML0tZY2oraWJBVmJIMG1nNE14dG9nUnBFL1BnSk03c0tEcjBC?= =?utf-8?B?aDVGWGJPWHFjaEZOTnJFaFRYOURocjFJbUcxYVN2ZGMyVW9MV214UnYvMFBI?= =?utf-8?B?OFZUbEIxT3JJRTBMRlN0eVM0UitzVGhsVUdEbUFqZ1NtdlR0REJUTGZidjhY?= =?utf-8?B?Vyt6WU04RGtkbk53cVpFeGVSQ2h0b3hQcVV2K2txTWYwMkx3UmRyMWJGVUt2?= =?utf-8?B?NVQ5WHlvK2pmTFk3YWVXZEtJU2t3UEpDREVRaXZmU016NStYSnFJZmpXVlF0?= =?utf-8?B?OTROYTlLaWptYzVGb1ozd2FEUDdxR3JDRWlyMWFYS3o5ZDhFYnE1Qi9IaC9C?= =?utf-8?B?RHdjT3pwYW1BVTVsN21wNC8zOWhzSkxodFdnQWVuS1o3YXlIdEkrUk5PMXFL?= =?utf-8?B?MytVVSs3eC9DYktiY2gwb2REVDFESDVXRExsdE9jUGloYXdUR2w1R25xTzdj?= =?utf-8?B?VUVDQ2xDK1VldHB6cnNLMzhwOGtjZUZzM1BPMUlyUTA5bGtNdGIzbWpRenl4?= =?utf-8?B?NmFRb1gvaU84WmhCMTlTY2VpM2gxeDk4NmRXNVBINTAwblQvajY3NVd2NkxP?= =?utf-8?B?a2o2YnVuRExRYlBield5Sy9RVy84eUtGOUtaYkk0YkxSUGxteSs1SnhlV2tz?= =?utf-8?B?RDNTdzJTUks5YkJRY0JMNjlRa0xuOUlJREhpK21qcXAyRzcxeCtuNnNjc1NL?= =?utf-8?B?cTZqQlg3RjJGbGhBL2JRemFnZi9ta0R0cXVhSk9FNTJWN1BJSUVvZ2NsTnAx?= =?utf-8?B?bW1ZTi9leWtBRlZSOUIwL2dGRDBKTEhSVFJuSEhSYmYrSmt3dkNqbXZad0lH?= =?utf-8?B?Z1JpTEZWVS9vbzlIMFQ1Ui8zSjBydjExSjh5b2dGKzdaYm0xNEg2eXBVTHFJ?= =?utf-8?B?MFhpcVpwYzFVVUdvZU0yamdnUzV2cWE0d29iaUczUHM4dnUvYm4xM2pjVmdh?= =?utf-8?B?aWlSYXpNSzBWUjhLUkJUWmNpekRNb0MyUHJQalhMVmJYczJvZ2lIUVk3cW5Y?= =?utf-8?B?Z3hkWktoNjN2OHFrQk1qM2YvYzdQZm9QVzNhQk9XNFFtU0hyTGxiQm1qQnhF?= =?utf-8?B?dnlCQjQ3TzhSN2p5cXI0UGd6K3luVVRXWE1nbEc2aHY1eWIxTWhRZGdRcmRt?= =?utf-8?B?WmE5bmkwMi9XeU9KR1llMjlIMjZWUWVSUTBvUW11Y2JucHdKT0lwWU9qcEdG?= =?utf-8?B?WkxWTUZsOUx5MSsxNDg4ZkM4ZldQV3h1b3cyVzMyREVJQ3Q4dnR1RkhsQzlH?= =?utf-8?B?dm13ZXI3SWhQTGNjZ0QxMGtUNkN2aDlUNHQ0M3J4RGg0cHYyNUJQVHJPY2dz?= =?utf-8?B?akxnZ2RFQ0x5aVg2SU9OR3hoK2FtbytBcWJSMTAwNUc0MGNpY0dQdGdNSTlN?= =?utf-8?B?K1VaUUxHOWU0MGZWMG51MGRHMW4vUU55SnJzcWQxTFFBU0Rzak9vdmJrTENl?= =?utf-8?B?U2Rhd2NzSzJRWmxvRjFIVzQwai9qMVFERzBwNnp0R0kvVGhTRnYxakwzL21u?= =?utf-8?B?clVsUnM2MG5OVzF4ZTdqNVltMDJ3QkcrT1V1RkI0VkRQSlZKd2ZCZGpKVzBB?= =?utf-8?Q?b3T/lMA3/9JI6DfGviVokIc=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 76efe257-18ae-431f-7585-08d9fb5977a9 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2022 07:59:52.9609 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PdQUAg8hIxFGj9tVYxPuUao+Qf4rqVWZnyEiZ8nYdCzsiySryX0+MHqoy9ctHgQB6ExQU+K4xEgQEZCKg9qA9A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0402MB2820 On 28.02.2022 23:51, Andrew Cooper wrote: > CET-IBT depend on executing indirect branches for protections to apply. > Extend the clobber for CET-SS to all of CET. > > Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich > I can't decide if this wants a fixes tag or not. If I'd remembered during the > CET series, it would have been its own patch. On this basis I'd say no Fixes: tag. > --- a/xen/arch/x86/spec_ctrl.c > +++ b/xen/arch/x86/spec_ctrl.c > @@ -944,10 +944,11 @@ void __init init_speculation_mitigations(void) > boot_cpu_has(X86_FEATURE_IBRS)); > > /* > - * First, disable the use of retpolines if Xen is using shadow stacks, as > - * they are incompatible. > + * First, disable the use of retpolines if Xen is using CET. Retpolines > + * are a ROP gadget so incompatbile with Shadow Stacks, while IBT depends > + * on executing indirect branches for the safety properties to apply. > */ > - if ( cpu_has_xen_shstk && > + if ( (read_cr4() & X86_CR4_CET) && > (opt_thunk == THUNK_DEFAULT || opt_thunk == THUNK_RETPOLINE) ) > thunk = THUNK_JMP; Just for my own understanding: Why unconditionally THUNK_JMP and not possibly THUNK_LFENCE? Jan From xen-devel-bounces@lists.xenproject.org Tue Mar 01 08:01:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 08:01:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.280951.479068 (Exim 4.92) (envelope-from ) id 1nOxRX-0001wD-AZ; Tue, 01 Mar 2022 08:01:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 280951.479068; Tue, 01 Mar 2022 08:01:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOxRX-0001w6-78; Tue, 01 Mar 2022 08:01:11 +0000 Received: by outflank-mailman (input) for mailman id 280951; Tue, 01 Mar 2022 08:01:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOxRV-0001vu-QH; Tue, 01 Mar 2022 08:01:09 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOxRV-0000p5-OX; Tue, 01 Mar 2022 08:01:09 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOxRV-0000iS-GL; Tue, 01 Mar 2022 08:01:09 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nOxRV-00007M-Fr; Tue, 01 Mar 2022 08:01:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=KaQ8qqfR1/en9rX2dPumlRLPpegRb8XBbFqaY1wFe1U=; b=iwztuSQpdc5EI69xYBl0bG7G6U X2HvSZQSvS0mb/uFusTWhb7B3q4gvoXMrqtDuKsXSMywi0TiQlPyqZy1TshphaNrs7sjX/JUmwkO2 fh+vge+CslRDJjKi5QSthv0FSUwT4gwtViE65YJx53JfUmoTfFp9Ik1kZrvB94R96o7U=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 168264: regressions - FAIL X-Osstest-Failures: libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=854ea58e4ee9dd5521bfb85df97f75381f617cb3 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Tue, 01 Mar 2022 08:01:09 +0000 flight 168264 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/168264/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt 854ea58e4ee9dd5521bfb85df97f75381f617cb3 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 599 days Failing since 151818 2020-07-11 04:18:52 Z 598 days 580 attempts Testing same since 168237 2022-02-26 04:19:42 Z 3 days 4 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Andika Triwidada Andrea Bolognani Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe Fergeau Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Luke Yue Luyao Zhong Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Olaf Hering Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle SeongHyun Jo Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Thomas Huth Tim Wiederhake Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 99017 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Mar 01 08:24:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 08:24:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.280968.479085 (Exim 4.92) (envelope-from ) id 1nOxo3-0004a3-CR; Tue, 01 Mar 2022 08:24:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 280968.479085; Tue, 01 Mar 2022 08:24:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOxo3-0004Zw-7W; Tue, 01 Mar 2022 08:24:27 +0000 Received: by outflank-mailman (input) for mailman id 280968; Tue, 01 Mar 2022 08:24:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOxo2-0004Zq-AK for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 08:24:26 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 00cd4a15-9939-11ec-8539-5f4723681683; Tue, 01 Mar 2022 09:24:25 +0100 (CET) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04lp2056.outbound.protection.outlook.com [104.47.12.56]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-24-ilgxC1XONL2EGnLxVdLN3Q-1; Tue, 01 Mar 2022 09:24:23 +0100 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by DB8PR04MB6475.eurprd04.prod.outlook.com (2603:10a6:10:103::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.25; Tue, 1 Mar 2022 08:24:22 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.027; Tue, 1 Mar 2022 08:24:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 00cd4a15-9939-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1646123064; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=9XJQN78ib1MVXdwfiKUllDBBg5cOZ43xtTpNhJqfgz8=; b=PgrUIglZmzqTHoy236Rd4OXQk2vGT5bWsHNgYdQIUUDC3F+LmbpvGbNVjf4/hOu7WJDfT3 26lbZEc6Ck3cMBh3DCHbTaoR9HCF35/Oo3wL2k1rbeA74MAPaeFpktPJyIFuJLd0b1qe/Q GNTxFreoO1VtWpYrPXVvfU6+8csItcM= X-MC-Unique: ilgxC1XONL2EGnLxVdLN3Q-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UQTbS3IwUmDf7klkO5J9m2mCq5QSsiZzoYG+8m5zx9nzlB0UH+VndbGkbGRare+HQ/6jLraJwPt/bbwtm7UYImZxWtV6hESGSGXRLFV5Kc9blNm6MhbGsnGVVyKZ1whKHk7FIF63ah7oUdr9hAcARH7m9LjdpCYbpR4w6SbpdCWfCVdJQwL5Xs8w/3EhYrPMyES5j5pGOF62pa81TpSLMiqtAZB7uqF46N/BCAVdo/9wQTncyb9U+LGbqvATWAhLT1OvELSVS2F+TNYZjlUzIw6y/nif0Q/MHV9TRPUPUH3rYzyRSgrdbeIWhZyAqQQk6Sdt2J3RZmNiFZttuhKnPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9XJQN78ib1MVXdwfiKUllDBBg5cOZ43xtTpNhJqfgz8=; b=RilcchYAZLDZ6w5zkGzKcUW7XVN+AyuA2mwvhVC0wVLwiaWRv4+LnGGClVmoAvF8WV/i5C0pcljW+qBLTwsSRCejbwHgjQpkTqkaJD6hHMnJKj0T3ypmky4+yVWNAi2jJT9qTdbhwqMIc/pmHtCEvbMU2X+I3RSW+QF4Lb9wGND1kzE7/n+Cpd9NM3VC381OZM+YPwI2zf+ROUdzQE9ucTUL8nd7gR7QytYbjpsV4y3fGpI/QuP8f26oV0VRJXFQWo5ZLh2ERxnQG4rlZWaSRLoernxOcP4AaaVPq/fxQUhtGOuCOayjhptrFZegCZrXtbpypCyiEJzcecaxBftekA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 1 Mar 2022 09:24:20 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Content-Language: en-US From: Jan Beulich Subject: Kconfig: defaults for UNSUPPORTED To: "xen-devel@lists.xenproject.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0047.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::18) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cb8b58fc-94a8-4a86-26ba-08d9fb5ce346 X-MS-TrafficTypeDiagnostic: DB8PR04MB6475:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mdelHzNmD5bflYw2kFUIYQcNxsTMnfwo59lO1aX0SlQzDge461590PG2ZZRZjBlqGQqHwo131yyvaWu1cgCNTIziNVL9p9c3o1f8xMCNIXr5oiGVGTbZMwoCvfarl77Uc+7Q27Hc4y6niq04DubnWVGwaumu63O1pahZUxHOFr4F5/jeEpzl3ETlaqu1Is4LYwwlwEgOrfTKJ1OGw8Hft2sXWSebhHR+u0+vzTC1HOFwXY+6FZ0RGkDbEFQ5dd8rhsboBkh3X0mcZhzLOYHOX0o0pGv/8DuSp7G8ZUFkTqsLMX9Sj0wDxU417fr1u1vMCARGv/VjEan94d0ulPBfblHqu1OBomLqu/1SMN67nKhy1dMME2e5NXwRYWrX1oZrA4MV026qcGIj77v71R1w08tGKkdR4p9Ky9FfLrp3i51gy0gs6vYLTxuXASaIn7TvgN8Yex0LWOta+SKosmzgcAq1xL7b9LYEOISBJawe69UaV+XfBad2PT7VpupFsjFjj7hiPwAdaAaoGzb5boajZtHLjTst/pGLf/Sk49YL/xFAFR4ll3o/QUE0z1TE2Q5CqnlVWazf/gUo7YSFeNWypiht/CGHyBEPV1ENYF1FenjQhiehwZ7TCTw1WPLM5EPM/bTyXDnogl15GvDtxtpwZKX0V7An8MK8eIVPM+lToURUs66CVR5poJUDypgzwGJqshdEXxHMuwGwQTrClHwtgQ1pVBa/ldLuERB1WFkV0Ms= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2906002)(6512007)(186003)(26005)(2616005)(6916009)(31696002)(316002)(86362001)(66946007)(4744005)(38100700002)(66556008)(8936002)(66476007)(8676002)(6486002)(5660300002)(31686004)(36756003)(6506007)(508600001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RVJlUlEyQWhkWmpCMklrcElaaGFobU9hakxJTk5JZnkyd1hxd3FkYytabTFP?= =?utf-8?B?U3dlV0FBbXdWWTNkZHV1NDM1aWlwclhYMFk1dWFGbFo0QVBlaDRyMmRyVGVD?= =?utf-8?B?NmxBbTRJTkwvV1N4ZitUanlJRHEzWkFER1RNelFQTmJlYjdyZXVDMnp3Sk13?= =?utf-8?B?KzZjeVhsOFlRVHVYam9GOHYrR0dFeUNYZEQ2bzZDbThOSUJUTGNnTmhzcUNT?= =?utf-8?B?OGkxZlhwSlZrTTYzVGNsMVRCV1luaHo0SUd6dzlWMHMrZUZHWmE4ajlLTXd0?= =?utf-8?B?QVZPNkdtbVpsRFBJd3dTMHFHb1htaXJFejB1U1Rob3gxd09jdUxCSUdxeTBP?= =?utf-8?B?b293bXRMVFpzQkVvV2Y2MGNadVluZWpGYVdWZUNVdFA0dkZ3K205T3pPM214?= =?utf-8?B?b243MWFteGV2VmFTRzJDNXl5Y3hBZGRkQkNYdlArYzlUVVkydFgwOEVnOVha?= =?utf-8?B?eUVhalpzTFRvVDJFeXFKL0J1YlBUd1ptVjA3Z2dHOEtMcWJjR20xVHF6YW5v?= =?utf-8?B?VENuVzFqVmxQT2N3eHZ6VDdXYW9hZE96Rld0YjhwZkp4QVB2d0VUNDNIdXhV?= =?utf-8?B?OHhIN2dYRUp3OVBWanJhQkgvMHAxRm1Na0xHS3Z0d1lxZkFYYlh0OHprcXQx?= =?utf-8?B?aWFzNWNqMSs3L2paQUV6UHdOM1YvMXRqaFZabVRRNDdTOERNbGd6Wm5IanZs?= =?utf-8?B?VENOS0RYYThENWJxZEZUSkFOZWVmNFg5RDhNRVZSL3lNOTRzUzc0RksvaWZ4?= =?utf-8?B?TDVsRisza0lacTQzOG9DbXpRNk5SRXp4ZXJNZ2pCWEVqOEZmSk1qL3Z6bUVz?= =?utf-8?B?UDF6N2taOXRWa0V6cU9pT0xSbVBncUg3QzRRRlRoaUV1bjVlTjdIWTVPckxJ?= =?utf-8?B?aUVKVnNZTGIycWwrV2pMQVhWaXppNldnK1huVDN0SURoV0RUcm1EclZsNVJy?= =?utf-8?B?Zjl2SE5rdEpCVFpMdGxKUEVmSVNhZFZxMUM1ZlpTZFpHQ3lWYmZNM2tmZENB?= =?utf-8?B?Nm5rSll5T1JRc1BiL0cwVUQ0VXE0MTc4V3Qrd0p2Y3BXaFlWbFJXVUFrRmJr?= =?utf-8?B?MzViWDloamlxc1lYdXN3cWdYZU5hbElWa2t5YkRHQ252L0RkcytCRXoxMGZm?= =?utf-8?B?bTAwMTJXeEswYzRXaVR6Z3hGaEMyeW5iK3JkVEN0SWgreFRNMFA2TmVKL3lI?= =?utf-8?B?a25leitua1NES3NyUWM4RU9WTGNQMDQwZzAyM0x6QTdaUEpKTCtHTzgrQlZ5?= =?utf-8?B?M2NpdmxycHp4bXVUN25NdzUySHEvbmo4Z0crQ0ZpK2RTTHg1dUdwL0s0OFFy?= =?utf-8?B?Z1pZMWovMGwxcG5WSjJ6SFJ1NlVxcHhrWXNQN0duaWxjLyt6SzlXK1ZrZFJU?= =?utf-8?B?NDBUR0FPaVVJM3FXVXRaaFZrTWlWSnJrSTM5TGZ0ZS91a3VSWEwxSTdDVCti?= =?utf-8?B?eFpCQ29OT2NHT2p5SjlmRkhKMWFGbUx1bEVJVkV0WndvRjRVZHJpQnFwZ2VP?= =?utf-8?B?SlNWd2xOVUczbzJKcEdYWTh4R0lZWXEwcGlWTmJwN21pVGRsSk1uMGtnbHdW?= =?utf-8?B?SlJnM0NCMGMyRWI4MjViVHdFMG51YndaUDlqaWNKNGl2ZlZzMlFWWFhCcDhK?= =?utf-8?B?aXJpWEUrRE5FS3oxS0hDcWlwclBsLzVmKzhPZzBlQ3J1dk95UWZVRklPS0Qz?= =?utf-8?B?Nzh1RjVZemtIUFQvdnZTTjJ5QjNpNTYzdWF3cUdWakE0SjFTcW9aY2Q1VnlL?= =?utf-8?B?UXBIOU5HZU1ZclQyd1pTOC9JbGxpdWlXM3Z0UjVFWkJsVThHaEpob0JQV1BH?= =?utf-8?B?bmdEd0YxeThvdUhxZjZ4RkdkSGhiano1bElzOWlRbDVCOTZ6M1RCZjk1TTk4?= =?utf-8?B?dnllTUNyQTZtZVNnbkozdHpvY1NyMHFkMmxhMklicVUzNzZLWnhveTJ0cEZ6?= =?utf-8?B?WjZjUkRtV3hCb0RuUTM5SjRaeTcrcENJWXZ2WGEwMitQakNEOTZZSmdpNXh3?= =?utf-8?B?UXhlQTI5ZTJZUzdqY2VncWlUR0xRRkpzbTQyWVZ3TGJjR1ZhQXRxeGlxOUVh?= =?utf-8?B?RzlNZGM5NXdRNmlMWHM2VU9sVDhhR1NhWmgwMTdMS2lMOUVwOUtYT00ySHlz?= =?utf-8?B?TksrMXY5WWFzV1drbHpyT2VUQmFKVWN4ak1tQTFRRTZ2VHAzczlYd1FpRHhL?= =?utf-8?Q?spKp/X679b/ccFwoq5q4AMs=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: cb8b58fc-94a8-4a86-26ba-08d9fb5ce346 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2022 08:24:21.9630 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZrsY3xnI1i67Z0ovQe++I7Hfysn8hcRDhzme8U8Lz0w5loyeruCbyY1j55I3P+49UWEMByzCaIHCcVfzzc2j8A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6475 Hello, when commit d96e5e6c1214 added UNSUPPORTED, it left x86'es TBOOT default untouched. This means we default-enable an unsupported setting, which doesn't look to be what's generally wanted. I can see defaulting to DEBUG as reasonable, and SCHED_NULL's defaulting to enabled when PV_SHIM can imo also be justified (there it's rather that UNSUPPORTED is inapplicable for the shim case, and the adjustment was also done subsequent to the named commit). Shouldn't we therefore have a rule of thumb that UNSUPPORTED entries only ever have no "default" (implying "n") or default to no more than DEBUG? Thanks for opinions, Jan From xen-devel-bounces@lists.xenproject.org Tue Mar 01 08:28:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 08:28:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.280978.479101 (Exim 4.92) (envelope-from ) id 1nOxrp-0005La-Sh; Tue, 01 Mar 2022 08:28:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 280978.479101; Tue, 01 Mar 2022 08:28:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOxrp-0005LT-Pm; Tue, 01 Mar 2022 08:28:21 +0000 Received: by outflank-mailman (input) for mailman id 280978; Tue, 01 Mar 2022 08:28:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOxro-0005LN-F4 for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 08:28:20 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 8c0f8799-9939-11ec-8539-5f4723681683; Tue, 01 Mar 2022 09:28:19 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E68941042; Tue, 1 Mar 2022 00:28:17 -0800 (PST) Received: from [10.57.5.142] (unknown [10.57.5.142]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6A5B13F66F; Tue, 1 Mar 2022 00:28:16 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8c0f8799-9939-11ec-8539-5f4723681683 Subject: Re: [PATCH] xen/arm: Remove unused BOOT_RELOC_VIRT_START To: Julien Grall , xen-devel@lists.xenproject.org Cc: Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Julien Grall References: <20220228100633.57593-1-julien@xen.org> From: Michal Orzel Message-ID: Date: Tue, 1 Mar 2022 09:28:09 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20220228100633.57593-1-julien@xen.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Julien, On 28.02.2022 11:06, Julien Grall wrote: > From: Julien Grall > > We stopped relocating Xen since commit f60658c6ae "xen/arm: Stop > relocating Xen". > > At the same time, update the memory layout description. > > Signed-off-by: Julien Grall > Signed-off-by: Julien Grall Are these two entries needed? I'd say one is enough. > --- Apart from that: Reviewed-by: Michal Orzel Cheers, Michal From xen-devel-bounces@lists.xenproject.org Tue Mar 01 08:46:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 08:46:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.280988.479119 (Exim 4.92) (envelope-from ) id 1nOy9G-0007tW-GR; Tue, 01 Mar 2022 08:46:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 280988.479119; Tue, 01 Mar 2022 08:46:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOy9G-0007tP-Cn; Tue, 01 Mar 2022 08:46:22 +0000 Received: by outflank-mailman (input) for mailman id 280988; Tue, 01 Mar 2022 08:46:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOy9E-0007tI-Tj for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 08:46:21 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1000ebaa-993c-11ec-8539-5f4723681683; Tue, 01 Mar 2022 09:46:19 +0100 (CET) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01lp2052.outbound.protection.outlook.com [104.47.2.52]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-14-_HzsyLxQPCi3Cmny5iMOww-2; Tue, 01 Mar 2022 09:46:17 +0100 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB5424.eurprd04.prod.outlook.com (2603:10a6:803:d0::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.25; Tue, 1 Mar 2022 08:46:15 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.027; Tue, 1 Mar 2022 08:46:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1000ebaa-993c-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1646124378; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0T2Dj9t3eq40h1Iz+f+/8zWi+R815wSe5e6l/W5S/+g=; b=dGVogbRfjFxTTMhPtzVSgW10wWJ4Xg0do8d9yWziR5jdzyk+zrZ0/hCDxfGJgQC96vpi5Z axF9VoyxQaPrZ85rGpasHr2Gtu/DLn8bgFOXSGUooDdNV+nhT1IGv5DG9UFfAG8e8Zb32p EdOFCvJF0Ctxty54jhmM9uuFHzg3lBI= X-MC-Unique: _HzsyLxQPCi3Cmny5iMOww-2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OHiQOl9Xpdcx3zQUCtxZnPe1o0vrWqrcZfxiC++CGFH7dk18d9RU686Te2rnT/UGIoqvZLw/hWv/ROXGK4xP5VSODAsxX7lb84UxV4vT5efDGlPcb7E3ZvlBEaDKUN5kaa+uAIFxIGDoNrSNVLIL4hEGINUnMcZDQO2xjvWODEhreRv6JjCL1tEtxefx1Qv79OrmMbp5ALVK11xwsdCGXPL5MfLtibHUsYQFpxEG6mH62/hPOpl0fhA06g251ZqrmeQnoqUyUPFv3xUHjKTIdnjdOcre02TzyHMZCywQCQj4ucLhFr/xPQkviRRmAsyh2szWcyG2YNnosEgPTtJ+hQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0T2Dj9t3eq40h1Iz+f+/8zWi+R815wSe5e6l/W5S/+g=; b=SurXWv+1bV5kSxfmGEEmwZ0EZXf10pRKdxFDOcvyUfmiGw8H8WU0n0tyBMThRTEbREtcbFmpd2s3VKemlGAZunkLa3ztn66ELXSj3dDNOckm3y1GD0MALLlpb1ZtqRFNvQCJQ9Jk6Jelg3HWQ9HjZZFrXR/ORRBXNtnOKShKIEs2g27LNR4J0LDaw9STpoOj7sRDq7dGeZQrHwSdSdb7fqvHlLCxN1NBJO/lsR0ubnKoAqodWDd/Z78moDOcqynlmglhqtrFDddhref1LBOqOKFDv9P4e7oBkKu0gElOHqpCctYwJ2u08GzEpZ/9Tmaiy9dp0zKOn4/NJaOIAfF1tg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <8597cd20-4d79-0f5f-8370-d2353e7116f7@suse.com> Date: Tue, 1 Mar 2022 09:46:13 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH v2.1 2/2] vpci/msix: fix PBA accesses Content-Language: en-US To: Roger Pau Monne Cc: Alex Olson , xen-devel@lists.xenproject.org References: <20220226100554.2664-1-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: <20220226100554.2664-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0097.eurprd06.prod.outlook.com (2603:10a6:20b:465::23) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2f64deea-1204-4e80-44f1-08d9fb5ff243 X-MS-TrafficTypeDiagnostic: VI1PR04MB5424:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sNKXlSlPJ3AJb+BOJh3EKVNSxdfEU2J2UTfSCzR2lJBi6LY2i/OrhunvrbXAOfxUfO+Tq57RG4B1sGVi4TOk4KEw3iC/VnApr+/wlzjV61LaaPoNdSNwdYyKOUn2Nuc3PMEKyRHC2+CQYRsl9ZJ4PN9bNrJcuTP1Ic9DAQAPY28U0nfXU3HFT/AEkVjkiMXkxlfJB/oeZxJ4OxFVe4NaT7UzQcu+Dmo2AL7WBYN6dQ3dEyZNZSyVmu5TcdY3js6AU+o+Xi5JbPR8xITZWLwjPZwl8VJCy4pzePKyAIRVPm7WfhYXQjC8rxF9WTGkNRrcfks02ObbICUIZSOs7bM/JCSyDhItE6aDqI5hrSmgijHBQZfxXv2NSv3Z4uQxgd4Bf6AKWvyjfJireJ65dErsBOVQPkauEGxqJVUPkMkMSM8VYDTmzjUiD1StMWIGk5ar7X/lvWQdrpvkZ42s/9RlOYoYikWnfOpTYt3BAQSOl2nNKzbnLF5TYdFl++U/sZNWBKxVudetxtHKYIIFA0jpnSqugf8x1jWPviJUA0XFuEuf+6yBPCNGN4oZZOibjeDRBW9i9AH303EXNef4sNIFyOm/jfS8WV8+ZttaCAfSe33zUOgrSATkyVI17wqdBkgZVGckgsS9G7Z7nDd/c2GWeAzOpcPHV+FEBdwMl6VI5zsEkLxTUcCkyZzSbkl6bFFx0fJ88ylWBzBQbjiLpQoyv18EO3cPKh41KtmLctAVfSSnzX/t4rwY5soEJ6Ai3SUO X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66556008)(8936002)(38100700002)(66946007)(6506007)(508600001)(6486002)(5660300002)(8676002)(4326008)(66476007)(53546011)(31686004)(36756003)(83380400001)(6512007)(2906002)(86362001)(2616005)(6916009)(186003)(26005)(31696002)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NFlWVXlvN1BTR09IN3daam5RTG1vU252allvQnVlTDFtTXY2aHhWRGRhZTZs?= =?utf-8?B?TFdoUXdvZWMrRUZQam1HS3V1V25oTm8zWDBHRUxTTzdobENNNWVBaDVrZFdk?= =?utf-8?B?UWw5ZG1mVGRrcVJEcjkyNmJoclF6Rm5yQkpZS0VCWGNLanVMaGROOTRNSlBu?= =?utf-8?B?cktMY21TVkFjRUUzUGliQyt4WjJaMHB1Y21keFZBN01YdlNFWmtKeUR3cVNI?= =?utf-8?B?bkdSQjdCZVlHNGhObDRyYXo1L0JFczNIUE9PeTdpc0hvWERPdll5ZkkzUVNR?= =?utf-8?B?VzE4cjBvdGcvN21EYWxwNGRDdDIxWXlDZVIvdEdMQkxzSkhaUDhLR1BpaEhC?= =?utf-8?B?WlBMOWNESk40V2RQNnV2RzlkdlpUZU9TRDFxTTZxUzdWS2l5aXJzWDlZR0Zh?= =?utf-8?B?VEF2c1IzeE54NXRqRFhkM210VFl5WVNnbTVuQkphcDcvTW4za1pGbHlreVo2?= =?utf-8?B?VUgwMzZQcmhTMThLc1dxazhBR0lQSWgwaHA0R3pmYUNGaVB6V25PdUVvRDgv?= =?utf-8?B?UXZKckFsc0p6WmkwUERvL0xyT2lRSnRzZVdJZWtDVVhzaUtTaHV1cVc0NmpS?= =?utf-8?B?QmJIOVV6eG5admFKQk43cGY2U2Y3SisxV3FKMHdlRFloNmlJc2FTcHR1YStr?= =?utf-8?B?S3lzTjZ4OFowNklXL3F6UHdERHliTHJaeUVOaHF4STJpWTZQT1I3K1VqYTU1?= =?utf-8?B?VFprWis1M2k1UUVlcEZrc2ZSV05jWXBsM0VwRThGUVBPaU1Td1MzQldqTERV?= =?utf-8?B?elFIVnF2cnkxNGpHbEwvblEzaUFlS2hveTNXUUtKbmR3VGVYTlpxZDNTQ1VJ?= =?utf-8?B?Um5LejNQeG9KeGdLZkRpRHhIYkZkYlZQVlRGTXAra0hSNm1mZy9NMDdjWjN6?= =?utf-8?B?YlkzZEJJSEk0bllyRyszckNUclpFUlRpdVdhc2Q2MlorL0tFRlptVGZnYUc0?= =?utf-8?B?UDdNOTNZS3RIbWhoQUxhMjRDMFROWGovUmgvZFpRZkpyUEdPdm1mSXAwcW1D?= =?utf-8?B?Mk9hVEJ0bUc5NWdMS2hPdXNvVVFyakhjVHVDN29CcERtR3ExNHBYbzd3UzJN?= =?utf-8?B?OGhwUFRVa0VQa1ZGaVhKS09yMGJueDJyNVN0eVVqTlFKL1drRzFrS3lZN1lQ?= =?utf-8?B?ZmVna0kxVzdvRGZRcnIyVzVSVVhHbjZoOXdoaktSMVFLWkRpNGJvQmFaenJY?= =?utf-8?B?ZTM2SlJLc0g2d1FwVGdmTmhwcWpIaGFaYlNPSUR4U0NOMlV1dGh2MFkrblUx?= =?utf-8?B?TzNrVWVGdlJ3cXpENVk0MEJvdXdrbzJnM2U4MFYyK3VlNE04UGEzODBMS2xl?= =?utf-8?B?K1BScXlHUmpHUUkyKzU3NWk1clRMV1pDYm16d1lxbjllUmsxdlZNallXeEEz?= =?utf-8?B?QTJ0UnFRb2ZIL1lHbTk5clVHZ1JqZlFEMzc0NnJMU3lVOXo4VkVlQWl1em42?= =?utf-8?B?bHJRSGY2aGYvSUIxU2pUSmtHcGtjSTQvZi9tdGxDTjdSY09pNkhZUXFlbGE3?= =?utf-8?B?T2ZkMTB2VEczMDBqQU1NaGNmY1ZVRXBSNkdFY01Ha2RrS2RwV0hWVWM0QWJ2?= =?utf-8?B?WnVDM1p0cUgrbDZtRGVPOVFMWjc3U1BOZE16ZjYxRjE2THNXZk83dVpHYWdl?= =?utf-8?B?ZHFORWx1WmZBMjhpNjZ5UVNXdXdwY2JvTkhXK3NwRFUvcHJoVUhpWlhkVFBH?= =?utf-8?B?UTZMa3ZvdW1KWkJzUkpwdHdybkN2UTZuZ09WU1haM0hxcU1UcnpITHczNkhX?= =?utf-8?B?V2F0cDU5NkhOR2xWQkNUY2lQdVYrZUl5NzJ5M0ZWUHN0bGdDTkJhV0VwMm5y?= =?utf-8?B?b2w1YjduMUFrazViVEd0MkM2SGVKclhabEc3VFFMdjU4RUZOVmNsUXZvQ3l5?= =?utf-8?B?MklDZWVZOVlIR1QxZjRqSm9vZXl5WUh1Uk95KzVPa1BQRUdiY2tyZDRUUFRZ?= =?utf-8?B?MkIyOVRGN0p3eDdVUDhVZWZIZkMxMktNVU5VenZLMGhMdUJXajM0bmlFQXpE?= =?utf-8?B?bWNsdDZ6bjQwZG9aeTAxT2F4djNISDlWNUkvNjZPZlpRZ0I2b1R5UXRFS3pt?= =?utf-8?B?RHpicFJhMy9UY010b3B1UHI0VGJKVUFUTVBHeGpvd1pFKzZFRmpzVUEvNzdY?= =?utf-8?B?eDQrMi8xY3RiV3hBSGpkZEVWcHF4eWhERldNaW1sUDhWN1BZK3V0Myt6Y1hR?= =?utf-8?Q?Tjdf55sd5zLobh3GUEPM2EQ=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2f64deea-1204-4e80-44f1-08d9fb5ff243 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2022 08:46:15.5533 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kdhDQLFNcgQX4mlRryCXlqovjUkz5WcAh+QZWODcXyQkfL8zaac/3ZraW2sWQo2ISPhI8Yl9HnS6nRbT3c2cJw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5424 On 26.02.2022 11:05, Roger Pau Monne wrote: > --- a/xen/drivers/vpci/msix.c > +++ b/xen/drivers/vpci/msix.c > @@ -198,8 +198,13 @@ static int cf_check msix_read( > if ( !access_allowed(msix->pdev, addr, len) ) > return X86EMUL_OKAY; > > + spin_lock(&msix->pdev->vpci->lock); > if ( VMSIX_ADDR_IN_RANGE(addr, msix->pdev->vpci, VPCI_MSIX_PBA) ) > { > + struct vpci *vpci = msix->pdev->vpci; > + paddr_t base = vmsix_table_addr(vpci, VPCI_MSIX_PBA); > + unsigned int idx = addr - base; > + > /* > * Access to PBA. > * > @@ -207,25 +212,43 @@ static int cf_check msix_read( > * guest address space. If this changes the address will need to be > * translated. > */ > + > + if ( !msix->pba ) > + { > + msix->pba = ioremap(base, vmsix_table_size(vpci, VPCI_MSIX_PBA)); > + if ( !msix->pba ) > + { > + /* > + * If unable to map the PBA return all 1s (all pending): it's > + * likely better to trigger spurious events than drop them. > + */ > + spin_unlock(&vpci->lock); > + gprintk(XENLOG_WARNING, > + "%pp: unable to map MSI-X PBA, report all pending\n", > + msix->pdev); > + return X86EMUL_OKAY; Hmm, this may report more set bits than there are vectors. Which is probably fine, but the comment may want adjusting a little to make clear this is understood and meant to be that way. > + } > + } Imo it would make sense to limit the locked region to around just this check-and-map logic. There's no need for ... > switch ( len ) > { > case 4: > - *data = readl(addr); > + *data = readl(msix->pba + idx); > break; > > case 8: > - *data = readq(addr); > + *data = readq(msix->pba + idx); > break; > > default: > ASSERT_UNREACHABLE(); > break; > } > + spin_unlock(&vpci->lock); ... the actual access to happen under lock, as you remove the mapping only when the device is being removed. I'm inclined to suggest making a helper function, which does an unlocked check, then the ioremap(), then takes the lock and re-checks whether the field's still NULL, and either installs the mapping or (after unlocking) iounmap()s it. > --- a/xen/include/xen/vpci.h > +++ b/xen/include/xen/vpci.h > @@ -127,6 +127,8 @@ struct vpci { > bool enabled : 1; > /* Masked? */ > bool masked : 1; > + /* PBA map */ > + void *pba; Here (and elsewhere as/if applicable) you want to add __iomem, even if this is merely for documentation purposes right now. I think you did mention this elsewhere: Don't we also need to deal with accesses to MMIO covered by the same BAR / page, but falling outside of the MSI-X table and PBA? Jan From xen-devel-bounces@lists.xenproject.org Tue Mar 01 08:55:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 08:55:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281000.479130 (Exim 4.92) (envelope-from ) id 1nOyIF-0000zI-Mz; Tue, 01 Mar 2022 08:55:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281000.479130; Tue, 01 Mar 2022 08:55:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOyIF-0000zB-Jy; Tue, 01 Mar 2022 08:55:39 +0000 Received: by outflank-mailman (input) for mailman id 281000; Tue, 01 Mar 2022 08:55:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOyIE-0000z5-4W for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 08:55:38 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5ca63873-993d-11ec-8539-5f4723681683; Tue, 01 Mar 2022 09:55:37 +0100 (CET) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05lp2172.outbound.protection.outlook.com [104.47.17.172]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-28-GkYsPyKJPLiDnji0F45UfA-1; Tue, 01 Mar 2022 09:55:35 +0100 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by AM0PR04MB4497.eurprd04.prod.outlook.com (2603:10a6:208:6a::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.13; Tue, 1 Mar 2022 08:55:34 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.027; Tue, 1 Mar 2022 08:55:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5ca63873-993d-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1646124936; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=R4Pgof5PQtcWSd4BB7sXGDJ55OaF2iH1mZ5hQRwpEXM=; b=JDo0k/1GgQ/RRlTMc3WTK0YJUZgMX3A18H1LL6MihmPZq6hcz7w/5PddItWxEuWk2rXiP1 As8eZJgHBAmXHDqDvs2Y4qj8XheQRyub/Zg7cNa6lPXEQwHDdA9r8knmU2Qk2UunknOOiH sofWRTr6Qmiw3Ua6V2i/GnSNnoRuiDk= X-MC-Unique: GkYsPyKJPLiDnji0F45UfA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iNK6/qsgiRrauq2Y6QzhSDGroHWMsaDShh/4WHhmJTftwjQg+VcyselGr4chzFrKTrITOPNAOBh5KOA6eBLO9spdLO2DuaKQGyc93mbWpZehlN0XRvwyvk+1I0/KfHzHr3ZnTcT8iLI3znMRMcdBdMwydzgJG5mVBlXYD2SH9Yys0MS1fAyH9QFgjrxKLLsabAl4bOVxOziupkcnNizipChdZ/bILLMX3QTTVbeBr90zmeGtJRMMoYXoWp3fASzqbdTuklqbjVZNp6R1DZls0K2veo37Jh9VdTYR75LFIcUz+FSy8dofJLeecEsoLBLcSRE1ovF4RqI4me8I+pTTpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=R4Pgof5PQtcWSd4BB7sXGDJ55OaF2iH1mZ5hQRwpEXM=; b=R0wA/rNv3JE1hdHynTKnclIunI6xu33m/bsTXln4doAjqHrCaqNJ+yV74aBgYqB4fT6PEGlDvY/JJFFR+McIVt/33OcxZRDqFFUIlJl/FwNquPb9bK5SEOCGwi1bTPJVPVgmnkk7aaSRv5uBoNb1Vilto1SAX/H/9BwPildEJESGxnvbOC8LqlULL2tmKiaCTq94a2kRsLC/l/0GYpdkg/ZVKlfgzYiqxe86zyXOfL5S5gLAhoH3swQ01SU0cNUGdV/NIVlDcFrBQnPoaGQ3skHMrSxIPUDecm8aphpgjdIBbQ3RJNO2SdoASXLZsawIJ9dWEthuWZTlf67tEqJtVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <03851bd4-9202-385f-d991-c9720185c946@suse.com> Date: Tue, 1 Mar 2022 09:55:32 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= From: Jan Beulich Subject: [PATCH] x86: fold sections in final binaries Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM5PR0301CA0017.eurprd03.prod.outlook.com (2603:10a6:206:14::30) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6ffda49a-0a09-4c43-b07d-08d9fb613f24 X-MS-TrafficTypeDiagnostic: AM0PR04MB4497:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KmalUWtGgVI16Papu1zmOORnMpmdzXJbqe3Bs3pgYYYvWneegZGwFyyzuDOVYK73Gr7uqOfjWMX/kwKrnT73M+XPojhlVdCNYQFwsUx2pPqzFNqQG5cjCht6/3QFY30G30U7ez5XO9IO432vmctW5oH0nvu6cBCKwCz7mPWMGhfi1Dns3K0dScAwUGpX/yfCgQuRA3nkPhZ8WdpNAnP1K6EbaaahB2s9hqMDXy6TYVK44Ws9ZMg+pIBY0M5J46fMntq+I+qVabrUSE/vyySqNXsvckyR1br9hEl2My/l622gfD6mJYL70QGMoi+1TJwTfDUDEorib0jwPFPzMf4miHCENalvWL5aF9fYVXaiivrONvf1bIfKjpAlZDr6bibFBOmKYmUaRc5n6EWzZvyDqwbJaHVwd5xP0f3ylf9P/vMe0IvN+F6XSR2RHocKl55bNtZWnFo67Rvaj05jPKIKguuv38DJZb6y0UVMvhEyVyFSxh/8BPY6PeeQk6D904UtTPDc3Fzg+05j5kqdgiuEQCY47RBbZAogSGoSFbv7wTzJ3CoTJ5jZOsg2QQZzTDCb5CRO1xb/FaKbRnZE3cYOnnCnEXNxm/dUIyPDnBuQt65+eMVanVaW3uUR6czizpMmKRz79i34cYyXukfqjS9BGnyyuUvHTG5wUjx+06hDe1hpr+DUHGgNDKgW5sQcjyJphXZGJpm3kBlmaugcjaIMmgyRG1BOVXkR8puJRjd7dSiBOpJJwB0QbsPUtnN3JbhZ X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2906002)(2616005)(26005)(186003)(8936002)(6506007)(6512007)(83380400001)(38100700002)(31686004)(36756003)(8676002)(4326008)(54906003)(66946007)(316002)(66556008)(66476007)(6916009)(6486002)(31696002)(508600001)(5660300002)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZVkwRnJBYXQ0Yit1UVNoYWU1RFNudjlHajRFa0V5eExHSDczWXNjZkMzSUJH?= =?utf-8?B?aDB6WFo1bFkvZUZVVS9TWUdvT0NMN05TV3hsN1ZMUjFTR2Z3eklqNEdNVE9u?= =?utf-8?B?Ym1sVUpnK29hVXJFQk5sd2M2eTNtOTRGMkdUNGpiQUMvdmcrZTAwSDYvS0Rs?= =?utf-8?B?SEVLMEU4ZzdjOTVEVGQrTmp5R2hUajRYam1IUERhdVhyUUNxbW92Zk5JUVJ3?= =?utf-8?B?cFg5NnZOSWw4R0JjSDVRdWVhNEhRUTRBN1FqdnZhbUV1eHJNNkZXR0dQaGVG?= =?utf-8?B?M01nU3pHSGNxTGVoakQ5VC9kWnJmaEJRWDA1OFBoWnpnUTZGSWhvRTdqU1pj?= =?utf-8?B?OUV2Zm5nRlNUMnloQytOZ01ndFhvemRiZlBjWFN6QmJ1Tk9Jbkx1ZTZHbGFJ?= =?utf-8?B?ci8wQ1UycEhCazJPclQwTi9uM1BFQm05TUJFeWNEWVZEcGpwRGhjR2xyTHhv?= =?utf-8?B?elZZSlJJZmhXWVNMWGpHOFh0d3lsTkY2OG9mUytyN0x3UTIraFpwVWZtanhs?= =?utf-8?B?V0FxbEdPbkVlQzBtMkdKUksraUFWVFJXZldjd2c5SlFNM0p1VGVVUDg0c2Vu?= =?utf-8?B?bGd0MytpbnNkb3pVWHRrckxlRkNqeCs2cExCak55TU1IeFpiZTR4U3VDM3F2?= =?utf-8?B?Zmtqb2FKYmdQQkhwS3pmUTZ0ZXZGbkRET2c1bGlZbkNjSTUzbXM1UE00MXhZ?= =?utf-8?B?aU93NndjNlJ3TklmeHo5YUxEc2YwV0QyRjU0ZGVDcU1QbTJXRmhab0lvclJS?= =?utf-8?B?WmpHRi9LTXV4NlQ1dlI5Wi81dUdPRVVtOGMrNHFNT0dqdHZMMHJFYm90RFZt?= =?utf-8?B?ZW9sWGRFWU5PZ09nWFhZdGlyRjNjQWJVU3RlbTZYZVBLU3ZUMzBwR0V2dG94?= =?utf-8?B?OTM2RmZoL25XNTYwRmovRTNFNGpaS3dMMXdPRVNpVHl2TFpvb21lSmV1bU5L?= =?utf-8?B?MWdhdlJVRXdnMWhjazJaWnAvYyszeitoQURXaUduSDBSazVWOGpMY084K3RT?= =?utf-8?B?dWZVSXA3TW42VmxKblJMazg0YjYvdHVVamQwbUJkOXc1L05vOG9vTlYwT3h2?= =?utf-8?B?bkI5UEQ0elhGY0NVRlgyVjVUc0lKMURhQTRnSXFHRHd1RDNuVUZ4Y2NFaWVK?= =?utf-8?B?UExXSmMyNXJiN0VnUEdjblBzMTNXa3EzcExmbEU3TWFscDR6V2d3VjkxcE1N?= =?utf-8?B?Um5yU28xcFhZVms1ZjJCWEZwYUNFeHY0Rlo5c2lBbEZ2SWFVekRjc05SSmhU?= =?utf-8?B?ZkswdURBS3BsVjhlZlcxb2g4V1NZVGhENTVwblR0SGlvZVlIMEdRQTVOOVE0?= =?utf-8?B?Y3ZuRTBBdW93T0V0YklZTHVvQXBjSlNqQWtqWXdDSjFZOHI5WXZMYnI0eGZ0?= =?utf-8?B?ajRuL3FPMHpOdXR3YjFQYWwxd3pqWUZtbWdqam5EWVF0UmdYOGx2cWVrZkpp?= =?utf-8?B?TWt5R0V5b2pGb29wSkRMN0xTdE9ieWhlRkw2bDBOeUc5WWlnV2V6andXTFFl?= =?utf-8?B?V2ViR1RURS9yRFVLT1B5VG9OcnMrbTRxQTB2R3I5ZHMzZWpuZ1NWaTBORE00?= =?utf-8?B?dlhMaFdrZzJsR1ZSWDdRNDUvV1V3ejJobU5lRXhsNVlvYnRVR3BvQWJ1eFR3?= =?utf-8?B?c0tBT1hndDg2K2M5WjRkZGI3Unc4NmVqdk1zZkFjZkpSb21lcy9POGZVdE1R?= =?utf-8?B?Tm0vM1pwcGV0WVdPUDJsODdod3BsWWVVQno3UFlFU2RoaUp4eGwrekdvV1Nw?= =?utf-8?B?M0VYYzBOM3RKUnNJc2NqL2xiSzl3bmRZbmI2TFBtaHQwQnNnekFGM2tLaDFE?= =?utf-8?B?VlJTdHk4cTE4SmI1QnJqNXhKN2lGbTIyK2VQMGNBaTdYdXZFb252OGNrV3A5?= =?utf-8?B?OHlhL2dXdU00ejV2SUNGUi81Mys4K0tKOXc5Sk9rNFU2RHREdGcvYmkxeE1I?= =?utf-8?B?blpDZ0VPdkd3VEhMVXpZSldubWwxVFBvSFY0L3p4bzNYNGx4RmRNS0lqY0Vw?= =?utf-8?B?QVJleFFVSU1KTnFxc1p1eml4NTdyNHRQRDBTNTVNSFhNZFVWZFJEbDdLb2RQ?= =?utf-8?B?cTJMc0J5SUx5cnNEanhVSTBTZm44WTZzS3ZiMTdWcTFReUFyNWZoRk5qTm1O?= =?utf-8?B?NUwwSElUcEF4MHhjT05sdUR2U2srMExMY2lidVkwK1JjSWJ4bDZxc2dXMlJh?= =?utf-8?Q?8ezBtu+8sgOCryHCOfpYBO0=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6ffda49a-0a09-4c43-b07d-08d9fb613f24 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2022 08:55:34.0498 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iU0TLPfUXG+T9lUzjJ2USZqh07nuH4BnVElDs+PvKhY22QniC/JWJuKnj0F7L9Y2f8kJaqTOMyKy/72YIumKUg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4497 Especially when linking a PE binary (xen.efi), standalone output sections are expensive: Often the linker will align the subsequent one on the section alignment boundary (2Mb) when the linker script doesn't otherwise place it. (I haven't been able to derive from observed behavior under what conditions it would not do so.) With gcov enabled (and with gcc11) I'm observing enough sections that, as of quite recently, the resulting image doesn't fit in 16Mb anymore, failing the final ASSERT() in the linker script. (That assertion is slated to go away, but that's a separate change.) Any destructor related sections can be discarded, as we never "exit" the hypervisor. This includes .text.exit, which is referenced from .dtors.*. Constructor related sections need to all be taken care of, not just those with historically used names: .ctors.* and .text.startup is what gcc11 populates. While there re-arrange ordering / sorting to match that used by the linker provided scripts. Finally, for xen.efi only, also discard .note.gnu.*. These are meaningless in a PE binary. Quite likely, while not meaningless there, the section is also of no use in ELF, but keep it there for now. Signed-off-by: Jan Beulich --- TBD: We also use CONSTRUCTORS for an unknown reason. Documentation for ld is quite clear that this is an a.out-only construct. Implementation doesn't look to fully match this for ELF, but I'd nevertheless be inclined to remove its use. --- a/xen/arch/x86/xen.lds.S +++ b/xen/arch/x86/xen.lds.S @@ -194,6 +194,7 @@ SECTIONS #endif _sinittext = .; *(.init.text) + *(.text.startup) _einittext = .; /* * Here are the replacement instructions. The linker sticks them @@ -258,9 +259,10 @@ SECTIONS . = ALIGN(8); __ctors_start = .; - *(.ctors) + *(SORT_BY_INIT_PRIORITY(.init_array.*)) + *(SORT_BY_INIT_PRIORITY(.ctors.*)) *(.init_array) - *(SORT(.init_array.*)) + *(.ctors) __ctors_end = .; } PHDR(text) @@ -404,16 +406,20 @@ SECTIONS /* Sections to be discarded */ /DISCARD/ : { + *(.text.exit) *(.exit.text) *(.exit.data) *(.exitcall.exit) *(.discard) *(.discard.*) *(.eh_frame) + *(.dtors) + *(.dtors.*) #ifdef EFI *(.comment) *(.comment.*) *(.note.Xen) + *(.note.gnu.*) #endif } From xen-devel-bounces@lists.xenproject.org Tue Mar 01 08:58:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 08:58:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281008.479141 (Exim 4.92) (envelope-from ) id 1nOyL7-0001hB-4h; Tue, 01 Mar 2022 08:58:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281008.479141; Tue, 01 Mar 2022 08:58:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOyL7-0001h4-1d; Tue, 01 Mar 2022 08:58:37 +0000 Received: by outflank-mailman (input) for mailman id 281008; Tue, 01 Mar 2022 08:58:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOyL5-0001gu-IZ for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 08:58:35 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c6340794-993d-11ec-8eba-a37418f5ba1a; Tue, 01 Mar 2022 09:58:34 +0100 (CET) Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-db5eur03lp2050.outbound.protection.outlook.com [104.47.10.50]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-10-ZA2Rdo9OP5qZtTan0tyZCA-1; Tue, 01 Mar 2022 09:58:32 +0100 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB3232.eurprd04.prod.outlook.com (2603:10a6:802:8::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.26; Tue, 1 Mar 2022 08:58:30 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.027; Tue, 1 Mar 2022 08:58:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c6340794-993d-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1646125113; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ft3AVtcvWbuURUPNZKVThsgE7AXGBdHKxZGrm8f1zgk=; b=K2MQrowGe6Z1fr+txVI7g32Ex2VdiXSIGB6grnYnzNjYo47DqzcjhhT/S1/4/nV4iWSC3I WUtfP6MTfoHQxgh14baNNq6nM+QtQfN3IpscvtLOv3QxkOe6gMejhocByylFPOG+BN/YFm QzUYMewW0Bpj05a/y3CSuNoSeeBtGv4= X-MC-Unique: ZA2Rdo9OP5qZtTan0tyZCA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nlffrs5h6ZqgxVPq4NFD14z2h+xH8A0bJpz2H3wbi7lwPuP5yeoGYUJ4GUVDoaRmm4i1R+BPodBrWrDTwTon6efrwBHbvsw8bFiyiBVfQg4L6uH3yC/m1Xg6qaLOY0USkugAfr/OaFXFji/lrxTEKHIQSpoJAwguf4QhWuuEl4QTzwqLm0qDr81ARGmqnHJYsB7ZRMEN8LSiWcHbiqh7Eg3JW5dtlJvHZJyWPdyFhvpzO+UbJhUk+TZ47z0Q2B37OeztJsLoNN6/NDv78XeJs/GdYmIZsH/oXdUS2DxLHAru5kYy/OWA3i1dT+q+1nhE8uoxrrTQz02/2wNHKbIOng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ft3AVtcvWbuURUPNZKVThsgE7AXGBdHKxZGrm8f1zgk=; b=CLPJBMJuGGteCMX4SAQQPFL0GLZ02zgrFWBLf0lGViGOR+6jU9Dyo7zgDans8fs1ALLFkcrWfe66D373FH561FnIwO0W5wyaoFX8SiOMPX0VYbpzTqQW+kZVBqAUMPcU5z49LyjimVO4I1na/pitVQZhMp6ZEPQfG8WZFAihVPeiBNsWPs4x4yrJybGp6j6b7GouD9mI1s3/2Np4f+KU53ONqna34nwz68cYxHS3ZX08IZpZg7wcXGeUS74uZEpnb8ed13n8ZFWVAg8gCfGXxHrqRlbpo9RHvXrwuaWjxCcga5FiVYft1NuZqIDAntyFyvyLUOTqHN1JyYhIFyW6jg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <1a4bef81-d29e-97ae-098b-d1e582e5af28@suse.com> Date: Tue, 1 Mar 2022 09:58:28 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH] x86: fold sections in final binaries Content-Language: en-US From: Jan Beulich To: Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , "xen-devel@lists.xenproject.org" References: <03851bd4-9202-385f-d991-c9720185c946@suse.com> In-Reply-To: <03851bd4-9202-385f-d991-c9720185c946@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM5PR0201CA0011.eurprd02.prod.outlook.com (2603:10a6:203:3d::21) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2ff4e34c-82d1-41a5-1301-08d9fb61a884 X-MS-TrafficTypeDiagnostic: VI1PR04MB3232:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: g/cZ0HNSHXdyf/ip8OIHLeiyzZ1wuRowM6ZZAHFABlRlZu7RVxvT5KjEbOGwiVaOBTh6g7+7VtqgXhiilS0oAJogCNLtY9ZCSuJq9Htbx+syeh5f2FBdfgmAV7pqHMt1ahmbWUCiJ2xvTXJZHEOvdETb1U4gb9GwScXTl34ZN3ceDVYUFbcwtPyLeg7X5hKkBFDvDDdyDjqhtE3OkuYY1eUQY9UYUqDjmwyq8GHnGwo/1/bbxP/4YSC+fpyiyJzjU+Uz/wPGmb5NIPwkTRVfZBrz2LwoxMvhgIFJZS5LRCYtzyGRtEgOpL8ZoKn53U/fIAruYeauiVtiIGw5WMfKE7upPZO7ZbKwVmwThGXWV+okyseG7vHWbVMMO+bzqeQpj4CannH/g9oGCvzF/shAxQxEDMiDme3DbOXpQJ2f+7bP3n8gyKfoosjvi3lz/jQceELCn/h1y/58DBjBW3GUhSKZhWjmahp67whPVMu58afKyfJ1nh61n0NYSLYH2wUMfh2HavIJYIeEYajs3MO1sIufLiA1DNbmXpNFBsho5j6TC3iWJT56jSlAARzf1fzdCWBvC271dqAqU9IdFPcGk/f7S3NrXktBnKvbP4mMC5ZgHIwOEgNAVfGnqc1AFYW1HxawwLoc5E2D789Kj1oX+Skhsi7X8lTbc2IgquHzryjS42Q99vfqeAVQOK+ng8veOcmQ1xTf1UwRmWXlNsUeQ+2+xGSkm+y2AdoDOzZBxN2LqG+s5pUvvZquUSHweWb3 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(4326008)(66476007)(66556008)(8676002)(38100700002)(2616005)(66946007)(186003)(26005)(6506007)(6512007)(53546011)(31696002)(83380400001)(508600001)(54906003)(6486002)(316002)(110136005)(86362001)(36756003)(5660300002)(2906002)(31686004)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dXJWMTZIMDE1SndlUUdvTXdWUDdNb0hrajdKT3BlM2VvYkxhUXpTQ1hIazJC?= =?utf-8?B?U0Z3L2t1elZZZDcySENrRENaZmZURFdzbGR2cGY5NGdFcEREdWo3dFJyQVFa?= =?utf-8?B?WUo2V0pzdUc5dnpaNUYzcU5Nd0Q4UW1iRWluNnZNWUJOdHVlMW1UVlZVK2lp?= =?utf-8?B?ZVNHRHVRSWVwU1M1eko0czFBV2xDN1Z2MytVUUxOL24zMno4Sk5KWjZIUHd0?= =?utf-8?B?d004aTU1M3g0RkI0aTVkT0Iwa25wOUZHeFdzaXFVekhtQmNTNERkNlYwZ2ti?= =?utf-8?B?Yk41RExnVERSd1pTak9uU2M5V1BHUk92MHpNV1oxaVJWc05IYjFJQWN0Tk1I?= =?utf-8?B?U2tmRmdtdmhpeElVUUlCcUJJVE9XaHJpYi9LS1hOekxkeXVka2xPYjFOcUkx?= =?utf-8?B?NGZBa1MySTdYVFE2bVEwUEtuVXZZblRRL3BIZmQyVlhmbmUwaUxsbUd2VERU?= =?utf-8?B?RWtYYWZtcm5LOHI4VmU2WU1MTFdnbThmcEdNSWdLakZqWThBUkNzZkFER2hX?= =?utf-8?B?OFhieE85azRIblhWMlJSWVIrZi9tTFkyUHZCUUZsU3JYaVQrWTI3VW5Gay9E?= =?utf-8?B?MHJvdFFjc3Mxc253Y3V1TVpnR0J3MCtIdWE2R2hGMElCRWFkVXBSbVkyNlF4?= =?utf-8?B?Mlo4N05UcnlKTk5wSnluUUNJSnlycVdGZ2tTeVYxMU9Ha2NGNFFyZHhJY0tQ?= =?utf-8?B?bzg0cnpFUnhxTE85bGZRb2VMQnhvdjhKbXdpck9VQTczcnM3UmxmTFcyOWF3?= =?utf-8?B?ZGJTTXlKWWNoYlFpVUYvUFdleW1RbGM3aHRUbWluMHJ3M21VRDFxWjhWZWxa?= =?utf-8?B?N0M3cXAwUjE3YjlJQ1ordDRnR05CT0VDZkdneWovakx0UnZDUHMwRS9Ydnlp?= =?utf-8?B?aUs1RStFYmg5UnV0ZmIrb0FxS2ZTVk03N24rNXY4RlQyK2ZCU0ZkRlJXMGxU?= =?utf-8?B?WUNvRHVyTW9QaDdjVFh4TE5oMUo5VHNiSzcrbko1Q0VMV0xMb2hGa0VvTmpM?= =?utf-8?B?U1NzcVVmRW85enRqQW11b3dmSzVRSzBuL3FWV0U3bE94b3JWWk1Pd21vTEJJ?= =?utf-8?B?Vmx6TVg3Ulh6V3NtemQ1TktaMDFvQzY2a3RMbWhCNE9WVmxyMWVLSTFQcUFi?= =?utf-8?B?SityNGpnNzkxUHlBeERFcGloZThRbHlHSVE3TWhJTlVvcE5kVTRRbzNKczBn?= =?utf-8?B?b2FoMGpUYlI3L3JmSVpCajdSbW80NEVoaUlwaUR4UGx3ei9PeExBcENDTFlZ?= =?utf-8?B?UVExZ1NjQ3J3b2xHTzljNFVUZThjM0FaR1JYOXRrUHVQdWlnNFhuaFdOUExn?= =?utf-8?B?U0dCWEJhMUZnOUkwaEJQaFY5bWFILzBBTEJuWHdsTk0wT21FckpwYzhsdGtr?= =?utf-8?B?VDJZVTZ2ZFJUdWlmdnFqcmtQVVExdkdXZHBST0s0QVBZcjZvd0dmWWU3YWlV?= =?utf-8?B?VHlLOWY2VlpCbDd5TjhLL2c3M0FKTWVJSlh2eWE0TnNwbjVtNHYveEp0Yzdi?= =?utf-8?B?U0lJKzg4czQ0MUN0a05jVjlseG92VUxnQkdnVlJRbmk4T3dBSzVYVkpadWhu?= =?utf-8?B?QkhBeVlkQU94UHBVNi9ZZzdZOEtiTndFOGpOV2VWNlJtMVJqZHV4Z2VLZ01z?= =?utf-8?B?VE1vTFdKUmNVMk5wamYrdVVGUVI4ZDFzTmpteFBzYzFUNlBOamJTVkludmdF?= =?utf-8?B?Nm82ZS9uRXNvWGpXWWhYbW9mSVFrazJPQUVabkNFUW1kam9qYTR6b0RBdEZD?= =?utf-8?B?c05jWnFZL09kOFczbFdnT25MOWxiQ0VBcmJDWUh2T2VvQ0czalNEejZEaW1V?= =?utf-8?B?cnpjelFXeStMN3hRZGltMEN3RmJlQkJUNmIrVmJ0eXFuZzRjclRzSFZtYmVp?= =?utf-8?B?R1BQUGlVS2pvNDRucDhBZy9RcVZaUU00SGh0MHREbTZmd1NnQStPbDlEdjdm?= =?utf-8?B?ZWJiZ25KODc4OUlNNFd1aWNORENUMGJPR0RoSzFsdHRLYXVTMGxhWUthbXY4?= =?utf-8?B?UTdiTjluY2pXQkpad1BDTlNWRGpyaitUZFpJK1k0ZVdKYVRYcHd6dHQxNk1a?= =?utf-8?B?R2tNUldhcGNIdnA2cEpRdkxXMVBMaWJYM2tIbXpuSUdPNUovb2F1WDN4THNG?= =?utf-8?B?Y3R2clVBVU1hYXVYbWU4NnM4QUxjY2dxakxBZHVVT3JiVzJNZXRndDRTazVX?= =?utf-8?Q?mAbh7knCSvXZr4o9/t/yQMo=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2ff4e34c-82d1-41a5-1301-08d9fb61a884 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2022 08:58:30.8200 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: skxtxGh7Vnb8vXk+hn6Bv6T8Tw9y4A/HG04B+DRJKvXmsz/xHw5G2W+HHpp/BI3GKocvtfj5ls6l3NHBIlTQ2w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3232 On 01.03.2022 09:55, Jan Beulich wrote: > Especially when linking a PE binary (xen.efi), standalone output > sections are expensive: Often the linker will align the subsequent one > on the section alignment boundary (2Mb) when the linker script doesn't > otherwise place it. (I haven't been able to derive from observed > behavior under what conditions it would not do so.) > > With gcov enabled (and with gcc11) I'm observing enough sections that, > as of quite recently, the resulting image doesn't fit in 16Mb anymore, > failing the final ASSERT() in the linker script. (That assertion is > slated to go away, but that's a separate change.) > > Any destructor related sections can be discarded, as we never "exit" > the hypervisor. This includes .text.exit, which is referenced from > .dtors.*. Constructor related sections need to all be taken care of, not > just those with historically used names: .ctors.* and .text.startup is > what gcc11 populates. While there re-arrange ordering / sorting to match > that used by the linker provided scripts. > > Finally, for xen.efi only, also discard .note.gnu.*. These are > meaningless in a PE binary. Quite likely, while not meaningless there, > the section is also of no use in ELF, but keep it there for now. > > Signed-off-by: Jan Beulich Some of this will likely want mirroring to Arm as well, even if xen.efi there isn't produced by the linker. Sections are better properly folded even for ELF, and constructors not ending up in [__ctors_start,__ctors_end) can surely not do any good. Jan > --- > TBD: We also use CONSTRUCTORS for an unknown reason. Documentation for > ld is quite clear that this is an a.out-only construct. > Implementation doesn't look to fully match this for ELF, but I'd > nevertheless be inclined to remove its use. > > --- a/xen/arch/x86/xen.lds.S > +++ b/xen/arch/x86/xen.lds.S > @@ -194,6 +194,7 @@ SECTIONS > #endif > _sinittext = .; > *(.init.text) > + *(.text.startup) > _einittext = .; > /* > * Here are the replacement instructions. The linker sticks them > @@ -258,9 +259,10 @@ SECTIONS > > . = ALIGN(8); > __ctors_start = .; > - *(.ctors) > + *(SORT_BY_INIT_PRIORITY(.init_array.*)) > + *(SORT_BY_INIT_PRIORITY(.ctors.*)) > *(.init_array) > - *(SORT(.init_array.*)) > + *(.ctors) > __ctors_end = .; > } PHDR(text) > > @@ -404,16 +406,20 @@ SECTIONS > > /* Sections to be discarded */ > /DISCARD/ : { > + *(.text.exit) > *(.exit.text) > *(.exit.data) > *(.exitcall.exit) > *(.discard) > *(.discard.*) > *(.eh_frame) > + *(.dtors) > + *(.dtors.*) > #ifdef EFI > *(.comment) > *(.comment.*) > *(.note.Xen) > + *(.note.gnu.*) > #endif > } > > > From xen-devel-bounces@lists.xenproject.org Tue Mar 01 09:07:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 09:07:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281017.479158 (Exim 4.92) (envelope-from ) id 1nOyTI-0003KD-2Q; Tue, 01 Mar 2022 09:07:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281017.479158; Tue, 01 Mar 2022 09:07:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOyTH-0003K6-Uj; Tue, 01 Mar 2022 09:07:03 +0000 Received: by outflank-mailman (input) for mailman id 281017; Tue, 01 Mar 2022 09:07:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOyTG-0003Jk-2Z for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 09:07:02 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f452db46-993e-11ec-8539-5f4723681683; Tue, 01 Mar 2022 10:07:00 +0100 (CET) Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-db5eur03lp2053.outbound.protection.outlook.com [104.47.10.53]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-36-LAZ0_ON-OZCYelWsRSRWWg-1; Tue, 01 Mar 2022 10:06:59 +0100 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by AM6PR04MB5815.eurprd04.prod.outlook.com (2603:10a6:20b:b0::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.26; Tue, 1 Mar 2022 09:06:58 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.027; Tue, 1 Mar 2022 09:06:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f452db46-993e-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1646125620; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hiU/P7w+AsXchWwmyxNqYBVb2zOqDmIi1c2BNpDN8n8=; b=Jb/Mi0yJBHdE/4/Tan0VgdAGmxdxKAZ4MDrIICoBoKG/Za7TcBmcc7l+UFfwCMS7zytQko CaUNb4tqQAgzfCwmtpf5OIw80XJn72ik23FBsG80h2CQxJoBuKmKTFrJZjcb85k9ymeunF kpgjjkqgPODOlfnVDoz5lKhaJONVD8E= X-MC-Unique: LAZ0_ON-OZCYelWsRSRWWg-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lzVY3g7SNEC2FzJuBBHsADuFntmAl+NG2lZuOSXXJFW0T9pGOkwqJiy7twaeo6CXlg+cFYww6Sn2cUiAWBpo11S8IG+/O4SGevLyZ1c9CJVgTpQBBoAOQrkRN+EB5qSRr+PhPFh5okWHoPvBSrToDgPCyN25TaHRnFhQ4boDzZz82NUVMpYs2HNAL+nH8VOcVk4NalYnn3W+aPVlwHk4clLK7xvAvRSathU889/Ji3NXwbLrZDxZ87iCin3SXvzlDENK3B+8AcxHs+FTpD2Fpcv/xeYTUGmZSbdPmdKlG0yMzUfPVJvVHXh7VoK7H/Ec72rZTopsB1f0hD9mkAd0CQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hiU/P7w+AsXchWwmyxNqYBVb2zOqDmIi1c2BNpDN8n8=; b=QaFnHckwi66g3bf7r3E/gEebp4DXxL+8OKsUG9kfN/+78iicLoa0PfP0kt8CQTz67GzeZ0p71805W7O4zUXy4gA+RaOxc6kyREvNECKqkqpapg0gh2m+AS59eSR0XqsZZ+fM5Ndvy3uuabKGx/68Eaxw1yTmGyybuNZrWzZ4/JEkhKhQINxTG07Kc5Ka8bLzmcWH8CmKOZ1zrY3QLjGzjnJxS+tJNy5r+tpDjLuwlafg4Qn111TrZVU4ysIF4iZR9p32TauJI6nNuCgbzOnbzvG1F65ptqsWm9n1vS7+RWtzh6ZIA/jXxY7U0oeWxfP53lp1zu6l/er98Et7u0HgmQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <2fffce8d-f462-a832-f323-87c93bcecf2a@suse.com> Date: Tue, 1 Mar 2022 10:06:57 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 From: Jan Beulich Subject: [PATCH v2] docs: correct "gnttab=" documented default To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0038.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::14) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 17585542-1bfe-4bf7-741a-08d9fb62d715 X-MS-TrafficTypeDiagnostic: AM6PR04MB5815:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: a0yXezymj15GpZVejotvReF9N44c0vlS0V0XltJixww2raMDdWWs3vtdY+GqZlnEQkO6Kwn3w4POve0eUztA+MBRUtryETwJ/nzT3SysjkDyo0FGVZMOozOqX1cplLi3mu4w+Q1Qypx67NFPs829gJVuZFwXNa9qms9FoQw4zqQ+koIwe25Ck50KWGs3uyngtHjEx9BbambRDPpvvVrB9bdWwp3O8QWDPnY8EmxqwiDtjVVC0yHDoZH3XwHTtYkLk73V4Q0/MyPczUR4GqooySQodY0APTjgBdZcU5G/9pEcwvLdxNKu7LEn/8klkY/Mg1co+J9NxDcArvcxcDyV9apBF702Tw+Nvu01yRSPU0TqQBmrvuLOIYNlB53Pp8C4zsNpMraJ83SKlRZf48XwWV3cZoGtt8c8RSrbhoLfgpbqYX2jgmMBopicW4JsGJlBY6oqBYxw56K4P4f9Xod5C696iO1LCx/sDG8bhOw7usA/lR1EFwHYiFoZuSl5kMnOf89az9fAbMvn7U3Va/hOiB+z8ECajSPz5PhX715GUhFLsua1AddEUEV7eZ9g4wrJ7oUs/A4w8LmqMR7D7gDnYS+88ZDH0/e7lGmCthLDaOqf35z98yH7GHz5BaYtltbDa7Dbs1DxQ7QKmtvqQ2um3TFg5i1xKahDb9byU6U/5aQxjhsZ3LMVQJlMHux15XICOpFNKfD4EzqCDxGBx9J7xDZEzNQqyWo/IUMyY7mtoSy5GTH07X7nXnNJlLuLEo5L X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2906002)(5660300002)(83380400001)(36756003)(86362001)(6512007)(6506007)(8936002)(31686004)(4326008)(2616005)(8676002)(6486002)(38100700002)(26005)(186003)(508600001)(31696002)(54906003)(66476007)(66556008)(66946007)(6916009)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MXZEUVRlMnFuYTR2blpuZWRUQ0Q5QTFGb2NjMG1lcTRuWUY4WXpqc2N0aFh6?= =?utf-8?B?c2JBQVhheS9CMnVQZFZndmUvaTZpZG5aMmNDeGNPekJTTmg3UzhiYUpSdWVF?= =?utf-8?B?OHo3SE56akRMd0gzYjF2MlMzTnhBNEdSVmNyTDJ0Z3Q5TGZBc3lXaWgrNXY0?= =?utf-8?B?enJ6VGJxaDFTaWRlMGRtd1ZlN0NLZkhjSCthMWJOdmVEY2VWRUhYZHRPMS9k?= =?utf-8?B?eDRDMFdiQXU2emlyWmErdmdaT25lVlVhRWMwb1NtWWQzRnRiNkE5N21kcWV3?= =?utf-8?B?MFA4aUJPVDdrdzBrdGpKVXpsdmZHRnl6UFdsSURtNEoxZWtETEp4Z2NRcUNX?= =?utf-8?B?aSt2eTJBcEFkdU5tRk5ISGxuK0pRUFVvTXF1WFRObnVsNlBlN3pobmZTbE5G?= =?utf-8?B?R3ZLSEUzNHZqY1NGSDF1TEpBejRXN1NNc1NZcTE1MTdIUG5xdWNxNk1reXVq?= =?utf-8?B?T0o1SGZmTStpanlZbzhRSmpxQmR6QW52OUY1T1ZNYmk2aTRLMjVBWWxGWTlz?= =?utf-8?B?cWRCa1c0YkhmTC9MaXZrNkpvSzVZL0VoMzZIandEcHJIQ1NISUdPMWRUMXk5?= =?utf-8?B?RmV6NGpaVXNtc09HSVIzQVFGZHdmeXNkbm5nS05ybWtEckhrYmxzQlIxWldn?= =?utf-8?B?VlJScmJxNHEwMEwrZWpsZ2gxVlZNN2o3eDBNK0YwbjBLRGtTdDlhOTZuajJZ?= =?utf-8?B?dWw2NVE3b05kZVdvaEJiNjBTdTZxYTd5alN2Tm1mRyt5cGRHME9MU1Q1Tm1m?= =?utf-8?B?K3BnUzZOUlduek9scHUvVFlFVG1XOFBBL1JmbDl1R1V4THFpNXNyNm5ocnZ5?= =?utf-8?B?UWpvUGJ5cnVNKzhZVUFCR2V1dlZ0Uy9xTy8yK1k3V0JOMmQxZHpnek5zODRx?= =?utf-8?B?MHpFUmZBd0dYYmw3bG15SEV1RmE5a1AwNG9obFBqUkwvdFNDT2NVS0FobVR6?= =?utf-8?B?RDhQUTFUSG1aY21EYUFtQW1sTUZnNnRvS1BVVzdWRU1hRzd2WUhTbTNnbE90?= =?utf-8?B?MXpsMFdtUUpTcDI1TDZEZE5uVXpPQUlMNlBMV2Q2UXpNTUJqbXhsdEZMNDJK?= =?utf-8?B?Sm0wZytEeWx2UzcwTlA2US9DNGNtcHFsYUx0ZmdmSWpTTzJYakhjNmdWSFg2?= =?utf-8?B?NkM5NXBiY0JTczN6eDRXVmtmZ0dpMmtEemFmVkNmaThDVkdmZlJlNW9QS3lI?= =?utf-8?B?SUVVaDh1ekYwcXh5aStnOWRrYXBITlF5NEpCT25qNk83YVFEYmdyYUlTQmEy?= =?utf-8?B?aHZpUEdoa1ppMkhaYkUxWC9XK0RZamhSUERwSEt1NEs2UXZxZkh4Um9kN1RE?= =?utf-8?B?ekFqbWpMZUZKOEJZRU9zOVFtWUpTSzh1M2ZOSzVZUnlJVno3d2tlaWcrTVl2?= =?utf-8?B?M1YrTTJHSllzTlZZUlUwdk5BMWtkWGVGeFNIdFdCUkNkRTE2L25mZEtZdHRJ?= =?utf-8?B?Ykx4U2s1Rm45Q2lWN2R2VkNDcHlOZ3FMWk10Q0RlUzgrSGxHNVozaHlWeHVh?= =?utf-8?B?d255c3RvbEpRYXkxZ0hQZmVHM1FyMHFnQ3lXa1kvZ09TSng1T1d5bGQwZlV5?= =?utf-8?B?d0hibzNHcS92bnloNFhRVHc2QjJ1ZWRNcFJDV2NCL3NHSkFSaUVFOS9nVnZF?= =?utf-8?B?TmFaQ1NZZTBiN1YzWGo2UXZCamNESGNicTJubVpocUNUQ2psaDZDZlZEaFJX?= =?utf-8?B?K1g0bHQ5VHViWGVUT1JGSnVMZGdtTU5aZkowSGFFMWJtN2EzOFEwSUZndHRo?= =?utf-8?B?VjU1eEh5TCs0K0Z2b0FLb2h2ejBxZ05mVmdIZlo2T1hXOHJqV20raStpVG1j?= =?utf-8?B?SERvOUh2LzljWUNyK0s2NzByYzJkV1BtNWxHOXc2OUtVbHRMTGNkY001NkxX?= =?utf-8?B?SHhLbjIwRVd2ZnVkcUh2NmcrWjBQVU55d3Bsb25NK2ZxNkpvMzEwUFQrMzdn?= =?utf-8?B?M0d5cFhtMHJ4bTV4Mzh5REc4c3MvVW1jNm14OFdFVUdlaWRnY2ZhUDQ0aDNn?= =?utf-8?B?YmZNSkQ5ZHVhM1AwTnhKVSs2Mno5Q3M3NnlCM0h1MFVSVE16SEtRWGxlS3o2?= =?utf-8?B?L2NOdzhqK3BkaXFkZVhSNWcreUJFTHRPa3puaVlIY1g0MW91MWM5ME53Ymts?= =?utf-8?B?RmY2N1dxTnRGVld1UlFwczJEeDJraC8rT1ovcHc3V1FnSk5KcmwvQ0xIYVJN?= =?utf-8?Q?8zjcIzLvZ+SBu2iZdQzJHAE=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 17585542-1bfe-4bf7-741a-08d9fb62d715 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2022 09:06:58.4447 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: s5UYzC5QHZtDyA+vvpWiVBN2/68kAmgZk2jmG770cj9+7hSfMmxOASTVZnoOtw3Uwj1HTjIBDxblFQyAMM8JsA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5815 Defaults differ for Arm and x86, not the least because of v2 not even being security supported on Arm. Also drop a bogus sentence from gnttab_max_maptrack_frames, which was presumably mistakenly cloned from gnttab_max_frames (albeit even there what is being said is neither very precise nor very useful imo). Signed-off-by: Jan Beulich Acked-by: Julien Grall --- v2: Split x86 PV and HVM. --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -1177,7 +1177,9 @@ Specify which console gdbstub should use ### gnttab > `= List of [ max-ver:, transitive=, transfer= ]` -> Default: `gnttab=max-ver:2,transitive,transfer` +> Default (Arm): `gnttab=max-ver:1` +> Default (x86,PV): `gnttab=max-ver:2,transitive,transfer` +> Default (x86,HVM): `gnttab=max-ver:2,transitive` Control various aspects of the grant table behaviour available to guests. @@ -1217,8 +1219,6 @@ Specify the maximum number of frames to maptrack array. This value is an upper boundary of the per-domain value settable via Xen tools. -Dom0 is using this value for sizing its maptrack table. - ### global-pages = From xen-devel-bounces@lists.xenproject.org Tue Mar 01 09:08:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 09:08:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281027.479169 (Exim 4.92) (envelope-from ) id 1nOyUn-0003xh-H7; Tue, 01 Mar 2022 09:08:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281027.479169; Tue, 01 Mar 2022 09:08:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOyUn-0003xa-Dw; Tue, 01 Mar 2022 09:08:37 +0000 Received: by outflank-mailman (input) for mailman id 281027; Tue, 01 Mar 2022 09:08:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOyUm-0003xN-LJ for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 09:08:36 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2b6a561a-993f-11ec-8539-5f4723681683; Tue, 01 Mar 2022 10:08:34 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2b6a561a-993f-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1646125714; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=jtaHO/6yv8fud/lDlGDMwHCV2yhz0Ye4vvTfd/lzXac=; b=cc2zjPm+G/PpglAfgooTz/J12sjuXJX79TepyJeQt2HhaIQxpEyEowee fRvc+YSRGB0q9PPrxvinaFGF+FbqlkWQ5oBn/HDnnjWvbkajyMx6CHHwZ jqcbwJKNsmcAyOGAPIKcOt3WBmdOObPwNdknCtWBl8gLrS28sng/8M0FO c=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com X-SBRS: 5.1 X-MesageID: 67485720 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:rUKaeqB5kOv34hVW/w3jw5YqxClBgxIJ4kV8jS/XYbTApD92hTMHx jccXG7Qbv+DYTb2eI8gYYm08UkDu5SGyIBkQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHWeIdA970Ug5w7Vh29Yx6TSEK1jlV e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhO5 d8XlqTzcj4MN5zoqdkUdiVFPgRhaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us 6ZCcXZUM07F17neLLGTE4GAguw5K8bmJsUHs2xIxjDFF/c2B5vERs0m4PcGg2tg258URZ4yY eIEdjszQzvBPyRpN2UtWJES27izpFPGJmgwRFW9+vNsvjm7IBZK+KjgNp/Zd8KHQe1Rn12Ev STW8mLhGBYYOdeDjz2f/RqEmu/OhmX6Q8QbTLmj8fhCj1iax2hVAxoTPXO5q/Skjk+1W/pEN lcZvCEpqMAPGFeDF4enGUfi+Tjd40BaC4E4//AGBB+l9YfeuSWhRVM9azdwTO0bveoKWBEPy Qrc9z/2PgBHvLqQQHOb076bqzKuJCQYRVM/iT84oRgtuIe6/txq5v7bZpM6SfPu0IWpcd3l6 23S9EADa6MvYdnnPklR1XTOmHqSq5fAVWbZDS2HDzv+vmuViGNIDrFECGQ3D94ddO51rXHb5 RDofvRyCshUVflhcwTXHY0w8EmBvartDdElqQcH82Md3zqs4WW/Wotb/StzIkxkWu5dJ2O3O BCI518IvcYCVJdPUUORS9jqYyjN5fK9fekJq9iONoYeCnSPXFXvEN5Sib64gDm2zRlEfVAXM paHa8e8ZUv2+ow8pAdas9w1iOdxrghnnDu7bcmik3yPjOrPDFbIGOxtGAbfMYgEAFas/Vy9H yB3bJDRlX2ykYTWP0HqzGLkBQtSfChjWMuv8JQ/myzqClMOJVzNwsT5mNsJU4dkg75UhqHP+ HS8UVVf013xmTvMLgDiV5ypQOqHsUpXxZ7jARERAA== IronPort-HdrOrdr: A9a23:/bwf7Kj0kXKi9WQp0XAEYd+c+3BQXzZ13DAbv31ZSRFFG/FwyP rAoB1L73PJYWgqNU3I+ergBEGBKUmskqKdxbNhR4tKPTOWw1dASbsN0WKM+UyDJ8STzJ856U 4kSdkCNDSSNykFsS+Z2njALz9I+rDum8rJ9ITjJjVWPHlXgslbnnhE422gYytLrWd9dP4E/M 323Ls6m9PsQwVfUu2LQl0+G8TTrdzCk5zrJTYAGh4c8QGLyRel8qTzHRS01goXF2on+8ZozU H11yjCoomzufCyzRHRk0fV8pRtgdPkjv9OHtaFhMQ5IijlziyoeINicbufuy1dmpDm1H8a1P 335zswNcV67H3cOkmzvBvWwgHllA0j7nfzoGXo9UfLkIjcfnYXGsBBjYVWfl/y8Ew7puxx16 pNwiawq4dXJQmoplWw2/H4EzVR0makq3srluAey1ZFV5EFVbNXpYsDuGtIDZY7Gj7g4oxPKp giMCjl3ocZTbqmVQGZgoE2q+bcHkjbXy32CHTqg/blnAS/xxtCvgglLM92pAZ0yHtycegH2w 3+CNUZqFh/dL5mUUtDPpZzfSKWMB27ffueChPlHbzYfJt3SU4l7aSHpYkI2A== X-IronPort-AV: E=Sophos;i="5.90,145,1643691600"; d="scan'208";a="67485720" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GUU6ztCNxhRi+078GXNnr6PR/+2w0XUyxyHtKAJGvxKNopyvvILyuuMPTPdUqufTbY/ck4AGenarqoIoVwLldYRQa9bIfmEobWFA2E1hQSpUsluxqPQOlaP+gCDYxzY0CZvlIRDki1RSrZuDwk8wVpvNoKwVPOn8bEMjS1pFT++5kmtx3+3XD4iLlxx7G9nXVrWgG83KSp06j58AHrbN51sH9RCMlQQ6gQkEJeo56u7yg5iKfMKgYSI41V3tTpGaKdH039w94dl/oZQwmNyJe9JSTSM8MstxkbJKbHG3000MFR2xuhx9kR7iUDBXkiagOFA+5F6oTJ6lX2CxITesMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T8fnzI4GTrw9523cEd4RFODQB3qr1XuIkTA83vsrJqM=; b=mX/ADKwkK7oTvl7kA+1P7hqNr4g9BgbnbT+QCrgj0lzQtkniQWnCUYKyXLL+iPwY4yehkwDQpPESKpv9AWQlOLFTf0OuZX+Bvi6CuzvAG+41iMnDloD411hyu8Si5/GtAS3KdPA+ys59xT+ttaG3GgcymIzCcr+sUdQ2PoUGhto9dOqbShpromaSR81ljDB7ZZtCpfLlQnMn8hIS8rdvO16XeAJdLS3EozU6jZODEX1Xzau80j32wPk+mb0+yvkcl2qFjSo9UEEI1iFhlQWwsOJSNSGTVnla5wP3fb6Rpomxm2nS/0JAtgFAOjKy9rTe6kWN/EDbfbcEBMCaZH2vzQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T8fnzI4GTrw9523cEd4RFODQB3qr1XuIkTA83vsrJqM=; b=QyFeJyc/mbZ/snlA617vD0ELUIMF/PnLKkfFdo2YFl3+lSMcS8b59PEZ9Ng+im1bZQEtWzPPC+G673oc6c0eIqbPlJOIdcHwuZq6W4xvpkPUHRj2J48XtzP5CIYz+cjjueWGtkKrahXMUQ1p8SBl/waZgTXdAUx66TTd4JOGT+A= Date: Tue, 1 Mar 2022 10:08:19 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich CC: Alex Olson , Subject: Re: [PATCH v2.1 2/2] vpci/msix: fix PBA accesses Message-ID: References: <20220226100554.2664-1-roger.pau@citrix.com> <8597cd20-4d79-0f5f-8370-d2353e7116f7@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <8597cd20-4d79-0f5f-8370-d2353e7116f7@suse.com> X-ClientProxiedBy: MR1P264CA0085.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:3f::16) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1cf0202e-27d6-49f5-1019-08d9fb630aa6 X-MS-TrafficTypeDiagnostic: CH0PR03MB6099:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4BFVsLTExQXoDluL+RcpPtOrI7tY2Ejp5h3c3JMBL6wiPn2XegRkoGHMNDRbl2ZXVwejErq9FHxLOcHUhp/E2B5X9QSO9WuR1NIzaSwAHKWAGx8kUke41QjQdtJhImAa5Y1ZxfyUiPX3WeImHJuQKZiBoybG+4e+ISN495ABp1QbWunexh3E/C5sPHhzPhzVua2oF0aD/eAhRRkztRpACvw1U52WhYVe/L5gVuUjq1KPb8JZ0kJCbrlbTdFRp7GUEwW/OWj6rvB6NTls0tfydD0kAC5oWHix1M/FeGM9xHi8mg+ra5GCAVfMXGhQ7ihN4xeZAEf+gKEWDjt+BlHIunL1g206oTLCEAO/ytGvAkb1q7LhJfGGP0/GOPshSkphAD5KiUoYH3cey0EPwn/BGd11uugt7Fw2re2CjqnSwaSthUP0AWt9MYXX0T3x26mdA5uuu+r8XOLc6roSLnFfvCZ0pbsmJg5s17ifpFv7CdKW4hgELjjP7tzXVTIrD8sQA0dhR/h3WcHZ7nbGLXHqSQp7D0PW5RwqAmtaSDHVBgNdWlCcKtWfQzlJ6wVGDx+xvCNil39+Om3BfvoKFw5YD2j659EyUhxPV0MbNNpmjxNsyHF6kvcXpCJXaYz8IMgkh8YQsXAoOdb5zEbgtmAioHigL8G9Kt2MMMYs5X/x2+cUAvf7k+ZhOyTB/EU0p5v7UlYqD/DHRT7GkYzKKw/YQ9yy75a3FV7s0NOtsUMMWJs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(2906002)(966005)(66946007)(8676002)(6486002)(4326008)(508600001)(66476007)(66556008)(85182001)(8936002)(5660300002)(6666004)(9686003)(6916009)(53546011)(316002)(33716001)(6506007)(6512007)(186003)(38100700002)(83380400001)(82960400001)(26005)(86362001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q1VxbnJ4UzQxUmZLMkgwelEzcnZZYW9oNjlnNHM5ay9Pa1o2SzlHMjJaMUZo?= =?utf-8?B?aFIrcWJwYXVXRDIxZys5Y2JuS3dhbms4MXVHREFrQ2hhazYvSFNHV0VSWThI?= =?utf-8?B?VTJTL21qRmFJb0t0YzFBWHp2bjR5RzZSck53NTdnazBWMUtYOW00REthSU14?= =?utf-8?B?ZXRBZDBob3VZRG5OVU9xcXJ2TXcvdjh2a1lRbW43MW1Ob2x0SEFoTWNOUjl1?= =?utf-8?B?NDVSWHNpR2pYS1dEWm5oSFE5Q3hzWmFmUHYvMUxQRWxuVDROaTRQbXBvSTEy?= =?utf-8?B?SXVJRmNsdlZCVjVEY2xaN05POUFscVFscWtoY01ueVlLalpMSTFONGJMRW5k?= =?utf-8?B?M0FsYVNiL1pvZ2wvTEp1MlBMZEd4SmdZMDNPT3AreGtXcm1yUGRhWnlEQ0VF?= =?utf-8?B?WWdNZzA0S1lxaVUyVnVuakFIbUR0bTlIcUFoajNDSWdZdm1nNVA1aVBETjJG?= =?utf-8?B?S000Y2NlWWU4QWlnNThFbnhzdllmWUh4L2R3N094MHg4MEE1K3ovTlhnT1c3?= =?utf-8?B?WUphcXNIZGgrRXZJekdQTDZ5eUFBcXJlNS8rSDJFWHJSejNzYUxqcFpNMGVz?= =?utf-8?B?TXlQbHhGdi9IWUEvZGdRR0xMMkxSamdrLzVZSDBPM3laV3ZjUjB4TWc1Y25l?= =?utf-8?B?Z3RyVFl4NU14cTdicjdXRmdZYnJRYVZzSklLcEw2Nmtyb3ZEeXNrNHFNc05h?= =?utf-8?B?OHZ5VXdvSUc5bm5LUXpwR1o0ZjFBSVhKTzFjeDBVMzFGendiYWVtNzI5Q1Ex?= =?utf-8?B?VDN1SzVQK3JUalFtTi9ZU3RMenZIZFNaUE1wZjQrZ291QlFxZjRkUmRaTXB6?= =?utf-8?B?d2tOcTF0T3lQNURXNGtPOVFZQ3FIMldSUko0SkphMGtwdGRpbE5pTDNGY3d3?= =?utf-8?B?dUxpeWg5YS9WQnF1ZnRlWkNPRFFvY0czZEpVM3dPRzF3ZklsT04wdGV3NzJr?= =?utf-8?B?aWhPQ3N5aTFaaStYaXNHMDRHUG9CUkJMelBsR0Y2TzFkN1YxWWZRQjdwc2ls?= =?utf-8?B?RDN6VnpXSXdiejNESnl6Q2Nja0hJdGx1V04ycjRpakp4dktDMXNoNTJyOVB6?= =?utf-8?B?UlUzRUJwa1RjWCtveCtNZ1RhdDR4dmt2NTM2TVh6K3ZvSXBQUnZXQTVySGpt?= =?utf-8?B?bS9FR0tJNURGcXFVVnBUUzI1WWhLdmFqcG44OFRJZkVQYng5WFRvdzRxUmc1?= =?utf-8?B?VXlJVlhrMGNBSVdBRmdFN0ZJcUtBZDhpOXFCdFhJc0E0cFlmRzJTdUFyV3hP?= =?utf-8?B?Zm0zMDZRdnQyUllpQ2tNTjRYTGNjbDI4TGcyZGJaekhFN2ZPZkhvZzNjV0JL?= =?utf-8?B?bUtISjBhVnd4TVZRczNpWU5wUmFmWXdPeDVPTExsM1pTYllrdXliRUViODBj?= =?utf-8?B?WUZHWkx0dVlPMFFqMWRZbWZmMEdTR0FoSVM1TUV6MTlJeXE3TDFRQmpsSTNl?= =?utf-8?B?WEdaVDJHVmYxNFNLZ0NQSUltY2V0S0NKUUlST1VERUhZZWNuSGQ1eXRtWU1i?= =?utf-8?B?K3RXZ0VLS3NWV3ZSYzF3R1hqajg2eXNhKzhTT3R5NXE1SmNxaGxZUXc0alFa?= =?utf-8?B?c2xEaTcxdzVocnM2UE10THJOWDFzMnpUSGpsUm1heGVWaTRIbVZvaE5SNjVM?= =?utf-8?B?RjF6R0s1NEtpOWRGYmtleXBGZW5hREQrZSs5M0RLYkNXcU5USzNtcFVBWHYx?= =?utf-8?B?TVUwY1ZzZDRzSzV5Sk1sdXhncHNXRTJycmlhMHZPMEZDSTdUSlk5QjZWV25H?= =?utf-8?B?YkdKWXZDRENsREdUdEQrTkN2MHJwVmJ5RWFxdFJQajBqa0ZycWxOU1lvMzBK?= =?utf-8?B?K3dETzFBZWJnUlBMaStoNklVdU9abVVNWmhzTU1vUmU3UVpQYnMvTjNoSGxr?= =?utf-8?B?N0hyRGZFNXdmK3ZQRmRGbmtlK2ZycVpHQWpOV0YzVEJDeWVISUxvRXpYNXRH?= =?utf-8?B?R01nbWxSbDZuRjBHMlpLdzk2cGpmNm4zWjRXWDl5WlkreDBMandSc2NwMlh5?= =?utf-8?B?Z2l1andXVm8yU0gwajJmcEwzWEFaUVRWRnFhckx5RGxkb0Z1bWhwT0trTy84?= =?utf-8?B?YWlIb1Mrd0loZWN1T1lDcjBRa2JiMGxWaTBwZkQwQkpINk04RzhXSEdKRUho?= =?utf-8?B?V1Q1TVh0SEtPWi9OTFJmdkJ1QXRwVG5MMDdoUVhEd25MWVNnOHpDSEFLRGpj?= =?utf-8?Q?5+7IsfFB/dDkyquUY9++XxU=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 1cf0202e-27d6-49f5-1019-08d9fb630aa6 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2022 09:08:25.0656 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0XsJ3V9DMn9wFtQTVfQ+cREKQku8NAtRrvyYz/HCXhWL9IStm5Uk5He693xLhYxZ4HqklJF7IEhT5wCwP9Egwg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR03MB6099 X-OriginatorOrg: citrix.com On Tue, Mar 01, 2022 at 09:46:13AM +0100, Jan Beulich wrote: > On 26.02.2022 11:05, Roger Pau Monne wrote: > > --- a/xen/drivers/vpci/msix.c > > +++ b/xen/drivers/vpci/msix.c > > @@ -198,8 +198,13 @@ static int cf_check msix_read( > > if ( !access_allowed(msix->pdev, addr, len) ) > > return X86EMUL_OKAY; > > > > + spin_lock(&msix->pdev->vpci->lock); > > if ( VMSIX_ADDR_IN_RANGE(addr, msix->pdev->vpci, VPCI_MSIX_PBA) ) > > { > > + struct vpci *vpci = msix->pdev->vpci; > > + paddr_t base = vmsix_table_addr(vpci, VPCI_MSIX_PBA); > > + unsigned int idx = addr - base; > > + > > /* > > * Access to PBA. > > * > > @@ -207,25 +212,43 @@ static int cf_check msix_read( > > * guest address space. If this changes the address will need to be > > * translated. > > */ > > + > > + if ( !msix->pba ) > > + { > > + msix->pba = ioremap(base, vmsix_table_size(vpci, VPCI_MSIX_PBA)); > > + if ( !msix->pba ) > > + { > > + /* > > + * If unable to map the PBA return all 1s (all pending): it's > > + * likely better to trigger spurious events than drop them. > > + */ > > + spin_unlock(&vpci->lock); > > + gprintk(XENLOG_WARNING, > > + "%pp: unable to map MSI-X PBA, report all pending\n", > > + msix->pdev); > > + return X86EMUL_OKAY; > > Hmm, this may report more set bits than there are vectors. Which is > probably fine, but the comment may want adjusting a little to make > clear this is understood and meant to be that way. Yes, it could return more bits than vectors, but that area is also part of the PBA (as the end is aligned to 8 bytes). I will adjust the comment. > > + } > > + } > > Imo it would make sense to limit the locked region to around just this > check-and-map logic. There's no need for ... > > > switch ( len ) > > { > > case 4: > > - *data = readl(addr); > > + *data = readl(msix->pba + idx); > > break; > > > > case 8: > > - *data = readq(addr); > > + *data = readq(msix->pba + idx); > > break; > > > > default: > > ASSERT_UNREACHABLE(); > > break; > > } > > + spin_unlock(&vpci->lock); > > ... the actual access to happen under lock, as you remove the mapping > only when the device is being removed. I'm inclined to suggest making > a helper function, which does an unlocked check, then the ioremap(), > then takes the lock and re-checks whether the field's still NULL, and > either installs the mapping or (after unlocking) iounmap()s it. I'm fine with dropping the lock earlier, but I'm not sure there's much point in placing this in a separate helper, as it's the mapping of at most 2 pages (PBA is 2048 bytes in size, 64bit aligned). I guess you are suggesting this in preparation for adding support to access the non PBA area falling into the same page(s)? > > --- a/xen/include/xen/vpci.h > > +++ b/xen/include/xen/vpci.h > > @@ -127,6 +127,8 @@ struct vpci { > > bool enabled : 1; > > /* Masked? */ > > bool masked : 1; > > + /* PBA map */ > > + void *pba; > > Here (and elsewhere as/if applicable) you want to add __iomem, even > if this is merely for documentation purposes right now. Will add. > I think you did mention this elsewhere: Don't we also need to deal > with accesses to MMIO covered by the same BAR / page, but falling > outside of the MSI-X table and PBA? Yes, I did mention it in a reply to Alex: https://lore.kernel.org/xen-devel/Yhj58BIIN2p4bYJ8@Air-de-Roger/ So far we seem to have gotten away without needing it, but I might as well try to implement, shouldn't be too complicated. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue Mar 01 09:26:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 09:26:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281038.479194 (Exim 4.92) (envelope-from ) id 1nOymC-0006dH-7g; Tue, 01 Mar 2022 09:26:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281038.479194; Tue, 01 Mar 2022 09:26:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOymC-0006dA-3d; Tue, 01 Mar 2022 09:26:36 +0000 Received: by outflank-mailman (input) for mailman id 281038; Tue, 01 Mar 2022 09:26:35 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOymB-0006d4-03 for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 09:26:35 +0000 Received: from smarthost01b.ixn.mail.zen.net.uk (smarthost01b.ixn.mail.zen.net.uk [212.23.1.21]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id adb1f189-9941-11ec-8539-5f4723681683; Tue, 01 Mar 2022 10:26:31 +0100 (CET) Received: from [217.155.64.189] (helo=mail0.xen.dingwall.me.uk) by smarthost01b.ixn.mail.zen.net.uk with esmtpsa (TLS1.0:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1nOym6-0004XZ-Fu; Tue, 01 Mar 2022 09:26:30 +0000 Received: from localhost (localhost [IPv6:::1]) by mail0.xen.dingwall.me.uk (Postfix) with ESMTP id 93C972EE61E; Tue, 1 Mar 2022 09:26:29 +0000 (GMT) Received: from mail0.xen.dingwall.me.uk ([IPv6:::1]) by localhost (mail0.xen.dingwall.me.uk [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id q1W6nSALjIFN; Tue, 1 Mar 2022 09:26:29 +0000 (GMT) Received: from ghoul.dingwall.me.uk (ghoul.dingwall.me.uk [IPv6:2a02:8010:698e:302::c0a8:1c8]) by dingwall.me.uk (Postfix) with ESMTP id 7B8602EE61B; Tue, 1 Mar 2022 09:26:29 +0000 (GMT) Received: by ghoul.dingwall.me.uk (Postfix, from userid 1000) id 76ECC982; Tue, 1 Mar 2022 09:26:29 +0000 (GMT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: adb1f189-9941-11ec-8539-5f4723681683 X-Virus-Scanned: Debian amavisd-new at dingwall.me.uk Date: Tue, 1 Mar 2022 09:26:29 +0000 From: James Dingwall To: Juergen Gross Cc: xen-devel@lists.xenproject.org Subject: Re: [RFC] kernel: xenfs parameter to hide deprecated files Message-ID: <20220301092629.GA3180808@dingwall.me.uk> References: <20220223180859.GA1412216@dingwall.me.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Originating-smarthost01b-IP: [217.155.64.189] Feedback-ID: 217.155.64.189 Hi Juergen, On Fri, Feb 25, 2022 at 03:09:05PM +0100, Juergen Gross wrote: > On 23.02.22 19:08, James Dingwall wrote: > > Hi, > > > > I have been investigating a very intermittent issue we have with xenstore > > access hanging. Typically it seems to happen when all domains are stopped > > prior to a system reboot. xenstore is running in a stubdom and using the > > hypervisor debug keys indicates the domain is still there. > > Could it be dom0 shutdown handling is unloading some modules which are > needed for Xenstore communication? E.g. xen-evtchn? > > > > > I have come across some old list threads which suggested access via > > /proc/xen/xenbus could cause problems but it seems patches went in to the > > kernel for 4.10. However to eliminate this entirely as a possibility > > I came up with this kernel patch to hide deprecated entries in xenfs. > > I don't see how this patch could help. > > libxenstore is using /dev/xen/xenbus if it is available. So the only > case where your patch would avoid accessing /proc/xen/xenbus would be > if /dev/xen/xenbus isn't there. But this wouldn't make Xenstore more > reactive, I guess. ;-) > > > I found this old thread for a similar change where the entries were made > > conditional on kernel config options instead of a module parameter but > > this was never merged. > > > > https://lkml.org/lkml/2015/11/30/761 > > > > If this would be a useful feature I would welcome feedback. > > I'm not sure how helpful it is to let the user specify a boot parameter > for hiding the files. It will probably not get used a lot. Thank you for taking the time to look this over. I did suspect it might not be relevant for most people. I'll keep it in our build for now to see if we improve our xenstore stability. Thank you also for your suggestions about why we might be having a xenstore problem. Next time we encounter that I'll check the status of the loaded modules. Regards, James From xen-devel-bounces@lists.xenproject.org Tue Mar 01 09:35:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 09:35:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281047.479211 (Exim 4.92) (envelope-from ) id 1nOyub-000862-2s; Tue, 01 Mar 2022 09:35:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281047.479211; Tue, 01 Mar 2022 09:35:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOyua-00085v-WA; Tue, 01 Mar 2022 09:35:16 +0000 Received: by outflank-mailman (input) for mailman id 281047; Tue, 01 Mar 2022 09:35:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOyuZ-00085p-PA for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 09:35:15 +0000 Received: from smarthost01a.sbp.mail.zen.net.uk (smarthost01a.sbp.mail.zen.net.uk [212.23.1.1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e5d286bd-9942-11ec-8539-5f4723681683; Tue, 01 Mar 2022 10:35:14 +0100 (CET) Received: from [217.155.64.189] (helo=mail0.xen.dingwall.me.uk) by smarthost01a.sbp.mail.zen.net.uk with esmtpsa (TLS1.0:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1nOyuY-00071n-54; Tue, 01 Mar 2022 09:35:14 +0000 Received: from localhost (localhost [IPv6:::1]) by mail0.xen.dingwall.me.uk (Postfix) with ESMTP id 93F462EE67F; Tue, 1 Mar 2022 09:35:13 +0000 (GMT) Received: from mail0.xen.dingwall.me.uk ([127.0.0.1]) by localhost (mail0.xen.dingwall.me.uk [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zaf6TsOvbNxP; Tue, 1 Mar 2022 09:35:13 +0000 (GMT) Received: from ghoul.dingwall.me.uk (ghoul.dingwall.me.uk [IPv6:2a02:8010:698e:302::c0a8:1c8]) by dingwall.me.uk (Postfix) with ESMTP id 739732EE67C; Tue, 1 Mar 2022 09:35:13 +0000 (GMT) Received: by ghoul.dingwall.me.uk (Postfix, from userid 1000) id 5FCF42E; Tue, 1 Mar 2022 09:35:13 +0000 (GMT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e5d286bd-9942-11ec-8539-5f4723681683 X-Virus-Scanned: Debian amavisd-new at dingwall.me.uk Date: Tue, 1 Mar 2022 09:35:13 +0000 From: James Dingwall To: xen-devel@lists.xenproject.org Cc: pdurrant@amazon.com Subject: [PATCH] fix invalid frontend path for set_mtu Message-ID: <20220301093513.GA3187840@dingwall.me.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Originating-smarthost01a-IP: [217.155.64.189] Feedback-ID: 217.155.64.189 Hi, The set_mtu() function of xen-network-common.sh currently has this code: if [ ${type_if} = vif ] then local dev_=${dev#vif} local domid=${dev_%.*} local devid=${dev_#*.} local FRONTEND_PATH="/local/domain/$domid/device/vif/$devid" xenstore_write "$FRONTEND_PATH/mtu" ${mtu} fi This works fine if the device has its default name but if the xen config defines the vifname parameter the FRONTEND_PATH is incorrectly constructed. Learn the frontend path by reading the appropriate value from the backend. diff --git a/tools/hotplug/Linux/xen-network-common.sh b/tools/hotplug/Linux/xen-network-common.sh index 02e2388600..cd98f0d486 100644 --- a/tools/hotplug/Linux/xen-network-common.sh +++ b/tools/hotplug/Linux/xen-network-common.sh @@ -163,11 +163,7 @@ set_mtu () { if [ ${type_if} = vif ] then - local dev_=${dev#vif} - local domid=${dev_%.*} - local devid=${dev_#*.} - - local FRONTEND_PATH="/local/domain/$domid/device/vif/$devid" + local FRONTEND_PATH=$(xenstore_read "$XENBUS_PATH/frontend") xenstore_write "$FRONTEND_PATH/mtu" ${mtu} fi Thanks, James From xen-devel-bounces@lists.xenproject.org Tue Mar 01 09:57:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 09:57:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281056.479228 (Exim 4.92) (envelope-from ) id 1nOzFy-0002Nd-Uq; Tue, 01 Mar 2022 09:57:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281056.479228; Tue, 01 Mar 2022 09:57:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOzFy-0002NW-RP; Tue, 01 Mar 2022 09:57:22 +0000 Received: by outflank-mailman (input) for mailman id 281056; Tue, 01 Mar 2022 09:57:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOzFx-0002NQ-QW for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 09:57:21 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOzFx-0002v5-ED; Tue, 01 Mar 2022 09:57:21 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=[192.168.6.66]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nOzFx-0002mG-7k; Tue, 01 Mar 2022 09:57:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=YVjhYH6kRAXW0WlGzpTvDmInUEioXLDF5vGnBFvgXbo=; b=XO3vnzYxXviPamMXcnHd/Y38U/ Wfd5lIAiZ8pSBb/bJXFmPnJniuyW1zcXpytWoT4v3ABSBNO4kzMEAjqtIy2anWRP70IR3THvCHDvE 0er3L1rvijAkGZx+vtOrFqNpR/PW9dGXvboDX+eIihqv0uUh5cVo57W2F/WRcT0GYQTw=; Message-ID: Date: Tue, 1 Mar 2022 09:57:19 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH] xen/arm: Remove unused BOOT_RELOC_VIRT_START To: Michal Orzel , xen-devel@lists.xenproject.org Cc: Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Julien Grall References: <20220228100633.57593-1-julien@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 01/03/2022 08:28, Michal Orzel wrote: > Hi Julien, Hi Michal, > On 28.02.2022 11:06, Julien Grall wrote: >> From: Julien Grall >> >> We stopped relocating Xen since commit f60658c6ae "xen/arm: Stop >> relocating Xen". >> >> At the same time, update the memory layout description. >> >> Signed-off-by: Julien Grall >> Signed-off-by: Julien Grall > Are these two entries needed? I'd say one is enough. From my understanding, it is necessary. The person is the same here but the companies are different. So I should properly account that the work was originaly done while working for Arm (see [1]) and was updated while I was working for Amazon. Even I didn't touch the patch, I still need to add a signed-off-by because of the DCO [2]. >> --- > > Apart from that: > Reviewed-by: Michal Orzel Cheers, [1] https://xenbits.xen.org/gitweb/?p=people/julieng/xen-unstable.git;a=commit;h=dfa041f32ae2fef6132d40df7cbce93b6e385937 [2] https://developercertificate.org/ -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Mar 01 10:01:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 10:01:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281063.479238 (Exim 4.92) (envelope-from ) id 1nOzJV-0003qx-E7; Tue, 01 Mar 2022 10:01:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281063.479238; Tue, 01 Mar 2022 10:01:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOzJV-0003qq-B2; Tue, 01 Mar 2022 10:01:01 +0000 Received: by outflank-mailman (input) for mailman id 281063; Tue, 01 Mar 2022 10:00:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOzJT-0003qh-R1 for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 10:00:59 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 7d8b62b9-9946-11ec-8539-5f4723681683; Tue, 01 Mar 2022 11:00:58 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1C005ED1; Tue, 1 Mar 2022 02:00:57 -0800 (PST) Received: from [10.57.5.142] (unknown [10.57.5.142]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B55943F73D; Tue, 1 Mar 2022 02:00:55 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7d8b62b9-9946-11ec-8539-5f4723681683 Subject: Re: [PATCH] xen/arm: Remove unused BOOT_RELOC_VIRT_START To: Julien Grall , xen-devel@lists.xenproject.org Cc: Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Julien Grall References: <20220228100633.57593-1-julien@xen.org> From: Michal Orzel Message-ID: Date: Tue, 1 Mar 2022 11:00:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Julien, On 01.03.2022 10:57, Julien Grall wrote: > On 01/03/2022 08:28, Michal Orzel wrote: >> Hi Julien, > > Hi Michal, > >> On 28.02.2022 11:06, Julien Grall wrote: >>> From: Julien Grall >>> >>> We stopped relocating Xen since commit f60658c6ae "xen/arm: Stop >>> relocating Xen". >>> >>> At the same time, update the memory layout description. >>> >>> Signed-off-by: Julien Grall >>> Signed-off-by: Julien Grall >> Are these two entries needed? I'd say one is enough. > From my understanding, it is necessary. The person is the same here but the companies are different. > > So I should properly account that the work was originaly done while working for Arm (see [1]) and was updated while I was working for Amazon. > > Even I didn't touch the patch, I still need to add a signed-off-by because of the DCO [2]. > Interesting. Thank you very much for the explanation. >>> --- >> >> Apart from that: >> Reviewed-by: Michal Orzel > > Cheers, > > [1] https://xenbits.xen.org/gitweb/?p=people/julieng/xen-unstable.git;a=commit;h=dfa041f32ae2fef6132d40df7cbce93b6e385937 > [2] https://developercertificate.org/ > Cheers, Michal From xen-devel-bounces@lists.xenproject.org Tue Mar 01 10:07:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 10:07:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281075.479255 (Exim 4.92) (envelope-from ) id 1nOzPG-0004iv-8y; Tue, 01 Mar 2022 10:06:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281075.479255; Tue, 01 Mar 2022 10:06:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOzPG-0004io-5w; Tue, 01 Mar 2022 10:06:58 +0000 Received: by outflank-mailman (input) for mailman id 281075; Tue, 01 Mar 2022 10:06:56 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOzPE-0004ie-8H; Tue, 01 Mar 2022 10:06:56 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOzPE-0003DD-2w; Tue, 01 Mar 2022 10:06:56 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOzPD-0005GE-SQ; Tue, 01 Mar 2022 10:06:55 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nOzPD-0001AC-Rx; Tue, 01 Mar 2022 10:06:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=UKRALphRydTXNZs3sM5FA0vbQOlzyyfkqoLTDrIQONc=; b=QMdMEnVg4J/h/ExEvGdVcIqfT/ UZhQEPls1mDOQSd5MC0k4adPW62d4w8FuI6gyGtwWtXa1WitLXgC+tFREIgBizJIuQMsA+rDjIW9y UIDhueIwZcwSRu5OOKvl9erVzm9NkOVdD2QMNxbnT8W27Y4M0eXqcXA1vjPBby+sHeug=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 168271: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=497ac7b6d7f9750f48f137db244931a5728b1968 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 01 Mar 2022 10:06:55 +0000 flight 168271 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/168271/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 497ac7b6d7f9750f48f137db244931a5728b1968 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 0 days Failing since 168258 2022-03-01 01:55:31 Z 0 days 4 attempts Testing same since 168262 2022-03-01 04:10:26 Z 0 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Guomin Jiang Jason Jason Lou jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 497ac7b6d7f9750f48f137db244931a5728b1968 Author: Guomin Jiang Date: Sat Jan 29 16:28:02 2022 +0800 UefiPayloadPkg/PayloadLoaderPeim: Use INT64 as input parameter REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3818 It will have some potential issue when memory larger than 2G because the high memory address will be fill with 0xFFFFFFFF when do the operation of INTN + INT64 but it is 32 bit normal data in fact. Should use same data type INT64 + INT64. V3: 1. Use INT64 as input parameter because all date type is 64 bit V2: 1. Force the data type to UINTN to avoid high dword be filled with 0xFFFFFFFF 2. Keep INTN because the offset may postive or negative. Reviewed-by: Guo Dong Reviewed-by: Ray Ni Signed-off-by: Guomin Jiang commit 6a890db161cd6d378bec3499a1e774db3f5a27a7 Author: Jason Date: Mon Jan 10 22:30:29 2022 +0800 BaseTools: Upgrade the version of NASM tool REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Upgrade the version of NASM tool to avoid compilation errors when compiling NASM code change. Signed-off-by: Jason Lou Cc: Bob Feng Cc: Liming Gao Reviewed-by: Yuwei Chen commit bbaa00dd01ed0df30e43a5a89fd2b0433d858b73 Author: Jason Date: Mon Jan 10 22:05:47 2022 +0800 MdePkg: Remove the macro definitions regarding Opcode. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Remove the macro definitions regarding Opcode because new version of NASM tool(e.g. v2.15.05) supports the corresponding instructions. Note: This patch need to be merged after other NASM code change to avoid compilation errors. Signed-off-by: Jason Lou Cc: Michael D Kinney Reviewed-by: Liming Gao Cc: Zhiguang Liu commit 2aa107c0aa2e1375651867c8df1b81ff64b67fce Author: Jason Date: Mon Jan 10 22:01:18 2022 +0800 UefiCpuPkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Reviewed-by: Ray Ni Cc: Eric Dong Cc: Laszlo Ersek Cc: Rahul Kumar commit 7bc8b1d9f412507d579f21ea9af56fced81e7827 Author: Jason Date: Mon Jan 10 21:52:52 2022 +0800 SourceLevelDebugPkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Reviewed-by: Hao A Wu commit d3febfd9ade35dc552df6b3607c2b15d26b82867 Author: Jason Date: Mon Jan 10 21:46:27 2022 +0800 MdePkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Cc: Michael D Kinney Reviewed-by: Liming Gao Cc: Zhiguang Liu commit 84338c0d498555f860a480693ee8647a1795fba3 Author: Jason Date: Mon Jan 10 21:04:09 2022 +0800 MdeModulePkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Reviewed-by: Ray Ni Cc: Dandan Bi Reviewed-by: Liming Gao From xen-devel-bounces@lists.xenproject.org Tue Mar 01 10:13:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 10:13:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281086.479267 (Exim 4.92) (envelope-from ) id 1nOzVo-00068Y-1L; Tue, 01 Mar 2022 10:13:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281086.479267; Tue, 01 Mar 2022 10:13:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOzVn-00068Q-U1; Tue, 01 Mar 2022 10:13:43 +0000 Received: by outflank-mailman (input) for mailman id 281086; Tue, 01 Mar 2022 10:13:42 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOzVm-00068D-PF; Tue, 01 Mar 2022 10:13:42 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOzVm-0003Kc-Hn; Tue, 01 Mar 2022 10:13:42 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOzVm-0005OW-6u; Tue, 01 Mar 2022 10:13:42 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nOzVm-0008Uj-6R; Tue, 01 Mar 2022 10:13:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=AOm0I99s6iKTwAV7Mm0P0sijJCVF0/D8vIfaDvLtwQs=; b=4u8DQ/G6YKzKMCyFj438jO3bqe ZMHRR/looRvmTZjmr3L9tzJkssQk85cB6DPeQGlEeeJZ6OIDUeBL7dWWMYJXRFuKSxBXtyNuIthj0 Ewlqmqbx+G7zCPSS3emp7LTm1ovUsBu6XxXXbjmfTPpjX1/JSlpJWNA6c0ZS2f1DElqU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 168257: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=4388144c44c4dd9e9b7df97938ef08ffa85eec07 X-Osstest-Versions-That: xen=4388144c44c4dd9e9b7df97938ef08ffa85eec07 From: osstest service owner Date: Tue, 01 Mar 2022 10:13:42 +0000 flight 168257 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/168257/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 168253 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168253 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 168253 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 168253 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 168253 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 168253 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 168253 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 168253 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 168253 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 168253 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 168253 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 168253 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 4388144c44c4dd9e9b7df97938ef08ffa85eec07 baseline version: xen 4388144c44c4dd9e9b7df97938ef08ffa85eec07 Last test of basis 168257 2022-03-01 01:53:09 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Tue Mar 01 10:32:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 10:32:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281101.479284 (Exim 4.92) (envelope-from ) id 1nOznd-0000Qm-R6; Tue, 01 Mar 2022 10:32:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281101.479284; Tue, 01 Mar 2022 10:32:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOznd-0000Qf-Mk; Tue, 01 Mar 2022 10:32:09 +0000 Received: by outflank-mailman (input) for mailman id 281101; Tue, 01 Mar 2022 10:32:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOznc-0000QZ-CO for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 10:32:08 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d7986752-994a-11ec-8539-5f4723681683; Tue, 01 Mar 2022 11:32:06 +0100 (CET) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-he1eur02lp2057.outbound.protection.outlook.com [104.47.5.57]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-7-ZJ69LoXtNkiKWFRWjggTGQ-1; Tue, 01 Mar 2022 11:32:05 +0100 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by AM6PR04MB4392.eurprd04.prod.outlook.com (2603:10a6:20b:1c::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.26; Tue, 1 Mar 2022 10:32:03 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.027; Tue, 1 Mar 2022 10:32:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d7986752-994a-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1646130726; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=s/S/93RDEUEGy29b4Zyofycj7JF6IGAg8eYAvK+Q9wc=; b=UVMUOgzzfdHt9RQt83AtBC4PX82Np6g7Po1T7SaxvhlC2If4G5LDrkv7medFnXmqLZ2Q+n ZbI8TWPUW2QnrOYswokzBKD4iBIuRJYq/eANu29mItsEGHnpLH6NaMLD1u3+ScBwVTgcwJ yjL/HAEJ2ModaRJ4jCye+GS+AQvnBgg= X-MC-Unique: ZJ69LoXtNkiKWFRWjggTGQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Mn3YfJHhAx1oDEkNFSuJk1Nr1AOYLJOWrrjBg3Ij8kA/IOuLUd1oiH/PFru+HVOLwKOjOkbZUxxuvP/JHcMSyLRJbdgIpbQF8+0gPSyV+b5oiLIAOZ7hLTzmr0RgBTpIPXYwnQbV1gi46hc2PWWLzysDU4uhK6uW9wEG/L/aY8gmK66hJuN4wuqGt9d3YlVVfd9iw059FjXJxHbhbZBQ+DAt7y4uTknr6hVHD8jKtT6FVjl5Z6B0TdzFf9ipmcxRIl83b0ly3auaPWAVT0icsE/rb+nzEopQqk5ifT+FGUkCIKjCj88Myw+2vpd3Aryl8kdTnHdZ2I+7h8FdiZMsEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=W0OvDogMLwRZTzxH9oWXV+jlOPVXgRUiv4aYpjtRNDw=; b=YS1flxjD8g8P3FBlXIjdfpcYviR9pYOwtP/6MuWNFMdHGX7i1FiHskNMu8WhR8MW5J7mRCfRGVT3pdXTaqbdrG+f2h93MI5KKdsKkvoac4EUjzGSCQSKjT13WrfuQdw8njeIOguwC+hdEPK+tWE61Qqij7iY7aLpcPmVgHAKpgusX5RnX7BMFfnxMeOh1BqpN2UCsLMouJra3vil7VizcI/pHLC8GEXgwBK4kFL1Qp6gZ7FV8KUgzket9yhloLS+KGfYOJ/GcUAOZfxy7jkaTKJV22jt55o28p60jV10j4m18fgQPxoITlTpUIDAY5oEr3/+uZJSUjAz+lygaxIRKw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <5e5ad6bf-8c58-745b-dc32-c906a1928329@suse.com> Date: Tue, 1 Mar 2022 11:32:01 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH v2.1 2/2] vpci/msix: fix PBA accesses Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: Alex Olson , xen-devel@lists.xenproject.org References: <20220226100554.2664-1-roger.pau@citrix.com> <8597cd20-4d79-0f5f-8370-d2353e7116f7@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM5PR04CA0008.eurprd04.prod.outlook.com (2603:10a6:206:1::21) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e594b93e-e5f8-459f-6edc-08d9fb6eb9ef X-MS-TrafficTypeDiagnostic: AM6PR04MB4392:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: d2FKaF8rjT8B51gLkVV8WEzqbXSdkhfCuy8O2pODdZAZsdEanIo2Dda+EVc6YWwZG0dUIuoI8tlw3oLkFzrnjzFwq60lGq1onmsNs2yeBxGbwEfz+1zJr0p4mdsjYmgxflcjjVSQcI/huGhoXESeVRn5NxtfCRMj5AG/I81MBxpT7hetvXvWX8I3q+qTkx6xS+4f5r6PRHJGcxcaiYmTrreAhEB2mfHT4J5ivwvqcbSbyrfqJ//P4JJThAjHw4MftrTq1Bnt4zz1a7ynrVa33dB2/6TOfpq0dLuLG8kwQiIhwW1ZQP6Dtn+LhaGpcID3dVXCa39PRlxIEIhwMyKS5Dsm1OzbZr4P/LnQsWOIjNuzbefNaxKrkHnl7HtM5BuxZ4JDYYWoKuxCO0q4WPN7bWjuDunPAPxgkpqGARupKSKeNtDichIxDLOmff2A+y+kE9Oc617qQ9Ew+pveaCI0uDoYeHZBMdFqExRzCH0muE/Ll13f0wStVkOjz0w7DUK7wJtoOw7OeEGY0erUNrkujkAmq3WMJWk67V8k6x7hvIR1nc7ifMb09/c1qwgWg1yCA3FzR9G3GwvPCsNazeglme+2Rf/tXf/nOclePPbNP+8ePmeJ0x4h3cMkkZbX1wzPbYHw2VgT7FUJS3pUGr1W+u/mSBJRDmHUKrV9xVcg6CbEXzEXsNSVFkfcBt7YLZTwwWyNlPRanj1Mn5lvI3r6C3uVuRM+dCL4PK9hJHP8Xzs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(83380400001)(8676002)(4326008)(2616005)(2906002)(186003)(26005)(5660300002)(8936002)(31696002)(6916009)(31686004)(6506007)(6512007)(86362001)(6486002)(508600001)(53546011)(36756003)(66946007)(66476007)(66556008)(38100700002)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?II6u1SchmHKJ70xprGA2o+AcrtCG5eH5aOr/90QV02d/OlvCc1Foi94OQLx9?= =?us-ascii?Q?ojeDGWdS7pLpOVTEhKb+nG1QaR/POwwsOg6oBEMOa12CFQC2eCaLyg5Z8wNv?= =?us-ascii?Q?64khgCwgdSE9hW0+1ihaPRXb7YESL95uXM+IMIxPBph0j2+JnpiQu9IqkXeF?= =?us-ascii?Q?TbaB2JNATsdpZdcIML/sj3kbq6Rr16FfVB+uAOCRyYC/Ducae3KTdUbPlsgR?= =?us-ascii?Q?JZf1r7piSxAR+Cy8zS9blD0P2M2CrftClaEfJWlCVHwk/uNvq18isgDxiSrO?= =?us-ascii?Q?AGSF0Z/Kvs1cBWhHOEcgvnmswmC+jwHPB4gBSH9nbjvQvdVAcES6s3gQygWj?= =?us-ascii?Q?cA9TmWY7eQ/lfAmwD1EOQ1hLKmqpK2RnBwUcVIoPpkrXxq8aGO7CmS8UE/Ch?= =?us-ascii?Q?XMxMzqlLGI7aeU70mLjoo//kxZ0hr80QMdyFshlUCf27nfYsMdUc2vxTfWcN?= =?us-ascii?Q?IdI8ZEvtT/kSk/irEouVuNCbNyhm7y1OjH+W0ceUCwOm+hc4mdgDXLMzpnko?= =?us-ascii?Q?wgn0oSKnSUZYD8A06RhrWgDphmUUjChU/qWgmZ4I92b9f9U9SejKlccF1xMf?= =?us-ascii?Q?fFFGGnhaFw5t9xyau1/UUfLvX4k2dlUPduhGWgAkb1snkyZwKdz4H89uw10l?= =?us-ascii?Q?a/5ycd5E7cvDqabu3CAb+h9LBjaUVcIcmDChg3IzsLrYHw5fS2s29RxNz5NJ?= =?us-ascii?Q?X19C7TVwVmUxfH8lK/YPX4tYK0MQJG44wbu4J7rk2c8Hd9ivFFP9ci6cF4sz?= =?us-ascii?Q?V1IT6TA0SX139q6Ox0uwY+ZfpBsSL7BDU9Pwl7Wf3YbrDMmpCvgL8weet+lV?= =?us-ascii?Q?In2Yvx/J5ZTdfqPCdjhpBxEu6/NT5x6AlKXESlhBQ5/yEAnPnqhkx83VaqCn?= =?us-ascii?Q?WaKYZ20dTdjp6MfTnew+c6mjyDoLFkMVs9vEB8sLUflFCME7vuJyGw7xdGSP?= =?us-ascii?Q?Wjz7Iqr4gSfA3WMbs+4t+fP+56KRoHM/gdGvFYuMwphUrSAsZPjMF6tUeLmC?= =?us-ascii?Q?7+pAAveXg6thQ/2+Dnof/Q2WgJ/gBJhmn+m8wXdBW/oJAypWrvfKaiKyugE4?= =?us-ascii?Q?yGsxPlvqUl1SasC3frH/a5DDBXp42iEjjyZKVuU5FhU2+TjMmzrWJKGEk96n?= =?us-ascii?Q?bByt+Q77B26wYWbrTGqUz9uMK1y+Z/ZJ99NYGzZDXxNZLvjnHVZ5acrGz6FG?= =?us-ascii?Q?naaqTwtgk1+5SWQLKaWkzZgOsiqgjBjOPHIND4Vkv2UKLGxt+mNW22u9nUi1?= =?us-ascii?Q?3dYpKzR6LcmKGK2uqV4KqklUh8MJ49GCtoCOC9tt4HyXTUUbjo+04d7KvTRr?= =?us-ascii?Q?Xa4jxgQKNQpPlsZTJMXZ9y+cZja/TDFuMoL35s8gqHPLmd6n6WBrOEUdkY0R?= =?us-ascii?Q?rfEWvEm6ItHPrOGAhIRU+Lpxl/+MNopLcjexWYK8UkGH42E/VBWtmqVB1S6t?= =?us-ascii?Q?TPJNzZ14kj8RIGT1GbxFBPkwWUOIqw7FNqHg7e1DC1DXdacc7Lpa9aRsvjh5?= =?us-ascii?Q?mrPi53pE5HbTn1HE5T7+w4WZuxhpkodVGpe14Grz8IiXkYWpfbjTmy7+a6FR?= =?us-ascii?Q?g1vUknnS+nfz0cBmXA9+BQB5sh0vp7M468vpaTNFnLRSrsp9mgHgBRCBhonQ?= =?us-ascii?Q?SCgQIJLWd3F39hRd/oZiiIg=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e594b93e-e5f8-459f-6edc-08d9fb6eb9ef X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2022 10:32:03.6586 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CDOUMM95qyyugQXKXjz16lEksp1br0hqjoQf/3+1C2wk16wadq8n5me6gl+ibBH/BM0zLOAzG/+7ogpi97O5nQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4392 On 01.03.2022 10:08, Roger Pau Monn=C3=A9 wrote: > On Tue, Mar 01, 2022 at 09:46:13AM +0100, Jan Beulich wrote: >> On 26.02.2022 11:05, Roger Pau Monne wrote: >>> --- a/xen/drivers/vpci/msix.c >>> +++ b/xen/drivers/vpci/msix.c >>> @@ -198,8 +198,13 @@ static int cf_check msix_read( >>> if ( !access_allowed(msix->pdev, addr, len) ) >>> return X86EMUL_OKAY; >>> =20 >>> + spin_lock(&msix->pdev->vpci->lock); >>> if ( VMSIX_ADDR_IN_RANGE(addr, msix->pdev->vpci, VPCI_MSIX_PBA) ) >>> { >>> + struct vpci *vpci =3D msix->pdev->vpci; >>> + paddr_t base =3D vmsix_table_addr(vpci, VPCI_MSIX_PBA); >>> + unsigned int idx =3D addr - base; >>> + >>> /* >>> * Access to PBA. >>> * >>> @@ -207,25 +212,43 @@ static int cf_check msix_read( >>> * guest address space. If this changes the address will need = to be >>> * translated. >>> */ >>> + >>> + if ( !msix->pba ) >>> + { >>> + msix->pba =3D ioremap(base, vmsix_table_size(vpci, VPCI_MS= IX_PBA)); >>> + if ( !msix->pba ) >>> + { >>> + /* >>> + * If unable to map the PBA return all 1s (all pending= ): it's >>> + * likely better to trigger spurious events than drop = them. >>> + */ >>> + spin_unlock(&vpci->lock); >>> + gprintk(XENLOG_WARNING, >>> + "%pp: unable to map MSI-X PBA, report all pend= ing\n", >>> + msix->pdev); >>> + return X86EMUL_OKAY; >> >> Hmm, this may report more set bits than there are vectors. Which is >> probably fine, but the comment may want adjusting a little to make >> clear this is understood and meant to be that way. >=20 > Yes, it could return more bits than vectors, but that area is also > part of the PBA (as the end is aligned to 8 bytes). I will adjust the > comment. >=20 >>> + } >>> + } >> >> Imo it would make sense to limit the locked region to around just this >> check-and-map logic. There's no need for ... >> >>> switch ( len ) >>> { >>> case 4: >>> - *data =3D readl(addr); >>> + *data =3D readl(msix->pba + idx); >>> break; >>> =20 >>> case 8: >>> - *data =3D readq(addr); >>> + *data =3D readq(msix->pba + idx); >>> break; >>> =20 >>> default: >>> ASSERT_UNREACHABLE(); >>> break; >>> } >>> + spin_unlock(&vpci->lock); >> >> ... the actual access to happen under lock, as you remove the mapping >> only when the device is being removed. I'm inclined to suggest making >> a helper function, which does an unlocked check, then the ioremap(), >> then takes the lock and re-checks whether the field's still NULL, and >> either installs the mapping or (after unlocking) iounmap()s it. >=20 > I'm fine with dropping the lock earlier, but I'm not sure there's much > point in placing this in a separate helper, as it's the mapping of at > most 2 pages (PBA is 2048 bytes in size, 64bit aligned). >=20 > I guess you are suggesting this in preparation for adding support to > access the non PBA area falling into the same page(s)? Not just. The write path wants to use the same logic, and with it becoming a little more involved I think it would be better to have it in just one place. Jan From xen-devel-bounces@lists.xenproject.org Tue Mar 01 10:53:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 10:53:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281111.479306 (Exim 4.92) (envelope-from ) id 1nP08N-000344-2B; Tue, 01 Mar 2022 10:53:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281111.479306; Tue, 01 Mar 2022 10:53:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP08M-00033l-Ro; Tue, 01 Mar 2022 10:53:34 +0000 Received: by outflank-mailman (input) for mailman id 281111; Tue, 01 Mar 2022 10:53:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP08L-00031b-9S for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 10:53:33 +0000 Received: from bombadil.infradead.org (bombadil.infradead.org [2607:7c80:54:e::133]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d3f564ac-994d-11ec-8539-5f4723681683; Tue, 01 Mar 2022 11:53:30 +0100 (CET) Received: from [2.53.44.23] (helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nP086-00GCwl-PS; Tue, 01 Mar 2022 10:53:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d3f564ac-994d-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=fpYq2gch6ejmPkcFKPjSyDr7OAs4OQSLe0uyAoUEPa0=; b=fPAUDOwUGnyXtx+hZA5zj2Ej4o HV9I6mYI0fayhovoE3oLXfq8qlMel6pFXXEc1mFWZvLXjhqfrbEyGhTBlOaKUDjaA5CMiNeYGJSlR GdeXeohIETuTXXnuIlqxqGPh/VMWo8hZjPyELE8feSOsKIkrkw8+qaC6yMhYVu17XpDc82M+q7Bjt P632yeVc6VELpePyjZp8VgOAEAH7yaxooKuzgDiHjXqCwex8uGIgNuXO8DeKOfVen/Dat6rNPrxN6 ijjP0c7VtoQrVKhle4tTPRFAXwLIjwChLUwuVEdyRedzAx7rh05DpVyMdlXZjiKBQ/Hagn5ofY1Vr BAWrqPTg==; From: Christoph Hellwig To: iommu@lists.linux-foundation.org Cc: x86@kernel.org, Anshuman Khandual , Tom Lendacky , Konrad Rzeszutek Wilk , Stefano Stabellini , Boris Ostrovsky , Juergen Gross , Joerg Roedel , David Woodhouse , Lu Baolu , Robin Murphy , linux-arm-kernel@lists.infradead.org, xen-devel@lists.xenproject.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-hyperv@vger.kernel.org, tboot-devel@lists.sourceforge.net, linux-pci@vger.kernel.org Subject: [PATCH 01/12] dma-direct: use is_swiotlb_active in dma_direct_map_page Date: Tue, 1 Mar 2022 12:53:00 +0200 Message-Id: <20220301105311.885699-2-hch@lst.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220301105311.885699-1-hch@lst.de> References: <20220301105311.885699-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Use the more specific is_swiotlb_active check instead of checking the global swiotlb_force variable. Signed-off-by: Christoph Hellwig Reviewed-by: Anshuman Khandual --- kernel/dma/direct.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/dma/direct.h b/kernel/dma/direct.h index 4632b0f4f72eb..4dc16e08c7e1a 100644 --- a/kernel/dma/direct.h +++ b/kernel/dma/direct.h @@ -91,7 +91,7 @@ static inline dma_addr_t dma_direct_map_page(struct device *dev, return swiotlb_map(dev, phys, size, dir, attrs); if (unlikely(!dma_capable(dev, dma_addr, size, true))) { - if (swiotlb_force != SWIOTLB_NO_FORCE) + if (is_swiotlb_active(dev)) return swiotlb_map(dev, phys, size, dir, attrs); dev_WARN_ONCE(dev, 1, -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Tue Mar 01 10:53:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 10:53:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281110.479301 (Exim 4.92) (envelope-from ) id 1nP08M-00031t-MS; Tue, 01 Mar 2022 10:53:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281110.479301; Tue, 01 Mar 2022 10:53:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP08M-00031m-Ir; Tue, 01 Mar 2022 10:53:34 +0000 Received: by outflank-mailman (input) for mailman id 281110; Tue, 01 Mar 2022 10:53:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP08L-00031a-2h for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 10:53:33 +0000 Received: from bombadil.infradead.org (bombadil.infradead.org [2607:7c80:54:e::133]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d356a529-994d-11ec-8eba-a37418f5ba1a; Tue, 01 Mar 2022 11:53:30 +0100 (CET) Received: from [2.53.44.23] (helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nP083-00GCvx-8y; Tue, 01 Mar 2022 10:53:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d356a529-994d-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=FLoPcwp8W110QTyBUFSAYe56vwqhsB+0w1jgowBLDrQ=; b=x4Ls4LGXlw3mqit2JgZ989HyZb T5qpKmQGteCGW5NyuTbuloRJzt7HhHDSWBkn6XMthvcPktTNRGiMhEjm3jNCxNFXallKVQH7jYfkV yMP1NQbMBXexGqNGRQAxlptnMjCU6iBaEsSYx496tSDH97RR6D0tylDgXaeXfMovaKcRHhD1mlnuz OQ2BdFcAyA097bBGDwCVXhJV6sp+r3vCa43JaFB+f/7FaiduK6PaxwT2gDQredky9tC0CHGWz/iGt MF2HppH9e3IKlAYjXSzy/Ts9RTiST6h6Fjh5rDDovAP92KH/7Uv2VhH/n7QVymPp/mWYAgqqJl+PH rhUuKZnQ==; From: Christoph Hellwig To: iommu@lists.linux-foundation.org Cc: x86@kernel.org, Anshuman Khandual , Tom Lendacky , Konrad Rzeszutek Wilk , Stefano Stabellini , Boris Ostrovsky , Juergen Gross , Joerg Roedel , David Woodhouse , Lu Baolu , Robin Murphy , linux-arm-kernel@lists.infradead.org, xen-devel@lists.xenproject.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-hyperv@vger.kernel.org, tboot-devel@lists.sourceforge.net, linux-pci@vger.kernel.org Subject: cleanup swiotlb initialization v4 Date: Tue, 1 Mar 2022 12:52:59 +0200 Message-Id: <20220301105311.885699-1-hch@lst.de> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Hi all, this series tries to clean up the swiotlb initialization, including that of swiotlb-xen. To get there is also removes the x86 iommu table infrastructure that massively obsfucates the initialization path. Git tree: git://git.infradead.org/users/hch/misc.git swiotlb-init-cleanup Gitweb: http://git.infradead.org/users/hch/misc.git/shortlog/refs/heads/swiotlb-init-cleanup Changes since v3: - fix a compilation issue on some powerpc configfs - fix and cleanup how forced bounce buffering is enabled for guest memory encryption Changes since v2: - make ppc_swiotlb_flags actually work again - also force enable swiotlb for guest encrypted memory to cater to hyperv which doesn't set the host encrypted memory flag Changes since v1: - skip IOMMU initialization on Xen PV kernels - various small whitespace / typo fixes Diffstat: From xen-devel-bounces@lists.xenproject.org Tue Mar 01 10:53:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 10:53:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281113.479315 (Exim 4.92) (envelope-from ) id 1nP08N-0003CC-G2; Tue, 01 Mar 2022 10:53:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281113.479315; Tue, 01 Mar 2022 10:53:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP08N-00038H-4n; Tue, 01 Mar 2022 10:53:35 +0000 Received: by outflank-mailman (input) for mailman id 281113; Tue, 01 Mar 2022 10:53:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP08M-00031a-MV for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 10:53:34 +0000 Received: from bombadil.infradead.org (bombadil.infradead.org [2607:7c80:54:e::133]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d658ee84-994d-11ec-8eba-a37418f5ba1a; Tue, 01 Mar 2022 11:53:34 +0100 (CET) Received: from [2.53.44.23] (helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nP08A-00GCxm-Dw; Tue, 01 Mar 2022 10:53:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d658ee84-994d-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=8kkkqKTmx4an5HwtAkctrRmIlb8tNewwdnwFgQaeBs4=; b=jLl0j4bSOfVgHsr3MQ5Bv5W25W eBCL+ezlRGLhWYJUDEMLnfnY03XvNmRuJ3NVkaIN+j91e7hLR85KeZAUrre7FDsYIGG5LJVefqfFQ aBw4XS4clVWlj8OlW5+no9SoBD1TeUv7rQYDWrKf4OHZIcAUPacEQWejKAQpzWZV4sMB16ogBdJNd BYo+cef7t0HrzSLXHOj4597NsWHTixNewjzb8+eB6sepbzbOCAKRdiYjQ0SKHJwpHXjDNI+7jB/Nl V6d7NCk96h2kf6oMslvOoIEJGHn3fDqOVyBakQxgHeZAYF5ayU7+PWsZkl0kSLTP/USHzDRJXcvab v9YgSnow==; From: Christoph Hellwig To: iommu@lists.linux-foundation.org Cc: x86@kernel.org, Anshuman Khandual , Tom Lendacky , Konrad Rzeszutek Wilk , Stefano Stabellini , Boris Ostrovsky , Juergen Gross , Joerg Roedel , David Woodhouse , Lu Baolu , Robin Murphy , linux-arm-kernel@lists.infradead.org, xen-devel@lists.xenproject.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-hyperv@vger.kernel.org, tboot-devel@lists.sourceforge.net, linux-pci@vger.kernel.org Subject: [PATCH 02/12] swiotlb: make swiotlb_exit a no-op if SWIOTLB_FORCE is set Date: Tue, 1 Mar 2022 12:53:01 +0200 Message-Id: <20220301105311.885699-3-hch@lst.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220301105311.885699-1-hch@lst.de> References: <20220301105311.885699-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html If force bouncing is enabled we can't release the buffers. Signed-off-by: Christoph Hellwig Reviewed-by: Anshuman Khandual --- kernel/dma/swiotlb.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c index bfc56cb217059..64b390136f9ef 100644 --- a/kernel/dma/swiotlb.c +++ b/kernel/dma/swiotlb.c @@ -378,6 +378,9 @@ void __init swiotlb_exit(void) unsigned long tbl_vaddr; size_t tbl_size, slots_size; + if (swiotlb_force == SWIOTLB_FORCE) + return; + if (!mem->nslabs) return; -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Tue Mar 01 10:53:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 10:53:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281112.479319 (Exim 4.92) (envelope-from ) id 1nP08N-0003Kk-Pn; Tue, 01 Mar 2022 10:53:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281112.479319; Tue, 01 Mar 2022 10:53:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP08N-0003Hr-I6; Tue, 01 Mar 2022 10:53:35 +0000 Received: by outflank-mailman (input) for mailman id 281112; Tue, 01 Mar 2022 10:53:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP08M-00031b-Bk for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 10:53:34 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-he1eur02on0604.outbound.protection.outlook.com [2a01:111:f400:fe05::604]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d61b203e-994d-11ec-8539-5f4723681683; Tue, 01 Mar 2022 11:53:33 +0100 (CET) Received: from AS8PR04CA0071.eurprd04.prod.outlook.com (2603:10a6:20b:313::16) by AM6PR08MB3672.eurprd08.prod.outlook.com (2603:10a6:20b:4d::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.26; Tue, 1 Mar 2022 10:53:28 +0000 Received: from AM5EUR03FT020.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:313:cafe::9d) by AS8PR04CA0071.outlook.office365.com (2603:10a6:20b:313::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19 via Frontend Transport; Tue, 1 Mar 2022 10:53:28 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT020.mail.protection.outlook.com (10.152.16.116) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22 via Frontend Transport; Tue, 1 Mar 2022 10:53:28 +0000 Received: ("Tessian outbound 341d209a0e52:v113"); Tue, 01 Mar 2022 10:53:28 +0000 Received: from e98e151bf0fd.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id F551B79B-F530-48EF-A956-8F6A4B27ADB8.1; Tue, 01 Mar 2022 10:53:21 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e98e151bf0fd.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 01 Mar 2022 10:53:21 +0000 Received: from AM0PR08MB3778.eurprd08.prod.outlook.com (2603:10a6:208:104::24) by VI1PR08MB3373.eurprd08.prod.outlook.com (2603:10a6:803:7b::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.21; Tue, 1 Mar 2022 10:53:18 +0000 Received: from AM0PR08MB3778.eurprd08.prod.outlook.com ([fe80::4dbb:4fed:bc86:1803]) by AM0PR08MB3778.eurprd08.prod.outlook.com ([fe80::4dbb:4fed:bc86:1803%6]) with mapi id 15.20.5017.027; Tue, 1 Mar 2022 10:53:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d61b203e-994d-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/m8pPoRu+85TyGj2cdbwexvelzOLKeuK5zCSd90Jpfk=; b=cjHB3X7t32514IEUinVsAEUjHLvvLaXzT9aGljisMIQQbC09ETL0WA5bSAusAFDw34dGe8qVPSgTuw6skyCbb6zZymQD3eddURDL8JCL/JdV+J6hFkkk6DH6HAJ+9oJW2Ta+LM1u1+lzonTgMSRvKwPx954yBfOQR2lqDdJ1OSU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: dcc9a82fe087dd1e X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Bjp/EKqdEGIniuhYycS+hk0JZ8TTc7JMMmYRh8wxnTgURdSRnwKYKFTDa5CTKDa/a4lFQ5s+/TAqR8zikIUtwwgJ7SWpL9ta/Yq3DJ7rDER47AWZLj+XXOQvud+SmPumlkckbwlwfy6J695XtQqINO83rA/mpUGOvfsh/mvWhdjJ7h9NldXBePx4+3UduRi5PPmUNUXCQ9cmcphGgnRZK30HCnrk0ekm4JhiYiPy9yn5oCilRgWyGG/sfNYg/A6PkguTAjgBw6SfH8aQmQr+vytWEJK4F32Bv3Z7irZdPVSe1dJnXj0X2TNe1kEi2XbiWZtX6u/TB6RyDb7hFjMLOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/m8pPoRu+85TyGj2cdbwexvelzOLKeuK5zCSd90Jpfk=; b=TI7CksXHbF9+atSPhahoBn8nfjfY3zMvqNgM25BYRt2VfvkpEinoJ12UfPUZTdf3ME49drJdtAFBZ1swaYUP3u3whtm1HBMDqMz5AwKIwUb1xUdPo2c32jEjdsJfKe/zawPl2tGfe0wa2LCyCnIS+PGz1cODTdJD5znjVHyM80Iq9V589t3+LIcvUie8iq/o9LlroQrT2G4xc9zD2dndqCvQq5S7Ew7AJMjsJtzGRiapTS/ubZ/hNmRCWoiGYVnXmjkBVPir0pTbNN0nmrTGgatlR9fjx9EDdFmdzTo+w7o9lHZHYN0EaxpjeBHv5/tcIivvn/WZ/BBugpkJAbwTVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/m8pPoRu+85TyGj2cdbwexvelzOLKeuK5zCSd90Jpfk=; b=cjHB3X7t32514IEUinVsAEUjHLvvLaXzT9aGljisMIQQbC09ETL0WA5bSAusAFDw34dGe8qVPSgTuw6skyCbb6zZymQD3eddURDL8JCL/JdV+J6hFkkk6DH6HAJ+9oJW2Ta+LM1u1+lzonTgMSRvKwPx954yBfOQR2lqDdJ1OSU= From: Bertrand Marquis To: Julien Grall CC: "xen-devel@lists.xenproject.org" , Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Julien Grall Subject: Re: [PATCH] xen/arm: Remove unused BOOT_RELOC_VIRT_START Thread-Topic: [PATCH] xen/arm: Remove unused BOOT_RELOC_VIRT_START Thread-Index: AQHYLIrpIk7mbc8G60OD3FqJgTcvKayqXAeA Date: Tue, 1 Mar 2022 10:53:18 +0000 Message-ID: <87B0168C-7020-4DB2-8FC9-F86ED999694C@arm.com> References: <20220228100633.57593-1-julien@xen.org> In-Reply-To: <20220228100633.57593-1-julien@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3693.60.0.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: cac44cd4-cad2-4a51-78ac-08d9fb71b7bb x-ms-traffictypediagnostic: VI1PR08MB3373:EE_|AM5EUR03FT020:EE_|AM6PR08MB3672:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 4n3GqBQMvvUr1VOF5iZhN9SuyUAXXobxDAtLdJYLYvfJR6V+9CArKqxg0bXvCG4SjQICm2sgOQ3Ibl872AX2o6i1IdrepnOWS9MiP5PhbZSnttKl9kCFEln0n1kNcYRk3TEblA0duXyfnGSCzoKIgnUizzg4a4aX5q+v0gkvNRS2drIc0r1LGitqzcQPCNZ/yaemNFQ0sSvL1pSY947QiiSjwZnm7XdZioDFn1LP8lziZ9YyNNtSN54GIe1E1fpWhZybmufmT8bWKFdYECT1sgelB7MzNkOjl3N46wYOR4ia2OdoyyK9pgJKdg5NyGeUTIjui9p6HY4LEAhkCy2XGOrliw4LJiBQn9GVLNtArDIhUf0wxmuQ4NcOlAMWbnWYPqEJrY27QZ0NSIPV/z/BmFeoRKxlgPU13+nyHMp7yS0DiisfbDSJxZ1RCcT5AzJWJ292KSA6gee7XFhVCw9ph42mKXVN3ZTS2qQD+iYfq3/HQh8xCy8jjj9DP3MuOFqsOJ/RWd4rdoJIwKxgLqncphuSsUq26pdOYF2cphrgxtSZntkNFbhZhBvheOu1ZGRQ1lPAaLQj5ZQqpvyNf5temhAIOtwuujmM/zbIgBNyS6d2PD9Zb9yspfiVIJ52bXev/+lr+5Ehb6CNASDgxPF0Y+meo4BCPF66x3AYeB2JeC3dPmPhSk++EyoQBitCG1+r/Pm2pZU57SstcsyAeg+ceVBsOYCJnL8AeoF9yml4TbwTKOKmJ38lqouJ+ketHxz1 X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3778.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38100700002)(38070700005)(36756003)(122000001)(33656002)(186003)(26005)(86362001)(2616005)(6916009)(54906003)(316002)(4326008)(76116006)(66476007)(66946007)(6506007)(66446008)(66556008)(6512007)(64756008)(53546011)(71200400001)(6486002)(508600001)(8676002)(2906002)(83380400001)(8936002)(5660300002)(91956017)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3373 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT020.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: a6d0a581-31e3-4643-c56d-08d9fb71b20a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nYwSQosoydZ7Ws/+a7977DYhwTfSAn3LFuR4HZ+hgmOkaP60bNRUzHMgVKpTGs03kwdlknDZnRxWbxkWn57SPTOu4DgauP6uO8lAmUzLZb/L+4otJBT7Mu2jcLR6iWXu6LXTr8t+zttZZDT3dQeFwlZOdp9T45t4UnZNZPb/7MsAEePyyR0o2YvlUXXZVHMlwiHbaxbPhPf1wfXBTMWDLH73nNi33hjj73jCDhE+5y/cW3KMt7fL/lT8zFbgTpivK3rw3ccaU8+o82u71qejyeNk3O6HeirJ8Te/fcOFV2AP2oBKrCu7vb3ClTKTJTBmJBGRbEkqWTwukvg5wAq1y3iXETl5GHPSDOyDpgNqkI0JPINIfOUJSMo8rVvnJkbi1huGBb8NcgWdG5ZB599jrBUWkx/hPXYkM1DwpiesASwUdEqcdTI+aao/rcDhezv7h7+f8ehxT56XLkKUTzvt/3jLKYtfZ0+aILoPdDl42aq8/KUv3SsHSvQEtCVbYrtIk3N+uVTiLTsFNHXa+3fGYJVYYxDXf98Qjye2/UEPt3Me3fHY4+4euB0QBwb0vTyEyrSzKiWkhkOWQleAtYAaEgu8W1f1zpBwlyI+/2s0ZdOG3a/eAonX3bhLICAtCyblgSuciL9WdpRKr9d79xQSqBnAxWsdmMEcTn4DehVk/1v7XMni1C5vnVJ9YDm+NaDm X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(6512007)(40460700003)(6862004)(4326008)(70586007)(5660300002)(70206006)(86362001)(8676002)(82310400004)(186003)(53546011)(26005)(6506007)(8936002)(336012)(33656002)(83380400001)(2616005)(6486002)(356005)(36860700001)(508600001)(54906003)(81166007)(2906002)(316002)(47076005)(36756003)(107886003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2022 10:53:28.1403 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cac44cd4-cad2-4a51-78ac-08d9fb71b7bb X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT020.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3672 Hi Julien, > On 28 Feb 2022, at 10:06, Julien Grall wrote: >=20 > From: Julien Grall >=20 > We stopped relocating Xen since commit f60658c6ae "xen/arm: Stop > relocating Xen". >=20 > At the same time, update the memory layout description. >=20 > Signed-off-by: Julien Grall > Signed-off-by: Julien Grall Reviewed-by: Bertrand Marquis Cheers Bertrand > --- > xen/arch/arm/include/asm/config.h | 4 +--- > xen/arch/arm/mm.c | 1 - > 2 files changed, 1 insertion(+), 4 deletions(-) >=20 > diff --git a/xen/arch/arm/include/asm/config.h b/xen/arch/arm/include/asm= /config.h > index 2aced0bc3b8b..b25c9d39bb32 100644 > --- a/xen/arch/arm/include/asm/config.h > +++ b/xen/arch/arm/include/asm/config.h > @@ -77,8 +77,7 @@ > * 2M - 4M Xen text, data, bss > * 4M - 6M Fixmap: special-purpose 4K mapping slots > * 6M - 10M Early boot mapping of FDT > - * 10M - 12M Early relocation address (used when relocating Xen) > - * and later for livepatch vmap (if compiled in) > + * 10M - 12M Livepatch vmap (if compiled in) > * > * ARM32 layout: > * 0 - 12M > @@ -115,7 +114,6 @@ > #define BOOT_FDT_SLOT_SIZE MB(4) > #define BOOT_FDT_VIRT_END (BOOT_FDT_VIRT_START + BOOT_FDT_SLOT_SIZE) >=20 > -#define BOOT_RELOC_VIRT_START _AT(vaddr_t,0x00a00000) > #ifdef CONFIG_LIVEPATCH > #define LIVEPATCH_VMAP_START _AT(vaddr_t,0x00a00000) > #define LIVEPATCH_VMAP_END (LIVEPATCH_VMAP_START + MB(2)) > diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c > index 515d0906f85b..8a17222109c6 100644 > --- a/xen/arch/arm/mm.c > +++ b/xen/arch/arm/mm.c > @@ -196,7 +196,6 @@ static void __init __maybe_unused build_assertions(vo= id) > /* 2MB aligned regions */ > BUILD_BUG_ON(XEN_VIRT_START & ~SECOND_MASK); > BUILD_BUG_ON(FIXMAP_ADDR(0) & ~SECOND_MASK); > - BUILD_BUG_ON(BOOT_RELOC_VIRT_START & ~SECOND_MASK); > /* 1GB aligned regions */ > #ifdef CONFIG_ARM_32 > BUILD_BUG_ON(XENHEAP_VIRT_START & ~FIRST_MASK); > --=20 > 2.32.0 >=20 From xen-devel-bounces@lists.xenproject.org Tue Mar 01 10:53:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 10:53:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281114.479345 (Exim 4.92) (envelope-from ) id 1nP08T-0004Bo-A9; Tue, 01 Mar 2022 10:53:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281114.479345; Tue, 01 Mar 2022 10:53:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP08T-0004BZ-6E; Tue, 01 Mar 2022 10:53:41 +0000 Received: by outflank-mailman (input) for mailman id 281114; Tue, 01 Mar 2022 10:53:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP08R-00031b-LO for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 10:53:39 +0000 Received: from bombadil.infradead.org (bombadil.infradead.org [2607:7c80:54:e::133]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d93cb5de-994d-11ec-8539-5f4723681683; Tue, 01 Mar 2022 11:53:38 +0100 (CET) Received: from [2.53.44.23] (helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nP08E-00GCz8-AM; Tue, 01 Mar 2022 10:53:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d93cb5de-994d-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=A0DzSvvS64HjAzE2XMQzk7Jm+OVlQzZUcMYFGVBmu7k=; b=QcD+g2bAZloPsGuAs2SY+vJGCg rv+HhE9TnpOXcyMAPOZmFzmHJl3jnx34GwZgZG24XzdnByIgzZE0CBoGWC/7y8jWksOx8gAtCOn9w 11rWTBSZFsTEY3QtBt2TLy/IU42CsemUekEbmdXyZugiZYIdY8t5MdbczK7zOZAhEtqydZMqx5sND hsDOkqXxSuZewhVYVyUPaMNFMtlQZ49ELHfETbHcYFn+wOw0D3MB+68OD6L2VF4BZU1ECdsEL85tx gWcrQajjKEnfOC+GPfRpESVf2ppYJUrQeHGkSbSMThkO7AZAg3xYpOLUqRA52iZRlvoiif6wNe7SB Ir/ycXgw==; From: Christoph Hellwig To: iommu@lists.linux-foundation.org Cc: x86@kernel.org, Anshuman Khandual , Tom Lendacky , Konrad Rzeszutek Wilk , Stefano Stabellini , Boris Ostrovsky , Juergen Gross , Joerg Roedel , David Woodhouse , Lu Baolu , Robin Murphy , linux-arm-kernel@lists.infradead.org, xen-devel@lists.xenproject.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-hyperv@vger.kernel.org, tboot-devel@lists.sourceforge.net, linux-pci@vger.kernel.org Subject: [PATCH 03/12] swiotlb: simplify swiotlb_max_segment Date: Tue, 1 Mar 2022 12:53:02 +0200 Message-Id: <20220301105311.885699-4-hch@lst.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220301105311.885699-1-hch@lst.de> References: <20220301105311.885699-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Remove the bogus Xen override that was usually larger than the actual size and just calculate the value on demand. Note that swiotlb_max_segment still doesn't make sense as an interface and should eventually be removed. Signed-off-by: Christoph Hellwig Reviewed-by: Anshuman Khandual --- drivers/xen/swiotlb-xen.c | 2 -- include/linux/swiotlb.h | 1 - kernel/dma/swiotlb.c | 20 +++----------------- 3 files changed, 3 insertions(+), 20 deletions(-) diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c index 47aebd98f52f5..485cd06ed39e7 100644 --- a/drivers/xen/swiotlb-xen.c +++ b/drivers/xen/swiotlb-xen.c @@ -202,7 +202,6 @@ int xen_swiotlb_init(void) rc = swiotlb_late_init_with_tbl(start, nslabs); if (rc) return rc; - swiotlb_set_max_segment(PAGE_SIZE); return 0; error: if (nslabs > 1024 && repeat--) { @@ -254,7 +253,6 @@ void __init xen_swiotlb_init_early(void) if (swiotlb_init_with_tbl(start, nslabs, true)) panic("Cannot allocate SWIOTLB buffer"); - swiotlb_set_max_segment(PAGE_SIZE); } #endif /* CONFIG_X86 */ diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h index f6c3638255d54..9fb3a568f0c51 100644 --- a/include/linux/swiotlb.h +++ b/include/linux/swiotlb.h @@ -164,7 +164,6 @@ static inline void swiotlb_adjust_size(unsigned long size) #endif /* CONFIG_SWIOTLB */ extern void swiotlb_print_info(void); -extern void swiotlb_set_max_segment(unsigned int); #ifdef CONFIG_DMA_RESTRICTED_POOL struct page *swiotlb_alloc(struct device *dev, size_t size); diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c index 64b390136f9ef..e31c235b5fd9e 100644 --- a/kernel/dma/swiotlb.c +++ b/kernel/dma/swiotlb.c @@ -75,12 +75,6 @@ struct io_tlb_mem io_tlb_default_mem; phys_addr_t swiotlb_unencrypted_base; -/* - * Max segment that we can provide which (if pages are contingous) will - * not be bounced (unless SWIOTLB_FORCE is set). - */ -static unsigned int max_segment; - static unsigned long default_nslabs = IO_TLB_DEFAULT_SIZE >> IO_TLB_SHIFT; static int __init @@ -104,18 +98,12 @@ early_param("swiotlb", setup_io_tlb_npages); unsigned int swiotlb_max_segment(void) { - return io_tlb_default_mem.nslabs ? max_segment : 0; + if (!io_tlb_default_mem.nslabs) + return 0; + return rounddown(io_tlb_default_mem.nslabs << IO_TLB_SHIFT, PAGE_SIZE); } EXPORT_SYMBOL_GPL(swiotlb_max_segment); -void swiotlb_set_max_segment(unsigned int val) -{ - if (swiotlb_force == SWIOTLB_FORCE) - max_segment = 1; - else - max_segment = rounddown(val, PAGE_SIZE); -} - unsigned long swiotlb_size_or_default(void) { return default_nslabs << IO_TLB_SHIFT; @@ -267,7 +255,6 @@ int __init swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, int verbose) if (verbose) swiotlb_print_info(); - swiotlb_set_max_segment(mem->nslabs << IO_TLB_SHIFT); return 0; } @@ -368,7 +355,6 @@ swiotlb_late_init_with_tbl(char *tlb, unsigned long nslabs) swiotlb_init_io_tlb_mem(mem, virt_to_phys(tlb), nslabs, true); swiotlb_print_info(); - swiotlb_set_max_segment(mem->nslabs << IO_TLB_SHIFT); return 0; } -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Tue Mar 01 10:53:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 10:53:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281115.479356 (Exim 4.92) (envelope-from ) id 1nP08W-0004Xs-Jr; Tue, 01 Mar 2022 10:53:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281115.479356; Tue, 01 Mar 2022 10:53:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP08W-0004Xf-GI; Tue, 01 Mar 2022 10:53:44 +0000 Received: by outflank-mailman (input) for mailman id 281115; Tue, 01 Mar 2022 10:53:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP08V-00031a-1n for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 10:53:43 +0000 Received: from bombadil.infradead.org (bombadil.infradead.org [2607:7c80:54:e::133]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id db4274b8-994d-11ec-8eba-a37418f5ba1a; Tue, 01 Mar 2022 11:53:42 +0100 (CET) Received: from [2.53.44.23] (helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nP08H-00GD0g-Sa; Tue, 01 Mar 2022 10:53:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: db4274b8-994d-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=F4csY1Wi5RcD4CgfgCj72ltp02xg/m2xFaHFXHqOV2U=; b=gUOyui1yxriv3hEEp272+80Q2F jOUBGJQGyIAeVliqSLArMsnw436LgJOzQQeLiq8Znfql2Jzag37nquPrG4dNyHN+wJZUIZ2FEmRzL VetzMUhB2WM68xOFhcY+0twrsScsxFZRaJt9+pmIRX6UcYn20suPG6XdsffIdmq5rXRvBHNeguSP6 73Oo9X1RQUGpHCIZ8XhrqVixxc0FBrQmM8ahlSO4qbkUI47d8dhdpqpl9jgxT9jiZs3SXGePiT3FS QCl1IiCbPqW8OCmr4X8Yypy8l194Dn26SoA6d0HIiT/r1YIQZq+YYFI7NtNdVbJlD///I5zwGw4OC NqAx9Geg==; From: Christoph Hellwig To: iommu@lists.linux-foundation.org Cc: x86@kernel.org, Anshuman Khandual , Tom Lendacky , Konrad Rzeszutek Wilk , Stefano Stabellini , Boris Ostrovsky , Juergen Gross , Joerg Roedel , David Woodhouse , Lu Baolu , Robin Murphy , linux-arm-kernel@lists.infradead.org, xen-devel@lists.xenproject.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-hyperv@vger.kernel.org, tboot-devel@lists.sourceforge.net, linux-pci@vger.kernel.org Subject: [PATCH 04/12] swiotlb: rename swiotlb_late_init_with_default_size Date: Tue, 1 Mar 2022 12:53:03 +0200 Message-Id: <20220301105311.885699-5-hch@lst.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220301105311.885699-1-hch@lst.de> References: <20220301105311.885699-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html swiotlb_late_init_with_default_size is an overly verbose name that doesn't even catch what the function is doing, given that the size is not just a default but the actual requested size. Rename it to swiotlb_init_late. Signed-off-by: Christoph Hellwig Reviewed-by: Anshuman Khandual --- arch/x86/pci/sta2x11-fixup.c | 2 +- include/linux/swiotlb.h | 2 +- kernel/dma/swiotlb.c | 6 ++---- 3 files changed, 4 insertions(+), 6 deletions(-) diff --git a/arch/x86/pci/sta2x11-fixup.c b/arch/x86/pci/sta2x11-fixup.c index 101081ad64b6d..e0c039a75b2db 100644 --- a/arch/x86/pci/sta2x11-fixup.c +++ b/arch/x86/pci/sta2x11-fixup.c @@ -57,7 +57,7 @@ static void sta2x11_new_instance(struct pci_dev *pdev) int size = STA2X11_SWIOTLB_SIZE; /* First instance: register your own swiotlb area */ dev_info(&pdev->dev, "Using SWIOTLB (size %i)\n", size); - if (swiotlb_late_init_with_default_size(size)) + if (swiotlb_init_late(size)) dev_emerg(&pdev->dev, "init swiotlb failed\n"); } list_add(&instance->list, &sta2x11_instance_list); diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h index 9fb3a568f0c51..b48b26bfa0edb 100644 --- a/include/linux/swiotlb.h +++ b/include/linux/swiotlb.h @@ -40,7 +40,7 @@ extern void swiotlb_init(int verbose); int swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, int verbose); unsigned long swiotlb_size_or_default(void); extern int swiotlb_late_init_with_tbl(char *tlb, unsigned long nslabs); -extern int swiotlb_late_init_with_default_size(size_t default_size); +int swiotlb_init_late(size_t size); extern void __init swiotlb_update_mem_attributes(void); phys_addr_t swiotlb_tbl_map_single(struct device *hwdev, phys_addr_t phys, diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c index e31c235b5fd9e..0b1992c355f36 100644 --- a/kernel/dma/swiotlb.c +++ b/kernel/dma/swiotlb.c @@ -290,11 +290,9 @@ swiotlb_init(int verbose) * initialize the swiotlb later using the slab allocator if needed. * This should be just like above, but with some error catching. */ -int -swiotlb_late_init_with_default_size(size_t default_size) +int swiotlb_init_late(size_t size) { - unsigned long nslabs = - ALIGN(default_size >> IO_TLB_SHIFT, IO_TLB_SEGSIZE); + unsigned long nslabs = ALIGN(size >> IO_TLB_SHIFT, IO_TLB_SEGSIZE); unsigned long bytes; unsigned char *vstart = NULL; unsigned int order; -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Tue Mar 01 10:53:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 10:53:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281116.479367 (Exim 4.92) (envelope-from ) id 1nP08Y-0004uK-Vf; Tue, 01 Mar 2022 10:53:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281116.479367; Tue, 01 Mar 2022 10:53:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP08Y-0004u5-QN; Tue, 01 Mar 2022 10:53:46 +0000 Received: by outflank-mailman (input) for mailman id 281116; Tue, 01 Mar 2022 10:53:45 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP08W-00031a-VL for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 10:53:45 +0000 Received: from bombadil.infradead.org (bombadil.infradead.org [2607:7c80:54:e::133]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id dc6d519c-994d-11ec-8eba-a37418f5ba1a; Tue, 01 Mar 2022 11:53:44 +0100 (CET) Received: from [2.53.44.23] (helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nP08L-00GD2p-Cd; Tue, 01 Mar 2022 10:53:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dc6d519c-994d-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=fw5CJGRWfS2qx4RLqYxqctHTinwQ2YN+lYk2/GZzFw8=; b=oQNBKGhMS01GkNaiykQiJM1eLd vRESuDJanvP54R4ITyrRLSUuGPOceoi6GtUCJmeVTcVbKIb6HTNWTn8kqxugSvDOVcDgZUsHy96pd dby66LZxGUvs/10nECjNWAMAguYvHKX/psdAJm7rWIlvynPLP9IcrWBmaDFf8HN+9J23CvC37TQaD sgY0/HEmNw6l5ck0Svp0ox8NUlX7Wa8dRG069/BR78zpB4VwRhg6mko9moUsppjv1oXN0aPQQse2j pJlWW5h93gf9TjjeUODJPDnwEXoacsoZV+pfZoJ6c/3jXpMoyweSQk7ch/UNQaDSu053oytWfCM3Q vHimhqeg==; From: Christoph Hellwig To: iommu@lists.linux-foundation.org Cc: x86@kernel.org, Anshuman Khandual , Tom Lendacky , Konrad Rzeszutek Wilk , Stefano Stabellini , Boris Ostrovsky , Juergen Gross , Joerg Roedel , David Woodhouse , Lu Baolu , Robin Murphy , linux-arm-kernel@lists.infradead.org, xen-devel@lists.xenproject.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-hyperv@vger.kernel.org, tboot-devel@lists.sourceforge.net, linux-pci@vger.kernel.org Subject: [PATCH 05/12] swiotlb: pass a gfp_mask argument to swiotlb_init_late Date: Tue, 1 Mar 2022 12:53:04 +0200 Message-Id: <20220301105311.885699-6-hch@lst.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220301105311.885699-1-hch@lst.de> References: <20220301105311.885699-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Let the caller chose a zone to allocate from. This will be used later on by the xen-swiotlb initialization on arm. Signed-off-by: Christoph Hellwig Reviewed-by: Anshuman Khandual --- arch/x86/pci/sta2x11-fixup.c | 2 +- include/linux/swiotlb.h | 2 +- kernel/dma/swiotlb.c | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/x86/pci/sta2x11-fixup.c b/arch/x86/pci/sta2x11-fixup.c index e0c039a75b2db..c7e6faf59a861 100644 --- a/arch/x86/pci/sta2x11-fixup.c +++ b/arch/x86/pci/sta2x11-fixup.c @@ -57,7 +57,7 @@ static void sta2x11_new_instance(struct pci_dev *pdev) int size = STA2X11_SWIOTLB_SIZE; /* First instance: register your own swiotlb area */ dev_info(&pdev->dev, "Using SWIOTLB (size %i)\n", size); - if (swiotlb_init_late(size)) + if (swiotlb_init_late(size, GFP_DMA)) dev_emerg(&pdev->dev, "init swiotlb failed\n"); } list_add(&instance->list, &sta2x11_instance_list); diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h index b48b26bfa0edb..1befd6b2ccf5e 100644 --- a/include/linux/swiotlb.h +++ b/include/linux/swiotlb.h @@ -40,7 +40,7 @@ extern void swiotlb_init(int verbose); int swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, int verbose); unsigned long swiotlb_size_or_default(void); extern int swiotlb_late_init_with_tbl(char *tlb, unsigned long nslabs); -int swiotlb_init_late(size_t size); +int swiotlb_init_late(size_t size, gfp_t gfp_mask); extern void __init swiotlb_update_mem_attributes(void); phys_addr_t swiotlb_tbl_map_single(struct device *hwdev, phys_addr_t phys, diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c index 0b1992c355f36..9a38ea3a46e9f 100644 --- a/kernel/dma/swiotlb.c +++ b/kernel/dma/swiotlb.c @@ -290,7 +290,7 @@ swiotlb_init(int verbose) * initialize the swiotlb later using the slab allocator if needed. * This should be just like above, but with some error catching. */ -int swiotlb_init_late(size_t size) +int swiotlb_init_late(size_t size, gfp_t gfp_mask) { unsigned long nslabs = ALIGN(size >> IO_TLB_SHIFT, IO_TLB_SEGSIZE); unsigned long bytes; @@ -309,7 +309,7 @@ int swiotlb_init_late(size_t size) bytes = nslabs << IO_TLB_SHIFT; while ((SLABS_PER_PAGE << order) > IO_TLB_MIN_SLABS) { - vstart = (void *)__get_free_pages(GFP_DMA | __GFP_NOWARN, + vstart = (void *)__get_free_pages(gfp_mask | __GFP_NOWARN, order); if (vstart) break; -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Tue Mar 01 10:53:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 10:53:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281118.479377 (Exim 4.92) (envelope-from ) id 1nP08e-0005b1-DG; Tue, 01 Mar 2022 10:53:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281118.479377; Tue, 01 Mar 2022 10:53:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP08e-0005ag-94; Tue, 01 Mar 2022 10:53:52 +0000 Received: by outflank-mailman (input) for mailman id 281118; Tue, 01 Mar 2022 10:53:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP08c-00031b-L4 for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 10:53:50 +0000 Received: from bombadil.infradead.org (bombadil.infradead.org [2607:7c80:54:e::133]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id dfcc905a-994d-11ec-8539-5f4723681683; Tue, 01 Mar 2022 11:53:49 +0100 (CET) Received: from [2.53.44.23] (helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nP08O-00GD52-Sv; Tue, 01 Mar 2022 10:53:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dfcc905a-994d-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=2LuLtS1efSBZ06JRKs3rwu/XDIHFFEkeBlwKrISdqYE=; b=d0GW7Tw12y7oHEGfOc2+6gvXWU gth40xP+Gz9285nWvmrnNehOfvBSMx2xt0QdApjuW42I7eWQpyyKL1pXI0s4WzqImgyuzcAb3j9jf +SISwsedK7cWJhFGHhjm5c7XuU8iQf1QTq0VDFeYk6ONhkhoWSgOm7iaWp5zedDcQjWUChB8dASDc /d0vPlBfgeQKsF5aXF9OIW8TwXU1Ixv68xdkCCkTrkwjXeTn7qylYSEif1BWWjiKHxYdVnXPCzfPN xdWlLnFGt6Y79j4yHp/oknbXTJhnyfXhZ8B9sm7KrK9dWl/oJA9n8pQJhROaLbLywWs6qg9KLS6Un cnAd3l4Q==; From: Christoph Hellwig To: iommu@lists.linux-foundation.org Cc: x86@kernel.org, Anshuman Khandual , Tom Lendacky , Konrad Rzeszutek Wilk , Stefano Stabellini , Boris Ostrovsky , Juergen Gross , Joerg Roedel , David Woodhouse , Lu Baolu , Robin Murphy , linux-arm-kernel@lists.infradead.org, xen-devel@lists.xenproject.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-hyperv@vger.kernel.org, tboot-devel@lists.sourceforge.net, linux-pci@vger.kernel.org Subject: [PATCH 06/12] MIPS/octeon: use swiotlb_init instead of open coding it Date: Tue, 1 Mar 2022 12:53:05 +0200 Message-Id: <20220301105311.885699-7-hch@lst.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220301105311.885699-1-hch@lst.de> References: <20220301105311.885699-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Use the generic swiotlb initialization helper instead of open coding it. Signed-off-by: Christoph Hellwig --- arch/mips/cavium-octeon/dma-octeon.c | 15 ++------------- arch/mips/pci/pci-octeon.c | 2 +- 2 files changed, 3 insertions(+), 14 deletions(-) diff --git a/arch/mips/cavium-octeon/dma-octeon.c b/arch/mips/cavium-octeon/dma-octeon.c index df70308db0e69..fb7547e217263 100644 --- a/arch/mips/cavium-octeon/dma-octeon.c +++ b/arch/mips/cavium-octeon/dma-octeon.c @@ -186,15 +186,12 @@ phys_addr_t dma_to_phys(struct device *dev, dma_addr_t daddr) return daddr; } -char *octeon_swiotlb; - void __init plat_swiotlb_setup(void) { phys_addr_t start, end; phys_addr_t max_addr; phys_addr_t addr_size; size_t swiotlbsize; - unsigned long swiotlb_nslabs; u64 i; max_addr = 0; @@ -236,15 +233,7 @@ void __init plat_swiotlb_setup(void) if (OCTEON_IS_OCTEON2() && max_addr >= 0x100000000ul) swiotlbsize = 64 * (1<<20); #endif - swiotlb_nslabs = swiotlbsize >> IO_TLB_SHIFT; - swiotlb_nslabs = ALIGN(swiotlb_nslabs, IO_TLB_SEGSIZE); - swiotlbsize = swiotlb_nslabs << IO_TLB_SHIFT; - - octeon_swiotlb = memblock_alloc_low(swiotlbsize, PAGE_SIZE); - if (!octeon_swiotlb) - panic("%s: Failed to allocate %zu bytes align=%lx\n", - __func__, swiotlbsize, PAGE_SIZE); - if (swiotlb_init_with_tbl(octeon_swiotlb, swiotlb_nslabs, 1) == -ENOMEM) - panic("Cannot allocate SWIOTLB buffer"); + swiotlb_adjust_size(swiotlbsize); + swiotlb_init(1); } diff --git a/arch/mips/pci/pci-octeon.c b/arch/mips/pci/pci-octeon.c index fc29b85cfa926..e457a18cbdc59 100644 --- a/arch/mips/pci/pci-octeon.c +++ b/arch/mips/pci/pci-octeon.c @@ -664,7 +664,7 @@ static int __init octeon_pci_setup(void) /* BAR1 movable regions contiguous to cover the swiotlb */ octeon_bar1_pci_phys = - virt_to_phys(octeon_swiotlb) & ~((1ull << 22) - 1); + io_tlb_default_mem.start & ~((1ull << 22) - 1); for (index = 0; index < 32; index++) { union cvmx_pci_bar1_indexx bar1_index; -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Tue Mar 01 10:53:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 10:53:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281133.479389 (Exim 4.92) (envelope-from ) id 1nP08k-0006Z0-RW; Tue, 01 Mar 2022 10:53:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281133.479389; Tue, 01 Mar 2022 10:53:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP08k-0006YR-N0; Tue, 01 Mar 2022 10:53:58 +0000 Received: by outflank-mailman (input) for mailman id 281133; Tue, 01 Mar 2022 10:53:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP08j-00031b-EO for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 10:53:57 +0000 Received: from bombadil.infradead.org (bombadil.infradead.org [2607:7c80:54:e::133]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e2bc49c5-994d-11ec-8539-5f4723681683; Tue, 01 Mar 2022 11:53:54 +0100 (CET) Received: from [2.53.44.23] (helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nP08S-00GD8C-Fs; Tue, 01 Mar 2022 10:53:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e2bc49c5-994d-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=QlJEhdZKSp+/j7GU59vJCF8WhoQcKGKIb5D13FyS+IU=; b=r9rZYgz8+yDMzg+TVcNrIpR5jM tpFBvURKAlNTMslLzEdEkLEEJ9fLs4MRaNOfN9E69YqNxR8z2HX7ei4q+P610iYtMYDgXvufqmiLK 1jGWVsTM/jGqBhe+jYhFkJmwqHq64UJMb4A0JtTyGOcgFr+bK0uFtZtly1qPLYrua8SdJRJUEi0B4 sjWz+pmHz4QpImiIu7wPgspbQCa1F1EDWvDIoSW+BeYLTxafaCEJDgSg5TS5B6qD0NwS7EkZm2R/v b1gxYQ16GJk7WTficLfM/6Gh4ELwzw3sgTLdff5AaQP3ZRoEeuCi0ktLqzJNqSQimemdwbJyObBy7 JbtGiYIw==; From: Christoph Hellwig To: iommu@lists.linux-foundation.org Cc: x86@kernel.org, Anshuman Khandual , Tom Lendacky , Konrad Rzeszutek Wilk , Stefano Stabellini , Boris Ostrovsky , Juergen Gross , Joerg Roedel , David Woodhouse , Lu Baolu , Robin Murphy , linux-arm-kernel@lists.infradead.org, xen-devel@lists.xenproject.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-hyperv@vger.kernel.org, tboot-devel@lists.sourceforge.net, linux-pci@vger.kernel.org Subject: [PATCH 07/12] x86: remove the IOMMU table infrastructure Date: Tue, 1 Mar 2022 12:53:06 +0200 Message-Id: <20220301105311.885699-8-hch@lst.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220301105311.885699-1-hch@lst.de> References: <20220301105311.885699-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html The IOMMU table tries to separate the different IOMMUs into different backends, but actually requires various cross calls. Rewrite the code to do the generic swiotlb/swiotlb-xen setup directly in pci-dma.c and then just call into the IOMMU drivers. Signed-off-by: Christoph Hellwig --- arch/ia64/include/asm/iommu_table.h | 7 -- arch/x86/include/asm/dma-mapping.h | 1 - arch/x86/include/asm/gart.h | 5 +- arch/x86/include/asm/iommu.h | 6 ++ arch/x86/include/asm/iommu_table.h | 102 ----------------------- arch/x86/include/asm/swiotlb.h | 30 ------- arch/x86/include/asm/xen/swiotlb-xen.h | 2 - arch/x86/kernel/Makefile | 2 - arch/x86/kernel/amd_gart_64.c | 5 +- arch/x86/kernel/aperture_64.c | 14 ++-- arch/x86/kernel/pci-dma.c | 107 ++++++++++++++++++++----- arch/x86/kernel/pci-iommu_table.c | 77 ------------------ arch/x86/kernel/pci-swiotlb.c | 77 ------------------ arch/x86/kernel/tboot.c | 1 - arch/x86/kernel/vmlinux.lds.S | 12 --- arch/x86/xen/Makefile | 2 - arch/x86/xen/pci-swiotlb-xen.c | 96 ---------------------- drivers/iommu/amd/init.c | 6 -- drivers/iommu/amd/iommu.c | 5 +- drivers/iommu/intel/dmar.c | 6 +- include/linux/dmar.h | 6 +- 21 files changed, 110 insertions(+), 459 deletions(-) delete mode 100644 arch/ia64/include/asm/iommu_table.h delete mode 100644 arch/x86/include/asm/iommu_table.h delete mode 100644 arch/x86/include/asm/swiotlb.h delete mode 100644 arch/x86/kernel/pci-iommu_table.c delete mode 100644 arch/x86/kernel/pci-swiotlb.c delete mode 100644 arch/x86/xen/pci-swiotlb-xen.c diff --git a/arch/ia64/include/asm/iommu_table.h b/arch/ia64/include/asm/iommu_table.h deleted file mode 100644 index cc96116ac276a..0000000000000 --- a/arch/ia64/include/asm/iommu_table.h +++ /dev/null @@ -1,7 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0 */ -#ifndef _ASM_IA64_IOMMU_TABLE_H -#define _ASM_IA64_IOMMU_TABLE_H - -#define IOMMU_INIT_POST(_detect) - -#endif /* _ASM_IA64_IOMMU_TABLE_H */ diff --git a/arch/x86/include/asm/dma-mapping.h b/arch/x86/include/asm/dma-mapping.h index bb1654fe0ce74..256fd8115223d 100644 --- a/arch/x86/include/asm/dma-mapping.h +++ b/arch/x86/include/asm/dma-mapping.h @@ -9,7 +9,6 @@ #include #include -#include extern int iommu_merge; extern int panic_on_overflow; diff --git a/arch/x86/include/asm/gart.h b/arch/x86/include/asm/gart.h index 3185565743459..5af8088a10df6 100644 --- a/arch/x86/include/asm/gart.h +++ b/arch/x86/include/asm/gart.h @@ -38,7 +38,7 @@ extern int gart_iommu_aperture_disabled; extern void early_gart_iommu_check(void); extern int gart_iommu_init(void); extern void __init gart_parse_options(char *); -extern int gart_iommu_hole_init(void); +void gart_iommu_hole_init(void); #else #define gart_iommu_aperture 0 @@ -51,9 +51,8 @@ static inline void early_gart_iommu_check(void) static inline void gart_parse_options(char *options) { } -static inline int gart_iommu_hole_init(void) +static inline void gart_iommu_hole_init(void) { - return -ENODEV; } #endif diff --git a/arch/x86/include/asm/iommu.h b/arch/x86/include/asm/iommu.h index bf1ed2ddc74bd..dba89ed40d38d 100644 --- a/arch/x86/include/asm/iommu.h +++ b/arch/x86/include/asm/iommu.h @@ -9,6 +9,12 @@ extern int force_iommu, no_iommu; extern int iommu_detected; +#ifdef CONFIG_SWIOTLB +extern bool x86_swiotlb_enable; +#else +#define x86_swiotlb_enable false +#endif + /* 10 seconds */ #define DMAR_OPERATION_TIMEOUT ((cycles_t) tsc_khz*10*1000) diff --git a/arch/x86/include/asm/iommu_table.h b/arch/x86/include/asm/iommu_table.h deleted file mode 100644 index 1fb3fd1a83c25..0000000000000 --- a/arch/x86/include/asm/iommu_table.h +++ /dev/null @@ -1,102 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0 */ -#ifndef _ASM_X86_IOMMU_TABLE_H -#define _ASM_X86_IOMMU_TABLE_H - -#include - -/* - * History lesson: - * The execution chain of IOMMUs in 2.6.36 looks as so: - * - * [xen-swiotlb] - * | - * +----[swiotlb *]--+ - * / | \ - * / | \ - * [GART] [Calgary] [Intel VT-d] - * / - * / - * [AMD-Vi] - * - * *: if SWIOTLB detected 'iommu=soft'/'swiotlb=force' it would skip - * over the rest of IOMMUs and unconditionally initialize the SWIOTLB. - * Also it would surreptitiously initialize set the swiotlb=1 if there were - * more than 4GB and if the user did not pass in 'iommu=off'. The swiotlb - * flag would be turned off by all IOMMUs except the Calgary one. - * - * The IOMMU_INIT* macros allow a similar tree (or more complex if desired) - * to be built by defining who we depend on. - * - * And all that needs to be done is to use one of the macros in the IOMMU - * and the pci-dma.c will take care of the rest. - */ - -struct iommu_table_entry { - initcall_t detect; - initcall_t depend; - void (*early_init)(void); /* No memory allocate available. */ - void (*late_init)(void); /* Yes, can allocate memory. */ -#define IOMMU_FINISH_IF_DETECTED (1<<0) -#define IOMMU_DETECTED (1<<1) - int flags; -}; -/* - * Macro fills out an entry in the .iommu_table that is equivalent - * to the fields that 'struct iommu_table_entry' has. The entries - * that are put in the .iommu_table section are not put in any order - * hence during boot-time we will have to resort them based on - * dependency. */ - - -#define __IOMMU_INIT(_detect, _depend, _early_init, _late_init, _finish)\ - static const struct iommu_table_entry \ - __iommu_entry_##_detect __used \ - __attribute__ ((unused, __section__(".iommu_table"), \ - aligned((sizeof(void *))))) \ - = {_detect, _depend, _early_init, _late_init, \ - _finish ? IOMMU_FINISH_IF_DETECTED : 0} -/* - * The simplest IOMMU definition. Provide the detection routine - * and it will be run after the SWIOTLB and the other IOMMUs - * that utilize this macro. If the IOMMU is detected (ie, the - * detect routine returns a positive value), the other IOMMUs - * are also checked. You can use IOMMU_INIT_POST_FINISH if you prefer - * to stop detecting the other IOMMUs after yours has been detected. - */ -#define IOMMU_INIT_POST(_detect) \ - __IOMMU_INIT(_detect, pci_swiotlb_detect_4gb, NULL, NULL, 0) - -#define IOMMU_INIT_POST_FINISH(detect) \ - __IOMMU_INIT(_detect, pci_swiotlb_detect_4gb, NULL, NULL, 1) - -/* - * A more sophisticated version of IOMMU_INIT. This variant requires: - * a). A detection routine function. - * b). The name of the detection routine we depend on to get called - * before us. - * c). The init routine which gets called if the detection routine - * returns a positive value from the pci_iommu_alloc. This means - * no presence of a memory allocator. - * d). Similar to the 'init', except that this gets called from pci_iommu_init - * where we do have a memory allocator. - * - * The standard IOMMU_INIT differs from the IOMMU_INIT_FINISH variant - * in that the former will continue detecting other IOMMUs in the call - * list after the detection routine returns a positive number, while the - * latter will stop the execution chain upon first successful detection. - * Both variants will still call the 'init' and 'late_init' functions if - * they are set. - */ -#define IOMMU_INIT_FINISH(_detect, _depend, _init, _late_init) \ - __IOMMU_INIT(_detect, _depend, _init, _late_init, 1) - -#define IOMMU_INIT(_detect, _depend, _init, _late_init) \ - __IOMMU_INIT(_detect, _depend, _init, _late_init, 0) - -void sort_iommu_table(struct iommu_table_entry *start, - struct iommu_table_entry *finish); - -void check_iommu_entries(struct iommu_table_entry *start, - struct iommu_table_entry *finish); - -#endif /* _ASM_X86_IOMMU_TABLE_H */ diff --git a/arch/x86/include/asm/swiotlb.h b/arch/x86/include/asm/swiotlb.h deleted file mode 100644 index ff6c92eff035a..0000000000000 --- a/arch/x86/include/asm/swiotlb.h +++ /dev/null @@ -1,30 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0 */ -#ifndef _ASM_X86_SWIOTLB_H -#define _ASM_X86_SWIOTLB_H - -#include - -#ifdef CONFIG_SWIOTLB -extern int swiotlb; -extern int __init pci_swiotlb_detect_override(void); -extern int __init pci_swiotlb_detect_4gb(void); -extern void __init pci_swiotlb_init(void); -extern void __init pci_swiotlb_late_init(void); -#else -#define swiotlb 0 -static inline int pci_swiotlb_detect_override(void) -{ - return 0; -} -static inline int pci_swiotlb_detect_4gb(void) -{ - return 0; -} -static inline void pci_swiotlb_init(void) -{ -} -static inline void pci_swiotlb_late_init(void) -{ -} -#endif -#endif /* _ASM_X86_SWIOTLB_H */ diff --git a/arch/x86/include/asm/xen/swiotlb-xen.h b/arch/x86/include/asm/xen/swiotlb-xen.h index 66b4ddde77430..e5a90b42e4dde 100644 --- a/arch/x86/include/asm/xen/swiotlb-xen.h +++ b/arch/x86/include/asm/xen/swiotlb-xen.h @@ -3,10 +3,8 @@ #define _ASM_X86_SWIOTLB_XEN_H #ifdef CONFIG_SWIOTLB_XEN -extern int __init pci_xen_swiotlb_detect(void); extern int pci_xen_swiotlb_init_late(void); #else -#define pci_xen_swiotlb_detect NULL static inline int pci_xen_swiotlb_init_late(void) { return -ENXIO; } #endif diff --git a/arch/x86/kernel/Makefile b/arch/x86/kernel/Makefile index 6aef9ee28a394..2851d4f0aa0d2 100644 --- a/arch/x86/kernel/Makefile +++ b/arch/x86/kernel/Makefile @@ -71,7 +71,6 @@ obj-y += bootflag.o e820.o obj-y += pci-dma.o quirks.o topology.o kdebugfs.o obj-y += alternative.o i8253.o hw_breakpoint.o obj-y += tsc.o tsc_msr.o io_delay.o rtc.o -obj-y += pci-iommu_table.o obj-y += resource.o obj-y += irqflags.o obj-y += static_call.o @@ -136,7 +135,6 @@ obj-$(CONFIG_PCSPKR_PLATFORM) += pcspeaker.o obj-$(CONFIG_X86_CHECK_BIOS_CORRUPTION) += check.o -obj-$(CONFIG_SWIOTLB) += pci-swiotlb.o obj-$(CONFIG_OF) += devicetree.o obj-$(CONFIG_UPROBES) += uprobes.o diff --git a/arch/x86/kernel/amd_gart_64.c b/arch/x86/kernel/amd_gart_64.c index ed837383de5c8..194d54eed5376 100644 --- a/arch/x86/kernel/amd_gart_64.c +++ b/arch/x86/kernel/amd_gart_64.c @@ -38,11 +38,9 @@ #include #include #include -#include #include #include #include -#include static unsigned long iommu_bus_base; /* GART remapping area (physical) */ static unsigned long iommu_size; /* size of remapping area bytes */ @@ -808,7 +806,7 @@ int __init gart_iommu_init(void) flush_gart(); dma_ops = &gart_dma_ops; x86_platform.iommu_shutdown = gart_iommu_shutdown; - swiotlb = 0; + x86_swiotlb_enable = false; return 0; } @@ -842,4 +840,3 @@ void __init gart_parse_options(char *p) } } } -IOMMU_INIT_POST(gart_iommu_hole_init); diff --git a/arch/x86/kernel/aperture_64.c b/arch/x86/kernel/aperture_64.c index af3ba08b684b5..7a5630d904b23 100644 --- a/arch/x86/kernel/aperture_64.c +++ b/arch/x86/kernel/aperture_64.c @@ -392,7 +392,7 @@ void __init early_gart_iommu_check(void) static int __initdata printed_gart_size_msg; -int __init gart_iommu_hole_init(void) +void __init gart_iommu_hole_init(void) { u32 agp_aper_base = 0, agp_aper_order = 0; u32 aper_size, aper_alloc = 0, aper_order = 0, last_aper_order = 0; @@ -401,11 +401,11 @@ int __init gart_iommu_hole_init(void) int i, node; if (!amd_gart_present()) - return -ENODEV; + return; if (gart_iommu_aperture_disabled || !fix_aperture || !early_pci_allowed()) - return -ENODEV; + return; pr_info("Checking aperture...\n"); @@ -491,10 +491,8 @@ int __init gart_iommu_hole_init(void) * and fixed up the northbridge */ exclude_from_core(last_aper_base, last_aper_order); - - return 1; } - return 0; + return; } if (!fallback_aper_force) { @@ -527,7 +525,7 @@ int __init gart_iommu_hole_init(void) panic("Not enough memory for aperture"); } } else { - return 0; + return; } /* @@ -561,6 +559,4 @@ int __init gart_iommu_hole_init(void) } set_up_gart_resume(aper_order, aper_alloc); - - return 1; } diff --git a/arch/x86/kernel/pci-dma.c b/arch/x86/kernel/pci-dma.c index de234e7a8962e..2ac0ef9c2fb76 100644 --- a/arch/x86/kernel/pci-dma.c +++ b/arch/x86/kernel/pci-dma.c @@ -7,13 +7,16 @@ #include #include #include +#include #include #include #include #include #include -#include + +#include +#include static bool disable_dac_quirk __read_mostly; @@ -34,24 +37,83 @@ int no_iommu __read_mostly; /* Set this to 1 if there is a HW IOMMU in the system */ int iommu_detected __read_mostly = 0; -extern struct iommu_table_entry __iommu_table[], __iommu_table_end[]; +#ifdef CONFIG_SWIOTLB +bool x86_swiotlb_enable; + +static void __init pci_swiotlb_detect(void) +{ + /* don't initialize swiotlb if iommu=off (no_iommu=1) */ + if (!no_iommu && max_possible_pfn > MAX_DMA32_PFN) + x86_swiotlb_enable = true; + + /* + * Set swiotlb to 1 so that bounce buffers are allocated and used for + * devices that can't support DMA to encrypted memory. + */ + if (cc_platform_has(CC_ATTR_HOST_MEM_ENCRYPT)) + x86_swiotlb_enable = true; + + if (swiotlb_force == SWIOTLB_FORCE) + x86_swiotlb_enable = true; +} +#else +static inline void __init pci_swiotlb_detect(void) +{ +} +#endif /* CONFIG_SWIOTLB */ + +#ifdef CONFIG_SWIOTLB_XEN +static bool xen_swiotlb; + +static void __init pci_xen_swiotlb_init(void) +{ + if (!xen_initial_domain() && !x86_swiotlb_enable && + swiotlb_force != SWIOTLB_FORCE) + return; + x86_swiotlb_enable = false; + xen_swiotlb = true; + xen_swiotlb_init_early(); + dma_ops = &xen_swiotlb_dma_ops; + if (IS_ENABLED(CONFIG_PCI)) + pci_request_acs(); +} + +int pci_xen_swiotlb_init_late(void) +{ + int rc; + + if (xen_swiotlb) + return 0; + + rc = xen_swiotlb_init(); + if (rc) + return rc; + + /* XXX: this switches the dma ops under live devices! */ + dma_ops = &xen_swiotlb_dma_ops; + if (IS_ENABLED(CONFIG_PCI)) + pci_request_acs(); + return 0; +} +EXPORT_SYMBOL_GPL(pci_xen_swiotlb_init_late); +#else +static inline void __init pci_xen_swiotlb_init(void) +{ +} +#endif /* CONFIG_SWIOTLB_XEN */ void __init pci_iommu_alloc(void) { - struct iommu_table_entry *p; - - sort_iommu_table(__iommu_table, __iommu_table_end); - check_iommu_entries(__iommu_table, __iommu_table_end); - - for (p = __iommu_table; p < __iommu_table_end; p++) { - if (p && p->detect && p->detect() > 0) { - p->flags |= IOMMU_DETECTED; - if (p->early_init) - p->early_init(); - if (p->flags & IOMMU_FINISH_IF_DETECTED) - break; - } + if (xen_pv_domain()) { + pci_xen_swiotlb_init(); + return; } + pci_swiotlb_detect(); + gart_iommu_hole_init(); + amd_iommu_detect(); + detect_intel_iommu(); + if (x86_swiotlb_enable) + swiotlb_init(0); } /* @@ -102,7 +164,7 @@ static __init int iommu_setup(char *p) } #ifdef CONFIG_SWIOTLB if (!strncmp(p, "soft", 4)) - swiotlb = 1; + x86_swiotlb_enable = 1; #endif if (!strncmp(p, "pt", 2)) iommu_set_default_passthrough(true); @@ -121,14 +183,17 @@ early_param("iommu", iommu_setup); static int __init pci_iommu_init(void) { - struct iommu_table_entry *p; - x86_init.iommu.iommu_init(); - for (p = __iommu_table; p < __iommu_table_end; p++) { - if (p && (p->flags & IOMMU_DETECTED) && p->late_init) - p->late_init(); +#ifdef CONFIG_SWIOTLB + /* An IOMMU turned us off. */ + if (x86_swiotlb_enable) { + pr_info("PCI-DMA: Using software bounce buffering for IO (SWIOTLB)\n"); + swiotlb_print_info(); + } else { + swiotlb_exit(); } +#endif return 0; } diff --git a/arch/x86/kernel/pci-iommu_table.c b/arch/x86/kernel/pci-iommu_table.c deleted file mode 100644 index 42e92ec62973b..0000000000000 --- a/arch/x86/kernel/pci-iommu_table.c +++ /dev/null @@ -1,77 +0,0 @@ -// SPDX-License-Identifier: GPL-2.0 -#include -#include -#include -#include - -static struct iommu_table_entry * __init -find_dependents_of(struct iommu_table_entry *start, - struct iommu_table_entry *finish, - struct iommu_table_entry *q) -{ - struct iommu_table_entry *p; - - if (!q) - return NULL; - - for (p = start; p < finish; p++) - if (p->detect == q->depend) - return p; - - return NULL; -} - - -void __init sort_iommu_table(struct iommu_table_entry *start, - struct iommu_table_entry *finish) { - - struct iommu_table_entry *p, *q, tmp; - - for (p = start; p < finish; p++) { -again: - q = find_dependents_of(start, finish, p); - /* We are bit sneaky here. We use the memory address to figure - * out if the node we depend on is past our point, if so, swap. - */ - if (q > p) { - tmp = *p; - memmove(p, q, sizeof(*p)); - *q = tmp; - goto again; - } - } - -} - -#ifdef DEBUG -void __init check_iommu_entries(struct iommu_table_entry *start, - struct iommu_table_entry *finish) -{ - struct iommu_table_entry *p, *q, *x; - - /* Simple cyclic dependency checker. */ - for (p = start; p < finish; p++) { - q = find_dependents_of(start, finish, p); - x = find_dependents_of(start, finish, q); - if (p == x) { - printk(KERN_ERR "CYCLIC DEPENDENCY FOUND! %pS depends on %pS and vice-versa. BREAKING IT.\n", - p->detect, q->detect); - /* Heavy handed way..*/ - x->depend = NULL; - } - } - - for (p = start; p < finish; p++) { - q = find_dependents_of(p, finish, p); - if (q && q > p) { - printk(KERN_ERR "EXECUTION ORDER INVALID! %pS should be called before %pS!\n", - p->detect, q->detect); - } - } -} -#else -void __init check_iommu_entries(struct iommu_table_entry *start, - struct iommu_table_entry *finish) -{ -} -#endif diff --git a/arch/x86/kernel/pci-swiotlb.c b/arch/x86/kernel/pci-swiotlb.c deleted file mode 100644 index 814ab46a0dada..0000000000000 --- a/arch/x86/kernel/pci-swiotlb.c +++ /dev/null @@ -1,77 +0,0 @@ -// SPDX-License-Identifier: GPL-2.0 - -#include -#include -#include -#include -#include -#include -#include - -#include -#include -#include -#include -#include - -int swiotlb __read_mostly; - -/* - * pci_swiotlb_detect_override - set swiotlb to 1 if necessary - * - * This returns non-zero if we are forced to use swiotlb (by the boot - * option). - */ -int __init pci_swiotlb_detect_override(void) -{ - if (swiotlb_force == SWIOTLB_FORCE) - swiotlb = 1; - - return swiotlb; -} -IOMMU_INIT_FINISH(pci_swiotlb_detect_override, - pci_xen_swiotlb_detect, - pci_swiotlb_init, - pci_swiotlb_late_init); - -/* - * If 4GB or more detected (and iommu=off not set) or if SME is active - * then set swiotlb to 1 and return 1. - */ -int __init pci_swiotlb_detect_4gb(void) -{ - /* don't initialize swiotlb if iommu=off (no_iommu=1) */ - if (!no_iommu && max_possible_pfn > MAX_DMA32_PFN) - swiotlb = 1; - - /* - * Set swiotlb to 1 so that bounce buffers are allocated and used for - * devices that can't support DMA to encrypted memory. - */ - if (cc_platform_has(CC_ATTR_HOST_MEM_ENCRYPT)) - swiotlb = 1; - - return swiotlb; -} -IOMMU_INIT(pci_swiotlb_detect_4gb, - pci_swiotlb_detect_override, - pci_swiotlb_init, - pci_swiotlb_late_init); - -void __init pci_swiotlb_init(void) -{ - if (swiotlb) - swiotlb_init(0); -} - -void __init pci_swiotlb_late_init(void) -{ - /* An IOMMU turned us off. */ - if (!swiotlb) - swiotlb_exit(); - else { - printk(KERN_INFO "PCI-DMA: " - "Using software bounce buffering for IO (SWIOTLB)\n"); - swiotlb_print_info(); - } -} diff --git a/arch/x86/kernel/tboot.c b/arch/x86/kernel/tboot.c index f9af561c3cd4f..0c1154a1c4032 100644 --- a/arch/x86/kernel/tboot.c +++ b/arch/x86/kernel/tboot.c @@ -24,7 +24,6 @@ #include #include #include -#include #include #include #include diff --git a/arch/x86/kernel/vmlinux.lds.S b/arch/x86/kernel/vmlinux.lds.S index 27f830345b6f0..bbe910c15b293 100644 --- a/arch/x86/kernel/vmlinux.lds.S +++ b/arch/x86/kernel/vmlinux.lds.S @@ -306,18 +306,6 @@ SECTIONS *(.altinstr_replacement) } - /* - * struct iommu_table_entry entries are injected in this section. - * It is an array of IOMMUs which during run time gets sorted depending - * on its dependency order. After rootfs_initcall is complete - * this section can be safely removed. - */ - .iommu_table : AT(ADDR(.iommu_table) - LOAD_OFFSET) { - __iommu_table = .; - *(.iommu_table) - __iommu_table_end = .; - } - . = ALIGN(8); .apicdrivers : AT(ADDR(.apicdrivers) - LOAD_OFFSET) { __apicdrivers = .; diff --git a/arch/x86/xen/Makefile b/arch/x86/xen/Makefile index 4953260e281c3..3c5b52fbe4a7f 100644 --- a/arch/x86/xen/Makefile +++ b/arch/x86/xen/Makefile @@ -47,6 +47,4 @@ obj-$(CONFIG_XEN_DEBUG_FS) += debugfs.o obj-$(CONFIG_XEN_PV_DOM0) += vga.o -obj-$(CONFIG_SWIOTLB_XEN) += pci-swiotlb-xen.o - obj-$(CONFIG_XEN_EFI) += efi.o diff --git a/arch/x86/xen/pci-swiotlb-xen.c b/arch/x86/xen/pci-swiotlb-xen.c deleted file mode 100644 index 46df59aeaa06a..0000000000000 --- a/arch/x86/xen/pci-swiotlb-xen.c +++ /dev/null @@ -1,96 +0,0 @@ -// SPDX-License-Identifier: GPL-2.0 - -/* Glue code to lib/swiotlb-xen.c */ - -#include -#include -#include - -#include -#include -#include - - -#include -#ifdef CONFIG_X86_64 -#include -#include -#endif -#include - -static int xen_swiotlb __read_mostly; - -/* - * pci_xen_swiotlb_detect - set xen_swiotlb to 1 if necessary - * - * This returns non-zero if we are forced to use xen_swiotlb (by the boot - * option). - */ -int __init pci_xen_swiotlb_detect(void) -{ - - if (!xen_pv_domain()) - return 0; - - /* If running as PV guest, either iommu=soft, or swiotlb=force will - * activate this IOMMU. If running as PV privileged, activate it - * irregardless. - */ - if (xen_initial_domain() || swiotlb || swiotlb_force == SWIOTLB_FORCE) - xen_swiotlb = 1; - - /* If we are running under Xen, we MUST disable the native SWIOTLB. - * Don't worry about swiotlb_force flag activating the native, as - * the 'swiotlb' flag is the only one turning it on. */ - swiotlb = 0; - -#ifdef CONFIG_X86_64 - /* pci_swiotlb_detect_4gb turns on native SWIOTLB if no_iommu == 0 - * (so no iommu=X command line over-writes). - * Considering that PV guests do not want the *native SWIOTLB* but - * only Xen SWIOTLB it is not useful to us so set no_iommu=1 here. - */ - if (max_pfn > MAX_DMA32_PFN) - no_iommu = 1; -#endif - return xen_swiotlb; -} - -static void __init pci_xen_swiotlb_init(void) -{ - if (xen_swiotlb) { - xen_swiotlb_init_early(); - dma_ops = &xen_swiotlb_dma_ops; - -#ifdef CONFIG_PCI - /* Make sure ACS will be enabled */ - pci_request_acs(); -#endif - } -} - -int pci_xen_swiotlb_init_late(void) -{ - int rc; - - if (xen_swiotlb) - return 0; - - rc = xen_swiotlb_init(); - if (rc) - return rc; - - dma_ops = &xen_swiotlb_dma_ops; -#ifdef CONFIG_PCI - /* Make sure ACS will be enabled */ - pci_request_acs(); -#endif - - return 0; -} -EXPORT_SYMBOL_GPL(pci_xen_swiotlb_init_late); - -IOMMU_INIT_FINISH(pci_xen_swiotlb_detect, - NULL, - pci_xen_swiotlb_init, - NULL); diff --git a/drivers/iommu/amd/init.c b/drivers/iommu/amd/init.c index b10fb52ea4428..721300cf90207 100644 --- a/drivers/iommu/amd/init.c +++ b/drivers/iommu/amd/init.c @@ -27,7 +27,6 @@ #include #include #include -#include #include #include #include @@ -3237,11 +3236,6 @@ __setup("ivrs_ioapic", parse_ivrs_ioapic); __setup("ivrs_hpet", parse_ivrs_hpet); __setup("ivrs_acpihid", parse_ivrs_acpihid); -IOMMU_INIT_FINISH(amd_iommu_detect, - gart_iommu_hole_init, - NULL, - NULL); - bool amd_iommu_v2_supported(void) { return amd_iommu_v2_present; diff --git a/drivers/iommu/amd/iommu.c b/drivers/iommu/amd/iommu.c index 461f1844ed1fb..541a7b8315a12 100644 --- a/drivers/iommu/amd/iommu.c +++ b/drivers/iommu/amd/iommu.c @@ -1834,7 +1834,10 @@ void amd_iommu_domain_update(struct protection_domain *domain) static void __init amd_iommu_init_dma_ops(void) { - swiotlb = (iommu_default_passthrough() || sme_me_mask) ? 1 : 0; + if (iommu_default_passthrough() || sme_me_mask) + x86_swiotlb_enable = true; + else + x86_swiotlb_enable = false; } int __init amd_iommu_init_api(void) diff --git a/drivers/iommu/intel/dmar.c b/drivers/iommu/intel/dmar.c index 915bff76fe965..29bee4b210c5b 100644 --- a/drivers/iommu/intel/dmar.c +++ b/drivers/iommu/intel/dmar.c @@ -30,7 +30,6 @@ #include #include #include -#include #include #include "../irq_remapping.h" @@ -913,7 +912,7 @@ dmar_validate_one_drhd(struct acpi_dmar_header *entry, void *arg) return 0; } -int __init detect_intel_iommu(void) +void __init detect_intel_iommu(void) { int ret; struct dmar_res_callback validate_drhd_cb = { @@ -946,8 +945,6 @@ int __init detect_intel_iommu(void) dmar_tbl = NULL; } up_write(&dmar_global_lock); - - return ret ? ret : 1; } static void unmap_iommu(struct intel_iommu *iommu) @@ -2165,7 +2162,6 @@ static int __init dmar_free_unused_resources(void) } late_initcall(dmar_free_unused_resources); -IOMMU_INIT_POST(detect_intel_iommu); /* * DMAR Hotplug Support diff --git a/include/linux/dmar.h b/include/linux/dmar.h index 45e903d847335..cbd714a198a0a 100644 --- a/include/linux/dmar.h +++ b/include/linux/dmar.h @@ -121,7 +121,7 @@ extern int dmar_remove_dev_scope(struct dmar_pci_notify_info *info, u16 segment, struct dmar_dev_scope *devices, int count); /* Intel IOMMU detection */ -extern int detect_intel_iommu(void); +void detect_intel_iommu(void); extern int enable_drhd_fault_handling(void); extern int dmar_device_add(acpi_handle handle); extern int dmar_device_remove(acpi_handle handle); @@ -197,6 +197,10 @@ static inline bool dmar_platform_optin(void) return false; } +static inline void detect_intel_iommu(void) +{ +} + #endif /* CONFIG_DMAR_TABLE */ struct irte { -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Tue Mar 01 10:54:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 10:54:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281138.479400 (Exim 4.92) (envelope-from ) id 1nP08n-0006xw-D5; Tue, 01 Mar 2022 10:54:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281138.479400; Tue, 01 Mar 2022 10:54:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP08n-0006xn-7J; Tue, 01 Mar 2022 10:54:01 +0000 Received: by outflank-mailman (input) for mailman id 281138; Tue, 01 Mar 2022 10:54:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP08m-00031b-4L for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 10:54:00 +0000 Received: from bombadil.infradead.org (bombadil.infradead.org [2607:7c80:54:e::133]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e50187be-994d-11ec-8539-5f4723681683; Tue, 01 Mar 2022 11:53:58 +0100 (CET) Received: from [2.53.44.23] (helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nP08W-00GDBz-Fe; Tue, 01 Mar 2022 10:53:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e50187be-994d-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=rn1lGNCzgBmJDwsQNrjsOcGImLW+b96q4xUCqvjdsk0=; b=TN8SI+uAq5DRfiCtROBmEeGw49 N1XQdXveQdISlA9PJvr7k3fqXJ9w4L4fp4g84Sx/b6Q3/TPXM34VfI00X3WX9GkM9+xkrbM+bMDai q9KxADFlSGYuizADeUGr7l7Wyhi+6wixAUA9bogKi+S84VubiWeuiOuSLOIOO/u8edfzcJXIwkX9B e3uJEQDCxXwbkmyOMf0943q8r0jk1gsz1PxYQdXM0pTs2h2ZzikrlK1tJTrcsOuna2VNTBldJOC0d KROkdtCbvHpsPMH2KXKaD98Llv7rUxGn22RsjoJ2MNNq95XdrxGoyXdrHr9Mrkal37Bq7EXzIylMK Fz5RfWkA==; From: Christoph Hellwig To: iommu@lists.linux-foundation.org Cc: x86@kernel.org, Anshuman Khandual , Tom Lendacky , Konrad Rzeszutek Wilk , Stefano Stabellini , Boris Ostrovsky , Juergen Gross , Joerg Roedel , David Woodhouse , Lu Baolu , Robin Murphy , linux-arm-kernel@lists.infradead.org, xen-devel@lists.xenproject.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-hyperv@vger.kernel.org, tboot-devel@lists.sourceforge.net, linux-pci@vger.kernel.org Subject: [PATCH 08/12] x86: centralize setting SWIOTLB_FORCE when guest memory encryption is enabled Date: Tue, 1 Mar 2022 12:53:07 +0200 Message-Id: <20220301105311.885699-9-hch@lst.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220301105311.885699-1-hch@lst.de> References: <20220301105311.885699-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Move enabling SWIOTLB_FORCE for guest memory encryption into common code. Signed-off-by: Christoph Hellwig --- arch/x86/kernel/cpu/mshyperv.c | 8 -------- arch/x86/kernel/pci-dma.c | 7 +++++++ arch/x86/mm/mem_encrypt_amd.c | 3 --- 3 files changed, 7 insertions(+), 11 deletions(-) diff --git a/arch/x86/kernel/cpu/mshyperv.c b/arch/x86/kernel/cpu/mshyperv.c index 5a99f993e6392..568274917f1cd 100644 --- a/arch/x86/kernel/cpu/mshyperv.c +++ b/arch/x86/kernel/cpu/mshyperv.c @@ -336,14 +336,6 @@ static void __init ms_hyperv_init_platform(void) swiotlb_unencrypted_base = ms_hyperv.shared_gpa_boundary; #endif } - -#ifdef CONFIG_SWIOTLB - /* - * Enable swiotlb force mode in Isolation VM to - * use swiotlb bounce buffer for dma transaction. - */ - swiotlb_force = SWIOTLB_FORCE; -#endif } if (hv_max_functions_eax >= HYPERV_CPUID_NESTED_FEATURES) { diff --git a/arch/x86/kernel/pci-dma.c b/arch/x86/kernel/pci-dma.c index 2ac0ef9c2fb76..7ab7002758396 100644 --- a/arch/x86/kernel/pci-dma.c +++ b/arch/x86/kernel/pci-dma.c @@ -53,6 +53,13 @@ static void __init pci_swiotlb_detect(void) if (cc_platform_has(CC_ATTR_HOST_MEM_ENCRYPT)) x86_swiotlb_enable = true; + /* + * Guest with guest memory encryption must always do I/O through a + * bounce buffer as the hypervisor can't access arbitrary VM memory. + */ + if (cc_platform_has(CC_ATTR_GUEST_MEM_ENCRYPT)) + swiotlb_force = SWIOTLB_FORCE; + if (swiotlb_force == SWIOTLB_FORCE) x86_swiotlb_enable = true; } diff --git a/arch/x86/mm/mem_encrypt_amd.c b/arch/x86/mm/mem_encrypt_amd.c index 2b2d018ea3450..a72942d569cf9 100644 --- a/arch/x86/mm/mem_encrypt_amd.c +++ b/arch/x86/mm/mem_encrypt_amd.c @@ -191,9 +191,6 @@ void __init sme_early_init(void) /* Update the protection map with memory encryption mask */ for (i = 0; i < ARRAY_SIZE(protection_map); i++) protection_map[i] = pgprot_encrypted(protection_map[i]); - - if (cc_platform_has(CC_ATTR_GUEST_MEM_ENCRYPT)) - swiotlb_force = SWIOTLB_FORCE; } void __init sev_setup_arch(void) -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Tue Mar 01 10:56:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 10:56:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281170.479411 (Exim 4.92) (envelope-from ) id 1nP0Ay-0000Zq-RY; Tue, 01 Mar 2022 10:56:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281170.479411; Tue, 01 Mar 2022 10:56:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP0Ay-0000Zj-OM; Tue, 01 Mar 2022 10:56:16 +0000 Received: by outflank-mailman (input) for mailman id 281170; Tue, 01 Mar 2022 10:56:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP090-00031b-Pw for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 10:54:14 +0000 Received: from bombadil.infradead.org (bombadil.infradead.org [2607:7c80:54:e::133]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id edbcae2c-994d-11ec-8539-5f4723681683; Tue, 01 Mar 2022 11:54:13 +0100 (CET) Received: from [2.53.44.23] (helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nP08m-00GDNp-DY; Tue, 01 Mar 2022 10:54:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: edbcae2c-994d-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=zCMW1Q+QCPXYuvBuEGOZUQKFwE9OwdLFtYhltvQ29K4=; b=IPppU23T/aMON7FLyMDFYzly4y SrIr5mKWZClafJa3/LlRCgHqXwAUqRrn8YOMeVLdYaruBDCwVZ+oeA1TCJP01OphckLh7aW/Xh4aE O+7A6N+iHQN61vqDHdCF4t6yTIgG5jpY3jGCH1A7IMaTqU+1RufnGYFZsg6ym2eXz6IbNS0Y3pwX8 UlH5YaicUs22JThgD0p9wjbHWFTvpyx++4eAJRbNQD6+RIciCW6RIaOv3nY2Arz6MwdIPsNH7bmDb kXbZR8ThXJdmI6NGYJUBwyHX1Lh35aW0/peguiWu3/sXXcELyqiay0utedyq1KmsYI+SOZJb3UYfi 1suKWqMQ==; From: Christoph Hellwig To: iommu@lists.linux-foundation.org Cc: x86@kernel.org, Anshuman Khandual , Tom Lendacky , Konrad Rzeszutek Wilk , Stefano Stabellini , Boris Ostrovsky , Juergen Gross , Joerg Roedel , David Woodhouse , Lu Baolu , Robin Murphy , linux-arm-kernel@lists.infradead.org, xen-devel@lists.xenproject.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-hyperv@vger.kernel.org, tboot-devel@lists.sourceforge.net, linux-pci@vger.kernel.org Subject: [PATCH 12/12] x86: remove cruft from Date: Tue, 1 Mar 2022 12:53:11 +0200 Message-Id: <20220301105311.885699-13-hch@lst.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220301105311.885699-1-hch@lst.de> References: <20220301105311.885699-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html gets pulled in by all drivers using the DMA API. Remove x86 internal variables and unnecessary includes from it. Signed-off-by: Christoph Hellwig --- arch/x86/include/asm/dma-mapping.h | 11 ----------- arch/x86/include/asm/iommu.h | 2 ++ 2 files changed, 2 insertions(+), 11 deletions(-) diff --git a/arch/x86/include/asm/dma-mapping.h b/arch/x86/include/asm/dma-mapping.h index 256fd8115223d..1c66708e30623 100644 --- a/arch/x86/include/asm/dma-mapping.h +++ b/arch/x86/include/asm/dma-mapping.h @@ -2,17 +2,6 @@ #ifndef _ASM_X86_DMA_MAPPING_H #define _ASM_X86_DMA_MAPPING_H -/* - * IOMMU interface. See Documentation/core-api/dma-api-howto.rst and - * Documentation/core-api/dma-api.rst for documentation. - */ - -#include -#include - -extern int iommu_merge; -extern int panic_on_overflow; - extern const struct dma_map_ops *dma_ops; static inline const struct dma_map_ops *get_arch_dma_ops(struct bus_type *bus) diff --git a/arch/x86/include/asm/iommu.h b/arch/x86/include/asm/iommu.h index dba89ed40d38d..0bef44d30a278 100644 --- a/arch/x86/include/asm/iommu.h +++ b/arch/x86/include/asm/iommu.h @@ -8,6 +8,8 @@ extern int force_iommu, no_iommu; extern int iommu_detected; +extern int iommu_merge; +extern int panic_on_overflow; #ifdef CONFIG_SWIOTLB extern bool x86_swiotlb_enable; -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Tue Mar 01 10:56:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 10:56:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281171.479422 (Exim 4.92) (envelope-from ) id 1nP0B1-0000qh-3M; Tue, 01 Mar 2022 10:56:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281171.479422; Tue, 01 Mar 2022 10:56:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP0B0-0000qY-WF; Tue, 01 Mar 2022 10:56:19 +0000 Received: by outflank-mailman (input) for mailman id 281171; Tue, 01 Mar 2022 10:56:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP090-00031b-BJ for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 10:54:14 +0000 Received: from bombadil.infradead.org (bombadil.infradead.org [2607:7c80:54:e::133]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ed0b796b-994d-11ec-8539-5f4723681683; Tue, 01 Mar 2022 11:54:11 +0100 (CET) Received: from [2.53.44.23] (helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nP08i-00GDLI-3y; Tue, 01 Mar 2022 10:53:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ed0b796b-994d-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=7CayTS9LrIpu0RxbQHu+iiiYCGwZaOhMRGYbZFEPab4=; b=PCnrvlAzWQMYA+/n1zcYMpR8CL zQPaxiWtxSrWukBZ1ZGpFn9V+ry6qDE2ajcJH645ZcVqLpf+cNzGvEZ05yIAA98K8rx8pdmXxHc/U KMmFWCrPbug0iZT6ybiU2/ZocXkyEBnqENiIWYLZL+1yZThUSEUFFjaSk4uFGLXe+jKadPn2pE39R JlZnYrjov5D4554i61roEmxjZENvDm+rto7S9AnU9d2VqeRcUZ/DPJnUoNDoKMVgFxCpByWFeAF0e msSCj2UdLMqlVzK1513TBBwG3INIa+yJERkjm9WY6g1Op6AvOLf9Y89dM2p/HaJrWO4YahhIR86CN gbro6lJg==; From: Christoph Hellwig To: iommu@lists.linux-foundation.org Cc: x86@kernel.org, Anshuman Khandual , Tom Lendacky , Konrad Rzeszutek Wilk , Stefano Stabellini , Boris Ostrovsky , Juergen Gross , Joerg Roedel , David Woodhouse , Lu Baolu , Robin Murphy , linux-arm-kernel@lists.infradead.org, xen-devel@lists.xenproject.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-hyperv@vger.kernel.org, tboot-devel@lists.sourceforge.net, linux-pci@vger.kernel.org Subject: [PATCH 11/12] swiotlb: merge swiotlb-xen initialization into swiotlb Date: Tue, 1 Mar 2022 12:53:10 +0200 Message-Id: <20220301105311.885699-12-hch@lst.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220301105311.885699-1-hch@lst.de> References: <20220301105311.885699-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Allow to pass a remap argument to the swiotlb initialization functions to handle the Xen/x86 remap case. ARM/ARM64 never did any remapping from xen_swiotlb_fixup, so we don't even need that quirk. Signed-off-by: Christoph Hellwig --- arch/arm/xen/mm.c | 23 +++--- arch/x86/include/asm/xen/page.h | 5 -- arch/x86/kernel/pci-dma.c | 19 +++-- arch/x86/pci/sta2x11-fixup.c | 2 +- drivers/xen/swiotlb-xen.c | 128 +------------------------------- include/linux/swiotlb.h | 7 +- include/xen/arm/page.h | 1 - include/xen/swiotlb-xen.h | 8 +- kernel/dma/swiotlb.c | 120 +++++++++++++++--------------- 9 files changed, 96 insertions(+), 217 deletions(-) diff --git a/arch/arm/xen/mm.c b/arch/arm/xen/mm.c index a7e54a087b802..58b40f87617d3 100644 --- a/arch/arm/xen/mm.c +++ b/arch/arm/xen/mm.c @@ -23,22 +23,20 @@ #include #include -unsigned long xen_get_swiotlb_free_pages(unsigned int order) +static gfp_t xen_swiotlb_gfp(void) { phys_addr_t base; - gfp_t flags = __GFP_NOWARN|__GFP_KSWAPD_RECLAIM; u64 i; for_each_mem_range(i, &base, NULL) { if (base < (phys_addr_t)0xffffffff) { if (IS_ENABLED(CONFIG_ZONE_DMA32)) - flags |= __GFP_DMA32; - else - flags |= __GFP_DMA; - break; + return __GFP_DMA32; + return __GFP_DMA; } } - return __get_free_pages(flags, order); + + return GFP_KERNEL; } static bool hypercall_cflush = false; @@ -143,10 +141,15 @@ static int __init xen_mm_init(void) if (!xen_swiotlb_detect()) return 0; - rc = xen_swiotlb_init(); /* we can work with the default swiotlb */ - if (rc < 0 && rc != -EEXIST) - return rc; + if (!io_tlb_default_mem.nslabs) { + if (!xen_initial_domain()) + return -EINVAL; + rc = swiotlb_init_late(swiotlb_size_or_default(), + xen_swiotlb_gfp(), NULL); + if (rc < 0) + return rc; + } cflush.op = 0; cflush.a.dev_bus_addr = 0; diff --git a/arch/x86/include/asm/xen/page.h b/arch/x86/include/asm/xen/page.h index e989bc2269f54..1fc67df500145 100644 --- a/arch/x86/include/asm/xen/page.h +++ b/arch/x86/include/asm/xen/page.h @@ -357,9 +357,4 @@ static inline bool xen_arch_need_swiotlb(struct device *dev, return false; } -static inline unsigned long xen_get_swiotlb_free_pages(unsigned int order) -{ - return __get_free_pages(__GFP_NOWARN, order); -} - #endif /* _ASM_X86_XEN_PAGE_H */ diff --git a/arch/x86/kernel/pci-dma.c b/arch/x86/kernel/pci-dma.c index e0def4b1c3181..2f2c468acb955 100644 --- a/arch/x86/kernel/pci-dma.c +++ b/arch/x86/kernel/pci-dma.c @@ -71,15 +71,12 @@ static inline void __init pci_swiotlb_detect(void) #endif /* CONFIG_SWIOTLB */ #ifdef CONFIG_SWIOTLB_XEN -static bool xen_swiotlb; - static void __init pci_xen_swiotlb_init(void) { if (!xen_initial_domain() && !x86_swiotlb_enable) return; x86_swiotlb_enable = false; - xen_swiotlb = true; - xen_swiotlb_init_early(); + swiotlb_init_remap(true, x86_swiotlb_flags, xen_swiotlb_fixup); dma_ops = &xen_swiotlb_dma_ops; if (IS_ENABLED(CONFIG_PCI)) pci_request_acs(); @@ -87,14 +84,16 @@ static void __init pci_xen_swiotlb_init(void) int pci_xen_swiotlb_init_late(void) { - int rc; - - if (xen_swiotlb) + if (dma_ops == &xen_swiotlb_dma_ops) return 0; - rc = xen_swiotlb_init(); - if (rc) - return rc; + /* we can work with the default swiotlb */ + if (!io_tlb_default_mem.nslabs) { + int rc = swiotlb_init_late(swiotlb_size_or_default(), + GFP_KERNEL, xen_swiotlb_fixup); + if (rc < 0) + return rc; + } /* XXX: this switches the dma ops under live devices! */ dma_ops = &xen_swiotlb_dma_ops; diff --git a/arch/x86/pci/sta2x11-fixup.c b/arch/x86/pci/sta2x11-fixup.c index c7e6faf59a861..7368afc039987 100644 --- a/arch/x86/pci/sta2x11-fixup.c +++ b/arch/x86/pci/sta2x11-fixup.c @@ -57,7 +57,7 @@ static void sta2x11_new_instance(struct pci_dev *pdev) int size = STA2X11_SWIOTLB_SIZE; /* First instance: register your own swiotlb area */ dev_info(&pdev->dev, "Using SWIOTLB (size %i)\n", size); - if (swiotlb_init_late(size, GFP_DMA)) + if (swiotlb_init_late(size, GFP_DMA, NULL)) dev_emerg(&pdev->dev, "init swiotlb failed\n"); } list_add(&instance->list, &sta2x11_instance_list); diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c index c2da3eb4826e8..df8085b50df10 100644 --- a/drivers/xen/swiotlb-xen.c +++ b/drivers/xen/swiotlb-xen.c @@ -104,7 +104,7 @@ static int is_xen_swiotlb_buffer(struct device *dev, dma_addr_t dma_addr) return 0; } -static int xen_swiotlb_fixup(void *buf, unsigned long nslabs) +int xen_swiotlb_fixup(void *buf, unsigned long nslabs) { int rc; unsigned int order = get_order(IO_TLB_SEGSIZE << IO_TLB_SHIFT); @@ -130,132 +130,6 @@ static int xen_swiotlb_fixup(void *buf, unsigned long nslabs) return 0; } -enum xen_swiotlb_err { - XEN_SWIOTLB_UNKNOWN = 0, - XEN_SWIOTLB_ENOMEM, - XEN_SWIOTLB_EFIXUP -}; - -static const char *xen_swiotlb_error(enum xen_swiotlb_err err) -{ - switch (err) { - case XEN_SWIOTLB_ENOMEM: - return "Cannot allocate Xen-SWIOTLB buffer\n"; - case XEN_SWIOTLB_EFIXUP: - return "Failed to get contiguous memory for DMA from Xen!\n"\ - "You either: don't have the permissions, do not have"\ - " enough free memory under 4GB, or the hypervisor memory"\ - " is too fragmented!"; - default: - break; - } - return ""; -} - -int xen_swiotlb_init(void) -{ - enum xen_swiotlb_err m_ret = XEN_SWIOTLB_UNKNOWN; - unsigned long bytes = swiotlb_size_or_default(); - unsigned long nslabs = bytes >> IO_TLB_SHIFT; - unsigned int order, repeat = 3; - int rc = -ENOMEM; - char *start; - - if (io_tlb_default_mem.nslabs) { - pr_warn("swiotlb buffer already initialized\n"); - return -EEXIST; - } - -retry: - m_ret = XEN_SWIOTLB_ENOMEM; - order = get_order(bytes); - - /* - * Get IO TLB memory from any location. - */ -#define SLABS_PER_PAGE (1 << (PAGE_SHIFT - IO_TLB_SHIFT)) -#define IO_TLB_MIN_SLABS ((1<<20) >> IO_TLB_SHIFT) - while ((SLABS_PER_PAGE << order) > IO_TLB_MIN_SLABS) { - start = (void *)xen_get_swiotlb_free_pages(order); - if (start) - break; - order--; - } - if (!start) - goto exit; - if (order != get_order(bytes)) { - pr_warn("Warning: only able to allocate %ld MB for software IO TLB\n", - (PAGE_SIZE << order) >> 20); - nslabs = SLABS_PER_PAGE << order; - bytes = nslabs << IO_TLB_SHIFT; - } - - /* - * And replace that memory with pages under 4GB. - */ - rc = xen_swiotlb_fixup(start, nslabs); - if (rc) { - free_pages((unsigned long)start, order); - m_ret = XEN_SWIOTLB_EFIXUP; - goto error; - } - rc = swiotlb_late_init_with_tbl(start, nslabs); - if (rc) - return rc; - return 0; -error: - if (nslabs > 1024 && repeat--) { - /* Min is 2MB */ - nslabs = max(1024UL, ALIGN(nslabs >> 1, IO_TLB_SEGSIZE)); - bytes = nslabs << IO_TLB_SHIFT; - pr_info("Lowering to %luMB\n", bytes >> 20); - goto retry; - } -exit: - pr_err("%s (rc:%d)\n", xen_swiotlb_error(m_ret), rc); - return rc; -} - -#ifdef CONFIG_X86 -void __init xen_swiotlb_init_early(void) -{ - unsigned long bytes = swiotlb_size_or_default(); - unsigned long nslabs = bytes >> IO_TLB_SHIFT; - unsigned int repeat = 3; - char *start; - int rc; - -retry: - /* - * Get IO TLB memory from any location. - */ - start = memblock_alloc(PAGE_ALIGN(bytes), - IO_TLB_SEGSIZE << IO_TLB_SHIFT); - if (!start) - panic("%s: Failed to allocate %lu bytes\n", - __func__, PAGE_ALIGN(bytes)); - - /* - * And replace that memory with pages under 4GB. - */ - rc = xen_swiotlb_fixup(start, nslabs); - if (rc) { - memblock_free(start, PAGE_ALIGN(bytes)); - if (nslabs > 1024 && repeat--) { - /* Min is 2MB */ - nslabs = max(1024UL, ALIGN(nslabs >> 1, IO_TLB_SEGSIZE)); - bytes = nslabs << IO_TLB_SHIFT; - pr_info("Lowering to %luMB\n", bytes >> 20); - goto retry; - } - panic("%s (rc:%d)", xen_swiotlb_error(XEN_SWIOTLB_EFIXUP), rc); - } - - if (swiotlb_init_with_tbl(start, nslabs, SWIOTLB_VERBOSE)) - panic("Cannot allocate SWIOTLB buffer"); -} -#endif /* CONFIG_X86 */ - static void * xen_swiotlb_alloc_coherent(struct device *hwdev, size_t size, dma_addr_t *dma_handle, gfp_t flags, diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h index ee655f2e4d28b..919cf82ed978e 100644 --- a/include/linux/swiotlb.h +++ b/include/linux/swiotlb.h @@ -34,10 +34,11 @@ struct scatterlist; /* default to 64MB */ #define IO_TLB_DEFAULT_SIZE (64UL<<20) -int swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, unsigned int flags); unsigned long swiotlb_size_or_default(void); -extern int swiotlb_late_init_with_tbl(char *tlb, unsigned long nslabs); -int swiotlb_init_late(size_t size, gfp_t gfp_mask); +int swiotlb_init_late(size_t size, gfp_t gfp_mask, + int (*remap)(void *tlb, unsigned long nslabs)); +void __init swiotlb_init_remap(bool addressing_limit, unsigned int flags, + int (*remap)(void *tlb, unsigned long nslabs)); extern void __init swiotlb_update_mem_attributes(void); phys_addr_t swiotlb_tbl_map_single(struct device *hwdev, phys_addr_t phys, diff --git a/include/xen/arm/page.h b/include/xen/arm/page.h index ac1b654705631..7e199c6656b90 100644 --- a/include/xen/arm/page.h +++ b/include/xen/arm/page.h @@ -115,6 +115,5 @@ static inline bool set_phys_to_machine(unsigned long pfn, unsigned long mfn) bool xen_arch_need_swiotlb(struct device *dev, phys_addr_t phys, dma_addr_t dev_addr); -unsigned long xen_get_swiotlb_free_pages(unsigned int order); #endif /* _ASM_ARM_XEN_PAGE_H */ diff --git a/include/xen/swiotlb-xen.h b/include/xen/swiotlb-xen.h index b3e647f86e3e2..590ceb923f0c8 100644 --- a/include/xen/swiotlb-xen.h +++ b/include/xen/swiotlb-xen.h @@ -10,8 +10,12 @@ void xen_dma_sync_for_cpu(struct device *dev, dma_addr_t handle, void xen_dma_sync_for_device(struct device *dev, dma_addr_t handle, size_t size, enum dma_data_direction dir); -int xen_swiotlb_init(void); -void __init xen_swiotlb_init_early(void); +#ifdef CONFIG_SWIOTLB_XEN +int xen_swiotlb_fixup(void *buf, unsigned long nslabs); +#else +#define xen_swiotlb_fixup NULL +#endif + extern const struct dma_map_ops xen_swiotlb_dma_ops; #endif /* __LINUX_SWIOTLB_XEN_H */ diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c index 77cf73dc20a78..128363dc9b5bb 100644 --- a/kernel/dma/swiotlb.c +++ b/kernel/dma/swiotlb.c @@ -234,40 +234,17 @@ static void swiotlb_init_io_tlb_mem(struct io_tlb_mem *mem, phys_addr_t start, return; } -int __init swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, - unsigned int flags) -{ - struct io_tlb_mem *mem = &io_tlb_default_mem; - size_t alloc_size; - - if (swiotlb_force_disable) - return 0; - - /* protect against double initialization */ - if (WARN_ON_ONCE(mem->nslabs)) - return -ENOMEM; - - alloc_size = PAGE_ALIGN(array_size(sizeof(*mem->slots), nslabs)); - mem->slots = memblock_alloc(alloc_size, PAGE_SIZE); - if (!mem->slots) - panic("%s: Failed to allocate %zu bytes align=0x%lx\n", - __func__, alloc_size, PAGE_SIZE); - - swiotlb_init_io_tlb_mem(mem, __pa(tlb), nslabs, false); - mem->force_bounce = flags & SWIOTLB_FORCE; - - if (flags & SWIOTLB_VERBOSE) - swiotlb_print_info(); - return 0; -} - /* * Statically reserve bounce buffer space and initialize bounce buffer data * structures for the software IO TLB used to implement the DMA API. */ -void __init swiotlb_init(bool addressing_limit, unsigned int flags) +void __init swiotlb_init_remap(bool addressing_limit, unsigned int flags, + int (*remap)(void *tlb, unsigned long nslabs)) { - size_t bytes = PAGE_ALIGN(default_nslabs << IO_TLB_SHIFT); + struct io_tlb_mem *mem = &io_tlb_default_mem; + unsigned long nslabs = default_nslabs; + size_t alloc_size = PAGE_ALIGN(array_size(sizeof(*mem->slots), nslabs)); + size_t bytes; void *tlb; if (!addressing_limit && !swiotlb_force_bounce) @@ -275,23 +252,48 @@ void __init swiotlb_init(bool addressing_limit, unsigned int flags) if (swiotlb_force_disable) return; + /* protect against double initialization */ + if (WARN_ON_ONCE(mem->nslabs)) + return; + /* * By default allocate the bonuce buffer memory from low memory. */ +retry: + bytes = PAGE_ALIGN(default_nslabs << IO_TLB_SHIFT); if (flags & SWIOTLB_ANY) tlb = memblock_alloc(bytes, PAGE_SIZE); else tlb = memblock_alloc_low(bytes, PAGE_SIZE); if (!tlb) - goto fail; - if (swiotlb_init_with_tbl(tlb, default_nslabs, flags)) - goto fail_free_mem; - return; + panic("%s: failed to allocate tlb structure\n", __func__); + + if (remap && remap(tlb, nslabs) < 0) { + memblock_free(tlb, PAGE_ALIGN(bytes)); + + /* Min is 2MB */ + if (nslabs <= 1024) + panic("%s: Failed to remap %zu bytes\n", + __func__, bytes); + nslabs = max(1024UL, ALIGN(nslabs >> 1, IO_TLB_SEGSIZE)); + goto retry; + } + + mem->slots = memblock_alloc(alloc_size, PAGE_SIZE); + if (!mem->slots) + panic("%s: Failed to allocate %zu bytes align=0x%lx\n", + __func__, alloc_size, PAGE_SIZE); -fail_free_mem: - memblock_free(tlb, bytes); -fail: - pr_warn("Cannot allocate buffer"); + swiotlb_init_io_tlb_mem(mem, __pa(tlb), default_nslabs, false); + mem->force_bounce = flags & SWIOTLB_FORCE; + + if (flags & SWIOTLB_VERBOSE) + swiotlb_print_info(); +} + +void __init swiotlb_init(bool addressing_limit, unsigned int flags) +{ + return swiotlb_init_remap(addressing_limit, flags, NULL); } /* @@ -299,8 +301,10 @@ void __init swiotlb_init(bool addressing_limit, unsigned int flags) * initialize the swiotlb later using the slab allocator if needed. * This should be just like above, but with some error catching. */ -int swiotlb_init_late(size_t size, gfp_t gfp_mask) +int swiotlb_init_late(size_t size, gfp_t gfp_mask, + int (*remap)(void *tlb, unsigned long nslabs)) { + struct io_tlb_mem *mem = &io_tlb_default_mem; unsigned long nslabs = ALIGN(size >> IO_TLB_SHIFT, IO_TLB_SEGSIZE); unsigned long bytes; unsigned char *vstart = NULL; @@ -310,9 +314,14 @@ int swiotlb_init_late(size_t size, gfp_t gfp_mask) if (swiotlb_force_disable) return 0; + /* protect against double initialization */ + if (WARN_ON_ONCE(mem->nslabs)) + return -ENOMEM; + /* * Get IO TLB memory from the low pages */ +retry: order = get_order(nslabs << IO_TLB_SHIFT); nslabs = SLABS_PER_PAGE << order; bytes = nslabs << IO_TLB_SHIFT; @@ -333,33 +342,28 @@ int swiotlb_init_late(size_t size, gfp_t gfp_mask) (PAGE_SIZE << order) >> 20); nslabs = SLABS_PER_PAGE << order; } - rc = swiotlb_late_init_with_tbl(vstart, nslabs); - if (rc) - free_pages((unsigned long)vstart, order); - - return rc; -} - -int -swiotlb_late_init_with_tbl(char *tlb, unsigned long nslabs) -{ - struct io_tlb_mem *mem = &io_tlb_default_mem; - unsigned long bytes = nslabs << IO_TLB_SHIFT; - if (swiotlb_force_disable) - return 0; + if (remap) + rc = remap(vstart, nslabs); + if (rc) { + free_pages((unsigned long)vstart, order); - /* protect against double initialization */ - if (WARN_ON_ONCE(mem->nslabs)) - return -ENOMEM; + /* Min is 2MB */ + if (nslabs <= 1024) + return rc; + nslabs = max(1024UL, ALIGN(nslabs >> 1, IO_TLB_SEGSIZE)); + goto retry; + } mem->slots = (void *)__get_free_pages(GFP_KERNEL | __GFP_ZERO, get_order(array_size(sizeof(*mem->slots), nslabs))); - if (!mem->slots) + if (!mem->slots) { + free_pages((unsigned long)vstart, order); return -ENOMEM; + } - set_memory_decrypted((unsigned long)tlb, bytes >> PAGE_SHIFT); - swiotlb_init_io_tlb_mem(mem, virt_to_phys(tlb), nslabs, true); + set_memory_decrypted((unsigned long)vstart, bytes >> PAGE_SHIFT); + swiotlb_init_io_tlb_mem(mem, virt_to_phys(vstart), nslabs, true); swiotlb_print_info(); return 0; -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Tue Mar 01 10:56:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 10:56:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281177.479433 (Exim 4.92) (envelope-from ) id 1nP0BH-0001Wh-BN; Tue, 01 Mar 2022 10:56:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281177.479433; Tue, 01 Mar 2022 10:56:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP0BH-0001WY-7o; Tue, 01 Mar 2022 10:56:35 +0000 Received: by outflank-mailman (input) for mailman id 281177; Tue, 01 Mar 2022 10:56:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP08v-00031b-Ve for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 10:54:10 +0000 Received: from bombadil.infradead.org (bombadil.infradead.org [2607:7c80:54:e::133]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id eb4a46bc-994d-11ec-8539-5f4723681683; Tue, 01 Mar 2022 11:54:09 +0100 (CET) Received: from [2.53.44.23] (helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nP08e-00GDJD-Jc; Tue, 01 Mar 2022 10:53:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eb4a46bc-994d-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=uIUvjX3splBhlaQqUgMhp+Ya0yKe0LcWUQ7okBzC2TY=; b=wcER0ODN4QJIKthFie+JZmR/Hy VdXf15NeqEWcQimAw7O9Mc2tWWNO381c3L9/sNOZ8czOQ9qgSykaLGehP4Pxw6bEXMjRsETCvcQfw a+JFsgZUT62YQcIlY13y/Gjs1OmUlGDLzRVSgleDuZDAa3bWnK7ZVhZGiMeC9jdkDy4XRXsgbE+eN R3o60tYwdvKUFIqfmPGh2z+vkPV8MMrAjLIt60roJ4r0p//uJxZxorz2JMMImLUiX8udsAtxR3SIe RvrO4/fZeloa2XdrSGHSl6A/DN7WiSOLfD58CF6z+LsUXEvmegPGFNgl/mGiYtsvg92XE4jHDjcGG 7X4aBMTA==; From: Christoph Hellwig To: iommu@lists.linux-foundation.org Cc: x86@kernel.org, Anshuman Khandual , Tom Lendacky , Konrad Rzeszutek Wilk , Stefano Stabellini , Boris Ostrovsky , Juergen Gross , Joerg Roedel , David Woodhouse , Lu Baolu , Robin Murphy , linux-arm-kernel@lists.infradead.org, xen-devel@lists.xenproject.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-hyperv@vger.kernel.org, tboot-devel@lists.sourceforge.net, linux-pci@vger.kernel.org Subject: [PATCH 10/12] swiotlb: add a SWIOTLB_ANY flag to lift the low memory restriction Date: Tue, 1 Mar 2022 12:53:09 +0200 Message-Id: <20220301105311.885699-11-hch@lst.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220301105311.885699-1-hch@lst.de> References: <20220301105311.885699-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Power SVM wants to allocate a swiotlb buffer that is not restricted to low memory for the trusted hypervisor scheme. Consolidate the support for this into the swiotlb_init interface by adding a new flag. Signed-off-by: Christoph Hellwig --- arch/powerpc/include/asm/svm.h | 4 ---- arch/powerpc/include/asm/swiotlb.h | 1 + arch/powerpc/kernel/dma-swiotlb.c | 1 + arch/powerpc/mm/mem.c | 5 +---- arch/powerpc/platforms/pseries/svm.c | 26 +------------------------- include/linux/swiotlb.h | 1 + kernel/dma/swiotlb.c | 9 +++++++-- 7 files changed, 12 insertions(+), 35 deletions(-) diff --git a/arch/powerpc/include/asm/svm.h b/arch/powerpc/include/asm/svm.h index 7546402d796af..85580b30aba48 100644 --- a/arch/powerpc/include/asm/svm.h +++ b/arch/powerpc/include/asm/svm.h @@ -15,8 +15,6 @@ static inline bool is_secure_guest(void) return mfmsr() & MSR_S; } -void __init svm_swiotlb_init(void); - void dtl_cache_ctor(void *addr); #define get_dtl_cache_ctor() (is_secure_guest() ? dtl_cache_ctor : NULL) @@ -27,8 +25,6 @@ static inline bool is_secure_guest(void) return false; } -static inline void svm_swiotlb_init(void) {} - #define get_dtl_cache_ctor() NULL #endif /* CONFIG_PPC_SVM */ diff --git a/arch/powerpc/include/asm/swiotlb.h b/arch/powerpc/include/asm/swiotlb.h index 3c1a1cd161286..4203b5e0a88ed 100644 --- a/arch/powerpc/include/asm/swiotlb.h +++ b/arch/powerpc/include/asm/swiotlb.h @@ -9,6 +9,7 @@ #include extern unsigned int ppc_swiotlb_enable; +extern unsigned int ppc_swiotlb_flags; #ifdef CONFIG_SWIOTLB void swiotlb_detect_4g(void); diff --git a/arch/powerpc/kernel/dma-swiotlb.c b/arch/powerpc/kernel/dma-swiotlb.c index fc7816126a401..ba256c37bcc0f 100644 --- a/arch/powerpc/kernel/dma-swiotlb.c +++ b/arch/powerpc/kernel/dma-swiotlb.c @@ -10,6 +10,7 @@ #include unsigned int ppc_swiotlb_enable; +unsigned int ppc_swiotlb_flags; void __init swiotlb_detect_4g(void) { diff --git a/arch/powerpc/mm/mem.c b/arch/powerpc/mm/mem.c index e1519e2edc656..a4d65418c30a9 100644 --- a/arch/powerpc/mm/mem.c +++ b/arch/powerpc/mm/mem.c @@ -249,10 +249,7 @@ void __init mem_init(void) * back to to-down. */ memblock_set_bottom_up(true); - if (is_secure_guest()) - svm_swiotlb_init(); - else - swiotlb_init(ppc_swiotlb_enable, 0); + swiotlb_init(ppc_swiotlb_enable, ppc_swiotlb_flags); #endif high_memory = (void *) __va(max_low_pfn * PAGE_SIZE); diff --git a/arch/powerpc/platforms/pseries/svm.c b/arch/powerpc/platforms/pseries/svm.c index c5228f4969eb2..3b4045d508ec8 100644 --- a/arch/powerpc/platforms/pseries/svm.c +++ b/arch/powerpc/platforms/pseries/svm.c @@ -28,7 +28,7 @@ static int __init init_svm(void) * need to use the SWIOTLB buffer for DMA even if dma_capable() says * otherwise. */ - swiotlb_force = SWIOTLB_FORCE; + ppc_swiotlb_flags |= SWIOTLB_ANY | SWIOTLB_FORCE; /* Share the SWIOTLB buffer with the host. */ swiotlb_update_mem_attributes(); @@ -37,30 +37,6 @@ static int __init init_svm(void) } machine_early_initcall(pseries, init_svm); -/* - * Initialize SWIOTLB. Essentially the same as swiotlb_init(), except that it - * can allocate the buffer anywhere in memory. Since the hypervisor doesn't have - * any addressing limitation, we don't need to allocate it in low addresses. - */ -void __init svm_swiotlb_init(void) -{ - unsigned char *vstart; - unsigned long bytes, io_tlb_nslabs; - - io_tlb_nslabs = (swiotlb_size_or_default() >> IO_TLB_SHIFT); - io_tlb_nslabs = ALIGN(io_tlb_nslabs, IO_TLB_SEGSIZE); - - bytes = io_tlb_nslabs << IO_TLB_SHIFT; - - vstart = memblock_alloc(PAGE_ALIGN(bytes), PAGE_SIZE); - if (vstart && !swiotlb_init_with_tbl(vstart, io_tlb_nslabs, false)) - return; - - - memblock_free(vstart, PAGE_ALIGN(io_tlb_nslabs << IO_TLB_SHIFT)); - panic("SVM: Cannot allocate SWIOTLB buffer"); -} - int set_memory_encrypted(unsigned long addr, int numpages) { if (!cc_platform_has(CC_ATTR_MEM_ENCRYPT)) diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h index dcecf953f7997..ee655f2e4d28b 100644 --- a/include/linux/swiotlb.h +++ b/include/linux/swiotlb.h @@ -15,6 +15,7 @@ struct scatterlist; #define SWIOTLB_VERBOSE (1 << 0) /* verbose initialization */ #define SWIOTLB_FORCE (1 << 1) /* force bounce buffering */ +#define SWIOTLB_ANY (1 << 2) /* allow any memory for the buffer */ /* * Maximum allowable number of contiguous slabs to map, diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c index 1a40c71c4d51a..77cf73dc20a78 100644 --- a/kernel/dma/swiotlb.c +++ b/kernel/dma/swiotlb.c @@ -275,8 +275,13 @@ void __init swiotlb_init(bool addressing_limit, unsigned int flags) if (swiotlb_force_disable) return; - /* Get IO TLB memory from the low pages */ - tlb = memblock_alloc_low(bytes, PAGE_SIZE); + /* + * By default allocate the bonuce buffer memory from low memory. + */ + if (flags & SWIOTLB_ANY) + tlb = memblock_alloc(bytes, PAGE_SIZE); + else + tlb = memblock_alloc_low(bytes, PAGE_SIZE); if (!tlb) goto fail; if (swiotlb_init_with_tbl(tlb, default_nslabs, flags)) -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Tue Mar 01 10:56:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 10:56:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281188.479444 (Exim 4.92) (envelope-from ) id 1nP0BS-00029z-Qh; Tue, 01 Mar 2022 10:56:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281188.479444; Tue, 01 Mar 2022 10:56:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP0BS-00029j-MY; Tue, 01 Mar 2022 10:56:46 +0000 Received: by outflank-mailman (input) for mailman id 281188; Tue, 01 Mar 2022 10:56:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP08r-00031b-O6 for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 10:54:05 +0000 Received: from bombadil.infradead.org (bombadil.infradead.org [2607:7c80:54:e::133]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e83bc8dc-994d-11ec-8539-5f4723681683; Tue, 01 Mar 2022 11:54:04 +0100 (CET) Received: from [2.53.44.23] (helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nP08a-00GDFK-PG; Tue, 01 Mar 2022 10:53:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e83bc8dc-994d-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=tv39sQgP2xcCr2eTxf5MnKYdYt65NXKD8YiezSmi0SY=; b=AEDmwyiGGA2iTFzY0+1I4wcvpz ikxKmDXpdOLqXxg5lLsFNsEJmX2CeSJPceloW3JG/BK3HNBLfPEMjOQmxtJVtmm8A5aGkPz6R+KDD WuUMKih85NvwMUSkikVPsaKhY1u4w7ty8o/kw3wYjJu2hRoH1/usg8JjE9CweCGDfmYNIk+WCBp25 P95HJiLNr+peUUGnWqdF42IObZSihvydS8qt8s8MzwgJe8gg5jLK1YhLOmRn0wkhyz9sXaIxHIurw jB0I7a6oqFq79nps497Tqb0H83l3CMVOMPm53vIRa5Fawy/Cb+y4MBRlTwEcCzqCVzQKvGC0Ft4L2 w7YgoLfQ==; From: Christoph Hellwig To: iommu@lists.linux-foundation.org Cc: x86@kernel.org, Anshuman Khandual , Tom Lendacky , Konrad Rzeszutek Wilk , Stefano Stabellini , Boris Ostrovsky , Juergen Gross , Joerg Roedel , David Woodhouse , Lu Baolu , Robin Murphy , linux-arm-kernel@lists.infradead.org, xen-devel@lists.xenproject.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-hyperv@vger.kernel.org, tboot-devel@lists.sourceforge.net, linux-pci@vger.kernel.org Subject: [PATCH 09/12] swiotlb: make the swiotlb_init interface more useful Date: Tue, 1 Mar 2022 12:53:08 +0200 Message-Id: <20220301105311.885699-10-hch@lst.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220301105311.885699-1-hch@lst.de> References: <20220301105311.885699-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Pass a bool to pass if swiotlb needs to be enabled based on the addressing needs and replace the verbose argument with a set of flags, including one to force enable bounce buffering. Note that this patch removes the possibility to force xen-swiotlb use using swiotlb=force on the command line on x86 (arm and arm64 never supported that), but this interface will be restored shortly. Signed-off-by: Christoph Hellwig --- arch/arm/mm/init.c | 6 +---- arch/arm64/mm/init.c | 6 +---- arch/ia64/mm/init.c | 4 +-- arch/mips/cavium-octeon/dma-octeon.c | 2 +- arch/mips/loongson64/dma.c | 2 +- arch/mips/sibyte/common/dma.c | 2 +- arch/powerpc/mm/mem.c | 3 ++- arch/powerpc/platforms/pseries/setup.c | 3 --- arch/riscv/mm/init.c | 8 +----- arch/s390/mm/init.c | 3 +-- arch/x86/kernel/pci-dma.c | 15 ++++++----- drivers/xen/swiotlb-xen.c | 4 +-- include/linux/swiotlb.h | 15 ++++++----- include/trace/events/swiotlb.h | 29 ++++++++------------- kernel/dma/swiotlb.c | 35 ++++++++++++++------------ 15 files changed, 55 insertions(+), 82 deletions(-) diff --git a/arch/arm/mm/init.c b/arch/arm/mm/init.c index 6d0cb0f7bc54b..73f30d278b565 100644 --- a/arch/arm/mm/init.c +++ b/arch/arm/mm/init.c @@ -312,11 +312,7 @@ static void __init free_highpages(void) void __init mem_init(void) { #ifdef CONFIG_ARM_LPAE - if (swiotlb_force == SWIOTLB_FORCE || - max_pfn > arm_dma_pfn_limit) - swiotlb_init(1); - else - swiotlb_force = SWIOTLB_NO_FORCE; + swiotlb_init(max_pfn > arm_dma_pfn_limit, SWIOTLB_VERBOSE); #endif set_max_mapnr(pfn_to_page(max_pfn) - mem_map); diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c index db63cc885771a..52102adda3d28 100644 --- a/arch/arm64/mm/init.c +++ b/arch/arm64/mm/init.c @@ -373,11 +373,7 @@ void __init bootmem_init(void) */ void __init mem_init(void) { - if (swiotlb_force == SWIOTLB_FORCE || - max_pfn > PFN_DOWN(arm64_dma_phys_limit)) - swiotlb_init(1); - else if (!xen_swiotlb_detect()) - swiotlb_force = SWIOTLB_NO_FORCE; + swiotlb_init(max_pfn > PFN_DOWN(arm64_dma_phys_limit), SWIOTLB_VERBOSE); /* this will put all unused low memory onto the freelists */ memblock_free_all(); diff --git a/arch/ia64/mm/init.c b/arch/ia64/mm/init.c index 5d165607bf354..3c3e15b22608f 100644 --- a/arch/ia64/mm/init.c +++ b/arch/ia64/mm/init.c @@ -437,9 +437,7 @@ mem_init (void) if (iommu_detected) break; #endif -#ifdef CONFIG_SWIOTLB - swiotlb_init(1); -#endif + swiotlb_init(true, SWIOTLB_VERBOSE); } while (0); #ifdef CONFIG_FLATMEM diff --git a/arch/mips/cavium-octeon/dma-octeon.c b/arch/mips/cavium-octeon/dma-octeon.c index fb7547e217263..9fbba6a8fa4c5 100644 --- a/arch/mips/cavium-octeon/dma-octeon.c +++ b/arch/mips/cavium-octeon/dma-octeon.c @@ -235,5 +235,5 @@ void __init plat_swiotlb_setup(void) #endif swiotlb_adjust_size(swiotlbsize); - swiotlb_init(1); + swiotlb_init(true, SWIOTLB_VERBOSE); } diff --git a/arch/mips/loongson64/dma.c b/arch/mips/loongson64/dma.c index 364f2f27c8723..8220a1bc0db64 100644 --- a/arch/mips/loongson64/dma.c +++ b/arch/mips/loongson64/dma.c @@ -24,5 +24,5 @@ phys_addr_t dma_to_phys(struct device *dev, dma_addr_t daddr) void __init plat_swiotlb_setup(void) { - swiotlb_init(1); + swiotlb_init(true, SWIOTLB_VERBOSE); } diff --git a/arch/mips/sibyte/common/dma.c b/arch/mips/sibyte/common/dma.c index eb47a94f3583e..c5c2c782aff68 100644 --- a/arch/mips/sibyte/common/dma.c +++ b/arch/mips/sibyte/common/dma.c @@ -10,5 +10,5 @@ void __init plat_swiotlb_setup(void) { - swiotlb_init(1); + swiotlb_init(true, SWIOTLB_VERBOSE); } diff --git a/arch/powerpc/mm/mem.c b/arch/powerpc/mm/mem.c index 8e301cd8925b2..e1519e2edc656 100644 --- a/arch/powerpc/mm/mem.c +++ b/arch/powerpc/mm/mem.c @@ -17,6 +17,7 @@ #include #include +#include #include #include #include @@ -251,7 +252,7 @@ void __init mem_init(void) if (is_secure_guest()) svm_swiotlb_init(); else - swiotlb_init(0); + swiotlb_init(ppc_swiotlb_enable, 0); #endif high_memory = (void *) __va(max_low_pfn * PAGE_SIZE); diff --git a/arch/powerpc/platforms/pseries/setup.c b/arch/powerpc/platforms/pseries/setup.c index 83a04d967a59f..45d637ab58261 100644 --- a/arch/powerpc/platforms/pseries/setup.c +++ b/arch/powerpc/platforms/pseries/setup.c @@ -838,9 +838,6 @@ static void __init pSeries_setup_arch(void) } ppc_md.pcibios_root_bridge_prepare = pseries_root_bridge_prepare; - - if (swiotlb_force == SWIOTLB_FORCE) - ppc_swiotlb_enable = 1; } static void pseries_panic(char *str) diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c index c27294128e182..6cdbb62672fe5 100644 --- a/arch/riscv/mm/init.c +++ b/arch/riscv/mm/init.c @@ -118,13 +118,7 @@ void __init mem_init(void) BUG_ON(!mem_map); #endif /* CONFIG_FLATMEM */ -#ifdef CONFIG_SWIOTLB - if (swiotlb_force == SWIOTLB_FORCE || - max_pfn > PFN_DOWN(dma32_phys_limit)) - swiotlb_init(1); - else - swiotlb_force = SWIOTLB_NO_FORCE; -#endif + swiotlb_init(max_pfn > PFN_DOWN(dma32_phys_limit), SWIOTLB_VERBOSE); high_memory = (void *)(__va(PFN_PHYS(max_low_pfn))); memblock_free_all(); diff --git a/arch/s390/mm/init.c b/arch/s390/mm/init.c index 86ffd0d51fd59..6fb6bf64326f9 100644 --- a/arch/s390/mm/init.c +++ b/arch/s390/mm/init.c @@ -185,8 +185,7 @@ static void pv_init(void) return; /* make sure bounce buffers are shared */ - swiotlb_force = SWIOTLB_FORCE; - swiotlb_init(1); + swiotlb_init(true, SWIOTLB_FORCE | SWIOTLB_VERBOSE); swiotlb_update_mem_attributes(); } diff --git a/arch/x86/kernel/pci-dma.c b/arch/x86/kernel/pci-dma.c index 7ab7002758396..e0def4b1c3181 100644 --- a/arch/x86/kernel/pci-dma.c +++ b/arch/x86/kernel/pci-dma.c @@ -39,6 +39,7 @@ int iommu_detected __read_mostly = 0; #ifdef CONFIG_SWIOTLB bool x86_swiotlb_enable; +static unsigned int x86_swiotlb_flags; static void __init pci_swiotlb_detect(void) { @@ -57,16 +58,16 @@ static void __init pci_swiotlb_detect(void) * Guest with guest memory encryption must always do I/O through a * bounce buffer as the hypervisor can't access arbitrary VM memory. */ - if (cc_platform_has(CC_ATTR_GUEST_MEM_ENCRYPT)) - swiotlb_force = SWIOTLB_FORCE; - - if (swiotlb_force == SWIOTLB_FORCE) + if (cc_platform_has(CC_ATTR_GUEST_MEM_ENCRYPT)) { x86_swiotlb_enable = true; + x86_swiotlb_flags |= SWIOTLB_FORCE; + } } #else static inline void __init pci_swiotlb_detect(void) { } +#define x86_swiotlb_flags 0 #endif /* CONFIG_SWIOTLB */ #ifdef CONFIG_SWIOTLB_XEN @@ -74,8 +75,7 @@ static bool xen_swiotlb; static void __init pci_xen_swiotlb_init(void) { - if (!xen_initial_domain() && !x86_swiotlb_enable && - swiotlb_force != SWIOTLB_FORCE) + if (!xen_initial_domain() && !x86_swiotlb_enable) return; x86_swiotlb_enable = false; xen_swiotlb = true; @@ -119,8 +119,7 @@ void __init pci_iommu_alloc(void) gart_iommu_hole_init(); amd_iommu_detect(); detect_intel_iommu(); - if (x86_swiotlb_enable) - swiotlb_init(0); + swiotlb_init(x86_swiotlb_enable, x86_swiotlb_flags); } /* diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c index 485cd06ed39e7..c2da3eb4826e8 100644 --- a/drivers/xen/swiotlb-xen.c +++ b/drivers/xen/swiotlb-xen.c @@ -251,7 +251,7 @@ void __init xen_swiotlb_init_early(void) panic("%s (rc:%d)", xen_swiotlb_error(XEN_SWIOTLB_EFIXUP), rc); } - if (swiotlb_init_with_tbl(start, nslabs, true)) + if (swiotlb_init_with_tbl(start, nslabs, SWIOTLB_VERBOSE)) panic("Cannot allocate SWIOTLB buffer"); } #endif /* CONFIG_X86 */ @@ -376,7 +376,7 @@ static dma_addr_t xen_swiotlb_map_page(struct device *dev, struct page *page, /* * Oh well, have to allocate and map a bounce buffer. */ - trace_swiotlb_bounced(dev, dev_addr, size, swiotlb_force); + trace_swiotlb_bounced(dev, dev_addr, size); map = swiotlb_tbl_map_single(dev, phys, size, size, 0, dir, attrs); if (map == (phys_addr_t)DMA_MAPPING_ERROR) diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h index 1befd6b2ccf5e..dcecf953f7997 100644 --- a/include/linux/swiotlb.h +++ b/include/linux/swiotlb.h @@ -13,11 +13,8 @@ struct device; struct page; struct scatterlist; -enum swiotlb_force { - SWIOTLB_NORMAL, /* Default - depending on HW DMA mask etc. */ - SWIOTLB_FORCE, /* swiotlb=force */ - SWIOTLB_NO_FORCE, /* swiotlb=noforce */ -}; +#define SWIOTLB_VERBOSE (1 << 0) /* verbose initialization */ +#define SWIOTLB_FORCE (1 << 1) /* force bounce buffering */ /* * Maximum allowable number of contiguous slabs to map, @@ -36,8 +33,7 @@ enum swiotlb_force { /* default to 64MB */ #define IO_TLB_DEFAULT_SIZE (64UL<<20) -extern void swiotlb_init(int verbose); -int swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, int verbose); +int swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, unsigned int flags); unsigned long swiotlb_size_or_default(void); extern int swiotlb_late_init_with_tbl(char *tlb, unsigned long nslabs); int swiotlb_init_late(size_t size, gfp_t gfp_mask); @@ -126,13 +122,16 @@ static inline bool is_swiotlb_force_bounce(struct device *dev) return mem && mem->force_bounce; } +void swiotlb_init(bool addressing_limited, unsigned int flags); void __init swiotlb_exit(void); unsigned int swiotlb_max_segment(void); size_t swiotlb_max_mapping_size(struct device *dev); bool is_swiotlb_active(struct device *dev); void __init swiotlb_adjust_size(unsigned long size); #else -#define swiotlb_force SWIOTLB_NO_FORCE +static inline void swiotlb_init(bool addressing_limited, unsigned int flags) +{ +} static inline bool is_swiotlb_buffer(struct device *dev, phys_addr_t paddr) { return false; diff --git a/include/trace/events/swiotlb.h b/include/trace/events/swiotlb.h index 705be43b71ab0..da05c9ebd224a 100644 --- a/include/trace/events/swiotlb.h +++ b/include/trace/events/swiotlb.h @@ -8,20 +8,15 @@ #include TRACE_EVENT(swiotlb_bounced, - - TP_PROTO(struct device *dev, - dma_addr_t dev_addr, - size_t size, - enum swiotlb_force swiotlb_force), - - TP_ARGS(dev, dev_addr, size, swiotlb_force), + TP_PROTO(struct device *dev, dma_addr_t dev_addr, size_t size), + TP_ARGS(dev, dev_addr, size), TP_STRUCT__entry( - __string( dev_name, dev_name(dev) ) - __field( u64, dma_mask ) - __field( dma_addr_t, dev_addr ) - __field( size_t, size ) - __field( enum swiotlb_force, swiotlb_force ) + __string(dev_name, dev_name(dev)) + __field(u64, dma_mask) + __field(dma_addr_t, dev_addr) + __field(size_t, size) + __field(bool, force) ), TP_fast_assign( @@ -29,19 +24,15 @@ TRACE_EVENT(swiotlb_bounced, __entry->dma_mask = (dev->dma_mask ? *dev->dma_mask : 0); __entry->dev_addr = dev_addr; __entry->size = size; - __entry->swiotlb_force = swiotlb_force; + __entry->force = is_swiotlb_force_bounce(dev); ), - TP_printk("dev_name: %s dma_mask=%llx dev_addr=%llx " - "size=%zu %s", + TP_printk("dev_name: %s dma_mask=%llx dev_addr=%llx size=%zu %s", __get_str(dev_name), __entry->dma_mask, (unsigned long long)__entry->dev_addr, __entry->size, - __print_symbolic(__entry->swiotlb_force, - { SWIOTLB_NORMAL, "NORMAL" }, - { SWIOTLB_FORCE, "FORCE" }, - { SWIOTLB_NO_FORCE, "NO_FORCE" })) + __entry->force ? "FORCE" : "NORMAL") ); #endif /* _TRACE_SWIOTLB_H */ diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c index 9a38ea3a46e9f..1a40c71c4d51a 100644 --- a/kernel/dma/swiotlb.c +++ b/kernel/dma/swiotlb.c @@ -69,7 +69,8 @@ #define INVALID_PHYS_ADDR (~(phys_addr_t)0) -enum swiotlb_force swiotlb_force; +static bool swiotlb_force_bounce; +static bool swiotlb_force_disable; struct io_tlb_mem io_tlb_default_mem; @@ -88,9 +89,9 @@ setup_io_tlb_npages(char *str) if (*str == ',') ++str; if (!strcmp(str, "force")) - swiotlb_force = SWIOTLB_FORCE; + swiotlb_force_bounce = true; else if (!strcmp(str, "noforce")) - swiotlb_force = SWIOTLB_NO_FORCE; + swiotlb_force_disable = true; return 0; } @@ -211,7 +212,7 @@ static void swiotlb_init_io_tlb_mem(struct io_tlb_mem *mem, phys_addr_t start, mem->index = 0; mem->late_alloc = late_alloc; - if (swiotlb_force == SWIOTLB_FORCE) + if (swiotlb_force_bounce) mem->force_bounce = true; spin_lock_init(&mem->lock); @@ -233,12 +234,13 @@ static void swiotlb_init_io_tlb_mem(struct io_tlb_mem *mem, phys_addr_t start, return; } -int __init swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, int verbose) +int __init swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, + unsigned int flags) { struct io_tlb_mem *mem = &io_tlb_default_mem; size_t alloc_size; - if (swiotlb_force == SWIOTLB_NO_FORCE) + if (swiotlb_force_disable) return 0; /* protect against double initialization */ @@ -252,8 +254,9 @@ int __init swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, int verbose) __func__, alloc_size, PAGE_SIZE); swiotlb_init_io_tlb_mem(mem, __pa(tlb), nslabs, false); + mem->force_bounce = flags & SWIOTLB_FORCE; - if (verbose) + if (flags & SWIOTLB_VERBOSE) swiotlb_print_info(); return 0; } @@ -262,20 +265,21 @@ int __init swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, int verbose) * Statically reserve bounce buffer space and initialize bounce buffer data * structures for the software IO TLB used to implement the DMA API. */ -void __init -swiotlb_init(int verbose) +void __init swiotlb_init(bool addressing_limit, unsigned int flags) { size_t bytes = PAGE_ALIGN(default_nslabs << IO_TLB_SHIFT); void *tlb; - if (swiotlb_force == SWIOTLB_NO_FORCE) + if (!addressing_limit && !swiotlb_force_bounce) + return; + if (swiotlb_force_disable) return; /* Get IO TLB memory from the low pages */ tlb = memblock_alloc_low(bytes, PAGE_SIZE); if (!tlb) goto fail; - if (swiotlb_init_with_tbl(tlb, default_nslabs, verbose)) + if (swiotlb_init_with_tbl(tlb, default_nslabs, flags)) goto fail_free_mem; return; @@ -298,7 +302,7 @@ int swiotlb_init_late(size_t size, gfp_t gfp_mask) unsigned int order; int rc = 0; - if (swiotlb_force == SWIOTLB_NO_FORCE) + if (swiotlb_force_disable) return 0; /* @@ -337,7 +341,7 @@ swiotlb_late_init_with_tbl(char *tlb, unsigned long nslabs) struct io_tlb_mem *mem = &io_tlb_default_mem; unsigned long bytes = nslabs << IO_TLB_SHIFT; - if (swiotlb_force == SWIOTLB_NO_FORCE) + if (swiotlb_force_disable) return 0; /* protect against double initialization */ @@ -362,7 +366,7 @@ void __init swiotlb_exit(void) unsigned long tbl_vaddr; size_t tbl_size, slots_size; - if (swiotlb_force == SWIOTLB_FORCE) + if (swiotlb_force_bounce) return; if (!mem->nslabs) @@ -709,8 +713,7 @@ dma_addr_t swiotlb_map(struct device *dev, phys_addr_t paddr, size_t size, phys_addr_t swiotlb_addr; dma_addr_t dma_addr; - trace_swiotlb_bounced(dev, phys_to_dma(dev, paddr), size, - swiotlb_force); + trace_swiotlb_bounced(dev, phys_to_dma(dev, paddr), size); swiotlb_addr = swiotlb_tbl_map_single(dev, paddr, size, size, 0, dir, attrs); -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Tue Mar 01 11:00:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 11:00:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281215.479455 (Exim 4.92) (envelope-from ) id 1nP0FJ-00042i-DN; Tue, 01 Mar 2022 11:00:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281215.479455; Tue, 01 Mar 2022 11:00:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP0FJ-00042b-AA; Tue, 01 Mar 2022 11:00:45 +0000 Received: by outflank-mailman (input) for mailman id 281215; Tue, 01 Mar 2022 11:00:44 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP0FI-00042R-HJ; Tue, 01 Mar 2022 11:00:44 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP0FI-0004aB-Em; Tue, 01 Mar 2022 11:00:44 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP0FI-0006Qp-85; Tue, 01 Mar 2022 11:00:44 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nP0FI-0003a7-7c; Tue, 01 Mar 2022 11:00:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=1tPSRtla2HNo/dMwWILBXhwXRqh2zbySNUV/S+vnH84=; b=OY5djjxYOpGibLn9kq2f7nch5f qTSCzeySpGVZBMybIlOMR8f2WgoJFaMdhBC4GfpqxnZQ/8bMCgJhVAqwQL4TMA7dO/RzJl1iAe6Ch tvc05dXUDvW6I8icGwCsQJzkerccJvPdjZZ/dokUN+Lyu55fFuAtnebDKwqX31gKaEso=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 168285: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=497ac7b6d7f9750f48f137db244931a5728b1968 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 01 Mar 2022 11:00:44 +0000 flight 168285 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/168285/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 497ac7b6d7f9750f48f137db244931a5728b1968 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 1 days Failing since 168258 2022-03-01 01:55:31 Z 0 days 5 attempts Testing same since 168262 2022-03-01 04:10:26 Z 0 days 4 attempts ------------------------------------------------------------ People who touched revisions under test: Guomin Jiang Jason Jason Lou jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 497ac7b6d7f9750f48f137db244931a5728b1968 Author: Guomin Jiang Date: Sat Jan 29 16:28:02 2022 +0800 UefiPayloadPkg/PayloadLoaderPeim: Use INT64 as input parameter REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3818 It will have some potential issue when memory larger than 2G because the high memory address will be fill with 0xFFFFFFFF when do the operation of INTN + INT64 but it is 32 bit normal data in fact. Should use same data type INT64 + INT64. V3: 1. Use INT64 as input parameter because all date type is 64 bit V2: 1. Force the data type to UINTN to avoid high dword be filled with 0xFFFFFFFF 2. Keep INTN because the offset may postive or negative. Reviewed-by: Guo Dong Reviewed-by: Ray Ni Signed-off-by: Guomin Jiang commit 6a890db161cd6d378bec3499a1e774db3f5a27a7 Author: Jason Date: Mon Jan 10 22:30:29 2022 +0800 BaseTools: Upgrade the version of NASM tool REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Upgrade the version of NASM tool to avoid compilation errors when compiling NASM code change. Signed-off-by: Jason Lou Cc: Bob Feng Cc: Liming Gao Reviewed-by: Yuwei Chen commit bbaa00dd01ed0df30e43a5a89fd2b0433d858b73 Author: Jason Date: Mon Jan 10 22:05:47 2022 +0800 MdePkg: Remove the macro definitions regarding Opcode. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Remove the macro definitions regarding Opcode because new version of NASM tool(e.g. v2.15.05) supports the corresponding instructions. Note: This patch need to be merged after other NASM code change to avoid compilation errors. Signed-off-by: Jason Lou Cc: Michael D Kinney Reviewed-by: Liming Gao Cc: Zhiguang Liu commit 2aa107c0aa2e1375651867c8df1b81ff64b67fce Author: Jason Date: Mon Jan 10 22:01:18 2022 +0800 UefiCpuPkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Reviewed-by: Ray Ni Cc: Eric Dong Cc: Laszlo Ersek Cc: Rahul Kumar commit 7bc8b1d9f412507d579f21ea9af56fced81e7827 Author: Jason Date: Mon Jan 10 21:52:52 2022 +0800 SourceLevelDebugPkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Reviewed-by: Hao A Wu commit d3febfd9ade35dc552df6b3607c2b15d26b82867 Author: Jason Date: Mon Jan 10 21:46:27 2022 +0800 MdePkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Cc: Michael D Kinney Reviewed-by: Liming Gao Cc: Zhiguang Liu commit 84338c0d498555f860a480693ee8647a1795fba3 Author: Jason Date: Mon Jan 10 21:04:09 2022 +0800 MdeModulePkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Reviewed-by: Ray Ni Cc: Dandan Bi Reviewed-by: Liming Gao From xen-devel-bounces@lists.xenproject.org Tue Mar 01 11:04:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 11:04:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281226.479466 (Exim 4.92) (envelope-from ) id 1nP0JF-0004f5-VZ; Tue, 01 Mar 2022 11:04:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281226.479466; Tue, 01 Mar 2022 11:04:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP0JF-0004ey-Rq; Tue, 01 Mar 2022 11:04:49 +0000 Received: by outflank-mailman (input) for mailman id 281226; Tue, 01 Mar 2022 11:04:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP0JE-0004eo-TD; Tue, 01 Mar 2022 11:04:48 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP0JE-0004dl-Ra; Tue, 01 Mar 2022 11:04:48 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP0JE-0006XM-Hk; Tue, 01 Mar 2022 11:04:48 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nP0JE-0004kI-HH; Tue, 01 Mar 2022 11:04:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Message-Id:Subject:To; bh=l/adDxeD0dH0TRHRSZeSm8RyLGHP5BocljlgYl/tvA8=; b=Rho9+iEZzLbBgXH1mIypedGGrT IQkTA7+TlwafXwEwARy7hqQp1qDAFPA+xVv2e3ZfM3ywck3MxE6goULccHePMSAeZMjCkZZ81wPui zp1gX40w09zSZqp8f/S4RSkKBqwhA3EUGrJQhsbNOwzKP0DWNFTIisUCWccSDzOyly1Y=; To: xen-devel@lists.xenproject.org Subject: [ovmf bisection] complete build-amd64 Message-Id: From: osstest service owner Date: Tue, 01 Mar 2022 11:04:48 +0000 branch xen-unstable xenbranch xen-unstable job build-amd64 testid xen-build Tree: ovmf https://github.com/tianocore/edk2.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: seabios git://xenbits.xen.org/osstest/seabios.git Tree: xen git://xenbits.xen.org/xen.git *** Found and reproduced problem changeset *** Bug is in tree: ovmf https://github.com/tianocore/edk2.git Bug introduced: d3febfd9ade35dc552df6b3607c2b15d26b82867 Bug not present: 84338c0d498555f860a480693ee8647a1795fba3 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/168287/ commit d3febfd9ade35dc552df6b3607c2b15d26b82867 Author: Jason Date: Mon Jan 10 21:46:27 2022 +0800 MdePkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Cc: Michael D Kinney Reviewed-by: Liming Gao Cc: Zhiguang Liu For bisection revision-tuple graph see: http://logs.test-lab.xenproject.org/osstest/results/bisect/ovmf/build-amd64.xen-build.html Revision IDs in each graph node refer, respectively, to the Trees above. ---------------------------------------- Running cs-bisection-step --graph-out=/home/logs/results/bisect/ovmf/build-amd64.xen-build --summary-out=tmp/168287.bisection-summary --basis-template=168254 --blessings=real,real-bisect,real-retry ovmf build-amd64 xen-build Searching for failure / basis pass: 168285 fail [host=himrod1] / 168254 [host=himrod2] 168249 [host=himrod2] 168232 ok. Failure / basis pass flights: 168285 / 168232 (tree with no url: minios) Tree: ovmf https://github.com/tianocore/edk2.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: seabios git://xenbits.xen.org/osstest/seabios.git Tree: xen git://xenbits.xen.org/xen.git Latest 497ac7b6d7f9750f48f137db244931a5728b1968 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 Basis pass 54cddc3ad4b3a317985ce5f491f9b1f31ab10dd8 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 9ba4c529985a1773852069889a5b53f2ed26c408 Generating revisions with ./adhoc-revtuple-generator https://github.com/tianocore/edk2.git#54cddc3ad4b3a317985ce5f491f9b1f31ab10dd8-497ac7b6d7f9750f48f137db244931a5728b1968 git://xenbits.xen.org/qemu-xen-traditional.git#3d273dd05e51e5a1ffba3d98c7437ee84e8f8764-3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 git://xenbits.xen.org/qemu-xen.git#a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42-a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 git://xenbits.xen.org/osstest/seabios.git#829b0f1a7cda1bccdf44a379fb3a96e519a7e8\ cd-829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd git://xenbits.xen.org/xen.git#9ba4c529985a1773852069889a5b53f2ed26c408-4388144c44c4dd9e9b7df97938ef08ffa85eec07 Loaded 10001 nodes in revision graph Searching for test results: 168232 pass 54cddc3ad4b3a317985ce5f491f9b1f31ab10dd8 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 9ba4c529985a1773852069889a5b53f2ed26c408 168249 [host=himrod2] 168254 [host=himrod2] 168258 fail 6a890db161cd6d378bec3499a1e774db3f5a27a7 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 168262 fail 497ac7b6d7f9750f48f137db244931a5728b1968 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 168267 fail 497ac7b6d7f9750f48f137db244931a5728b1968 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 168275 pass 54cddc3ad4b3a317985ce5f491f9b1f31ab10dd8 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 9ba4c529985a1773852069889a5b53f2ed26c408 168276 fail 497ac7b6d7f9750f48f137db244931a5728b1968 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 168277 pass 54cddc3ad4b3a317985ce5f491f9b1f31ab10dd8 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 1449f6873d7dd477ba110b415ca08a3c2553451e 168278 pass de463163d9f6d3c5dc6b55ff35d1e5676e0e1b9f 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 168279 pass 84338c0d498555f860a480693ee8647a1795fba3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 168280 fail 7bc8b1d9f412507d579f21ea9af56fced81e7827 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 168281 fail d3febfd9ade35dc552df6b3607c2b15d26b82867 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 168282 pass 84338c0d498555f860a480693ee8647a1795fba3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 168271 fail 497ac7b6d7f9750f48f137db244931a5728b1968 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 168284 fail d3febfd9ade35dc552df6b3607c2b15d26b82867 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 168286 pass 84338c0d498555f860a480693ee8647a1795fba3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 168285 fail 497ac7b6d7f9750f48f137db244931a5728b1968 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 168287 fail d3febfd9ade35dc552df6b3607c2b15d26b82867 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 Searching for interesting versions Result found: flight 168232 (pass), for basis pass For basis failure, parent search stopping at 84338c0d498555f860a480693ee8647a1795fba3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07, results HASH(0x555f15b711c8) HASH(0x555f15b78d90) HASH(0x555f15b7d9c8) For basis failure, parent search stopping at de463163d9f6d3c5dc6b55ff35d1e5676e0e1b9f 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7\ cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07, results HASH(0x555f15b6f1c0) For basis failure, parent search stopping at 54cddc3ad4b3a317985ce5f491f9b1f31ab10dd8 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 1449f6873d7dd477ba110b415ca08a3c2553451e, results HASH(0x555f15b6e8c0) For basis failure, parent search stopping at 54cddc3ad4b3a317985ce5f491f9b1f31ab10dd8 3d273dd05e51e5a1ffba3d98c7437ee\ 84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 9ba4c529985a1773852069889a5b53f2ed26c408, results HASH(0x555f15b5ff38) HASH(0x555f15b6a888) Result found: flight 168258 (fail), for basis failure (at ancestor ~5258) Repro found: flight 168275 (pass), for basis pass Repro found: flight 168276 (fail), for basis failure 0 revisions at 84338c0d498555f860a480693ee8647a1795fba3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 No revisions left to test, checking graph state. Result found: flight 168279 (pass), for last pass Result found: flight 168281 (fail), for first failure Repro found: flight 168282 (pass), for last pass Repro found: flight 168284 (fail), for first failure Repro found: flight 168286 (pass), for last pass Repro found: flight 168287 (fail), for first failure *** Found and reproduced problem changeset *** Bug is in tree: ovmf https://github.com/tianocore/edk2.git Bug introduced: d3febfd9ade35dc552df6b3607c2b15d26b82867 Bug not present: 84338c0d498555f860a480693ee8647a1795fba3 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/168287/ commit d3febfd9ade35dc552df6b3607c2b15d26b82867 Author: Jason Date: Mon Jan 10 21:46:27 2022 +0800 MdePkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Cc: Michael D Kinney Reviewed-by: Liming Gao Cc: Zhiguang Liu Revision graph left in /home/logs/results/bisect/ovmf/build-amd64.xen-build.{dot,ps,png,html,svg}. ---------------------------------------- 168287: tolerable ALL FAIL flight 168287 ovmf real-bisect [real] http://logs.test-lab.xenproject.org/osstest/logs/168287/ Failures :-/ but no regressions. Tests which did not succeed, including tests which could not be run: build-amd64 6 xen-build fail baseline untested jobs: build-amd64 fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary From xen-devel-bounces@lists.xenproject.org Tue Mar 01 11:04:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 11:04:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281229.479476 (Exim 4.92) (envelope-from ) id 1nP0JO-0004yx-Bp; Tue, 01 Mar 2022 11:04:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281229.479476; Tue, 01 Mar 2022 11:04:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP0JO-0004yq-8j; Tue, 01 Mar 2022 11:04:58 +0000 Received: by outflank-mailman (input) for mailman id 281229; Tue, 01 Mar 2022 11:04:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP0JM-0004xb-EC for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 11:04:56 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6ce38020-994f-11ec-8539-5f4723681683; Tue, 01 Mar 2022 12:04:55 +0100 (CET) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-am5eur02lp2052.outbound.protection.outlook.com [104.47.4.52]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-39-Kxb7z4QqOLeCEz0IxItOeA-1; Tue, 01 Mar 2022 12:04:54 +0100 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by PAXPR04MB8095.eurprd04.prod.outlook.com (2603:10a6:102:1c6::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.26; Tue, 1 Mar 2022 11:04:52 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.027; Tue, 1 Mar 2022 11:04:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6ce38020-994f-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1646132694; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=XRCBJrGYHuXcM+y+uvLEjkirCD2EFtAu6W00DFjZ3Qk=; b=TUbTPjzQd7DSgQvC4VjOaDkIsxeZbpW4/ckXiAm0Hs2s5B0pEwdWrwXJaMj/WxTDMBMoAy KkRsI/wBvWtkOh8GRUDVP9JrQyc3pKjU6HdKeS/KsD4b75nPpSOBs3u0urZeCNF8Oq5yUs 4DbzspLVnwJjJ6yGH8vLiTR0l8sq82A= X-MC-Unique: Kxb7z4QqOLeCEz0IxItOeA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QQivutYdrsDao/cXCJYj0xzU9uqphpwdvzyw7Rk580tP4/Lwjae1DOrvZ6lbrW39d/kah1JOgzBDdFNlXn+xByUMjzAEdArysqqs4j8jR14aG7X5PLoVVa9qgF4J3IAsmGe0EzOe7Ztcq9kPeuj8+gYc25jM8rPTamkbg595a9/BK2osRWgArNbod64V/oLnk7+di7kcpY9AgyINNuXs7p5yoD+l6+o5k/ZSovcwnct4dyZ2hxjpdhjrq2VR2a6KqgBMx9mYMdMCY3tThV7zl6HKOtydg2ZcpZRaPpaoNVXZOl7ErUdu6ZpcRsMEuZ3/IIJscx5+w7zInNQVCTvqhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XRCBJrGYHuXcM+y+uvLEjkirCD2EFtAu6W00DFjZ3Qk=; b=aFNelPHfz6BeSv/p1DGkw4NFzILwu9mlJZL66i4iZvUt5h1VWRGZAM+6TLOeRiB4PWVeO0K+k/6HUn65egh1VtOheAwXylT6S8mOBQm+gcEAjXMPJDHlgCIc0GAv/kNfZMJCTvmxpVejSOuywoKxGPW6YnPa1jvbc/4JRcSu2BgXuINNKWiZLtrQV8PxsXvAw0T/vyZQXjcLRYD/mTBFmH+Ot4rhjYLPdW9WkX05eBpFi3da7ddHi0D7bTV71LSQ39PyUX7dVLvowUgZjKg4299Dqe1TdLAFO8sowC792+0129F3MRNBgSl3kURYb8qP5bnejioRcTj+55CZHmuPmg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <77675e7f-2a7e-f517-4aba-e20774c8bfe5@suse.com> Date: Tue, 1 Mar 2022 12:04:50 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= From: Jan Beulich Subject: [PATCH 0/2] x86/time: CF-clobber annotations Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0276.eurprd06.prod.outlook.com (2603:10a6:20b:45a::34) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f6b32ab1-00d8-4c09-c005-08d9fb734f70 X-MS-TrafficTypeDiagnostic: PAXPR04MB8095:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2NoCMf2xXxtjKYlqWNIOQHGERGuU17ecqpjOHPtKFvQ+9vQEoN1kCKSjHj0FJr3OpxOAqkzcDxIDRil8U1v/B5a6Bj9HKgvJ1wlQAQEWcRt2ii896aZVwl5uQW3XI4TlRwKm5wcV9i4LlQXhbvksQCXd8Y0z9URQniORwYzP0wdHWHZHEADphcTaJyolWdumURYqzV+qKv8EhK5k7W2DXtkrQsOCXPOCVLd83O8RluhGbMgW6bNNHvlClFrrGQ4JvaVY3IPammSXudtDsz6qIJgihm2MArwC5mizfQ9bKJX/2kV1LsF0a4MwaYhlxQe6IMFFBoISK4EO/RWhgg9huLJQbEbiDJKGCIdEkaELWaHuPJ5vYi8cW8cw0S0kwvSrvuRQ+KaYHwlF33qMqHn7soH+3h0Sfu9GuBNcQCO9siCvGIb4ynbM/zENA6oPR6NOmjLqj0iLh92vC+C8xDWo3kfhOMq2X2ptDJeUpHRga+H2bmD/2T/gJiVavrSdFFi1a64EAvguH8z9dbvuocgAo8o9s8sr9dic9FTiHKHoFSoqnxbPo/xny2uSI3zmp23QQIlbbItryuTHOriY2pukh5cgv8Oi42xtZCwAHhXydfq8pAthMf+7iBrCEKqke9WHQATPMjb9r/S7npq7aFXS7OW7maYasFIan5fhPElocFk/5vIUeqko8NQWjDFEHwKlWY8M9Jef+gHXjA1lvcAyVaR5i09lVQ7R8rNNboJyTUs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(5660300002)(558084003)(31696002)(86362001)(6512007)(66476007)(66556008)(8936002)(316002)(38100700002)(4326008)(6916009)(54906003)(66946007)(508600001)(6486002)(8676002)(2906002)(2616005)(186003)(31686004)(26005)(6506007)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OE8xZXY2SEZGYnRQclhkblUzeGJjbVJhYlRnczljdDRtV0JQUHRlbHVURzRW?= =?utf-8?B?UnRNR1Vkc3hEVVVYSVhmcDhmS241elVqQ3B5ZmRzdlYrYUlORWJCRFJIRTV0?= =?utf-8?B?Z3Q5UHp6Kzl0SkVGc3phakVCMFRaMVhXdStNU0tQemh2ME9UVDhjdStOc3lY?= =?utf-8?B?S1JkV2lIU0ZKUC9RTzc3QjBWUUZPNWlsajVxc3lZQmJZd2p0bWZ5d21YZ213?= =?utf-8?B?bzI0ZmtwQ1FtekhNTXRpOExSYm9qdVNDUDh3cjVXK3BaUVdOSVc3S3lXQ2Z0?= =?utf-8?B?NDR6WjFPT3J3aUpNenhuZGpaNEZKU3RWWmNSa08rR3I2MHdUUmJVWjEyZWEy?= =?utf-8?B?OUZISFpzUTlWU2pEcHk0MFV3SkcxWkxhQm8zOGRoVUFSeTJkRUtIYlJ3V2hF?= =?utf-8?B?ZG9DK0pHM2diWWVibmczUnRYU2wrY0xBaXdoN0ZuSEtMenFsWGRTa3ErREsy?= =?utf-8?B?RXd5QTk3d25PSis5U1pLRHNuMEVGL1pEK1h3TVo1S0c0RXdBUzVrNHBGZXc2?= =?utf-8?B?QXBVTkVKT1ZxQklIOC9mVk1ORHc2dGVtaW5KSHpoTUlIN202ZlczWTNkeE9U?= =?utf-8?B?dUhkTG9XRlAzOUZxVzFqZjYrakhzL2FMNzdvbm9YWmtEUmw1dkUrdlp0eGgz?= =?utf-8?B?OVZoRDZyN1dlcVRVMlhIZ21TUlFFZ3I3SHFYLy85RFBObDhUbkpwT0Q5K1Ro?= =?utf-8?B?c2NLRDdjYlNvbG9samMrdjZTYlZ2UzhMWXllZ3gxYzhaTWZXbmxzN1NCb2Y5?= =?utf-8?B?a1pLc1liNDVhKzNma1VYZnFZWTNNeWk3S0NzVklDY1oxQSsxbU5kYzRTYzYx?= =?utf-8?B?WklDc1ZEbWxiLzBTT1krd0lMRTN1NEc5TlRBdVlnZFlSTG0xakQ2Q0lOc2lX?= =?utf-8?B?cG5PNkFPVzdHVGNycnQvenp2N0xyZ001dGVrYUVsUG5zaWh6cnBJVG5HNUN5?= =?utf-8?B?VHJWSzFFNmRuV1lYWU9yakxVQk1FVG45VXlFdnlLVUxsUkJYMU5nL2JRdXhQ?= =?utf-8?B?VXF5SWllQkxQQmNrSHlzNCtWN2lyUWpGN1g5YXBhdFk0Mi9CdmV2dGRVMFZO?= =?utf-8?B?TUxLWkFDenhsSnFZak85Wk9qdG1qZ09IVDg5ZENPSC9UcW1YZ2gvUzhidEhu?= =?utf-8?B?SHVyVkJWdDZuY2gxTXptb3FCYWRSRFE0MG95aHVjTFFML0JXS0ZRZlRMSFRL?= =?utf-8?B?L0cycnZCMFR2aGdlRFIveWVaRlhJWkg4Rzk5K1Z6NkMrSkh4cHI4aU4xR1ZO?= =?utf-8?B?TGpQNnBCOTBmL3hXRmdzM2c2R01CaGVkemxnRmtDMCt5eEdlZW5YSXV3Zlpn?= =?utf-8?B?b1VoYlRCTWplNFlWa0thQXdzOUZwdUtBSkNjWGcrUmpQSEFmbTRpRXRyUzRF?= =?utf-8?B?a1hYODR4N3VXZ1lINzA0WUp0TEhzRTUwMWFrRmJjNVQ5YS9BWnBnQnVPZmly?= =?utf-8?B?bTZHMFQ1UmdlVlRFNlJ3MEdjMk5wNDZSK1dOQjZOcFZDbksyNmttRDFFdVBr?= =?utf-8?B?bkU0enI2SUtnTzFmazBPY3gzcG1jTlYrNnJDZmtPRVRlOUY2ZnFEQU5oQktv?= =?utf-8?B?MUdzQXNzNnJhOWwzUjJJSE12enZabEFjSUJRdFlkNGc4Zngwc2dTcktzYitB?= =?utf-8?B?YjRjUzJCUmMrMVNiZjg0NHp0b0Vwa3R1NVZrby9QUXpjK2Z5QiszTXJOMGV2?= =?utf-8?B?VjA2cW5kbXJybk1sTjFQNjBsWDRNUkdmeDhOTHdrL0NHenlRejFwTGJ0dWl6?= =?utf-8?B?NGlPM29jVTl4UEw0YW5UblFzeTYrLytzQ1lsSGd3UzJFN2U0cWNLK1l5VWlE?= =?utf-8?B?SXgybll3T0ZkSm1tcFJoaktxbGVlSDBtMm9QaW5wTzJaeGcyQlVpUm90b0cr?= =?utf-8?B?SlUyZEN2ZmFmNVR3UXJJZWt0L01aeTFRVUxxM0JXa1dmRnE4Q3h5NUNqdWRp?= =?utf-8?B?cHdsT1ZJeXhoZ2xnWmJadE80Z3E4NmhKQjN5M2pKY1ltcHk4V3AvTWdNYTlm?= =?utf-8?B?WlU0eXI4Z0p3L3pFM3lNc1gxdE5hOUFjdFBITk1XcVkwajFZTUllTFVhRDRl?= =?utf-8?B?WXgwWDBIUzIzY1FKK1pjWkwvNkdmbUltVWdVeFdxUWs1M3N0eXF2Y21uTG92?= =?utf-8?B?ekVnbnRDMzJ5eFFHWGtGNkJNY0FHNWQzZ0RpdGo3UXRsMVg4cWF3cUhKa1lZ?= =?utf-8?Q?Rkkhlld0OAgxpajQzAr9KDU=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f6b32ab1-00d8-4c09-c005-08d9fb734f70 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2022 11:04:52.4892 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WfgawCdk0TC29Bl55RYH0qom8y6sjTBBT7af1oDgCSDusigary3dW/+8VQtEzTdCON0F1MJ29/YPsQlqqBYGcQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8095 1: use fake read_tsc() 2: add CF-clobber annotations Jan From xen-devel-bounces@lists.xenproject.org Tue Mar 01 11:05:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 11:05:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281245.479491 (Exim 4.92) (envelope-from ) id 1nP0KH-0005sA-Pq; Tue, 01 Mar 2022 11:05:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281245.479491; Tue, 01 Mar 2022 11:05:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP0KH-0005s3-MR; Tue, 01 Mar 2022 11:05:53 +0000 Received: by outflank-mailman (input) for mailman id 281245; Tue, 01 Mar 2022 11:05:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP0KG-0005rB-DZ for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 11:05:52 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8e601d69-994f-11ec-8539-5f4723681683; Tue, 01 Mar 2022 12:05:51 +0100 (CET) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-am5eur02lp2059.outbound.protection.outlook.com [104.47.4.59]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-23-bIPFnNKYN3uSy7cJjYTBhA-2; Tue, 01 Mar 2022 12:05:49 +0100 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by PAXPR04MB8095.eurprd04.prod.outlook.com (2603:10a6:102:1c6::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.26; Tue, 1 Mar 2022 11:05:49 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.027; Tue, 1 Mar 2022 11:05:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8e601d69-994f-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1646132751; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yVhh9raFqY1k1mmmz8RZiJfkzqL7jHEKprsJSfJ+qW8=; b=HLdOUkx+gebQi2TvLwqlywxBsKktvMc9Hv5XBYqScvWGUQ1Xxg8LlJ6feFTdd9yfucTuLL 7u0r93VUqP88e9Mfwtm8nX08mjHoIxgM1KVEUeZThtDP5gpRnC75NLjWfQfX814LE6XCln pL3JUez3K6cCvowuK+9IxH71toaBa+M= X-MC-Unique: bIPFnNKYN3uSy7cJjYTBhA-2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZRdmnOnjSJ2Uvo98Tm4jPYGnspuBqOptTwVzWy63A5oEvqHELWgEHrrBuhhH26TOBO5dYNO56E6XVoW1n+l4Ovkp93471Y7WgMtI2vlYfySZOk2oZiQSZtohFjNMvxZYUhXiTaGI9AeZ5EqQeowoAzhX5TAm8/eax3C0pq3QRPGULmBS2okUxcZD0/pFZjjCPUK54HnMkNF0ABwMqYsA4Gizai7yPoACVHYE2VpyCpwpsZXsAmlZn43Tg2EDeXgXhasKFQUl4x0J+HsKvSHLWHCpIuQC0HpTVdBf/Cu6cvubKZxMPEds8hlSWBbLmhIRWU5HsvUpJV8ULfQlsTwVDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yVhh9raFqY1k1mmmz8RZiJfkzqL7jHEKprsJSfJ+qW8=; b=jWCBziFs9DYO4cOpBFWd56R5GdRyQDRW0Ktv1A7qpK25XnhBlHOPKPbo6GKtL0giyHF6jjVmKngksQnWxvS+mOY1ocbO7j39TKlihvpQDs23SKJkW3RAFAW/gJORS4iW4umlQ+MDLF5yEjBvGOYWks+VoOEhIODaOJTPCssLnIqt8WZP3p/2q+/PLG8wnnnDZa84KvMwk7CDmTN3WfAehU7b72mZorgSxwAN8RZb9WsqDj2CRxydXwx7y3Bsrp4tjx3xc+z8Bafkc43K5oj5tbvxMs41pKid5EN/Sdf2iPQ2ZGuGTHwIZEssPeBrJicOg46O7yaDlCOeIbbMS1dNSw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 1 Mar 2022 12:05:47 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: [PATCH 1/2] x86/time: use fake read_tsc() Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <77675e7f-2a7e-f517-4aba-e20774c8bfe5@suse.com> In-Reply-To: <77675e7f-2a7e-f517-4aba-e20774c8bfe5@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0272.eurprd06.prod.outlook.com (2603:10a6:20b:45a::10) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 69dc9f71-5cd7-4d6d-2022-08d9fb73710f X-MS-TrafficTypeDiagnostic: PAXPR04MB8095:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Uh62QAnIYPkzL7Nagz1kpvhoFB1YtFwNl/H03ifJNkxRi54G5YE+Z/Lz4UQSAAdg3qmemxbPx8QtScuMlB0fo0TVbCYw53JzrmDDnuVT2syHUvpRfEhYZ2zRWaYc4UmUgQfdChk2ZH/ZLxKO3ibbs11lKacIRSeI8cGR4aWnQxe4GaH10eT32tKqeIC1g7Zs46uD7oVLnz6aQI5FrcmOzDAG/xy4KzqKkCqZltDUWwhVvDbsmhTwz2Ha0sEza/TCa9l1OhpQd3rwl+cjUuNOCYqTdLdGdghsGbxfuLvNDV6dHy/v9b530EMP93CuvzXLoZla1DkViBpyDkTTZbQQbCY5rWpsEqHf5+6TdIAlyKgHV9kpKm/B2tPHA5/QXwaGrAv3ZysNMfTeiR5t8B0tr52RTOQ/UXbLNqgTlH65GAP9g5EErJAfhhcSaO1C+cAw2L9syWFOLWaP9OQxEwe/e76jo4NZIYS9FLqXV6S0/4ggPLqS0EVh6SU/O8A6LGAdTtLYNSt5SqJkovkPxIsOO5ZjHsAizp7u/7IavC0xs2XoI75OcOUXE/pUYNnFuGm28Roiyv3s0l/GoUvVkfX/KLVxYFwR6JW7ecP6WCexyybPtfSWY/Km9rj/ZuU8h6YVbZgUA5mWPMo4kGkDMEkTneRmTUfKlRtvz9sX/KwL7mID+nqpftaRvNnvcFAag9EPT2gswAJRKOE4U40D3uXJYjrYbBbiBoDGGpMeWiTT/Xk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(5660300002)(31696002)(86362001)(6512007)(66476007)(66556008)(8936002)(83380400001)(316002)(38100700002)(4326008)(6916009)(54906003)(66946007)(508600001)(6486002)(8676002)(2906002)(2616005)(186003)(31686004)(26005)(6506007)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OWk0WXdoV1pSdi9vNFFKNjF0a2xDYVFXKzVNQ1N2T0xWeDJIOWRVN0hPcXI2?= =?utf-8?B?OVBGWk96NnZ0cEQxS3k4K3ovb1Yxd3JrSDZnSWQrS2hQVFlydklXanAyNDdl?= =?utf-8?B?RVJkdDd3RHJKTmpiQ29jRlp0ZEdKeTF5M2RoTDlXU2IwRG54ZVNLazFMdkkr?= =?utf-8?B?NWZ6OVYrcUQyZjgvVmFFU1FRN3FMZFViVURiZC9rZkFEeGN4OXNBL2s2L1B0?= =?utf-8?B?VFlaYWp0YTN6aFhPdW5xQVBNRWZiWkxHOE1CMEpoUGE1RFJPeHIyN0RKSjZz?= =?utf-8?B?bGhrdjQrZmV6WThtcHQ2VHVGS2F3OHdrZ1gwYy9ZbGZkS2dXdmlQckFyWWlZ?= =?utf-8?B?SFNjNDFsMElhSTI0clZkRXdXSWJBdStTcjlFdWpKQ2hHRXg1WngyeVNNOFc4?= =?utf-8?B?ZVgxZjlaVkhQU3luUnp5R1VSWjN2eXFnQjhoMk9UL01odmF5eW1nRWl6N004?= =?utf-8?B?N296d3o5bFpXZWc2R0FNa1NrWVhMNThrNU5Vcnl3Y1JzOFg1a3ZMM2YzZlhJ?= =?utf-8?B?TU9zZVpGS1VMZUJlVWZFeHRPUjJDckMwaFBnMlplOXVCaFdkOGI1RjJ5SkZZ?= =?utf-8?B?U090MTlWdTNlSHpFNGg1ZmY5SDk0YTVFYXhkWUNCaXhTeWpmdWdwSjJsRy9p?= =?utf-8?B?S3M2c2UvV2FUeUk3V3RZMmc0eUkrSHdaQzZGaEcrTDNDNUo0QnJ1UXRibXV6?= =?utf-8?B?UE4rd1NyR3A2amNuZUxON3Z1dHJtUjZMY1A5dytjVkxVcC9zRzZwVmMxbmRt?= =?utf-8?B?ZG1LV3U1VHp1dDVQbnhjRFhJMHVaWFBrYTdCZG5TK01XcTZMTWxZdDJUUnBW?= =?utf-8?B?aTBySFhrS0tPWTNqZ0hTTHJsTWJsQ01iUERHYldjVFcwekpiM0ovcU1uOExv?= =?utf-8?B?ZGlOQm5OYVo3LzJIM05LeWtGN2ltMFhaL2hpVnFUVDlHQ1pkYW9TNVplWGhI?= =?utf-8?B?Q09RVWttUHdUckRTNlRQNXRJTzZldHBxbFIyNWRvZngyYkQ3MG1Yd2RzVjBB?= =?utf-8?B?M2ZsZ2l6TXVoR2pWR2cwUS9hcEtqSjR1MFlHSWpaMFQwNTNGVElJbVdhbEov?= =?utf-8?B?ZStHUWRGeHB0emRvUTNKRTU1dnhRNm9ZRHc5UFFMTDEyZnNJNDV3c3Yyc2F1?= =?utf-8?B?dTJJaWY0d2dXUCt5eGNSMi8vcDVjYmo1TFZic0ZJNElaWmpSMTlvTHRjZXFK?= =?utf-8?B?akdKM3l6eGMveDNrbVd3b2dvUzR4eExSNDhjaUlSbnBIUjV1elR0KzhaSnVB?= =?utf-8?B?U05JNWUvYjJPUDQ0OW8wRC83alZWb01QN1VMa1BTenh3M3A2S3Zsb1VURjZv?= =?utf-8?B?YlYySUlqMmk3ME93S21jU1M0SDVYNDdIaHR0eXdNejRzbkxGcndFeTBKZm9M?= =?utf-8?B?UnM4WTZBbFNYOExqV1BtV20vUVA0NnBxV3hYTGRicjhWUTZDR1BYZGZJWTU3?= =?utf-8?B?clJzQTdpOWtUcUJSaXZzU09ObHhRSVdWV2QrWTU1R2Izd1EycFFQZFJjeHda?= =?utf-8?B?TUR4cS9hdlBSelgzWmJXczNoS0p3bDc0TGZHV0ppVmFRR2JjYUJGNU9idGsy?= =?utf-8?B?a1NtaEFxZlRJaTBCM0FxSU0vOHhjSkNnTlpFY3Ezcll1cEV4M2ZMMTBhU3c0?= =?utf-8?B?dFZ3Vjdrd2Q2eUQ3cmpRaGl6TGhLSnBCQ1hCcHNWbnJydnNEb0kzY1pBV0xI?= =?utf-8?B?dHF0UWYvL0hQdngrU2QrWGlwRWp3RUNqc04xWFFvV25GUDdsQmpOTnV3b1JU?= =?utf-8?B?cmh5Um02NTFoVFN2Nisrbi9iRWJ4alYwdUpEWVZIWFVzRzcrRmlkSHc3Ympy?= =?utf-8?B?cmV3R3RybTl0ZmhjenRCckFpYmY4dCtYQllXckk3ZE03NnR2VXgybjdTQXdx?= =?utf-8?B?cmxpUWtEeUJUbkdoNm96d29lYVZjdkRveDVIVFJyNCt1QVBLTy92Sk1UN0lX?= =?utf-8?B?cXBGVWtrZWNMRGJxanhKbGVFY3Uxb2JxNXJnakNqWTNWcmw0MGFnaGUyYzZL?= =?utf-8?B?OVROM0Z0THNJa0ZxNUJBZEp4MVQ0d3U2MzNFNTZoanUvSGl1eFdKb2p6MExW?= =?utf-8?B?K2ptZkJZY2pRMFZpaXZpNXlGcituQTBoNTZSYU12UWtGZ1d0V3pCK0tyRUhw?= =?utf-8?B?VVJlZG5DR09oUUUwaDJsQzRVV1p2bFk2LzVWN2szVThBakdpd2NNOVdBKy9q?= =?utf-8?Q?97Bp5H8YQ2tStU3oeKBZw4U=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 69dc9f71-5cd7-4d6d-2022-08d9fb73710f X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2022 11:05:48.7825 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CeUt1EXn8FJ9jcllL9zZFAqp9084DVoxGU2H/9W4iefjzdD4KnNnVp7T6BAKFeWZivSD9auPMGQE+xkmUzP0CA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8095 Go a step further than bed9ae54df44 ("x86/time: switch platform timer hooks to altcall") did and eliminate the "real" read_tsc() altogether: It's not used except in pointer comparisons, and hence it looks overall more safe to simply poison plt_tsc's read_counter hook. Signed-off-by: Jan Beulich --- I wasn't really sure whether it would be better to use simply void * for the type of the expression, resulting in an undesirable data -> function pointer conversion, but making it impossible to mistakenly try and call the (fake) function directly. --- a/xen/arch/x86/time.c +++ b/xen/arch/x86/time.c @@ -585,10 +585,12 @@ static s64 __init cf_check init_tsc(stru return ret; } -static uint64_t __init cf_check read_tsc(void) -{ - return rdtsc_ordered(); -} +/* + * plt_tsc's read_counter hook is (and should not be) invoked via the struct + * field. To avoid carrying an unused, indirectly reachable function, poison + * the field with an easily identifiable non-canonical pointer. + */ +#define read_tsc ((uint64_t(*)(void))0x75C75C75C75C75C0ul) static struct platform_timesource __initdata plt_tsc = { From xen-devel-bounces@lists.xenproject.org Tue Mar 01 11:06:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 11:06:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281253.479502 (Exim 4.92) (envelope-from ) id 1nP0L1-0006dG-3g; Tue, 01 Mar 2022 11:06:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281253.479502; Tue, 01 Mar 2022 11:06:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP0L1-0006d5-0T; Tue, 01 Mar 2022 11:06:39 +0000 Received: by outflank-mailman (input) for mailman id 281253; Tue, 01 Mar 2022 11:06:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP0L0-0006HM-4A for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 11:06:38 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a9c78dd7-994f-11ec-8eba-a37418f5ba1a; Tue, 01 Mar 2022 12:06:37 +0100 (CET) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05lp2176.outbound.protection.outlook.com [104.47.17.176]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-30-64P3WOMhN2WodCFz9b4a_g-1; Tue, 01 Mar 2022 12:06:36 +0100 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by PAXPR04MB8095.eurprd04.prod.outlook.com (2603:10a6:102:1c6::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.26; Tue, 1 Mar 2022 11:06:35 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.027; Tue, 1 Mar 2022 11:06:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a9c78dd7-994f-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1646132797; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7Hcjv5yq81hzSD4vfgXUo4NPyGvjN63yGcHqxJqVJiY=; b=BbRJWy+XxuD5k03LhPXhyTru08aIU04K7RjO8+8nvvgy6Z0NhqeYaxFLsJbh2jKYvKYH10 +wATSF3+Omb6Lgg80+WME0Y7YcOB8CVquf5XdItemWVwWNNFBVS4tIg2Dg//LHcPs0N5Hx M/t/5/O/EpzazG1Wgu9AXYje52sQr0w= X-MC-Unique: 64P3WOMhN2WodCFz9b4a_g-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XoYDXQIh6HdPVxe+FEDuGpz8xMLiqZzSV6fkP+UPJ+Ok1/PTKfjN/ocImxVrNI9eImI0iPYxYfqs6V244N1FuhLmKvtBNjyfuFkBj+h5RzS9xl8tLwzyy5B6S+7PK3re+0aHd7zEayMDKbfLJr52h01abo1B7znC7bX0ZmASA4lD4aNGkC5IsLkUfhFcVhQokxVC1wQRkwUFzCEoWSQ1odXON4CbCjQ+W75FEC2fmDwMhgdSx9XajGOsddfWCyBs8d7yzCn6H8iZ/hl2f1DGk315+XoqQak7HmLfjCM2MKXesEdHEUq5R7Bba1XBUjaEgTSOW7Z64XvKstzP+cHUBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7Hcjv5yq81hzSD4vfgXUo4NPyGvjN63yGcHqxJqVJiY=; b=fuRvz87fIqhfNko060phsYx6S1OJVgl4BX08S8RPneS2gvQYhT+kGwL4C7RccNxdpYLfAqx9Xmpq3JjXMYmm5Zsm+svkIrnMlTDomYBOOoHu/Z1kgvav52AzenfHQXqf5MJpGtqIh0V8dryHw21PU7nVZiZn+9YydadRTJbvvVQoPJwyUD9+ss0h4nmp/DVxcXOlHv2Wa9hB0RmuUBIGbaPfZi2CxpkoCYdwaSoMh2k9Tb3+T1mWD3nFF6iVnMENCKVwkc6NIgNTpG2uy/K+SZIBxCs+qo3T7IhsPpdqLYzdX6edu50VxCJA/9J6JOEMrmf6hWMtpI0ZvOuxwbwGyQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <61bbf544-74ac-b698-425a-d1db80acab43@suse.com> Date: Tue, 1 Mar 2022 12:06:33 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: [PATCH 2/2] x86/time: add CF-clobber annotations Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <77675e7f-2a7e-f517-4aba-e20774c8bfe5@suse.com> In-Reply-To: <77675e7f-2a7e-f517-4aba-e20774c8bfe5@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6P194CA0024.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:90::37) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a595ae01-3f95-4936-90b3-08d9fb738cb0 X-MS-TrafficTypeDiagnostic: PAXPR04MB8095:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8bIr4f7BfXW8zS8WBQy9sw8bXKYzfv8zssvTh0yvT1fgJGd1E3Cup7RGVvXw7AbT+08WrthkGvPM1wFep+aUVrHLxsIvl7chNRB0VoP9cwVULDsh85O0kp0AXndLANayqgAj8l/O2R2PBgDDOg748SI+v8faBjkeGScduc/5npIY/T76Z/vXcxGSDFXj/Ok9oEmVNQXxTgMIWDHAM/9u95hOuauU5VmJE8NsI72MYb+ZZCneJWMoEiUhsnuaNqYnuuiZNHbDYf2OylwwDY5XFFBsxu49I2oY84jmx5hWdAO5Mez3q8eYVl218nTKOO2ZsZOvupd4DbyR/z8iWQn/b6q+JDBz17TOVrcD7gZB76ERIoSGrZGKCkq/gr7hFoub1AKatECC1gYXi0hSNZ1feOHA+0JUSyirkRpPbMKWxCO1C/E1hYsAztDO9QDG2uhAr7nvHKjXZ1gX7GNDyT4hAcr1Xy2CqSmZPVotuToo93kW5hk9+w3WA6hn2SGticOQSgMWwLV59GwVqgwzdjyvregSelagmH34ohEu6JhXM9tKKHW3zNeDeo6IhkE0NkUMvvntJxPlNsA54u8d6/pjOKJGOL9q09Gkeq9tnAJ8gbLVjpheNMq5zgQ2rNX337u6n/pzEXWV/RmaFzhFJiVtOqmvvuskY5naREh0Fy0+53sJk/jki4vqC/9aq7S9g3msUUpR8uefJkE7WH6s15dCGfbiGL+yFrs9kbGZnXifyWR7LJquD2XPtJjatkCekgwW X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(5660300002)(31696002)(86362001)(6512007)(66476007)(66556008)(8936002)(83380400001)(316002)(38100700002)(4326008)(6916009)(54906003)(66946007)(508600001)(6486002)(8676002)(2906002)(2616005)(186003)(31686004)(26005)(6506007)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a2ZpcEIyWDR0Q3cyNVFqRUFnN2VtdVAyb2xLOG92a1hEVnI1SGpRYWhZK3pV?= =?utf-8?B?QUlwQTYvOWgwZkt1aktxZTU5U0JYVUpObUltUnRlSDJPaEkvWnh6bCtnUFVu?= =?utf-8?B?WCs1Nkd5TU9EeC9MSFJCY09DODBUNE03OTg0ZHZvTGZiODNDNnJwV3NKMytv?= =?utf-8?B?MGNxOUsrWlJ0bFRhTGN3ZTRudVJiSHhoVERtZ0paVGRuOGZPekZyaS80ajl1?= =?utf-8?B?akFTOFNwOUtldTg3bEJmZnVubk5aVE5LV0R5UEFDVzZMc2Vsc1cvM1pkN1Z6?= =?utf-8?B?blZMOTVsRVQ5Z2pLYlFlNFVXaXo2emJwSVhIVUEwOTdpODdhMHJDWk9qT082?= =?utf-8?B?bFVibDdPVVlSeVBSUUkyYnlvWDdybzRVRzNpRk1vajNRekRrNUlDdjlKc01y?= =?utf-8?B?bTJDT1FVTWxYa0huMVBFTHBJMnkwZ2liajlnVFR3T2ZHNzd5MjZpMVZDSTJP?= =?utf-8?B?SlJtN2xXREd1OENxVG9UeTFSL3I1SVhxWEFiakduZHFyMlhoUnZnQytSeG9v?= =?utf-8?B?RVdMN0ZxTXdZTzJWU2tXTW1pRjJLcnR1UEs2ZjFLVUE5V0oxVzBGYzdJMHFi?= =?utf-8?B?UWhYbko2T1U2NkJyMHRQamJrV0lsckRFcFZXNm1TMzRtSnVKOHg0ZE5DOWJM?= =?utf-8?B?Z0VoS1UzU3lORW5MMG80ZGNqQ0FGelhRUGVhWHBKaDF5ZEFOaXZ0T1lKOTA0?= =?utf-8?B?SkFmRERlQ0l1blFiYmRnVTJxUlJMSVVRWk93eGsxVU5ZZGRUbksxQTBXYmtj?= =?utf-8?B?UENJRndNM2pYVEg2OVl5NkRRc01PeFNlc1pNTll5ZXZSckVJWHpMRXAwckRL?= =?utf-8?B?cmV0c2J0cTFVZzl5WVo3MTU0WjdNKzNkdlUwWkltYlFVNm5HVVVzbEpFTkUy?= =?utf-8?B?Ull0NnV3eWNCYWxBS3ZYMURVL3VBTzYxUklFL2J3N2RrOWY2KzdVUHNIaXho?= =?utf-8?B?aWNxMkh2Q0J2MG1KNDVnVGtqSlZ6YzdsRlFvU3UrbXg1alZZSndLUnVMcUNi?= =?utf-8?B?THlVVk04Vk1Pa1d1NWhZc2lKTFZiNFNId09jRmEvOXMwL3VORzlvcVJQK2Zy?= =?utf-8?B?cnpjWHI5TGJiWWVNNzRIdFlGL1psME1GM1VHTXBPeTczZE9hZXVLREdJTEpn?= =?utf-8?B?V3hHbFlSaFNnWHQwQkVIeFdzRFZ3V0JpeDh3OEZIL0ZpNUV6SHVPeHJMaXVr?= =?utf-8?B?SzdBSGp1U1kxdUZ1dTBKVTRTTlRlR0RuUzhZU3hiNlNtdUVNb09lQk1KdDRh?= =?utf-8?B?ZGh6a212TUtQdmFyZlpwallsRUUrTHNBdUptSXV3eit6ZFB3Z0Z1dkhvN1Vp?= =?utf-8?B?SngxTHFmVHlMNWV2eDQ4clFTVlFOREdLWFJScTBSejdpQUtRYWFiYVMxckZE?= =?utf-8?B?QlVPMm0yeVd3U085am1oT1RhZ2VXeSt6Rld2TjA1enI3ZXB1a2xzaXRYYThH?= =?utf-8?B?OFl2VDM2VVQrNXk2aTdsZXlCdE9TcTdXTlkvREh5cDIrc2V1aXl0dUtwcUxq?= =?utf-8?B?SGFzN3dKT2F5ZDQxQlg4TzFEYjllamZKVWZrZDMrdnBOeEtRa3d1Z0ZjcVhm?= =?utf-8?B?QnAwOUk4WjNTUlVIWHhZVmRTU2ZpSjRJVlcxT3lFU25aR2p4Sk1ZYzFqcXJH?= =?utf-8?B?a0lnZ2VWTzdHT2Q4R0dvdkNWa1FKNWhmenZzZlI2akRONXFlMzNFSkFmVzFm?= =?utf-8?B?bzVoWjdobzgwK1RiK25TY1VxZDY0dmtpeU9iMTg2VjhER3NraUpXYUFJZHRO?= =?utf-8?B?Y05xSTBuNHlka0Q5OGMzTVhYYXVNTUtuTXFWWUxiWCs0dEt0b2RWOUdIby9p?= =?utf-8?B?UHVDVFlGZXcwZUJ5Mk1xMit1UlYvcS9jU1ZzdFFlM2pieVZtK2RpaDF1aEJr?= =?utf-8?B?UFQwUDhvcDBmQ0o0V3pLSTJleUF6SThrdWRPbXZ1ZWlBMmZNZ0NHSTJ3bjVC?= =?utf-8?B?ZERTc2pjZm1mNUZJeEtQdDBFeFJ1SzdtWXJXMStBeTZBTzlURXhWYWdKazJa?= =?utf-8?B?bVlKUGJ3RE1qODhsYUJESllKeFJPa2pvdzBNRWtpMmZVTzQzWU5ZY1p5OGhN?= =?utf-8?B?VGg0OXRPWXI0dE54Y00xQXB6N0RqMXV3ektYdUw2Q0JNcWkwWFVHQWk2Y25t?= =?utf-8?B?THdKUkNSek00em9GRmt0OUQwRjhwd2RxNlhtZGpaNGxENi9aTXVESWlxd1U2?= =?utf-8?Q?uQmSpnVlc+8M/FT9lw2Gy5Q=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a595ae01-3f95-4936-90b3-08d9fb738cb0 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2022 11:06:35.1078 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pyRoRVU43jPHoeLfyRyqCSiFmtTG2dwJ+cSbAKveiE8YqwI7GAdfN7rTyp4qou2AcwMkYVpRdTlqDgtPtUdFbQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8095 With bed9ae54df44 ("x86/time: switch platform timer hooks to altcall") in place we can further arrange for ENDBR removal from the functions no longer subject to indirect calls. Note that plt_tsc is left untouched, for not holding any pointer eligible for ENDBR removal. Signed-off-by: Jan Beulich --- I did consider converting most of the plt_* to const (plt_hpet and plt_pmtimer cannot be converted), but this would entail quite a few further changes. --- a/xen/arch/x86/time.c +++ b/xen/arch/x86/time.c @@ -375,7 +375,7 @@ static void cf_check resume_pit(struct p outb(0, PIT_CH2); /* MSB of count */ } -static struct platform_timesource __initdata plt_pit = +static struct platform_timesource __initdata_cf_clobber plt_pit = { .id = "pit", .name = "PIT", @@ -483,7 +483,7 @@ static void cf_check resume_hpet(struct hpet_resume(NULL); } -static struct platform_timesource __initdata plt_hpet = +static struct platform_timesource __initdata_cf_clobber plt_hpet = { .id = "hpet", .name = "HPET", @@ -528,7 +528,7 @@ static s64 __init cf_check init_pmtimer( return adjust_elapsed(rdtsc_ordered() - start, elapsed, target); } -static struct platform_timesource __initdata plt_pmtimer = +static struct platform_timesource __initdata_cf_clobber plt_pmtimer = { .id = "acpi", .name = "ACPI PM Timer", @@ -683,7 +683,7 @@ static void cf_check resume_xen_timer(st write_atomic(&xen_timer_last, 0); } -static struct platform_timesource __initdata plt_xen_timer = +static struct platform_timesource __initdata_cf_clobber plt_xen_timer = { .id = "xen", .name = "XEN PV CLOCK", @@ -780,7 +780,7 @@ static uint64_t cf_check read_hyperv_tim return hv_scale_tsc(tsc, scale, offset); } -static struct platform_timesource __initdata plt_hyperv_timer = +static struct platform_timesource __initdata_cf_clobber plt_hyperv_timer = { .id = "hyperv", .name = "HYPER-V REFERENCE TSC", From xen-devel-bounces@lists.xenproject.org Tue Mar 01 11:36:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 11:36:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281263.479513 (Exim 4.92) (envelope-from ) id 1nP0nf-0001qY-Kh; Tue, 01 Mar 2022 11:36:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281263.479513; Tue, 01 Mar 2022 11:36:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP0nf-0001qR-HK; Tue, 01 Mar 2022 11:36:15 +0000 Received: by outflank-mailman (input) for mailman id 281263; Tue, 01 Mar 2022 11:36:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP0ne-0001qL-8M for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 11:36:14 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cbd7b545-9953-11ec-8539-5f4723681683; Tue, 01 Mar 2022 12:36:12 +0100 (CET) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05lp2107.outbound.protection.outlook.com [104.47.17.107]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-20-mvBW0GLBNK2bXaF868IcLw-2; Tue, 01 Mar 2022 12:36:11 +0100 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by PR3PR04MB7356.eurprd04.prod.outlook.com (2603:10a6:102:8d::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.25; Tue, 1 Mar 2022 11:36:10 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.027; Tue, 1 Mar 2022 11:36:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cbd7b545-9953-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1646134572; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=1CGuQnavDaQzxl8KQfCDTDU2TjGe6+yb2XeXhfdCsjI=; b=RxwI8dNwrcND+MjbPBnCnHH8qZBoeZ3B+bxeNHT3bUUI8kZc82Vj9Ymnd3EMhbmGOZAiqn ja/ilHw8hCClooNTURM0UcRVIFdK2BmhK4mAcImxZ79u15qJo3WPTZ1oR905JmyE34tDoA 5euntlp97WylkkwKWcu8wc+f0skA5l8= X-MC-Unique: mvBW0GLBNK2bXaF868IcLw-2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mzq7KSX76EZzT/aHLQyWd9FdkdzscqKe0mKOBFj60LCIJuxTcV9lM2o2VBmC+K6R60RNGcfL96KE7uwHsnRtcAsA3nk4GsttLpQcojB1BtLDz7uBuEGrBcqH5PPTZ3SLoAC9oKsI9KknBOs9WbZsBMfZE3a9IM6VwZPpM36RlqYb4n3wOCaxYDl+MuBfSq2iEa6SV3GstcsmtHto2kvk7oLHGfHb6XGFd4E0aMb0Fqofr2j31FFmGvYXlwZ4Vj7q2hA51k/b6jebM98uXcrnrPRGEsMzcs7zMeJq7Mjx1NGurdHRQeHo/Yv3fRINGX+NY7qehHobBf3H54Ww7YHcvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1CGuQnavDaQzxl8KQfCDTDU2TjGe6+yb2XeXhfdCsjI=; b=c4vXLvOfnq5ne9vobrOCKSGq3Ddsf7S1hR67isvr6sCti+GYjlRv8d0IyDnzuk3CJO+mdIBdjSXUXCFNaIkTOW+VfGjUABKtoDzDjuUWVU2+Vv0sCCzRUSnDgHZ0u4CvrXBZKKOMlfQK3j0XA6g57MGFV0Yhk354j+kWZE37uwUKBIS/XjlbJKB5L5zYNbELos2h4ETpxUIQw0TzDyg2mLpV3Tpiiwc9Q6eEoQvWRBA3KOuEJrqwD0ksDoyn7koo6gJIYsvyCA7866odkSo/QoQ8jbw0UPDKL0Je/3na10rnJglw3WcwK2ZPTATcq12l9i3fg67C5evUNPD5bPI59g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <0e3594ff-c637-46f2-bc95-7a26b5471b86@suse.com> Date: Tue, 1 Mar 2022 12:36:08 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= From: Jan Beulich Subject: [PATCH] x86/altcall: silence undue warning Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR0301CA0016.eurprd03.prod.outlook.com (2603:10a6:20b:468::34) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ac26bf4d-58be-45ce-2a90-08d9fb77aea7 X-MS-TrafficTypeDiagnostic: PR3PR04MB7356:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8dsD3V15LU1DxfhZFIAepuWGR+CsqKO36Smh00aAYJcQQs0nR0lQAvGJ1umOwXWhEICpdb+a2LO/heaVe0vgCzHh9lG/fbIiV/kIba8ZVxawUOocdYAItP1qu/xwtaa2zdPRluOOnUZoIaqR8VE7CpzTjXq6PuD1hZ8Db7Xutw/nuGfy34IezjYm4MrhcmqjKEXLhwnL2ChTFiUQmPpvawh+CjqWDTLab3DISEpAKa+LmsMAZaRK35HovxJjysf3rsmNKJboaie+oB6/Asyg7b5dDnIzmsHLnOFW+fvX5NAqoQDzZXEUrywjdq0wQBDuTwezaxpyMWrnC4Co3DZOGSQff4WS9r+8j640IXTXXObo/da47S824+HsAYcYfQj07JCL3vaE/xaLwNiSKQXW2hdzUHt1S6VLUcxaa/DBMyDMDE3Eon3ov5HBPPFcaXQfHVOCmPyWOUaB+h7TPL6Go1/nVpg2Up2fv2JJqmf+QZtoEYBWpnKU6xKOBL/NvZMszH3SlM879F7pnh6+Rwt5XxY0KRaFsiFw87/La7URs2hTcZvEE24jpyBF9/pc+auh21T7jsc1vgSa/A7KRGzeupp7KGTjIq2goPa7TJqaycStryxmGXkZwCHJ8I16h7ZRegLLEVlG7SzvxkI0VhIYWXH1QWH0lKtLbTtc7hvftQhC+MxycbwKb+XepGRDjPXqCpbTHXZMR8eXM5Av8kRRNx0jXq37OKw65uLZi4nYEmM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(31696002)(8936002)(86362001)(6916009)(54906003)(4326008)(8676002)(6506007)(36756003)(66556008)(66946007)(66476007)(38100700002)(26005)(186003)(316002)(83380400001)(6512007)(5660300002)(2906002)(4744005)(2616005)(6486002)(508600001)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c20rc2p5a2FtRVZQSlBKMlBIU2tCVE41QWpvNHNtSWFvTWRabkdRQkZjWEVm?= =?utf-8?B?VStpL0xhcWFjbkRWNmk0OTE2bkozL1VqTE5MRkxNM3k2cFBJQ0tDdHoveDlF?= =?utf-8?B?b3hzN2xCeUV1dDdEOWMwWVhKNzhBazNPNk1Nb3hlaXpNcVJoc09MeVpBNUtq?= =?utf-8?B?MGFzTXpjNE8rOGFmVWErWnJtVGNwb3NzZXE4Q0trRnpZWTAxeVRXaFdTVm1N?= =?utf-8?B?bUN0b2VRZWdZK011dnlXY01IR3dqcjVIMGFvMFVPOG93dkd1REZOLytsak5Q?= =?utf-8?B?UDFSM1d6QkV6NU9aK1VHckRBS3hHYkNLOVFEY1IxenNXT1I5K2k3OStkVjQ4?= =?utf-8?B?N2tSN0xEU1dYb3IvOEtuY3paV0F0M3B0SnljYVBQVm1SYUNVVnpUeFBxWFY5?= =?utf-8?B?OXJoNG1CL2MzR2VFUUh1UkJjMHdTdUtOd25ubFBnQUtnOGdlT1l3TzlOTmF3?= =?utf-8?B?RVV2R0grUkkrTkdoV0tCcGp6K2l0R1ZMNGNvWUJDMDhjZnRjZm1qZEI2ency?= =?utf-8?B?eGw4eTY2Y1RmcnBPMDc2WjBFOEs5VnA2Wk0vb2psd2Q0SzBJRDlJZUV5S1RJ?= =?utf-8?B?WE9YMFovZ2tMRmZyeTR0YjNrVCtEVjVwN1ZEb1VYRjFPdXdrQTgxWWk0aUIv?= =?utf-8?B?UXovRkQ5K0lnam50Q2swZURXNGxQOE5vVHlUK0JRVmhXNXlTTjgybmJmV1h3?= =?utf-8?B?clVxMUdQQWtTVGJGZk84Nk9DdzlYTEFZZmN5cnlXblR3SXVQUGw2QTJuTXhm?= =?utf-8?B?NjVIUVNKT1gxMktRblhtZElEQU1iMEVzNkkxcFcwTkpRdHptNGRtNWxaYUd2?= =?utf-8?B?R0Y4MUxHbk9Db0lpa3F4K2dRQ29qWVBsRDkvTFZob1dVYzBsWGRnb29rR29O?= =?utf-8?B?ZEEwQm9EQ0tYdDgvWjNMZkVOOFVCcTN0VS8zTllEcGdnWjY0ZVlXajAzaHBX?= =?utf-8?B?Wm9OZ0IvQWV4UXR5eUVxck1odFRsdFdKR1ZJWm1oK09xV0tVRVBUOGtSRmtS?= =?utf-8?B?UmxrNHV2SUpwUzM0a1FmSklXa1p5NlkvU0NLVWJ0NmU3Ti9kKzAwNytvQUpC?= =?utf-8?B?UjRWc3daVUxHdnc5WlhTNmhURmlLZEx4aFVvdXh2UHBYWW1IOUNTY1lSa01Y?= =?utf-8?B?MzNDZExWMXRhWE9Td3RobVJpd2ZITDJNZ1pZdVFIeFp6SDROZ05oNVNYZUdz?= =?utf-8?B?MDUvQVJPYld0dUhhMVZoWGVqdVY2dUNiRVA1RllWME1DNnBoMEFUU1hrczli?= =?utf-8?B?YXEwNWxNbW51alpYa0tzNlcxbTNKTjF0RnJTT0VHZ1d4TlJaNDdCdnRBRGdU?= =?utf-8?B?VDFCN2RLcUpqYU5KRFJFd0ZjTlRGYk5UYS9ISENWZWlMaFFONnY2bmdYeHJT?= =?utf-8?B?aDVjdlp2OHZEYTlPcElkYkMvOElRTFpwR0tka1k1YVdmMlBMMWtCa3pZTmM0?= =?utf-8?B?cGM2U25CY0hjZEpJcEl0OTg2czNXZ0xIaHdTSDFmMXFCUDhIMjVLVmthWnhs?= =?utf-8?B?ZGNsOFduQXU3K2VRWnppTHBHYmJnNURIU0NjMFllMzE5QVNiVDQvSSt6YzBL?= =?utf-8?B?S1FNV2V6KzJFVml1ajhYSTdpT2I2c2dMUmlpc2pNa1JWVC9TVnJ5WmNDUW9m?= =?utf-8?B?ZFUwSnlVbUxIaU0yL0hZUm9KNFljYWZuSWN0RmNvV3dQOWJ3OVVtMFJDZHhz?= =?utf-8?B?SW1JMVJHREltOThPRytpNnVPSjNEdktac0s5bThYRDJTZk9wR1dHQVhuZVM1?= =?utf-8?B?a2VhRk5oeG5xY01HVXBEVHNHVXJkRnZ1QTlMUFJ4VXFiMGl0RkFQRkgzNVJn?= =?utf-8?B?VEtnOTBPMGZ6c3JrQnFNMWZueFJ5MWpXZmsvb0FkQW5MSE5EWWVSbHRZQUN4?= =?utf-8?B?Mk41YWQ2NHNXYVI4ZFgyZzBQbVV1VVZPZjJCY0tvYWg3ZnFNLy9YaWsvYVVz?= =?utf-8?B?Yk4yamxMTVRjSjB6c2Q5TS91NFNISlJBdHZ5ME80TXdyaGJvb2tGdC9OcTh5?= =?utf-8?B?anJPOVprdXQwcG1vb3I0MWtHaEZkWnhIR2xKR3BVdHM3YWRlSXp5ck5ZbDFN?= =?utf-8?B?Z0lUZGJOV3h2RDIvaENMRU9GTGEzN0FJdjN1N3pZQUtCaEJuSUNZMmVuNTBX?= =?utf-8?B?VG52UkhLVHNJTVFTOUxFTitmaXNGaHpHZHVZRGpERThGQ2NKejFacmg0WXlI?= =?utf-8?Q?hiQ+qoLN0a+rG/QvVrewyzQ=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ac26bf4d-58be-45ce-2a90-08d9fb77aea7 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2022 11:36:10.1069 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ao0yPZqaURAYGtVxJp9EbwWDPv4fSel04260zMzAOYhLkNE8GNE+BsEGYFS5NYCQel5hx8y2zou0cqQAWofYkw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7356 Suitable compiler options are passed only when the actual feature (XEN_IBT) is enabled, not when merely the compiler capability was found to be available. Fixes: 12e3410e071e ("x86/altcall: Check and optimise altcall targets") Signed-off-by: Jan Beulich --- Furthermore, is "Optimised away ..." really appropriate in what 37ed5da851b8 ("x86/altcall: Optimise away endbr64 instruction where possible") added? If this really was an optimization (rather than hardening), shouldn't we purge ENDBR also when !cpu_has_xen_ibt, and then ideally all of them? Whereas if this is mainly about hardening, wouldn't the message better say "Purged" or "Clobbered"? --- a/xen/arch/x86/alternative.c +++ b/xen/arch/x86/alternative.c @@ -295,7 +295,7 @@ static void init_or_livepatch _apply_alt * marginal perf improvement which saves on instruction * decode bandwidth. */ - if ( IS_ENABLED(CONFIG_HAS_CC_CET_IBT) ) + if ( IS_ENABLED(CONFIG_XEN_IBT) ) { if ( is_endbr64(dest) ) dest += ENDBR64_LEN; From xen-devel-bounces@lists.xenproject.org Tue Mar 01 11:39:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 11:39:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281270.479524 (Exim 4.92) (envelope-from ) id 1nP0qx-0002Yw-4N; Tue, 01 Mar 2022 11:39:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281270.479524; Tue, 01 Mar 2022 11:39:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP0qx-0002Yp-0h; Tue, 01 Mar 2022 11:39:39 +0000 Received: by outflank-mailman (input) for mailman id 281270; Tue, 01 Mar 2022 11:39:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP0qv-0002Yj-8k for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 11:39:37 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 442caab8-9954-11ec-8eba-a37418f5ba1a; Tue, 01 Mar 2022 12:39:35 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 442caab8-9954-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1646134775; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=YkxE1f2Bzj1X7jPJQvSSRXnaMkgU9fY9NDuKWHA4v4Q=; b=bTKZ3yI+yZzBIGXzF3yoKNzCsSAhSQEUJAu5K3w/9fheEaxj6wl1jCkm a/czv2c2VnYD2Bja9cTUuhRr1l3WnQwSqCe1W8YXqYLUDtgE9u4E9pIxb vL/QssAMNiq5Uba5ZVko5Q4PGINSizsGl4Z5B0M0F3rXA2GsFDiv/rv3u Y=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com X-SBRS: 5.1 X-MesageID: 65208004 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:bn3jqa3mM61RMjrMjvbD5eJ3kn2cJEfYwER7XKvMYLTBsI5bp2QCz TNMDWrVbPjZMGP3fN93Pd6yoU4Du5XRmINlSApvpC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EE/NtTo5w7Rj2tUw2IDga++wk YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx /1kuayBRF4XD5bMnc0ZSjBpOB1gY/F/reqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr KJCbmpXN1ba2rzwkOnTpupE36zPKOHCOo8Ft24m5jbeFfs8GrjIQrnQ5M8e1zA17ixLNaiDP ZJJMWIzBPjGS00RHGYlFY0PoOmhhCfHcxhT9nykl4NitgA/yyQuieOwYbI5YOeiQcRTg1bdp 2uYo0znDRwAct+S0zyI9jSrnOCntSf6Xp8CUbi57uVCnlKe3CoQBQcQWF/9puO24mauVtQaJ 0EK9y4Gqakp6FftXtT7Rwe/onOPolgbQdU4O/c94gCLjK/J+R6ZF0ANVDsHY9sj3OcyRDo3x hqAhdasBjF1trCRYXac7auP6zK0NzIcIWILaWkDVwRty93ippwjlgrEC9puDoaxj8bpAnf30 TSDpjN4gK8c5eYX3aK84RXLjiyhorDNTxUp/UPMWX+/5Q53Y5Sqasqu5ESzxfJBKpuJC0GKv VAalMWEquMDF5eAkGqKWuplNLWo4euVdT3NmVN1AbE/+Dm3vX2uZ4Zd5Hd5PkgBGsIFfyL5J VXSoghPzJtSJ2exK65xbZi4B8kjwe7nD9uNfvTVaMdeJ4MqJVev4i5jfwiT0nrrnUxqlrswU b+ReMGoEDAeFIxjzTyrV6Ec16MmwmY1wma7bZn91BS61LOYIn2VQLEJLVKKRukj6eWPpwC92 8pfMM6D0FNbXevyayLU4KYaKFxMJn8+bbjm+5J/deOZJAdiXmY7BJf5wbghU4h+g+JZm4/g/ 3a4X1JwzFvkmWaBLQSMd2AmZrTyW5p2sXM8O2orJ1nA83skZ5ym4OEAdp80Vb49/ednwLh/S PxtU8eHGPNnGj7W5zkGK57no+RKeAuumlimPiyrejEzcpdsAQvT9bfMfAT18zIVJjGqrsZ4q LqlvivAWoYKTQlmCMfQadqswkm3sHxbn/h9N2PCJcNSYwPr65RwLDLqje4fJNsFIhHOgDCd0 m6r7Qww/LeX5dVvqZ+Q2P7C/9zB//ZC8lRyNmXr3LvvCxjh/m+KxZZpYc20Y26BbTahkEm9X tl9w/b5OfwBuV9FtYtgDrpmpZ4DC8vTS6xylVo9QiiSB7i/IvY5eyTdg5ET3kFY7uIB4WOLt lSzFs620FljEOfsCxYvKQUsdYxvPtlEy2CJvZzZzKgXjRKbHYZrs20PZ3FgawQHddOZ1b/JJ 8974Kb6DCTl13IX3i6u1Hw8yoh1BiVov18bnp8bGpT3rQEg10tPZ5fRYgevvs3RM4oXbBVze 2bF7EYnu1i67hCZG5bUPSKQtdexeLxU4EwapLP8Dw7hdiX5ag8fg0QKrGVfovV9xRRbyeNjU lWHxGUuTZhiCwxA3ZAZN0j1QlkpLETApiTZlgtY/EWEHhLAfjGccwUA1ROloRlxH5R0JWMAo tl1CQ/NDF7XQS0G9nBqCB499qe6FoQZG8+rsJnPIvlp1qISOFLNqqSveXAJu13gB8Ywj1fAv u5k4KB7bqiTCMLai/dT51WyvVjIdC25GQ== IronPort-HdrOrdr: A9a23:fW7ZVautmpH1osJiNB1AaJrn7skC2IMji2hC6mlwRA09TyXGra +TdaUguSMc1gx9ZJh5o6H8BEGBKUmskKKceeEqTPiftXrdyReVxeZZnMXfKlzbamHDH4tmu5 uIHJIOceEYYWIK7voSpTPIaerIo+P3sZxA592ut0uFJDsCA8oLjmdE40SgYzZLrWF9dMEE/f Gnl656Tk+bCBIqh7OAdx44tob41r/2vaOjRSRDKw8s6QGIgz/twqX9CQKk0hAXVC4K6as+8E De+jaJppmLgrWe8FvxxmXT55NZlJ/K0d1YHvGBjcATN3HFlhuoXoJ8QLeP1QpF491HqWxa0u UkkS1Qe/ib2EmhOV1dZiGdnTUI5QxerkMKD2Xo2EcL7/aJHA7SQPAx+r6xOiGplXbI+usMip 6jlljpx6a+R3n77VXAzsmNWBdwmkWup30+1eYVknxESIMbLKRctIoF4SpuYdw99Q/Bmcka+d NVfYnhDTdtACenRmGcunMqzM2nX3w1EBvDSk8eutaN2zwTmHxi1UMXyMEWg39FrfsGOtR5zv WBNr4tmKBFT8cQY644DOAdQdGvAmiIRR7XKmqdLVnuCalCMXPQrJz85qkz+YiRCdY15Yp3nI 6EXEJTtGY0dU6rAcqS3IdT+hSIW2m5VSSF8LAp23G4gMyKeFPGC1zwdLl1qbrSnxw2OLyvZ8 qO X-IronPort-AV: E=Sophos;i="5.90,145,1643691600"; d="scan'208";a="65208004" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Rrjyn4HlQnEHcuIqGpcs28ooDKC34t9cILAgwXLCdmdfJpSTuFHzlcCkkfGGFyV1CTbcB3+bXYogyKiXIkXGT/peo5Ruqu2bXChvG29LUdpJose1gilGWZqS0ZLDxECaUWkQ8RaErEkbaMWdVpfVWAV+Tcx8zwnaDEE7kyCLGptCHg61BRltbpg2VRzpKeGtx5nhC3Vbpxb/s8OLOWYsJvUgOQcHBc5fvlYbtftx4AGmCZY+Ld21GnZNUwhoqVnsAPYDD7pjDeT7qpbZuW2z7V2dHhZeklYK9EtuDuu1CX/PXkl90i8Qyj8ANPIGT458qqfjgnlgA1iheabbBHy7qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YkxE1f2Bzj1X7jPJQvSSRXnaMkgU9fY9NDuKWHA4v4Q=; b=PN0XQDeHFqDPlEUM2KLVxdx6hxfe3b+6KiTEz/XrFrtWo5e1HmsInVdXUDTpQWeZ1LvUDhc31E7xFn6p2JPpi7b92tjBHryXabyvcdNFgd95377zUjORYqJyvo7gQhvava5IhRpHwbK1Pv0NACUMTzzPSWQno0TVtgVEo9yKMLdZRV6an+mRTHDgpYBALTAqB02KUSm8q4lH6wZ6q7ud/VbW9DSrDPn/leVuRiBadGkfj6mZvv5qfCy64yoeqoNGDVpgvhMFOQo00bx3gMWl5j6f6btmZ4ackCPGwt00Ovs85azCoKc1xL69cvdkJyHkH2lmx0xhAE3HTSoQK/cNbQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YkxE1f2Bzj1X7jPJQvSSRXnaMkgU9fY9NDuKWHA4v4Q=; b=ikhNENNh/YG4IYUOOWYwB9BS6DStnY3cvmx+NVkB+LWJP6FsKhTYrvhH6hyWVoERAHMEzUt53/2Jj4qARu4cRjbGraKRnFSup3kQepXg6bDEOLs2SjQvH9iZybYfmrxq/3x6qLKHxM78e5N5BMPjdfutOjfDSkJDm15c2eucLGw= From: Andrew Cooper To: Christoph Hellwig , "iommu@lists.linux-foundation.org" CC: "x86@kernel.org" , Anshuman Khandual , Tom Lendacky , "Konrad Rzeszutek Wilk" , Stefano Stabellini , Boris Ostrovsky , Juergen Gross , Joerg Roedel , "David Woodhouse" , Lu Baolu , "Robin Murphy" , "linux-arm-kernel@lists.infradead.org" , "xen-devel@lists.xenproject.org" , "linux-ia64@vger.kernel.org" , "linux-mips@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-riscv@lists.infradead.org" , "linux-s390@vger.kernel.org" , "linux-hyperv@vger.kernel.org" , "tboot-devel@lists.sourceforge.net" , "linux-pci@vger.kernel.org" Subject: Re: [PATCH 08/12] x86: centralize setting SWIOTLB_FORCE when guest memory encryption is enabled Thread-Topic: [PATCH 08/12] x86: centralize setting SWIOTLB_FORCE when guest memory encryption is enabled Thread-Index: AQHYLVsO0esfCi4ktkCl+GWHal7mDKyqZ0+A Date: Tue, 1 Mar 2022 11:39:29 +0000 Message-ID: <8e623a11-d809-4fab-401c-2ce609a9fc14@citrix.com> References: <20220301105311.885699-1-hch@lst.de> <20220301105311.885699-9-hch@lst.de> In-Reply-To: <20220301105311.885699-9-hch@lst.de> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c374ea50-179c-4ab3-e28f-08d9fb7825f5 x-ms-traffictypediagnostic: BYAPR03MB4135:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: eqr1nj/ADPfeq9PVCJBr+xjKZqtUjR5u30OY6zkNoUAZL+/B4yliVPv4iJCsQQtWhlsplDdoapbqyAZmz8RG+x4PgMjdulajurymsHBmp0mm2kWSATBllOis9nkoKfbjut8aMybKD5sA8GrZ72QfM3mShxhKQ66MAQ7VbwuhFLL4tVL0Awm0Q3R+7pu97dT/4sWhyXSlJiwsKvqXgt83GJKc27XlHmho9KAO6aBi9vMw7SE6WeLXJ2E3X32OAHVTYRKfujpdDZ9Bog0pde30SgcMFuyUljEk9poXhy2w7OL4ydDTfTbWSm8jc/b+/dIEiquExy06y7f9n5Eb0ruOHP0epECNITbR2sESxyFul/TL9V8K+wZT6BLg3UqKjYW7rCca0hevDx3qk3Ien2nCv/U07Y+gfhUJ0p/gQ/dReQFPSnQ3WZeOpFHgmmlWFzZRrVoBfbz/cbK5tQbMM7FU75RYxG1rJyDsAyHKbHSvC5VnaW50UPUnm76LtWH6+k2ooG5p9eo6rbD9rD2Rjxajg1mPSqxyQqlGvP4p+ZEj2yZMR951JFrcEhE8Ri5bOON9GMGgkhFhvGE0IMg7fMHFMBe7TqBlNBFdzHnhl8w3cfgFjWi99Yi2BSsfDeLENMvDgcqa6N/M9l0XZAc1bjfh+QMXFJ3BTL2TZJb0baPQGJbK1K1Y7G51bczEgGjXSb0ulD7WHNj7bty0g38lVkaaJ+p9+D1VDWi33gehc4DY35kG0VYIwqhj0vGPK1WP6piaywpGilNedp2rVu7CGk1Qqw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(508600001)(8936002)(4744005)(71200400001)(2616005)(6486002)(54906003)(8676002)(4326008)(91956017)(31686004)(66556008)(66446008)(64756008)(76116006)(66946007)(66476007)(36756003)(2906002)(7416002)(5660300002)(316002)(26005)(110136005)(38100700002)(82960400001)(83380400001)(53546011)(122000001)(6506007)(6512007)(38070700005)(31696002)(86362001)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?V29KQUxGQ3Z1eE9uZzlEN1JXSHNJRUZxZEV1bU5PbDRnS3ZpckxTTTdJekpl?= =?utf-8?B?bTZHdmNGMWFmajdVd3dIajgxSjIwVmJ1bC9oZUtNSU1hVGppY3BSd2NVWHUy?= =?utf-8?B?RU9VOWE5VnJXM2dHaUFDdTJUMnpMZDBzdnJHYjBhV2VoT2hqZ0ZDbjdTN2Jv?= =?utf-8?B?aTdvci92ZHY3SXhNK0dmNTQvL2MzaTViYWN6bkJodStHcGJHVTBhV0xFcGZR?= =?utf-8?B?Zzl4SVpVajVKVkZ4ek0vaVRtZHovUms1bnQxT0UwVzRJc21wTEpiVzRzL3NC?= =?utf-8?B?clR4ckRTVWlZNDNaa0RQU3R3TmNJTjBEZE85em5JOVZFcU5NN3A0eFFpbmgz?= =?utf-8?B?Q2QvdTdjdmlvOXVPWG5OWjBJbDBsMmFTdTRybjI0S0ROakF6MlIxWnJNelFU?= =?utf-8?B?T3F0ZWdXRFI2V2R0amxwckVBTjB1WkliMmVCTVlTQW1DRHRmUVRCYTgxMStS?= =?utf-8?B?a3VBeU56dnBxUTF4UGtodEZHU09PMVNkc2ZGK2dyZkJCT2lKZ2xGOUJnRWRi?= =?utf-8?B?NmdsVHkwdDBUZGl4UFRXbGRuL2Y2T3k3ZXQ2UGllczZWdThPY1dObTRaSEg5?= =?utf-8?B?ZHIwbVJ5dFhOL0hZRnczbERnMFJjK1BWZktLamhVVkZuN1VmYUdpZnVOdnY1?= =?utf-8?B?ejByN01ITmdyMUZYZkRCVk9Lc3o4V3diSVJWWnNqL0xmUkh0WUorU3YrWFJZ?= =?utf-8?B?di85UGZHbHBVSENWai9NTlJOSFlzbEQ1NjNXeC9aRGhLZ1IvaWovMER0S3RR?= =?utf-8?B?amdLQ3hsMHpIWjhQMkZhUS9xNFNWK2tkb3JVMmZkSTI0WUU5a3dBd0pnRlds?= =?utf-8?B?SXBPUHpVZHV2Ym5zNUJDdkJwdUxRcDJKaTZ4RktUL2VDUFpGTkk0UFR6UFVZ?= =?utf-8?B?SXhycDVyVlRXQ1c0WTVhSVpHMkNsRE5YYjk3cDNWdUY2UUlGSDNBMHRUamRk?= =?utf-8?B?bFdEYUFnZmk5dUk2UWhjcUUxcTFTSEJDcE9ZdGFNbDNJQUFsdmVVaEJ1NnYx?= =?utf-8?B?TWU1THhRY2tNS3NSUWJDNkZrN3J6cEtVNCtMdno0ekhLTXVPSEdKUGlKTldq?= =?utf-8?B?SVN2YTF3b0lMRUZaRFBzMWlRdW1iZGYvdDlGK3NRb25Cek9FWXFab1dJUm9H?= =?utf-8?B?eFdwY1ZwWFpaQVg5UmR5cXJYbnZHbEpJUHAvRDRiYXorWXQ0aGs0dG5hVVhN?= =?utf-8?B?ekllUS9HbUxPaUoyYnY1ajAyUEV4WlJvaE51bXpXYkFiWjQ4MnBKN1E1Vzg1?= =?utf-8?B?TnRGY09ybWt3cUorR0ltbk1UR1haQkJFYUx2T2ZITzJxOFNFZEl2Y2IxT2x5?= =?utf-8?B?bWE2cjJwMFNJVEY1NGtqR01xSWM2TFlraUR1SjRMM0V5YkRSKzZxUjBsakp0?= =?utf-8?B?ajdycmovMzRYc3pncERnczUxTzlIUWZ2ZDNQWHU1dVNqNmVudDhnRVo3VmJo?= =?utf-8?B?OG5HdlcrSy9vNEpiSy9WVjk2YmRFZGpMZGNZS09mWXJ6TjlkYVRIWGJTRFdH?= =?utf-8?B?UFgycnZzZDI3WnExY0k0eHVnSVRpQ2FsQ0RaakRMWHNWeHRrTXBoam1NVzdx?= =?utf-8?B?ZjBGZE1mekw2RFBvd1R4dDBpeG5vemhlUDdyOWhIZHV3NHNSclVjOTRtcVFJ?= =?utf-8?B?MXRMQmsyelZudU5SaThBQnBTZ1R3Z0lUOVFVeDcyZjk5S21DS0hSZkE1MjZV?= =?utf-8?B?YTJja3htenErTEpLdmtTUVRqcWlJcHpocDFuWDFoS2lLdGZ0dzhRSU1IQ2Zp?= =?utf-8?B?aEJ1R1lJaHd0ZzZaeWZPK3o0b1FyNEQ0TXZUSGtyU25Ja0FWc28wRFJiRm9M?= =?utf-8?B?ZlRXS2drbXlLL3NQOEZKTzFnRXhnQ0Nqa1c4QkVsUmZZRlJxTjhmdzFPZVN0?= =?utf-8?B?cGVzOE5DRGw4cjhVbG11aWwvdER6UlllOHAxUStjNENaVWxhRndudmhvS1Vm?= =?utf-8?B?RS9iQnNYZzhqT2VWbDJZMkNqYjZxMUtOSWJVVmp4cENrTWllVWpuWXdybndx?= =?utf-8?B?anM3a1hsWWNvbXVldWlBUzVhU3ArRHZKMlcwYkRCQTFHV2NieGR6ZHlWZTQ2?= =?utf-8?B?NTFPQ3dENFd2alBJSG5ZUXJTVzNDd3k2Q2xUSHljMVE0cW40c1lVcW8wZlk2?= =?utf-8?B?Z1NBVzZGQndUUjNlRHBRdnpaTWJKdnB5TFduL202dm45bHdSMDJrdVU0NjlU?= =?utf-8?B?d0RBWmI4ZFFpdzZHVlp2UGtrZzdWNTh4OHRSc0xpV1MyajM0R3p6WTR2T05i?= =?utf-8?B?SDR6OHlqZjlEUVZVcTRxVy9oQW1RPT0=?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c374ea50-179c-4ab3-e28f-08d9fb7825f5 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Mar 2022 11:39:29.9592 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cn7CjesrcGKBpaPLehKxWy78J7QftlA2WxBhsLzq3mibgMd/ZVh1iPL1bNoyD8clO3N3VBw2CneavMhSmbRjE7aIiZ88WgnHvaEqDuwU2Sw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4135 X-OriginatorOrg: citrix.com T24gMDEvMDMvMjAyMiAxMDo1MywgQ2hyaXN0b3BoIEhlbGx3aWcgd3JvdGU6DQo+IGRpZmYgLS1n aXQgYS9hcmNoL3g4Ni9rZXJuZWwvcGNpLWRtYS5jIGIvYXJjaC94ODYva2VybmVsL3BjaS1kbWEu Yw0KPiBpbmRleCAyYWMwZWY5YzJmYjc2Li43YWI3MDAyNzU4Mzk2IDEwMDY0NA0KPiAtLS0gYS9h cmNoL3g4Ni9rZXJuZWwvcGNpLWRtYS5jDQo+ICsrKyBiL2FyY2gveDg2L2tlcm5lbC9wY2ktZG1h LmMNCj4gQEAgLTUzLDYgKzUzLDEzIEBAIHN0YXRpYyB2b2lkIF9faW5pdCBwY2lfc3dpb3RsYl9k ZXRlY3Qodm9pZCkNCj4gIAlpZiAoY2NfcGxhdGZvcm1faGFzKENDX0FUVFJfSE9TVF9NRU1fRU5D UllQVCkpDQo+ICAJCXg4Nl9zd2lvdGxiX2VuYWJsZSA9IHRydWU7DQo+ICANCj4gKwkvKg0KPiAr CSAqIEd1ZXN0IHdpdGggZ3Vlc3QgbWVtb3J5IGVuY3J5cHRpb24gbXVzdCBhbHdheXMgZG8gSS9P IHRocm91Z2ggYQ0KPiArCSAqIGJvdW5jZSBidWZmZXIgYXMgdGhlIGh5cGVydmlzb3IgY2FuJ3Qg YWNjZXNzIGFyYml0cmFyeSBWTSBtZW1vcnkuDQoNClRoaXMgaXNuJ3QgcmVhbGx5ICJtdXN0Ii7C oCBUaGUgZ3Vlc3QgaXMgcGVyZmVjdGx5IGNhcGFibGUgb2Ygc2hhcmluZw0KbWVtb3J5IHdpdGgg dGhlIGh5cGVydmlzb3IuDQoNCkl0J3MganVzdCB0aGF0IGZvciBub3csIGJvdW5jZSBidWZmZXJp bmcgaXMgYWxsZWdlZGx5IGZhc3RlciwgYW5kIHRoZQ0Kc2ltcGxlIHdheSBvZiBnZXR0aW5nIGl0 IHdvcmtpbmcuDQoNCn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Tue Mar 01 11:43:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 11:43:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281279.479541 (Exim 4.92) (envelope-from ) id 1nP0ur-0003yc-Mu; Tue, 01 Mar 2022 11:43:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281279.479541; Tue, 01 Mar 2022 11:43:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP0ur-0003yV-JN; Tue, 01 Mar 2022 11:43:41 +0000 Received: by outflank-mailman (input) for mailman id 281279; Tue, 01 Mar 2022 11:43:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP0uq-0003yP-9S for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 11:43:40 +0000 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d6063504-9954-11ec-8539-5f4723681683; Tue, 01 Mar 2022 12:43:39 +0100 (CET) Received: by verein.lst.de (Postfix, from userid 2407) id 5C51F68AFE; Tue, 1 Mar 2022 12:43:35 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d6063504-9954-11ec-8539-5f4723681683 Date: Tue, 1 Mar 2022 12:43:35 +0100 From: Christoph Hellwig To: Andrew Cooper Cc: Christoph Hellwig , "iommu@lists.linux-foundation.org" , "x86@kernel.org" , Anshuman Khandual , Tom Lendacky , Konrad Rzeszutek Wilk , Stefano Stabellini , Boris Ostrovsky , Juergen Gross , Joerg Roedel , David Woodhouse , Lu Baolu , Robin Murphy , "linux-arm-kernel@lists.infradead.org" , "xen-devel@lists.xenproject.org" , "linux-ia64@vger.kernel.org" , "linux-mips@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-riscv@lists.infradead.org" , "linux-s390@vger.kernel.org" , "linux-hyperv@vger.kernel.org" , "tboot-devel@lists.sourceforge.net" , "linux-pci@vger.kernel.org" Subject: Re: [PATCH 08/12] x86: centralize setting SWIOTLB_FORCE when guest memory encryption is enabled Message-ID: <20220301114335.GA2881@lst.de> References: <20220301105311.885699-1-hch@lst.de> <20220301105311.885699-9-hch@lst.de> <8e623a11-d809-4fab-401c-2ce609a9fc14@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8e623a11-d809-4fab-401c-2ce609a9fc14@citrix.com> User-Agent: Mutt/1.5.17 (2007-11-01) On Tue, Mar 01, 2022 at 11:39:29AM +0000, Andrew Cooper wrote: > This isn't really "must".  The guest is perfectly capable of sharing > memory with the hypervisor. > > It's just that for now, bounce buffering is allegedly faster, and the > simple way of getting it working. Yeah, I guess you щould just share/unshare on demand. But given that this isn't implemented it is a must in the current kernel. But if you want a different wording suggest one and I'll put it in. From xen-devel-bounces@lists.xenproject.org Tue Mar 01 11:59:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 11:59:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281286.479552 (Exim 4.92) (envelope-from ) id 1nP19x-0005mN-1y; Tue, 01 Mar 2022 11:59:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281286.479552; Tue, 01 Mar 2022 11:59:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP19w-0005mG-VC; Tue, 01 Mar 2022 11:59:16 +0000 Received: by outflank-mailman (input) for mailman id 281286; Tue, 01 Mar 2022 11:59:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP19v-0005mA-Ll for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 11:59:15 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 035966cc-9957-11ec-8eba-a37418f5ba1a; Tue, 01 Mar 2022 12:59:14 +0100 (CET) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05lp2112.outbound.protection.outlook.com [104.47.17.112]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-7-cmQUEMhtN4i_4aw6HG3yoA-1; Tue, 01 Mar 2022 12:59:12 +0100 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by DB8PR04MB6364.eurprd04.prod.outlook.com (2603:10a6:10:10c::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.25; Tue, 1 Mar 2022 11:59:11 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.027; Tue, 1 Mar 2022 11:59:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 035966cc-9957-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1646135953; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=euxWGwpNFpXQayf1WVFqTvC95+comyZxg0/6MsdppYw=; b=TTcKVg7hyks0yn+5ZxFsoGAATtO8/Ljks057xnTnPqyUVhjDg+KTATff3WdfOpofNP390C V5h/K4k21HckdFLh8253tPNep59lHkuNFLBzrJEr9eSSy+TSPiZtpX96F1zWD0oy32qqMR 1lp7xxB3tmO74r6CJWrAGbxfE1kNYbU= X-MC-Unique: cmQUEMhtN4i_4aw6HG3yoA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h/lJyp+tvL1+Jbk1hCI0A2FR/JKfRj7kCfyWsae94+/z+eeblDkKt2ovyDsGl8+40BU81ulfTyXNbMNO3MaY4VkdAghXtze/cEAg+EPmU4Bg25LSpN1VclQdlbguAfitPh+LvOMJ1OJW+G2tNlQmUtv0w8FTHIkxG3ANEkFD+26+7ZHw+9Be4rzgLHOnlYKE+tXNu2MKG7ImYJo1z1amQ2wWfkagj9X4O2kXu3rTaE5m1zWcZ8VBEb70f3TXkG4QSPNFg2ccR6EDqxZ7Dv4yI7zeVw+nlN3KmltLz5mhEOQeSUxLS4KTxZgZ67YXjSI+4E9KQkzH3FEf8CSvZYyjdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=euxWGwpNFpXQayf1WVFqTvC95+comyZxg0/6MsdppYw=; b=MQ7O+YEthIfeHC1OI/UADKld26qo6JYGIpcMlcJbqQ5AFvanF/J+UtYIatSBuh5cLrRc4PojIjNthQoEJSYJOXvUviIhBArFeeNHel5d5bS7g0tGikzyLqT6b5RE1CbUXa6M7ZxDPwdVHBTKWw4eJ/psXQdJ6lD9iXBqFqb/pI0Sumq057pClpMOSKoV+g6cBjiq0J0G3hUX0dv+vX9knY1EiVx2zqT4VM6nO8BcCASdvVH7MB/uHki6lGnSi7fZofsnWxg/XogRe1ALyLyzxtw9CEDlZS68Coef6iv7OEcAgXRX4ppcCjmZrzMNLmNh2P+IWspgXVE3gCKCNPueeQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <2808e805-60a7-2f1e-0ff4-8da123c79afd@suse.com> Date: Tue, 1 Mar 2022 12:59:09 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH v2 3/7] x86/altcall: Optimise away endbr64 instruction where possible Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20220214125632.24563-1-andrew.cooper3@citrix.com> <20220214125632.24563-4-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20220214125632.24563-4-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS8P251CA0009.EURP251.PROD.OUTLOOK.COM (2603:10a6:20b:2f2::34) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: eed71500-e4bb-4936-0b64-08d9fb7ae5dd X-MS-TrafficTypeDiagnostic: DB8PR04MB6364:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xI1d0FboKO00E1aOgQhSI4AMHfCi4zpb2NiVPbhD967g36GwAgQKauZb8PnJDz3dJIqgKFVSL4TxQyWRkp5YqZQkSBK5LmvRqBn/XiPKJV0KQSUREY1S3bNis1XloYJjRcXGGq6BW1lbaJLSk9u5OZIS5Dj44vmVNf0z9l5sSaZUy15TUnb7//kjoZxfjog+4rK32bj23HDUoAZvVxEb1yKNCfTH8LQByZWZzxJjpwC5pVueUkIcSOTIVqMpg1ovzqkgr8Ecp97hISYni2DrvOzl31jD3tV6ANYihMeiE0JuhCKul5svFSrQZboHXJkt+fM0yW1Dyjt0FX5qAoo45PN0n4wuzTAZ9zzzmN4LOm+KtysOiB7Raon+C3LKo0cwVaf0G/Rf7eiIam72orjgsmi4j3EMNNPtCNqjSvdeWrH20nBvzQv7Nod8gH7vbnI02mDG/JT1PPwJt6skyj0kBaOj/15e+6oNLIrMUWMTJE67iDnWaLett9K+Zrft6lt1e2arzuyQzJNg7aoBFsPNDc/SeYLKUnZAFmbxWynfO9hqmOXqnci5D4ABsfQZirVwt1zzYUhljgrU2Iw2aT7W8vt6vAMnQ/d+z62Ns91tgH15Ep3bVzhw3UlNcfoT6SIKV2sFzVyvf61pc5KjJbLUP4mJf1q5Nziz76LmANewUkxcbyUzbpG8lDJIuoatCyw+V2Z7rIOCQNP02B0Wog6UYJo4LWcV664Z0JColO8zBdg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6506007)(2906002)(6512007)(38100700002)(4326008)(5660300002)(53546011)(6916009)(86362001)(83380400001)(26005)(186003)(316002)(2616005)(36756003)(66476007)(66946007)(54906003)(66556008)(8676002)(6486002)(31686004)(8936002)(31696002)(508600001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c0VmcGZDSFR0T3BFWmY2S0Q5YWZoQ2VlalZOVjVJeUFpbk8vUUdhVDdlTWRp?= =?utf-8?B?TEdKeDh5dkVKeXZtb1VjdUJEcnZZZzM1aXdTb1B4TUkxTHp6NWgzZzZ5Tkcz?= =?utf-8?B?a2wrZmFSaTdvVkNxMzM4THhkZzV4SlM3T2lKUk9QQUo0MW5jRFZXbHc2Nk9K?= =?utf-8?B?cEwzenVTNjMyVUgxNitzMVpXemZYaERGT3BFUzRod0ZzZjlJV0FxUnkrb0hl?= =?utf-8?B?NVV4TC8zSWw3QU9seCtIdDNNRE5CTUdRRTVrYnVhNkJqbmUydHhaTk03UXdP?= =?utf-8?B?bUVFbUxaSmQrdnZVTmI4UTNHbHkyeVRSQ2NLN3EybFg5NjBodjM3bXpHUUh2?= =?utf-8?B?Z1BSYTZwNXJSTkYyZ0djL0Q5N1MyUUxGYklHMTdvNUtUVGp6Mmt5dHpiZExp?= =?utf-8?B?dDFCR1F6SDV1NzV6WTZQQWc3a1JJSDhrMG5YdUNKa3dtSWlIdnhnUTdQcmM0?= =?utf-8?B?ek5YcUhZVlN3d1VRdUJUS1g0QWRONE03Qit1WTI3MzBGOFJXQjRFRFRvaklP?= =?utf-8?B?aVVQVmVqeXRwekdnbXpJa3NaM0lTenpHQXZPSnprZDF2QWpucis4b2R5SXNS?= =?utf-8?B?TkdOVHE3K1hiM2RTeEZkajlnbXZ6Qm45RTYrekpRMWd3d2Z0VjJSY0xha2pY?= =?utf-8?B?d1R0SHlrMnJieXBacjNSRjhhVXZsSTl4YVpPWlZvd25Gb2NTNFBIbmo1SnFX?= =?utf-8?B?TktpZnh0eWF2VC9DOS9PODB3M2xINlQyYjFmVkhLdXptME1LV0RwYSswV3Vl?= =?utf-8?B?VDlwa2JlbFVIMHZRQWhmbDVnOVp2eFc4Syt1WVNPVjhTSE5PbWYrZzVTSXhQ?= =?utf-8?B?N3RuNGpIeExWb3JTWm0xbG52cjd2eXJWdUMvY0xnaTJlRFRXWGljeFNYNXQ1?= =?utf-8?B?VTRIN3RFQVV4N1lZRTE0ejZ2d3FBeWpVMklhRG1rKzFyS2ljUTg3V0xZUTJV?= =?utf-8?B?WmtBa0F3TGxNOU90N09NUmw2RlBhL1JsZnhzWGNwR1FRS0Zpb2thTzRPdW1H?= =?utf-8?B?TEFQSzhpMERQa1JYeTdHdjQ3ZEZWNHhCamdGRUc5Z044NDJmNUJvVEczSFAz?= =?utf-8?B?b1V1V2VWOVFWeDhaTW9ITldoYWxweUp0eEowMnZYTW4vRDU2NEtnaVQrblc5?= =?utf-8?B?cXBjSVN1TG9YdjcraGJhQ1lpUkFjSG1YdjgvaEdLU1lma1piRmVPMEQyY0Z5?= =?utf-8?B?UkROV0NyaU1JNUNHc1F2VmNmQVhMa0JaTks3RURZSXpvTTRhRGZPV0lOMHI3?= =?utf-8?B?cW9qV2RPYTUwVFIyTVRYaExEbkMyS0dGNWlIczFISE9tUjdBa0xMY2hQYVhX?= =?utf-8?B?UnBtcmdYbWRYb0NYbW9lTk9hTUY0d0NyYzdRUmpETkR4OGFjR21LU1ZHalZy?= =?utf-8?B?djNHSmwycjFjRHJ6QVpIVjZTaE9QNVRodkUzMDlYWDJ0bytvN1I2L2pRVVVs?= =?utf-8?B?cWFJNGJPelhOSmNueFg5c1F6bS9rblRwVGMzYjQ4TXA4QUNqMm1XUVhQeVVU?= =?utf-8?B?SFBBdzd1UDVkVDlaQzNsUVVUZ3VweUFRbTR1d1hsaDBoZTlNcE00RFMrUEpD?= =?utf-8?B?VXVLRVRnZVRFNE9zbkVMU3hQMFVsQjZHNDRDZ2dSUjBEVTd4UGJJMnhBb3Bw?= =?utf-8?B?ZGN3aHc4THVTNHRUL0lVT0ZYaTFmaXZLdnJTTFNzemhmaWorR2hlTDkrMjhq?= =?utf-8?B?RnFTUjkvTTBPNmREdGIyNXRWRXlYZTdja2pXVmRuLzVPTHBBM3VNYUtPZkxP?= =?utf-8?B?MEMxN29SSUFqWTBJNGtMUzlHa2V0bFB1b2FhM3I3Yyt3WkRkQ2h1dklMTmlq?= =?utf-8?B?ci9LWTNuM2J0c3h5TjMvTThBcFBXcWQzZFFLcWQ0OGtCVnQ2QUw4dkdWMXZJ?= =?utf-8?B?MVpqaWlFZElWMUFnci9lZnlUQ2lBZS9Id2h1NmthdW9CalMvK0dPb1pHSWZS?= =?utf-8?B?RVhzMnk2Z2lKWmRGQy82d0l2cVV3VmQrTERRUnNxdmJOYzY1QS9YQktNYy9v?= =?utf-8?B?RWVDbWNXZFRoQ0FFRmVoaHdMS0RRY2pYelBNbHoyUmJ5dlhqRWx0YjVyOHYy?= =?utf-8?B?WXU2Y1Y4cCsxdFhNVWRhTThWOEVVRU1WeCsyZ0o5WW82WHc3WmhQYm9DV0Ja?= =?utf-8?B?MjEyOWRadE5BL0ZDVkdJT1hOTzJMWFdKK2t3MU1CVzE1MjRRSmVJQzlvYzJi?= =?utf-8?Q?9GgY9gbstvp/M+9/zLmp1TM=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: eed71500-e4bb-4936-0b64-08d9fb7ae5dd X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2022 11:59:11.2405 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9LWfnp9o5A3JWhpLZ/OSKOZIDXE2o8sr4dEnYZ9hKeRcp8g/LuLlGsLbUWh1ALAVps3soozerWQOHhXSSZixZQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6364 On 14.02.2022 13:56, Andrew Cooper wrote: > @@ -330,6 +333,41 @@ static void init_or_livepatch _apply_alternatives(struct alt_instr *start, > add_nops(buf + a->repl_len, total_len - a->repl_len); > text_poke(orig, buf, total_len); > } > + > + /* > + * Clobber endbr64 instructions now that altcall has finished optimising > + * all indirect branches to direct ones. > + */ > + if ( force && cpu_has_xen_ibt ) Btw, this is now also entered when the function is called from apply_alternatives() (i.e. when livepatching), but ... > + { > + void *const *val; > + unsigned int clobbered = 0; > + > + /* > + * This is some minor structure (ab)use. We walk the entire contents > + * of .init.{ro,}data.cf_clobber as if it were an array of pointers. > + * > + * If the pointer points into .text, and at an endbr64 instruction, > + * nop out the endbr64. This causes the pointer to no longer be a > + * legal indirect branch target under CET-IBT. This is a > + * defence-in-depth measure, to reduce the options available to an > + * adversary who has managed to hijack a function pointer. > + */ > + for ( val = __initdata_cf_clobber_start; > + val < __initdata_cf_clobber_end; ... this being main binary boundaries, no action would be taken on the livepatch binary. Hence (also due to having been here before during boot), all that I understand will happen ... > + val++ ) > + { > + void *ptr = *val; > + > + if ( !is_kernel_text(ptr) || !is_endbr64(ptr) ) > + continue; > + > + add_nops(ptr, 4); > + clobbered++; > + } > + > + printk("altcall: Optimised away %u endbr64 instructions\n", clobbered); ... that this message be logged once per patch load (with a number of 0). I think the enclosing if() wants to be amended by "&& system_state < SYS_STATE_active". If you agree, I can easily make a patch. Jan From xen-devel-bounces@lists.xenproject.org Tue Mar 01 12:11:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 12:11:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281299.479590 (Exim 4.92) (envelope-from ) id 1nP1M3-0000Rz-6d; Tue, 01 Mar 2022 12:11:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281299.479590; Tue, 01 Mar 2022 12:11:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP1M3-0000Qy-0H; Tue, 01 Mar 2022 12:11:47 +0000 Received: by outflank-mailman (input) for mailman id 281299; Tue, 01 Mar 2022 12:11:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP1M2-0008Ic-1O for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 12:11:46 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c2e86dc5-9958-11ec-8eba-a37418f5ba1a; Tue, 01 Mar 2022 13:11:45 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c2e86dc5-9958-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1646136705; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=fvTSRerL3DdcqoyCmQ0+MA1pOOEfGWViyWiS5fU/zLA=; b=DDPj4bNJOrtGiDYZ/b7sCSjeBTxOpm2IJGRZgcgmF4mBytOxIM7Cob3a 8mb3punCkri7i9dFvYetSJyWmQgjL0OKFYaf6tN1/fEaGlEImuaPfTkR/ 0mPnnwe3JUBkVd0cWsdD8uPzIBfFS144PujVHM43kss3ZkGMZ9CyKdlP1 8=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 65205238 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:hiHVhq1UC5XQPIzHrfbD5c9xkn2cJEfYwER7XKvMYLTBsI5bp2YEx 2AfUGjUbvyIZWrxLd1xOd+//EkHuJCGnddiGVZspC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EE/NtTo5w7Rj2tUw2IDja++wk YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx /0UrLC+eTsOJ5btwuY6fRZWGTFAJZNZreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr KJCbmpXN1ba2rzwkOnTpupE36zPKOHiOp8fvXdxiynUF/88TbjIQrnQ5M8e1zA17ixLNaiDP ZJEM2E/BPjGSydpYQgQNaI8oLqhiHbycx0BpkKzvaVitgA/yyQuieOwYbI5YOeiXt5Jl0yVo mbH+WXRARwAMtGbjz2f/RqEjebVkST2cIkbDrG/+7hhh1j77nweDlgaWEW2pdG9i1WiQJRPJ koM4C0soKMuskuxQbHVQBmQsHOC+BkGVLJt//YSsV/XjPCOukDAWzZCHmUphMEaWNEeHCUG2 G+1uMrSJGZtl5OaR3iNyK+qsmbnUcQKFlMqaSgBRAoDxtDspoAvkx7CJupe/L6JYs7dQm+pn W3TxMQqr/BK1JNQif3nlbzSq2/0/vD0ohgJChI7t45Pxidwf8abaoOh8jA3Bt4Qfd/CHjFtU JXp8vVyDdzi77nQzERho81XRdlFAspp1hWG2TaD+LF7qlyQF4aLJ9w43d2HDB4B3jw4UTHoe lTPngha+YVeOnCnBYcuPd7vU5txk/S5TI20PhwxUjaoSsIqHONg1HszDXN8Iki3yBR8+U3BE c3znTmQ4YYyVv08kWveqxY12r433CEurV4/trigpylLJYG2PSbPIZ9caQPmRrlgsMus/VWEm /4CZpDi40gOD4XDjtz/rNd7waYidiNgW/gbaqV/K4a+H+aRMDp5Wq+JnOh4INQNcmY8vr6gw 0xRk3RwkDLX7UAr4y3QApy/QNsDhapCkE8= IronPort-HdrOrdr: A9a23:HKz9f6k4paRf1XdCTpxvL7Q1lEbpDfIU3DAbv31ZSRFFG/Fxl6 iV8sjzsiWE7gr5OUtQ4exoV5PhfZqxz/JICMwqTNKftWrdyQyVxeNZnOjfKlTbckWUnINgPO VbAsxD4bXLfCFHZK3BgTVQfexO/DD+ytHLudvj X-IronPort-AV: E=Sophos;i="5.90,146,1643691600"; d="scan'208";a="65205238" From: Anthony PERARD To: CC: , , , Anthony PERARD , Doug Goldstein Subject: [XEN PATCH 3/3] automation: check for generated files Date: Tue, 1 Mar 2022 12:11:33 +0000 Message-ID: <20220301121133.19271-4-anthony.perard@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220301121133.19271-1-anthony.perard@citrix.com> References: <20220301121133.19271-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Try to find out whether genereted files that are commited needs to be regenerated. Signed-off-by: Anthony PERARD --- automation/gitlab-ci/test.yaml | 10 +++++ automation/scripts/check-generated-files | 55 ++++++++++++++++++++++++ 2 files changed, 65 insertions(+) create mode 100755 automation/scripts/check-generated-files diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml index 56747fb335..a4b08c26ca 100644 --- a/automation/gitlab-ci/test.yaml +++ b/automation/gitlab-ci/test.yaml @@ -25,6 +25,16 @@ build-each-commit-gcc: tags: - x86_64 +build-check-generated-files-tools: + extends: .test-jobs-common + variables: + CONTAINER: debian:stable + script: + - automation/scripts/check-generated-files + needs: [] + tags: + - x86_64 + qemu-alpine-arm64-gcc: extends: .test-jobs-common variables: diff --git a/automation/scripts/check-generated-files b/automation/scripts/check-generated-files new file mode 100755 index 0000000000..054ea3e025 --- /dev/null +++ b/automation/scripts/check-generated-files @@ -0,0 +1,55 @@ +#!/bin/bash + +# Check that generated files that are commited are actually up to date + +check_git_status() { + output="$(git status --porcelain --untracked-files=no)" + if [ -n "$output" ]; then + echo + echo "Files potentially needs to be regenerated:" + echo "$output" + return 1 + fi +} + +set -e +set -x + +# Try to have recently changed files more recent than generated files if those haven't been regenerated. +if [[ "$CI_COMMIT_BEFORE_SHA" && "$CI_COMMIT_BEFORE_SHA" != 0000000000000000000000000000000000000000 ]]; then + git switch --detach $CI_COMMIT_BEFORE_SHA + git switch --detach - +fi + +# Lists of files that generate other commited files: +touch tools/libs/light/*.idl + + +# Regen autoconf files +./autogen.sh + +# build up our configure options +cfgargs=() + +# Disable non-tools subsystems +cfgargs+=("--disable-xen") +cfgargs+=("--disable-stubdom") +cfgargs+=("--disable-docs") + + +# Disable external trees +cfgargs+=("--with-system-seabios=/bin/false") +cfgargs+=("--with-system-qemu=/bin/false") +cfgargs+=("--with-system-ipxe=/usr/lib/ipxe/ipxe.pxe") +cfgargs+=("--disable-ovmf") +cfgargs+=("--disable-pvshim") +cfgargs+=("--disable-qemu-traditional") + + +./configure --quiet "${cfgargs[@]}" +make -s -j$(nproc) build-tools + +if ! check_git_status; then + git diff + exit 1 +fi -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Tue Mar 01 12:11:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 12:11:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281296.479563 (Exim 4.92) (envelope-from ) id 1nP1Ly-0008Iv-B5; Tue, 01 Mar 2022 12:11:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281296.479563; Tue, 01 Mar 2022 12:11:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP1Ly-0008Io-7W; Tue, 01 Mar 2022 12:11:42 +0000 Received: by outflank-mailman (input) for mailman id 281296; Tue, 01 Mar 2022 12:11:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP1Lw-0008Ic-Uo for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 12:11:40 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id be63be4d-9958-11ec-8eba-a37418f5ba1a; Tue, 01 Mar 2022 13:11:39 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: be63be4d-9958-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1646136699; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=AOGi+1fHNk/QNeSxzKelWiy0U7zrLKMb5/LRkXgzbOY=; b=JcVXfpMcUiFK0HwxKcFye7bpsppBhQ3iLKoSI6vY44kTj3q/XL4FPDX9 CAvrqC605CyA3HcgYif6M/J/uNVXVY5AUecJmMJo2eav9/KhfczWGlaTF H+oZLIJnjC+akt/U3nT1utIPlLD45h16Lj5BGkkC93i/bPwpGPGZYxgw8 A=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 65210546 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:ispNrqrhh24HIKV4f7H0lznPno9eBmIEZRIvgKrLsJaIsI4StFCzt garIBnXOKuKZGD8L90jad+/oxgCupXTnNUxGVA4ry03Qn5Bp5uZCYyVIHmrMnLJJKUvbq7GA +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8lyrZRbrJA24DjWVvW4 Yqq+aUzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk b1wWZKMpQgBD7KUuc0hTSlhKQonYfcb9qLWESWGmJnGp6HGWyOEL/RGCUg3OcsT+/ptAHEI/ vsdQNwPRknd3aTsmuv9E7QywJR4RCXoFNp3VnVIxDfFDfEgUNbbTr/D/9Nw1zYsnMFeW/3ZY qL1bBIxMU6ZO0ATZD/7DrpghNe5n3j2XQd5j061l7oyyWfL4id+he2F3N39JYXRGJQ9clyjj nnd423zDxUeNdqe4TmI6HShgqnIhyyTcIkbDrG/+9ZhiUefwWFVAxoTPXOrrP/8hkOgVtZ3L 00P5jFovaU07FasTNT2Q1u/unHslgEYc8pdFas98g7l90bPy1/HXC5eFGcHMYF48p9tLdA36 rOXt+L2XR1GjKOlcEi2r+vO8D2vKBhIFEZXMEfoUjA5y9XkpYgyiDfGQdBiDLO5g7XJJN3g/ 9yZhHNg3utO1Kbnw43+pAma2Gz0+vAlWyZovl2/Y46z0u9uiGdJjaSM4EOT0/tPJZ3xorKp7 CldwJj2AAzj4PiweM2xrAclQenBCxWtamS0bbtT838JrWzFF5mLJ9043d2GDB01WvvogBewC KMphStf5YVIIFyhZrJtboS6BqwClPa8S4y6Da6IN4MXM/CdkTNrGgk0PiZ8OEi3zSARfVwXY 8/HIa5A815AYUiY8NZGb7hEiuJ6rszP7WjSWYr633yaPUm2PxaopUM+GALWNIgRtfrcyC2Mq oo3H5bamn13DbylCgGKoNF7ELz/BSVibXwAg5cMLbDrz8sPMDxJNsI9Npt6I901x/kOz7yQl px/M2cBoGfCabT8AV3iQhhehHnHB/6TcVpT0fQQAGuV IronPort-HdrOrdr: A9a23:idZC86mo4H/rYRgXzZlyKbqYGyDpDfIm3DAbv31ZSRFFG/Fxl6 iV88jzsiWE7Qr5OUtQ/uxoV5PgfZqxz/NICOoqTNWftWvd2FdARbsKheCJ/9SJIVybygc378 ldmsZFZOEYdWIK7vrH3A== X-IronPort-AV: E=Sophos;i="5.90,146,1643691600"; d="scan'208";a="65210546" From: Anthony PERARD To: CC: , , , Anthony PERARD , Doug Goldstein Subject: [XEN PATCH 0/3] automation: auto-build container, check generated file Date: Tue, 1 Mar 2022 12:11:30 +0000 Message-ID: <20220301121133.19271-1-anthony.perard@citrix.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Patch series available in this git branch: https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git br.gitlab-ci-build-container-v1 I wanted to automatically check that generated files that we have in our repo are up-to-date, those are autoconf and *.gen.go files generataed from libxl_types.idl. But this can only be check on debian stable. So new container, and I look at building the new container from the CI. The second patch depends on some changes to our GitLab runner: https://gitlab.com/xen-project/xen-gitlab-ci/-/merge_requests/15 I've already apply the changes to one runner, for testing. The new debian:stable container is already published, but commiting the change should rebuild it. Thanks. Anthony PERARD (3): automation: adding debian:stable container automation: automatically build debian:stable container automation: check for generated files .gitlab-ci.yml | 2 + automation/build/debian/stable.dockerfile | 53 ++++++++++++++++++++++ automation/gitlab-ci/containers.yaml | 22 +++++++++ automation/gitlab-ci/test.yaml | 10 +++++ automation/scripts/check-generated-files | 55 +++++++++++++++++++++++ 5 files changed, 142 insertions(+) create mode 100644 automation/build/debian/stable.dockerfile create mode 100644 automation/gitlab-ci/containers.yaml create mode 100755 automation/scripts/check-generated-files -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Tue Mar 01 12:11:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 12:11:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281298.479585 (Exim 4.92) (envelope-from ) id 1nP1M2-0000Op-R3; Tue, 01 Mar 2022 12:11:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281298.479585; Tue, 01 Mar 2022 12:11:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP1M2-0000Og-NZ; Tue, 01 Mar 2022 12:11:46 +0000 Received: by outflank-mailman (input) for mailman id 281298; Tue, 01 Mar 2022 12:11:45 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP1M0-0008Ic-S6 for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 12:11:44 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c23443fd-9958-11ec-8eba-a37418f5ba1a; Tue, 01 Mar 2022 13:11:43 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c23443fd-9958-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1646136703; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=cqtCddEDOMO9N2RINgp4gRg+BSZg2vJGBvVef7c4kfs=; b=fNkZWA8hX3vSDkdwh/BlOQpW2wKTSQyt1fQxzXDyatog/f8/OLp2B5VY A+9RzzYLWRAEI4pLsCQnnOHtlFOtZqYcfmYH/JSQcM9xsOC7e0JkQH+Pk 65Q47jxU8o+q1YEaUFRxb7rG+iQ/VKvujtIByE1VZPfl1K18jQ01kQNxt Y=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 65205233 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:wkIlAqnuMJDzGyxqp31RZiHo5gydJkRdPkR7XQ2eYbSJt1+Wr1Gzt xJOWGuDbP+JZDb0Kdwjb46z/BtU7ZSHndBjSwRkqng1EiMWpZLJC+rCIxarNUt+DCFioGGLT Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EoLd9IR2NYy24DiW1rV4 7senuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ NtxWZOYbg10Dq7VxfYhVBgASC8uOu5i9oP/Li3q2SCT5xWun3rExvxvCAc9PJEC+/YxCmZLn RAaAGlTNFbZ3bvwme/lDLk37iggBJCD0Ic3s3d8zTbfHLA+TIrKWani7t5ExjYgwMtJGJ4yY uJHNGA3MU6bOHWjPH9JBJ8kmbewmkXlTDtWjECetPQ14XbqmVkZPL/Fb4OOJ43iqd9utl2Du mvM8mD9AxcbHN+S0zyI9jSrnOCntSjyQo4VGZWz/+Rmh1DVzWsWYDUGWF3+rfSnh0qWX9NEN 1dS6icotbI19kGgUp/6RRLQiGGAlg4RXZxXCeJS1e2W4vOKuUDDXDFCF2MfLox93CMredA0/ niDwuPqHGF9jLqUESmTprDXiT2OASdAeAfuehQ4ZQcC5tDipqQ6gRTOUstvHcaJszHlJd3j6 2vU9XZj3t3/meZOjvzmpg6f31pAs7CUFlZd2+nBYo6yAuqVjqaBbpfg11XU5O0owG2xHgjY5 yhsdyRzAYkz4XCxeM6lHb1l8FKBva/t3NjgbbhHRcFJG9OFoSPLQGyoyGsiTHqFy+5dEdMTX GfduBlK+LhYN2awYKl8buqZUpp2k/C/Toq5D6mNP7Kih6Sdkifdp0mCgmbKggjQfLUEy/lja f93j+72ZZrlNUiX5GXvHLpMuVPa7is/2XnSVfjGI+ePitKjiIquYe5dajOmN7lhhIvd+Vm92 4sPZqOilkQEOMWjM3a/zGLmBQ1TRZTNLcut8JI/my/qClcOJVzN/NeKmeJxI9E+xv8N/goKl 1nkMnJlJJPErSWvAW23hrpLMtsDgb4XQaoHABER IronPort-HdrOrdr: A9a23:crhbyazxyZGY8tnSuOGhKrPwKr1zdoMgy1knxilNoRw8SKOlfq eV7ZMmPH7P+U8ssR4b+OxoVJPsfZqYz+8W3WBzB8bHYOCFgguVxehZhOOIqQEIWReOk9K1vZ 0QFZSWY+efMbEVt6rHCXGDYrUd/OU= X-IronPort-AV: E=Sophos;i="5.90,146,1643691600"; d="scan'208";a="65205233" From: Anthony PERARD To: CC: , , , Anthony PERARD , Doug Goldstein Subject: [XEN PATCH 2/3] automation: automatically build debian:stable container Date: Tue, 1 Mar 2022 12:11:32 +0000 Message-ID: <20220301121133.19271-3-anthony.perard@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220301121133.19271-1-anthony.perard@citrix.com> References: <20220301121133.19271-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Only run this on the staging branch, whenever the dockerfile changes. Signed-off-by: Anthony PERARD --- .gitlab-ci.yml | 2 ++ automation/gitlab-ci/containers.yaml | 22 ++++++++++++++++++++++ 2 files changed, 24 insertions(+) create mode 100644 automation/gitlab-ci/containers.yaml diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index c8bd7519d5..f934d3eff8 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -1,7 +1,9 @@ stages: + - containers - build - test include: + - 'automation/gitlab-ci/containers.yaml' - 'automation/gitlab-ci/build.yaml' - 'automation/gitlab-ci/test.yaml' diff --git a/automation/gitlab-ci/containers.yaml b/automation/gitlab-ci/containers.yaml new file mode 100644 index 0000000000..2daf257f11 --- /dev/null +++ b/automation/gitlab-ci/containers.yaml @@ -0,0 +1,22 @@ +debian-stable-container: + stage: containers + image: docker:stable + variables: + BUILD_CONTAINER: debian/stable + tags: + - container-builder + only: + refs: + - staging + changes: + - automation/build/${BUILD_CONTAINER}.dockerfile + services: + - docker:dind + before_script: + - apk add make + - docker info + - docker login -u $CI_DEPLOY_USER -p $CI_DEPLOY_PASSWORD $CI_REGISTRY + script: + - make -C automation/build ${BUILD_CONTAINER} PUSH=1 + after_script: + - docker logout -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Tue Mar 01 12:11:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 12:11:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281297.479574 (Exim 4.92) (envelope-from ) id 1nP1M1-00007Y-Iz; Tue, 01 Mar 2022 12:11:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281297.479574; Tue, 01 Mar 2022 12:11:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP1M1-00007Q-FV; Tue, 01 Mar 2022 12:11:45 +0000 Received: by outflank-mailman (input) for mailman id 281297; Tue, 01 Mar 2022 12:11:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP1Lz-0008Ic-Qg for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 12:11:43 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c025121f-9958-11ec-8eba-a37418f5ba1a; Tue, 01 Mar 2022 13:11:42 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c025121f-9958-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1646136702; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ud7MXxbX94bNlyXml0X8hASsYOPzgNU7AYPT+z5zGV8=; b=I3Gdhs8ShNjYbIy6U8g83SBnMvezC8+6bTLDMixNRZy6ORPug9067Rce mxMhD1wt8R8RIcLrCMA1Icbh33dEImuDCLJzbON9DlnZX5k+GRmUaXboT M+NBiKStoCRLortPe9CFmxrdQXEmIjVlWEE+6NuWBZD/4Bxj5UmTz0uDM M=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 65205231 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:FJ87bKBgtdeQkRVW/zXjw5YqxClBgxIJ4kV8jS/XYbTApD9302EPz 2oeWGGDaPaJZjfxf90jaoS08EpSuJ7QxtJqQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHWeIdA970Ug5w7Vh29Yy6TSEK1jlV e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhfm NgKpbq3ZD4tJ6KcoNg9dCRCGWZhaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us 6ZCcXZUM07F17neLLGTE4GAguwqKtXrO4UO/Glt1zjDAd4tQIzZQrWM7thdtNs1rp4TR66DP ZFAAdZpRCjvXDhwKHkMM4Adhva2iFXkeixEuE3A8MLb5ECMlVcsgdABKuH9YceWTM9YmkKZo GPu/GnjBBwectuFxlKt+Xu2iujCtSjyQo4VGfuz8fsCqE2ewCkfBQMbUXO/oOKlkQiuVtRHM UsW9yEy668o+ySDUd3VTxC+5nmesXYht8F4SrNgrlvXk+yNvljfVjNsoiN9hMIOmp87AiwM0 XKwm8rmVQRTkJqoU3ja6eLBxd+tAhQ9IWgHbC4CaAIK5dj/vY0+5i7yosZf/L2d1YOsR2ypq 9yehG1n3uhI05ZXv0mu1Q2f21qRSo71ohnZD+k9dkas9UtHaYGsfOREAnCLvK8bfO51orRs1 UXoevRyDshTVflhdwTXGY3h+Y1FAd7faFUwZnY1QvEcG8yFoSLLQGypyGgWyL1VGsgFYyT1R 0TYpBlc4pReVFPzM/MpO93qVZhzlPGxfTgAahwyRoAVCnSWXFXalByCmGbKhzy9+KTSuftX1 WinnTaEUi9BVPUPIMueTOYBy747rh3SNkuILa0XOy+PiOLEDFbMEO9tGALXMogRsfPVyC2Io o03H5bblH1ivBjWP3C/HXg7dgtRcxDWxPne9qRqSwJ0ClE+STF5VqSImutJlk4Mt/09q9okN 0qVAidwoGcTT1WdQelWQhiPsI/SYKs= IronPort-HdrOrdr: A9a23:x5wfiaGUJ/VBdCIfpLqE0MeALOsnbusQ8zAXP0AYc3Jom6uj5q aTdZUgpGfJYVkqOE3I9ertBEDEewK4yXcX2/h3AV7BZniEhILAFugLhuGO/9SjIVybygc079 YYT0EUMrzN5DZB4voSmDPIceod/A== X-IronPort-AV: E=Sophos;i="5.90,146,1643691600"; d="scan'208";a="65205231" From: Anthony PERARD To: CC: , , , Anthony PERARD , Doug Goldstein Subject: [XEN PATCH 1/3] automation: adding debian:stable container Date: Tue, 1 Mar 2022 12:11:31 +0000 Message-ID: <20220301121133.19271-2-anthony.perard@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220301121133.19271-1-anthony.perard@citrix.com> References: <20220301121133.19271-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain This container will be used to check that generated source file in the git repository are up to date. Signed-off-by: Anthony PERARD --- automation/build/debian/stable.dockerfile | 53 +++++++++++++++++++++++ 1 file changed, 53 insertions(+) create mode 100644 automation/build/debian/stable.dockerfile diff --git a/automation/build/debian/stable.dockerfile b/automation/build/debian/stable.dockerfile new file mode 100644 index 0000000000..912c4a5345 --- /dev/null +++ b/automation/build/debian/stable.dockerfile @@ -0,0 +1,53 @@ +FROM debian:stable +LABEL maintainer.name="The Xen Project" \ + maintainer.email="xen-devel@lists.xenproject.org" + +RUN useradd -ms /bin/bash user +ENV DEBIAN_FRONTEND=noninteractive + +# build depends +RUN apt-get update && \ + apt-get --quiet --yes install \ + build-essential \ + autoconf \ + zlib1g-dev \ + libncurses5-dev \ + libssl-dev \ + python3-dev \ + xorg-dev \ + uuid-dev \ + libyajl-dev \ + libaio-dev \ + libglib2.0-dev \ + clang \ + libpixman-1-dev \ + pkg-config \ + flex \ + bison \ + # gettext for Xen < 4.13 + gettext \ + acpica-tools \ + bin86 \ + bcc \ + liblzma-dev \ + # libc6-dev-i386 for Xen < 4.15 + libc6-dev-i386 \ + libnl-3-dev \ + ocaml-nox \ + libfindlib-ocaml-dev \ + markdown \ + transfig \ + pandoc \ + checkpolicy \ + wget \ + git \ + nasm \ + gnupg \ + golang \ + && \ + apt-get autoremove -y && \ + apt-get clean && \ + rm -rf /var/lib/apt/lists* /tmp/* /var/tmp/* + +USER user +WORKDIR /build -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Tue Mar 01 12:20:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 12:20:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281324.479606 (Exim 4.92) (envelope-from ) id 1nP1US-0003Ef-0r; Tue, 01 Mar 2022 12:20:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281324.479606; Tue, 01 Mar 2022 12:20:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP1UR-0003EY-Tv; Tue, 01 Mar 2022 12:20:27 +0000 Received: by outflank-mailman (input) for mailman id 281324; Tue, 01 Mar 2022 12:20:27 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP1UR-0003ES-33 for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 12:20:27 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f88dc28b-9959-11ec-8eba-a37418f5ba1a; Tue, 01 Mar 2022 13:20:25 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f88dc28b-9959-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1646137225; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=K+M57JmbFWzBV5opLBEASvneUAOtiGXhgVOGDtf1NNA=; b=Q3GJsSOtmolKcaeNdVZZbufA9cf8LrkT0C+Cjp7I98yMGLGj0abaD/8B ylH+cDsUTRFwrfuiUTKtiJE/26fQ+nUtHObCurY8rLPfUnJW0jxUDS/7u 2lBfWXij54Q/pVEiwADcZgS3UrdIwWDzjvpTQ3Zomm1igOzoivNCVmdlN c=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 65211002 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:PtWV0qOsMDyim+nvrR25l8FynXyQoLVcMsEvi/4bfWQNrUon0WRTy 2QbC2GAPK6MZjGkeI0nb4m0pBsC6p+GzYc1Swto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFcMpBsJ00o5wbZi2tcw27BVPivW0 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z1 sgQmoS/dgESPfP2xeIPCRtDQwxEFPgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr 7pCcmlLN03dwbLtqF64YrAEasALJc/3PIQZqzd4wCvQF/oOSpHfWaTao9Rf2V/cg+gQQKyHP pJBM1KDajzickZDJlhGGqg4ws2ap2f5IhZ0tVe88P9fD2/7k1UqjemF3MDuUseRWcxfk0Kcp 2TH12f0GBcXMJqY0zXt2nmlnOPIkAvwUZgeE7D+/flv6HWDy2pWBBAIWF+TpfiillX4S99ZM 1YT+Cclse417kPDZsb5dw21pjiDpBF0ZjZLO7RkskfXkPOSulvHQDhfJtJcVDA4nNErGBMy2 WCPpNC3P2FpoueXUiKwzJ7B+FteJhMpBWMFYCYFSy4M7N/ivJw/g3rzczpzLEKmpoarQG+tm lhmuAB73uxO1pBTi81X6Hia22rEm3TfcuIiCuw7tEqB5xgxWoOqbpfABbPzvacZd9bxorVsU RE5dymiAAImUMnleM+lGrxl8FSVCxCtamW0bblHRcRJythV0yT/Fb28GRknTKuTDu4KeCXyf GjYsh5L6ZlYMROCNPErPdruUJp2lPG5RLwJs8w4iPIUOfCdkyfdoUlTibO4hTixwCDAb4llU XtkTSpcJSlDUvk2pNZHb+wczaUq1kgDKZD7HvjGI+Cc+ePGPha9EO5dWHPXN7xRxP7U8W39r ocEX+PXmko3bQELSnSOmWLlBQtRdiZT6FGfg5E/S9Nv1SI9QDBxU6KKmOh5E2Gn9owM/tr1E riGchcw4DLCabfvcG1mtlgLhGvTYKtC IronPort-HdrOrdr: A9a23:yF1F5q7kR5GTYRhLYgPXwMjXdLJyesId70hD6qhwISY6TiW9rb HLoB17726QtN9/YhwdcLy7VJVoBEmskqKdgrNhX4tKPjOHhILAFugLhuHfKn/bak7DH4ZmpM FdmsNFaeEYY2IUsfrH X-IronPort-AV: E=Sophos;i="5.90,146,1643691600"; d="scan'208";a="65211002" Date: Tue, 1 Mar 2022 12:20:20 +0000 From: Anthony PERARD To: CC: , , , "Doug Goldstein" Subject: Re: [XEN PATCH 0/3] automation: auto-build container, check generated file Message-ID: References: <20220301121133.19271-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20220301121133.19271-1-anthony.perard@citrix.com> On Tue, Mar 01, 2022 at 12:11:30PM +0000, Anthony PERARD wrote: > Patch series available in this git branch: > https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git br.gitlab-ci-build-container-v1 > > I wanted to automatically check that generated files that we have in our repo > are up-to-date, those are autoconf and *.gen.go files generataed from > libxl_types.idl. But this can only be check on debian stable. So new container, > and I look at building the new container from the CI. > > The second patch depends on some changes to our GitLab runner: > https://gitlab.com/xen-project/xen-gitlab-ci/-/merge_requests/15 > I've already apply the changes to one runner, for testing. > > The new debian:stable container is already published, but commiting the change > should rebuild it. Forgot to say that this series also depends on my previous one: [XEN PATCH 0/4] Some improvement for gitlab CI jobs <20220228145523.8954-1-anthony.perard@citrix.com> (for the last patch) -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Tue Mar 01 12:40:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 12:40:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281334.479635 (Exim 4.92) (envelope-from ) id 1nP1nz-00068p-7m; Tue, 01 Mar 2022 12:40:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281334.479635; Tue, 01 Mar 2022 12:40:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP1nz-00068i-1f; Tue, 01 Mar 2022 12:40:39 +0000 Received: by outflank-mailman (input) for mailman id 281334; Tue, 01 Mar 2022 12:40:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP1nx-0005sl-8S for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 12:40:37 +0000 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on20605.outbound.protection.outlook.com [2a01:111:f400:7e89::605]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c9aa9b9b-995c-11ec-8539-5f4723681683; Tue, 01 Mar 2022 13:40:35 +0100 (CET) Received: from SN2PR01CA0023.prod.exchangelabs.com (2603:10b6:804:2::33) by MN2PR02MB5789.namprd02.prod.outlook.com (2603:10b6:208:11e::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.24; Tue, 1 Mar 2022 12:40:30 +0000 Received: from SN1NAM02FT0008.eop-nam02.prod.protection.outlook.com (2603:10b6:804:2:cafe::8c) by SN2PR01CA0023.outlook.office365.com (2603:10b6:804:2::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22 via Frontend Transport; Tue, 1 Mar 2022 12:40:30 +0000 Received: from xir-pvapexch01.xlnx.xilinx.com (149.199.80.198) by SN1NAM02FT0008.mail.protection.outlook.com (10.97.5.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5017.22 via Frontend Transport; Tue, 1 Mar 2022 12:40:29 +0000 Received: from xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Tue, 1 Mar 2022 12:40:28 +0000 Received: from smtp.xilinx.com (172.21.105.198) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Tue, 1 Mar 2022 12:40:28 +0000 Received: from [10.108.8.223] (port=53852 helo=xcbayankuma41x.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1nP1nn-0000Ui-E4; Tue, 01 Mar 2022 12:40:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c9aa9b9b-995c-11ec-8539-5f4723681683 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JWkYG6IsxD98zWO/PTntRRXAGNpiCFZ5m2MTz+NczXGmqgmzXOmb61sCiRrsx0cgTu470mGSpoOIwgubL03DW4y6u004an2sMrxbGTtjN6vpSGOGKghc5HUcPsXHjxpTlLQgR8I2z0kqepG3CaymOOKqWNNJUh2VWQLWWzaFTMEcHz3AW8sLEFqNVopN5mAYsF7IOKdXG63G9wamzEelJzjeamlHnwjxRml+4tFcb+wpnSpdlyCgRiHeXBIPxEHugnzyCENLkNXA3TMIAOAEPdEGTYzmyElqPAOc4CLl1QFUs8spwwR58a2keUWc6a82+HctRy6bFGe/jQA72QdDoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+8o+9YqgUrb/hZmnZVc0UJwjMZa2ok5VdKErypv1CWA=; b=nIs4ZL9Y50uOtuGMr2h+UDusOmyID/I2rqNPrtLrHLyXZJ96AuZUjvhfekB+YE4uZ7Ggjxzjay/Rct/nstZ2OSBI4PcACqaxKVNxg63XV5e0/nLIsqNwvY7ob3A74z42F+z2yCuTctJJVTQiPChLFdMQLSOs7r5ONU69bAQ449lxIniQwKfBrgIFKjtWZfpLgBUVwV5Tpv0b/6+8r0bHHVxZto0BWHbGQd67MLP/23HyFe1/2+IUMCyD0OhIoS7apbnzEJ+f6yAFW7vpRTgnjFUojbH7u+Qlrb7UrXGkIl2qoNVDF/7ue7dlGfvm4dX9pFqy1GIGytv2hLO4T1MS+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+8o+9YqgUrb/hZmnZVc0UJwjMZa2ok5VdKErypv1CWA=; b=AjSpIuuuitsivCu0lnB85CBTJ3YjBzlY24BA4tIHK6murMzFDZ+CP5yP3OVerAk7zSNLzeg2goZbcB1M/CCKAEHcm9ZBoL8+ofG8QZd5tHHL6N0DDPkgqgHtvogeVrzibP+7f4xfE/eqzHEgQ/w9XSmOgIlrvDkAaWuIUsxjUYk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.80.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.80.198; helo=xir-pvapexch01.xlnx.xilinx.com; From: Ayan Kumar Halder To: CC: , , , , , , , , , , , Ayan Kumar Halder Subject: [XEN v9 1/4] xen/arm64: Decode ldr/str post increment operations Date: Tue, 1 Mar 2022 12:40:19 +0000 Message-ID: <20220301124022.10168-2-ayankuma@xilinx.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220301124022.10168-1-ayankuma@xilinx.com> References: <20220301124022.10168-1-ayankuma@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6defbd93-9392-4130-6e1c-08d9fb80ab89 X-MS-TrafficTypeDiagnostic: MN2PR02MB5789:EE_ X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uAsw3kCEpuF9xuCyCTcGTWwwTIBaae0a3G805rvbUBXsGLqDZ5BAJx2XMQrYRkt+fJxsRJ2ZEA4xv7T8pMm9+RTKwp8lqFpnLP/uxRBMldPgZ1jF3NJGa655+A5WW17Or0lJn9rCP8Sg25nyfITxioy8h0JY4sWPIuzsEfajLAMO9qNENrt6SltaCVqffBnY32Wah5nPICHZSBEBcSOKtQsokWHHxmQxZhWmDfV0KtmmFWi+hms3a817A0KjU9sFj8+eaxk11zt0ct6Jg3elSZtp9CjXRHqv0rf7X8enfzUrETGIFBx0SfH28US8FzX63EM8WN4028SZPyeBEURde3VsyOiDaLAbY0ViEN8QroWyLF4uzD6LrH3xa66qLiYkArzGOta88tlR2TBku3j+J9Rdv3s42sKZnmwBAFQHvHksI29LBXEEwZ3P57WIo203Wo5vmkDc+4bN37Daojr2quD4MeDI4vM3VoXm8Oat1m1kXm7mSUz4oS+aUgw8yunApe5MwNm1sP+3lrnxL+O848djA3DExiP2PES9hiW+tUOabNEcnYuJzpzC4p+wWNqGFdVt/pryEnINpRA/Hc70Rm/uU7z3H9tzWK3UCE78BVtmMNaPHHaa2bQp9UcMyYylsWC3n/K5mEJ6I5rxR74eN2Pw1R2Ra2YVfjV4kZ6U60ZGjOR8IyLpGgfTCZNchnbj/1qTxgMqt8sSmYy0qf5U3Q== X-Forefront-Antispam-Report: CIP:149.199.80.198;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:xir-pvapexch01.xlnx.xilinx.com;PTR:unknown-80-198.xilinx.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(26005)(54906003)(40460700003)(6916009)(6666004)(186003)(36756003)(356005)(7416002)(82310400004)(107886003)(2616005)(5660300002)(1076003)(316002)(508600001)(47076005)(7636003)(7696005)(83380400001)(2906002)(70586007)(8676002)(70206006)(336012)(426003)(8936002)(4326008)(36860700001)(9786002)(102446001);DIR:OUT;SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2022 12:40:29.9276 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6defbd93-9392-4130-6e1c-08d9fb80ab89 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.80.198];Helo=[xir-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: SN1NAM02FT0008.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR02MB5789 At the moment, Xen does not decode any of the arm64 instructions. This means that when hsr_dabt.isv == 0, Xen cannot handle those instructions. This will lead to Xen to abort the guests (from which those instructions originate). With this patch, Xen is able to decode ldr/str post indexing instructions. These are a subset of instructions for which hsr_dabt.isv == 0. The following instructions are now supported by Xen :- 1. ldr x2, [x1], #8 2. ldr w2, [x1], #-4 3. ldr x2, [x1], #-8 4. ldr w2, [x1], #4 5. ldrh w2, [x1], #2 6. ldrb w2, [x1], #1 7. str x2, [x1], #8 8. str w2, [x1], #-4 9. strh w2, [x1], #2 10. strb w2, [x1], #1 In the subsequent patch, decode_arm64() will get invoked when hsr_dabt.isv == 0. Signed-off-by: Ayan Kumar Halder --- Changelog :- v2..v5 - Mentioned in the cover letter. v6 - 1. Fixed the code style issues as mentioned in v5. v7 - No change. v8 - 1. Removed some un-necessary header files inclusion. 2. Some style changes pointed out in v7. v9 - 1. Rebased on top of the master. 2. Renamed psr_mode_is_32bit to regs_mode_is_32bit. xen/arch/arm/decode.c | 79 ++++++++++++++++++++++++++++++++- xen/arch/arm/decode.h | 48 +++++++++++++++++--- xen/arch/arm/include/asm/mmio.h | 4 ++ xen/arch/arm/io.c | 2 +- 4 files changed, 124 insertions(+), 9 deletions(-) diff --git a/xen/arch/arm/decode.c b/xen/arch/arm/decode.c index 792c2e92a7..3add87e83a 100644 --- a/xen/arch/arm/decode.c +++ b/xen/arch/arm/decode.c @@ -84,6 +84,78 @@ bad_thumb2: return 1; } +static int decode_arm64(register_t pc, mmio_info_t *info) +{ + union instr opcode = {0}; + struct hsr_dabt *dabt = &info->dabt; + struct instr_details *dabt_instr = &info->dabt_instr; + + if ( raw_copy_from_guest(&opcode.value, (void * __user)pc, sizeof (opcode)) ) + { + gprintk(XENLOG_ERR, "Could not copy the instruction from PC\n"); + return 1; + } + + /* + * Refer Arm v8 ARM DDI 0487G.b, Page - C6-1107 + * "Shared decode for all encodings" (under ldr immediate) + * If n == t && n != 31, then the return value is implementation defined + * (can be WBSUPPRESS, UNKNOWN, UNDEFINED or NOP). Thus, we do not support + * this. This holds true for ldrb/ldrh immediate as well. + * + * Also refer, Page - C6-1384, the above described behaviour is same for + * str immediate. This holds true for strb/strh immediate as well + */ + if ( (opcode.ldr_str.rn == opcode.ldr_str.rt) && (opcode.ldr_str.rn != 31) ) + { + gprintk(XENLOG_ERR, "Rn should not be equal to Rt except for r31\n"); + goto bad_loadstore; + } + + /* First, let's check for the fixed values */ + if ( (opcode.value & POST_INDEX_FIXED_MASK) != POST_INDEX_FIXED_VALUE ) + { + gprintk(XENLOG_ERR, + "Decoding instruction 0x%x is not supported\n", opcode.value); + goto bad_loadstore; + } + + if ( opcode.ldr_str.v != 0 ) + { + gprintk(XENLOG_ERR, + "ldr/str post indexing for vector types are not supported\n"); + goto bad_loadstore; + } + + /* Check for STR (immediate) */ + if ( opcode.ldr_str.opc == 0 ) + dabt->write = 1; + /* Check for LDR (immediate) */ + else if ( opcode.ldr_str.opc == 1 ) + dabt->write = 0; + else + { + gprintk(XENLOG_ERR, + "Decoding ldr/str post indexing is not supported for this variant\n"); + goto bad_loadstore; + } + + gprintk(XENLOG_INFO, + "opcode->ldr_str.rt = 0x%x, opcode->ldr_str.size = 0x%x, opcode->ldr_str.imm9 = %d\n", + opcode.ldr_str.rt, opcode.ldr_str.size, opcode.ldr_str.imm9); + + update_dabt(dabt, opcode.ldr_str.rt, opcode.ldr_str.size, false); + + dabt_instr->rn = opcode.ldr_str.rn; + dabt_instr->imm9 = opcode.ldr_str.imm9; + + return 0; + + bad_loadstore: + gprintk(XENLOG_ERR, "unhandled Arm instruction 0x%x\n", opcode.value); + return 1; +} + static int decode_thumb(register_t pc, struct hsr_dabt *dabt) { uint16_t instr; @@ -150,10 +222,13 @@ bad_thumb: return 1; } -int decode_instruction(const struct cpu_user_regs *regs, struct hsr_dabt *dabt) +int decode_instruction(const struct cpu_user_regs *regs, mmio_info_t *info) { if ( is_32bit_domain(current->domain) && regs->cpsr & PSR_THUMB ) - return decode_thumb(regs->pc, dabt); + return decode_thumb(regs->pc, &info->dabt); + + if ( !regs_mode_is_32bit(regs) ) + return decode_arm64(regs->pc, info); /* TODO: Handle ARM instruction */ gprintk(XENLOG_ERR, "unhandled ARM instruction\n"); diff --git a/xen/arch/arm/decode.h b/xen/arch/arm/decode.h index 4613763bdb..13db8ac968 100644 --- a/xen/arch/arm/decode.h +++ b/xen/arch/arm/decode.h @@ -23,19 +23,55 @@ #include #include -/** +/* + * Refer to the ARMv8 ARM (DDI 0487G.b), Section C4.1.4 Loads and Stores + * Page 318 specifies the following bit pattern for + * "load/store register (immediate post-indexed)". + * + * 31 30 29 27 26 25 23 21 20 11 9 4 0 + * ___________________________________________________________________ + * |size|1 1 1 |V |0 0 |opc |0 | imm9 |0 1 | Rn | Rt | + * |____|______|__|____|____|__|_______________|____|_________|_______| + */ +union instr { + uint32_t value; + struct { + unsigned int rt:5; /* Rt register */ + unsigned int rn:5; /* Rn register */ + unsigned int fixed1:2; /* value == 01b */ + signed int imm9:9; /* imm9 */ + unsigned int fixed2:1; /* value == 0b */ + unsigned int opc:2; /* opc */ + unsigned int fixed3:2; /* value == 00b */ + unsigned int v:1; /* vector */ + unsigned int fixed4:3; /* value == 111b */ + unsigned int size:2; /* size */ + } ldr_str; +}; + +#define POST_INDEX_FIXED_MASK 0x3B200C00 +#define POST_INDEX_FIXED_VALUE 0x38000400 + +/* * Decode an instruction from pc - * /!\ This function is not intended to fully decode an instruction. It - * considers that the instruction is valid. + * /!\ This function is intended to decode an instruction. It considers that the + * instruction is valid. * - * This function will get: - * - The transfer register + * In case of thumb mode, this function will get: + * - The transfer register (ie Rt) * - Sign bit * - Size + * + * In case of arm64 mode, this function will get: + * - The transfer register (ie Rt) + * - The source register (ie Rn) + * - Size + * - Immediate offset + * - Read or write */ int decode_instruction(const struct cpu_user_regs *regs, - struct hsr_dabt *dabt); + mmio_info_t *info); #endif /* __ARCH_ARM_DECODE_H_ */ diff --git a/xen/arch/arm/include/asm/mmio.h b/xen/arch/arm/include/asm/mmio.h index 7ab873cb8f..3354d9c635 100644 --- a/xen/arch/arm/include/asm/mmio.h +++ b/xen/arch/arm/include/asm/mmio.h @@ -29,6 +29,10 @@ typedef struct { struct hsr_dabt dabt; + struct instr_details { + unsigned long rn:5; + signed int imm9:9; + } dabt_instr; paddr_t gpa; } mmio_info_t; diff --git a/xen/arch/arm/io.c b/xen/arch/arm/io.c index 1a066f9ae5..fad103bdbd 100644 --- a/xen/arch/arm/io.c +++ b/xen/arch/arm/io.c @@ -141,7 +141,7 @@ enum io_state try_handle_mmio(struct cpu_user_regs *regs, { int rc; - rc = decode_instruction(regs, &info.dabt); + rc = decode_instruction(regs, &info); if ( rc ) { gprintk(XENLOG_DEBUG, "Unable to decode instruction\n"); -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue Mar 01 12:40:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 12:40:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281333.479624 (Exim 4.92) (envelope-from ) id 1nP1nx-0005t0-Qt; Tue, 01 Mar 2022 12:40:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281333.479624; Tue, 01 Mar 2022 12:40:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP1nx-0005st-N2; Tue, 01 Mar 2022 12:40:37 +0000 Received: by outflank-mailman (input) for mailman id 281333; Tue, 01 Mar 2022 12:40:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP1nv-0005sf-S7 for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 12:40:35 +0000 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam08on20606.outbound.protection.outlook.com [2a01:111:f400:7e8c::606]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c947ded3-995c-11ec-8eba-a37418f5ba1a; Tue, 01 Mar 2022 13:40:33 +0100 (CET) Received: from SN6PR01CA0020.prod.exchangelabs.com (2603:10b6:805:b6::33) by BN6PR02MB2577.namprd02.prod.outlook.com (2603:10b6:404:58::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Tue, 1 Mar 2022 12:40:27 +0000 Received: from SN1NAM02FT0021.eop-nam02.prod.protection.outlook.com (2603:10b6:805:b6:cafe::fd) by SN6PR01CA0020.outlook.office365.com (2603:10b6:805:b6::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.23 via Frontend Transport; Tue, 1 Mar 2022 12:40:27 +0000 Received: from xir-pvapexch02.xlnx.xilinx.com (149.199.80.198) by SN1NAM02FT0021.mail.protection.outlook.com (10.97.5.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5017.22 via Frontend Transport; Tue, 1 Mar 2022 12:40:26 +0000 Received: from xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Tue, 1 Mar 2022 12:40:25 +0000 Received: from smtp.xilinx.com (172.21.105.198) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Tue, 1 Mar 2022 12:40:25 +0000 Received: from [10.108.8.223] (port=53852 helo=xcbayankuma41x.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1nP1nl-0000Ui-3X; Tue, 01 Mar 2022 12:40:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c947ded3-995c-11ec-8eba-a37418f5ba1a ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J+TZLWJ4YhOfNAvgCEacUVtsXGCUyeKiS/f+mMNPQIx9qhyXB+PTOaTqoOgCZREBbLfTd4ol7RCcgbqZoFxUtHDyIGtDigRuylnIbVcuMfLo4lERbiRkImpOw6JYGzGJUCiunBvYua6bnAjx2CgtZr7D8yFTKElnPcooznuED/KOWc5IoDQMB7QxAQWIryxi4HWjzYWxsWay1HQeYy5Od8dvHcbUYkKu2Zan387mFPR8/BohRGLJBIOvGaSumc+cB02N60bnCmHkcAfQaeT/nftLRaFX/30jt3ziXumTIWKo4kAOxupWGM17cqT8CSRV5mi9RE9kY8x+R0H5etXCpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=s7JM5sSqmCS0X6wpG3eHNfOa7X8ZI8f0x0HeN9KJuhU=; b=Rtq9UaqBnh/YaqUI1tAziKyjyi+hXQjzws6cUZaEeCYKQ9g4nZwV2V5ZHa9FEvl9kkxXCJLn8jB3fJnO7k86nYdB42oAFl9SRHwneuIif7Lz6YpPOQyHJzHpDq3eYbjfyovgDVHDQWBoJkAfAORBBm54yhm6UTH6g6M0P75ltgCeUUFmJW7wutzWKgDN3v2e+4nZXb7xN2uzMxuBObGxJfAbjDEv+ocXomC0KUwMzEeokIFeueXElH4PonSA2CCwP0cWaqfmMnB+m9cuYd1wBkLGGeJaltiFJl4E6jVr9u4VY7RdzmFloVQLklbC21mOeBncqQ4CK/3IEnzcrC42sg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s7JM5sSqmCS0X6wpG3eHNfOa7X8ZI8f0x0HeN9KJuhU=; b=Kt7WwKak+XY/VaDtv4TbOnnrm4wrkhdzf1idNJJGUdAqbOaNE9zdjtXknhhgMHFBNJmpCxCVbpyzMcsmSi4ah9V27PWB/hXUXnHLj3we+4MnZGBphjo8dtGsHc3nemEnYz2geuM4GBxJZ2tYKESwA/5PfcCAXg97mPx60rS/XIs= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.80.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.80.198; helo=xir-pvapexch02.xlnx.xilinx.com; From: Ayan Kumar Halder To: CC: , , , , , , , , , , , Ayan Kumar Halder Subject: [XEN v9 0/4] xen/arm64: io: Decode ldr/str post-indexing instruction Date: Tue, 1 Mar 2022 12:40:18 +0000 Message-ID: <20220301124022.10168-1-ayankuma@xilinx.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 83578c97-1964-4599-5bdd-08d9fb80a9c4 X-MS-TrafficTypeDiagnostic: BN6PR02MB2577:EE_ X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +P0iazNZpEJYmIPFUKfHMJNnQfrjDkEcEc1wKHwxu/YXS3TpqbvTR+FUAfS8RSVbo+0TvF6LqDv4TvqzG1W9bkzfhC1FuNigjHnRglqdb8ucWk5Jr6zgzxP/Pmt6+1b/OcwGqCwGYAS/UgjyyXUtIiaI08WVmke89oy1NnL/H6IvZ7fwQTSCZ8hmZNM8XX9pWagxwRVb4ckJgbqD95vAOES3DJid5XiboLB0CkbOQ+UI6NdiVD3SnVr00PhsZjwbj3uEnWqE77wBJaoLS92PsMOuWeGMyiRLJ9zpmB3afokNhnQgoaRSAa9HQ3e0/VyNxmwGwyesE8BANHXp5MC0n0jOOujWyhHmlGQvGOjeREhfvPXQ6peqch4aA2SFurPN2UDWGIFAur2so+e410TkQjecYjEtN0/AIIuSxQc8uDwGyGZSZV+IhHICifecmmbmSFzmnM0oo0ueID0bmdBZOiDGSxqLQUtYm5h01pGfi8Lvc3z5CQcBNMlsjot/PrHLLcP0alyDSDnYnFgZ6N38PPk4Ze50wi5lrVtVZk3B5JhtyILeHhtJpRuPlQlzMFU/ZryS/QinPJusHQMEedDHgHGj3fwJR+z99GK7j7ksSItyztgseoVNADmd+bqHHBWs/itH9wycNY61MObGcDVVgWVGMU8KKZPtGdb+Sl1Xu7VfSP2Qf62djsRUGCN077ZaizgJlcAKa96E5W6lfbKJ9Q== X-Forefront-Antispam-Report: CIP:149.199.80.198;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:xir-pvapexch02.xlnx.xilinx.com;PTR:unknown-80-198.xilinx.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(70586007)(70206006)(6666004)(54906003)(8676002)(7696005)(508600001)(82310400004)(336012)(7636003)(356005)(186003)(6916009)(426003)(2616005)(47076005)(36860700001)(1076003)(107886003)(83380400001)(26005)(4326008)(5660300002)(8936002)(9786002)(7416002)(36756003)(2906002)(316002)(102446001)(473944003);DIR:OUT;SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2022 12:40:26.9427 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 83578c97-1964-4599-5bdd-08d9fb80a9c4 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.80.198];Helo=[xir-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: SN1NAM02FT0021.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR02MB2577 Hi All, The patch series introduces support to decode instructions by Xen when ISS is invalid. Currently, when the guest executes post indexing ldr/str instructions on emulated MMIO, these instructions are trapped into Xen as a data abort. Xen reads hsr_dabt.isv == 0, so ISS is invalid. Therefore, it reads the faulting instruction's opcode from guest's PC. It decodes and executes the instruction on the emulated region. While doing the patch, we found two bugs in the codebase. I have addressed them in patches 3 and 4. These bugs were discussed with Julien on IRC chat. The purpose of addressing these bugs (in this series) is that 1. We should not forget about them. 2. To get clarity if our understanding is correct. Ayan Kumar Halder (4): xen/arm64: Decode ldr/str post increment operations xen/arm64: io: Support instructions (for which ISS is not valid) on emulated MMIO region using MMIO/ioreq handler xen/arm64: io: Handle the abort due to access to stage1 translation table xen/arm64: io: Handle data abort due to cache maintenance instructions xen/arch/arm/arm32/traps.c | 11 +++ xen/arch/arm/arm64/traps.c | 47 +++++++++++++ xen/arch/arm/decode.c | 80 ++++++++++++++++++++- xen/arch/arm/decode.h | 48 +++++++++++-- xen/arch/arm/include/asm/domain.h | 4 ++ xen/arch/arm/include/asm/mmio.h | 22 +++++- xen/arch/arm/include/asm/traps.h | 2 + xen/arch/arm/io.c | 112 +++++++++++++++++++++--------- xen/arch/arm/ioreq.c | 7 +- xen/arch/arm/traps.c | 93 ++++++++++++++++++++----- xen/arch/x86/include/asm/ioreq.h | 3 + xen/include/xen/sched.h | 2 + 12 files changed, 369 insertions(+), 62 deletions(-) Changelog :- v2 - 1. Updated the rn register after reading from it. (Pointed by Julien, Stefano) 2. Used a union to represent the instruction opcode (Suggestd by Bertrand) 3. Fixed coding style issues (Pointed by Julien) 4. In the previous patch, I was updating dabt->sign based on the signedness of imm9. This was incorrect. As mentioned in ARMv8 ARM DDI 0487G.b, Page 3221, SSE indicates the signedness of the data item loaded. In our case, the data item loaded is always unsigned. v3- 1. Handled all the variants of ldr/str (ie 64, 32, 16, 8 bit variants). Thus, I have removed the check for "instr->code.opc == 0" (Suggested by Andre) 2. Handled the scenario when rn = SP, rt = XZR (Suggested by Jan, Andre) 3. Added restriction for "rt != rn" (Suggested by Andre) 4. Moved union ldr_str_instr_class {} to decode.h. This is the header included by io.c and decode.c (where the union is referred). (Suggested by Jan) 5. Indentation and typo fixes (Suggested by Jan) v4- 1. Fixed the patch as per Stefano's comments on v3. They are as follows :- 1.1 Use macros to determine the fixed values in the instruction opcode 1.2 Checked if instr != NULL 1.3 Changed some data types and added #define ARM_64 for AArch64 specific code 1.4 Moved post_increment_register() to decode.c so that the decoding logic is confined to a single file. 1.5 Moved some checks from post_increment_register() to decode_loadstore_postindexing() 1.6 Removed a duplicate check 2. Updated the commit message as per Andre's comments. 3. Changed the names of a label and some comments. *32bit* was erroneously mentioned in a label and comments in decode_loadstore_postindexing() although the function handled all variants of ldr/str post indexing. v5- 1. Renamed decode_loadstore_postindexing() to decode_arm64(). The reason being this will be extended in future to support more instructions for which hsr_badt.isv = 0 2. Introduce a function try_decode_instruction_invalid_iss() to determine if the instruction needs to be decoded before invoking decode_instruction(). It checks :- 2.1 dabt->s1ptw - Returns IO_UNHANDLED 2.2 dabt->cache - Returns IO_IGNORED. (new enum instroduced to let the caller know that the instruction needs to be ignored by Xen. Thus the caller needs to increment the PC and return to the guest. 3. Invoked try_decode_instruction_invalid_iss() from the following 2 places :- 3.a - try_handle_mmio() - When we have determined that there is a valid mmio handler. 3.b - try_fwd_ioserv() When ioserver completes the io request, the acknowledgement is sent via handle_ioserv(). Here, we need to increment the register. As there is no common data shared between try_fwd_ioserv() and handle_ioserv(), we need to decode the instruction again in handle_ioserv() to determine rn, imm9. (NOTE to Reviewers) - This does not feel correct. However, I could not think of a better approach. Please provide your inputs. 4. Augumented struct hsr_dabt{} with struct hsr_dabt_instr_details{} to hold rn and imm9. This is passed to post_increment_register() to update rn. 5. Other style changes as suggested in v4. v6 - 1. Split the patch into three parts. v7 - 1. Merged patch2 and patch3 into a single patch. v8 - 1. Changes mentioned in the individual patches. v9 - 1. Added patches 3 and 4 to address the bugs found in the existing codebase. 2. Changes mentioned in the individual patches. -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue Mar 01 12:40:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 12:40:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281337.479666 (Exim 4.92) (envelope-from ) id 1nP1o1-0006pu-BM; Tue, 01 Mar 2022 12:40:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281337.479666; Tue, 01 Mar 2022 12:40:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP1o1-0006o8-5x; Tue, 01 Mar 2022 12:40:41 +0000 Received: by outflank-mailman (input) for mailman id 281337; Tue, 01 Mar 2022 12:40:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP1nz-0005sf-ER for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 12:40:39 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2060b.outbound.protection.outlook.com [2a01:111:f400:fe59::60b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cb8ae4f1-995c-11ec-8eba-a37418f5ba1a; Tue, 01 Mar 2022 13:40:38 +0100 (CET) Received: from SN4PR0501CA0065.namprd05.prod.outlook.com (2603:10b6:803:41::42) by SA2PR02MB7595.namprd02.prod.outlook.com (2603:10b6:806:146::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.24; Tue, 1 Mar 2022 12:40:35 +0000 Received: from SN1NAM02FT0034.eop-nam02.prod.protection.outlook.com (2603:10b6:803:41:cafe::26) by SN4PR0501CA0065.outlook.office365.com (2603:10b6:803:41::42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.9 via Frontend Transport; Tue, 1 Mar 2022 12:40:35 +0000 Received: from xir-pvapexch01.xlnx.xilinx.com (149.199.80.198) by SN1NAM02FT0034.mail.protection.outlook.com (10.97.5.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5017.22 via Frontend Transport; Tue, 1 Mar 2022 12:40:35 +0000 Received: from xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Tue, 1 Mar 2022 12:40:33 +0000 Received: from smtp.xilinx.com (172.21.105.198) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Tue, 1 Mar 2022 12:40:33 +0000 Received: from [10.108.8.223] (port=53852 helo=xcbayankuma41x.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1nP1nt-0000Ui-HL; Tue, 01 Mar 2022 12:40:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cb8ae4f1-995c-11ec-8eba-a37418f5ba1a ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QBvOPPiNoDnbGzOmbH3T4GREgxfOa85ijjKj9CEo9jmIYlk4NqUW8WSGNA/m0fU6jJKfEupNgW+jvMov6BMGOUhbhst/vU+i88+LUNkeDxh5FjCyonWV/EAFttSqOK3X+FO/wt6Gm7/bkkN5DI/si7faEZWHzWBkfT1uZzZkuxyDIEObuJpEjAlseZYezfzB+dGDha0lupIfUVG/Sk8927p942CH66DIzvKid4jmBS0lfy1jqtiU09KmbQcZqtEv50aUJ8epQGLvThVZdL4ZvpSmek5MMOG6gNo2aaX++kRk4fK92sjj9YieSRlrPNTgAKzmW6l/MuyY3kgLD7UtjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uK2cUyN9RFSxW7UNMQ2w1UgKi3QyK4ZDqHMa9YicuXc=; b=akzf4FL2nbMYuDrXnkR9SnsFVLduGBFgX0wm1MoKMOSMeLw6Hzx8wuMtx3Tf09sT3819/AM3coQ8n8P39aPUJ/uW6lp2JIgQnz9TaRxZPQuv5VdgZpNufw9HErybXexx1Lw6GrbNJvOcoG3B8wkXzR22Hv3uG/ArS49XlVyLvUSKJVP5neUvOUnQ133UTh2h/jyTYHwc52kILXiIVpCF2qhtU3L4R109gW6aV0wl3rXbLgIoPtpq7D8hqSldbfpZ9T84rqn7S8KpliRZrgjXAjtb4xyyqwNeGFYpcnW3EKzIorPrZzcc2xn+Pi243v5lX4tdqC70/9QnWulOhxssRw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uK2cUyN9RFSxW7UNMQ2w1UgKi3QyK4ZDqHMa9YicuXc=; b=dPvGtKI9WPAbWoyyyCSs+KTyFQBd2odKMPnh852RvpsbzThUVjM1KWiAA95Yd7tGlKahc5aQ/ay/uY1cNctQjybOn7sK5RTZZpAYXoi3x3NjF64s73DODmVWenuj4o8GlvVbRZqgEf4vfKx96+FI7WtA0tQf1i+OAAyxYTy44kg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.80.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.80.198; helo=xir-pvapexch01.xlnx.xilinx.com; From: Ayan Kumar Halder To: CC: , , , , , , , , , , , Ayan Kumar Halder Subject: [XEN v9 4/4] xen/arm64: io: Handle data abort due to cache maintenance instructions Date: Tue, 1 Mar 2022 12:40:22 +0000 Message-ID: <20220301124022.10168-5-ayankuma@xilinx.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220301124022.10168-1-ayankuma@xilinx.com> References: <20220301124022.10168-1-ayankuma@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 085d2622-7828-4709-ca18-08d9fb80ae8f X-MS-TrafficTypeDiagnostic: SA2PR02MB7595:EE_ X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BtoEydReEZTQidQ1DtzbCrBExAzj0TMjUIm/3AEjIcSCmyY7yRfIMD9b2L1XP7j+QLya5LZ7jR3aRffjGvMaDLOICNS+flXkuBVlX49O3h0s2u0aOCuLhc15wT2YWwzx+M3USMW3MZxCA3RuU9T1X0NcShhvMmPITeQJcHJfaHIKzUYYftto09PkWjALgPauukb86Lcipnw29sdfSXnu3leRStRo7qJCViDbyeuJnYX3QVlQ0nxrrHJFnR6TSGAKLM7Vy84h6yW8YGSW7sHdk1qcPJ0zADDHEi2nI8ZVtfmdLcP1Hmo+avuVsIDA7v5GNmpdssaWe5b2cneVFJHWRfCnwT6zJ/ZCm9TF+OnjcYfweSolkphT4PIv0iwBw/bCHD3I7SvKe08qFLeh3d1L+bjgK4fg5eTDgTh2rZ6T4oi097hNzjOjAuKOwzxPIwIKoNTObpVd6fSpbJaObK+ul+x7cDv06Y9PwTALXo0j5SVTfffC5lhhkKvgN31CsOWkFo/52xYXDkR0gCrsdJZdq1G1IV9DAWNPFHhs64M9dVY/EzigmvoDpWg62YLOIRq8oDpVfiKfM9dreVddlocnlLfuv2CZMVHVlLy/sGTZyxGNkdeu3Pd0YUe8z81fDpuPvEHZ/cfdqeR9xeBQvzdsROajKoM3+JzZ8h70guf98xVuKE1yywimkUY/lP3wZ4HZ2IzuOBgxGuZWkBucSQAFpw== X-Forefront-Antispam-Report: CIP:149.199.80.198;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:xir-pvapexch01.xlnx.xilinx.com;PTR:unknown-80-198.xilinx.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(316002)(1076003)(5660300002)(7416002)(40460700003)(8676002)(70586007)(70206006)(82310400004)(4326008)(2906002)(186003)(26005)(426003)(9786002)(107886003)(2616005)(36756003)(356005)(7636003)(7696005)(6666004)(8936002)(83380400001)(6916009)(508600001)(336012)(54906003)(36860700001)(47076005)(102446001);DIR:OUT;SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2022 12:40:35.0024 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 085d2622-7828-4709-ca18-08d9fb80ae8f X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.80.198];Helo=[xir-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: SN1NAM02FT0034.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR02MB7595 When the data abort is caused due to cache maintenance for an address, there are two scenarios:- 1. Address belonging to a non emulated region - For this, Xen should set the corresponding bit in the translation table entry to valid and return to the guest to retry the instruction. This can happen sometimes as Xen need to set the translation table entry to invalid. (for eg 'Break-Before-Make' sequence). 2. Address belongs to an emulated region - Xen should ignore the instruction (ie increment the PC) and return to the guest. We try to deal with scenario#1, by invoking check_p2m(). If this is unsuccessful, then we assume scenario#2. Signed-off-by: Ayan Kumar Halder --- Changelog:- v1...v8 - NA v9 - Extracted this change from "[XEN v7 2/2] xen/arm64: io: Support instructions (for which ISS is not ..." into a separate patch of its own. The reason being this addresses an existing bug in the codebase. xen/arch/arm/include/asm/mmio.h | 3 ++- xen/arch/arm/io.c | 11 +++++++++++ xen/arch/arm/traps.c | 6 ++++++ 3 files changed, 19 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/include/asm/mmio.h b/xen/arch/arm/include/asm/mmio.h index ef2c57a2d5..75d362d5f5 100644 --- a/xen/arch/arm/include/asm/mmio.h +++ b/xen/arch/arm/include/asm/mmio.h @@ -34,7 +34,8 @@ enum instr_decode_state * Instruction is decoded successfully. It is a ldr/str post indexing * instruction. */ - INSTR_LDR_STR_POSTINDEXING + INSTR_LDR_STR_POSTINDEXING, + INSTR_IGNORE /* Instruction is ignored */ }; typedef struct diff --git a/xen/arch/arm/io.c b/xen/arch/arm/io.c index ebcb8ed548..7e9dd4bb08 100644 --- a/xen/arch/arm/io.c +++ b/xen/arch/arm/io.c @@ -139,6 +139,17 @@ void try_decode_instruction(const struct cpu_user_regs *regs, return; } + /* + * When the data abort is caused due to cache maintenance, Xen should ignore + * this instruction as the cache maintenance was caused on an address belonging + * to the emulated region. + */ + if ( info->dabt.cache ) + { + info->dabt_instr.state = INSTR_IGNORE; + return; + } + /* * Armv8 processor does not provide a valid syndrome for decoding some * instructions. So in order to process these instructions, Xen must diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c index e491ca15d7..5879640b73 100644 --- a/xen/arch/arm/traps.c +++ b/xen/arch/arm/traps.c @@ -2011,6 +2011,12 @@ static void do_trap_stage2_abort_guest(struct cpu_user_regs *regs, try_decode_instruction(regs, &info); + if ( info.dabt_instr.state == INSTR_IGNORE ) + { + advance_pc(regs, hsr); + return; + } + /* * If Xen could not decode the instruction or encountered an error * while decoding, then it should forward the abort to the guest. -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue Mar 01 12:40:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 12:40:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281335.479640 (Exim 4.92) (envelope-from ) id 1nP1nz-0006CB-II; Tue, 01 Mar 2022 12:40:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281335.479640; Tue, 01 Mar 2022 12:40:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP1nz-0006BL-Ak; Tue, 01 Mar 2022 12:40:39 +0000 Received: by outflank-mailman (input) for mailman id 281335; Tue, 01 Mar 2022 12:40:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP1nx-0005sf-SP for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 12:40:37 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2060e.outbound.protection.outlook.com [2a01:111:f400:7e88::60e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ca9644c5-995c-11ec-8eba-a37418f5ba1a; Tue, 01 Mar 2022 13:40:37 +0100 (CET) Received: from SN2PR01CA0002.prod.exchangelabs.com (2603:10b6:804:2::12) by BY5PR02MB6740.namprd02.prod.outlook.com (2603:10b6:a03:202::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.14; Tue, 1 Mar 2022 12:40:32 +0000 Received: from SN1NAM02FT0008.eop-nam02.prod.protection.outlook.com (2603:10b6:804:2:cafe::bf) by SN2PR01CA0002.outlook.office365.com (2603:10b6:804:2::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.14 via Frontend Transport; Tue, 1 Mar 2022 12:40:32 +0000 Received: from xir-pvapexch01.xlnx.xilinx.com (149.199.80.198) by SN1NAM02FT0008.mail.protection.outlook.com (10.97.5.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5017.22 via Frontend Transport; Tue, 1 Mar 2022 12:40:32 +0000 Received: from xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Tue, 1 Mar 2022 12:40:31 +0000 Received: from smtp.xilinx.com (172.21.105.198) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Tue, 1 Mar 2022 12:40:31 +0000 Received: from [10.108.8.223] (port=53852 helo=xcbayankuma41x.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1nP1nr-0000Ui-3l; Tue, 01 Mar 2022 12:40:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ca9644c5-995c-11ec-8eba-a37418f5ba1a ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gkgVaqNI0yTxHbJyJBQyLB0Ti7GigUfaOGqaFNxbXJQqGXeDMHdUTuSnF9Rpqq1e/TpoRNnCPMW+ZdcCvBCZxS+79eSpI95Sye9HSbNKP1pSS2prZ7z6Xru3mMznaMdHv1uA/IsOB1tzhTm9fwfPHUXqKcK+tcs9ByQ8x/8GCaIDpq6vXhNl9yn5KqzGjOnFHNvakh9WDLJqMbzMqgrpC8zY8z9S8oJbxR+BPiDlXeZ2ccP0pnH6FnYPsr9gsKOURFgBz/IckbzLGK2kcb5DOgU/BfnZe+XiQ9bNlPfrQjCyMdwUzHXGwvwtu3m3gk9zBNQSOaQGtBqOfk+2TZ+moQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oHuuIqCSklM84YJbzg3sQCXYQhhgJ1Du7gvCW1yJRv4=; b=e1z1tssqiorsGvXd/sGa9IgseF+W/1oe9ZYUeQjE3gTSVIabo9w6T45rVxR5NCpcU55OgIlKPndf9M0VE6JOsmjJqQWd9DQw+/2riqhY5Bvh6pl6PtK/3pFxql9QNeQgp94iGaieVBuPk6FfyEqRfITvtk8Q9PNJ4E8E6iBu0ziWOn4STgI6oaq0MmpSczGNWwEV3Dw7oEnM0+PPokwfw35Rapg2pwXCe1zW/+3Gyt4/9JyEczer3a/5ZmeqnoGE+PpzRiuoCa5dNO8w5H//KLnns35Jul0XaMU9uYZu3T3hxcytQ2pCM1yiTQvPzR6uz7onUTmQC+zYxy1xOnyEuQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oHuuIqCSklM84YJbzg3sQCXYQhhgJ1Du7gvCW1yJRv4=; b=FgZYvxMV4nXMWCXOnq81852QJs8j6L2WB4k57FMWUcG/G2VYfeB+FM6xdZDlIABD/lZjKSFov1Z+XNhX8O6PxApSCtqkyDsMfn+8zMt8ivg6g3v7W+F4XAOkahQoSyx6F9DJDOP7WCNWWXhO8F3nUMp15rdZFfkBXvzPwdrVYkU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.80.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.80.198; helo=xir-pvapexch01.xlnx.xilinx.com; From: Ayan Kumar Halder To: CC: , , , , , , , , , , , Ayan Kumar Halder Subject: [XEN v9 3/4] xen/arm64: io: Handle the abort due to access to stage1 translation table Date: Tue, 1 Mar 2022 12:40:21 +0000 Message-ID: <20220301124022.10168-4-ayankuma@xilinx.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220301124022.10168-1-ayankuma@xilinx.com> References: <20220301124022.10168-1-ayankuma@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 44db705b-959e-4b2f-582d-08d9fb80acde X-MS-TrafficTypeDiagnostic: BY5PR02MB6740:EE_ X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: d3dPeSJuBeHBOsCj/mVF2L7czXUBSoddBIZD1U7JiFU5r5ewhEu8Fvva/weZ6YQ/CoPZCWmhDzY/dvar0r4GBGbqO5wV458676kT5vrk+8o8/NOnW0qL6qMAzLmJ6Et2z15irNydlVNohKWmU0yzL+u5s4gngqnoeYCphxKWKbO7HQtVCvgWAXYnmPjvg94H00aAflODX5x+JT5jtFz6OkDa1B3/XMLSOPkieAAn3E7as/IitQZhy1fGjMXvPhgHvNsCN1MgYQfNfMT6hPYPbvZ8s8LuKAQZ5N9uUVQOrkuMcscQWeYLzOTLGJZ/3MZBAaYy6qeO/a/hpX92DmW/wq9ABu+cX1kpxuN5TW1nzD1fWJhatQLn7gc+IwwojZVR1OvHh60DGeUV553auX73PMvIwEnADP62HyVwemXh6++vVee5KNmeOx8UMPZ3sLKjiyDzNeAj+xSvlr4oYMLSaB7UDHvzEglkzRBAKRwrueqkXCJ7wDduxpAmyLgGVqB9czk23JAUxQeX+A5yThAggmN3goF1Inx2BmvqmUGa5hhRA3iDWX5gjxBS+S+CJKkvgf4+3eECPQGkxOpPhi6qESMy9L08x8RS1i94PnX+apndORwJsWiki6wUOwwpxuMGDFNIXk9iHlCX+QF80T0l8YaF7HzhAK/DclcM1SbtwMtAcaB0LpoJ072k33D0/Fiwtr+zrDDkVAFbMitku7XA0A== X-Forefront-Antispam-Report: CIP:149.199.80.198;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:xir-pvapexch01.xlnx.xilinx.com;PTR:unknown-80-198.xilinx.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(6916009)(54906003)(316002)(8936002)(8676002)(9786002)(4326008)(26005)(1076003)(107886003)(7416002)(36756003)(508600001)(6666004)(70206006)(70586007)(36860700001)(5660300002)(7696005)(356005)(7636003)(2616005)(82310400004)(336012)(47076005)(426003)(186003)(83380400001)(2906002)(102446001)(473944003);DIR:OUT;SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2022 12:40:32.1618 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 44db705b-959e-4b2f-582d-08d9fb80acde X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.80.198];Helo=[xir-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: SN1NAM02FT0008.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR02MB6740 If the abort was caused due to access to stage1 translation table, Xen will assume that the stage1 translation table is in the non MMIO region. It will try to resolve the translation fault. If it succeeds, it will return to the guest to retry the instruction. If not, then it means that the table is in MMIO region which is not expected by Xen. Thus, Xen will forward the abort to the guest. Signed-off-by: Ayan Kumar Halder --- Changelog :- v1..v8 - NA v9 - 1. Extracted this change from "[XEN v8 2/2] xen/arm64: io: Support instructions (for which ISS is not..." into a separate patch of its own. The reason being this is an existing bug in the codebase. xen/arch/arm/io.c | 11 +++++++++++ xen/arch/arm/traps.c | 12 +++++++++++- 2 files changed, 22 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/io.c b/xen/arch/arm/io.c index bea69ffb08..ebcb8ed548 100644 --- a/xen/arch/arm/io.c +++ b/xen/arch/arm/io.c @@ -128,6 +128,17 @@ void try_decode_instruction(const struct cpu_user_regs *regs, return; } + /* + * At this point, we know that the stage1 translation table is in the MMIO + * region. This is not expected by Xen and thus it forwards the abort to the + * guest. + */ + if ( info->dabt.s1ptw ) + { + info->dabt_instr.state = INSTR_ERROR; + return; + } + /* * Armv8 processor does not provide a valid syndrome for decoding some * instructions. So in order to process these instructions, Xen must diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c index 120c971b0f..e491ca15d7 100644 --- a/xen/arch/arm/traps.c +++ b/xen/arch/arm/traps.c @@ -1923,6 +1923,7 @@ static void do_trap_stage2_abort_guest(struct cpu_user_regs *regs, bool is_data = (hsr.ec == HSR_EC_DATA_ABORT_LOWER_EL); mmio_info_t info; enum io_state state; + bool check_mmio_region = true; /* * If this bit has been set, it means that this stage-2 abort is caused @@ -1987,7 +1988,16 @@ static void do_trap_stage2_abort_guest(struct cpu_user_regs *regs, */ if ( !is_data || !info.dabt.valid ) { - if ( check_p2m(is_data, gpa) ) + /* + * If the translation fault was caused due to access to stage 1 + * translation table, then we try to set the translation table entry + * for page1 translation table (assuming that it is in the non mmio + * region). + */ + if ( xabt.s1ptw ) + check_mmio_region = false; + + if ( check_p2m((is_data && check_mmio_region), gpa) ) return; /* -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue Mar 01 12:40:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 12:40:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281336.479645 (Exim 4.92) (envelope-from ) id 1nP1nz-0006Hs-R6; Tue, 01 Mar 2022 12:40:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281336.479645; Tue, 01 Mar 2022 12:40:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP1nz-0006FM-KO; Tue, 01 Mar 2022 12:40:39 +0000 Received: by outflank-mailman (input) for mailman id 281336; Tue, 01 Mar 2022 12:40:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP1ny-0005sl-0t for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 12:40:38 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on20619.outbound.protection.outlook.com [2a01:111:f400:7e8a::619]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c99c4667-995c-11ec-8539-5f4723681683; Tue, 01 Mar 2022 13:40:35 +0100 (CET) Received: from SN2PR01CA0018.prod.exchangelabs.com (2603:10b6:804:2::28) by CO6PR02MB8740.namprd02.prod.outlook.com (2603:10b6:303:137::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.13; Tue, 1 Mar 2022 12:40:31 +0000 Received: from SN1NAM02FT0008.eop-nam02.prod.protection.outlook.com (2603:10b6:804:2:cafe::5c) by SN2PR01CA0018.outlook.office365.com (2603:10b6:804:2::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.14 via Frontend Transport; Tue, 1 Mar 2022 12:40:31 +0000 Received: from xir-pvapexch01.xlnx.xilinx.com (149.199.80.198) by SN1NAM02FT0008.mail.protection.outlook.com (10.97.5.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5017.22 via Frontend Transport; Tue, 1 Mar 2022 12:40:31 +0000 Received: from xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Tue, 1 Mar 2022 12:40:29 +0000 Received: from smtp.xilinx.com (172.21.105.198) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Tue, 1 Mar 2022 12:40:29 +0000 Received: from [10.108.8.223] (port=53852 helo=xcbayankuma41x.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1nP1np-0000Ui-Kn; Tue, 01 Mar 2022 12:40:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c99c4667-995c-11ec-8539-5f4723681683 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Dnf2ucCp7HQSW8784E9FbEEtd1BklkSLuEqx+v77R5SJB0i3XfNm8k3DsNRNZKd2GqlTyId+dJGCXge1ZvaMw+/8M5PFfLoaQnC+vnGx1eEILLPqjUzTG57ZozmKdbqPUv07YbhTky6v0iOWEuSkGLPOWTGMoblXJdG5qpVqXtA/InJ/u/2+K+K5eCiiHK5QoNY0erajmp4cU0sgQxFRQ4nlf4d80dxuy4BriX/hDXIs2EO9m/CXx6RDlWvkQQ8GzAoNgzoYFCZpEWCXR/wKnbbX7PIh68jWSIcK/tGdY31hr8WEN4ZnioQpHpACEN44tMwfqN4co+zcLYJ3JG031A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Bhj1NX8FCoRo5gnmWG26pkZJvCkh97mFevBkM0EGpmA=; b=Feh0poPbLm2UzLO2lnEOPyLCMsehc6yVVDDoaEm1qkT+x4yvVGUh+Mo1nH6AjFgSRgBs0Nvw53BwoqIfKTZmXAY4eL8zBX/cCz2JSto5cIQqaOjRYBO/p5r9IuGaIpnhAhopqhyEzk8A80V32gkBhbVts25+6w4uCpQmv/qjXiW4xt/YtB2qgZZGjZJp2Tdwb/3HqZxUDZOLCwVA2f9wq4sHw/mY0xZpicj91UsiKsCq62SZJdzJJHfi/xsdceyrxP6pDfMf5lXKeyEpoq1WWJI0HlsKbxAYefCAoZ+aISff2sAV/hGEGQmreCEZCDGSmgb+oU4kZhjE39Z/Wtmqvg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Bhj1NX8FCoRo5gnmWG26pkZJvCkh97mFevBkM0EGpmA=; b=RmcDEf1nBumi+UTERObK3HTC/mkNyHmXDIVsp4f1WrnOLduUbpHsaEW2NCsP8Edd/56FCTjQt4wvLwb5eSIQTT+QItxcNGbbDDIV9g5VzQLyqFCJy43BQ7Y7ZfpcKOhNSdCUzGJAPREkPd1rN+GKWoS8QIM6xgf2UblNCiQnaCE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.80.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.80.198; helo=xir-pvapexch01.xlnx.xilinx.com; From: Ayan Kumar Halder To: CC: , , , , , , , , , , , Ayan Kumar Halder Subject: [XEN v9 2/4] xen/arm64: io: Support instructions (for which ISS is not valid) on emulated MMIO region using MMIO/ioreq handler Date: Tue, 1 Mar 2022 12:40:20 +0000 Message-ID: <20220301124022.10168-3-ayankuma@xilinx.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220301124022.10168-1-ayankuma@xilinx.com> References: <20220301124022.10168-1-ayankuma@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5aff75a4-4b86-4aa3-fdd7-08d9fb80ac5f X-MS-TrafficTypeDiagnostic: CO6PR02MB8740:EE_ X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: b+hZrp6fQ+UscmT3sS9oUSOC42bmjJKZpZhAusJuUUg7kJ8WWelMVxPXNsPQbjEZojt4oKaQSwTNOcGmI/WZA7odax7SWdBGHHvCxTmnQs4/C0II5TZQugBtM3iNJ+R3MD/q8O+cikvIwk6dNSOyJ+u+lrFy9ciCHDS3rTQabT6uCmQhcWBjucWhOxlFJIyhyqlUVzwJF1e/ZajsVuJ1KkJiCSQXsSO5xGnPwudNYW/IdUd0a/OAwaW+Ct4BlHFTiXTcjcR59cKdBpYbDjg0mgOHoex492Ps0aq8r+P2EP8mDhhPokkrv6ylRvKK/FPcEC4PtmBpWI9qyudLAWbR1Wfe1oWTtXSSKwu4sAA8TkFNJw5Ody/NWAcjesj+FhvL2rBE2phB7IsYKvVT1eee/ZEFfJwGGyvK51CUa/0mNyqpv5We0i5eIqe+Bf4QuqLnSxtB0A3s2XOaNcgxzM9vL5xy/ksDQXBk0L0esIZkbOrg6jQrAKXBxzBk8K5bqlhpFnqlmpevkX5cNtdhSYuZMXefy8lzdyDr+JPjDx4aT1reYYqjIOWqCu5Xy0egKMt9WHTdLgUDMHcadhoZ5L1rpdY7eic8IUdyDGClIVnNHD0Ptz5GxbM+SuOj99swTsGoVHx5SabnjbpiXhWjhH8lRo/cMrMCQoqNVOMOmN2xzPEqIk0keKYSkMGiIqoS015b/oBeYaWFN0zLed126dLo1d2S4MTFPG0OaAvw7yz6db4= X-Forefront-Antispam-Report: CIP:149.199.80.198;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:xir-pvapexch01.xlnx.xilinx.com;PTR:unknown-80-198.xilinx.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(7636003)(356005)(5660300002)(7696005)(47076005)(426003)(336012)(2906002)(186003)(83380400001)(2616005)(82310400004)(36860700001)(26005)(1076003)(316002)(8936002)(6916009)(54906003)(9786002)(4326008)(8676002)(508600001)(36756003)(70206006)(70586007)(6666004)(30864003)(40460700003)(7416002)(107886003)(102446001)(473944003);DIR:OUT;SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2022 12:40:31.2400 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5aff75a4-4b86-4aa3-fdd7-08d9fb80ac5f X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.80.198];Helo=[xir-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: SN1NAM02FT0008.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR02MB8740 When an instruction is trapped in Xen due to translation fault, Xen checks if the ISS is invalid (for data abort) or it is an instruction abort. If so, Xen tries to resolve the translation fault using p2m page tables. In case of data abort, Xen will try to map the mmio region to the guest (ie tries to emulate the mmio region). If the ISS is not valid and it is a data abort, then Xen tries to decode the instruction. In case of ioreq, Xen saves the decoding state, rn and imm9 to vcpu_io. Whenever the vcpu handles the ioreq successfully, it will read the decoding state to determine if the instruction decoded was a ldr/str post indexing (ie INSTR_LDR_STR_POSTINDEXING). If so, it uses these details to post increment rn. In case of mmio handler, if the mmio operation was successful, then Xen retrives the decoding state, rn and imm9. For state == INSTR_LDR_STR_POSTINDEXING, Xen will update rn. If there is an error encountered while decoding/executing the instruction, Xen will forward the abort to the guest. Signed-off-by: Ayan Kumar Halder --- Changelog :- v2..v5 - Mentioned in the cover letter. v6 - 1. Mantained the decoding state of the instruction. This is used by the caller to either abort the guest or retry or ignore or perform read/write on the mmio region. 2. try_decode() invokes decoding for both aarch64 and thumb state. (Previously it used to invoke decoding only for aarch64 state). Thus, it handles all the checking of the registers before invoking any decoding of instruction. try_decode_instruction_invalid_iss() has thus been removed. 3. Introduced a new field('enum instr_decode_state state') inside 'struct instr_details'. This holds the decoding state of the instruction. This is later read by the post_increment_register() to determine if rn needs to be incremented. Also, this is read by the callers of try_decode_instruction() to determine if the instruction was valid or ignored or to be retried or error or decoded successfully. 4. Also stored 'instr_details' inside 'struct ioreq'. This enables arch_ioreq_complete_mmio() to invoke post_increment_register() without decoding the instruction again. 5. Check hsr.dabt.valid in do_trap_stage2_abort_guest(). If it is not valid, then decode the instruction. This ensures that try_handle_mmio() is invoked only when the instruction is either valid or decoded successfully. 6. Inside do_trap_stage2_abort_guest(), if hsr.dabt.valid is not set, then resolve the translation fault before trying to decode the instruction. If translation fault is resolved, then return to the guest to execute the instruction again. v7 - 1. Moved the decoding instruction details ie instr_details from 'struct ioreq' to 'struct vcpu_io'. 2. The instruction is decoded only when we get a data abort. 3. Replaced ASSERT_UNREACHABLE() with domain_crash(). The reason being asserts can be disabled in some builds. In this scenario when the guest's cpsr is in an erroneous state, Xen should crash the guest. 4. Introduced check_p2m() which invokes p2m_resolve_translation_fault() and try_map_mmio() to resolve translation fault by configuring the page tables. This gets invoked first if ISS is invalid and it is an instruction abort. If it is a data abort and hsr.dabt.s1ptw is set or try_handle_mmio() returns IO_UNHANDLED, then check_p2m() gets invoked again. v8 - 1. Removed the handling of data abort when info->dabt.cache is set. This will be implemented in a subsequent patch. (Not as part of this series) 2. When the data abort is due to access to stage 1 translation tables, Xen will try to fix the mapping of the page table for the corresponding address. If this returns an error, Xen will abort the guest. Else, it will ask the guest to retry the instruction. 3. Changed v->io.info.dabt_instr from pointer to variable. The reason being that arch_ioreq_complete_mmio() is called from leave_hypervisor_to_guest(). That is after do_trap_stage2_abort_guest() has been invoked. So the original variable will be no longer valid. 4. Some other style issues pointed out in v7. v9 - 1. Ensure that "Erratum 766422" is handled only when ISS is valid. 2. Whenever Xen receives and instruction abort or data abort (with invalid ISS), Xen should first try to resolve the p2m translation fault or see if it it needs to map a MMIO region. If it succeeds, it should return to the guest to retry the instruction. 3. Removed handling of "dabt.s1ptw == 1" aborts. This is addressed in patch3 as it is an existing bug in codebase. 4. Various style issues pointed by Julien in v8. xen/arch/arm/arm32/traps.c | 11 ++++ xen/arch/arm/arm64/traps.c | 47 ++++++++++++++++ xen/arch/arm/decode.c | 1 + xen/arch/arm/include/asm/domain.h | 4 ++ xen/arch/arm/include/asm/mmio.h | 17 +++++- xen/arch/arm/include/asm/traps.h | 2 + xen/arch/arm/io.c | 90 +++++++++++++++++++------------ xen/arch/arm/ioreq.c | 7 ++- xen/arch/arm/traps.c | 77 ++++++++++++++++++++------ xen/arch/x86/include/asm/ioreq.h | 3 ++ xen/include/xen/sched.h | 2 + 11 files changed, 207 insertions(+), 54 deletions(-) diff --git a/xen/arch/arm/arm32/traps.c b/xen/arch/arm/arm32/traps.c index 9c9790a6d1..159e3cef8b 100644 --- a/xen/arch/arm/arm32/traps.c +++ b/xen/arch/arm/arm32/traps.c @@ -18,9 +18,11 @@ #include #include +#include #include +#include #include #include @@ -82,6 +84,15 @@ void do_trap_data_abort(struct cpu_user_regs *regs) do_unexpected_trap("Data Abort", regs); } +void post_increment_register(const struct instr_details *instr) +{ + /* + * We have not implemented decoding of post indexing instructions for 32 bit. + * Thus, this should be unreachable. + */ + domain_crash(current->domain); +} + /* * Local variables: * mode: C diff --git a/xen/arch/arm/arm64/traps.c b/xen/arch/arm/arm64/traps.c index 9113a15c7a..e18b6b2626 100644 --- a/xen/arch/arm/arm64/traps.c +++ b/xen/arch/arm/arm64/traps.c @@ -17,6 +17,7 @@ */ #include +#include #include #include @@ -44,6 +45,52 @@ void do_bad_mode(struct cpu_user_regs *regs, int reason) panic("bad mode\n"); } +void post_increment_register(const struct instr_details *instr) +{ + struct cpu_user_regs *regs = guest_cpu_user_regs(); + register_t val = 0; + + /* Currently, we handle only ldr/str post indexing instructions */ + if ( instr->state != INSTR_LDR_STR_POSTINDEXING ) + return; + + /* + * Handle when rn = SP + * Refer ArmV8 ARM DDI 0487G.b, Page - D1-2463 "Stack pointer register + * selection" + * t = SP_EL0 + * h = SP_ELx + * and M[3:0] (Page - C5-474 "When exception taken from AArch64 state:") + */ + if (instr->rn == 31 ) + { + if ( (regs->cpsr & PSR_MODE_MASK) == PSR_MODE_EL1h ) + val = regs->sp_el1; + else if ( ((regs->cpsr & PSR_MODE_MASK) == PSR_MODE_EL1t) || + ((regs->cpsr & PSR_MODE_MASK) == PSR_MODE_EL0t) ) + val = regs->sp_el0; + else + { + domain_crash(current->domain); + return; + } + } + else + val = get_user_reg(regs, instr->rn); + + val += instr->imm9; + + if ( instr->rn == 31 ) + { + if ( (regs->cpsr & PSR_MODE_MASK) == PSR_MODE_EL1h ) + regs->sp_el1 = val; + else + regs->sp_el0 = val; + } + else + set_user_reg(regs, instr->rn, val); +} + /* * Local variables: * mode: C diff --git a/xen/arch/arm/decode.c b/xen/arch/arm/decode.c index 3add87e83a..16ad0747bb 100644 --- a/xen/arch/arm/decode.c +++ b/xen/arch/arm/decode.c @@ -146,6 +146,7 @@ static int decode_arm64(register_t pc, mmio_info_t *info) update_dabt(dabt, opcode.ldr_str.rt, opcode.ldr_str.size, false); + dabt_instr->state = INSTR_LDR_STR_POSTINDEXING; dabt_instr->rn = opcode.ldr_str.rn; dabt_instr->imm9 = opcode.ldr_str.imm9; diff --git a/xen/arch/arm/include/asm/domain.h b/xen/arch/arm/include/asm/domain.h index c56f6e4398..ed63c2b6f9 100644 --- a/xen/arch/arm/include/asm/domain.h +++ b/xen/arch/arm/include/asm/domain.h @@ -281,6 +281,10 @@ static inline void arch_vcpu_block(struct vcpu *v) {} /* vPCI is not available on Arm */ #define has_vpci(d) ({ (void)(d); false; }) +struct arch_vcpu_io { + struct instr_details dabt_instr; /* when the instruction is decoded */ +}; + #endif /* __ASM_DOMAIN_H__ */ /* diff --git a/xen/arch/arm/include/asm/mmio.h b/xen/arch/arm/include/asm/mmio.h index 3354d9c635..ef2c57a2d5 100644 --- a/xen/arch/arm/include/asm/mmio.h +++ b/xen/arch/arm/include/asm/mmio.h @@ -26,12 +26,24 @@ #define MAX_IO_HANDLER 16 +enum instr_decode_state +{ + INSTR_ERROR, /* Error encountered while decoding instr */ + INSTR_VALID, /* ISS is valid, so no need to decode */ + /* + * Instruction is decoded successfully. It is a ldr/str post indexing + * instruction. + */ + INSTR_LDR_STR_POSTINDEXING +}; + typedef struct { struct hsr_dabt dabt; struct instr_details { unsigned long rn:5; signed int imm9:9; + enum instr_decode_state state; } dabt_instr; paddr_t gpa; } mmio_info_t; @@ -69,14 +81,15 @@ struct vmmio { }; enum io_state try_handle_mmio(struct cpu_user_regs *regs, - const union hsr hsr, - paddr_t gpa); + mmio_info_t *info); void register_mmio_handler(struct domain *d, const struct mmio_handler_ops *ops, paddr_t addr, paddr_t size, void *priv); int domain_io_init(struct domain *d, int max_count); void domain_io_free(struct domain *d); +void try_decode_instruction(const struct cpu_user_regs *regs, + mmio_info_t *info); #endif /* __ASM_ARM_MMIO_H__ */ diff --git a/xen/arch/arm/include/asm/traps.h b/xen/arch/arm/include/asm/traps.h index 2ed2b85c6f..95c46ad391 100644 --- a/xen/arch/arm/include/asm/traps.h +++ b/xen/arch/arm/include/asm/traps.h @@ -109,6 +109,8 @@ static inline register_t sign_extend(const struct hsr_dabt dabt, register_t r) return r; } +void post_increment_register(const struct instr_details *instr); + #endif /* __ASM_ARM_TRAPS__ */ /* * Local variables: diff --git a/xen/arch/arm/io.c b/xen/arch/arm/io.c index fad103bdbd..bea69ffb08 100644 --- a/xen/arch/arm/io.c +++ b/xen/arch/arm/io.c @@ -102,57 +102,79 @@ static const struct mmio_handler *find_mmio_handler(struct domain *d, return handler; } +void try_decode_instruction(const struct cpu_user_regs *regs, + mmio_info_t *info) +{ + int rc; + + if ( info->dabt.valid ) + { + info->dabt_instr.state = INSTR_VALID; + + /* + * Erratum 766422: Thumb store translation fault to Hypervisor may + * not have correct HSR Rt value. + */ + if ( check_workaround_766422() && (regs->cpsr & PSR_THUMB) && + info->dabt.write ) + { + rc = decode_instruction(regs, info); + if ( rc ) + { + gprintk(XENLOG_DEBUG, "Unable to decode instruction\n"); + info->dabt_instr.state = INSTR_ERROR; + } + } + return; + } + + /* + * Armv8 processor does not provide a valid syndrome for decoding some + * instructions. So in order to process these instructions, Xen must + * decode them. + */ + rc = decode_instruction(regs, info); + if ( rc ) + { + gprintk(XENLOG_ERR, "Unable to decode instruction\n"); + info->dabt_instr.state = INSTR_ERROR; + } +} + enum io_state try_handle_mmio(struct cpu_user_regs *regs, - const union hsr hsr, - paddr_t gpa) + mmio_info_t *info) { struct vcpu *v = current; const struct mmio_handler *handler = NULL; - const struct hsr_dabt dabt = hsr.dabt; - mmio_info_t info = { - .gpa = gpa, - .dabt = dabt - }; + int rc; - ASSERT(hsr.ec == HSR_EC_DATA_ABORT_LOWER_EL); + ASSERT(info->dabt.ec == HSR_EC_DATA_ABORT_LOWER_EL); - handler = find_mmio_handler(v->domain, info.gpa); - if ( !handler ) + if ( !((info->dabt_instr.state == INSTR_VALID) || (info->dabt_instr.state == INSTR_LDR_STR_POSTINDEXING)) ) { - int rc; + ASSERT_UNREACHABLE(); + return IO_ABORT; + } - rc = try_fwd_ioserv(regs, v, &info); + handler = find_mmio_handler(v->domain, info->gpa); + if ( !handler ) + { + rc = try_fwd_ioserv(regs, v, info); if ( rc == IO_HANDLED ) return handle_ioserv(regs, v); return rc; } - /* All the instructions used on emulated MMIO region should be valid */ - if ( !dabt.valid ) - return IO_ABORT; - /* - * Erratum 766422: Thumb store translation fault to Hypervisor may - * not have correct HSR Rt value. + * At this point, we know that the instruction is either valid or has been + * decoded successfully. Thus, Xen should be allowed to execute the + * instruction on the emulated MMIO region. */ - if ( check_workaround_766422() && (regs->cpsr & PSR_THUMB) && - dabt.write ) - { - int rc; - - rc = decode_instruction(regs, &info); - if ( rc ) - { - gprintk(XENLOG_DEBUG, "Unable to decode instruction\n"); - return IO_ABORT; - } - } - - if ( info.dabt.write ) - return handle_write(handler, v, &info); + if ( info->dabt.write ) + return handle_write(handler, v, info); else - return handle_read(handler, v, &info); + return handle_read(handler, v, info); } void register_mmio_handler(struct domain *d, diff --git a/xen/arch/arm/ioreq.c b/xen/arch/arm/ioreq.c index 308650b400..58cd320b5a 100644 --- a/xen/arch/arm/ioreq.c +++ b/xen/arch/arm/ioreq.c @@ -47,6 +47,7 @@ enum io_state try_fwd_ioserv(struct cpu_user_regs *regs, struct vcpu *v, mmio_info_t *info) { struct vcpu_io *vio = &v->io; + struct dabt_instr instr = info->dabt_instr; ioreq_t p = { .type = IOREQ_TYPE_COPY, .addr = info->gpa, @@ -76,10 +77,10 @@ enum io_state try_fwd_ioserv(struct cpu_user_regs *regs, if ( !s ) return IO_UNHANDLED; - if ( !info->dabt.valid ) - return IO_ABORT; + ASSERT(dabt.valid); vio->req = p; + vio->info.dabt_instr = instr; rc = ioreq_send(s, &p, 0); if ( rc != IO_RETRY || v->domain->is_shutting_down ) @@ -95,6 +96,7 @@ enum io_state try_fwd_ioserv(struct cpu_user_regs *regs, bool arch_ioreq_complete_mmio(void) { struct vcpu *v = current; + struct instr_details dabt_instr = v->io.info.dabt_instr; struct cpu_user_regs *regs = guest_cpu_user_regs(); const union hsr hsr = { .bits = regs->hsr }; @@ -106,6 +108,7 @@ bool arch_ioreq_complete_mmio(void) if ( handle_ioserv(regs, v) == IO_HANDLED ) { + post_increment_register(&dabt_instr); advance_pc(regs, hsr); return true; } diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c index 7a1b679b8c..120c971b0f 100644 --- a/xen/arch/arm/traps.c +++ b/xen/arch/arm/traps.c @@ -1893,6 +1893,21 @@ static bool try_map_mmio(gfn_t gfn) return !map_regions_p2mt(d, gfn, 1, mfn, p2m_mmio_direct_c); } +static inline bool check_p2m(bool is_data, paddr_t gpa) +{ + /* + * First check if the translation fault can be resolved by the P2M subsystem. + * If that's the case nothing else to do. + */ + if ( p2m_resolve_translation_fault(current->domain , gaddr_to_gfn(gpa)) ) + return true; + + if ( is_data && try_map_mmio(gaddr_to_gfn(gpa)) ) + return true; + + return false; +} + static void do_trap_stage2_abort_guest(struct cpu_user_regs *regs, const union hsr hsr) { @@ -1906,6 +1921,8 @@ static void do_trap_stage2_abort_guest(struct cpu_user_regs *regs, paddr_t gpa; uint8_t fsc = xabt.fsc & ~FSC_LL_MASK; bool is_data = (hsr.ec == HSR_EC_DATA_ABORT_LOWER_EL); + mmio_info_t info; + enum io_state state; /* * If this bit has been set, it means that this stage-2 abort is caused @@ -1959,21 +1976,52 @@ static void do_trap_stage2_abort_guest(struct cpu_user_regs *regs, return; } case FSC_FLT_TRANS: + { + info.gpa = gpa; + info.dabt = hsr.dabt; + /* - * Attempt first to emulate the MMIO as the data abort will - * likely happen in an emulated region. - * - * Note that emulated region cannot be executed + * Assumption :- Most of the times when we get a data abort and the ISS + * is invalid or an instruction abort, the underlying cause is that the + * page tables have not been set up correctly. */ - if ( is_data ) + if ( !is_data || !info.dabt.valid ) { - enum io_state state = try_handle_mmio(regs, hsr, gpa); + if ( check_p2m(is_data, gpa) ) + return; - switch ( state ) - { + /* + * If the instruction abort could not be resolved by setting the + * appropriate bits in the translation table, then Xen should + * forward the abort to the guest. + */ + if ( !is_data ) + goto inject_abt; + } + + try_decode_instruction(regs, &info); + + /* + * If Xen could not decode the instruction or encountered an error + * while decoding, then it should forward the abort to the guest. + */ + if ( info.dabt_instr.state == INSTR_ERROR ) + goto inject_abt; + + state = try_handle_mmio(regs, &info); + + switch ( state ) + { case IO_ABORT: goto inject_abt; case IO_HANDLED: + /* + * If the instruction was decoded and has executed successfully + * on the MMIO region, then Xen should execute the next part of + * the instruction. (for eg increment the rn if it is a + * post-indexing instruction. + */ + post_increment_register(&info.dabt_instr); advance_pc(regs, hsr); return; case IO_RETRY: @@ -1982,21 +2030,18 @@ static void do_trap_stage2_abort_guest(struct cpu_user_regs *regs, case IO_UNHANDLED: /* IO unhandled, try another way to handle it. */ break; - } } /* - * First check if the translation fault can be resolved by the - * P2M subsystem. If that's the case nothing else to do. + * If the instruction syndrome was invalid, then we already checked if + * this was due to a P2M fault. So no point to check again as the result + * will be the same. */ - if ( p2m_resolve_translation_fault(current->domain, - gaddr_to_gfn(gpa)) ) - return; - - if ( is_data && try_map_mmio(gaddr_to_gfn(gpa)) ) + if ( info.dabt.valid && check_p2m(is_data, gpa) ) return; break; + } default: gprintk(XENLOG_WARNING, "Unsupported FSC: HSR=%#"PRIregister" DFSC=%#x\n", diff --git a/xen/arch/x86/include/asm/ioreq.h b/xen/arch/x86/include/asm/ioreq.h index d06ce9a6ea..ecfe7f9fdb 100644 --- a/xen/arch/x86/include/asm/ioreq.h +++ b/xen/arch/x86/include/asm/ioreq.h @@ -26,6 +26,9 @@ #include #endif +struct arch_vcpu_io { +}; + #endif /* __ASM_X86_IOREQ_H__ */ /* diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h index 10ea969c7a..406d9bc610 100644 --- a/xen/include/xen/sched.h +++ b/xen/include/xen/sched.h @@ -160,6 +160,8 @@ struct vcpu_io { /* I/O request in flight to device model. */ enum vio_completion completion; ioreq_t req; + /* Arch specific info pertaining to the io request */ + struct arch_vcpu_io info; }; struct vcpu -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue Mar 01 12:48:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 12:48:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281374.479683 (Exim 4.92) (envelope-from ) id 1nP1vz-0000mj-54; Tue, 01 Mar 2022 12:48:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281374.479683; Tue, 01 Mar 2022 12:48:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP1vz-0000mc-20; Tue, 01 Mar 2022 12:48:55 +0000 Received: by outflank-mailman (input) for mailman id 281374; Tue, 01 Mar 2022 12:48:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP1vy-0000mV-Cw for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 12:48:54 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f151a782-995d-11ec-8eba-a37418f5ba1a; Tue, 01 Mar 2022 13:48:52 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f151a782-995d-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1646138932; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=oZo5lPjNxNbmBmBf/ntNRJMOZECLKTp51QAUaoMkA7w=; b=BE1oNPLzOAXC4FQvt0hfzGafNn6RG91RPVRV5zQjjywaEVKPGOc7UikW ecUBadhRvOkR8fnV5phvCuH0Nf9Mhn+SDkH234U20nQpVG8gtybBTaO+k WKc8whNp/QgXR3+qo7aXGlX2yx/CVWIxcOY6fbs83IRibzrgvJmGfxx7q w=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com X-SBRS: 5.1 X-MesageID: 67500473 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:XDDEy6jaLPgcvHr3yA8SOiQfX161fRAKZh0ujC45NGQN5FlHY01je htvXGHUbPmCZGDzftx/a4+x8U9V7JeDn9A1QVY4+Sw2QS8b9cadCdqndUqhZCn6wu8v7a5EA 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M78wIFqtQw24LhWFvU4 YmaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9 TlDiXC/YT15ML/0vfo3aQdFOCZQL7xn2uHNO2fq5KR/z2WeG5ft6/BnDUVwNowE4OdnR2pJ8 JT0KhhUMErF3bjvhuvmFK883azPL+GyVG8bklhmwSvUErANRpfbTr+RzdRZwC0xloZFGvO2i 88xN2UyNEycPEYn1lE/KNFvueKvhybFLDB8tFeou4Qq5kz0w1kkuFTqGIWMIYHbLSlPpW6Ho krW8mK/BQsVXPSPxDzA/n+yi+vnmSLgRJlUBLC+7uRtglCY2ioUEhJ+fVmxrOS9i0W+c8lCM EFS8S0rxZXe72TyEIO7BUfh5ifZ4FhMALK8DtHW9im3mqTG2yOHLFIaUxVGRs43le1oTyY1g wrhc8zSORRjt7icSHS4/7iSrC+vNSV9EVLudRPoXiNevYC9/dhbYgbnC486TfXr1oGd9STYn mjSxBXSkYn/miLiO0+T2VncywyhqZHSJuLezlWGBzn1hu+ViWPMWmBJ1bQ5xasYRGp6ZgPY1 JThpyR4xLpWZX1qvHbQKNjh5Jnzu5643MT02DaD5aUJ+TW34GKEdotN+jx4L0oBGp9aJWGxP xSN5VoIvc470J6WgUlfOdnZ5yMCl/WIKDgYfqqMMoomjmZZLmdrAx2ClWbPhjuwwSDAYIk0O IuBcNbEMJrpIf8P8dZCfM9EieVD7nlnnQv7HMmnpzz6gev2TCPEEt8tbQrRBt3VGYvZ+W05B f4EbJDUo/ieOcWjChTqHXk7dghbfSBmXsmt86S6tIere2JbJY3oMNeIqZsJcI15haVF0ODO+ 3C2QEhDz1Tjw3bALG23hrpLNNsDgb4XQaoHABER IronPort-HdrOrdr: A9a23:IQYcTqslujTT3DRjDmRJpbmI7skC2IMji2hC6mlwRA09TyXGra +TdaUguSMc1gx9ZJh5o6H8BEGBKUmskKKceeEqTPiftXrdyReVxeZZnMXfKlzbamHDH4tmu5 uIHJIOceEYYWIK7voSpTPIaerIo+P3sZxA592ut0uFJDsCA8oLjmdE40SgYzZLrWF9dMEE/f Gnl656Tk+bCBIqh7OAdx44tob41r/2vaOjRSRDKw8s6QGIgz/twqX9CQKk0hAXVC4K6as+8E De+jaJppmLgrWe8FvxxmXT55NZlJ/K0d1YHvGBjcATN3HFlhuoXoJ8QLeP1QpF491HqWxa0u UkkS1Qe/ib2EmhOV1dZiGdnTUI5QxerkMKD2Xo2EcL7/aJHA7SQPAx+r6xOiGplXbI+usMip 6jlljpx6a+R3n77VXAzsmNWBdwmkWup30+1eYVknxESIMbLKRctIoF4SpuYdw99Q/Bmcka+d NVfYnhDTdtACenRmGcunMqzM2nX3w1EBvDSk8eutaN2zwTmHxi1UMXyMEWg39FrfsGOtR5zv WBNr4tmKBFT8cQY644DOAdQdGvAmiIRR7XKmqdLVnuCalCMXPQrJz85qkz+YiRCdY15Yp3nI 6EXEJTtGY0dU6rAcqS3IdT+hSIW2m5VSSF8LAp23G4gMyKeFPGC1zwdLl1qbrSnxw2OLyvZ8 qO X-IronPort-AV: E=Sophos;i="5.90,146,1643691600"; d="scan'208";a="67500473" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Epf6X6V+N/txvJx/Qo2uGlRYz+ITXPduccgIYaH5Jz8GcdAQb5VFmoq7XxLJQEwOjydDpIv83KR/zoULwreMsjrjNToZhnv40Rpaubfhb/l/Ki7OpLUIJl8e5Q3W4DEwTSMVL3TzOPR/ZwjHmnYUMXcHp5OjHZoYWONE1gP0Kn9pAqVZyBMDbgZTeFRAftbKYvJ7bJPB7b5qXfYmmTANb/tMRo41/8FbwcfOlAfegsZAAzGGai4QfkSaWwr/qwk5MWn+peijSUO7uHatqdC18yvAb1JbrbpcIUHmT4aEBB9srVjlNngZrw5+v/nkqrjNrjuTscD3En6dLh4zroiaWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oZo5lPjNxNbmBmBf/ntNRJMOZECLKTp51QAUaoMkA7w=; b=m/zfsJZVl6rEsmD6FLFVc9lLdsYqU/mIzLXD3YAh+6dONFhYfeGV4g8JkqZ6B+zM0aIuxtRodZZ9Ie0N25+rxAQPMdWzMvgdoLRD0Gsj9L70v6MeQd3FWqzonEmts48Brsv1khDAKk/c6LgHWPIlV3Om2Ui3zbSiJi95iqlxBv5rgz+17wM/Wj2mgwE83zBJz6d5DpUpNtGBA/y2cDAmXeHYVvlHbbSJI7OZKNYeIgDmk14aQYUss4vkMKy4ZqO3YlzS9oSdMFd79mWUrK9tjjg4sKtUNleQZp+Q1rHrdaC+lMm2XsK2GAQwgr7ONMUadMyeNTV/f2aX3B/ZGYjuqg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oZo5lPjNxNbmBmBf/ntNRJMOZECLKTp51QAUaoMkA7w=; b=tcpBtXvTTr1HgL/BBMAigmr1lFXiB8AuBd8jsSQUDoEfeki8WaoijRwKoSwvsbJ2SW9yCCNf0WlT9xHsOB8yvhjaqmxr+Bns0GjGmu/nPFxn5HRCU4n72LzWxKcjxNbKvoYWPsbJoFCe2HvTnuu6ynkfvOiYbxdtHGySbYmdjBU= From: Andrew Cooper To: Jan Beulich , "xen-devel@lists.xenproject.org" CC: Wei Liu , Roger Pau Monne Subject: Re: [PATCH] x86/altcall: silence undue warning Thread-Topic: [PATCH] x86/altcall: silence undue warning Thread-Index: AQHYLWCYr1nVwle0TEu9TqkN6fmfJ6yqeogA Date: Tue, 1 Mar 2022 12:48:26 +0000 Message-ID: <40306bc7-f61c-d330-0ec7-d986e4711d88@citrix.com> References: <0e3594ff-c637-46f2-bc95-7a26b5471b86@suse.com> In-Reply-To: <0e3594ff-c637-46f2-bc95-7a26b5471b86@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0d03efde-6d91-42ab-3f3d-08d9fb81c79c x-ms-traffictypediagnostic: BN6PR03MB2945:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 5k/mFrAFanrnYxaNtvT2cicYkIFrUec0fhZTrurzKw+EiEFlUtDAlov7hIcddzd96mcw7Gnv56+rDUuOEBoRwUdUrywK3fq5GRxg4At8cjM4a3mXXu049bCzTqCJUYnqJ+/kC/Cirmn9gQsZvCNTGJyhzqq/7j3O768sN/85MY1bMweT8SGSbb/F+Ox0ejg53EJWyTN9wH+RJV0hOXyqS1sKLvfeSID9GVCq4U1TRIDQ+DqoITse+opiuQkXBMuunQDhewh9FS5PsCXW5a2GcfaHFUsf3ZUkGr1/wGX924IbuZEYdl+9yAahgf2hAD1PaxTl6B0zoMt0dV0ZxBGFfVtEko+eT5JmA7n74jgoY5xif2emMNh6NBONrq9dMqlnwGPaVdhRAKtPE7cskEd+6bDrP9bOv5z0gbr9L6u/8Fz8fdjxsyw01EIKTHG5RAu0GhhzTOPTJaWiwEB1L1vCuYmbkBg7jd0QPf3kSGK8pq731wa53aut9GDb5RgnF6bxWuKBjAGeU733HLcYyuYCXPngJf6r70l3T722sTeJIImGTxfiajvccn+rEYEE19kg7vZiab6SZZejxbnR5VFrutOvVMVmE/osKgBF7bFzHGc+w5tUsJueHupe87lbSvfaDkpj7TJyvebCYftVA2PXCzqRygCuO60l2i/yLA2pWCOCKz0aM7jFq/DFg/TQUOhMiAqcVmAvdaA/NoeG7+RhAqcrF/HqaN+QDH4ZJz/TNCRMJvS/x4ZNGK4fnoHvTCA805UxxSP7HXQo9yRRcIIaBg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66446008)(66946007)(66476007)(91956017)(66556008)(64756008)(4326008)(83380400001)(8676002)(86362001)(76116006)(186003)(110136005)(6506007)(71200400001)(107886003)(2616005)(26005)(31686004)(36756003)(316002)(54906003)(6512007)(53546011)(508600001)(6486002)(8936002)(82960400001)(5660300002)(38100700002)(122000001)(38070700005)(31696002)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?RENiYTkzeW9VY3p6LzZpaE5UVmQxUXh0MkJxbmZqdTBiS1U3cDFuNzBqTGFU?= =?utf-8?B?YTZrZ2pacGdMKzRacnVKVXlzZUVPQjRWK0toOFJOZjIveVhyOU1sWHNFcjFM?= =?utf-8?B?alVYMUhJSG9Gamh0NVp6cnJaY3BXSk1laVR2V2EvQ1hsVmpEbXIzRDFFYUJn?= =?utf-8?B?dGFUTHB4U1kzSUVkUXB0RXNLaDUySWthenlicmQwN0Y0WVZBZWd0R3k1bEE1?= =?utf-8?B?WXB6UUdnaFVqTnF3WFVvV3RQZjBsZkNwM3lxMjhuYUNUMjQ1akVzNnhVcVNR?= =?utf-8?B?SzNCb3JlV3ZaSVRBaXE5bm5KbkdUa1JXcFJUM2t0OG1pSy94Ly9DQkZTaHRl?= =?utf-8?B?VzdnTy9BbDJRLzY4Y0JOQXJiZHY5N0RNZk9OV2VrUWhyUmo1aDk2bHAxTzFl?= =?utf-8?B?SmR0WkViNkpZQ1F1ZTdkbk9yYTJISHNVdTJ2QUZrd0N4MDhJdnhIVGs1ZmQx?= =?utf-8?B?T2NrSzVFbWl1OEltOVBnTXRBbEc2czRWaXlwOWdJS25sOTI4S3c4VVl0Q0wy?= =?utf-8?B?T0dvODFVYUFJUFppeWVOaTJLRzhwdWtiMk5rNlhUckhQZTdHMDhSdVd2NUZS?= =?utf-8?B?SVcwNGFZaVBDbTE1bHNCVjJLSzFmWWo0bzlGaXB6QXRKMGdJeDhKNzMvbU9Z?= =?utf-8?B?QWdNYlgxY2NZZnpDUmlPdmJVYmF6Qjd3b01ldGN4eHFnSGdiNmdiaHpwd1Qr?= =?utf-8?B?NDBBc0hVbVBkUUoxZ0NsOENRL0RFeVVXdkt2S1FvRURpTU9yaEtQblZXZmJI?= =?utf-8?B?YklFQ1pmNlhWdHBnVDBrVkV0Ukd0ajNMeXNranlYMU44R3NiWmlXSkI4b3E5?= =?utf-8?B?T1JDT0VWUGF5QWlxSkh2SnVrcVNiVEhPS0ROSXNtbTZpWFBST1dOU2pUVkZX?= =?utf-8?B?RlBTRXY0V3hMam0xcWEvcmI5anEyN2xoWlNZdVRkWGhlcitsR2xEYlVsMFFl?= =?utf-8?B?Q3Y4MjExQlltSEgrN0psQzhMS3B1TklndytnK2g0bkM4bkZyU3RvT1I0RDV2?= =?utf-8?B?OERIQ3YwQ2VjNjZvdnFIVXhxVldJcWQzNHJzdlVucWJZSy8yY2tkQTg2bUhI?= =?utf-8?B?Z3lRZWVvblBaY2FpUVRBS293M3UwSWNHNkYzTDRtTkViNWtpOG51YklqUXQ3?= =?utf-8?B?MnJJM1lvV2FlZGJ4TlBrak45bUhOWUJuSDhoNzErSFZBK1g0bk45enA2Znh0?= =?utf-8?B?Z3hVN1Q2Mmxwdjc3N3NJdUU5Y04reFE3cXpYb2xYSGtEMDY1YllScHpPeEUx?= =?utf-8?B?N0ZERjlIeVV1d212UXR1ak5FL05VbFpnS0lRWURkS2JVdU9xUzd0dWxSZUdt?= =?utf-8?B?bUlUTmh2NlJ1b2d3ZGxtUy96TWFtUmZEUCtYK2J3VUZKTE9MYmJyWU9qVTRh?= =?utf-8?B?M3NYR2ZJdWhRNEV2dnJJQ3F0YVdvV1dDMnZJZUh6RFhrOVhFcm81OXVmREQ1?= =?utf-8?B?UmNGRDMzb2tkZ0hYZHdQOFltakQveVJRR0c0UHU5eWY1SkZRU0VuNjVlckVQ?= =?utf-8?B?ano1MGxBcnVkOXhxT1Z6cldUOFVhbkppV3FCTDRseHVnKzNVVDdSWXFzWjha?= =?utf-8?B?Y3N5MzBNa2lvNmMzWWZraWlGM1c0bXVLQVFsZnhFZ1ZNWllSTThVWjllbnc5?= =?utf-8?B?Um1laVE4ZWxhbVprMHloRWt4QjMyRXdHcnlZOHVQS1FTWjdVVFpMcFIxNHVa?= =?utf-8?B?R3NpOVdmbG1iTjRUaWg1cmYrRzJzV3ZNVkQ4V3QzT3JNZ25tWm1HYW14NHJ3?= =?utf-8?B?a3ArTXNKWkNYUVkzeEhFeGJDVy9oS2lvZmFVMWxUb0NqUnlCNVhzZitqdXdm?= =?utf-8?B?OFNOWCt4ZDFQdnR6V1JLVnJjd0dicjVTUjh5amZKK1BFVUFXTG1PZkVkTTNU?= =?utf-8?B?Y2YxSVprUUdmUzZNWVRSVVFDSlpsQURBdWRsMG5nRkdsVjA0bXRRa0Yxbmlo?= =?utf-8?B?VnVubEtRRURGNi9SVERMUW8wZTVybVcwaFBGSnVOTDEwSElVZlVhS0dRcW1n?= =?utf-8?B?U1ZlMFVDNXhGdUVMSFkvOGdTMU44ZGZHVDlkWVZrL3loVyszQjRJOHFiVzgr?= =?utf-8?B?MzlxR21qbnN6WXIxeW5YYjYrQWdwVkp3Z2JVaGtBWVZGc2hmMFNUWk0yZkVM?= =?utf-8?B?MEU5Ykk2WERmUkw4NnA2M0NUSGRKVDExNDZSK1c5c1RZajhaaTNCTy9tdmFB?= =?utf-8?B?b3B1UFh0QTBKcTVpSmxaMEJtZmpTS2NFL1RwSGl3MnBmbEtqL3hFN1ZkcEdq?= =?utf-8?B?RndvYlJlMGkyd3BLRXFZV0dZczhBPT0=?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0d03efde-6d91-42ab-3f3d-08d9fb81c79c X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Mar 2022 12:48:26.6957 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: k8Zd1Xv0gk2NVKV3gwsLOrw/cAbmegTIVp5Ir3n3j4R8OB0s4/z+Nn9jGnN+rGEaK17St+/23QpozquGJNqxbjwN//PwZyawZYU+7j6Eq5E= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2945 X-OriginatorOrg: citrix.com T24gMDEvMDMvMjAyMiAxMTozNiwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IFN1aXRhYmxlIGNvbXBp bGVyIG9wdGlvbnMgYXJlIHBhc3NlZCBvbmx5IHdoZW4gdGhlIGFjdHVhbCBmZWF0dXJlDQo+IChY RU5fSUJUKSBpcyBlbmFibGVkLCBub3Qgd2hlbiBtZXJlbHkgdGhlIGNvbXBpbGVyIGNhcGFiaWxp dHkgd2FzIGZvdW5kDQo+IHRvIGJlIGF2YWlsYWJsZS4NCj4NCj4gRml4ZXM6IDEyZTM0MTBlMDcx ZSAoIng4Ni9hbHRjYWxsOiBDaGVjayBhbmQgb3B0aW1pc2UgYWx0Y2FsbCB0YXJnZXRzIikNCj4g U2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KDQpIbW0geWVz LsKgIFRoaXMgaXMgZmFsbG91dCBmcm9tIHNlcGFyYXRpbmcgQ09ORklHX0hBU19DQ19DRVRfSUJU IGFuZA0KQ09ORklHX1hFTl9JQlQuDQoNClJldmlld2VkLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRy ZXcuY29vcGVyM0BjaXRyaXguY29tPg0KDQo+IC0tLQ0KPiBGdXJ0aGVybW9yZSwgaXMgIk9wdGlt aXNlZCBhd2F5IC4uLiIgcmVhbGx5IGFwcHJvcHJpYXRlIGluIHdoYXQNCj4gMzdlZDVkYTg1MWI4 ICgieDg2L2FsdGNhbGw6IE9wdGltaXNlIGF3YXkgZW5kYnI2NCBpbnN0cnVjdGlvbiB3aGVyZQ0K PiBwb3NzaWJsZSIpIGFkZGVkPyBJZiB0aGlzIHJlYWxseSB3YXMgYW4gb3B0aW1pemF0aW9uIChy YXRoZXIgdGhhbg0KPiBoYXJkZW5pbmcpLCBzaG91bGRuJ3Qgd2UgcHVyZ2UgRU5EQlIgYWxzbyB3 aGVuICFjcHVfaGFzX3hlbl9pYnQsIGFuZA0KPiB0aGVuIGlkZWFsbHkgYWxsIG9mIHRoZW0/IFdo ZXJlYXMgaWYgdGhpcyBpcyBtYWlubHkgYWJvdXQgaGFyZGVuaW5nLA0KPiB3b3VsZG4ndCB0aGUg bWVzc2FnZSBiZXR0ZXIgc2F5ICJQdXJnZWQiIG9yICJDbG9iYmVyZWQiPw0KDQpJIGRpZCBoYXZl IGFuIFJGQyBhYm91dCB0aGlzLsKgIFR1cm5pbmcgRU5EQlIgaW50byBOT1A0IG1hdHRlcnMsIG9u IGENCkNFVC1JQlQtYWN0aXZlIHN5c3RlbSwgdG8gcmVzdHJpY3QgdGhlIGF2YWlsYWJsZSBvcHRp b25zIGFuIGF0dGFja2VyIGhhcw0Kd2hlbiB0aGV5IGhhdmUgYWxyZWFkeSBtYW5hZ2VkIHRvIGhp amFjayBhIGZ1bmN0aW9uIHBvaW50ZXIgKGkuZS4NCmFscmVhZHkgZ290IGEgcGFydGlhbCB3cml0 ZSBnYWRnZXQpLg0KDQpGcm9tIHRoYXQgcG9pbnQgb2YgdmlldywgaXQgaXMgaGFyZGVuaW5nLg0K DQpUaGUgZmlyc3QgdmVyc2lvbiBvZiB0aGlzIGxvZ2ljIHdhcyB0cnlpbmcgdG8gdXNlIFVEMSBp biB0aGUgc2FtZSB3YXkgYXMNCkxpbnV4IGRvZXMsIHRvIGhhcmRlbiBub24tQ0VUIGJ1aWxkcyB0 b28sIGJ1dCB0aGF0IGRvZXMgZGVwZW5kIG9uIGhhdmluZw0Kb2JqdG9vbCBzbyBhbGwgZGlyZWN0 IGJyYW5jaGVzIGNhbiBoYXZlIHRoZWlyIHRhcmdldHMgdXBkYXRlZCB0byBtaXNzDQp0aGUgVUQx IGluc3RydWN0aW9uLg0KDQp+QW5kcmV3DQoNClAuUy4gSSdkIHN0aWxsIGxpa2UgdG8gaGF2ZSAi YXdheSAldSBvZiAldSBlbmRicjY0J3MiLsKgIEl0IG9jY3VycyB0byBtZQ0KdGhhdCBub3cgd2Ug aGF2ZSBjaGVjay1lbmRicjY0LnNoLCB3ZSBjb3VsZCBgd2MgLWxgIHRoZSAkVkFMSUQgZmlsZSBh bmQNCnJlLWxpbmsgdGhpcyBiYWNrIGluLCBidXQgdGhlbiB3ZSBjb3VsZG4ndCBjaGVjayB0aGUg ZmluYWwgb2JqZWN0cy4NCg0K From xen-devel-bounces@lists.xenproject.org Tue Mar 01 12:56:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 12:56:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281381.479694 (Exim 4.92) (envelope-from ) id 1nP234-0002Su-VC; Tue, 01 Mar 2022 12:56:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281381.479694; Tue, 01 Mar 2022 12:56:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP234-0002Sn-R8; Tue, 01 Mar 2022 12:56:14 +0000 Received: by outflank-mailman (input) for mailman id 281381; Tue, 01 Mar 2022 12:56:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP233-0002SE-Mf for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 12:56:14 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2061c.outbound.protection.outlook.com [2a01:111:f400:7e1b::61c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f6540aee-995e-11ec-8539-5f4723681683; Tue, 01 Mar 2022 13:56:08 +0100 (CET) Received: from DBBPR09CA0018.eurprd09.prod.outlook.com (2603:10a6:10:c0::30) by PAXPR08MB7060.eurprd08.prod.outlook.com (2603:10a6:102:1df::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.25; Tue, 1 Mar 2022 12:56:05 +0000 Received: from DB5EUR03FT016.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:c0:cafe::d9) by DBBPR09CA0018.outlook.office365.com (2603:10a6:10:c0::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22 via Frontend Transport; Tue, 1 Mar 2022 12:56:05 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT016.mail.protection.outlook.com (10.152.20.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22 via Frontend Transport; Tue, 1 Mar 2022 12:56:04 +0000 Received: ("Tessian outbound 741ca6c82739:v113"); Tue, 01 Mar 2022 12:56:04 +0000 Received: from d81e6e463433.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 054DC2E8-B3C7-4C3E-A86C-84196CDFBB2E.1; Tue, 01 Mar 2022 12:55:54 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d81e6e463433.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 01 Mar 2022 12:55:54 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by VI1PR0801MB1757.eurprd08.prod.outlook.com (2603:10a6:800:5a::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.26; Tue, 1 Mar 2022 12:55:51 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::89b3:80a2:2b58:f1aa]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::89b3:80a2:2b58:f1aa%4]) with mapi id 15.20.5017.026; Tue, 1 Mar 2022 12:55:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f6540aee-995e-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qCdVBw5rxkZPLmnT0qaGwsnLpFP2EmcrHOrT1gbf+ZY=; b=WGREJ+3AVV8YsjEKdhIo6rUnJ1k+i+MVW0lkEwwiYy9oEnT+URPRv/61sLa8wyuViYTBR4YFp/hhAA2F2xJmfsAzRN8SX+XzZV+jRw+PN8VXKIb2YuAWKz22btt0R+/J30TYGuPkZTrW7UDcoBrJuMh/GdZJbBw2tU6ZDrw+Tg8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K93rsIQdhxqHbHOM/KFyYw4jVQuXwQNJ6fNv7gI7zHazXGO6qQm901NeyuNzheimLL69YCk51qIeg3JCjd5DSpHdrULNkV6Nr3SVTMCtE9fhk9ER8BNS3k1CfjSQ79MpgZyA8Yt0Fes0fPnn+oDnZUDH2iJeocsLSUxYHT+yBVpqM9mtZVshRohuJ8H0nCWqmgvbA+qnb+OcZbHoCiBhPAnxvs6utWXbq1w8c8GsURw8QlzYsRiD657DKwbBH5G68UIeFu7E1m/nzZtHfgMtwsNwcR7c08ovRGP3RjZCVk2spQWY9oAg/dQveClEgkZVXpCxDGF01XXRJqdtds3t+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qCdVBw5rxkZPLmnT0qaGwsnLpFP2EmcrHOrT1gbf+ZY=; b=lY50WP5QPTYo2Zl/RL0+TjvJqLhvMx38gSh7YJVaFtj/Ndq7ybnwajX+q3Q6FYeN1ki6TmWJIUrnzMq6Bw8vzFbItMGjKyfRqHts8cYIkNYVqujzT6ZmS7N1+Gp1e24ms6PUz1zve4RzxKeB23R8cymZWeTEoKuz9nODTPzqs0UBWU77SJwzv+zFinlIHcFTqiWHhp7hez+zvq5N9ScLSQZ3iEz1ozblE8+7BeB2eLG/6/LYMExgp1CPxraVBcwBSJmM0JpRwf23pKdupxz9doGzs8dW7/sciGzDVVO0qWATRsc2Oa6/82rsvnoaPWaAKBxT6JLaI+xsLfJXtGVBzw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qCdVBw5rxkZPLmnT0qaGwsnLpFP2EmcrHOrT1gbf+ZY=; b=WGREJ+3AVV8YsjEKdhIo6rUnJ1k+i+MVW0lkEwwiYy9oEnT+URPRv/61sLa8wyuViYTBR4YFp/hhAA2F2xJmfsAzRN8SX+XzZV+jRw+PN8VXKIb2YuAWKz22btt0R+/J30TYGuPkZTrW7UDcoBrJuMh/GdZJbBw2tU6ZDrw+Tg8= From: Wei Chen To: Stefano Stabellini CC: "xen-devel@lists.xenproject.org" , "julien@xen.org" , Bertrand Marquis , Penny Zheng , Henry Wang , nd Subject: RE: Proposal for Porting Xen to Armv8-R64 - DraftA Thread-Topic: Proposal for Porting Xen to Armv8-R64 - DraftA Thread-Index: AdgpQxtXwh7LkfydTgiYk9bhMgU+ogAn0mUAABEK2UAAHxozAACs/mTQ Date: Tue, 1 Mar 2022 12:55:50 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: CD711C5D640AC04CBD5FB43C2F9DAF45.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 1621c405-a3cd-49bc-730b-08d9fb82d8ab x-ms-traffictypediagnostic: VI1PR0801MB1757:EE_|DB5EUR03FT016:EE_|PAXPR08MB7060:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Him8/lhlIm4CXCrUabMJKylEmitvdg0U2t+2FCaYs58YZ9n7m/UUCYHE/Caqo/j4O2U3dr6uAwBHTc2nhKyVQ7I7NmaihT/q39LACBqm9Db+2vxHyl/+yS01FAv+DY+1+RipynYQ1+OSouRpIcKLQb/9rw5lJZuJMwHkuyE/DvbgRBbbXRMF3vpDAqcYSfIY0uSo+7VDXLWigUQCgZpgdqVl620OQ+2Rn/XghEeFlvq3yHICm/9E6R6uog8n08aAs8qFbKGn66nRbJMTi/dj88AEBJ/9qRojSnshxR1qCV+kGbv299aDMEXL51ltpc35U2zlotDUrJfyKqN1K9z1wORZQLVBgWcvrvV3BRQtCLF+zrBOGxJCARg1hOpQS/AIqPqyC0ZgFZyB1hMks81sRynN4L9O3+g2MHaTYTLEUBD/czHL5t+xw0zCnvk0QMFB0n/9aU89pm9nM2eIoXPsnrM13K0Dl5GVv63SnY91MAF5jxVyD8TeArkXVnCqyqWjoGa0i54vXwwPDux7O7Q4IqscSogP+ABq34jitG7nD3mzicb09b8npUAV1ynnI2ZDFvImeOiJ9e0TEi6Lp43kXLEzSGE5995Zo/I4303qnFN3Lh3zZPiaF3A6Ko8i70Gm5jiv4LOWxBL+CQ4DNN+MznKOGykWj4J7qdCrieUfmPaeoEO9jKWsOWaAro5TvUghDZlqFtBeKYjndeVuiScO8dIWeF1AR4BVvp7T9Op4ss6tNwERt9Oy228vOmDkVxl3H41BIK8VGG19sjHDQv14bI6mWGH25SLRBJZ1FgN14hdjKPFlXwZg4NOQ1ys5cmYH2HTFEGFmuZxTB2UiXlKB84RJ1TZfuoagCa5vO9rQj8I= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(966005)(8676002)(4326008)(71200400001)(53546011)(9686003)(122000001)(83380400001)(508600001)(55016003)(6916009)(54906003)(7696005)(8936002)(38100700002)(6506007)(86362001)(38070700005)(316002)(52536014)(5660300002)(2906002)(33656002)(26005)(186003)(30864003)(66476007)(66946007)(64756008)(76116006)(66556008)(66446008)(559001)(579004)(139555002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB1757 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT016.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 29806ce1-af3e-4bd6-7b9b-08d9fb82d05c X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wv4Y7hqzapO8o4HIlvlty5AtffPkTgMPXh5JskaU85zifNS/OdCNfffyNtTmjGOJb3sltD18QgKNLzsrIqkgBGBh8McdTDqHAPhkS30D58VY+8jVM/ONiPpvKR3HYSwAl7ybQKjD4J3cg+OQfEUsSbxwvIGBRv0QC5QbpdCq7lUoS4cSw2TBubNPMCpNkZpT42JIUGNDnc5vRKKkNIEDIe+fQmSAjoK2LxLkWXqAboukWZeypQD24Bf/EtNNzK+/I4qASg/lyLhQ0G9Op7TdALPzRN5ZS29SNruAtJ0V38C48ZOznWurvh9U7YMwEIY5xSPYc3YPo0x3HkhDldQ7Y7XHezoNrtKp6aD+QTYEnbda0k/sTS4sbfxjtawE6l4Sx8UGcEV4Qv02FBJBApjI2zTcFV53eQcfPhrOtdvSN7e7FMag31RK6+ZDWopTK6eBrfTHeKFJi3NlSOqlTiPDCYl5Y1l7RMjCe3x2Rzlju53E1Qm9Az/4Qp+eeaRxU1bL5W0AV9PFaYCIq9ThHUUFnIxO73HtNLIywXI5us/5eb12c5kbH7qTuQ00oNUQ2l9f0+WMvMSyX9cZkvwF3HFpvHCPJDjsaPWcMp/ZMSz39G/kFrQ9StOiL/FCmwl0WLmJxQQEiyewPr5GCObvsMg0XPvw10oBYIusFSBgAOaoFAKz0KIQ8s/aPnKYYy1Tx8l1z+RVto4BaFcD0iTbeeWwpdyV+XH0/TuysY5/wtQWgrda7cVOeJBl0ukHNVzH2t8wEsXxtonmd7Zj7kv5h7QOjkLWTWw0Ma6ZubmN5dLj4o7JL+Z7boSh1YpHVmXZ4MBrLYG132PUezCUA+TpZkTVEA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(336012)(356005)(8936002)(54906003)(316002)(36860700001)(81166007)(30864003)(2906002)(82310400004)(70586007)(9686003)(26005)(5660300002)(6862004)(8676002)(4326008)(70206006)(52536014)(40460700003)(47076005)(186003)(53546011)(7696005)(83380400001)(966005)(86362001)(6506007)(508600001)(55016003)(33656002)(139555002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2022 12:56:04.8986 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1621c405-a3cd-49bc-730b-08d9fb82d8ab X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT016.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7060 SGkgU3RlZmFubywNCg0KPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBTdGVm YW5vIFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+DQo+IFNlbnQ6IDIwMjLlubQy 5pyIMjbml6UgNzo1NA0KPiBUbzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+DQo+IENjOiBT dGVmYW5vIFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+OyB4ZW4tDQo+IGRldmVs QGxpc3RzLnhlbnByb2plY3Qub3JnOyBqdWxpZW5AeGVuLm9yZzsgQmVydHJhbmQgTWFycXVpcw0K PiA8QmVydHJhbmQuTWFycXVpc0Bhcm0uY29tPjsgUGVubnkgWmhlbmcgPFBlbm55LlpoZW5nQGFy bS5jb20+OyBIZW5yeSBXYW5nDQo+IDxIZW5yeS5XYW5nQGFybS5jb20+OyBuZCA8bmRAYXJtLmNv bT4NCj4gU3ViamVjdDogUkU6IFByb3Bvc2FsIGZvciBQb3J0aW5nIFhlbiB0byBBcm12OC1SNjQg LSBEcmFmdEENCj4gDQo+IE9uIEZyaSwgMjUgRmViIDIwMjIsIFdlaSBDaGVuIHdyb3RlOg0KPiA+ ID4gSGkgV2VpLA0KPiA+ID4NCj4gPiA+IFRoaXMgaXMgZXh0cmVtZWx5IGV4Y2l0aW5nLCB0aGFu a3MgZm9yIHRoZSB2ZXJ5IG5pY2Ugc3VtbWFyeSENCj4gPiA+DQo+ID4gPg0KPiA+ID4gT24gVGh1 LCAyNCBGZWIgMjAyMiwgV2VpIENoZW4gd3JvdGU6DQo+ID4gPiA+ICMgUHJvcG9zYWwgZm9yIFBv cnRpbmcgWGVuIHRvIEFybXY4LVI2NA0KPiA+ID4gPg0KPiA+ID4gPiBUaGlzIHByb3Bvc2FsIHdp bGwgaW50cm9kdWNlIHRoZSBQb0Mgd29yayBvZiBwb3J0aW5nIFhlbiB0byBBcm12OC0NCj4gUjY0 LA0KPiA+ID4gPiB3aGljaCBpbmNsdWRlczoNCj4gPiA+ID4gLSBUaGUgY2hhbmdlcyBvZiBjdXJy ZW50IFhlbiBjYXBhYmlsaXR5LCBsaWtlIFhlbiBidWlsZCBzeXN0ZW0sDQo+IG1lbW9yeQ0KPiA+ ID4gPsKgwqAgbWFuYWdlbWVudCwgZG9tYWluIG1hbmFnZW1lbnQsIHZDUFUgY29udGV4dCBzd2l0 Y2guDQo+ID4gPiA+IC0gVGhlIGV4cGFuZGVkIFhlbiBjYXBhYmlsaXR5LCBsaWtlIHN0YXRpYy1h bGxvY2F0aW9uIGFuZCBkaXJlY3QtbWFwLg0KPiA+ID4gPg0KPiA+ID4gPiAqKipOb3RlczoqKioN Cj4gPiA+ID4gMS4gKioqVGhpcyBwcm9wb3NhbCBvbmx5IGNvdmVycyB0aGUgd29yayBvZiBwb3J0 aW5nIFhlbiB0byBBcm12OC0NCj4gUjY0KioqDQo+ID4gPiA+wqDCoMKgICoqKnNpbmdsZSBDUFUu IFhlbiBTTVAgc3VwcG9ydCBvbiBBcm12OC1SNjQgcmVsYXRlcyB0byBBcm12OC1SKioqDQo+ID4g PiA+wqDCoMKgICoqKlRydXN0ZWQtRnJpbXdhcmUgKFRGLVIpLiBUaGlzIGlzIGFuIGV4dGVybmFs IGRlcGVuZGVuY3ksKioqDQo+ID4gPiA+wqDCoMKgICoqKnNvIHdlIHRoaW5rIHRoZSBkaXNjdXNz aW9uIG9mIFhlbiBTTVAgc3VwcG9ydCBvbiBBcm12OC1SNjQqKioNCj4gPiA+ID7CoMKgwqAgKioq c2hvdWxkIGJlIHN0YXJ0ZWQgd2hlbiBzaW5nbGUtQ1BVIHN1cHBvcnQgaXMgY29tcGxldGUuKioq DQo+ID4gPiA+IDIuICoqKlRoaXMgcHJvcG9zYWwgd2lsbCBub3QgdG91Y2ggeGVuLXRvb2xzLiBJ biBjdXJyZW50IHN0YWdlLCoqKg0KPiA+ID4gPsKgwqDCoCAqKipYZW4gb24gQXJtdjgtUjY0IG9u bHkgc3VwcG9ydCBkb20wbGVzcywgYWxsIGd1ZXN0cyBzaG91bGQqKioNCj4gPiA+ID7CoMKgwqAg KioqYmUgYm9vdGVkIGZyb20gZGV2aWNlIHRyZWUuKioqDQo+ID4gPiA+DQo+ID4gPiA+ICMjIDEu IEVzc2VudGlhbCBCYWNrZ3JvdW5kDQo+ID4gPiA+DQo+ID4gPiA+ICMjIyAxLjEuIEFybXY4LVI2 NCBQcm9maWxlDQo+ID4gPiA+IFRoZSBBcm12LVIgYXJjaGl0ZWN0dXJlIHByb2ZpbGUgd2FzIGRl c2lnbmVkIHRvIHN1cHBvcnQgdXNlIGNhc2VzDQo+IHRoYXQNCj4gPiA+ID4gaGF2ZSBhIGhpZ2gg c2Vuc2l0aXZpdHkgdG8gZGV0ZXJtaW5pc3RpYyBleGVjdXRpb24uIChlLmcuIEZ1ZWwNCj4gSW5q ZWN0aW9uLA0KPiA+ID4gPiBCcmFrZSBjb250cm9sLCBEcml2ZSB0cmFpbnMsIE1vdG9yIGNvbnRy b2wgZXRjKQ0KPiA+ID4gPg0KPiA+ID4gPiBBcm0gYW5ub3VuY2VkIEFybXY4LVIgaW4gMjAxMywg aXQgaXMgdGhlIGxhdGVzdCBnZW5lcmF0aW9uIEFybQ0KPiA+ID4gYXJjaGl0ZWN0dXJlDQo+ID4g PiA+IHRhcmdldGVkIGF0IHRoZSBSZWFsLXRpbWUgcHJvZmlsZS4gSXQgaW50cm9kdWNlcyB2aXJ0 dWFsaXphdGlvbiBhdA0KPiB0aGUNCj4gPiA+IGhpZ2hlc3QNCj4gPiA+ID4gc2VjdXJpdHkgbGV2 ZWwgd2hpbGUgcmV0YWluaW5nIHRoZSBQcm90ZWN0ZWQgTWVtb3J5IFN5c3RlbQ0KPiBBcmNoaXRl Y3R1cmUNCj4gPiA+IChQTVNBKQ0KPiA+ID4gPiBiYXNlZCBvbiBhIE1lbW9yeSBQcm90ZWN0aW9u IFVuaXQgKE1QVSkuIEluIDIwMjAsIEFybSBhbm5vdW5jZWQNCj4gQ29ydGV4LQ0KPiA+ID4gUjgy LA0KPiA+ID4gPiB3aGljaCBpcyB0aGUgZmlyc3QgQXJtIDY0LWJpdCBDb3J0ZXgtUiBwcm9jZXNz b3IgYmFzZWQgb24gQXJtdjgtUjY0Lg0KPiA+ID4gPg0KPiA+ID4gPiAtIFRoZSBsYXRlc3QgQXJt djgtUjY0IGRvY3VtZW50IGNhbiBiZSBmb3VuZCBoZXJlOg0KPiA+ID4gPsKgwqAgW0FybSBBcmNo aXRlY3R1cmUgUmVmZXJlbmNlIE1hbnVhbCBTdXBwbGVtZW50IC0gQXJtdjgsIGZvciBBcm12OC1S DQo+ID4gPiBBQXJjaDY0IGFyY2hpdGVjdHVyZQ0KPiA+ID4gcHJvZmlsZV0oaHR0cHM6Ly9kZXZl bG9wZXIuYXJtLmNvbS9kb2N1bWVudGF0aW9uL2RkaTA2MDAvbGF0ZXN0LykuDQo+ID4gPiA+DQo+ ID4gPiA+IC0gQXJtdi1SIEFyY2hpdGVjdHVyZSBwcm9ncmVzc2lvbjoNCj4gPiA+ID7CoMKgIEFy bXY3LVIgLT4gQXJtdjgtUiBBQXJjaDMyIC0+IEFybXY4IEFBcmNoNjQNCj4gPiA+ID7CoMKgIFRo ZSBmb2xsb3dpbmcgZmlndXJlIGlzIGEgc2ltcGxlIGNvbXBhcmlzb24gb2YgIlIiIHByb2Nlc3Nv cnMNCj4gYmFzZWQgb24NCj4gPiA+ID7CoMKgIGRpZmZlcmVudCBBcm12LVIgQXJjaGl0ZWN0dXJl cy4NCj4gPiA+ID7CoMKgICFbaW1hZ2VdKGh0dHBzOi8vZHJpdmUuZ29vZ2xlLmNvbS91Yz9leHBv cnQ9dmlldyZpZD0xbkU1UkFYYVg4elkySw0KPiBQWjhpDQo+ID4gPiBtQnBidklyMmVxQmd1RUIp DQo+ID4gPiA+DQo+ID4gPiA+IC0gVGhlIEFybXY4LVIgYXJjaGl0ZWN0dXJlIGV2b2x2ZWQgYWRk aXRpb25hbCBmZWF0dXJlcyBvbiB0b3Agb2YNCj4gQXJtdjctUjoNCj4gPiA+ID7CoMKgwqDCoCAt IEFuIGV4Y2VwdGlvbiBtb2RlbCB0aGF0IGlzIGNvbXBhdGlibGUgd2l0aCB0aGUgQXJtdjgtQSBt b2RlbA0KPiA+ID4gPsKgwqDCoMKgIC0gVmlydHVhbGl6YXRpb24gd2l0aCBzdXBwb3J0IGZvciBn dWVzdCBvcGVyYXRpbmcgc3lzdGVtcw0KPiA+ID4gPsKgwqDCoMKgwqDCoMKgwqAgLSBQTVNBIHZp cnR1YWxpemF0aW9uIHVzaW5nIE1QVXMgSW4gRUwyLg0KPiA+ID4gPiAtIFRoZSBuZXcgZmVhdHVy ZXMgb2YgQXJtdjgtUjY0IGFyY2hpdGVjdHVyZQ0KPiA+ID4gPsKgwqDCoMKgIC0gQWRkcyBzdXBw b3J0IGZvciB0aGUgNjQtYml0IEE2NCBpbnN0cnVjdGlvbiBzZXQsIHByZXZpb3VzbHkNCj4gQXJt djgtDQo+ID4gPiBSDQo+ID4gPiA+wqDCoMKgwqDCoMKgIG9ubHkgc3VwcG9ydGVkIEEzMi4NCj4g PiA+ID7CoMKgwqDCoCAtIFN1cHBvcnRzIHVwIHRvIDQ4LWJpdCBwaHlzaWNhbCBhZGRyZXNzaW5n LCBwcmV2aW91c2x5IHVwIHRvDQo+IDMyLWJpdA0KPiA+ID4gPsKgwqDCoMKgwqDCoCBhZGRyZXNz aW5nIHdhcyBzdXBwb3J0ZWQuDQo+ID4gPiA+wqDCoMKgwqAgLSBPcHRpb25hbCBBcm0gTmVvbiB0 ZWNobm9sb2d5IGFuZCBBZHZhbmNlZCBTSU1EDQo+ID4gPiA+wqDCoMKgwqAgLSBTdXBwb3J0cyB0 aHJlZSBFeGNlcHRpb24gTGV2ZWxzIChFTHMpDQo+ID4gPiA+wqDCoMKgwqDCoMKgwqDCoCAtIFNl Y3VyZSBFTDIgLSBUaGUgSGlnaGVzdCBQcml2aWxlZ2UsIE1QVSBvbmx5LCBmb3IgZmlybXdhcmUs DQo+ID4gPiBoeXBlcnZpc29yDQo+ID4gPiA+wqDCoMKgwqDCoMKgwqDCoCAtIFNlY3VyZSBFTDEg LSBSaWNoT1MgKE1NVSkgb3IgUlRPUyAoTVBVKQ0KPiA+ID4gPsKgwqDCoMKgwqDCoMKgwqAgLSBT ZWN1cmUgRUwwIC0gQXBwbGljYXRpb24gV29ya2xvYWRzDQo+ID4gPiA+wqDCoMKgwqAgLSBPcHRp b25hbGx5IHN1cHBvcnRzIFZpcnR1YWwgTWVtb3J5IFN5c3RlbSBBcmNoaXRlY3R1cmUgYXQgUy0N Cj4gRUwxL1MtDQo+ID4gPiBFTDAuDQo+ID4gPiA+wqDCoMKgwqDCoMKgIFRoaXMgbWVhbnMgaXQn cyBwb3NzaWJsZSB0byBydW4gcmljaCBPUyBrZXJuZWxzIC0gbGlrZSBMaW51eCAtDQo+ID4gPiBl aXRoZXINCj4gPiA+ID7CoMKgwqDCoMKgwqAgYmFyZS1tZXRhbCBvciBhcyBhIGd1ZXN0Lg0KPiA+ ID4gPiAtIERpZmZlcmVuY2VzIHdpdGggdGhlIEFybXY4LUEgQUFyY2g2NCBhcmNoaXRlY3R1cmUN Cj4gPiA+ID7CoMKgwqDCoCAtIFN1cHBvcnRzIG9ubHkgYSBzaW5nbGUgU2VjdXJpdHkgc3RhdGUg LSBTZWN1cmUuIFRoZXJlIGlzIG5vdA0KPiBOb24tDQo+ID4gPiBTZWN1cmUNCj4gPiA+ID7CoMKg wqDCoMKgwqAgZXhlY3V0aW9uIHN0YXRlIHN1cHBvcnRlZC4NCj4gPiA+ID7CoMKgwqDCoCAtIEVM MyBpcyBub3Qgc3VwcG9ydGVkLCBFTDIgaXMgbWFuZGF0b3J5LiBUaGlzIG1lYW5zIHNlY3VyZSBF TDINCj4gaXMNCj4gPiA+IHRoZQ0KPiA+ID4gPsKgwqDCoMKgwqDCoCBoaWdoZXN0IEVMLg0KPiA+ ID4gPsKgwqDCoMKgIC0gU3VwcG9ydHMgdGhlIEE2NCBJU0EgaW5zdHJ1Y3Rpb24NCj4gPiA+ID7C oMKgwqDCoMKgwqDCoMKgIC0gV2l0aCBhIHNtYWxsIHNldCBvZiB3ZWxsLWRlZmluZWQgZGlmZmVy ZW5jZXMNCj4gPiA+ID7CoMKgwqDCoCAtIFByb3ZpZGVzIGEgUE1TQSAoUHJvdGVjdGVkIE1lbW9y eSBTeXN0ZW0gQXJjaGl0ZWN0dXJlKSBiYXNlZA0KPiA+ID4gPsKgwqDCoMKgwqDCoCB2aXJ0dWFs aXphdGlvbiBtb2RlbC4NCj4gPiA+ID7CoMKgwqDCoMKgwqDCoMKgIC0gQXMgb3Bwb3NlZCB0byBB cm12OC1BIEFBcmNoNjQncyBWTVNBIGJhc2VkIFZpcnR1YWxpemF0aW9uDQo+ID4gPiA+wqDCoMKg wqDCoMKgwqDCoCAtIENhbiBzdXBwb3J0IGFkZHJlc3MgYml0cyB1cCB0byA1MiBpZiBGRUFUX0xQ QSBpcyBlbmFibGVkLA0KPiA+ID4gPsKgwqDCoMKgwqDCoMKgwqDCoMKgIG90aGVyd2lzZSA0OCBi aXRzLg0KPiA+ID4gPsKgwqDCoMKgwqDCoMKgwqAgLSBEZXRlcm1pbmVzIHRoZSBhY2Nlc3MgcGVy bWlzc2lvbnMgYW5kIG1lbW9yeSBhdHRyaWJ1dGVzIG9mDQo+ID4gPiA+wqDCoMKgwqDCoMKgwqDC oMKgwqAgdGhlIHRhcmdldCBQQS4NCj4gPiA+ID7CoMKgwqDCoMKgwqDCoMKgIC0gQ2FuIGltcGxl bWVudCBQTVNBdjgtNjQgYXQgRUwxIGFuZCBFTDINCj4gPiA+ID7CoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqAgLSBBZGRyZXNzIHRyYW5zbGF0aW9uIGZsYXQtbWFwcyB0aGUgVkEgdG8gdGhlIFBBIGZv ciBFTDINCj4gPiA+IFN0YWdlIDEuDQo+ID4gPiA+wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIC0g QWRkcmVzcyB0cmFuc2xhdGlvbiBmbGF0LW1hcHMgdGhlIFZBIHRvIHRoZSBQQSBmb3IgRUwxDQo+ ID4gPiBTdGFnZSAxLg0KPiA+ID4gPsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAtIEFkZHJlc3Mg dHJhbnNsYXRpb24gZmxhdC1tYXBzIHRoZSBJUEEgdG8gdGhlIFBBIGZvcg0KPiBFTDENCj4gPiA+ IFN0YWdlIDIuDQo+ID4gPiA+wqDCoMKgwqAgLSBQTVNBIGluIEVMMSAmIEVMMiBpcyBjb25maWd1 cmFibGUsIFZNU0EgaW4gRUwxIGlzIGNvbmZpZ3VyYWJsZS4NCj4gPiA+ID4NCj4gPiA+ID4gIyMj IDEuMi4gWGVuIENoYWxsZW5nZXMgd2l0aCBQTVNBIFZpcnR1YWxpemF0aW9uDQo+ID4gPiA+IFhl biBpcyBQTVNBIHVuYXdhcmUgVHlwZS0xIEh5cGVydmlzb3IsIGl0IHdpbGwgbmVlZCBtb2RpZmlj YXRpb25zIHRvDQo+IHJ1bg0KPiA+ID4gPiB3aXRoIGFuIE1QVSBhbmQgaG9zdCBtdWx0aXBsZSBn dWVzdCBPU2VzLg0KPiA+ID4gPg0KPiA+ID4gPiAtIE5vIE1NVSBhdCBFTDI6DQo+ID4gPiA+wqDC oMKgwqAgLSBObyBFTDIgU3RhZ2UgMSBhZGRyZXNzIHRyYW5zbGF0aW9uDQo+ID4gPiA+wqDCoMKg wqDCoMKgwqDCoCAtIFhlbiBwcm92aWRlcyBmaXhlZCBBUk02NCB2aXJ0dWFsIG1lbW9yeSBsYXlv dXQgYXMgYmFzaXMgb2YNCj4gRUwyDQo+ID4gPiA+wqDCoMKgwqDCoMKgwqDCoMKgwqAgc3RhZ2Ug MSBhZGRyZXNzIHRyYW5zbGF0aW9uLCB3aGljaCBpcyBub3QgYXBwbGljYWJsZSBvbg0KPiBNUFUN Cj4gPiA+IHN5c3RlbSwNCj4gPiA+ID7CoMKgwqDCoMKgwqDCoMKgwqDCoCB3aGVyZSB0aGVyZSBp cyBubyB2aXJ0dWFsIGFkZHJlc3NpbmcuIEFzIGEgcmVzdWx0LCBhbnkNCj4gPiA+IG9wZXJhdGlv bg0KPiA+ID4gPsKgwqDCoMKgwqDCoMKgwqDCoMKgIGludm9sdmluZyB0cmFuc2l0aW9uIGZyb20g UEEgdG8gVkEsIGxpa2UgaW9yZW1hcCwgbmVlZHMNCj4gPiA+IG1vZGlmaWNhdGlvbg0KPiA+ID4g PsKgwqDCoMKgwqDCoMKgwqDCoMKgIG9uIE1QVSBzeXN0ZW0uDQo+ID4gPiA+wqDCoMKgwqAgLSBY ZW4ncyBydW4tdGltZSBhZGRyZXNzZXMgYXJlIHRoZSBzYW1lIGFzIHRoZSBsaW5rIHRpbWUNCj4g YWRkcmVzc2VzLg0KPiA+ID4gPsKgwqDCoMKgwqDCoMKgwqAgLSBFbmFibGUgUElDIChwb3NpdGlv bi1pbmRlcGVuZGVudCBjb2RlKSBvbiBhIHJlYWwtdGltZQ0KPiB0YXJnZXQNCj4gPiA+ID7CoMKg wqDCoMKgwqDCoMKgwqDCoCBwcm9jZXNzb3IgcHJvYmFibHkgdmVyeSByYXJlLg0KPiA+ID4gPsKg wqDCoMKgIC0gWGVuIHdpbGwgbmVlZCB0byB1c2UgdGhlIEVMMiBNUFUgbWVtb3J5IHJlZ2lvbiBk ZXNjcmlwdG9ycyB0bw0KPiA+ID4gbWFuYWdlDQo+ID4gPiA+wqDCoMKgwqDCoMKgIGFjY2VzcyBw ZXJtaXNzaW9ucyBhbmQgYXR0cmlidXRlcyBmb3IgYWNjZXNzZXMgbWFkZSBieSBWTXMgYXQNCj4g PiA+IEVMMS8wLg0KPiA+ID4gPsKgwqDCoMKgwqDCoMKgwqAgLSBYZW4gY3VycmVudGx5IHJlbGll cyBvbiBNTVUgRUwxIHN0YWdlIDIgdGFibGUgdG8gbWFuYWdlDQo+IHRoZXNlDQo+ID4gPiA+wqDC oMKgwqDCoMKgwqDCoMKgwqAgYWNjZXNzZXMuDQo+ID4gPiA+IC0gTm8gTU1VIFN0YWdlIDIgdHJh bnNsYXRpb24gYXQgRUwxOg0KPiA+ID4gPsKgwqDCoMKgIC0gQSBndWVzdCBkb2Vzbid0IGhhdmUg YW4gaW5kZXBlbmRlbnQgZ3Vlc3QgcGh5c2ljYWwgYWRkcmVzcw0KPiBzcGFjZQ0KPiA+ID4gPsKg wqDCoMKgIC0gQSBndWVzdCBjYW4gbm90IHJldXNlIHRoZSBjdXJyZW50IEludGVybWVkaWF0ZSBQ aHlzaWNhbA0KPiBBZGRyZXNzDQo+ID4gPiA+wqDCoMKgwqDCoMKgIG1lbW9yeSBsYXlvdXQNCj4g PiA+ID7CoMKgwqDCoCAtIEEgZ3Vlc3QgdXNlcyBwaHlzaWNhbCBhZGRyZXNzZXMgdG8gYWNjZXNz IG1lbW9yeSBhbmQgZGV2aWNlcw0KPiA+ID4gPsKgwqDCoMKgIC0gVGhlIE1QVSBhdCBFTDIgbWFu YWdlcyBFTDEgc3RhZ2UgMiBhY2Nlc3MgcGVybWlzc2lvbnMgYW5kDQo+ID4gPiBhdHRyaWJ1dGVz DQo+ID4gPiA+IC0gVGhlcmUgYXJlIGEgbGltaXRlZCBudW1iZXIgb2YgTVBVIHByb3RlY3Rpb24g cmVnaW9ucyBhdCBib3RoIEVMMg0KPiBhbmQNCj4gPiA+IEVMMToNCj4gPiA+ID7CoMKgwqDCoCAt IEFyY2hpdGVjdHVyYWxseSwgdGhlIG1heGltdW0gbnVtYmVyIG9mIHByb3RlY3Rpb24gcmVnaW9u cyBpcw0KPiAyNTYsDQo+ID4gPiA+wqDCoMKgwqDCoMKgIHR5cGljYWwgaW1wbGVtZW50YXRpb25z IGhhdmUgMzIuDQo+ID4gPiA+wqDCoMKgwqAgLSBCeSBjb250cmFzdCwgWGVuIGRvZXMgbm90IG5l ZWQgdG8gY29uc2lkZXIgdGhlIG51bWJlciBvZiBwYWdlDQo+ID4gPiB0YWJsZQ0KPiA+ID4gPsKg wqDCoMKgwqDCoCBlbnRyaWVzIGluIHRoZW9yeSB3aGVuIHVzaW5nIE1NVS4NCj4gPiA+ID4gLSBU aGUgTVBVIHByb3RlY3Rpb24gcmVnaW9ucyBhdCBFTDIgbmVlZCB0byBiZSBzaGFyZWQgYmV0d2Vl biB0aGUNCj4gPiA+IGh5cGVydmlzb3INCj4gPiA+ID7CoMKgIGFuZCB0aGUgZ3Vlc3Qgc3RhZ2Ug Mi4NCj4gPiA+ID7CoMKgwqDCoCAtIFJlcXVpcmVzIGNhcmVmdWwgY29uc2lkZXJhdGlvbiAtIG1h eSBpbXBhY3QgZmVhdHVyZSAnZnVsbG5lc3MnDQo+IG9mDQo+ID4gPiBib3RoDQo+ID4gPiA+wqDC oMKgwqDCoMKgIHRoZSBoeXBlcnZpc29yIGFuZCB0aGUgZ3Vlc3QNCj4gPiA+ID7CoMKgwqDCoCAt IEJ5IGNvbnRyYXN0LCB3aGVuIHVzaW5nIE1NVSwgWGVuIGhhcyBzdGFuZGFsb25lIFAyTSB0YWJs ZSBmb3INCj4gPiA+IGd1ZXN0DQo+ID4gPiA+wqDCoMKgwqDCoMKgIHN0YWdlIDIgYWNjZXNzZXMu DQo+ID4gPiA+DQo+ID4gPiA+ICMjIDIuIFByb3Bvc2VkIGNoYW5nZXMgb2YgWGVuDQo+ID4gPiA+ ICMjIyAqKjIuMS4gQ2hhbmdlcyBvZiBidWlsZCBzeXN0ZW06KioNCj4gPiA+ID4NCj4gPiA+ID4g LSAqKipJbnRyb2R1Y2UgbmV3IEtjb25maWcgb3B0aW9ucyBmb3IgQXJtdjgtUjY0KioqOg0KPiA+ ID4gPsKgwqAgVW5saWtlIEFybXY4LUEsIGJlY2F1c2UgbGFjayBvZiBNTVUgc3VwcG9ydCBvbiBB cm12OC1SNjQsIHdlIG1heQ0KPiBub3QNCj4gPiA+ID7CoMKgIGV4cGVjdCBvbmUgWGVuIGJpbmFy eSB0byBydW4gb24gYWxsIG1hY2hpbmVzLiBYZW4gaW1hZ2VzIGFyZSBub3QNCj4gPiA+IGNvbW1v bg0KPiA+ID4gPsKgwqAgYWNyb3NzIEFybXY4LVI2NCBwbGF0Zm9ybXMuIFhlbiBtdXN0IGJlIHJl LWJ1aWx0IGZvciBkaWZmZXJlbnQNCj4gQXJtdjgtDQo+ID4gPiBSNjQNCj4gPiA+ID7CoMKgIHBs YXRmb3Jtcy4gQmVjYXVzZSB0aGVzZSBwbGF0Zm9ybXMgbWF5IGhhdmUgZGlmZmVyZW50IG1lbW9y eQ0KPiBsYXlvdXQNCj4gPiA+IGFuZA0KPiA+ID4gPsKgwqAgbGluayBhZGRyZXNzLg0KPiA+ID4g PsKgwqDCoMKgIC0gYEFSTTY0X1Y4UmA6DQo+ID4gPiA+wqDCoMKgwqDCoMKgIFRoaXMgb3B0aW9u IGVuYWJsZXMgQXJtdjgtUiBwcm9maWxlIGZvciBBcm02NC4gRW5hYmxpbmcgdGhpcw0KPiA+ID4g b3B0aW9uDQo+ID4gPiA+wqDCoMKgwqDCoMKgIHJlc3VsdHMgaW4gc2VsZWN0aW5nIE1QVS4gVGhp cyBLY29uZmlnIG9wdGlvbiBpcyB1c2VkIHRvIGdhdGUNCj4gc29tZQ0KPiA+ID4gPsKgwqDCoMKg wqDCoCBBcm12OC1SNjQgc3BlY2lmaWMgY29kZSBleGNlcHQgTVBVIGNvZGUsIGxpa2Ugc29tZSBj b2RlIGZvcg0KPiBBcm12OC0NCj4gPiA+IFI2NA0KPiA+ID4gPsKgwqDCoMKgwqDCoCBvbmx5IHN5 c3RlbSBJRCByZWdpc3RlcnMgYWNjZXNzLg0KPiA+ID4gPg0KPiA+ID4gPsKgwqDCoMKgIC0gYEFS TV9NUFVgDQo+ID4gPiA+wqDCoMKgwqDCoMKgIFRoaXMgb3B0aW9uIGVuYWJsZXMgTVBVIG9uIEFS TXY4LVIgYXJjaGl0ZWN0dXJlLiBFbmFibGluZyB0aGlzDQo+ID4gPiBvcHRpb24NCj4gPiA+ID7C oMKgwqDCoMKgwqAgcmVzdWx0cyBpbiBkaXNhYmxpbmcgTU1VLiBUaGlzIEtjb25maWcgb3B0aW9u IGlzIHVzZWQgdG8gZ2F0ZQ0KPiBzb21lDQo+ID4gPiA+wqDCoMKgwqDCoMKgIEFSTV9NUFUgc3Bl Y2lmaWMgY29kZS4gT25jZSB3aGVuIHRoaXMgS2NvbmZpZyBvcHRpb24gaGFzIGJlZW4NCj4gPiA+ IGVuYWJsZWQsDQo+ID4gPiA+wqDCoMKgwqDCoMKgIHRoZSBNTVUgcmVsYXRlIGNvZGUgd2lsbCBu b3QgYmUgYnVpbHQgZm9yIEFybXY4LVI2NC4gVGhlDQo+IHJlYXNvbg0KPiA+ID4gd2h5DQo+ID4g PiA+wqDCoMKgwqDCoMKgIG5vdCBkZXBlbmRzIG9uIHJ1bnRpbWUgZGV0ZWN0aW9uIHRvIHNlbGVj dCBNTVUgb3IgTVBVIGlzIHRoYXQsDQo+IHdlDQo+ID4gPiBkb24ndA0KPiA+ID4gPsKgwqDCoMKg wqDCoCB0aGluayB3ZSBjYW4gdXNlIG9uZSBpbWFnZSBmb3IgYm90aCBBcm12OC1SNjQgYW5kIEFy bXY4LUE2NC4NCj4gPiA+IEFub3RoZXINCj4gPiA+ID7CoMKgwqDCoMKgwqAgcmVhc29uIHRoYXQg d2Ugc2VwYXJhdGUgTVBVIGFuZCBWOFIgaW4gcHJvdmlzaW9uIHRvIGFsbG93IHRvDQo+ID4gPiBz dXBwb3J0IE1QVQ0KPiA+ID4gPsKgwqDCoMKgwqDCoCBvbiAzMmJpdCBBcm0gb25lIGRheS4NCj4g PiA+ID4NCj4gPiA+ID7CoMKgwqDCoCAtIGBYRU5fU1RBUlRfQUREUkVTU2ANCj4gPiA+ID7CoMKg wqDCoMKgwqAgVGhpcyBvcHRpb24gYWxsb3dzIHRvIHNldCB0aGUgY3VzdG9tIGFkZHJlc3MgYXQg d2hpY2ggWGVuIHdpbGwNCj4gYmUNCj4gPiA+ID7CoMKgwqDCoMKgwqAgbGlua2VkLiBUaGlzIGFk ZHJlc3MgbXVzdCBiZSBhbGlnbmVkIHRvIGEgcGFnZSBzaXplLiBYZW4ncw0KPiBydW4tDQo+ID4g PiB0aW1lDQo+ID4gPiA+wqDCoMKgwqDCoMKgIGFkZHJlc3NlcyBhcmUgdGhlIHNhbWUgYXMgdGhl IGxpbmsgdGltZSBhZGRyZXNzZXMuIERpZmZlcmVudA0KPiA+ID4gcGxhdGZvcm1zDQo+ID4gPiA+ wqDCoMKgwqDCoMKgIG1heSBoYXZlIGRpZmZlcm50IG1lbW9yeSBsYXlvdXQuIFRoaXMgS2NvbmZp ZyBvcHRpb24gcHJvdmlkZXMNCj4gPiA+IHVzZXJzDQo+ID4gPiA+wqDCoMKgwqDCoMKgIHRoZSBh YmlsaXR5IHRvIHNlbGVjdCBwcm9wZXIgbGluayBhZGRyZXNzZXMgZm9yIHRoZWlyIGJvYXJkcy4N Cj4gPiA+ID7CoMKgwqDCoMKgwqAgKioqTm90ZXM6IEZpeGVkIGxpbmsgYWRkcmVzcyBtZWFucyB0 aGUgWGVuIGJpbmFyeSBjb3VsZCBub3QNCj4gYmUqKioNCj4gPiA+ID7CoMKgwqDCoMKgwqAgKioq cmVsb2NhdGVkIGJ5IEVGSSBsb2FkZXIuIFNvIGluIGN1cnJlbnQgc3RhZ2UsIFhlbiBjb3VsZA0K PiBub3QqKioNCj4gPiA+ID7CoMKgwqDCoMKgwqAgKioqYmUgbGF1bmNoZWQgYXMgYW4gRUZJIGFw cGxpY2F0aW9uIG9uIEFybXY4LVI2NC4qKioNCj4gPiA+ID4NCj4gPiA+ID7CoMKgwqDCoCAtIGBB Uk1fTVBVX05PUk1BTF9NRU1PUllfU1RBUlRgIGFuZCBgQVJNX01QVV9OT1JNQUxfTUVNT1JZX0VO RGANCj4gPiA+ID7CoMKgwqDCoMKgwqAgYEFSTV9NUFVfREVWSUNFX01FTU9SWV9TVEFSVGAgYW5k IGBBUk1fTVBVX0RFVklDRV9NRU1PUllfRU5EYA0KPiA+ID4gPsKgwqDCoMKgwqDCoCBUaGVzZSBL Y29uZmlnIG9wdGlvbnMgYWxsb3cgdG8gc2V0IG1lbW9yeSByZWdpb25zIGZvciBYZW4gY29kZSwN Cj4gPiA+IGRhdGENCj4gPiA+ID7CoMKgwqDCoMKgwqAgYW5kIGRldmljZSBtZW1vcnkuIEJlZm9y ZSBwYXJzaW5nIG1lbW9yeSBpbmZvcm1hdGlvbiBmcm9tDQo+IGRldmljZQ0KPiA+ID4gdHJlZSwN Cj4gPiA+ID7CoMKgwqDCoMKgwqAgWGVuIHdpbGwgdXNlIHRoZSB2YWx1ZXMgdGhhdCBzdG9yZWQg aW4gdGhlc2Ugb3B0aW9ucyB0byBzZXR1cA0KPiA+ID4gYm9vdC10aW1lDQo+ID4gPiA+wqDCoMKg wqDCoMKgIE1QVSBjb25maWd1cmF0aW9uLiBXaHkgd2UgbmVlZCBhIGJvb3QtdGltZSBNUFUgY29u ZmlndXJhdGlvbj8NCj4gPiA+ID7CoMKgwqDCoMKgwqAgMS4gTW9yZSBkZXRlcm1pbmlzdGljOiBB cm0gTVBVIHN1cHBvcnRzIGJhY2tncm91bmQgcmVnaW9ucywNCj4gPiA+ID7CoMKgwqDCoMKgwqDC oMKgwqAgaWYgd2UgZG9uJ3QgY29uZmlndXJlIHRoZSBNUFUgcmVnaW9ucyBhbmQgZG9uJ3QgZW5h YmxlIE1QVS4NCj4gPiA+ID7CoMKgwqDCoMKgwqDCoMKgwqAgV2UgY2FuIGVuYWJsZSBNUFUgYmFj a2dyb3VuZCByZWdpb25zLiBCdXQgdGhhdCBtZWFucyBhbGwNCj4gUkFNDQo+ID4gPiA+wqDCoMKg wqDCoMKgwqDCoMKgIGlzIFJXWC4gUmFuZG9tIHZhbHVlcyBpbiBSQU0gb3IgbWFsaWNpb3VzbHkg ZW1iZWRkZWQgZGF0YQ0KPiBjYW4NCj4gPiA+ID7CoMKgwqDCoMKgwqDCoMKgwqAgYmUgZXhwbG9p dGVkLiBVc2luZyB0aGVzZSBLY29uZmlnIG9wdGlvbnMgYWxsb3cgdXNlcnMgdG8NCj4gaGF2ZQ0K PiA+ID4gPsKgwqDCoMKgwqDCoMKgwqDCoCBhIGRldGVybWluaXN0aWMgUkFNIGFyZWEgdG8gZXhl Y3V0ZSBjb2RlLg0KPiA+ID4gPsKgwqDCoMKgwqDCoCAyLiBNb3JlIGNvbXBhdGlibGU6IE9uIHNv bWUgQXJtdjgtUjY0IHBsYXRmb3JtcywgaWYgdGhlIE1QVSBpcw0KPiA+ID4gPsKgwqDCoMKgwqDC oMKgwqDCoCBkaXNhYmxlZCwgdGhlIGBkYyB6dmFgIGluc3RydWN0aW9uIHdpbGwgbWFrZSB0aGUg c3lzdGVtDQo+IGhhbHQuDQo+ID4gPiA+wqDCoMKgwqDCoMKgwqDCoMKgIEFuZCB0aGlzIGluc3Ry dWN0aW9uIHdpbGwgYmUgZW1iZWRkZWQgaW4gc29tZSBidWlsdC1pbg0KPiA+ID4gZnVuY3Rpb25z LA0KPiA+ID4gPsKgwqDCoMKgwqDCoMKgwqDCoCBsaWtlIGBtZW1vcnkgc2V0YC4gSWYgd2UgdXNl IGAtZGRvbnRfdXNlX2RjYCB0byByZWJ1aWxkIEdDQywNCj4gPiA+ID7CoMKgwqDCoMKgwqDCoMKg wqAgdGhlIGJ1aWx0LWluIGZ1bmN0aW9ucyB3aWxsIG5vdCBjb250YWluIGBkYyB6dmFgLiBIb3dl dmVyLA0KPiBpdA0KPiA+ID4gaXMNCj4gPiA+ID7CoMKgwqDCoMKgwqDCoMKgwqAgb2J2aW91c2x5 IHVubGlrZWx5IHRoYXQgd2Ugd2lsbCBiZSBhYmxlIHRvIHJlY29tcGlsZSBhbGwNCj4gR0NDDQo+ ID4gPiA+wqDCoMKgwqDCoMKgwqDCoMKgIGZvciBBUk12OC1SNjQuDQo+ID4gPiA+wqDCoMKgwqDC oMKgIDMuIE9uZSBvcHRpb25hbCBpZGVhOg0KPiA+ID4gPsKgwqDCoMKgwqDCoMKgwqDCoMKgIFdl IGNhbiBtYXAgYFhFTl9TVEFSVF9BRERSRVNTYCB0byBgWEVOX1NUQVJUX0FERFJFU1MgKw0KPiAy TUJgIG9yDQo+ID4gPiA+wqDCoMKgwqDCoMKgwqDCoMKgwqAgYFhFTl9TVEFSVF9BRERSRVNTYCB0 byBgWEVOX1NUQVJUX0FERFJFU1MgKyBpbWFnZV9lbmRgIGZvcg0KPiA+ID4gPsKgwqDCoMKgwqDC oMKgwqDCoMKgIE1QVSBub3JtYWwgbWVtb3J5LiBJdCdzIGVub3VnaCB0byBzdXBwb3J0IFhlbiBy dW4gaW4gYm9vdA0KPiB0aW1lLg0KPiA+ID4NCj4gPiA+IEkgY2FuIGltYWdpbmUgdGhhdCB3ZSBu ZWVkIHRvIGhhdmUgYSBkaWZmZXJlbnQgWGVuIGJ1aWxkIGZvciBlYWNoDQo+ID4gPiBBUk12OC1S IHBsYXRmb3JtLiBEbyB5b3UgZW52aXNpb24gdGhhdCBYRU5fU1RBUlRfQUREUkVTUyBhbmQNCj4g PiA+IEFSTV9NUFVfKl9NRU1PUllfU1RBUlQvRU5EIGFyZSBwcmVjb25maWd1cmVkIGJhc2VkIG9u IHRoZSBwbGF0Zm9ybQ0KPiA+ID4gY2hvaWNlIGF0IGJ1aWxkIHRpbWU/IEkgZG9uJ3QgdGhpbmsg d2Ugd2FudCBhIHVzZXIgdG8gcHJvdmlkZSBhbGwgb2YNCj4gPiA+IHRob3NlIGFkZHJlc3NlcyBi eSBoYW5kLCByaWdodD8NCj4gPg0KPiA+IFllcywgdGhpcyBpcyBpbiBvdXIgVE9ETyBsaXN0LiBX ZSB3YW50IHRvIHJldXNlIGN1cnJlbnQgYXJtL3BsYXRmb3Jtcw0KPiBhbmQNCj4gPiBLY29uZmln IG1lbnUgZm9yIEFybXY4LVIuDQo+IA0KPiBPSywgZ29vZA0KPiANCj4gDQo+ID4gPiBUaGUgbmV4 dCBxdWVzdGlvbiBpcyB3aGV0aGVyIHdlIGNvdWxkIGF1dG9tYXRpY2FsbHkgZ2VuZXJhdGUNCj4g PiA+IFhFTl9TVEFSVF9BRERSRVNTIGFuZCBBUk1fTVBVXypfTUVNT1JZX1NUQVJUL0VORCBiYXNl ZCBvbiB0aGUgcGxhdGZvcm0NCj4gPiA+IGRldmljZSB0cmVlIGF0IGJ1aWxkIHRpbWUgKGF0IGJ1 aWxkIHRpbWUsIG5vdCBydW50aW1lKS4gVGhhdCB3b3VsZA0KPiA+ID4gbWFrZSB0aGluZ3MgYSBs b3QgZWFzaWVyIGFuZCBpdCBpcyBhbHNvIGFsaWduZWQgd2l0aCB0aGUgd2F5IFplcGh5cg0KPiBh bmQNCj4gPiA+IG90aGVyIFJUT1NlcyBhbmQgYmFyZW1ldGFsIGFwcHMgd29yay4NCj4gPg0KPiA+ IEl0J3MgYSBjb25zaWRlcmFibGUgb3B0aW9uLiBCdXQgaGVyZSB3ZSBtYXkgZW5jb3VudGVyIHNv bWUgcHJvYmxlbXMgbmVlZA0KPiA+IHRvIGJlIHNvbHZlZCBmaXJzdDoNCj4gPiAxLiBEb2VzIENP TkZJR19EVEIgbXVzdCBiZSBzZWxlY3RlZCBieSBkZWZhdWx0IG9uIEFybXY4LVI/IFdpdGhvdXQN Cj4gZmlybXdhcmUNCj4gPiDCoMKgIG9yIGJvb3Rsb2FkZXIgKGxpa2UgdS1ib290KSwgd2UgaGF2 ZSB0byBidWlsZCBEVEIgaW50byBYZW4gYmluYXJ5Lg0KPiANCj4gQ09ORklHX0RUQiBzaG91bGQg dHJpZ2dlciBydW50aW1lIHN1cHBvcnQgZm9yIGRldmljZSB0cmVlLCB3aGlsZSBoZXJlIHdlDQo+ IGFyZSB0YWxraW5nIGFib3V0IGJ1aWxkIHRpbWUgc3VwcG9ydCBmb3IgZGV2aWNlIHRyZWUuIEl0 IGlzIHZlcnkNCj4gZGlmZmVyZW50Lg0KPiANCj4gSnVzdCB0byBtYWtlIGFuIGV4YW1wbGUsIHRo ZSB3aG9sZSBidWlsZC10aW1lIGRldmljZSB0cmVlIGNvdWxkIGJlDQo+IHNjYW5uZWQgYnkgTWFr ZWZpbGVzIGFuZCBvdGhlciBzY3JpcHRzLCBsZWFkaW5nIHRvIEMgaGVhZGVyIGZpbGVzDQo+IGdl bmVyYXRpb25zLCBidXQgbm8gY29kZSBpbiBYZW4gdG8gcGFyc2UgZGV2aWNlIHRyZWUgYXQgYWxs Lg0KPiANCj4gRFRCIC0tLT4gTWFrZWZpbGVzL3NjcmlwdHMgLS0tPiAuaCBmaWxlcyAtLS0+IE1h a2VmaWxlcy9zY3JpcHRzIC0tLT4geGVuDQo+IA0KDQpZZXMsIHRoaXMgaXMgZmVhc2libGUuDQoN Cj4gDQo+IEkgYW0gbm90IHNheWluZyB0aGlzIGlzIHRoZSBiZXN0IHdheSB0byBkbyBpdCwgSSBh bSBvbmx5IHBvaW50aW5nIG91dA0KPiB0aGF0IGJ1aWxkLXRpbWUgZGV2aWNlIHRyZWUgZG9lcyBu b3QgaW1wbHkgcnVuLXRpbWUgZGV2aWNlIHRyZWUuIEFsc28sDQo+IGl0IGRvZXNuJ3QgaW1wbHkg YSBEVEIgYnVpbHQtaW4gdGhlIFhlbiBiaW5hcnkgKGFsdGhvdWdoIHRoYXQgaXMgYWxzbyBhbg0K PiBvcHRpb24pLg0KPiANCg0KSSBhZ3JlZS4NCg0KPiBUaGUgd2F5IG1hbnkgYmFyZW1ldGFsIE9T ZXMgYW5kIFJUT1NlcyB3b3JrIGlzIHRoYXQgdGhleSB0YWtlIGEgRFRCIGFzDQo+IGlucHV0IHRv IHRoZSBidWlsZCAqb25seSouIEZyb20gdGhlIERUQiwgdGhlIGJ1aWxkLXRpbWUgbWFrZSBzeXN0 ZW0NCj4gZ2VuZXJhdGVzICNkZWZpbmVzIGFuZCBoZWFkZXIgZmlsZXMgdGhhdCBhcmUgaW1wb3J0 ZWQgaW4gQy4NCj4gDQo+IFRoZSByZXN1bHRpbmcgUlRPUyBiaW5hcnkgZG9lc24ndCBuZWVkIHN1 cHBvcnQgZm9yIERUQiwgYmVjYXVzZSBhbGwgdGhlDQo+IHJpZ2h0IGFkZHJlc3NlcyBoYXZlIGFs cmVhZHkgYmVlbiBwcm92aWRlZCBhcyAjZGVmaW5lIGJ5IHRoZSBNYWtlDQo+IHN5c3RlbS4NCj4g DQo+IEkgZG9uJ3QgdGhpbmsgd2UgbmVlZCB0byBnbyB0byB0aGUgZXh0cmVtZSBvZiByZW1vdmlu ZyBEVEIgc3VwcG9ydCBmcm9tDQo+IFhlbiBvbiBBUk12OC1SLiBJIGFtIG9ubHkgc2F5aW5nIHRo YXQgaWYgd2UgYWRkIGJ1aWxkLXRpbWUgZGV2aWNlIHRyZWUNCj4gc3VwcG9ydCBpdCB3b3VsZCBt YWtlIGl0IGVhc2llciB0byBzdXBwb3J0IG11bHRpcGxlIGJvYXJkcyB3aXRob3V0DQo+IGhhdmlu ZyB0byBoYXZlIHBsYXRmb3JtIGZpbGVzIGluIFhlbiBmb3IgZWFjaCBvZiB0aGVtLCBhbmQgd2Ug Y2FuIGRvDQo+IHRoYXQgd2l0aG91dCBhbnkgaW1wYWN0IG9uIHJ1bnRpbWUgZGV2aWNlIHRyZWUg cGFyc2luZy4NCj4gDQoNCkFzIFY4UidzIHVzZSBjYXNlcyBtYXliZSBtYWlubHkgZm9jdXMgb24g c29tZSByZWFsLXRpbWUvY3JpdGljYWwgc2NlbmFyaW9zLA0KdGhpcyBtYXkgYmUgYSBiZXR0ZXIg bWV0aG9kIHRoYW4gcGxhdGZvcm0gZmlsZXMuIFdlIGRvbid0IG5lZWQgdG8gbWFpbnRhaW4NCnRo ZSBwbGF0Zm9ybSByZWxhdGVkIGRlZmluaXRpb25zIGhlYWRlciBmaWxlcy4gWGVuIGFsc28gY2Fu IHNraXAgdGhlIHNvbWUNCnBsYXRmb3JtIGluZm9ybWF0aW9uIHBhcnNpbmcgaW4gYm9vdCB0aW1l LiBUaGlzIHdpbGwgaW5jcmVhc2UgdGhlIGJvb3Qgc3BlZWQNCm9mIFhlbiBpbiByZWFsLXRpbWUv Y3JpdGljYWwgc2NlbmFyaW9zLg0KDQo+IA0KPiA+ICAgIFRoaXMNCj4gPiDCoMKgIGNhbiBndWFy YW50ZWUgYnVpbGQtdGltZSBEVEIgaXMgdGhlIHNhbWUgYXMgcnVudGltZSBEVEIuIEJ1dA0KPiBl dmVudHVhbGx5LA0KPiA+IMKgwqAgd2Ugd2lsbCBoYXZlIGZpcm13YXJlIGFuZCBib290bG9hZGVy IGJlZm9yZSBYZW4gbGF1bmNoIChhcyBBcm0gRUJCUidzDQo+ID4gwqDCoCByZXF1aXJlbWVudCku IEluIHRoaXMgY2FzZSwgd2UgbWF5IG5vdCBidWlsZCBEVEIgaW50byBYZW4gaW1hZ2UuIEFuZA0K PiA+IMKgwqAgd2UgY2FuJ3QgZ3VhcmFudGVlIGJ1aWxkLXRpbWUgRFRCIGlzIHRoZSBzYW1lIGFz IHJ1bnRpbWUgRFRCLg0KPiANCj4gQXMgbWVudGlvbmVkLCBpZiB3ZSBoYXZlIGEgYnVpbGQtdGlt ZSBEVEIgd2UgbWlnaHQgbm90IG5lZWQgYSBydW4tdGltZQ0KPiBEVEIuIFNlY29uZGx5LCBJIHRo aW5rIGl0IGlzIGVudGlyZWx5IHJlYXNvbmFibGUgdG8gZXhwZWN0IHRoYXQgdGhlDQo+IGJ1aWxk LXRpbWUgRFRCIGFuZCB0aGUgcnVuLXRpbWUgRFRCIGFyZSB0aGUgc2FtZS4NCj4gDQoNClllcywg aWYgd2UgaW1wbGVtZW50IGluIHRoaXMgd2F5LCB3ZSBzaG91bGQgZGVzY3JpYmUgaXQgaW4gbGlt aXRhdGlvbg0Kb2YgdjhyIFhlbi4NCg0KPiBJdCBpcyB0aGUgc2FtZSBwcm9ibGVtIHdpdGggcGxh dGZvcm0gZmlsZXM6IHdlIGhhdmUgdG8gYXNzdW1lIHRoYXQgdGhlDQo+IGluZm9ybWF0aW9uIGlu IHRoZSBwbGF0Zm9ybSBmaWxlcyBtYXRjaGVzIHRoZSBydW50aW1lIERUQi4NCj4gDQoNCmluZGVl ZC4NCg0KPiANCj4gPiAyLiBJZiBidWlsZC10aW1lIERUQiBpcyB0aGUgc2FtZSBhcyBydW50aW1l IERUQiwgaG93IGNhbiB3ZSBkZXRlcm1pbmUNCj4gPiDCoMKgIHRoZSBYRU5fU1RBUlRfQUREUkVT UyBpbiBEVEIgZGVzY3JpYmUgbWVtb3J5IHJhbmdlPyBTaG91bGQgd2UgYWx3YXlzDQo+ID4gwqDC oCBsaW1pdCBYZW4gdG8gYm9vdCBmcm9tIGxvd2VzdCBhZGRyZXNzPyBPciB3aWxsIHdlIGludHJv ZHVjZSBzb21lIG5ldw0KPiA+IMKgwqAgRFQgcHJvcGVydHkgdG8gc3BlY2lmeSB0aGUgWGVuIHN0 YXJ0IGFkZHJlc3M/IEkgdGhpbmsgdGhpcyBEVA0KPiBwcm9wZXJ0eQ0KPiA+IMKgwqAgYWxzbyBj YW4gc29sdmUgYWJvdmUgcXVlc3Rpb24jMS4NCj4gDQo+IFRoZSBsb2FkaW5nIGFkZHJlc3Mgc2hv dWxkIGJlIGF1dG9tYXRpY2FsbHkgY2hvc2VuIGJ5IHRoZSBidWlsZCBzY3JpcHRzLg0KPiBXZSBj YW4gZG8gdGhhdCBub3cgd2l0aCBJbWFnZUJ1aWxkZXIgWzFdOiBpdCBzZWxlY3RzIGEgMk1CLWFs aWduZWQNCj4gYWRkcmVzcyBmb3IgZWFjaCBiaW5hcnkgdG8gbG9hZCwgb25lIGJ5IG9uZSBzdGFy dGluZyBmcm9tIGEgMk1CIG9mZnNldA0KPiBmcm9tIHN0YXJ0IG9mIG1lbW9yeS4NCj4gDQo+IFsx XSBodHRwczovL2dpdGxhYi5jb20vVmlyeWFPUy9pbWFnZWJ1aWxkZXIvLS9ibG9iL21hc3Rlci9z Y3JpcHRzL3Vib290LQ0KPiBzY3JpcHQtZ2VuI0wzOTANCj4gDQo+IFNvIHRoZSBidWlsZCBzY3Jp cHRzIGNhbiBzZWxlY3QgWEVOX1NUQVJUX0FERFJFU1MgYmFzZWQgb24gdGhlDQo+IG1lbW9yeSBu b2RlIGluZm9ybWF0aW9uIG9uIHRoZSBidWlsZC10aW1lIGRldmljZSB0cmVlLiBBbmQgdGhlcmUg c2hvdWxkDQo+IGJlIG5vIG5lZWQgdG8gYWRkIFhFTl9TVEFSVF9BRERSRVNTIHRvIHRoZSBydW50 aW1lIGRldmljZSB0cmVlLg0KPiANCg0KVGhpcyBpcyBmaW5lIGlmIHRoZXJlIGFyZSBubyBleHBs aWNpdCByZXN0cmljdGlvbnMgb24gdGhlIHBsYXRmb3JtLg0KU29tZSBwbGF0Zm9ybSBtYXkgcmVz ZXJ2ZSBzb21lIG1lbW9yeSBhcmVhIGZvciBzb21ldGhpbmcgbGlrZSBmaXJtd2FyZSwNCkJ1dCBJ IHRoaW5rIGl0J3MgT0ssIGluIHRoZSB3b3JzdCBjYXNlLCB3ZSBjYW4gaGlkZSB0aGlzIGFyZWEg ZnJvbQ0KYnVpbGQgRFRCLg0KDQo+IA0KPiA+ID4gVGhlIGRldmljZSB0cmVlIGNhbiBiZSBnaXZl biBhcyBpbnB1dCB0byB0aGUgYnVpbGQgc3lzdGVtLCBhbmQgdGhlDQo+ID4gPiBNYWtlZmlsZXMg d291bGQgdGFrZSBjYXJlIG9mIGdlbmVyYXRpbmcgWEVOX1NUQVJUX0FERFJFU1MgYW5kDQo+ID4g PiBBUk1fTVBVXypfTUVNT1JZX1NUQVJUL0VORCBiYXNlZCBvbiAvbWVtb3J5IGFuZCBvdGhlciBp bnRlcmVzdGluZw0KPiBub2Rlcy4NCj4gPiA+DQo+ID4NCj4gPiBJZiB3ZSBjYW4gc29sdmUgYWJv dmUgcXVlc3Rpb25zLCB5ZXMsIGRldmljZSB0cmVlIGlzIGEgZ29vZCBpZGVhIGZvcg0KPiA+IFhF Tl9TVEFSVF9BRERSRVNTLiBGb3IgQVJNX01QVV9OT1JNQUxfTUVNT1JZXyosIHdlIGNhbiBnZXQg dGhlbSBmcm9tDQo+ID4gbWVtb3J5IG5vZGVzLCBidXQgZm9yIEFSTV9NUFVfREVWSUNFX01FTU9S WV8qLCB0aGV5IGFyZSBub3QgZWFzeSBmb3INCj4gPiB1cyB0byBzY2FuIGFsbCBkZXZpY2VzJyBu b2Rlcy4gQW5kIGl0J3MgdmVyeSB0cmlja3ksIGlmIHRoZSBtZW1vcnkNCj4gPiByZWdpb25zIGFy ZSBpbnRlcmxlYXZlZC4gU28gaW4gb3VyIGN1cnJlbnQgUkZDIGNvZGUsIHdlIHNlbGVjdCB0byB1 c2UNCj4gPiB0aGUgb3B0aW9uYWwgaWRlYToNCj4gPiBXZSBtYXAgYFhFTl9TVEFSVF9BRERSRVNT YCB0byBgWEVOX1NUQVJUX0FERFJFU1MgKyAyTUJgIGZvciBNUFUgbm9ybWFsDQo+IG1lbW9yeS4N Cj4gPiBCdXQgd2UgdXNlIG1wdSxkZXZpY2UtbWVtb3J5LXNlY3Rpb24gaW4gRFQgZm9yIE1QVSBk ZXZpY2UgbWVtb3J5Lg0KPiANCj4gS2VlcCBpbiBtaW5kIHRoYXQgd2UgYXJlIHRhbGtpbmcgYWJv dXQgYnVpbGQtdGltZSBzY3JpcHRzOiBpdCBkb2Vzbid0DQo+IG1hdHRlciBpZiB0aGV5IGFyZSBz bG93LiBXZSBjYW4gc2NhbiB0aGUgYnVpbGQtdGltZSBkdGIgYXMgbWFueSB0aW1lIGFzDQo+IG5l ZWRlZCBhbmQgZ2VuZXJhdGUgQVJNX01QVV9ERVZJQ0VfTUVNT1JZXyogYXMgYXBwcm9wcmlhdGUu IEl0IG1pZ2h0DQo+IG1ha2UgIm1ha2UgeGVuIiBzbG93ZXIgYnV0IHJ1bnRpbWUgd2lsbCBiZSB1 bmFmZmVjdGVkLg0KPiANCj4gU28sIEkgZG9uJ3QgdGhpbmsgdGhpcyBpcyBhIHByb2JsZW0uDQo+ IA0KDQpPSy4NCg0KPiANCj4gPiA+ID4gLSAqKipEZWZpbmUgbmV3IHN5c3RlbSByZWdpc3RlcnMg Zm9yIGNvbXBpbGVycyoqKjoNCj4gPiA+ID7CoMKgIEFybXY4LVI2NCBpcyBiYXNlZCBvbiBBcm12 OC40LiBUaGF0IG1lYW5zIHdlIHdpbGwgdXNlIHNvbWUgQXJtdjguNA0KPiA+ID4gPsKgwqAgc3Bl Y2lmaWMgc3lzdGVtIHJlZ2lzdGVycy4gQXMgQXJtdjgtUjY0IG9ubHkgaGF2ZSBzZWN1cmUgc3Rh dGUsIHNvDQo+ID4gPiA+wqDCoCBhdCBsZWFzdCwgYFZTVENSX0VMMmAgYW5kIGBWU0NUTFJfRUwy YCB3aWxsIGJlIHVzZWQgZm9yIFhlbi4gQW5kDQo+IHRoZQ0KPiA+ID4gPsKgwqAgZmlyc3QgR0ND IHZlcnNpb24gdGhhdCBzdXBwb3J0cyBBcm12OC40IGlzIEdDQyA4LjEuIEluIGFkZGl0aW9uIHRv DQo+ID4gPiA+wqDCoCB0aGVzZSwgUE1TQSBvZiBBcm12OC1SNjQgaW50cm9kdWNlZCBsb3RzIG9m IE1QVSByZWxhdGVkIHN5c3RlbQ0KPiA+ID4gcmVnaXN0ZXJzOg0KPiA+ID4gPsKgwqAgYFBSQkFS X0VMeGAsIGBQUkJBUnhfRUx4YCwgYFBSTEFSX0VMeGAsIGBQUkxBUnhfRUx4YCwgYFBSRU5SX0VM eGANCj4gYW5kDQo+ID4gPiA+wqDCoCBgTVBVSVJfRUx4YC4gQnV0IHRoZSBmaXJzdCBHQ0MgdmVy c2lvbiB0byBzdXBwb3J0IHRoZXNlIHN5c3RlbQ0KPiA+ID4gcmVnaXN0ZXJzDQo+ID4gPiA+wqDC oCBpcyBHQ0MgMTEuIFNvIHdlIGhhdmUgdHdvIHdheXMgdG8gbWFrZSBjb21waWxlcnMgdG8gd29y ayBwcm9wZXJseQ0KPiB3aXRoDQo+ID4gPiA+wqDCoCB0aGVzZSBzeXN0ZW0gcmVnaXN0ZXJzLg0K PiA+ID4gPsKgwqAgMS4gQnVtcCBHQ0MgdmVyc2lvbiB0byBHQ0MgMTEuDQo+ID4gPiA+wqDCoMKg wqDCoCBUaGUgcHJvcyBvZiB0aGlzIG1ldGhvZCBpcyB0aGF0LCB3ZSBkb24ndCBuZWVkIHRvIGVu Y29kZSB0aGVzZQ0KPiA+ID4gPsKgwqDCoMKgwqAgc3lzdGVtIHJlZ2lzdGVycyBpbiBtYWNyb3Mg Ynkgb3Vyc2VsdmVzLiBCdXQgdGhlIGNvbnMgYXJlIHRoYXQsDQo+ID4gPiA+wqDCoMKgwqDCoCB3 ZSBoYXZlIHRvIHVwZGF0ZSBNYWtlZmlsZXMgdG8gc3VwcG9ydCBHQ0MgMTEgZm9yIEFybXY4LVI2 NC4NCj4gPiA+ID7CoMKgwqDCoMKgIDEuMS4gQ2hlY2sgdGhlIEdDQyB2ZXJzaW9uIDExIGZvciBB cm12OC1SNjQuDQo+ID4gPiA+wqDCoMKgwqDCoCAxLjIuIEFkZCBtYXJjaD1hcm12OHIgdG8gQ0ZM QUdTIGZvciBBcm12OC1SNjQuDQo+ID4gPiA+wqDCoMKgwqDCoCAxLjMuIFNvbHZlIHRoZSBjb25m bGljdGlvbiBvZiBtYXJjaD1hcm12OHIgYW5kIG1jcHU9Z2VuZXJpYw0KPiA+ID4gPsKgwqDCoMKg IFRoZXNlIGNoYW5nZXMgd2lsbCBhZmZlY3QgY29tbW9uIE1ha2VmaWxlcywgbm90IG9ubHkgQXJt DQo+IE1ha2VmaWxlcy4NCj4gPiA+ID7CoMKgwqDCoCBBbmQgR0NDIDExIGlzIG5ldywgbG90cyBv ZiB0b29sY2hhaW5zIGFuZCBEaXN0cm8gaGF2ZW4ndA0KPiBzdXBwb3J0ZWQNCj4gPiA+IGl0Lg0K PiA+ID4gPg0KPiA+ID4gPsKgwqAgMi4gRW5jb2RlIG5ldyBzeXN0ZW0gcmVnaXN0ZXJzIGluIG1h Y3JvcyAqKioocHJlZmVycmVkKSoqKg0KPiA+ID4gPsKgwqDCoMKgwqDCoMKgwqAgYGBgDQo+ID4g PiA+wqDCoMKgwqDCoMKgwqDCoCAvKiBWaXJ0dWFsaXphdGlvbiBTZWN1cmUgVHJhbnNsYXRpb24g Q29udHJvbCBSZWdpc3RlciAqLw0KPiA+ID4gPsKgwqDCoMKgwqDCoMKgwqAgI2RlZmluZSBWU1RD Ul9FTDLCoCBTM180X0MyX0M2XzINCj4gPiA+ID7CoMKgwqDCoMKgwqDCoMKgIC8qIFZpcnR1YWxp emF0aW9uIFN5c3RlbSBDb250cm9sIFJlZ2lzdGVyICovDQo+ID4gPiA+wqDCoMKgwqDCoMKgwqDC oCAjZGVmaW5lIFZTQ1RMUl9FTDIgUzNfNF9DMl9DMF8wDQo+ID4gPiA+wqDCoMKgwqDCoMKgwqDC oCAvKiBFTDEgTVBVIFByb3RlY3Rpb24gUmVnaW9uIEJhc2UgQWRkcmVzcyBSZWdpc3RlciBlbmNv ZGUgKi8NCj4gPiA+ID7CoMKgwqDCoMKgwqDCoMKgICNkZWZpbmUgUFJCQVJfRUwxwqAgUzNfMF9D Nl9DOF8wDQo+ID4gPiA+wqDCoMKgwqDCoMKgwqDCoCAuLi4NCj4gPiA+ID7CoMKgwqDCoMKgwqDC oMKgIC8qIEVMMiBNUFUgUHJvdGVjdGlvbiBSZWdpb24gQmFzZSBBZGRyZXNzIFJlZ2lzdGVyIGVu Y29kZSAqLw0KPiA+ID4gPsKgwqDCoMKgwqDCoMKgwqAgI2RlZmluZSBQUkJBUl9FTDLCoCBTM180 X0M2X0M4XzANCj4gPiA+ID7CoMKgwqDCoMKgwqDCoMKgIC4uLg0KPiA+ID4gPsKgwqDCoMKgwqDC oMKgwqAgYGBgDQo+ID4gPiA+wqDCoMKgwqDCoCBJZiB3ZSBlbmNvZGUgYWxsIGFib3ZlIHN5c3Rl bSByZWdpc3RlcnMsIHdlIGRvbid0IG5lZWQgdG8gYnVtcA0KPiBHQ0MNCj4gPiA+ID7CoMKgwqDC oMKgIHZlcnNpb24uIEFuZCB0aGUgY29tbW9uIENGTEFHUyBYZW4gaXMgdXNpbmcgc3RpbGwgY2Fu IGJlDQo+IGFwcGxpZWQgdG8NCj4gPiA+ID7CoMKgwqDCoMKgIEFybXY4LVI2NC4gV2UgZG9uJ3Qg bmVlZCB0byBtb2RpZnkgTWFrZWZpbGVzIHRvIGFkZCBzcGVjaWZpYw0KPiBDRkxBR1MuDQo+ID4g Pg0KPiA+ID4gSSB0aGluayB0aGF0J3MgZmluZSBhbmQgd2UgZGlkIHNvbWV0aGluZyBzaW1pbGFy IHdpdGggdGhlIG9yaWdpbmFsDQo+IEFSTXY3LUENCj4gPiA+IHBvcnQgaWYgSSByZW1lbWJlciBj b3JyZWN0bHkuDQo+ID4gPg0KPiA+ID4NCj4gPiA+ID4gIyMjICoqMi4yLiBDaGFuZ2VzIG9mIHRo ZSBpbml0aWFsaXphdGlvbiBwcm9jZXNzKioNCj4gPiA+ID4gSW4gZ2VuZXJhbCwgd2Ugc3RpbGwg ZXhwZWN0IEFybXY4LVI2NCBhbmQgQXJtdjgtQTY0IHRvIGhhdmUgYQ0KPiBjb25zaXN0ZW50DQo+ ID4gPiA+IGluaXRpYWxpemF0aW9uIHByb2Nlc3MuIEluIGFkZGl0aW9uIHRvIHNvbWUgYXJjaGl0 ZWN0dXJlIGRpZmZlcmVuY2VzLA0KPiA+ID4gdGhlcmUNCj4gPiA+ID4gaXMgbm8gbW9yZSB0aGFu IHJldXNhYmxlIGNvZGUgdGhhdCB3ZSB3aWxsIGRpc3Rpbmd1aXNoIHRocm91Z2gNCj4gPiA+IENP TkZJR19BUk1fTVBVDQo+ID4gPiA+IG9yIENPTkZJR19BUk02NF9WOFIuIFdlIHdhbnQgbW9zdCBv ZiB0aGUgaW5pdGlhbGl6YXRpb24gY29kZSB0byBiZQ0KPiA+ID4gcmV1c2FibGUNCj4gPiA+ID4g YmV0d2VlbiBBcm12OC1SNjQgYW5kIEFybXY4LUE2NC4NCj4gPiA+DQo+ID4gPiArMQ0KPiA+ID4N Cj4gPiA+DQo+ID4gPiA+IC0gV2Ugd2lsbCByZXVzZSB0aGUgb3JpZ2luYWwgaGVhZC5zIGFuZCBz ZXR1cC5jIG9mIEFybS4gQnV0IHJlcGxhY2UNCj4gdGhlDQo+ID4gPiA+wqDCoCBNTVUgYW5kIHBh Z2UgdGFibGUgb3BlcmF0aW9ucyBpbiB0aGVzZSBmaWxlcyB3aXRoIGNvbmZpZ3VyYXRpb24NCj4g PiA+IG9wZXJhdGlvbnMNCj4gPiA+ID7CoMKgIGZvciBNUFUgYW5kIE1QVSByZWdpb25zLg0KPiA+ ID4gPg0KPiA+ID4gPiAtIFdlIHByb3ZpZGUgYSBib290LXRpbWUgTVBVIGNvbmZpZ3VyYXRpb24u IFRoaXMgTVBVIGNvbmZpZ3VyYXRpb24NCj4gd2lsbA0KPiA+ID4gPsKgwqAgc3VwcG9ydCBYZW4g dG8gZmluaXNoIGl0cyBpbml0aWFsaXphdGlvbi4gQW5kIHRoaXMgYm9vdC10aW1lIE1QVQ0KPiA+ ID4gPsKgwqAgY29uZmlndXJhdGlvbiB3aWxsIHJlY29yZCB0aGUgbWVtb3J5IHJlZ2lvbnMgdGhh dCB3aWxsIGJlIHBhcnNlZA0KPiBmcm9tDQo+ID4gPiA+wqDCoCBkZXZpY2UgdHJlZS4NCj4gPiA+ ID4NCj4gPiA+ID7CoMKgIEluIHRoZSBlbmQgb2YgWGVuIGluaXRpYWxpemF0aW9uLCB3ZSB3aWxs IHVzZSBhIHJ1bnRpbWUgTVBVDQo+ID4gPiBjb25maWd1cmF0aW9uDQo+ID4gPiA+wqDCoCB0byBy ZXBsYWNlIGJvb3QtdGltZSBNUFUgY29uZmlndXJhdGlvbi4gVGhlIHJ1bnRpbWUgTVBVDQo+IGNv bmZpZ3VyYXRpb24NCj4gPiA+IHdpbGwNCj4gPiA+ID7CoMKgIG1lcmdlIGFuZCByZW9yZGVyIG1l bW9yeSByZWdpb25zIHRvIHNhdmUgbW9yZSBNUFUgcmVnaW9ucyBmb3INCj4gZ3Vlc3RzLg0KPiA+ ID4gPsKgwqAgIVtpbWddKGh0dHBzOi8vZHJpdmUuZ29vZ2xlLmNvbS91Yz9leHBvcnQ9dmlldyZp ZD0xd1RGeUsyWGZVM2xUbEgxDQo+IFBxUkQNCj4gPiA+IG9hY1FWVHdVdFdJR1UpDQo+ID4gPiA+ DQo+ID4gPiA+IC0gRGVmZXIgc3lzdGVtIHVucGF1c2luZyBkb21haW4uDQo+ID4gPiA+wqDCoCBX aGVuIFhlbiBpbml0aWFsaXphdGlvbiBpcyBhYm91dCB0byBlbmQsIFhlbiB1bnBhdXNlIGd1ZXN0 cw0KPiBjcmVhdGVkDQo+ID4gPiA+wqDCoCBkdXJpbmcgaW5pdGlhbGl6YXRpb24uIEJ1dCB0aGlz IHdpbGwgY2F1c2Ugc29tZSBpc3N1ZXMuIFRoZQ0KPiB1bnBhdXNlDQo+ID4gPiA+wqDCoCBhY3Rp b24gb2NjdXJzIGJlZm9yZSBmcmVlX2luaXRfbWVtb3J5LCBob3dldmVyIHRoZSBydW50aW1lIE1Q VQ0KPiA+ID4gY29uZmlndXJhdGlvbg0KPiA+ID4gPsKgwqAgaXMgYnVpbHQgYWZ0ZXIgZnJlZV9p bml0X21lbW9yeS4NCj4gPiA+ID4NCj4gPiA+ID7CoMKgIFNvIGlmIHRoZSB1bnBhdXNlZCBndWVz dHMgc3RhcnQgZXhlY3V0aW5nIHRoZSBjb250ZXh0IHN3aXRjaCBhdA0KPiB0aGlzDQo+ID4gPiA+ wqDCoCBwb2ludCwgdGhlbiBpdHMgTVBVIGNvbnRleHQgd2lsbCBiYXNlIG9uIHRoZSBib290LXRp bWUgTVBVDQo+ID4gPiBjb25maWd1cmF0aW9uLg0KPiA+ID4gPsKgwqAgUHJvYmFibHkgaXQgd2ls bCBiZSBpbmNvbnNpc3RlbnQgd2l0aCBydW50aW1lIE1QVSBjb25maWd1cmF0aW9uLA0KPiB0aGlz DQo+ID4gPiA+wqDCoCB3aWxsIGNhdXNlIHVuZXhwZWN0ZWQgcHJvYmxlbXMgKFRoaXMgbWF5IG5v dCBoYXBwZW4gaW4gYSBzaW5nbGUNCj4gY29yZQ0KPiA+ID4gPsKgwqAgc3lzdGVtLCBidXQgb24g U01QIHN5c3RlbXMsIHRoaXMgcHJvYmxlbSBpcyBmb3Jlc2VlYWJsZSwgc28gd2UNCj4gaG9wZSB0 bw0KPiA+ID4gPsKgwqAgc29sdmUgaXQgYXQgdGhlIGJlZ2lubmluZykuDQo+ID4gPiA+DQo+ID4g PiA+ICMjIyAqKjIuMy4gQ2hhbmdlcyB0byByZWR1Y2UgbWVtb3J5IGZyYWdtZW50YXRpb24qKg0K PiA+ID4gPg0KPiA+ID4gPiBJbiBnZW5lcmFsLCBtZW1vcnkgaW4gWGVuIHN5c3RlbSBjYW4gYmUg Y2xhc3NpZmllZCB0byA0IGNsYXNzZXM6DQo+ID4gPiA+IGBpbWFnZSBzZWN0aW9uc2AsIGBoZWFw IHNlY3Rpb25zYCwgYGd1ZXN0IFJBTWAsIGBib290IG1vZHVsZXMgKGd1ZXN0DQo+ID4gPiBLZXJu ZWwsDQo+ID4gPiA+IGluaXRyZCBhbmQgZHRiKWANCj4gPiA+ID4NCj4gPiA+ID4gQ3VycmVudGx5 LCBYZW4gZG9lc24ndCBoYXZlIGFueSByZXN0cmljdGlvbiBmb3IgdXNlcnMgaG93IHRvDQo+IGFs bG9jYXRlDQo+ID4gPiA+IG1lbW9yeSBmb3IgZGlmZmVyZW50IGNsYXNzZXMuIFRoYXQgbWVhbnMg dXNlcnMgY2FuIHBsYWNlIGJvb3QNCj4gbW9kdWxlcw0KPiA+ID4gPiBhbnl3aGVyZSwgY2FuIHJl c2VydmUgWGVuIGhlYXAgbWVtb3J5IGFueXdoZXJlIGFuZCBjYW4gYWxsb2NhdGUNCj4gZ3Vlc3QN Cj4gPiA+ID4gbWVtb3J5IGFueXdoZXJlLg0KPiA+ID4gPg0KPiA+ID4gPiBJbiBhIFZNU0Egc3lz dGVtLCB0aGlzIHdvdWxkIG5vdCBiZSB0b28gbXVjaCBvZiBhIHByb2JsZW0sIHNpbmNlIHRoZQ0K PiA+ID4gPiBNTVUgY2FuIG1hbmFnZSBtZW1vcnkgYXQgYSBncmFudWxhcml0eSBvZiA0S0IgYWZ0 ZXIgYWxsLiBCdXQgaW4gYQ0KPiA+ID4gPiBQTVNBIHN5c3RlbSwgdGhpcyB3aWxsIGJlIGEgYmln IHByb2JsZW0uIE9uIEFybXY4LVI2NCwgdGhlIG1heCBNUFUNCj4gPiA+ID4gcHJvdGVjdGlvbiBy ZWdpb25zIG51bWJlciBoYXMgYmVlbiBsaW1pdGVkIHRvIDI1Ni4gQnV0IGluIHR5cGljYWwNCj4g PiA+ID4gcHJvY2Vzc29yIGltcGxlbWVudGF0aW9ucywgZmV3IHByb2Nlc3NvcnMgd2lsbCBkZXNp Z24gbW9yZSB0aGFuIDMyDQo+ID4gPiA+IE1QVSBwcm90ZWN0aW9uIHJlZ2lvbnMuIEFkZCBpbiB0 aGUgZmFjdCB0aGF0IFhlbiBzaGFyZXMgTVBVDQo+IHByb3RlY3Rpb24NCj4gPiA+ID4gcmVnaW9u cyB3aXRoIGd1ZXN0J3MgRUwxIFN0YWdlIDIuIEl0IGJlY29tZXMgZXZlbiBtb3JlIGltcG9ydGFu dA0KPiA+ID4gPiB0byBwcm9wZXJseSBwbGFuIHRoZSB1c2Ugb2YgTVBVIHByb3RlY3Rpb24gcmVn aW9ucy4NCj4gPiA+ID4NCj4gPiA+ID4gLSBBbiBpZGVhbCBvZiBtZW1vcnkgdXNhZ2UgbGF5b3V0 IHJlc3RyaWN0aW9uOg0KPiA+ID4gPiAhW2ltZ10oaHR0cHM6Ly9kcml2ZS5nb29nbGUuY29tL3Vj P2V4cG9ydD12aWV3JmlkPTFraXJPTDBUeDJhQXlwVHRkMw0KPiBrWEF0DQo+ID4gPiBkNzVYdHJu Z2NuVykNCj4gPiA+ID4gMS4gUmVzZXJ2ZSBwcm9wZXIgTVBVIHJlZ2lvbnMgZm9yIFhlbiBpbWFn ZSAoY29kZSwgcm9kYXRhIGFuZCBkYXRhICsNCj4gPiA+IGJzcykuDQo+ID4gPiA+IDIuIFJlc2Vy dmUgb25lIE1QVSByZWdpb24gZm9yIGJvb3QgbW9kdWxlcy4NCj4gPiA+ID7CoMKgwqAgVGhhdCBt ZWFucyB0aGUgcGxhY2VtZW50IG9mIGFsbCBib290IG1vZHVsZXMsIGluY2x1ZGUgZ3Vlc3QNCj4g a2VybmVsLA0KPiA+ID4gPsKgwqDCoCBpbml0cmQgYW5kIGR0Yiwgd2lsbCBiZSBsaW1pdGVkIHRv IHRoaXMgTVBVIHJlZ2lvbiBwcm90ZWN0ZWQgYXJlYS4NCj4gPiA+ID4gMy4gUmVzZXJ2ZSBvbmUg b3IgbW9yZSBNUFUgcmVnaW9ucyBmb3IgWGVuIGhlYXAuDQo+ID4gPiA+wqDCoMKgIE9uIEFybXY4 LVI2NCwgdGhlIGd1ZXN0IG1lbW9yeSBpcyBwcmVkZWZpbmVkIGluIGRldmljZSB0cmVlLCBpdA0K PiB3aWxsDQo+ID4gPiA+wqDCoMKgIG5vdCBiZSBhbGxvY2F0ZWQgZnJvbSBoZWFwLiBVbmxpa2Ug QXJtdjgtQTY0LCB3ZSB3aWxsIG5vdCBtb3ZlDQo+IGFsbA0KPiA+ID4gPsKgwqDCoCBmcmVlIG1l bW9yeSB0byBoZWFwLiBXZSB3YW50IFhlbiBoZWFwIGlzIGRlcnRlcm1pc3RpYyB0b28sIHNvIFhl bg0KPiBvbg0KPiA+ID4gPsKgwqDCoCBBcm12OC1SNjQgYWxzbyByZWx5IG9uIFhlbiBzdGF0aWMg aGVhcCBmZWF0dXJlLiBUaGUgbWVtb3J5IGZvcg0KPiBYZW4NCj4gPiA+ID7CoMKgwqAgaGVhcCB3 aWxsIGJlIGRlZmluZWQgaW4gdHJlZSB0b28uIENvbnNpZGVyaW5nIHRoYXQgcGh5c2ljYWwNCj4g bWVtb3J5DQo+ID4gPiA+wqDCoMKgIGNhbiBhbHNvIGJlIGRpc2NvbnRpbnVvdXMsIG9uZSBvciBt b3JlIE1QVSBwcm90ZWN0aW9uIHJlZ2lvbnMNCj4gbmVlZHMNCj4gPiA+ID7CoMKgwqAgdG8gYmUg cmVzZXJ2ZWQgZm9yIFhlbiBIRUFQLg0KPiA+ID4gPiA0LiBJZiB3ZSBuYW1lIGFib3ZlIHVzZWQg TVBVIHByb3RlY3Rpb24gcmVnaW9ucyBQQVJUX0EsIGFuZCBuYW1lDQo+IGxlZnQNCj4gPiA+ID7C oMKgwqAgTVBVIHByb3RlY3Rpb24gcmVnaW9ucyBQQVJUX0I6DQo+ID4gPiA+wqDCoMKgIDQuMS4g SW4gaHlwZXJ2aXNvciBjb250ZXh0LCBYZW4gd2lsbCBtYXAgbGVmdCBSQU0gYW5kIGRldmljZXMg dG8NCj4gPiA+IFBBUlRfQi4NCj4gPiA+ID7CoMKgwqDCoMKgwqDCoMKgIFRoaXMgd2lsbCBnaXZl IFhlbiB0aGUgYWJpbGl0eSB0byBhY2Nlc3Mgd2hvbGUgbWVtb3J5Lg0KPiA+ID4gPsKgwqDCoCA0 LjIuIEluIGd1ZXN0IGNvbnRleHQsIFhlbiB3aWxsIGNyZWF0ZSBFTDEgc3RhZ2UgMiBtYXBwaW5n IGluDQo+IFBBUlRfQi4NCj4gPiA+ID7CoMKgwqDCoMKgwqDCoMKgIEluIHRoaXMgY2FzZSwgWGVu IGp1c3QgbmVlZCB0byB1cGRhdGUgUEFSVF9CIGluIGNvbnRleHQNCj4gc3dpdGNoLA0KPiA+ID4g PsKgwqDCoMKgwqDCoMKgwqAgYnV0IGtlZXAgUEFSVF9BIGFzIGZpeGVkLg0KPiA+ID4NCj4gPiA+ IEkgdGhpbmsgdGhhdCB0aGUgbWVtb3J5IGxheW91dCBhbmQgcmVzdHJpY3Rpb25zIHRoYXQgeW91 IHdyb3RlIGFib3ZlDQo+ID4gPiBtYWtlIHNlbnNlLiBJIGhhdmUgc29tZSBjb21tZW50cyBvbiB0 aGUgd2F5IHRoZXkgYXJlIHJlcHJlc2VudGVkIGluDQo+ID4gPiBkZXZpY2UgdHJlZSwgYnV0IHRo YXQncyBkaWZmZXJlbnQuDQo+ID4gPg0KPiA+ID4NCj4gPiA+ID4gKioqTm90ZXM6IFN0YXRpYyBh bGxvY2F0aW9uIHdpbGwgYmUgbWFuZGF0b3J5IG9uIE1QVSBiYXNlZA0KPiBzeXN0ZW1zKioqDQo+ ID4gPiA+DQo+ID4gPiA+ICoqQSBzYW1wbGUgZGV2aWNlIHRyZWUgb2YgbWVtb3J5IGxheW91dCBy ZXN0cmljdGlvbioqOg0KPiA+ID4gPiBgYGANCj4gPiA+ID4gY2hvc2VuIHsNCj4gPiA+ID7CoMKg wqDCoCAuLi4NCj4gPiA+ID7CoMKgwqDCoCAvKg0KPiA+ID4gPsKgwqDCoMKgwqAgKiBEZWZpbmUg YSBzZWN0aW9uIHRvIHBsYWNlIGJvb3QgbW9kdWxlcywNCj4gPiA+ID7CoMKgwqDCoMKgICogYWxs IGJvb3QgbW9kdWxlcyBtdXN0IGJlIHBsYWNlZCBpbiB0aGlzIHNlY3Rpb24uDQo+ID4gPiA+wqDC oMKgwqDCoCAqLw0KPiA+ID4gPsKgwqDCoMKgIG1wdSxib290LW1vZHVsZS1zZWN0aW9uID0gPDB4 MTAwMDAwMDAgMHgxMDAwMDAwMD47DQo+ID4gPiA+wqDCoMKgwqAgLyoNCj4gPiA+ID7CoMKgwqDC oMKgICogRGVmaW5lIGEgc2VjdGlvbiB0byBjb3ZlciBhbGwgZ3Vlc3QgUkFNLiBBbGwgZ3Vlc3Qg UkFNIG11c3QNCj4gYmUNCj4gPiA+IGxvY2F0ZWQNCj4gPiA+ID7CoMKgwqDCoMKgICogd2l0aGlu IHRoaXMgc2VjdGlvbi4gVGhlIHByb3MgaXMgdGhhdCwgaW4gYmVzdCBjYXNlLCB3ZSBjYW4NCj4g b25seQ0KPiA+ID4gaGF2ZQ0KPiA+ID4gPsKgwqDCoMKgwqAgKiBvbmUgTVBVIHByb3RlY3Rpb24g cmVnaW9uIHRvIG1hcCBhbGwgZ3Vlc3QgUkFNIGZvciBYZW4uDQo+ID4gPiA+wqDCoMKgwqDCoCAq Lw0KPiA+ID4gPsKgwqDCoMKgIG1wdSxndWVzdC1tZW1vcnktc2VjdGlvbiA9IDwweDIwMDAwMDAw IDB4MzAwMDAwMDA+Ow0KPiA+ID4gPsKgwqDCoMKgIC8qDQo+ID4gPiA+wqDCoMKgwqDCoCAqIERl ZmluZSBhIG1lbW9yeSBzZWN0aW9uIHRoYXQgY2FuIGNvdmVyIGFsbCBkZXZpY2UgbWVtb3J5IHRo YXQNCj4gPiA+ID7CoMKgwqDCoMKgICogd2lsbCBiZSB1c2VkIGluIFhlbi4NCj4gPiA+ID7CoMKg wqDCoMKgICovDQo+ID4gPiA+wqDCoMKgwqAgbXB1LGRldmljZS1tZW1vcnktc2VjdGlvbiA9IDww eDgwMDAwMDAwIDB4N2ZmZmYwMDA+Ow0KPiA+ID4gPsKgwqDCoMKgIC8qIERlZmluZSBhIHNlY3Rp b24gZm9yIFhlbiBoZWFwICovDQo+ID4gPiA+wqDCoMKgwqAgeGVuLHN0YXRpYy1tZW0gPSA8MHg1 MDAwMDAwMCAweDIwMDAwMDAwPjsNCj4gPiA+DQo+ID4gPiBBcyBtZW50aW9uZWQgYWJvdmUsIEkg dW5kZXJzdGFuZCB0aGUgbmVlZCBmb3IgdGhlc2Ugc2VjdGlvbnMsIGJ1dCB3aHkNCj4gZG8NCj4g PiA+IHdlIG5lZWQgdG8gZGVzY3JpYmUgdGhlbSBpbiBkZXZpY2UgdHJlZSBhdCBhbGw/IENvdWxk IFhlbiBzZWxlY3QgdGhlbQ0KPiBieQ0KPiA+ID4gaXRzZWxmIGR1cmluZyBib290Pw0KPiA+DQo+ ID4gSSB0aGluayB3aXRob3V0IHNvbWUgaW5wdXRzLCBYZW4gY291bGQgbm90IGRvIHRoaXMgb3Ig d2lsbCBkbyBpdCBpbiBzb21lDQo+ID4gYXNzdW1wdGlvbi4gRm9yIGV4YW1wbGUsIGFzc3VtZSB0 aGUgZmlyc3QgdGhlIGJvb3QtbW9kdWxlLXNlY3Rpb24NCj4gZGV0ZXJtaW5lZA0KPiA+IGJ5IGxv d2VzdCBhZGRyZXNzIGFuZCBoaWdoZXN0IGFkZHJlc3Mgb2YgYWxsIG1vZHVsZXMuIEFuZCB0aGUg c2FtZSBmb3INCj4gPiBndWVzdC1tZW1vcnktc2VjdGlvbiwgY2FsY3VsYXRlZCBmcm9tIGFsbCBn dWVzdCBhbGxvY2F0ZWQgbWVtb3J5IHJlZ2lvbnMuDQo+IA0KPiBSaWdodCwgSSB0aGluayB0aGF0 IHRoZSBtcHUsYm9vdC1tb2R1bGUtc2VjdGlvbiBzaG91bGQgYmUgZ2VuZXJhdGVkIGJ5IGENCj4g c2V0IG9mIHNjcmlwdHMgbGlrZSBJbWFnZUJ1aWxkZXIuIFNvbWV0aGluZyB3aXRoIGEgbGlzdCBv ZiBhbGwgdGhlDQo+IGJpbmFyaWVzIHRoYXQgbmVlZCB0byBiZSBsb2FkZWQgYW5kIGFsc28gdGhl IERUQiBhdCBidWlsZC10aW1lLg0KPiBTb21ldGhpbmcgbGlrZSBJbWFnZUJ1aWxkZXIgd291bGQg aGF2ZSB0aGUgYWJpbGl0ecKgdG8gYWRkDQo+ICJtcHUsYm9vdC1tb2R1bGUtc2VjdGlvbiIgdG8g ZGV2aWNlIHRyZWUgYXV0b21hdGljYWxseSBhbmQgYXV0b21hdGljYWxseQ0KPiBjaG9vc2UgYSBn b29kIGFkZHJlc3MgZm9yIGl0Lg0KPiANCj4gQXMgYW4gZXhhbXBsZSwgdG9kYXkgSW1hZ2VCdWls ZGVyIHRha2VzIGFzIGlucHV0IGEgY29uZmlnIGZpbGUgbGlrZSB0aGUNCj4gZm9sbG93aW5nOg0K PiANCj4gLS0tDQo+IE1FTU9SWV9TVEFSVD0iMHgwIg0KPiBNRU1PUllfRU5EPSIweDgwMDAwMDAw Ig0KPiANCj4gREVWSUNFX1RSRUU9IjQuMTYtMjAyMi4xL21wc29jLmR0YiINCj4gWEVOPSI0LjE2 LTIwMjIuMS94ZW4iDQo+IERPTTBfS0VSTkVMPSI0LjE2LTIwMjIuMS9JbWFnZS1kb20wLTUuMTYi DQo+IERPTTBfUkFNRElTSz0iNC4xNi0yMDIyLjEveGVuLXJvb3Rmcy5jcGlvLmd6Ig0KPiANCj4g TlVNX0RPTVVTPTENCj4gRE9NVV9LRVJORUxbMF09IjQuMTYtMjAyMi4xL0ltYWdlLWRvbVUiDQo+ IERPTVVfUkFNRElTS1swXT0iNC4xNi0yMDIyLjEvaW5pdHJkLmNwaW8iDQo+IERPTVVfUEFTU1RI Uk9VR0hfRFRCWzBdPSI0LjE2LTIwMjIuMS9wYXNzdGhyb3VnaC1leGFtcGxlLXNyYW0uZHRiIg0K PiAtLS0NCj4gDQo+IEFuZCBnZW5lcmF0ZXMgYSBVLUJvb3QgYm9vdC5zY3Igc2NyaXB0IHdpdGg6 DQo+IC0gbG9hZCBhZGRyZXNzZXMgZm9yIGVhY2ggYmluYXJ5DQo+IC0gY29tbWFuZHMgdG8gZWRp dCB0aGUgRFRCIHRvIGFkZCB0aG9zZSBhZGRyZXNzZXMgdG8gZGV2aWNlIHRyZWUgKGUuZy4NCj4g ICBkb20wbGVzcyBrZXJuZWxzIGFkZHJlc3NlcykNCj4gDQo+IEltYWdlQnVpbGRlciBjYW4gYWxz byBtb2RpZnkgdGhlIERUQiBhdCBidWlsZCB0aW1lIGluc3RlYWQgKGluc3RlYWQgb2YNCj4gZG9p bmcgaXQgZnJvbSBib290LnNjci4pIFNlZSBGRFRFRElULg0KPiANCj4gSSBhbSBub3Qgc2F5aW5n IHdlIHNob3VsZCB1c2UgSW1hZ2VCdWlsZGVyLCBidXQgaXQgc291bmRzIGxpa2Ugd2UgbmVlZA0K PiBzb21ldGhpbmcgc2ltaWxhci4NCj4gDQo+IA0KDQpZZXMsIGV4YWN0bHkuIEkgaGF2ZSBjb21t ZW50IG9uIEhlbnJ5J3Mgc3RhY2sgaGVhcCBSRkMgdG8gc2FpZCB3ZSBuZWVkDQphIHNpbWlsYXIg dG9vbC4gTm93LCBoZXJlIGl0IGlzIDogKQ0KDQo+ID4gPiBJZiBub3QsIGFuZCBjb25zaWRlcmlu ZyB0aGF0IHdlIGhhdmUgdG8gZ2VuZXJhdGUNCj4gPiA+IEFSTV9NUFVfKl9NRU1PUllfU1RBUlQv RU5EIGFueXdheSBhdCBidWlsZCB0aW1lLCB3b3VsZCBpdCBtYWtlIHNlbnNlDQo+IHRvDQo+ID4g PiBhbHNvIGdlbmVyYXRlIG1wdSxndWVzdC1tZW1vcnktc2VjdGlvbiwgeGVuLHN0YXRpYy1tZW0s IGV0Yy4gYXQgYnVpbGQNCj4gPiA+IHRpbWUgcmF0aGVyIHRoYW4gcGFzc2luZyBpdCB2aWEgZGV2 aWNlIHRyZWUgdG8gWGVuIGF0IHJ1bnRpbWU/DQo+ID4gPg0KPiA+DQo+ID4gRGlkIHlvdSBtZWFu IHdlIHN0aWxsIGFkZCB0aGVzZSBpbmZvcm1hdGlvbiBpbiBkZXZpY2UgdHJlZSwgYnV0IGZvcg0K PiBidWlsZA0KPiA+IHRpbWUgb25seS4gSW4gcnVudGltZSB3ZSBkb24ndCBwYXJzZSB0aGVtPw0K PiANCj4gWWVzLCBzb21ldGhpbmcgbGlrZSB0aGF0LCBidXQgc2VlIGJlbG93Lg0KPiANCj4gDQo+ ID4gPiBXaGF0J3MgdGhlIHZhbHVlIG9mIGRvaW5nIEFSTV9NUFVfKl9NRU1PUllfU1RBUlQvRU5E IGF0IGJ1aWxkIHRpbWUgYW5kDQo+ID4gPiBldmVyeXRoaW5nIGVsc2UgYXQgcnVudGltZT8NCj4g Pg0KPiA+IEFSTV9NUFVfKl9NRU1PUllfU1RBUlQvRU5EIGlzIGRlZmluZWQgYnkgcGxhdGZvcm0u IEJ1dCBvdGhlciB0aGluZ3MgYXJlDQo+ID4gdXNlcnMgY3VzdG9taXplZC4gVGhleSBjYW4gY2hh bmdlIHRoZWlyIHVzYWdlIHdpdGhvdXQgcmVidWlsZCB0aGUgaW1hZ2UuDQo+IA0KPiBHb29kIHBv aW50Lg0KPiANCj4gV2UgZG9uJ3Qgd2FudCB0byBoYXZlIHRvIHJlYnVpbGQgWGVuIGlmIHRoZSB1 c2VyIHVwZGF0ZWQgYSBndWVzdCBrZXJuZWwsDQo+IHJlc3VsdGluZyBpbiBhIGxhcmdlciBib290 LW1vZHVsZS1zZWN0aW9uLg0KPiANCj4gU28gSSB0aGluayBpdCBtYWtlcyBzZW5zZSB0aGF0ICJt cHUsYm9vdC1tb2R1bGUtc2VjdGlvbiIgaXMgZ2VuZXJhdGVkIGJ5DQo+IHRoZSBzY3JpcHRzIChl LmcuIEltYWdlQnVpbGRlcikgYXQgYnVpbGQgdGltZSwgYW5kIFhlbiByZWFkcyB0aGUNCj4gcHJv cGVydHkgYXQgYm9vdCBmcm9tIHRoZSBydW50aW1lIGRldmljZSB0cmVlLg0KPiANCj4gSSB0aGlu ayB3ZSBuZWVkIHRvIGRpdmlkZSB0aGUgaW5mb3JtYXRpb24gaW50byB0d28gZ3JvdXBzOg0KPiAN Cj4gDQo+ICMgR3JvdXAxOiBib2FyZCBpbmZvDQo+IA0KPiBUaGlzIGluZm9ybWF0aW9uIGlzIHBs YXRmb3JtIHNwZWNpZmljIGFuZCBpdCBpcyBub3QgbWVhbnQgdG8gY2hhbmdlDQo+IGRlcGVuZGlu ZyBvbiB0aGUgVk0gY29uZmlndXJhdGlvbi4gSWRlYWxseSwgd2UgYnVpbGQgWGVuIGZvciBhIHBs YXRmb3JtDQo+IG9uY2UsIHRoZW4gd2UgY2FuIHVzZSB0aGUgc2FtZSBYZW4gYmluYXJ5IHRvZ2V0 aGVyIHdpdGggYW55IGNvbWJpbmF0aW9uDQo+IG9mIGRvbTAvZG9tVSBrZXJuZWxzIGFuZCByYW1k aXNrcy4NCj4gDQo+IFRoaXMga2luZCBvZiBpbmZvcm1hdGlvbiBkb2Vzbid0IG5lZWQgdG8gYmUg ZXhwb3NlZCB0byB0aGUgcnVudGltZQ0KPiBkZXZpY2UgdHJlZS4gQnV0IHdlIGNhbiBzdGlsbCB1 c2UgYSBidWlsZC10aW1lIGRldmljZSB0cmVlIHRvIGdlbmVyYXRlDQo+IHRoZSBhZGRyZXNzZXMg aWYgaXQgaXMgY29udmVuaWVudC4NCj4gDQo+IFhFTl9TVEFSVF9BRERSRVNTLCBBUk1fTVBVX0RF VklDRV9NRU1PUllfKiwgYW5kIEFSTV9NUFVfTk9STUFMX01FTU9SWV8qDQo+IHNlZW0gdG8gYmUg cGFydCBvZiB0aGlzIGdyb3VwLg0KPiANCg0KWWVzLg0KDQo+IA0KPiAjIEdyb3VwMjogYm9vdCBj b25maWd1cmF0aW9uDQo+IA0KPiBUaGlzIGluZm9ybWF0aW9uIGlzIGFib3V0IHRoZSBzcGVjaWZp YyBzZXQgb2YgYmluYXJpZXMgYW5kIFZNcyB0aGF0IHdlDQo+IG5lZWQgdG8gYm9vdC4gSXQgaXMg Y29uY2VwdHVhbGx5IHNpbWlsYXIgdG8gdGhlIGRvbTBsZXNzIGRldmljZSB0cmVlDQo+IG5vZGVz IHRoYXQgd2UgYWxyZWFkeSBoYXZlLiBJZiB3ZSBjaGFuZ2Ugb25lIG9mIHRoZSBWTSBiaW5hcmll cywgd2UNCj4gbGlrZWx5IGhhdmUgdG8gcmVmcmVzaCB0aGUgaW5mb3JtYXRpb24gaGVyZS4NCj4g DQo+ICJtcHUsYm9vdC1tb2R1bGUtc2VjdGlvbiIgcHJvYmFibHkgYmVsb25ncyB0byB0aGlzIGdy b3VwICh1bmxlc3Mgd2UgZmluZA0KPiBhIHdheSB0byBkZWZpbmUgIm1wdSxib290LW1vZHVsZS1z ZWN0aW9uIiBnZW5lcmljYWxseSBzbyB0aGF0IHdlIGRvbid0DQo+IG5lZWQgdG8gY2hhbmdlIGl0 IGFueSB0aW1lIHRoZSBzZXQgb2YgYm9vdCBtb2R1bGVzIGNoYW5nZS4pDQo+IA0KPiANCg0KSSBh Z3JlZS4NCg0KPiA+ID4gSXQgbG9va3MgbGlrZSB3ZSBhcmUgZm9yY2VkIHRvIGhhdmUgdGhlIHNl Y3Rpb25zIGRlZmluaXRpb25zIGF0IGJ1aWxkDQo+ID4gPiB0aW1lIGJlY2F1c2Ugd2UgbmVlZCB0 aGVtIGJlZm9yZSB3ZSBjYW4gcGFyc2UgZGV2aWNlIHRyZWUuIEluIHRoYXQNCj4gY2FzZSwNCj4g PiA+IHdlIG1pZ2h0IGFzIHdlbGwgZGVmaW5lIGFsbCB0aGUgc2VjdGlvbnMgYXQgYnVpbGQgdGlt ZS4NCj4gPiA+DQo+ID4gPiBCdXQgSSB0aGluayBpdCB3b3VsZCBiZSBldmVuIGJldHRlciBpZiBY ZW4gY291bGQgYXV0b21hdGljYWxseSBjaG9vc2UNCj4gPiA+IHhlbixzdGF0aWMtbWVtLCBtcHUs Z3Vlc3QtbWVtb3J5LXNlY3Rpb24sIGV0Yy4gb24gaXRzIG93biBiYXNlZCBvbiB0aGUNCj4gPiA+ IHJlZ3VsYXIgZGV2aWNlIHRyZWUgaW5mb3JtYXRpb24gKC9tZW1vcnksIC9hbWJhLCBldGMuKSwg d2l0aG91dCBhbnkNCj4gbmVlZA0KPiA+ID4gZm9yIGV4cGxpY2l0bHkgZGVzY3JpYmluZyBlYWNo IHJhbmdlIHdpdGggdGhlc2UgbmV3IHByb3BlcnRpZXMuDQo+ID4gPg0KPiA+DQo+ID4gZm9yIG1w dSxndWVzdC1tZW1vcnktc2VjdGlvbiwgd2l0aCB0aGUgbGltaXRhdGlvbnM6IG5vIG90aGVyIHVz YWdlDQo+IGJldHdlZW4NCj4gPiBkaWZmZXJlbnQgZ3Vlc3QnIG1lbW9yeSBub2RlcywgdGhpcyBp cyBPSy4gQnV0IGZvciB4ZW4sc3RhdGljLW1lbSAoaGVhcCksDQo+ID4gd2UganVzdCB3YW50IGV2 ZXJ5dGhpbmcgb24gYSBNUFUgc3lzdGVtIGlzIGRlcnRlcm1pc3RpYy4gQnV0LCBvZiBjb3Vyc2UN Cj4gWGVuDQo+ID4gY2FuIHNlbGVjdCBsZWZ0IG1lbW9yeSBmb3IgaGVhcCB3aXRob3V0IHN0YXRp Yy1tZW0uDQo+IA0KPiBJdCBpcyBnb29kIHRoYXQgeW91IHRoaW5rIHRoZXkgY2FuIGJlIGNob3Nl biBieSBYZW4uDQo+IA0KPiBEaWZmZXJlbnRseSBmcm9tICJib290LW1vZHVsZS1zZWN0aW9uIiwg d2hpY2ggaGFzIHRvIGRvIHdpdGggdGhlIGJvb3QNCj4gbW9kdWxlcyBzZWxlY3RlZCBieSB0aGUg dXNlciBmb3IgYSBzcGVjaWZpYyBleGVjdXRpb24sDQo+IGd1ZXN0LW1lbW9yeS1zZWN0aW9uIGFu ZCBzdGF0aWMtbWVtIGFyZSBYZW4gc3BlY2lmaWMgbWVtb3J5DQo+IHBvbGljaWVzL2FsbG9jYXRp b25zLg0KPiANCj4gQSB1c2VyIHdvdWxkbid0IGtub3cgaG93IHRvIGZpbGwgdGhlbSBpbi4gQW5k IEkgd29ycnkgdGhhdCBldmVuIGEgc2NyaXB0DQoNCkJ1dCB1c2VycyBzaG91bGQga25vdyBpdCwg YmVjYXVzZSBzdGF0aWMtbWVtIGZvciBndWVzdCBtdXN0IGJlIGFsbG9jYXRlZA0KaW4gdGhpcyBy YW5nZS4gQW5kIHVzZXJzIHRha2UgdGhlIHJlc3BvbnNpYmlsaXR5IHRvIHNldCB0aGUgRG9tVSdz DQpzdGF0aWMgYWxsb2NhdGUgbWVtb3J5IHJhbmdlcy4NCg0KPiBsaWtlIEltYWdlQnVpbGRlciB3 b3VsZG4ndCBiZSB0aGUgYmVzdCBwbGFjZSB0byBwaWNrIHRoZXNlIHZhbHVlcyAtLQ0KPiB0aGV5 IHNlZW0gdG9vICJpbXBvcnRhbnQiIHRvIGxlYXZlIHRvIGEgc2NyaXB0Lg0KPiANCj4gQnV0IGl0 IHNlZW1zIHBvc3NpYmxlIHRvIGNob29zZSB0aGUgdmFsdWVzIGluIFhlbjoNCj4gLSBYZW4ga25v d3MgQVJNX01QVV9OT1JNQUxfTUVNT1JZXyogYmVjYXVzZSBpdCB3YXMgZGVmaW5lZCBhdCBidWls ZCB0aW1lDQo+IC0gWGVuIHJlYWRzIGJvb3QtbW9kdWxlLXNlY3Rpb24gZnJvbSBkZXZpY2UgdHJl ZQ0KPiANCj4gSXQgc2hvdWxkIGJlIHBvc3NpYmxlIGF0IHRoaXMgcG9pbnQgZm9yIFhlbiB0byBw aWNrIHRoZSBiZXN0IHZhbHVlcyBmb3INCj4gZ3Vlc3QtbWVtb3J5LXNlY3Rpb24gYW5kIHN0YXRp Yy1tZW0gYmFzZWQgb24gdGhlIG1lbW9yeSBhdmFpbGFibGUuDQo+IA0KDQpIb3cgWGVuIHRvIHBp Y2s/IERvZXMgaXQgbWVhbiBpbiBzdGF0aWMgYWxsb2NhdGlvbiBEb21VIERUIG5vZGUsIHdlIGp1 c3QNCm5lZWQgYSBzaXplLCBidXQgZG9uJ3QgcmVxdWlyZSBhIHN0YXJ0IGFkZHJlc3MgZm9yIHN0 YXRpYy1tZW0/DQoNCj4gDQo+ID4gPiA+wqDCoMKgwqAgZG9tVTEgew0KPiA+ID4gPsKgwqDCoMKg wqDCoMKgwqAgLi4uDQo+ID4gPiA+wqDCoMKgwqDCoMKgwqDCoCAjeGVuLHN0YXRpYy1tZW0tYWRk cmVzcy1jZWxscyA9IDwweDAxPjsNCj4gPiA+ID7CoMKgwqDCoMKgwqDCoMKgICN4ZW4sc3RhdGlj LW1lbS1zaXplLWNlbGxzID0gPDB4MDE+Ow0KPiA+ID4gPsKgwqDCoMKgwqDCoMKgwqAgLyogU3Rh dGljYWxseSBhbGxvY2F0ZWQgZ3Vlc3QgbWVtb3J5LCB3aXRoaW4gbXB1LGd1ZXN0LQ0KPiBtZW1v cnktDQo+ID4gPiBzZWN0aW9uICovDQo+ID4gPiA+wqDCoMKgwqDCoMKgwqDCoCB4ZW4sc3RhdGlj LW1lbSA9IDwweDMwMDAwMDAwIDB4MWYwMDAwMDA+Ow0KPiA+ID4gPg0KPiA+ID4gPsKgwqDCoMKg wqDCoMKgwqAgbW9kdWxlQDExMDAwMDAwIHsNCj4gPiA+ID7CoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqAgY29tcGF0aWJsZSA9ICJtdWx0aWJvb3Qsa2VybmVsXDBtdWx0aWJvb3QsbW9kdWxlIjsNCj4g PiA+ID7CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgLyogQm9vdCBtb2R1bGUgYWRkcmVzcywgd2l0 aGluIG1wdSxib290LW1vZHVsZS1zZWN0aW9uDQo+ICovDQo+ID4gPiA+wqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgIHJlZyA9IDwweDExMDAwMDAwIDB4MzAwMDAwMD47DQo+ID4gPiA+wqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgIC4uLg0KPiA+ID4gPsKgwqDCoMKgwqDCoMKgwqAgfTsNCj4gPiA+ID4N Cj4gPiA+ID7CoMKgwqDCoMKgwqDCoMKgIG1vZHVsZUAxMEZGMDAwMCB7DQo+ID4gPiA+wqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgY29tcGF0aWJsZSA9ICJtdWx0aWJvb3QsZGV2aWNl LQ0KPiB0cmVlXDBtdWx0aWJvb3QsbW9kdWxlIjsNCj4gPiA+ID7CoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoCAvKiBCb290IG1vZHVsZSBhZGRyZXNzLCB3aXRoaW4gbXB1LGJvb3QtbW9k dWxlLQ0KPiBzZWN0aW9uDQo+ID4gPiAqLw0KPiA+ID4gPsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgIHJlZyA9IDwweDEwZmYwMDAwIDB4MTAwMDA+Ow0KPiA+ID4gPsKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgIC4uLg0KPiA+ID4gPsKgwqDCoMKgwqDCoMKgwqAgfTsNCj4g PiA+ID7CoMKgwqDCoCB9Ow0KPiA+ID4gPiB9Ow0KPiA+ID4gPiBgYGANCg== From xen-devel-bounces@lists.xenproject.org Tue Mar 01 12:58:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 12:58:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281390.479705 (Exim 4.92) (envelope-from ) id 1nP24p-000382-FC; Tue, 01 Mar 2022 12:58:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281390.479705; Tue, 01 Mar 2022 12:58:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP24p-00037t-BV; Tue, 01 Mar 2022 12:58:03 +0000 Received: by outflank-mailman (input) for mailman id 281390; Tue, 01 Mar 2022 12:58:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP24n-00037h-RU; Tue, 01 Mar 2022 12:58:01 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP24n-0006je-OE; Tue, 01 Mar 2022 12:58:01 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP24n-0002pY-D7; Tue, 01 Mar 2022 12:58:01 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nP24n-00021f-Cd; Tue, 01 Mar 2022 12:58:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=VzN/AYgjCtV70HAm+LSlj4eh2AwFQHFPpTsmRNGgUGw=; b=ZxtG3FhpYpND+ELfoD5/5DI4rI pwf4Ur9oCm20Ldbf/0dJIgP4pbFcaUvx4gB9bVQwe/REAFzw+Nl7Wry0GCSEQ9GfG0GDcalhSR8g8 KUzNNd6ROYXwWg8Dx4TN8gFY1N9Kex/KHlT1vXR09jx1WCO3IYDs8xSZb1kd6IMAEajQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 168290: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=497ac7b6d7f9750f48f137db244931a5728b1968 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 01 Mar 2022 12:58:01 +0000 flight 168290 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/168290/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 497ac7b6d7f9750f48f137db244931a5728b1968 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 1 days Failing since 168258 2022-03-01 01:55:31 Z 0 days 6 attempts Testing same since 168262 2022-03-01 04:10:26 Z 0 days 5 attempts ------------------------------------------------------------ People who touched revisions under test: Guomin Jiang Jason Jason Lou jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 497ac7b6d7f9750f48f137db244931a5728b1968 Author: Guomin Jiang Date: Sat Jan 29 16:28:02 2022 +0800 UefiPayloadPkg/PayloadLoaderPeim: Use INT64 as input parameter REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3818 It will have some potential issue when memory larger than 2G because the high memory address will be fill with 0xFFFFFFFF when do the operation of INTN + INT64 but it is 32 bit normal data in fact. Should use same data type INT64 + INT64. V3: 1. Use INT64 as input parameter because all date type is 64 bit V2: 1. Force the data type to UINTN to avoid high dword be filled with 0xFFFFFFFF 2. Keep INTN because the offset may postive or negative. Reviewed-by: Guo Dong Reviewed-by: Ray Ni Signed-off-by: Guomin Jiang commit 6a890db161cd6d378bec3499a1e774db3f5a27a7 Author: Jason Date: Mon Jan 10 22:30:29 2022 +0800 BaseTools: Upgrade the version of NASM tool REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Upgrade the version of NASM tool to avoid compilation errors when compiling NASM code change. Signed-off-by: Jason Lou Cc: Bob Feng Cc: Liming Gao Reviewed-by: Yuwei Chen commit bbaa00dd01ed0df30e43a5a89fd2b0433d858b73 Author: Jason Date: Mon Jan 10 22:05:47 2022 +0800 MdePkg: Remove the macro definitions regarding Opcode. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Remove the macro definitions regarding Opcode because new version of NASM tool(e.g. v2.15.05) supports the corresponding instructions. Note: This patch need to be merged after other NASM code change to avoid compilation errors. Signed-off-by: Jason Lou Cc: Michael D Kinney Reviewed-by: Liming Gao Cc: Zhiguang Liu commit 2aa107c0aa2e1375651867c8df1b81ff64b67fce Author: Jason Date: Mon Jan 10 22:01:18 2022 +0800 UefiCpuPkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Reviewed-by: Ray Ni Cc: Eric Dong Cc: Laszlo Ersek Cc: Rahul Kumar commit 7bc8b1d9f412507d579f21ea9af56fced81e7827 Author: Jason Date: Mon Jan 10 21:52:52 2022 +0800 SourceLevelDebugPkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Reviewed-by: Hao A Wu commit d3febfd9ade35dc552df6b3607c2b15d26b82867 Author: Jason Date: Mon Jan 10 21:46:27 2022 +0800 MdePkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Cc: Michael D Kinney Reviewed-by: Liming Gao Cc: Zhiguang Liu commit 84338c0d498555f860a480693ee8647a1795fba3 Author: Jason Date: Mon Jan 10 21:04:09 2022 +0800 MdeModulePkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Reviewed-by: Ray Ni Cc: Dandan Bi Reviewed-by: Liming Gao From xen-devel-bounces@lists.xenproject.org Tue Mar 01 13:02:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 13:02:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281401.479716 (Exim 4.92) (envelope-from ) id 1nP29G-0004eO-2o; Tue, 01 Mar 2022 13:02:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281401.479716; Tue, 01 Mar 2022 13:02:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP29F-0004eH-Vw; Tue, 01 Mar 2022 13:02:37 +0000 Received: by outflank-mailman (input) for mailman id 281401; Tue, 01 Mar 2022 13:02:36 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP29E-0004e5-5z; Tue, 01 Mar 2022 13:02:36 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP29E-0006uc-5A; Tue, 01 Mar 2022 13:02:36 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP29D-00031r-SC; Tue, 01 Mar 2022 13:02:35 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nP29D-0003XR-Rl; Tue, 01 Mar 2022 13:02:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=TAyQlAjPQxvhjsHARJD4lqI3yWRE4Jw3kgZs3m8ZnI8=; b=0zug5ar3Rraqcrm87DWMnxuRe+ WuRf18PubzUSa04bZqdcGEClA+XZOe8lf11CzfCEtl3ifoLDze91uj+piFKEKwze+AJ3T7Z+fj+si zo/0N6sKCUI/p5mY6dVGKGytVk0n1Gz427dVVh6+xXUYKJBTPBFfXWXVK20rmsNE3WKE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 168283: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=e0a514d2f4b2fcb51835aa9a9b02653b491a61fc X-Osstest-Versions-That: xen=4388144c44c4dd9e9b7df97938ef08ffa85eec07 From: osstest service owner Date: Tue, 01 Mar 2022 13:02:35 +0000 flight 168283 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/168283/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen e0a514d2f4b2fcb51835aa9a9b02653b491a61fc baseline version: xen 4388144c44c4dd9e9b7df97938ef08ffa85eec07 Last test of basis 168246 2022-02-27 20:00:25 Z 1 days Testing same since 168283 2022-03-01 10:00:26 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jan Beulich Roger Pau Monné jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 4388144c44..e0a514d2f4 e0a514d2f4b2fcb51835aa9a9b02653b491a61fc -> smoke From xen-devel-bounces@lists.xenproject.org Tue Mar 01 13:07:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 13:07:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281413.479733 (Exim 4.92) (envelope-from ) id 1nP2E5-0005Y6-QB; Tue, 01 Mar 2022 13:07:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281413.479733; Tue, 01 Mar 2022 13:07:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP2E5-0005Xz-Ml; Tue, 01 Mar 2022 13:07:37 +0000 Received: by outflank-mailman (input) for mailman id 281413; Tue, 01 Mar 2022 13:07:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP2E5-0005Xt-1r for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 13:07:37 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8f00fcf1-9960-11ec-8eba-a37418f5ba1a; Tue, 01 Mar 2022 14:07:35 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8f00fcf1-9960-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1646140055; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=YJ+fCSm8D5VU+uZHrw75Nj2/sezhnaA0OYiRp42QpAc=; b=d+nv+zz17gZ6rF7NQ4C+dtEXeB07MEk2eK4M9o3eh5B/zM839YRdiFbv N5KgDplrIgkndFhqoXzIP3aJtruJAcWeJJmNI3SZ3Uyu0H/3QS995VJcf BHq6/AqVLFknA0S5lwM0JzqGbxJaCJYzj9pttr5cnoLoiwaO/UHWhCTjD M=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com X-SBRS: 5.1 X-MesageID: 64656946 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:WFJ8Fa7UNWxHrQJ6/JVqugxRtCXHchMFZxGqfqrLsTDasY5as4F+v mRMXDyGaf3YMDGge993YISz/RtUv5/cy4RiSAdrrXsyHi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0XqPp8Zj2tQy2YPhWlvX0 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx umhurSNViczJ5bOm9gDVkFXExlYHpRJ3pr+dC3XXcy7lyUqclPpyvRqSko3IZcZ6qB8BmQmG f4wcW5XKErZ3qTvnez9GrIEascLdaEHOKs2vH16wC6fJvEhWZ3ZGI3B5MNC3Sd2jcdLdRrbT 5RFN2cxPUieC/FJEgkyS5IPw8T1ulLiNARdj2yYhbp03FGGmWSd15CyaYGIK7RmX/59gUKwt m/AuWPjDXkyJNGZjDaI7H+oruvOhj/gHpIfEqWi8fxni0HVwXYcYDUUX1ampfiyimalRslSb UcT/0ITQbMarRLxCIOnBlvh/SDC7kV0t8ds//MS1R6t0LPv4QWlGG1cQT55Tv8fu+kTfGl/v rOWpO/BCTtqubyTbHuS8LaIsD+/URQowX8+iTwsFlVcvYS6yG0npleWF4s4Tvbp5jHgMWyom 1i3QD4Ca6L/ZCLh/4Gy5hj5jj2lvfAlpSZlt1yMDgpJAu6UDbNJhrBEC3CGtZ6sz67DFzFtW UTofeDEtIji6rnXyUSwrB0lRu3B2hp8GGS0baRTN5cg7S+x3HWoYJpd5jpzTG8wbJpaIWCyP hOK4FoAjHO2AJdMRfUsC25WI553pZUM6Py/DqyEBjawSsIZmPC7ENFGOhfLgjGFfLkEmqAjI 5aLGftA/l5BYZmLOAGeHr9HuZdyn3hW7TqKGfjTkkT2uZLDNSX9YepUbzOzghURsfrsTPP9q I0EaaNnCnx3DYXDX8Ug2dVLfABScCNiXsieRg4+XrfrHzeK0VoJUpf56bggZ5Zkj+JSkOLJ9 Wu6QUhW1Bz0gnivFOlAQioLhG/HNXqnkU8GAA== IronPort-HdrOrdr: A9a23:IRqloqBq022owpLlHegCsceALOsnbusQ8zAXPh9KJiC9I/b1qy nxppkmPEfP+UsssHFJo6HkBEEZKUmsuqKdkrNhQYtKOzOW9ldATbsSobcKpgePJ8SQzJ8l6U 4NSdkcNDS0NykBsS+Y2nj4Lz9D+qj+zEnAv463pB0NLT2CKZsQlDuRYjzrSXGeLzM2YabRYa DsgPav0ADQHkj/AP7LZEUtbqzmnZnmhZjmaRkJC1oM8w+Vlw6l77b8Dlyxwgoeeykn+8ZjzU H11yjCoomzufCyzRHRk0XJ6Y5NpdfnwtxfQOSRl8kuLCn2gArAXvUjZ1TChkF2nAic0idvrD D+mWZmAy210QKWQoiBm2qp5+An6kd215at8y7BvZKpm72HeNtzMbs+uWseSGqC16NohqAN7E oAtVjpxqZ/HFfOmj/w6MPPUAwvnk2ooWA6mepWlHBHV5ACAYUh5rD30XklWavoJhiKoLzP0d MeeP309bJTaxeXfnrZtm5gzJilWWkyBA6PRgwHttaO2zZbkXhlxw9ArfZv00so5dY4Ud1J9u 7EOqNnmPVHSdIXd7t0AKMETdGsAmLATBrQOCaZIEjhFqsAJ3XRwqSHqokd9aWvYtgF3ZEykJ POXBdRsnMzYVvnDYmU0JhC4nn2MROAtPTWu7ZjDrRCy8/BreDQQF6+oXgV4r6dn8k= X-IronPort-AV: E=Sophos;i="5.90,146,1643691600"; d="scan'208";a="64656946" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dAB1IFVaTnaiACZUcTKt+5FQY4OkRFZEPSjfa+zGWJnIKNr8dcZLT/nNtt8hO2ht29YHIn9Mff6jNisLP5In9jZz7Qwg0nf/EYFMBkgw867/WHCGRvPoBD/iJ3Rs9VhBNPGw4VZ5mhm3iaxAjlLzyEKU7VS8iMGvoT21GM37R81VLfeUzPx5ddSW+4tG9Nxn2WumnCeQu22yJzcRB12aeOQJE4tPUGsvGoiUW+23gJAHXVcbS1JdicedhlXMpjgIUk2nG0F1NAT9VTj8d+kFcgff0X7+UJK9AqKBdY2yKfJS9zTelhvf2m6X3h/I0XIf2eOCGiN1l15RNW8EKxNkeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YJ+fCSm8D5VU+uZHrw75Nj2/sezhnaA0OYiRp42QpAc=; b=UQlZWqeR4O+iiK2t4iIcbgJQdWJPHbd5hfu2wtKWZ2q854+TTQjy2crAbU82ll+IHhdzUidMtbS/WNu9nbbfvyD/yXntZRPozsOSzjjZC7+fLWRw4d+iHK/JJfsAsOL0k0fPDu5k4yohU2MDhGUe3s7E96AXxYhEpE7Is5v2nmduTYuXe3KjLp8sBp72QeWiGQj6YlQPLhUa1M3YVvfcxjwsegIFYNn/PBz6WtsvkaH5Zzy7PdneSmcNvvGUWwwy3vxH+DJybSwVEaL8332JEpLpHh+kyyeeNNp2fVLIG59f7jA9hC8mFsJ9YpPM1TYQS6xAnQQUBt0r6YJbob4MMw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YJ+fCSm8D5VU+uZHrw75Nj2/sezhnaA0OYiRp42QpAc=; b=ggd2z+8+SQEiNps4ecsF+2pNiRJEXJURGB4/rN+22+zopzmLWpPhPecolSYkmqStiAsD++6osPc+yjjSgE7Z7vBlGDm+PkaVRy+ghXDrxkXcvEKAfv1+tOkJhTlBZZhAlt8/8bdag0zkXLyaoJShbz8+r5BzDVkPtX7W8+kRjmI= From: Andrew Cooper To: Jan Beulich , "xen-devel@lists.xenproject.org" CC: Wei Liu , Roger Pau Monne Subject: Re: [PATCH 1/2] x86/time: use fake read_tsc() Thread-Topic: [PATCH 1/2] x86/time: use fake read_tsc() Thread-Index: AQHYLVxVKor9YtEUbkuWag9T3yUcNqyqf+CA Date: Tue, 1 Mar 2022 13:07:27 +0000 Message-ID: References: <77675e7f-2a7e-f517-4aba-e20774c8bfe5@suse.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ab334437-0fd9-4bde-1b36-08d9fb846fdb x-ms-traffictypediagnostic: BLAPR03MB5378:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: kbHfnVjUgJQOrOQrm5DltGeKT/4N4SdtG+rOgAAgyU1rFDMcOaIYHrzRx+O2GSI9yVf1VhZg8NudRhPG7IGbhTEay2PeNgYjj6n2RpEagFe8VI3gcAtT3wyZ84iaumCPUBkE7D/GQK/kTS/85MqJ3p1IQFIp+2P3vzP4C/UINq/y6bsvkUlpfRfEuo1BBhc6yoy44D36U/d90itdUl2UljmN/rUfQjJMnBrx6WlwPqJLDgd85wImfdejCbLFORRPsWWjLdy+M3VPcOReyaM/qmSVHPGleZysRG6j+xj39GjIpGPvTcqJuRT671tVD1JdwZ8fGOaa83fbJ2KoZooIkR5PJWXC/ic7yl4lo5JI69y1WfvdAPJKd3epGaJkF8IzhTkTMOTSRp3yQA7q9QgAh2DOnrVRvuDYmf3yJGPegfLmUEO51+s1BvTPdtAJrsghut0glRe+VfSd/VSwmII+uvlIosOaKN+JE13ola+/VqL16T6fEC20Ft94sZVLdO/Ar8mRN8gIt+IrhVfLLIA6ShGAxnme866lhZUq8otsrOzfW1OguMErTRy4s8ve17Le6o7vDWeiAALSyAHicmz8dQwy6dMsCLQsJsIFhwQjf19+JSaIBgfxlcC2Etj1ak3OAGU8ss7aRtIs7SOEjQ7PKNP74Zf35bqvMfLP2q0TAMJJc28OGDvzZ9VURfULko0qzEDtdwupfU+lgdSBdawzPwjFZlA9JDaEPotTsDO/wilkq009nFbXpmJv0bRyZnqF8M772FknMXhoWvnuQj/o6Q== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6486002)(31686004)(53546011)(54906003)(110136005)(6506007)(2616005)(122000001)(82960400001)(5660300002)(86362001)(316002)(8676002)(2906002)(38070700005)(26005)(64756008)(66446008)(66476007)(66556008)(38100700002)(66946007)(31696002)(4326008)(91956017)(71200400001)(76116006)(36756003)(508600001)(186003)(6512007)(8936002)(83380400001)(107886003)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?SlpkY1lMTmsrRUZpcUpQRnFZVHRlb0YvR1pvRlBqYUd3TjJVdnBXWHdvYzBq?= =?utf-8?B?Z3dkbEcvMktIRjYrM3VuMkthS2dnRGs1amU3dFV5VnBXZUlnTXJzQ0Z0WTZu?= =?utf-8?B?Ulg4azVvQ3R3NWxOTTNkekU4bFJ5dEpyZVR6U0xkTUtsd3JMTmlvNm5jLzZO?= =?utf-8?B?OVJvRXNiSzJCeExHdGN0RUplL3FhekIrRnZpV2lKejRsOEVib0pMajFWU2Fk?= =?utf-8?B?SEgxOUVjQ1hSNFJnUW5KN3BIdjgzYml6bVoydGp3VVQwUytjRmZvQ2RteU5Z?= =?utf-8?B?elZZc2pnR3Q1dksraFM3RDlRWThDTlcwYnA5SitFV3hpQ0Q2TjF5dkxMQ2dO?= =?utf-8?B?NGVWdmxqTERqRkpRd0N1YXlHVTlwanM0VVZ1Wlp3RVJRSTg0SWNnQW1BNHJu?= =?utf-8?B?dCtzWjJFK2RiSVFWUWYzVHNTUUxQVzhVd0taZnVqM2RMUmdTUXRYV2NKL2lL?= =?utf-8?B?eHIzd3ZqdDFpVkFUelVGV2IwenErRWljSlppTWROTVY2SGh2SkxHVUFyNGds?= =?utf-8?B?Tmc4bEF1SHQ5L2o3WTRXKzFMVmpZMVM1K2lpQVpPSWFVR1BUOUNUUkZkbjJ3?= =?utf-8?B?bEhqUWlxZnREemYvdENMREcwbDh0b1E5TzZhY3pXQ2orbXdDVHpCTW1rKzBz?= =?utf-8?B?K3E2REs3Z2txVkt0OWw1QVIvMkNuVWwra2Uzb1VKdHNTWThkWmhZRGY4MWJn?= =?utf-8?B?aGxNditacWQxT20rRlVnc3p5TVZRQjFUc1ZUV0txV2oxMzFzNUg2SHM3NWpY?= =?utf-8?B?YVg1bzhFQm5UZXM2ak1MNFJ2aWI4c3lnSFpTTGcrYmVmWUNpNnFJbElRaklh?= =?utf-8?B?ZEhUZHFDRHFKVWk3SGV1bUpoa0FtMTRqdVdKR0FXU05aUFFzT1lDcWRzVURY?= =?utf-8?B?WjJiT3BKKzBrVXExVFBPaE9TNmtScy9XdnpDSnVPQ21jWlJoMk1la2pGZkpG?= =?utf-8?B?cGpsWk1UaDVkUW5HY1c2UHVJWWxpcG1MdW5ZVWpNd1lnRmduaWliTVVSdkxu?= =?utf-8?B?KzR3Z09mNE56dFRFVzk2RWZOYkFwSUpKRlB0bUUzdUtBMlJvMVF2ZVh0MXFq?= =?utf-8?B?dFRZV0x4Mlk5Ylg0TGN2d1VPdVFMSEhwcGEvMmZqQUQybHRBalNpK0krb3RR?= =?utf-8?B?d2hzYWs3RlI1L2xvQWRHampkbm9nSnhRTG5CbGJBMHBVVWQvTzNSTG1xTGlu?= =?utf-8?B?REE0Q2RzUTkyRUZqK1ZrSHVkc0NOR2JaaHVqbUxheUMzS0RwazZNbm1pSUZU?= =?utf-8?B?Q0tzUzgzV2MvTUtNKzNyKzI1bnc0cVRCdjArK3JUdGlmS3dMQWZjTE9STll5?= =?utf-8?B?cG1VUXhYblcxQ2FmSDNMVjE5Mnc5Ky96WU8reUdIUXhmR1R3ZUw4aXpvL2hq?= =?utf-8?B?bkdMKzNOam1WcW5WMHozbVM2VlI4Y0FLRzR5Uk5TU0d4L3ZlbjAzNDlRMnE1?= =?utf-8?B?bGZBR1R0R3d0YndpVWtFbmdiRTZvZlFRT1R3aTVBZlJMaHBmUGZyWDZaTW1w?= =?utf-8?B?OWJqc1FlMjhEOXV5T2Y1dXdZU0dtSExwLzhtbklyclNtaUNteHhHR05SSWFl?= =?utf-8?B?Q0RCYmM0dEl5UG16UEdJak9iQkk4L0huekJVU1JjZWh4VUc2bTRhSm84TXlu?= =?utf-8?B?bml6YiszRGdlNE05aTdWMXk2aUU3RURpZ1dRT2MxYVRXNWhKbVhMVHdFT3Z4?= =?utf-8?B?L3pWZXhuUFloaUw5SEtheDZJY0kzL0xqOFA2dFV6S1Q1MGJmcDZwZUpzUWdJ?= =?utf-8?B?YVVoemp3ZHpoNUptR3RQSnFMQnZ6Z0pUSDg3TXg5Y2VMcGpXaVV1OXRCRHUx?= =?utf-8?B?ZlZZdjNobFpLb0FFS2t0SzdkNFBtYTJwY0hDZ2RWS0NtZ3A0alBBb1hiUWEw?= =?utf-8?B?ck9DeFdVYXBLM1NYNmx3Y3hIVGRwdjdkMk5YN3g4alJJMGxiM0lmMDd4SG1S?= =?utf-8?B?U2hvNzFVUlpQd3haZ1RwT0lLRXRYWmVTc1pKN09tMDl2QjVheTBWc29pSEgv?= =?utf-8?B?MG4za3R2bjFBTEJDTUVkQmlHWllaQnZwZnM2TTkvRWgxRWhVZEhEWDRNUFps?= =?utf-8?B?S1oyd2hmdU9yQWt1MVdNaWFUZVR3WHVydDMzTVZVQVlIV2NVaWg3RnRPWlNa?= =?utf-8?B?Z3gyWTBWYks1dWpLS3FET3VGamo0TFpDVlc1cmRzWXlMUnZ0WWU1STNQTldC?= =?utf-8?B?NWtJSi9QdEZpSXRIWC9tOTRBOVhxZmQyUTJGN05oY2k3R2ljSW1oOVIzWWdG?= =?utf-8?B?YXJFek9VNlFNTjFJcHpvdG5RTW1RPT0=?= Content-Type: text/plain; charset="utf-8" Content-ID: <6FC41E461015B94B866D74A8F7476A2D@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ab334437-0fd9-4bde-1b36-08d9fb846fdb X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Mar 2022 13:07:27.9739 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: E5Zx6hpdbQ0Te5Xmfr2Wz+FOZF6Co00ZG/p26Xf0Vl9aoHBiuGEmfLgX7n8FOk6TFbMktJAEcW8v7CWofJMrruFPvDAODV9zK6ChoOohjQI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR03MB5378 X-OriginatorOrg: citrix.com T24gMDEvMDMvMjAyMiAxMTowNSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IEdvIGEgc3RlcCBmdXJ0 aGVyIHRoYW4gYmVkOWFlNTRkZjQ0ICgieDg2L3RpbWU6IHN3aXRjaCBwbGF0Zm9ybSB0aW1lcg0K PiBob29rcyB0byBhbHRjYWxsIikgZGlkIGFuZCBlbGltaW5hdGUgdGhlICJyZWFsIiByZWFkX3Rz YygpIGFsdG9nZXRoZXI6DQo+IEl0J3Mgbm90IHVzZWQgZXhjZXB0IGluIHBvaW50ZXIgY29tcGFy aXNvbnMsIGFuZCBoZW5jZSBpdCBsb29rcyBvdmVyYWxsDQo+IG1vcmUgc2FmZSB0byBzaW1wbHkg cG9pc29uIHBsdF90c2MncyByZWFkX2NvdW50ZXIgaG9vay4NCj4NCj4gU2lnbmVkLW9mZi1ieTog SmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KPiAtLS0NCj4gSSB3YXNuJ3QgcmVhbGx5 IHN1cmUgd2hldGhlciBpdCB3b3VsZCBiZSBiZXR0ZXIgdG8gdXNlIHNpbXBseSB2b2lkICogZm9y DQo+IHRoZSB0eXBlIG9mIHRoZSBleHByZXNzaW9uLCByZXN1bHRpbmcgaW4gYW4gdW5kZXNpcmFi bGUgZGF0YSAtPiBmdW5jdGlvbg0KPiBwb2ludGVyIGNvbnZlcnNpb24sIGJ1dCBtYWtpbmcgaXQg aW1wb3NzaWJsZSB0byBtaXN0YWtlbmx5IHRyeSBhbmQgY2FsbA0KPiB0aGUgKGZha2UpIGZ1bmN0 aW9uIGRpcmVjdGx5Lg0KPg0KPiAtLS0gYS94ZW4vYXJjaC94ODYvdGltZS5jDQo+ICsrKyBiL3hl bi9hcmNoL3g4Ni90aW1lLmMNCj4gQEAgLTU4NSwxMCArNTg1LDEyIEBAIHN0YXRpYyBzNjQgX19p bml0IGNmX2NoZWNrIGluaXRfdHNjKHN0cnUNCj4gICAgICByZXR1cm4gcmV0Ow0KPiAgfQ0KPiAg DQo+IC1zdGF0aWMgdWludDY0X3QgX19pbml0IGNmX2NoZWNrIHJlYWRfdHNjKHZvaWQpDQo+IC17 DQo+IC0gICAgcmV0dXJuIHJkdHNjX29yZGVyZWQoKTsNCj4gLX0NCj4gKy8qDQo+ICsgKiBwbHRf dHNjJ3MgcmVhZF9jb3VudGVyIGhvb2sgaXMgKGFuZCBzaG91bGQgbm90IGJlKSBpbnZva2VkIHZp YSB0aGUgc3RydWN0DQoNCkVpdGhlciAiaXMgbm90IChhbmQgc2hvdWxkIG5vdCBiZSkiIG9yICJp cyAoYW5kIHNob3VsZCkgbm90IGJlIi4NCg0KPiArICogZmllbGQuIFRvIGF2b2lkIGNhcnJ5aW5n IGFuIHVudXNlZCwgaW5kaXJlY3RseSByZWFjaGFibGUgZnVuY3Rpb24sIHBvaXNvbg0KPiArICog dGhlIGZpZWxkIHdpdGggYW4gZWFzaWx5IGlkZW50aWZpYWJsZSBub24tY2Fub25pY2FsIHBvaW50 ZXIuDQo+ICsgKi8NCj4gKyNkZWZpbmUgcmVhZF90c2MgKCh1aW50NjRfdCgqKSh2b2lkKSkweDc1 Qzc1Qzc1Qzc1Qzc1QzB1bCkNCg0KSG93IGFib3V0IHVzaW5nIFpFUk9fQkxPQ0tfUFRSP8KgIFRo ZSBoZXggY29uc3RhbnQgMHhCQUQwLi4uIGlzIG1vcmUNCmVhc2lseSByZWNvZ25pc2FibGUsIGFu ZCBhbnkgcG9pc29uZWQgcG9pbnRlciB3aWxsIGRvLg0KDQpUaGF0IHNhaWQuLi4gd2hhdCdzIHdy b25nIGEgcGxhaW4gTlVMTD/CoCBJIGNhbid0IHNlZSBhbnkgbmVlZCBmb3IgYQ0KbWFnaWMgY29u c3RhbnQgaGVyZS4NCg0KDQpPdmVyYWxsLCBJIHRoaW5rIHRoaXMgcGF0Y2ggc2hvdWxkIGJlIG1l cmdlZCB3aXRoIHRoZSBzdWJzZXF1ZW50IG9uZSwNCmJlY2F1c2UgaW4gaXNvbGF0aW9uIGl0IGlz IHNsaWdodGx5IGR1YmlvdXMuwqAgcmVhZF90c2MoKSBpcyBvbmUgb2YgdGhlDQpmZXcgZnVuY3Rp b25zIHdoaWNoIGlzIG9mIG5vIGludGVyZXN0IHRvIGFuIGF0dGFja2VyLCBhcmNoaXRlY3R1cmFs bHkNCihiZWNhdXNlIGl0J3MganVzdCByZHRzYykgb3Igc3BlY3VsYXRpdmVseSAoYmVjYXVzZSBp dCBpcyBkaXNwYXRjaA0Kc2VyaWFsaXNpbmcpLg0KDQpUaGlzIGNoYW5nZSBpcyBvbmx5IChBRkFJ Q1QpIHRvIGFsbG93IHRoZSB1c2Ugb2YgY2ZfY2xvYmJlciBsYXRlci4NCg0KfkFuZHJldw0K From xen-devel-bounces@lists.xenproject.org Tue Mar 01 13:17:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 13:17:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281423.479744 (Exim 4.92) (envelope-from ) id 1nP2NU-0007Lk-Sn; Tue, 01 Mar 2022 13:17:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281423.479744; Tue, 01 Mar 2022 13:17:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP2NU-0007Ld-P0; Tue, 01 Mar 2022 13:17:20 +0000 Received: by outflank-mailman (input) for mailman id 281423; Tue, 01 Mar 2022 13:17:19 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP2NT-0007LV-6v for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 13:17:19 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP2NS-0007Pa-Tt; Tue, 01 Mar 2022 13:17:18 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=[192.168.6.66]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nP2NS-0001le-O9; Tue, 01 Mar 2022 13:17:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=bLkgc3t5QqA0tYP1xFG/GpU6vNgDn3gbTj1IxLYQhl8=; b=VWOt4lCvLnfoLkCyu+U2+t0MFc f50rhrUNhKQeACaF+NQnMfUZYAfZpytHPPWoVD+X9CiAqSd47VfotXbt9POyEwIqYyT6kzQuTrKO4 0dWElwn4UseyRjpSmo4EFeFGWT37Qytw77D216L4xiEkOad8CjgoLicNZzCB8BvlJ+8w=; Message-ID: <7260f050-9022-4adf-618b-a8b271aca8c3@xen.org> Date: Tue, 1 Mar 2022 13:17:16 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: Proposal for Porting Xen to Armv8-R64 - DraftA To: Wei Chen , Stefano Stabellini Cc: "xen-devel@lists.xenproject.org" , Bertrand Marquis , Penny Zheng , Henry Wang , nd References: <4c558f8f-56d4-0445-32d4-169bc5d0a3bc@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 01/03/2022 06:29, Wei Chen wrote: > Hi Julien, Hi, >> -----Original Message----- >> From: Julien Grall >> Sent: 2022年2月26日 4:12 >> To: Wei Chen ; Stefano Stabellini >> >> Cc: xen-devel@lists.xenproject.org; Bertrand Marquis >> ; Penny Zheng ; Henry Wang >> ; nd >> Subject: Re: Proposal for Porting Xen to Armv8-R64 - DraftA >> >> Hi Wei, >> >> On 25/02/2022 10:48, Wei Chen wrote: >>>>>      Armv8-R64 can support max to 256 MPU regions. But that's just >>>> theoretical. >>>>>      So we don't want to define `pr_t mpu_regions[256]`, this is a >> memory >>>> waste >>>>>      in most of time. So we decided to let the user specify through a >>>> Kconfig >>>>>      option. `CONFIG_ARM_MPU_EL1_PROTECTION_REGIONS` default value can >> be >>>> `32`, >>>>>      it's a typical implementation on Armv8-R64. Users will recompile >> Xen >>>> when >>>>>      their platform changes. So when the MPU changes, respecifying the >>>> MPU >>>>>      protection regions number will not cause additional problems. >>>> >>>> I wonder if we could probe the number of MPU regions at runtime and >>>> dynamically allocate the memory needed to store them in arch_vcpu. >>>> >>> >>> We have considered to used a pr_t mpu_regions[0] in arch_vcpu. But it >> seems >>> we will encounter some static allocated arch_vcpu problems and sizeof >> issue. >> >> Does it need to be embedded in arch_vcpu? If not, then we could allocate >> memory outside and add a pointer in arch_vcpu. >> > > We had thought to use a pointer in arch_vcpu instead of embedding mpu_regions > into arch_vcpu. But we noticed that arch_vcpu has a __cacheline_aligned > attribute, this may be because of arch_vcpu will be used very frequently > in some critical path. So if we use the pointer for mpu_regions, may cause > some cache miss in these critical path, for example, in context_swtich. From my understanding, the idea behind ``cacheline_aligned`` is to avoid the struct vcpu to be shared with other datastructure. Otherwise you may end up to have two pCPUs to frequently write the same cacheline which is not ideal. arch_vcpu should embbed anything that will be accessed often (e.g. entry/exit) to certain point. For instance, not everything related to the vGIC are embbed in the vCPU/Domain structure. I am a bit split regarding the mpu_regions. If they are mainly used in the context_switch() then I would argue this is a premature optimization because the scheduling decision is probably going to take a lot more time than the context switch itself. Note that for the P2M we already have that indirection because it is embbed in the struct domain. This raises one question, why is the MPUs regions will be per-vCPU rather per domain? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Mar 01 13:18:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 13:18:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281429.479755 (Exim 4.92) (envelope-from ) id 1nP2Oj-0007uz-7l; Tue, 01 Mar 2022 13:18:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281429.479755; Tue, 01 Mar 2022 13:18:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP2Oj-0007us-2m; Tue, 01 Mar 2022 13:18:37 +0000 Received: by outflank-mailman (input) for mailman id 281429; Tue, 01 Mar 2022 13:18:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP2Oi-0007ug-3L for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 13:18:36 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 17fd7b0c-9962-11ec-8eba-a37418f5ba1a; Tue, 01 Mar 2022 14:18:34 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 17fd7b0c-9962-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1646140714; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=FNUCsQ/3JDb57Sl6fkwHLvMucRLmH2WJUthE75WdN54=; b=NjSg2bJcdA+wf6GJ6NJ3/qffOM489q0ADowz3wmCyHw6J5J7wvyOp9bk ePbdZztdncx0R/rV1riThrL/AAxTY+gqvS3k8xhZl/kmm5NAll+lUb2en CwRbKl7DQOaCO/nSLS9s/s4jEDLwZn11wxSX9XlTTqAfvGaVHLsgXQU9j Y=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com X-SBRS: 5.1 X-MesageID: 65216691 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:quNuG63V3Ug/w92StfbD5c5xkn2cJEfYwER7XKvMYLTBsI5bp2MHm jMWXG/Saa2OZ2L0LYx3PNm38h8EvMOHyd5rTgFkpC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EE/NtTo5w7Rj2tUw2IDja++wk YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx /1ilru9SgRxN5aSwukMfgVSAQdlZ51JreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr KJCbmpXN1ba2rzwkOnTpupE36zPKOHCOo8Ft24m5jbeFfs8GrjIQrnQ5M8e1zA17ixLNaiDP ZNHN2s2BPjGSwYMOHsxC5QZp9zyrGjgUiVyqULM+ZNitgA/yyQuieOwYbI5YOeiWsF9jkue4 GXc8AzREhwccdCS1zeB2natnfPU2zP2XpoIE7+1/eIsh0ecrkQRAhALUVqwodGil1WzHdlYL iQpFjEG9PZoshbxF5+kAkP+8CXsUgMgt8R4PM4d5QKOkqPvvVyUF0UYRCxnc4YWu5pjLdA17 WOhk9TsDD1plbSaT3OB67uZxQ+P1TgpwXwqPnFdE1ZcizX3iMRq10+UEI4/eEKgpoCtQVnNL ya2QD/Sbln5peoCzO2F8F/OmFpATbCZH1dutm07so9Ihz6VhbJJhaT1sTA3Dt4ade51q2VtW lBew6ByC8hUUPmweNSlGrllIV1Qz6/t3MfgqVBuBYI90D+m5mSue4tdiBknehs3aplfJ2OwO RaC0e+02HO1FCHxBUOQS9jsY/nGMIC6TYi1PhwqRoAmjmdNmP+vo3g1OB/4M5HFm0kwi6AvU ap3gu73ZUv2/Z9PlWLsL89EiOdD7nlnmQv7GMCqpzz6gOH2TCPEFt843K6mM7lRAFWs+16Or b6y9qKiln1ibQEJSnKPoN5LcAtTdiBT6FKfg5U/S9Nv6zFOQQkJI/TQ3akga8pimaFUnf3P5 XazRglTz1+XuJENAV/ihqxLAF83YatCkA== IronPort-HdrOrdr: A9a23:OQJ0jamiaf2AxCJeJBWsCqRTQPTpDfOMimdD5ihNYBxZY6Wkfp +V8sjzhCWatN9OYh0dcIi7SdW9qXO1z+8Q3WGIVY3SEjUOy1HYU72KirGSggEIeheOudK1sJ 0AT0EQMqyJMbEXt7eZ3OD8Kadc/DDlytHpuQ699QYXcegCUcgJhG0Vanf5LqQ1fng9OXNQLu vH2iMtnUvGRZ1jVLXDOpBzZZmkmzSkruOCXTc2QzocrCWehzKh77D3VzKC2A0Fbj9JybA+tU DYjg3Q/MyYwrKG4y6Z81WWw4VdmdPnxNcGLteLkNIpJjLljRvtTJh9WoeFoCs+rIiUmRQXeZ j30lId1vZImjTsl1KO0F3QMs7boW8TAkrZuBulaL3Y0JTErXwBepF8bMliA2XkAgIbzaBBOe Rwrj+kXtNsfGD9dG6W3am5azh60kWzunYsiugVkjhWVpYfcqZYqcgF8FpSC4poJlOx1GkLKp gnMCjn3occTbpaVQGvgkB/hNi3GngjFBaPRUYP/sSTzjhNhXh8i08V3tYWkHsM/I80D8As3Z WJDo140LVVCsMGZ6N0A+kMBcOxF2zWWBrJdGafO07uGq0LM2/E75T3/LI27ue3f4Fg9up+pL 3RFFdD8WIicUPnDsODmJVN7xDWWW24GS/gz8lPjqIJ84EUhICbRxFrZGpe5vdI+c9vcPEzc8 zDTK5rPw== X-IronPort-AV: E=Sophos;i="5.90,146,1643691600"; d="scan'208";a="65216691" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h7oilectNqtwr/dToN49LEL3WxFctig1P3v8x0BEXw6i5zAM65ynwBwWLwpiNBwCRiNoOZUpo7i3J9Pu+aanLT8QzAmFUB+TKscGi6xOFVC5GY6EzGf2kwHAQbKk2LLEFO1TbzPY7Qr+CF7EnayXVQwKDEFD4OnDlitZSuOsL28whh2+AVurANR367pCj/XymYuz/vwZrl7JqUXqybmFlrYslcN/vXCxsI7NU+Csw9zV36G9yAG9+uEmL2gfmWr89Q7Clq5pWKe75ARBje2zBvClz3frVBmoTOmkv3eFa29bjBKQ++9bO8DG6hLXFuucXddHvktsDOx6qnxytNudtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FNUCsQ/3JDb57Sl6fkwHLvMucRLmH2WJUthE75WdN54=; b=WR1gMQx4NxDqrnz91k3mWBjdytfYzkR9ALHi5hTqEnyNMpV0ZyQ2UJF7kI4s+j+hhWczqeW4tAjUlAGWaCuSUsNADtPZcAWd/vQRxRmpUJ2o0OzBnhmlqJ14Y3a5uGITsL5d7crWPSGfXdZDaBHynyRYmBENbXG60Gtue0e/3Y4sRA2rSUdHmNvUsnuUFcweRUwuVLjOm12CjeWhR5as7nR8u9g/Bqg4nikJ9zQChEL2YsJ+Zr6wDCd5DIjeEkBhOgWVHLL0jgLeozx6BIG0IPecmCLKXMf4mUE+qOz7oXu6Pba3e/aUlUJ21kbkBHIYztXVuRsViqwOVPG6LA0wQQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FNUCsQ/3JDb57Sl6fkwHLvMucRLmH2WJUthE75WdN54=; b=lY7FANjnqIjPAymBxjLxRZus9ZlNu/2R8WjsQD1+kj9/DdGWyYMpod+MbfgBgli2HzHW+KkmlcIiXVoBrW5+JLNdgrP13vtQkTO/E90phxErYiirdWROLBK0moFTdb+gYvGrK+gn70+51huVFd/5AvERepNSwNrW5E1hH0Hiy3g= From: Andrew Cooper To: Jan Beulich , "xen-devel@lists.xenproject.org" CC: Wei Liu , Roger Pau Monne Subject: Re: [PATCH 2/2] x86/time: add CF-clobber annotations Thread-Topic: [PATCH 2/2] x86/time: add CF-clobber annotations Thread-Index: AQHYLVxwam4XOlcoM0qksn/nZK0dPqyqgvIA Date: Tue, 1 Mar 2022 13:18:26 +0000 Message-ID: <20185a89-0a2b-6bbd-5484-31b6582ed200@citrix.com> References: <77675e7f-2a7e-f517-4aba-e20774c8bfe5@suse.com> <61bbf544-74ac-b698-425a-d1db80acab43@suse.com> In-Reply-To: <61bbf544-74ac-b698-425a-d1db80acab43@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e114ef2a-9688-4d25-577f-08d9fb85f893 x-ms-traffictypediagnostic: DM6PR03MB4841:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: O16tGBj26aYukF16a4X15DJ70uUxuw0+0V3VdJJ40XMMdhCbKg8th4ruo2VNn/RfIB8SX8RQgKmNKXEikOftqgE/ACCcjyh9/jPOduHmje4YPbxxrmJ82mLMCRZgSiJqyoRTQufSkYuSTSeGJBZPiHCXOxjXVDddSmAZ2So8T/sqY/0oKzJ6Z/2jEPVjC6t7EwTrztJ2XKtDjXIBe395ZTdobb4FqiRKEk3Ot22T8ydos590QwGGRo8a42xEuC6KZdRBP/NrUMuC4bA+HpPSE46xTYLorVP7e4G2UkFRBqTqNu0n3PP+p/Q7U86Y2EeoVTt5DBfN4Mk5l0jTCA6Hl+TFH5pgivpbLttVOCk0VTwh/xZ0OmLjdwpov8dCOME8Z2TZ/I3RLJetIktL+AYT4OCtRMgeP/hFz5+kn5wZs8ssG1MlEtu5+9h4JAS1gW4wAbpzxCPUsp1ixRpKLNW/9uGDrJ5U9Bujx+2nDyo1QTHL3zCdSH15RrFNnT0PwqPrZ2F2rBLhzn9H7xp0qjuOimfnHHqgxX9MV6HC/odcZlATt9mkjsnwf0xNrJ3d+iFgMwy46f8tI49LxckpYGE+g/wdpsMjFc+P7JXKpZhy97W5siSrJjb3+JTjTSxtooMh4oeYwidO00tFCfg5F3g+unTsP/iDKiW8aLcD/XjpjzdtwDizCKUDMZ6c1VhoG80GUAHN5UQ5jahJ9+FoZDR2AQkk/jnfo9IMECUbqgIXxu/9inegQjgGr4hV6tZpzjV/E7hUeJCrer22PvoPEKP10Q== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(36756003)(82960400001)(6486002)(2616005)(8936002)(53546011)(31686004)(83380400001)(508600001)(122000001)(71200400001)(110136005)(54906003)(6506007)(86362001)(6512007)(107886003)(316002)(5660300002)(31696002)(38070700005)(38100700002)(4744005)(186003)(26005)(66556008)(8676002)(64756008)(66476007)(66446008)(66946007)(91956017)(2906002)(76116006)(4326008)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?NGNBaVQzWXN3L3A2VG1lRWpvV1Z0NElJS3N2b2dmUEJicFZYRmZjWlRnVVc4?= =?utf-8?B?N2c3WitGbEVNZlJ3WExES3lKdkxKMm5weXhTZ3RXL2U1bXBKRmVQQ3Z3cEh4?= =?utf-8?B?Y0tBMExhUUZacnhBSm9PWVZodWVRMFJWL2RHL2FsM1FTWXhQa2t0YmRNRy9M?= =?utf-8?B?VXp3d3hQL0R1cThGUzYvZE11RWc3emtYM0QwNXpxWis1NWhPTitHSHdCZnRm?= =?utf-8?B?VnpYbkNmQ0YyM1diN3VSaFBvYVgwUHp6M2I3WUJCWit3RlU2T2FhcWJ4YVlp?= =?utf-8?B?dWJEaTF0TXEyNE42RTAxWmhLbks3SG51ZnQxclFPbXZGUjArV0tocnpVaXBK?= =?utf-8?B?b0cxMHl0TWJ6L2FOem9NU1dnVVB5N1cweVJRYmQ3eTN6anJCak42dmZkMHRN?= =?utf-8?B?bk1YTlpuYVNQWWNJYWo2Vk4wMUxSU3RUL0RqY2UycFJyR2NSSXMvd2l4VE0x?= =?utf-8?B?MnlwTVFKakNjWEJneGVicFlOZnIrazhJV0RIUlEwdzlEN1VKTFVhY3ZtUERH?= =?utf-8?B?NDlPM1F1d1FjSGFFODRValF4eWdqZmEvUXhQdlI4OTllY1Qyemxmdi9PRTVo?= =?utf-8?B?VkdEak5vNnJEMDF6aCtudWpuYk9GakFSQ0l1aGVUSjNLY3M1aTh2aHNzSnR5?= =?utf-8?B?UWVsdnIwZzVraWNMSUJUQUdZbXRrUHZTWWE0bHlaNUQyS2F2SDg4bFltc2xh?= =?utf-8?B?bDVDRTVmeWttUXc4WVdoRk43MHMvNmlkQlZVMzZ1S0xYbkx3cWFCay9FODRl?= =?utf-8?B?MXM1MFBHZ1pLMWpaNjh4UDI1MFgzZnVqRTd4UTgwOW43b045emFlWkNXZDdN?= =?utf-8?B?akk5S0ZEdGhNb2JRTmQ5cXZmdXV5d3A4aFR5YStHOHFiWGk0ZkZMWFVsUUR3?= =?utf-8?B?V2FkY0FHNnZhZjZqazNsNHp2bHpsV3FmV0R1cFI5ekEveDk3Z3JKUmNFSTJG?= =?utf-8?B?cFRvcGxNT2dMUTU1bUVxTGNaZUQzRGFMTEhKRW1WK3ZOY0I2UlplQjVjcDN4?= =?utf-8?B?Z093NGgvTFgxNmJ5V0NsalBaeUJWNGN0SUlsL2t5TWY2VFVSNTFTQlUwMUJK?= =?utf-8?B?RXJOajhjWWVYajF5QmZjZHNFNFZRWm5STHF1NjdXSVpsdnlIdmpPdmFGbVNW?= =?utf-8?B?YUIyRHR5azNHWVpmV09vU2t6dGJXWFhqTFc1NDBsTVRLQnVVOFZqZGlRMHBa?= =?utf-8?B?MWhqbnViR3JFeTdiQldERjJUZUZma2V1eGxLNUh2Q1IxOGl0QkpDblFqb1d2?= =?utf-8?B?TW52OVVPcHU0cVM0UHhsV1QwV1JQbGN0alBidmtyOTcyTVZyOWYvWmNOTkpl?= =?utf-8?B?UEtsR1d4VUM1S0lpVzlsNitLYzVPc0l2ak93Q2owRGphS2FMaXoxbTBrbDl5?= =?utf-8?B?WUhtS0ZXT0xkZmF3dGdpSW4xazFxRFI3Y2xIbCthMkZEZ28wQWc0Y3lZTXFq?= =?utf-8?B?Z2c1NlkzSEI0VFVHODBYTTl4N3I2M3lINjNWeGpXZWorSEFTNkd2QTE2M3hF?= =?utf-8?B?Zk9BYUR1TXd0NE9uQy94VG0rNjhvUGd2YzB0Uk9WSzZYRUZTNjM0Z29QM0Ni?= =?utf-8?B?TjI4RTg3ZzJhM0RrZDZYK1dia0prNktmQXNIZEpyQzBPWmFLZzVDSEZKTTFj?= =?utf-8?B?TEFiSHl4Ym0zUmFjS0NaSkVaV1Azc3RlcC9nVUZmQTROb0JGc2R3UCtpSXlU?= =?utf-8?B?UjN0cGdpbWhBUVVRa0tYU3Rucm9Pc21LWnlIV1k3YXY5UXR1SVh5aThvaWtN?= =?utf-8?B?R1YxcmdpR1phNG9hclAyem1SU0JPVzJLdWRkMVlqVk9JT1JySWRWeUZ3VGY3?= =?utf-8?B?dHdiOEkwYWpocDNpeWFFVU5PQUQ1M0oxdFpURUJnTWM2c09xMW5TOTRkMVBU?= =?utf-8?B?bjYxdy9RSmIrY3Q5L3VlQmVYalBPc0NxQUNMckMzTFZFcjNoRUg5MUUwUDRS?= =?utf-8?B?dVJKMDdsSzBkUmJzY3NaRnN6U0NyQUIxWmwzSzRDbklwNUcvSU9jc2VJTWc4?= =?utf-8?B?R2ZLK2pERGpiNlRjUWRGMXNiVTZBZllrMm80VHlnaWhRQTJucGNrWld3Rzlw?= =?utf-8?B?S0gzVzFjYlhtallMcm5DYkpwNC9jNHhiTW50TDBScnp2RVVFcVhDcGR5MnhC?= =?utf-8?B?Qm1oTEEydFc3MzI1bSt0Qyt0ZnRvdWJTY0sxK2Y2RHBaeThGYW96a2ltdk1B?= =?utf-8?B?eHZNSHdWZ3BIRnhMOFlybm9yRm5DejRBdmlQTnJwR3gvY21CaHMza1BiNHN0?= =?utf-8?B?UDZjOWgrc0lRYi9NSzhWZXdGTSt3PT0=?= Content-Type: text/plain; charset="utf-8" Content-ID: <2F720E199895F34CAA51EECC4B024B0D@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e114ef2a-9688-4d25-577f-08d9fb85f893 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Mar 2022 13:18:26.8638 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: JcfK3DAHQWmU+TlubSce8lIZOjVzU1iyEWQVeIK0MlQLLG4coE0zwOv0sgaFB3+JAyciyOjFdTQXCOyOmdW5ahxi3Yy7gLWPL3o4eVP/izI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4841 X-OriginatorOrg: citrix.com T24gMDEvMDMvMjAyMiAxMTowNiwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IFdpdGggYmVkOWFlNTRk ZjQ0ICgieDg2L3RpbWU6IHN3aXRjaCBwbGF0Zm9ybSB0aW1lciBob29rcyB0byBhbHRjYWxsIikN Cj4gaW4gcGxhY2Ugd2UgY2FuIGZ1cnRoZXIgYXJyYW5nZSBmb3IgRU5EQlIgcmVtb3ZhbCBmcm9t IHRoZSBmdW5jdGlvbnMgbm8NCj4gbG9uZ2VyIHN1YmplY3QgdG8gaW5kaXJlY3QgY2FsbHMuIE5v dGUgdGhhdCBwbHRfdHNjIGlzIGxlZnQgdW50b3VjaGVkLA0KPiBmb3Igbm90IGhvbGRpbmcgYW55 IHBvaW50ZXIgZWxpZ2libGUgZm9yIEVOREJSIHJlbW92YWwuDQoNCkknZCBiZSB0ZW1wdGVkIHRv IGluY2x1ZGUgaXQsIGZvciBjb25zaXN0ZW5jeSBzYWtlIGFsb25lLg0KDQpJdCBpcyBsZXNzIGxp a2VseSB0byBnbyB3cm9uZyBpbiB0aGUgZnV0dXJlIGlmIGFub3RoZXIgaG9vayBpcyBpbnRyb2R1 Y2VkLg0KDQo+IFNpZ25lZC1vZmYtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4N Cg0KV2l0aCB0aGUgY29tbWl0IG1lc3NhZ2UsIEknbSBub3Qgbm90IGNlcnRhaW4gaWYgdGhpcyBp cyBsaW5rZWQgdG8gdGhlDQpwcmV2aW91cyBwYXRjaC4NCg0KT3ZlcmFsbCBpdCBsb29rcyBmaW5l LCBidXQgSSdkIGxpa2UgdG8gZ2V0IGNsYXJpdHkgb24gdGhpcyBwb2ludC4NCg0KPiAtLS0NCj4g SSBkaWQgY29uc2lkZXIgY29udmVydGluZyBtb3N0IG9mIHRoZSBwbHRfKiB0byBjb25zdCAocGx0 X2hwZXQgYW5kDQo+IHBsdF9wbXRpbWVyIGNhbm5vdCBiZSBjb252ZXJ0ZWQpLCBidXQgdGhpcyB3 b3VsZCBlbnRhaWwgcXVpdGUgYSBmZXcNCj4gZnVydGhlciBjaGFuZ2VzLg0KDQpJdCdzIGFsbCBp bml0ZGF0YS7CoCBjb25zdCBpcyBub3QgdGVycmlibHkgaW50ZXJlc3RpbmcsIGVzcGVjaWFsbHkg aWYgaXQNCmlzIGludmFzaXZlIGFuZCBpbmNvbXBsZXRlIHRvIGRvLg0KDQp+QW5kcmV3DQo= From xen-devel-bounces@lists.xenproject.org Tue Mar 01 13:30:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 13:30:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281437.479766 (Exim 4.92) (envelope-from ) id 1nP2a1-000259-7o; Tue, 01 Mar 2022 13:30:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281437.479766; Tue, 01 Mar 2022 13:30:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP2a1-000252-4X; Tue, 01 Mar 2022 13:30:17 +0000 Received: by outflank-mailman (input) for mailman id 281437; Tue, 01 Mar 2022 13:30:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP2Zz-00024q-4a for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 13:30:15 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20631.outbound.protection.outlook.com [2a01:111:f400:7d00::631]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b9a7caf5-9963-11ec-8539-5f4723681683; Tue, 01 Mar 2022 14:30:14 +0100 (CET) Received: from AM7PR04CA0006.eurprd04.prod.outlook.com (2603:10a6:20b:110::16) by DB8PR08MB4571.eurprd08.prod.outlook.com (2603:10a6:10:ac::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.24; Tue, 1 Mar 2022 13:30:11 +0000 Received: from VE1EUR03FT035.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:110:cafe::9d) by AM7PR04CA0006.outlook.office365.com (2603:10a6:20b:110::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.26 via Frontend Transport; Tue, 1 Mar 2022 13:30:10 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT035.mail.protection.outlook.com (10.152.18.110) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22 via Frontend Transport; Tue, 1 Mar 2022 13:30:10 +0000 Received: ("Tessian outbound 63bb5eb69ee8:v113"); Tue, 01 Mar 2022 13:30:09 +0000 Received: from 9e6f22f12155.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 2BE4B18E-70EE-446E-9ED5-6BB98E40787A.1; Tue, 01 Mar 2022 13:30:03 +0000 Received: from EUR03-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9e6f22f12155.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 01 Mar 2022 13:30:03 +0000 Received: from AM0PR08MB3778.eurprd08.prod.outlook.com (2603:10a6:208:104::24) by PAXPR08MB7245.eurprd08.prod.outlook.com (2603:10a6:102:210::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.26; Tue, 1 Mar 2022 13:30:02 +0000 Received: from AM0PR08MB3778.eurprd08.prod.outlook.com ([fe80::4dbb:4fed:bc86:1803]) by AM0PR08MB3778.eurprd08.prod.outlook.com ([fe80::4dbb:4fed:bc86:1803%6]) with mapi id 15.20.5017.027; Tue, 1 Mar 2022 13:30:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b9a7caf5-9963-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0QJG6lUHRRR5Bx3rjh8fSAN00goQWZPELfVy7v1+b2g=; b=UH6MZl/7vnBdf6aVCu16GgQjyT+zxKhJay8+ci9v0n4HwmQ/eQj5URgn/9VOxuHqwfE533HUeRAEn5r67Ebb/FzvuW4cKGGCYQ+amPJ39jBbGMtLbswX/2gTBDA78+DwKj8WeAxGhlgQwISAW4fvsBNCXW7DjYGINGTeZAJjVqs= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 700619e766453692 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XfdY3iVlxJxOxz1M/69x0h5civqz40qpLF7kjNK/dFl7xl4TDGfpEFdQQJyd5JUeHqZrt4I2vcTMrEpkq6XbnI2ETeEaChxF4uowJrG3wLM136sQ95DsXIIooZ8O3LQEjjczPAZ3vRbAuhx9kO8BHCpEj0ingg2fRnucMEC/6kOx2xwNtytStxKQi4cZNs/DD1KymRdmcb0g2ph7owgw6JRLmApyeAa2ZnCX5eeu/68SSx/gFM6BKa3BQ5zXM0vfx4lN4ME1qhzFaMki+biIs3OCb0cc+X7JyKz+XLaFwPnhxZCEMtKuZxsTc0ii+42NAQ1jXHCcR13AQEmtk1S+UQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0QJG6lUHRRR5Bx3rjh8fSAN00goQWZPELfVy7v1+b2g=; b=g/wBM+R9+ZkxQuGJKz3t0XsQmgoqtv4unBhXtsDFuYVQOCtT6PoYIc8d+lDKLs1R/nzGmeI1sP+jS0qsrIc/wJ+Vn6gWbyhPbOE/g2QIyHPtN1srAUWlASiXOB9kDsaVH8kJVRzbcVxVKG//j0N/haM1FhMSvxOb53tkC6vHEUN9eus6m+AiwytXFUoX+Zz2Ra4gwa76jjRJrnH65CS0+/0t1Akro21zwKFzNUS9xDjuGhzgsiZIv5t1UhqscMMue+o8Ic4JnvZCIFNLqyq84xpTf4qDpn23baGPnv5EXmyo1ASPSu1YpxqdjfVBbK053eO8obraiLlP8a8S4bpOJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0QJG6lUHRRR5Bx3rjh8fSAN00goQWZPELfVy7v1+b2g=; b=UH6MZl/7vnBdf6aVCu16GgQjyT+zxKhJay8+ci9v0n4HwmQ/eQj5URgn/9VOxuHqwfE533HUeRAEn5r67Ebb/FzvuW4cKGGCYQ+amPJ39jBbGMtLbswX/2gTBDA78+DwKj8WeAxGhlgQwISAW4fvsBNCXW7DjYGINGTeZAJjVqs= From: Bertrand Marquis To: Jan Beulich CC: Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , Wei Liu , =?iso-8859-1?Q?Roger_Pau_Monn=E9?= , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH] x86: fold sections in final binaries Thread-Topic: [PATCH] x86: fold sections in final binaries Thread-Index: AQHYLUowkdMxBaiHpEebmldzPiiqI6yqOnQAgABL34A= Date: Tue, 1 Mar 2022 13:30:02 +0000 Message-ID: <915C7BBD-AD0C-42B8-8459-C3BFDCDC0A11@arm.com> References: <03851bd4-9202-385f-d991-c9720185c946@suse.com> <1a4bef81-d29e-97ae-098b-d1e582e5af28@suse.com> In-Reply-To: <1a4bef81-d29e-97ae-098b-d1e582e5af28@suse.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3693.60.0.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 4ca02b7d-64c8-4a41-4abe-08d9fb879be1 x-ms-traffictypediagnostic: PAXPR08MB7245:EE_|VE1EUR03FT035:EE_|DB8PR08MB4571:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: A1QqoG3aaBOUuf4YgpBSZ+utEUR0jBmDrc3LuWEngNGLG6ID2n7w9MLdIj42I4OP+f9PINDNUYHk1KFBVVv4miGtp2csMu9PkWbeJWpfVrr4uZkcoCZ4eBjBSaJg5t0I1HYLy0QgtKR/xk4lvSDL9O3KcsXVrXomkRsxbx5PxDLCwC5+1AsE8XtvEUk3Or91v6AxwMev6t70ExzF/rzBO/sb81vi4ZlHmmSfR/Tw1dgUoEwdbi7EavrDeLWfdIdvFJVWQKLayMm4LgsSjX0N7QkBNScOdkfYJuDUT9K3IF9yvtTs6GfsiawEGwnoV7WIrnqUdvoaZdT8OSnqdhk6+Vw8uuexXXwMvcwtQY1gLw+RLiVVQkifYAxIR7uNd9EVrE5HFzIcoODjEAXhWnmXJeKySUVAS8kdTsfqWCX4qEfr9XEBs8jR1vzI4RvmLWoc0Uc9MisGrZ3hDWZSD4Fge3AHKPlNLU0MR0JD3MQ2biBkl7vXnVuPUJDm8gnvKXJRO6ODG5HeMki930EtU8fKy9Iw5+n3XekR2s3rxeayDi6q1fvfCbroacsVMjyIBO9vK9Zfl9ghAyIfLa1AQf5YD0vMu2asDFy72DLAgRgDlRLi7j5JhtCNYoMBAfLHVuVFu4vMGKE3QjjBIE3lo8y/Dr4eS3kA0Qx7OcLGgNrdL/EiogXHJ2Yu6OwcV9PrE78itf1w6UZSv6EJQZ0ne3do0HohXFP66NbdRdYz2V13SegamthCkh9kTcbCMzOvij8r X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3778.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(36756003)(122000001)(83380400001)(2906002)(38100700002)(6486002)(8936002)(5660300002)(6506007)(91956017)(64756008)(6512007)(76116006)(38070700005)(66946007)(66446008)(66476007)(66556008)(4326008)(8676002)(33656002)(316002)(26005)(186003)(2616005)(6916009)(54906003)(53546011)(86362001)(508600001)(71200400001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-ID: <980D511F3F5AE34189FA3120E4E260AA@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7245 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT035.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: bef005c9-bb6c-48a9-3569-08d9fb8796f6 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Xt5I6Ik8BZ2ciksmoBn7YvBvBp6ZTO6QfMWlfcvHtCCqz4/wCqYl2NSdDlT3p+0TmmWQPpNpPV1ABD2EV1huX8TlHV6qt5jkaUW7xtPGmFRbgnIlEq7D8KIJ6BzmqXu48ypgsgw07SnXoW9u7Lu4d7VYYM9x6/ByR/P5/6AoThw6pKSxBUHdEzxur/asiTVJ5CtuXS628J7CC1zXC1SM1dotFcDSFHGgwZ0WlQj1nczjlRGHNcKAUT7xUcW65YV/aOXSC+uLLfB5QoBMlHmTf8bWjTpfBbzZJ41MAi8MHJ00wlwkkwRtGqdzEou2n4VkF9dIS5W5l5LmP7l6HwhZYwuPdi7oBd67tEHqIsMM1FYsiafNPENewzABBlabcsBt8+1Ym37+q9ywqzKfAw7Zx6yEx/MhDfYPpVFqAWbH4ZV1irIB1gNQt36JiHnkO8+PzviOsKVMIyDJZ9GI+uDakyCvW9mtJ2s27bFOHT6DtD+1J2NcK0nW/YQvc4qIl39wyMu7BZp8qwbYKFNi2lXwVi1YgTJupKeD2VFFJPAoI7sO/2JdTEM37NupR/udaf0ZdCNbCw21XiFSd6avEWduKkVyz1Cx3CQXnOlk6IVf67Z4JNOOQVZMGuaCsdHobQ/yJGzsS3goTPrvLSghSaEO9uMKRJxUxuSndfHyBQiIEKiQ16YnovFKyYWZSev2YZcw X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(36860700001)(8936002)(47076005)(5660300002)(2906002)(81166007)(356005)(82310400004)(40460700003)(6862004)(2616005)(6506007)(508600001)(8676002)(6512007)(53546011)(4326008)(316002)(70586007)(70206006)(54906003)(6486002)(336012)(33656002)(83380400001)(36756003)(26005)(186003)(86362001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2022 13:30:10.2932 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4ca02b7d-64c8-4a41-4abe-08d9fb879be1 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT035.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB4571 Hi Jan, > On 1 Mar 2022, at 08:58, Jan Beulich wrote: >=20 > On 01.03.2022 09:55, Jan Beulich wrote: >> Especially when linking a PE binary (xen.efi), standalone output >> sections are expensive: Often the linker will align the subsequent one >> on the section alignment boundary (2Mb) when the linker script doesn't >> otherwise place it. (I haven't been able to derive from observed >> behavior under what conditions it would not do so.) >>=20 >> With gcov enabled (and with gcc11) I'm observing enough sections that, >> as of quite recently, the resulting image doesn't fit in 16Mb anymore, >> failing the final ASSERT() in the linker script. (That assertion is >> slated to go away, but that's a separate change.) >>=20 >> Any destructor related sections can be discarded, as we never "exit" >> the hypervisor. This includes .text.exit, which is referenced from >> .dtors.*. Constructor related sections need to all be taken care of, not >> just those with historically used names: .ctors.* and .text.startup is >> what gcc11 populates. While there re-arrange ordering / sorting to match >> that used by the linker provided scripts. >>=20 >> Finally, for xen.efi only, also discard .note.gnu.*. These are >> meaningless in a PE binary. Quite likely, while not meaningless there, >> the section is also of no use in ELF, but keep it there for now. >>=20 >> Signed-off-by: Jan Beulich >=20 > Some of this will likely want mirroring to Arm as well, even if xen.efi > there isn't produced by the linker. Sections are better properly folded > even for ELF, and constructors not ending up in [__ctors_start,__ctors_en= d) > can surely not do any good. I fully agree with that and it would make sense to do both changes together= to avoid differences between x86 and arm unless required. Right now our discard section on arm is a lot shorter and I do not see why = we would need any of the sections that are discarded on x86. As this needs testing and checking I do not think it makes sense for you to= do that right now. @Stefano and Julien: I am ok to create myself a task to sync with x86 in th= e next weeks/months, what do you think ? Cheers Bertrand >=20 > Jan >=20 >> --- >> TBD: We also use CONSTRUCTORS for an unknown reason. Documentation for >> ld is quite clear that this is an a.out-only construct. >> Implementation doesn't look to fully match this for ELF, but I'd >> nevertheless be inclined to remove its use. >>=20 >> --- a/xen/arch/x86/xen.lds.S >> +++ b/xen/arch/x86/xen.lds.S >> @@ -194,6 +194,7 @@ SECTIONS >> #endif >> _sinittext =3D .; >> *(.init.text) >> + *(.text.startup) >> _einittext =3D .; >> /* >> * Here are the replacement instructions. The linker sticks them >> @@ -258,9 +259,10 @@ SECTIONS >>=20 >> . =3D ALIGN(8); >> __ctors_start =3D .; >> - *(.ctors) >> + *(SORT_BY_INIT_PRIORITY(.init_array.*)) >> + *(SORT_BY_INIT_PRIORITY(.ctors.*)) >> *(.init_array) >> - *(SORT(.init_array.*)) >> + *(.ctors) >> __ctors_end =3D .; >> } PHDR(text) >>=20 >> @@ -404,16 +406,20 @@ SECTIONS >>=20 >> /* Sections to be discarded */ >> /DISCARD/ : { >> + *(.text.exit) >> *(.exit.text) >> *(.exit.data) >> *(.exitcall.exit) >> *(.discard) >> *(.discard.*) >> *(.eh_frame) >> + *(.dtors) >> + *(.dtors.*) >> #ifdef EFI >> *(.comment) >> *(.comment.*) >> *(.note.Xen) >> + *(.note.gnu.*) >> #endif >> } From xen-devel-bounces@lists.xenproject.org Tue Mar 01 13:34:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 13:34:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281446.479776 (Exim 4.92) (envelope-from ) id 1nP2du-0002kw-Su; Tue, 01 Mar 2022 13:34:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281446.479776; Tue, 01 Mar 2022 13:34:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP2du-0002kp-Pv; Tue, 01 Mar 2022 13:34:18 +0000 Received: by outflank-mailman (input) for mailman id 281446; Tue, 01 Mar 2022 13:34:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP2du-0002kj-14 for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 13:34:18 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4a3f27dc-9964-11ec-8539-5f4723681683; Tue, 01 Mar 2022 14:34:16 +0100 (CET) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05lp2175.outbound.protection.outlook.com [104.47.17.175]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-29-mqzv5cn1N6yqZRKOEcfAzA-1; Tue, 01 Mar 2022 14:34:15 +0100 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by AM7PR04MB7061.eurprd04.prod.outlook.com (2603:10a6:20b:114::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.26; Tue, 1 Mar 2022 13:34:13 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.027; Tue, 1 Mar 2022 13:34:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4a3f27dc-9964-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1646141656; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=p1AyWg0vwPItKSSz0+s8cP9t1+6GAd0LD25hIoGPo7w=; b=akQ5s24Lx7WYuerwDgFXC8daBDy117MiZCHWMeSviW5/uBYFSy9qnD++gN0LFcQWS1UUyU yOG8aChBZEjMmttXalWR0hXDlO7Dneunl+d1B2iavU0BmHPA86sx+WVVha2CLbqG3qCWHr 04sRUXtHXcvz/43mQgAIDXjPjgLIs/o= X-MC-Unique: mqzv5cn1N6yqZRKOEcfAzA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aePV97E8tc2RxVczVqwKFVsApN1okvUpt5ID1HyAP3fZnav5d2mtpeQra7Xiu6E1K7gWERYZd5BHItcoM+B3dZXR7YCyO5HSyj4XgTn+ziepCfIsZ7QRSRy4dK+3f8JPEXJ5VeYF9io27+hl+kX2+uw/7dwufeB6CMkPZtq9kxlz6d3Half20mWab7RA7ejiwXKksXMp4SHqjRcUfgHQHBQJORZ8qBGZRTCAH7j4IjRYiLtwSe8myXMRa2K0Tqz9za10SO5AUK6ZJoVXzxIsmoFnGfq4SNMIXJUBZKKiOys6wpxceBjMiOqAoALI8VXLLZqk+3diULai+9u70B+f2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=N4ApPAC8cZm8fRq41lmYjfGFw5DqEZ5qWgmha3HlxGo=; b=AF0IcW32fTSwzbd0Fj4Ap1i6CyEA7zgmtsdFotDIiiRNLMLMNmP8hkIpBW2IoS3myboOFIJGsULQcRkDVdOg10x2mrqK9lMeC4QeaV0yFHC5RHtijXsnJos0bHUXDnquW1Gn+pIan/ceum93Zmu/khuuojxu+/EoHEoVb5bwIEzRP4Hm2n1y1jBBVvhVJLs2Qmzc3PveHciBRdYiJ2EZA8tuDNKG78Z+N8xU1Fg3iaSyA/FBTHURdBCqB/7Q9mrt9V6nY0oaDmqrRcKT80BTHuLk8xjZLsCyxMJYhwdZlY6AazcuqS4IUPsbyZKrWt4qsNXLR8CKH7m73Lv4TGf1/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <06452eab-653b-458a-048b-cc709151353a@suse.com> Date: Tue, 1 Mar 2022 14:34:11 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH] x86/altcall: silence undue warning Content-Language: en-US To: Andrew Cooper CC: Wei Liu , Roger Pau Monne , "xen-devel@lists.xenproject.org" References: <0e3594ff-c637-46f2-bc95-7a26b5471b86@suse.com> <40306bc7-f61c-d330-0ec7-d986e4711d88@citrix.com> From: Jan Beulich In-Reply-To: <40306bc7-f61c-d330-0ec7-d986e4711d88@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS9PR06CA0070.eurprd06.prod.outlook.com (2603:10a6:20b:464::21) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f8294b98-c379-4f69-e660-08d9fb882ca4 X-MS-TrafficTypeDiagnostic: AM7PR04MB7061:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Fb8lPPWHgC2gxWvypA85/C4uTbPx8cs+39yt6i5PdFk6SBqSyqLixbDjRx1UWQSGbfGIWyZmtQNYviljOPLbsjMVcf9BXfHwyOqr2mePEchD2qWvTGccy3+KnT+XAfG+iOdgCODEFZ1ZFjyLyqZARV5jjj+zQSHgCzoUBkudmeYAgOsiqi5FQfH7wy+qsrkEvan9pNrVlC01dzRa+2VB2rqDkbV/CBhh+ZYc/Slz5fQzzOuky9X2DDrmT38iK9dWvXLgr9NAPF1uKeqc3ZIIWXwDfUlp59bHFS5vNwvg8RVUUgkjHQNzEPI1yXToE6+AyxmivOWn6U7VhRsMaNdPCzh4QqBR9gNTgxAvFSp4ccxcaQZ33qxQtXOwIO/a4on2F+qCsjYxU7mQR/pfoNhpv7thBGTCAouF97892jkQQOnawIdC76bQ3s6HOR4nJrlrV1yeVmvcBY8kChl9U1Qh2vthyfW5A340201VexDtCL2q+mbLpyg7fiFd3IeKRWDHFGi4N/2i5RjDN+S2iXpT4CsLDRB6j2aZWT4K65LTX5XL664gpQ+CXN/T4yJtK4K/XxwpTSHUJhBoes8VCCSr4j0B8QLBHlBuGu+5VTjs1+EdMDOM606+0MrsmGbSvVaqpGrzjgS6+FFDmrzuaQcZ1eBBtdg9Yljb7a3oaWc/pJ4TEVivUF/jusXK6+mMmG0R6FVjaGxK76sq+4iex9pCGvd+r70cQ/21ahSrBzjO66g= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(26005)(31696002)(53546011)(2616005)(186003)(6486002)(66946007)(66556008)(508600001)(6512007)(86362001)(6506007)(316002)(6916009)(54906003)(38100700002)(83380400001)(8936002)(5660300002)(36756003)(31686004)(8676002)(4326008)(66476007)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?QylmcOEI0Zjj+sYx1ZZFYAyMNEGS5XlWHysaySX5PDjx7ZOKWEMu6UQhdFSz?= =?us-ascii?Q?XI/9ryw3PpWZmcOYrakIayz4luWANZf5AAqcWl9GKyq32x21sNUrqOAF2Asn?= =?us-ascii?Q?s3JUOtKYPvvmBONYLplr9feUU08wOGO3a4IdRs7HE+yoepinKjQuDF1Bq5vN?= =?us-ascii?Q?ICy2CPHMj+ICCGo08V2q5j/iB2xL7ne1Cde/d5dEqk7vysQUswE60elRwhvW?= =?us-ascii?Q?bcdUvccHeWl00fhNuTJFhZHOx85YjWrmG1FZSm5JwfDrYx9y7BwIW63ILd81?= =?us-ascii?Q?WjuGUTF20bMIgt/XcAIDl4mxwjZwRRzeAIMdB8p/dKqkNqB9zAvL9i4L3mlx?= =?us-ascii?Q?LzgmTNjSbhzN/iOGvHoaE+eULT8bj0Xn8p3kwK6U2xADdkT3d+Gl520yYWrS?= =?us-ascii?Q?1kBc6JLecnGyLVJfQMbAHWzpEP5kQMQ+Zqkzvame0i1X1yMVFZPdxA9hnbbO?= =?us-ascii?Q?4BiE4DjhfgiZhVD8MnigKanvXuqVZ9L7eeCVx2nuCT2BQWQB2EC5QWQBrX/v?= =?us-ascii?Q?NxNKGXQHHqcrnMHF52rXa1nLhLoum9rxwH4lTYz1K1ywQEC/7DYsw0xwKRnq?= =?us-ascii?Q?1Cn/tyvNqt14iUF4Q6hOWFIie4wNqgICtWfd8/hyoGFMC8qdWNkZz2iaRpkL?= =?us-ascii?Q?WiSdpfc4u6k9jqKihNlOfv+OcujcwKor5N+NtFrjQU/MADvep+jU5fNUijzp?= =?us-ascii?Q?6kyUSJhNHW14v/RZGb43QhGr6OOjP8agYWuo07aahCwBNzoMi6AOxOQUP/ow?= =?us-ascii?Q?7VAVy1V0ct2OOAHWmpjy7AltPVz822e2UyyD7LcQ5KHFk06i3Y4spVePGrXA?= =?us-ascii?Q?7yYpQbGOBexwdayucnhE7QH7BRPkeEq7b71HTiTQU4LSyhPYp4LHWWCovTAT?= =?us-ascii?Q?kJVy81m4GuFov3blxHXBF1wZ9F3EA/PbhJFLenNjQphcAj9hAG8ut5+r9g3E?= =?us-ascii?Q?jdo1S1xiLoAzcGAttXXOzjeDbChnZQf9e2PO6Fnj3ANP1fxAR4ScBZlf39Cd?= =?us-ascii?Q?a9E3aVYmzPyArzbaIvPJsD2oqwIjLXunInvQeTTGIYSMrZVm8ddhihyo2L8M?= =?us-ascii?Q?KNKwztYagvnRk9Wbw/OXPmMtI1WaKmI6JoersDCK9Mje2YK6MNS2plWED9g2?= =?us-ascii?Q?INwOCVR2siZJek23gy2HrFVTLfnm7tUbuUGU/OVMXG4hrJ5xcr4N51MiX8qa?= =?us-ascii?Q?GxoMQHGrXQ7aIzw05RAwQVZw/7w394lLZY+Vm3IPDEogZv4b0p4kpBAu5Kju?= =?us-ascii?Q?kBHKY0AzOm23vKkyehLfNhChW1a2BfCqzC1t7QqL+YiXEemMIF8FwWFUkqoO?= =?us-ascii?Q?QA1VXHJa/bbdyE2uNnbGrDEAP6kdyu5rpJD09izTSCjECY1G9MFSHXus4/tW?= =?us-ascii?Q?FvkEKAa+PANNWjUoXzKPeC2bbY28ch41vaINorNP+YqiP87UTf9WnfX8Qd9W?= =?us-ascii?Q?I+7mg3MUf6wLIysFRtIDjObPYRCyT74inWeXPu42j6W5PZhMuMRl2RxNJ13o?= =?us-ascii?Q?8pw9TAusjO+ZrEYJDHOmcvgBL1hkhJ0t6xqwDvU+J4kptTzBV0Mf7mx2gf1U?= =?us-ascii?Q?vy6/owJp1PVIn1bmLEfKQ9LFipejKlnh8jI2CkdDKVr3zgacwJ/0FEoEfkFQ?= =?us-ascii?Q?RhwnVt72VmLA6TNJC3bVSs4=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f8294b98-c379-4f69-e660-08d9fb882ca4 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2022 13:34:13.4951 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: H40kgJ+gKrWehKTnylnE9EuK/lye1fRH+pc7PWUWzEKWEhHEvegjYG/MgN4HLDCv9GdvuftYYle2l4qJjibn/A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB7061 On 01.03.2022 13:48, Andrew Cooper wrote: > On 01/03/2022 11:36, Jan Beulich wrote: >> Suitable compiler options are passed only when the actual feature >> (XEN_IBT) is enabled, not when merely the compiler capability was found >> to be available. >> >> Fixes: 12e3410e071e ("x86/altcall: Check and optimise altcall targets") >> Signed-off-by: Jan Beulich >=20 > Hmm yes.=C2=A0 This is fallout from separating CONFIG_HAS_CC_CET_IBT and > CONFIG_XEN_IBT. >=20 > Reviewed-by: Andrew Cooper Thanks. >> --- >> Furthermore, is "Optimised away ..." really appropriate in what >> 37ed5da851b8 ("x86/altcall: Optimise away endbr64 instruction where >> possible") added? If this really was an optimization (rather than >> hardening), shouldn't we purge ENDBR also when !cpu_has_xen_ibt, and >> then ideally all of them? Whereas if this is mainly about hardening, >> wouldn't the message better say "Purged" or "Clobbered"? >=20 > I did have an RFC about this.=C2=A0 Turning ENDBR into NOP4 matters, on a > CET-IBT-active system, to restrict the available options an attacker has > when they have already managed to hijack a function pointer (i.e. > already got a partial write gadget). >=20 > From that point of view, it is hardening. But then you don't say whether there's any optimization aspect here. My question was really about the wording of that log message. > The first version of this logic was trying to use UD1 in the same way as > Linux does, to harden non-CET builds too, but that does depend on having > objtool so all direct branches can have their targets updated to miss > the UD1 instruction. I think it would be possible (but likely cumbersome) to arrange for this also without objtool. > P.S. I'd still like to have "away %u of %u endbr64's".=C2=A0 It occurs to= me > that now we have check-endbr64.sh, we could `wc -l` the $VALID file and > re-link this back in, but then we couldn't check the final objects. I was thinking about this wish of yours as well; I simply didn't know how important you view it to have this information. Not being able to check the final objects is not an issue: If the data is available after the 2nd linking pass, contents of .text isn't going to change anymore. All addresses are the same for the 2nd and 3rd linking passes. Hence if the checking was inserted between these two passes, the value of interest could be propagated suitably. Jan From xen-devel-bounces@lists.xenproject.org Tue Mar 01 13:34:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 13:34:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281448.479788 (Exim 4.92) (envelope-from ) id 1nP2eC-00039z-5y; Tue, 01 Mar 2022 13:34:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281448.479788; Tue, 01 Mar 2022 13:34:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP2eC-00039m-1x; Tue, 01 Mar 2022 13:34:36 +0000 Received: by outflank-mailman (input) for mailman id 281448; Tue, 01 Mar 2022 13:34:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP2eA-0002kj-Iy for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 13:34:34 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-he1eur02on062f.outbound.protection.outlook.com [2a01:111:f400:fe05::62f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 53cf0a54-9964-11ec-8539-5f4723681683; Tue, 01 Mar 2022 14:34:33 +0100 (CET) Received: from DB6PR0301CA0038.eurprd03.prod.outlook.com (2603:10a6:4:3e::48) by PAXPR08MB6621.eurprd08.prod.outlook.com (2603:10a6:102:dc::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.25; Tue, 1 Mar 2022 13:34:29 +0000 Received: from DB5EUR03FT057.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:3e:cafe::98) by DB6PR0301CA0038.outlook.office365.com (2603:10a6:4:3e::48) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.25 via Frontend Transport; Tue, 1 Mar 2022 13:34:29 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT057.mail.protection.outlook.com (10.152.20.235) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22 via Frontend Transport; Tue, 1 Mar 2022 13:34:29 +0000 Received: ("Tessian outbound 63bb5eb69ee8:v113"); Tue, 01 Mar 2022 13:34:29 +0000 Received: from 04de89535d06.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 73D7EB47-4B57-4FD0-8C4E-D7860382F7C8.1; Tue, 01 Mar 2022 13:34:23 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 04de89535d06.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 01 Mar 2022 13:34:23 +0000 Received: from AM5PR0801MB2020.eurprd08.prod.outlook.com (2603:10a6:203:4c::14) by AM6PR08MB4358.eurprd08.prod.outlook.com (2603:10a6:20b:b6::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.24; Tue, 1 Mar 2022 13:34:21 +0000 Received: from AM5PR0801MB2020.eurprd08.prod.outlook.com ([fe80::253a:4d6c:61c9:af60]) by AM5PR0801MB2020.eurprd08.prod.outlook.com ([fe80::253a:4d6c:61c9:af60%10]) with mapi id 15.20.5017.027; Tue, 1 Mar 2022 13:34:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 53cf0a54-9964-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hmgvc60Lh7JtbNghknVL20rXiMusarbxrZ8AuH8JKHE=; b=OGczUwGvCIAeL95yLZyKqfJH7mrgz2yFw9oEFcW4q99clIG7g3JMos2a/k9ir36eY/jO6LS3UtiOprv7EAA7HRGJdpOSGmRsyatEQStmw1Pw/JPuc1Wrw3D+ur6PXDo4noD/D6Ap13il7fu6z5sxxqxtHpeqG12qCnRYUAFCRDE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: c10a95bd88a7f45c X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K7XtmzoE/f7ZMVGKS+DEk+MV1vJpagBPYVxIazIGZHchrZhCo9Dx00/gNwuQsRCGmpUTJXo8YfFttP1Km4Qucum2IdjahgMoJIRGx+Dwz0CjQcw/3Gb/NGYeBycgj3w05GzEEYBkzX+T/ZrKqfWR5Kcewv6ban1+pPgzQR79Dgn9BLbIzhBkKn3Ij2QxQWKFiUJkOBsmm9aYXqxGMmRHA2dGqpMbAL2c1/rDFwZ92smEht4A2Omgdej7fchmc68teHpb2FjWSPJa8LX2xfUdA4BomeeGtLqDz+GHf7hnV1glt9O/41gAwtN2P7zFA2j7pdBe+LRzEDkk04hGGFYU5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hmgvc60Lh7JtbNghknVL20rXiMusarbxrZ8AuH8JKHE=; b=F25Q7tPRC2uOXhnsgoS7hb/iZADpm/wI6GBl+JbljNQEL5OC5JBZJGVS21YEK+ME4AYeCdlKyh0V9eHpG6hDESJBK6iJ4C+U/3gfRMf9b6ND39aPT2xcxP3Xg64FwSeTxp8by2jBCSw4Rzpw6AGSFReUgNUWEWn0kTO/FOsCzW7RCrwIxw99wN9Y6rNwChJLxuXeuako0wsU4GXf4vMWNAaDecqjKTmujAunGARleHuxcrHIqcieDN5KdpmFaUZda1WVAeSeZcdesfRK7CguqeN0WwmEVHsjYH2EXnGnLBuW8dOg0Jd1T1mH/y9H+c7N87g99TY0dDB0zl2g8Qq3LQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hmgvc60Lh7JtbNghknVL20rXiMusarbxrZ8AuH8JKHE=; b=OGczUwGvCIAeL95yLZyKqfJH7mrgz2yFw9oEFcW4q99clIG7g3JMos2a/k9ir36eY/jO6LS3UtiOprv7EAA7HRGJdpOSGmRsyatEQStmw1Pw/JPuc1Wrw3D+ur6PXDo4noD/D6Ap13il7fu6z5sxxqxtHpeqG12qCnRYUAFCRDE= From: Rahul Singh To: Jan Beulich CC: Bertrand Marquis , Andrew Cooper , =?iso-8859-1?Q?Roger_Pau_Monn=E9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH v2 1/3] xen/vpci: msix: move x86 specific code to x86 file Thread-Topic: [PATCH v2 1/3] xen/vpci: msix: move x86 specific code to x86 file Thread-Index: AQHYIoBoEZVl6/zkE0mK7dGMpvA2Zqyi2K6AgAfEbQA= Date: Tue, 1 Mar 2022 13:34:21 +0000 Message-ID: <6BFB9B87-D8A1-442D-B4DC-18760C59D7BF@arm.com> References: <4d2a727ba218468e4f347dc12ca051a0534fe205.1644937405.git.rahul.singh@arm.com> <6e188f87-7e4c-00ee-dd0c-373d42acec34@suse.com> In-Reply-To: <6e188f87-7e4c-00ee-dd0c-373d42acec34@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 5865d4d0-cc34-4371-1a39-08d9fb883651 x-ms-traffictypediagnostic: AM6PR08MB4358:EE_|DB5EUR03FT057:EE_|PAXPR08MB6621:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: OyK2OrzoQgCm5hcAPGB/R5k1aXXlVDI+WHT1GKFqyrU0wnkThYPU0jMlIW0rxfOUFB1gZjb8EifWnIujDRlT1bIY8rBHY8CELpHHdVQGjgUAEUe12lh2r7sKttWSViZ/dGHQdmvSatZezt7/zKR2TfrLYWFp0vy520NGo3EdsLey/uddSChNz2zllrXwjEaw3XlRv3gpnJu9XXv1TiDtOZ5KZd1KmJQ/t0iQGs6wxGRRlJrC58H1hWF7nGBZ6i0AwJX9aGpwg69iWkF/UN4QVPaskAu1CTXHPTQErwmSX+JxUucY2kvwP5OKgC9jrEzdfr4Nvaeu0P7DSAf7vMQcJe0GQGdcfi+SfLUakFjGyu6VlwGZfapJTAs+FKLsFh6mydKieiSm2s26Q08HhMpPyjJpxckvsZGtz2iKLKKvfECBOSjgmhZgyrW/UKbTcsmOEqG6onNfuHJEDU03BHkm8xU696e/QKs8WxKG9EJcMMGzL3PWmqT2IsM5kCmmkb8HQ59+RYcpxB9iWMSuA7tj3GTYOuW9ut2rG2k5T/NXcRFgaSjlIEkQGFJVJf8OSQMRXKsglElovkfu8XdMjA7CY+QqM0W5L9OLvp8fN5zn3nXNElOM9k99SYwKaFcK5/FWgqHRTvj2i80ssvk8EsMtiyAQhS7ANg7wgPcPdN+dMMb6cbdjeOhyY54GAQcQYnGLziq5Bkg/+CCRiSAKsANgDyti77zOVHsLf7GRvY8MGIQqHyfFkRn8QYZZr/TOyFY+ X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM5PR0801MB2020.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38100700002)(122000001)(83380400001)(5660300002)(6916009)(54906003)(66556008)(8676002)(4326008)(66476007)(66946007)(76116006)(66446008)(64756008)(8936002)(316002)(6486002)(2616005)(91956017)(26005)(186003)(71200400001)(508600001)(53546011)(6506007)(6512007)(33656002)(2906002)(36756003)(38070700005)(86362001)(45980500001)(309714004);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-ID: <0EDF91FBADF737418CE667B814D5C657@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4358 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT057.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 2990341d-51e6-44f7-1dca-08d9fb883183 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ixJWVEext5MWUO0B9L4ZvM8GitHIz3g6/fUCHLNxJuyEz0cyzZdADV5zxg4XPzhWDPhaGX12pNEgbdnHq8Kh0jAbMLzbe325hTag3Xen78GUTYg1vNZA/4EWwfCHm/E2Mbqv23cQmSnOph5qv2qLgHjllhssVH3+B0ikbqZiS3hSqYdNq9c3VUhX0DHhPV9r5vLLtuyj16Y148Ybv+ohEsC+Wv7M+MkgjzR29/Dr3AIhLKxRv+fKNTJPXqHKuZpYiuxFK/7Ng1yjwZJxRX3qO8YUVf23+O+GNP0G0GLZbltIb+Cgb8hJM+klFcfMuUTJkZLgM2j1c8BcHn/AdNOiUXR9fVv/aBuJI+XjCV/UcR1JisjFZ4VsDroHlzALrBqtwcab44moCmPvnwp4Jb9d5/IdTLk86OGqpy3Zaru84xMnGDUkoVTC+mv4CgdneBdt8x19k5OHIHu+8iXw0Uabn0duKwHE1m8ufAYQqid6k0vc3OwjdeytJJP4VDsiPsoIGvIbr/PGIlA+obWkHSGY6cAWIpiu7g9CcNT1QKED/+hmx0kukrqN/hkEqX0Ekjoa7PQjKdH8f4rl8WPdsS8K+7Twmi8CY4PrGqDTofeYl01JdfgQNuS/IS/uIz34PqyUE3TO4GNisrBbKndIK2V//Fm125hc6CuDO/IsSvH0acUS1F5LbnlBVXBjJUbBsmReHuRUvt/nQ+3JIRUqJ2VGsQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(86362001)(316002)(5660300002)(2616005)(6506007)(336012)(8936002)(82310400004)(70206006)(70586007)(2906002)(33656002)(26005)(186003)(4326008)(8676002)(36756003)(53546011)(356005)(81166007)(6486002)(83380400001)(508600001)(54906003)(36860700001)(6512007)(47076005)(40460700003)(6862004)(309714004);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2022 13:34:29.4954 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5865d4d0-cc34-4371-1a39-08d9fb883651 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT057.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6621 H Jan, > On 24 Feb 2022, at 2:57 pm, Jan Beulich wrote: >=20 > On 15.02.2022 16:25, Rahul Singh wrote: >> vpci/msix.c file will be used for arm architecture when vpci msix >> support will be added to ARM, but there is x86 specific code in this >> file. >>=20 >> Move x86 specific code to the x86/hvm/vmsi.c file to make sure common >> code will be used for other architecture. >=20 > Could you provide some criteria by which code is considered x86-specific > (or not)? For example ... Code moved to x86 file is based on criteria that either the code will be un= usable or will be different=20 for ARM when MSIX support will be introduce for ARM. >=20 >> --- a/xen/arch/x86/hvm/vmsi.c >> +++ b/xen/arch/x86/hvm/vmsi.c >> @@ -925,4 +925,106 @@ int vpci_msix_arch_print(const struct vpci_msix *m= six) >>=20 >> return 0; >> } >> + >> +int vpci_make_msix_hole(const struct pci_dev *pdev) >> +{ >> + struct domain *d =3D pdev->domain; >> + unsigned int i; >> + >> + if ( !pdev->vpci->msix ) >> + return 0; >> + >> + /* Make sure there's a hole for the MSIX table/PBA in the p2m. */ >> + for ( i =3D 0; i < ARRAY_SIZE(pdev->vpci->msix->tables); i++ ) >> + { >> + unsigned long start =3D PFN_DOWN(vmsix_table_addr(pdev->vpci, i= )); >> + unsigned long end =3D PFN_DOWN(vmsix_table_addr(pdev->vpci, i) = + >> + vmsix_table_size(pdev->vpci, i) - = 1); >> + >> + for ( ; start <=3D end; start++ ) >> + { >> + p2m_type_t t; >> + mfn_t mfn =3D get_gfn_query(d, start, &t); >> + >> + switch ( t ) >> + { >> + case p2m_mmio_dm: >> + case p2m_invalid: >> + break; >> + case p2m_mmio_direct: >> + if ( mfn_x(mfn) =3D=3D start ) >> + { >> + clear_identity_p2m_entry(d, start); >> + break; >> + } >> + /* fallthrough. */ >> + default: >> + put_gfn(d, start); >> + gprintk(XENLOG_WARNING, >> + "%pp: existing mapping (mfn: %" PRI_mfn >> + "type: %d) at %#lx clobbers MSIX MMIO area\n", >> + &pdev->sbdf, mfn_x(mfn), t, start); >> + return -EEXIST; >> + } >> + put_gfn(d, start); >> + } >> + } >> + >> + return 0; >> +} >=20 > ... nothing in this function looks to be x86-specific, except maybe > functions like clear_identity_p2m_entry() may not currently be available > on Arm. But this doesn't make the code x86-specific. I will maybe be wrong but what I understand from the code is that for x86=20 if there is no p2m entries setup for the region, accesses to them will be t= rapped=20 into the hypervisor and can be handled by specific MMIO handler. But for ARM when we are registering the MMIO handler we have to provide=20 the GPA also for the MMIO handler.=20 For ARM arch vpci_make_msix_hole() will be used to register the MMIO handle= r=20 for the MSIX MMIO region. int vpci_make_msix_hole(const struct pci_dev *pdev) { struct vpci_msix *msix =3D pdev->vpci->msix; paddr_t addr,size; for ( int i =3D 0; msix && i < ARRAY_SIZE(msix->tables); i++ ) { = =20 addr =3D vmsix_table_addr(pdev->vpci, i); =20 size =3D vmsix_table_size(pdev->vpci, i) - 1; = =20 register_mmio_handler(pdev->domain, &vpci_msi_mmio_handler, = =20 addr, size, NULL); = =20 } = =20 return 0; = =20 } Therefore in this case there is difference how ARM handle this case. =20 >=20 >> +struct vpci_msix *vpci_msix_find(const struct domain *d, unsigned long = addr) >> +{ >> + struct vpci_msix *msix; >> + >> + list_for_each_entry ( msix, &d->arch.hvm.msix_tables, next ) >> + { >> + const struct vpci_bar *bars =3D msix->pdev->vpci->header.bars; >> + unsigned int i; >> + >> + for ( i =3D 0; i < ARRAY_SIZE(msix->tables); i++ ) >> + if ( bars[msix->tables[i] & PCI_MSIX_BIRMASK].enabled && >> + VMSIX_ADDR_IN_RANGE(addr, msix->pdev->vpci, i) ) >> + return msix; >> + } >> + >> + return NULL; >> +} >=20 > Or take this one - I don't see anything x86-specific in here. The use > of d->arch.hvm merely points out that there may be a field which now > needs generalizing. Yes, you are right here I can avoid this change if I will introduce=20 "struct list_head msix_tables" in "d->arch.hvm" for ARM also.=20 >=20 >> +static int x86_msix_accept(struct vcpu *v, unsigned long addr) >> +{ >> + return !!vpci_msix_find(v->domain, addr); >> +} >> + >> +static int x86_msix_write(struct vcpu *v, unsigned long addr, unsigned = int len, >> + unsigned long data) >> +{ >> + const struct domain *d =3D v->domain; >> + struct vpci_msix *msix =3D vpci_msix_find(d, addr); >> + >> + return vpci_msix_write(msix, addr, len, data); >> +} >> + >> +static int x86_msix_read(struct vcpu *v, unsigned long addr, unsigned i= nt len, >> + unsigned long *data) >> +{ >> + const struct domain *d =3D v->domain; >> + struct vpci_msix *msix =3D vpci_msix_find(d, addr); >> + >> + return vpci_msix_read(msix, addr, len, data); >> +} >> + >> +static const struct hvm_mmio_ops vpci_msix_table_ops =3D { >> + .check =3D x86_msix_accept, >> + .read =3D x86_msix_read, >> + .write =3D x86_msix_write, >> +}; >=20 > I don't see the need to add x86_ prefixes to static functions while > you're moving them. Provided any of this is really x86-specific in > the first place. >=20 Ok. Let me remove the x86_ prefixes in next version. MMIO handler function= s declaration is different=20 for ARM and X86 therefore I need to move this code to arch specific file. >> +void vpci_msix_arch_register(struct vpci_msix *msix, struct domain *d) >> +{ >> + if ( list_empty(&d->arch.hvm.msix_tables) ) >> + register_mmio_handler(d, &vpci_msix_table_ops); >=20 > This is perhaps the only thing which I could see would better live > in arch-specific code. >=20 >> --- a/xen/arch/x86/msi.c >> +++ b/xen/arch/x86/msi.c >> @@ -20,10 +20,10 @@ >> #include >> #include >> #include >> +#include >> #include >> #include >> #include >> -#include >=20 > Just like you do here and elsewhere, ... >=20 >> --- a/xen/drivers/passthrough/amd/iommu.h >> +++ b/xen/drivers/passthrough/amd/iommu.h >> @@ -26,6 +26,7 @@ >> #include >> #include >> #include >> +#include >>=20 >> #include >=20 > ... I think you want to remove this now redundant #include as well. Ok. >=20 >> --- a/xen/include/xen/msi.h >> +++ b/xen/include/xen/msi.h >> @@ -3,6 +3,34 @@ >>=20 >> #include >>=20 >> +#define msi_control_reg(base) (base + PCI_MSI_FLAGS) >> +#define msi_lower_address_reg(base) (base + PCI_MSI_ADDRESS_LO) >> +#define msi_upper_address_reg(base) (base + PCI_MSI_ADDRESS_HI) >> +#define msi_data_reg(base, is64bit) \ >> + ( (is64bit) ? (base) + PCI_MSI_DATA_64 : (base) + PCI_MSI_DATA_32 ) >> +#define msi_mask_bits_reg(base, is64bit) \ >> + ( (is64bit) ? (base) + PCI_MSI_MASK_BIT : (base) + PCI_MSI_MASK_BIT - = 4) >> +#define msi_pending_bits_reg(base, is64bit) \ >> + ( (is64bit) ? (base) + PCI_MSI_MASK_BIT + 4 : (base) + PCI_MSI_MASK_BI= T) >> +#define msi_disable(control) control &=3D ~PCI_MSI_FLAGS_ENABLE >> +#define multi_msi_capable(control) \ >> + (1 << ((control & PCI_MSI_FLAGS_QMASK) >> 1)) >> +#define multi_msi_enable(control, num) \ >> + control |=3D (((fls(num) - 1) << 4) & PCI_MSI_FLAGS_QSIZE); >> +#define is_64bit_address(control) (!!(control & PCI_MSI_FLAGS_64BIT)) >> +#define is_mask_bit_support(control) (!!(control & PCI_MSI_FLAGS_MAS= KBIT)) >> +#define msi_enable(control, num) multi_msi_enable(control, num); \ >> + control |=3D PCI_MSI_FLAGS_ENABLE >> + >> +#define msix_control_reg(base) (base + PCI_MSIX_FLAGS) >> +#define msix_table_offset_reg(base) (base + PCI_MSIX_TABLE) >> +#define msix_pba_offset_reg(base) (base + PCI_MSIX_PBA) >> +#define msix_enable(control) control |=3D PCI_MSIX_FLAGS_ENABLE >> +#define msix_disable(control) control &=3D ~PCI_MSIX_FLAGS_ENABLE >> +#define msix_table_size(control) ((control & PCI_MSIX_FLAGS_QSIZE)+1= ) >> +#define msix_unmask(address) (address & ~PCI_MSIX_VECTOR_BITMASK= ) >> +#define msix_mask(address) (address | PCI_MSIX_VECTOR_BITMASK) >=20 > Why did you put these not ... >=20 >> #ifdef CONFIG_HAS_PCI_MSI >=20 > .. below here? I will fix this in next version. >=20 > Also the movement of these is quite the opposite of what the title > says. IOW this likely wants to be a separate change. Ok. Let me move this change in separate patch in next series. Regards, Rahul >=20 > Jan >=20 From xen-devel-bounces@lists.xenproject.org Tue Mar 01 13:40:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 13:40:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281462.479799 (Exim 4.92) (envelope-from ) id 1nP2jg-000507-Tg; Tue, 01 Mar 2022 13:40:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281462.479799; Tue, 01 Mar 2022 13:40:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP2jg-000500-QN; Tue, 01 Mar 2022 13:40:16 +0000 Received: by outflank-mailman (input) for mailman id 281462; Tue, 01 Mar 2022 13:40:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP2je-0004zu-SF for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 13:40:14 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0604.outbound.protection.outlook.com [2a01:111:f400:fe1f::604]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1ee861eb-9965-11ec-8eba-a37418f5ba1a; Tue, 01 Mar 2022 14:40:14 +0100 (CET) Received: from AM5PR0601CA0047.eurprd06.prod.outlook.com (2603:10a6:203:68::33) by AM4PR0802MB2324.eurprd08.prod.outlook.com (2603:10a6:200:5f::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Tue, 1 Mar 2022 13:40:00 +0000 Received: from AM5EUR03FT029.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:68:cafe::ca) by AM5PR0601CA0047.outlook.office365.com (2603:10a6:203:68::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.23 via Frontend Transport; Tue, 1 Mar 2022 13:40:00 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT029.mail.protection.outlook.com (10.152.16.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22 via Frontend Transport; Tue, 1 Mar 2022 13:40:00 +0000 Received: ("Tessian outbound 1f399c739551:v113"); Tue, 01 Mar 2022 13:39:59 +0000 Received: from f9ac703d02b1.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 34767BB8-C71B-4241-B039-0B7209675DD7.1; Tue, 01 Mar 2022 13:39:49 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f9ac703d02b1.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 01 Mar 2022 13:39:49 +0000 Received: from AM0PR08MB3778.eurprd08.prod.outlook.com (2603:10a6:208:104::24) by HE1PR0802MB2602.eurprd08.prod.outlook.com (2603:10a6:3:e2::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.25; Tue, 1 Mar 2022 13:39:47 +0000 Received: from AM0PR08MB3778.eurprd08.prod.outlook.com ([fe80::4dbb:4fed:bc86:1803]) by AM0PR08MB3778.eurprd08.prod.outlook.com ([fe80::4dbb:4fed:bc86:1803%6]) with mapi id 15.20.5017.027; Tue, 1 Mar 2022 13:39:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1ee861eb-9965-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=o54D5Ouvu3ReLaYNHPl9bo5bDSn+jk5JPf3ZQyesVtY=; b=g0+WPbcV+TdBHnifaM0+LlHUVXpLvwfQ7firzUcZXNI1ZTgF4M6WoRiTFjB2hPwPeWaAvI/0JudEkD589e/kRbs7krc5bG7afHRVrUzt3iM17Gn1de1Qq6DZIVP4AOYKYCj5EBVCLDnsh/hBXdw56Y1C/IhGVtSTm5i9F+OALiI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 1b7deb144c4fe53a X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ABEosmYa8BbLW6jRK6lmNDMU7CIcDm7/KFcHHPxarsNYWpWQP63GuSi5UQbCSlhVFH+HerwcOsjMbVR403rOKb2FszbdQmWG85fjLU2yvIct7WbEPh4PZbuHG5TDUEZLTYrLCwmRFZhFmgKXgbzg1+Zk8PI0/N2e84xrlE1SdfRzSszqbwVWQYVxB1WOVRERL5C8+rekwBhHppN/IoR//OqrpmRVv/yDFhuiUopbO4RIc3F0tgg+fH8rals8COSAea2BZdmX+IWbThYY8usPTxCdTNXM+NcU0hgcDAAb3yr6oDl+96+IlU9FrvDYO6L3YlHT/x+qxvOojXvApw6Feg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=o54D5Ouvu3ReLaYNHPl9bo5bDSn+jk5JPf3ZQyesVtY=; b=Ddc9PFm8nWOTXRQdhtXJaIOT31eqEktkKxZEgW5YWfexDQKZZE2TOpZRAAvEhiJOI5Oq+yLjkGBVbVxoLSGyDyfCTKgjHWTQgCF0oSyyGKukEywnH8bxDu3DjnkDZIwEAX6amNjrH0olf5mrbC6bQ1g/Dm4ItxxrwJZOr3w7qQ67k1YMp7QqY5UQGfbpnrFhpbrzmrbm9RzGUyhbpqBeoVk8vF7fBKcLciNmJYTIhKKXF1WNzGu1EC0O7VEUiAt6zX5+par/MC37x6qZTJOGpRJOm8oBklNU+v7XeFQzYL1aHElHT2LaY2OC3HASx4Mogu4rKt8gJzqcZbqpwn5HAQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=o54D5Ouvu3ReLaYNHPl9bo5bDSn+jk5JPf3ZQyesVtY=; b=g0+WPbcV+TdBHnifaM0+LlHUVXpLvwfQ7firzUcZXNI1ZTgF4M6WoRiTFjB2hPwPeWaAvI/0JudEkD589e/kRbs7krc5bG7afHRVrUzt3iM17Gn1de1Qq6DZIVP4AOYKYCj5EBVCLDnsh/hBXdw56Y1C/IhGVtSTm5i9F+OALiI= From: Bertrand Marquis To: Julien Grall CC: Henry Wang , "xen-devel@lists.xenproject.org" , "sstabellini@kernel.org" , Wei Chen , Penny Zheng Subject: Re: [RFC PATCH 0/2] Introduce reserved Xenheap Thread-Topic: [RFC PATCH 0/2] Introduce reserved Xenheap Thread-Index: AQHYKR4hXoXrj++ew0mI1ZjbqpdQh6yktMKAgAPeNACAAMMegIABO0+A Date: Tue, 1 Mar 2022 13:39:47 +0000 Message-ID: <316007B7-51BA-4820-8F6F-018BC6D3A077@arm.com> References: <20220224013023.50920-1-Henry.Wang@arm.com> <6269ec3d-039e-d68f-771d-c5e088631410@xen.org> <48a0712c-eff8-dfc1-2136-59317f22321f@xen.org> In-Reply-To: <48a0712c-eff8-dfc1-2136-59317f22321f@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3693.60.0.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 2d4d3b6c-cf5e-4402-0fdd-08d9fb88fb5b x-ms-traffictypediagnostic: HE1PR0802MB2602:EE_|AM5EUR03FT029:EE_|AM4PR0802MB2324:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: wGSIFR8+r5hUX0kgNNngt9odj+fLJFKXQhp4+aK/u848YYdbrZ/N5LjrzmVQuDvdNh/ksQewSKsDXRcrJC8yIo4le21PPHGML+YK9lF73aF0dNsZVJM42jmEX1PJUuppl/eM96Wtk0gpVyqPMxKkWYVNVnJMvWiPgc2vr9XEXj4+ja5/++1lNTxeMpZy7xyizj52grnk+9Sk0GqZkjuXArRfeq7XCyEVYWTP9S8TrNSRIRLHyIsfGa03Ruo/9JsRX7J8zfvG3sQT9IWg5BIzh0iSoNEoZQXtQZyI/1LgQMQ5vzTROAi4+WMo3nFp3yWEIi7m7c3heR8hl9P3Z38Paub35m9XP22M4qoVWQ8zf0kZqwz88Dw4nr66sUMiIeqKpGcm4VtxPT9VbaPbIAWilWOdyrTilVz41INTh/IjndXdX8HhOfxLGcfHzbjemxHd5WcSEibvlmdSKbKKV2RDJ9oZenPS6zt+Qd75/BtSkQeZZNnpih+p7nenXikzIufzv7/ULxWWu8orapateO7ngfsrobgY8s0AQpJBWWuPWyYLndAcfWTsMeNIRnBMBwUpE1iF3i+p9gTjIdL9Rb12kLyi61x8ieUnZ7dwxDu2sNjWabfGpDn9Az6UpxWsE/EreDLmREYmRQSS+BlfkYTeerOZG88idO6515ZXPSzl/YdxNQGHgTNz+zuY1r+xCuINAtvdlTu1Ph+4qqlj2VjdOSIcHF5dOIodgyeSdA5B2Xw= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3778.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(53546011)(6486002)(71200400001)(36756003)(6512007)(38100700002)(6506007)(122000001)(83380400001)(508600001)(6916009)(54906003)(8936002)(316002)(4326008)(86362001)(38070700005)(5660300002)(2616005)(2906002)(33656002)(26005)(186003)(66446008)(66476007)(66946007)(91956017)(64756008)(76116006)(66556008)(8676002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0802MB2602 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT029.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: c354b0de-36b8-48ed-e5a9-08d9fb88f3cd X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Wy33sZjvoer/qDocw4lkA1MP5ixR00JXpJRKNNUiQcDW9OvusFR5cdtRAp7yB6AmEatpnAQEdVwx5k9f6zqL3PgJk7/L+obgqzdYYgXDLvcwCLOV0p6gpZzCy50rQMb3WyBkxd3VulNbYem2VA6XpBFnBo42/whyui0lO/1cOT2A8aoIhNjbaDxejDTzMY2qG3xtGr3lYFI+z8TI+PpbGinUOREAZL1Kwrr2btg+qXCNJzmNl3+GOcu8zRbQVQPESUSWYYHIF9Bqp6f5XkmKR+XxR2XFQU/9eYpURxxtTEtvG59mEOHFhnNaqVCpeFVY34vu///SlyaXy6a9Jntre+KcAMKxLtUMfyxDzKX/8M4Dyuw733//NX1+Xgtjoi0ijLCZerEY6jfaUc0DzieZJG8JYn+i0LawnQivoBJtT8jYeThQ9RCTXe+XoGQE47+dwYOH16rlJbPXADtYh8lV1lE4PISU8s0rmQEWqR8nsBIW8oaMAe08Pm9MZxc8b9zxzHbZuUREABqrzlIka+H+DPnRtsVsy0DVcHd3RAjD/oN1FXJRFkPBiy9lA88TAnZkxdyIZFR7B1vZQ8FkYN6pdQrh3ME64Kqi55nYPohvx+7CcfdC7VdTuWtcXYBzoc+6a/t5pXJJJIM83W8C4rj/BM6h5yoqixfmvCD2fLfGPfgxBAfWkTAcWYTKkYT2CAkw X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(336012)(186003)(26005)(81166007)(40460700003)(2616005)(83380400001)(47076005)(8936002)(33656002)(36756003)(5660300002)(2906002)(36860700001)(82310400004)(70206006)(70586007)(6512007)(6486002)(6506007)(53546011)(508600001)(356005)(54906003)(86362001)(8676002)(6862004)(4326008)(316002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2022 13:40:00.0183 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2d4d3b6c-cf5e-4402-0fdd-08d9fb88fb5b X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT029.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0802MB2324 Hi, > On 28 Feb 2022, at 18:51, Julien Grall wrote: >=20 >=20 >=20 > On 28/02/2022 07:12, Henry Wang wrote: >> Hi Julien, >=20 > Hi Henry, >=20 >>> -----Original Message----- >>> From: Julien Grall >>> Sent: Saturday, February 26, 2022 4:09 AM >>> To: Henry Wang ; xen-devel@lists.xenproject.org; >>> sstabellini@kernel.org >>> Cc: Bertrand Marquis ; Wei Chen >>> ; Penny Zheng >>> Subject: Re: [RFC PATCH 0/2] Introduce reserved Xenheap >>>=20 >>> Hi Henry, >>>=20 >>> On 24/02/2022 01:30, Henry Wang wrote: >>>> The reserved Xenheap, or statically configured Xenheap, refers to part= s >>>> of RAM reserved in the beginning for Xenheap. Like the static memory >>>> allocation, such reserved Xenheap regions are reserved by configuratio= n >>>> in the device tree using physical address ranges. >>>=20 >>> In Xen, we have the concept of domheap and xenheap. For Arm64 and x86 >>> they would be the same. But for Arm32, they would be different: xenheap >>> is always mapped whereas domheap is separate. >>>=20 >>> Skimming through the series, I think you want to use the region for bot= h >>> domheap and xenheap. Is that correct? >> Yes I think that would be correct, for Arm32, instead of using the full >> `ram_pages` as the initial value of `heap_pages`, we want to use the >> region specified in the device tree. But we are confused if this is the >> correct (or preferred) way for Arm32, so in this series we only >> implemented the reserved heap for Arm64. >=20 > That's an interesting point. When I skimmed through the series on Friday,= my first thought was that for arm32 it would be only xenheap (so > all the rest of memory is domheap). >=20 > However, Xen can allocate memory from domheap for its own purpose (e.g. w= e don't need contiguous memory, or for page-tables). >=20 > In a fully static environment, the domheap and xenheap are both going to = be quite small. It would also be somewhat difficult for a user to size it. = So I think, it would be easier to use the region you introduce for both dom= heap and xenheap. >=20 > Stefano, Bertrand, any opionions? Only one region is easier to configure and I think in this case it will als= o prevent lots of over allocation. So in a full static case, having only one heap is a good strategy for now. There might be some cases where someone would want to fully control the mem= ory allocated by Xen per domain and in this case be able to size it for eac= h guest (to make sure one guest cannot be impacted by an other at all). But this is definitely something that could be done later, if needed. Cheers Bertrand >=20 > On a separate topic, I think we need some documentation explaining how a = user can size the xenheap. How did you figure out for your setup? >=20 >>>=20 >>> Furthemore, now that we are introducing more static region, it will get >>> easier to overlap the regions by mistakes. I think we want to have some >>> logic in Xen (or outside) to ensure that none of them overlaps. Do you >>> have any plan for that? >> Totally agree with this idea, but before we actually implement the code, >> we would like to firstly share our thoughts on this: One option could be= to >> add data structures to notes down these static memory regions when the >> device tree is parsed, and then we can check if they are overlapped. >=20 > This should work. >=20 >> Over >> the long term (and this long term option is currently not in our plan), >> maybe we can add something in the Xen toolstack for this usage? >=20 > When I read "Xen toolstack", I read the tools that will run in dom0. Is i= t what you meant? >=20 >> Also, I am wondering if the overlapping check logic should be introduced >> in this series. WDYT? >=20 > I would do that in a separate series. >=20 > Cheers, >=20 > --=20 > Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Mar 01 13:42:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 13:42:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281469.479810 (Exim 4.92) (envelope-from ) id 1nP2lc-0005a0-9g; Tue, 01 Mar 2022 13:42:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281469.479810; Tue, 01 Mar 2022 13:42:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP2lc-0005Zt-5H; Tue, 01 Mar 2022 13:42:16 +0000 Received: by outflank-mailman (input) for mailman id 281469; Tue, 01 Mar 2022 13:42:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP2la-0005Zl-OA for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 13:42:14 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on061f.outbound.protection.outlook.com [2a01:111:f400:fe0e::61f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 66a805c0-9965-11ec-8539-5f4723681683; Tue, 01 Mar 2022 14:42:14 +0100 (CET) Received: from DB6P18901CA0007.EURP189.PROD.OUTLOOK.COM (2603:10a6:4:16::17) by AM0PR08MB5460.eurprd08.prod.outlook.com (2603:10a6:208:187::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.21; Tue, 1 Mar 2022 13:42:04 +0000 Received: from DB5EUR03FT024.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:16:cafe::bd) by DB6P18901CA0007.outlook.office365.com (2603:10a6:4:16::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.13 via Frontend Transport; Tue, 1 Mar 2022 13:42:04 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT024.mail.protection.outlook.com (10.152.20.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22 via Frontend Transport; Tue, 1 Mar 2022 13:42:04 +0000 Received: ("Tessian outbound 741ca6c82739:v113"); Tue, 01 Mar 2022 13:42:04 +0000 Received: from e39459335042.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7498BAF1-A7B9-4C84-A273-F72C58736038.1; Tue, 01 Mar 2022 13:41:53 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e39459335042.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 01 Mar 2022 13:41:53 +0000 Received: from AM0PR08MB3778.eurprd08.prod.outlook.com (2603:10a6:208:104::24) by AM5PR0801MB1938.eurprd08.prod.outlook.com (2603:10a6:203:4a::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Tue, 1 Mar 2022 13:41:51 +0000 Received: from AM0PR08MB3778.eurprd08.prod.outlook.com ([fe80::4dbb:4fed:bc86:1803]) by AM0PR08MB3778.eurprd08.prod.outlook.com ([fe80::4dbb:4fed:bc86:1803%6]) with mapi id 15.20.5017.027; Tue, 1 Mar 2022 13:41:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 66a805c0-9965-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l7+NjUtIl4PtuQwZtk4J6GpMswcXb9VYN05c0Y1IzzQ=; b=7FVaZbuiYq5Uml/8omSPN8vgoQcK81rdMR753/l+07uCQSn8MZYYi0mBQhNBB9bvGYCXYiSrZUTqd68uFEpENkbwnp0udHpSXxq5kobBKH/RjKXX1gfqGoIjeO504k/orltwyy9pqifZHg7GGKwK5LUOWFXxHxBrbZdXJso8eYo= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 434c5e17371c0bf4 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gfvXUOfQB1FtJc2fD/wR4pcc9MW6xp3IG7SsL6tyzYFHbgWQE1kwvs3j4o/dNblp8SktFyEqGEeslTO+laAQzcXMX7/VZjL8NircxpYBosbuAJ0yB6DmODd8M5Hrm5nDwG4T4vWjjOE4NY+9DbCa5cbemHf6Dk++LMYSzEYba5RGAUDMorB0l3TS48CVYcUIj1iqFUloZR04mmM96I28kVSsoV0Jlg6PpANJ4arLcNRA7fIxwKaGPHaWtikK9/HtPpx08jx/w7zphn7E33STav4JTlF7F5dcJP8X5YjYjjHtxoCKUEzJmNCP+qpM9JCwm4IzAnG8VZ2UcG4hqE8Knw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=l7+NjUtIl4PtuQwZtk4J6GpMswcXb9VYN05c0Y1IzzQ=; b=jSx+lcmEn7bWLI76bG14n2JpdV14ThzaEO4ojm7vtH/TOT/N4zYES5GQLGRkeaXFco8y2q/GDI9HrRXT7hKgK2W+F3ZWg5p2oWLFAfxIidJEgMACKJmUUxrrMWyxOL8roAVzt1It75fzjtoB4inSXQhMFy2+z+oCasN/v2aARc1m0LW9WhYhQv155WV8isouPvDTyEkuhpQR4ocqZ1W/QohfuG36EOpS5SBylpi5+GejFGpPZ7RF4AbY2kXLoQxH18lZGUhb5N9RTRzFET1lMR4/GP7mcl4sHRxQOMBnzZj3PNeHKCoCWl7gHhH6P0SR0BMyJbWyvCfxUDfbY2j8Uw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l7+NjUtIl4PtuQwZtk4J6GpMswcXb9VYN05c0Y1IzzQ=; b=7FVaZbuiYq5Uml/8omSPN8vgoQcK81rdMR753/l+07uCQSn8MZYYi0mBQhNBB9bvGYCXYiSrZUTqd68uFEpENkbwnp0udHpSXxq5kobBKH/RjKXX1gfqGoIjeO504k/orltwyy9pqifZHg7GGKwK5LUOWFXxHxBrbZdXJso8eYo= From: Bertrand Marquis To: Julien Grall CC: "xen-devel@lists.xenproject.org" , Michal Orzel , Julien Grall , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH v2] xen/arm32: head: Don't set r12 and update the documentation Thread-Topic: [PATCH v2] xen/arm32: head: Don't set r12 and update the documentation Thread-Index: AQHYLKgtSgsY3bUkq0KDQmgeSYVnA6yqiuQA Date: Tue, 1 Mar 2022 13:41:51 +0000 Message-ID: References: <20220228133536.57004-1-julien@xen.org> In-Reply-To: <20220228133536.57004-1-julien@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3693.60.0.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: db0658ff-01ab-4a3e-8490-08d9fb894590 x-ms-traffictypediagnostic: AM5PR0801MB1938:EE_|DB5EUR03FT024:EE_|AM0PR08MB5460:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: urG9u9MkH6bk74nbenzEnNotWncfAi9iCIy31oe4G4nvFAc1Mtkf7fDKCG9EHVEa2j+HjvES654/TdJ/dtpbC/nlEF35S108/8+A0gksdZNagSKs6CBWZTLQqs2ySjx5fr4+sg2OOQE/MAhdfT6Ot27eqT60XyctY1i3eAiH2JGcZlE4kcq/TJqR1jOp8BJuzmsZNl7VyqfwjCHWtQ692w62VhiMmaAhmO+rq/vIuWvsSIrFC5rrzfmJ4asneOweOYAV2da8UAC2nEUqdnIpHB19gLHUofj1GbZHA+QrO9D2Woo768qpdffn8yZuFhlpjr888kvW898LheMBx2ov8a7LD5ZIJXspkj52iq6KtSGcG1T7vyDceMtaKiIuSeG6SSX+/1gwQ9GT1SihbEqjkcKdEm2MiDSaycHRJrPFpOZqsHEd47Y34z3gsClHTtLj7wh+IVhkEvyGeqj04tz7AWfritkFg0D1HB1msMdTV3J8ip5mB1AAFH2VU5/1lXSD8zPWX7R6z0dzXng8Mtyk5Fa87Vy2zg8vyxOt3mlfjONX/13lGS47MSKcQ8GZpHEhJrBjTbHxCFjx1a1fZ0FMF7yyFFf94Ei/UcRdtOouBoGyQHCL1y/BEkAU39drzpaCr6vEKXsz8DH2glWX4HqNXkFKwPQaXFBGDzoesmBShRX1bQAb8TeUVF5JQXyTOMJyzywfpz6axyxN7oq9XJCYvahK7Mu43ySw9D5tt8dIwMY= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3778.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(53546011)(66446008)(64756008)(66946007)(66476007)(54906003)(66556008)(86362001)(5660300002)(508600001)(83380400001)(4326008)(8676002)(122000001)(71200400001)(38070700005)(6512007)(38100700002)(91956017)(76116006)(36756003)(33656002)(2906002)(316002)(6486002)(8936002)(15650500001)(6916009)(186003)(26005)(6506007)(2616005)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <466B31CA86310446BFEB74B70AFDD278@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB1938 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT024.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 3ca181af-f5fa-467f-9ffa-08d9fb893db5 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6fL3EEJ09M4B/sV7OaQsmi+enpSNBEjHUtqRxt1Z6MHDxs9rzaDDp+Kw2gvy201tbe/r4ytecbRt4ebhDwmAmLCLNqUxjp0+0I5J41htpi/s8FfUxHBDFfm0d3y2T5rp65frgZwq1tdFdRkLDVsZikU6JiKtpXBbybA5NSoRAzKNQkJ1rSxJf8Iun+rDrAld7cRbEV8PP+J7X/lzvut5wvLIZu98VSQUA6JbksWZhLm3uX/7oUT1+0YYz0OvUKJTL4Idu7h7iwO8FYWMR2J9ydu4Ik3fnM/lm1HdzE6Q544YB9ul+pTTGvN+hdPrSE0lCfEHEw9J8ABB9yo0jbV5E0T9HbCU3BA2RMOgJA7gJmTvcVcDFO7bQ9UwVNi9IWTp4okeW9YqW3VvAjDcWgEsRSvpEPw6YruxknpCpWDLJ/pT9VXuN9tFIHRqtq/B5twG7AAmf3AsnzuJXfuiQyoMdTzRv0sKZgW1t3dBSkokQVm7KKiYzdWASvZUZzxdN62z1TPj8nfDRsrNzk22u9RKWnxhPwoOBDaLxmH679D6u6A3xDcnCsGtO+/eNOWq9OxZvp9Ww6yPtVFtOdS2Zu7hRpMJTm5OqZDFECOYyYwccoNO8295CVuM/I8nYeFuZOcAp5eSwRGuVMta3bqJhvt+U0lM3Mp1UETw2c+flxX7u+m0koAjbeZGnQtNig1pKH6f X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(83380400001)(8676002)(6862004)(4326008)(86362001)(336012)(70586007)(70206006)(47076005)(186003)(6506007)(2616005)(107886003)(26005)(36756003)(316002)(54906003)(6512007)(53546011)(36860700001)(508600001)(40460700003)(33656002)(6486002)(8936002)(356005)(82310400004)(81166007)(15650500001)(5660300002)(2906002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2022 13:42:04.5751 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: db0658ff-01ab-4a3e-8490-08d9fb894590 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT024.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5460 Hi Julien, > On 28 Feb 2022, at 13:35, Julien Grall wrote: >=20 > From: Julien Grall >=20 > Since commit 54c4ae18d158 ("xen/arm32: head: Rework and document > launch()"), the boot code is setting r12 but not read it. >=20 > So remove the two instructions setting r12 and update the documentation > to show r12 has no specific purpose. >=20 > Signed-off-by: Julien Grall Reviewed-by: Bertrand Marquis Cheers Bertrand >=20 > --- > Changes in v2: > - Don't set r12. > --- > xen/arch/arm/arm32/head.S | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) >=20 > diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/arm32/head.S > index 13cfc837d39c..7a906167efca 100644 > --- a/xen/arch/arm/arm32/head.S > +++ b/xen/arch/arm/arm32/head.S > @@ -79,7 +79,7 @@ > * r9 - paddr(start) > * r10 - phys offset > * r11 - UART address > - * r12 - is_secondary_cpu > + * r12 - > * r13 - SP > * r14 - LR > * r15 - PC > @@ -166,8 +166,6 @@ past_zImage: > #endif > PRINT("- Boot CPU booting -\r\n") >=20 > - mov r12, #0 /* r12 :=3D is_secondary_cpu */ > - > bl check_cpu_mode > bl cpu_init > bl create_page_tables > @@ -206,8 +204,6 @@ GLOBAL(init_secondary) > adr r9, start /* r9 :=3D paddr (start) */ > sub r10, r9, r0 /* r10 :=3D phys-offset */ >=20 > - mov r12, #1 /* r12 :=3D is_secondary_cpu */ > - > mrc CP32(r1, MPIDR) > bic r7, r1, #(~MPIDR_HWID_MASK) /* Mask out flags to get CPU ID= */ >=20 > --=20 > 2.32.0 >=20 >=20 From xen-devel-bounces@lists.xenproject.org Tue Mar 01 13:43:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 13:43:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281475.479821 (Exim 4.92) (envelope-from ) id 1nP2mz-0006AB-LA; Tue, 01 Mar 2022 13:43:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281475.479821; Tue, 01 Mar 2022 13:43:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP2mz-0006A4-GZ; Tue, 01 Mar 2022 13:43:41 +0000 Received: by outflank-mailman (input) for mailman id 281475; Tue, 01 Mar 2022 13:43:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP2my-00069y-Cj for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 13:43:40 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 98772716-9965-11ec-8539-5f4723681683; Tue, 01 Mar 2022 14:43:38 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 98772716-9965-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1646142218; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=9JZVEUfUgVGCzGZwPMO7/BrprmBcSVATClbrT3NVFJQ=; b=PE6A/Tu/rOH4bkqj+fd9l1cU9d8UL2PCwG9Jfa5sSIgwXFlztsn3sXNn iNcRggFmi5cPfJ30Tn6ou2AsQuorTeLr7Ok1PQNzElHGUrZB2beZE+nc+ FCtFhaZbk8uPGrwkx61dDrOK6cwTXxJ+LwMERXbiOCj72OVdT9HcDPlVt c=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com X-SBRS: 5.1 X-MesageID: 64659634 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:/ofwJquaWf1FVU/KPHcCJuu69OfnVEBeMUV32f8akzHdYApBsoF/q tZmKT3UPqyJNDSmfdx3O4W0phhX7JXWzINgSgA+pCsxFXsa+JbJXdiXEBz9bniYRiHhoOOLz Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQyw4bVvqYy2YLjW1jV4 IuoyyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo Oihu6BcRi81GqDhodo9XyUBNCEhF/RlpIL3LCKW5Jn7I03uKxMAwt1rBUAye4YZ5vx2ESdF8 vlwxDIlN07ZwbjsmfTiF7cq1p9LwMrDZevzvll6yj7UF7A+SI3rSKTW/95Imjw3g6iiGN6AO 5REOGQ0MHwsZTVoH0dJLLUYgNyNmyGhWBB0+GqzmvAetj27IAtZj+G2bYu9lsaxbdpRtlaVo CTB5WuRKgEXMpmTxCSI9lqoh/TThmXrVYQKDrq6+/V2xlqJyQQ7ChcbSF+6qvmRkVOlVpRUL El8x8Y1hfFsrgrxFIC7BkDm5i7f1vIBZzZOO/Ee5Sy09IrY31++BjcuFx0dVewr7uZjEFTGy WS1t9/uADVutpicRnSc6qqYoFuOBMQFEYMRTXRaFFVYurEPtKl210uSFYg7TMZZm/WoQWmY/ tyckMQpa1z/Z+Yv3r7zw13IiinESnPhHl9svVW/so5IA2pEiG+Zi26AtACzARVodt/xory9U J4swZD2AAcmV8zlqcB1aL9RdIxFHt7cWNEmvXZhHoM66xOm8GO5cIZb7VlWfRk1bJ5bImG1O RaK6Gu9AaO/2lPwNsebhKrrVqwXIVXIT4y5Bpg4kPIUCnSOSON31H43PhPBt4wcuEMtjbs+K f+mnTWEVh4n5VBc5GPuHY81iOZzrghnnD+7bc2rnnyPjOvFDFbIGOhtDbd7Rr1ghE9yiF6Oq Ig32grj40g3bdASlQGMqd9DdQ1RdCNjbX00wuQOHtO+zsNdMDhJI9fawK87epwjmKJQl+zS+ Wq6VFMew1367UAr4y3TApy/QNsDhapCkE8= IronPort-HdrOrdr: A9a23:jMbR/KrAUsyYLpu2z99fdxwaV5oleYIsimQD101hICG9E/b1qy nKpp8mPHDP5wr5NEtPpTnjAsm9qALnlKKdiLN5Vd3OYOCMghrKEGgN1/qG/xTQXwH46+5Bxe NBXsFFebnN5IFB/KTH3DU= X-IronPort-AV: E=Sophos;i="5.90,146,1643691600"; d="scan'208";a="64659634" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K5vCUTK4EWu/UnquWQ3DFsn9FxKdTINpw/NZVoYMQQY4ueUXWCkSzJBBgt4noj6Wcxfu86v3oRY0LI+oRBEZn3qH+6u3P8fwYvPLe8Xczz4pbNDlvKGrW2DDPP5ipJUB6cpcew8xCMqGxksBT16OhMtt3nUmF7H0WFV2YlQTc1aBtWqKphdVkKupnPegr1wbRlFtIboAZ7hox1fHgyf3sAag4CSmGrVRZgDaoezWAXCNKMvt7GxMWnO2op6a+IF5RsnB2RKOxY+spO1utSzsfC46MQFESglCL42oo+XxSDQBGOuxpYYrCU5igWrONoE6b9RIKi0hrnUXhKTGhG9Icw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=o+SBL3Rf+ExGdrUo3Mmdpp8ZIwRGZZZeo7loAC7KyZI=; b=N9mueqtH94q+6VxnO44tWR1m/UVTE6lJsbv99Eog8RjS6NiKJajBwnHs65CEOYdQjsfnpq4qi3mduSruRJhVxuEfTxXcKrZu91Bh3OQ5l1AIgTNRigqpBfLoFh1EEEM006FPfYGthuMKnTYXS1ztEYhZsaXxHKLMGlFwmR0c7ZdPPzjJwoHHMWnbJORWLm6NQX0uHm5f1INsDYYH7DwOPAXYf8kop4J/+NjAKddlhbbyGvtqDdqODOR3OJwwefSEz8+CoygsGhf+L5X/79ileuJBYcEgWeWM8zplFQH7CNQOCVtXN//LOu7tI9EezVNOcJq6HCe51aRs27suqgseMw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=o+SBL3Rf+ExGdrUo3Mmdpp8ZIwRGZZZeo7loAC7KyZI=; b=Pn8bIl1j0R2dHJxK1QprR7646m1T/HwL8RSM8ldKlUVOjU3gsT9FpTk9cyWv4qNBmslcEnRFSaWVngxZTYAquEArEMetXJrQNsdaLBe7hB0OxCX5Nz6KGibwAtDynyo+pHmp9W784X5ZII0m26ItFLnLcUkya9j7Q+gU2Fq295g= Date: Tue, 1 Mar 2022 14:43:25 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich CC: "xen-devel@lists.xenproject.org" , "Andrew Cooper" , Wei Liu Subject: Re: [PATCH] x86: fold sections in final binaries Message-ID: References: <03851bd4-9202-385f-d991-c9720185c946@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <03851bd4-9202-385f-d991-c9720185c946@suse.com> X-ClientProxiedBy: LO4P123CA0353.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18d::16) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 02ff37b5-fa28-4d2a-eba6-08d9fb897967 X-MS-TrafficTypeDiagnostic: CO3PR03MB6759:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +lmaNazFV2ayhWd5/yWCljC5+BCswBgzWzYMjLUyyAYklrPeskIJ9NBrq4K+HgDY7tzxDyFx29IzOrUZCmmSBUhKOkKecxVcyDlCJuxzmtl/5D05cyronOdepgzBEYlmRGduE4iCdJChSgvKM8NS7cPhtpfxvosgiH7o9NKDNABguKPBI5rBw9c9QUIn63Jyl6IRqqbnBFx3QO0dt5zUD4mN+uWlN4+3DtaMrPgtuU/hw9sthww3eiS1Z9YP0SSr1YLUZve14MeJfK6ixGtMFO8pJ0rbeB8WMcK8MxAnMektjyQlneqja5cqY7rgTs/QPl7AZlSX42nCJlx5S73DXY5BfEUU0eAb3s4ZEDS+w7ZwdG0ondo9gNqGDSgxKYAsJXGeaF/otZqiWidmTrFuVlI0SlDeni8Wdlr5AVaxuRZIUr+UNSu3CAPbOinmMUihuZj9Dfk9UDysv6koLYVKCY74RtIPvplTbhAsPPLKLDeUk2pNLY3oB3B9wkR4l+5qYOkVwp199WtqeQwAuzWWTZf5boGEEiWv4s5f5uJ3ZwgV+U2JCQYjiFFKQWZO5RWs+XKlT5yl45zIZ3giY9F4g0AoG/lKZeC2Ct4WoaZ+h1ckQ6GqaljB0ppq5pWZ+sroSJYzqi7B6PU4QPDjL3/1oA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(6486002)(86362001)(66946007)(4326008)(85182001)(26005)(186003)(82960400001)(5660300002)(8676002)(66476007)(66556008)(8936002)(38100700002)(83380400001)(316002)(6916009)(54906003)(508600001)(6512007)(9686003)(2906002)(6506007)(6666004)(33716001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UDJub3RNb2dJclhna3gwblRyNGN0Y3hURi85aW5zbEw2TzN4S3puRDMyWWpP?= =?utf-8?B?cGtBY1FQR0V1NVlOZkdpMzM2czV3WVRxaHlmUk00aER1c1VyV3JBdktpbXJF?= =?utf-8?B?ZElaVE5qRzhjcENva2R6bTY2UStBTDZaZERQcGNyR0RJSXlka0FycVozOG9a?= =?utf-8?B?SDZ5ZkI1S1E0d1NGaWNSenNDM05ULzBKWFlSd2NPUG1JbTlHZi93VHBUSi9l?= =?utf-8?B?ZVB1cElDZVY2NExKeStRbTRNTmc5L0hZKzVXTzA2Y3ZRR1RaYmtsd3l3S1Bl?= =?utf-8?B?b09XdXhRcEw3cHZqT3NFd2E2YXhrVThHc1FBazUzSjF3Q09CYzZqVU5EczBi?= =?utf-8?B?eWRGZkpPbGFCYlBWVitTT1QzTDIvdk5jSDFBWWo5SyswSGI0T2RiK2NjTVE0?= =?utf-8?B?SUNSUHR4UUVWRCs3dUxyZ0RLSnlScWEyMFcxRUd4RHd2dE05eFU5T3dXazFJ?= =?utf-8?B?MEo2NlBUbXd5Y3N1aHhBRXVSRzU5dkxJWDJhYXNWUCttRXVnU2RvVEpIVWF2?= =?utf-8?B?TlBlZ2Y2RHJQT3lPVkxhbk9rdXJHN1lwYWRLYkJ0ekIrOVhJM2FTejByaU5X?= =?utf-8?B?SWF1QlNOemFwdHJpQ0xxc0o2VzZydFdFcUdEazJqSWo0R285MWxub0dsZjZB?= =?utf-8?B?ZUo5QTV1UGliOTVSK2VMd0VwZ09VQ2JGZ0dpWWs4cmM0SnMya3NKTWpTMW1U?= =?utf-8?B?MkpldG5jNGRya1FQUUF5NlREOWtGMXhBdHJSQmJqa1V6OE95Ull2Z3hwNWxk?= =?utf-8?B?RGtBUUJaMlN5U2pYQ0JWMG9vNDNVVUlyWlVIRXV6V1RoYjM0VEVPUnAzV2Jy?= =?utf-8?B?WmJjRGhKNW5EOVNjamRtWUFLa3d3SFNZWlVYbndGeDBLR0R1TnJ1Rk1WYU5K?= =?utf-8?B?YnBPeU82eFlqdWE0ekx0UDgyQkd5Qi83bkFGWVZqQ3FmOG16L3NkSnJrakZo?= =?utf-8?B?T0xMUzI3Nnd5U1hTei9nZGtkK1puejVxVjZ3U3lqVjNMQVUvUzhxelN4QUx0?= =?utf-8?B?cWpVT0VEbWpLSjhVVjVFTUNEUFRZZGhWdUt2amJCQ0djZkhNZm5KWkx4UjBZ?= =?utf-8?B?OG9DalFqa0F4V0VpZ2toMUdLaTZRVmhaUCtaM3AySXhEYk15QTRwa1cyTTBj?= =?utf-8?B?aVhVb3I0SUlGRjV3TEpSZlREU1YzeDYwbUc3cUNLTVE4VDZqRlFnKzRqZzF2?= =?utf-8?B?VHN2RXp4aGdoaUw5emtIT3lTQm9QdjJLTERDMVdTb0RzK1ZCVUJtZ0FDWmZB?= =?utf-8?B?TjRCV3c0eEtlQzdZT1NZODQyTW1zc1dkMnZRWWNicWozemhlNU5WN1Y2dStr?= =?utf-8?B?ZG9ESTcxbjZMNlZud3FQcCtzaCtHbFBoeStZbXVGZVo0YVZMdEh5Vzl2NFVl?= =?utf-8?B?RjU1dmZFMmVYL09WLzc5bzJUQjh4YkRleXhWUktxNVdHY2h4OWhONjZXaWNy?= =?utf-8?B?S1Q5NjMrcHdFREZMQ0ZJUXA3Vld4VzMxQVF5dHA5ZkhlVnFCK2JRcURSYVhP?= =?utf-8?B?MXpIWHF1SmlNc1gxd1dWTERYd3JMM0NSN0I5RzRZYnE2Q2hCRTZKek1Gekx5?= =?utf-8?B?N1krOTlDUVBUMlZrckJvL3RJT0gxcjZXYlhPZDNkcDdYdXMvYkRxQlZ4eTZ0?= =?utf-8?B?Si9yck8rd0NPM0ROSlp3ZXQ5QWF2SnB6anVabDZnejVDRGIwU1ZsWWJkR09p?= =?utf-8?B?WVJCemtBcjZGRnhJWVRVcTZoN0tCajFJT1haa1IxTm5RYjhBNHc0NXY3Y01T?= =?utf-8?B?bXVjczlKZ1h2MDZvYmlZZ09UcklWc2NaYlo0dWZMSGtMd0hNbzJFYThpV3No?= =?utf-8?B?NjZDMC91bDA5RlR5Zkg4YStpc2lqTUJiK1NTeGlVWTFQVitmK2xsV2R5TmVh?= =?utf-8?B?T3gzZWx1SkJMMm5NcUxPUVRzQlA1a3JnSVBjODlwaGcxRWRGUEVtVG5qOU0r?= =?utf-8?B?WmpUL044T0s2L1hlbXNvM25OeUIvUGhPd08ycjZTL1p5NlJCWk1EZVRnYnlM?= =?utf-8?B?OUh4NnNzSjhJL0lFT3VnVmY0Uk5sK1poeEE3NUlIR09hNm9TdElwYVZKdXlI?= =?utf-8?B?aFFzWmg0by90VnRtWld5bTU3SmQyR3FscGZqU3JXTUQrZFpLMktNbThxVjNM?= =?utf-8?B?VkpxMWJHaUpHNGorbUM5TXF5ZHN3dUhIc2t4Q0FjSkhCMHlIWk43S2U3M3VJ?= =?utf-8?Q?YcgpffDAZVpuU9ZNn0lGD1Y=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 02ff37b5-fa28-4d2a-eba6-08d9fb897967 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2022 13:43:31.7924 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Xs6VNexOsjE+HJKGnDKBukALbdY8JtfcWpeIH2B219IExjRPedXMdrEGIBGXMnVrHk6sZG7e4/6ldSnekxNRKg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO3PR03MB6759 X-OriginatorOrg: citrix.com On Tue, Mar 01, 2022 at 09:55:32AM +0100, Jan Beulich wrote: > Especially when linking a PE binary (xen.efi), standalone output > sections are expensive: Often the linker will align the subsequent one > on the section alignment boundary (2Mb) when the linker script doesn't > otherwise place it. (I haven't been able to derive from observed > behavior under what conditions it would not do so.) > > With gcov enabled (and with gcc11) I'm observing enough sections that, > as of quite recently, the resulting image doesn't fit in 16Mb anymore, > failing the final ASSERT() in the linker script. (That assertion is > slated to go away, but that's a separate change.) > > Any destructor related sections can be discarded, as we never "exit" > the hypervisor. This includes .text.exit, which is referenced from > .dtors.*. Constructor related sections need to all be taken care of, not > just those with historically used names: .ctors.* and .text.startup is > what gcc11 populates. While there re-arrange ordering / sorting to match > that used by the linker provided scripts. > > Finally, for xen.efi only, also discard .note.gnu.*. These are > meaningless in a PE binary. Quite likely, while not meaningless there, > the section is also of no use in ELF, but keep it there for now. Should we also use --orphan-handling=warn as to recognize orphaned sections and attempt place them? We have now detected this because of the 16Mb limit, but if we remove that check that we could end up carrying a non-trivial amount of 2Mb aligned unhandled regions. > Signed-off-by: Jan Beulich > --- > TBD: We also use CONSTRUCTORS for an unknown reason. Documentation for > ld is quite clear that this is an a.out-only construct. I've found some (old) documentation where it does also mention ECOFF and XCOFF apart from a.out: "When linking object file formats which do not support arbitrary sections, such as ECOFF and XCOFF, the linker will automatically recognize C++ global constructors and destructors by name. For these object file formats, the CONSTRUCTORS command tells the linker where this information should be placed." I guess we can get rid of it. The patch LGTM: Reviewed-by: Roger Pau Monné With the possible addition of --orphan-handling=warn. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue Mar 01 13:55:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 13:55:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281485.479832 (Exim 4.92) (envelope-from ) id 1nP2y8-0007tR-Ke; Tue, 01 Mar 2022 13:55:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281485.479832; Tue, 01 Mar 2022 13:55:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP2y8-0007tK-HW; Tue, 01 Mar 2022 13:55:12 +0000 Received: by outflank-mailman (input) for mailman id 281485; Tue, 01 Mar 2022 13:55:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP2y7-0007tE-9h for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 13:55:11 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3522f487-9967-11ec-8539-5f4723681683; Tue, 01 Mar 2022 14:55:09 +0100 (CET) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05lp2108.outbound.protection.outlook.com [104.47.17.108]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-24-g4GYUZhOO-2VLYetR-Y6fA-1; Tue, 01 Mar 2022 14:55:08 +0100 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by AM0PR0402MB3714.eurprd04.prod.outlook.com (2603:10a6:208:f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.25; Tue, 1 Mar 2022 13:55:06 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.027; Tue, 1 Mar 2022 13:55:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3522f487-9967-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1646142909; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QJMu4YL5jAQhiUJ7KcDsX49vB3plU9GmSJbM8enSqx4=; b=iHXohUYMk5qr+MOBFrIl69WXdz++FZr0RN/SPCt/Wa7fX6mfPFrj9jdmOjkmtb5FrLnBhz N1omTy6O3U5qliezpgLgwf2srvZ5wwL5bxjgRE2GLOf76FpRUhjiiyS1CEd9arcqOH3sds Wh/9TwLImOQLGf+1QVGngdBamx1+EAM= X-MC-Unique: g4GYUZhOO-2VLYetR-Y6fA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YZU1seUnjKSy0/eEwLMOBtlemWGhU0vV/tNMnJXDWlyjY0JcYGULLCxQMul3ozReqMfl5YcGHXpmLtsKMBY5nbIUdbOT79VKto/UscRtj4DT+acLktmTCp5T4u4+WtwC4XF49i+csZEQvBMDtETcljY3YYW/H0Bj8EGF9WQll/4AJx7Uhs1KJ2kMJWtsLChf204RFdiBoSeP6Slt3rFQTjcXaEHm7AVBO7WQDo+lSIDuvyjds3+NCoMqq7wKJDeSvFHCOQ4UJFQVoY0mDw0JAZqFHjzyaH+sktIRLqbJbhvAactk6a/Ha32LJ//XpkRltUIeby5+LJpLhgKmxfs5fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QJMu4YL5jAQhiUJ7KcDsX49vB3plU9GmSJbM8enSqx4=; b=NGJKWjS6F/ROmPhoP7yDgPDt9szCBljPzJptFsStbpM8O25L81aeuOxJx5FaDHLlaOJB2N1nJF83vbs0TS6V9S+IMmPfE0M15gr/jXWFKqqst0mOOY0ClflM817rClV20YsBqyk7b0MV9Ev8VsIPfVtSYqIvr86y5l3NA48Lapv58CbVqJZooaLTz/i58gYITQrjDE/KywD8l1peYYRF18c5BUZ4inBv3OdQx6cgTVjABUovUE8ChIEZOLa4kv4gRce1wclYDjt0pe+CW6eGBnKA72HHoG+/8V4KMCGp//3vzFOnUSTbVewdeKuDVTFjZ3i5ubeVHb8jg0K7W9wnFw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 1 Mar 2022 14:55:04 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH v2 1/3] xen/vpci: msix: move x86 specific code to x86 file Content-Language: en-US To: Rahul Singh Cc: Bertrand Marquis , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , "xen-devel@lists.xenproject.org" References: <4d2a727ba218468e4f347dc12ca051a0534fe205.1644937405.git.rahul.singh@arm.com> <6e188f87-7e4c-00ee-dd0c-373d42acec34@suse.com> <6BFB9B87-D8A1-442D-B4DC-18760C59D7BF@arm.com> From: Jan Beulich In-Reply-To: <6BFB9B87-D8A1-442D-B4DC-18760C59D7BF@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6P194CA0091.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:8f::32) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d3b8f420-77ae-432c-1125-08d9fb8b179f X-MS-TrafficTypeDiagnostic: AM0PR0402MB3714:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qHEHguYB9/S8blyyKipJ3ZT6v6DnHDVYdthvcjRnXQxUKfpmZUyqULcG0tL0+AG8Ob1JBBxUOcV/77K6I/j6DV9kdrmMaj3V4rBfYYZAivQuz3dhAkeXmDB6qGrYzalGQwLehR/q9n2J4eIP7yNcwHmIYGFscXdIr7zmydfRLorCT1ybXxzL97MlQtaMXGFrTPF3ayuHQ8auBEprpxwog+qd4cg9eUs27QaS/O8DZk7G8MKSgaUUTYFoJftLw4uXf13E/nVlaDDeyDW0NUpjC9ZY9Z8f2sLibGzN74pp6z2drNKQacCdLHWpNQnl4n88XvRXrAT7rmhbKf2qRd5FKi+O7AEjroGf2wiv4wWXzxUlO4fAitFrOATxlF/GfWjw0zcXpyIAlGWIhBYQK2IxJDse+rRZH8oifHECfFu7TfMmDIvvYipDNaPTSMCB+ZHlywU4VE9U+PZL0U11drR6VDF/fgRSj052hvL5WTArsJJ8yMaYh5Q+m6NtCLwXNAqDerqCbM69sB7xWVM3DvpwGHHHHQffEY2wAu/ACpX4y9jFIsDFsipNVoqqeWzEcKi8+8h4AQK8O+QGBe1jJKglea5O2eASxZ5bmQ4kqVnVccwmCURlE26tCQxn8dQtpYgQtN4J1cFJxszTyhjgE29dcKLpU4adhyJK3P8em1BPYpi9nRZ6pc+7iiGh1m2CqjJ37gTaCCBg6YV4MNTUubZ2Agxznx56x1JDL7/XdG5sPoe0OnPByg0yVDZE1tn/jUuR X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(508600001)(36756003)(54906003)(31696002)(6512007)(6916009)(6506007)(31686004)(8676002)(66946007)(66556008)(66476007)(83380400001)(4326008)(316002)(86362001)(53546011)(2906002)(8936002)(5660300002)(38100700002)(6486002)(2616005)(186003)(26005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U3hsMndZQ0ZCbjFrT1prK1lDQjdGTHBQMy9CZVpuWjZDZVhSTTNYZHQ0RGlW?= =?utf-8?B?bGRtMmQ5YzJpZEQ0eXdZN1diczZSdzBPOG5LVjdmSHdLQzgrY0d0bEhvUVA0?= =?utf-8?B?emxsVCsyaHZMbUFzMFpKOFliKy9naHdiY2pNT3J0eklsM1ZmMXFDSW1iYXFV?= =?utf-8?B?anp0WmlGaW1TenByNHpMM1ZqZ1dLUG9iY1JGTHd6SGFsa2c2aHpNT1U1OFFF?= =?utf-8?B?N3RFb0laenN3NytFZ3FoazNHaDY3WWw5QTg0UytEMkpXdzlkODkyOVZNNjNz?= =?utf-8?B?a1JPaE12RHdmQjJGS21NaklOQnBwc2F1TEJYcDFJYXl0SjROZmtYckhYcjly?= =?utf-8?B?b1pqakxPRzRpSkRtVUdZUTdUaE5oc2FKUVh0cVpuRGljZHZMUmx6UEdXMXRC?= =?utf-8?B?azRvWHd0anJYblo0N29wcWRvZmZHS1BxY0FVQ1E4YjVON2lMUFRqbDhMRnpP?= =?utf-8?B?TG1IM1NVamZobVlsenVVUnNaQksxVXlrZTE3dStOZnZ2MENnN2s1dzBHMkRx?= =?utf-8?B?VExHV2IySzA2TG9Nc05YbmVvOWRNY0NvSE1FYWc0UTc0ZjNOZWxOUzUwQVpQ?= =?utf-8?B?dzRkNmhyUnZXUWt0QXIyQW5WUndsbnlRSVZQeTJ0aHR1M2Z2b0w0L0ozSVdi?= =?utf-8?B?V0l2UW1QT2h3OU4yKzNqa2VvRytFZmMzSTQycytzY2hqekxsRklZTmJTaGNJ?= =?utf-8?B?VDQvWTBHVFpkc3BvSjZKN3N3bHh3clZ3VngvdU80SVFBNSs5NUdvYm5UcTMv?= =?utf-8?B?NlJnOGpINzlaZnUwTmxaNjUyQkRKWkxaYXhtOVR4Nk53SWNjazJaWU1SNVh1?= =?utf-8?B?SFFVbFY2YTlpdy9qczlSYTJKS1lrS21ONG9wTTVQTXpaSGs0YTN0NEJRc3NU?= =?utf-8?B?dWdVNlVsVU9mdUVGMmdQQjdzYnBlbktkVU84MUFhWUQxTjU1RHVUSjM4M0pi?= =?utf-8?B?QzJaR21tYXVpVnBobDhncVZaLzRISHRiOWZuM2tRWG5wdDB6T1VxRjBKOFA3?= =?utf-8?B?OEpDQ2gvOUVSUHpOYjFjem10R3BnbnRNQ0U1YnphUThkdmd1MXY3OExFaG9W?= =?utf-8?B?SDVlRWx4alhzaGJhVisxM1RWYzFEbVUvcVZ6RWp1WXhmVXl2b1hPY09uUnZZ?= =?utf-8?B?RUNNN2RTMjNobEw2UEFUSjFTY1pid1dRZFR3bTJxQU83VzA5MWJMdGR5aUNB?= =?utf-8?B?Q2NWak1kenpPYWJ1bjBBWXNLMThudlIyOFlaWExLc1ZxSmFlQWhMeENJU3hs?= =?utf-8?B?OUhtdW5HbXVGUmh4czd4dXd5TmFNM011ZDVXU3RGR2xjdTZkTGNZSVFjWmRN?= =?utf-8?B?dVRyU2ZjTERVcGRPaWtIalV3NzI0N1JadXRqUExYVTRhVnE0M0JLMlBGR1JN?= =?utf-8?B?eUdsNUkyYWFJekZETWk5WUY0RFpMT21TWHNMU0J0M0ZsMjJ4M3dhb3dCc2Js?= =?utf-8?B?dTcxdEVRNzJxY0V0dW9HQlFPK0pvaUpPOVNLWHIrSFMrdlRFcUVuZ2NrMmJ6?= =?utf-8?B?MkFtdnQ4QVhzYlU4bEtVOTh4QnFRTDh6K2l5WEtIWDRHNUJVZ0JIbzQrSE1j?= =?utf-8?B?VDBSNVZZMFp4K3ZneU1sM05WQzY2K3M1VGJ5Wm9vZGd0OWxnNFNzSGNmWk9W?= =?utf-8?B?ZDFKR2hrR1VwY0lSRG04U0NzOGRocFVIajZkai9aeCtPTEpFenJ3ZUR2V0Z3?= =?utf-8?B?emN6L2hUZC9sTm5GcTNabWhKdlc2Q0ZmVG9wdWJhdGs5STduL1FsbWpJOXlm?= =?utf-8?B?VHN2MXBxSy9Da2dPQmpyM1Z4U29aRUlCZk4vRUdEWUVRUVlFaXhPQ0Y0eG0v?= =?utf-8?B?V1hySTF3dlNzbFpoT3lLb1B1aDdlMU5sNFdjZlhCMkpHbTNjcVBFd3h2RVVG?= =?utf-8?B?OW9kTVVFSC93RFVlMzVWb0tCR1ZJbkZaVGI3d00vL1E0K2xNLzdQeHFPSmU1?= =?utf-8?B?eDN4cDRMS0JKc0E3NXR6N3paNGYyTFN4TE5UOG83anNNK0dVQ3Q4ay9tcGhF?= =?utf-8?B?VkFtZkdoMVR6a05XZTNDcnBxbytYWHd3V2xnVjZYb0xzSUU3OU5MWElkSGpv?= =?utf-8?B?STFvdWZ6MDFPWkV3SEhoQjlsa0pvTG51ZFZCTEtVSXVRdWdNRm1tam8wOVNF?= =?utf-8?B?c2FWYzFwZDJmZW83b0N0UWsxYUpMNHJWMkFyRHhuRDVxWjFvdGl5b0psaWs0?= =?utf-8?Q?Z0DlzFwXa6tPZrgW890ljXU=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d3b8f420-77ae-432c-1125-08d9fb8b179f X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2022 13:55:06.6680 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +1dww6YaTWYp5b7hdbKRvacSO7SEx4EqA4ljq6N8RYDC6XQozc6UdhDIoz+w6AeG16vSScgbREpPOp2E6Up18Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0402MB3714 On 01.03.2022 14:34, Rahul Singh wrote: >> On 24 Feb 2022, at 2:57 pm, Jan Beulich wrote: >> >> On 15.02.2022 16:25, Rahul Singh wrote: >>> vpci/msix.c file will be used for arm architecture when vpci msix >>> support will be added to ARM, but there is x86 specific code in this >>> file. >>> >>> Move x86 specific code to the x86/hvm/vmsi.c file to make sure common >>> code will be used for other architecture. >> >> Could you provide some criteria by which code is considered x86-specific >> (or not)? For example ... > > Code moved to x86 file is based on criteria that either the code will be unusable or will be different > for ARM when MSIX support will be introduce for ARM. That's a very abstract statement, which you can't really derive any judgement from. It'll be necessary to see in how far the code is indeed different. After all PCI, MSI, and MSI-X are largely arch- agnostic. >>> --- a/xen/arch/x86/hvm/vmsi.c >>> +++ b/xen/arch/x86/hvm/vmsi.c >>> @@ -925,4 +925,106 @@ int vpci_msix_arch_print(const struct vpci_msix *msix) >>> >>> return 0; >>> } >>> + >>> +int vpci_make_msix_hole(const struct pci_dev *pdev) >>> +{ >>> + struct domain *d = pdev->domain; >>> + unsigned int i; >>> + >>> + if ( !pdev->vpci->msix ) >>> + return 0; >>> + >>> + /* Make sure there's a hole for the MSIX table/PBA in the p2m. */ >>> + for ( i = 0; i < ARRAY_SIZE(pdev->vpci->msix->tables); i++ ) >>> + { >>> + unsigned long start = PFN_DOWN(vmsix_table_addr(pdev->vpci, i)); >>> + unsigned long end = PFN_DOWN(vmsix_table_addr(pdev->vpci, i) + >>> + vmsix_table_size(pdev->vpci, i) - 1); >>> + >>> + for ( ; start <= end; start++ ) >>> + { >>> + p2m_type_t t; >>> + mfn_t mfn = get_gfn_query(d, start, &t); >>> + >>> + switch ( t ) >>> + { >>> + case p2m_mmio_dm: >>> + case p2m_invalid: >>> + break; >>> + case p2m_mmio_direct: >>> + if ( mfn_x(mfn) == start ) >>> + { >>> + clear_identity_p2m_entry(d, start); >>> + break; >>> + } >>> + /* fallthrough. */ >>> + default: >>> + put_gfn(d, start); >>> + gprintk(XENLOG_WARNING, >>> + "%pp: existing mapping (mfn: %" PRI_mfn >>> + "type: %d) at %#lx clobbers MSIX MMIO area\n", >>> + &pdev->sbdf, mfn_x(mfn), t, start); >>> + return -EEXIST; >>> + } >>> + put_gfn(d, start); >>> + } >>> + } >>> + >>> + return 0; >>> +} >> >> ... nothing in this function looks to be x86-specific, except maybe >> functions like clear_identity_p2m_entry() may not currently be available >> on Arm. But this doesn't make the code x86-specific. > > I will maybe be wrong but what I understand from the code is that for x86 > if there is no p2m entries setup for the region, accesses to them will be trapped > into the hypervisor and can be handled by specific MMIO handler. > > But for ARM when we are registering the MMIO handler we have to provide > the GPA also for the MMIO handler. Question is: Is this just an effect resulting from different implementation, or an inherent requirement? In the former case, harmonizing things may be an alternative option. > For ARM arch vpci_make_msix_hole() will be used to register the MMIO handler > for the MSIX MMIO region. > > int vpci_make_msix_hole(const struct pci_dev *pdev) > { > struct vpci_msix *msix = pdev->vpci->msix; > paddr_t addr,size; > > for ( int i = 0; msix && i < ARRAY_SIZE(msix->tables); i++ ) > { > addr = vmsix_table_addr(pdev->vpci, i); > size = vmsix_table_size(pdev->vpci, i) - 1; > register_mmio_handler(pdev->domain, &vpci_msi_mmio_handler, > addr, size, NULL); > } > return 0; > } > > Therefore in this case there is difference how ARM handle this case. > >> >>> +struct vpci_msix *vpci_msix_find(const struct domain *d, unsigned long addr) >>> +{ >>> + struct vpci_msix *msix; >>> + >>> + list_for_each_entry ( msix, &d->arch.hvm.msix_tables, next ) >>> + { >>> + const struct vpci_bar *bars = msix->pdev->vpci->header.bars; >>> + unsigned int i; >>> + >>> + for ( i = 0; i < ARRAY_SIZE(msix->tables); i++ ) >>> + if ( bars[msix->tables[i] & PCI_MSIX_BIRMASK].enabled && >>> + VMSIX_ADDR_IN_RANGE(addr, msix->pdev->vpci, i) ) >>> + return msix; >>> + } >>> + >>> + return NULL; >>> +} >> >> Or take this one - I don't see anything x86-specific in here. The use >> of d->arch.hvm merely points out that there may be a field which now >> needs generalizing. > > Yes, you are right here I can avoid this change if I will introduce > "struct list_head msix_tables" in "d->arch.hvm" for ARM also. Wait - if you pass in the guest address at registration time, you shouldn't have a need for a "find" function. Jan From xen-devel-bounces@lists.xenproject.org Tue Mar 01 14:06:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 14:06:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281492.479843 (Exim 4.92) (envelope-from ) id 1nP39B-0001Kc-MN; Tue, 01 Mar 2022 14:06:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281492.479843; Tue, 01 Mar 2022 14:06:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP39B-0001KV-JB; Tue, 01 Mar 2022 14:06:37 +0000 Received: by outflank-mailman (input) for mailman id 281492; Tue, 01 Mar 2022 14:06:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP39A-0001KP-1C for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 14:06:36 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cd8b59cb-9968-11ec-8eba-a37418f5ba1a; Tue, 01 Mar 2022 15:06:34 +0100 (CET) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04lp2058.outbound.protection.outlook.com [104.47.12.58]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-41-DMjONFKaOcOvCB0lcOniTw-1; Tue, 01 Mar 2022 15:06:33 +0100 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by AM8PR04MB7427.eurprd04.prod.outlook.com (2603:10a6:20b:1d4::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.26; Tue, 1 Mar 2022 14:06:32 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.027; Tue, 1 Mar 2022 14:06:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cd8b59cb-9968-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1646143594; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NH789zOs3WNiySRoMVWAKpB8KEacNg1hBBr3qGOdNCo=; b=Zg+nJjrokMmhbtPzuWvNkJZLZPTcx2nwwTeiKYSEgsE+Qct/8AFbnbrE4BScRZyz6U+tu8 5fHf73yW3cWNU/K88locRmXUbC4jjEkLHfsbyIGxofD01v4yQS8IAMgFgHIgcFlz0BMIa6 ctd57sWJvHd2dzjNinseN3Mt50PlZvQ= X-MC-Unique: DMjONFKaOcOvCB0lcOniTw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a/xaQ/5fLvveAxVIaaUNTZk/7aIO8bb+YK/tm1JKY4D+0XkvX8aqYoPpYC/40vt8Dz8FwiAVqXlLgr7FbRC5XVpRKYbDRrv2fH50JHZWWYNcDCOESd87qCqY0A52hnPUtu8OcwzQbCMQ5nKGHtOGfWJgW5IZoA53Wk/JKGArtH1ztOcFcFnnSqUaiWAVHWQDvViR0PhinLRTVa/q0NnutR/IbzSANtHqS9U6fAfLx+tHjFh68Mtr3AEx85RbcRF/k2pje7IdO5//XInNfXgFMInJXn7NrzlnfZ5uTFS69MWmK/M7wMCyzCeRXvZFh9323x0zP2xhJ9MBXFZMs9U7jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hORdoKxuHhXm3Z9OxT65NOFrf0TCcz7XNSLSOaspVgQ=; b=hyRQ9KOszQLLT/nDhzeA6m+ACOvRL4rdiclDFPPKNmZQVFsDeZa8k8nFKF9X/1K3I1mHnRcoCstVYI/jw+z6lfpJlK1xSIHr3UucmfGF5X5ssv6X6UZ8I8yxAFiXFNafmRVHGE3rvcH93L0p4pYFyNi3fjqamAfuWKQxDDAJ3KCmrdmF9NmkSZHTFzEedxoCcAL7yxVMEOXr10I/LJedXK9GMujHZasJsnF7HdqWhm4aj07pHGOFmSFVIZIdVfkmPCFeyol7unN9JUgDNchmycdwm45L0u7/c/Z8XNI4K5yR2ddvbHFp3S+UmHCyjupTFzKn/haXqXxNwyk+SqATsg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3ed7482b-c445-92f2-66df-a075f571bbf0@suse.com> Date: Tue, 1 Mar 2022 15:06:30 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH] x86: fold sections in final binaries Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu References: <03851bd4-9202-385f-d991-c9720185c946@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM6PR10CA0065.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:80::42) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4e58866a-c092-403f-1275-08d9fb8cb02d X-MS-TrafficTypeDiagnostic: AM8PR04MB7427:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zz5ZdheiO4bdfx2D08LbkisQPCeqTA1KuBCH7SvsJA23zpR5qEwwAuDgqYgdWqQ6CIF/g0XaVMdbz8mC1tp7HZ9y/ivnkXguA3JDNCE/7P3dUBF8qGv3s9S3SSD3tPZZxCz8hLa3m5Dtoj9b/IlFqglEeR25SuA05ic593E/CbWZDqlISKduC1AkpRtzYza0G3Ruy74BL55dCFDXCcjiD5MxpFxXdCegdkB2PdURO3/kJEb0f44YJAW5dD8+9FWM+uh/JptDCfUOhzad9BaQ2K+Chnqgoh9IsFXv7+IYnSaFGt7TShAijINtgLERIh7REMDT8sEQ94kQ8fu/2lEM2jcltkxxKU5Hf3aeIGBKz6M0Jh/fwqQQojb7u52WXfiIfT8B7wxEdpemPNR/c14Rf7GGGb27nFZSng20Jp6P9lXKkcrQigc8HfIdE5qNO3jVjBFZy2TQYMR5w4mUuLnfWvkrXqIqLOetgZ52jfJmelY7SzTBitdDg+N2TThWHh4gBjhvNgRIe+tqp0J7sJPax0+i47ZLi8D8wvaibH9W5yqSgqgQsRt8vTMWNVc0KgoKWKzxIXWhpDFieiMRkWzX4cbLgewqZ3YHI9PU7PQTCvSzMKh7Xvui3xQFRzbQSgrQprLivCwdN4CitqW4oYe62W96MeFNo4V3kHSdjlaQC0rsdps2CFw8H9sWwMJjAkNjjTUEeZyyuQb9NewcWjNFVJ0rJnIHgEBrbwv9gAsyCvLL/rmwDS6B60zHtILCDu0d X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(36756003)(186003)(66476007)(66946007)(2906002)(83380400001)(26005)(2616005)(8676002)(508600001)(4326008)(6486002)(31696002)(5660300002)(8936002)(66556008)(31686004)(316002)(38100700002)(6916009)(53546011)(86362001)(6512007)(6506007)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?22Q3oX6OFi1jR8xQT+J05ImjXG9E9E+8wRf6u17EtaS6z4Ck0PoQ3xwKaFxr?= =?us-ascii?Q?zhPMH7ZREhkrjHpbNwAUjm2b1HUy2jihA0l0C4HuAFoelI1l5xgXc2QwiqCE?= =?us-ascii?Q?knbtcfKqyqhMQ9siYOzmTAA5ByLPGRGe4qeKpHb2h9shWr10PYzGW+o3kqeo?= =?us-ascii?Q?PwSF0rXenzcA05SY++HpwipFOQ1KZKfUlqGcRc2z5+DvrgHNpQsoLNvvwCxI?= =?us-ascii?Q?WUp5efKOzKiMi9kMWL2TQDc3hea38R0mYO80/VsKrd3tf9+6pZp4rerABO9i?= =?us-ascii?Q?kcvNu/sUlI7Crh5xydXPF1guHYJGmVwve7DtmXZVNWoaXp0Lvn16T0gSr1qT?= =?us-ascii?Q?oYeFFX2Krbm+Z2LCZU7UbXTZzAX+tjSTAS8xh7su6GOfBtrqeWA5wOdB4dvd?= =?us-ascii?Q?MN8vmD1jmp1D2RhNRNBtf/OytSXw0IiYqRpgAH8ed/q21UUkfI8ziP/BSR9F?= =?us-ascii?Q?0bJ2XyXWDKeTObM66bkCwqAF+c3KbOBTEPvK6EniBaOxA6ig3GvUlk1PuiEd?= =?us-ascii?Q?DcMd7XrMd2gwMYmPtd1ejcPFrOx6BSCkTneTVexPpGEenLiEB9utVW9p2Gg8?= =?us-ascii?Q?5fpfp9ndhMHP5gPFONaVoheihtIZnSa6xeo8Q4nep9qhELtM4l2Pox8RHDQ1?= =?us-ascii?Q?G45s/YwWiELcOFjnoO/gLXQZQmnc5w8ZqIyH8xcrxwlcolAKb6pdLSvPCDug?= =?us-ascii?Q?dLPPOhFJCzuGxdqeBw1BH5WHvqd1TIlZfit0GwR7tXqDKgbosCpetV9u3FtT?= =?us-ascii?Q?hVeBOtReCDnZubtNHK05vCbv8IzGy5S2kdDGDYegmXqcFNigdpW+MXexSP3K?= =?us-ascii?Q?Afyutvi7ERRj54e0X/7cX9FuckgdBnlg73geLu+Wh367liMtAkPOl+HCOC8H?= =?us-ascii?Q?BfZgqXT2yWTtJmxtlMpbyreCdrFOBvpyAmpEVv2rA3orldGwn0lQCJX4z103?= =?us-ascii?Q?HWl77QN/XIxHxk58MlQnzWjOa8kRzS3+JMZJGYWqHnPzOEZO1UIfzrPfo9hm?= =?us-ascii?Q?5YyOXfDCPCT8/MKRjql1XdY2VvrdVdrVfOTB5biVZEy32SxKHqQm6NQ1ErXZ?= =?us-ascii?Q?s1LghgZlssDBQTVvEZ7dEL+C7RV6gIMBDmG88NKJqX4kn46w058Iff1EK6vE?= =?us-ascii?Q?XyARj6qJmHg3JSbRoKpxbpFEhVL5jYu12KHVvWqhRyYzmurGDebYfifjLPGs?= =?us-ascii?Q?hprVUTWKEBYw98e7s2VZFzDX/drZZL8xHe0VJZl/XDtjhVxqX0pg0gR/Y7dc?= =?us-ascii?Q?t7b8MK0hnYcOhhrUFi5kTwy5cN3178Q2e8+MorxxzOq/lgSmgGqHwGtdQBWD?= =?us-ascii?Q?QjuESRQRuS6kQIvltZhbbpP2fuBu5zJqNjQ7SY0h4CTH/gm95GPTZOFBOcyU?= =?us-ascii?Q?GHwRjx641mEaNmF07R4LwZjGavNYmDuZcLi9Yhgz8xlr6R9ERSHCnbXsyoyZ?= =?us-ascii?Q?jKyv7zgQk3XGH0SddoZXAJHurSKuPpHiyFmzYi/P+UbyNQpF2RnMrPRk08j0?= =?us-ascii?Q?GO7N1PhYBjRHh5KQmXkpta+QPhmBOGHSk7IhvUho3jqGADBqCud8QwOpx3Of?= =?us-ascii?Q?0K5eMWv7Ryfxaz0rJ0ay8y7CFUb+v/25rOHqcwXuqEpbnrmlLcNDbzpw9NQF?= =?us-ascii?Q?yhG/wFaAbUtxgy7xgC4OV+I=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4e58866a-c092-403f-1275-08d9fb8cb02d X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2022 14:06:32.0935 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /yNnGiWXE5nNbB5c8Gq2ZeTEaEczB3PVFvsvXdHZ4MTzc1O/apis+RKlPH8ibQ2FU3SYv6MMlhsKuWIF+VQ0lA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7427 On 01.03.2022 14:43, Roger Pau Monn=C3=A9 wrote: > On Tue, Mar 01, 2022 at 09:55:32AM +0100, Jan Beulich wrote: >> Especially when linking a PE binary (xen.efi), standalone output >> sections are expensive: Often the linker will align the subsequent one >> on the section alignment boundary (2Mb) when the linker script doesn't >> otherwise place it. (I haven't been able to derive from observed >> behavior under what conditions it would not do so.) >> >> With gcov enabled (and with gcc11) I'm observing enough sections that, >> as of quite recently, the resulting image doesn't fit in 16Mb anymore, >> failing the final ASSERT() in the linker script. (That assertion is >> slated to go away, but that's a separate change.) >> >> Any destructor related sections can be discarded, as we never "exit" >> the hypervisor. This includes .text.exit, which is referenced from >> .dtors.*. Constructor related sections need to all be taken care of, not >> just those with historically used names: .ctors.* and .text.startup is >> what gcc11 populates. While there re-arrange ordering / sorting to match >> that used by the linker provided scripts. >> >> Finally, for xen.efi only, also discard .note.gnu.*. These are >> meaningless in a PE binary. Quite likely, while not meaningless there, >> the section is also of no use in ELF, but keep it there for now. >=20 > Should we also use --orphan-handling=3Dwarn as to recognize orphaned > sections and attempt place them? We have now detected this because of > the 16Mb limit, but if we remove that check that we could end up > carrying a non-trivial amount of 2Mb aligned unhandled regions. Yes, I guess we should use this option. See below. >> Signed-off-by: Jan Beulich >> --- >> TBD: We also use CONSTRUCTORS for an unknown reason. Documentation for >> ld is quite clear that this is an a.out-only construct. >=20 > I've found some (old) documentation where it does also mention ECOFF > and XCOFF apart from a.out: >=20 > "When linking object file formats which do not support arbitrary > sections, such as ECOFF and XCOFF, the linker will automatically > recognize C++ global constructors and destructors by name. For these > object file formats, the CONSTRUCTORS command tells the linker where > this information should be placed." >=20 > I guess we can get rid of it. I've taken note to make yet another patch. > The patch LGTM: >=20 > Reviewed-by: Roger Pau Monn=C3=A9 Thanks. > With the possible addition of --orphan-handling=3Dwarn. As above: I agree we should make use of the option, but I don't think this should be squashed in here. The option appeared in 2.26, so with the current documented binutils baseline we'll need to probe for its availability. I'd therefore prefer to make this a separate change, and I've taken respective note as well. Jan From xen-devel-bounces@lists.xenproject.org Tue Mar 01 14:15:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 14:15:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281499.479854 (Exim 4.92) (envelope-from ) id 1nP3HE-0002kN-HI; Tue, 01 Mar 2022 14:14:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281499.479854; Tue, 01 Mar 2022 14:14:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP3HE-0002kG-EG; Tue, 01 Mar 2022 14:14:56 +0000 Received: by outflank-mailman (input) for mailman id 281499; Tue, 01 Mar 2022 14:14:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP3HC-0002kA-Kv for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 14:14:54 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f6d56e0e-9969-11ec-8539-5f4723681683; Tue, 01 Mar 2022 15:14:53 +0100 (CET) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05lp2172.outbound.protection.outlook.com [104.47.17.172]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-36-4xnKMn17MF-dxSx8Aeu0pg-1; Tue, 01 Mar 2022 15:14:52 +0100 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by AS8PR04MB7528.eurprd04.prod.outlook.com (2603:10a6:20b:297::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.13; Tue, 1 Mar 2022 14:14:50 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.027; Tue, 1 Mar 2022 14:14:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f6d56e0e-9969-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1646144093; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oq1ZRAhU9Q4MkkXTsjrRi/7LpPuPDcvU8/trqhc2rPU=; b=WzcMoyehqfEbmuVzO7gNdf7IXzCHl2jIMqk+b4B82VOSLHsQja4axQcMWqYsWmfeWeZ9kU 7LeYChGVHvphJDkaD9H+I8twodgGs/XV6Kqwheq1cyymv4sbl7aMMN0MFcpXW7ZqgY9tGA vQaMPPIiHAvMJaWPN9v8fRmDPVduAy8= X-MC-Unique: 4xnKMn17MF-dxSx8Aeu0pg-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j45khpdFn4pqgL/txI7zlEzW7ieekFMK7uP+Mps86VSAnZtiC2hXfmfX6p2qEzrUs0GMS8MyVG7L/xZ1b4x2VTxw5tTGav8F5JCvCZRG6CKEamFVrak/i1Z/MWkQonzXLU10LW1XmrbH87uI93C/XBY/wZWDxj87bPn2Z/9fpbGjJQrhCHkSBsOPQ4a3CxZKapjEMdv+BNBjw5W1Jdd3/ffJYf7e361f0jouuhcgHc7CBqol/TSWxIdfTo75mZwlLXXiCeXVYqh/c+lJGdKJIrEpRI1kIyNeL1TQ9JYLw7kbPX03QgihToPKCOBPAW3P+99SXueiRYEQnUzXdNPO5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=P4Wui87pS9Nc396SWhM/waAHPk+Jt68Fa+FaWuQHLg4=; b=Ff/BU23uoxlqx4p+t6xDmdR8WIyom7ssOHW3EBNVN9RvOX3/UjFmMjXACALBc8mzBsOWgrM081Dcb3n7kc4/lGZ/PPEuuiYsBvNw0jnHu/LQKOg5QapVhgQBsHfmn9diUSrBJDGzxcfhqz5Ew9WZGnBWITiBW9VWN5WhFnBoJXBHJbMjDS27BuRQvaKw4h08wiJmILYUmfqkZ22nEfYJS+PGwuUA/gF7TZh/iXGVO9CBvXXqND8/a91iAbslAaMfTPb9GgaIf46meRLPr8dr6nber3OJWVwsj7bzRgxqnEnlIptXOChFvtBnH5ftBAvEo5BdeB5GDoXgOIIFq6fEXw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <2c3bb06d-e4f4-33d8-7972-71dc7d61c554@suse.com> Date: Tue, 1 Mar 2022 15:14:48 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH 1/2] x86/time: use fake read_tsc() Content-Language: en-US To: Andrew Cooper CC: Wei Liu , Roger Pau Monne , "xen-devel@lists.xenproject.org" References: <77675e7f-2a7e-f517-4aba-e20774c8bfe5@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM6PR10CA0074.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:8c::15) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4fe9ec1c-fefb-47db-d550-08d9fb8dd8cf X-MS-TrafficTypeDiagnostic: AS8PR04MB7528:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: e27I8fOwgIqifB9ZIaVr/eXv7H7HyN8E1/40EYtZPusSFWTX0PZJP5miT1XIeVqWOplGdlaj/ldzMfZsSKxNZCohNKiPOnZu9g+SQxClmzosOBB+QPTeFudyk1ajwqrfZZlElFLhcvYXfw4sU1se7zYdvBTUlAXFtXH3qZF5+j3UgP9teXhPegeqA0TjFwrXTT+Afcxr2KZiw0hDdznmoQr1wBlaTNeX40PC9qZjipAMPuEnk5OkmaaK8EbYf/8BxYCYb0MxfGFvKuZhm6QHTvWjVHpBjY5CZ9arr8DO+9ZJSrFEhhHjUloHdYVvR7xbosr8wetAFzgbAHYECRxYMZJvXRdoJopjZlwZoEBcDeevUjf7Vz17fx1W+I5HQUKul10Jd/PMW9/el7U7D9fbF4JbEf4AxsVz0cUYk6mMPY53vIrxAEYT8k5CdemRVM76ZTWnqP54aJtseTwQ7kOIe64zkBvxqBtGuw5bbGrQrZaOyWo2FUkcWlag5zc8P9sGzm3Kn1/nxQx07DM+ihpcMYHSb1XDp4BCCDo5ctWR8J08H9tQZ5/lOSQ7t0QG17FQ1dDjSV3+XezkulGM2w0WYd5Sqmj3p0kH1YAupKZTXDBTXHswuzN/wE6ybOoixKcF1plybq5nP5ItSKBV5hlkswFau7GFfJwpQYAKQUEW7FA7R2ONQtM93L7jJagAB3BXDXH4igLqt+ydv8gn78slKkwelGaYyT+L86y9wPc9RsLbrLJeXeq3ALipyJNasDZF X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6506007)(38100700002)(6512007)(5660300002)(53546011)(186003)(83380400001)(2616005)(26005)(2906002)(6916009)(316002)(8936002)(54906003)(4326008)(8676002)(31686004)(6486002)(66476007)(66556008)(508600001)(36756003)(66946007)(31696002)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?jUb1hoNszGh839/Qmh399h883nJfIhbN8OeT+gXvtL/W2XGDaNQ+GNYwQ17r?= =?us-ascii?Q?gVcpIndhxaLGtJIlu+r1iE11Bo2+hNUIuq3nAB3ft6hzX6uWALsUEaJhVjHk?= =?us-ascii?Q?lkwBEHhdyc2FXT6CV9XK3ClYbkRyCujYZMDOhstD6HvZ4sm/+aUbDxLJKnxa?= =?us-ascii?Q?rhAgwWJIDm1Fus9rZy2tkbPC0L3Ptu/9dCCryPIPcl6YOSKUKpAR7ePObi4q?= =?us-ascii?Q?aNNxPH4OryuepZ+285mhc+KfaNBgB/sUfn0mnlRvskdJHUxIGjof6NvI95rq?= =?us-ascii?Q?s+wks9Jtu1zwOe/6jg9+8x4ZD2xQrT6CQ32bADsfu4b8Cz6imhEuFlv//Kr/?= =?us-ascii?Q?h96qQ20L5Kh3+dvQmTSfF9IkSAUFbwJ6/ViW+V/y7wPTRjc0Y5UYNm/cdO4P?= =?us-ascii?Q?4f1DNuITjTLDFODWw0w7W4ctYFFKopRTfc2CJu6kIYtU52DHLwydKYgwZnsM?= =?us-ascii?Q?FaVdp6JWUq0V2u9msL3UhR1B8ckpCogWKGjzdJE4drMY8HNsucbVcBRJT08/?= =?us-ascii?Q?5LXPlAmE+wZuqgR/EOH5PPgJIeddy4Zy0My1buZU8yspPzgbtMF9KRP3aWY9?= =?us-ascii?Q?ns1A+RyfNZB36EzVXt0LrfWYQ0cV6z3gmMaF1s6JN8XEy4WkXTk/8btLqCzY?= =?us-ascii?Q?jG3qL83Z1n3BEhXeQeBN5YI4qDQ4AxFe3NyMME1yglm5CVjEq+cx32P4tZvd?= =?us-ascii?Q?BmwdZVg4pkGi5Y6VAqM//HpXlTdRSNj9P+z/0aDJVGxe5sFv3/gM10rBIzhP?= =?us-ascii?Q?9/PJqWsGO6SsthpdXdpYwYgL8hQe2xpy7D0rC54/RYuNykjABOPYD2/qCzhg?= =?us-ascii?Q?aktppThtxXsGoG6JUo/ZWJDoKfjh5ggHnoeJKZX3KyeYkWm5JG35qCMO0i0d?= =?us-ascii?Q?zvWkqw2ZL0fTllqXybU0ua30BkKqYMWTbPjbOFpdw1IUCyooeW+gsfAsb+PR?= =?us-ascii?Q?NQtylRPgNcvWARfPvxwvFPlMJZtPfv3spR4v+lZSM5zS0u0Gg3g9tIkfq29C?= =?us-ascii?Q?h66fKXegG527gG1LY4+G4jjET9bYp3hP5zLfyXWsICtfF7kmxXI0XmJnYZxe?= =?us-ascii?Q?5GOHyMdQeu7LtNRLqK0CG3mW0Mm8pHvrwQjFSD6VQqatIgt9IVCnafpc3q5y?= =?us-ascii?Q?4ElpKOnss7qTW7/bLSRBDYh8WsTGZaHL99jl9WtF+uN7VurZAFIJUr5yArEV?= =?us-ascii?Q?YIqqJ7vM1+OYmgLe8PstFUR7gj/xkim+M8faXa30fj0BcV1NopZy/dOhO9qx?= =?us-ascii?Q?SGFyV72lD9PucF6W7PeKfgfWYLA/0bwxa91L04EpcEd0av9qqehhQ8tsyAoJ?= =?us-ascii?Q?igjvkZ/Q3c/fIyygbS28YuSnyEFiJABS7h9/gaFB0ST4zdICPtVyd4H/aLwE?= =?us-ascii?Q?FZ3+vjZ67gY36VS5aN9RAlMtjyPu2TtlZm4q84MM13/KMk6mfiNEvgfKWJ/k?= =?us-ascii?Q?JjG+ReWWDYLM2Ip5FngI9zh53aCDyzelteNvg8IkfDJPkf/sCcFKsROqz/Nj?= =?us-ascii?Q?5rZkDdz3Do23KJ4rOzhoqwBdpSK6/XtWzVSVnjWWij6vd48C1VNffVpzUBdI?= =?us-ascii?Q?52LdZiscIzmRqT9A40i2+OozrjKLIaC661XgfjvqyD9U6UDuIcnYSvjkbt2c?= =?us-ascii?Q?QDcxxP1cjHhm+pWuoj2aFas=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4fe9ec1c-fefb-47db-d550-08d9fb8dd8cf X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2022 14:14:50.7813 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: aSs0FFMuvs1copZg1b8OHSy/5bdvJVRZSRjgb1+zxhwYRcSTtDiqBRjiRQrvb9m1Ici26aJocilpCu0Xu+FZGQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7528 On 01.03.2022 14:07, Andrew Cooper wrote: > On 01/03/2022 11:05, Jan Beulich wrote: >> Go a step further than bed9ae54df44 ("x86/time: switch platform timer >> hooks to altcall") did and eliminate the "real" read_tsc() altogether: >> It's not used except in pointer comparisons, and hence it looks overall >> more safe to simply poison plt_tsc's read_counter hook. >> >> Signed-off-by: Jan Beulich >> --- >> I wasn't really sure whether it would be better to use simply void * for >> the type of the expression, resulting in an undesirable data -> function >> pointer conversion, but making it impossible to mistakenly try and call >> the (fake) function directly. >> >> --- a/xen/arch/x86/time.c >> +++ b/xen/arch/x86/time.c >> @@ -585,10 +585,12 @@ static s64 __init cf_check init_tsc(stru >> return ret; >> } >> =20 >> -static uint64_t __init cf_check read_tsc(void) >> -{ >> - return rdtsc_ordered(); >> -} >> +/* >> + * plt_tsc's read_counter hook is (and should not be) invoked via the s= truct >=20 > Either "is not (and should not be)" or "is (and should) not be". Oh, of course. >> + * field. To avoid carrying an unused, indirectly reachable function, p= oison >> + * the field with an easily identifiable non-canonical pointer. >> + */ >> +#define read_tsc ((uint64_t(*)(void))0x75C75C75C75C75C0ul) >=20 > How about using ZERO_BLOCK_PTR?=C2=A0 The hex constant 0xBAD0... is more > easily recognisable, and any poisoned pointer will do. Well, I specifically wanted to _not_ re-use any of the constants we already use. > That said... what's wrong a plain NULL?=C2=A0 I can't see any need for a > magic constant here. Are you fancying an XSA for a call through NULL in PV guest context? > Overall, I think this patch should be merged with the subsequent one, > because in isolation it is slightly dubious.=C2=A0 read_tsc() is one of t= he > few functions which is of no interest to an attacker, architecturally > (because it's just rdtsc) or speculatively (because it is dispatch > serialising). What code would appear to live at read_tsc()'s address at the time an attacker can come into play is unknown, given it's __init. > This change is only (AFAICT) to allow the use of cf_clobber later. Not exactly. The subsequent patch specifically does not touch plt_tsc. And if it did, it would have no effect with read_tsc() living in .init.text. Jan From xen-devel-bounces@lists.xenproject.org Tue Mar 01 14:18:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 14:18:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281508.479864 (Exim 4.92) (envelope-from ) id 1nP3Kk-0003cm-3U; Tue, 01 Mar 2022 14:18:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281508.479864; Tue, 01 Mar 2022 14:18:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP3Kk-0003cf-0T; Tue, 01 Mar 2022 14:18:34 +0000 Received: by outflank-mailman (input) for mailman id 281508; Tue, 01 Mar 2022 14:18:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP3Ki-0003cZ-FB for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 14:18:32 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 78687fc2-996a-11ec-8eba-a37418f5ba1a; Tue, 01 Mar 2022 15:18:31 +0100 (CET) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01lp2059.outbound.protection.outlook.com [104.47.0.59]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-24-61HUAGoiPaarM2g6_TOSLg-1; Tue, 01 Mar 2022 15:18:29 +0100 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by PA4PR04MB7936.eurprd04.prod.outlook.com (2603:10a6:102:c6::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.26; Tue, 1 Mar 2022 14:18:28 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.027; Tue, 1 Mar 2022 14:18:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 78687fc2-996a-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1646144310; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XvD4MMtvcaPKx23Cg8/gsE0qHf/waojcPXGHwdeZSik=; b=BcRxVv9Ea28e3fwyJZoda78rcxVVBvL0mrFUNv5A9MN9QVbM6+iN/+3bdfiIgfrrp3wXkO WprxFi5afaxE9C3Jcqlyp6AmglRV4xDiC/irXb+ozzqEzAP53RkQ2+ZSIFqfL+CJU2kNYx 5Em8Li17MqxHbCMxg30uIbajRIFRplI= X-MC-Unique: 61HUAGoiPaarM2g6_TOSLg-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fexer6soqBZV4SnTpz/iod5RtLEEaCH08Ouxsl4+7UAxFK+7/ta6y1H2edy+E6wvRJn0Lf2lujYtq4fJlW3HoZnZrgWkBHSHfWFwRINytL5rCaXZMWd7B8T7UK3BpjFLDLCLxj1SjvErK/zK/dRSJYus4Z2DUcIMgNxpO+iZ2nO6/PyGkriNZzjluOysDiUFvlvcKjOq0ak5ml7cegOnPE2xNlq72iVH02EDW+bHiDNgsNm/oOqtOrP3lpHd8ikrKdQJwg/8tDTqJFd0K/qxUYE1KGbe239afFt8M2nPQOK8aJriD4j5VGHsMsCcwZqxAEEbcPQbjsdvIAanFZrPtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XvD4MMtvcaPKx23Cg8/gsE0qHf/waojcPXGHwdeZSik=; b=NGdgHcKpD+5CqKlbHef9AbZh9bSLGI+vKC+91DcF/Njzs2jc+SYW+QAk3f2+uYiox7JEDemyTp7kWG7XTEvPO2wKE6jDTSo9YPnnJrXHrKO27HdvwWfi9GqU4oEG2F32/V/YBvOP/E4JhSanU/aBBNF0Qob0039MOYS9T/HSY9TlOGJgy6aohUbFK7kEJXOmO+O3ja7UvcwPZCrcfbe1uzDoTAG3LuKiO1cryWpzgoytivH/k8e/47F3OBbS7hG0fxBgZz9KcdBgUr5/NJmLMpexS0RlOw1mNSG0m3mToVa0U9+3vxS6g+fK9J8Iua32pQWb2/0Y12sm3w2lN4V/GA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <40ce913e-4388-2d2f-45e3-e725a927da92@suse.com> Date: Tue, 1 Mar 2022 15:18:26 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH 2/2] x86/time: add CF-clobber annotations Content-Language: en-US To: Andrew Cooper Cc: Wei Liu , Roger Pau Monne , "xen-devel@lists.xenproject.org" References: <77675e7f-2a7e-f517-4aba-e20774c8bfe5@suse.com> <61bbf544-74ac-b698-425a-d1db80acab43@suse.com> <20185a89-0a2b-6bbd-5484-31b6582ed200@citrix.com> From: Jan Beulich In-Reply-To: <20185a89-0a2b-6bbd-5484-31b6582ed200@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0208.eurprd06.prod.outlook.com (2603:10a6:20b:45d::23) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 718cba1f-9da2-4f66-bfd1-08d9fb8e5b1f X-MS-TrafficTypeDiagnostic: PA4PR04MB7936:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zmUUNpjPBlumjhI7H2ojQoUKgWRUIODuKfd36lXgPT5eIiTwm9YvQ7hURXRHbXu9jEjCSmSqO7DJvVuPdKxjxN59aAAf/c8/ioCRhy1RO5RvXWP5TNSbG/PBmbiLj4/k4y15AVR3JteAS7AAuYb4Bn2L5IMi224HOuJ2R6/pmY8PxAhR4qNXdP8/WGgLpeYVf1ZdGfiLT5A2QOyPI4U8syb/c1kR84AXytND3m9CXt0Q6yZYP7ep3HxeZbI0O4tjiVwOfyafGpgv1Sq4U1zvfv/RV/RTnqdJbTkKGknnchFg5brWEx/UKULpAfShJ9NqgPlY52fvwxtiqd1lHjst/N1ySQ2m7TECvzLrCXf14M07+YECfyPP3gmC7skmAIJSsfUF31XYYSvlsTfvltPZkJxqVyhyZh5w9vJ0GOhP5h2DCqoPoOhfUNO1hvxyN9jeRIICjfAQUEKMw4bMfaviJRZe9Sq0ZjXUjB5UrgnThmCoc1qMVz204pUttqNkaCEgGINOP7lMf+L56PhBOjjnQDwi3zUgZEXx434Zdp5GI2dBhskWLi631KFH+KHT4aSwBw0cM1bP7ppymZTv0St0hnsGxfCFHeeNjObUKBBjX8QysyCdG4dPwqxb5YIP8ttbLzxg+vbCl3Vb4g/ZBPrB8Q2lz4ed7iQ1e9339r7NuQcDGVFrc08e5uT2kJURzv8cprxsKECOxnpH0PBVc3Q9/f7rLGl56zlLs9P/OWrKhLaGAbyh9szygTYIR83OkPZx X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8676002)(66476007)(4326008)(66556008)(66946007)(6916009)(316002)(508600001)(54906003)(26005)(6486002)(86362001)(186003)(2616005)(83380400001)(38100700002)(31686004)(8936002)(5660300002)(2906002)(53546011)(36756003)(31696002)(6512007)(6506007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bDBnVkRJUmpxMWtqekcrRDVER3kycTJlV1AyNGROcVVQWCtTditaOW90T3Rr?= =?utf-8?B?NjF6NExQeWRqdjNVelNmVHg2QW1Jb3hVT2FKNDR2a3RCRDNUMWl3UWF4V3pu?= =?utf-8?B?QXdzOG9FS3FZbFZWV2xhclRodDAxaVNyM2VsSUlvTHpuQmxRamZSRUlPVldv?= =?utf-8?B?S0VCZUtNOUxuZE45bDBvdjI3Tis3ZTRpK2pnM2ZCVkJpRUhWTU9JTEpuN3Nw?= =?utf-8?B?OXpKNUR3dTk4dnFxN0Znd3VCTWFSS0lkNUtQc0pjZ2hPSlNJd0FyMVJOWHdr?= =?utf-8?B?ZEZmR2NQaFpFRWZFeUE0bVNZSEt0MTFqZ09SK0QveURTNHBwRFZ1N0xMSU5r?= =?utf-8?B?V2VNcVRqbWN6bk5mRFBZYThldUZkS01INUZUZ1QweUs5MTJHWm5oVFNhWnR2?= =?utf-8?B?VlJ3Nlo4blNFZVROOHc5WUpHZlZBRElNN3Y2SlUzRDZiVlNHdWR2VTAvMThQ?= =?utf-8?B?WjNLZ2RlQlM4WTBVQ25tbVNOZzBzd29RcS9lWTRUL3hTc3VkZEo5OXhTeUNz?= =?utf-8?B?cjk0UUVVQnFtY09mQm5LdXB2ODlhYzNBRnhlTTA2cXFHS1JabmQxRCtHTHU3?= =?utf-8?B?MmtPRFMvUGZtMmJlOWg2OWJ0Rk8yem1oNHZ3TGpUeElsMnNUSXRGZkZiTU8z?= =?utf-8?B?aTAvWEJIWTJIMkhjVEJuclFNaXh2NXdUUks4UndhTnBxMk15c2Rjc0QvL1hx?= =?utf-8?B?MEFlU0ZvMHJxeFRVZTAycGRLRDZQV3loMnVjRWhlaXNTWFNKUlQ3dlhyNy9t?= =?utf-8?B?THdWQ2YzOGxUMWpxRXI3RHFHcTRBNjMwRkkzL3g2UVY5TFJwMm1IaWVvalUx?= =?utf-8?B?VUtkVlI1Z3VKdWdWU3J3SU1WeThnelpxV25Eb0hHcW9nRk5ZK1BzZ0J5dEx5?= =?utf-8?B?TkRMQ3VDYTNiTzNwNGIzamJSRVZlQUZzRStuZ3Ewa3lWUUxDNVNGRlhlZHQ4?= =?utf-8?B?Rmk5UjlLQ2NtZVlOS1c5SU5IcEIrNWRsR2RQc2M2N3J5NDVYNityeGIwdkl1?= =?utf-8?B?ckNsclpxeWdTUGZhbURaaHhCVVdFZy9VUXBjVENVL3M5WWIrcjZ1VENoWm1q?= =?utf-8?B?Vk52S25IZGpMeWtrZ1JQUE9Ycjc0K0t3eVNVU1REeU5JTHA2ZGNybzBJdzhl?= =?utf-8?B?RllZMGhYREV0end1amI1SExYdmJqNXRnbTRWeTdTcUtVRlEyZmQ3eXBVQ2sw?= =?utf-8?B?amZKSTlGWUdvSXJYTWFoWGFaSitVK0V2MEloMWRMT09JZ0sxTjkrS1hPVEpi?= =?utf-8?B?cmZQZk9CUkpIZ2JOMTdjYUFSTmN0WXhHSTNGcXF2VU5LT0VuTU5vM2tOZllG?= =?utf-8?B?MUNDdHlSd2NoMkU1ZWtEeGplV0FjRFhkQ1lCbkRVMU1VellKeTZ2K0dnL0Zy?= =?utf-8?B?djRpK1FaSzBZeUhiTUd3R1dia3NDVUJoU0I2OURpdlk3VHBjWDQwa3hkWFpN?= =?utf-8?B?bjJGZzg5M2IzQ1VDcDE2emN6M0NjNFRma2hFZFdLOG55WFJNQ3Nvbnh3VEx5?= =?utf-8?B?OWFSZWV3b2RDM1RrVG9PWDZIQkVjUmZyUkM1d0NBeVFIbittbEdlM3pHWlRm?= =?utf-8?B?QWY3TWI2VzUxR21iWHhuTmNvUWtkVnp4ZklXOEFiMEFsN3l5QTZreGNrTHdj?= =?utf-8?B?OGRhYUdEOGRsUWVkUDBFbzRRakkyY1JPV2dtTFRVZHFEOThCYmZkdytySjJJ?= =?utf-8?B?cnZJS3pKSDEzSHBWbVZjQVNWeGFwYkorRUgrcnpRTTJtRDgyUHVhM21OWWEr?= =?utf-8?B?NVFlVVB4MHVad3huakJHbnZvUnV2bGJYMTZVbjB5S3RIZktaSllqRnVrNnpq?= =?utf-8?B?RHFkSUFidStVd0xra2UrWEt3L25SMmJod2xPcEdQSTBtTnFVK2RhUnIxdnJr?= =?utf-8?B?NWMwNm5nV3hTUFp6eDhNenlvVU1WTWN3ZjhRMWNHZzNzR2VBNVZndXVmeTFo?= =?utf-8?B?ajFka2RSa1p4NXh1ZDhIRWR2bTI1NGswbjRWalk2dzlCK1V3M3RoMlI5QXhv?= =?utf-8?B?TDQ0cWZ4V0JuQXAxNEc4WldTSXBBdlRBTjJCYlZ3Y1lCbmR2VzNtQ1Z6UkVE?= =?utf-8?B?dmdBUjJoNWtzTmoyNzBpTGo0ek9abWpqWmFIekQ0c1ZhTkZIVXJEc01lUEpC?= =?utf-8?B?aU9BNk9odEFDVDRvM2txaDJnSUFkdWZMQ1hSaElBL2V2dzM4SERPU00wK2VV?= =?utf-8?Q?wYPBOtTTfMmx3rIgzmeeyAE=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 718cba1f-9da2-4f66-bfd1-08d9fb8e5b1f X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2022 14:18:28.3933 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +34IuQ63i2WsKdYlv9Yw7zfu5QvXEOAe5qhf4FaTtnQm4G9tA3E9xdU9EVIps/KocYKTiGEWx3+wZltnkkdgog== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7936 On 01.03.2022 14:18, Andrew Cooper wrote: > On 01/03/2022 11:06, Jan Beulich wrote: >> With bed9ae54df44 ("x86/time: switch platform timer hooks to altcall") >> in place we can further arrange for ENDBR removal from the functions no >> longer subject to indirect calls. Note that plt_tsc is left untouched, >> for not holding any pointer eligible for ENDBR removal. > > I'd be tempted to include it, for consistency sake alone. > > It is less likely to go wrong in the future if another hook is introduced. Can do, sure. >> Signed-off-by: Jan Beulich > > With the commit message, I'm not not certain if this is linked to the > previous patch. > > Overall it looks fine, but I'd like to get clarity on this point. Converting read_tsc() was discussed (with Roger) earlier on, so I'd view this as a separate change. As said in reply to your comments on the 1st patch, how exactly read_tsc() looks like is orthogonal to the changes here at least as long as it doesn't live in .text. Jan From xen-devel-bounces@lists.xenproject.org Tue Mar 01 14:20:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 14:20:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281514.479875 (Exim 4.92) (envelope-from ) id 1nP3MM-0004yL-FC; Tue, 01 Mar 2022 14:20:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281514.479875; Tue, 01 Mar 2022 14:20:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP3MM-0004yE-C4; Tue, 01 Mar 2022 14:20:14 +0000 Received: by outflank-mailman (input) for mailman id 281514; Tue, 01 Mar 2022 14:20:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP3MK-0004y3-QM for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 14:20:13 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b274b7ab-996a-11ec-8539-5f4723681683; Tue, 01 Mar 2022 15:20:09 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b274b7ab-996a-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1646144409; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=8Jdq0/ohAYWojsb1R/HhqNnDc9KaRrY0G3pRZ4N+EuU=; b=Y0NzSIqmgSkR5/Gix9CQ6fJn/fsqv+ktaIBQ1TVhoNjztNfg7mDYM3Sq f90asoKAkc3G1U92xbiUBl1ESo8pqKpUoBPHyxYUHYtFhuoBoc1sunwwl HVHl9iYpocyR/w5MFAKu198DYrEG5RFSxEbwCEcLIrVxFo54GUyhvRXuq A=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com X-SBRS: 5.1 X-MesageID: 67510270 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:j5EnNa191U6k5JW3H/bD5WZxkn2cJEfYwER7XKvMYLTBsI5bp2BUy WMYCzzUb/mKYmf1eIskbduxo0sAvZTWzIRhSFNtpC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EE/NtTo5w7Rj2tUw2IDja++wk YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx /1tmZGKQw4kBJTTxuEyUyJITzAhBadvreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr KJCbmpXN1ba2rzwkOnTpupE36zPKOHxO4wSoDd4xCzxBvc6W5HTBa7N4Le02R9u2Z0XRayBP 6L1bxJAMk/ufzhvYG4sM7QcwtynmnzyVxtX/Qf9Sa0fvDGIkV0ZPKLWGNDYYMCQTMNZ2EORv Hvb/n/RCwsfcteYzFKtzHWogePemDLhb6gbHra46/1CjUWawyoYDxh+fVmmp7+/g023WdNaI mQV/DYjqe4580nDZsnwWVi0rWCJujYYWsFMCKsq5QeV0K3W7g2FQG8eQVZpa9E4tclwWT0j0 HeImc/kAXpkt7j9YW2Z3qeZq3W1Iyd9BW0IaDIATAAFy8L+u4x1hRXKJv5hH7SylcbdAizrz naBqy1Wr64IkccB2qG//FbGqzGhvJ7ESkgy/Aq/dmC46gJ0Yqa1aoru7kLUhcusN67AEAPH5 iJd3ZHDsqZeVvlhiRBhXs0tMLyT7f+ICgTD31tAH6IxqyXyw3SKKNU4DC5FGG9lNcMNeDnMa UDVuB9M6JI7AEZGfZObcKrqVZ10kPGI+cDNE6mNM4EQOsQZmBqvoXk2DXN8yVwBh6TFfUsXH Z6AOfihAn8BYUiM5GrnHrxNuVPHK81X+I8yeXwZ50n/uVZ9TCTMIVvgDLdoRrphhE9jiF+Im +uzz+PQl31ivBTWO0E7C7I7I1EQNmQcDpvrscFRfePrClM4RD95VKSPnep4It0Nc0FpegHgp CrVtqhwkgeXuJE6AV/SNiALhE3HB/6TUk7XzQRzZA31ihDPkK6k7bsFdotfQFXU3LcL8BKAd NFcI5/oKq0WElzvom1BBbGg/N0KXEn63mqmYnv6CAXTirY9HmQlDPe/JVCxnMTPZwLq3fYDT 0qIjVuKEcJeHF05VK47qpuHljuMgJTUo8orN2PgKdhPYkT8to9sLi36lPgsJM8Qbx7Ew1OnO 8y+W3/0ecGlT1cJzeT0 IronPort-HdrOrdr: A9a23:1ua03ai+0IfjBWanRjikfxkJ2HBQXiAji2hC6mlwRA09TyX5ra 2TdTogtSMc6QxhPE3I/OrrBEDuexzhHPJOj7X5Xo3SOTUO2lHYT72KhLGKq1Hd8kXFndK1vp 0QEZSWZueQMbB75/yKnTVREbwbsaW6GHbDv5ag859vJzsaFZ2J921Ce2Gm+tUdfng8OXI+fq DsgPZvln6bVlk8SN+0PXUBV/irnaywqHq3CSR2fiLO8WO1/EuV1II= X-IronPort-AV: E=Sophos;i="5.90,146,1643691600"; d="scan'208";a="67510270" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IYM/BMkHRdILa//7Qdal053mUihfcFApfsOWvDOLjrvBfBTxDzchSvarA6gEUwsREf+5hfU4gC7pjpwOxCL0HibdgmWhDVtlTn23sxTyDYRm1p+TZuQL43hzxHD5ruxWTrgOpq7bx3nIffIqX55Fd0KQmK3Ie7NyCrzk2IuEMlqdzFYK4Z9J35z0V9K7gd9DCib9mZtpEzQzjp/D9x/lZFIgqCfCe6BLkLlLxEoXLsDA6aT6Znodcgj789q1dkhmdZAQhrtSGbJn/kw685beXnudf5zVYMh8+O7tWWQ2SPHz5cnESWfKOHjiNu/9jpVSfmHhaK88a69BH6/NXZKpRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wOfGY3OP8edMG6TcG86RWFr89ImlVtGKDeGPiH+RVd4=; b=FxsfQQ5E5+x2t2cN9Y6rEi/oSS44O5rN6UKCeYQ+8GqUBsjLEKleSvkX4DrsDMK8v/+MYDqBtcet+YhB8m5UWvD/WiqPz3JcLoMEjHomCTck9cbGcmG8CtA7mFPPnnzYks588qW67TIc4R8en2ve6khuVaaUWNgJzabKzIS1v2sqyZhbWF8M18VjLpP3qS9co3bUDvP8DM+o0G/3x0z+k2j4ugcdanu7ioZxuzqyaoFu1BdfEFkh5gKzXd3h1Q3pmool5DfLQqqjcT45lhAahURvxSFxrFLb8stMsdiej95ykhtk/iN/G9SiJrW8WIiPOLwDGl3SUqmt8it6W5FWQg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wOfGY3OP8edMG6TcG86RWFr89ImlVtGKDeGPiH+RVd4=; b=S07LLasSkxkLP5ui4WUv9OsTZxlA75thHRjE8eMGQXBsu8FrouL9lx1pFXH2rOLWBDBPV4m7zv68uYLFRTc3wiTxewSzV2++zgWPlnlz74H0A9yIX2ujGEfbaMKsr2X2jvKw0doK0Pw/ldxTdI2xgr46W1stqeewDtt3hVy5g/k= Date: Tue, 1 Mar 2022 15:19:55 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich CC: Jane Malalane , Wei Liu , Anthony PERARD , Juergen Gross , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis , Jun Nakajima , Kevin Tian , Xen-devel Subject: Re: [PATCH v3 1/2] xen+tools: Report Interrupt Controller Virtualization capabilities on x86 Message-ID: References: <20220218172943.12182-1-jane.malalane@citrix.com> <20220218172943.12182-2-jane.malalane@citrix.com> <0a31970c-c0f8-c995-ce04-67523a4a830a@suse.com> <9aff51c2-0e8c-685c-7bff-0ed7ff7347c7@suse.com> <6b59e3ea-01ff-e26c-02d4-3b11594fd7f0@suse.com> <60bcd74d-5686-9813-e3a6-b28c15b66a22@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <60bcd74d-5686-9813-e3a6-b28c15b66a22@suse.com> X-ClientProxiedBy: LO2P265CA0297.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a5::21) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 79d7c066-fa3f-441f-dd4c-08d9fb8e9261 X-MS-TrafficTypeDiagnostic: SJ0PR03MB5647:EE_ X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZGx9RSJ9ETMmFNzBmvlteU55YNOXqY6/1aNm+TWA0v8g7T4nW+aB/f8OgyoRCF/WhLe2XvUJAmRN+6xwMSOi3IhtM7g99p3gOia4+UE3AvplfJLasnJZYNpxy+kK+yb2R7qjWlfQk7cBhwgAySvT6kH5tcGbEZsMcqAH6bvJKFRxOaPeENPOX4O8XBbpqthBICsB/XlL6kf3HqrOrto4fhQe9f8X5UnJbyogZQ3WGYdlc/6c9l00dym3nrZEPTNTXzSLhCv9be38rFv9wqM9KtOiHgiGDNJeBfV275m8kvXKayBSdWR4hT0+v6R1eEeb+ERXFVWlzkNdA6jO1PmD2F2iwbuRMLoPmeKkIcluBhdlXNBTa+OtmNZxYv6RFQQzeeoimga7xBGLTQpNU8uT5wuUPvZ8Rrqmhi805Adm6VLByc4wdwkjhYnzHC/qmq/13ffsdqPLpNXEWUl3Xar5gfDl3jvd8fhJ/CbkvUDUzwI1olEJ6o2YulU+QH+dLSTP3v5gWmwI1E1WCHNZN4lS13XNaVaFg5QCQuFFG/foi0nDCA6JQz12IwRSsS7q8huhkVGDorL3rURtCiUsycdUbx1PYgbMK+S5bQXDFnwqH6AAPeqyR9dCo+BUZfSVJJEcZYb9OIOCzmm5YqlbGEhcPg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(86362001)(8936002)(8676002)(4326008)(66556008)(66946007)(66476007)(33716001)(85182001)(2906002)(6486002)(508600001)(7416002)(316002)(5660300002)(6916009)(38100700002)(6666004)(53546011)(6506007)(82960400001)(83380400001)(9686003)(6512007)(54906003)(26005)(186003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bTBRcDVvZHY1TjJ5c1JNUDNFM01ZNm1QUm4zZUdMZm9TS0NlK2x2VWErQ2cy?= =?utf-8?B?OHFHSlRMVUdCRjJHMjl1eUluczY2cEZFWWlueDVNRjhvc3dVejZzYjRWR3Bv?= =?utf-8?B?cExwQWNWWXdNT0ZJdkRJK3l3RU5RWE1MSWhUTVZlcU84djh1S2NoZkZ2WVMy?= =?utf-8?B?dk5aWUVRSlh0QWFScitieTU0Q3JLMy95ZlVKWExuQStZU2NMbFJ2MkFxS0N1?= =?utf-8?B?aVpqRnB2TWpVWTl0ME1PMDIvTU9PN0lJWU44RzJUc2Rpc2dHOW5LV3R4WU8z?= =?utf-8?B?TGExaXpJWkpUMXd5bnFCcWYva0pxRXZkd3k3U2ptQnFJeVQ1a1dCUW9QNEsz?= =?utf-8?B?OEUzWDE4NC8wZkk1VHFTVHRSSWNxa2QyYWhYbVdBZkpEemtOS1dGdFJsTUpH?= =?utf-8?B?MTQwTnRSakMzdUhYL1kzWlhVSXQ1aGxVUFJMTm5iMWwyNURXd3VoMW00OHpZ?= =?utf-8?B?QVoraHZtcTk3WWpmNUdUUlI2ZDdrSzdQMnVXYUYzSWRJNGlCeHR0d1l3NFFN?= =?utf-8?B?NHR3SlNtUHlLRWMzaUY5cXJFcW8razFObi9rUmZMeE9OQkZhSHVsd0JkYVhM?= =?utf-8?B?MmJzWmlLbGtZWVdEWTRNTC9UVGJNUGRBMmlMTTQwaDRhZUxlaitPMFoxZmxs?= =?utf-8?B?QndUaGZZV0YveDMvRk82TjVPeGU4NGlYZHFzRzdIQU5IVWFwZXhxQndrVzBS?= =?utf-8?B?VWYrcTkvK3dZNDk4MktIQWhoTzdDTXFaYUlpcHhRL2o5SUlTT2FiTEJHczEx?= =?utf-8?B?djRtRThLSGRyMTloQWlXaGlOYzF5dS9sWW1udURnRXZoTldWeEpCRFhoL2xI?= =?utf-8?B?Sm1Pb1JPTEIreU9nZzBIUGlpSDBVbW9DSkFRd3hhdlhiNThSSVp2THQxVGQw?= =?utf-8?B?K0lEZ1pKWkZlTzJ0c3k0QVo0SW5ObmxpMUR1cVQ3emFRbVdtK3lPWWtBcnNQ?= =?utf-8?B?N1NTNWdET0IzSVN5bXoxL0trZHFRaWN3ZEM0Q0t2TmhSYzNuakxNN3haZS9C?= =?utf-8?B?NElFVTRCMGw2NE11aFE2NS9LdW9wUzNZQ1VvUWF1eHR2Nm1MTzdldG9aQ2Vi?= =?utf-8?B?cmJhM2lLVUFaZzVqSlNpS3ZCT2dWQVlUSE9qT1JvWXlIRG9ibDJiM3BUdFho?= =?utf-8?B?UGsxMEhPK3AyL3lZMTFQRTRkK1M1aE1ISlQxRmNsdkgvcFpMZXFxQmVnR0ta?= =?utf-8?B?QWMzQXVwRGlJU3FoSWJsWlpyK2NuakVvdVc5cnVwNzZCbnRXRW1FTXhEeUkr?= =?utf-8?B?VXphRnllcitSdWxsa2pJWDFMQ1hCL3RHVVFLMXdzRzdIcmUyamsvYnFrVlJy?= =?utf-8?B?OXlPWGFXWFVPVlFOTmhJZTFZb2xIcUNpMmx5VnQyUHdqRXZML1BWU1NEZzhX?= =?utf-8?B?YmpFN1VNdkRCZURLeDFSYysvdVdhbTlwT05mTThFMXQ5LzFyUi8reTRFcXZY?= =?utf-8?B?VGp5YitKOFRMZThlQjlxRUk3SW1VaWVlYkhUbG9ESHU5Y2lEL2ZUUHhCakVQ?= =?utf-8?B?eE5za2c3WmJSRWN2UlFMOFF1REpZYzFmMlZvUlhkNUF5MmZsZjVQQktkS3Bx?= =?utf-8?B?NW1kWkNQRE1nYW5NMit6ZDNXU2ZkaVBGcHdYUzZVazRNdExmVmdUZndZR1dh?= =?utf-8?B?TUFUemVIZWNQU2tWdTZ1N2c3WGM5MTBodW1ZT2dYcXpiYW9kbFd4S0ZRaDM1?= =?utf-8?B?SWpUbno0d0RHTWs0M2VGaHlKT3h1eVRacVlLcERabzRmNGp5QlZNNXlwc1A0?= =?utf-8?B?a2RTeFlyaTA2UTA2czNUNGF0aVhTelFmNU1DSHJLSVhOWU92Z1RsYXdLNisw?= =?utf-8?B?eFhsRktTaUZDRTNpZ0ZYeFg1THBNL1l1bjV6TU1JTTk3THFWMDFQdXgyOXM4?= =?utf-8?B?SmFuNTRMTGRDK3Bld1NWTXdEK1VKYUVSY2pRZUhDbG05R0NweFc4Vmp3VlZC?= =?utf-8?B?aWdhNXBGYXpYc2VvditDbUh3bTVGd3BMYXZ3TVNFVVFXVzBPRGlPZHRINHg2?= =?utf-8?B?QUxRYWlEQkhQQ2V4M2xaR3ZDODc4K2lYaTFvTDFobE05Vm43bElGbnB6OHFk?= =?utf-8?B?Z0lwNXd2U3ZwV2g3MVVBR21pci9vZGRCa1ZoTSs0YXV5WjF4M2o2MHZkRHFi?= =?utf-8?B?dktvTmFqREdyM0ZrYUZJeGZhek5BclRaQitrVElkbzZ2WGUyRlkxN0hpY09s?= =?utf-8?Q?c93Fzw2HceOLw8g8S+0L0UU=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 79d7c066-fa3f-441f-dd4c-08d9fb8e9261 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2022 14:20:01.1025 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cIZZei+yAVN/DSlWxCw2DnZFZHnwGIyfpLyEO1osUKKeEkcqbQ6+hLZuCZcXZrYlVQFtzGmvhW6ckK4xmgYDzg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5647 X-OriginatorOrg: citrix.com On Tue, Mar 01, 2022 at 08:51:59AM +0100, Jan Beulich wrote: > On 28.02.2022 17:31, Roger Pau Monné wrote: > > On Mon, Feb 28, 2022 at 05:14:26PM +0100, Jan Beulich wrote: > >> On 28.02.2022 16:36, Roger Pau Monné wrote: > >>> On Mon, Feb 28, 2022 at 02:11:04PM +0100, Jan Beulich wrote: > >>>> On 28.02.2022 11:59, Roger Pau Monné wrote: > >>>>> On Thu, Feb 24, 2022 at 03:08:41PM +0100, Jan Beulich wrote: > >>>>>> On 18.02.2022 18:29, Jane Malalane wrote: > >>>>>>> Add XEN_SYSCTL_PHYSCAP_ARCH_ASSISTED_xapic and > >>>>>>> XEN_SYSCTL_PHYSCAP_ARCH_ASSISTED_x2apic to report accelerated xapic > >>>>>>> and x2apic, on x86 hardware. > >>>>>>> No such features are currently implemented on AMD hardware. > >>>>>>> > >>>>>>> For that purpose, also add an arch-specific "capabilities" parameter > >>>>>>> to struct xen_sysctl_physinfo. > >>>>>>> > >>>>>>> Suggested-by: Andrew Cooper > >>>>>>> Signed-off-by: Jane Malalane > >>>>>>> --- > >>>>>>> v3: > >>>>>>> * Define XEN_SYSCTL_PHYSCAP_ARCH_MAX for ABI checking and actually > >>>>>>> set arch_capbilities, via a call to c_bitmap_to_ocaml_list() > >>>>>>> * Have assisted_x2apic_available only depend on > >>>>>>> cpu_has_vmx_virtualize_x2apic_mode > >>>>>> > >>>>>> I understand this was the result from previous discussion, but this > >>>>>> needs justifying in the description. Not the least because it differs > >>>>>> from when XEN_HVM_CPUID_X2APIC_VIRT would be set as well as from what > >>>>>> vmx_vlapic_msr_changed() does. The difference between those two is > >>>>>> probably intended (judging from a comment there), but the further > >>>>>> difference to what you add isn't obvious. > >>>>>> > >>>>>> Which raises another thought: If that hypervisor leaf was part of the > >>>>>> HVM feature set, the tool stack could be able to obtain the wanted > >>>>>> information without altering sysctl (assuming the conditions to set > >>>>>> the respective bits were the same). And I would view it as generally > >>>>>> reasonable for there to be a way for tool stacks to know what > >>>>>> hypervisor leaves guests are going to get to see (at the maximum and > >>>>>> by default). > >>>>> > >>>>> I'm not sure using CPUID would be appropriate for this. Those fields > >>>>> are supposed to be used by a guest to decide whether it should prefer > >>>>> the x{2}APIC over PV alternatives for certain operations (ie: IPIs for > >>>>> example), but the level of control we can provide with the sysctl is > >>>>> more fine grained. > >>>>> > >>>>> The current proposal is limited to the exposure and control of the > >>>>> usage of APIC virtualization, but we could also expose availability > >>>>> and per-domain enablement of APIC register virtualization and posted > >>>>> interrupts. > >>>> > >>>> But then I would still like to avoid duplication of information > >>>> exposure and expose through the featureset what can be exposed there > >>>> and limit sysctl to what cannot be expressed otherwise. > >>> > >>> So you would rather prefer to expose this information in a synthetic > >>> CPUID leaf? > >> > >> Depends on what you mean by "synthetic leaf". We already have a leaf. > >> What I'm suggesting to consider to the give that hypervisor leaf a > >> representation in the featureset. > > > > Hm, but then we won't be able to expose more fine grained controls, > > ie: separate between basic APIC virtualization support, APIC register > > virtualization and interrupt virtualization. We would need to keep the > > meaning of XEN_HVM_CPUID_APIC_ACCESS_VIRT / XEN_HVM_CPUID_X2APIC_VIRT > > (and exposing more fine grained features to guests make no sense). > > I did say before that once (if ever) finer grained controls are wanted, > a sysctl like suggested would indeed look to be the way to report the > capability. But we aren't at that point. So we would expose everything in the 0x40000000 range, and caller would figure out the position of the Xen leaves doing a signature check until the Xen leaf is found? Would we represent the max policy as having Viridian enabled (so Xen leaves starting at 0x40000100)? I would agree with this if the hypervisor leaves where already part of the managed CPUID data, but the work required to expose the leaves in the policy/featureset doesn't seem trivial. Making those leaves part of the policy will likely be done at some point, and then we can decide to drop the sysctl bits. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue Mar 01 14:21:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 14:21:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281521.479887 (Exim 4.92) (envelope-from ) id 1nP3Nc-0005Yr-Qj; Tue, 01 Mar 2022 14:21:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281521.479887; Tue, 01 Mar 2022 14:21:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP3Nc-0005Yk-NK; Tue, 01 Mar 2022 14:21:32 +0000 Received: by outflank-mailman (input) for mailman id 281521; Tue, 01 Mar 2022 14:21:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP3Nb-0005Ya-MF for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 14:21:31 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e22694af-996a-11ec-8eba-a37418f5ba1a; Tue, 01 Mar 2022 15:21:30 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e22694af-996a-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1646144490; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=CFq7ucWFa/8Vfo2JLBh9/+mDVj4ToCSNMC7UOOXAgzU=; b=ASnO1m2KjLMNJJBgiiqpwg66xAtUvScqj2rVunc8tG2WtNdQfUANs94l Gr/5mlfiNtUiQFd2FZ8V6t7IOyoqGfupW7YCXpfdOWVcPFe2e7Q1+2/Er ZPbHhAlzavtCDJrvzPuwdPHWB7EVJtItdk/Ok8fisNacNJyrjwE0Qrmzs A=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com X-SBRS: 5.1 X-MesageID: 67510505 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:QNHp46M++a9/+K/vrR20l8FynXyQoLVcMsEvi/4bfWQNrUol3mMGy zBMWDyOb6uKYmT8KNh/Pd/n9EICv5GByodrHgto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFcMpBsJ00o5wbZi2tcw27BVPivW0 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zl NFdq6TzWwgQNajDor4QdDN+SnovMvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr 7pCcmlLN03dwbLtqF64YrAEasALNs7kMZlZonh95TrYEewnUdbIRKCiCdpwgmht35gTRau2i 8wxamB+RxruRzp1NVYzL9EEjtau2yf5SmgNwL6SjfVuuDWCpOBr65DyNPLFd9rMQt9a9m6Iq 2SD82nnDxUyMN2E1SHD4n+qnvXIny7wRMQVDrLQ3vxgjUCXx2cTIAYLTlb9qv684nNSQPoGd RZSoHB36/Fvqgr7FbERQiFUvlbYug4CY5lCHNQx7Q63kKfzySDAXTkLG2sphMMdiOc6Qjkj1 1msltzvBCByvLD9dU9x5ot4vhvpZ3FLcDZqiTssCFJcvoK9+N1bYgfnE447eJNZmOEZDt0ZL 9qiiCElz4segscQv0lQ1QCW2mn8znQlo+Nc2+k2Yo5Hxl4hDGJGT9bxgbQ+0RqmBNzBJrVml CJZ8/VyFMhUUfmweNWlGY3h5o2B6fefKyH7ilVyBZQn/DnF0yf9Id4Iv2ogeB4wa5dsldrVj Kn741g5CHh7ZibCUEOKS9jpV5RCIVbIT7wJqcw4nvIRO8MsJWdrDQllZFKK3nCFraTfufpXB HtvSu71VSxyIf0+lFKeHr5BuZd2lnFW7T6CHvjTkkX4uYdykVbIEN/pxnPVNbtnhE5FyS2Im +ti2zyikE0OALWjOXCMqeb+7zkidBAGOHw/kOQOHsarKQt6AmAxTfjXxLIqYYt+mKpJ0OzP+ xmAtoVwkwCXaaHvQelSVk1eVQ== IronPort-HdrOrdr: A9a23:WcndNaw4i4T3Tf2ptAUCKrPwIr1zdoMgy1knxilNoH1uHvBw8v rEoB1173DJYVoqNk3I++rhBEDwexLhHPdOiOF6UItKNzOW21dAQrsSiLfK8nnNHDD/6/4Y9Y oISdkbNDQoNykZsfrH X-IronPort-AV: E=Sophos;i="5.90,146,1643691600"; d="scan'208";a="67510505" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Zz8CpiKRMsJrNGSKa/QegXiqORufyKQcOX2q/5UVgaDW5TOMdjrwUxgNQVFHmiVt10ho6aVbtt4jE85J8N+SacxHU3SLQeWhRGrAK1DVgKLvtf/7/Xf8gteEHEDML7grUMtLqGY66xv3loo6ph7gJaHCPCK3rQ7UmJmFwwNdKVVECALCRek17YpQxzp8/BzSxwCM42BtLUf9Ag+NuisJtgGf/MW+bMbE5+ZHztYl+72VC2lAOtD/TpHcN5y7ERzZwGRk7ED2mosuyh/Dcf+cxhR85712wHZyN7YXkCvlWnrNsYLPkPMnHy1QApnOeE4EBrntw4Z4qUQQOq/B4JWB5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=asEOo2hUVtkuimU0mOHJme/HCaJCwWp4xy/3Mmvsl/k=; b=eXBfnqHK66lXfcG5eRFXNdTtyQZ1XYDZWaHACh0O5+juSUqoNT2k+L8Jp+8cUcfSespLKF0Pv3E4qPQF4eMY3ab+a5358G4BSxoTpIyN8npyq2WJLx6wh8TmJoZkbHTbJMeBRH3GkwsKZqEQWI0Ua9xcAFXVPYCBqeU1s+Kz4BI6DYdD0i/OVRhCFE55R3CnEhgesu2xQ1ek2FUgYbx/ZewjBiYURj4r7ZPvJEq/O/vlXCj58fSMcz2+Yk9ALj4+sztUVpX6jp6isWHF0grqnEqHJAjR82Mq0m6IZO9XtZ4fEVjfQ052aHtytl1SsR7718lGgt6Hq4MqISWflvq64Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=asEOo2hUVtkuimU0mOHJme/HCaJCwWp4xy/3Mmvsl/k=; b=VT65dr7re9MNuPiWmCo6//KCqD4XePjaD+15ExQR6XEquqpu0H2oV99DdDttlJQ4rSA5nDA+dnuJ4s0f+56aSw9S+AcYIPXn0YUyn+aPDBLFmUGPgmESH4alS5t41m3FuyroNn9dAAn7gIIJH9tdPdBAz1DO37T4vynu9Y0Tylw= Date: Tue, 1 Mar 2022 15:21:16 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich CC: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu Subject: Re: [PATCH] x86: fold sections in final binaries Message-ID: References: <03851bd4-9202-385f-d991-c9720185c946@suse.com> <3ed7482b-c445-92f2-66df-a075f571bbf0@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3ed7482b-c445-92f2-66df-a075f571bbf0@suse.com> X-ClientProxiedBy: LO3P123CA0006.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:ba::11) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bf08fcfb-f0e8-48ea-d227-08d9fb8ec1e6 X-MS-TrafficTypeDiagnostic: BN7PR03MB4514:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hB7wBtUBpitqRnLyDgT6AcECnUXKDXG006ON9ZH7JL5pDFQNg5Z5/vy8wAHY5Iox/IVKPTkTh0B/TYd8fw74UlhafapVHYyAglNmhfqAJdHeJ8XR5DK2u8rR1n1R3PtE35s3YO0fysUlPBovqZcHwBc+RBotOy1H3uw34t4zkUTmm/Ns9gTBQLHtlt4Z+6TE7bOwSLPNlfnzLQqJz3Yelo0ils5Xpo2VH6Z9U9qDUt+5K6/2+u3j/INhgA0dfNfG+JFNYwoxZQVjnJWyLPtVckl2rUlQ+mX09oL1q7wnaqKHf6lW85ar1ewfFZpo1RGA5TFsLARU0ftVRrEOJF/jc4Spse/EPbqRAQqv/dzpwtcs1qJ/ac3JJG2i9UPbKzWZ3H25wGDboguvLIwQvaiugRhKPjzkXxZz+xyXCqhY4Gafct/06V8I34Dq3zgQCj39Hff4vxlyOiisw3TSkNVDgUyarELYH/rf783lr8v9jbo1VfMaQXQHcNfP7c63jehiB9CQYYLwUuHzor9Kg18Tk143MvSo5PQobZ4a1JS8PtdNjYWDbLLT3+am4jtE6Bu1AWLesNi6XvdRz1RiQnZs8IOKyS/IUolHTcDpkvs32/GO+h8Pq1o5kEpREQP4R4zbWETj6eQCUeCIk7gPxfV2ZA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(82960400001)(6506007)(316002)(33716001)(6916009)(6666004)(53546011)(8936002)(54906003)(86362001)(83380400001)(66556008)(66476007)(66946007)(8676002)(9686003)(6512007)(6486002)(508600001)(2906002)(26005)(186003)(5660300002)(38100700002)(85182001)(4326008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z2NlQ2FnSDgrRUZrM00vLzkvalVsUUw2aEVzcU8vVm5CRVBjREMxTzFCaFdG?= =?utf-8?B?bTk1YW1oVkswY0IzN0Jad0NlTnBYVkYxN0J2M3puR0NCSHJ6NG1hMWdxK043?= =?utf-8?B?SENWRUd6aW5Ja3ltUUUzT3JaL3gzOU00NTA1QlJPQnJ6NHNBTW8rbGVRd2Jn?= =?utf-8?B?ZGJXUElobC9KeksrMEV3KzBtS0Q5QTBnZ3pVQTVVdExobVhidkxyYVdjTWFz?= =?utf-8?B?WTlDcVlpcVdyNmM3WW1nbll6YnZwcU0wL2VtTWcwYmVYWUsyUzJIdE8vekhG?= =?utf-8?B?bUFyN0xBV3NSQjUvc0prV081ODlRaVg2Q3A5bDFkZzVRT0o1Ujl2NHpLN3BL?= =?utf-8?B?SkRUNCtBZVl5OCtuNFp1dkdLT3ZXaUdadXU5Tk44ZE1WdHdzQ2lMK2tBRVpt?= =?utf-8?B?bnFEV0tXVWw4TmI1RmRCR2p1TVhvTVhJYXVuWkNpZjd1THo0dUNSVmhUaDcx?= =?utf-8?B?aEcyc2VpYmxWajdEL1FicmNya3BBTlNlMkJYc2FZUmlHSkVnR2pqWU9xWVky?= =?utf-8?B?S0Uvb3VVSVZKUU5yKzU4VW8vWUVadzlCTnFZclJZOHRuQmhpdTdxTFFFdm1X?= =?utf-8?B?N3c4NHVTMk1jUzA3V3ZIdFlqVkpmbmlsbUFuNW5JcURCVmp2S3MyQjhiMEtq?= =?utf-8?B?MDZxN3NISUVLZTQvSHRHblRuaEhHalBvWXBjczd6UUJDWGtjcW5vaEcwT3hx?= =?utf-8?B?bkEyRmxyWTVVQVRTRmxDTE9wUUxhZUEzbDBvdmtFVXRnMWFzcGJ4QzA0Yitw?= =?utf-8?B?K3l5VmJCRW05OGtWTlB0ZkpXTmhqVW5BSzN5Y1VPem96aitMV2E1V2ZjT2lW?= =?utf-8?B?ZnVPakk4RWluejNpR2YzYWRlRFBxZU1LejVnM0dJb0NxTmp1WEgrb01JSnU5?= =?utf-8?B?eC9BbkFiSDg0Rk1EbThKNEtXSzdKeG5ka3c2WGNpNHhwbzEvQlFHRW0wQURm?= =?utf-8?B?K011VURPRTN6L1U2YXdoYTJnUXhpVXIrV0VLWnhmTXdlSGJLVExSOW5lNkYy?= =?utf-8?B?NzNxL0JyREIwT1R0bUk5MlQ5R2VqbFpBemRqaFh6UjZUeXk1MkljYS9VejJv?= =?utf-8?B?WURIYkx1UUI0ODZjMW1YbVBaOTVsSTNrN0ZZbTFZVGRQYTNDU2xGZUtLZWtk?= =?utf-8?B?NTg2bWorSGJ2WHdUeGRtdFJGVHk0OCtOR1JnZGdlK05zc2I5NkxQdEEvYUs4?= =?utf-8?B?TWN4OWhDZFNrRVZNUE9SMW5RR1B0dmlQd1VZY3RsRFVuck0vZUFwU2g5dFA2?= =?utf-8?B?MUdvcHcwVTI3N3NPUVA5R2RKclFQU001MnJPTGpwRFNpWkFwM0Rtbk9DeGFC?= =?utf-8?B?Qk1Wd3grRzlOSk5QeGZTYWNnQ3ZnUFZudHVzbU1xeEVTYnk5UWtOdCthVnhq?= =?utf-8?B?eFZDMXhOWXlBVEhzMWFUZWZBQlIzK2pISXYvVGZkSjIzQ2xXWDRKcEpncU1o?= =?utf-8?B?S29LNVdLdzVaT0sweWJNQ0hzZ2hDSEtnK3l4Z0pkdHB0ZVFRRDMxc2ZsRmF0?= =?utf-8?B?UytoeU0zelZtRHF1eHJSckloamZ1YXhINkFlalVWTHNoRExFWmNId0dINWlN?= =?utf-8?B?MGUwaFV2WGZVVFEyQXc1a2tKbkxlM2lKdHV0L3p0NHVXRWZyY3F0aHJ2K0JT?= =?utf-8?B?ZVJQVEJ5QVViK21oTHE1ZmVjVjhxVjZWdHgwa1FJQmVsWDFpQlRBL3NMSERT?= =?utf-8?B?SUtvYXNzeTE1MUJZampTZUJncnlkdXFFM3VvRjVmZWRrcFJnWVM5ZXY1QWp6?= =?utf-8?B?bE9wUVVYQW54MGRUK01BOFQ3NlJLbTFZTWdpbWp4ckRuNTZTSnk5Q1J2ZmRt?= =?utf-8?B?NFNGVVFON205Z2NOaVJJZTcvalQrQkR5RzlramtrbzZaV0YyOHphbkZBL2lZ?= =?utf-8?B?eDN5WFBiNnhqODZKc25ZR2F3YkExYWNDdDdvVExvaW9JMU9oNWZsYVU1SE5r?= =?utf-8?B?d3hzWXBLNXd2aDlyNHpRekNmTVgvU1Radm9UNUQ5b0lnd0dTQUR2KzVXbkpU?= =?utf-8?B?T003NlVXMXQrQkM5NXRoVkxISlpqVzZEUXdjMS9ISDQxVnhtbk4rRW1zTTEx?= =?utf-8?B?UVhJakNoYXpkbjd6K0ZkMW5GZzlSVmZpV1diWEgxcERRbkQ4eDJzcVc4U08y?= =?utf-8?B?NnBlcWlCbUMwbXRJbmYyeUxqdHM2OWRCWWtCZmZVYnExQ0UrZW9ka0t4S1hL?= =?utf-8?Q?xfA+lP18cjH1NrwHvwIbplw=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: bf08fcfb-f0e8-48ea-d227-08d9fb8ec1e6 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2022 14:21:20.7943 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OxtpW94KFm9ekU7MWLtbAOpP27QMD1VJrf6rvtcRLFV+6sMPtbnvsMU45+VSVfHj4gjZx3f+QW2B+dMcz3DANw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB4514 X-OriginatorOrg: citrix.com On Tue, Mar 01, 2022 at 03:06:30PM +0100, Jan Beulich wrote: > On 01.03.2022 14:43, Roger Pau Monné wrote: > > On Tue, Mar 01, 2022 at 09:55:32AM +0100, Jan Beulich wrote: > >> Especially when linking a PE binary (xen.efi), standalone output > >> sections are expensive: Often the linker will align the subsequent one > >> on the section alignment boundary (2Mb) when the linker script doesn't > >> otherwise place it. (I haven't been able to derive from observed > >> behavior under what conditions it would not do so.) > >> > >> With gcov enabled (and with gcc11) I'm observing enough sections that, > >> as of quite recently, the resulting image doesn't fit in 16Mb anymore, > >> failing the final ASSERT() in the linker script. (That assertion is > >> slated to go away, but that's a separate change.) > >> > >> Any destructor related sections can be discarded, as we never "exit" > >> the hypervisor. This includes .text.exit, which is referenced from > >> .dtors.*. Constructor related sections need to all be taken care of, not > >> just those with historically used names: .ctors.* and .text.startup is > >> what gcc11 populates. While there re-arrange ordering / sorting to match > >> that used by the linker provided scripts. > >> > >> Finally, for xen.efi only, also discard .note.gnu.*. These are > >> meaningless in a PE binary. Quite likely, while not meaningless there, > >> the section is also of no use in ELF, but keep it there for now. > > > > Should we also use --orphan-handling=warn as to recognize orphaned > > sections and attempt place them? We have now detected this because of > > the 16Mb limit, but if we remove that check that we could end up > > carrying a non-trivial amount of 2Mb aligned unhandled regions. > > Yes, I guess we should use this option. See below. > > >> Signed-off-by: Jan Beulich > >> --- > >> TBD: We also use CONSTRUCTORS for an unknown reason. Documentation for > >> ld is quite clear that this is an a.out-only construct. > > > > I've found some (old) documentation where it does also mention ECOFF > > and XCOFF apart from a.out: > > > > "When linking object file formats which do not support arbitrary > > sections, such as ECOFF and XCOFF, the linker will automatically > > recognize C++ global constructors and destructors by name. For these > > object file formats, the CONSTRUCTORS command tells the linker where > > this information should be placed." > > > > I guess we can get rid of it. > > I've taken note to make yet another patch. > > > The patch LGTM: > > > > Reviewed-by: Roger Pau Monné > > Thanks. > > > With the possible addition of --orphan-handling=warn. > > As above: I agree we should make use of the option, but I don't think > this should be squashed in here. The option appeared in 2.26, so with > the current documented binutils baseline we'll need to probe for its > availability. I'd therefore prefer to make this a separate change, > and I've taken respective note as well. I didn't check when it first appeared. I'm fine with a separate change. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue Mar 01 14:23:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 14:23:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281531.479899 (Exim 4.92) (envelope-from ) id 1nP3Ph-0006Er-Ea; Tue, 01 Mar 2022 14:23:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281531.479899; Tue, 01 Mar 2022 14:23:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP3Ph-0006Ek-8h; Tue, 01 Mar 2022 14:23:41 +0000 Received: by outflank-mailman (input) for mailman id 281531; Tue, 01 Mar 2022 14:23:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP3Pf-0006Ee-6j for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 14:23:39 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2e397192-996b-11ec-8eba-a37418f5ba1a; Tue, 01 Mar 2022 15:23:37 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2e397192-996b-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1646144617; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=4ObiUhpeQyuA1VDFdAzZ7biM4EWMeMxqTrJB4a4yTsA=; b=YJdzb6p8BuGKCIZibEhakwoJG9C/K/6jxM1Zai+iVXfa3oK5jn32i9cG CVQCMReDjICf5RobttQi9MGKb5EFIWPwiE9/qAnojp3C+lxjAMZjH1bCA 97EbSbBjq0e1arIa+ICo75ygTPUBqBDr3L2uYhEGrSKt0ywbl+4EKzYWo Y=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com X-SBRS: 5.1 X-MesageID: 65629216 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:bmHkfq+YLqfsyhZhVSpoDrUDnX6TJUtcMsCJ2f8bNWPcYEJGY0x3x moYCmrTPviJZWCge48naY6x908Cup/QzdcxG1Rt+S88E34SpcT7XtnIdU2Y0wF+jyHgoOCLy +1EN7Es+ehtFie0Si+Fa+Sn9T8mvU2xbuKU5NTsY0idfic5DnZ54f5fs7Rh2NQw2oDgW1nlV e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9 DlCncysVyNqGbLroec6XjN3CHxmEaQF6IaSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFKoZtmtt0nfyCvE+TIqYa67L+cVZzHE7gcUm8fP2O ZdHM2s1NUqojxtnEHxQAZgVs9iRuyO4djRhr3CkvqMu/D2GpOB2+Oe0a4eEEjCQfu1Fk0Ddq m/Y8mDRBhABKMfZ2TeD6mirhOLEgWX8Qo16PKK83u5nhhuU3GN7IB8cWEa/oPK5olWjQN8ZI EsRkhfCtoBrqhbtFIOkGUTl/jjU5XbwRua8DcVq9B+piY3LxD+aIWUuYSUccPAv998PEGlCO kCyo/vlAjlmsbuwQH2b96uJoT7aBRX5PVPudgdfE1JbvoCLTJUby0uWE409SPLdYsjdRGmoq w1muhTSkFn6YSQj86ygtW7KjDu3znQiZl5kv16HNo5JA+4QWWJEW2BKwQWDhRqjBNzAJrVkg JTis5LGhAzpJcvQ/BFhuM1XQNmUCw+taVUwe2JHEZg77CiK8HW+Z41W6zwWDB43bphcJmS3P BaK4FI5CHpv0J2CN/Qfj2WZUZlC8EQdPY69CqC8giRmOPCdizNrDAkxPBXNjggBYWAnkL0lO IfzTCpfJS1yNEiT9xLvH711+eZynkgWnDqPLbimn0XP+efPPxa9FOZaWGZim8hktctoVi2Oq I0BXyZLoj0CONDDjt7/qtZCfQhXdiFgXfgbaaV/L4a+H+avI0l4Y9f5yrI9YY112aNTk+bD5 HamXUFEjlH4gBX6xc+iNxiPtJuHsU5DkE8G IronPort-HdrOrdr: A9a23:+vD6lqP9ksTr2sBcTuijsMiBIKoaSvp037B87TEIdfUzSL39qy nOpoV/6feX4Ax6ZJhEo7290ca7LU80maQb3WBzB8bBYOCFgguVxdpZnPLfKlTbckWUygc678 ldmsNFeb7N5DZB7PoTT2ODYq0dKHXsytHOuQ9+pU0dKz1XVw== X-IronPort-AV: E=Sophos;i="5.90,146,1643691600"; d="scan'208";a="65629216" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HNJhvVO02XFWh/WZepET+ULDebW+yJ23PkpJjXl0ib7t/9NgZbIrGDs5ulDdWAQy2ltFEoamPF3lRB9CdRi22bqKCuwms45vUeiSmk2FLKO9aUKQxifWaplI0RSgseEE+qEH0V2pKXUBxwHyKUztSlfJiHaWeV9dOXOTWmd1sWcLOEUFpvf6alvQ3ET6x2D2YFgsNtY0/IHdqMDe0r1gylqElSM5R8/0zadWilUz6Wo4/tF/Ja0tOdN/7h6cy9uKyESDrcR+92/1WIYDL4lLocwihtKVaFs0O5ASOoKUQjQd+zjLT34scmhgWAVrHmR1jJhvMQVPgTD2RCQBIyWG3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4ObiUhpeQyuA1VDFdAzZ7biM4EWMeMxqTrJB4a4yTsA=; b=GfHzAxsrgnyzMoTD1DHGmgptAq5PTVbQnpWfJ7rzLlcgaP/rmhDsfqxVhwZX19ULjKzqaoSsX1XIkGA91Umape0ot0UqDCXNZ/gMtsufCsW5EwtG5Pcc0VCwSPfzlwqyfHni6gJria939q0xdzzhmRzr2st1wz0IG5z0TADoLpvmA2nqyKwQKWSmGwZ9pyaH27h+GHgnmtTrtYCvD63vsh/V6wzn8gHDyUVbEFov1llKeNRBQ/ESBG0GQO39VL2MW1wTThLQOUWi67WDGcF2o6Kt/8+RPbTnlgSb9hCbcbHiN2orFrdhdas62dYe02TWM1oeh5egEf3HGvzoBMG5pg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4ObiUhpeQyuA1VDFdAzZ7biM4EWMeMxqTrJB4a4yTsA=; b=Cr68EAANKizvDbmk4hCFJV3mvyyK9A+GoW7Cndzc4lA7iEu2tapy/OH+JSKqLMZi+qUhSMWRHScJBXiLtjahKZlwTc2vX0cjn1xBxqmb8yVwUE2L6xKHIvcSsGx5dGNKJQ6sFHaQx6GRwKE4QcPJm0nB/eqD2PlOy6dNftm84Rk= From: Andrew Cooper To: Jan Beulich CC: Wei Liu , Roger Pau Monne , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH] x86/altcall: silence undue warning Thread-Topic: [PATCH] x86/altcall: silence undue warning Thread-Index: AQHYLWCYr1nVwle0TEu9TqkN6fmfJ6yqeogAgAAMyICAAA3FAA== Date: Tue, 1 Mar 2022 14:23:28 +0000 Message-ID: <6f005e15-eb81-c41c-7296-4929e85eae21@citrix.com> References: <0e3594ff-c637-46f2-bc95-7a26b5471b86@suse.com> <40306bc7-f61c-d330-0ec7-d986e4711d88@citrix.com> <06452eab-653b-458a-048b-cc709151353a@suse.com> In-Reply-To: <06452eab-653b-458a-048b-cc709151353a@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1597012d-3964-4b9f-f7c0-08d9fb8f0e0b x-ms-traffictypediagnostic: BN7PR03MB3745:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: yLLCweoKb5T3scyQSJgs2nAphbhXfnqqIfc5ryxmG8i5aWQZ60H9bGjzI68VJHQAwTXtX6Fcb2l/PrxDnDviinXICAxXJHNmVIHQe7FM+Jzmw2jEnP53IJfiNeT+GG8ePeuXqokDJuF5J+/r6aiMy2VCdfSDzwVzIRgOnisJ9SzGwIXDlVLIY4n27eJGfMQhyZQDeCHB7EYAjubhx2CdzfkjznKXRlaKumeqermF//vnvI+ss9JYJb26F3CbZdaizq1DTnVXQ2vhStXG5/dDMs/cfTzyYGCojL8hovveORV9ZrGK94Ajiuvf2foISVVSPmJ4w9TwNJ3nHS/CFr8dRXcwdwOeH1CPabPJigboRavgRjmoNlINEABUcgqXFWtwdpJaQFRSq4+c0eDJpiaPJOPJ2bx/8bZBhydfn1XYXfVJY0CUdbrzNaesApwCFVeS2/KrD5/qxq9+9ujtFNAgtZL9mqgwdCpzkHy6eTKkVBZtPGXBbeKNOOplTPz0o/N6qXSpWqeImVBhbQzbeOlJJ1SbyaWDUQWiJW+TZXyRIc5Ba2Wb2C+mQHc7TzsrJ7ImkLzyDnL4rTthZiP1xk8xKmQKXO1HbFw1K/Cp9cPeRfz4aTrUHXZJY2UDXZ6SwQIAsxwbQY36zUYh8O/sonWKhJUREhhGx63V1onJSHIzvsmjQoHxJeRV/1NIwkQ9ImNQtsfyB47eFiWW8x71uneUCsiGbMGtOOUiHmKwXYitB3GKwJDqmADptUimQcCpnWx+HVv1XQRd4SBbZvGTKD5JHg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(71200400001)(6486002)(508600001)(8676002)(5660300002)(36756003)(53546011)(6506007)(54906003)(6916009)(316002)(82960400001)(91956017)(122000001)(8936002)(64756008)(66446008)(66476007)(4326008)(76116006)(66556008)(38100700002)(66946007)(6512007)(186003)(38070700005)(31686004)(86362001)(31696002)(2906002)(2616005)(83380400001)(26005)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?QVp6anNpK1ZoRVZFQXNtZWNZZVFqa2hlS2g5SVdSQ3FqQTR2Y2NSYUhueC9V?= =?utf-8?B?ci83Mit4VGZxMnJxeGVpcDNwaEhBU2xZczVzRmlhS0o0UmIwcUcydC9uV203?= =?utf-8?B?bUhmeXphZnBybC9KOUJsclY4Z1plWjdaUm5QN2lMdmZXcTN2a2ZVWlJyYUsx?= =?utf-8?B?bHhGS29hLzgxTGlZSUY1TzVjN1ZLUWJkOXFGS0xxQ2dUajIydjgxWUZRcStn?= =?utf-8?B?NHMvSnJnOGtmRXFUTDI1dmppTkI2UlF0U2cremZMVHI0dDdBZysxWFFpMHpR?= =?utf-8?B?dnBlT2JCRUswOFF5VGdvS2F5SHZwNnhtYWhNMnFyLzNDYjdpRlh1blVFMERD?= =?utf-8?B?VlZCUzhUUjA4NnF1M1pMQThOZmxUZ0VtaGhQQlhGbkdrelc3Sk5NOFBnckdX?= =?utf-8?B?ajJvdjVXUDdaTk8yandCd3docW1OS2dXM3JTV3pYYk45UzVzRXh2bmNYR2Q2?= =?utf-8?B?ZnBIYmV2MGkzYzJKUFR0ZXdYOWFSZlBSc3lhRGZHNFNwZlQvOVR4ellSSHRy?= =?utf-8?B?N1NieTI0K3dpVXFYRUdpYWlENXlxQmFSN2U5Q1JaZ21LaytWL3hRV0FPWitj?= =?utf-8?B?UE1VUzBVZytKNEVneXpScTI0Q0VwTGxFMFRacSthUjJuRzNLb21hN0tSVjlm?= =?utf-8?B?RUZDVmxrTXI1NENvZXc1cnFITkt3cGFQOVlvODhlWHhSL2pjaGdwaitZM1Rh?= =?utf-8?B?MXkybi9jbmNyUWkwQXZzS016cDBNYlVPNW9ZQVdUdjN4VURzbDM5MDFFZ29F?= =?utf-8?B?ajZIeDZpY1BJTGpMNjNrOWJmMDFzVlVCdjBkTjRrazQ1ay9YQVdQbkE5UTk2?= =?utf-8?B?d2w2cms5S21LenYxZFI0ZERQSllGUUJlR0xKZVdUQlBpTUtiT290MW9YNUZj?= =?utf-8?B?c1ZEYVJTVEY0VkFaakJUODV4eFBVMDVmbGtvY0FRejZ6eDluRXUzNmYrWGVv?= =?utf-8?B?R3BwSGJmNXVXTGRwdTRHWUkzZkJzK1NDeTZkZUpRRnllOGwrUTN3d29mRVFZ?= =?utf-8?B?aEt6OU9GR0RxMWRtaSs0bVJxSExoRkdPNnp0dlZxU2RNcGo5TFoyd1dycU5q?= =?utf-8?B?MlhYZmplVWhkYk81YXFidnVzcWRSWmJpMW1KRDZob3pNbnNOYVM3Y1J2NHlY?= =?utf-8?B?czZ1NDloWmJFbXdjbmltMElqVGZ1Umh6QklKcnhrVm5vaG50YVpXcFNqVlRn?= =?utf-8?B?S3h3b2pSWWw5ZCs5NEhubkVNQ2grdVpOaU9zeVlwTnhJNmt5dDArU1l0SlZM?= =?utf-8?B?TVBQbXRSUUgwOGlJZURSQjJNNTlNVVE0Qy9XVGszb3BBcytxR2ZzaTkzMGJl?= =?utf-8?B?MDhJRjF2K3FnMHFnUmJJdjZJcUMwMFhyMW1VaW9vL3o0MnpIYkhEL1JvLzcr?= =?utf-8?B?aUtsbWkvM3FyeWx1NjNnQXFUMzJ2YzVMeExaM09FeVVmL0RCaFRYVmVZSHk0?= =?utf-8?B?dnR2KzROeWtxajNiMkZXQ2RRMHM4d3hTeWoxMkRadUJEOXUxSXRSTmdzamUw?= =?utf-8?B?K0dCZDIwUnpaTEZxUDRNay9lM2FCSnlZT0VsVTNPYko1UzR6WWlaS01xUU9J?= =?utf-8?B?L0d2WTdsVXZES2U1ZTRXSUIxeDBMSFlLaUVuNmgwVFB3bHZGbTBpYk5ieGZN?= =?utf-8?B?eDl1MWtXV0R3RmVqbk9OSkRpOEpwUnI5Tk12MXZtSmlTYjJxQnpib3gzdXE0?= =?utf-8?B?bGJQL3pQVnN3NTRjOHcxNTlmVGRCV3pkUkF6TGFOdnd3Q0t0dm1WYjFaVFBY?= =?utf-8?B?Mkl1blpVRDlEbC95Kys4V0JZOElrVVpPZ3NQMmpaWHU5Ym5lMUNVUmhxU3ow?= =?utf-8?B?bHg4WFpOdUhLdWhLRHVRNi84OWJYaU9OOFVwcmF1azJVT3FVL000MkFuTk10?= =?utf-8?B?ZGtpMFlhUlZTeXVSYlcrbGxSaEIxQlk3QU5vS1dWWUxWSFFoK1FnT3d1cjZE?= =?utf-8?B?SDJEVVpCRUEzZ0pNbVlkNllIdGdLMisxODRPWVBURjFjbHE4V0ZXbFd1VHRK?= =?utf-8?B?YlpnaGxZRU1rQVVHQ3BNOVBUOTRPaDR4akpQSW5RTFg5QkxQUVVTU3Zmc2xS?= =?utf-8?B?ajF5ZzUyZGhwZUhSUmp4MURkWFNIejlGWDJSTFdVRXFmZ3E5TUx0WUdBZEJV?= =?utf-8?B?ck1hODk3TU9zczI4UENWUm1xV0dzWGFISlNtQUVLYzUwTHFUMzhCbHpnZENZ?= =?utf-8?B?RDlIUHFBZWM0MmE3T2FjalZJYjVMaGtMYWx1M2dIRWFsbXRNcE8xcStxeUpS?= =?utf-8?B?RzZvdUFWMWx2SGs3bjR2anNmam13PT0=?= Content-Type: text/plain; charset="utf-8" Content-ID: <59F963B3DB1ED249ABCCDB5F30F0509D@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1597012d-3964-4b9f-f7c0-08d9fb8f0e0b X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Mar 2022 14:23:28.3258 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: c3teThOSoQ3SLo2G+EDlb/vazwhL9/cmC4FZWo1yw2+D3XksFMryW7UF/85D9g0ZXMM5D5mPLHJxL59/Anbe/pl6T3VpmUOF9LFtWuYVtUI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB3745 X-OriginatorOrg: citrix.com T24gMDEvMDMvMjAyMiAxMzozNCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDAxLjAzLjIwMjIg MTM6NDgsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBPbiAwMS8wMy8yMDIyIDExOjM2LCBKYW4g QmV1bGljaCB3cm90ZToNCj4+PiBTdWl0YWJsZSBjb21waWxlciBvcHRpb25zIGFyZSBwYXNzZWQg b25seSB3aGVuIHRoZSBhY3R1YWwgZmVhdHVyZQ0KPj4+IChYRU5fSUJUKSBpcyBlbmFibGVkLCBu b3Qgd2hlbiBtZXJlbHkgdGhlIGNvbXBpbGVyIGNhcGFiaWxpdHkgd2FzIGZvdW5kDQo+Pj4gdG8g YmUgYXZhaWxhYmxlLg0KPj4+DQo+Pj4gRml4ZXM6IDEyZTM0MTBlMDcxZSAoIng4Ni9hbHRjYWxs OiBDaGVjayBhbmQgb3B0aW1pc2UgYWx0Y2FsbCB0YXJnZXRzIikNCj4+PiBTaWduZWQtb2ZmLWJ5 OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+PiBIbW0geWVzLsKgIFRoaXMgaXMg ZmFsbG91dCBmcm9tIHNlcGFyYXRpbmcgQ09ORklHX0hBU19DQ19DRVRfSUJUIGFuZA0KPj4gQ09O RklHX1hFTl9JQlQuDQo+Pg0KPj4gUmV2aWV3ZWQtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJldy5j b29wZXIzQGNpdHJpeC5jb20+DQo+IFRoYW5rcy4NCj4NCj4+PiAtLS0NCj4+PiBGdXJ0aGVybW9y ZSwgaXMgIk9wdGltaXNlZCBhd2F5IC4uLiIgcmVhbGx5IGFwcHJvcHJpYXRlIGluIHdoYXQNCj4+ PiAzN2VkNWRhODUxYjggKCJ4ODYvYWx0Y2FsbDogT3B0aW1pc2UgYXdheSBlbmRicjY0IGluc3Ry dWN0aW9uIHdoZXJlDQo+Pj4gcG9zc2libGUiKSBhZGRlZD8gSWYgdGhpcyByZWFsbHkgd2FzIGFu IG9wdGltaXphdGlvbiAocmF0aGVyIHRoYW4NCj4+PiBoYXJkZW5pbmcpLCBzaG91bGRuJ3Qgd2Ug cHVyZ2UgRU5EQlIgYWxzbyB3aGVuICFjcHVfaGFzX3hlbl9pYnQsIGFuZA0KPj4+IHRoZW4gaWRl YWxseSBhbGwgb2YgdGhlbT8gV2hlcmVhcyBpZiB0aGlzIGlzIG1haW5seSBhYm91dCBoYXJkZW5p bmcsDQo+Pj4gd291bGRuJ3QgdGhlIG1lc3NhZ2UgYmV0dGVyIHNheSAiUHVyZ2VkIiBvciAiQ2xv YmJlcmVkIj8NCj4+IEkgZGlkIGhhdmUgYW4gUkZDIGFib3V0IHRoaXMuwqAgVHVybmluZyBFTkRC UiBpbnRvIE5PUDQgbWF0dGVycywgb24gYQ0KPj4gQ0VULUlCVC1hY3RpdmUgc3lzdGVtLCB0byBy ZXN0cmljdCB0aGUgYXZhaWxhYmxlIG9wdGlvbnMgYW4gYXR0YWNrZXIgaGFzDQo+PiB3aGVuIHRo ZXkgaGF2ZSBhbHJlYWR5IG1hbmFnZWQgdG8gaGlqYWNrIGEgZnVuY3Rpb24gcG9pbnRlciAoaS5l Lg0KPj4gYWxyZWFkeSBnb3QgYSBwYXJ0aWFsIHdyaXRlIGdhZGdldCkuDQo+Pg0KPj4gRnJvbSB0 aGF0IHBvaW50IG9mIHZpZXcsIGl0IGlzIGhhcmRlbmluZy4NCj4gQnV0IHRoZW4geW91IGRvbid0 IHNheSB3aGV0aGVyIHRoZXJlJ3MgYW55IG9wdGltaXphdGlvbiBhc3BlY3QgaGVyZS4NCj4gTXkg cXVlc3Rpb24gd2FzIHJlYWxseSBhYm91dCB0aGUgd29yZGluZyBvZiB0aGF0IGxvZyBtZXNzYWdl Lg0KDQpUaGUgb3B0aW1pc2F0aW9uIGFzcGVjdCBpcyBkaXJlY3QgYnJhbmNoIHRhcmdldCArNCwg YmVjYXVzZSB0aGF0IGlzIHdoYXQNCnNhdmVzIG9uIGRlY29kZSBiYW5kd2lkdGguDQoNCj4NCj4+ IFRoZSBmaXJzdCB2ZXJzaW9uIG9mIHRoaXMgbG9naWMgd2FzIHRyeWluZyB0byB1c2UgVUQxIGlu IHRoZSBzYW1lIHdheSBhcw0KPj4gTGludXggZG9lcywgdG8gaGFyZGVuIG5vbi1DRVQgYnVpbGRz IHRvbywgYnV0IHRoYXQgZG9lcyBkZXBlbmQgb24gaGF2aW5nDQo+PiBvYmp0b29sIHNvIGFsbCBk aXJlY3QgYnJhbmNoZXMgY2FuIGhhdmUgdGhlaXIgdGFyZ2V0cyB1cGRhdGVkIHRvIG1pc3MNCj4+ IHRoZSBVRDEgaW5zdHJ1Y3Rpb24uDQo+IEkgdGhpbmsgaXQgd291bGQgYmUgcG9zc2libGUgKGJ1 dCBsaWtlbHkgY3VtYmVyc29tZSkgdG8gYXJyYW5nZSBmb3INCj4gdGhpcyBhbHNvIHdpdGhvdXQg b2JqdG9vbC4NCg0KSXQncyBvbmx5IHVzZWZ1bCBub24tQ0VUIGhhcmR3YXJlIHRvIGNyb3NzLWNo ZWNrIHRoYXQgdGhpbmdzIHdvbid0DQpleHBsb2RlIHdoZW4gQ0VUIGlzIGVuYWJsZWQsIGR1ZSB0 byBtaXNwb3NpdGlvbmVkIGJyYW5jaGVzL2V0Yy4NCg0KQW4gYWN0dWFsIGF0dGFja2VyIG9uIG5v bi1DRVQgaGFyZHdhcmUgd291bGQganVzdCBhZGp1c3QgdGhlIGZ1bmN0aW9uDQpwb2ludGVyICs0 IHRvIHNraXAgdGhlIFVEMS4NCg0KPj4gUC5TLiBJJ2Qgc3RpbGwgbGlrZSB0byBoYXZlICJhd2F5 ICV1IG9mICV1IGVuZGJyNjQncyIuwqAgSXQgb2NjdXJzIHRvIG1lDQo+PiB0aGF0IG5vdyB3ZSBo YXZlIGNoZWNrLWVuZGJyNjQuc2gsIHdlIGNvdWxkIGB3YyAtbGAgdGhlICRWQUxJRCBmaWxlIGFu ZA0KPj4gcmUtbGluayB0aGlzIGJhY2sgaW4sIGJ1dCB0aGVuIHdlIGNvdWxkbid0IGNoZWNrIHRo ZSBmaW5hbCBvYmplY3RzLg0KPiBJIHdhcyB0aGlua2luZyBhYm91dCB0aGlzIHdpc2ggb2YgeW91 cnMgYXMgd2VsbDsgSSBzaW1wbHkgZGlkbid0IGtub3cgaG93DQo+IGltcG9ydGFudCB5b3Ugdmll dyBpdCB0byBoYXZlIHRoaXMgaW5mb3JtYXRpb24uDQoNClRoZSBtb3N0IHVzZWZ1bCBwaWVjZSBv ZiBpbmZvcm1hdGlvbiBpcyBob3cgbWFueSBFTkRCUjY0J3MgcmVtYWluLA0KYmVjYXVzZSB0aG9z ZSBkZW5vdGUgdGhlIGV4dGVudCBvZiB0aGUgYXR0YWNrZXJzIGFiaWxpdHkgdG8gaGlqYWNrDQpm dW5jdGlvbiBwb2ludGVycyB3aXRob3V0IHN1ZmZlcmluZyAjQ1AuwqAgSWRlYWxseSwgdGhlIG51 bWJlciBwcm9kdWNlZA0KYXQgYm9vdCB3YW50cyBjcm9zcy1jaGVja2luZyB3aXRoIHNjcmlwdCB3 aGljaCBjYW4gdGFrZSB4ZW4tc3ltcywNCmNhbGN1bGF0ZSAkVkFMSUQgLSAkQ0ZfQ0xPQkJFUiBh bmQgaWRlbnRpZnkgYWxsIHRoZSBleHBlY3RlZA0KcnVudGltZS1hY3RpdmUgdGFyZ2V0cy4NCg0K QXQgdGhlIG1vbWVudCwgSSBjYW4gZ3Vlc3RpbWF0ZSBiYXNlZCBvbiBrbm93aW5nIGhvdyBtYW55 IHdoZXJlIGRpc2FibGVkDQphdCBib290IHRpbWUsIGFuZCBob3cgbWFueSB3ZXJlIGluIHRoZSBv cmlnaW5hbCBidWlsZCwgYnV0IEkgZG9uJ3QNCmV4cGVjdCBhbnlvbmUgZWxzZSB0byBrbm93IHRo YXQgYW4gYWxsLWVuYWJsZWQgYnVpbGQgb2YgWGVuIGlzIH4xNjAwDQpFTkRCUjY0J3MuDQoNCn5B bmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Tue Mar 01 14:24:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 14:24:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281537.479909 (Exim 4.92) (envelope-from ) id 1nP3QT-0006mz-LT; Tue, 01 Mar 2022 14:24:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281537.479909; Tue, 01 Mar 2022 14:24:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP3QT-0006ms-IQ; Tue, 01 Mar 2022 14:24:29 +0000 Received: by outflank-mailman (input) for mailman id 281537; Tue, 01 Mar 2022 14:24:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP3QS-0006mi-AY for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 14:24:28 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4bc9197c-996b-11ec-8539-5f4723681683; Tue, 01 Mar 2022 15:24:26 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4bc9197c-996b-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1646144666; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=xaici8cdAXimItpFNgulJa2mXejsU3sDY7hjdE8UlLQ=; b=QD4ZepsellU1xXKNCjnaDhoS5ZJipAalYPFYPnmv1p5thKy1OTnCPZuB lpsOfxq6LRNRvRaJ3fKPqMDSt5JZg9IhR/6OwFyHIMXVqTEGG6YMMvqMt KZiSbeoemyZgi1Gw/8J3RobF0blhv2lVTNssl5D7o4N2l/G9wHTd+nejQ w=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com X-SBRS: 5.1 X-MesageID: 65629341 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:tQ7ICa6zI79f/CF9pXTGTwxRtCXHchMFZxGqfqrLsTDasY5as4F+v mEfDWrQbK2DMTHwKdt1Ot/n9E5V7ZLTnNZhQAY9rS5mHi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0XqPp8Zj2tQy2YPhWlvX0 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx umhurSZSAoAObfhg90vVjgfMyNiAohl/bjYdC3XXcy7lyUqclPpyvRqSko3IZcZ6qB8BmQmG f4wcW5XKErZ3qTvnez9GrIEascLdaEHOKs2vH16wC6fJvEhWZ3ZGI3B5MNC3Sd2jcdLdRrbT 5REN2A+N0iZC/FJEgYYVqwskr33umTUYSdJuXSTj6YOsneGmWSd15CyaYGIK7RmX/59jkue4 27L4Wn9KhUbL8CEjyqI9Gq2ge3Clj+9X5gdfJWn8tZ6jVvVwXYcYDUUX1ampfiyimalRslSb UcT/0ITQbMarRLxCIOnBlvh/SDC7kV0t8ds//MSwQCA463Ozh2gNG0lCR5DdOMDl8oxWml/v rOWpO/BCTtqubyTbHuS8LaIsD+/URQowX8+iTwsFlVcvYS6yG0npleWF4s4Tvbp5jHgMWyom 1i3QD4Ca6L/ZCLh/4Gy5hj5jj2lvfAlpSZlt1yMDgpJAu6UDbNJhrBEC3CGtZ6sz67DFzFtW UTofeDEtIji6rnXyUSwrB0lRu3B2hp8GGS0baRTN5cg7S+x3HWoYJpd5jpzTG8wbJpaIWCyP hOK4FoAjHO2AJdMRfUsC25WI553pZUM6Py/DqyEBjawSsIZmPC7ENFGOhfLgjGFfLkEmqAjI 5aLGftA/l5BYZmLOAGeHr9HuZdyn3hW7TqKGfjTkkT2uZLDNSX9YepUbzOzghURsfrsTPP9q I0EaaNnCnx3DYXDX8Ug2dVLfABScCNiXsieRg4+XrfrHzeK0VoJUpf56bggZ5Zkj+JSkOLJ9 Wu6QUhW1Bz0gnivFOlAQioLhG/HNXqnkU8GAA== IronPort-HdrOrdr: A9a23:2Qev1aijkG6JbpFT8WotB/UDB3BQXvMji2hC6mlwRA09TyXPrb HXoB19726RtN9xYgBEpTjjUJPrfZq4z/NICOYqUYtKMDOIhILKFvAB0WKB+V3d8nbFh5dgPM 5bGsAUNDSXNzZHZK3BkWqF+rgboeVuX8qT9JzjJ9sGd3AMV0nAhT0JbDqmLg== X-IronPort-AV: E=Sophos;i="5.90,146,1643691600"; d="scan'208";a="65629341" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PgqthP5GVfvcYFFXb0iWzUAT3RDKoD8Z2XNYajkVkXMpXffcZ2p0pcWNCjQGzFGCiyf24ceIYDOV/U3aaHo7ZVSq0rWml/7MecIew7H4ENz1mEDnUzKlmudlBs2DUVqg220/N4AsWmAUHKUaZp/JS8eiX6cgQIkgp4NcUgA8MGjhKGAa5tORZGZYApfYUm/ofZ6Wnl2fvWMAl7voAk3TIYeEZuzSBXTPRT6TX5xadT0aU/Xbbq3quROdaN8fzIMgIttE6yTclJTwpHsOEjzdtfq0xHFrQ9MKwGwTDBEughjc/ze74fFUW6pYJwktdMzF5pD+Kq75rfBGSEnmdT/wSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xaici8cdAXimItpFNgulJa2mXejsU3sDY7hjdE8UlLQ=; b=J4wbyKpoWThswLti/VQ/16UiPZPs8PZaKg1vT5ao1kp3uAwIDtX7QwJiDaAPEZF/kj8eOdP67HVWhuDi5yIgI05b/XiIeM4RRiHCu1J9XqQJmbTZy0cFV144YsYAmRFqCNL1WAyQoB2K4V3dGbajB5kjrSpgln7AN/oOwhsF87yGhTaB7lhZznfrSM2Vjo/JhvfgEWEs9Wm63BagbX56FFfblfwRGWNErG7+Cqt5r32GnQKX6WJab78rvW9ZdJvqNNBdCY2BaVArUzGvbLvyc54u22dt7N+hlrz7OvIEUvw72exSRODiB3bBFyMG4ToR58eBGZbvZDBMQ3G3r1vIkw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xaici8cdAXimItpFNgulJa2mXejsU3sDY7hjdE8UlLQ=; b=HpzvPHOqNa4A3FPl6cxAcRSrdpocNJ3WctH8COgLszBn3n8LVTbgr3Z287cZNyXbI7Xc83EuO7U1/lehknpvmAsYwBX65MSjeZZ6SlpXNgW9W7w33lkB5JYVHBN75as86CJu78Wjiz8x2B4YHDL2NIdemJ+CMJw4cgKFF/XctLU= From: Andrew Cooper To: Jan Beulich CC: Wei Liu , Roger Pau Monne , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH 2/2] x86/time: add CF-clobber annotations Thread-Topic: [PATCH 2/2] x86/time: add CF-clobber annotations Thread-Index: AQHYLVxwam4XOlcoM0qksn/nZK0dPqyqgvIAgAAQwwCAAAGngA== Date: Tue, 1 Mar 2022 14:24:21 +0000 Message-ID: References: <77675e7f-2a7e-f517-4aba-e20774c8bfe5@suse.com> <61bbf544-74ac-b698-425a-d1db80acab43@suse.com> <20185a89-0a2b-6bbd-5484-31b6582ed200@citrix.com> <40ce913e-4388-2d2f-45e3-e725a927da92@suse.com> In-Reply-To: <40ce913e-4388-2d2f-45e3-e725a927da92@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 80dcb7a7-b2a5-4b90-27f0-08d9fb8f2da0 x-ms-traffictypediagnostic: BN7PR03MB3745:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: NYncMaXCEl+RmN+2SRkR9dcduHWyQG85jXMIjAXJp7xw49hvCm2wmFrzzA0w4LFWqfHlbCUdDQlqe22ZvESgoiglbG61rCiEEZCTv2GlL5Kdk0U9mFc8wZDf98iBd17QIo1tfZpHtFrYmUAS5e0adfVhdskOF0WWxNaQ0rpFwEGyWaoPhad0gnMqbbKyO6eC8wqthOaRawZ6/5cI+kxJFgEPPR2O6pGG9fweUjhaGj5V+y+zrpPjiBP2nD8xmS9FkYi1cX6POAlMO9fwdYLhNx50QbjLdHDwV14dcNkKhbBmPlXGWB5hHN4CM8+e8KH+3aGjUnDaIsqHSLFYPlbuhVDue1Cx6ky/Wz9N39RNnhV9q1JfFH+PE0/n6jJAdo4uab/NgBUaCTX8abjTXSu++HW2PLWd8eeM5L12M1Khz72TKN6LZyWNqhMoo/9L15fco1nOSvEgzQRlnCg3Rojh9tGPWacbzujpKFTTu8NQ96i3yKduORHpaK3DoTao9K9r6+YJtKf6G7j8TVKA9wZzfZTVrumqdaMeh/j1kPHOQ77R1r8NiGRzGT3C3pnBxbPIVrkElg2YZR6M3q773qtgXqFjNlQoSyfSZxfRiPX97tZ3X8RAhmjuNkgapyyjxW6oYKmzF7pBnQF97ydx8a0ew/aGwu/ebFilZhrtOSAwroDSkGhkhpmOQlW5olO/OzOBa314hfTD3bvguZPcYoRHAP4x95J/Roz73OT1lr09aLEvfx48wCFiYHxoMLB8Q5IvfVOWIDwp9cHF+3UgBfll4g== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(71200400001)(6486002)(508600001)(8676002)(5660300002)(36756003)(53546011)(6506007)(54906003)(6916009)(316002)(82960400001)(91956017)(122000001)(8936002)(64756008)(66446008)(66476007)(4326008)(76116006)(66556008)(38100700002)(66946007)(6512007)(186003)(38070700005)(31686004)(86362001)(31696002)(2906002)(2616005)(83380400001)(26005)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?dWtaMklocGxqZFdZN05JZlczNHNib05COXRqNFQ3d3hXOFZ5WWh6NjBHMWkz?= =?utf-8?B?alVFU2tZaVZBdTFBUFMzR3plOTBNN1dYS1dQY0pSVVcycEVkQkovUjlad05T?= =?utf-8?B?dDMyQy9UNmJVK1NWb1orVDhqY1hDK0tMQ0REVDg5eDBIbUZiQURYYmowa1Fh?= =?utf-8?B?b0ZSQS95VmZ2eUVOM3IvbGFUN2dCc1JpTjREVXhrdmZTeW9MWXRkSGtPY1pM?= =?utf-8?B?R2M3OFlJZVdhKzB1S0QzQ3hXdm03clh3bkNGVSt6Z3Z3NDdJOFhBdDllOGo2?= =?utf-8?B?cTVXK21PcjlmbTlaVjcwOXNGTHBqenlsUWRYc1ZINFVnL1dFTUpMbGJJTXFX?= =?utf-8?B?dXZVOEViWnNNNHFUQlZFNW1VMnQ3MENUSEFKYmU5bG5jVnlzMkRLTVliVzEy?= =?utf-8?B?V3N3cmZrQ0grZlNISVpkZXdKK3k4b0hwaUcwRE9tUTRFbjJ5T2prb0xYeGRm?= =?utf-8?B?NTR2TXYrMVZCZ09HYUYzMDJjTng0VXBpMWM5Vks0cGxqdGhod2JDTmJ5NFAy?= =?utf-8?B?UFRyd2lsMGRhN2JtaDdQd1JNazNwUy9WMnpZNGV6aHVKSjd4WmpOc3lKQVBm?= =?utf-8?B?c3VRQUxTNzB5d0p2SmlJbXNwZHd3T3NPelhENEVLeVk0MlViRU1lUDV6OERH?= =?utf-8?B?T1BNNDg3N1orSldTbUFFUFZZa2NhOWhLcFFKdlNrU1ZBYmJKR1VjeVZ0S3J6?= =?utf-8?B?Zlg5bTkvVDBPdnIxS04rZjUvWFdxdElkT3VEM0RRZk5mY2xadXdVZ21jTU1Q?= =?utf-8?B?WS9pZzB0eThCTjIzMzFMTGpzbE9kSHRjUFR5VnBHNGxpM1hwZ3hUK3BrU0FF?= =?utf-8?B?WWRJeHhFZW51SVJRekFQa3cvSU50cW55MVF5Zm90UVhhL0h1VEkyWnN2aEJY?= =?utf-8?B?cXZQRjFya21nNTA0bnd0NEtmYXBtdEF2QXZQUWw4Y25DdVpNbWZpbW5ZTDZk?= =?utf-8?B?SmpoR3lBMlFuV0xlaW9mREtGNkQ1YTBzNDYyeng4alYzM0ZZcEt0VUNMRVhz?= =?utf-8?B?SDAvMVQrem40QUJ0QmkwaVA3dkJ5V1V3aTk3Ti9WRTRvRG9Ca1NmUFJLMTNH?= =?utf-8?B?bXNhUzRKWU5vbFRzU0VENkM2KzVUN1dnQlRnUUV4ZHRVTUxTWE1SSDhDejZt?= =?utf-8?B?SDFDT2hQQjVqYlZ0Mm5IOUhDMzN2SjFaRkxKYngwcXJHbnNNM1JpZExQMnZK?= =?utf-8?B?am5LS1BjY3BGKzRjaGszVlRSQm1lOFk5RkhIaU1nUjZZbG9XdmNjSkhjM0lw?= =?utf-8?B?ekdVUnVIdXZxYjZJSUR1WWJqWVBYS295aTg4Z09Hdjd0bk5UNVVvTUgzYU9P?= =?utf-8?B?TW1RQ2ViMGw1emNsWmlqTHdxdEJHRXMyWXl4MG50VVhLR0xVdmowcGpDSSti?= =?utf-8?B?MXltWXdIQXE4T2JVUW9OYlJQQ3M2ZHFEcTJTY1RkN3luakYydmxpWHF4ZTl3?= =?utf-8?B?cExER3cyS3B2cUFzNjludFFWeGNCRzN5MjZaMGpwdWVCcm5ycFZOb29FM0xI?= =?utf-8?B?ekhpSDNwQ1J4Tnk2NHFtcUZPT1BZTmRnRHVKRGJ5Ymt0cXNraHNTUEZ2d1JL?= =?utf-8?B?aEhlRGswR0VheHJlTGExMTYwSGJiaDZpMXZuemtLdkUzdS9IMzgvYkcrdkxX?= =?utf-8?B?R1RWamh6WVovdWVZdDVaT3BiRkNueTMwamFmK0x3RFNoY01mSTlONG1Lb3RY?= =?utf-8?B?SnZkR3VyNVovbVdRV2hRQTZZMmF5RjFzaDZRSk1IcjJyc2gwWEZINDh6WG1X?= =?utf-8?B?ajBDSS82dXo4dEkxcTBBdjFjR1NsUkFacTBDRjRPS0lTMmxGYkFrdnJvUWNO?= =?utf-8?B?V2xSS3lHc01pK3Y5bnBLSzE5TVorWEJCMi9HSEsrK2d2cTNBbE00NFBqaVg3?= =?utf-8?B?bVJpSDZTaFZ0cisxQTNhODRKUjNJYzkvNmxYZVFhS21CR3ZEaTRzZDdwOXBU?= =?utf-8?B?ckJCUkFXYXlQZ2N2N3hZdlhYbkZ4alp5TWJMbjAvWjVWNDJWVkovUzZDSzcy?= =?utf-8?B?WWFCeHlkQ05mQi9zNkEwS0V2TmJHTTJMdEhGejJnZU8raFkrVEJVbUw1Vk8r?= =?utf-8?B?TC9tSjJLLzNRM3phd1pLZjZ6ODEzQWFFekNWUlE4UDdvRWUzT3k0cy9vaWZG?= =?utf-8?B?MmJoRE9MQWptQ0twQ0d5YkJSNlBScGd0YUxNS2dzZ3pHWHdMeGNUTkJZamlK?= =?utf-8?B?V1JCWG5zNm9qQkJGaTBldlIwYUdSZjl6ZUNkcEYzcTE3L1lIMk1OMFgwRmJs?= =?utf-8?B?bnBpd0l6MHd3ZVNVNUJ4UXZIanJ3PT0=?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 80dcb7a7-b2a5-4b90-27f0-08d9fb8f2da0 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Mar 2022 14:24:21.3220 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: JzGguSLShiN9jBOvWi2w8vitgSPvh0LMb6yzaUJRTsdnOHtdSkez2Q3H9ZkCrXimxlEOF7eT8Ymz1SNDdLllAttk38HY729P90l+A+HTUX4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB3745 X-OriginatorOrg: citrix.com T24gMDEvMDMvMjAyMiAxNDoxOCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDAxLjAzLjIwMjIg MTQ6MTgsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBPbiAwMS8wMy8yMDIyIDExOjA2LCBKYW4g QmV1bGljaCB3cm90ZToNCj4+PiBXaXRoIGJlZDlhZTU0ZGY0NCAoIng4Ni90aW1lOiBzd2l0Y2gg cGxhdGZvcm0gdGltZXIgaG9va3MgdG8gYWx0Y2FsbCIpDQo+Pj4gaW4gcGxhY2Ugd2UgY2FuIGZ1 cnRoZXIgYXJyYW5nZSBmb3IgRU5EQlIgcmVtb3ZhbCBmcm9tIHRoZSBmdW5jdGlvbnMgbm8NCj4+ PiBsb25nZXIgc3ViamVjdCB0byBpbmRpcmVjdCBjYWxscy4gTm90ZSB0aGF0IHBsdF90c2MgaXMg bGVmdCB1bnRvdWNoZWQsDQo+Pj4gZm9yIG5vdCBob2xkaW5nIGFueSBwb2ludGVyIGVsaWdpYmxl IGZvciBFTkRCUiByZW1vdmFsLg0KPj4gSSdkIGJlIHRlbXB0ZWQgdG8gaW5jbHVkZSBpdCwgZm9y IGNvbnNpc3RlbmN5IHNha2UgYWxvbmUuDQo+Pg0KPj4gSXQgaXMgbGVzcyBsaWtlbHkgdG8gZ28g d3JvbmcgaW4gdGhlIGZ1dHVyZSBpZiBhbm90aGVyIGhvb2sgaXMgaW50cm9kdWNlZC4NCj4gQ2Fu IGRvLCBzdXJlLg0KPg0KPj4+IFNpZ25lZC1vZmYtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBz dXNlLmNvbT4NCj4+IFdpdGggdGhlIGNvbW1pdCBtZXNzYWdlLCBJJ20gbm90IG5vdCBjZXJ0YWlu IGlmIHRoaXMgaXMgbGlua2VkIHRvIHRoZQ0KPj4gcHJldmlvdXMgcGF0Y2guDQo+Pg0KPj4gT3Zl cmFsbCBpdCBsb29rcyBmaW5lLCBidXQgSSdkIGxpa2UgdG8gZ2V0IGNsYXJpdHkgb24gdGhpcyBw b2ludC4NCj4gQ29udmVydGluZyByZWFkX3RzYygpIHdhcyBkaXNjdXNzZWQgKHdpdGggUm9nZXIp IGVhcmxpZXIgb24sIHNvIEknZA0KPiB2aWV3IHRoaXMgYXMgYSBzZXBhcmF0ZSBjaGFuZ2UuIEFz IHNhaWQgaW4gcmVwbHkgdG8geW91ciBjb21tZW50cyBvbg0KPiB0aGUgMXN0IHBhdGNoLCBob3cg ZXhhY3RseSByZWFkX3RzYygpIGxvb2tzIGxpa2UgaXMgb3J0aG9nb25hbCB0bw0KPiB0aGUgY2hh bmdlcyBoZXJlIGF0IGxlYXN0IGFzIGxvbmcgYXMgaXQgZG9lc24ndCBsaXZlIGluIC50ZXh0Lg0K DQpPay7CoCBSZXZpZXdlZC1ieTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4 LmNvbT4NCg== From xen-devel-bounces@lists.xenproject.org Tue Mar 01 14:35:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 14:35:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281545.479920 (Exim 4.92) (envelope-from ) id 1nP3b0-0008Tu-M9; Tue, 01 Mar 2022 14:35:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281545.479920; Tue, 01 Mar 2022 14:35:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP3b0-0008Tn-J6; Tue, 01 Mar 2022 14:35:22 +0000 Received: by outflank-mailman (input) for mailman id 281545; Tue, 01 Mar 2022 14:35:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP3az-0008Tg-Ep for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 14:35:21 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d1066318-996c-11ec-8eba-a37418f5ba1a; Tue, 01 Mar 2022 15:35:20 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d1066318-996c-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1646145319; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=RIry1fOwgDOAhhdNZBm4dA+nFybFDJJ02i51Nkot6Mw=; b=SYSvDnzSAHisyHGZ9ap3QYX1jONDJBbN0U8QSBQH2WsEm1IlfG7xxafj Cm8TWIA/lXf9Hd/8dkiuRvmq6U49Mx0yGlMqxwCs0ozRCAvwBi48ENjCC Z0IqrLpfIuO+87Kve3bmvwdALtLsB7ANHliD19JHgqqm4MmW72QfStJ+M I=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com X-SBRS: 5.1 X-MesageID: 65122601 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:6ZJvbaJxeUIXCfTXFE+RzJUlxSXFcZb7ZxGr2PjKsXjdYENS1DVTz GAeC2zTa/fYZ2ejct9/adnn/U4DsJWGz4cxSFBlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA148IMsdoUg7wbRh2dYx2YLR7z6l4 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4 Mlxj5iCexVyAvHFveIZehcGIWZxBbITrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq 6ZecmpUKEne2aTmm9pXScE17ignBODtMJkSpTdLyjbBAOx9aZvCX7/L9ZlT2zJYasVmQ6uHP ZBHMWMHgBLoOSUWKlhHN60Hl9yMnGOjQmcfpn/OnP9ii4TU5FMoi+W8WDbPQfSaSMMQkkuGq 2bu+2XiHgpcJNGZ0SCC8H+nmqnIhyyTcJ0WPK218LhtmlL77m4ZBQASVFC7ieKkkUP4UNVaQ 3H44QJ38/J0rhbyCICgAVvo+xZooyLwRfJML9c+2jOfkZaI6iOfAkEKEAwGZ+Q54ZpeqSMR6 neFmNbgBDpKubKTSG6A+rr8kQ5eKRT5PkdZO3ZaEFJtD83L5dhq00mRFooL/Lud04WtcQwc1 Qxmu8TXa187qccQn5u28lnc695HjsiYF1Vljuk7s4/M0++YWGJHT9HwgbQ4xawZRGp8crVnl CJc8yR5xLpTZaxhbATXHI0w8EiBvp5pygH0j191BIUG/D+w4XOldo04yGggeBkxbZ1aJWawO R67VeZtCHl7ZiDCgUhfOd/ZNijX5fK4SYSNug78NLKinaSdhCfYpXozNCZ8LkjmkVQ2kLFXB HtoWZ3EMJruMow+lGDeb75EidcDn3lirUuOFcGT50n2itK2OS/KIYrpxXPTN4jVGovf+16Lm zueXuPXoyhivBrWOXGGodZOdglRdRDWx/ne8qRqSwJKGSI/cEkJAP7N27IxPYtjmqVejODT+ X+hHERfzTLCabfvc21mtlgLhGvTYKtC IronPort-HdrOrdr: A9a23:lvUFNKwThFY8ND8YH9CJKrPxguskLtp133Aq2lEZdPULSKOlfp GV8MjziyWYtN9IYgBcpTiBUJPwJE81bfZOkMYs1MSZLXXbUQyTXc9fBOrZsnHd8kjFmNK1up 0QCpSWZOeAbmSSyPyKmjVQcOxQgeVvkprY/ds2pk0FJWoBCsFdBkVCe32m+yVNNVJ77PECZf 6hD7981lydkAMsH6OG7xc+Lor+juyOsKijTQ8NBhYh5gXLpyiv8qTGHx+R2Qpbey9TwJ85mF K10zDR1+GGibWW2xXc32jc49B9g9360OZOA8SKl4w8NijssAC1f45sMofy/wzd4dvfqmrCou O85yvIDP4DrE85uVvF5ycF7jOQlQrGLUWSkGNwz0GT+fARDwhKdPapzbgpDCcxrXBQ5u2UmZ g7r15w/fBsfGL9tTW46N7SWx5wkE2o5XIkjO4IlnRaFZATcblLsOUkjQho+bo7bWvHAbocYa FT5QDnlYJrWELfa2qcsnhkwdSqUHh2FhCaQlIassjQ1zRNhnh2w0YR2cRaxx47hd8AYogB4/ 6BPrVjlblIQMNTZaVhBP0ZSc/yDmDWWxrDPG+bPFyiHqAaPHDGrYLx/dwOlauXUY1NyIF3lI XKUVteu2J3c0XyCdeW1JkO6RzJSHXVZ0Wa9iif3ekPhlTRfsuYDcTYciFcryKJmYRrPvHm X-IronPort-AV: E=Sophos;i="5.90,146,1643691600"; d="scan'208";a="65122601" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ud0D7KWKwR5HreP7O4N3VXBGd/tNEok3yj2fthRAwtl67+Fh9YMFcmVa1HSgy2wp+wPXrSy2IL3tgfAf/aifUCyLjCRZt97ghZHRPECqmzJVqdpNrSEsAd/bzfLEsrbxnFuWzAXT5otdJDFwBUHM7uvZIyK8WQoVISExkzoV3S1CwdYp+SX1fp5GAJ8DjKA8Ylf8wvEMRpC1qw6HlzXxjaEHOxj+ZY/hvfjqXInhOMpkl21Ly3LlwAxYirhGIgKF28qK3gFroWKFE/D3jKHGDieHv7jZJDlNtBu0rHhyAK0pwlYPcdWkQvjQPS2TlT6761/iGENKojlJi5JDtxCLSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RIry1fOwgDOAhhdNZBm4dA+nFybFDJJ02i51Nkot6Mw=; b=inQN0SYw0XGZ/EJ+uJwgnROxfWQNx5khB3N0e/wt/ClR335+lxZ+DFGYctOi8yFd8TLmo+LupS9QE0brkFiJhIT+HeUwvZF21VStFE/oSIrlZPyFyoCs7lnVWj3J8w0BJdsXw2Lhk8KVbR5oWkM5CwFhqQmX5tf5rSQsfk5ptNU8KHbY51NBAZPUI3hNATgDr7XXqdXBfAS2MyEj6t+Nf94YTdNQiLcZq3aOeuIqKPtqqyn5BdJr5sfyF8LAW2nm8y7a/MTW4Cd/O4L+FLREtsbS8+e0ZOTcIJozHtvkVibbfYhbyo+WW1+fW+c74flJvHSTq8kHE6HDUwjPd8iT8Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RIry1fOwgDOAhhdNZBm4dA+nFybFDJJ02i51Nkot6Mw=; b=tJKkDYODkdKA3OgIBmNn76aJY3Vija9AaAFaw0h8yInYWPKn62zGlORpu5JVEYI8z/7UhGw1L3ol49SK9iukFRKlTR6zJVtWOWWz6TY54Qgo3g8zHVeohHSwKxh2uCLXfVbLR5INQGsqh882Yy8HSezWm2GD3J+pKk3AxPMsK/I= From: Andrew Cooper To: Jan Beulich CC: Wei Liu , Roger Pau Monne , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH 2/2] x86/time: add CF-clobber annotations Thread-Topic: [PATCH 2/2] x86/time: add CF-clobber annotations Thread-Index: AQHYLVxwam4XOlcoM0qksn/nZK0dPqyqgvIAgAAQwwCAAAGngIAAAwqA Date: Tue, 1 Mar 2022 14:35:14 +0000 Message-ID: References: <77675e7f-2a7e-f517-4aba-e20774c8bfe5@suse.com> <61bbf544-74ac-b698-425a-d1db80acab43@suse.com> <20185a89-0a2b-6bbd-5484-31b6582ed200@citrix.com> <40ce913e-4388-2d2f-45e3-e725a927da92@suse.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: caf351aa-73e9-4045-22af-08d9fb90b2d8 x-ms-traffictypediagnostic: MW4PR03MB6458:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: IZ8lP/gkC+nzp44go3t55jDzTK1nt0qUd8e4l+SsApbmEqn6bLdCqg3pXqG/hMMXeTN4SIPaZHiHrrRn8bowdxbWslljP8JjKsxXxURMm10jpluVEbLuIuogyVwXlSkMEVWMcmw06tMLMj3CFCx8LB7vTOb/xchQ8QzcebQY3IGz1/9CWH+mfbyrH8MmQJXpC5XU4HcAs4ex/192F0P0RsYMtZTfB/dv438nnAY1c+OMH3MQRUM81Y8X7cAlwFpvQGR9JPpuh6onGDq3/H/pSYZI0fE8M2XvflwnkqSCliGwBr2v+bZKsq6xUga50JaEOjpo++XqYJRwEgT0CLr+csifUKuoCi9pNRfNk+2YOnIFBZC6mimXyVW7+T88CHld7pRp0ILCeQKdr3CETP3DWSjjq6IMJcFvzZD6zuqWfCUEdX/73TGXlbgco+Pgy6dfNqHzjWlD31aAn90KVj1Vox7q/JDS/h6LMlTWKIgcSiLkmNyQLb7TAEvdmxY8DNBFbeGby1wu/9yTeXYNexM9RajW2pRCEkg2/Q+jg/NaaABm5R/sd9Vg30PmNbF7N/StCBjefF+5E38Ku2cywEhWe6ask5FrQNBhM/G6vLe173wbPjI/eCS3VlmSa5mlB16QmzuU6Pfo7Wu7er8bux3pOzD38mFvugYzQZBkmOxxIbnm+VVMycuvymBTbnDm0tBWvKqVjFzFzE9bA/alrSMwhOUeEPs2NYy0f/O/hYfkHs6x0RPTI9CiPxv+vHh1oLPSPbtoexzBUSD72tuuPZ5xkA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(508600001)(38100700002)(2906002)(76116006)(71200400001)(26005)(5660300002)(8936002)(83380400001)(31686004)(186003)(6512007)(36756003)(2616005)(6506007)(53546011)(6916009)(54906003)(4326008)(8676002)(66556008)(66946007)(91956017)(66476007)(66446008)(64756008)(122000001)(38070700005)(86362001)(31696002)(6486002)(316002)(82960400001)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Z3hBODZrSGdKYTFGZkZxaGE2M2c4eDZ4Rjl3S2hyd1NEbHZOdStXbDBBSEJV?= =?utf-8?B?UzQzSEJnOXhRZURUMVBjRTh6cXc1Zk1leER6dHY5cG9TMmJLZWNjalBDb01T?= =?utf-8?B?MkYyeVRCckFYT1IvTEVtWnA5M0w2anlYc2lQY3RwUG4zdFJkTFhVQlVjUkxX?= =?utf-8?B?SnU5dWFvdlhmWFV4SEhYOVA2cEpyajJQSmVUTUNVTHpUeWhlTTM1bVRmaWFq?= =?utf-8?B?ZllOUFNyQ3o2c3RGUStJWjZiU2lUT2N2WGVVZFVLUlNzdEM4L3pBcFF5UXha?= =?utf-8?B?eGw4OEcvTGdkVUVpaW4rNlpWTjdKZUgxcEM5MkNYL2pTUTVQc1VHeFJNemNF?= =?utf-8?B?ODVEUGd0TkRzMldXa0FXOVZTaWhEd1JoUlhiYkRzOW5FVzc2VmRkSXV6K2pU?= =?utf-8?B?OXlPUmx5eWVHbXlpVEcxcktnZGh4S0g3Q0MvcWtIYVV5dmF3SGcxY1lwS1E1?= =?utf-8?B?TWhpMVpueHp0bTg5ZVpNcnhmOE0wYmRGcFJ4NXVkZlh6Uk80eFpIakxGVGlo?= =?utf-8?B?eTVoa1BWOUI5VXcwYTQrc2N4ZEh6MkpuNVZDbnNkazNhaThTdm9IWUdoRkhx?= =?utf-8?B?OVZmSUkvWlkycjZ0ZW5WSzJ5THR0cHdiV2gwK1o2a3praXFRV2NIa2VYeXox?= =?utf-8?B?YWcyajl0aG0zREFqVkk2WXR0bFZCQ1V2KzRBcWtmR0Z0ajM2SDdFNTZJWmZl?= =?utf-8?B?Ris2R1kyYW1udnRseTR4UXZYN1VTT2txZzBNSVBIa0Fia1RhZEF2REVjb3Bo?= =?utf-8?B?TnNvUW45N2xaRzJpaHhkbmJiSEcrTCtIMzBlcXFSS3gySEtJMjBnTVVtRmFN?= =?utf-8?B?SnpDWCtlRmJ0UVRhSWtrMGdvRG5YWi9nRTByVkNvMldqWExmaE1KQzhIL2dH?= =?utf-8?B?TGNBQmF1OHI4V1VPQWRnNkQ0YlhFalI1MzVlY3ZWeWhYdVA0b09YdE5Ddnlv?= =?utf-8?B?UkNKSGMvZkFlenJKV2JMVHdkT0luRmd6TTFYVWNCLzZrVTFaMkZsS3F3VzNE?= =?utf-8?B?UUg1Sm43ZVRWSVVtdmt5ZmJQYTViZG5rb2sxQW9RYzlkTHFKYytveTdBWE96?= =?utf-8?B?Sy9PN3hGUUR1WTErOHNMdnFQTGZycWlGNllrTjhmSisza3pzNUR3MTJYQTBQ?= =?utf-8?B?dmhUeDUweDYzSVJjcWgrbFc1bUZhZkZ3Q3lETnZVYm1FZU1lZHYxMUM4ZGN6?= =?utf-8?B?WnJwaGRMdis5Y0VQZXAyaFdJQTJhT3k0RTlzVUVtTkMyQi9rWjNteFRUR3VE?= =?utf-8?B?U0xZZmxGWmlBVVNPL0o1ZGFPZXhOYVFvN0xRUlNLbVJobHc1MTVWcWtoL29K?= =?utf-8?B?RWNLbStwcElQUk9rN3g5MkE3Y0dkcFdCUHBZVW56MDFuNVA5eUNHd3NSVUEv?= =?utf-8?B?cnVxQkdrOVFKOHVUVElvSWFUWlF3QllDRlBuWk9DWGt5VGllK2czbVFsYm03?= =?utf-8?B?NkY1L2lKb0lzY0J3WEVTNTdub0RxN3VDUkU5aHVBZThRV2hsK1ZxTHo1dzl5?= =?utf-8?B?d0Z5b0hlV1ZYL21kNWpxYVlCMStSd3pyRU1NYVhhVjYwL3lSMktmUXFBTTJj?= =?utf-8?B?aHNJZ0VaOThtYzUzYk9oeGNhL0U3RUx1ZUdjNlFTRjhNYXB6V2R0bXBRWVNE?= =?utf-8?B?U2JsTisvNnplQnlOdUZxRjB4c3o2S0g0RTdFTEh2T09rVUdUamFsU0FuZDNK?= =?utf-8?B?Uk5hWU4vN09CaW9JS28vYi9wMGZVWDFmcmR6V0FsODZTb3luV2dPWnJocFFi?= =?utf-8?B?ZXpWWklVNk1DMkFyd0lzSDlxUTJsbDJFUGN0SGJQcVNtakR0TldGREZ0V2dk?= =?utf-8?B?NnRIaENydWUvbjMyNFFYL3ZUcnpOS2dLQ3FmelhMR1hNR1h2VlZ5elRVbVRa?= =?utf-8?B?WXVaS2hwWjBPS0tsbUdhTlFJQXMwaXZzTUVsbUpRcStHWGhZRGFWdG1ETUpq?= =?utf-8?B?MGNsV1dqTGU4M0RMTktXNXNpTGhLT25EdTNYMGY1TXVEVmk2VTVpWjBwc3I3?= =?utf-8?B?SytHS0RFbm9VUEZNYVdiSGxLRFNya3ZuaVp0RkZJT1RHbkF0dWlCb2s5MUVm?= =?utf-8?B?UkFLd1RHbVlqUnpaOHBUc29yNTV5RmJsWmlXVWIvY2p0ck1VanJWa3dGYlNI?= =?utf-8?B?OXR0MkJUVDcybjR0S04vVmM5UFlKeW91elBwT2d0RlBuamhDZ3I0Y1BscTlB?= =?utf-8?B?UFlMeTF0aEJFZDQrc3RNcldTbU05ektuL2xMS2UyYytpdGptUWZCd2Q3SXZj?= =?utf-8?B?a2JNNHl4QVRaeVNldkJ0M2VjaTJnPT0=?= Content-Type: text/plain; charset="utf-8" Content-ID: <4E824280FC02FB4F842E6FA8106318B5@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: caf351aa-73e9-4045-22af-08d9fb90b2d8 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Mar 2022 14:35:14.2913 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: OcudNISJxXkB7A2HyM0KSabOTgLqaZ96zfIN4X9RCyef7juu9jkwnR8X/Jmm9y2Z3MxTK2OVyWDhXcDGusl4Lj0+YEYCsBJTHWd5hC54TBo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR03MB6458 X-OriginatorOrg: citrix.com T24gMDEvMDMvMjAyMiAxNDoyNCwgQW5kcmV3IENvb3BlciB3cm90ZToNCj4gT24gMDEvMDMvMjAy MiAxNDoxOCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+PiBPbiAwMS4wMy4yMDIyIDE0OjE4LCBBbmRy ZXcgQ29vcGVyIHdyb3RlOg0KPj4+IE9uIDAxLzAzLzIwMjIgMTE6MDYsIEphbiBCZXVsaWNoIHdy b3RlOg0KPj4+PiBXaXRoIGJlZDlhZTU0ZGY0NCAoIng4Ni90aW1lOiBzd2l0Y2ggcGxhdGZvcm0g dGltZXIgaG9va3MgdG8gYWx0Y2FsbCIpDQo+Pj4+IGluIHBsYWNlIHdlIGNhbiBmdXJ0aGVyIGFy cmFuZ2UgZm9yIEVOREJSIHJlbW92YWwgZnJvbSB0aGUgZnVuY3Rpb25zIG5vDQo+Pj4+IGxvbmdl ciBzdWJqZWN0IHRvIGluZGlyZWN0IGNhbGxzLiBOb3RlIHRoYXQgcGx0X3RzYyBpcyBsZWZ0IHVu dG91Y2hlZCwNCj4+Pj4gZm9yIG5vdCBob2xkaW5nIGFueSBwb2ludGVyIGVsaWdpYmxlIGZvciBF TkRCUiByZW1vdmFsLg0KPj4+IEknZCBiZSB0ZW1wdGVkIHRvIGluY2x1ZGUgaXQsIGZvciBjb25z aXN0ZW5jeSBzYWtlIGFsb25lLg0KPj4+DQo+Pj4gSXQgaXMgbGVzcyBsaWtlbHkgdG8gZ28gd3Jv bmcgaW4gdGhlIGZ1dHVyZSBpZiBhbm90aGVyIGhvb2sgaXMgaW50cm9kdWNlZC4NCj4+IENhbiBk bywgc3VyZS4NCj4+DQo+Pj4+IFNpZ25lZC1vZmYtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBz dXNlLmNvbT4NCj4+PiBXaXRoIHRoZSBjb21taXQgbWVzc2FnZSwgSSdtIG5vdCBub3QgY2VydGFp biBpZiB0aGlzIGlzIGxpbmtlZCB0byB0aGUNCj4+PiBwcmV2aW91cyBwYXRjaC4NCj4+Pg0KPj4+ IE92ZXJhbGwgaXQgbG9va3MgZmluZSwgYnV0IEknZCBsaWtlIHRvIGdldCBjbGFyaXR5IG9uIHRo aXMgcG9pbnQuDQo+PiBDb252ZXJ0aW5nIHJlYWRfdHNjKCkgd2FzIGRpc2N1c3NlZCAod2l0aCBS b2dlcikgZWFybGllciBvbiwgc28gSSdkDQo+PiB2aWV3IHRoaXMgYXMgYSBzZXBhcmF0ZSBjaGFu Z2UuIEFzIHNhaWQgaW4gcmVwbHkgdG8geW91ciBjb21tZW50cyBvbg0KPj4gdGhlIDFzdCBwYXRj aCwgaG93IGV4YWN0bHkgcmVhZF90c2MoKSBsb29rcyBsaWtlIGlzIG9ydGhvZ29uYWwgdG8NCj4+ IHRoZSBjaGFuZ2VzIGhlcmUgYXQgbGVhc3QgYXMgbG9uZyBhcyBpdCBkb2Vzbid0IGxpdmUgaW4g LnRleHQuDQo+IE9rLsKgIFJldmlld2VkLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVy M0BjaXRyaXguY29tPg0KDQpBY3R1YWxseSwgeW91IHByb2JhYmx5IHdhbnQgdG8gbW92ZSBwbHRf c3JjIGludG8gX19yb19hZnRlcl9pbml0IGFsb25nDQp3aXRoIHRoaXMgY2hhbmdlLg0KDQp+QW5k cmV3DQo= From xen-devel-bounces@lists.xenproject.org Tue Mar 01 14:39:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 14:39:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281554.479931 (Exim 4.92) (envelope-from ) id 1nP3ek-0000tw-C5; Tue, 01 Mar 2022 14:39:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281554.479931; Tue, 01 Mar 2022 14:39:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP3ek-0000tp-8l; Tue, 01 Mar 2022 14:39:14 +0000 Received: by outflank-mailman (input) for mailman id 281554; Tue, 01 Mar 2022 14:39:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP3ei-0000tj-Gz for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 14:39:12 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5ac5d9aa-996d-11ec-8eba-a37418f5ba1a; Tue, 01 Mar 2022 15:39:11 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5ac5d9aa-996d-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1646145551; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=b3ie2UdnaGhAvEeedo3V4gsmdguE8rT330zB2Ok0ack=; b=Pd9SdvNWS4+IZLJU1Eji7R2MhQ3YhZU0Oi24WTungNGLJAEm/kWGbBO6 KSrXtAqmODygQSek6UkRSUv9Ee/VXJcVcdRBz2OVNfWV3Ki87WZ6hcH40 aZWxC3AjdoBo1b+DFhEzStlrQ7lsvvym8g/lvqhhoQ6g9v8P+k6egN0yi U=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com X-SBRS: 5.1 X-MesageID: 65630726 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:qhmNxqLpf3TRDE6+FE+RzJUlxSXFcZb7ZxGr2PjKsXjdYENShTMDx 2QaXW2FOv+CZDPxfdgnborn9hhT7JXUz4dkGQBlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA148IMsdoUg7wbRh2dYx2YLR7z6l4 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4 NZ3mbzpUjoxBK3dv9kXckdkTBBXY5QTrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq 6ZecmpUKEne2aTmm9pXScE17ignBODtMJkSpTdLyjbBAOx9aZvCX7/L9ZlT2zJYasVmQ6uAP JJGM2QHgBLoeS0Vak4ILs8HzOai3XmlWCZciF3Luv9ii4TU5FMoi+W8WDbPQfSaSMMQkkuGq 2bu+2XiHgpcJNGZ0SCC8H+nmqnIhyyTcJ0WPK218LhtmlL77m4ZBQASVFC7ieKkkUP4UNVaQ 3H44QJ38/J0rhbyCICgAVvo+xZooyLwRfJTKcEasRqw0pDU8iGkDElacmFwQYIf4ZpeqSMR6 neFmNbgBDpKubKTSG6A+rr8kQ5eKRT5PkdZO3ZaEFJtD83L5dhq00mRFooL/Lud04WtcQwc1 Qxmu8TXa187qccQn5u28lnc695HjsiYF1Vljuk7s4/M0++YWGJHT9HwgbQ4xawZRGp8crVnl CJc8yR5xLpTZaxhbATXHI0w8EiBvp5pygH0j191BIUG/D+w4XOldo04yGggeBkxbZ1aJWawO R67VeZtCHl7ZiDCgUhfOd/ZNijX5fK4SYSNug78NLKinaSdhCfYpXozNCZ8LkjmkVQ2kLFXB HtoWZ3EMJruMow+lGDeb75EidcDn3lirUuOFcGT50n2itK2OS/KIYrpxXPTN4jVGovf+16Lm zueXuPXoyhivBrWOXGGodZOdglRdRDWx/ne8qRqSwJKGSI/cEkJAP7N27IxPYtjmqVejODT+ X+hHERfzTLCabfvcm1mtlgLhGvTYKtC IronPort-HdrOrdr: A9a23:f5xLy67MDRuvAXIfvwPXwWaBI+orL9Y04lQ7vn2ZFiY7TiXIra yTdaoguCMc0AxhJU3Jmbi7Scy9qeu1z+873WBjB8bfYOCAghrnEGgC1/qv/9SEIUPDH4FmpN 5dmsRFeb7N5B1B/LzHCWqDYpcdKbu8gdiVbI7lph8HJ2ALV0gj1XYDNu/yKDwseOAsP+tcKH Po3Lsgm9PWQwVxUi3UPAhmY8Hz4/nw0L72ax8PABAqrCOUiymz1bL8Gx+Emj8DTjJm294ZgC j4uj28wp/mn+Cwyxfa2WOWxY9RgsHdxtxKA9HJotQJKw/rlh2jaO1aKv6/VXEO0aOSAWQR4Z 3xSiQbToNOArTqDyeISC7WqkzdOfAVmibfIBGj8CPeSIfCNU0H4oJ69Pxkm13imhAdVZhHod J2NyjyjesnMTrQ2Cv6/NTGTBdsiw69pmcji/caizhFXZIZc6I5l/1VwKp5KuZIIMvB0vFuLA CuNrCp2N9GNVeBK3zJtGhmx9KhGnw1AxedW0AH/siYySJfknx1x1YRgJV3pAZMyLstD51fo+ jUOKVhk79DCscQcKJmHe8EBc+6EHbETx7AOH+bZV7nCKYEMXTQrIOf2sR+2Mi6PJgTiJcikp XIV11V8WY0ZkL1EMWLmIZG9xjcKV/NKwgFCvsukKSRloeMNoYDaxfzO2zGu/HQ1skiPg== X-IronPort-AV: E=Sophos;i="5.90,146,1643691600"; d="scan'208";a="65630726" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FY1goSWaN1VXKrBdtDqTdE36jKjl6aXxJcNELr9cLA61tiKcAslyEgkCJd8oE9U9O/AVMfM+/rZRbVwvNAJNa38gQpEuknnp7bwd3CjGbtvI79uDNJkuEA0aCTcXcMS3RLxGbrAAR46Z9ZKGNMNRjlDexc8Rkpmjy0YNh6IXnCY/MUNdMYSNKlvhdgiMB2wTR4acu148t5RuiX5ExG/Z/J8q9blDFzCymXn+96THJiLBmYs3MRWX7BONmo5hdrjfvrimY/gVJ3bd2S0T/AFi0BsXoO1614mLuVnq7kLbsX4ISOKHZ3JULhkIShSO069Lz26jJj0wGU1ZMLzzKGXzwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b3ie2UdnaGhAvEeedo3V4gsmdguE8rT330zB2Ok0ack=; b=Af0pHpeUYtQ8Esxow0JJJj9+RflSvSwr2bZ9YF0dj0syYH1gSCWvsEHW5LsaAJ8SwmkCzuuVSIu5DfJOS1KjK0dQGIaKt/qF9fEFeQbktmDEznzNNELA7AqnnLiLpHCJdu2sfQKpGXtYGXBk72hY7vvaE+Pz/L1I1dZpBjVFent4dCmEJVBJgANVIs65HLykxJZ5D0UHC9VOT5uz5rdn368I9101OYhuqNwg43lwrzWfhofbuJnOSaHX6hUIVagK6IU8zf3npi7kNTr4oiYRzX6QNAodIcktAS58Hxg+Pm6FhG0F4uWmBWAVV6uSbxQ+Z1hKdS0uQ+fFMZqu21vx3g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b3ie2UdnaGhAvEeedo3V4gsmdguE8rT330zB2Ok0ack=; b=Q76YW8dvEDJ8mmxvk8NZzmelJwwXKnYavWYUTGQuZ+UKvTWoAexMW7qLspuP2SLSUIvU8VOVWACOzdRAR39+VkyR1cVBGDfUPxy93HU44y7ikg/FGpjKCYumnXEaO+MgXc7cV7f5McdJiEUZqroJ+kFLtnlclHm+o3RJP3vz8oQ= From: Andrew Cooper To: Jan Beulich CC: Wei Liu , Roger Pau Monne , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH 1/2] x86/time: use fake read_tsc() Thread-Topic: [PATCH 1/2] x86/time: use fake read_tsc() Thread-Index: AQHYLVxVKor9YtEUbkuWag9T3yUcNqyqf+CAgAAS0gCAAAbHAA== Date: Tue, 1 Mar 2022 14:39:05 +0000 Message-ID: References: <77675e7f-2a7e-f517-4aba-e20774c8bfe5@suse.com> <2c3bb06d-e4f4-33d8-7972-71dc7d61c554@suse.com> In-Reply-To: <2c3bb06d-e4f4-33d8-7972-71dc7d61c554@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b8fbfac8-3e4b-4ca1-62de-08d9fb913ca4 x-ms-traffictypediagnostic: BN6PR03MB2467:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Z+FW9xmntO6+Qgp+weOxqx4NEfgBPc2A0XeeTzinq1UuWD78Ru6pIN0frBTVrAIT2HQUjdcbq1PD3k7XJFtTzH1mqWizH4jO83t2MntcCfP80gaurjoOxGmaZkE10A/HZJPqmvSCjMrjbb35kxtv+NU0s3TdV+8TYvaFIbX9ODsUpxf+dpY8Utn80mop9V1ZHcVXNkgzKWjmDN/2+NwzQvKvz01WVB4bb+42fQmOqFi6xwubntwVRGorH/RVXdAIkFLo7XhXDBvUZZKJbVGk2Z2pZXapGtv7JXRyT5oI8Jo9c9W9nr2VAMYETBufyrkkY/kwwuZM8CTgO+pXn4zqszMjz8Ei+7VdPQNpL4AMYUBSgtuHkzmIQeXkQfHXybBBypsnSzOi6j/T+nFX2/Xf51diTr7ZMm6UvLd1dtr1LtROmM6nfRf0hHNvRCPfVodpvtgcSoilTUDdaL4T9h045KOAIW2gcKJNOtPBkP19tUtCFKJM8rSS84lgAlLgKmxiEkJM+SmYk6ft7KtWBAM1n7L76FnJjHtj9LsLCOz8AqNpIO2sNSOt3Ln1n+QkabGUjqukjXCLvvmG5epqvs7uX8hLL0hqcWpKpka4oNg2zrenli6m1v9dfum257TQPNzPBENBRMh04qMEsP40+aDd3QPsyw38Mm3v7nkA0v6a4AB+VMRdnaRCRhIkdapihdeOhcaOJYzLwHP8/vAqbslUupR/Smpgz6yZk7s5ws4OWW3lYQ+7XZSs1w4XpiMqP65rbgfreDH0MJp28dJ37Kb25w== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(82960400001)(186003)(122000001)(26005)(38100700002)(38070700005)(36756003)(4744005)(6916009)(6512007)(31686004)(2906002)(66556008)(6486002)(66446008)(31696002)(8676002)(4326008)(64756008)(66946007)(53546011)(83380400001)(508600001)(91956017)(76116006)(2616005)(86362001)(54906003)(5660300002)(6506007)(71200400001)(316002)(8936002)(66476007)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?dUc1UVFtaHIxQTRZcC9BOXM1bWgrZWtCa3pDR0xIZlhZeDcwZkd4dHVJYXlO?= =?utf-8?B?WE9nalBERzNVRUFOMDZCVFkzUjNKQy9EY20vZnFPY0ZIYXIrT1pCVGtSMmNY?= =?utf-8?B?akNNbUNYRTZ4aUlFSzBGUGdORFgwQ0pWZlpJaTlPMk5NS3FWVlh2a3ZKSzV3?= =?utf-8?B?ZVZZNUxXOFNiZmgxS3lGVEh0Y2YyS29oYVB0Y0xKdXBHYjJidjlCWENWZGt6?= =?utf-8?B?dDZ3SWNFaGRSSkxiMVNwWGZnNFVmTklQY0QzVE9hQXZvMGJUcFdQb3JXc05o?= =?utf-8?B?aGx0cWhQR1EzSWVJSktMRGRKdUsrbVRmcTFaN3ZuUEl4akdIR212TUhzdUpr?= =?utf-8?B?NEJRWVF2RlBkVWtxMTU1KzZCUENtMjJDNnBPNjQ3WGhka3RnR2l5aW1WdmZ3?= =?utf-8?B?c0tWYldQdlRpSzE3TGt4QXBHYnJKeWRqc0h6ZzRpMlhFSTV5K3BwVjZxajV0?= =?utf-8?B?ZENhK0pVT2ppVDR0bWpKWm81WUtIM1Z6YVJWMGw1eHpjYmErY0FOWGRnVHV2?= =?utf-8?B?YWNqUVdiTGUzZW92ejF5VTJJemVMNmJrMDFZYXJHai9xcC91ZmZ4Zi9RY3h1?= =?utf-8?B?WER0SWF4V2I0NXlYZjBGbE1kbTJQNVpsMzNkNkJ6YnoxeVlGekxDM3hkajJH?= =?utf-8?B?MzlkSWNRYkZ0SVF6ZFNCbVRNbFpiMVNtVFhxREJEaEtRSC9yM0NQd3RmZzdn?= =?utf-8?B?eW5xb1cvd0xIeTBZQWc0Qm9zY3k1NkdLa0t3anZlVjc5L1h3Q3ByTHJEV3B0?= =?utf-8?B?bFgvb2NhU3lWblc2bHhWZHJiV0NaZFFGeUlMZ1hTUFFFeVk3QkxOZ0JzckRX?= =?utf-8?B?YWJPa0pHRWltNXdkdWZuNm95cjc4NzAzRk0zRHV2K204clVYNzhubVRPV1FR?= =?utf-8?B?dVp6QXJYdkxNdjB6TVd2YjZIZDJOYStKUDBUSG5oMmkzOGpvRk9lYmFhODV0?= =?utf-8?B?Y3M5UnN6UW1ZTHI0bWtJOFJaMXJvYjc2cFFUcnhWeFk1azRyU2lNTG5wL2J6?= =?utf-8?B?UjZRY1lPU0Uybk5rR0hlODNHNFpkSkVwdzZGOXZSMTBFUDJDSlduUFE3Z0du?= =?utf-8?B?b0xoaTZ0MlBRdUIyUTMyS0d6V2VnMmoxckpoR3pRc09Pc1p1UEVuNlJHN2lB?= =?utf-8?B?RWhUdWpVeFN6cEd5UmtRclh1NVBDZGpaL3hQaXVtZVBmdjhranBCTlBIb2ZM?= =?utf-8?B?dU5VSk9Md0t5cENyUEFhekxUamJrMHVjcERKb09QR2ZJSlJHMzM4Ti83ZnhC?= =?utf-8?B?UmZSQ3pDMklWSXFsUkc3SjdXdWVlTFY3aUcrSEVyUkJJNWFmUmtpalFydnJJ?= =?utf-8?B?cElVSWlTdHdVUUxRODZJNEJidzR5QXJVeExCYy9WQWVlMUhKY0kxOG1SVXNT?= =?utf-8?B?Sy9qWlExM3g4dWR3RmtGQ3pRRFY2VmlWQ2V4VG5TUnNMQ2dFRTFjYW9GOGc0?= =?utf-8?B?RFVTSXZvbTBOdWFSSFlQbkxSQUlVMEtzekFEdkIzUEk4NXI5OGljVWRFc0xX?= =?utf-8?B?YnRYTlNkWjY0ZG1kSkdPT3llK1d4cnk1bllRekJpM2VLZWhYL0swL2E0dVVX?= =?utf-8?B?UTh4N2FGaTZ0UFp3NEdCc0RTaU1BTHEyWVR5dkFsSnFhbWRVUHF3eXVEbVow?= =?utf-8?B?YXRuOWkrRXlGcU9WeHUzcUVPVnlGVjNEeEFSYjdhMFg3N2lBanBNeklpK3o5?= =?utf-8?B?UWg0ZXQvZVJydjZJYnBjS3ZseldBR2NTREFXNnhWc3h2VFlGK0VJa3lBT3pr?= =?utf-8?B?SUhOcGorZTlRSmxqaEVFNTArRzR0Z24zSHdLSEkxajlRZkpiKzlxMDQ4QllQ?= =?utf-8?B?QURTV0pjMDFyRTRLSzVGVEFkVmk0WlBVRlp5aFhsNGkxZnY0dElzWllDK0Fk?= =?utf-8?B?bWF6cjE2MzBoeVhkeGlxZ1pGemIvejA3cEM3VGMxaU83TGRnb3VrN2c5SSt6?= =?utf-8?B?ZWozaVBab3M2VHEvV2h5cGVBR2NVN1JqKzV3ZVNobmVRa1VMU2hoeDJVbmNh?= =?utf-8?B?WWVweDdHT29ZODZNSlVLMzlvblRZNDFlcmZLMnBKZUZDN0FDVmJodDZ0YXB0?= =?utf-8?B?bGw3NEd3K3p3dXEvVlA0V1lMZUVjUmhJQWlta0p6USttRjFuaVB5ZWprRUhF?= =?utf-8?B?dUlCRDZjVHdVdmNYK0JCZ2dDSW5vU3hwNFdNajJkVUZqSW1WSDVMbmxVKy9r?= =?utf-8?B?blpoTmdweVBZVC8rK3g5N0hlenU0c3F6OTR3M3JVTHRjNkhuWFNyRWZNazlM?= =?utf-8?B?SE41NUpybDljbW9DQjg3K2t6RmRRPT0=?= Content-Type: text/plain; charset="utf-8" Content-ID: <8D2398779606C241A6E866C697B2D6E0@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b8fbfac8-3e4b-4ca1-62de-08d9fb913ca4 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Mar 2022 14:39:05.4934 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rFrlNSiqOK5yr0xZJoPeu/VAJ7KqKZ4GuEjTQgWCKo1FevH2zIkT0ibfG+wRZaqC7s7bNszx1zQ09Ks/sXJL+o22tA4lbBuuh3VPL1m3Hu4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2467 X-OriginatorOrg: citrix.com T24gMDEvMDMvMjAyMiAxNDoxNCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDAxLjAzLjIwMjIg MTQ6MDcsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBPbiAwMS8wMy8yMDIyIDExOjA1LCBKYW4g QmV1bGljaCB3cm90ZToNCj4+IFRoYXQgc2FpZC4uLiB3aGF0J3Mgd3JvbmcgYSBwbGFpbiBOVUxM P8KgIEkgY2FuJ3Qgc2VlIGFueSBuZWVkIGZvciBhDQo+PiBtYWdpYyBjb25zdGFudCBoZXJlLg0K PiBBcmUgeW91IGZhbmN5aW5nIGFuIFhTQSBmb3IgYSBjYWxsIHRocm91Z2ggTlVMTCBpbiBQViBn dWVzdCBjb250ZXh0Pw0KDQpXaHkgZG8geW91IHRoaW5rIHRoYXQgYSByaXNrP8KgIE9ubHkgbm9u LU5VTEwgZnVuY3Rpb24gcG9pbnRlcnMgYXJlDQpmb2xsb3dlZCwgYW5kIGFsdGNhbGwgcmVzb2x2 ZXMgc2FmZWx5IGlmIHRoZSBwb2ludGVyIGlzIHN0aWxsIE5VTEwuDQoNCkFuZCBvbiB0aGF0IHN1 YmplY3QsIGRvbid0IHdlIG5vdCBoaXQgdGhlIGFsdGNhbGwncyBCVUdfT04oKSBmb3INCmV4Y2Vl ZGluZyBkaXNwMzI/DQoNCn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Tue Mar 01 14:40:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 14:40:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281559.479942 (Exim 4.92) (envelope-from ) id 1nP3fq-0002EV-Mj; Tue, 01 Mar 2022 14:40:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281559.479942; Tue, 01 Mar 2022 14:40:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP3fq-0002EO-JO; Tue, 01 Mar 2022 14:40:22 +0000 Received: by outflank-mailman (input) for mailman id 281559; Tue, 01 Mar 2022 14:40:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP3fp-0002EE-3q for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 14:40:21 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 846a9d90-996d-11ec-8539-5f4723681683; Tue, 01 Mar 2022 15:40:19 +0100 (CET) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-am5eur03lp2057.outbound.protection.outlook.com [104.47.8.57]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-3-yx1oQ5sdNVCrWUFfaeoeIg-1; Tue, 01 Mar 2022 15:40:18 +0100 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by DB6PR0401MB2326.eurprd04.prod.outlook.com (2603:10a6:4:47::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.13; Tue, 1 Mar 2022 14:40:15 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.027; Tue, 1 Mar 2022 14:40:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 846a9d90-996d-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1646145619; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1Tp6eeM+bJVVLPcsHvwb5t5ic8e0eWZrXvqaygMrey8=; b=AvAE7/fwGpSl62Mu6LqI88pasOlANnXRlUF1PQ5dOD8kc/aq5UMovoB/OpngquAbH44rHW +/ed2lA2N5y5IphCEnYTQejxraVnQQFZGVLRSHWnU1zd2Uonw809nUnxswqboAhU2B6fvY iImSzyIZuDH/ftHcd2vHDAtVf2MWUYA= X-MC-Unique: yx1oQ5sdNVCrWUFfaeoeIg-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PifrZlDFm1nqTTnG4KOvyoQqRAdZddoIrTXMtyBL6/oF/LmJZZmOBoBPkry1J4pucAf67aJ1C88hGLou36bApoeqB/ybgm2Y9NDkzi6xOWMYfWovK8fPnyC/uVNYz5lMQAx+ieeGZ+hQ+JpZ1urDsSdhXlQYWDkIUW9AnnQlZdBdfx6n3q+ijS3Dme6Fl1dGrfSTfVBUcCbwgu0SIqA+qe7e2dZx8vFGRc/fMsxRY8BdMDtS1Y5OKsWLw+iVljfstwFbEjMWFfelZS50p8KC7LLlSRu7XbWCnU8NecvAE6o6WNd4ZRRNtTfvjaISEG7lJS5BTbgeawfs3vQ6R++ULg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2+3+5dA28raY52aHpc7KzJ6+oTJvxhqJIrB8LChS1A4=; b=Hu2uPspnWOPGe/rT7iptNLr087gMN6DDHFtEJlvTsGkGsl4y/1a5iGfY1cCwuYofoWgVDS0Goj0YdEyrgDG/PH+nC9jIqi6hfTQUY+Se/2SoItlkNcm2zeCCnb5nGvdO0NMSUyXnrl7lwo0mPGfvjgI5bH1x3i2cYfw/uYObgQwwoPovjVnhLCa91gFnUE6mvsZJFyNerKmJu9jrShbhOHmqLnW5zB9ii8cBhQkjwendPUmbBLN8L2r0Ls8B+PhMOioujVq5banyyEAY5dYy5Iwev7FgARfpXDfqHO4KST7Qn0SeMWVG1UFejtHApaKHvqs0J/BFET9nfOZgQpPcgg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <152549ca-37b7-47f3-3b63-2d2ccf8070ad@suse.com> Date: Tue, 1 Mar 2022 15:40:12 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH v3 1/2] xen+tools: Report Interrupt Controller Virtualization capabilities on x86 Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: Jane Malalane , Wei Liu , Anthony PERARD , Juergen Gross , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis , Jun Nakajima , Kevin Tian , Xen-devel References: <20220218172943.12182-1-jane.malalane@citrix.com> <20220218172943.12182-2-jane.malalane@citrix.com> <0a31970c-c0f8-c995-ce04-67523a4a830a@suse.com> <9aff51c2-0e8c-685c-7bff-0ed7ff7347c7@suse.com> <6b59e3ea-01ff-e26c-02d4-3b11594fd7f0@suse.com> <60bcd74d-5686-9813-e3a6-b28c15b66a22@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM6P195CA0017.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:81::30) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ce4bde3d-a4f5-42c8-f726-08d9fb9165c5 X-MS-TrafficTypeDiagnostic: DB6PR0401MB2326:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: a3WiOBdWFr0uLAuJNl9A8Pz62mjFzfgBZsejDCpaRiHvnuNf+WB0lkMxhQOd1FdXx721HSxL4VeFdEFk+ofGnTplEnmx6G3VWPQYI2P33I1vtAnS2rrjwlvRrEFXz9NKN+I7up4Br3kZA6rQX12o3CvXkvFaoDkitT/6QS8//MNVGHcsZyZ9Cw5rJ+gYExYvpXu+hR2RmGk0qipjg6EbHBnxEBDV0TGreL4q/GH8c7J5AWjBfWgwu+zlPVEpFskmWOcuJYZW78NsYKZ/nWY8hNcAONS/N9mjsb6gSvYHF3z0FU0Z0YWYqaz/efNOo9t08ab//v88zaGRwN0ZvALQCCV83xbIMC7KV/vgrbrBApL6rjJqJhOIFJTf9IB9+cccYvf5smLK/c1w/1sZMjc2otGTpLIgGKIv4Io7+Vdum0ORpoxgN1JAmNkFDnxGzzwVXObVwtCI56udxR2x3eJmPNggQU+7Yur2bztHdiEYG55kxS9NqpwFAdV3lReFAJ+onHpLaYwkHaolKyf//rtzg2YA5awaHz6ugnNQhq9+ak12XeCtNER8243XK90XIylFSTvBSXWM3p/Dt+h+Zl1s1J9IORrWn9lJdOE3+xC2c1D6+mEgyjh3y5KS1q29197XGebUET9Gsw3ciMAOnHainJLfGo67/lhscPGrZ+I32ofV/CVklfTSBkh8UILcYacQRVY58n5Qc+d8p9vHdie0A+z79sH7ixN7o2Lb++YEsxI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6506007)(38100700002)(6512007)(5660300002)(53546011)(186003)(83380400001)(2616005)(26005)(2906002)(6916009)(316002)(8936002)(54906003)(4326008)(8676002)(31686004)(6486002)(66476007)(66556008)(508600001)(36756003)(66946007)(31696002)(7416002)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?4SViXnrNLyiz3pJwbf+gBmPlsdn4r3GO5WgPEO0FXbN+IA0eCiBwrE66KzK8?= =?us-ascii?Q?JLamUKY4GAzXuYaxk5HWbjL5qDewaflz5YTOiW2pcGUS9FnDdRlz0KLN65PI?= =?us-ascii?Q?otxtApY7Bmb+qzYw60F9Yav2082eC2K7Dr9b8u9atH61ADnD5lhJ2wInRN0d?= =?us-ascii?Q?oJ56cu5LIto0NcyChuiEne9BSzmrpgnb5lqJqet43sjWQWLw0kuhr8fdEgzO?= =?us-ascii?Q?vu8cWs0v3FCojbKNFxvW8xOZe+5OWrTpyRhjBumU+a72IVXFFI3TaLNh62Mh?= =?us-ascii?Q?T9Seu9DUyf1TcmnZ6BPwRgWOzANjcqVotDyne5jxC3t6OhoJ2xnoeqISOJf7?= =?us-ascii?Q?MHKepdscSgZX45skh131rVzUM0g8Hq5K4ctWmwEdHeyDIOP8MLShZXrv32bK?= =?us-ascii?Q?Mi++QIRuDC39LPNfypNzaoM746gDKfym86gk+Po6VJIeiZdLb/fRClBGZzog?= =?us-ascii?Q?D2Kvk7YdEwS/iUUGpgGYOJyIAO1CK08Dm5M3dyfz9oLjLZ0Vsz2FAhw6NPzc?= =?us-ascii?Q?zz8K/VKVJ1raxl6FnIbM7U7KXYnOUYP+FniRHr626eB3WXNgKYm2GYMkl5Bv?= =?us-ascii?Q?sZxIUZzlHW5VsVl1rB6Ij28TwB3++yI4fjuc50rL+blX7nV2UNDrNRdKDnP1?= =?us-ascii?Q?6c8rmP0y2ghG63NYx1fWhMIBwQ6TUq0W/D6NOH8s8H3RCvBwhTil1nPHnGlH?= =?us-ascii?Q?HMQcYRaSfAis+8nNzU0YUPIrcI3XGN54ZRL5wkhwyJd3tzgVJ1HSyeEzvMB+?= =?us-ascii?Q?c3CH2IZtWBav0zBNUHqw40eWCrCeuNitkG0d/Wss1obCU94auJGfxwon/Pnt?= =?us-ascii?Q?b6vtFJMjtzeQH8NywHVh9YEMSEQBHuvZsAUfRmDoP5E9Veh22G6axkcv19CX?= =?us-ascii?Q?+wifCqfrHoNGCGxQZP5dw4GI77dCPYbdEuj4vgtOANJ3nhmACIrBaylCJERQ?= =?us-ascii?Q?lf0tCBqNEWp27P4upFOxdLzLwQsyj5SUKEWanykVaEbw0Rg1y8ajdVIeP5XQ?= =?us-ascii?Q?29i6nHBc2hkE3NhLZk5dQDyN85UuXdn4+yDigOYlyDZkmNoCzMQ3QVjq6kFH?= =?us-ascii?Q?N/0KnIiyPwi7SNlmDqTrNJFaszNOnG3MG9cQmQH6YDd/5bzz3KwnnXrFrnK9?= =?us-ascii?Q?GB4Mr+8R6890+RYQsObxJ43jibV811bmNZDHyB33+B3mWVMf0ardEHDnY00s?= =?us-ascii?Q?NqOokRoNRqIpn7a5+TMzxmx4tLHJq5HuEbvWhzcNuue9isOvD+7b6O5DnDwd?= =?us-ascii?Q?k5OgvyPV3Sh0Cov147wa7EAIMsRkihIEHA6BZ/55DsdMl6eodX9IAaEDS36q?= =?us-ascii?Q?NNoM8z9B1pcv9zsxagsHFmPSkoRN474krEqOe6rajeoMmcRReKz5Xp9aSCEn?= =?us-ascii?Q?Kpmoc/Ms72BFhtEeOycoYGAmPvKvoncWvdM+xVaIzrzyw1fnbyVXUzmKJM4d?= =?us-ascii?Q?ZDzg+m7bquQbdtjzon8QzzqISWofF+/QOYJB0wVBKTvdzkIlGysZvIQS6wad?= =?us-ascii?Q?0HCkuXwJQhfXYM5haKg9+QxH43EbDgloVWKnRaHeys4VdDs9LYEldDDcGkGk?= =?us-ascii?Q?GNY+uddn8K+hzMMp9QGM13TEUVeudRd9ualvsQgQPWP4vpOoCNjZoKtSy2LF?= =?us-ascii?Q?TLAs02fFyGpKLjYKd4NCQ6A=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ce4bde3d-a4f5-42c8-f726-08d9fb9165c5 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2022 14:40:14.7813 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: O9Qdym0WiZwq4WWMfKBqiUjjI60brcYcnzntw7LVQKeHisDMpq8bP1vtCTRKlVtJ9webQPT4XFG0AsrYRdgiJA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0401MB2326 On 01.03.2022 15:19, Roger Pau Monn=C3=A9 wrote: > On Tue, Mar 01, 2022 at 08:51:59AM +0100, Jan Beulich wrote: >> On 28.02.2022 17:31, Roger Pau Monn=C3=A9 wrote: >>> On Mon, Feb 28, 2022 at 05:14:26PM +0100, Jan Beulich wrote: >>>> On 28.02.2022 16:36, Roger Pau Monn=C3=A9 wrote: >>>>> On Mon, Feb 28, 2022 at 02:11:04PM +0100, Jan Beulich wrote: >>>>>> On 28.02.2022 11:59, Roger Pau Monn=C3=A9 wrote: >>>>>>> On Thu, Feb 24, 2022 at 03:08:41PM +0100, Jan Beulich wrote: >>>>>>>> On 18.02.2022 18:29, Jane Malalane wrote: >>>>>>>>> Add XEN_SYSCTL_PHYSCAP_ARCH_ASSISTED_xapic and >>>>>>>>> XEN_SYSCTL_PHYSCAP_ARCH_ASSISTED_x2apic to report accelerated xap= ic >>>>>>>>> and x2apic, on x86 hardware. >>>>>>>>> No such features are currently implemented on AMD hardware. >>>>>>>>> >>>>>>>>> For that purpose, also add an arch-specific "capabilities" parame= ter >>>>>>>>> to struct xen_sysctl_physinfo. >>>>>>>>> >>>>>>>>> Suggested-by: Andrew Cooper >>>>>>>>> Signed-off-by: Jane Malalane >>>>>>>>> --- >>>>>>>>> v3: >>>>>>>>> * Define XEN_SYSCTL_PHYSCAP_ARCH_MAX for ABI checking and actual= ly >>>>>>>>> set arch_capbilities, via a call to c_bitmap_to_ocaml_list() >>>>>>>>> * Have assisted_x2apic_available only depend on >>>>>>>>> cpu_has_vmx_virtualize_x2apic_mode >>>>>>>> >>>>>>>> I understand this was the result from previous discussion, but thi= s >>>>>>>> needs justifying in the description. Not the least because it diff= ers >>>>>>>> from when XEN_HVM_CPUID_X2APIC_VIRT would be set as well as from w= hat >>>>>>>> vmx_vlapic_msr_changed() does. The difference between those two is >>>>>>>> probably intended (judging from a comment there), but the further >>>>>>>> difference to what you add isn't obvious. >>>>>>>> >>>>>>>> Which raises another thought: If that hypervisor leaf was part of = the >>>>>>>> HVM feature set, the tool stack could be able to obtain the wanted >>>>>>>> information without altering sysctl (assuming the conditions to se= t >>>>>>>> the respective bits were the same). And I would view it as general= ly >>>>>>>> reasonable for there to be a way for tool stacks to know what >>>>>>>> hypervisor leaves guests are going to get to see (at the maximum a= nd >>>>>>>> by default). >>>>>>> >>>>>>> I'm not sure using CPUID would be appropriate for this. Those field= s >>>>>>> are supposed to be used by a guest to decide whether it should pref= er >>>>>>> the x{2}APIC over PV alternatives for certain operations (ie: IPIs = for >>>>>>> example), but the level of control we can provide with the sysctl i= s >>>>>>> more fine grained. >>>>>>> >>>>>>> The current proposal is limited to the exposure and control of the >>>>>>> usage of APIC virtualization, but we could also expose availability >>>>>>> and per-domain enablement of APIC register virtualization and poste= d >>>>>>> interrupts. >>>>>> >>>>>> But then I would still like to avoid duplication of information >>>>>> exposure and expose through the featureset what can be exposed there >>>>>> and limit sysctl to what cannot be expressed otherwise. >>>>> >>>>> So you would rather prefer to expose this information in a synthetic >>>>> CPUID leaf? >>>> >>>> Depends on what you mean by "synthetic leaf". We already have a leaf. >>>> What I'm suggesting to consider to the give that hypervisor leaf a >>>> representation in the featureset. >>> >>> Hm, but then we won't be able to expose more fine grained controls, >>> ie: separate between basic APIC virtualization support, APIC register >>> virtualization and interrupt virtualization. We would need to keep the >>> meaning of XEN_HVM_CPUID_APIC_ACCESS_VIRT / XEN_HVM_CPUID_X2APIC_VIRT >>> (and exposing more fine grained features to guests make no sense). >> >> I did say before that once (if ever) finer grained controls are wanted, >> a sysctl like suggested would indeed look to be the way to report the >> capability. But we aren't at that point. >=20 > So we would expose everything in the 0x40000000 range, and caller > would figure out the position of the Xen leaves doing a signature > check until the Xen leaf is found? The leaf number doesn't matter. The FEATURESET_* constants are part of the ABI (just that the names we give them aren't in the public headers). There would simply be a new FEATURESET_x4a. > I would agree with this if the hypervisor leaves where already part of > the managed CPUID data, but the work required to expose the leaves in > the policy/featureset doesn't seem trivial. Making those leaves part > of the policy will likely be done at some point, and then we can > decide to drop the sysctl bits. I may well be underestimating the amount of work involved. I wanted to put this up as a possible alternative. Seeing that it's not liked, I'm not going to insist to further pursue this. Jan From xen-devel-bounces@lists.xenproject.org Tue Mar 01 14:41:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 14:41:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281566.479952 (Exim 4.92) (envelope-from ) id 1nP3gw-0002os-1P; Tue, 01 Mar 2022 14:41:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281566.479952; Tue, 01 Mar 2022 14:41:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP3gv-0002ol-UP; Tue, 01 Mar 2022 14:41:29 +0000 Received: by outflank-mailman (input) for mailman id 281566; Tue, 01 Mar 2022 14:41:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP3gt-0002mE-UB for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 14:41:28 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ab6e9db5-996d-11ec-8539-5f4723681683; Tue, 01 Mar 2022 15:41:26 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ab6e9db5-996d-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1646145686; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=cYvcvTlc7QjuOAplFLIHIwXoyIbJYXN1vmW4gf/g2bc=; b=Py+xDWdEy8ti45laaARgU8exCWwG8zVqUm32PqUyhH22jlYNxe95Kt6d 3YzuSw5xfuGc57hxLNdyxMLDJ43llOJILSsz5CU0aPeIq2MDn2qt/VRW3 KRs8lBrZIrSbKyRCSrAeJKlIry2RnhhLkCLQl/mTQM8HulDZr8oFrUr6x o=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com X-SBRS: 5.1 X-MesageID: 65224444 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:qIwR8K16Mt4cKl+dF/bD5c5xkn2cJEfYwER7XKvMYLTBsI5bpzQHz TdNCmiAaamIYzf1f991aozi9E9VsMWDn9FrHANrpC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EE/NtTo5w7Rj2tUw2IDja++wk YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx /1xu76UdFkgPJaShcUhUCECPXljZrZ/reqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr KJCbmpXN1ba2rzwkOnTpupE36zPKOHCOo8Ft24m5jbeFfs8GrjIQrnQ5M8e1zA17ixLNaiDP ZBFNWYzBPjGSyxCHHgsDao/pcrymSmufTAD+WiNo4NitgA/yyQuieOwYbI5YOeiVchT20qVu G/C12D4GQ0BcsySzyKf9XChjfOJmjn0MKoNEJWo+/gsh0ecrkQRAhALUVqwodGil1WzHdlYL iQpFjEG9PZoshbxF5+kAkP+8CXsUgMgt8R4L+MYzDzTw6jvvRu4Oms8FBAZdYc9jZpjLdA17 WOhk9TsDD1plbSaT3OB67uZxQ+P1TgpwXwqPnFdE1ZcizX3iMRq10+UEI4/eEKgpoCtQVnNL ya2QD/Sbln5peoCzO2F8F/OmFpATbCZH1dutm07so9Ihz6VhbJJhaT1sTA3Dt4ade51q2VtW lBew6ByC8hUUPmweNSlGrllIV1Qz6/t3MfgqVBuBYI90D+m5mSue4tdiBknehs3aplfJ2OwO RaC0e+02HO1FCHxBUOQS9jsY/nGMIC6TYi1PhwqRoAmjmdNmP+vo3g1OB/4M5HFm0kwi6AvU ap3gu73ZUv2/Z9PlWLsL89EiOdD7nlnmQv7GMCqpzz6gOH2TCPEFt843K6mM7lRAFWs+16Or b6y9qKiln1ibQEJSnKPoN5LcAtTdiBT6FKfg5U/S9Nv6zFOQQkJI/TQ3akga8pimaFUnf3P5 XazRglTz1+XuJENAV7ihqxLAF83YatCkA== IronPort-HdrOrdr: A9a23:q53S1qMSvcrII8BcT2/155DYdb4zR+YMi2TDiHofdfUFSKClfp 6V8cjzjSWE9Qr4WBkb6LW90DHpewKSyXcH2/hsAV7EZniphILIFvAv0WKG+VPd8kLFh5dgPM tbAstD4ZjLfCJHZKXBkUiF+rQbsaG6GcmT7I+0pRYMcegpUdAa0+4QMHfBLqQcfngjOXNNLu v72iMxnUvGRZ14VLXYOlA1G8z44/HbnpPvZhALQzQ97hOVsD+u4LnmVzCFwxY3SVp0sPcf2F mAtza8yrSosvm9xBOZ/XTU9Y5qlNzozcYGLNCQi/ISNi7nhm+TFcdcsvy5zXIISdOUmRIXee r30lAd1gNImjXsl1SO0F7QMs/boW8TAjHZuAelaDDY0LPErXoBerR8bMRiA0HkAgMbzaFBOO gg5RPpi7NHSRzHhyjz/N7OSlVjkVe1u2MrlaoJg2VYSpZ2Us4bkWUzxjIdLH47JlOz1GnnKp gbMOjMoPJNNV+KZXHQuWdihNSqQ3QoBx+DBkwPoNac3TRalG1wixJw/r1Tol4QsJYmD5VU7e XNNapl0LlIU88NdKp4QOMMW9G+BGDBSQ/FdGiSPVPkHqcaPG+lke+83JwloOWxPJAYxpo7n5 rMFFteqG4pYkrrTdaD2ZVamyq9NllVnQ6dvf22y6IJyIEUHoCbQhFrYGpe5vednw== X-IronPort-AV: E=Sophos;i="5.90,146,1643691600"; d="scan'208";a="65224444" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FfgK09031yvhwFnIOkYdYvfK/I7IoMfxVxSlRsKCy96zx9/xFQXt98HzrTCcMOeZ1naDOwLrMARbZ1BH/xt0Lo/hi9ISkHvGG70doUBgOBaRgbEBePbESOggD1q3ecm96saycg2XI+hsgaHa+jqsuuZYQinfibUfOSskqdbgA9nAT04/swulkMdcRX+mDepL/4Vtig9bH8O/q034WqPf7uDChvIg4cFLWzDjfwuzTRHoAALRDLY9lnel5azW0h74HP9TB3tjW6Ru/ZQDJZiSJxWePxFY/6edXYX0cRKXwQq2KRlKU5c9GX5MnGpjHtLsGRX+cF4SyV605Y+PRszRxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cYvcvTlc7QjuOAplFLIHIwXoyIbJYXN1vmW4gf/g2bc=; b=agmSLJzK36lQbCJmCps+t/Tjn1dfh2BtCdK+co+rY/JGXuswbHXmee700g637Yi+WzGSeY7f0pMUpNJjqO1o0ZyCbUrTuWtHd6HMslmWWo8KCjRVx1S+s881of971Nd32bYUFIWFR4GXILugnHOUFiiZTQOoY7YxuC8li7KGj6kbUq5V3H4LOL30Vx9fNzEApkOgnmIJTfTREyXIqqhcEpvCM8/shRv/5pH/20CAi1Jq6/CYsKEHZtRgIq0G/ZpqprCEQTXqXehuLpkkKBKIee1NrsGiFjsTwIlzb3aXa8fVQtlszl9HWT/RDcgwYM8mc+jHNMxXumU/yruCrZh7/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cYvcvTlc7QjuOAplFLIHIwXoyIbJYXN1vmW4gf/g2bc=; b=du93A644cCVGlS4pN8zd7EsVN7VpHY71fZiVLKH8GkDAHafH1OfD/kwYR9pQVFLkAZgVM5mkd/rEEdoIuHv1egwtx3/OwvTgzuoz/wOTCt4AMWsdef+1NB7jHwD13af6qunuMTNSgqBuwVQKJBOucJ/Mbc49oYr5jJJTNwCwMAE= From: Andrew Cooper To: Jan Beulich CC: Wei Liu , Roger Pau Monne , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH 1/2] x86/time: use fake read_tsc() Thread-Topic: [PATCH 1/2] x86/time: use fake read_tsc() Thread-Index: AQHYLVxVKor9YtEUbkuWag9T3yUcNqyqf+CAgAAS0gCAAAbHAIAAAKIA Date: Tue, 1 Mar 2022 14:41:20 +0000 Message-ID: <63fc645b-3a03-d14b-c4a7-d6a46dcb8190@citrix.com> References: <77675e7f-2a7e-f517-4aba-e20774c8bfe5@suse.com> <2c3bb06d-e4f4-33d8-7972-71dc7d61c554@suse.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 57d00f6a-1840-42c0-407b-08d9fb918d39 x-ms-traffictypediagnostic: MWHPR03MB2528:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 18i/SdHIRGoJoMNkmpZbfRYQPlM6P4u4yX12dkPImTLrW/aMW+rGulZcnoMRuMUeSOvrgbVLil3HnNBh0W4t/XUxDk/uRlMVkir/AuZ1vByq1OYR3bIBhz0bwmY6mBCBO/wMgfqxds6kykedKgIHHW4bYeThkRZd9FBruNZM9phrHkqlo7BPybSkcIPBpithZU9bJ6lL0ZXTeGNZbQsGqvO9J2tu4UwUpTyvEwt5p7sjtp1+4+9oDo6ufJGu94rFe46BVAu73d3x3zJ22/1nKbx5kJXRCdBtbCqOhBVMqiHqtsHNelBTb+8UzbbLex0YWCuMgiU5XnVyf1d4mOYfq0zOtlr+64puX4MwHrBleYCd1dGi5YPam5gIzjUHlYtflvHEgHBeCNMeHdJhhzC2KwpdVrjhCAnfDF6gBl3Vc24AHNxq575sbkQFuKKx49gxXza1t26nxOPzRFaYdbOcDtC02cYtwFTEzgVzLy38nhWxhirzi6dEYpyd8jkzqYHc7PLQU5ZZlZBzuH+mjzBoItLHru1dFAKMJyhekYvMqpk4TpngLbg3kEMHbeqXqJTzdomOfNQEm1Y1+oDAslnRIDjBLf2VjLfaFTqb/iPlBGaY214PeILc2CBqXwuIwBtb87rwBdQpTnngX866CMbnYzOXKeRbh+z36ZxjpJhfxl6yAo1Ms9abKfB/ewxOxpGwxSI3THTRAl/i8kRhQdGGlY8EyoWwxiMN5VdnMbU4iMkk/jCuxQj9eAHdDIs4yC0c2uWAoCrsD2pJai5v5bNUrA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(82960400001)(122000001)(38100700002)(6512007)(6506007)(53546011)(2906002)(186003)(2616005)(26005)(83380400001)(71200400001)(316002)(8936002)(6916009)(54906003)(4326008)(6486002)(31686004)(8676002)(64756008)(66446008)(66476007)(36756003)(508600001)(91956017)(66946007)(66556008)(31696002)(4744005)(76116006)(5660300002)(86362001)(38070700005)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?bkVRU0dXN3lpTGNvWStlMENhRXZuNWtDemJhRjBGdTJxM1JMYTZ1R3VuZTlw?= =?utf-8?B?UDhVaSsrOHdabUtZbkFtbXlMWk5KbkM5YmcybitvZDc3dThXUVRsdTZkdmNX?= =?utf-8?B?TXNLYS9pOWpUdlpTOU5xdDcyRHhjT1IyWkt1QUtyczJ1L09veXVPUndZazQ2?= =?utf-8?B?RkdWa1BVVFVZcVVlQVZwRlFSckhxbG1GcmxWeXBhOFRkNVhoRlRYTEliSE9z?= =?utf-8?B?Slg4RnZFaE9xL3l6bUc0YkhyT0RLSTN1UnlWcXNBSG1lVlFTNlVQc3NyRXQv?= =?utf-8?B?L2hDbGkxTVkzbzcrb2pBNlkySnc2aE00OU9wRVp4YUpRWks3bzBETEpyVVdK?= =?utf-8?B?MERBZnBNRThqZzVwd2xTTFdvNkljNzlYQlFaL2ZINWlZenUxOFVhN1pxQ3p3?= =?utf-8?B?KzZqa3k4blV1M0hqSDhPNzZJWW9LRStNMXFSUmZZRFNWckRXWWVVSFBWK2tn?= =?utf-8?B?OFEzTlZpUkd1YWJHMkF4Q1VlS05TV1VPeHMxNGZhejhwTnFyT3JwZFI0STIw?= =?utf-8?B?cE1zYXpUTW1kaUVEZ3F3WkRncVlHdWMyWENZV2t5RFF1cldkdUI2OGlWeW5i?= =?utf-8?B?aXlpU21maUxESWpqVzlXUGZLUEpFeStDbEMvdkFmcmlIcHp0anZOaHdFWGdw?= =?utf-8?B?OS9tYjNoUDAya3JGL2Q4M3hiVGtyVjM4UlpZTmRoQVBVY245MmkrVHBOand4?= =?utf-8?B?V0RKOWRoaWZNZkFYY3VjZm9aOHhpNzNYeVV5WjZXQXZKdFI0MzlHYThrQnpB?= =?utf-8?B?cU4yTGV1MmFIOFZiVnVYbjVQcXFNZXFsSytlYnF6ZFN6dVhZblVNbUxEZ0xq?= =?utf-8?B?ekxJc0pJSlNwQXkyTXpOWU5lTEJWOGxLODBnOVc0blJaWHRCRDcrUXpPaXJU?= =?utf-8?B?SjdQOWZ6dmRrUnRseDU4eEhZTkNXS25uOVRwdHRxY3lzUVNYOHR4aEZxNmh2?= =?utf-8?B?M1RVUlYrb0NoekdVR05LNXZlanJocFcxV203QjYzcUtFRG02ZDgyQ1ZYV1gz?= =?utf-8?B?YUxScS82bHROc3ZRelB3dEVHdXpBU1VYcGNGMXJibTMxVS9RbGVuVzhaTnhy?= =?utf-8?B?Q2d3RFluQmNabDdvQ1dWK0xlZkxCUzlMdnQ1ZVNGRmwvUjEvYXVlQlFTMjM3?= =?utf-8?B?NmMrOGdOTWFqZVJOK0tqMTNtUzI2OVBENHNWWkUrbU9CMHhOQVA1YkEydmhq?= =?utf-8?B?ZmFZN0gwVWErVU1mME43TCtQbHJBZTZ2dFNzNVc5UDM2cGhpaXp6eE84a2wv?= =?utf-8?B?dEZiQVBZbE1OMEZEQXR6YnN3SDdBT29zdzNsQ0RDbityWXp2SldtRkhkN0pv?= =?utf-8?B?M3IxMG8zSkY4R05pUG53emxsZVpXRy9FcVNzVG5TM3ZGZGRGcWY0L2h5Qm5D?= =?utf-8?B?bUZFWlVpVFNMbFFMUG1pa1pzSjhCMGdVOG1ON1RnR3VkK2N0YWF5WG1OZElz?= =?utf-8?B?MUJPWUNoSXU3eFBGUnZFK2pjcUxLaS9aaU1Hc1BiNk0xM01NR3hJeWMwdy9h?= =?utf-8?B?dldUUUVQamJ0UUJaK1VTeitCZTF1RU0wcmtmbkNpR1VSYnM2YnZjOXFNNkVF?= =?utf-8?B?U21IanRCT3hKVWlqY2k1ZG1FUnVZckswR296cndPSnlNM1h2QzhMaFVGZDNp?= =?utf-8?B?cHZneEREVlJ0c3h4RUVtOFVaZG5hcHhvZzMvRTZ3M3ZOTGtDMHBvb2pqbTc4?= =?utf-8?B?OTRlSmZnOGRFcmsrTVRsS1Qrc0hMMkV3YjBMUzhlUVJtWHFWR2plTnRUd1pl?= =?utf-8?B?cWp0bUxGZHlKREFtUStoQ0o4RG0rMkRwbTVSemZ2ZldCU29qRW9PQmNpL0Uw?= =?utf-8?B?SmJZRlBRSm1oSzUrYW1zNVFiczVlMGRKeml3aUp3UzNpZEZFc2pWMFpTZ3cr?= =?utf-8?B?eHZjNW1vaVZzcHREOEhhUlYzTmhuUHhMMTBKc1RMWFpwbDZpQlpJTGtZdGls?= =?utf-8?B?a2NxRkdpRzJsYXlGejB5S2xZam9PbjFCbVFXclF2Z2RNVnhWZHlZaDdHMlh2?= =?utf-8?B?VTgwS1BWMC92dFc2cmk3YWZBTzJlOHBNc05XZHVBbkhIYW9sTWI4NHlIdzhH?= =?utf-8?B?ZENLTlBWdWhBcVpFcGg3cEhtNkJuY1FNUzVHTGJrdFJ0Y29XWGpEdjkwbG1q?= =?utf-8?B?OWRHZTRaZkQyVDgzNjk3QmZ2L29xSjJNRE5mNkR2Q09BUGdkWW1ydVpFblRp?= =?utf-8?B?RUp2NVg3ZHViZ1NBSE84T1R2VTN1MisvajBZZW9RNnd4NEtvKzRIVDBERzgw?= =?utf-8?B?bmp5dEFHN0FtMHp2K1drWnk4VWNBPT0=?= Content-Type: text/plain; charset="utf-8" Content-ID: <2172C992CE5EB344B99C3951CFC09BAB@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 57d00f6a-1840-42c0-407b-08d9fb918d39 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Mar 2022 14:41:20.7180 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mjE3z7Ki+lnoJP6k8mqeQNgPYqORRv13cBSM6eXX2wqNGgICzBr/I2c7PmAJqP/IdPl57nIy3Dtzzh3HwB59+xk0l/gb4icum4aV0IUnx14= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2528 X-OriginatorOrg: citrix.com T24gMDEvMDMvMjAyMiAxNDozOSwgQW5kcmV3IENvb3BlciB3cm90ZToNCj4gT24gMDEvMDMvMjAy MiAxNDoxNCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+PiBPbiAwMS4wMy4yMDIyIDE0OjA3LCBBbmRy ZXcgQ29vcGVyIHdyb3RlOg0KPj4+IE9uIDAxLzAzLzIwMjIgMTE6MDUsIEphbiBCZXVsaWNoIHdy b3RlOg0KPj4+IFRoYXQgc2FpZC4uLiB3aGF0J3Mgd3JvbmcgYSBwbGFpbiBOVUxMP8KgIEkgY2Fu J3Qgc2VlIGFueSBuZWVkIGZvciBhDQo+Pj4gbWFnaWMgY29uc3RhbnQgaGVyZS4NCj4+IEFyZSB5 b3UgZmFuY3lpbmcgYW4gWFNBIGZvciBhIGNhbGwgdGhyb3VnaCBOVUxMIGluIFBWIGd1ZXN0IGNv bnRleHQ/DQo+IFdoeSBkbyB5b3UgdGhpbmsgdGhhdCBhIHJpc2s/wqAgT25seSBub24tTlVMTCBm dW5jdGlvbiBwb2ludGVycyBhcmUNCj4gZm9sbG93ZWQsIGFuZCBhbHRjYWxsIHJlc29sdmVzIHNh ZmVseSBpZiB0aGUgcG9pbnRlciBpcyBzdGlsbCBOVUxMLg0KPg0KPiBBbmQgb24gdGhhdCBzdWJq ZWN0LCBkb24ndCB3ZSBub3QgaGl0IHRoZSBhbHRjYWxsJ3MgQlVHX09OKCkgZm9yDQo+IGV4Y2Vl ZGluZyBkaXNwMzI/DQoNCmRvbid0IHdlIGhpdCoNCg0KfkFuZHJldw0K From xen-devel-bounces@lists.xenproject.org Tue Mar 01 14:44:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 14:44:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281576.479964 (Exim 4.92) (envelope-from ) id 1nP3jK-0003Wn-IT; Tue, 01 Mar 2022 14:43:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281576.479964; Tue, 01 Mar 2022 14:43:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP3jK-0003Wg-FM; Tue, 01 Mar 2022 14:43:58 +0000 Received: by outflank-mailman (input) for mailman id 281576; Tue, 01 Mar 2022 14:43:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP3jJ-0003WX-OT for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 14:43:57 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 05e66ced-996e-11ec-8539-5f4723681683; Tue, 01 Mar 2022 15:43:56 +0100 (CET) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05lp2113.outbound.protection.outlook.com [104.47.17.113]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-37-rD4iyPtWOT6clTKuJ1yfVQ-1; Tue, 01 Mar 2022 15:43:55 +0100 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by AM0PR04MB6691.eurprd04.prod.outlook.com (2603:10a6:208:17a::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.26; Tue, 1 Mar 2022 14:43:53 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.027; Tue, 1 Mar 2022 14:43:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 05e66ced-996e-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1646145836; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vfYXY4Pa2JRczICtJYZAMBr1IkiD/j5RCEybgZF2ddY=; b=dN9UAj6xZmnXPWKqVYad5IIk+B6s6OvZzf8RhuVdQ5Fl78nRsh7mdnV0fYA6EKnqwMcWUG SN/V1Vy1ydGXd0HZVqn9on+lynabXSeZwHareoCK3oVJmHQd4Tr1kn0MtLpk6UG0qP7Hzh FQHNowcgzxJInjIPfBZjX8MUxVqypfQ= X-MC-Unique: rD4iyPtWOT6clTKuJ1yfVQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oJEXnXKAuhhoTk7WEQmKvlNUNhbiVab7yDNUaRcRXm/dkIff/eCFuh6l3VdyAhpJfsuhGMVCbFAWBQBOKiE7Cw02kM4H8k8ig+6xMuCm2X4DPpYIOLZ2mYhj/iotQ35xQ851RuR2Sci6YZBsiFjbYK7FmAlVY8pygCfesCE11i5OPqJN15Iwce2KKPKLzC+3Qh2ZdruGFBjVUAPta+WRuRUeJl7LK6G4jI329tBkVMDFRgjBt2Er5TBQcTLhTkuHMRsIw48CWJiM1YHU3Lvgort/TWq5JfxMXFm1cn80vKJoxMIbx9RIRDq7KuAdqFAnVU6k/x/oBM+4QrsZjZA8GQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qwJzIZS51ymivE2MOwq4WJF7j8kjoWz9UHofoBY9E/o=; b=EwawHODIh2SfRzZcEd7OtH5ZC+JlpNpg3UrLFuZAJk12Bc2/pmy2PvsfLiDhDzqfa7vLyawDffGBSmsGUZvDbrKhP/3s7YGsmOa8lnRETdD/ExqjQnd8YQk1Zq/XLcJd0vDtu6Hx5B5lYUUlftdChK+qmjKuy8E4nrn94uOnax4e6sf7i+L4VZgxbyahYrEBeVkZ7rJZAz1dEzxxiAF+pyhMJHTJmQ9KjntZc8pRm2xi/2EkAfKbPPlOZAojyo3au/WoYsUwOP1D9dStsc/TBQQebHJye4PbXI4eZ+5I9Pqo7EeBvqiL95qlMN60IVf+wenKQvznDMykA6XGXvncwg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <2f30d30e-5e65-bd03-2975-b81e2eba60a7@suse.com> Date: Tue, 1 Mar 2022 15:43:51 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH 1/2] x86/time: use fake read_tsc() Content-Language: en-US To: Andrew Cooper CC: Wei Liu , Roger Pau Monne , "xen-devel@lists.xenproject.org" References: <77675e7f-2a7e-f517-4aba-e20774c8bfe5@suse.com> <2c3bb06d-e4f4-33d8-7972-71dc7d61c554@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS8PR04CA0029.eurprd04.prod.outlook.com (2603:10a6:20b:310::34) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6aa21200-4fe0-4c76-0ba4-08d9fb91e7f2 X-MS-TrafficTypeDiagnostic: AM0PR04MB6691:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5T+/aoBSOw5sPkLKI8AKPiWfdJm1+KlAqzmoAJbLUCBFDFhtFX4cKnXJf1SdwA3rO8NUDAftOfeGmbWR6tDcogt4iAE3rQ4Ag9hr/vQiYgldaFqzMeQSDO/PKEwyw628PEE1OHzUvB2BLsf8i0JRty7XgaxRFUhLVYMG+Uy0e3Ls4XNwWTFu/cm73hdwZHncxYVqPhuvqy4a6ewhQ20Dw7cAtfd52Gj3V2yoXvnkEguGkw3waeqiumhF1nF2RAb6ph9XjSh0tbs1Ane1uI7KP/2/gqp+hpIgEg97Mq64C6MRbJbFNNXaq9AG6PXcUm5dFhPTyhBoHRcMrk7sZIBJAW+2wkcfHRZvGRSu33CpULjcg7BoAcVl4bfBhWrefjEExU11icRjGlWz0QILcQ9AOnYvysWDRBLqJ6aJ+rbEjHr7TpExQ/tjxGgrTdiJUoWevzN+N/FAy1QckctW4rG2aEzTNneEZEsjw5RDTL5RCfzcFTt/wDoGZYLiYpYNfJ5m9IjWQmiwRFvDzg+IOzoIl1pyzTLPuCyueM8YKmYCqbsuo4B2D2KCzZ7g9IY1C5MRi/Sv4Pc+E+Jfau0w2p4PqFMPaLSZ+6zxnIxoHMa4h7bCa+4nGg2akvNmI2i1WDB4DTcxYQZx3Z2Wl1Yj6HLQu9Z92nx4SrYIzMx8RMx125QhhnweXjmkgGfJNfSEu8V7okw6YzeJDwzP4GxB19wJVfyUgdzZYANEmKY39gbTWotVFuzOsEbElJyAI2XVtTCh X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66946007)(8676002)(8936002)(38100700002)(2906002)(36756003)(31686004)(66476007)(66556008)(4326008)(6512007)(5660300002)(4744005)(316002)(6486002)(2616005)(26005)(186003)(31696002)(6916009)(54906003)(83380400001)(86362001)(508600001)(53546011)(6506007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?jd4btnBgANNtO23KOyIeXX7LnOW7UrrYLUn2bWOuoc6d3cAQMqseu96aGbcC?= =?us-ascii?Q?qrwJR1++iTmKNsN2cJc1DfuusEnurWWPu0Vn7Ck5dlBtR2KDcsq1OTgdhTl4?= =?us-ascii?Q?C+XsPjGIYvmUwHYEwsTVPfFQS7fefdBOOkQ4JT0DtSwnh5CurdHXHZVr7kT+?= =?us-ascii?Q?NR57rMkngpSJQT+09Uzq4UcUeFqxPa3Y8/xl9zQ8ZyXQ0hZy/LtwFvcdMRTu?= =?us-ascii?Q?kWNvssZIbwrsOi41IlPk6x3nVPx5IJMM+nZ9AmqPsteRYhfPdZ6TSWY+rrH/?= =?us-ascii?Q?Z5Qrc1rLzWn0GWXxps5WvMl4bhR1S3P8SEK6IK6AAiipY1j5+B3hoMoClBpy?= =?us-ascii?Q?sn3tykjYK+1TJvDJAGDqmnY8Bandxv/e16DBsBxevmOmBdqfqE33Cp82vYxC?= =?us-ascii?Q?xRuQ1/2eSPr2JdiHVIsSrY7TrUFbT2kpklE16kosT4BuUlqZYIRvxsJLOVyh?= =?us-ascii?Q?b6NywYS3m47JOBT/XZompi7ZXAgUZUaQxbMzf2TfyJ+/mjZCGALgDPw6q8Ec?= =?us-ascii?Q?pPujUAlvT75cL00OrJu8UIsAjRAfhp+JoOVcHLC+vgctPgqHy6k+AMphgqcR?= =?us-ascii?Q?JSeIwqXFdzFOsQeSdUxdBO5OumZwhPjm8XlD9Pfa/tQ03KuKvLMXESaWHNKA?= =?us-ascii?Q?B7bJygxO5zIPIOcoJMwyZ0iGU0yMlrlB8fYlc+Uym8pPXKgrnIpzU+ncYmW1?= =?us-ascii?Q?1sesMTiUfgyYn7/Cu3uNZx34ubxnSp2zNKZwPUnv+ZQuTz1YAuEkmkvthIEV?= =?us-ascii?Q?+0Ss16mZMWGpEkgk1psX2guWrIc1/yAKulnzkUcUWDuTZbAKzbqSAeub8YDP?= =?us-ascii?Q?jpPxcMyuexfAgUbhVacbH/c6bnJW0/fUHzKI8F48KtPUKD7KJ5/H520JyPHR?= =?us-ascii?Q?H8WA5nbwQ9adldMWNA4e/CBkH8fracitHNrz6NPMLRZ78fL8zndCwr5ghE0b?= =?us-ascii?Q?rThpgNKj0VQkjc2ncZ27fjuxuDMgmH7gJhlAc4wLYDo3jBQcNMHW0pUO6mA5?= =?us-ascii?Q?rz31ezBs6v0aLyJ5g1Glk0lh0MCcSwggVIJzTApF/k8l5zzMw6BcLso3IJJQ?= =?us-ascii?Q?jFaBmcWOWqHZAuLJ9D0UjpX5HsxZ+6XDRI+MhchzWdwm6ShxmKAk2GnFfzie?= =?us-ascii?Q?aLNLuGSGvW2sMPsIoQZMaVqEhzb0CGEzMq9CSsXGe10qVxMxiRqDjhca3Bpz?= =?us-ascii?Q?db5ZCV8DhjR34PMIRILI0W9nP9DIL+viT1gZD98OV3i0oViE8iHlM3MU2De2?= =?us-ascii?Q?qDzOFz4TQRg2KfUWNwbx4TQ/GDeMAjUrvbBCocJyUyMAqkJIVYTVwdlByfxq?= =?us-ascii?Q?nvwQTFi5GEVSKBP6yEgS1O+ezXYzGqf1GSwzkuWOujezpcmpSlhejs3sVQt+?= =?us-ascii?Q?9nTpxFUgZsuyBEcmCzGT+zEAAt+73Z/sz7y7ijyhmTol6y2xSjeIvHKVYkPm?= =?us-ascii?Q?HbXVofB85lYPsfaR6Nj1JEfx80UNq7N8sBb9j3QvRMq9co8HCKFgcNwfWIfL?= =?us-ascii?Q?VvL9ZTni/b0Vihk1KmK3ilHhMZO91eGX5etsDIuSU3972UH7QW6vInXW+hNz?= =?us-ascii?Q?Gm5rNAPQY07vUDh8Q3qCEy9DNUBvZpV3DuFcK/yM18YDBz86ZbK2X0doEiaq?= =?us-ascii?Q?4CnrXyHAY5SZdwyWaoCPaUA=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6aa21200-4fe0-4c76-0ba4-08d9fb91e7f2 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2022 14:43:53.1740 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Gpljv+BOz/ZIdvuGYSEBKNWK3MUpNP0Qe2Q8c8QQJ6+Ib4TVfAqh2gOuiGxkVge6QSqgkk1SVVniFDfTxIYNVg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6691 On 01.03.2022 15:39, Andrew Cooper wrote: > On 01/03/2022 14:14, Jan Beulich wrote: >> On 01.03.2022 14:07, Andrew Cooper wrote: >>> On 01/03/2022 11:05, Jan Beulich wrote: >>> That said... what's wrong a plain NULL?=C2=A0 I can't see any need for = a >>> magic constant here. >> Are you fancying an XSA for a call through NULL in PV guest context? >=20 > Why do you think that a risk?=C2=A0 Only non-NULL function pointers are > followed, and altcall resolves safely if the pointer is still NULL. >=20 > And on that subject, don't we not hit the altcall's BUG_ON() for > exceeding disp32? There's no altcall involved here. As said in earlier contexts, altcall patching comes to early to cover plt_tsc use. Hence the only concern is a non-altacll-ed use of the pointer. Jan From xen-devel-bounces@lists.xenproject.org Tue Mar 01 14:45:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 14:45:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281584.479975 (Exim 4.92) (envelope-from ) id 1nP3kz-00048v-Tu; Tue, 01 Mar 2022 14:45:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281584.479975; Tue, 01 Mar 2022 14:45:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP3kz-00048o-Qq; Tue, 01 Mar 2022 14:45:41 +0000 Received: by outflank-mailman (input) for mailman id 281584; Tue, 01 Mar 2022 14:45:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP3ky-00048g-Ic for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 14:45:40 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 430805ff-996e-11ec-8539-5f4723681683; Tue, 01 Mar 2022 15:45:39 +0100 (CET) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05lp2104.outbound.protection.outlook.com [104.47.17.104]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-23-jGdeFzw5PYee6YkSS9tEUw-1; Tue, 01 Mar 2022 15:45:38 +0100 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by AM0PR04MB6691.eurprd04.prod.outlook.com (2603:10a6:208:17a::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.26; Tue, 1 Mar 2022 14:45:36 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.027; Tue, 1 Mar 2022 14:45:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 430805ff-996e-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1646145939; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DorVAtudWv5Of1f/b2H2VMdz9EpaBjaWcK6d1llyyy8=; b=AEIxSj7WsH3LIEYAGtPNpSCqz3IUQ7ScAR2uR+u1oXKoqTX0uZuqrGH05JO5zoqi9MZbF0 EELMtn2fTP9jOr6F5nTci2j3NuY18OxLJ5OwSwllSeMSkbZ8rtnZgYktg36lzDdhbhHnAV q4isO9sJ5es69cl9CpW4UbKe7It+A9A= X-MC-Unique: jGdeFzw5PYee6YkSS9tEUw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=enLtmbEmGZyacWRZr499XuTeJUA20AxWK+4EoUiEmUuaT5j60hHeXNTIQ5OP86SiKvJ4HzJe1FiiZEzHvwFwaYNwQx9/hkb+bBfuYkKs8vwGSh4LpdGaW874CnHZcxczLDI3oJQsdiyVVZ70I/V+/TM0shRMH+RjlGTUCspXtaCj+ynrUB87cqBOjBYVLx/ufaY2/szfOQJz4mIKQFNw22l3vlqPWsCHIp6zzXsAaukcXAxLFz8pC3sh7TsQvnI+PN5YfmTzj6D9WfxivN6J2CzKwcS+knTkO7zzCgaahMUHa9TSXRYVtk8Q+m5k/FHgLPh1N28WIpVd8riDBwU/FA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Y6W/DUj8P73Qa56qkRd4IJ/l2Yw34qOaIaEzNLwsejY=; b=kB79BYkuM8bVOZwvFZtr8ew7jw4gyUngCq9iBgs+n3lYmVrt2vmtUYiF0gIETg7IUPz7HuYs2N4mURYiQcLrV9F5Gs7RY0b27JOGD4et/+G46FRJ0/Yo4TGZyFUSv3iCCV/vtprEYaNmXGoZkc5DfN7MQuyvORNYhEtkR5UBMUYDEmx6cvxYWqkFA/OVkwn9YTvBA9mA8Eqbg62x3QR/RDpeUbNxXOxUrBj7lyirJ1FRt7QayrIz6QW+UjbMZnU0WDpbQFeflua10LXvt0XwG4xp8zt56YhEZPBk4gZs79xh/YdLi92jZDgV/AOOQ+BNoJEblljaUmfZCl85smUbtw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <99599e7f-c72f-7b20-d601-fc4fa99998a4@suse.com> Date: Tue, 1 Mar 2022 15:45:34 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH 2/2] x86/time: add CF-clobber annotations Content-Language: en-US To: Andrew Cooper CC: Wei Liu , Roger Pau Monne , "xen-devel@lists.xenproject.org" References: <77675e7f-2a7e-f517-4aba-e20774c8bfe5@suse.com> <61bbf544-74ac-b698-425a-d1db80acab43@suse.com> <20185a89-0a2b-6bbd-5484-31b6582ed200@citrix.com> <40ce913e-4388-2d2f-45e3-e725a927da92@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM6P193CA0114.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:85::19) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 578fa8d5-341e-44eb-105f-08d9fb9225a9 X-MS-TrafficTypeDiagnostic: AM0PR04MB6691:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: i4/GnNOabh7DQBSA8aeKynMvk+bMwI7utW3BFnd9rrRPfdaDZgJjNGJHh3uoX7V8kHvQQFoE8pxPIv+FfKQh9xDaZTfNwQbbc0dCttNOLye8mI0/DXQEi5+KUZtoO+0Y9UpOuuzceZZAAE+VG0Rs/xW1IvwsQNzqehlOG4rn01y0SL1KqF+r3LE3ipHBdWrOm9hF+vxoO/5sKrdbsZPl8GlCsoN4xlrrSWOcUAbwr0wmPQNDim4+D9MlD1fLTOJGaMyyer4dWoiim7eXVrDvzhr+f+cNsrNnhFs2yIRLqZj+oJQEFBwRa6t+yEO4ygo/7BLl5YtQudFn7gay5GMe40x6HI4Ez1XiuJYisTxm5FwLe/T2JeDGDgvs4iBjlrIseMGxfD01lewZ/jDOTHQWrqAH+38eJEy+Sx2SUBpWTbGPc2GI7qW6ZYGVT4ygb/cQxy+3SHzK6bTP0gxGMb5LBjdRhnCVV3gUoUsBhIg657268WlJQBhS1/62m1dTfno05Qzuar7azzOmMcVUn4loFHxBtkETvUF2+lD6mMVpy66zUtuzntYc/zTPVcWgb4Bu980azYbt3exLtqQLcKoGQZPOds3LIj6HSGfGII16RVrzEkrsoBKAu4P1Sr4ZsECqtAdjRuxokZMpHgcj8ryoQ+JN5QoSPBe/Y32UzIxTZWRnrO+EuG9CscC46LXFowhsTxj8PZZXjzrj8nOGPLOT1MmyILPnr2kTBux2ydlqGXdCOpFjt46zCpfJ0bbp1bRq X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66946007)(8676002)(8936002)(38100700002)(2906002)(36756003)(31686004)(66476007)(66556008)(4326008)(6512007)(5660300002)(316002)(6486002)(2616005)(26005)(186003)(31696002)(6916009)(54906003)(83380400001)(86362001)(508600001)(53546011)(6506007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?p0glLugHsvTHFWgQ3vdzp/VMV2ah8gBYvXBqo0F1ghyKwtk5XBjb82oWPMm1?= =?us-ascii?Q?XRg4FWliXTrkPlYTJhzavSV72uVDLbs+ULg7wvovx+DGgV2ZlX/COw1Vy2v0?= =?us-ascii?Q?lI7Km2ouLSYBgqjcAxeimc2jyfpMl3iqwFWaAPNsjzH7pnViNQR2DWOWRoU4?= =?us-ascii?Q?Y1xzuKbjam3Xhu6Y7936L2l6OvYH+mx6yLam8qmW4GqiRcYBTNK3jNcUOq7T?= =?us-ascii?Q?7ifFt+iKVSeLKXaF2U3GnTAg5yXf+v8MnVG4aIgv2TSNn20RmVoXeGMuBCbT?= =?us-ascii?Q?O8bUrTLfLxeyvUeI95zICoUppuB0/TwpJsZmulSO3B1TZKKd1mxeb/WRDu9k?= =?us-ascii?Q?FjuNNeewXR//LE85KFn6Rj04j+WUiFB6ojPYJjK1SM+BIzQRv46oOtENgPcm?= =?us-ascii?Q?ByZWiuY+PrNHh1+vY+Mu8Y9SR4DXjP+t1g5DOmV/KmHTCrJQ6aNKX/PWx+GH?= =?us-ascii?Q?DaIp29JtYgUoqIqBn9izIyq/U0Dhw+PVtFzpasNs2O+iN0SLDkBWp4mA5dQ3?= =?us-ascii?Q?GCttNWwMBig23qnZ5Ft/dqa55YNNJKyq5rpeubdjyNC4FRgb+LbxfbBQRzpK?= =?us-ascii?Q?2gOtKHCw39wq01oF18FumfACwnZKO9TIGbjFcIvG8yoJMbIzOO0ibojhAiz5?= =?us-ascii?Q?0KC2SwxZukzgqg4B2Exeo2szXWlpvGU9Uu15SqDe9a65p+xm28d/4VXALVXt?= =?us-ascii?Q?eYD1tCmAm0r+BjN7XO4hbTYRm994EfhK32XHop5/KK1i7++zfD0i8lwEjKxg?= =?us-ascii?Q?Ri/l9BnM/18+5mpE/0XLszXmqxPmcthP3KIQ0/9UCwjVhNPrh6JuIJ7I41A3?= =?us-ascii?Q?p1sSd7kxrgynwFy2RfNTljvJegvyMjKbkqCZcU/vL5m+0QTX9tGei1gn416u?= =?us-ascii?Q?rFj+tRcBQnrug8Uxi6TJev92gX7e20XJjzxAVGSQP3JzF50DGdya2txp317+?= =?us-ascii?Q?c24I2mm8gSbNwf3OccYsaMEXBrF8kbbrGbFjIJyeeUzrbqJvN3jni0VDyKME?= =?us-ascii?Q?SkXhSYsg2IxmX4FOAgGSP8HzoOuyOi2KICDEaA/8ygNSEH5gbAcvP80a2sjT?= =?us-ascii?Q?WilrIp6n3/6D0ElExHzCVfj2hbeaWcPcZW7WnGDQuixYf/iaV+cKqvbmrK6x?= =?us-ascii?Q?sAxZLgrHbwaPlbbjNtm+k8tdcJd0qjIlLwvav9WwV751KrzkJOmX66eZ12Bb?= =?us-ascii?Q?Q3Yus38LJHVll20C4wxJr5aOTvWa9oxQ2OabO23OOFj94oxjG62zbKzASU9s?= =?us-ascii?Q?JCLdF8kPqCRoVyk3YzcSLAA0mh54LJi6fI25Baa5WrnoTMYdmKM7fyJvdrSt?= =?us-ascii?Q?EhFY9kOjxPicD3eZ+XfYYA2xyMGiY8EIiFD0qGmft0J6NjRVt7RU9rGhAXU5?= =?us-ascii?Q?TpppPp4LsP1rHA6jN1aN6e3HZ5vkSNprPP9Dc1B1ioFhER2sGV+CXeDMHNyp?= =?us-ascii?Q?KkjVaD5aoC1FtS3hS3UzqDxU6yCUMKEds2sWeB7ufwXN+S17xUN4GyQNfKbn?= =?us-ascii?Q?k3h+nKOCRG1Azo3w920MT9FVy6w6qDak08T7UzDVI6GrMO255ySiVCYtV4cQ?= =?us-ascii?Q?Qt3dTvzyAuMXlwKYIw14EkaYswTDK9SGu0xVAD8iTgLZGD7CupfURKWef2SQ?= =?us-ascii?Q?uUB6voh+ESlQENZ4v91X+38=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 578fa8d5-341e-44eb-105f-08d9fb9225a9 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2022 14:45:36.6519 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1t9fL8dugMr1Y2HYL4nf2HuSSaMuJ/06tpOycvSvLb1nfFu8cS29WaLDBVVEAH4iX2K0TyhIZKJOc1QadFYjoQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6691 On 01.03.2022 15:24, Andrew Cooper wrote: > On 01/03/2022 14:18, Jan Beulich wrote: >> On 01.03.2022 14:18, Andrew Cooper wrote: >>> On 01/03/2022 11:06, Jan Beulich wrote: >>>> With bed9ae54df44 ("x86/time: switch platform timer hooks to altcall") >>>> in place we can further arrange for ENDBR removal from the functions n= o >>>> longer subject to indirect calls. Note that plt_tsc is left untouched, >>>> for not holding any pointer eligible for ENDBR removal. >>> I'd be tempted to include it, for consistency sake alone. >>> >>> It is less likely to go wrong in the future if another hook is introduc= ed. >> Can do, sure. >> >>>> Signed-off-by: Jan Beulich >>> With the commit message, I'm not not certain if this is linked to the >>> previous patch. >>> >>> Overall it looks fine, but I'd like to get clarity on this point. >> Converting read_tsc() was discussed (with Roger) earlier on, so I'd >> view this as a separate change. As said in reply to your comments on >> the 1st patch, how exactly read_tsc() looks like is orthogonal to >> the changes here at least as long as it doesn't live in .text. >=20 > Ok.=C2=A0 Reviewed-by: Andrew Cooper Thanks. I'll take it this includes annotating plt_tsc as well, just as a precautionary measure (and as you did suggest; still visible in context above). Jan From xen-devel-bounces@lists.xenproject.org Tue Mar 01 14:46:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 14:46:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281590.479986 (Exim 4.92) (envelope-from ) id 1nP3m2-0004sf-7p; Tue, 01 Mar 2022 14:46:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281590.479986; Tue, 01 Mar 2022 14:46:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP3m2-0004sY-41; Tue, 01 Mar 2022 14:46:46 +0000 Received: by outflank-mailman (input) for mailman id 281590; Tue, 01 Mar 2022 14:46:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP3m0-0004sQ-Dh for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 14:46:44 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 67bc262b-996e-11ec-8539-5f4723681683; Tue, 01 Mar 2022 15:46:43 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 41F3461602; Tue, 1 Mar 2022 14:46:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 140F8C340F0; Tue, 1 Mar 2022 14:46:39 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 67bc262b-996e-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646145999; bh=XuPfbJ5gyWV/sNDbzNt2QVmxD4bkkTRFvCQ8bl7OriU=; h=From:To:Cc:Subject:Date:From; b=K1iG7/KtxI8qmv6YXuSrkbTtoXNkYG7uLI00ux8Mcf5KqeJKyaZJT7hbh5iedi3TQ dQU7yl7Gl+vmbbyoSH2DOPc7mXMkA7fkcZYAmTkDaGXUwdn39QDpMrxmVUn0OUpLiL SUFPYvGqYxuiKALMvfeRGEPa8QWfqPDqLpd0F5MBoFtu/Jc9k93IjVRjJHSMsZh1LX lZXknFTSjrfvvd2/ZEQWdtFPo/AeZ4LOGqIXMtn7HDrH5uixCv6Lsc2RRcqK4iFogc C+DW5bWRvlySFZMxHRnZkX/+LrUBo6C6hBmeKxtN87LmIDiYmllCEUDlTaeo9uXBGU CPnBn6e9oIkPw== From: SeongJae Park To: roger.pau@citrix.com, jgross@suse.com Cc: mheyne@amazon.de, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, SeongJae Park Subject: [PATCH] xen-blk{back,front}: Update contact points for buffer_squeeze_duration_ms and feature_persistent Date: Tue, 1 Mar 2022 14:46:28 +0000 Message-Id: <20220301144628.2858-1-sj@kernel.org> X-Mailer: git-send-email 2.17.1 SeongJae is currently listed as a contact point for some blk{back,front} features, but he will not work for XEN for a while. This commit therefore updates the contact point to his colleague, Maximilian, who is understanding the context and actively working with the features now. Signed-off-by: SeongJae Park Signed-off-by: Maximilian Heyne --- Documentation/ABI/testing/sysfs-driver-xen-blkback | 4 ++-- Documentation/ABI/testing/sysfs-driver-xen-blkfront | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Documentation/ABI/testing/sysfs-driver-xen-blkback b/Documentation/ABI/testing/sysfs-driver-xen-blkback index a74dfe52dd76..7faf719af165 100644 --- a/Documentation/ABI/testing/sysfs-driver-xen-blkback +++ b/Documentation/ABI/testing/sysfs-driver-xen-blkback @@ -29,7 +29,7 @@ Description: What: /sys/module/xen_blkback/parameters/buffer_squeeze_duration_ms Date: December 2019 KernelVersion: 5.6 -Contact: SeongJae Park +Contact: Maximilian Heyne Description: When memory pressure is reported to blkback this option controls the duration in milliseconds that blkback will not @@ -39,7 +39,7 @@ Description: What: /sys/module/xen_blkback/parameters/feature_persistent Date: September 2020 KernelVersion: 5.10 -Contact: SeongJae Park +Contact: Maximilian Heyne Description: Whether to enable the persistent grants feature or not. Note that this option only takes effect on newly created backends. diff --git a/Documentation/ABI/testing/sysfs-driver-xen-blkfront b/Documentation/ABI/testing/sysfs-driver-xen-blkfront index 61fd173fabfe..7f646c58832e 100644 --- a/Documentation/ABI/testing/sysfs-driver-xen-blkfront +++ b/Documentation/ABI/testing/sysfs-driver-xen-blkfront @@ -12,7 +12,7 @@ Description: What: /sys/module/xen_blkfront/parameters/feature_persistent Date: September 2020 KernelVersion: 5.10 -Contact: SeongJae Park +Contact: Maximilian Heyne Description: Whether to enable the persistent grants feature or not. Note that this option only takes effect on newly created frontends. -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue Mar 01 14:48:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 14:48:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281597.479997 (Exim 4.92) (envelope-from ) id 1nP3nG-0005Tl-HF; Tue, 01 Mar 2022 14:48:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281597.479997; Tue, 01 Mar 2022 14:48:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP3nG-0005Te-E9; Tue, 01 Mar 2022 14:48:02 +0000 Received: by outflank-mailman (input) for mailman id 281597; Tue, 01 Mar 2022 14:48:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP3nF-0005TW-Ai for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 14:48:01 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 970bf319-996e-11ec-8eba-a37418f5ba1a; Tue, 01 Mar 2022 15:48:00 +0100 (CET) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04lp2056.outbound.protection.outlook.com [104.47.14.56]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-31-ULVi9T2pN8Ce-Q3ftC1Pjg-1; Tue, 01 Mar 2022 15:47:59 +0100 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by AM5PR0401MB2610.eurprd04.prod.outlook.com (2603:10a6:203:3c::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.26; Tue, 1 Mar 2022 14:47:57 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.027; Tue, 1 Mar 2022 14:47:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 970bf319-996e-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1646146080; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UQ4jdTWxlZGApeChgMmKKjO8QRrHTIp03uBQQXZSq8M=; b=NLIgR1dK+cqWixTvpV60d9KnMvV7WhEyW91bfnCPj4CWb0jps4lu4nsecAFq5oEiKxM+gy qg9uQYnaPi3lysb+4XaeGgIjbwHLsYRGkIGlch6TZPb0feXhn/WKbPEGliodnTW2ReFHHR fte8V5RPaEL3Asyw4FPPgmlDV0wH2x8= X-MC-Unique: ULVi9T2pN8Ce-Q3ftC1Pjg-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UrD9zzenl5+1NjBkiJMigWlPcPtH2MiG2GQSAym8C0ACz+MMFPCLtfYSTtWfqqXgHHwKrRswlJIFMumTCPZ+596Dzt1NSfBLuiAXUIYXCzeZf4u92e6cSO951KVHWAf97XHrkrmxW2guwQowEaaofC/uZufzgSsTEWVNe23z8nDGDdmB/u8LDWDZ4j+9HpEneMc+kWfqg1c2vbH3fBenWM0FBZs0G+niMxj7sx3wcB2Dk2xZIeAOnM4ksdqvOfMhVeMtKWmcI9pgjkn+1b/oLyr3EHdfm4yxK8Q0W8NtXHJepx+1c43Yja9PQi4OWvnWXHxwumzf6Dz2f6RvUUwbJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QGJRUDfOJhcjOsQNVB6rBpzXdwkRo0EE1W5f+8ArDks=; b=ZCfp8o0SoDZDokIcdHGiiLm/0cw3bgUwVuCTuh07715YQlT7me0s3xTsPGhRajnNEXHP7VSrKD6ejQbnryXtK46vqejvEqNy6lW0TAOK08aDy9TQWFOwlXDQJ77A4g2PPSqnb/wst3OMCtxbBipywChkmq90XJZJjnABpxnnCRJeqIq9+zzh97riLHkwKPn5HGX2ERufoIfBHvNDMFzdOJyXzSN7XShxBYcM0oigN950de2BsbX6VyB/15VpRw1zea25zfOnAyxM68H6Ut4JB1E0qkF4U7Eoub1j8YOqizkxB6XrB+GU/vRuIEhj54IMIau8MV1uvPyeHtaDUyUBvg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 1 Mar 2022 15:47:55 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH 2/2] x86/time: add CF-clobber annotations Content-Language: en-US To: Andrew Cooper CC: Wei Liu , Roger Pau Monne , "xen-devel@lists.xenproject.org" References: <77675e7f-2a7e-f517-4aba-e20774c8bfe5@suse.com> <61bbf544-74ac-b698-425a-d1db80acab43@suse.com> <20185a89-0a2b-6bbd-5484-31b6582ed200@citrix.com> <40ce913e-4388-2d2f-45e3-e725a927da92@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS9P194CA0004.EURP194.PROD.OUTLOOK.COM (2603:10a6:20b:46d::32) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0eea43e0-1c9f-494b-675e-08d9fb927979 X-MS-TrafficTypeDiagnostic: AM5PR0401MB2610:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nraxtAx35rbBRA7qusffwG1n+saj5gf15Fs6PEPzdT0CmEzRz2/Xq1dYDoxl4mmyRm/yJ3Ynv4SewJyMSv5XtOPDd9KZPJOtPNkEPhmnGcueAyqpgRb2TH2f97iun/NIruLHTI5M1GRuR4gxddAW6oE4n1VX5diNdjM09HLzbWmZ1ECN9asf7v0biRMUmQFEgprznPtxxyTFiUzz8G6ayRXAbujDrJwyef4b1gXcnuJ/WqKo+GhkfsU6Y7sVmR8j0mv3uS2A3e9KL7eKFDP1ZVNg8LWm9LhsvihPmWm/BjH4oZMU3ZhUBCxjN7CS8KPR5Ji20WLz2fGWklrcUdfhba/mx69ji/6feXltLPPaZG8Y3Cte9c44hJIPV8JRblw/wSOdsvDI7S0gVgC2uff7lr3L9ipHdCtUlkOBPVcjeG3mYWru2M4SSd36rRwSnzDwE1xm4LuoWRAeLpVGSPGS05JXr1K04SoASDh3jYx3EYNFd9IfOgcVDRdO9Nikc0aGIkBvKb/PGp/wRbli4sS4yZxGvjt+th5bFJq3cVtk7qq5GH/UwIsocsJMVQHuCmQfDSoRahR/hxdXKjY2vHDuhnbDTZADXIAEPA4fB+QRcPDIQmZXMz+IXkQSDUPXcW/aFuY+0CFX6eOcY972UZMAuvqiy2LortqsDNfDZRsjW3XE0feoDIykHax2LyPw69s5Xj+41z76d4ynpNwwpjJIe8cp0ovcxML4gR/Do6cO2qKBqdMwpot8iV3V3uWcS82j X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66556008)(36756003)(54906003)(8676002)(2616005)(316002)(66476007)(66946007)(8936002)(508600001)(31696002)(31686004)(6486002)(5660300002)(53546011)(6916009)(2906002)(6506007)(38100700002)(6512007)(83380400001)(86362001)(186003)(26005)(4326008)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Fb96YWpMajcUrNnkioKcBPVnQziXJaZNgqsqK/grfDD3YqJ5BoYR7xRAeOkZ?= =?us-ascii?Q?AqUvKvW84gOzWrzGGEECTL761TT4FUuXozod+tQh1MHQE7Fk4X6/vM7LkfyE?= =?us-ascii?Q?Bgi3TuGsl2VmYbYT2NXvPgYnFZ+zhtXYER9Ev4jtg/8BKSK2n6wQK+2QEObX?= =?us-ascii?Q?9zC5dYzfN/83YcUQqtElbBjc6tYlFDNwD2Gt2ghVyPaRZsg9Z+LWgRXWqPQI?= =?us-ascii?Q?lJPLSlNtrKe7XlCXCIt7aGfYvAUwvAXqOZ3+fXEUlxEwze5XEq0rqqnuoVEF?= =?us-ascii?Q?6mPLUpOoE9k7R1X9ZxdregW38wX9lKXIAZbI6/DCuGP3+BomoaiSFBOVL+84?= =?us-ascii?Q?Y15KTKgExuIGImAwnYVK+fMZBbBbQrUnSN1ce7M++/MjWDicE4HJFMqmet+X?= =?us-ascii?Q?nPZtLJjfElYVcnL0W1zgUBfbPvl1YcNACPmEGK9zNZHP4Ub5rlAsiT2yF+/5?= =?us-ascii?Q?u0Tm487AnZ4dPdMTorCnuHws2XLgilhO0/jDMf5u6R5q92843TyTEnTEBCFp?= =?us-ascii?Q?OmfdRizxXTZ2sZ+Y+Vwt+JF5nDkSFLBcbyp/hCVxDO0dCXCBbXXLMqcBYPKZ?= =?us-ascii?Q?+PmOJsFAPJ9llvmXu4YxPFNkOIq0eIQUKzuwKl+sfPXIdv3QvaN9dRWojXNc?= =?us-ascii?Q?2Bt9h8LTLUrik8tvcKsHEzfSW2Aho3jia5tVXeyWn4BFQRVLo5uq9LoPqFCq?= =?us-ascii?Q?5xqKIaaGmQfQ9m7AHglJIf462HHOaT0ZNDYMYwsdBbVjaG0kO9gNHOzFHzvK?= =?us-ascii?Q?feOzB2UGYzr3OkDOm50Ux4+NrjvzznFB3lqQ7+k94Fdefl0CqYaIqnS1BNOv?= =?us-ascii?Q?UuMfaSB581973Ui/k6craKFbNH1CSDOnXou1VINkHUEKygRiyVScOxcY1Kwq?= =?us-ascii?Q?tMaVYWrZOGq6jpSul5U6EZyCigZAUxDn4k6sVG5XmdQuN+OHjcK9AHY/9xF4?= =?us-ascii?Q?i/nqHhnBlWwBkRmdndOvF32fS83hEWDQ7SJbWB8yg6vaXORvRhn7nCKPT7pt?= =?us-ascii?Q?n+onCQiAqQRlFFJCLxMegkrc383ooMEfHSrIEDVh/j6W4dILCInc940PHCVw?= =?us-ascii?Q?bUz5CmwUkam1C4uNfdec7Tyb+RDmWddZbqDnPNMwYzVsRvc/y329gDG7kxrJ?= =?us-ascii?Q?amFKCofWPbhRgVRn36O4/WsKxK3tO8Sa/S3cNrA9l6ZA7Aq/ia+wM/7DfY+f?= =?us-ascii?Q?mhNk9mJgd9WMJ5xcyHqt+e4bwywFAt8bKQg1wjSBIXfhsAThoe7VoEkcVIWG?= =?us-ascii?Q?wcR5tE4Q2+zcD341Sp245hDQsh0gI6T5Jg6cjvhbgXu1Rt/Junelgm3WtGle?= =?us-ascii?Q?VQBjysa3FtN82Nb0gQFT8Z1B+ZIlHwzaKtPk/Q0DWqKxyPn2uAj6zQkdIkOS?= =?us-ascii?Q?43da5afhIk81gQoYYTdvRYtG3nscNELFC3TGSPUX+zW5hRUxHJeItkfYk6n2?= =?us-ascii?Q?CjC3lAHs2rnwmI0wYWlJST8l8oUmC5+5cVhL0qkPEV9M3CTAGTO1CkS2UVSu?= =?us-ascii?Q?yXiB1DHF7yBbbyqDn3D0MEuEJT9DXjAnNGxYu6RClMxgrbpTmZ+pCNV/E5Wt?= =?us-ascii?Q?kLKTtTiRYXX0FtTjlaiewulHiRcYz7EOsyYW2l9CXHAnFjLK7EYKY/rGXIQg?= =?us-ascii?Q?v6qdq/otupLCPaarrIrCCvw=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0eea43e0-1c9f-494b-675e-08d9fb927979 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2022 14:47:57.2838 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cw9TCyeTAn86tA9lArOtTqZcojEHby1m9EYi3zmjBBw3bF/Z2ci/QFiAl70WYMvPZMwwp86zBxFYrWo7xseeMQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0401MB2610 On 01.03.2022 15:35, Andrew Cooper wrote: > On 01/03/2022 14:24, Andrew Cooper wrote: >> On 01/03/2022 14:18, Jan Beulich wrote: >>> On 01.03.2022 14:18, Andrew Cooper wrote: >>>> On 01/03/2022 11:06, Jan Beulich wrote: >>>>> With bed9ae54df44 ("x86/time: switch platform timer hooks to altcall"= ) >>>>> in place we can further arrange for ENDBR removal from the functions = no >>>>> longer subject to indirect calls. Note that plt_tsc is left untouched= , >>>>> for not holding any pointer eligible for ENDBR removal. >>>> I'd be tempted to include it, for consistency sake alone. >>>> >>>> It is less likely to go wrong in the future if another hook is introdu= ced. >>> Can do, sure. >>> >>>>> Signed-off-by: Jan Beulich >>>> With the commit message, I'm not not certain if this is linked to the >>>> previous patch. >>>> >>>> Overall it looks fine, but I'd like to get clarity on this point. >>> Converting read_tsc() was discussed (with Roger) earlier on, so I'd >>> view this as a separate change. As said in reply to your comments on >>> the 1st patch, how exactly read_tsc() looks like is orthogonal to >>> the changes here at least as long as it doesn't live in .text. >> Ok.=C2=A0 Reviewed-by: Andrew Cooper >=20 > Actually, you probably want to move plt_src into __ro_after_init along > with this change. I'd view this as an independent change. Perhaps it would make for a better change if we went through and converted from __read_mostly for a bunch of items all in one go. Jan From xen-devel-bounces@lists.xenproject.org Tue Mar 01 14:51:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 14:51:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281607.480008 (Exim 4.92) (envelope-from ) id 1nP3qN-0006wk-3Y; Tue, 01 Mar 2022 14:51:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281607.480008; Tue, 01 Mar 2022 14:51:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP3qN-0006wd-0Q; Tue, 01 Mar 2022 14:51:15 +0000 Received: by outflank-mailman (input) for mailman id 281607; Tue, 01 Mar 2022 14:51:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP3qM-0006wX-BK for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 14:51:14 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 08bc40c6-996f-11ec-8eba-a37418f5ba1a; Tue, 01 Mar 2022 15:51:12 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 08bc40c6-996f-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1646146272; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=FNt0PkLU/gHV1JfBMjBRBHU+/JETTyZQ8Znho2lLnTw=; b=ZC8xlPce1OgZolibSZuwwniMjMCnNcQ0NXnrFAnkEhcA42xMeuIKUSdc cuE0DtJJxO0a2XMcmAW287W6QNbgZ5f6CCT31fOPlGPpmOhnS596dkFh9 YsAzWgT+tb4j+1CXHy9tMfbeBUoo1lhjdKndmlCgVSHoVGuQ5LKlMh/GK 0=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com X-SBRS: 5.1 X-MesageID: 65225268 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:zqjnoawIS4rT1CReRC56t+cqxirEfRIJ4+MujC+fZmUNrF6WrkUCx 2NNDGHVPP3fMGXwe41zPt+390oC78XXy4BgTgVs+SAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGX9JZS5LwbZj2NYz2YHhWWthh PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ Nplls2we1g3J6L3vssiUyJ7FSpiOZBl0eqSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DFYUToHx/ixreCu4rW8vrSKTW/95Imjw3g6iiGN6AO pBDNGAxPHwsZTVpNRBHJ6Ma292Qg3LfTG1Bt1O1oJAetj27IAtZj+G2bYu9lsaxbdVYmAOUq 3zL+0z9AwoGL5qPxDyd6HWui+TT2yThV+o6C7mQ5vNsxlqJyQQ7ChcbSF+6qvmRkVOlVpRUL El8x8Y1hfFsrgrxFIC7BkDm5i7f1vIBZzZOO85r6DPS1LPb2CC2OWg/bThKdNgbl+ZjEFTGy WS1t9/uADVutpicRnSc6qqYoFuOBMQFEYMRTXRaFFVYurEPtKl210uSFYg7TMZZm/WoQWmY/ tyckMQpa1z/Z+Yv3r7zw13IiinESnPhHl9svVW/so5IA2pEiG+Zi26AtACzARVodt/xory9U J4swZD2AAcmV8zlqcB1aL9RdIxFHt7cWNEmvXZhHoM66xOm8GO5cIZb7VlWfRk1bJ5bImG1O RaK6Gu9AaO/2lPwNsebhKrrVqwXIVXIT4y5Bpg4kPIUCnSOSON31H43PhPBt4wcuEMtjbs+K f+mnTWEVh4n5VBc5GPuHY81iOZzrghnnD+7bc2rnnyPjOvFDFbIGOhtDbd7Rr1ghE9yiF6Oq Ig32grj40g3bdASlQGMqd9DdQ1RdCNjbX00wuQOHtO+zsNdMDhJI9fawK87epwjmKJQl+zS+ Wq6VFMew1367UAr4y3QApy/QNsDhapCkE8= IronPort-HdrOrdr: A9a23:iTNQxaFYq6Ck1KJppLqEEseALOsnbusQ8zAXPiBKJCC9vPb5qy nOpoV+6faQslwssR4b9uxoVJPvfZq+z+8R3WByB8bAYOCOggLBQL2KhbGI/9SKIVydygcy78 Zdm6gVMqyMMbB55/yKnDVRxbwbsaa6GKPDv5ah8590JzsaDJ2Jd21Ce32m+ksdfnghObMJUK Cyy+BgvDSadXEefq2AdwM4t7iqnayzqHr+CyR2fyIa1A== X-IronPort-AV: E=Sophos;i="5.90,146,1643691600"; d="scan'208";a="65225268" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O+M8pOkHIuhicArkjVoKOb4G4PdR2CLVqCC71geT86pMgvjNDl/OHmxRPU4xF2vSkODCV20HLSl01lAhuyWLqcRZp1XTxxJNwmslHbFUtf68l0TsV1rQ41oPH21t7128NZsyQFBqqg5hVz2BqStRVaMMVQDlyyTu+WXiDa7njqye1lcqBcWPj7vLBqRbxOJOpchw+5UBfxssaa8Ro3UovXPVS1Q9faLsVPr3wcnOea3FHP+jCGHxbGaPYoZv5soCJ/ADsDfWQ+n/NJklzhWvmEsxJ/hsMTOVrwOxJ7qLOOhv7v+k5sAjwtGVB+zDv+05+389oOsQD76yWUC1LDAauw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FNt0PkLU/gHV1JfBMjBRBHU+/JETTyZQ8Znho2lLnTw=; b=jeemfDpWe+c7SOIPkznKYrPrJRCtGh/IV/7OsmI5f9WLvgN7m8pz3sZ0cO49yfnsmdyJ0E80Fp5hmsrTOVWMgR8bYkf3KwPIrJvQE/f4ofPS0/5ioxQBZIbC8PySQotpQwrrg/tWzr/PInG4yMoZCQD43q9rAdjOfnQ4IHlg5wX9o/jDQ9wWbyhAxlyfJnm5tUbS71690I2eyLXL6dWMzjsTyrUw1zFflZStd/eYNys5uNxWyhoeFTRUq3flbxJMl5ASOTceSaZ3ACiRScnvg0cf1FQJ8ISxLMEbM5vV9gV3E30sLSzCoSX8+AOF9ShcVPA/9kaCgAz/rfrn+2UwpQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FNt0PkLU/gHV1JfBMjBRBHU+/JETTyZQ8Znho2lLnTw=; b=uSy7gkxdwR4uSxVZGaoaGMB8rhMV4uLuX8i7Tu1aEw2nWD46wWNsjJIpDg9/s6CPDx3EuaDGZpmv1g1eJQorRdA+0hG1fNZiOHxo7kVjA50P4oXfxUu2CS5dQKu9fW056JTLZrreDKNej6A4qPymuH80SxA5ClpZEziLTfT1gEA= From: Andrew Cooper To: Jan Beulich CC: Roger Pau Monne , Wei Liu , Xen-devel Subject: Re: [PATCH v2 3/7] x86/altcall: Optimise away endbr64 instruction where possible Thread-Topic: [PATCH v2 3/7] x86/altcall: Optimise away endbr64 instruction where possible Thread-Index: AQHYIaJdlBm1laP+30eCBtzXO5xQTKyqhD+AgAAwCwA= Date: Tue, 1 Mar 2022 14:51:06 +0000 Message-ID: References: <20220214125632.24563-1-andrew.cooper3@citrix.com> <20220214125632.24563-4-andrew.cooper3@citrix.com> <2808e805-60a7-2f1e-0ff4-8da123c79afd@suse.com> In-Reply-To: <2808e805-60a7-2f1e-0ff4-8da123c79afd@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d6c4709c-75e1-4ccb-c097-08d9fb92ea89 x-ms-traffictypediagnostic: BL1PR03MB6022:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: lL4EhZA1zMEex3j9tr7jpnSO4AqewMVKrJcdP7kNqfvrWnXMZKUldB0UKueLCqMM2mV+WulvbTTvR7eG6OwZu8WLoqrO30AAg5IU43xmyrKy2RaW90Ja9XoZOCz9bF/djY0WYzDiiIo5wbaZ0nePq0pckEz8CAxh9RY3V/SNnA2uah/01xgdN+C6KHTA1V3ZP+6XPNRPOKb+YUoYSzU0JXzcENZ+xBEGKgLngH0AB+UvTVdAE0TZWOrVnnopvQPvGd8G2EVpc0wDc8aK4rBg/YngH8ImqvIBOur6U0aOg/FAEavhPZshfmPWbX7RuVPrXbhtDjtZsCc1hV/c1R9HjsY5dKO0fLgU/VvJwboOLZtgrQZv8vK4vqbvo/p/5/Oz42oMh3I9AHdsQXxjq+N0Bv3nEj2NkJrsPjTuC/TjlD7seEjuZNPuHQBKP07sQWMrWj/+6FrImQodz9pNpviRZhlyQFGoNMpSKcYqRiB2c59SqH3YEG7VFHS3bOn+J50eeaW/qywFEei/26kO92pHJTCEIw1yqX2xWKVdTVMVRgAxKVXglay9bl8hmipovqc5leNucGEhWrLYR+mSpxvYWpWmr98iehOmjODA1HDD0TwKsvLd/oORubXtMPAKv6Quo1UMhxxNvUvUpi51MrET8mF+wcf19tIRsPslrdeJaF5iAgc8hxRfRHZhcha5Bw9Maaw0Hr38LCf1WSy1fhIGW0CKVghX1WIK+GqOvpK0AxPEiC5mJRxuFXsLdMzinTI5yNPDFPUYf52B0Bh5sZAIvw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(54906003)(6916009)(316002)(8936002)(31686004)(6486002)(64756008)(66446008)(66476007)(66556008)(4326008)(8676002)(2906002)(26005)(71200400001)(508600001)(31696002)(38070700005)(86362001)(91956017)(36756003)(66946007)(76116006)(5660300002)(6512007)(53546011)(82960400001)(6506007)(122000001)(38100700002)(2616005)(83380400001)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?ekZyLzBvNDFZWlRoeVQ0Yno0UHpSNkkrRFVNN29oNVdzNWZKWDFCYWdzTUIw?= =?utf-8?B?ZWtBSFN0VFQwbDFqNkNvdWZhdWhzaEJZdXpZZDhNM1NNeWhYNTZaY3F2WDQv?= =?utf-8?B?YXp6SGNTTExRWVErZGUyRTdmMmJvcmRrUWhEc0FkbC92Q3hrdEtyOEhxcFVM?= =?utf-8?B?SnZ3MGVwSFN5cWtCRjlLYXFJNlpiYnorblVxTmhrT2RoOUJBTGZ0ZWRFSi8z?= =?utf-8?B?aWV0RGk1dVpaQi9KcC9NV1hZczBTSk9lRExJbWYvVnJvNXVwZzBxVUlhQkc3?= =?utf-8?B?WXBNbG9veWkvczFFZkVHL0NTdmpTLzUzdGx1cXp2ck1UMys2MlRJZW81NTNO?= =?utf-8?B?bDcxaHpWWDF3WDIwRVROUGtlYkoranFRY0Jxb0JFSGV3MGdoQmQ5alJrOGd4?= =?utf-8?B?dGxnTk1TcHBvSWt4Vk5GVmc4bld2ZnZMclpUQlQ3QVJvRGRVSXBpaTd0d2Jy?= =?utf-8?B?enc0aUxrd3FCNi8xcUtmTWQ0a28rUzB3K0hEZUowelhINk5pUGxCMnU2UE4r?= =?utf-8?B?VFMxaUJhUmZEM1FEUkxIUTNyZmo4NVFoYWJhZGlxdSsvTGhMT2JLeWVIYnRm?= =?utf-8?B?SzlpMndObW41STU1aXJIUGdRTlVMOXgweUZqVHVqSFRIeHoxNUNDaUc3amNn?= =?utf-8?B?NWtJSmliZVR3bUFnYkhrNkVjdUNSb1dtV0drY1pJL2hLU1pheFJQRVpZQnVu?= =?utf-8?B?YXpPYXBtWURHU2tTTSt2L1lBZiswNVRDQmYyUWVoYWtHUWE1bE9mMlRvN3JM?= =?utf-8?B?T09xaUQ2ZU9VZjJRcU8wVGZDWTNqS3ZZZzRJQWMrdkFsM0VMeFdsMmdDT0lj?= =?utf-8?B?VDhzek5NcmFNcUtKK0dMWkJ0eWt0cnROWUZoN2ZhY3dObTRyRnRZQVVsdWlP?= =?utf-8?B?UjFZd1h1NStPMFgrcWo4MytRaVpJcCsvaTMyaGFHRmRuOHB2VEg0eGNkVVFs?= =?utf-8?B?VHNBMTJUTlU5NzFza2dJUlp6c0paSC9tMmYwR21sbWdNeUpJR2ZaMXBpRCt3?= =?utf-8?B?Z29BZ0tocThLR1lJSno5bkU5aGl0ZEx6eDB6MmpTVzA1UnFlUG1FQ2pUNi93?= =?utf-8?B?eCs3Z2pMQklKR1NSQnJ1elhEaWMwUkFRc2VkamNsWnZTV0VzUW93dGRySFlN?= =?utf-8?B?bld6a2txOHhOWnlKQXJSSXNZeU9SN0JIMVI1cVlaRE5BOVN2bjI3RnA2dHNy?= =?utf-8?B?QlVPK0ZQQUEwUW9JL2daM3h3eExsNXlxSGo5eUNabUJwUDNXRkNPY3V5Zitp?= =?utf-8?B?WUMzdzlSUXNvc3hQMnhqa2dPb2IydmNUSWl6dXhEeHBBRngyVkxGdFhXTS9z?= =?utf-8?B?YVdUY3ZUaEpONE5BN0lzTSt6aFo5bFBRUDc1WVdUdDRZV2IrZDFENzA5bmY3?= =?utf-8?B?ZHBoT3l5Z0VySW9jODhsbDFqaUdzdEpZRU5RZDVqWUhpamNNUjBKMk9rNFVE?= =?utf-8?B?LzlmNW0zaVVEYlIrRlNld3Vwd0NuOWx1SDdvcTBwaFRzc2J5d0RLZEdjTk1i?= =?utf-8?B?N245dDZyUGNINmtybGtsQUt0VXFUdzc2dUg0WmdRbUpwSCtjRHpKRmtIbkFl?= =?utf-8?B?cHIvSlIyQjNBZWhNWCs2MDF2QWVibDhTU1RyeitOU2oxTXNLS2JMSzlVVjA3?= =?utf-8?B?WVBYMEdLVU5LY0F6OHZVY2hNcTROWEx3Q21HUmcxVHBaUnRUVVdXTTlQNWNS?= =?utf-8?B?Z01BcWhKanFhVjl4TmMzdDd4eGQyWG52ckRNWm9qR2ZkVjdDeXhVaEtVVXp1?= =?utf-8?B?YUZnVG9ETHdxcVByYUN5K3FVeWFMOGpidmFGaXhESVhwbjhtRXVhQXQ0MkMv?= =?utf-8?B?aXBnTTRmSk12UzA0VnZQdTQ2V1dDb08zZU45YmRna3pVN1lZWUhEYkhwVEhh?= =?utf-8?B?NGhmUllNTDR1UkZSNUl6QnB4L3VLZkZSSEIvZFUvZWdaQ0cyVThpNmdHb2hk?= =?utf-8?B?SHB0RkgvbCtkaGJsd2d3NncybG96eFgvM3k2OHlnNmV6cFJvbko2RDNsV1VT?= =?utf-8?B?YVM0bExsWGVaelhoeHh4ckZxQUs5OXVBb2p1ZVpnWWhpelZIVWpiYW01QVVZ?= =?utf-8?B?c240emxqYkFzdUMwS3VBL3JaTTRlWkJCaW9mOEdsN21WY1lrcWxYUFUweDBr?= =?utf-8?B?ckxZalJFazlmck53T21saEx0cXhWUHJnNUJ0WjV5Q2NyRFJjR3IyRHQvSWpo?= =?utf-8?B?NmhrS2cwV1NBTVFsOXdtdFF2RTNzYjVHdGM1S2R4VlBha2FYd2lPcUZTNElZ?= =?utf-8?B?eXBuTC81aXQ2ZFNvMzdMS0hObXFBPT0=?= Content-Type: text/plain; charset="utf-8" Content-ID: <506250EC111C4841B7E3F1F545027EDF@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d6c4709c-75e1-4ccb-c097-08d9fb92ea89 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Mar 2022 14:51:06.7079 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: /0kAaBOdjgkPpkgb8zk9WCPGVmWKrV2GDhReK4xhWpCLB9mmmcF0P+zYJCtSqTPQuGGPmyfpb9ivQT9AIChn5qndvJ5NXgN6tOvvOzAiaBk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR03MB6022 X-OriginatorOrg: citrix.com T24gMDEvMDMvMjAyMiAxMTo1OSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDE0LjAyLjIwMjIg MTM6NTYsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBAQCAtMzMwLDYgKzMzMyw0MSBAQCBzdGF0 aWMgdm9pZCBpbml0X29yX2xpdmVwYXRjaCBfYXBwbHlfYWx0ZXJuYXRpdmVzKHN0cnVjdCBhbHRf aW5zdHIgKnN0YXJ0LA0KPj4gICAgICAgICAgYWRkX25vcHMoYnVmICsgYS0+cmVwbF9sZW4sIHRv dGFsX2xlbiAtIGEtPnJlcGxfbGVuKTsNCj4+ICAgICAgICAgIHRleHRfcG9rZShvcmlnLCBidWYs IHRvdGFsX2xlbik7DQo+PiAgICAgIH0NCj4+ICsNCj4+ICsgICAgLyoNCj4+ICsgICAgICogQ2xv YmJlciBlbmRicjY0IGluc3RydWN0aW9ucyBub3cgdGhhdCBhbHRjYWxsIGhhcyBmaW5pc2hlZCBv cHRpbWlzaW5nDQo+PiArICAgICAqIGFsbCBpbmRpcmVjdCBicmFuY2hlcyB0byBkaXJlY3Qgb25l cy4NCj4+ICsgICAgICovDQo+PiArICAgIGlmICggZm9yY2UgJiYgY3B1X2hhc194ZW5faWJ0ICkN Cj4gQnR3LCB0aGlzIGlzIG5vdyBhbHNvIGVudGVyZWQgd2hlbiB0aGUgZnVuY3Rpb24gaXMgY2Fs bGVkIGZyb20NCj4gYXBwbHlfYWx0ZXJuYXRpdmVzKCkgKGkuZS4gd2hlbiBsaXZlcGF0Y2hpbmcp LCBidXQgLi4uDQo+DQo+PiArICAgIHsNCj4+ICsgICAgICAgIHZvaWQgKmNvbnN0ICp2YWw7DQo+ PiArICAgICAgICB1bnNpZ25lZCBpbnQgY2xvYmJlcmVkID0gMDsNCj4+ICsNCj4+ICsgICAgICAg IC8qDQo+PiArICAgICAgICAgKiBUaGlzIGlzIHNvbWUgbWlub3Igc3RydWN0dXJlIChhYil1c2Uu ICBXZSB3YWxrIHRoZSBlbnRpcmUgY29udGVudHMNCj4+ICsgICAgICAgICAqIG9mIC5pbml0Lnty byx9ZGF0YS5jZl9jbG9iYmVyIGFzIGlmIGl0IHdlcmUgYW4gYXJyYXkgb2YgcG9pbnRlcnMuDQo+ PiArICAgICAgICAgKg0KPj4gKyAgICAgICAgICogSWYgdGhlIHBvaW50ZXIgcG9pbnRzIGludG8g LnRleHQsIGFuZCBhdCBhbiBlbmRicjY0IGluc3RydWN0aW9uLA0KPj4gKyAgICAgICAgICogbm9w IG91dCB0aGUgZW5kYnI2NC4gIFRoaXMgY2F1c2VzIHRoZSBwb2ludGVyIHRvIG5vIGxvbmdlciBi ZSBhDQo+PiArICAgICAgICAgKiBsZWdhbCBpbmRpcmVjdCBicmFuY2ggdGFyZ2V0IHVuZGVyIENF VC1JQlQuICBUaGlzIGlzIGENCj4+ICsgICAgICAgICAqIGRlZmVuY2UtaW4tZGVwdGggbWVhc3Vy ZSwgdG8gcmVkdWNlIHRoZSBvcHRpb25zIGF2YWlsYWJsZSB0byBhbg0KPj4gKyAgICAgICAgICog YWR2ZXJzYXJ5IHdobyBoYXMgbWFuYWdlZCB0byBoaWphY2sgYSBmdW5jdGlvbiBwb2ludGVyLg0K Pj4gKyAgICAgICAgICovDQo+PiArICAgICAgICBmb3IgKCB2YWwgPSBfX2luaXRkYXRhX2NmX2Ns b2JiZXJfc3RhcnQ7DQo+PiArICAgICAgICAgICAgICB2YWwgPCBfX2luaXRkYXRhX2NmX2Nsb2Ji ZXJfZW5kOw0KPiAuLi4gdGhpcyBiZWluZyBtYWluIGJpbmFyeSBib3VuZGFyaWVzLCBubyBhY3Rp b24gd291bGQgYmUgdGFrZW4gb24NCj4gdGhlIGxpdmVwYXRjaCBiaW5hcnkuIEhlbmNlIChhbHNv IGR1ZSB0byBoYXZpbmcgYmVlbiBoZXJlIGJlZm9yZQ0KPiBkdXJpbmcgYm9vdCksIGFsbCB0aGF0 IEkgdW5kZXJzdGFuZCB3aWxsIGhhcHBlbiAuLi4NCj4NCj4+ICsgICAgICAgICAgICAgIHZhbCsr ICkNCj4+ICsgICAgICAgIHsNCj4+ICsgICAgICAgICAgICB2b2lkICpwdHIgPSAqdmFsOw0KPj4g Kw0KPj4gKyAgICAgICAgICAgIGlmICggIWlzX2tlcm5lbF90ZXh0KHB0cikgfHwgIWlzX2VuZGJy NjQocHRyKSApDQo+PiArICAgICAgICAgICAgICAgIGNvbnRpbnVlOw0KPj4gKw0KPj4gKyAgICAg ICAgICAgIGFkZF9ub3BzKHB0ciwgNCk7DQo+PiArICAgICAgICAgICAgY2xvYmJlcmVkKys7DQo+ PiArICAgICAgICB9DQo+PiArDQo+PiArICAgICAgICBwcmludGsoImFsdGNhbGw6IE9wdGltaXNl ZCBhd2F5ICV1IGVuZGJyNjQgaW5zdHJ1Y3Rpb25zXG4iLCBjbG9iYmVyZWQpOw0KPiAuLi4gdGhh dCB0aGlzIG1lc3NhZ2UgYmUgbG9nZ2VkIG9uY2UgcGVyIHBhdGNoIGxvYWQgKHdpdGggYSBudW1i ZXINCj4gb2YgMCkuIEkgdGhpbmsgdGhlIGVuY2xvc2luZyBpZigpIHdhbnRzIHRvIGJlIGFtZW5k ZWQgYnkNCj4gIiYmIHN5c3RlbV9zdGF0ZSA8IFNZU19TVEFURV9hY3RpdmUiLiBJZiB5b3UgYWdy ZWUsIEkgY2FuIGVhc2lseQ0KPiBtYWtlIGEgcGF0Y2guDQoNCkhtbS7CoCBUaGVyZSBhcmUgb3Ro ZXIgbGl2ZXBhdGNoaW5nIGZpeGVzIGdvaW5nIG9uLCBidXQgdGhleSdyZSBzdGFydGluZw0Kd2l0 aCBmaXhpbmcgdGhlIGJ1aWxkIHN5c3RlbSBicmVha2FnZS7CoCAoVGhlIG1ham9yIGxpdmVwYXRj aGluZyBmaXggaXMNCnRvIGFkanVzdCBob3cgd2UgcGF0Y2ggYW4gb2xkIGZ1bmN0aW9uIHRoYXQg aGFzIGFuIEVOREJSNjQgYXQgdGhlIHN0YXJ0LikNCg0KVGhhdCBzYWlkLCBhIGxpdmVwYXRjaCBu ZWVkcyB0byBjb250YWluIGEgc2VjdGlvbiBlcXVpdmFsZW50IHRvDQpfX2luaXRkYXRhX2NmX2Ns b2JiZXIsIHRvIGJlIHByb2Nlc3NlZCBkdXJpbmcgbG9hZCwgZGVwZW5kZW50IG9uDQpjcHVfaGFz X3hlbl9pYnQuDQoNClBlcmhhcHMgdGhlIGJlc3Qgb3B0aW9uIGlzIHRvIGJyZWFrIHRoZSBjbG9i YmVyIG91dCBpbnRvIGEgaGVscGVyIHRoYXQNCnRha2VzIGEgc3RhcnQvZW5kIHBhaXIgYW5kIHJl dHVybnMgdGhlIG51bWJlciBjbG9iYmVyZWQuwqAgVGhhdCB3YXksIGl0DQpjYW4gYmUgcmV1c2Vk IGJ5IHRoZSBsaXZlcGF0Y2ggbG9naWMsIGFuZCBpbmRlcGVuZGVudGx5IG9mIHRoaXMgcHJpbnRr KCkuDQoNCn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Tue Mar 01 14:54:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 14:54:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281614.480018 (Exim 4.92) (envelope-from ) id 1nP3tu-0007YJ-Jy; Tue, 01 Mar 2022 14:54:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281614.480018; Tue, 01 Mar 2022 14:54:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP3tu-0007YC-Gj; Tue, 01 Mar 2022 14:54:54 +0000 Received: by outflank-mailman (input) for mailman id 281614; Tue, 01 Mar 2022 14:54:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP3tt-0007Y6-RA for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 14:54:53 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8cdf0156-996f-11ec-8539-5f4723681683; Tue, 01 Mar 2022 15:54:52 +0100 (CET) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04lp2056.outbound.protection.outlook.com [104.47.13.56]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-33-iUytBLa9P8e6U2MhzJ2smQ-1; Tue, 01 Mar 2022 15:54:51 +0100 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by PA4PR04MB8064.eurprd04.prod.outlook.com (2603:10a6:102:cf::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.25; Tue, 1 Mar 2022 14:54:49 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.027; Tue, 1 Mar 2022 14:54:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8cdf0156-996f-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1646146492; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JSzYXa+uvXP7Qbjc888Jb9bpDn0cbEJLg9c5rCWs+Xk=; b=Ml3b1ZKgvpEgZrVd05CowdUW6Cdz31MUORyT8b+JtMf4r7VVqsC2znh0Bgoeet77cdl/EF fklFJ0obAcnibaMuRH69P/RsgMlYH93EvXQ5adoRscJ0/AOiKFMD5Q15Wf4Y9zdo0nG6V7 oxwLOYp0tGjuHJ2hgknA5b5JdQ9kaek= X-MC-Unique: iUytBLa9P8e6U2MhzJ2smQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=chHom2qJAfCnO6VF5aT4EeqIgMOvUTCsQSgKmLA8EVw9OEMpNhmw/gGFAAx8JkW0BxrGtVn5KyXNyO74Lk4bFiTI9M73C2aFDa8Sqw0kPLB7i+iUTltvVtUNR8iwmqD6RBSkbqNzSnP8mItRSI2audaMJHvZEhe0JFezdaHlji+uYQyUijIFZaQl5jUdrPxCFT7GpcKw7irOyNZfUl+urkUe4SKIW8EYAK7QzP/bu3V52D2WPRyvT1lCKYaAAuQICwo8frSfassFq/ecw35bz5vlTkP9oYap3ccwzSnKl2gOK0wvC9CkOqv7D+4zJrcVv13sK4+wxaDmzBNvGUP30w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ijX2WpQj7tEuuyqNL6tA3cFiHwcdr+MngAW3Zh1Lo6s=; b=Ctb1JVmH062s3GGxyFe9/C8jA5EdSF4S3neFzar6AuV3ac1WDcNgZLdrQE1FfDCahBlyqUAsVepa5C/r+zv8CSt+EzPwyOsaujjTNt5x/WhFS0FrUUkwoicOpTzcs7t/q4fow+o2iSA8Adv6Va/g5pBsCqgX1s97E3EKvjq+dN9l3gbyhfQZLXpe6HG23iCH0WImh2+GYiAVTdLYkgKjdF3OSQ48ceWimwgnmjHPBGNGguNeTn1M46M1+CvQU31xxg6tYyWeVgTDHIT/QE+kSYRln9N7qpTTd1AcWmgeSXsZrXu82u9DS/2f+dbZ9XxgjTeyeKh+opxBn1+5T/E5lw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <6ee69f56-e37b-ee00-5705-231f8f300f5a@suse.com> Date: Tue, 1 Mar 2022 15:54:47 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH] x86/altcall: silence undue warning Content-Language: en-US To: Andrew Cooper CC: Wei Liu , Roger Pau Monne , "xen-devel@lists.xenproject.org" References: <0e3594ff-c637-46f2-bc95-7a26b5471b86@suse.com> <40306bc7-f61c-d330-0ec7-d986e4711d88@citrix.com> <06452eab-653b-458a-048b-cc709151353a@suse.com> <6f005e15-eb81-c41c-7296-4929e85eae21@citrix.com> From: Jan Beulich In-Reply-To: <6f005e15-eb81-c41c-7296-4929e85eae21@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS9PR06CA0100.eurprd06.prod.outlook.com (2603:10a6:20b:465::11) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7220b249-7756-47fd-ea1f-08d9fb936f5f X-MS-TrafficTypeDiagnostic: PA4PR04MB8064:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 642Vybm1g+WHoGd9jBjGksl0vec9z/rKnRpclnBWnoAC140kfN6aQnBEldR+CiFR123EqgzmHQrFEgaz0bRP8VYEGWzNAT7SRyP8j5Jv6EvvuSktFp7dxL6fpSot59RaVyKYLYrdlhgWIGLaWuhHV07j9EHOemHhpmuimvU3qB1iexcMMOW09red/YB5XuACEWQvVU+57+pHAnD52dXXwOB/C4FovxAjp1FsHA12vjYgL02nnJ6wh8NJsfYxwHkfwH7fKPfibfVQVoHak0cta058emgfvXsZJuMpT8nXtRSftbfpihM/Rs28wDaIZO8vI/VobHM0REKq1R3zIDI0aN9T+wbPqBojFjld3nhRq5vj4vAdJm86k8SkpX/shdLKxiDej6yOQqdf7hNzOwfXixIb8izPRvsqbr+TQPo4lG9H/sVth65nbWaeTrK2A5ikA1hHrbPDfGcAi13d8A39caiEHiKscNfKUuTxLQ2b5bHRtMTywSYS+y2fO2d+TaSVd78P7gHP0szSbcqxEZW401zuO1XYB60hM/BH7M9cA5d2z5gKuC5oxM/Ld+wWO0tEORB1hvlqvbbxwFZcKKbYOJh40QppHVLP51QEoaNu11Apcu8w/0u791FyD9YocK7fvCM1Wu+54+mg06goLsoxQs4USQL9fPuyzNWLJsn8JHK6MoWyTzTaSYPE33H9DokxDx1tqLJQS4cWp4TovDXhp4xddv2PYNivLwWmynOfA7OsX7D2CGMH2vf/Le9BRJg8 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6512007)(53546011)(66476007)(66946007)(316002)(6506007)(66556008)(4326008)(2616005)(508600001)(8676002)(83380400001)(36756003)(86362001)(26005)(186003)(31686004)(6486002)(54906003)(6916009)(5660300002)(8936002)(2906002)(38100700002)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7U7c98db4FZRy1M5qtW453tXCxoy64nP7JlGrQ/Osq24hIGeXdatTilf8oyk?= =?us-ascii?Q?/bdD0Q5rVnf/Pk8G/n8C1DDcRKdcpzM1/8JHm9H0Zqr11QPBwhk3GYV/955c?= =?us-ascii?Q?WUN2RDrMSW5DeZ33RddbmghsQCtq6mWMjnH2mKsNFHoh8+4DGtLDdgAqmF4V?= =?us-ascii?Q?f7lrg9xnryX4sjzxlbVk/1bPPaXwnSsRpLpqJZvEQAKQrrzNtFpGbIQJq3Gb?= =?us-ascii?Q?AWCML4h3RQXwoInPa+dDeYVclgGiflQyEJht8hBBfPJwzWkJVvX9IOKnmOcC?= =?us-ascii?Q?tGwwEdLtaTilYMxXTNiE2dBQ3J34T9Lr+kXgjrJLI2bz7eOYwZeWBxCi+Zki?= =?us-ascii?Q?tFJuncWTQgWkaj9wY7IiWH/ji1XZKLXqyd0pCE/ADaftU3J/vy8QEGCtINlc?= =?us-ascii?Q?lbvE9XFi4VniNfzTZjTkMWnlQdXsr1CkVLk6FWXhQ0DPJ5ayusiZ85QLnW3u?= =?us-ascii?Q?VbCnkUKC+4zNmBIsxBSePMfQHtgggsA2K8tF8nrt/gMwCGvRu1dVNTups2Dr?= =?us-ascii?Q?eMdzZItUvPOVIKe+v6cTsZDzzpFiNCFGRe477xipBFuwu7dZ8SoXhg9FMatD?= =?us-ascii?Q?BQKDhe4B1Hlb/+5KwzyN7pLtlUu1IoDjm5hW7NlR7Fy6fLfr71GWkn8zTzTt?= =?us-ascii?Q?aDKLpyhR7y23E+Ck1ycRT6BkBiDStU8JqS5mbnDvyrUCWeUcB0HOwnDRLAiG?= =?us-ascii?Q?rdjRviQpw83AavThYqXzJAKCdcHmtcWdUl6mg+8/8BKP6AF5qgRZ0e+acDAJ?= =?us-ascii?Q?O/dwlR9lLA1ru8DTbN/Ix1pkQ/pBgCR8L+96maEB3xhVw2fmxF2qyRwoNIvJ?= =?us-ascii?Q?luhb9EOWOOiOVE0BbVD9x5mCgg7SdbDSoqNKjilukoWtZ7CVYHdrB2ezYGcs?= =?us-ascii?Q?yMm2JFYvs0CeUWa9mH51HqYjOrPACONk1wynMoueVnSuf1eqLMAAHNU2igtH?= =?us-ascii?Q?2vBdkXAfR8xCRbhWnkp3Zv109acK6tUpWoc0ulwZBHqGutzD6Xsh1pKi6xcr?= =?us-ascii?Q?IMli8y3kwqHVk9x8bX6HWH8U7OvJx6ThbCBJcCAcnLylP0uBaFvU1wfn00Ec?= =?us-ascii?Q?q2Vv6XI/BBubDZFntj61F2sW4YXxIXZNQHogP9Ylx1TW522RAO1G7FYPv7fE?= =?us-ascii?Q?ls0yvMUTjk595Jls9PeZLBGDUeWtUJbtsBAUPLDyvZwIzQBKhjMXxIPMlj4E?= =?us-ascii?Q?SZ6tuecDFzmEjT3+hknTwSZUDMMWCt7BddrcBVcqIcQAkDORMkZRf9F0rhAa?= =?us-ascii?Q?W9DJWVtwfOOZcXgdxPOIrcgynarIetlK/d07BfjJUeCCO6WeihmjpoV8tC/K?= =?us-ascii?Q?Hoi2s27HINzsuigws193L4D/Ox9IF6IE+j+W5zezfJN2ggdbwCLY59TyrHEO?= =?us-ascii?Q?SPKGgkNxig/CBsPg8GMXxDLYG6gdhrck6ICk25ZKYBlz4B/W9FpYjHkKbi9c?= =?us-ascii?Q?Mt6ep7P5+3do0eQVqxiRGaWLc8Ufl36B58cJm/OCrOVJbK/fzV2tNcGQOO7X?= =?us-ascii?Q?d3u7mkWBJwn/RkHIYygeNdFDAcfhjmjQ3HRgPqR+2+b7Fh7XapFF/A6FB2Y6?= =?us-ascii?Q?Qimaycldt8jnDwTSwcpRPXZkyOs/EunBrE7H3Hcd6RvrzHDKiQavImizOt2s?= =?us-ascii?Q?GoN1wYqbG/MfdM0DweNHOJA=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7220b249-7756-47fd-ea1f-08d9fb936f5f X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2022 14:54:49.8363 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KBcrWwbk3FOmmvMw4F16HLh8pWci165ACsXkqIwOt5cA93LUEjk7i+jfSmwY9wPHYNr3ykN2fQqY2hH1Qax4Ww== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB8064 On 01.03.2022 15:23, Andrew Cooper wrote: > On 01/03/2022 13:34, Jan Beulich wrote: >> On 01.03.2022 13:48, Andrew Cooper wrote: >>> On 01/03/2022 11:36, Jan Beulich wrote: >>>> Suitable compiler options are passed only when the actual feature >>>> (XEN_IBT) is enabled, not when merely the compiler capability was foun= d >>>> to be available. >>>> >>>> Fixes: 12e3410e071e ("x86/altcall: Check and optimise altcall targets"= ) >>>> Signed-off-by: Jan Beulich >>> Hmm yes.=C2=A0 This is fallout from separating CONFIG_HAS_CC_CET_IBT an= d >>> CONFIG_XEN_IBT. >>> >>> Reviewed-by: Andrew Cooper >> Thanks. >> >>>> --- >>>> Furthermore, is "Optimised away ..." really appropriate in what >>>> 37ed5da851b8 ("x86/altcall: Optimise away endbr64 instruction where >>>> possible") added? If this really was an optimization (rather than >>>> hardening), shouldn't we purge ENDBR also when !cpu_has_xen_ibt, and >>>> then ideally all of them? Whereas if this is mainly about hardening, >>>> wouldn't the message better say "Purged" or "Clobbered"? >>> I did have an RFC about this.=C2=A0 Turning ENDBR into NOP4 matters, on= a >>> CET-IBT-active system, to restrict the available options an attacker ha= s >>> when they have already managed to hijack a function pointer (i.e. >>> already got a partial write gadget). >>> >>> From that point of view, it is hardening. >> But then you don't say whether there's any optimization aspect here. >> My question was really about the wording of that log message. >=20 > The optimisation aspect is direct branch target +4, because that is what > saves on decode bandwidth. But that's the other, entirely independent ENDBR-related piece of code in the function. All we do in the loop ahead of emitting the message here is "add_nops(ptr, ENDBR64_LEN)". There's no counting at all of how many times we advance a call target by 4. Jan From xen-devel-bounces@lists.xenproject.org Tue Mar 01 14:57:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 14:57:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281623.480036 (Exim 4.92) (envelope-from ) id 1nP3w5-0008NR-4J; Tue, 01 Mar 2022 14:57:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281623.480036; Tue, 01 Mar 2022 14:57:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP3w5-0008NK-0P; Tue, 01 Mar 2022 14:57:09 +0000 Received: by outflank-mailman (input) for mailman id 281623; Tue, 01 Mar 2022 14:57:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP3w3-0008My-4O for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 14:57:07 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0627.outbound.protection.outlook.com [2a01:111:f400:fe0e::627]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id dbe10499-996f-11ec-8eba-a37418f5ba1a; Tue, 01 Mar 2022 15:57:05 +0100 (CET) Received: from AM6PR04CA0022.eurprd04.prod.outlook.com (2603:10a6:20b:92::35) by VE1PR08MB5615.eurprd08.prod.outlook.com (2603:10a6:800:1b3::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Tue, 1 Mar 2022 14:57:02 +0000 Received: from VE1EUR03FT043.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:92:cafe::8) by AM6PR04CA0022.outlook.office365.com (2603:10a6:20b:92::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.13 via Frontend Transport; Tue, 1 Mar 2022 14:57:02 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT043.mail.protection.outlook.com (10.152.19.122) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22 via Frontend Transport; Tue, 1 Mar 2022 14:57:02 +0000 Received: ("Tessian outbound 826a6d8e58c3:v113"); Tue, 01 Mar 2022 14:57:01 +0000 Received: from 2123dd14850d.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id CCA1B9B7-9360-4DD4-8B39-FD90FAD0D9AA.1; Tue, 01 Mar 2022 14:56:55 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 2123dd14850d.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 01 Mar 2022 14:56:55 +0000 Received: from AM0PR08MB3778.eurprd08.prod.outlook.com (2603:10a6:208:104::24) by HE1PR0801MB1675.eurprd08.prod.outlook.com (2603:10a6:3:87::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.26; Tue, 1 Mar 2022 14:56:52 +0000 Received: from AM0PR08MB3778.eurprd08.prod.outlook.com ([fe80::4dbb:4fed:bc86:1803]) by AM0PR08MB3778.eurprd08.prod.outlook.com ([fe80::4dbb:4fed:bc86:1803%6]) with mapi id 15.20.5017.027; Tue, 1 Mar 2022 14:56:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dbe10499-996f-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WMo1hLmk0qH/EB55HU7/OnIZLjY9f/TCFdkVU0IOvuU=; b=twf5ZRYA5mDhOu+ycKsmocpAf6+/wEhTlTS8QCppKFYLDnhVYABPoGdwkcc7ik1l5Z7qwJeN5bll08b09hhOaElbTKslKMJ/d37Gnl5IJvW/b17gU9cZcB5S0FxQrHM6TKeurZMfKIE1tpAqx7eC0KRB/qSrmPNgRjQ19u0S8qw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: ac41b1ebd037f7db X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dwZ8ToyfGnaSkHm+Ya4iI5RNUMkode7abK0XCsk+RnujlwBVsJ/B8fxMP2eH3Smr3SmVkrEhYxjA4GK9PISGC3yHWTUXoF0HsJlJ/SbicIT5zX33+1hXKtSNmQZ9UdoxDw7dZGPrNmfr9WR5tGqTmPjOTccWWGODc3hpwSnLMCn/bTIYEo4Y0W4ITvQZddXT2XoJowOxfKM5y6ugpvzMkWjTd3alHDaFOEoifLN+LMWApIsFaCwC7harSOXfxYMB9YPYlCYiPMdpfo3shit22Iqp7M/2B5NTdVnedELZ6G8bYgreNQ/8JhPzgoXsbj+D181y2mq42AkPv4z1ajjTqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WMo1hLmk0qH/EB55HU7/OnIZLjY9f/TCFdkVU0IOvuU=; b=f6c4cWZ7kxk3mouMoNBvNzMGgtpQn4+zrmqDa+sUYSF2PS01GpMdijtX9BvkqGAESDnxo75SVmPsMvrcEB/OJz01PY6O/qQuryya36syQy5TIV4GbvoVRzWqNJ8xVOFMYgNbE6N+VR26joadrCKJAllz+8u7L8mhTwHf/9yoi14nJ6bP2i9v+jSAUztqzaM/C30epm8oJL7DJJTdCYlEc7Pjr7122T/roOYn9nbFnUahcUrIZRtJ2AjIHZgGd26AgoSo4uNJjAWb+3KhN0wK5UhFcSgsBiYi2diqh/FHIkpofx0proXf7LklYHP9poq3R1f7o5JpN5HOcD6lSQSo1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WMo1hLmk0qH/EB55HU7/OnIZLjY9f/TCFdkVU0IOvuU=; b=twf5ZRYA5mDhOu+ycKsmocpAf6+/wEhTlTS8QCppKFYLDnhVYABPoGdwkcc7ik1l5Z7qwJeN5bll08b09hhOaElbTKslKMJ/d37Gnl5IJvW/b17gU9cZcB5S0FxQrHM6TKeurZMfKIE1tpAqx7eC0KRB/qSrmPNgRjQ19u0S8qw= From: Bertrand Marquis To: Julien Grall CC: "xen-devel@lists.xenproject.org" , Julien Grall , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH] xen/arm64: head: Mark the end of subroutines with ENDPROC (take two) Thread-Topic: [PATCH] xen/arm64: head: Mark the end of subroutines with ENDPROC (take two) Thread-Index: AQHYLIsbZnt9ucibr0G+vW8JMwB0sqyqoBUA Date: Tue, 1 Mar 2022 14:56:52 +0000 Message-ID: References: <20220228100805.60918-1-julien@xen.org> In-Reply-To: <20220228100805.60918-1-julien@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3693.60.0.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 6dfd0050-63a5-46a5-12ba-08d9fb93be5c x-ms-traffictypediagnostic: HE1PR0801MB1675:EE_|VE1EUR03FT043:EE_|VE1PR08MB5615:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: wrFErsKjH2nHZ2u389m0TauJnuCJCFXNytbHC9mrE+ouzV0jnxxkYLWTvDJ/ctM2G5pEsNRXU+hqffJd+wNLA6VQE2zJHkt92wtYG0BxgozaJ0tXSd6/rPaeyg4tfyw6Ja/eppjR9IH6eovOGi5oQAvg6bkyEseU7aa86+BEIaA2eQHcRo3UfernVatMQjUEe0gG9UzF9WJXc4wBU5eXMMjt7WVV4SeyziYeAthnUZSSUP5r6gG4Zr+jQnhU/4w5dbu81kDzAtGcXew91I+OXKX5+eLM1c+VT8Jb/0i34Bv4OZfoQD0GLokd9C/TxPtFm0RtFhMHysCoAhc65VVyAVH06KUUiDhJFn8yjXguXnbjS/KCaq8TRrhRo6jemWVr0CTF1K2VwgReEJpy2W6ZOm9A197YHKRUo1n+pHLpcl5JqAgPSQhjfJtQJ9eS9YctWGzCLzXup7RlIryHzzX4DC45884Gp48wIkVV7nrmm3O1qV70njvl6M5wiOR3UVf6LNrl1wkx3KjWzZG190Y1dGc+IK2Z9Rh15BraGeVxCR8SRyQld+dE525IUb9EBZDQ8W20SfghaRGUMlOZPZl9nmt135TDFftzaF2MBfxP1IV7Hchz2JVlIXZ/RW4givMIiSladsX9OkrKYzgPqni3C3ESalLuqgjZJUne5LGuISZUsNJZGuERGgs0XgSTCe7K/pOOEF0Zfok/UScUqK+l2Cm8R1aDkYXg9tQAEp5/tV+y/F0iaFsECAE+0Nwn1ufl X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3778.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(71200400001)(6486002)(33656002)(83380400001)(86362001)(508600001)(38070700005)(2616005)(6506007)(54906003)(6916009)(66446008)(53546011)(64756008)(4326008)(66556008)(76116006)(66946007)(8676002)(26005)(186003)(6512007)(91956017)(66476007)(316002)(38100700002)(2906002)(36756003)(122000001)(5660300002)(8936002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <5D097B401A9A204E90868CD84E3D6C82@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1675 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: a357c5c3-f99f-47c6-df27-08d9fb93b8a7 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NtThdvEuh3+5Os6eRpZP0bF5K46wm4aZ8RY/sOaxmkOfLyt9aa0XQj+zws4hzJPI2o4qL9SOKnqHlDTGFX4VgbXZ0ykXDddqWGf/YLfcZKAJ+0xGJqFtouMzgFLYKHmqPEHiho0aBa4w0/Ooi0kLKFP9QpzZVgEp7IzIAOUSIlSIv0DZ2g6Y0GPpbt3KHJyOAqxz0trYvzM4mQFv8+0sJwStu7uvLKmrNzN5Xs/oqZsbzbTggNosDHyEKCADellPzZ612mH2t5xl0TtWFXvCzCyCla6JMkSPxB4YwRq4f1p8g0NYTsh8ahsMo/YeFBpV8lSiMThzsgVrJ4sMp+jOWSdB/N0GYMcs9xr9V6unmf9jy+7IJOtOul6gipJxc4Utv6yuqo0aH9BGYxYMmIK48Tk4qgNhctc8mG9M0rECR4pFWEv1Do25gH53qcjMRngw0LOTuZ8Omi/K1ZPNm+NXzB5eM+SuQJ+nB3WhfaMfqV+WllXSkVTczkKtfw3chZrv+4Xx4LSeqExcJfAMuNEansuNBmqkXkWggDdD8xBIAyM3t6yGhpMc+dGjumTyEh5NBUdpJNDjw5cFxULKoB0fy1HWn+AKnmK5JBRI0qn3KXZ4hcWnnA0R4SXL4TI8b7Equx3DJ0Dg01jybxVV8GfbAlGZqZX9gZmdGf7crUwhJsbT3tFo1zLxyZCjgTDhRLZ3 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(316002)(5660300002)(2616005)(107886003)(6506007)(336012)(8936002)(86362001)(82310400004)(70206006)(70586007)(8676002)(2906002)(26005)(186003)(33656002)(4326008)(36756003)(356005)(81166007)(6486002)(53546011)(508600001)(83380400001)(54906003)(36860700001)(6512007)(47076005)(40460700003)(6862004);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2022 14:57:02.1027 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6dfd0050-63a5-46a5-12ba-08d9fb93be5c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5615 Hi Julien, > On 28 Feb 2022, at 10:08, Julien Grall wrote: >=20 > From: Julien Grall >=20 > Commit 13c03002c5df ("xen/arm64: head: Mark the end of subroutines > with ENDPROC") intended to mark all the subroutines with ENDPROC. >=20 > Unfortunately, I missed fail(), switch_ttbr() and init_uart(). Add > ENDPROC for the benefits of static analysis tools and the reader. >=20 > Signed-off-by: Julien Grall Reviewed-by: Bertrand Marquis Cheers Bertrand > --- > xen/arch/arm/arm64/head.S | 3 +++ > 1 file changed, 3 insertions(+) >=20 > diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S > index 314b800b3f8e..66d862fc8137 100644 > --- a/xen/arch/arm/arm64/head.S > +++ b/xen/arch/arm/arm64/head.S > @@ -800,6 +800,7 @@ ENDPROC(launch) > fail: PRINT("- Boot failed -\r\n") > 1: wfe > b 1b > +ENDPROC(fail) >=20 > GLOBAL(_end_boot) >=20 > @@ -830,6 +831,7 @@ ENTRY(switch_ttbr) > isb >=20 > ret > +ENDPROC(switch_ttbr) >=20 > #ifdef CONFIG_EARLY_PRINTK > /* > @@ -847,6 +849,7 @@ init_uart: > #endif > PRINT("- UART enabled -\r\n") > ret > +ENDPROC(init_uart) >=20 > /* Print early debug messages. > * x0: Nul-terminated string to print. > --=20 > 2.32.0 >=20 From xen-devel-bounces@lists.xenproject.org Tue Mar 01 14:58:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 14:58:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281631.480047 (Exim 4.92) (envelope-from ) id 1nP3wy-0000Yg-HO; Tue, 01 Mar 2022 14:58:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281631.480047; Tue, 01 Mar 2022 14:58:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP3wy-0000YZ-DQ; Tue, 01 Mar 2022 14:58:04 +0000 Received: by outflank-mailman (input) for mailman id 281631; Tue, 01 Mar 2022 14:58:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP3ww-0000Vt-VX for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 14:58:03 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-ve1eur02on061b.outbound.protection.outlook.com [2a01:111:f400:fe06::61b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fddccaf0-996f-11ec-8539-5f4723681683; Tue, 01 Mar 2022 15:58:02 +0100 (CET) Received: from AM6P191CA0079.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:8a::20) by AM0PR08MB3204.eurprd08.prod.outlook.com (2603:10a6:208:5d::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.24; Tue, 1 Mar 2022 14:58:00 +0000 Received: from VE1EUR03FT053.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:8a:cafe::c9) by AM6P191CA0079.outlook.office365.com (2603:10a6:209:8a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.13 via Frontend Transport; Tue, 1 Mar 2022 14:58:00 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT053.mail.protection.outlook.com (10.152.19.198) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22 via Frontend Transport; Tue, 1 Mar 2022 14:58:00 +0000 Received: ("Tessian outbound 63bb5eb69ee8:v113"); Tue, 01 Mar 2022 14:57:59 +0000 Received: from 1297990f98b1.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 969F2B92-8224-46A0-B9FE-990DA1FEE08D.1; Tue, 01 Mar 2022 14:57:54 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 1297990f98b1.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 01 Mar 2022 14:57:54 +0000 Received: from AM0PR08MB3778.eurprd08.prod.outlook.com (2603:10a6:208:104::24) by PAXPR08MB7365.eurprd08.prod.outlook.com (2603:10a6:102:225::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.26; Tue, 1 Mar 2022 14:57:51 +0000 Received: from AM0PR08MB3778.eurprd08.prod.outlook.com ([fe80::4dbb:4fed:bc86:1803]) by AM0PR08MB3778.eurprd08.prod.outlook.com ([fe80::4dbb:4fed:bc86:1803%6]) with mapi id 15.20.5017.027; Tue, 1 Mar 2022 14:57:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fddccaf0-996f-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F0o4CclDFBM/vYkNxNk52Pf4Zvl4PzYaQgACplhV06M=; b=Zzj2ZsxR7weHIcVZF98IIaEyyVwOl2Mu3DBNAeeMci/MRlxXscmd451tNvqPl4LYfocWeshRknhaOX09+oO8u2KAZ3YHyWKHtLImsNuzippgdor7KdgHiZHUcx4DRY+0HRhLfcwdO4QQ5VpAF8MKM/wDxWWVKE4ueHiv2KMT7hA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 2e52b09017e24f9a X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OgLcxz8yjKpe3EYkBQTvATaz/kA3ly6E/hNbIkO50uLrxjhlOutnIG+BDud5H1eD4cCpBMgrKLtcG8g5kgGUuB+LTkQl96FNY0DYL0XTGgEjWKzNrYOf5KgeAvGfVcmfktr3jHFFApjwPQNPO0yfbT4ZldbWB6otRch3YDw7MTW2VVsRbX4qx1gzNSVOElPWfBxdR4n9vdY73W6qwzr6vT3u0TIFCkpnJOQPT5L/DEUDKk32U840Pxm4hMqitdUiFe3ud+9PuRp5t7lGu8Fj/BjUaBjOKsgrHkFlbQ6gIwaRnbwZPzosZbdhD9gRZC9miiQYwPQfZ70mZ69bQ08LnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F0o4CclDFBM/vYkNxNk52Pf4Zvl4PzYaQgACplhV06M=; b=dxkHk8Iw+v00Y75gKIUNUsoaXVzIld7DmMqb7lqTs3Z8nxdn1gNGTbHI8L0HKhSAeRfu/Um/R//jm/f8QYg7HWhVy1fz+eeCJmy6dD5YxDkIWM/B5qqLNq+FWlih5yhjZvoC/E0Dl5mn7shyLK3U6M76HQe1BVCPMhISUYXzox0hFwuPeI90DUtwQvFiGPw8uBWIBR86C5ynBHM629vN39WlIP6DukJ6YKcRDDi17bpfUbkP2iVLwhRo6vMzwmdns0Fiz17MpSCIzhH2Y6hyvB0CAHudMIKJnmcaalOmOQUe+33dXpfLfI+hsSmm25P2SjdprrSFm4bmOXeOy6WStA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F0o4CclDFBM/vYkNxNk52Pf4Zvl4PzYaQgACplhV06M=; b=Zzj2ZsxR7weHIcVZF98IIaEyyVwOl2Mu3DBNAeeMci/MRlxXscmd451tNvqPl4LYfocWeshRknhaOX09+oO8u2KAZ3YHyWKHtLImsNuzippgdor7KdgHiZHUcx4DRY+0HRhLfcwdO4QQ5VpAF8MKM/wDxWWVKE4ueHiv2KMT7hA= From: Bertrand Marquis To: Julien Grall CC: "xen-devel@lists.xenproject.org" , Julien Grall , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH] xen/arm32: head: Mark the end of subroutines with ENDPROC (take two) Thread-Topic: [PATCH] xen/arm32: head: Mark the end of subroutines with ENDPROC (take two) Thread-Index: AQHYLIsQ1/MnnQEZyUi9t6TTCfZIq6yqoFuA Date: Tue, 1 Mar 2022 14:57:51 +0000 Message-ID: <0A2ACFE7-5B4C-41F5-8B3C-AF49FE635487@arm.com> References: <20220228100740.60332-1-julien@xen.org> In-Reply-To: <20220228100740.60332-1-julien@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3693.60.0.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 26747966-9bbe-45b2-d566-08d9fb93e0ee x-ms-traffictypediagnostic: PAXPR08MB7365:EE_|VE1EUR03FT053:EE_|AM0PR08MB3204:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: CJrskTJhHIyNG724fh/o3VJpdjBRePlokmfYanPtqEdD7YBUhJL5U5td6gWcaRp2s3gnNfCHnruuUtof5uXmAtknfQACW/70pilMWuK3/LJ/1MLpAKFU76vyw6dnLE2FgQW9h1ePR4pg4AV3bawm9x0AXV6reqp437js0zHtiA0M0+HVPp9IVWrUtS+Udc+G0fUWxJ5R2QXdxAjaqcC9cBHB0mz7agxmXCtE9Z8D0ysLHFgpsF75Swx4h62WGnH7d88tfyT2EazN9squXeg8ZhUsak/dcemfyBCKDMt9eUlcBurpstXjaNizZLQZteXLB9ieUT24wq1fS6R3gqZ8rXpZhmyXAn1WFvd+T6cTuvFp9g8dYG3OQ3PWMV2CjgV7mvmqQ3FToMFRru75d8gWaRjkCEsZBKsv9J+zfY+f2m9yqWGvzhelFuZ7yYy54uaJg0l4rdRwdBM91QMUKo1KfRETtLUt1RNH9nbtDBFEGVxAil/0fu9UHGh4re8+XbxGtdCJX2eNQdnMxwgViJ20PmTHt8Fe8nMrSWSJhD5rZy6IHTlsyAJkvae4Ctri4I0sOKTQT4DgbA3Ypnp0gjEzsYMWEIM9e87v2pgv9yyuST3SO4R4mkU9dDaYQ8/mxBW0S37is+xh2verJMLFKnq1DwKKfvsTtLjIozuXskN7m5q/pFV8RRvWoaLgC6rFB5tokyGRZ4sG8Ubds/5aitRVrwzGhmJ4VNpaM5cAEnI2JOdqZrS75GV28Ff8ZVNWZKHN X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3778.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(122000001)(4326008)(8936002)(8676002)(5660300002)(38100700002)(6512007)(71200400001)(2906002)(6506007)(38070700005)(6486002)(53546011)(508600001)(36756003)(86362001)(64756008)(6916009)(54906003)(316002)(83380400001)(2616005)(26005)(186003)(66946007)(33656002)(91956017)(66446008)(76116006)(66556008)(66476007)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <67650794060AE844BD958BB54DAA5573@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7365 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT053.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: eb82adbd-c87a-404c-fec7-08d9fb93dbd1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pLkI055e0yZxpSCTZJb5xNG5+lhkmMyV0YgQxXB3uxTNLnhNOcYw9UfBzKjmAgS8IzT5SkojakcmHWehLw9OUSUwrTi67os25qNgdJp1TlAbXLu3UpArpv7b4HxTRxhHduJQmqgzS8Gwejgaf/1uAd5+K3we4RN1A402Xc9EcTkFlUuWRWK7UH+axx381e2G9kHBx0qldgNqM4ZY4AfN7GFQABK24br7i6gHMrSqGjmiY880xxN9hzPDwnwLjO4ocNVFV/nzv7Q1bHkLBcidP4s/LlUzAmAEM6rpL8HA/Q0f/E8i8M3tJ3dftv84G06AJXPILLRP5jcxVQZ/Bol7TmGZPFVLueWqAn7McaWIE7D5tvqfHt3+j5hg2OFoAYKQoLy2qKJ8O4yUTzccVdRl07BF95p3yMober4ohCHoYTnjQIw3XFQYnaP8Et7WfZjAUN232bmm00ajtUQISxRearzE0q5wg7KAD3+iGHMivpsRwsvBzLJYRZgRnfnEvcvyT9b0P3DOKxtc6YjzIz+ruUmp6m01DCwFONErNoaWvBipdx6Pd7fYjL4+1yqlAGqLLKwhqJQsWtTZeq8qrWt0J/W8HQcqzani2OQ26UdXosj7a4Fama3Bksyr9lhqElqolveZ32Y9Ls5g6LN8t9fopwNk9Xc1lk3SdIc2LIiRdsW2YW7YjM8f5q91PL4/bf3j X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(6506007)(6512007)(53546011)(508600001)(6486002)(40460700003)(54906003)(81166007)(356005)(70586007)(70206006)(8676002)(47076005)(83380400001)(82310400004)(26005)(2906002)(107886003)(6862004)(186003)(336012)(4326008)(2616005)(8936002)(33656002)(5660300002)(36860700001)(316002)(86362001)(36756003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2022 14:58:00.0742 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 26747966-9bbe-45b2-d566-08d9fb93e0ee X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT053.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3204 Hi Julien, > On 28 Feb 2022, at 10:07, Julien Grall wrote: >=20 > From: Julien Grall >=20 > Commit 2ac705a59ef5 ("xen/arm32: head: Mark the end of subroutines > with ENDPROC") intended to mark all the subroutines with ENDPROC. >=20 > Unfortunately, I missed fail(), switch_ttbr(), init_uart() and > __lookup_processor_type(). Add ENDPROC for the benefits of > static analysis tools and the reader. >=20 > Signed-off-by: Julien Grall Reviewed-by: Bertrand Marquis Cheers Bertrand > --- > xen/arch/arm/arm32/head.S | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/arm32/head.S > index b1d209ea2842..13cfc837d39c 100644 > --- a/xen/arch/arm/arm32/head.S > +++ b/xen/arch/arm/arm32/head.S > @@ -661,6 +661,7 @@ ENDPROC(launch) > fail: PRINT("- Boot failed -\r\n") > 1: wfe > b 1b > +ENDPROC(fail) >=20 > GLOBAL(_end_boot) >=20 > @@ -694,6 +695,7 @@ ENTRY(switch_ttbr) > isb >=20 > mov pc, lr > +ENDPROC(switch_ttbr) >=20 > #ifdef CONFIG_EARLY_PRINTK > /* > @@ -711,6 +713,7 @@ init_uart: > #endif > PRINT("- UART enabled -\r\n") > mov pc, lr > +ENDPROC(init_uart) >=20 > /* > * Print early debug messages. > @@ -798,6 +801,7 @@ __lookup_processor_type: > mov r1, #0 > 2: > mov pc, lr > +ENDPROC(__lookup_processor_type) >=20 > /* > * Local variables: > --=20 > 2.32.0 >=20 From xen-devel-bounces@lists.xenproject.org Tue Mar 01 14:58:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 14:58:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281632.480058 (Exim 4.92) (envelope-from ) id 1nP3x4-0000sP-PK; Tue, 01 Mar 2022 14:58:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281632.480058; Tue, 01 Mar 2022 14:58:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP3x4-0000sI-ME; Tue, 01 Mar 2022 14:58:10 +0000 Received: by outflank-mailman (input) for mailman id 281632; Tue, 01 Mar 2022 14:58:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP3x3-0000rR-D1 for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 14:58:09 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0159fdd0-9970-11ec-8eba-a37418f5ba1a; Tue, 01 Mar 2022 15:58:08 +0100 (CET) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05lp2105.outbound.protection.outlook.com [104.47.17.105]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-7-Ef4FgCsSNMCwDjXCLyMM1A-1; Tue, 01 Mar 2022 15:58:07 +0100 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR0401MB2431.eurprd04.prod.outlook.com (2603:10a6:800:2a::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.25; Tue, 1 Mar 2022 14:58:04 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.027; Tue, 1 Mar 2022 14:58:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0159fdd0-9970-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1646146687; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ztmfq5fITsOk3cRhkKnyEXijrKpo+rZWlcUJd0hVKZw=; b=U0Zc5qzxhgWMd+/zhR3cvI72kQbvQKVrxfdFyO0nWna9yKvfaV3iA8vs82J4m+VGQqB1xB eWqB5YDXBH9xpDLFRmW1tgRjCkpDIQej0iMeTbKMxupLK09P9NP5dbYgj9zN8HZXZ176zY t/QDUCunOzS2/oqupQab6CY8RQaZZgA= X-MC-Unique: Ef4FgCsSNMCwDjXCLyMM1A-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YrcMjknU0DDePEJoRvWfkRUV8Gc333BhnZf+xx5uonIqZLuLTRcdZuQqppZXpeU0oPeC3WU2A94Ozihzryij4ioujID4i5InZAedJkUyEstVUBe1ZNP8DFjjSFTedIct3+cN3fd+YCDToXA2PFOyZtbqAz0AdtkJnbgrMWxsWZRNfpf0CxGP8NB2j/xCRrCAHTWv1pu4AZ9wvMmGu8OF03kxbirrE/IA90d6fBNjORO2/ewlbG74DtjFHWB1So5ZS3mitekAO6eKW7//oZ47SVkMUYxzL0M6ZApGZiaOWOI1C1h80brW+cD8lFux/dP4GkT5ru42Azlw/5maGaUX6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=am9EStbXSqHKqU0MT/hvArx+4c4Jvx/vCLeo3n2ngx0=; b=DwUqpbd6okEoR/EjzF0E17B9RKu/Hvx8GDwmVYdxiYqR6vci4M1DVJXgDSpTS2b7u4h3GSLcDK4AxfdMF0E60BR1pceKgWb2FsS2I+34T3tWU9PNJTx+J9r0WQ4as62axrk1IRCgAunXhtaIbCmDfPjKBcjwgfL66da1lWUyJlzseuHE/pfPBwOx9GmKd8HEvJjXwYsSABFT4PsfPpH6OP/mbcP2KChEZ3wZ7QMlO0NVD5LGWRLtaADqVhHHkYgHKJgkmuxFmdZbNqfavDPv10XThCrNEyuP9Mc3QXtpt1ZglVWL/KAsS/EN04ZSMBM3fIbD6tCshf8yN+Oepzsd1A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 1 Mar 2022 15:58:02 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH v2 3/7] x86/altcall: Optimise away endbr64 instruction where possible Content-Language: en-US To: Andrew Cooper CC: Roger Pau Monne , Wei Liu , Xen-devel References: <20220214125632.24563-1-andrew.cooper3@citrix.com> <20220214125632.24563-4-andrew.cooper3@citrix.com> <2808e805-60a7-2f1e-0ff4-8da123c79afd@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS9P194CA0017.EURP194.PROD.OUTLOOK.COM (2603:10a6:20b:46d::33) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 96722ba8-581e-4301-b895-08d9fb93e35a X-MS-TrafficTypeDiagnostic: VI1PR0401MB2431:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AREPU62mRoOSOuId9LRNsn9FkoDTXHd1L7NBBX0hYEb2cY4S7v1bwUCRuId6+CApun9s6Cp+Hjzcj4F2XnttM/P6/BmZT4xKQhmwrYC9GeTnHsNBYe5EuS7lrx7JB7MBtq5tgCNGgWlwOIbPTyMmCk/8A7m3DzqbxLmVM6uYS6NReFiDSptD0ct1i4/d25lLiu8A8qb/NYrp6pgVcM7F9ihEFP+8d4e2hjI1pY7GAJGbkgAOvpsvBuni3S7qmysDmd5fh31D4jkzdITQE8ahstFpBIW2qm5fAHMtyYSFAg1T7qL3MJPXP12OuUn6UfwH+7Xw3pEWlfRyOaRRyEv2TphwGVIhrSlyoiXPgPJ6gLFnsGAckoicTYa4eKsER6rpzunNCj3XK5Q8R0qSbFa6YtWr7YZibfzYX8D5rryHWxs/Eei7ihYj4a9Mv0F0ofSd/Eldz3rCAkAA/0W4JZzdGFle7vvl/PNcGxhXl5JnWVhjywBUxV+3+2xu0FKRSUnwxqsit1p/UbEspt+q+ok9zFtTmE/MU+8IiKZerdgPsYvIErglnR7OGWzaaQN+DxtOSh2JGsBIYyQzt/nbNFmN3PEP1APLzrhNeHCq76hSstBQ6pOgn3RPxEqiI75hDQO/sItquyBbHx56oYckg/1vxTSnm3Q+2PAgcff46+ml7v1CR+1dznmSRcoadeARqv8VZyBlu/iuyAiO28x8Sd72zx15u+sJi74XG5S09GsIwxQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(53546011)(66946007)(66476007)(54906003)(66556008)(31686004)(86362001)(5660300002)(508600001)(83380400001)(4326008)(8676002)(6512007)(38100700002)(36756003)(31696002)(2906002)(316002)(6486002)(8936002)(6916009)(186003)(26005)(6506007)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?m7hO/U7iKMtOAWX6+VR7lR0l8FT0sH2UYi7NQc4JkLZWFNXf8m5A7KrE3lag?= =?us-ascii?Q?zIwWABwzeMlp295/HEMynua6uSxL9yFjEuXXneX1NNAzgdTBg6ivrvqey2Qk?= =?us-ascii?Q?CsOu1/AZetBcBR/HgW6/nhoMFEwRB3xFWCuGBUrXXp/NwzRzhJdVYaPKO/hE?= =?us-ascii?Q?vPDhWoaeEhFN5nA0KQkf9jrRHPsqm52wgomxIgSjM7LNyK99HlJMvzcf3gpQ?= =?us-ascii?Q?u0LYKvPWFDW0lcfAo/paS9bfS/TjjdV9/A96MtkHqfnZExRSq3qP6BkCmf0C?= =?us-ascii?Q?bOUo0F8AuXI0xab9RZd8eV1TJcg0u1By+bhTWP45GpZQZNXP5oCDOya1S0Ki?= =?us-ascii?Q?AuGq79x+N9yRvzh9O9anQaekDLhUw13xz9ijWuhESNuH4YLrpIEVFaB5M1Ng?= =?us-ascii?Q?4kh7KBG4V1qpTBONXUWXQuYLcKq9+5DR3Cwvq4BK4Kb+pOICipxcYS6+TcAv?= =?us-ascii?Q?0+A1zr+RM2rqwuBSGlzbX/pEwuF2QCRJ2wp2QiiwWg/76RA45zeVJAxzy8e0?= =?us-ascii?Q?7aA9EknmKbvY2c5Mv52Yy8kNjjqNriEjQ/qxBnzzmMrH6wXixvhXJRCDcXiH?= =?us-ascii?Q?/Qs1FGVOAm3jBsNayObQT1qjYPfIIHcx3N5v5Mgh10hUXpNeJVu423VhIbKW?= =?us-ascii?Q?0JKqRUB/h2jdYyhthgKJm0c7uBU+EIJXzuLTslwN7nXxRYbZG5F9cd7uPHQq?= =?us-ascii?Q?PPVZQAxGkPw85NnOBwN8kANfvSuyeLjFGAKe1AtNz+6h7wS3St4aORxxbmUQ?= =?us-ascii?Q?Zc1lo+Sqb9/PPbgKZycytiCQ4bf34WvxL8gCZoEq+80A/j169zHE45/AxdMr?= =?us-ascii?Q?x/cKeEGVSDUZl6/6JpJg3Dm3QlCOiCMkh+/2d6M8R8FcbeVMcsdTHVtLyfGP?= =?us-ascii?Q?vKE2seoJ9/bbFbBkjqJ+GMpqtwxtgM5hL9aRMpJFwUV/q5M+Nz/dNz5SkiwJ?= =?us-ascii?Q?YOWPK2LC9RSj1Vt60KMXtmIPB5z+y+raN2EufwtzT4oP1OApUzZLjnUQJh+E?= =?us-ascii?Q?YeRiILDjATGOLKD5sKvUmTSl1VJmQ+M0E0Ba9oEiSokqQXNNZ9kDJlX30wxq?= =?us-ascii?Q?lAL3Vjbf807qCmisj88WuRUxRGodwQYnSxwtssYmyYg1wkjnL5A0u3GA/v7b?= =?us-ascii?Q?UYZUVMbfA44C7JALzc8SwoikFfR+jRzEZHLX1009qPXAXXzrIFJFxGh4PgSG?= =?us-ascii?Q?ir+XM05Lo8RRKBJw3c+GMxkC0Tnor07ElxtF/V9Ohm3/SItB/I+M+rWsxKTA?= =?us-ascii?Q?S3WYVjk9wC+Wp9El6RwP68dQZzl/+7mdW82oBO2oX/S5SZWwdse7lmQXr3O7?= =?us-ascii?Q?4SC6zxxJbM5vL3Orlt9MgfikEg2bKl6Yk1KNT6MF33u3UWmVB+DjdHRi6Wcl?= =?us-ascii?Q?jK99VT09Gz3vDj5IpBho8yLH/EL8gqmyJga441eLeAFd9DcpKdHsB4XGvxtR?= =?us-ascii?Q?lScim8Uvo+6bI2WU9fPuqRQ808lxoGmho3FibqnXrYvq0rPoWZyabvvD/I40?= =?us-ascii?Q?f2weCPCyi4as5tbLWyB+N33cDkxZbTGij/O518L1ixAL78vy5nOGpWMvuvDP?= =?us-ascii?Q?qptV+zDRSJvqT7Gm8kfZhKimY28GtNKXeXJE70d/oNzPsJ0T7LUtLXHFmA/h?= =?us-ascii?Q?ZGrIuLgDV1DqifGb0/vAxZw=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 96722ba8-581e-4301-b895-08d9fb93e35a X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2022 14:58:04.4492 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1ud7AS495cBgQ5VBGPi3ANRk95yai57qL6rovlowViipB9kiq/g389eqZJ2GRGDxfQNfKnO5FpLnQVSk2nhf+Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2431 On 01.03.2022 15:51, Andrew Cooper wrote: > On 01/03/2022 11:59, Jan Beulich wrote: >> On 14.02.2022 13:56, Andrew Cooper wrote: >>> @@ -330,6 +333,41 @@ static void init_or_livepatch _apply_alternatives(= struct alt_instr *start, >>> add_nops(buf + a->repl_len, total_len - a->repl_len); >>> text_poke(orig, buf, total_len); >>> } >>> + >>> + /* >>> + * Clobber endbr64 instructions now that altcall has finished opti= mising >>> + * all indirect branches to direct ones. >>> + */ >>> + if ( force && cpu_has_xen_ibt ) >> Btw, this is now also entered when the function is called from >> apply_alternatives() (i.e. when livepatching), but ... >> >>> + { >>> + void *const *val; >>> + unsigned int clobbered =3D 0; >>> + >>> + /* >>> + * This is some minor structure (ab)use. We walk the entire c= ontents >>> + * of .init.{ro,}data.cf_clobber as if it were an array of poi= nters. >>> + * >>> + * If the pointer points into .text, and at an endbr64 instruc= tion, >>> + * nop out the endbr64. This causes the pointer to no longer = be a >>> + * legal indirect branch target under CET-IBT. This is a >>> + * defence-in-depth measure, to reduce the options available t= o an >>> + * adversary who has managed to hijack a function pointer. >>> + */ >>> + for ( val =3D __initdata_cf_clobber_start; >>> + val < __initdata_cf_clobber_end; >> ... this being main binary boundaries, no action would be taken on >> the livepatch binary. Hence (also due to having been here before >> during boot), all that I understand will happen ... >> >>> + val++ ) >>> + { >>> + void *ptr =3D *val; >>> + >>> + if ( !is_kernel_text(ptr) || !is_endbr64(ptr) ) >>> + continue; >>> + >>> + add_nops(ptr, 4); >>> + clobbered++; >>> + } >>> + >>> + printk("altcall: Optimised away %u endbr64 instructions\n", cl= obbered); >> ... that this message be logged once per patch load (with a number >> of 0). I think the enclosing if() wants to be amended by >> "&& system_state < SYS_STATE_active". If you agree, I can easily >> make a patch. >=20 > Hmm.=C2=A0 There are other livepatching fixes going on, but they're start= ing > with fixing the build system breakage.=C2=A0 (The major livepatching fix = is > to adjust how we patch an old function that has an ENDBR64 at the start.) >=20 > That said, a livepatch needs to contain a section equivalent to > __initdata_cf_clobber, to be processed during load, dependent on > cpu_has_xen_ibt. IOW you say altcall patching can occur in live patches? If so, then ... > Perhaps the best option is to break the clobber out into a helper that > takes a start/end pair and returns the number clobbered.=C2=A0 That way, = it > can be reused by the livepatch logic, and independently of this printk(). ... yes, parametrizing would be necessary. Jan From xen-devel-bounces@lists.xenproject.org Tue Mar 01 14:58:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 14:58:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281644.480069 (Exim 4.92) (envelope-from ) id 1nP3xh-0001fX-3M; Tue, 01 Mar 2022 14:58:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281644.480069; Tue, 01 Mar 2022 14:58:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP3xg-0001fQ-WE; Tue, 01 Mar 2022 14:58:49 +0000 Received: by outflank-mailman (input) for mailman id 281644; Tue, 01 Mar 2022 14:58:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP3xf-0001ex-C0 for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 14:58:47 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1739bbe3-9970-11ec-8eba-a37418f5ba1a; Tue, 01 Mar 2022 15:58:46 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1739bbe3-9970-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1646146726; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=j6G4UMWqA/hPTRe/kzbfqxxngv/FBfgFnY0TcfNZOQc=; b=TeGAwFe1AjKt95w7+wZAV3a7QksftBvnY5COtwo29G3nsb8+11u6mqg1 8rM12bL+dhP9FrCTupfJd0YMdjVq2Uw2WJqKbr4Rq17wft5h6SULSY5gX VlZYPKvTq0xG+z5rToSAkBBizPhpXnSj7tGRojZ+RltOz0xqIL+urG7tV 8=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com X-SBRS: 5.1 X-MesageID: 65632347 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:0hIU6qAbg6/KTxVW/zTjw5YqxClBgxIJ4kV8jS/XYbTApDh30DUOx mIcW27XOaqNZzP2KIwnaYiy8BsBusTSyYNnQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHWeIdA970Ug5w7Vh29Yy6TSEK1jlV e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhyy N4Uqs3uaz4KBfHRoucvYjgIQx1XaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us 6ZCcXZUM07F17neLLGTE4GAguwKKsXxMZxZkXZn1TzDVt4tQIzZQrWM7thdtNs1rp4TQ62EP JZGAdZpRCvKPUF+OGgKNIkFsdmDhHynXB9Wp3vA8MLb5ECMlVcsgdABKuH9atGMAMlYgEucj mbH5HjiRAEXMsSFzjiI+W7qgfXA9QvkXKoCGbv+8eRl6HWRzGEODBwdVXOgvOK0zEW5Xrpix 1c8o3R06/JorQryE4e7D0bQTGO4UgA0WNpbSvJrtiO06ZGI/jyaNFklHm59QYlz3CMpfgAC2 liMltLvIDVgtryJVH6QnoupQSOO1Ts9djFbO3JdJecRy5y6+dxo0EqTJjp2OPPt1rXI9SfML ydmRcTUr5EaloY12qqy5jgraBr898GSHmbZCug6N19JDz+Vhqb4P+RECnCBtJ6sybp1qHHb5 BDofODEsYgz4WmlznDlfQn0NOjBCwy5GDPdm0VzOJIq6i6g/XWuFagJvm0gfBgybJpdIGa4C KM2he+3zMUIVJdNRfUqC79d9uxwlfSwfTgbfqq8giVyjmhZK1bcoXAGib+41GHxikk8+ZzTy r/AGftA+U0yUPw9pBLvHr91+eZymkgWmDOCLbimnk/P+efPOxaopUItbQLmghYRt/jf/m04M r93aqO39vmoeLamM3mPrNVKdghiwLpSLcmelvG7v9Wre2JOMGogF+XQ0fUmfYlklL5SjeDG4 je2XUow9bY1rSSvxdmiApy7VI7SYA== IronPort-HdrOrdr: A9a23:Z7zTwKGoSyibvhI2pLqFSJHXdLJyesId70hD6qkvc3Jom52j+P xGws526fatskdsZJkh8erwXJVp2RvnhNBICPoqTMiftW7dySqVxeBZnMTfKljbehEWmdQtrZ uIH5IOauEYSGIK8PoSgzPIU+rIouP3i5xA7N22pxwGIGEaCJ2IrT0JcDpzencGHjWubqBJc6 Z0k/A33gZIDk5nCPhTaEN1OtTrlpnurtbLcBQGDxko5E2lljWz8oP3FBCew1M3Ty5P6a1Kyx mHryXJooGY992rwB7V0GHeq75MnsH699dFDMuQzuAINzTXjBqybogJYczBgNl1mpDr1L8Zqq iKn/4SBbU015oXRBDtnfLZ4Xil7N/p0Q679bbXuwq5nSWzfkNFNyMIv/MpTvKe0Tt8gDg06t M544rS3aAnfS/ojWDz4cPFWAptkVfxqX0+kfQLh3gaSocGbqRNxLZvtn+9Pa1wVB4S0rpXW9 WGzfusk8p+YBefdTTUr2NvyNujUjA6GQqHWFELvoiQ3yJNlH50wkMEzIhH901wuK4VWt1B/a DJI65onLZBQosfar98Hv4IRY+yBnbWSRzBPWqOKRDsFb0BOXjKt5nriY9Fqd2CadgN1t8/iZ 7BWFRXuSo7fF/vE9SH2NlR/hXEUAyGLH3QIwFllu5EU5HHNc/W2He4OSITeuOb0oEiPvE= X-IronPort-AV: E=Sophos;i="5.90,146,1643691600"; d="scan'208";a="65632347" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CrFlZPrzQvCrZ72GVgkAfE7Sxj2g0d0+GL9S5ISANXudc/x1AjJ9Z0AjcWeMp7qDb/0p6G1t5AHP4zOfz8Fw7/s1HCRbkzL96BniuA8EJfqgBYLjBFu1+fXiyKhI36RVHwwbEe3uRYqeHXLmP2Lgb4dd7r50K/fuJtmtRL14toBg90DdhtpD7GKEYOAGVTGzM6fT34byW82GzmkYd3KGU9VC3meTehUiFM4CsDRxDBBA6MwhzAzsoia9KJ68tvnwyRnnSwPHD1sPJFk68+S/H8W+vHdawOkSzTSPRdyFrvTT0z9+ataDkSRFyUeSNM+q2mQnRcSF+3sS7Jd++3ne6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=j6G4UMWqA/hPTRe/kzbfqxxngv/FBfgFnY0TcfNZOQc=; b=CAEbbmKGp5iKZs/cR/CPQhFXM1ieDrY5wRtqZUoM7oeeN8UkThy2+eh0Mo8D2ZTflD6Z5yT8kDVTjIQEwxUV/6cdccbcq3STZ990sB1jkOHA+O5hsr2aOHbYgIGnyxY7ezb/2CuXnnsiwkalXOw2l4WHRX031PTag3O0D5k6BEnjCysVj5dcIZDhxn955B3yM9e0I/uQKGU3pkJdwu7P5LNRw761/uEF7nG9JKUFK58xjuD4oXY4Isj3kDQR/zd8tAHxw2KuPmLIQW+cvSYaWQP2ywQyf+uaz45iZ5IOuSPIg2xIFcm6hLJ1LmAflRx1y/KY5Ehy1043kfi+77N88g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=j6G4UMWqA/hPTRe/kzbfqxxngv/FBfgFnY0TcfNZOQc=; b=v1urMe3zog+GlIS+GwcD/9QE/ONM3j+ZCTjWxwxUS/aZ0kSnYnQdF4izWhgD7Dy7KRtNEO7L64XpAff2KESpDzcwi4mK1N/f2B8DeOj4y1gM1zdihWqGJmlamzxfsWXGc/wSeclVfOUVLL5gGVnJSU1YSdirvEZ4Vv5nmDq9WAw= From: Andrew Cooper To: Jan Beulich CC: Roger Pau Monne , Wei Liu , Xen-devel Subject: Re: [PATCH v2.2 8/7] x86/IOMMU: Use altcall, and __initconst_cf_clobber Thread-Topic: [PATCH v2.2 8/7] x86/IOMMU: Use altcall, and __initconst_cf_clobber Thread-Index: AQHYJ+IV6PtRJY8p5U2wBnUH9jKzdqyj8n0AgAa3aoA= Date: Tue, 1 Mar 2022 14:58:40 +0000 Message-ID: <5fae516a-17c1-0ce4-c46e-909a83c0e273@citrix.com> References: <20220214125632.24563-1-andrew.cooper3@citrix.com> <20220222114711.19209-1-andrew.cooper3@citrix.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6da19933-1718-43b9-710f-08d9fb93f8e6 x-ms-traffictypediagnostic: SJ0PR03MB6875:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: KjtwmHeLV9esxaKbTQaSuGyQQiX3vDg65l0mxzibRvaTeCCy2HhGaHK9HU6lsg/ehVoNWgxqbnZJ3K+9l0KWqeXs6R/u/BUbESXjcfEVSGu7E7RA3DcJLcxJMRMNN3GdVwbwBIy+lbmTrRGv0v2iaB+N5VDJzaNCX9C488cTAtN5qmQvlb1ELC5OEFjEm8/qfG2FNgS6iVazuVNwsO5TbdciUsvmBfN6oWej82eZeIQn6rc+iCIm3Qj3IChwZ7J9eC8nDdWB7zE29lu6Z46yIPq5P8JtnkFOieKbAKn/Sn0ibPTqEGfvl6nKgrziSJ+6Hp9GmvhgO2ClxL/YdB+6EwPBR6ljnb+41nrzMMpR/LVP/r61itL/0aMvJhu7Kj/js5Oa9zNsNWWvyu4F2Hd7c7A4makG0/69caVaWetIoZm1IwSyOBj6dpwDY83VYxMYMu9hj/OLnVukCpAT2Imc7TCwouTE3xEMf4T+/BoTS0wV9rZ87Hhn4adslZujx8hyofmheouP3iLEdb+MhZhnQz1o02zSNLpGBcK8HT/4WJ06lv+0CXZGdnO3yZvSHDgTLlD98JmHqAZ2RnFFJxtocu5bAR14eCMMmbMFsPOxwx/rF/u0wGcZ6+1Yrcq8IlrJvDRKWyc7qN3yjnJ4kEeVNkxk6Mmbh9wq71TLmWBd4X+PDQXslHvrb66Fe3XwBnyIrV24t9rD0acPF5u1ByJ7yAM/B6Z12qj8FbtTKGLbXnCoLzkaksRe3PqE8Fgnz+/4geSu4I1Vpvnb3dPqadQQ9Q== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(71200400001)(82960400001)(186003)(26005)(6512007)(6506007)(64756008)(66446008)(53546011)(2616005)(122000001)(36756003)(38100700002)(54906003)(66946007)(2906002)(5660300002)(66556008)(76116006)(38070700005)(8676002)(4326008)(6486002)(86362001)(8936002)(508600001)(91956017)(66476007)(31686004)(316002)(6916009)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?TEtnejUweUtheGtwQm5JYVlBTVJVK3ExR1lCZkNlRkc5eTVQeU5DaHRuMEI1?= =?utf-8?B?RzR5cDd3SGYvT3dSL0treDE0eTh6a2kzQU5BdzJaaUpTamhGL2dkZjhybmRZ?= =?utf-8?B?ck93M01NMm9HdEU0U3AyMVhtNjY5bWRYZVZGZWdPUzZ5c0MxT05FTE5aR0hD?= =?utf-8?B?UUJ3MVRCWWFyYW1UVmc4S3F6cS8wRmE5RE5VeDFGd2VodG9TR2c0RHlnL3V6?= =?utf-8?B?d1kyWnF4Zk4rbzNHemNDVzZ6RC9XRjVRNEVCR01rcXRFR1hydWxBT3lwdHZG?= =?utf-8?B?aVNES0hKOGFJWkl0MEc5QWt4azFJWnhWMnFMcTlIQURORFB5bWM1NVdGL21y?= =?utf-8?B?UW9qekpRK1hIei8zV3FiZ2dwRnZ6bzBmd0REUDY2RzNPWTJFS1I0aUphN0VE?= =?utf-8?B?Wm80dGpVTERMRGJ5R2pvZXI0Wk1MSWJPM1JycEsxOWs3blQyQjNmNzNiUWJR?= =?utf-8?B?UXZWNll3NE9HMzZQdURhaDRBdnhwSFRqeHFLdHdmd20rUFAxU3dHMWFoZm9v?= =?utf-8?B?NGFRUFlXQlZSdHFJTFB1aDFDMVo3MlFKYzJYelZvQnZjMkpIblZpQW1vQTY0?= =?utf-8?B?STd0Y2d2NXhXSzVHUkdxK0xXdFhrOGNJbVRSU3NTc0Vla2tkdkdYbXNTUjFG?= =?utf-8?B?VzAyMkZBQkw1V1F4b0dnMTZETWZUSFpodm5ibkxqKyt3UGJlc1Z3OHpiYzJa?= =?utf-8?B?a21LdEhRVHg3MVIvTklTZlZIZkVIZWswSjBYYXdnUDd2NzdDWVNYZjRDaDA1?= =?utf-8?B?OWpTeDdmcjhQTU5zeXdmUTBoUUtoOGpsK3V2Ulo2WWpaWXZXK3BlZ0VJV0lU?= =?utf-8?B?dzNnZTdqbVd6N2RqQ28wVGlEY3hKRnkwKzd4UXBOUVlWMURIbGloWDh1QnlH?= =?utf-8?B?cFJsNjViMjFCMUEyNnpuRFpkcUtoSHB0cWNuREtkWHgrVHV5N0lRbzN6VUk4?= =?utf-8?B?NkFOczRQSUJ6VjVJMEFxeGxGQnpVeWxPZUJyZUM2enFPV2VUUXlFc3JiNVJQ?= =?utf-8?B?Mis5QlhySVJ6Q0g2ZUdRTHFvRjJreW51NDUvOW9nbHhkeEVoektSbVB6RzZC?= =?utf-8?B?OVEwR2NPc0hFUEVhSUtPbWQvQkkyTHpTOUZXZzJIWEJIbGlPcFFBSzd6NXdM?= =?utf-8?B?bUd0ZWVyZHByN1R2a3hFVGZpRW1GZUQ1Z1VqYjZSWGtnR0xLL2hlV0JqV1BQ?= =?utf-8?B?UG9RbUp4MHh6YmZPYVRocnBFUGNsNFJpdHA3UGdTeHV1RER2eFVIVWdaTEtv?= =?utf-8?B?ZERwNDJSejZ1RzJOUElWNXczSzJ4Q01wbmFoYm95S3FocnNDNjhGZWdPLzlE?= =?utf-8?B?RHZiWThaZFRnaDJ6VGVPaCs0SmJqVHB1OSs5ZUFxRGpacHNibkoxM1lyTmhZ?= =?utf-8?B?azdsclBlRDluYVFRQ0t0V0VMb1NLU1ludExqa2tUb3BCOFFySmpXenZBOER4?= =?utf-8?B?SkNjdmZzY2JkZFZ1RDB5ZTd4SkxkSENMVUtVNFF6VUpxU3Q2blZHR3oxMWNo?= =?utf-8?B?TDE1aVV2SFNtK0lhUWo4K1VjUC8zb1orRzFmbVN1OTZZZnBSNUpsWXRUQkx4?= =?utf-8?B?REZmNkZUbUd4VzRETStveWVxeTRtd1paN3U3MWNtTmhpVU1aZGhZZklyQ1Y4?= =?utf-8?B?VkhzdVBrTTF1WElKd0doVmo3ZEVJSWhEMnByQnNoSURVMkQ2aHV5RmgvdkdR?= =?utf-8?B?bFVlQzdDTWlOaUdlcGRvOXRqYW00R004YTRmblFlaDBKZk9FZXFKSGpIWGZS?= =?utf-8?B?NXl0MHE3cHZ2NHUrL2FEMzdKeWVqR09ZSjU4UXo0Mmh1WGpqWFZMcFVmNWNF?= =?utf-8?B?Y1lsaDh2UnJ0UXZzekxSbEFVaFB2QUY3ZEY1a0p4ZmpldVRpNFdZUU5YL3lX?= =?utf-8?B?dzlMWDQ5THpMOVZwbS9yQTNXRGt6c0M4aitmQTE2SDN3R2dOR0pyODMyLzd4?= =?utf-8?B?Y1BGTTk3TW0xVjhiNVhiS2N4bmZDR3pWbUlJZlFYSi9hZG1nS1IvWFZBZng0?= =?utf-8?B?b1JFcHoxTEZJZkJxTVV5WitRK0RhVFlFWVM1aXgrTWdTcWUrMzJSQ3JvWWNM?= =?utf-8?B?ajBUdnQrcHRkeThEcXdwamE5aDkzUHdkQlNhVWYyZ0Vub3FBWDNpMmluN3NX?= =?utf-8?B?R0tVek8zMVh5bXNEQWoxMmJPb0cvY2Y0Y2h6eGE1WmswZzZsSFJSaFY5RWNG?= =?utf-8?B?QnAxTTE1Z2lZejdRK3R2TTVHVDU3QjdJeXAyb29oLytDdlAvWDJlRWRBV2ZO?= =?utf-8?B?bFJyR0lNaDNHdmJnMHJMY3dKdGhRPT0=?= Content-Type: text/plain; charset="utf-8" Content-ID: <936D1C8243B1124E9AD37FD77DEE6455@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6da19933-1718-43b9-710f-08d9fb93f8e6 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Mar 2022 14:58:40.3158 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: sD8ST2X8DW6hjGzip51hN5w/76LGD8TQqs3ODwfkNVlzgx2MZLZd1IMxsdNr2QiTkPaown86e2RMZ2LY0deXeo74c904j+aWXL7eFhxRx8c= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6875 X-OriginatorOrg: citrix.com T24gMjUvMDIvMjAyMiAwODoyNCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDIyLjAyLjIwMjIg MTI6NDcsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiAtLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhy b3VnaC9hbWQvcGNpX2FtZF9pb21tdS5jDQo+PiArKysgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3Vn aC9hbWQvcGNpX2FtZF9pb21tdS5jDQo+PiBAQCAtNjI4LDcgKzYyOCw3IEBAIHN0YXRpYyB2b2lk IGNmX2NoZWNrIGFtZF9kdW1wX3BhZ2VfdGFibGVzKHN0cnVjdCBkb21haW4gKmQpDQo+PiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgaGQtPmFyY2guYW1kLnBhZ2luZ19tb2RlLCAwLCAw KTsNCj4+ICB9DQo+PiAgDQo+PiAtc3RhdGljIGNvbnN0IHN0cnVjdCBpb21tdV9vcHMgX19pbml0 Y29uc3RyZWwgX2lvbW11X29wcyA9IHsNCj4+ICtzdGF0aWMgY29uc3Qgc3RydWN0IGlvbW11X29w cyBfX2luaXRjb25zdF9jZl9jbG9iYmVyIF9pb21tdV9vcHMgPSB7DQo+IEZvbGxvd2luZyBteSBp bml0Y2FsbCByZWxhdGVkIHJlbWFyayBvbiB4ODYnZXMgdGltZS5jIEknbSBhZnJhaWQgSSBkb24n dA0KPiBzZWUgaG93IHRoaXMgYW5kIC4uLg0KPg0KPj4gQEAgLTI3OTQsNyArMjc5Myw3IEBAIHN0 YXRpYyBpbnQgX19pbml0IGNmX2NoZWNrIGludGVsX2lvbW11X3F1YXJhbnRpbmVfaW5pdChzdHJ1 Y3QgZG9tYWluICpkKQ0KPj4gICAgICByZXR1cm4gcmM7DQo+PiAgfQ0KPj4gIA0KPj4gLXN0YXRp YyBzdHJ1Y3QgaW9tbXVfb3BzIF9faW5pdGRhdGEgdnRkX29wcyA9IHsNCj4+ICtzdGF0aWMgY29u c3Qgc3RydWN0IGlvbW11X29wcyBfX2luaXRjb25zdF9jZl9jbG9iYmVyIHZ0ZF9vcHMgPSB7DQo+ IC4uLiB0aGlzIGFjdHVhbGx5IHdvcmtzLiBCdXQgSSBndWVzcyBJIG11c3QgYmUgb3Zlcmxvb2tp bmcgc29tZXRoaW5nLCBhcw0KPiBJJ20gc3VyZSB0aGF0IHlvdSBkaWQgdGVzdCB0aGUgY2hhbmdl Lg0KPg0KPiBCb3RoIG9wcyBzdHJ1Y3R1cmVzIHJlZmVyZW5jZSBhIGZ1bmN0aW9uLCB0aHJvdWdo IC5hZGp1c3RfaXJxX2FmZmluaXRpZXMsDQo+IHdoaWNoIGlzbid0IF9faW5pdCBidXQgd2hpY2gg aXMgdXNlZCAoYmVzaWRlcyBoZXJlKSBmb3IgYW4gaW5pdGNhbGwuIFdpdGgNCj4gdGhlIEVOREJS IHJlbW92ZWQgYnkgdGhlIHRpbWUgaW5pdGNhbGxzIGFyZSBydW4sIHRoZXNlIHNob3VsZCBjYXVz ZSAjQ1AuDQoNClRoaXMgZG9lc24ndCBleHBsb2RlIGJlY2F1c2UgdGhlIGluZGlyZWN0IGNhbGxz IGFyZSByZXNvbHZlZCB0byBkaXJlY3QNCmNhbGxzIGJlZm9yZSB0aGUgRU5EQlIncyBhcmUgY2xv YmJlcmVkIHRvIE5PUDQuDQoNCkJ1dCBJIHJlYWxseSBkbyBuZWVkIHRvIHdyaXRlIGEgcHJvcGVy IHNwaGlueCBkb2MgZXhwbGFpbmluZyBob3cgdGhpcw0Kd29ya3MgYW5kIHRoZSBzYWZldHkgY29u c2lkZXJhdGlvbnMuDQoNCn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Tue Mar 01 15:54:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 15:54:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281657.480085 (Exim 4.92) (envelope-from ) id 1nP4ow-00009x-5K; Tue, 01 Mar 2022 15:53:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281657.480085; Tue, 01 Mar 2022 15:53:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP4ow-00009p-2J; Tue, 01 Mar 2022 15:53:50 +0000 Received: by outflank-mailman (input) for mailman id 281657; Tue, 01 Mar 2022 15:53:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP4ou-00009e-Gc; Tue, 01 Mar 2022 15:53:48 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP4ou-00027t-F5; Tue, 01 Mar 2022 15:53:48 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP4ou-00022E-58; Tue, 01 Mar 2022 15:53:48 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nP4ou-0001UU-4i; Tue, 01 Mar 2022 15:53:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=6EwxkTfBkuPZ2/ybwh9V2xGYugdwgp2od9n/oIelTuk=; b=znWI2ZHvWK8DjRjMp5IWCm2BES jAS0lJyrLRRcauCwTAn3Ht1a2CKDcTcSpf01WpE+PdRctTc3IiS+X35aao8OwnL1QuRHapwW4oTxt tK8qnkoCiJv9jpC+yYiEObBFetrMvg7Ml7SgJRHkm8E2ejyZ+nZ+1SDnMMW4tMttaTO4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 168295: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=497ac7b6d7f9750f48f137db244931a5728b1968 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 01 Mar 2022 15:53:48 +0000 flight 168295 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/168295/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 497ac7b6d7f9750f48f137db244931a5728b1968 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 1 days Failing since 168258 2022-03-01 01:55:31 Z 0 days 7 attempts Testing same since 168262 2022-03-01 04:10:26 Z 0 days 6 attempts ------------------------------------------------------------ People who touched revisions under test: Guomin Jiang Jason Jason Lou jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 497ac7b6d7f9750f48f137db244931a5728b1968 Author: Guomin Jiang Date: Sat Jan 29 16:28:02 2022 +0800 UefiPayloadPkg/PayloadLoaderPeim: Use INT64 as input parameter REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3818 It will have some potential issue when memory larger than 2G because the high memory address will be fill with 0xFFFFFFFF when do the operation of INTN + INT64 but it is 32 bit normal data in fact. Should use same data type INT64 + INT64. V3: 1. Use INT64 as input parameter because all date type is 64 bit V2: 1. Force the data type to UINTN to avoid high dword be filled with 0xFFFFFFFF 2. Keep INTN because the offset may postive or negative. Reviewed-by: Guo Dong Reviewed-by: Ray Ni Signed-off-by: Guomin Jiang commit 6a890db161cd6d378bec3499a1e774db3f5a27a7 Author: Jason Date: Mon Jan 10 22:30:29 2022 +0800 BaseTools: Upgrade the version of NASM tool REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Upgrade the version of NASM tool to avoid compilation errors when compiling NASM code change. Signed-off-by: Jason Lou Cc: Bob Feng Cc: Liming Gao Reviewed-by: Yuwei Chen commit bbaa00dd01ed0df30e43a5a89fd2b0433d858b73 Author: Jason Date: Mon Jan 10 22:05:47 2022 +0800 MdePkg: Remove the macro definitions regarding Opcode. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Remove the macro definitions regarding Opcode because new version of NASM tool(e.g. v2.15.05) supports the corresponding instructions. Note: This patch need to be merged after other NASM code change to avoid compilation errors. Signed-off-by: Jason Lou Cc: Michael D Kinney Reviewed-by: Liming Gao Cc: Zhiguang Liu commit 2aa107c0aa2e1375651867c8df1b81ff64b67fce Author: Jason Date: Mon Jan 10 22:01:18 2022 +0800 UefiCpuPkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Reviewed-by: Ray Ni Cc: Eric Dong Cc: Laszlo Ersek Cc: Rahul Kumar commit 7bc8b1d9f412507d579f21ea9af56fced81e7827 Author: Jason Date: Mon Jan 10 21:52:52 2022 +0800 SourceLevelDebugPkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Reviewed-by: Hao A Wu commit d3febfd9ade35dc552df6b3607c2b15d26b82867 Author: Jason Date: Mon Jan 10 21:46:27 2022 +0800 MdePkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Cc: Michael D Kinney Reviewed-by: Liming Gao Cc: Zhiguang Liu commit 84338c0d498555f860a480693ee8647a1795fba3 Author: Jason Date: Mon Jan 10 21:04:09 2022 +0800 MdeModulePkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Reviewed-by: Ray Ni Cc: Dandan Bi Reviewed-by: Liming Gao From xen-devel-bounces@lists.xenproject.org Tue Mar 01 17:13:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 17:13:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281669.480097 (Exim 4.92) (envelope-from ) id 1nP63W-0001Pk-T4; Tue, 01 Mar 2022 17:12:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281669.480097; Tue, 01 Mar 2022 17:12:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP63W-0001Pd-QG; Tue, 01 Mar 2022 17:12:58 +0000 Received: by outflank-mailman (input) for mailman id 281669; Tue, 01 Mar 2022 17:12:57 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP63V-0001PR-SL; Tue, 01 Mar 2022 17:12:57 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP63V-0003z1-Ql; Tue, 01 Mar 2022 17:12:57 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP63V-0005my-HX; Tue, 01 Mar 2022 17:12:57 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nP63V-0005tz-H3; Tue, 01 Mar 2022 17:12:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=uFitI1AGJ/vKOeX/TiQFNPnEm/NSo320fsrIQv45SZE=; b=PimpQ0O91SfvNdksS5NpYOIEFP 3PlmL3N5ia6K3QU2OSo/2sIF7+pie9HUbyZFXrNClbfQb+ipTqC8K33aP2z181J1iR0K/+AdjBoSJ xum2zgyjJVNOsHiaQaKYjGqHKIehPav4QJLuOxjvBfLEEtlWB+RoMZSJOHYtZPMdQ1gg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 168296: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=6e3f36387de566b09aa4145ea0e3bfe4814d68b4 X-Osstest-Versions-That: xen=e0a514d2f4b2fcb51835aa9a9b02653b491a61fc From: osstest service owner Date: Tue, 01 Mar 2022 17:12:57 +0000 flight 168296 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/168296/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 6e3f36387de566b09aa4145ea0e3bfe4814d68b4 baseline version: xen e0a514d2f4b2fcb51835aa9a9b02653b491a61fc Last test of basis 168283 2022-03-01 10:00:26 Z 0 days Testing same since 168296 2022-03-01 14:03:25 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git e0a514d2f4..6e3f36387d 6e3f36387de566b09aa4145ea0e3bfe4814d68b4 -> smoke From xen-devel-bounces@lists.xenproject.org Tue Mar 01 17:23:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 17:23:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281680.480107 (Exim 4.92) (envelope-from ) id 1nP6Db-000353-Sx; Tue, 01 Mar 2022 17:23:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281680.480107; Tue, 01 Mar 2022 17:23:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP6Db-00034w-PV; Tue, 01 Mar 2022 17:23:23 +0000 Received: by outflank-mailman (input) for mailman id 281680; Tue, 01 Mar 2022 17:23:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP6Da-00034q-3E for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 17:23:22 +0000 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 495411d0-9984-11ec-8eba-a37418f5ba1a; Tue, 01 Mar 2022 18:23:20 +0100 (CET) Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 221Gb1kJ030734; Tue, 1 Mar 2022 17:21:51 GMT Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by mx0b-00069f02.pphosted.com with ESMTP id 3eh14buhn5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 01 Mar 2022 17:21:51 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 221HBKKS133310; Tue, 1 Mar 2022 17:21:49 GMT Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2103.outbound.protection.outlook.com [104.47.70.103]) by userp3020.oracle.com with ESMTP id 3efdnn67g1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 01 Mar 2022 17:21:49 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) by BYAPR10MB3735.namprd10.prod.outlook.com (2603:10b6:a03:11e::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.24; Tue, 1 Mar 2022 17:21:46 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::6d20:6694:a16:56f7]) by BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::6d20:6694:a16:56f7%3]) with mapi id 15.20.5038.014; Tue, 1 Mar 2022 17:21:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 495411d0-9984-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=2VvizOzOuPTAj7HuT3zbIn+GnTrob2/mtqBRbU1SXiU=; b=mzjnXb9BbJbkntKi2URx6woevpzghgDqWOrIuLecA2Onej+RPL3My9Ne0q68kzdDnVAu e0Bn6d78tqz7lKgMz+NOfkZbxNGx8d1GMIvfq2Z0AdaCkxnPFvoPcrZQo88amL9XIo2y iKmJNXLxGDIl8vbnSr2eOR1n7hiNxdDbP/dP9M0RzSt4j4B3I7aOxJ508Xbt0Gc9U/Wr 8rbZQl3vvQlTQWMGkluEszYHXzgPy0riqwRf9I1M4SZtjIxwUMXGCejMHJkOyPWdxuea NRkT7mIWjGvyQddBOJuvPtTC50Y/TRNH4Cq7GEB3Z/gM4oRvPbhdNPgVLJQnYBUEgyLJ 3Q== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=atkh1ZJrWfbdwrvgrSPNlz9Y22EqE9Xtk8QNmDvI780heD4DgvqcBMinkeg2pDUluW7cvMODFTAOCZGVI6XrSChzWuiHg/krndycJ/ZdNieOCDPOG+7FmdQQy/PG8hn19mDw+cN1y9L2yfZ1RihHJohKuhOb4qppySIXHzygmoYQKtcStzVWqr0qCK79IOWS5cbkDDQo70ObGU8tXVHRFehxiZjf7i/bMmdbdB2YDO6EBGhLDBJVRAqNA6o2hrfxqyrgLJ75szun0qPY37hlTpfuYkJRZwaPdXXH5KYHfMPyoa8oh4eZ/kookUPJObntwdhhCLgpJHQM3H91d/FguA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2VvizOzOuPTAj7HuT3zbIn+GnTrob2/mtqBRbU1SXiU=; b=KIkFMOK3jyF2xgzZwhp+lN1x3q7YNYX2StuQ7pgQIj2qn6dLBq22DjX2tcYFB6BJbRBTeTTVjlJIX8k4lO0YsIxiCzuUcx+tV6JCdBF2lYoxqZRtK0lpEE8ABJSO33gNV96OL1P914LJYQiliResKQ++EZa0AugulA2LZeiHEoWB8EbnGyju/lGHyGeMDeh9k9ceiMQGjOkGo6vcThXvbgnAW5EfLInTbeyQy4Qfvvr5+DxNF+IJh73XnLRPI8SyD4uhy3Wd73l1Lfsi3To2Nc2CoJaTmWtHHlerxLczBEfo4fGYXXbYtiALJJ1FrzZvHoMhiOrirR0RIddiM3DuGw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2VvizOzOuPTAj7HuT3zbIn+GnTrob2/mtqBRbU1SXiU=; b=srxrjkWJ/7NzED2+Trk6grYZIeStN7H4GbSa13XBcFwXXIjgu/EfOFceOI0y6udgWlZE4jFlzu3f2pjJ2zcCOZSz7vTa/lDkac5RiaYz/3CPgTRnwPciJTTBg6ElKbMjR3YRSPlZeNPL5knJujrKJCjFnG9agr/bGA4P5BD8Su0= Message-ID: Date: Tue, 1 Mar 2022 12:21:41 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH v3 0/1] xen: fix HVM kexec kernel panic Content-Language: en-US To: Dongli Zhang Cc: linux-kernel@vger.kernel.org, jgross@suse.com, sstabellini@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, joe.jin@oracle.com, xen-devel@lists.xenproject.org, x86@kernel.org References: <20220224215049.2845-1-dongli.zhang@oracle.com> <9de1059b-6b48-e2c8-60bc-f29b42b217f7@oracle.com> <36014dbd-e63c-cf49-dafd-2d7a8b84db5d@oracle.com> <8e3e4716-22e7-8684-394c-b5a457906975@oracle.com> <1a5a683d-17c8-9730-d2f5-745262430569@oracle.com> From: Boris Ostrovsky In-Reply-To: <1a5a683d-17c8-9730-d2f5-745262430569@oracle.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SA9P223CA0005.NAMP223.PROD.OUTLOOK.COM (2603:10b6:806:26::10) To BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5dcbc3af-9376-4339-9145-08d9fba7f686 X-MS-TrafficTypeDiagnostic: BYAPR10MB3735:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xYM04L6TQ8yMr/FSKYUWVCeRzxf6ipqyH4SYjBX52V8PFr8xhzZjo/yZ5oadRmM/IrZtDPBHGF0czqPNja0mietVHgwbdZlHkBtoif04dEQBOX5ljDfavnl750WIxQxPCMzOGYcacxN4D2Wy8KmycXT7FE2+SiR+nvtr91fNHW704DeKY15kkOz9n+KSWYoZv651KVz0ALoYxRxiQWC6y5ezU2vm7kpbHCJTYw3Mucfey3FPmYamEM9nZSnsy2967RWF7wRFFUV8I7M85kvuaKtPRQhgUpuOejIMz67VMTn6zJLcqYn7cTweF1qXb5yz7M+JdxjGfOEdKPUvLeghfAXyZeyLj53W1qoIyvciNjg3KvDUGmwj0oOKPqR7wBwdsgObZZjOv4saND7epzbPJk2X/KD75IDdlFsn7MzvY6tu6zIXRwxqba1Scspt5ZUnkrvbrl2/tC0C4X5k5ncHTsrX0Cl30doFjWy7ewZVrM/Q2RPb8PRs0s7Wx36UUUdRTeqA/5bffEK1kcnBWYeYtYSZjSiOm4o2yfd11JHzqDGojQ202alkLQO0LlCejQaB4GM2jOB80GkOF28X2yhr43B+uTVbrDwSdTjIXpkRmgufT7ItvYsBeYgZVe4j4jbM26eKI/e1MbzGZ5Zu0K9k1OE4KzaXiJCbkF/62OsePHsfy0Q/7qlxk7aQNUOrHqpE4q3QAxDl+6c4pf28O44hv1FyIWAvp8CHVfx8mzkyVe4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66476007)(6862004)(2906002)(31696002)(4326008)(66556008)(8676002)(86362001)(5660300002)(66946007)(36756003)(6486002)(508600001)(7416002)(8936002)(31686004)(44832011)(38100700002)(37006003)(83380400001)(53546011)(2616005)(316002)(6512007)(6666004)(6636002)(186003)(6506007)(26005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S01UR1FYUEJ4c1RtQjg0SWlzVXkrMjg4bVNjd0U4dy9mRGJnc2E3MEl4T0pI?= =?utf-8?B?RmlmSnhCM3grSEJUN3BlTWVkQ2JYVXl4bkNvRkRZaFdhV2sycWg4UUtCK1JX?= =?utf-8?B?emV5OGw1ZEw5bVRJaFRrY2ZZNGp6bFJKOTFRdUxmME1hbE9PU3N0VXdjaHVP?= =?utf-8?B?ZWhhdTUxcWdCWldwVTMrWE92ZExZc3ZvNWlSbndoTU8rWkJKYndxVmxvVnBF?= =?utf-8?B?VnhMWHRFUDYwUHdLRWhBYlBGc3UzOUlnc0RqZFk3NWZRZjlBcFF5WVhyb0pI?= =?utf-8?B?RGNSbWpVeGowcjRLTHdsTmdCczhPc2NtNmJ5TGdSbmpHaTZJQUlCZFZPdFFS?= =?utf-8?B?RHZtUnFnbFBYK3FEZXp0eDVacksyQndKU0t5eVhkdFU2TlJ0OFpCR0R2QWVE?= =?utf-8?B?TDJocDV3M2Q3Y2Q5SXFmVkJFU2k2bXNlWUdlQkZOVlQ4aDAwd0s3RVVWbnBz?= =?utf-8?B?M3p3eENGc054Q1FNb3A2MjAyZGd0ZEgvRW9lWDVGSkFWUDlwSHpZMENFSTdE?= =?utf-8?B?K3R6dzRRMk5mc3ZiUHFqV3NEUXB6VkczTnRDZkVXRlNhSVlRNHM0eXo4bDhI?= =?utf-8?B?YnhJMjFGRmFqa2RtMiszR1hCYmY3THFyMTZNaS9jWUlQSEkzeGlqdDJlbUtM?= =?utf-8?B?cFA3TGZLYnRwdFlDYUJRNk9mUzRzOTMxbkhycmdjMFByR096VE9iZk1rL1Ev?= =?utf-8?B?SEZ6Z1VXYnRIbkR0UGF4My9SNjRPbnFEbmI3SW1mdUsyWmc0RjRJa2c4Tk5L?= =?utf-8?B?RFhJMThNdG5YTlN2Y3dBVDZXZHBHQVFSQjZ6bTF2TEJaWUlLZlBNZldpWFox?= =?utf-8?B?V1IvQjJRazU5VTkzbnFlTjRIbHN3SC80blBkQjZXWStldm43QlNWcU1VZHVN?= =?utf-8?B?TTljTlRGWklvRTNta2FCdUJFOGl4dFlNSy9NN2piNHNmSDlBRWwzaXRtWENm?= =?utf-8?B?SVhGSGU5N3dzYXh4bExnM0hhMWtYNVlxdFFXVDN1WmJiSmhMaDlEempoV2Nm?= =?utf-8?B?QXRJalh1UURrdGYzVEJNdWxGOHp6NTVmdmc3Y2E4RSthOXk4OWQ4Zy9neXNN?= =?utf-8?B?M1R1TWdqdUlaSUFMVllhNCtlS2pmNENBNjJLUlVlMkRyZWhpWWdtcnlXSjBY?= =?utf-8?B?WHhtMEsrVURtL25hT2d0T1JTSTlPb09TbXNSNmRObVJnL0t3VTVLQ3VZbWVi?= =?utf-8?B?WGVFNGlBTzFhbnQ1TWFJVzB6eVp2WDc4K0FIdHdwOVlqYWtxSE0yWFNOTTc2?= =?utf-8?B?dFdDdldEeWMvanhOeSs3SU85RHVCaFlOc2V0UWNmaVFzTmU0dEJ6dFh6bHYv?= =?utf-8?B?NVp4WWM3NFIvU2JIMlI5NGcvSnMzaFhkVVRxRFBBRGRiemRzb2xVazVoUjRu?= =?utf-8?B?NGNad3FFYkduU1JhZHF0Mk9YZGlqRlV6ZU1idlpENVo3OSt1QXByYktpL2dX?= =?utf-8?B?WHpLRldlcFhJb2VjNjlrWFo5K3c1aG9LSUJrTmtQUW9idit1aUhtKyt2S2VF?= =?utf-8?B?c00xRjdLSXQ3UWJUR25ob1htMUo0SGJ4dFN5WHY2YmdtNXk5YzVya0V5L1A3?= =?utf-8?B?K0J6ZTg4bmw4NTduUGNDQ0N0N0Q0Z1JFZTAwSi9tOTdYVUdBclRBZ2RIZG1K?= =?utf-8?B?ZXNZRUNaTUlLclpQcHhrcVVBOG04TGxJNktOT21Hb0NLZitWRHQ3c3dSSVgw?= =?utf-8?B?aG1EZ0M0TndDTVVKMDBydmQxYkhMa3JUSmZHYjUyejljVkh4YUsvMFdGM3M1?= =?utf-8?B?cEJaaWNXaDJPbEMxUmIrdHord3NBTkhFa08vbUZPT2VhWXRUMVY5OEFTcDhM?= =?utf-8?B?RFZETHZ6TzhYdmxVM2hSTFQrcXVRT251TDdqSVQrYW5hZjlVZTVIMzhOOGtP?= =?utf-8?B?cUdwaWs5emFYZjVrNnllVk5kS0JnUDcyc0ErQW9YVWNDaDBXc0c1WWt0TGxV?= =?utf-8?B?Sk5SQkxSNlZXNkkyNHA2bjQ3eHJKa3hzSzhNMnZ2TmdWRytaektYY2JmaXJC?= =?utf-8?B?d0ZtTVpxQ0pvMXY4N3B0aVhCK1IrNUVGd0RKeTB0L0lXcmtQakNJSCtnaDJG?= =?utf-8?B?UE1TQnNRSGxOelFpV2ZyVHB5WkxsZ3YxMmpacnR0U2M1Wi9KYnFGQ0NrUmZZ?= =?utf-8?B?eHpiWkRCc2lJL3o0UzhvNUF3MkhBM011UVIwR1ZVYTVlMHc3ZDF4M2RjRTht?= =?utf-8?B?V0NWdUg4anhmNGhOWFFwcUo4UzBlQ29kNFZydjhEODk3dUJ4OFZTODV2YzZX?= =?utf-8?B?Z0h0M010eXVjMXNybXVZSjRjaFNnPT0=?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5dcbc3af-9376-4339-9145-08d9fba7f686 X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2022 17:21:46.5009 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6mQFtqQMEuKoGfp+IqX0ILB6SdYjABqFtiDGxc0ssjEItl0XKnEZzfrl5Yn1/PjIgIBUkXIbvVyGBMeWjQMw6OgrVE8L/leb29JZU0kTVFs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3735 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10273 signatures=685966 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 bulkscore=0 adultscore=0 phishscore=0 spamscore=0 suspectscore=0 malwarescore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000 definitions=main-2203010090 X-Proofpoint-GUID: xKoXMw0UF3TN4vlVI_TJUE4uNaFuIwYy X-Proofpoint-ORIG-GUID: xKoXMw0UF3TN4vlVI_TJUE4uNaFuIwYy On 2/28/22 11:56 PM, Dongli Zhang wrote: > Hi Boris, > > On 2/28/22 5:18 PM, Dongli Zhang wrote: >> Hi Boris, >> >> On 2/28/22 12:45 PM, Boris Ostrovsky wrote: >>> >>> On 2/25/22 8:17 PM, Dongli Zhang wrote: >>>> Hi Boris, >>>> >>>> On 2/25/22 2:39 PM, Boris Ostrovsky wrote: >>>>> On 2/24/22 4:50 PM, Dongli Zhang wrote: >>>>>> This is the v3 of the patch to fix xen kexec kernel panic issue when the >>>>>> kexec is triggered on VCPU >= 32. >>>>>> >>>>>> PANIC: early exception 0x0e IP 10:ffffffffa96679b6 error 0 cr2 0x20 >>>>>> [    0.000000] CPU: 0 PID: 0 Comm: swapper Not tainted >>>>>> 5.17.0-rc4xen-00054-gf71077a4d84b-dirty #1 >>>>>> [    0.000000] Hardware name: Xen HVM domU, BIOS 4.4.4OVM 12/15/2020 >>>>>> [    0.000000] RIP: 0010:pvclock_clocksource_read+0x6/0xb0 >>>>>> ... ... >>>>>> [    0.000000] RSP: 0000:ffffffffaae03e10 EFLAGS: 00010082 ORIG_RAX: >>>>>> 0000000000000000 >>>>>> [    0.000000] RAX: 0000000000000000 RBX: 0000000000010000 RCX: >>>>>> 0000000000000002 >>>>>> [    0.000000] RDX: 0000000000000003 RSI: ffffffffaac37515 RDI: >>>>>> 0000000000000020 >>>>>> [    0.000000] RBP: 0000000000011000 R08: 0000000000000000 R09: >>>>>> 0000000000000001 >>>>>> [    0.000000] R10: ffffffffaae03df8 R11: ffffffffaae03c68 R12: >>>>>> 0000000040000004 >>>>>> [    0.000000] R13: ffffffffaae03e50 R14: 0000000000000000 R15: >>>>>> 0000000000000000 >>>>>> [    0.000000] FS:  0000000000000000(0000) GS:ffffffffab588000(0000) >>>>>> knlGS:0000000000000000 >>>>>> [    0.000000] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033 >>>>>> [    0.000000] CR2: 0000000000000020 CR3: 00000000ea410000 CR4: >>>>>> 00000000000406a0 >>>>>> [    0.000000] DR0: 0000000000000000 DR1: 0000000000000000 DR2: >>>>>> 0000000000000000 >>>>>> [    0.000000] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: >>>>>> 0000000000000400 >>>>>> [    0.000000] Call Trace: >>>>>> [    0.000000]  >>>>>> [    0.000000]  ? xen_clocksource_read+0x24/0x40 >>>>> >>>>> This is done to set xen_sched_clock_offset which I think will not be used for a >>>>> while, until sched_clock is called (and the other two uses are for >>>>> suspend/resume) >>>>> >>>>> >>>>> Can we simply defer 'xen_sched_clock_offset = xen_clocksource_read();' until >>>>> after all vcpu areas are properly set? Or are there other uses of >>>>> xen_clocksource_read() before ? >>>>> >>>> I have tested that below patch will panic kdump kernel. >>>> >>> >>> >>> Oh well, so much for that then. Yes, sched_clock() is at least called from >>> printk path. >>> >>> >>> I guess we will have to go with v2 then, we don't want to start seeing time >>> going back, even if only with older hypervisors. The only thing I might ask is >>> that you roll the logic inside xen_hvm_init_time_ops(). Something like >>> >>> >>> xen_hvm_init_time_ops() >>> { >>>     /* >>>      * Wait until per_cpu(xen_vcpu, 0) is initialized which may happen >>>      * later (e.g. when kdump kernel runs on >=MAX_VIRT_CPUS vcpu) >>>      */ >>>     if (__this_cpu_read(xen_vcpu_nr(0)) == NULL) >>>         return; >>> >> I think you meant __this_cpu_read(xen_vcpu). >> >> I will call xen_hvm_init_time_ops() at both places, and move the logic into >> xen_hvm_init_time_ops(). >> >> Thank you very much! >> >> Dongli Zhang >> > > How about we do not move the logic into xen_hvm_init_time_ops()? > > Suppose we move the logic into xen_hvm_init_time_ops() line 573, the line line > 570 might be printed twice. You would need to make sure the routine is executed only once so something like a local static variable would be needed. > > > 559 void __init xen_hvm_init_time_ops(void) > 560 { > 561 /* > 562 * vector callback is needed otherwise we cannot receive interrupts > 563 * on cpu > 0 and at this point we don't know how many cpus are > 564 * available. > 565 */ > 566 if (!xen_have_vector_callback) > 567 return; > 568 > 569 if (!xen_feature(XENFEAT_hvm_safe_pvclock)) { > 570 pr_info("Xen doesn't support pvclock on HVM, disable pv timer"); > 571 return; > 572 } > 573 > 574 xen_init_time_common(); > 575 > 576 x86_init.timers.setup_percpu_clockev = xen_time_init; > 577 x86_cpuinit.setup_percpu_clockev = xen_hvm_setup_cpu_clockevents; > 578 > 579 x86_platform.set_wallclock = xen_set_wallclock; > 580 } > > I feel the code looks better if we keep the logic at caller side. Would you mind > letting me know your feedback? My preference is to keep logic concentrated in one place whenever possible. -boris From xen-devel-bounces@lists.xenproject.org Tue Mar 01 17:35:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 17:35:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281689.480119 (Exim 4.92) (envelope-from ) id 1nP6PV-0004s4-5v; Tue, 01 Mar 2022 17:35:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281689.480119; Tue, 01 Mar 2022 17:35:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP6PV-0004rx-2H; Tue, 01 Mar 2022 17:35:41 +0000 Received: by outflank-mailman (input) for mailman id 281689; Tue, 01 Mar 2022 17:35:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP6PU-0004rn-2d; Tue, 01 Mar 2022 17:35:40 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP6PT-0004Nd-RC; Tue, 01 Mar 2022 17:35:39 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP6PT-0006o4-H5; Tue, 01 Mar 2022 17:35:39 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nP6PT-0000Rl-Gd; Tue, 01 Mar 2022 17:35:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=HzFW7dPbtcsWBCEKi104ei/kdQqBIRXoPWIfJymmJnU=; b=BmXXDlio+bxwOmC9rl6r2D3CcY r1uFdeUWldQq8IjYuZ8xpHSwTL10Zvow1nrr/bKG3QyFapusm2qIOjCm4KYrb69p5Y8j3yGiVTpHU UcJ5bYOKaLBEoQ1h7ApyhxZVxwb29yifHi5DkM1XoSDZ9mR2v5BINJzd/DBht3iQC278=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 168289: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-armhf-armhf-xl-rtds:guest-start.2:fail:allowable qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=a8d39f5b5ae899b1c872f128f82959158cfce048 X-Osstest-Versions-That: qemuu=00483d386901173e84c7965f9f0d678791a75e01 From: osstest service owner Date: Tue, 01 Mar 2022 17:35:39 +0000 flight 168289 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/168289/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 19 guest-start.2 fail REGR. vs. 168255 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 168255 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 168255 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168255 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 168255 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 168255 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 168255 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 168255 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 168255 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu a8d39f5b5ae899b1c872f128f82959158cfce048 baseline version: qemuu 00483d386901173e84c7965f9f0d678791a75e01 Last test of basis 168255 2022-02-28 17:08:25 Z 1 days Testing same since 168289 2022-03-01 11:07:45 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Cédric Le Goater Joel Stanley Peter Maydell jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 00483d3869..a8d39f5b5a a8d39f5b5ae899b1c872f128f82959158cfce048 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Tue Mar 01 18:20:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 18:20:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281702.480135 (Exim 4.92) (envelope-from ) id 1nP76V-0002IN-NF; Tue, 01 Mar 2022 18:20:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281702.480135; Tue, 01 Mar 2022 18:20:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP76V-0002IG-JS; Tue, 01 Mar 2022 18:20:07 +0000 Received: by outflank-mailman (input) for mailman id 281702; Tue, 01 Mar 2022 18:20:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP76U-0002I6-F5; Tue, 01 Mar 2022 18:20:06 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP76U-0005Bd-Bh; Tue, 01 Mar 2022 18:20:06 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP76U-0000Tp-1h; Tue, 01 Mar 2022 18:20:06 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nP76U-0002fZ-1F; Tue, 01 Mar 2022 18:20:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=j0Kbs40vLLH/DCfYksNY1A5KGcSGiIMsiMYbFBppfx4=; b=VjjV7w/hpOVB6PkEkTJu4lZI2v OzDH3TAJ34oVovU7ZhXIMpUWRigp8iX61ZvbPyEHHFkjWNzH6Fb/jNrEZBZvf2VUI4cpObrb+pPDa 48PXP0cHLsyiwI2qAiR06CtkzmBXf8ySfyulNC6w/m5qQdkrOphpzlEt843GV388jjwU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 168299: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=497ac7b6d7f9750f48f137db244931a5728b1968 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 01 Mar 2022 18:20:06 +0000 flight 168299 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/168299/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 497ac7b6d7f9750f48f137db244931a5728b1968 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 1 days Failing since 168258 2022-03-01 01:55:31 Z 0 days 8 attempts Testing same since 168262 2022-03-01 04:10:26 Z 0 days 7 attempts ------------------------------------------------------------ People who touched revisions under test: Guomin Jiang Jason Jason Lou jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 497ac7b6d7f9750f48f137db244931a5728b1968 Author: Guomin Jiang Date: Sat Jan 29 16:28:02 2022 +0800 UefiPayloadPkg/PayloadLoaderPeim: Use INT64 as input parameter REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3818 It will have some potential issue when memory larger than 2G because the high memory address will be fill with 0xFFFFFFFF when do the operation of INTN + INT64 but it is 32 bit normal data in fact. Should use same data type INT64 + INT64. V3: 1. Use INT64 as input parameter because all date type is 64 bit V2: 1. Force the data type to UINTN to avoid high dword be filled with 0xFFFFFFFF 2. Keep INTN because the offset may postive or negative. Reviewed-by: Guo Dong Reviewed-by: Ray Ni Signed-off-by: Guomin Jiang commit 6a890db161cd6d378bec3499a1e774db3f5a27a7 Author: Jason Date: Mon Jan 10 22:30:29 2022 +0800 BaseTools: Upgrade the version of NASM tool REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Upgrade the version of NASM tool to avoid compilation errors when compiling NASM code change. Signed-off-by: Jason Lou Cc: Bob Feng Cc: Liming Gao Reviewed-by: Yuwei Chen commit bbaa00dd01ed0df30e43a5a89fd2b0433d858b73 Author: Jason Date: Mon Jan 10 22:05:47 2022 +0800 MdePkg: Remove the macro definitions regarding Opcode. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Remove the macro definitions regarding Opcode because new version of NASM tool(e.g. v2.15.05) supports the corresponding instructions. Note: This patch need to be merged after other NASM code change to avoid compilation errors. Signed-off-by: Jason Lou Cc: Michael D Kinney Reviewed-by: Liming Gao Cc: Zhiguang Liu commit 2aa107c0aa2e1375651867c8df1b81ff64b67fce Author: Jason Date: Mon Jan 10 22:01:18 2022 +0800 UefiCpuPkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Reviewed-by: Ray Ni Cc: Eric Dong Cc: Laszlo Ersek Cc: Rahul Kumar commit 7bc8b1d9f412507d579f21ea9af56fced81e7827 Author: Jason Date: Mon Jan 10 21:52:52 2022 +0800 SourceLevelDebugPkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Reviewed-by: Hao A Wu commit d3febfd9ade35dc552df6b3607c2b15d26b82867 Author: Jason Date: Mon Jan 10 21:46:27 2022 +0800 MdePkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Cc: Michael D Kinney Reviewed-by: Liming Gao Cc: Zhiguang Liu commit 84338c0d498555f860a480693ee8647a1795fba3 Author: Jason Date: Mon Jan 10 21:04:09 2022 +0800 MdeModulePkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Reviewed-by: Ray Ni Cc: Dandan Bi Reviewed-by: Liming Gao From xen-devel-bounces@lists.xenproject.org Tue Mar 01 18:21:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 18:21:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281712.480147 (Exim 4.92) (envelope-from ) id 1nP77j-0002uU-3L; Tue, 01 Mar 2022 18:21:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281712.480147; Tue, 01 Mar 2022 18:21:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP77j-0002uL-09; Tue, 01 Mar 2022 18:21:23 +0000 Received: by outflank-mailman (input) for mailman id 281712; Tue, 01 Mar 2022 18:21:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP77h-0002uD-BB for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 18:21:21 +0000 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 637fa19e-998c-11ec-8eba-a37418f5ba1a; Tue, 01 Mar 2022 19:21:19 +0100 (CET) Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 221GibBC021769; Tue, 1 Mar 2022 18:20:30 GMT Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by mx0b-00069f02.pphosted.com with ESMTP id 3ehdaysxfj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 01 Mar 2022 18:20:29 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 221I1JQc108032; Tue, 1 Mar 2022 18:20:29 GMT Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2106.outbound.protection.outlook.com [104.47.58.106]) by aserp3030.oracle.com with ESMTP id 3efa8ehhee-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 01 Mar 2022 18:20:28 +0000 Received: from BYAPR10MB2999.namprd10.prod.outlook.com (2603:10b6:a03:85::27) by BN6PR1001MB2145.namprd10.prod.outlook.com (2603:10b6:405:2d::38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.24; Tue, 1 Mar 2022 18:20:27 +0000 Received: from BYAPR10MB2999.namprd10.prod.outlook.com ([fe80::d06b:5108:1d72:ac6c]) by BYAPR10MB2999.namprd10.prod.outlook.com ([fe80::d06b:5108:1d72:ac6c%5]) with mapi id 15.20.5038.014; Tue, 1 Mar 2022 18:20:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 637fa19e-998c-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=corp-2021-07-09; bh=uolvxQacXYmhg6H3oD0H5MVWhM/QphFrFeGOHREHM6k=; b=xt7vB76B1jEYqBcWNxIQQ4P9qzlf8BEunkxJ0fLEEPaSz2GzMKYukPUvMBfXI3ojVWsl lOL+Thi951bPUYwk6m9qcV4CHGuLip9WwL5L58eozoxuOXM18y9A/zWA3LI0fHjTovWI gZgYxH6RvBGo7qrC/dUpLXuydn0HnugZTz2trCH/MzOPmcE7cNfrTOruFizMG1vh2QBD VgvPK9SRD9s7p4TESSQ4S0gX+o1/cxEROfAwZJpgkroH9+lRyLkQbZZ+kMtgv8LN1Zn6 vhChsxWRfg2NzTFWxQi+zNuCNFPg+9fqqfilEtL6nC2YgMV3289FOj/9/dEgYSr30kWb BA== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RTEkQ3+VW0KrT7/MofZKpdMQUN7WPAk3KY0OKVReLptjXfFUjz4TuQPnLxJVvDyHU1vzmfsejbdWUWz8yDRg5Aau4gwceJBdr4x2Hb2AAUtJmfA7eeLHnH5HWvIoaWir+GQKlWo3QAz+X6hQP+T3090iV94KG0gKdLnb91kUaS+iP+XP92LyWc1BnDmOBAbZo/0FmyxtMOD+Buk2jKrsTEB08+1medsg82zY3m+r4SrTYRJpth/OCjchimLOS7VXsMqmbXBo5R2qO+jHpCrVpQZ3ZGXotDuCdl6ZXMEqvX8BRRvwHyOZtgbQT6m7gBE/Ox180bqdSNEJPj2qPF0nyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uolvxQacXYmhg6H3oD0H5MVWhM/QphFrFeGOHREHM6k=; b=ABUYj9cyWP8PCp2htP2NAZDrB/GO3uGXY6dKkHOdbPsf2gK99sCcHHyLLCkve+HYysqKYNyLXXlQo3bKdGNzN5nEcp40VIAR+KK1dPClJhay9/gqacJ7WwQgmGLNh0ulo1aoKzGirOmpJYYiFg8TKvYshXPQSH+lXlKp/zHJ5zgfjybFpm5rdtm+Fg5SoaI4Va30VtCH07mQQlrmWo6+WYNkJBWS5fIiI7pCnT6eWip0I8Q+nTR6C0dDI9t64JVkjY50PO+KDa6B8jtUwaftHqLhtC+JTVCxXot7f3PRu1bHkJ+d9GtFF+FVrNuMPvd5xl+eyXgeYMOU2jqALFCuBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uolvxQacXYmhg6H3oD0H5MVWhM/QphFrFeGOHREHM6k=; b=xDglO4tWOiUv9F1nbCfdc6cvuc1CJyDdCfLuhlBPhDzmv0RN6mggAgilvV4rXkjUKJ23vXFuxdwvaltsD9xaBkjbqw1OytzEN8W4o5SDe+MxtYofbojHgB4cgVvTfMQO+gJdygPTkeWeMjktRvL3FAETDPhX5jjMjQksbWnJ90A= Date: Tue, 1 Mar 2022 13:20:22 -0500 From: Konrad Rzeszutek Wilk To: Christoph Hellwig Cc: iommu@lists.linux-foundation.org, x86@kernel.org, Anshuman Khandual , Stefano Stabellini , Boris Ostrovsky , Juergen Gross , Joerg Roedel , David Woodhouse , Lu Baolu , Robin Murphy , linux-arm-kernel@lists.infradead.org, xen-devel@lists.xenproject.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-hyperv@vger.kernel.org, tboot-devel@lists.sourceforge.net, linux-pci@vger.kernel.org Subject: Re: [PATCH 07/11] x86: remove the IOMMU table infrastructure Message-ID: References: <20220227143055.335596-1-hch@lst.de> <20220227143055.335596-8-hch@lst.de> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220227143055.335596-8-hch@lst.de> X-ClientProxiedBy: BL1P223CA0009.NAMP223.PROD.OUTLOOK.COM (2603:10b6:208:2c4::14) To BYAPR10MB2999.namprd10.prod.outlook.com (2603:10b6:a03:85::27) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e9d924ff-f2f5-4ebb-efcb-08d9fbb028f3 X-MS-TrafficTypeDiagnostic: BN6PR1001MB2145:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lFIez9K45UjxTdw10wtEbimJWr0rXFnLt/ECe7AxJSP92ZPCU9waRxNp6elQ2PCYJoAsEfhB/13zdpEYlo2kBmMY+ayIpbILRGF9jPuxTIon18MBm++qRVF7+7tni/ODB6zkJ6FlplNyEZnV4zacMhBjUOy93eobCEyehC0I76yzDqN5JbF6pEd5fpoScOWKYF2jSeo8ztRRL8peOiuCg2NMc5KddwxhBKp556AzjYzN+F9JZBSxn7D1Vjb9f6Qn64gr+Mo9s1IQS6xLdeS5Fk7GE7gJUp5cov+l0bAHwaqSLkGKw96ceoOPYT4Ws25RMr5pW87W0fXB9CvXhulFHD9DAHH0KYNFFHCd0q0l+D+Z0/rKuWOWUPMFeBSn1fsa2Uno9yBFNyr3Q0l2mlYcg6CeDo+9RveoVWfMrO3tZKYDhi1S1WOh4E6litI9IKN3jmBwF17hdTkHhPg+iFGOX8Cilmy7sFT3anFMZRR1rjVOU/agfYWqxwd+rVxQsp0vJWwp0EgNr/z7KcyywH+xwJbjdZFIw5ybYRJPC+wl0DEiEI+pRANk5HQ8QVnTTAGxFdI8L5BmBflmIaP0da0UmaQADrN9EGNSn++zejCfFH/YprZmqBZl41psnTxKCUHR+KoIqY/Qbh4pQKMTeSONCtlXkg1rVdgL9zFuUOIfJvKEGpgHFAvbmmuNM+AmnBfn9OLE0gKq6kRQ3GOTurBCjQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB2999.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(26005)(6512007)(508600001)(7416002)(9686003)(8936002)(5660300002)(186003)(83380400001)(6486002)(4744005)(52116002)(86362001)(6916009)(54906003)(66946007)(2906002)(6506007)(38350700002)(316002)(6666004)(36756003)(66556008)(66476007)(38100700002)(4326008)(8676002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?z7srtht3IKXb5mVU5m92ELUiYvGhBogF9JhMOfxwcCeBRFJHpeXs1zxPP9qt?= =?us-ascii?Q?AKL2LY9LVzBPhHu5V0T3WBj7Gay/MwLcXS2CAup+h2z4iR78ovr89+Dnm2Ld?= =?us-ascii?Q?UrUnj//6W3vo3QZODXSxJEtSpSiFj3SX9iKeZ2Exe2TfCDONWUjIMHQdUbSC?= =?us-ascii?Q?dPEMc7YiNoEZVAPrhazsupT/Mgkg9vNIZ4GkTTdt9st8obEOslwesXRwp7v+?= =?us-ascii?Q?Ae51MH9W767t9gcwRGjn26j9l53B0nLzZSNWdlssi6h5fxLbLiOxaB3frNfV?= =?us-ascii?Q?gI4rCv/p9VnifZ8HUkY5KJnEMSTvxKkCcXmlyTgFnOwcWg8i4I7Ltn5cSSks?= =?us-ascii?Q?UqFdUyUuQCF0z899mJzCuyF0AhB0iuChSaHyhxA8uJ2i7N7Tohqzu5zyqKpu?= =?us-ascii?Q?wkXzeu3MVB/q6xJqeg/UQq7G/5cedUN8Ul0FHKPeMYF3xSYo7QDheyaKbziU?= =?us-ascii?Q?Kg+2Yy2lnS5q7XKEbwoMQ7XfuN6yl24DijBSte6N5zJZ+BM9x7M4VEZBGhT4?= =?us-ascii?Q?UgJxbfnN+gW9kXlGXsOsEclVWmaimxjCsYrf96AqHDMGsIdqziU4LjNREDSQ?= =?us-ascii?Q?bDdGNMAJEY43lVSR2Go7P/p6vGcp4C5DKkTA/2Y51VdiTTueU3ig7AjXqGIK?= =?us-ascii?Q?V7xIDgg8eG9+ZClcis4Y+e36nBwNKqaattKL+GuEGvh1lOfRmg9b8hQwzeGS?= =?us-ascii?Q?UEJaQGUVW3gLBIsBQeBZoTVo0MnHXYMI6uVak39zNk0OVDNoP8MeM8uWX0sj?= =?us-ascii?Q?XBot+wVPWI6rE7d9MupXZI/FJKnPl38Z/mZpZrpB3FVHafMujOO7mCHZwO31?= =?us-ascii?Q?oOi3uegaXOeuvbNSc1vyxfFz0zL9k+WLv+qpZPme6mv9/mmDa/MsEkSQe9xs?= =?us-ascii?Q?wY26xnM5bKngOZ8YI8rYEHlKKR9etqCD7z+CMGbT4HOeefIY3ZuBu+4mkJvq?= =?us-ascii?Q?PoGymggFXNwaQzw7SGMhF9y/vmP/niCoftXhnsrxJXlSObDM0UgtWeLjXGGu?= =?us-ascii?Q?TxrqsnQRDWeifT/rwDUSR/daQgUfAbr9Jswki7o1NwLWjqTdUJUrz7fWudH5?= =?us-ascii?Q?ySYhZzJHVemfam4PwUMoR9wShPO5kxTCsjKl++PjVuyvlFccMOqyRb9Tpw28?= =?us-ascii?Q?JNbn/S1EidVmIVwnCNL1pwhoTpJ8Z1pKWXL1eG4FqCxghELuZogZL0KYtZj1?= =?us-ascii?Q?iZVzjNOBHGQpu6gcJPHNU6zPpOIB/UgA4bdWOcCcw7XjJMY85rAHJPRQjx3p?= =?us-ascii?Q?5DqKB1hOPvpeA49iESkLGGENz8Tm9fLZdC4lTfSvFp5qVZUKNdzROzZXbn3h?= =?us-ascii?Q?Sy24x3GYe5tXWTevh4dE1aL705aMggtxKCE6/kc839b/Q9srD3JI8m3z/Shs?= =?us-ascii?Q?H6f7P6hW8ImEvjOmxujqZ/aRcRYNLKZbBwZkUxjvguifoUoAJlcCWbVaodNG?= =?us-ascii?Q?fxyoJW+TFkNCs8BUaNnrKU4fFtQLCjG0qDJMC4EEj7L0EZ6pkd3f5b3Gl6/T?= =?us-ascii?Q?cZStqh8Gq5+ulKQSfHPFv9NK174GYE9vwRZoAMsFPs8Xo6Xgd9YIMAf66dOu?= =?us-ascii?Q?WGD6hHk/QMzfp01L9PiSN9oLXkFb6ujEJMAQyIlIgdhMMrtz/DYf8TCl7LFH?= =?us-ascii?Q?EWCj8xCGlCXK2x9JCfEVl3A=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: e9d924ff-f2f5-4ebb-efcb-08d9fbb028f3 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2999.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2022 18:20:27.1245 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nHKZJHL5Fd9+ay+RKT4Mc3Poar9CEw1upWk5crVmkMULgkWOMgZ3NUaCBjzcs/Yl3WKLXUK8gxejnIBgqEkSDA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1001MB2145 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10273 signatures=685966 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 bulkscore=0 phishscore=0 malwarescore=0 mlxscore=0 suspectscore=0 spamscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000 definitions=main-2203010092 X-Proofpoint-GUID: Wj3Br-e4L6ngZnnKtFr824BC2zi0-dGS X-Proofpoint-ORIG-GUID: Wj3Br-e4L6ngZnnKtFr824BC2zi0-dGS > -#include > - > -/* > - * History lesson: > - * The execution chain of IOMMUs in 2.6.36 looks as so: > - * > - * [xen-swiotlb] > - * | > - * +----[swiotlb *]--+ > - * / | \ > - * / | \ > - * [GART] [Calgary] [Intel VT-d] > - * / > - * / > - * [AMD-Vi] .. snip.. > - * > void __init pci_iommu_alloc(void) > { > - struct iommu_table_entry *p; > - > - sort_iommu_table(__iommu_table, __iommu_table_end); > - check_iommu_entries(__iommu_table, __iommu_table_end); > - > - for (p = __iommu_table; p < __iommu_table_end; p++) { > - if (p && p->detect && p->detect() > 0) { > - p->flags |= IOMMU_DETECTED; > - if (p->early_init) > - p->early_init(); > - if (p->flags & IOMMU_FINISH_IF_DETECTED) > - break; > - } > + if (xen_pv_domain()) { > + pci_xen_swiotlb_init(); > + return; > } > + pci_swiotlb_detect_4gb(); I think you also need to check for IBM Calgary? > + gart_iommu_hole_init(); > + amd_iommu_detect(); > + detect_intel_iommu(); > + if (x86_swiotlb_enable) > + swiotlb_init(0); From xen-devel-bounces@lists.xenproject.org Tue Mar 01 20:16:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 20:16:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281732.480189 (Exim 4.92) (envelope-from ) id 1nP8ua-0007Gv-2b; Tue, 01 Mar 2022 20:15:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281732.480189; Tue, 01 Mar 2022 20:15:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP8uZ-0007Go-Uz; Tue, 01 Mar 2022 20:15:55 +0000 Received: by outflank-mailman (input) for mailman id 281732; Tue, 01 Mar 2022 20:15:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP8uY-0007Gi-FH for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 20:15:54 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 642fa7a8-999c-11ec-8eba-a37418f5ba1a; Tue, 01 Mar 2022 21:15:52 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2731A6173F; Tue, 1 Mar 2022 20:15:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 63E80C340EF; Tue, 1 Mar 2022 20:15:47 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 642fa7a8-999c-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646165750; bh=ktPF91zrjQqYukHJvi8JLaQ23mLJd5oC5eRxAgYO28Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ENjX7uzT/NGwUJDdsXSevrSMeGX1v91JOzh8isKuuoAK7dMaSpswr26O4CwbVUPzI rBw6tZ5Mpii68ccEjrc4jju8oJq7kEqzPLjxscueDel2NZ4Xyt0h6EPHTmV1kF1kf+ 6AXxVZmMJVJ0Q8GkVB7/mRcBd2HVCMKXQ18jZed9366rf3CbAsJ4+J2ObzHpY7IXhj 1sAMeyEEnw+J/iGYRPB5gegoipmoqY/dxxIVLejPMbT2qvwc7aPSd5JpE0khyrWWS+ JB5n5gVN9NPt/EUqVdsxIvpnWZ6JlFOFgiBNZpybd9A127/u5jQcmPM+qNKvQRMdwn 0jLF9mVVgKeZQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Paul Durrant , Jakub Kicinski , Sasha Levin , wei.liu@kernel.org, davem@davemloft.net, xen-devel@lists.xenproject.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 5.16 21/28] Revert "xen-netback: remove 'hotplug-status' once it has served its purpose" Date: Tue, 1 Mar 2022 15:13:26 -0500 Message-Id: <20220301201344.18191-21-sashal@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220301201344.18191-1-sashal@kernel.org> References: <20220301201344.18191-1-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Marek Marczykowski-Górecki [ Upstream commit 0f4558ae91870692ce7f509c31c9d6ee721d8cdc ] This reverts commit 1f2565780e9b7218cf92c7630130e82dcc0fe9c2. The 'hotplug-status' node should not be removed as long as the vif device remains configured. Otherwise the xen-netback would wait for re-running the network script even if it was already called (in case of the frontent re-connecting). But also, it _should_ be removed when the vif device is destroyed (for example when unbinding the driver) - otherwise hotplug script would not configure the device whenever it re-appear. Moving removal of the 'hotplug-status' node was a workaround for nothing calling network script after xen-netback module is reloaded. But when vif interface is re-created (on xen-netback unbind/bind for example), the script should be called, regardless of who does that - currently this case is not handled by the toolstack, and requires manual script call. Keeping hotplug-status=connected to skip the call is wrong and leads to not configured interface. More discussion at https://lore.kernel.org/xen-devel/afedd7cb-a291-e773-8b0d-4db9b291fa98@ipxe.org/T/#u Signed-off-by: Marek Marczykowski-Górecki Reviewed-by: Paul Durrant Link: https://lore.kernel.org/r/20220222001817.2264967-1-marmarek@invisiblethingslab.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/xen-netback/xenbus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/xen-netback/xenbus.c b/drivers/net/xen-netback/xenbus.c index d24b7a7993aa0..3fad58d22155b 100644 --- a/drivers/net/xen-netback/xenbus.c +++ b/drivers/net/xen-netback/xenbus.c @@ -256,6 +256,7 @@ static void backend_disconnect(struct backend_info *be) unsigned int queue_index; xen_unregister_watchers(vif); + xenbus_rm(XBT_NIL, be->dev->nodename, "hotplug-status"); #ifdef CONFIG_DEBUG_FS xenvif_debugfs_delif(vif); #endif /* CONFIG_DEBUG_FS */ @@ -675,7 +676,6 @@ static void hotplug_status_changed(struct xenbus_watch *watch, /* Not interested in this watch anymore. */ unregister_hotplug_status_watch(be); - xenbus_rm(XBT_NIL, be->dev->nodename, "hotplug-status"); } kfree(str); } -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Mar 01 20:16:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 20:16:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281733.480200 (Exim 4.92) (envelope-from ) id 1nP8ue-0007Wx-C5; Tue, 01 Mar 2022 20:16:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281733.480200; Tue, 01 Mar 2022 20:16:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP8ue-0007Wq-6n; Tue, 01 Mar 2022 20:16:00 +0000 Received: by outflank-mailman (input) for mailman id 281733; Tue, 01 Mar 2022 20:15:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP8uc-0007Gi-Gr for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 20:15:58 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 673f5079-999c-11ec-8eba-a37418f5ba1a; Tue, 01 Mar 2022 21:15:57 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 70AA561660; Tue, 1 Mar 2022 20:15:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 50981C36AE5; Tue, 1 Mar 2022 20:15:51 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 673f5079-999c-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646165755; bh=pw0Qj8vjosGWO4vo4tauge3HBJo809oseTBs39UMTuE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Cf7WkDdcPErdbHz/jdnLHgVJNSLfl9pSkBiaMGC1lNYzB8h1v31LWuSWZSM+gMDj1 vmYEzRbTZ5khT8T3mmm4R9YpzmbkJItVqvSR9PPhV1RwxiX7tDfh61zykTOBx3FeCk G5Fa6+VrzjanTRkm/ty/KssRR1q4C6bbOq1IGW5Ohzwfg2pl00bafpZas3pGzROlmu wnvGVihkVDYJDAC7YInCZi5HuJhZzVsyNai389IcEotROQscbuOr415k3+9JEYctRg SXZ4NmcV6mouTa3e9zJVPz6o6/qRq8kmmK/lG/XPmRtR4EobzkFmk6DlYAArX/Ocio sboPtiqgsyl0w== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Paul Durrant , Michael Brown , Jakub Kicinski , Sasha Levin , wei.liu@kernel.org, davem@davemloft.net, xen-devel@lists.xenproject.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 5.16 22/28] Revert "xen-netback: Check for hotplug-status existence before watching" Date: Tue, 1 Mar 2022 15:13:27 -0500 Message-Id: <20220301201344.18191-22-sashal@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220301201344.18191-1-sashal@kernel.org> References: <20220301201344.18191-1-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Marek Marczykowski-Górecki [ Upstream commit e8240addd0a3919e0fd7436416afe9aa6429c484 ] This reverts commit 2afeec08ab5c86ae21952151f726bfe184f6b23d. The reasoning in the commit was wrong - the code expected to setup the watch even if 'hotplug-status' didn't exist. In fact, it relied on the watch being fired the first time - to check if maybe 'hotplug-status' is already set to 'connected'. Not registering a watch for non-existing path (which is the case if hotplug script hasn't been executed yet), made the backend not waiting for the hotplug script to execute. This in turns, made the netfront think the interface is fully operational, while in fact it was not (the vif interface on xen-netback side might not be configured yet). This was a workaround for 'hotplug-status' erroneously being removed. But since that is reverted now, the workaround is not necessary either. More discussion at https://lore.kernel.org/xen-devel/afedd7cb-a291-e773-8b0d-4db9b291fa98@ipxe.org/T/#u Signed-off-by: Marek Marczykowski-Górecki Reviewed-by: Paul Durrant Reviewed-by: Michael Brown Link: https://lore.kernel.org/r/20220222001817.2264967-2-marmarek@invisiblethingslab.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/xen-netback/xenbus.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/net/xen-netback/xenbus.c b/drivers/net/xen-netback/xenbus.c index 3fad58d22155b..990360d75cb64 100644 --- a/drivers/net/xen-netback/xenbus.c +++ b/drivers/net/xen-netback/xenbus.c @@ -824,15 +824,11 @@ static void connect(struct backend_info *be) xenvif_carrier_on(be->vif); unregister_hotplug_status_watch(be); - if (xenbus_exists(XBT_NIL, dev->nodename, "hotplug-status")) { - err = xenbus_watch_pathfmt(dev, &be->hotplug_status_watch, - NULL, hotplug_status_changed, - "%s/%s", dev->nodename, - "hotplug-status"); - if (err) - goto err; + err = xenbus_watch_pathfmt(dev, &be->hotplug_status_watch, NULL, + hotplug_status_changed, + "%s/%s", dev->nodename, "hotplug-status"); + if (!err) be->have_hotplug_status_watch = 1; - } netif_tx_wake_all_queues(be->vif->dev); -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Mar 01 20:18:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 20:18:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281746.480211 (Exim 4.92) (envelope-from ) id 1nP8wc-0000Av-M3; Tue, 01 Mar 2022 20:18:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281746.480211; Tue, 01 Mar 2022 20:18:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP8wc-0000An-J8; Tue, 01 Mar 2022 20:18:02 +0000 Received: by outflank-mailman (input) for mailman id 281746; Tue, 01 Mar 2022 20:18:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP8wb-0000Ah-0Y for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 20:18:01 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id af626cfe-999c-11ec-8539-5f4723681683; Tue, 01 Mar 2022 21:17:59 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7FAA761774; Tue, 1 Mar 2022 20:17:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 162F8C340EE; Tue, 1 Mar 2022 20:17:53 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: af626cfe-999c-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646165877; bh=ktPF91zrjQqYukHJvi8JLaQ23mLJd5oC5eRxAgYO28Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CP935D0wG5TwqsAcWuYjMySe/Jun2DWqSzaCQpAZu0fpL95jZmJwxywMTaSTbzVRj tqdqJRY31l4U+DpDkPXL31nCmw1SRYPIuqRAFM5ozaYf421VoKGBuv6TfZmgSin8a6 5OEHS2ZvR8EygJKIjBCJfxL9x2ziqIjXvdIIVQANhpEyvdt+OgnWGIDUjov9y859ZE ErJQJ8vzXDNWph7LKktEK95Xnr1uek4AMdb9Ek+xFw51QwyJJy3T8v+ZhzMjKH0g6A KxBiZPlsYg6+R6vWbAciBo6oUt3KinACWwH+hApxukht0vyb+y2FiK7FG8YevVDCvY qR+zcYu4R3WuQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Paul Durrant , Jakub Kicinski , Sasha Levin , wei.liu@kernel.org, davem@davemloft.net, xen-devel@lists.xenproject.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 5.15 17/23] Revert "xen-netback: remove 'hotplug-status' once it has served its purpose" Date: Tue, 1 Mar 2022 15:16:16 -0500 Message-Id: <20220301201629.18547-17-sashal@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220301201629.18547-1-sashal@kernel.org> References: <20220301201629.18547-1-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Marek Marczykowski-Górecki [ Upstream commit 0f4558ae91870692ce7f509c31c9d6ee721d8cdc ] This reverts commit 1f2565780e9b7218cf92c7630130e82dcc0fe9c2. The 'hotplug-status' node should not be removed as long as the vif device remains configured. Otherwise the xen-netback would wait for re-running the network script even if it was already called (in case of the frontent re-connecting). But also, it _should_ be removed when the vif device is destroyed (for example when unbinding the driver) - otherwise hotplug script would not configure the device whenever it re-appear. Moving removal of the 'hotplug-status' node was a workaround for nothing calling network script after xen-netback module is reloaded. But when vif interface is re-created (on xen-netback unbind/bind for example), the script should be called, regardless of who does that - currently this case is not handled by the toolstack, and requires manual script call. Keeping hotplug-status=connected to skip the call is wrong and leads to not configured interface. More discussion at https://lore.kernel.org/xen-devel/afedd7cb-a291-e773-8b0d-4db9b291fa98@ipxe.org/T/#u Signed-off-by: Marek Marczykowski-Górecki Reviewed-by: Paul Durrant Link: https://lore.kernel.org/r/20220222001817.2264967-1-marmarek@invisiblethingslab.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/xen-netback/xenbus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/xen-netback/xenbus.c b/drivers/net/xen-netback/xenbus.c index d24b7a7993aa0..3fad58d22155b 100644 --- a/drivers/net/xen-netback/xenbus.c +++ b/drivers/net/xen-netback/xenbus.c @@ -256,6 +256,7 @@ static void backend_disconnect(struct backend_info *be) unsigned int queue_index; xen_unregister_watchers(vif); + xenbus_rm(XBT_NIL, be->dev->nodename, "hotplug-status"); #ifdef CONFIG_DEBUG_FS xenvif_debugfs_delif(vif); #endif /* CONFIG_DEBUG_FS */ @@ -675,7 +676,6 @@ static void hotplug_status_changed(struct xenbus_watch *watch, /* Not interested in this watch anymore. */ unregister_hotplug_status_watch(be); - xenbus_rm(XBT_NIL, be->dev->nodename, "hotplug-status"); } kfree(str); } -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Mar 01 20:18:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 20:18:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281747.480222 (Exim 4.92) (envelope-from ) id 1nP8wg-0000T4-UQ; Tue, 01 Mar 2022 20:18:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281747.480222; Tue, 01 Mar 2022 20:18:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP8wg-0000Sv-Qf; Tue, 01 Mar 2022 20:18:06 +0000 Received: by outflank-mailman (input) for mailman id 281747; Tue, 01 Mar 2022 20:18:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP8wf-0000Rt-K1 for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 20:18:05 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b318ceb9-999c-11ec-8eba-a37418f5ba1a; Tue, 01 Mar 2022 21:18:04 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 11242B81D40; Tue, 1 Mar 2022 20:18:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2002FC340EE; Tue, 1 Mar 2022 20:17:57 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b318ceb9-999c-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646165882; bh=pw0Qj8vjosGWO4vo4tauge3HBJo809oseTBs39UMTuE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KHAGf/B8QH90/Ba7i60IjQtmaoPSJVbHFBwhp2w6ftD1c1EkxmOoUXSG+bEaI5VbX 9nfaSFQe/npJ1IBPaZXzzedJ4azBajOXIXyO0SY0rxqvPv0Y6nC0fBkRb1/wlszNNT HE7NbmdetzuGRDqlQH5ckDe1KuD+/hOUTuIr7RbcyIJJPddnebzABJLI5PsRdayNFH O+q8Hwg1u/EALhXpegotjJMzmzVjgVqh9UfQ0ouBNmArfx1VHMCDn24j4YGRLT+s5j h0ezFxAV96V+6LvtnQB0L/2OVJMMGQDo/CcfVkyU456jvMFJ6QQD2nNhTUFhx5L8pK Y3b9fiLoD6c6g== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Paul Durrant , Michael Brown , Jakub Kicinski , Sasha Levin , wei.liu@kernel.org, davem@davemloft.net, xen-devel@lists.xenproject.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 5.15 18/23] Revert "xen-netback: Check for hotplug-status existence before watching" Date: Tue, 1 Mar 2022 15:16:17 -0500 Message-Id: <20220301201629.18547-18-sashal@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220301201629.18547-1-sashal@kernel.org> References: <20220301201629.18547-1-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Marek Marczykowski-Górecki [ Upstream commit e8240addd0a3919e0fd7436416afe9aa6429c484 ] This reverts commit 2afeec08ab5c86ae21952151f726bfe184f6b23d. The reasoning in the commit was wrong - the code expected to setup the watch even if 'hotplug-status' didn't exist. In fact, it relied on the watch being fired the first time - to check if maybe 'hotplug-status' is already set to 'connected'. Not registering a watch for non-existing path (which is the case if hotplug script hasn't been executed yet), made the backend not waiting for the hotplug script to execute. This in turns, made the netfront think the interface is fully operational, while in fact it was not (the vif interface on xen-netback side might not be configured yet). This was a workaround for 'hotplug-status' erroneously being removed. But since that is reverted now, the workaround is not necessary either. More discussion at https://lore.kernel.org/xen-devel/afedd7cb-a291-e773-8b0d-4db9b291fa98@ipxe.org/T/#u Signed-off-by: Marek Marczykowski-Górecki Reviewed-by: Paul Durrant Reviewed-by: Michael Brown Link: https://lore.kernel.org/r/20220222001817.2264967-2-marmarek@invisiblethingslab.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/xen-netback/xenbus.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/net/xen-netback/xenbus.c b/drivers/net/xen-netback/xenbus.c index 3fad58d22155b..990360d75cb64 100644 --- a/drivers/net/xen-netback/xenbus.c +++ b/drivers/net/xen-netback/xenbus.c @@ -824,15 +824,11 @@ static void connect(struct backend_info *be) xenvif_carrier_on(be->vif); unregister_hotplug_status_watch(be); - if (xenbus_exists(XBT_NIL, dev->nodename, "hotplug-status")) { - err = xenbus_watch_pathfmt(dev, &be->hotplug_status_watch, - NULL, hotplug_status_changed, - "%s/%s", dev->nodename, - "hotplug-status"); - if (err) - goto err; + err = xenbus_watch_pathfmt(dev, &be->hotplug_status_watch, NULL, + hotplug_status_changed, + "%s/%s", dev->nodename, "hotplug-status"); + if (!err) be->have_hotplug_status_watch = 1; - } netif_tx_wake_all_queues(be->vif->dev); -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Mar 01 20:19:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 20:19:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281758.480233 (Exim 4.92) (envelope-from ) id 1nP8xs-0001Kj-AV; Tue, 01 Mar 2022 20:19:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281758.480233; Tue, 01 Mar 2022 20:19:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP8xs-0001Kc-6U; Tue, 01 Mar 2022 20:19:20 +0000 Received: by outflank-mailman (input) for mailman id 281758; Tue, 01 Mar 2022 20:19:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP8xr-0001KS-Ka for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 20:19:19 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id df790003-999c-11ec-8eba-a37418f5ba1a; Tue, 01 Mar 2022 21:19:18 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 31D7EB81D44; Tue, 1 Mar 2022 20:19:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A399BC36AE5; Tue, 1 Mar 2022 20:19:14 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: df790003-999c-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646165957; bh=C+wyaY36ujuCY8gfIRQFdcYKiGxUSMFKCf8hXyx+qjE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EozefPWiZWzcsW72npT0g2LHJhq4gIduBf6TcxikRU9VRRuAmTxr6ng6Lg+9MeOw2 IIwJZTsRuEB8ECqzd9DPiKAEen8bh6oQJ6KK+4BCNnr94DPgukC1YB+VpoMmDurooC Hg/4LGLC9i0nTTE8ddQ/VyY1giiAvg0h893Mv+F6v+wAnZ+Fj1NUNGqmxrt7h1dqXH QM0hCRtQ/Vs1rnELkF3B5q6w4LPRHJSIOjuxOcawLhXjJfbFJd4wO53gt+BiS2//G2 0MrutcmGKq7vdMSkJRq31vZhYWtvpEqEBiCIZYbYj84WNF137UiwNfwrp/NnaknUSt 8OZoBc00rjCwA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Paul Durrant , Jakub Kicinski , Sasha Levin , wei.liu@kernel.org, davem@davemloft.net, xen-devel@lists.xenproject.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 5.10 09/14] Revert "xen-netback: remove 'hotplug-status' once it has served its purpose" Date: Tue, 1 Mar 2022 15:18:21 -0500 Message-Id: <20220301201833.18841-9-sashal@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220301201833.18841-1-sashal@kernel.org> References: <20220301201833.18841-1-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Marek Marczykowski-Górecki [ Upstream commit 0f4558ae91870692ce7f509c31c9d6ee721d8cdc ] This reverts commit 1f2565780e9b7218cf92c7630130e82dcc0fe9c2. The 'hotplug-status' node should not be removed as long as the vif device remains configured. Otherwise the xen-netback would wait for re-running the network script even if it was already called (in case of the frontent re-connecting). But also, it _should_ be removed when the vif device is destroyed (for example when unbinding the driver) - otherwise hotplug script would not configure the device whenever it re-appear. Moving removal of the 'hotplug-status' node was a workaround for nothing calling network script after xen-netback module is reloaded. But when vif interface is re-created (on xen-netback unbind/bind for example), the script should be called, regardless of who does that - currently this case is not handled by the toolstack, and requires manual script call. Keeping hotplug-status=connected to skip the call is wrong and leads to not configured interface. More discussion at https://lore.kernel.org/xen-devel/afedd7cb-a291-e773-8b0d-4db9b291fa98@ipxe.org/T/#u Signed-off-by: Marek Marczykowski-Górecki Reviewed-by: Paul Durrant Link: https://lore.kernel.org/r/20220222001817.2264967-1-marmarek@invisiblethingslab.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/xen-netback/xenbus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/xen-netback/xenbus.c b/drivers/net/xen-netback/xenbus.c index 94d19158efc18..7acf3940dc1ff 100644 --- a/drivers/net/xen-netback/xenbus.c +++ b/drivers/net/xen-netback/xenbus.c @@ -256,6 +256,7 @@ static void backend_disconnect(struct backend_info *be) unsigned int queue_index; xen_unregister_watchers(vif); + xenbus_rm(XBT_NIL, be->dev->nodename, "hotplug-status"); #ifdef CONFIG_DEBUG_FS xenvif_debugfs_delif(vif); #endif /* CONFIG_DEBUG_FS */ @@ -675,7 +676,6 @@ static void hotplug_status_changed(struct xenbus_watch *watch, /* Not interested in this watch anymore. */ unregister_hotplug_status_watch(be); - xenbus_rm(XBT_NIL, be->dev->nodename, "hotplug-status"); } kfree(str); } -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Mar 01 20:19:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 20:19:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281759.480243 (Exim 4.92) (envelope-from ) id 1nP8xx-0001d3-Hn; Tue, 01 Mar 2022 20:19:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281759.480243; Tue, 01 Mar 2022 20:19:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP8xx-0001cu-EU; Tue, 01 Mar 2022 20:19:25 +0000 Received: by outflank-mailman (input) for mailman id 281759; Tue, 01 Mar 2022 20:19:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP8xw-0001KS-MW for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 20:19:24 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e29ce3ea-999c-11ec-8eba-a37418f5ba1a; Tue, 01 Mar 2022 21:19:23 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 869A3B81D44; Tue, 1 Mar 2022 20:19:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9DB16C340EF; Tue, 1 Mar 2022 20:19:18 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e29ce3ea-999c-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646165962; bh=7DIF98D9Nnh9j9zlHtj60xMVnXJSxq5drnls3enId7I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=q/yuKn7h60nZhLIMp+ysAX9albRDhJGb7Vfd6BY0uF4QIz527d8RssvhIwX/3FAwv JGsCDIfODWbBylPwQjXkmZY1tYWC2a8SXZZzjH0ALOcL01bnSDucKVInn5ldZ6/TlG lubn8tz/6EN8gv5SmwnXy0xq98q4g4t0Y5MndcAagKDL5gye6tR8VAmE48XTmROB/B 8pAmG9dVuyKxL9wHbt2oO9gQG06U9uH+N1sW9XKUIQLJHZYTKyZbiX/YLsxbcDdFIU kB5JmUhnK2jAx3iT5CSFqsIpmowM39nm3rq55NV9TPOglr6K5VkKAumP5PwqqYWbY3 2CuHsHB3uuc4w== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Paul Durrant , Michael Brown , Jakub Kicinski , Sasha Levin , wei.liu@kernel.org, davem@davemloft.net, xen-devel@lists.xenproject.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 5.10 10/14] Revert "xen-netback: Check for hotplug-status existence before watching" Date: Tue, 1 Mar 2022 15:18:22 -0500 Message-Id: <20220301201833.18841-10-sashal@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220301201833.18841-1-sashal@kernel.org> References: <20220301201833.18841-1-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Marek Marczykowski-Górecki [ Upstream commit e8240addd0a3919e0fd7436416afe9aa6429c484 ] This reverts commit 2afeec08ab5c86ae21952151f726bfe184f6b23d. The reasoning in the commit was wrong - the code expected to setup the watch even if 'hotplug-status' didn't exist. In fact, it relied on the watch being fired the first time - to check if maybe 'hotplug-status' is already set to 'connected'. Not registering a watch for non-existing path (which is the case if hotplug script hasn't been executed yet), made the backend not waiting for the hotplug script to execute. This in turns, made the netfront think the interface is fully operational, while in fact it was not (the vif interface on xen-netback side might not be configured yet). This was a workaround for 'hotplug-status' erroneously being removed. But since that is reverted now, the workaround is not necessary either. More discussion at https://lore.kernel.org/xen-devel/afedd7cb-a291-e773-8b0d-4db9b291fa98@ipxe.org/T/#u Signed-off-by: Marek Marczykowski-Górecki Reviewed-by: Paul Durrant Reviewed-by: Michael Brown Link: https://lore.kernel.org/r/20220222001817.2264967-2-marmarek@invisiblethingslab.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/xen-netback/xenbus.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/net/xen-netback/xenbus.c b/drivers/net/xen-netback/xenbus.c index 7acf3940dc1ff..ca261e0fc9c9b 100644 --- a/drivers/net/xen-netback/xenbus.c +++ b/drivers/net/xen-netback/xenbus.c @@ -824,15 +824,11 @@ static void connect(struct backend_info *be) xenvif_carrier_on(be->vif); unregister_hotplug_status_watch(be); - if (xenbus_exists(XBT_NIL, dev->nodename, "hotplug-status")) { - err = xenbus_watch_pathfmt(dev, &be->hotplug_status_watch, - NULL, hotplug_status_changed, - "%s/%s", dev->nodename, - "hotplug-status"); - if (err) - goto err; + err = xenbus_watch_pathfmt(dev, &be->hotplug_status_watch, NULL, + hotplug_status_changed, + "%s/%s", dev->nodename, "hotplug-status"); + if (!err) be->have_hotplug_status_watch = 1; - } netif_tx_wake_all_queues(be->vif->dev); -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Mar 01 20:20:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 20:20:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281774.480255 (Exim 4.92) (envelope-from ) id 1nP8yw-0003Lj-0z; Tue, 01 Mar 2022 20:20:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281774.480255; Tue, 01 Mar 2022 20:20:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP8yv-0003Lc-Tk; Tue, 01 Mar 2022 20:20:25 +0000 Received: by outflank-mailman (input) for mailman id 281774; Tue, 01 Mar 2022 20:20:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP8yu-0002IQ-Jx for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 20:20:24 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [2604:1380:4601:e00::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0632fe39-999d-11ec-8539-5f4723681683; Tue, 01 Mar 2022 21:20:23 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 40D85B81D46; Tue, 1 Mar 2022 20:20:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A31AFC340F5; Tue, 1 Mar 2022 20:20:18 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0632fe39-999d-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646166021; bh=Wi+OIq1ClSsfZD7h1ZbTDCrIa5Mqda+wcBv7b7g77bI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kgxYo73PO8Ze9qgfeSOCjUgy81g0+DVhIbxosiV5i5kwWwNkSyl+xEeSaSr6jiS4V v06NWaW8H6llUU85wmjlmh0xQVFgabU2pnqJYZoZzvXDBZVnHq9lRVQaaA1TQ5Foxq T2kLaxd0LPjDs71KDi/zOSr+gNYAuumLmmEZSic9TurSvcAgP5BrhaVSXgBGv0ZSBv fAdcUsQncq9MzfCNTr6WpkFhfvfQ2PwQieQtH0g712j4PSKG4IYFFCuZ9dk3uWKzh0 8UvIZllb6jgv6RAiBYLNyU6T+fsuORs8WD1qkj6B+eWoICEEGyHQJQk1/x6i4aSJZ3 fhOLcaTsbvy/g== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Paul Durrant , Jakub Kicinski , Sasha Levin , wei.liu@kernel.org, davem@davemloft.net, xen-devel@lists.xenproject.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 06/11] Revert "xen-netback: remove 'hotplug-status' once it has served its purpose" Date: Tue, 1 Mar 2022 15:19:39 -0500 Message-Id: <20220301201951.19066-6-sashal@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220301201951.19066-1-sashal@kernel.org> References: <20220301201951.19066-1-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Marek Marczykowski-Górecki [ Upstream commit 0f4558ae91870692ce7f509c31c9d6ee721d8cdc ] This reverts commit 1f2565780e9b7218cf92c7630130e82dcc0fe9c2. The 'hotplug-status' node should not be removed as long as the vif device remains configured. Otherwise the xen-netback would wait for re-running the network script even if it was already called (in case of the frontent re-connecting). But also, it _should_ be removed when the vif device is destroyed (for example when unbinding the driver) - otherwise hotplug script would not configure the device whenever it re-appear. Moving removal of the 'hotplug-status' node was a workaround for nothing calling network script after xen-netback module is reloaded. But when vif interface is re-created (on xen-netback unbind/bind for example), the script should be called, regardless of who does that - currently this case is not handled by the toolstack, and requires manual script call. Keeping hotplug-status=connected to skip the call is wrong and leads to not configured interface. More discussion at https://lore.kernel.org/xen-devel/afedd7cb-a291-e773-8b0d-4db9b291fa98@ipxe.org/T/#u Signed-off-by: Marek Marczykowski-Górecki Reviewed-by: Paul Durrant Link: https://lore.kernel.org/r/20220222001817.2264967-1-marmarek@invisiblethingslab.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/xen-netback/xenbus.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/xen-netback/xenbus.c b/drivers/net/xen-netback/xenbus.c index 416305e6d0932..0fe0fbd83ce4a 100644 --- a/drivers/net/xen-netback/xenbus.c +++ b/drivers/net/xen-netback/xenbus.c @@ -435,6 +435,7 @@ static void backend_disconnect(struct backend_info *be) unsigned int queue_index; xen_unregister_watchers(vif); + xenbus_rm(XBT_NIL, be->dev->nodename, "hotplug-status"); #ifdef CONFIG_DEBUG_FS xenvif_debugfs_delif(vif); #endif /* CONFIG_DEBUG_FS */ -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Mar 01 20:20:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 20:20:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281775.480266 (Exim 4.92) (envelope-from ) id 1nP8z1-0003e2-9N; Tue, 01 Mar 2022 20:20:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281775.480266; Tue, 01 Mar 2022 20:20:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP8z1-0003dr-5a; Tue, 01 Mar 2022 20:20:31 +0000 Received: by outflank-mailman (input) for mailman id 281775; Tue, 01 Mar 2022 20:20:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP8yz-0002Zx-RX for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 20:20:29 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 08ead2f9-999d-11ec-8eba-a37418f5ba1a; Tue, 01 Mar 2022 21:20:28 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AA9FA608C3; Tue, 1 Mar 2022 20:20:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 31139C340EE; Tue, 1 Mar 2022 20:20:22 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 08ead2f9-999d-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646166027; bh=MqtP/Imy0BEHmQw5F9Yule8qbJc9LXHaH82WdVKlA3U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AV42EJSjOhTmeVKKhVLjdOnh8Slcmij3nIWpwPZ2NsS3J0XcTCBGZS0LP8+ifjUWg nKWqoooqIK1UkYbLPqMfI8gv1hxqHvDmL34dHrv/m8Jenq7F74euyCI/qtHva5/T80 1qZgg4pOxhDilR2NtOifq4VhRRKws+b9pLznnkGjz627dCaT7QK2bMZy6crrexPI7L 0o3+OZccQ0+taKe38SItG6sE7qsCUcXnbwE0AwNr0hUOk7OAAyUMDBWf40X6t9wQT3 mm6EqIuL/1sg3JXsUdAcc1rLzG0JZPmKVuA3zf+qyG/ubqJgkLA6EAN9kCZ6FSuvM6 x4j/QFagaSsZA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Paul Durrant , Michael Brown , Jakub Kicinski , Sasha Levin , wei.liu@kernel.org, davem@davemloft.net, xen-devel@lists.xenproject.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 07/11] Revert "xen-netback: Check for hotplug-status existence before watching" Date: Tue, 1 Mar 2022 15:19:40 -0500 Message-Id: <20220301201951.19066-7-sashal@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220301201951.19066-1-sashal@kernel.org> References: <20220301201951.19066-1-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Marek Marczykowski-Górecki [ Upstream commit e8240addd0a3919e0fd7436416afe9aa6429c484 ] This reverts commit 2afeec08ab5c86ae21952151f726bfe184f6b23d. The reasoning in the commit was wrong - the code expected to setup the watch even if 'hotplug-status' didn't exist. In fact, it relied on the watch being fired the first time - to check if maybe 'hotplug-status' is already set to 'connected'. Not registering a watch for non-existing path (which is the case if hotplug script hasn't been executed yet), made the backend not waiting for the hotplug script to execute. This in turns, made the netfront think the interface is fully operational, while in fact it was not (the vif interface on xen-netback side might not be configured yet). This was a workaround for 'hotplug-status' erroneously being removed. But since that is reverted now, the workaround is not necessary either. More discussion at https://lore.kernel.org/xen-devel/afedd7cb-a291-e773-8b0d-4db9b291fa98@ipxe.org/T/#u Signed-off-by: Marek Marczykowski-Górecki Reviewed-by: Paul Durrant Reviewed-by: Michael Brown Link: https://lore.kernel.org/r/20220222001817.2264967-2-marmarek@invisiblethingslab.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/xen-netback/xenbus.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/net/xen-netback/xenbus.c b/drivers/net/xen-netback/xenbus.c index 0fe0fbd83ce4a..44e353dd2ba19 100644 --- a/drivers/net/xen-netback/xenbus.c +++ b/drivers/net/xen-netback/xenbus.c @@ -980,15 +980,11 @@ static void connect(struct backend_info *be) xenvif_carrier_on(be->vif); unregister_hotplug_status_watch(be); - if (xenbus_exists(XBT_NIL, dev->nodename, "hotplug-status")) { - err = xenbus_watch_pathfmt(dev, &be->hotplug_status_watch, - NULL, hotplug_status_changed, - "%s/%s", dev->nodename, - "hotplug-status"); - if (err) - goto err; + err = xenbus_watch_pathfmt(dev, &be->hotplug_status_watch, NULL, + hotplug_status_changed, + "%s/%s", dev->nodename, "hotplug-status"); + if (!err) be->have_hotplug_status_watch = 1; - } netif_tx_wake_all_queues(be->vif->dev); -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Mar 01 20:22:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 20:22:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281788.480277 (Exim 4.92) (envelope-from ) id 1nP90Q-0004X8-LQ; Tue, 01 Mar 2022 20:21:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281788.480277; Tue, 01 Mar 2022 20:21:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP90Q-0004X1-Hy; Tue, 01 Mar 2022 20:21:58 +0000 Received: by outflank-mailman (input) for mailman id 281788; Tue, 01 Mar 2022 20:21:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP90P-0004Wo-C2 for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 20:21:57 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3d1d3d79-999d-11ec-8539-5f4723681683; Tue, 01 Mar 2022 21:21:56 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 500F560C0F; Tue, 1 Mar 2022 20:21:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BC3DCC340EE; Tue, 1 Mar 2022 20:21:50 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3d1d3d79-999d-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646166115; bh=zTG1k1vysBnYvsVHPSxToBqW0AedjF15Tk77ur3IC8M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NXWxrs91iiNL4csa+LB1zuUldsIkUxBfVL2N46Yk9n1/H+IFjjffgd15bP9hOwevi Fsm/pFGqZ3AhQNxpp6HeXf8F4nEC8+kZE+alyvTUEPDsNlelEIbnzTP9SIdvexF6J2 BD4oBSk9kwTS1Gfdd15ZVWU+j+bsKZ6Yjg40nfO7q6gmGDsGC4BLbBqWduAeV3E0+k gKbFl7FAZ1NDJMvSh+MLQiRf+o8GOvnPtFu+27XBgUncQWR7HFu/CPb6BUMi6opBlB fp5ls3wSkUunemzmqy+217Xe9PtHGnEZu6EFtxN61tyyj4KvyZtcTdv/qS9A3FxvBq 4fClfvX9G8i/A== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Paul Durrant , Jakub Kicinski , Sasha Levin , wei.liu@kernel.org, davem@davemloft.net, xen-devel@lists.xenproject.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 4/7] Revert "xen-netback: remove 'hotplug-status' once it has served its purpose" Date: Tue, 1 Mar 2022 15:21:25 -0500 Message-Id: <20220301202131.19318-4-sashal@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220301202131.19318-1-sashal@kernel.org> References: <20220301202131.19318-1-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Marek Marczykowski-Górecki [ Upstream commit 0f4558ae91870692ce7f509c31c9d6ee721d8cdc ] This reverts commit 1f2565780e9b7218cf92c7630130e82dcc0fe9c2. The 'hotplug-status' node should not be removed as long as the vif device remains configured. Otherwise the xen-netback would wait for re-running the network script even if it was already called (in case of the frontent re-connecting). But also, it _should_ be removed when the vif device is destroyed (for example when unbinding the driver) - otherwise hotplug script would not configure the device whenever it re-appear. Moving removal of the 'hotplug-status' node was a workaround for nothing calling network script after xen-netback module is reloaded. But when vif interface is re-created (on xen-netback unbind/bind for example), the script should be called, regardless of who does that - currently this case is not handled by the toolstack, and requires manual script call. Keeping hotplug-status=connected to skip the call is wrong and leads to not configured interface. More discussion at https://lore.kernel.org/xen-devel/afedd7cb-a291-e773-8b0d-4db9b291fa98@ipxe.org/T/#u Signed-off-by: Marek Marczykowski-Górecki Reviewed-by: Paul Durrant Link: https://lore.kernel.org/r/20220222001817.2264967-1-marmarek@invisiblethingslab.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/xen-netback/xenbus.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/xen-netback/xenbus.c b/drivers/net/xen-netback/xenbus.c index 9092b55e087f1..df2e1ec9e6248 100644 --- a/drivers/net/xen-netback/xenbus.c +++ b/drivers/net/xen-netback/xenbus.c @@ -499,6 +499,7 @@ static void backend_disconnect(struct backend_info *be) unsigned int queue_index; xen_unregister_watchers(vif); + xenbus_rm(XBT_NIL, be->dev->nodename, "hotplug-status"); #ifdef CONFIG_DEBUG_FS xenvif_debugfs_delif(vif); #endif /* CONFIG_DEBUG_FS */ -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Mar 01 20:22:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 20:22:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281789.480287 (Exim 4.92) (envelope-from ) id 1nP90W-0004py-Sq; Tue, 01 Mar 2022 20:22:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281789.480287; Tue, 01 Mar 2022 20:22:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP90W-0004pr-Pf; Tue, 01 Mar 2022 20:22:04 +0000 Received: by outflank-mailman (input) for mailman id 281789; Tue, 01 Mar 2022 20:22:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP90V-0004Wo-KL for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 20:22:03 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [2604:1380:4601:e00::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 41570f00-999d-11ec-8539-5f4723681683; Tue, 01 Mar 2022 21:22:02 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 3BFC4B81D4B; Tue, 1 Mar 2022 20:22:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1B0EDC340EF; Tue, 1 Mar 2022 20:21:55 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 41570f00-999d-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646166120; bh=g61cHQ8vevn8Jy3lrP7L3VNjPI8mTGSu5fcUfjBYktw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CnQthTY3r8PBTDrko7bpjfFH814462sjThYoiWbMi92vEHzp1CRQIN1+nriL09ica Ipa9PsogrQ9LmjOVsPNr4p3STr2ZwM8S5nxbRBM4zGLcJl/4TWpHckvL32jilku10A YX+HxW5DAYfsgcVqORUG1hO2FwTYVf4H9WxdWZbG0YhOIpBEv/pxffXCVmX7ZETR/u +vgvzj31u60dDMnckNDlnTi3S6hirdYTRGhm1GU2+5yztRGBbleCVrT65rRA2rTbtE TxKPbJ5UdHTEQ/n0ZXGu6WNk37ylbEOgSMSIyUPXCbcasCD91lWbKbmtBh5lHZJMxU S1oCJQSdJoETg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Paul Durrant , Michael Brown , Jakub Kicinski , Sasha Levin , wei.liu@kernel.org, davem@davemloft.net, xen-devel@lists.xenproject.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 5/7] Revert "xen-netback: Check for hotplug-status existence before watching" Date: Tue, 1 Mar 2022 15:21:26 -0500 Message-Id: <20220301202131.19318-5-sashal@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220301202131.19318-1-sashal@kernel.org> References: <20220301202131.19318-1-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Marek Marczykowski-Górecki [ Upstream commit e8240addd0a3919e0fd7436416afe9aa6429c484 ] This reverts commit 2afeec08ab5c86ae21952151f726bfe184f6b23d. The reasoning in the commit was wrong - the code expected to setup the watch even if 'hotplug-status' didn't exist. In fact, it relied on the watch being fired the first time - to check if maybe 'hotplug-status' is already set to 'connected'. Not registering a watch for non-existing path (which is the case if hotplug script hasn't been executed yet), made the backend not waiting for the hotplug script to execute. This in turns, made the netfront think the interface is fully operational, while in fact it was not (the vif interface on xen-netback side might not be configured yet). This was a workaround for 'hotplug-status' erroneously being removed. But since that is reverted now, the workaround is not necessary either. More discussion at https://lore.kernel.org/xen-devel/afedd7cb-a291-e773-8b0d-4db9b291fa98@ipxe.org/T/#u Signed-off-by: Marek Marczykowski-Górecki Reviewed-by: Paul Durrant Reviewed-by: Michael Brown Link: https://lore.kernel.org/r/20220222001817.2264967-2-marmarek@invisiblethingslab.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/xen-netback/xenbus.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/net/xen-netback/xenbus.c b/drivers/net/xen-netback/xenbus.c index df2e1ec9e6248..37b662f0eebca 100644 --- a/drivers/net/xen-netback/xenbus.c +++ b/drivers/net/xen-netback/xenbus.c @@ -1044,15 +1044,11 @@ static void connect(struct backend_info *be) xenvif_carrier_on(be->vif); unregister_hotplug_status_watch(be); - if (xenbus_exists(XBT_NIL, dev->nodename, "hotplug-status")) { - err = xenbus_watch_pathfmt(dev, &be->hotplug_status_watch, - NULL, hotplug_status_changed, - "%s/%s", dev->nodename, - "hotplug-status"); - if (err) - goto err; + err = xenbus_watch_pathfmt(dev, &be->hotplug_status_watch, NULL, + hotplug_status_changed, + "%s/%s", dev->nodename, "hotplug-status"); + if (!err) be->have_hotplug_status_watch = 1; - } netif_tx_wake_all_queues(be->vif->dev); -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Mar 01 20:22:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 20:22:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281801.480298 (Exim 4.92) (envelope-from ) id 1nP916-0005fW-4j; Tue, 01 Mar 2022 20:22:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281801.480298; Tue, 01 Mar 2022 20:22:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP916-0005fP-1n; Tue, 01 Mar 2022 20:22:40 +0000 Received: by outflank-mailman (input) for mailman id 281801; Tue, 01 Mar 2022 20:22:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP914-0004Wo-QS for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 20:22:38 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 55d41463-999d-11ec-8539-5f4723681683; Tue, 01 Mar 2022 21:22:37 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B972E60C1A; Tue, 1 Mar 2022 20:22:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2111DC340EF; Tue, 1 Mar 2022 20:22:31 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 55d41463-999d-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646166156; bh=aPLnTDcN5Cogu7sSosopTtKGWxetddHlbwS/+ePDwqU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=h+UeU/zpRmHfhaCMfuhxF+u1Vz65yCguVXd6YqWMqQ9EwnBIAdimJOSMbh1mAA2Ms 84ZxX16WllwqYrGoHC6mgt0OLiTn4sqHEj8N0+1nlzOhG/c3wqsRz1iZN43zEJNX6C fOf4Cb2jJVVdUET9zwIB+H3zmJA7Caz4tE2pUgkXtzGXRkSGea/bqMf+C+8c3pO6ic URTUFe4V1gScGuoQ3D0Ekcj6AqUmhMRCtUvNeQ2y1vxYvRG7Kh5ET4Xm1PesL/gEUo 3Q0KWJJ2kRi0inmOpZ6BpBCsXbyHVleS9ScuehEAQi26couDLVPeTg2unOF1F5DL2M wOb7icT5FLxrA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Paul Durrant , Michael Brown , Jakub Kicinski , Sasha Levin , wei.liu@kernel.org, davem@davemloft.net, xen-devel@lists.xenproject.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.9 4/6] Revert "xen-netback: Check for hotplug-status existence before watching" Date: Tue, 1 Mar 2022 15:22:08 -0500 Message-Id: <20220301202212.19419-4-sashal@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220301202212.19419-1-sashal@kernel.org> References: <20220301202212.19419-1-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Marek Marczykowski-Górecki [ Upstream commit e8240addd0a3919e0fd7436416afe9aa6429c484 ] This reverts commit 2afeec08ab5c86ae21952151f726bfe184f6b23d. The reasoning in the commit was wrong - the code expected to setup the watch even if 'hotplug-status' didn't exist. In fact, it relied on the watch being fired the first time - to check if maybe 'hotplug-status' is already set to 'connected'. Not registering a watch for non-existing path (which is the case if hotplug script hasn't been executed yet), made the backend not waiting for the hotplug script to execute. This in turns, made the netfront think the interface is fully operational, while in fact it was not (the vif interface on xen-netback side might not be configured yet). This was a workaround for 'hotplug-status' erroneously being removed. But since that is reverted now, the workaround is not necessary either. More discussion at https://lore.kernel.org/xen-devel/afedd7cb-a291-e773-8b0d-4db9b291fa98@ipxe.org/T/#u Signed-off-by: Marek Marczykowski-Górecki Reviewed-by: Paul Durrant Reviewed-by: Michael Brown Link: https://lore.kernel.org/r/20220222001817.2264967-2-marmarek@invisiblethingslab.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/xen-netback/xenbus.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/net/xen-netback/xenbus.c b/drivers/net/xen-netback/xenbus.c index e6646c8a7bdbb..78788402edd8b 100644 --- a/drivers/net/xen-netback/xenbus.c +++ b/drivers/net/xen-netback/xenbus.c @@ -1040,15 +1040,11 @@ static void connect(struct backend_info *be) xenvif_carrier_on(be->vif); unregister_hotplug_status_watch(be); - if (xenbus_exists(XBT_NIL, dev->nodename, "hotplug-status")) { - err = xenbus_watch_pathfmt(dev, &be->hotplug_status_watch, - NULL, hotplug_status_changed, - "%s/%s", dev->nodename, - "hotplug-status"); - if (err) - goto err; + err = xenbus_watch_pathfmt(dev, &be->hotplug_status_watch, NULL, + hotplug_status_changed, + "%s/%s", dev->nodename, "hotplug-status"); + if (!err) be->have_hotplug_status_watch = 1; - } netif_tx_wake_all_queues(be->vif->dev); -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Mar 01 20:26:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 20:26:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281812.480315 (Exim 4.92) (envelope-from ) id 1nP94Z-0006j7-2R; Tue, 01 Mar 2022 20:26:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281812.480315; Tue, 01 Mar 2022 20:26:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP94Y-0006h3-UT; Tue, 01 Mar 2022 20:26:14 +0000 Received: by outflank-mailman (input) for mailman id 281812; Tue, 01 Mar 2022 20:26:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP8zo-0002IQ-VS for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 20:21:21 +0000 Received: from sin.source.kernel.org (sin.source.kernel.org [2604:1380:40e1:4800::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 26ce0ae7-999d-11ec-8539-5f4723681683; Tue, 01 Mar 2022 21:21:19 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 3CF8ECE1EC9; Tue, 1 Mar 2022 20:21:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B8B30C340F1; Tue, 1 Mar 2022 20:21:12 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 26ce0ae7-999d-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646166076; bh=2Vzk2YwMAxcJNg8Rm+jvnFFtDs7ThSFhX2BqVrZ51qo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=s6tBqiNjjpaShVM2/hLDqSkz66ePssOER49OmyquP39Tq6m2BI2YapFbHlwUFzxCi kn1fd2AEx/TEPMsuXdS+/pCmJ2yci+YGf4XMddrcLm4lq/k8hOTs7Xv3nthX1Kl4t1 7Lq59r4cr0r8w9YqP32gIE66aeYSUcJe5st8M3MY2q4PVkWd2FhU6WNmtBnwZh4Nbm G4duiclmwVtLv0SKoj99DjRM5h+Cuv8wwoPS2PvlEMW8efRhJa/SN50yLNluv0+VbH yAxayxO1mwWx7Ff+FxCAZHwZEd/0gLmOsSC0vPn0x1AFtKB7+6pOgocyhoNAYpbbgo uBiPKjFuD/4Zw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Paul Durrant , Michael Brown , Jakub Kicinski , Sasha Levin , wei.liu@kernel.org, davem@davemloft.net, xen-devel@lists.xenproject.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 5/7] Revert "xen-netback: Check for hotplug-status existence before watching" Date: Tue, 1 Mar 2022 15:20:43 -0500 Message-Id: <20220301202046.19220-5-sashal@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220301202046.19220-1-sashal@kernel.org> References: <20220301202046.19220-1-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Marek Marczykowski-Górecki [ Upstream commit e8240addd0a3919e0fd7436416afe9aa6429c484 ] This reverts commit 2afeec08ab5c86ae21952151f726bfe184f6b23d. The reasoning in the commit was wrong - the code expected to setup the watch even if 'hotplug-status' didn't exist. In fact, it relied on the watch being fired the first time - to check if maybe 'hotplug-status' is already set to 'connected'. Not registering a watch for non-existing path (which is the case if hotplug script hasn't been executed yet), made the backend not waiting for the hotplug script to execute. This in turns, made the netfront think the interface is fully operational, while in fact it was not (the vif interface on xen-netback side might not be configured yet). This was a workaround for 'hotplug-status' erroneously being removed. But since that is reverted now, the workaround is not necessary either. More discussion at https://lore.kernel.org/xen-devel/afedd7cb-a291-e773-8b0d-4db9b291fa98@ipxe.org/T/#u Signed-off-by: Marek Marczykowski-Górecki Reviewed-by: Paul Durrant Reviewed-by: Michael Brown Link: https://lore.kernel.org/r/20220222001817.2264967-2-marmarek@invisiblethingslab.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/xen-netback/xenbus.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/net/xen-netback/xenbus.c b/drivers/net/xen-netback/xenbus.c index 6b678ab0a31f7..6d7fb0a956452 100644 --- a/drivers/net/xen-netback/xenbus.c +++ b/drivers/net/xen-netback/xenbus.c @@ -1044,15 +1044,11 @@ static void connect(struct backend_info *be) xenvif_carrier_on(be->vif); unregister_hotplug_status_watch(be); - if (xenbus_exists(XBT_NIL, dev->nodename, "hotplug-status")) { - err = xenbus_watch_pathfmt(dev, &be->hotplug_status_watch, - NULL, hotplug_status_changed, - "%s/%s", dev->nodename, - "hotplug-status"); - if (err) - goto err; + err = xenbus_watch_pathfmt(dev, &be->hotplug_status_watch, NULL, + hotplug_status_changed, + "%s/%s", dev->nodename, "hotplug-status"); + if (!err) be->have_hotplug_status_watch = 1; - } netif_tx_wake_all_queues(be->vif->dev); -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Mar 01 20:26:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 20:26:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281811.480309 (Exim 4.92) (envelope-from ) id 1nP94Y-0006bi-KM; Tue, 01 Mar 2022 20:26:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281811.480309; Tue, 01 Mar 2022 20:26:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP94Y-0006bb-H3; Tue, 01 Mar 2022 20:26:14 +0000 Received: by outflank-mailman (input) for mailman id 281811; Tue, 01 Mar 2022 20:26:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP8zi-0002IQ-6K for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 20:21:14 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 234fcbdb-999d-11ec-8539-5f4723681683; Tue, 01 Mar 2022 21:21:13 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EC85260C1B; Tue, 1 Mar 2022 20:21:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6C7C9C340F1; Tue, 1 Mar 2022 20:21:08 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 234fcbdb-999d-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646166071; bh=RvXug01H9kluAEqabwUZGjwgNYTE/wBoZUtVrQZmwb0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pd2p17hyUgQUU8QgN9hPriWSLOlFECl0x2q1QPw6jCtHIl6QkOS93cUHecaz9knO1 Z4sVFWwam78nkZAtUOx8LMY7RYKs3yqO4hS8Ue6pzZnrjZEwfuvDkLO92eCAm32bzM k+mNS5ehK8gvKeh5kj+SkZFDS/OfXKU6376Uqmcteo4+4yDkacFv5IV7Xu+sOuU6KJ K7qkomWjjXA9nDVn1pY4DwWCjyOuZt/qPpd5rapMMsyHIT9BALyeODRW+sBN4rK57/ n2onTDHJFuFvAmYG5H0ItQZ8U0ixVAx4LyiJpk3lv/n4eLoKhmPp4GAqAQxGmcNwYy AliO66PVrC0qQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Paul Durrant , Jakub Kicinski , Sasha Levin , wei.liu@kernel.org, davem@davemloft.net, xen-devel@lists.xenproject.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 4/7] Revert "xen-netback: remove 'hotplug-status' once it has served its purpose" Date: Tue, 1 Mar 2022 15:20:42 -0500 Message-Id: <20220301202046.19220-4-sashal@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220301202046.19220-1-sashal@kernel.org> References: <20220301202046.19220-1-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Marek Marczykowski-Górecki [ Upstream commit 0f4558ae91870692ce7f509c31c9d6ee721d8cdc ] This reverts commit 1f2565780e9b7218cf92c7630130e82dcc0fe9c2. The 'hotplug-status' node should not be removed as long as the vif device remains configured. Otherwise the xen-netback would wait for re-running the network script even if it was already called (in case of the frontent re-connecting). But also, it _should_ be removed when the vif device is destroyed (for example when unbinding the driver) - otherwise hotplug script would not configure the device whenever it re-appear. Moving removal of the 'hotplug-status' node was a workaround for nothing calling network script after xen-netback module is reloaded. But when vif interface is re-created (on xen-netback unbind/bind for example), the script should be called, regardless of who does that - currently this case is not handled by the toolstack, and requires manual script call. Keeping hotplug-status=connected to skip the call is wrong and leads to not configured interface. More discussion at https://lore.kernel.org/xen-devel/afedd7cb-a291-e773-8b0d-4db9b291fa98@ipxe.org/T/#u Signed-off-by: Marek Marczykowski-Górecki Reviewed-by: Paul Durrant Link: https://lore.kernel.org/r/20220222001817.2264967-1-marmarek@invisiblethingslab.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/xen-netback/xenbus.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/xen-netback/xenbus.c b/drivers/net/xen-netback/xenbus.c index 78c56149559ce..6b678ab0a31f7 100644 --- a/drivers/net/xen-netback/xenbus.c +++ b/drivers/net/xen-netback/xenbus.c @@ -499,6 +499,7 @@ static void backend_disconnect(struct backend_info *be) unsigned int queue_index; xen_unregister_watchers(vif); + xenbus_rm(XBT_NIL, be->dev->nodename, "hotplug-status"); #ifdef CONFIG_DEBUG_FS xenvif_debugfs_delif(vif); #endif /* CONFIG_DEBUG_FS */ -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Mar 01 21:23:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 21:23:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281827.480331 (Exim 4.92) (envelope-from ) id 1nP9xg-0005l5-DT; Tue, 01 Mar 2022 21:23:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281827.480331; Tue, 01 Mar 2022 21:23:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP9xg-0005ky-A0; Tue, 01 Mar 2022 21:23:12 +0000 Received: by outflank-mailman (input) for mailman id 281827; Tue, 01 Mar 2022 21:23:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP9xf-0005kW-1u; Tue, 01 Mar 2022 21:23:11 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP9xf-00008m-08; Tue, 01 Mar 2022 21:23:11 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nP9xe-0001wv-Pk; Tue, 01 Mar 2022 21:23:10 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nP9xe-0005VQ-PI; Tue, 01 Mar 2022 21:23:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=fgQDROt0gPaCDg9H/kNou+7c4bbuhY63FEKFNOM8sqw=; b=zgwSR6D03FXqeBC2THMp6KgeUC W7kaiua3sG//44E3kHgz9nj3+b2hSvKbkVYonA0tG3pEaltaIFATEJiAFjN2+j9KirtqZa4Hruz6i yKD3K9iVB+HAsz1e3ctBtvxZrmzn2g02r7ZzYUpf3jEILd/H1p7ExRJ7ytPLYPlnE9PY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 168303: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=497ac7b6d7f9750f48f137db244931a5728b1968 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 01 Mar 2022 21:23:10 +0000 flight 168303 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/168303/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 497ac7b6d7f9750f48f137db244931a5728b1968 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 1 days Failing since 168258 2022-03-01 01:55:31 Z 0 days 9 attempts Testing same since 168262 2022-03-01 04:10:26 Z 0 days 8 attempts ------------------------------------------------------------ People who touched revisions under test: Guomin Jiang Jason Jason Lou jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 497ac7b6d7f9750f48f137db244931a5728b1968 Author: Guomin Jiang Date: Sat Jan 29 16:28:02 2022 +0800 UefiPayloadPkg/PayloadLoaderPeim: Use INT64 as input parameter REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3818 It will have some potential issue when memory larger than 2G because the high memory address will be fill with 0xFFFFFFFF when do the operation of INTN + INT64 but it is 32 bit normal data in fact. Should use same data type INT64 + INT64. V3: 1. Use INT64 as input parameter because all date type is 64 bit V2: 1. Force the data type to UINTN to avoid high dword be filled with 0xFFFFFFFF 2. Keep INTN because the offset may postive or negative. Reviewed-by: Guo Dong Reviewed-by: Ray Ni Signed-off-by: Guomin Jiang commit 6a890db161cd6d378bec3499a1e774db3f5a27a7 Author: Jason Date: Mon Jan 10 22:30:29 2022 +0800 BaseTools: Upgrade the version of NASM tool REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Upgrade the version of NASM tool to avoid compilation errors when compiling NASM code change. Signed-off-by: Jason Lou Cc: Bob Feng Cc: Liming Gao Reviewed-by: Yuwei Chen commit bbaa00dd01ed0df30e43a5a89fd2b0433d858b73 Author: Jason Date: Mon Jan 10 22:05:47 2022 +0800 MdePkg: Remove the macro definitions regarding Opcode. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Remove the macro definitions regarding Opcode because new version of NASM tool(e.g. v2.15.05) supports the corresponding instructions. Note: This patch need to be merged after other NASM code change to avoid compilation errors. Signed-off-by: Jason Lou Cc: Michael D Kinney Reviewed-by: Liming Gao Cc: Zhiguang Liu commit 2aa107c0aa2e1375651867c8df1b81ff64b67fce Author: Jason Date: Mon Jan 10 22:01:18 2022 +0800 UefiCpuPkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Reviewed-by: Ray Ni Cc: Eric Dong Cc: Laszlo Ersek Cc: Rahul Kumar commit 7bc8b1d9f412507d579f21ea9af56fced81e7827 Author: Jason Date: Mon Jan 10 21:52:52 2022 +0800 SourceLevelDebugPkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Reviewed-by: Hao A Wu commit d3febfd9ade35dc552df6b3607c2b15d26b82867 Author: Jason Date: Mon Jan 10 21:46:27 2022 +0800 MdePkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Cc: Michael D Kinney Reviewed-by: Liming Gao Cc: Zhiguang Liu commit 84338c0d498555f860a480693ee8647a1795fba3 Author: Jason Date: Mon Jan 10 21:04:09 2022 +0800 MdeModulePkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Reviewed-by: Ray Ni Cc: Dandan Bi Reviewed-by: Liming Gao From xen-devel-bounces@lists.xenproject.org Tue Mar 01 23:22:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 23:22:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281844.480357 (Exim 4.92) (envelope-from ) id 1nPBog-0002m0-V6; Tue, 01 Mar 2022 23:22:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281844.480357; Tue, 01 Mar 2022 23:22:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPBog-0002lt-RT; Tue, 01 Mar 2022 23:22:02 +0000 Received: by outflank-mailman (input) for mailman id 281844; Tue, 01 Mar 2022 23:22:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPBof-0002ld-LH; Tue, 01 Mar 2022 23:22:01 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPBof-0002Fo-HD; Tue, 01 Mar 2022 23:22:01 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPBof-0000eT-3R; Tue, 01 Mar 2022 23:22:01 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nPBof-0004fQ-2y; Tue, 01 Mar 2022 23:22:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=s/s9/34Q0ZpDzkx2q2EH2snsBqv4LphHRmlebOkeNo4=; b=pVTbfVgvTseIIGxrlhQv5oSfrb +Muc4r4eAZUKTrhHlv2jaVJvBQbx0i8HBCE1yTWAhUjTuvuON85PUBr5aRce1tmC7Uzl0hxGvjDAb bM2ef+HVFWgDNi8zsXcUnk4fkFOAchbOon5LOC8dlJj55IvfRhPNkQTwaWlYIkh4OgAs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 168294: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=e0a514d2f4b2fcb51835aa9a9b02653b491a61fc X-Osstest-Versions-That: xen=4388144c44c4dd9e9b7df97938ef08ffa85eec07 From: osstest service owner Date: Tue, 01 Mar 2022 23:22:01 +0000 flight 168294 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/168294/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 168257 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168257 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 168257 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 168257 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 168257 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 168257 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 168257 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 168257 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 168257 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 168257 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 168257 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 168257 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen e0a514d2f4b2fcb51835aa9a9b02653b491a61fc baseline version: xen 4388144c44c4dd9e9b7df97938ef08ffa85eec07 Last test of basis 168257 2022-03-01 01:53:09 Z 0 days Testing same since 168294 2022-03-01 13:07:32 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jan Beulich Roger Pau Monné jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 4388144c44..e0a514d2f4 e0a514d2f4b2fcb51835aa9a9b02653b491a61fc -> master From xen-devel-bounces@lists.xenproject.org Tue Mar 01 23:32:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 23:32:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281859.480377 (Exim 4.92) (envelope-from ) id 1nPByq-0004bi-4q; Tue, 01 Mar 2022 23:32:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281859.480377; Tue, 01 Mar 2022 23:32:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPByq-0004bb-1J; Tue, 01 Mar 2022 23:32:32 +0000 Received: by outflank-mailman (input) for mailman id 281859; Tue, 01 Mar 2022 23:32:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPByo-0004bV-Ll for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 23:32:30 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id db66cf26-99b7-11ec-8eba-a37418f5ba1a; Wed, 02 Mar 2022 00:32:28 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 417D0B81E9E; Tue, 1 Mar 2022 23:32:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 75C45C340EE; Tue, 1 Mar 2022 23:32:25 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: db66cf26-99b7-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646177545; bh=+SA82CamGfLPzzHxYpYuzMUaSa0MxSu4P4PwkY7jH04=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=O3DOvQLN4pclMrpiNvqv9YCAeO8vne6fd42TCWCLuB6T2Ku51vp5155oGPV5ArOAM 3ph2RkU69+9eBqb61zhhKNIH3saV7/6OiXRIiQO7PNDJLEkFt5bwkrttHwEuXcb69/ Pq+sQL2nth4xala1hM40dGSAWskVi6ODTteSvxn0DQGfR4KAxtEkAdSF2uFA3p+6AA 5GiXMRyRGcZinxXrPip8ysfNNDV2FMw6dG7Dioqssx8KiRv+g5Wn8VppmPdz589aS2 F5H6lNoZyPSeTdmBq5rCrHgnGrN1xH97bt7U7oHKdEYX9Rvd67VsLxPBInFRoUvMBg FyZ85Q6SykJPA== Date: Tue, 1 Mar 2022 15:32:18 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Wei Chen cc: Henry Wang , Julien Grall , "xen-devel@lists.xenproject.org" , "sstabellini@kernel.org" , Bertrand Marquis , Penny Zheng Subject: RE: [RFC PATCH 0/2] Introduce reserved Xenheap In-Reply-To: Message-ID: References: <20220224013023.50920-1-Henry.Wang@arm.com> <6269ec3d-039e-d68f-771d-c5e088631410@xen.org> <48a0712c-eff8-dfc1-2136-59317f22321f@xen.org> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 1 Mar 2022, Wei Chen wrote: > > Hi Julien, > > > > > -----Original Message----- > > > From: Julien Grall > > > On 28/02/2022 07:12, Henry Wang wrote: > > > > Hi Julien, > > > > > > Hi Henry, > > > > > > >> -----Original Message----- > > > >> From: Julien Grall > > > >> Hi Henry, > > > >> > > > >> On 24/02/2022 01:30, Henry Wang wrote: > > > >>> The reserved Xenheap, or statically configured Xenheap, refers to > > parts > > > >>> of RAM reserved in the beginning for Xenheap. Like the static memory > > > >>> allocation, such reserved Xenheap regions are reserved by > > configuration > > > >>> in the device tree using physical address ranges. > > > >> > > > >> In Xen, we have the concept of domheap and xenheap. For Arm64 and > > > x86 > > > >> they would be the same. But for Arm32, they would be different: > > xenheap > > > >> is always mapped whereas domheap is separate. > > > >> > > > >> Skimming through the series, I think you want to use the region for > > both > > > >> domheap and xenheap. Is that correct? > > > > > > > > Yes I think that would be correct, for Arm32, instead of using the > > full > > > > `ram_pages` as the initial value of `heap_pages`, we want to use the > > > > region specified in the device tree. But we are confused if this is > > the > > > > correct (or preferred) way for Arm32, so in this series we only > > > > implemented the reserved heap for Arm64. > > > > > > That's an interesting point. When I skimmed through the series on > > > Friday, my first thought was that for arm32 it would be only xenheap (so > > > all the rest of memory is domheap). > > > > > > However, Xen can allocate memory from domheap for its own purpose (e.g. > > > we don't need contiguous memory, or for page-tables). > > > > > > In a fully static environment, the domheap and xenheap are both going to > > > be quite small. It would also be somewhat difficult for a user to size > > > it. So I think, it would be easier to use the region you introduce for > > > both domheap and xenheap. > > > > > > Stefano, Bertrand, any opionions? > > > > > > On a separate topic, I think we need some documentation explaining how a > > > user can size the xenheap. How did you figure out for your setup? > > > > Not sure if I fully understand the question. I will explain in two parts: > > I tested > > this series on a dom0less (static mem) system on FVP_Base. > > (1) For configuring the system, I followed the documentation I added in > > the > > first patch in this series (docs/misc/arm/device-tree/booting.txt). The > > idea is > > adding some static mem regions under the chosen node. > > > > chosen { > > + #xen,static-mem-address-cells = <0x2>; > > + #xen,static-mem-size-cells = <0x2>; > > + xen,static-mem = <0x8 0x80000000 0x0 0x00100000 0x8 0x90000000 > > 0x0 0x08000000>; > > [...] > > } > > > > (2) For verifying this series, what I did was basically playing with the > > region size > > and number of the regions, adding printks and also see if the guests can > > boot > > as expected when I change the xenheap size. > > > > > > > > >> > > > >> Furthemore, now that we are introducing more static region, it will > > get > > > >> easier to overlap the regions by mistakes. I think we want to have > > some > > > >> logic in Xen (or outside) to ensure that none of them overlaps. Do > > you > > > >> have any plan for that? > > > > > > > > Totally agree with this idea, but before we actually implement the > > code, > > > > we would like to firstly share our thoughts on this: One option could > > be to > > > > add data structures to notes down these static memory regions when the > > > > device tree is parsed, and then we can check if they are overlapped. > > > > > > This should work. > > > > Ack. > > > > > > > > > Over > > > > the long term (and this long term option is currently not in our plan), > > > > maybe we can add something in the Xen toolstack for this usage? > > > > > > When I read "Xen toolstack", I read the tools that will run in dom0. Is > > > it what you meant? > > > > Nonono, sorry for the misleading. I mean a build time tool that can run > > on host (build machine) to generate/configure the Xen DTS for static > > allocated memory. But maybe this tool can be placed in Xen tool or it can > > be a separate tool that out of Xen's scope. > > > > Anyway, this is just an idea as we find it is not easy for users to > > configure > > so many static items manually. > > Not only for this one. As v8R64 support code also includes lots of static > allocated items, it will also encounter this user configuration issue. > So this would be a long term consideration. We can discuss this topic > after Xen V8R64 support code upstream work be done. > > And this tool does not necessarily need to be provided by the community. > Vendors that want to use Xen also can do it. IMO, it would be better if > community could provide it. Anyway let's defer this topic : ) Yes, I agree with you that it would be best if this tool was provided by the community. I'll continue the conversation on the Armv8-R64 thread. From xen-devel-bounces@lists.xenproject.org Tue Mar 01 23:39:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Mar 2022 23:39:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281866.480388 (Exim 4.92) (envelope-from ) id 1nPC5E-0005UD-QT; Tue, 01 Mar 2022 23:39:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281866.480388; Tue, 01 Mar 2022 23:39:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPC5E-0005U5-NH; Tue, 01 Mar 2022 23:39:08 +0000 Received: by outflank-mailman (input) for mailman id 281866; Tue, 01 Mar 2022 23:39:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPC5C-0005Tz-LQ for xen-devel@lists.xenproject.org; Tue, 01 Mar 2022 23:39:06 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c67c8ccf-99b8-11ec-8539-5f4723681683; Wed, 02 Mar 2022 00:39:02 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7C988B81E9D; Tue, 1 Mar 2022 23:39:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8AE21C340EE; Tue, 1 Mar 2022 23:38:59 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c67c8ccf-99b8-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646177940; bh=a2y6xAFIOwCSjNYbPnSQHd9gSgww/81hSTr9siF2xhM=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=mjU+egZsXUNWk+KWaUHasjtpGCGb09OXqlPk5qt1FNDJ02cYF9LHo1wtZdeccd43x lFCWj4Z+N0HVsokoxSXQmdYsmgNXGZx3zfXtQKkVxRYL6rFLdaIaFGftUQhTW+3rjY mzDQxGXIaHro1yiKDpd2f1BshphCCkTIXsVr2mMwLM8jOTMF/+KKVBlnbEfw61HecN y+GHBux85NrcFA97a5nqbIPS24n3/oJiEpocZU15EiPWxxXsAQjs/lU+ludlPps1MX rlENSdDMvWi7Nl593JNwZg3Z2FVS4vB7y0CGh1rU47GoZiZ7vMMNUgWHwojFQeTlmG f0X76oF1dauDw== Date: Tue, 1 Mar 2022 15:38:58 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Wei Chen cc: Stefano Stabellini , "xen-devel@lists.xenproject.org" , "julien@xen.org" , Bertrand Marquis , Penny Zheng , Henry Wang , nd Subject: RE: Proposal for Porting Xen to Armv8-R64 - DraftA In-Reply-To: Message-ID: References: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-1877311929-1646175755=:3261" Content-ID: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1877311929-1646175755=:3261 Content-Type: text/plain; CHARSET=UTF-8 Content-Transfer-Encoding: 8BIT Content-ID: On Tue, 1 Mar 2022, Wei Chen wrote: > > On Fri, 25 Feb 2022, Wei Chen wrote: > > > > Hi Wei, > > > > > > > > This is extremely exciting, thanks for the very nice summary! > > > > > > > > > > > > On Thu, 24 Feb 2022, Wei Chen wrote: > > > > > # Proposal for Porting Xen to Armv8-R64 > > > > > > > > > > This proposal will introduce the PoC work of porting Xen to Armv8- > > R64, > > > > > which includes: > > > > > - The changes of current Xen capability, like Xen build system, > > memory > > > > >   management, domain management, vCPU context switch. > > > > > - The expanded Xen capability, like static-allocation and direct-map. > > > > > > > > > > ***Notes:*** > > > > > 1. ***This proposal only covers the work of porting Xen to Armv8- > > R64*** > > > > >    ***single CPU. Xen SMP support on Armv8-R64 relates to Armv8-R*** > > > > >    ***Trusted-Frimware (TF-R). This is an external dependency,*** > > > > >    ***so we think the discussion of Xen SMP support on Armv8-R64*** > > > > >    ***should be started when single-CPU support is complete.*** > > > > > 2. ***This proposal will not touch xen-tools. In current stage,*** > > > > >    ***Xen on Armv8-R64 only support dom0less, all guests should*** > > > > >    ***be booted from device tree.*** > > > > > > > > > > ## 1. Essential Background > > > > > > > > > > ### 1.1. Armv8-R64 Profile > > > > > The Armv-R architecture profile was designed to support use cases > > that > > > > > have a high sensitivity to deterministic execution. (e.g. Fuel > > Injection, > > > > > Brake control, Drive trains, Motor control etc) > > > > > > > > > > Arm announced Armv8-R in 2013, it is the latest generation Arm > > > > architecture > > > > > targeted at the Real-time profile. It introduces virtualization at > > the > > > > highest > > > > > security level while retaining the Protected Memory System > > Architecture > > > > (PMSA) > > > > > based on a Memory Protection Unit (MPU). In 2020, Arm announced > > Cortex- > > > > R82, > > > > > which is the first Arm 64-bit Cortex-R processor based on Armv8-R64. > > > > > > > > > > - The latest Armv8-R64 document can be found here: > > > > >   [Arm Architecture Reference Manual Supplement - Armv8, for Armv8-R > > > > AArch64 architecture > > > > profile](https://developer.arm.com/documentation/ddi0600/latest/). > > > > > > > > > > - Armv-R Architecture progression: > > > > >   Armv7-R -> Armv8-R AArch32 -> Armv8 AArch64 > > > > >   The following figure is a simple comparison of "R" processors > > based on > > > > >   different Armv-R Architectures. > > > > >   ![image](https://drive.google.com/uc?export=view&id=1nE5RAXaX8zY2K > > PZ8i > > > > mBpbvIr2eqBguEB) > > > > > > > > > > - The Armv8-R architecture evolved additional features on top of > > Armv7-R: > > > > >     - An exception model that is compatible with the Armv8-A model > > > > >     - Virtualization with support for guest operating systems > > > > >         - PMSA virtualization using MPUs In EL2. > > > > > - The new features of Armv8-R64 architecture > > > > >     - Adds support for the 64-bit A64 instruction set, previously > > Armv8- > > > > R > > > > >       only supported A32. > > > > >     - Supports up to 48-bit physical addressing, previously up to > > 32-bit > > > > >       addressing was supported. > > > > >     - Optional Arm Neon technology and Advanced SIMD > > > > >     - Supports three Exception Levels (ELs) > > > > >         - Secure EL2 - The Highest Privilege, MPU only, for firmware, > > > > hypervisor > > > > >         - Secure EL1 - RichOS (MMU) or RTOS (MPU) > > > > >         - Secure EL0 - Application Workloads > > > > >     - Optionally supports Virtual Memory System Architecture at S- > > EL1/S- > > > > EL0. > > > > >       This means it's possible to run rich OS kernels - like Linux - > > > > either > > > > >       bare-metal or as a guest. > > > > > - Differences with the Armv8-A AArch64 architecture > > > > >     - Supports only a single Security state - Secure. There is not > > Non- > > > > Secure > > > > >       execution state supported. > > > > >     - EL3 is not supported, EL2 is mandatory. This means secure EL2 > > is > > > > the > > > > >       highest EL. > > > > >     - Supports the A64 ISA instruction > > > > >         - With a small set of well-defined differences > > > > >     - Provides a PMSA (Protected Memory System Architecture) based > > > > >       virtualization model. > > > > >         - As opposed to Armv8-A AArch64's VMSA based Virtualization > > > > >         - Can support address bits up to 52 if FEAT_LPA is enabled, > > > > >           otherwise 48 bits. > > > > >         - Determines the access permissions and memory attributes of > > > > >           the target PA. > > > > >         - Can implement PMSAv8-64 at EL1 and EL2 > > > > >             - Address translation flat-maps the VA to the PA for EL2 > > > > Stage 1. > > > > >             - Address translation flat-maps the VA to the PA for EL1 > > > > Stage 1. > > > > >             - Address translation flat-maps the IPA to the PA for > > EL1 > > > > Stage 2. > > > > >     - PMSA in EL1 & EL2 is configurable, VMSA in EL1 is configurable. > > > > > > > > > > ### 1.2. Xen Challenges with PMSA Virtualization > > > > > Xen is PMSA unaware Type-1 Hypervisor, it will need modifications to > > run > > > > > with an MPU and host multiple guest OSes. > > > > > > > > > > - No MMU at EL2: > > > > >     - No EL2 Stage 1 address translation > > > > >         - Xen provides fixed ARM64 virtual memory layout as basis of > > EL2 > > > > >           stage 1 address translation, which is not applicable on > > MPU > > > > system, > > > > >           where there is no virtual addressing. As a result, any > > > > operation > > > > >           involving transition from PA to VA, like ioremap, needs > > > > modification > > > > >           on MPU system. > > > > >     - Xen's run-time addresses are the same as the link time > > addresses. > > > > >         - Enable PIC (position-independent code) on a real-time > > target > > > > >           processor probably very rare. > > > > >     - Xen will need to use the EL2 MPU memory region descriptors to > > > > manage > > > > >       access permissions and attributes for accesses made by VMs at > > > > EL1/0. > > > > >         - Xen currently relies on MMU EL1 stage 2 table to manage > > these > > > > >           accesses. > > > > > - No MMU Stage 2 translation at EL1: > > > > >     - A guest doesn't have an independent guest physical address > > space > > > > >     - A guest can not reuse the current Intermediate Physical > > Address > > > > >       memory layout > > > > >     - A guest uses physical addresses to access memory and devices > > > > >     - The MPU at EL2 manages EL1 stage 2 access permissions and > > > > attributes > > > > > - There are a limited number of MPU protection regions at both EL2 > > and > > > > EL1: > > > > >     - Architecturally, the maximum number of protection regions is > > 256, > > > > >       typical implementations have 32. > > > > >     - By contrast, Xen does not need to consider the number of page > > > > table > > > > >       entries in theory when using MMU. > > > > > - The MPU protection regions at EL2 need to be shared between the > > > > hypervisor > > > > >   and the guest stage 2. > > > > >     - Requires careful consideration - may impact feature 'fullness' > > of > > > > both > > > > >       the hypervisor and the guest > > > > >     - By contrast, when using MMU, Xen has standalone P2M table for > > > > guest > > > > >       stage 2 accesses. > > > > > > > > > > ## 2. Proposed changes of Xen > > > > > ### **2.1. Changes of build system:** > > > > > > > > > > - ***Introduce new Kconfig options for Armv8-R64***: > > > > >   Unlike Armv8-A, because lack of MMU support on Armv8-R64, we may > > not > > > > >   expect one Xen binary to run on all machines. Xen images are not > > > > common > > > > >   across Armv8-R64 platforms. Xen must be re-built for different > > Armv8- > > > > R64 > > > > >   platforms. Because these platforms may have different memory > > layout > > > > and > > > > >   link address. > > > > >     - `ARM64_V8R`: > > > > >       This option enables Armv8-R profile for Arm64. Enabling this > > > > option > > > > >       results in selecting MPU. This Kconfig option is used to gate > > some > > > > >       Armv8-R64 specific code except MPU code, like some code for > > Armv8- > > > > R64 > > > > >       only system ID registers access. > > > > > > > > > >     - `ARM_MPU` > > > > >       This option enables MPU on ARMv8-R architecture. Enabling this > > > > option > > > > >       results in disabling MMU. This Kconfig option is used to gate > > some > > > > >       ARM_MPU specific code. Once when this Kconfig option has been > > > > enabled, > > > > >       the MMU relate code will not be built for Armv8-R64. The > > reason > > > > why > > > > >       not depends on runtime detection to select MMU or MPU is that, > > we > > > > don't > > > > >       think we can use one image for both Armv8-R64 and Armv8-A64. > > > > Another > > > > >       reason that we separate MPU and V8R in provision to allow to > > > > support MPU > > > > >       on 32bit Arm one day. > > > > > > > > > >     - `XEN_START_ADDRESS` > > > > >       This option allows to set the custom address at which Xen will > > be > > > > >       linked. This address must be aligned to a page size. Xen's > > run- > > > > time > > > > >       addresses are the same as the link time addresses. Different > > > > platforms > > > > >       may have differnt memory layout. This Kconfig option provides > > > > users > > > > >       the ability to select proper link addresses for their boards. > > > > >       ***Notes: Fixed link address means the Xen binary could not > > be*** > > > > >       ***relocated by EFI loader. So in current stage, Xen could > > not*** > > > > >       ***be launched as an EFI application on Armv8-R64.*** > > > > > > > > > >     - `ARM_MPU_NORMAL_MEMORY_START` and `ARM_MPU_NORMAL_MEMORY_END` > > > > >       `ARM_MPU_DEVICE_MEMORY_START` and `ARM_MPU_DEVICE_MEMORY_END` > > > > >       These Kconfig options allow to set memory regions for Xen code, > > > > data > > > > >       and device memory. Before parsing memory information from > > device > > > > tree, > > > > >       Xen will use the values that stored in these options to setup > > > > boot-time > > > > >       MPU configuration. Why we need a boot-time MPU configuration? > > > > >       1. More deterministic: Arm MPU supports background regions, > > > > >          if we don't configure the MPU regions and don't enable MPU. > > > > >          We can enable MPU background regions. But that means all > > RAM > > > > >          is RWX. Random values in RAM or maliciously embedded data > > can > > > > >          be exploited. Using these Kconfig options allow users to > > have > > > > >          a deterministic RAM area to execute code. > > > > >       2. More compatible: On some Armv8-R64 platforms, if the MPU is > > > > >          disabled, the `dc zva` instruction will make the system > > halt. > > > > >          And this instruction will be embedded in some built-in > > > > functions, > > > > >          like `memory set`. If we use `-ddont_use_dc` to rebuild GCC, > > > > >          the built-in functions will not contain `dc zva`. However, > > it > > > > is > > > > >          obviously unlikely that we will be able to recompile all > > GCC > > > > >          for ARMv8-R64. > > > > >       3. One optional idea: > > > > >           We can map `XEN_START_ADDRESS` to `XEN_START_ADDRESS + > > 2MB` or > > > > >           `XEN_START_ADDRESS` to `XEN_START_ADDRESS + image_end` for > > > > >           MPU normal memory. It's enough to support Xen run in boot > > time. > > > > > > > > I can imagine that we need to have a different Xen build for each > > > > ARMv8-R platform. Do you envision that XEN_START_ADDRESS and > > > > ARM_MPU_*_MEMORY_START/END are preconfigured based on the platform > > > > choice at build time? I don't think we want a user to provide all of > > > > those addresses by hand, right? > > > > > > Yes, this is in our TODO list. We want to reuse current arm/platforms > > and > > > Kconfig menu for Armv8-R. > > > > OK, good > > > > > > > > The next question is whether we could automatically generate > > > > XEN_START_ADDRESS and ARM_MPU_*_MEMORY_START/END based on the platform > > > > device tree at build time (at build time, not runtime). That would > > > > make things a lot easier and it is also aligned with the way Zephyr > > and > > > > other RTOSes and baremetal apps work. > > > > > > It's a considerable option. But here we may encounter some problems need > > > to be solved first: > > > 1. Does CONFIG_DTB must be selected by default on Armv8-R? Without > > firmware > > >    or bootloader (like u-boot), we have to build DTB into Xen binary. > > > > CONFIG_DTB should trigger runtime support for device tree, while here we > > are talking about build time support for device tree. It is very > > different. > > > > Just to make an example, the whole build-time device tree could be > > scanned by Makefiles and other scripts, leading to C header files > > generations, but no code in Xen to parse device tree at all. > > > > DTB ---> Makefiles/scripts ---> .h files ---> Makefiles/scripts ---> xen > > > > Yes, this is feasible. > > > > > I am not saying this is the best way to do it, I am only pointing out > > that build-time device tree does not imply run-time device tree. Also, > > it doesn't imply a DTB built-in the Xen binary (although that is also an > > option). > > > > I agree. > > > The way many baremetal OSes and RTOSes work is that they take a DTB as > > input to the build *only*. From the DTB, the build-time make system > > generates #defines and header files that are imported in C. > > > > The resulting RTOS binary doesn't need support for DTB, because all the > > right addresses have already been provided as #define by the Make > > system. > > > > I don't think we need to go to the extreme of removing DTB support from > > Xen on ARMv8-R. I am only saying that if we add build-time device tree > > support it would make it easier to support multiple boards without > > having to have platform files in Xen for each of them, and we can do > > that without any impact on runtime device tree parsing. > > > > As V8R's use cases maybe mainly focus on some real-time/critical scenarios, > this may be a better method than platform files. We don't need to maintain > the platform related definitions header files. Xen also can skip the some > platform information parsing in boot time. This will increase the boot speed > of Xen in real-time/critical scenarios. +1 > > > This > > >    can guarantee build-time DTB is the same as runtime DTB. But > > eventually, > > >    we will have firmware and bootloader before Xen launch (as Arm EBBR's > > >    requirement). In this case, we may not build DTB into Xen image. And > > >    we can't guarantee build-time DTB is the same as runtime DTB. > > > > As mentioned, if we have a build-time DTB we might not need a run-time > > DTB. Secondly, I think it is entirely reasonable to expect that the > > build-time DTB and the run-time DTB are the same. > > > > Yes, if we implement in this way, we should describe it in limitation > of v8r Xen. > > > It is the same problem with platform files: we have to assume that the > > information in the platform files matches the runtime DTB. > > > > indeed. > > > > > > 2. If build-time DTB is the same as runtime DTB, how can we determine > > >    the XEN_START_ADDRESS in DTB describe memory range? Should we always > > >    limit Xen to boot from lowest address? Or will we introduce some new > > >    DT property to specify the Xen start address? I think this DT > > property > > >    also can solve above question#1. > > > > The loading address should be automatically chosen by the build scripts. > > We can do that now with ImageBuilder [1]: it selects a 2MB-aligned > > address for each binary to load, one by one starting from a 2MB offset > > from start of memory. > > > > [1] https://gitlab.com/ViryaOS/imagebuilder/-/blob/master/scripts/uboot- > > script-gen#L390 > > > > So the build scripts can select XEN_START_ADDRESS based on the > > memory node information on the build-time device tree. And there should > > be no need to add XEN_START_ADDRESS to the runtime device tree. > > > > This is fine if there are no explicit restrictions on the platform. > Some platform may reserve some memory area for something like firmware, > But I think it's OK, in the worst case, we can hide this area from > build DTB. > > > > > > > The device tree can be given as input to the build system, and the > > > > Makefiles would take care of generating XEN_START_ADDRESS and > > > > ARM_MPU_*_MEMORY_START/END based on /memory and other interesting > > nodes. > > > > > > > > > > If we can solve above questions, yes, device tree is a good idea for > > > XEN_START_ADDRESS. For ARM_MPU_NORMAL_MEMORY_*, we can get them from > > > memory nodes, but for ARM_MPU_DEVICE_MEMORY_*, they are not easy for > > > us to scan all devices' nodes. And it's very tricky, if the memory > > > regions are interleaved. So in our current RFC code, we select to use > > > the optional idea: > > > We map `XEN_START_ADDRESS` to `XEN_START_ADDRESS + 2MB` for MPU normal > > memory. > > > But we use mpu,device-memory-section in DT for MPU device memory. > > > > Keep in mind that we are talking about build-time scripts: it doesn't > > matter if they are slow. We can scan the build-time dtb as many time as > > needed and generate ARM_MPU_DEVICE_MEMORY_* as appropriate. It might > > make "make xen" slower but runtime will be unaffected. > > > > So, I don't think this is a problem. > > > > OK. > > > > > > > > - ***Define new system registers for compilers***: > > > > >   Armv8-R64 is based on Armv8.4. That means we will use some Armv8.4 > > > > >   specific system registers. As Armv8-R64 only have secure state, so > > > > >   at least, `VSTCR_EL2` and `VSCTLR_EL2` will be used for Xen. And > > the > > > > >   first GCC version that supports Armv8.4 is GCC 8.1. In addition to > > > > >   these, PMSA of Armv8-R64 introduced lots of MPU related system > > > > registers: > > > > >   `PRBAR_ELx`, `PRBARx_ELx`, `PRLAR_ELx`, `PRLARx_ELx`, `PRENR_ELx` > > and > > > > >   `MPUIR_ELx`. But the first GCC version to support these system > > > > registers > > > > >   is GCC 11. So we have two ways to make compilers to work properly > > with > > > > >   these system registers. > > > > >   1. Bump GCC version to GCC 11. > > > > >      The pros of this method is that, we don't need to encode these > > > > >      system registers in macros by ourselves. But the cons are that, > > > > >      we have to update Makefiles to support GCC 11 for Armv8-R64. > > > > >      1.1. Check the GCC version 11 for Armv8-R64. > > > > >      1.2. Add march=armv8r to CFLAGS for Armv8-R64. > > > > >      1.3. Solve the confliction of march=armv8r and mcpu=generic > > > > >     These changes will affect common Makefiles, not only Arm > > Makefiles. > > > > >     And GCC 11 is new, lots of toolchains and Distro haven't > > supported > > > > it. > > > > > > > > > >   2. Encode new system registers in macros ***(preferred)*** > > > > >         ``` > > > > >         /* Virtualization Secure Translation Control Register */ > > > > >         #define VSTCR_EL2  S3_4_C2_C6_2 > > > > >         /* Virtualization System Control Register */ > > > > >         #define VSCTLR_EL2 S3_4_C2_C0_0 > > > > >         /* EL1 MPU Protection Region Base Address Register encode */ > > > > >         #define PRBAR_EL1  S3_0_C6_C8_0 > > > > >         ... > > > > >         /* EL2 MPU Protection Region Base Address Register encode */ > > > > >         #define PRBAR_EL2  S3_4_C6_C8_0 > > > > >         ... > > > > >         ``` > > > > >      If we encode all above system registers, we don't need to bump > > GCC > > > > >      version. And the common CFLAGS Xen is using still can be > > applied to > > > > >      Armv8-R64. We don't need to modify Makefiles to add specific > > CFLAGS. > > > > > > > > I think that's fine and we did something similar with the original > > ARMv7-A > > > > port if I remember correctly. > > > > > > > > > > > > > ### **2.2. Changes of the initialization process** > > > > > In general, we still expect Armv8-R64 and Armv8-A64 to have a > > consistent > > > > > initialization process. In addition to some architecture differences, > > > > there > > > > > is no more than reusable code that we will distinguish through > > > > CONFIG_ARM_MPU > > > > > or CONFIG_ARM64_V8R. We want most of the initialization code to be > > > > reusable > > > > > between Armv8-R64 and Armv8-A64. > > > > > > > > +1 > > > > > > > > > > > > > - We will reuse the original head.s and setup.c of Arm. But replace > > the > > > > >   MMU and page table operations in these files with configuration > > > > operations > > > > >   for MPU and MPU regions. > > > > > > > > > > - We provide a boot-time MPU configuration. This MPU configuration > > will > > > > >   support Xen to finish its initialization. And this boot-time MPU > > > > >   configuration will record the memory regions that will be parsed > > from > > > > >   device tree. > > > > > > > > > >   In the end of Xen initialization, we will use a runtime MPU > > > > configuration > > > > >   to replace boot-time MPU configuration. The runtime MPU > > configuration > > > > will > > > > >   merge and reorder memory regions to save more MPU regions for > > guests. > > > > >   ![img](https://drive.google.com/uc?export=view&id=1wTFyK2XfU3lTlH1 > > PqRD > > > > oacQVTwUtWIGU) > > > > > > > > > > - Defer system unpausing domain. > > > > >   When Xen initialization is about to end, Xen unpause guests > > created > > > > >   during initialization. But this will cause some issues. The > > unpause > > > > >   action occurs before free_init_memory, however the runtime MPU > > > > configuration > > > > >   is built after free_init_memory. > > > > > > > > > >   So if the unpaused guests start executing the context switch at > > this > > > > >   point, then its MPU context will base on the boot-time MPU > > > > configuration. > > > > >   Probably it will be inconsistent with runtime MPU configuration, > > this > > > > >   will cause unexpected problems (This may not happen in a single > > core > > > > >   system, but on SMP systems, this problem is foreseeable, so we > > hope to > > > > >   solve it at the beginning). > > > > > > > > > > ### **2.3. Changes to reduce memory fragmentation** > > > > > > > > > > In general, memory in Xen system can be classified to 4 classes: > > > > > `image sections`, `heap sections`, `guest RAM`, `boot modules (guest > > > > Kernel, > > > > > initrd and dtb)` > > > > > > > > > > Currently, Xen doesn't have any restriction for users how to > > allocate > > > > > memory for different classes. That means users can place boot > > modules > > > > > anywhere, can reserve Xen heap memory anywhere and can allocate > > guest > > > > > memory anywhere. > > > > > > > > > > In a VMSA system, this would not be too much of a problem, since the > > > > > MMU can manage memory at a granularity of 4KB after all. But in a > > > > > PMSA system, this will be a big problem. On Armv8-R64, the max MPU > > > > > protection regions number has been limited to 256. But in typical > > > > > processor implementations, few processors will design more than 32 > > > > > MPU protection regions. Add in the fact that Xen shares MPU > > protection > > > > > regions with guest's EL1 Stage 2. It becomes even more important > > > > > to properly plan the use of MPU protection regions. > > > > > > > > > > - An ideal of memory usage layout restriction: > > > > > ![img](https://drive.google.com/uc?export=view&id=1kirOL0Tx2aAypTtd3 > > kXAt > > > > d75XtrngcnW) > > > > > 1. Reserve proper MPU regions for Xen image (code, rodata and data + > > > > bss). > > > > > 2. Reserve one MPU region for boot modules. > > > > >    That means the placement of all boot modules, include guest > > kernel, > > > > >    initrd and dtb, will be limited to this MPU region protected area. > > > > > 3. Reserve one or more MPU regions for Xen heap. > > > > >    On Armv8-R64, the guest memory is predefined in device tree, it > > will > > > > >    not be allocated from heap. Unlike Armv8-A64, we will not move > > all > > > > >    free memory to heap. We want Xen heap is dertermistic too, so Xen > > on > > > > >    Armv8-R64 also rely on Xen static heap feature. The memory for > > Xen > > > > >    heap will be defined in tree too. Considering that physical > > memory > > > > >    can also be discontinuous, one or more MPU protection regions > > needs > > > > >    to be reserved for Xen HEAP. > > > > > 4. If we name above used MPU protection regions PART_A, and name > > left > > > > >    MPU protection regions PART_B: > > > > >    4.1. In hypervisor context, Xen will map left RAM and devices to > > > > PART_B. > > > > >         This will give Xen the ability to access whole memory. > > > > >    4.2. In guest context, Xen will create EL1 stage 2 mapping in > > PART_B. > > > > >         In this case, Xen just need to update PART_B in context > > switch, > > > > >         but keep PART_A as fixed. > > > > > > > > I think that the memory layout and restrictions that you wrote above > > > > make sense. I have some comments on the way they are represented in > > > > device tree, but that's different. > > > > > > > > > > > > > ***Notes: Static allocation will be mandatory on MPU based > > systems*** > > > > > > > > > > **A sample device tree of memory layout restriction**: > > > > > ``` > > > > > chosen { > > > > >     ... > > > > >     /* > > > > >      * Define a section to place boot modules, > > > > >      * all boot modules must be placed in this section. > > > > >      */ > > > > >     mpu,boot-module-section = <0x10000000 0x10000000>; > > > > >     /* > > > > >      * Define a section to cover all guest RAM. All guest RAM must > > be > > > > located > > > > >      * within this section. The pros is that, in best case, we can > > only > > > > have > > > > >      * one MPU protection region to map all guest RAM for Xen. > > > > >      */ > > > > >     mpu,guest-memory-section = <0x20000000 0x30000000>; > > > > >     /* > > > > >      * Define a memory section that can cover all device memory that > > > > >      * will be used in Xen. > > > > >      */ > > > > >     mpu,device-memory-section = <0x80000000 0x7ffff000>; > > > > >     /* Define a section for Xen heap */ > > > > >     xen,static-mem = <0x50000000 0x20000000>; > > > > > > > > As mentioned above, I understand the need for these sections, but why > > do > > > > we need to describe them in device tree at all? Could Xen select them > > by > > > > itself during boot? > > > > > > I think without some inputs, Xen could not do this or will do it in some > > > assumption. For example, assume the first the boot-module-section > > determined > > > by lowest address and highest address of all modules. And the same for > > > guest-memory-section, calculated from all guest allocated memory regions. > > > > Right, I think that the mpu,boot-module-section should be generated by a > > set of scripts like ImageBuilder. Something with a list of all the > > binaries that need to be loaded and also the DTB at build-time. > > Something like ImageBuilder would have the ability to add > > "mpu,boot-module-section" to device tree automatically and automatically > > choose a good address for it. > > > > As an example, today ImageBuilder takes as input a config file like the > > following: > > > > --- > > MEMORY_START="0x0" > > MEMORY_END="0x80000000" > > > > DEVICE_TREE="4.16-2022.1/mpsoc.dtb" > > XEN="4.16-2022.1/xen" > > DOM0_KERNEL="4.16-2022.1/Image-dom0-5.16" > > DOM0_RAMDISK="4.16-2022.1/xen-rootfs.cpio.gz" > > > > NUM_DOMUS=1 > > DOMU_KERNEL[0]="4.16-2022.1/Image-domU" > > DOMU_RAMDISK[0]="4.16-2022.1/initrd.cpio" > > DOMU_PASSTHROUGH_DTB[0]="4.16-2022.1/passthrough-example-sram.dtb" > > --- > > > > And generates a U-Boot boot.scr script with: > > - load addresses for each binary > > - commands to edit the DTB to add those addresses to device tree (e.g. > > dom0less kernels addresses) > > > > ImageBuilder can also modify the DTB at build time instead (instead of > > doing it from boot.scr.) See FDTEDIT. > > > > I am not saying we should use ImageBuilder, but it sounds like we need > > something similar. > > > > > > Yes, exactly. I have comment on Henry's stack heap RFC to said we need > a similar tool. Now, here it is : ) Ahah yes :-) Initially I wrote ImageBuilder because people kept sending me emails to ask me for help with dom0less and almost always it was an address loading error. I would be happy to turn ImageBuilder into something useful for ARMv8-R as well and add more maintainers from ARM and other companies. > > > > If not, and considering that we have to generate > > > > ARM_MPU_*_MEMORY_START/END anyway at build time, would it make sense > > to > > > > also generate mpu,guest-memory-section, xen,static-mem, etc. at build > > > > time rather than passing it via device tree to Xen at runtime? > > > > > > > > > > Did you mean we still add these information in device tree, but for > > build > > > time only. In runtime we don't parse them? > > > > Yes, something like that, but see below. > > > > > > > > What's the value of doing ARM_MPU_*_MEMORY_START/END at build time and > > > > everything else at runtime? > > > > > > ARM_MPU_*_MEMORY_START/END is defined by platform. But other things are > > > users customized. They can change their usage without rebuild the image. > > > > Good point. > > > > We don't want to have to rebuild Xen if the user updated a guest kernel, > > resulting in a larger boot-module-section. > > > > So I think it makes sense that "mpu,boot-module-section" is generated by > > the scripts (e.g. ImageBuilder) at build time, and Xen reads the > > property at boot from the runtime device tree. > > > > I think we need to divide the information into two groups: > > > > > > # Group1: board info > > > > This information is platform specific and it is not meant to change > > depending on the VM configuration. Ideally, we build Xen for a platform > > once, then we can use the same Xen binary together with any combination > > of dom0/domU kernels and ramdisks. > > > > This kind of information doesn't need to be exposed to the runtime > > device tree. But we can still use a build-time device tree to generate > > the addresses if it is convenient. > > > > XEN_START_ADDRESS, ARM_MPU_DEVICE_MEMORY_*, and ARM_MPU_NORMAL_MEMORY_* > > seem to be part of this group. > > > > Yes. > > > > > # Group2: boot configuration > > > > This information is about the specific set of binaries and VMs that we > > need to boot. It is conceptually similar to the dom0less device tree > > nodes that we already have. If we change one of the VM binaries, we > > likely have to refresh the information here. > > > > "mpu,boot-module-section" probably belongs to this group (unless we find > > a way to define "mpu,boot-module-section" generically so that we don't > > need to change it any time the set of boot modules change.) > > > > > > I agree. > > > > > It looks like we are forced to have the sections definitions at build > > > > time because we need them before we can parse device tree. In that > > case, > > > > we might as well define all the sections at build time. > > > > > > > > But I think it would be even better if Xen could automatically choose > > > > xen,static-mem, mpu,guest-memory-section, etc. on its own based on the > > > > regular device tree information (/memory, /amba, etc.), without any > > need > > > > for explicitly describing each range with these new properties. > > > > > > > > > > for mpu,guest-memory-section, with the limitations: no other usage > > between > > > different guest' memory nodes, this is OK. But for xen,static-mem (heap), > > > we just want everything on a MPU system is dertermistic. But, of course > > Xen > > > can select left memory for heap without static-mem. > > > > It is good that you think they can be chosen by Xen. > > > > Differently from "boot-module-section", which has to do with the boot > > modules selected by the user for a specific execution, > > guest-memory-section and static-mem are Xen specific memory > > policies/allocations. > > > > A user wouldn't know how to fill them in. And I worry that even a script > > But users should know it, because static-mem for guest must be allocated > in this range. And users take the responsibility to set the DomU's > static allocate memory ranges. Let me premise that my goal is to avoid having many users reporting errors to xen-devel and xen-users when actually it is just a wrong choice of addresses. I think we need to make a distinction between addresses for the boot modules, e.g. addresses where to load xen, the dom0/U kernel, dom0/U ramdisk in memory at boot time, and VM static memory addresses. The boot modules addresses are particularly difficult to fill in because they are many and a small update in one of the modules could invalidate all the other addresses. This is why I ended up writing ImageBuilder. Since them, I received several emails from users thanking me for ImageBuilder :-) The static VM memory addresses (xen,static-mem) should be a bit easier to fill in correctly. They are meant to be chosen once, and it shouldn't happen that an update on a kernel forces the user to change all the VM static memory addresses. Also, I know that some users actually want to be able to choose the domU addresses by hand because they have specific needs. So it is good that we can let the user choose the addresses if they want to. With all of that said, I do think that many users won't have an opinion on the VM static memory addresses and won't know how to choose them. It would be error prone to let them try to fill them in by hand. So I was already planning on adding support to ImageBuilder to automatically generate xen,static-mem for dom0less domains. Going back to this specific discussion about boot-module-section: I can see now that, given xen,static-mem is chosen by ImageBuilder (or similar) and not Xen, then it makes sense to have ImageBuilder (or similar) also generate boot-module-section. > > like ImageBuilder wouldn't be the best place to pick these values -- > > they seem too "important" to leave to a script. > > > > But it seems possible to choose the values in Xen: > > - Xen knows ARM_MPU_NORMAL_MEMORY_* because it was defined at build time > > - Xen reads boot-module-section from device tree > > > > It should be possible at this point for Xen to pick the best values for > > guest-memory-section and static-mem based on the memory available. > > > > How Xen to pick? Does it mean in static allocation DomU DT node, we just > need a size, but don't require a start address for static-mem? Yes the idea was that the user would only provide the size (e.g. DOMU_STATIC_MEM[1]=1024) and the addresses would be automatically calculated. But I didn't mean to change the existing xen,static-mem device tree bindings. So it is best if the xen,static-mem addresses generation is done by ImageBuilder (or similar tool) instead of Xen. Sorry for the confusion! > > > > >     domU1 { > > > > >         ... > > > > >         #xen,static-mem-address-cells = <0x01>; > > > > >         #xen,static-mem-size-cells = <0x01>; > > > > >         /* Statically allocated guest memory, within mpu,guest- > > memory- > > > > section */ > > > > >         xen,static-mem = <0x30000000 0x1f000000>; > > > > > > > > > >         module@11000000 { > > > > >             compatible = "multiboot,kernel\0multiboot,module"; > > > > >             /* Boot module address, within mpu,boot-module-section > > */ > > > > >             reg = <0x11000000 0x3000000>; > > > > >             ... > > > > >         }; > > > > > > > > > >         module@10FF0000 { > > > > >                 compatible = "multiboot,device- > > tree\0multiboot,module"; > > > > >                 /* Boot module address, within mpu,boot-module- > > section > > > > */ > > > > >                 reg = <0x10ff0000 0x10000>; > > > > >                 ... > > > > >         }; > > > > >     }; > > > > > }; > > > > > ``` --8323329-1877311929-1646175755=:3261-- From xen-devel-bounces@lists.xenproject.org Wed Mar 02 00:25:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 00:25:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281875.480399 (Exim 4.92) (envelope-from ) id 1nPCnc-0003Qr-T7; Wed, 02 Mar 2022 00:25:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281875.480399; Wed, 02 Mar 2022 00:25:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPCnc-0003Qk-QA; Wed, 02 Mar 2022 00:25:00 +0000 Received: by outflank-mailman (input) for mailman id 281875; Wed, 02 Mar 2022 00:24:59 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPCnb-0003Qa-By; Wed, 02 Mar 2022 00:24:59 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPCnb-0003vC-9S; Wed, 02 Mar 2022 00:24:59 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPCna-0003ej-VK; Wed, 02 Mar 2022 00:24:59 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nPCna-0001YS-RR; Wed, 02 Mar 2022 00:24:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=DWcNlXO5cdDRXdKVB8o9BAHAzbr0g1U6ZUk8zk+LEJc=; b=JUw0BJAWbDCj6UN+VY3zsmmE+K 60zd/EGS9wgsMmgpNqaL244giZFwvF94CR3fyn/D25iIXzT0OoJr+Pb7Od0tjx5eXYJWmn+u+SbeZ KRh3Uwo2iuwauLL7sEzuc13fHd+hWo0A5AttA1r9DZBHXV/Z0r4idI90jeTR9sXwsRIw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 168308: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=497ac7b6d7f9750f48f137db244931a5728b1968 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Wed, 02 Mar 2022 00:24:58 +0000 flight 168308 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/168308/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 497ac7b6d7f9750f48f137db244931a5728b1968 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 1 days Failing since 168258 2022-03-01 01:55:31 Z 0 days 10 attempts Testing same since 168262 2022-03-01 04:10:26 Z 0 days 9 attempts ------------------------------------------------------------ People who touched revisions under test: Guomin Jiang Jason Jason Lou jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 497ac7b6d7f9750f48f137db244931a5728b1968 Author: Guomin Jiang Date: Sat Jan 29 16:28:02 2022 +0800 UefiPayloadPkg/PayloadLoaderPeim: Use INT64 as input parameter REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3818 It will have some potential issue when memory larger than 2G because the high memory address will be fill with 0xFFFFFFFF when do the operation of INTN + INT64 but it is 32 bit normal data in fact. Should use same data type INT64 + INT64. V3: 1. Use INT64 as input parameter because all date type is 64 bit V2: 1. Force the data type to UINTN to avoid high dword be filled with 0xFFFFFFFF 2. Keep INTN because the offset may postive or negative. Reviewed-by: Guo Dong Reviewed-by: Ray Ni Signed-off-by: Guomin Jiang commit 6a890db161cd6d378bec3499a1e774db3f5a27a7 Author: Jason Date: Mon Jan 10 22:30:29 2022 +0800 BaseTools: Upgrade the version of NASM tool REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Upgrade the version of NASM tool to avoid compilation errors when compiling NASM code change. Signed-off-by: Jason Lou Cc: Bob Feng Cc: Liming Gao Reviewed-by: Yuwei Chen commit bbaa00dd01ed0df30e43a5a89fd2b0433d858b73 Author: Jason Date: Mon Jan 10 22:05:47 2022 +0800 MdePkg: Remove the macro definitions regarding Opcode. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Remove the macro definitions regarding Opcode because new version of NASM tool(e.g. v2.15.05) supports the corresponding instructions. Note: This patch need to be merged after other NASM code change to avoid compilation errors. Signed-off-by: Jason Lou Cc: Michael D Kinney Reviewed-by: Liming Gao Cc: Zhiguang Liu commit 2aa107c0aa2e1375651867c8df1b81ff64b67fce Author: Jason Date: Mon Jan 10 22:01:18 2022 +0800 UefiCpuPkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Reviewed-by: Ray Ni Cc: Eric Dong Cc: Laszlo Ersek Cc: Rahul Kumar commit 7bc8b1d9f412507d579f21ea9af56fced81e7827 Author: Jason Date: Mon Jan 10 21:52:52 2022 +0800 SourceLevelDebugPkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Reviewed-by: Hao A Wu commit d3febfd9ade35dc552df6b3607c2b15d26b82867 Author: Jason Date: Mon Jan 10 21:46:27 2022 +0800 MdePkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Cc: Michael D Kinney Reviewed-by: Liming Gao Cc: Zhiguang Liu commit 84338c0d498555f860a480693ee8647a1795fba3 Author: Jason Date: Mon Jan 10 21:04:09 2022 +0800 MdeModulePkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Reviewed-by: Ray Ni Cc: Dandan Bi Reviewed-by: Liming Gao From xen-devel-bounces@lists.xenproject.org Wed Mar 02 00:46:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 00:46:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281888.480416 (Exim 4.92) (envelope-from ) id 1nPD7z-0006Db-OP; Wed, 02 Mar 2022 00:46:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281888.480416; Wed, 02 Mar 2022 00:46:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPD7z-0006DU-LB; Wed, 02 Mar 2022 00:46:03 +0000 Received: by outflank-mailman (input) for mailman id 281888; Wed, 02 Mar 2022 00:46:03 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPD7z-0006DK-6a; Wed, 02 Mar 2022 00:46:03 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPD7z-0004Hw-4s; Wed, 02 Mar 2022 00:46:03 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPD7y-0004ec-Ue; Wed, 02 Mar 2022 00:46:02 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nPD7y-0005vJ-U7; Wed, 02 Mar 2022 00:46:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=UEP/pFQKm4YoioPfHMNyx6W1gGO8IZ4VvRRxjJX6Frs=; b=FWRHgVU7280iBB8d0k1Szor3mH iypdPNVaGxni0pIEfP4yEnO/hiaIDzhXp/50Y9mtI+vGB5XWEuoOFqz7K2RTsU50tHD12Qs9us76j vCiQf3YhUQGgTvh8P69TTW2EdY9zt6UCwcyShNF1Ls2FwNMDI7oUA6Swf0JHHsHowiPw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 168305: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=0c18fb76323bfb13615b6f13c98767face2d8097 X-Osstest-Versions-That: xen=6e3f36387de566b09aa4145ea0e3bfe4814d68b4 From: osstest service owner Date: Wed, 02 Mar 2022 00:46:02 +0000 flight 168305 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/168305/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 0c18fb76323bfb13615b6f13c98767face2d8097 baseline version: xen 6e3f36387de566b09aa4145ea0e3bfe4814d68b4 Last test of basis 168296 2022-03-01 14:03:25 Z 0 days Testing same since 168305 2022-03-01 20:01:41 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Julien Grall Julien Grall jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 6e3f36387d..0c18fb7632 0c18fb76323bfb13615b6f13c98767face2d8097 -> smoke From xen-devel-bounces@lists.xenproject.org Wed Mar 02 01:17:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 01:17:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281899.480427 (Exim 4.92) (envelope-from ) id 1nPDci-0006Af-BB; Wed, 02 Mar 2022 01:17:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281899.480427; Wed, 02 Mar 2022 01:17:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPDci-0006AY-6w; Wed, 02 Mar 2022 01:17:48 +0000 Received: by outflank-mailman (input) for mailman id 281899; Wed, 02 Mar 2022 01:17:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPDch-0006AO-DJ; Wed, 02 Mar 2022 01:17:47 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPDch-0000Dg-8T; Wed, 02 Mar 2022 01:17:47 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPDcg-0005kL-QH; Wed, 02 Mar 2022 01:17:46 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nPDcg-0006Im-Pn; Wed, 02 Mar 2022 01:17:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=yjyJK1PrzYGecq6CgYc2OLageYUfWoW0auj7hMMF7RM=; b=QIE/Fx1xU3mdo4T59muJJn2Agm 5gYujPd1hI7HqVAbo9xGAqKXFrp3c3qfRtOayh2aSv8eDavKIyXEArzHFexmCc+qBRjobvW5MOsss FSdZUH6q6zBniPJL3i0nVLe8/pBEke0W1/0x8M3Ovomx8srnCGmkoT3+tZSatgr6E1qk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 168312: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=497ac7b6d7f9750f48f137db244931a5728b1968 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Wed, 02 Mar 2022 01:17:46 +0000 flight 168312 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/168312/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 497ac7b6d7f9750f48f137db244931a5728b1968 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 1 days Failing since 168258 2022-03-01 01:55:31 Z 0 days 11 attempts Testing same since 168262 2022-03-01 04:10:26 Z 0 days 10 attempts ------------------------------------------------------------ People who touched revisions under test: Guomin Jiang Jason Jason Lou jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 497ac7b6d7f9750f48f137db244931a5728b1968 Author: Guomin Jiang Date: Sat Jan 29 16:28:02 2022 +0800 UefiPayloadPkg/PayloadLoaderPeim: Use INT64 as input parameter REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3818 It will have some potential issue when memory larger than 2G because the high memory address will be fill with 0xFFFFFFFF when do the operation of INTN + INT64 but it is 32 bit normal data in fact. Should use same data type INT64 + INT64. V3: 1. Use INT64 as input parameter because all date type is 64 bit V2: 1. Force the data type to UINTN to avoid high dword be filled with 0xFFFFFFFF 2. Keep INTN because the offset may postive or negative. Reviewed-by: Guo Dong Reviewed-by: Ray Ni Signed-off-by: Guomin Jiang commit 6a890db161cd6d378bec3499a1e774db3f5a27a7 Author: Jason Date: Mon Jan 10 22:30:29 2022 +0800 BaseTools: Upgrade the version of NASM tool REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Upgrade the version of NASM tool to avoid compilation errors when compiling NASM code change. Signed-off-by: Jason Lou Cc: Bob Feng Cc: Liming Gao Reviewed-by: Yuwei Chen commit bbaa00dd01ed0df30e43a5a89fd2b0433d858b73 Author: Jason Date: Mon Jan 10 22:05:47 2022 +0800 MdePkg: Remove the macro definitions regarding Opcode. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Remove the macro definitions regarding Opcode because new version of NASM tool(e.g. v2.15.05) supports the corresponding instructions. Note: This patch need to be merged after other NASM code change to avoid compilation errors. Signed-off-by: Jason Lou Cc: Michael D Kinney Reviewed-by: Liming Gao Cc: Zhiguang Liu commit 2aa107c0aa2e1375651867c8df1b81ff64b67fce Author: Jason Date: Mon Jan 10 22:01:18 2022 +0800 UefiCpuPkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Reviewed-by: Ray Ni Cc: Eric Dong Cc: Laszlo Ersek Cc: Rahul Kumar commit 7bc8b1d9f412507d579f21ea9af56fced81e7827 Author: Jason Date: Mon Jan 10 21:52:52 2022 +0800 SourceLevelDebugPkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Reviewed-by: Hao A Wu commit d3febfd9ade35dc552df6b3607c2b15d26b82867 Author: Jason Date: Mon Jan 10 21:46:27 2022 +0800 MdePkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Cc: Michael D Kinney Reviewed-by: Liming Gao Cc: Zhiguang Liu commit 84338c0d498555f860a480693ee8647a1795fba3 Author: Jason Date: Mon Jan 10 21:04:09 2022 +0800 MdeModulePkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Reviewed-by: Ray Ni Cc: Dandan Bi Reviewed-by: Liming Gao From xen-devel-bounces@lists.xenproject.org Wed Mar 02 02:49:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 02:49:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281910.480438 (Exim 4.92) (envelope-from ) id 1nPF3W-0008R2-3n; Wed, 02 Mar 2022 02:49:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281910.480438; Wed, 02 Mar 2022 02:49:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPF3V-0008Qu-Ub; Wed, 02 Mar 2022 02:49:33 +0000 Received: by outflank-mailman (input) for mailman id 281910; Wed, 02 Mar 2022 02:49:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPF3U-0008Qk-7Q; Wed, 02 Mar 2022 02:49:32 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPF3U-00029p-46; Wed, 02 Mar 2022 02:49:32 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPF3T-0001WF-Q9; Wed, 02 Mar 2022 02:49:31 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nPF3K-0001Mt-Jy; Wed, 02 Mar 2022 02:49:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Z7jZaQcnJb5IuuoaG1khQGdMVWhxhEie6s1u3EAomwc=; b=iQdGIvFE/2j4cmUQ9AvVl8Wt/M lk7vZIjjbzIwS3Z4A2WjtfbUSFtXR4YQpTJQ8adl4wrA2LSVejtwI2QM7ET9R2DKaWlRt5walmcNI vvwV5kGEOzU+PcoGMTkp5OmexrbItVtN51X4CoFTGfWLK3QdW3KZ+onqWeKylzFYHePI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 168314: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=497ac7b6d7f9750f48f137db244931a5728b1968 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Wed, 02 Mar 2022 02:49:22 +0000 flight 168314 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/168314/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 497ac7b6d7f9750f48f137db244931a5728b1968 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 1 days Failing since 168258 2022-03-01 01:55:31 Z 1 days 12 attempts Testing same since 168262 2022-03-01 04:10:26 Z 0 days 11 attempts ------------------------------------------------------------ People who touched revisions under test: Guomin Jiang Jason Jason Lou jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 497ac7b6d7f9750f48f137db244931a5728b1968 Author: Guomin Jiang Date: Sat Jan 29 16:28:02 2022 +0800 UefiPayloadPkg/PayloadLoaderPeim: Use INT64 as input parameter REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3818 It will have some potential issue when memory larger than 2G because the high memory address will be fill with 0xFFFFFFFF when do the operation of INTN + INT64 but it is 32 bit normal data in fact. Should use same data type INT64 + INT64. V3: 1. Use INT64 as input parameter because all date type is 64 bit V2: 1. Force the data type to UINTN to avoid high dword be filled with 0xFFFFFFFF 2. Keep INTN because the offset may postive or negative. Reviewed-by: Guo Dong Reviewed-by: Ray Ni Signed-off-by: Guomin Jiang commit 6a890db161cd6d378bec3499a1e774db3f5a27a7 Author: Jason Date: Mon Jan 10 22:30:29 2022 +0800 BaseTools: Upgrade the version of NASM tool REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Upgrade the version of NASM tool to avoid compilation errors when compiling NASM code change. Signed-off-by: Jason Lou Cc: Bob Feng Cc: Liming Gao Reviewed-by: Yuwei Chen commit bbaa00dd01ed0df30e43a5a89fd2b0433d858b73 Author: Jason Date: Mon Jan 10 22:05:47 2022 +0800 MdePkg: Remove the macro definitions regarding Opcode. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Remove the macro definitions regarding Opcode because new version of NASM tool(e.g. v2.15.05) supports the corresponding instructions. Note: This patch need to be merged after other NASM code change to avoid compilation errors. Signed-off-by: Jason Lou Cc: Michael D Kinney Reviewed-by: Liming Gao Cc: Zhiguang Liu commit 2aa107c0aa2e1375651867c8df1b81ff64b67fce Author: Jason Date: Mon Jan 10 22:01:18 2022 +0800 UefiCpuPkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Reviewed-by: Ray Ni Cc: Eric Dong Cc: Laszlo Ersek Cc: Rahul Kumar commit 7bc8b1d9f412507d579f21ea9af56fced81e7827 Author: Jason Date: Mon Jan 10 21:52:52 2022 +0800 SourceLevelDebugPkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Reviewed-by: Hao A Wu commit d3febfd9ade35dc552df6b3607c2b15d26b82867 Author: Jason Date: Mon Jan 10 21:46:27 2022 +0800 MdePkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Cc: Michael D Kinney Reviewed-by: Liming Gao Cc: Zhiguang Liu commit 84338c0d498555f860a480693ee8647a1795fba3 Author: Jason Date: Mon Jan 10 21:04:09 2022 +0800 MdeModulePkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Reviewed-by: Ray Ni Cc: Dandan Bi Reviewed-by: Liming Gao From xen-devel-bounces@lists.xenproject.org Wed Mar 02 02:56:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 02:56:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281925.480455 (Exim 4.92) (envelope-from ) id 1nPF9g-0001X1-VH; Wed, 02 Mar 2022 02:55:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281925.480455; Wed, 02 Mar 2022 02:55:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPF9g-0001Wu-S1; Wed, 02 Mar 2022 02:55:56 +0000 Received: by outflank-mailman (input) for mailman id 281925; Wed, 02 Mar 2022 02:55:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPF9g-0001Wo-Ao for xen-devel@lists.xenproject.org; Wed, 02 Mar 2022 02:55:56 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 45bd9cdd-99d4-11ec-8eba-a37418f5ba1a; Wed, 02 Mar 2022 03:55:53 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B8666B81D71; Wed, 2 Mar 2022 02:55:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5CC18C340EE; Wed, 2 Mar 2022 02:55:48 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 45bd9cdd-99d4-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646189749; bh=+9ELN9vs62ISIoM03rj0HMh2JUdciOzBOCDhQI6QFPc=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=Yz8AyEKVJasXFNiZ8rmTZeX76EMZyQ9CVYri7P9h7/S6WH9S/TTWf9kmuC58xl0bP mus56AWm7bIQY4S0dK37bXzdJOBeuDInue9pq0+mJyGOgcGtQIEnZx+s+LXo23HRDZ /PEi9o40pO8LM0kcvJs9PBB1dZRgZszDafnAf7iGlSdzQZcvH2k+svZKIJTdAs+/KZ hXm39T9r/qhKfL/Pz2mDOxaOXNjAFXBV3zv0efwV5hO5pCIVKQk+xft7XixOHGVUnB ZdypAI3gDK0oWKrimsGXDtsXlzWMDbUxd3xqxDtM+7nBlpjzO31ACN1Qpfy1nPC0WO 6tKIbg7mY2UFw== Date: Tue, 1 Mar 2022 18:55:47 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Christoph Hellwig cc: iommu@lists.linux-foundation.org, x86@kernel.org, Anshuman Khandual , Tom Lendacky , Konrad Rzeszutek Wilk , Stefano Stabellini , Boris Ostrovsky , Juergen Gross , Joerg Roedel , David Woodhouse , Lu Baolu , Robin Murphy , linux-arm-kernel@lists.infradead.org, xen-devel@lists.xenproject.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-hyperv@vger.kernel.org, tboot-devel@lists.sourceforge.net, linux-pci@vger.kernel.org Subject: Re: [PATCH 11/12] swiotlb: merge swiotlb-xen initialization into swiotlb In-Reply-To: <20220301105311.885699-12-hch@lst.de> Message-ID: References: <20220301105311.885699-1-hch@lst.de> <20220301105311.885699-12-hch@lst.de> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 1 Mar 2022, Christoph Hellwig wrote: > Allow to pass a remap argument to the swiotlb initialization functions > to handle the Xen/x86 remap case. ARM/ARM64 never did any remapping > from xen_swiotlb_fixup, so we don't even need that quirk. > > Signed-off-by: Christoph Hellwig > --- > arch/arm/xen/mm.c | 23 +++--- > arch/x86/include/asm/xen/page.h | 5 -- > arch/x86/kernel/pci-dma.c | 19 +++-- > arch/x86/pci/sta2x11-fixup.c | 2 +- > drivers/xen/swiotlb-xen.c | 128 +------------------------------- > include/linux/swiotlb.h | 7 +- > include/xen/arm/page.h | 1 - > include/xen/swiotlb-xen.h | 8 +- > kernel/dma/swiotlb.c | 120 +++++++++++++++--------------- > 9 files changed, 96 insertions(+), 217 deletions(-) > > diff --git a/arch/arm/xen/mm.c b/arch/arm/xen/mm.c > index a7e54a087b802..58b40f87617d3 100644 > --- a/arch/arm/xen/mm.c > +++ b/arch/arm/xen/mm.c > @@ -23,22 +23,20 @@ > #include > #include > > -unsigned long xen_get_swiotlb_free_pages(unsigned int order) > +static gfp_t xen_swiotlb_gfp(void) > { > phys_addr_t base; > - gfp_t flags = __GFP_NOWARN|__GFP_KSWAPD_RECLAIM; > u64 i; > > for_each_mem_range(i, &base, NULL) { > if (base < (phys_addr_t)0xffffffff) { > if (IS_ENABLED(CONFIG_ZONE_DMA32)) > - flags |= __GFP_DMA32; > - else > - flags |= __GFP_DMA; > - break; > + return __GFP_DMA32; > + return __GFP_DMA; > } > } > - return __get_free_pages(flags, order); > + > + return GFP_KERNEL; > } Unrelated to this specific patch series: now that I think about it, if io_tlb_default_mem.nslabs is already allocated by the time xen_mm_init is called, wouldn't we potentially have an issue with the GFP flags used for the earlier allocation (e.g. GFP_DMA32 not used)? Maybe something for another day. > static bool hypercall_cflush = false; > @@ -143,10 +141,15 @@ static int __init xen_mm_init(void) > if (!xen_swiotlb_detect()) > return 0; > > - rc = xen_swiotlb_init(); > /* we can work with the default swiotlb */ > - if (rc < 0 && rc != -EEXIST) > - return rc; > + if (!io_tlb_default_mem.nslabs) { > + if (!xen_initial_domain()) > + return -EINVAL; I don't think we need this xen_initial_domain() check. It is all already sorted out by the xen_swiotlb_detect() check above. Aside from that the rest looks OK. Also, you can add my: Tested-by: Stefano Stabellini > + rc = swiotlb_init_late(swiotlb_size_or_default(), > + xen_swiotlb_gfp(), NULL); > + if (rc < 0) > + return rc; > + } > > cflush.op = 0; > cflush.a.dev_bus_addr = 0; > diff --git a/arch/x86/include/asm/xen/page.h b/arch/x86/include/asm/xen/page.h > index e989bc2269f54..1fc67df500145 100644 > --- a/arch/x86/include/asm/xen/page.h > +++ b/arch/x86/include/asm/xen/page.h > @@ -357,9 +357,4 @@ static inline bool xen_arch_need_swiotlb(struct device *dev, > return false; > } > > -static inline unsigned long xen_get_swiotlb_free_pages(unsigned int order) > -{ > - return __get_free_pages(__GFP_NOWARN, order); > -} > - > #endif /* _ASM_X86_XEN_PAGE_H */ > diff --git a/arch/x86/kernel/pci-dma.c b/arch/x86/kernel/pci-dma.c > index e0def4b1c3181..2f2c468acb955 100644 > --- a/arch/x86/kernel/pci-dma.c > +++ b/arch/x86/kernel/pci-dma.c > @@ -71,15 +71,12 @@ static inline void __init pci_swiotlb_detect(void) > #endif /* CONFIG_SWIOTLB */ > > #ifdef CONFIG_SWIOTLB_XEN > -static bool xen_swiotlb; > - > static void __init pci_xen_swiotlb_init(void) > { > if (!xen_initial_domain() && !x86_swiotlb_enable) > return; > x86_swiotlb_enable = false; > - xen_swiotlb = true; > - xen_swiotlb_init_early(); > + swiotlb_init_remap(true, x86_swiotlb_flags, xen_swiotlb_fixup); > dma_ops = &xen_swiotlb_dma_ops; > if (IS_ENABLED(CONFIG_PCI)) > pci_request_acs(); > @@ -87,14 +84,16 @@ static void __init pci_xen_swiotlb_init(void) > > int pci_xen_swiotlb_init_late(void) > { > - int rc; > - > - if (xen_swiotlb) > + if (dma_ops == &xen_swiotlb_dma_ops) > return 0; > > - rc = xen_swiotlb_init(); > - if (rc) > - return rc; > + /* we can work with the default swiotlb */ > + if (!io_tlb_default_mem.nslabs) { > + int rc = swiotlb_init_late(swiotlb_size_or_default(), > + GFP_KERNEL, xen_swiotlb_fixup); > + if (rc < 0) > + return rc; > + } > > /* XXX: this switches the dma ops under live devices! */ > dma_ops = &xen_swiotlb_dma_ops; > diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c > index c2da3eb4826e8..df8085b50df10 100644 > --- a/drivers/xen/swiotlb-xen.c > +++ b/drivers/xen/swiotlb-xen.c > @@ -104,7 +104,7 @@ static int is_xen_swiotlb_buffer(struct device *dev, dma_addr_t dma_addr) > return 0; > } > > -static int xen_swiotlb_fixup(void *buf, unsigned long nslabs) > +int xen_swiotlb_fixup(void *buf, unsigned long nslabs) > { > int rc; > unsigned int order = get_order(IO_TLB_SEGSIZE << IO_TLB_SHIFT); > @@ -130,132 +130,6 @@ static int xen_swiotlb_fixup(void *buf, unsigned long nslabs) > return 0; > } > > -enum xen_swiotlb_err { > - XEN_SWIOTLB_UNKNOWN = 0, > - XEN_SWIOTLB_ENOMEM, > - XEN_SWIOTLB_EFIXUP > -}; > - > -static const char *xen_swiotlb_error(enum xen_swiotlb_err err) > -{ > - switch (err) { > - case XEN_SWIOTLB_ENOMEM: > - return "Cannot allocate Xen-SWIOTLB buffer\n"; > - case XEN_SWIOTLB_EFIXUP: > - return "Failed to get contiguous memory for DMA from Xen!\n"\ > - "You either: don't have the permissions, do not have"\ > - " enough free memory under 4GB, or the hypervisor memory"\ > - " is too fragmented!"; > - default: > - break; > - } > - return ""; > -} > - > -int xen_swiotlb_init(void) > -{ > - enum xen_swiotlb_err m_ret = XEN_SWIOTLB_UNKNOWN; > - unsigned long bytes = swiotlb_size_or_default(); > - unsigned long nslabs = bytes >> IO_TLB_SHIFT; > - unsigned int order, repeat = 3; > - int rc = -ENOMEM; > - char *start; > - > - if (io_tlb_default_mem.nslabs) { > - pr_warn("swiotlb buffer already initialized\n"); > - return -EEXIST; > - } > - > -retry: > - m_ret = XEN_SWIOTLB_ENOMEM; > - order = get_order(bytes); > - > - /* > - * Get IO TLB memory from any location. > - */ > -#define SLABS_PER_PAGE (1 << (PAGE_SHIFT - IO_TLB_SHIFT)) > -#define IO_TLB_MIN_SLABS ((1<<20) >> IO_TLB_SHIFT) > - while ((SLABS_PER_PAGE << order) > IO_TLB_MIN_SLABS) { > - start = (void *)xen_get_swiotlb_free_pages(order); > - if (start) > - break; > - order--; > - } > - if (!start) > - goto exit; > - if (order != get_order(bytes)) { > - pr_warn("Warning: only able to allocate %ld MB for software IO TLB\n", > - (PAGE_SIZE << order) >> 20); > - nslabs = SLABS_PER_PAGE << order; > - bytes = nslabs << IO_TLB_SHIFT; > - } > - > - /* > - * And replace that memory with pages under 4GB. > - */ > - rc = xen_swiotlb_fixup(start, nslabs); > - if (rc) { > - free_pages((unsigned long)start, order); > - m_ret = XEN_SWIOTLB_EFIXUP; > - goto error; > - } > - rc = swiotlb_late_init_with_tbl(start, nslabs); > - if (rc) > - return rc; > - return 0; > -error: > - if (nslabs > 1024 && repeat--) { > - /* Min is 2MB */ > - nslabs = max(1024UL, ALIGN(nslabs >> 1, IO_TLB_SEGSIZE)); > - bytes = nslabs << IO_TLB_SHIFT; > - pr_info("Lowering to %luMB\n", bytes >> 20); > - goto retry; > - } > -exit: > - pr_err("%s (rc:%d)\n", xen_swiotlb_error(m_ret), rc); > - return rc; > -} > - > -#ifdef CONFIG_X86 > -void __init xen_swiotlb_init_early(void) > -{ > - unsigned long bytes = swiotlb_size_or_default(); > - unsigned long nslabs = bytes >> IO_TLB_SHIFT; > - unsigned int repeat = 3; > - char *start; > - int rc; > - > -retry: > - /* > - * Get IO TLB memory from any location. > - */ > - start = memblock_alloc(PAGE_ALIGN(bytes), > - IO_TLB_SEGSIZE << IO_TLB_SHIFT); > - if (!start) > - panic("%s: Failed to allocate %lu bytes\n", > - __func__, PAGE_ALIGN(bytes)); > - > - /* > - * And replace that memory with pages under 4GB. > - */ > - rc = xen_swiotlb_fixup(start, nslabs); > - if (rc) { > - memblock_free(start, PAGE_ALIGN(bytes)); > - if (nslabs > 1024 && repeat--) { > - /* Min is 2MB */ > - nslabs = max(1024UL, ALIGN(nslabs >> 1, IO_TLB_SEGSIZE)); > - bytes = nslabs << IO_TLB_SHIFT; > - pr_info("Lowering to %luMB\n", bytes >> 20); > - goto retry; > - } > - panic("%s (rc:%d)", xen_swiotlb_error(XEN_SWIOTLB_EFIXUP), rc); > - } > - > - if (swiotlb_init_with_tbl(start, nslabs, SWIOTLB_VERBOSE)) > - panic("Cannot allocate SWIOTLB buffer"); > -} > -#endif /* CONFIG_X86 */ > - > static void * > xen_swiotlb_alloc_coherent(struct device *hwdev, size_t size, > dma_addr_t *dma_handle, gfp_t flags, > diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h > index ee655f2e4d28b..919cf82ed978e 100644 > --- a/include/linux/swiotlb.h > +++ b/include/linux/swiotlb.h > @@ -34,10 +34,11 @@ struct scatterlist; > /* default to 64MB */ > #define IO_TLB_DEFAULT_SIZE (64UL<<20) > > -int swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, unsigned int flags); > unsigned long swiotlb_size_or_default(void); > -extern int swiotlb_late_init_with_tbl(char *tlb, unsigned long nslabs); > -int swiotlb_init_late(size_t size, gfp_t gfp_mask); > +int swiotlb_init_late(size_t size, gfp_t gfp_mask, > + int (*remap)(void *tlb, unsigned long nslabs)); > +void __init swiotlb_init_remap(bool addressing_limit, unsigned int flags, > + int (*remap)(void *tlb, unsigned long nslabs)); > extern void __init swiotlb_update_mem_attributes(void); > > phys_addr_t swiotlb_tbl_map_single(struct device *hwdev, phys_addr_t phys, > diff --git a/include/xen/arm/page.h b/include/xen/arm/page.h > index ac1b654705631..7e199c6656b90 100644 > --- a/include/xen/arm/page.h > +++ b/include/xen/arm/page.h > @@ -115,6 +115,5 @@ static inline bool set_phys_to_machine(unsigned long pfn, unsigned long mfn) > bool xen_arch_need_swiotlb(struct device *dev, > phys_addr_t phys, > dma_addr_t dev_addr); > -unsigned long xen_get_swiotlb_free_pages(unsigned int order); > #endif /* _ASM_ARM_XEN_PAGE_H */ > diff --git a/include/xen/swiotlb-xen.h b/include/xen/swiotlb-xen.h > index b3e647f86e3e2..590ceb923f0c8 100644 > --- a/include/xen/swiotlb-xen.h > +++ b/include/xen/swiotlb-xen.h > @@ -10,8 +10,12 @@ void xen_dma_sync_for_cpu(struct device *dev, dma_addr_t handle, > void xen_dma_sync_for_device(struct device *dev, dma_addr_t handle, > size_t size, enum dma_data_direction dir); > > -int xen_swiotlb_init(void); > -void __init xen_swiotlb_init_early(void); > +#ifdef CONFIG_SWIOTLB_XEN > +int xen_swiotlb_fixup(void *buf, unsigned long nslabs); > +#else > +#define xen_swiotlb_fixup NULL > +#endif > + > extern const struct dma_map_ops xen_swiotlb_dma_ops; > > #endif /* __LINUX_SWIOTLB_XEN_H */ > diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c > index 77cf73dc20a78..128363dc9b5bb 100644 > --- a/kernel/dma/swiotlb.c > +++ b/kernel/dma/swiotlb.c > @@ -234,40 +234,17 @@ static void swiotlb_init_io_tlb_mem(struct io_tlb_mem *mem, phys_addr_t start, > return; > } > > -int __init swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, > - unsigned int flags) > -{ > - struct io_tlb_mem *mem = &io_tlb_default_mem; > - size_t alloc_size; > - > - if (swiotlb_force_disable) > - return 0; > - > - /* protect against double initialization */ > - if (WARN_ON_ONCE(mem->nslabs)) > - return -ENOMEM; > - > - alloc_size = PAGE_ALIGN(array_size(sizeof(*mem->slots), nslabs)); > - mem->slots = memblock_alloc(alloc_size, PAGE_SIZE); > - if (!mem->slots) > - panic("%s: Failed to allocate %zu bytes align=0x%lx\n", > - __func__, alloc_size, PAGE_SIZE); > - > - swiotlb_init_io_tlb_mem(mem, __pa(tlb), nslabs, false); > - mem->force_bounce = flags & SWIOTLB_FORCE; > - > - if (flags & SWIOTLB_VERBOSE) > - swiotlb_print_info(); > - return 0; > -} > - > /* > * Statically reserve bounce buffer space and initialize bounce buffer data > * structures for the software IO TLB used to implement the DMA API. > */ > -void __init swiotlb_init(bool addressing_limit, unsigned int flags) > +void __init swiotlb_init_remap(bool addressing_limit, unsigned int flags, > + int (*remap)(void *tlb, unsigned long nslabs)) > { > - size_t bytes = PAGE_ALIGN(default_nslabs << IO_TLB_SHIFT); > + struct io_tlb_mem *mem = &io_tlb_default_mem; > + unsigned long nslabs = default_nslabs; > + size_t alloc_size = PAGE_ALIGN(array_size(sizeof(*mem->slots), nslabs)); > + size_t bytes; > void *tlb; > > if (!addressing_limit && !swiotlb_force_bounce) > @@ -275,23 +252,48 @@ void __init swiotlb_init(bool addressing_limit, unsigned int flags) > if (swiotlb_force_disable) > return; > > + /* protect against double initialization */ > + if (WARN_ON_ONCE(mem->nslabs)) > + return; > + > /* > * By default allocate the bonuce buffer memory from low memory. > */ > +retry: > + bytes = PAGE_ALIGN(default_nslabs << IO_TLB_SHIFT); > if (flags & SWIOTLB_ANY) > tlb = memblock_alloc(bytes, PAGE_SIZE); > else > tlb = memblock_alloc_low(bytes, PAGE_SIZE); > if (!tlb) > - goto fail; > - if (swiotlb_init_with_tbl(tlb, default_nslabs, flags)) > - goto fail_free_mem; > - return; > + panic("%s: failed to allocate tlb structure\n", __func__); > + > + if (remap && remap(tlb, nslabs) < 0) { > + memblock_free(tlb, PAGE_ALIGN(bytes)); > + > + /* Min is 2MB */ > + if (nslabs <= 1024) > + panic("%s: Failed to remap %zu bytes\n", > + __func__, bytes); > + nslabs = max(1024UL, ALIGN(nslabs >> 1, IO_TLB_SEGSIZE)); > + goto retry; > + } > + > + mem->slots = memblock_alloc(alloc_size, PAGE_SIZE); > + if (!mem->slots) > + panic("%s: Failed to allocate %zu bytes align=0x%lx\n", > + __func__, alloc_size, PAGE_SIZE); > > -fail_free_mem: > - memblock_free(tlb, bytes); > -fail: > - pr_warn("Cannot allocate buffer"); > + swiotlb_init_io_tlb_mem(mem, __pa(tlb), default_nslabs, false); > + mem->force_bounce = flags & SWIOTLB_FORCE; > + > + if (flags & SWIOTLB_VERBOSE) > + swiotlb_print_info(); > +} > + > +void __init swiotlb_init(bool addressing_limit, unsigned int flags) > +{ > + return swiotlb_init_remap(addressing_limit, flags, NULL); > } > > /* > @@ -299,8 +301,10 @@ void __init swiotlb_init(bool addressing_limit, unsigned int flags) > * initialize the swiotlb later using the slab allocator if needed. > * This should be just like above, but with some error catching. > */ > -int swiotlb_init_late(size_t size, gfp_t gfp_mask) > +int swiotlb_init_late(size_t size, gfp_t gfp_mask, > + int (*remap)(void *tlb, unsigned long nslabs)) > { > + struct io_tlb_mem *mem = &io_tlb_default_mem; > unsigned long nslabs = ALIGN(size >> IO_TLB_SHIFT, IO_TLB_SEGSIZE); > unsigned long bytes; > unsigned char *vstart = NULL; > @@ -310,9 +314,14 @@ int swiotlb_init_late(size_t size, gfp_t gfp_mask) > if (swiotlb_force_disable) > return 0; > > + /* protect against double initialization */ > + if (WARN_ON_ONCE(mem->nslabs)) > + return -ENOMEM; > + > /* > * Get IO TLB memory from the low pages > */ > +retry: > order = get_order(nslabs << IO_TLB_SHIFT); > nslabs = SLABS_PER_PAGE << order; > bytes = nslabs << IO_TLB_SHIFT; > @@ -333,33 +342,28 @@ int swiotlb_init_late(size_t size, gfp_t gfp_mask) > (PAGE_SIZE << order) >> 20); > nslabs = SLABS_PER_PAGE << order; > } > - rc = swiotlb_late_init_with_tbl(vstart, nslabs); > - if (rc) > - free_pages((unsigned long)vstart, order); > - > - return rc; > -} > - > -int > -swiotlb_late_init_with_tbl(char *tlb, unsigned long nslabs) > -{ > - struct io_tlb_mem *mem = &io_tlb_default_mem; > - unsigned long bytes = nslabs << IO_TLB_SHIFT; > > - if (swiotlb_force_disable) > - return 0; > + if (remap) > + rc = remap(vstart, nslabs); > + if (rc) { > + free_pages((unsigned long)vstart, order); > > - /* protect against double initialization */ > - if (WARN_ON_ONCE(mem->nslabs)) > - return -ENOMEM; > + /* Min is 2MB */ > + if (nslabs <= 1024) > + return rc; > + nslabs = max(1024UL, ALIGN(nslabs >> 1, IO_TLB_SEGSIZE)); > + goto retry; > + } > > mem->slots = (void *)__get_free_pages(GFP_KERNEL | __GFP_ZERO, > get_order(array_size(sizeof(*mem->slots), nslabs))); > - if (!mem->slots) > + if (!mem->slots) { > + free_pages((unsigned long)vstart, order); > return -ENOMEM; > + } > > - set_memory_decrypted((unsigned long)tlb, bytes >> PAGE_SHIFT); > - swiotlb_init_io_tlb_mem(mem, virt_to_phys(tlb), nslabs, true); > + set_memory_decrypted((unsigned long)vstart, bytes >> PAGE_SHIFT); > + swiotlb_init_io_tlb_mem(mem, virt_to_phys(vstart), nslabs, true); > > swiotlb_print_info(); > return 0; > -- > 2.30.2 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > From xen-devel-bounces@lists.xenproject.org Wed Mar 02 03:44:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 03:44:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281934.480472 (Exim 4.92) (envelope-from ) id 1nPFuq-0007XI-Qn; Wed, 02 Mar 2022 03:44:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281934.480472; Wed, 02 Mar 2022 03:44:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPFuq-0007XB-MY; Wed, 02 Mar 2022 03:44:40 +0000 Received: by outflank-mailman (input) for mailman id 281934; Wed, 02 Mar 2022 03:44:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPFup-0007X1-BP; Wed, 02 Mar 2022 03:44:39 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPFup-00034k-97; Wed, 02 Mar 2022 03:44:39 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPFuo-0004K0-UD; Wed, 02 Mar 2022 03:44:38 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nPFuo-0001Kd-Tj; Wed, 02 Mar 2022 03:44:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=LRIPitsiaZb/8HvvMizl8c8S/IMPfIbNpuVq5PGoVZs=; b=oSCmvwE1yUNQbVw+vx0L1OX8m8 Jy9WPWqpSpwookcOjJ6f6eBpsWqZJbsXz2DNnh2/fJJw31xlGqv2C2PxFvoXvzM0KdzI7mygTmG7l Df9DyuLyqvIEjFnLrC0KdpJE9VggBXe35dn0r2dt2rj3PCJ9DL5w9222VLjOSflKOjAE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 168316: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=dc39554d58af4a50b50eca1f57c49415a12b0c98 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Wed, 02 Mar 2022 03:44:38 +0000 flight 168316 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/168316/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf dc39554d58af4a50b50eca1f57c49415a12b0c98 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 1 days Failing since 168258 2022-03-01 01:55:31 Z 1 days 13 attempts Testing same since 168316 2022-03-02 02:50:20 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Guomin Jiang Jason Jason Lou Xiaolu.Jiang jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit dc39554d58af4a50b50eca1f57c49415a12b0c98 Author: Xiaolu.Jiang Date: Tue Feb 22 22:14:05 2022 +0800 edk2/MdeModulePkg/Debuglib: Add Standalone MM support https://bugzilla.tianocore.org/show_bug.cgi?id=3844 This change added Standalone MM instance of DebugLib. Reviewd-by: Jian J Wang Reviewd-by: Liming Gao Signed-off-by: Xiaolu.Jiang commit 497ac7b6d7f9750f48f137db244931a5728b1968 Author: Guomin Jiang Date: Sat Jan 29 16:28:02 2022 +0800 UefiPayloadPkg/PayloadLoaderPeim: Use INT64 as input parameter REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3818 It will have some potential issue when memory larger than 2G because the high memory address will be fill with 0xFFFFFFFF when do the operation of INTN + INT64 but it is 32 bit normal data in fact. Should use same data type INT64 + INT64. V3: 1. Use INT64 as input parameter because all date type is 64 bit V2: 1. Force the data type to UINTN to avoid high dword be filled with 0xFFFFFFFF 2. Keep INTN because the offset may postive or negative. Reviewed-by: Guo Dong Reviewed-by: Ray Ni Signed-off-by: Guomin Jiang commit 6a890db161cd6d378bec3499a1e774db3f5a27a7 Author: Jason Date: Mon Jan 10 22:30:29 2022 +0800 BaseTools: Upgrade the version of NASM tool REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Upgrade the version of NASM tool to avoid compilation errors when compiling NASM code change. Signed-off-by: Jason Lou Cc: Bob Feng Cc: Liming Gao Reviewed-by: Yuwei Chen commit bbaa00dd01ed0df30e43a5a89fd2b0433d858b73 Author: Jason Date: Mon Jan 10 22:05:47 2022 +0800 MdePkg: Remove the macro definitions regarding Opcode. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Remove the macro definitions regarding Opcode because new version of NASM tool(e.g. v2.15.05) supports the corresponding instructions. Note: This patch need to be merged after other NASM code change to avoid compilation errors. Signed-off-by: Jason Lou Cc: Michael D Kinney Reviewed-by: Liming Gao Cc: Zhiguang Liu commit 2aa107c0aa2e1375651867c8df1b81ff64b67fce Author: Jason Date: Mon Jan 10 22:01:18 2022 +0800 UefiCpuPkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Reviewed-by: Ray Ni Cc: Eric Dong Cc: Laszlo Ersek Cc: Rahul Kumar commit 7bc8b1d9f412507d579f21ea9af56fced81e7827 Author: Jason Date: Mon Jan 10 21:52:52 2022 +0800 SourceLevelDebugPkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Reviewed-by: Hao A Wu commit d3febfd9ade35dc552df6b3607c2b15d26b82867 Author: Jason Date: Mon Jan 10 21:46:27 2022 +0800 MdePkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Cc: Michael D Kinney Reviewed-by: Liming Gao Cc: Zhiguang Liu commit 84338c0d498555f860a480693ee8647a1795fba3 Author: Jason Date: Mon Jan 10 21:04:09 2022 +0800 MdeModulePkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Reviewed-by: Ray Ni Cc: Dandan Bi Reviewed-by: Liming Gao From xen-devel-bounces@lists.xenproject.org Wed Mar 02 05:24:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 05:24:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281950.480489 (Exim 4.92) (envelope-from ) id 1nPHTU-0002iu-Gv; Wed, 02 Mar 2022 05:24:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281950.480489; Wed, 02 Mar 2022 05:24:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPHTU-0002in-DL; Wed, 02 Mar 2022 05:24:32 +0000 Received: by outflank-mailman (input) for mailman id 281950; Wed, 02 Mar 2022 05:24:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPHTT-0002id-L3; Wed, 02 Mar 2022 05:24:31 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPHTT-0005FB-JI; Wed, 02 Mar 2022 05:24:31 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPHTT-0001O0-2w; Wed, 02 Mar 2022 05:24:31 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nPHTT-000132-2N; Wed, 02 Mar 2022 05:24:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=5qRvCfzIcMDNCnEYrFU/GRKlxVG38hIAur9AUSdc6t0=; b=JKOV/iGrExkmZy4Ic8q7fiINzF 27fNFxJhLyJMi9ueu+201ZAzllU33WmwN+r9yyCqwGO/ZuYmOSpFCtZ1NqIN+NQLRFXwyAtcb45S+ 0/fqLmzXip+7zUEqxPX2UXCT77pMZVQkZcn48HJai5dadSbPlKNS8PaZ3ZgjZMl0Oda0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 168313: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=faecea18d252f97c6ad41f0f457566ff2c125b8d X-Osstest-Versions-That: xen=0c18fb76323bfb13615b6f13c98767face2d8097 From: osstest service owner Date: Wed, 02 Mar 2022 05:24:31 +0000 flight 168313 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/168313/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen faecea18d252f97c6ad41f0f457566ff2c125b8d baseline version: xen 0c18fb76323bfb13615b6f13c98767face2d8097 Last test of basis 168305 2022-03-01 20:01:41 Z 0 days Testing same since 168313 2022-03-02 01:00:26 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Julien Grall jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 0c18fb7632..faecea18d2 faecea18d252f97c6ad41f0f457566ff2c125b8d -> smoke From xen-devel-bounces@lists.xenproject.org Wed Mar 02 06:19:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 06:19:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281966.480512 (Exim 4.92) (envelope-from ) id 1nPIL0-0000iU-PR; Wed, 02 Mar 2022 06:19:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281966.480512; Wed, 02 Mar 2022 06:19:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPIL0-0000iN-LG; Wed, 02 Mar 2022 06:19:50 +0000 Received: by outflank-mailman (input) for mailman id 281966; Wed, 02 Mar 2022 06:19:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPIKz-0000iD-T3; Wed, 02 Mar 2022 06:19:49 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPIKz-0006EQ-O5; Wed, 02 Mar 2022 06:19:49 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPIKz-0004Gs-BB; Wed, 02 Mar 2022 06:19:49 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nPIKz-00053d-9b; Wed, 02 Mar 2022 06:19:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=rVOWcl2q8aVzShaskv0CIcGJPtiCCrsoEwn+e9FFkCQ=; b=iEzYg/8Xm6KYjIkwflQoNFj0el snsmauLxW+m3k/Ay0ww6mGTqq/c5RI2pY+IJoZ7qydq1wFnBxd6vJXa4UYdVvfT6EmRtdvcpbeb3d MqiFwxQhhWrqbwvoRUNRZMMVl4VIuSJUvlLttg8IHkgNv7kj1nismj0rOYbNHC63iemk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 168306: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:debian-hvm-install:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=575115360652e9920cc56a028a286ebe9bf82694 X-Osstest-Versions-That: linux=719fce7539cd3e186598e2aed36325fe892150cf From: osstest service owner Date: Wed, 02 Mar 2022 06:19:49 +0000 flight 168306 linux-linus real [real] flight 168322 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/168306/ http://logs.test-lab.xenproject.org/osstest/logs/168322/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemut-debianhvm-amd64 12 debian-hvm-install fail pass in 168322-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 168256 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 168256 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 168256 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 168256 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 168256 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 168256 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 168256 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168256 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: linux 575115360652e9920cc56a028a286ebe9bf82694 baseline version: linux 719fce7539cd3e186598e2aed36325fe892150cf Last test of basis 168256 2022-02-28 21:11:14 Z 1 days Testing same since 168306 2022-03-01 20:09:49 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: John Paul Adrian Glaubitz Kees Cook Linus Torvalds matoro jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 719fce7539cd..575115360652 575115360652e9920cc56a028a286ebe9bf82694 -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Wed Mar 02 06:43:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 06:43:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281977.480523 (Exim 4.92) (envelope-from ) id 1nPIhn-0004GM-MA; Wed, 02 Mar 2022 06:43:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281977.480523; Wed, 02 Mar 2022 06:43:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPIhn-0004GF-IH; Wed, 02 Mar 2022 06:43:23 +0000 Received: by outflank-mailman (input) for mailman id 281977; Wed, 02 Mar 2022 06:43:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPIhm-0004G6-JN for xen-devel@lists.xenproject.org; Wed, 02 Mar 2022 06:43:22 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20631.outbound.protection.outlook.com [2a01:111:f400:7e1a::631]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0b7c6f8d-99f4-11ec-8539-5f4723681683; Wed, 02 Mar 2022 07:43:19 +0100 (CET) Received: from DB6PR0501CA0025.eurprd05.prod.outlook.com (2603:10a6:4:67::11) by HE1PR0801MB1769.eurprd08.prod.outlook.com (2603:10a6:3:7f::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.13; Wed, 2 Mar 2022 06:43:16 +0000 Received: from DB5EUR03FT045.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:67:cafe::31) by DB6PR0501CA0025.outlook.office365.com (2603:10a6:4:67::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.13 via Frontend Transport; Wed, 2 Mar 2022 06:43:15 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT045.mail.protection.outlook.com (10.152.21.164) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22 via Frontend Transport; Wed, 2 Mar 2022 06:43:15 +0000 Received: ("Tessian outbound 31aeb3346a45:v113"); Wed, 02 Mar 2022 06:43:15 +0000 Received: from ef8bdd70029a.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id DAC707AD-D9F0-4A1F-A313-F4E4AAD9E3ED.1; Wed, 02 Mar 2022 06:43:09 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ef8bdd70029a.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 02 Mar 2022 06:43:09 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by PAXPR08MB7123.eurprd08.prod.outlook.com (2603:10a6:102:206::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Wed, 2 Mar 2022 06:43:07 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::89b3:80a2:2b58:f1aa]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::89b3:80a2:2b58:f1aa%4]) with mapi id 15.20.5038.014; Wed, 2 Mar 2022 06:43:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0b7c6f8d-99f4-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=d99pwRro3QOML7H0OZ9ZmZKoZLCKgq75MfxSO1ypTIc=; b=bMIbnnA/1iEuqO9RMl0klONqFIBUcQQvexJOa4B5JytKliIBff2aJYs+SP/Jeh9RLMUhdA344ylZlkhv4ABHIPMkhCrm/FBr54dFAzMkaauKShNciKyNfjbgy6GL3+JPwXmlFTX/QJglUYr+vmDscP/b5mRalMm6FGUel8DINCM= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mJ31Zr5tlO4GjpLCRY0MG43XWDBc5Rm+yZ7qYHTzAbtGG3Sx+s40oroxIYC5B/NcvBBopuIGEEBYCrMEs9q0ATwQ9PWavK5B+uTePAqLY9qHdM+vcdJPfchxhJodnN7MfRelV35oz9H0XG2BpmaMy/iqbgcDZSAE0iXn+JVQ7Uf0IT1AHxALK6aFC3GJVpO2UmRR2N3xVm90O6lYAurX3dqZ4CZ9yFCo/63xI7GtFx2l3zG49yqfAaOUpS8A1CdNIRYtiTaMH5wnQRR3g+CArYm2lU/7jeVtVRw3KrwYS4PXJ0TP726zdU05dnf3oGcRTcltTU6wzqFIr3n602kWIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=d99pwRro3QOML7H0OZ9ZmZKoZLCKgq75MfxSO1ypTIc=; b=Taa62mw1uAvC6djQ5JTvbH6wAGy4uIZyptOkjVWs1Q7OFds+NwX1ZMp1PaH/aRVpcnKG0oDm/VuHnkMtT/iUiNYCoz9qZ/fpwmUy4sFNXlhUVITm9edbGut+cj5PnOZ3AhCF2sk80KfyCDNo2CN+vYvpFPWZfJ9M0ctGzzdc/dnKIltB1HtjIsXuO8x74lEXXnHQ4URjBZhsOBzY992j+TWbSyktZ3P/xoiegyrUsZN+Efn7I6nazeCSpxba8BzLxjM16efZZr5VqPlPoOMbe75fRzqpA1jc0JIMUmfTrjHi+34leS/wzgw6FCQKaVHe9HcmM602XMltf7q+/rMrXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=d99pwRro3QOML7H0OZ9ZmZKoZLCKgq75MfxSO1ypTIc=; b=bMIbnnA/1iEuqO9RMl0klONqFIBUcQQvexJOa4B5JytKliIBff2aJYs+SP/Jeh9RLMUhdA344ylZlkhv4ABHIPMkhCrm/FBr54dFAzMkaauKShNciKyNfjbgy6GL3+JPwXmlFTX/QJglUYr+vmDscP/b5mRalMm6FGUel8DINCM= From: Wei Chen To: Julien Grall , Stefano Stabellini CC: "xen-devel@lists.xenproject.org" , Bertrand Marquis , Penny Zheng , Henry Wang , nd Subject: RE: Proposal for Porting Xen to Armv8-R64 - DraftA Thread-Topic: Proposal for Porting Xen to Armv8-R64 - DraftA Thread-Index: AdgpQxtXwh7LkfydTgiYk9bhMgU+ogAn0mUAABEK2UAAF1ylAACsO9YwAA5uZgAAI3g7sA== Date: Wed, 2 Mar 2022 06:43:06 +0000 Message-ID: References: <4c558f8f-56d4-0445-32d4-169bc5d0a3bc@xen.org> <7260f050-9022-4adf-618b-a8b271aca8c3@xen.org> In-Reply-To: <7260f050-9022-4adf-618b-a8b271aca8c3@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 32B2944F5526F64A92C3528439773948.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 2842dfa8-c121-4c6d-1408-08d9fc17edf5 x-ms-traffictypediagnostic: PAXPR08MB7123:EE_|DB5EUR03FT045:EE_|HE1PR0801MB1769:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: KiXgAiG9pXI4YVQjM4OCmkUhKHIdWTlZfwlfQwpJRKDe2bwXdn0fv19FWWGQyv5IQ4zbnL51Rkf81BWIGBSrJt/0PWQrHdT//Z4M3Pguuk4OuEfQw0WSqO82lsR9F3Y72RcAt0I+ZllskTNC6E25gn3zI5fpRvVtbOI5EfdtyBh0QaBAcG5vyVEoNOzJZwXGVXsaSNOZCSkVcAMfMusEu1xjpY4ZirNEJD17OgV3B37flaxnTkUjpbIFoAgQNfWZcyTPzu10XwzZDrunMfjuktFG/TvPILRbnZ7RVUbtT4cfPSuOeY/2w0oFoEn64+miuCOf0l5taKTJAnBtUIZhZf94Qp2lUv8gn/MyrNTI7JPUUtSLvtjT1YE8e5Z0FHBxdd+29U93tEhfmFDLbWLANTpMH99KsAfy0dwKMtgQmYQPUgu+a6aSQVEIbZ1C/p7yr9bo3pDJl0l9ugxnq80Tf3zB+/ii8lK4X9yejGWnL3vp+fCxY9h6g2ibzuiiGT3977DCNQk8/GagnrVmTLDJuwJF5CG5k4FXSa3oK8OecX6NBygiz8yZQBBJ7faSFFPnkrNXX+c2WR2DtHt9Rn820zZyQy6L9wzoWIrJ8XXSa3sdUl4iFnBIJY0AXpWtPRT928zSKiJnxXPwRtIz1EoYTY/2S5ovH5Oe4V/WetX/eWc/Fc/LYTLN0PwUwYZeyGzdFwXQBQoq2WOTTt93cU0Apw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(54906003)(8936002)(5660300002)(110136005)(186003)(26005)(52536014)(66476007)(66556008)(64756008)(76116006)(66946007)(71200400001)(33656002)(508600001)(66446008)(122000001)(38070700005)(6506007)(53546011)(7696005)(38100700002)(55016003)(4326008)(316002)(8676002)(2906002)(83380400001)(9686003)(86362001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7123 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT045.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 3932a1f5-edf3-4c9f-3da7-08d9fc17e8fa X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PiHeeDm2q8L0ih/d+FgYrBLq8hlSNAURKGYzj19t6gDYJEv1eRZp8Npuh6Vs05wOwroQ0AUQLwCB+pD0Nv4/ASy/EBo739KnL9yyV28zeWLgt4/YT1z7Qc4ifpKKiLuakyaJljoaVSHCw10Zf+hGmVZfeyoGh/z5xP8Vir7A+dav/4YG4OzYN+XJQ89AOuzehgsemj+zIxgOmQe1XUeix0B/2FShj25tgKRoi74b9MbAP4EPCGFBxWdsC/lmeaeuIXPbOJR6yumIO9k35VLxAOP/addNXGrx4+CQFZJnt9riiFfyfvNV35jrLJrrPmrXxFp2OD3yMvRh1JQHHR74oWOIckOJStJ9MtaV7NEQRf+KKqWFSO3HB7D+wVxypcKqA0IvTNhnSGbSbM4j8qGm3k5y0H1eRq7BpFJZk96paGJ+BJpeWyXZCJTKX4+SGPAuF5TCxORIo8xyz9VHouKM6mGR3foMmy8u0wFYEdYorIp6Od/It4Y0x8KXPNsMJW8QoDL1vZQshqvDOwMd4ldyMqDL6b97nPZfUuRZO09SiDJw1+IqRdf2+wMypDzqTf32LfzzsQgRktRMljm3L5eVgCSpkAG1n84Z3t541cVhCR0ur2UzKWAAmUWujdhU6aJwXS4bmBMn7J9xj2MlunBzLXmiAIwkZ0NexUOcQOlBht0TtQrIyYln7g6z5PD3Sbct X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(110136005)(316002)(8936002)(52536014)(4326008)(8676002)(5660300002)(2906002)(26005)(54906003)(40460700003)(86362001)(508600001)(70206006)(70586007)(36860700001)(55016003)(9686003)(7696005)(53546011)(356005)(81166007)(6506007)(33656002)(82310400004)(336012)(47076005)(83380400001)(186003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2022 06:43:15.6344 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2842dfa8-c121-4c6d-1408-08d9fc17edf5 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT045.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1769 SGkgSnVsaWVuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEp1bGll biBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+IFNlbnQ6IDIwMjLlubQz5pyIMeaXpSAyMToxNw0K PiBUbzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+OyBTdGVmYW5vIFN0YWJlbGxpbmkNCj4g PHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+DQo+IENjOiB4ZW4tZGV2ZWxAbGlzdHMueGVucHJvamVj dC5vcmc7IEJlcnRyYW5kIE1hcnF1aXMNCj4gPEJlcnRyYW5kLk1hcnF1aXNAYXJtLmNvbT47IFBl bm55IFpoZW5nIDxQZW5ueS5aaGVuZ0Bhcm0uY29tPjsgSGVucnkgV2FuZw0KPiA8SGVucnkuV2Fu Z0Bhcm0uY29tPjsgbmQgPG5kQGFybS5jb20+DQo+IFN1YmplY3Q6IFJlOiBQcm9wb3NhbCBmb3Ig UG9ydGluZyBYZW4gdG8gQXJtdjgtUjY0IC0gRHJhZnRBDQo+IA0KPiBPbiAwMS8wMy8yMDIyIDA2 OjI5LCBXZWkgQ2hlbiB3cm90ZToNCj4gPiBIaSBKdWxpZW4sDQo+IA0KPiBIaSwNCj4gDQo+ID4+ IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+ID4+IEZyb206IEp1bGllbiBHcmFsbCA8anVs aWVuQHhlbi5vcmc+DQo+ID4+IFNlbnQ6IDIwMjLlubQy5pyIMjbml6UgNDoxMg0KPiA+PiBUbzog V2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+OyBTdGVmYW5vIFN0YWJlbGxpbmkNCj4gPj4gPHNz dGFiZWxsaW5pQGtlcm5lbC5vcmc+DQo+ID4+IENjOiB4ZW4tZGV2ZWxAbGlzdHMueGVucHJvamVj dC5vcmc7IEJlcnRyYW5kIE1hcnF1aXMNCj4gPj4gPEJlcnRyYW5kLk1hcnF1aXNAYXJtLmNvbT47 IFBlbm55IFpoZW5nIDxQZW5ueS5aaGVuZ0Bhcm0uY29tPjsgSGVucnkNCj4gV2FuZw0KPiA+PiA8 SGVucnkuV2FuZ0Bhcm0uY29tPjsgbmQgPG5kQGFybS5jb20+DQo+ID4+IFN1YmplY3Q6IFJlOiBQ cm9wb3NhbCBmb3IgUG9ydGluZyBYZW4gdG8gQXJtdjgtUjY0IC0gRHJhZnRBDQo+ID4+DQo+ID4+ IEhpIFdlaSwNCj4gPj4NCj4gPj4gT24gMjUvMDIvMjAyMiAxMDo0OCwgV2VpIENoZW4gd3JvdGU6 DQo+ID4+Pj4+ICDCoMKgwqDCoCBBcm12OC1SNjQgY2FuIHN1cHBvcnQgbWF4IHRvIDI1NiBNUFUg cmVnaW9ucy4gQnV0IHRoYXQncyBqdXN0DQo+ID4+Pj4gdGhlb3JldGljYWwuDQo+ID4+Pj4+ICDC oMKgwqDCoCBTbyB3ZSBkb24ndCB3YW50IHRvIGRlZmluZSBgcHJfdCBtcHVfcmVnaW9uc1syNTZd YCwgdGhpcyBpcyBhDQo+ID4+IG1lbW9yeQ0KPiA+Pj4+IHdhc3RlDQo+ID4+Pj4+ICDCoMKgwqDC oCBpbiBtb3N0IG9mIHRpbWUuIFNvIHdlIGRlY2lkZWQgdG8gbGV0IHRoZSB1c2VyIHNwZWNpZnkg dGhyb3VnaA0KPiBhDQo+ID4+Pj4gS2NvbmZpZw0KPiA+Pj4+PiAgwqDCoMKgwqAgb3B0aW9uLiBg Q09ORklHX0FSTV9NUFVfRUwxX1BST1RFQ1RJT05fUkVHSU9OU2AgZGVmYXVsdCB2YWx1ZQ0KPiBj YW4NCj4gPj4gYmUNCj4gPj4+PiBgMzJgLA0KPiA+Pj4+PiAgwqDCoMKgwqAgaXQncyBhIHR5cGlj YWwgaW1wbGVtZW50YXRpb24gb24gQXJtdjgtUjY0LiBVc2VycyB3aWxsDQo+IHJlY29tcGlsZQ0K PiA+PiBYZW4NCj4gPj4+PiB3aGVuDQo+ID4+Pj4+ICDCoMKgwqDCoCB0aGVpciBwbGF0Zm9ybSBj aGFuZ2VzLiBTbyB3aGVuIHRoZSBNUFUgY2hhbmdlcywgcmVzcGVjaWZ5aW5nDQo+IHRoZQ0KPiA+ Pj4+IE1QVQ0KPiA+Pj4+PiAgwqDCoMKgwqAgcHJvdGVjdGlvbiByZWdpb25zIG51bWJlciB3aWxs IG5vdCBjYXVzZSBhZGRpdGlvbmFsIHByb2JsZW1zLg0KPiA+Pj4+DQo+ID4+Pj4gSSB3b25kZXIg aWYgd2UgY291bGQgcHJvYmUgdGhlIG51bWJlciBvZiBNUFUgcmVnaW9ucyBhdCBydW50aW1lIGFu ZA0KPiA+Pj4+IGR5bmFtaWNhbGx5IGFsbG9jYXRlIHRoZSBtZW1vcnkgbmVlZGVkIHRvIHN0b3Jl IHRoZW0gaW4gYXJjaF92Y3B1Lg0KPiA+Pj4+DQo+ID4+Pg0KPiA+Pj4gV2UgaGF2ZSBjb25zaWRl cmVkIHRvIHVzZWQgYSBwcl90IG1wdV9yZWdpb25zWzBdIGluIGFyY2hfdmNwdS4gQnV0IGl0DQo+ ID4+IHNlZW1zDQo+ID4+PiB3ZSB3aWxsIGVuY291bnRlciBzb21lIHN0YXRpYyBhbGxvY2F0ZWQg YXJjaF92Y3B1IHByb2JsZW1zIGFuZCBzaXplb2YNCj4gPj4gaXNzdWUuDQo+ID4+DQo+ID4+IERv ZXMgaXQgbmVlZCB0byBiZSBlbWJlZGRlZCBpbiBhcmNoX3ZjcHU/IElmIG5vdCwgdGhlbiB3ZSBj b3VsZA0KPiBhbGxvY2F0ZQ0KPiA+PiBtZW1vcnkgb3V0c2lkZSBhbmQgYWRkIGEgcG9pbnRlciBp biBhcmNoX3ZjcHUuDQo+ID4+DQo+ID4NCj4gPiBXZSBoYWQgdGhvdWdodCB0byB1c2UgYSBwb2lu dGVyIGluIGFyY2hfdmNwdSBpbnN0ZWFkIG9mIGVtYmVkZGluZw0KPiBtcHVfcmVnaW9ucw0KPiA+ IGludG8gYXJjaF92Y3B1LiBCdXQgd2Ugbm90aWNlZCB0aGF0IGFyY2hfdmNwdSBoYXMgYSBfX2Nh Y2hlbGluZV9hbGlnbmVkDQo+ID4gYXR0cmlidXRlLCB0aGlzIG1heSBiZSBiZWNhdXNlIG9mIGFy Y2hfdmNwdSB3aWxsIGJlIHVzZWQgdmVyeSBmcmVxdWVudGx5DQo+ID4gaW4gc29tZSBjcml0aWNh bCBwYXRoLiBTbyBpZiB3ZSB1c2UgdGhlIHBvaW50ZXIgZm9yIG1wdV9yZWdpb25zLCBtYXkNCj4g Y2F1c2UNCj4gPiBzb21lIGNhY2hlIG1pc3MgaW4gdGhlc2UgY3JpdGljYWwgcGF0aCwgZm9yIGV4 YW1wbGUsIGluIGNvbnRleHRfc3d0aWNoLg0KPiANCj4gIEZyb20gbXkgdW5kZXJzdGFuZGluZywg dGhlIGlkZWEgYmVoaW5kIGBgY2FjaGVsaW5lX2FsaWduZWRgYCBpcyB0bw0KPiBhdm9pZCB0aGUg c3RydWN0IHZjcHUgdG8gYmUgc2hhcmVkIHdpdGggb3RoZXIgZGF0YXN0cnVjdHVyZS4gT3RoZXJ3 aXNlDQo+IHlvdSBtYXkgZW5kIHVwIHRvIGhhdmUgdHdvIHBDUFVzIHRvIGZyZXF1ZW50bHkgd3Jp dGUgdGhlIHNhbWUgY2FjaGVsaW5lDQo+IHdoaWNoIGlzIG5vdCBpZGVhbC4NCj4gDQo+IGFyY2hf dmNwdSBzaG91bGQgZW1iYmVkIGFueXRoaW5nIHRoYXQgd2lsbCBiZSBhY2Nlc3NlZCBvZnRlbiAo ZS5nLg0KPiBlbnRyeS9leGl0KSB0byBjZXJ0YWluIHBvaW50LiBGb3IgaW5zdGFuY2UsIG5vdCBl dmVyeXRoaW5nIHJlbGF0ZWQgdG8NCj4gdGhlIHZHSUMgYXJlIGVtYmJlZCBpbiB0aGUgdkNQVS9E b21haW4gc3RydWN0dXJlLg0KPiANCj4gSSBhbSBhIGJpdCBzcGxpdCByZWdhcmRpbmcgdGhlIG1w dV9yZWdpb25zLiBJZiB0aGV5IGFyZSBtYWlubHkgdXNlZCBpbg0KPiB0aGUgY29udGV4dF9zd2l0 Y2goKSB0aGVuIEkgd291bGQgYXJndWUgdGhpcyBpcyBhIHByZW1hdHVyZSBvcHRpbWl6YXRpb24N Cj4gYmVjYXVzZSB0aGUgc2NoZWR1bGluZyBkZWNpc2lvbiBpcyBwcm9iYWJseSBnb2luZyB0byB0 YWtlIGEgbG90IG1vcmUNCj4gdGltZSB0aGFuIHRoZSBjb250ZXh0IHN3aXRjaCBpdHNlbGYuDQoN Cm1wdV9yZWdpb25zIGluIGFyY2hfdmNwdSBhcmUgdXNlZCB0byBzYXZlIGd1ZXN0J3MgRUwxIE1Q VSBjb250ZXh0LiBTbywgeWVzLA0KdGhleSBhcmUgbWFpbmx5IHVzZWQgaW4gY29udGV4dF9zd2l0 Y2guIEluIHRlcm1zIG9mIHRoZSBudW1iZXIgb2YgcmVnaXN0ZXJzLA0KaXQgd2lsbCBzYXZlL3Jl c3RvcmUgbW9yZSB3b3JrIHRoYW4gdGhlIG9yaWdpbmFsIFY4QS4gQW5kIG9uIFY4UiB3ZSBhbHNv IG5lZWQNCnRvIGtlZXAgbW9zdCBvZiB0aGUgb3JpZ2luYWwgVjhBIHNhdmUvcmVzdG9yZSB3b3Jr LiBTbyBpdCB3aWxsIHRha2UgbG9uZ2VyDQp0aGFuIHRoZSBvcmlnaW5hbCBWOEEgY29udGV4dF9z d2l0Y2guIEFuZCBJIHRoaW5rIHRoaXMgaXMgZHVlIHRvIGFyY2hpdGVjdHVyZSdzDQpkaWZmZXJl bmNlLiBTbyBpdCdzIGltcG9zc2libGUgZm9yIHVzIG5vdCB0byBzYXZlL3Jlc3RvcmUgRUwxIE1Q VSByZWdpb24NCnJlZ2lzdGVycyBpbiBjb250ZXh0X3N3aXRjaC4gQW5kIHdlIGhhdmUgZG9uZSBz b21lIG9wdGltaXphdGlvbiBmb3IgRUwxIE1QVQ0Kc2F2ZS9yZXN0b3JlOg0KMS4gQXNzZW1ibHkg Y29kZSBmb3IgRUwxIE1QVSBjb250ZXh0X3N3aXRjaA0KMi4gVXNlIHJlYWwgTVBVIHJlZ2lvbnMg bnVtYmVyIGluc3RlYWQgb2YgQ09ORklHX0FSTV9NUFVfRUwxX1BST1RFQ1RJT05fUkVHSU9OUw0K ICAgaW4gY29udGV4dF9zd2l0Y2guIENPTkZJR19BUk1fTVBVX0VMMV9QUk9URUNUSU9OX1JFR0lP TlMgaXMgZGVmaW5lZCB0aGUgTWF4DQogICBzdXBwb3J0ZWQgRUwxIE1QVSByZWdpb25zIGZvciB0 aGlzIFhlbiBpbWFnZS4gQWxsIHBsYXRmb3JtcyB0aGF0IGltcGxlbWVudA0KICAgRUwxIE1QVSBy ZWdpb25zIGluIHRoaXMgcmFuZ2UgY2FuIHdvcmsgd2VsbCB3aXRoIHRoaXMgWGVuIEltYWdlLiBC dXQgaWYgdGhlDQogICBpbXBsZW1lbnRlZCBFTDEgTVBVIHJlZ2lvbiBudW1iZXIgZXhjZWVkcyBD T05GSUdfQVJNX01QVV9FTDFfUFJPVEVDVElPTl9SRUdJT05TLA0KICAgdGhpcyBYZW4gaW1hZ2Ug Y291bGQgbm90IHdvcmsgd2VsbCBvbiB0aGlzIHBsYXRmb3JtLg0KICANCj4gDQo+IE5vdGUgdGhh dCBmb3IgdGhlIFAyTSB3ZSBhbHJlYWR5IGhhdmUgdGhhdCBpbmRpcmVjdGlvbiBiZWNhdXNlIGl0 IGlzDQo+IGVtYmJlZCBpbiB0aGUgc3RydWN0IGRvbWFpbi4NCg0KSXQncyBkaWZmZXJlbnQgd2l0 aCBWOEEgUDJNIGNhc2UuIEluIFY4QSBjb250ZXh0X3N3aXRjaCB3ZSBqdXN0IG5lZWQgdG8NCnNh dmUvcmVzdG9yZSBWVFRCUiwgd2UgZG9uJ3QgbmVlZCB0byBkbyBQMk0gdGFibGUgd2Fsay4gQnV0 IG9uIFY4Uiwgd2UNCm5lZWQgdG8gYWNjZXNzIHZhbGlkIG1wdV9yZWdpb25zIGZvciBzYXZlL3Jl c3RvcmUuDQoNCj4gDQo+IFRoaXMgcmFpc2VzIG9uZSBxdWVzdGlvbiwgd2h5IGlzIHRoZSBNUFVz IHJlZ2lvbnMgd2lsbCBiZSBwZXItdkNQVQ0KPiByYXRoZXIgcGVyIGRvbWFpbj8NCj4gDQoNCkJl Y2F1c2UgdGhlcmUgaXMgYSBFTDEgTVBVIGNvbXBvbmVudCBmb3IgZWFjaCBwQ1BVLiBXZSBjYW4n dCBhc3N1bWUgZ3Vlc3QNCnRvIHVzZSB0aGUgc2FtZSBFTDEgTVBVIGNvbmZpZ3VyYXRpb24gZm9y IGFsbCB2Q1BVLg0KDQo+IENoZWVycywNCj4gDQo+IC0tDQo+IEp1bGllbiBHcmFsbA0K From xen-devel-bounces@lists.xenproject.org Wed Mar 02 07:14:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 07:14:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281986.480534 (Exim 4.92) (envelope-from ) id 1nPJBa-0008Du-4d; Wed, 02 Mar 2022 07:14:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281986.480534; Wed, 02 Mar 2022 07:14:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPJBa-0008Dn-1S; Wed, 02 Mar 2022 07:14:10 +0000 Received: by outflank-mailman (input) for mailman id 281986; Wed, 02 Mar 2022 07:14:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPJBY-0008Df-9M for xen-devel@lists.xenproject.org; Wed, 02 Mar 2022 07:14:08 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2060b.outbound.protection.outlook.com [2a01:111:f400:7e1b::60b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 57400dca-99f8-11ec-8539-5f4723681683; Wed, 02 Mar 2022 08:14:04 +0100 (CET) Received: from AS9PR0301CA0049.eurprd03.prod.outlook.com (2603:10a6:20b:469::24) by DB6PR0801MB2086.eurprd08.prod.outlook.com (2603:10a6:4:7a::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.14; Wed, 2 Mar 2022 07:14:01 +0000 Received: from VE1EUR03FT029.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:469:cafe::f8) by AS9PR0301CA0049.outlook.office365.com (2603:10a6:20b:469::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.13 via Frontend Transport; Wed, 2 Mar 2022 07:14:00 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT029.mail.protection.outlook.com (10.152.18.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22 via Frontend Transport; Wed, 2 Mar 2022 07:14:00 +0000 Received: ("Tessian outbound 341d209a0e52:v113"); Wed, 02 Mar 2022 07:13:59 +0000 Received: from 14b013f39f5a.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 0F37C026-B26F-4748-A949-738663332DE7.1; Wed, 02 Mar 2022 07:13:49 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 14b013f39f5a.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 02 Mar 2022 07:13:49 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by AM6PR08MB4949.eurprd08.prod.outlook.com (2603:10a6:20b:ee::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.25; Wed, 2 Mar 2022 07:13:45 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::89b3:80a2:2b58:f1aa]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::89b3:80a2:2b58:f1aa%4]) with mapi id 15.20.5038.014; Wed, 2 Mar 2022 07:13:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 57400dca-99f8-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R+GuZmXQOOI8FRMFGhDAIngXggNyEjE1zTaEpblgAj0=; b=0w0MjTtEREJP039zHyU72VBnEJgQnVqUT6laA6twpvzVGf/0tDBcOl1XXfwdHNNI9OjXfXQSH1UuaL3sxe8roy4JETLpSVFBVgi5ITk1aHCOHxTkE4ITrGFzvo+AOrAmtVtvP/1v4zeAZaX/h6t+E1Sju8KU0Dr81jioXiZ+wP4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mNZzB6Lu6XRaki0XJDDP50FPR7nA93VkQlTwt4JlDYX/V8FEqIEMX2Z7QVzHUQ8l/l8rIGX8nn1ctY/Q4e7kArCuV/JCrvk0wxstutNKWx2gQSoQXfePlRd7KCNu7OPNfqv2A5LvQGgi5wBLBLzM6B9TGZWSmxuHYahWKMzzs4fNXX3a7TJ79Ax9qLzLx1Ebqk7rFWFfidnex3zlf7rCXFCLU8ePkrXfmAOTCtTbU4NtelhkHdaZtfmWKL2T7FAX7+VjRBXy9QTfOIZnqwpWtq4Tcfbf4fYgxlKnlsHgwodoWKy1Vfl9RS4pzJnvgeNl7kK3gatRFQ6iCuYwi1n4HQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=R+GuZmXQOOI8FRMFGhDAIngXggNyEjE1zTaEpblgAj0=; b=gu1ugyg4MKMlxeDPzD3CBejuojtlK2gpz3krNtnxY9xuDtFvMmHhcKgtCQt9A6mE0bWn71XeJQhfMQM3wBt9xOohlMgbRm4tXzAkFarJ71bfy+gDS+8vXqU334rjtJTOj7Z+O623hJhiI/93Y0rTAqc0fuEY6Xguabo6BYdL2y8YCijAG8y1DuQ6Jj3WDT2aIIUq4Xcm7jjK9++097cdG17nrNkDoYltAYcaeRqWFihIFslxrN+SfE2stzN/S7efcfL76KnVqkmVX89tlyMBay/tfuHPWM/bUcqPPTf2L8nw5+w803AOdkMRLsf3wg0Il4zbB2NQOzh35m9jNirkbw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R+GuZmXQOOI8FRMFGhDAIngXggNyEjE1zTaEpblgAj0=; b=0w0MjTtEREJP039zHyU72VBnEJgQnVqUT6laA6twpvzVGf/0tDBcOl1XXfwdHNNI9OjXfXQSH1UuaL3sxe8roy4JETLpSVFBVgi5ITk1aHCOHxTkE4ITrGFzvo+AOrAmtVtvP/1v4zeAZaX/h6t+E1Sju8KU0Dr81jioXiZ+wP4= From: Wei Chen To: Stefano Stabellini CC: "xen-devel@lists.xenproject.org" , "julien@xen.org" , Bertrand Marquis , Penny Zheng , Henry Wang , nd Subject: RE: Proposal for Porting Xen to Armv8-R64 - DraftA Thread-Topic: Proposal for Porting Xen to Armv8-R64 - DraftA Thread-Index: AdgpQxtXwh7LkfydTgiYk9bhMgU+ogAn0mUAABEK2UAAHxozAACs/mTQABukuQAADud+gA== Date: Wed, 2 Mar 2022 07:13:44 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 25CFC8A70C8CA143B8947340CFB2DDD0.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: a964d035-844f-4a53-7d0c-08d9fc1c398b x-ms-traffictypediagnostic: AM6PR08MB4949:EE_|VE1EUR03FT029:EE_|DB6PR0801MB2086:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: al51wOamlzRXrHxpPDdk0YY39IpBv2j9H735PwwjJ2bUbAf4omLDKTG3HMVTLsmJLWMQ711vnyKFBHLljewpmbYD7yPpYgmppn2o3R7n0OEoJ3ZwYOl0txxOp2Ts3Hq+YLXoTqkfHv5Qrr7xa4DgRqF4Jy2vz9gRsk0Q01chnMORIzO+JguwvMnTnbsCzaxf44SVTIQ03e7amtzbWKI8KEGM1pum/gtkU2rgo9BdHuu9WkWlsZSGyZplTuAgHN4mxeiPO8iF7+g+q3xU0NH2J7cVspYlewR6oeOssisNqwihHwHeaqnAUaaX9yt+Qxi82i8OmVKRAVpwVXFSGljHxG6pR+9PT8t7tG2K59pAD02HVTEdQ3CO4SrW3FsW+jMxxQ8UMj4LLbSM3C9gCAeEK8gCCDtzrWYwzMv4VCRVo2R3tkyu5oE1kvcGjU+l06T0F4Lc1SNCqXnddm4guuXHQ8Dwei8oSUpw3Kp6Rnp/bmRbVgDZN4y5Sz7FabbJiQ1FaUzTHt0vKNVmOJjIvP7Bn0gpJdEMs+ybpdqfWWRs9SPoLIeXuTLmioZy5zQ1DOvHJ2TDU0J43MvTH2sFTXVCQ3gNmPQz/WKvTMIJuv1YTHJBxq+Trxh4COkf1qlBigWECKa7fMvC30Svg6bHa1m4EZgN8c3L+H+lpVCf5YQW38im0UwWQtazFP7yVVH8TaDxYgjt/fEV7sdolnYD6qTn/pq+L0o4kIK5robJ6fj9qyXRaA7HrEc+IcCWh/5ieWN6gynnqnkN0W6sYxm5sVAj/4suL93Pid7dFMKS7nDbIPLNTHbniWgNcE0ChrajqaWe4JQJdDy6ggYG5Hb1F+/Ad4HI7ls+hMrJiY8Xje/qhIg= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(26005)(86362001)(38100700002)(9686003)(53546011)(6506007)(83380400001)(186003)(71200400001)(7696005)(38070700005)(122000001)(8936002)(30864003)(4326008)(5660300002)(66476007)(8676002)(64756008)(76116006)(66556008)(66446008)(66946007)(33656002)(55016003)(2906002)(6916009)(54906003)(508600001)(966005)(316002)(52536014)(559001)(579004)(139555002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4949 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT029.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 7b895621-a288-417d-1c15-08d9fc1c305a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dEEvbIqvV6WWKxy+oWEwiaRi54DcmO585cFpr37kvRnPHB1BCK2FkCbm6pnza09WYO8gGoWIXnLLalq5scdp81th6FmVJZTmbvx/2GWTRAGBKv+dnkZXQYZ5qW48uZJR9b+6KJ4y+yfvaoY9NEiwEJ7yVZ1sYXbLq1X5pQ2UUaK35Wv8ejwtGvMlKEfkQ9CJZNAud+Q16SOAVRwoGwWfrPwBrp02yHYvqbBnU/gvnMEZ4F7vDJwz99m8SVUMoHBo1ccOG5K16dkgr9vGNlZVnr9nIT8UHNC3zV/x0crGkUY9mmhil3daEy8Tpl8lpnMrHTkeuTRjox6Be45YeJcx41IRIuxGALlaFteVMtgaLr+ytUR3L4GC8BHkn8BatA+9Q07grYH1UyFnGwBA6G+BaguZMgT40HYYbYC6rQGziZ9o3WDim3Frk7V6sy9aK2duwDjW38yrnmJpKfsaEjlBmVt9sa9wUztx/+WKKmN7OARj+SxwMxQ0c4OkRhrEG456ITSIl4FpEmKv86waRrpN9u4UKu0l3qhuAZOYgxGcE89GtOdUU/ZR+bsgS3sgCPhXvHjWBzGXsjkyFH2CkivA0rAWwr1CrtI0hJkJahihwQ9V2n5h6SnEmnsspu4vQvi/NVQ6pNun4KoHLDcK9cg3T8NnHosBEiml4j5IgWPTz9PQqLpwzaSebNPVIaj5KFN3vnOF2SdgMbpMPmPQ0xzd4SfuiNjTbDw6Ms4sFNLqrJCMWDByMt8M6ONgB/0MX1mH9JGzEYPGbJKl6shAX/ug5DlD8cddtk4/dEQZffApZ9fjd24bxpVFZzpZlJvZN/X2UlaP+Vj1jZeIPaaWaQOqOA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(8936002)(36860700001)(336012)(186003)(26005)(54906003)(316002)(82310400004)(9686003)(33656002)(7696005)(53546011)(6506007)(70586007)(70206006)(30864003)(52536014)(4326008)(6862004)(5660300002)(8676002)(508600001)(40460700003)(81166007)(55016003)(86362001)(47076005)(966005)(83380400001)(356005)(2906002)(579004)(139555002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2022 07:14:00.2956 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a964d035-844f-4a53-7d0c-08d9fc1c398b X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT029.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB2086 SGkgU3RlZmFubywNCg0KPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBTdGVm YW5vIFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+DQo+IFNlbnQ6IDIwMjLlubQz 5pyIMuaXpSA3OjM5DQo+IFRvOiBXZWkgQ2hlbiA8V2VpLkNoZW5AYXJtLmNvbT4NCj4gQ2M6IFN0 ZWZhbm8gU3RhYmVsbGluaSA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz47IHhlbi0NCj4gZGV2ZWxA bGlzdHMueGVucHJvamVjdC5vcmc7IGp1bGllbkB4ZW4ub3JnOyBCZXJ0cmFuZCBNYXJxdWlzDQo+ IDxCZXJ0cmFuZC5NYXJxdWlzQGFybS5jb20+OyBQZW5ueSBaaGVuZyA8UGVubnkuWmhlbmdAYXJt LmNvbT47IEhlbnJ5IFdhbmcNCj4gPEhlbnJ5LldhbmdAYXJtLmNvbT47IG5kIDxuZEBhcm0uY29t Pg0KPiBTdWJqZWN0OiBSRTogUHJvcG9zYWwgZm9yIFBvcnRpbmcgWGVuIHRvIEFybXY4LVI2NCAt IERyYWZ0QQ0KPiANCj4gT24gVHVlLCAxIE1hciAyMDIyLCBXZWkgQ2hlbiB3cm90ZToNCj4gPiA+ IE9uIEZyaSwgMjUgRmViIDIwMjIsIFdlaSBDaGVuIHdyb3RlOg0KPiA+ID4gPiA+IEhpIFdlaSwN Cj4gPiA+ID4gPg0KPiA+ID4gPiA+IFRoaXMgaXMgZXh0cmVtZWx5IGV4Y2l0aW5nLCB0aGFua3Mg Zm9yIHRoZSB2ZXJ5IG5pY2Ugc3VtbWFyeSENCj4gPiA+ID4gPg0KPiA+ID4gPiA+DQo+ID4gPiA+ ID4gT24gVGh1LCAyNCBGZWIgMjAyMiwgV2VpIENoZW4gd3JvdGU6DQo+ID4gPiA+ID4gPiAjIFBy b3Bvc2FsIGZvciBQb3J0aW5nIFhlbiB0byBBcm12OC1SNjQNCj4gPiA+ID4gPiA+DQo+ID4gPiA+ ID4gPiBUaGlzIHByb3Bvc2FsIHdpbGwgaW50cm9kdWNlIHRoZSBQb0Mgd29yayBvZiBwb3J0aW5n IFhlbiB0bw0KPiBBcm12OC0NCj4gPiA+IFI2NCwNCj4gPiA+ID4gPiA+IHdoaWNoIGluY2x1ZGVz Og0KPiA+ID4gPiA+ID4gLSBUaGUgY2hhbmdlcyBvZiBjdXJyZW50IFhlbiBjYXBhYmlsaXR5LCBs aWtlIFhlbiBidWlsZCBzeXN0ZW0sDQo+ID4gPiBtZW1vcnkNCj4gPiA+ID4gPiA+wqDCoCBtYW5h Z2VtZW50LCBkb21haW4gbWFuYWdlbWVudCwgdkNQVSBjb250ZXh0IHN3aXRjaC4NCj4gPiA+ID4g PiA+IC0gVGhlIGV4cGFuZGVkIFhlbiBjYXBhYmlsaXR5LCBsaWtlIHN0YXRpYy1hbGxvY2F0aW9u IGFuZA0KPiBkaXJlY3QtbWFwLg0KPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ICoqKk5vdGVzOioq Kg0KPiA+ID4gPiA+ID4gMS4gKioqVGhpcyBwcm9wb3NhbCBvbmx5IGNvdmVycyB0aGUgd29yayBv ZiBwb3J0aW5nIFhlbiB0bw0KPiBBcm12OC0NCj4gPiA+IFI2NCoqKg0KPiA+ID4gPiA+ID7CoMKg wqAgKioqc2luZ2xlIENQVS4gWGVuIFNNUCBzdXBwb3J0IG9uIEFybXY4LVI2NCByZWxhdGVzIHRv IEFybXY4LQ0KPiBSKioqDQo+ID4gPiA+ID4gPsKgwqDCoCAqKipUcnVzdGVkLUZyaW13YXJlIChU Ri1SKS4gVGhpcyBpcyBhbiBleHRlcm5hbA0KPiBkZXBlbmRlbmN5LCoqKg0KPiA+ID4gPiA+ID7C oMKgwqAgKioqc28gd2UgdGhpbmsgdGhlIGRpc2N1c3Npb24gb2YgWGVuIFNNUCBzdXBwb3J0IG9u IEFybXY4LQ0KPiBSNjQqKioNCj4gPiA+ID4gPiA+wqDCoMKgICoqKnNob3VsZCBiZSBzdGFydGVk IHdoZW4gc2luZ2xlLUNQVSBzdXBwb3J0IGlzIGNvbXBsZXRlLioqKg0KPiA+ID4gPiA+ID4gMi4g KioqVGhpcyBwcm9wb3NhbCB3aWxsIG5vdCB0b3VjaCB4ZW4tdG9vbHMuIEluIGN1cnJlbnQNCj4g c3RhZ2UsKioqDQo+ID4gPiA+ID4gPsKgwqDCoCAqKipYZW4gb24gQXJtdjgtUjY0IG9ubHkgc3Vw cG9ydCBkb20wbGVzcywgYWxsIGd1ZXN0cw0KPiBzaG91bGQqKioNCj4gPiA+ID4gPiA+wqDCoMKg ICoqKmJlIGJvb3RlZCBmcm9tIGRldmljZSB0cmVlLioqKg0KPiA+ID4gPiA+ID4NCj4gPiA+ID4g PiA+ICMjIDEuIEVzc2VudGlhbCBCYWNrZ3JvdW5kDQo+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4g IyMjIDEuMS4gQXJtdjgtUjY0IFByb2ZpbGUNCj4gPiA+ID4gPiA+IFRoZSBBcm12LVIgYXJjaGl0 ZWN0dXJlIHByb2ZpbGUgd2FzIGRlc2lnbmVkIHRvIHN1cHBvcnQgdXNlDQo+IGNhc2VzDQo+ID4g PiB0aGF0DQo+ID4gPiA+ID4gPiBoYXZlIGEgaGlnaCBzZW5zaXRpdml0eSB0byBkZXRlcm1pbmlz dGljIGV4ZWN1dGlvbi4gKGUuZy4gRnVlbA0KPiA+ID4gSW5qZWN0aW9uLA0KPiA+ID4gPiA+ID4g QnJha2UgY29udHJvbCwgRHJpdmUgdHJhaW5zLCBNb3RvciBjb250cm9sIGV0YykNCj4gPiA+ID4g PiA+DQo+ID4gPiA+ID4gPiBBcm0gYW5ub3VuY2VkIEFybXY4LVIgaW4gMjAxMywgaXQgaXMgdGhl IGxhdGVzdCBnZW5lcmF0aW9uIEFybQ0KPiA+ID4gPiA+IGFyY2hpdGVjdHVyZQ0KPiA+ID4gPiA+ ID4gdGFyZ2V0ZWQgYXQgdGhlIFJlYWwtdGltZSBwcm9maWxlLiBJdCBpbnRyb2R1Y2VzIHZpcnR1 YWxpemF0aW9uDQo+IGF0DQo+ID4gPiB0aGUNCj4gPiA+ID4gPiBoaWdoZXN0DQo+ID4gPiA+ID4g PiBzZWN1cml0eSBsZXZlbCB3aGlsZSByZXRhaW5pbmcgdGhlIFByb3RlY3RlZCBNZW1vcnkgU3lz dGVtDQo+ID4gPiBBcmNoaXRlY3R1cmUNCj4gPiA+ID4gPiAoUE1TQSkNCj4gPiA+ID4gPiA+IGJh c2VkIG9uIGEgTWVtb3J5IFByb3RlY3Rpb24gVW5pdCAoTVBVKS4gSW4gMjAyMCwgQXJtIGFubm91 bmNlZA0KPiA+ID4gQ29ydGV4LQ0KPiA+ID4gPiA+IFI4MiwNCj4gPiA+ID4gPiA+IHdoaWNoIGlz IHRoZSBmaXJzdCBBcm0gNjQtYml0IENvcnRleC1SIHByb2Nlc3NvciBiYXNlZCBvbiBBcm12OC0N Cj4gUjY0Lg0KPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+IC0gVGhlIGxhdGVzdCBBcm12OC1SNjQg ZG9jdW1lbnQgY2FuIGJlIGZvdW5kIGhlcmU6DQo+ID4gPiA+ID4gPsKgwqAgW0FybSBBcmNoaXRl Y3R1cmUgUmVmZXJlbmNlIE1hbnVhbCBTdXBwbGVtZW50IC0gQXJtdjgsIGZvcg0KPiBBcm12OC1S DQo+ID4gPiA+ID4gQUFyY2g2NCBhcmNoaXRlY3R1cmUNCj4gPiA+ID4gPiBwcm9maWxlXShodHRw czovL2RldmVsb3Blci5hcm0uY29tL2RvY3VtZW50YXRpb24vZGRpMDYwMC9sYXRlc3QvKS4NCj4g PiA+ID4gPiA+DQo+ID4gPiA+ID4gPiAtIEFybXYtUiBBcmNoaXRlY3R1cmUgcHJvZ3Jlc3Npb246 DQo+ID4gPiA+ID4gPsKgwqAgQXJtdjctUiAtPiBBcm12OC1SIEFBcmNoMzIgLT4gQXJtdjggQUFy Y2g2NA0KPiA+ID4gPiA+ID7CoMKgIFRoZSBmb2xsb3dpbmcgZmlndXJlIGlzIGEgc2ltcGxlIGNv bXBhcmlzb24gb2YgIlIiIHByb2Nlc3NvcnMNCj4gPiA+IGJhc2VkIG9uDQo+ID4gPiA+ID4gPsKg wqAgZGlmZmVyZW50IEFybXYtUiBBcmNoaXRlY3R1cmVzLg0KPiA+ID4gPiA+ID7CoMKgICFbaW1h Z2VdKGh0dHBzOi8vZHJpdmUuZ29vZ2xlLmNvbS91Yz9leHBvcnQ9dmlldyZpZD0xbkU1UkFYYVg4 DQo+IHpZMksNCj4gPiA+IFBaOGkNCj4gPiA+ID4gPiBtQnBidklyMmVxQmd1RUIpDQo+ID4gPiA+ ID4gPg0KPiA+ID4gPiA+ID4gLSBUaGUgQXJtdjgtUiBhcmNoaXRlY3R1cmUgZXZvbHZlZCBhZGRp dGlvbmFsIGZlYXR1cmVzIG9uIHRvcCBvZg0KPiA+ID4gQXJtdjctUjoNCj4gPiA+ID4gPiA+wqDC oMKgwqAgLSBBbiBleGNlcHRpb24gbW9kZWwgdGhhdCBpcyBjb21wYXRpYmxlIHdpdGggdGhlIEFy bXY4LUENCj4gbW9kZWwNCj4gPiA+ID4gPiA+wqDCoMKgwqAgLSBWaXJ0dWFsaXphdGlvbiB3aXRo IHN1cHBvcnQgZm9yIGd1ZXN0IG9wZXJhdGluZyBzeXN0ZW1zDQo+ID4gPiA+ID4gPsKgwqDCoMKg wqDCoMKgwqAgLSBQTVNBIHZpcnR1YWxpemF0aW9uIHVzaW5nIE1QVXMgSW4gRUwyLg0KPiA+ID4g PiA+ID4gLSBUaGUgbmV3IGZlYXR1cmVzIG9mIEFybXY4LVI2NCBhcmNoaXRlY3R1cmUNCj4gPiA+ ID4gPiA+wqDCoMKgwqAgLSBBZGRzIHN1cHBvcnQgZm9yIHRoZSA2NC1iaXQgQTY0IGluc3RydWN0 aW9uIHNldCwNCj4gcHJldmlvdXNseQ0KPiA+ID4gQXJtdjgtDQo+ID4gPiA+ID4gUg0KPiA+ID4g PiA+ID7CoMKgwqDCoMKgwqAgb25seSBzdXBwb3J0ZWQgQTMyLg0KPiA+ID4gPiA+ID7CoMKgwqDC oCAtIFN1cHBvcnRzIHVwIHRvIDQ4LWJpdCBwaHlzaWNhbCBhZGRyZXNzaW5nLCBwcmV2aW91c2x5 IHVwDQo+IHRvDQo+ID4gPiAzMi1iaXQNCj4gPiA+ID4gPiA+wqDCoMKgwqDCoMKgIGFkZHJlc3Np bmcgd2FzIHN1cHBvcnRlZC4NCj4gPiA+ID4gPiA+wqDCoMKgwqAgLSBPcHRpb25hbCBBcm0gTmVv biB0ZWNobm9sb2d5IGFuZCBBZHZhbmNlZCBTSU1EDQo+ID4gPiA+ID4gPsKgwqDCoMKgIC0gU3Vw cG9ydHMgdGhyZWUgRXhjZXB0aW9uIExldmVscyAoRUxzKQ0KPiA+ID4gPiA+ID7CoMKgwqDCoMKg wqDCoMKgIC0gU2VjdXJlIEVMMiAtIFRoZSBIaWdoZXN0IFByaXZpbGVnZSwgTVBVIG9ubHksIGZv cg0KPiBmaXJtd2FyZSwNCj4gPiA+ID4gPiBoeXBlcnZpc29yDQo+ID4gPiA+ID4gPsKgwqDCoMKg wqDCoMKgwqAgLSBTZWN1cmUgRUwxIC0gUmljaE9TIChNTVUpIG9yIFJUT1MgKE1QVSkNCj4gPiA+ ID4gPiA+wqDCoMKgwqDCoMKgwqDCoCAtIFNlY3VyZSBFTDAgLSBBcHBsaWNhdGlvbiBXb3JrbG9h ZHMNCj4gPiA+ID4gPiA+wqDCoMKgwqAgLSBPcHRpb25hbGx5IHN1cHBvcnRzIFZpcnR1YWwgTWVt b3J5IFN5c3RlbSBBcmNoaXRlY3R1cmUgYXQNCj4gUy0NCj4gPiA+IEVMMS9TLQ0KPiA+ID4gPiA+ IEVMMC4NCj4gPiA+ID4gPiA+wqDCoMKgwqDCoMKgIFRoaXMgbWVhbnMgaXQncyBwb3NzaWJsZSB0 byBydW4gcmljaCBPUyBrZXJuZWxzIC0gbGlrZQ0KPiBMaW51eCAtDQo+ID4gPiA+ID4gZWl0aGVy DQo+ID4gPiA+ID4gPsKgwqDCoMKgwqDCoCBiYXJlLW1ldGFsIG9yIGFzIGEgZ3Vlc3QuDQo+ID4g PiA+ID4gPiAtIERpZmZlcmVuY2VzIHdpdGggdGhlIEFybXY4LUEgQUFyY2g2NCBhcmNoaXRlY3R1 cmUNCj4gPiA+ID4gPiA+wqDCoMKgwqAgLSBTdXBwb3J0cyBvbmx5IGEgc2luZ2xlIFNlY3VyaXR5 IHN0YXRlIC0gU2VjdXJlLiBUaGVyZSBpcw0KPiBub3QNCj4gPiA+IE5vbi0NCj4gPiA+ID4gPiBT ZWN1cmUNCj4gPiA+ID4gPiA+wqDCoMKgwqDCoMKgIGV4ZWN1dGlvbiBzdGF0ZSBzdXBwb3J0ZWQu DQo+ID4gPiA+ID4gPsKgwqDCoMKgIC0gRUwzIGlzIG5vdCBzdXBwb3J0ZWQsIEVMMiBpcyBtYW5k YXRvcnkuIFRoaXMgbWVhbnMgc2VjdXJlDQo+IEVMMg0KPiA+ID4gaXMNCj4gPiA+ID4gPiB0aGUN Cj4gPiA+ID4gPiA+wqDCoMKgwqDCoMKgIGhpZ2hlc3QgRUwuDQo+ID4gPiA+ID4gPsKgwqDCoMKg IC0gU3VwcG9ydHMgdGhlIEE2NCBJU0EgaW5zdHJ1Y3Rpb24NCj4gPiA+ID4gPiA+wqDCoMKgwqDC oMKgwqDCoCAtIFdpdGggYSBzbWFsbCBzZXQgb2Ygd2VsbC1kZWZpbmVkIGRpZmZlcmVuY2VzDQo+ ID4gPiA+ID4gPsKgwqDCoMKgIC0gUHJvdmlkZXMgYSBQTVNBIChQcm90ZWN0ZWQgTWVtb3J5IFN5 c3RlbSBBcmNoaXRlY3R1cmUpDQo+IGJhc2VkDQo+ID4gPiA+ID4gPsKgwqDCoMKgwqDCoCB2aXJ0 dWFsaXphdGlvbiBtb2RlbC4NCj4gPiA+ID4gPiA+wqDCoMKgwqDCoMKgwqDCoCAtIEFzIG9wcG9z ZWQgdG8gQXJtdjgtQSBBQXJjaDY0J3MgVk1TQSBiYXNlZA0KPiBWaXJ0dWFsaXphdGlvbg0KPiA+ ID4gPiA+ID7CoMKgwqDCoMKgwqDCoMKgIC0gQ2FuIHN1cHBvcnQgYWRkcmVzcyBiaXRzIHVwIHRv IDUyIGlmIEZFQVRfTFBBIGlzDQo+IGVuYWJsZWQsDQo+ID4gPiA+ID4gPsKgwqDCoMKgwqDCoMKg wqDCoMKgIG90aGVyd2lzZSA0OCBiaXRzLg0KPiA+ID4gPiA+ID7CoMKgwqDCoMKgwqDCoMKgIC0g RGV0ZXJtaW5lcyB0aGUgYWNjZXNzIHBlcm1pc3Npb25zIGFuZCBtZW1vcnkNCj4gYXR0cmlidXRl cyBvZg0KPiA+ID4gPiA+ID7CoMKgwqDCoMKgwqDCoMKgwqDCoCB0aGUgdGFyZ2V0IFBBLg0KPiA+ ID4gPiA+ID7CoMKgwqDCoMKgwqDCoMKgIC0gQ2FuIGltcGxlbWVudCBQTVNBdjgtNjQgYXQgRUwx IGFuZCBFTDINCj4gPiA+ID4gPiA+wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIC0gQWRkcmVzcyB0 cmFuc2xhdGlvbiBmbGF0LW1hcHMgdGhlIFZBIHRvIHRoZSBQQSBmb3INCj4gRUwyDQo+ID4gPiA+ ID4gU3RhZ2UgMS4NCj4gPiA+ID4gPiA+wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIC0gQWRkcmVz cyB0cmFuc2xhdGlvbiBmbGF0LW1hcHMgdGhlIFZBIHRvIHRoZSBQQSBmb3INCj4gRUwxDQo+ID4g PiA+ID4gU3RhZ2UgMS4NCj4gPiA+ID4gPiA+wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIC0gQWRk cmVzcyB0cmFuc2xhdGlvbiBmbGF0LW1hcHMgdGhlIElQQSB0byB0aGUgUEENCj4gZm9yDQo+ID4g PiBFTDENCj4gPiA+ID4gPiBTdGFnZSAyLg0KPiA+ID4gPiA+ID7CoMKgwqDCoCAtIFBNU0EgaW4g RUwxICYgRUwyIGlzIGNvbmZpZ3VyYWJsZSwgVk1TQSBpbiBFTDEgaXMNCj4gY29uZmlndXJhYmxl Lg0KPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ICMjIyAxLjIuIFhlbiBDaGFsbGVuZ2VzIHdpdGgg UE1TQSBWaXJ0dWFsaXphdGlvbg0KPiA+ID4gPiA+ID4gWGVuIGlzIFBNU0EgdW5hd2FyZSBUeXBl LTEgSHlwZXJ2aXNvciwgaXQgd2lsbCBuZWVkDQo+IG1vZGlmaWNhdGlvbnMgdG8NCj4gPiA+IHJ1 bg0KPiA+ID4gPiA+ID4gd2l0aCBhbiBNUFUgYW5kIGhvc3QgbXVsdGlwbGUgZ3Vlc3QgT1Nlcy4N Cj4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiAtIE5vIE1NVSBhdCBFTDI6DQo+ID4gPiA+ID4gPsKg wqDCoMKgIC0gTm8gRUwyIFN0YWdlIDEgYWRkcmVzcyB0cmFuc2xhdGlvbg0KPiA+ID4gPiA+ID7C oMKgwqDCoMKgwqDCoMKgIC0gWGVuIHByb3ZpZGVzIGZpeGVkIEFSTTY0IHZpcnR1YWwgbWVtb3J5 IGxheW91dCBhcw0KPiBiYXNpcyBvZg0KPiA+ID4gRUwyDQo+ID4gPiA+ID4gPsKgwqDCoMKgwqDC oMKgwqDCoMKgIHN0YWdlIDEgYWRkcmVzcyB0cmFuc2xhdGlvbiwgd2hpY2ggaXMgbm90IGFwcGxp Y2FibGUNCj4gb24NCj4gPiA+IE1QVQ0KPiA+ID4gPiA+IHN5c3RlbSwNCj4gPiA+ID4gPiA+wqDC oMKgwqDCoMKgwqDCoMKgwqAgd2hlcmUgdGhlcmUgaXMgbm8gdmlydHVhbCBhZGRyZXNzaW5nLiBB cyBhIHJlc3VsdCwgYW55DQo+ID4gPiA+ID4gb3BlcmF0aW9uDQo+ID4gPiA+ID4gPsKgwqDCoMKg wqDCoMKgwqDCoMKgIGludm9sdmluZyB0cmFuc2l0aW9uIGZyb20gUEEgdG8gVkEsIGxpa2UgaW9y ZW1hcCwNCj4gbmVlZHMNCj4gPiA+ID4gPiBtb2RpZmljYXRpb24NCj4gPiA+ID4gPiA+wqDCoMKg wqDCoMKgwqDCoMKgwqAgb24gTVBVIHN5c3RlbS4NCj4gPiA+ID4gPiA+wqDCoMKgwqAgLSBYZW4n cyBydW4tdGltZSBhZGRyZXNzZXMgYXJlIHRoZSBzYW1lIGFzIHRoZSBsaW5rIHRpbWUNCj4gPiA+ IGFkZHJlc3Nlcy4NCj4gPiA+ID4gPiA+wqDCoMKgwqDCoMKgwqDCoCAtIEVuYWJsZSBQSUMgKHBv c2l0aW9uLWluZGVwZW5kZW50IGNvZGUpIG9uIGEgcmVhbC10aW1lDQo+ID4gPiB0YXJnZXQNCj4g PiA+ID4gPiA+wqDCoMKgwqDCoMKgwqDCoMKgwqAgcHJvY2Vzc29yIHByb2JhYmx5IHZlcnkgcmFy ZS4NCj4gPiA+ID4gPiA+wqDCoMKgwqAgLSBYZW4gd2lsbCBuZWVkIHRvIHVzZSB0aGUgRUwyIE1Q VSBtZW1vcnkgcmVnaW9uIGRlc2NyaXB0b3JzDQo+IHRvDQo+ID4gPiA+ID4gbWFuYWdlDQo+ID4g PiA+ID4gPsKgwqDCoMKgwqDCoCBhY2Nlc3MgcGVybWlzc2lvbnMgYW5kIGF0dHJpYnV0ZXMgZm9y IGFjY2Vzc2VzIG1hZGUgYnkgVk1zDQo+IGF0DQo+ID4gPiA+ID4gRUwxLzAuDQo+ID4gPiA+ID4g PsKgwqDCoMKgwqDCoMKgwqAgLSBYZW4gY3VycmVudGx5IHJlbGllcyBvbiBNTVUgRUwxIHN0YWdl IDIgdGFibGUgdG8NCj4gbWFuYWdlDQo+ID4gPiB0aGVzZQ0KPiA+ID4gPiA+ID7CoMKgwqDCoMKg wqDCoMKgwqDCoCBhY2Nlc3Nlcy4NCj4gPiA+ID4gPiA+IC0gTm8gTU1VIFN0YWdlIDIgdHJhbnNs YXRpb24gYXQgRUwxOg0KPiA+ID4gPiA+ID7CoMKgwqDCoCAtIEEgZ3Vlc3QgZG9lc24ndCBoYXZl IGFuIGluZGVwZW5kZW50IGd1ZXN0IHBoeXNpY2FsIGFkZHJlc3MNCj4gPiA+IHNwYWNlDQo+ID4g PiA+ID4gPsKgwqDCoMKgIC0gQSBndWVzdCBjYW4gbm90IHJldXNlIHRoZSBjdXJyZW50IEludGVy bWVkaWF0ZSBQaHlzaWNhbA0KPiA+ID4gQWRkcmVzcw0KPiA+ID4gPiA+ID7CoMKgwqDCoMKgwqAg bWVtb3J5IGxheW91dA0KPiA+ID4gPiA+ID7CoMKgwqDCoCAtIEEgZ3Vlc3QgdXNlcyBwaHlzaWNh bCBhZGRyZXNzZXMgdG8gYWNjZXNzIG1lbW9yeSBhbmQNCj4gZGV2aWNlcw0KPiA+ID4gPiA+ID7C oMKgwqDCoCAtIFRoZSBNUFUgYXQgRUwyIG1hbmFnZXMgRUwxIHN0YWdlIDIgYWNjZXNzIHBlcm1p c3Npb25zIGFuZA0KPiA+ID4gPiA+IGF0dHJpYnV0ZXMNCj4gPiA+ID4gPiA+IC0gVGhlcmUgYXJl IGEgbGltaXRlZCBudW1iZXIgb2YgTVBVIHByb3RlY3Rpb24gcmVnaW9ucyBhdCBib3RoDQo+IEVM Mg0KPiA+ID4gYW5kDQo+ID4gPiA+ID4gRUwxOg0KPiA+ID4gPiA+ID7CoMKgwqDCoCAtIEFyY2hp dGVjdHVyYWxseSwgdGhlIG1heGltdW0gbnVtYmVyIG9mIHByb3RlY3Rpb24gcmVnaW9ucw0KPiBp cw0KPiA+ID4gMjU2LA0KPiA+ID4gPiA+ID7CoMKgwqDCoMKgwqAgdHlwaWNhbCBpbXBsZW1lbnRh dGlvbnMgaGF2ZSAzMi4NCj4gPiA+ID4gPiA+wqDCoMKgwqAgLSBCeSBjb250cmFzdCwgWGVuIGRv ZXMgbm90IG5lZWQgdG8gY29uc2lkZXIgdGhlIG51bWJlciBvZg0KPiBwYWdlDQo+ID4gPiA+ID4g dGFibGUNCj4gPiA+ID4gPiA+wqDCoMKgwqDCoMKgIGVudHJpZXMgaW4gdGhlb3J5IHdoZW4gdXNp bmcgTU1VLg0KPiA+ID4gPiA+ID4gLSBUaGUgTVBVIHByb3RlY3Rpb24gcmVnaW9ucyBhdCBFTDIg bmVlZCB0byBiZSBzaGFyZWQgYmV0d2Vlbg0KPiB0aGUNCj4gPiA+ID4gPiBoeXBlcnZpc29yDQo+ ID4gPiA+ID4gPsKgwqAgYW5kIHRoZSBndWVzdCBzdGFnZSAyLg0KPiA+ID4gPiA+ID7CoMKgwqDC oCAtIFJlcXVpcmVzIGNhcmVmdWwgY29uc2lkZXJhdGlvbiAtIG1heSBpbXBhY3QgZmVhdHVyZQ0K PiAnZnVsbG5lc3MnDQo+ID4gPiBvZg0KPiA+ID4gPiA+IGJvdGgNCj4gPiA+ID4gPiA+wqDCoMKg wqDCoMKgIHRoZSBoeXBlcnZpc29yIGFuZCB0aGUgZ3Vlc3QNCj4gPiA+ID4gPiA+wqDCoMKgwqAg LSBCeSBjb250cmFzdCwgd2hlbiB1c2luZyBNTVUsIFhlbiBoYXMgc3RhbmRhbG9uZSBQMk0gdGFi bGUNCj4gZm9yDQo+ID4gPiA+ID4gZ3Vlc3QNCj4gPiA+ID4gPiA+wqDCoMKgwqDCoMKgIHN0YWdl IDIgYWNjZXNzZXMuDQo+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gIyMgMi4gUHJvcG9zZWQgY2hh bmdlcyBvZiBYZW4NCj4gPiA+ID4gPiA+ICMjIyAqKjIuMS4gQ2hhbmdlcyBvZiBidWlsZCBzeXN0 ZW06KioNCj4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiAtICoqKkludHJvZHVjZSBuZXcgS2NvbmZp ZyBvcHRpb25zIGZvciBBcm12OC1SNjQqKio6DQo+ID4gPiA+ID4gPsKgwqAgVW5saWtlIEFybXY4 LUEsIGJlY2F1c2UgbGFjayBvZiBNTVUgc3VwcG9ydCBvbiBBcm12OC1SNjQsIHdlDQo+IG1heQ0K PiA+ID4gbm90DQo+ID4gPiA+ID4gPsKgwqAgZXhwZWN0IG9uZSBYZW4gYmluYXJ5IHRvIHJ1biBv biBhbGwgbWFjaGluZXMuIFhlbiBpbWFnZXMgYXJlDQo+IG5vdA0KPiA+ID4gPiA+IGNvbW1vbg0K PiA+ID4gPiA+ID7CoMKgIGFjcm9zcyBBcm12OC1SNjQgcGxhdGZvcm1zLiBYZW4gbXVzdCBiZSBy ZS1idWlsdCBmb3IgZGlmZmVyZW50DQo+ID4gPiBBcm12OC0NCj4gPiA+ID4gPiBSNjQNCj4gPiA+ ID4gPiA+wqDCoCBwbGF0Zm9ybXMuIEJlY2F1c2UgdGhlc2UgcGxhdGZvcm1zIG1heSBoYXZlIGRp ZmZlcmVudCBtZW1vcnkNCj4gPiA+IGxheW91dA0KPiA+ID4gPiA+IGFuZA0KPiA+ID4gPiA+ID7C oMKgIGxpbmsgYWRkcmVzcy4NCj4gPiA+ID4gPiA+wqDCoMKgwqAgLSBgQVJNNjRfVjhSYDoNCj4g PiA+ID4gPiA+wqDCoMKgwqDCoMKgIFRoaXMgb3B0aW9uIGVuYWJsZXMgQXJtdjgtUiBwcm9maWxl IGZvciBBcm02NC4gRW5hYmxpbmcNCj4gdGhpcw0KPiA+ID4gPiA+IG9wdGlvbg0KPiA+ID4gPiA+ ID7CoMKgwqDCoMKgwqAgcmVzdWx0cyBpbiBzZWxlY3RpbmcgTVBVLiBUaGlzIEtjb25maWcgb3B0 aW9uIGlzIHVzZWQgdG8NCj4gZ2F0ZQ0KPiA+ID4gc29tZQ0KPiA+ID4gPiA+ID7CoMKgwqDCoMKg wqAgQXJtdjgtUjY0IHNwZWNpZmljIGNvZGUgZXhjZXB0IE1QVSBjb2RlLCBsaWtlIHNvbWUgY29k ZQ0KPiBmb3INCj4gPiA+IEFybXY4LQ0KPiA+ID4gPiA+IFI2NA0KPiA+ID4gPiA+ID7CoMKgwqDC oMKgwqAgb25seSBzeXN0ZW0gSUQgcmVnaXN0ZXJzIGFjY2Vzcy4NCj4gPiA+ID4gPiA+DQo+ID4g PiA+ID4gPsKgwqDCoMKgIC0gYEFSTV9NUFVgDQo+ID4gPiA+ID4gPsKgwqDCoMKgwqDCoCBUaGlz IG9wdGlvbiBlbmFibGVzIE1QVSBvbiBBUk12OC1SIGFyY2hpdGVjdHVyZS4gRW5hYmxpbmcNCj4g dGhpcw0KPiA+ID4gPiA+IG9wdGlvbg0KPiA+ID4gPiA+ID7CoMKgwqDCoMKgwqAgcmVzdWx0cyBp biBkaXNhYmxpbmcgTU1VLiBUaGlzIEtjb25maWcgb3B0aW9uIGlzIHVzZWQgdG8NCj4gZ2F0ZQ0K PiA+ID4gc29tZQ0KPiA+ID4gPiA+ID7CoMKgwqDCoMKgwqAgQVJNX01QVSBzcGVjaWZpYyBjb2Rl LiBPbmNlIHdoZW4gdGhpcyBLY29uZmlnIG9wdGlvbiBoYXMNCj4gYmVlbg0KPiA+ID4gPiA+IGVu YWJsZWQsDQo+ID4gPiA+ID4gPsKgwqDCoMKgwqDCoCB0aGUgTU1VIHJlbGF0ZSBjb2RlIHdpbGwg bm90IGJlIGJ1aWx0IGZvciBBcm12OC1SNjQuIFRoZQ0KPiA+ID4gcmVhc29uDQo+ID4gPiA+ID4g d2h5DQo+ID4gPiA+ID4gPsKgwqDCoMKgwqDCoCBub3QgZGVwZW5kcyBvbiBydW50aW1lIGRldGVj dGlvbiB0byBzZWxlY3QgTU1VIG9yIE1QVSBpcw0KPiB0aGF0LA0KPiA+ID4gd2UNCj4gPiA+ID4g PiBkb24ndA0KPiA+ID4gPiA+ID7CoMKgwqDCoMKgwqAgdGhpbmsgd2UgY2FuIHVzZSBvbmUgaW1h Z2UgZm9yIGJvdGggQXJtdjgtUjY0IGFuZCBBcm12OC0NCj4gQTY0Lg0KPiA+ID4gPiA+IEFub3Ro ZXINCj4gPiA+ID4gPiA+wqDCoMKgwqDCoMKgIHJlYXNvbiB0aGF0IHdlIHNlcGFyYXRlIE1QVSBh bmQgVjhSIGluIHByb3Zpc2lvbiB0byBhbGxvdw0KPiB0bw0KPiA+ID4gPiA+IHN1cHBvcnQgTVBV DQo+ID4gPiA+ID4gPsKgwqDCoMKgwqDCoCBvbiAzMmJpdCBBcm0gb25lIGRheS4NCj4gPiA+ID4g PiA+DQo+ID4gPiA+ID4gPsKgwqDCoMKgIC0gYFhFTl9TVEFSVF9BRERSRVNTYA0KPiA+ID4gPiA+ ID7CoMKgwqDCoMKgwqAgVGhpcyBvcHRpb24gYWxsb3dzIHRvIHNldCB0aGUgY3VzdG9tIGFkZHJl c3MgYXQgd2hpY2ggWGVuDQo+IHdpbGwNCj4gPiA+IGJlDQo+ID4gPiA+ID4gPsKgwqDCoMKgwqDC oCBsaW5rZWQuIFRoaXMgYWRkcmVzcyBtdXN0IGJlIGFsaWduZWQgdG8gYSBwYWdlIHNpemUuIFhl bidzDQo+ID4gPiBydW4tDQo+ID4gPiA+ID4gdGltZQ0KPiA+ID4gPiA+ID7CoMKgwqDCoMKgwqAg YWRkcmVzc2VzIGFyZSB0aGUgc2FtZSBhcyB0aGUgbGluayB0aW1lIGFkZHJlc3Nlcy4NCj4gRGlm ZmVyZW50DQo+ID4gPiA+ID4gcGxhdGZvcm1zDQo+ID4gPiA+ID4gPsKgwqDCoMKgwqDCoCBtYXkg aGF2ZSBkaWZmZXJudCBtZW1vcnkgbGF5b3V0LiBUaGlzIEtjb25maWcgb3B0aW9uDQo+IHByb3Zp ZGVzDQo+ID4gPiA+ID4gdXNlcnMNCj4gPiA+ID4gPiA+wqDCoMKgwqDCoMKgIHRoZSBhYmlsaXR5 IHRvIHNlbGVjdCBwcm9wZXIgbGluayBhZGRyZXNzZXMgZm9yIHRoZWlyDQo+IGJvYXJkcy4NCj4g PiA+ID4gPiA+wqDCoMKgwqDCoMKgICoqKk5vdGVzOiBGaXhlZCBsaW5rIGFkZHJlc3MgbWVhbnMg dGhlIFhlbiBiaW5hcnkgY291bGQNCj4gbm90DQo+ID4gPiBiZSoqKg0KPiA+ID4gPiA+ID7CoMKg wqDCoMKgwqAgKioqcmVsb2NhdGVkIGJ5IEVGSSBsb2FkZXIuIFNvIGluIGN1cnJlbnQgc3RhZ2Us IFhlbiBjb3VsZA0KPiA+ID4gbm90KioqDQo+ID4gPiA+ID4gPsKgwqDCoMKgwqDCoCAqKipiZSBs YXVuY2hlZCBhcyBhbiBFRkkgYXBwbGljYXRpb24gb24gQXJtdjgtUjY0LioqKg0KPiA+ID4gPiA+ ID4NCj4gPiA+ID4gPiA+wqDCoMKgwqAgLSBgQVJNX01QVV9OT1JNQUxfTUVNT1JZX1NUQVJUYCBh bmQNCj4gYEFSTV9NUFVfTk9STUFMX01FTU9SWV9FTkRgDQo+ID4gPiA+ID4gPsKgwqDCoMKgwqDC oCBgQVJNX01QVV9ERVZJQ0VfTUVNT1JZX1NUQVJUYCBhbmQNCj4gYEFSTV9NUFVfREVWSUNFX01F TU9SWV9FTkRgDQo+ID4gPiA+ID4gPsKgwqDCoMKgwqDCoCBUaGVzZSBLY29uZmlnIG9wdGlvbnMg YWxsb3cgdG8gc2V0IG1lbW9yeSByZWdpb25zIGZvciBYZW4NCj4gY29kZSwNCj4gPiA+ID4gPiBk YXRhDQo+ID4gPiA+ID4gPsKgwqDCoMKgwqDCoCBhbmQgZGV2aWNlIG1lbW9yeS4gQmVmb3JlIHBh cnNpbmcgbWVtb3J5IGluZm9ybWF0aW9uIGZyb20NCj4gPiA+IGRldmljZQ0KPiA+ID4gPiA+IHRy ZWUsDQo+ID4gPiA+ID4gPsKgwqDCoMKgwqDCoCBYZW4gd2lsbCB1c2UgdGhlIHZhbHVlcyB0aGF0 IHN0b3JlZCBpbiB0aGVzZSBvcHRpb25zIHRvDQo+IHNldHVwDQo+ID4gPiA+ID4gYm9vdC10aW1l DQo+ID4gPiA+ID4gPsKgwqDCoMKgwqDCoCBNUFUgY29uZmlndXJhdGlvbi4gV2h5IHdlIG5lZWQg YSBib290LXRpbWUgTVBVDQo+IGNvbmZpZ3VyYXRpb24/DQo+ID4gPiA+ID4gPsKgwqDCoMKgwqDC oCAxLiBNb3JlIGRldGVybWluaXN0aWM6IEFybSBNUFUgc3VwcG9ydHMgYmFja2dyb3VuZCByZWdp b25zLA0KPiA+ID4gPiA+ID7CoMKgwqDCoMKgwqDCoMKgwqAgaWYgd2UgZG9uJ3QgY29uZmlndXJl IHRoZSBNUFUgcmVnaW9ucyBhbmQgZG9uJ3QgZW5hYmxlDQo+IE1QVS4NCj4gPiA+ID4gPiA+wqDC oMKgwqDCoMKgwqDCoMKgIFdlIGNhbiBlbmFibGUgTVBVIGJhY2tncm91bmQgcmVnaW9ucy4gQnV0 IHRoYXQgbWVhbnMNCj4gYWxsDQo+ID4gPiBSQU0NCj4gPiA+ID4gPiA+wqDCoMKgwqDCoMKgwqDC oMKgIGlzIFJXWC4gUmFuZG9tIHZhbHVlcyBpbiBSQU0gb3IgbWFsaWNpb3VzbHkgZW1iZWRkZWQN Cj4gZGF0YQ0KPiA+ID4gY2FuDQo+ID4gPiA+ID4gPsKgwqDCoMKgwqDCoMKgwqDCoCBiZSBleHBs b2l0ZWQuIFVzaW5nIHRoZXNlIEtjb25maWcgb3B0aW9ucyBhbGxvdyB1c2Vycw0KPiB0bw0KPiA+ ID4gaGF2ZQ0KPiA+ID4gPiA+ID7CoMKgwqDCoMKgwqDCoMKgwqAgYSBkZXRlcm1pbmlzdGljIFJB TSBhcmVhIHRvIGV4ZWN1dGUgY29kZS4NCj4gPiA+ID4gPiA+wqDCoMKgwqDCoMKgIDIuIE1vcmUg Y29tcGF0aWJsZTogT24gc29tZSBBcm12OC1SNjQgcGxhdGZvcm1zLCBpZiB0aGUNCj4gTVBVIGlz DQo+ID4gPiA+ID4gPsKgwqDCoMKgwqDCoMKgwqDCoCBkaXNhYmxlZCwgdGhlIGBkYyB6dmFgIGlu c3RydWN0aW9uIHdpbGwgbWFrZSB0aGUgc3lzdGVtDQo+ID4gPiBoYWx0Lg0KPiA+ID4gPiA+ID7C oMKgwqDCoMKgwqDCoMKgwqAgQW5kIHRoaXMgaW5zdHJ1Y3Rpb24gd2lsbCBiZSBlbWJlZGRlZCBp biBzb21lIGJ1aWx0LWluDQo+ID4gPiA+ID4gZnVuY3Rpb25zLA0KPiA+ID4gPiA+ID7CoMKgwqDC oMKgwqDCoMKgwqAgbGlrZSBgbWVtb3J5IHNldGAuIElmIHdlIHVzZSBgLWRkb250X3VzZV9kY2Ag dG8gcmVidWlsZA0KPiBHQ0MsDQo+ID4gPiA+ID4gPsKgwqDCoMKgwqDCoMKgwqDCoCB0aGUgYnVp bHQtaW4gZnVuY3Rpb25zIHdpbGwgbm90IGNvbnRhaW4gYGRjIHp2YWAuDQo+IEhvd2V2ZXIsDQo+ ID4gPiBpdA0KPiA+ID4gPiA+IGlzDQo+ID4gPiA+ID4gPsKgwqDCoMKgwqDCoMKgwqDCoCBvYnZp b3VzbHkgdW5saWtlbHkgdGhhdCB3ZSB3aWxsIGJlIGFibGUgdG8gcmVjb21waWxlDQo+IGFsbA0K PiA+ID4gR0NDDQo+ID4gPiA+ID4gPsKgwqDCoMKgwqDCoMKgwqDCoCBmb3IgQVJNdjgtUjY0Lg0K PiA+ID4gPiA+ID7CoMKgwqDCoMKgwqAgMy4gT25lIG9wdGlvbmFsIGlkZWE6DQo+ID4gPiA+ID4g PsKgwqDCoMKgwqDCoMKgwqDCoMKgIFdlIGNhbiBtYXAgYFhFTl9TVEFSVF9BRERSRVNTYCB0byBg WEVOX1NUQVJUX0FERFJFU1MgKw0KPiA+ID4gMk1CYCBvcg0KPiA+ID4gPiA+ID7CoMKgwqDCoMKg wqDCoMKgwqDCoCBgWEVOX1NUQVJUX0FERFJFU1NgIHRvIGBYRU5fU1RBUlRfQUREUkVTUyArIGlt YWdlX2VuZGANCj4gZm9yDQo+ID4gPiA+ID4gPsKgwqDCoMKgwqDCoMKgwqDCoMKgIE1QVSBub3Jt YWwgbWVtb3J5LiBJdCdzIGVub3VnaCB0byBzdXBwb3J0IFhlbiBydW4gaW4NCj4gYm9vdA0KPiA+ ID4gdGltZS4NCj4gPiA+ID4gPg0KPiA+ID4gPiA+IEkgY2FuIGltYWdpbmUgdGhhdCB3ZSBuZWVk IHRvIGhhdmUgYSBkaWZmZXJlbnQgWGVuIGJ1aWxkIGZvciBlYWNoDQo+ID4gPiA+ID4gQVJNdjgt UiBwbGF0Zm9ybS4gRG8geW91IGVudmlzaW9uIHRoYXQgWEVOX1NUQVJUX0FERFJFU1MgYW5kDQo+ ID4gPiA+ID4gQVJNX01QVV8qX01FTU9SWV9TVEFSVC9FTkQgYXJlIHByZWNvbmZpZ3VyZWQgYmFz ZWQgb24gdGhlIHBsYXRmb3JtDQo+ID4gPiA+ID4gY2hvaWNlIGF0IGJ1aWxkIHRpbWU/IEkgZG9u J3QgdGhpbmsgd2Ugd2FudCBhIHVzZXIgdG8gcHJvdmlkZSBhbGwNCj4gb2YNCj4gPiA+ID4gPiB0 aG9zZSBhZGRyZXNzZXMgYnkgaGFuZCwgcmlnaHQ/DQo+ID4gPiA+DQo+ID4gPiA+IFllcywgdGhp cyBpcyBpbiBvdXIgVE9ETyBsaXN0LiBXZSB3YW50IHRvIHJldXNlIGN1cnJlbnQNCj4gYXJtL3Bs YXRmb3Jtcw0KPiA+ID4gYW5kDQo+ID4gPiA+IEtjb25maWcgbWVudSBmb3IgQXJtdjgtUi4NCj4g PiA+DQo+ID4gPiBPSywgZ29vZA0KPiA+ID4NCj4gPiA+DQo+ID4gPiA+ID4gVGhlIG5leHQgcXVl c3Rpb24gaXMgd2hldGhlciB3ZSBjb3VsZCBhdXRvbWF0aWNhbGx5IGdlbmVyYXRlDQo+ID4gPiA+ ID4gWEVOX1NUQVJUX0FERFJFU1MgYW5kIEFSTV9NUFVfKl9NRU1PUllfU1RBUlQvRU5EIGJhc2Vk IG9uIHRoZQ0KPiBwbGF0Zm9ybQ0KPiA+ID4gPiA+IGRldmljZSB0cmVlIGF0IGJ1aWxkIHRpbWUg KGF0IGJ1aWxkIHRpbWUsIG5vdCBydW50aW1lKS4gVGhhdCB3b3VsZA0KPiA+ID4gPiA+IG1ha2Ug dGhpbmdzIGEgbG90IGVhc2llciBhbmQgaXQgaXMgYWxzbyBhbGlnbmVkIHdpdGggdGhlIHdheQ0K PiBaZXBoeXINCj4gPiA+IGFuZA0KPiA+ID4gPiA+IG90aGVyIFJUT1NlcyBhbmQgYmFyZW1ldGFs IGFwcHMgd29yay4NCj4gPiA+ID4NCj4gPiA+ID4gSXQncyBhIGNvbnNpZGVyYWJsZSBvcHRpb24u IEJ1dCBoZXJlIHdlIG1heSBlbmNvdW50ZXIgc29tZSBwcm9ibGVtcw0KPiBuZWVkDQo+ID4gPiA+ IHRvIGJlIHNvbHZlZCBmaXJzdDoNCj4gPiA+ID4gMS4gRG9lcyBDT05GSUdfRFRCIG11c3QgYmUg c2VsZWN0ZWQgYnkgZGVmYXVsdCBvbiBBcm12OC1SPyBXaXRob3V0DQo+ID4gPiBmaXJtd2FyZQ0K PiA+ID4gPiDCoMKgIG9yIGJvb3Rsb2FkZXIgKGxpa2UgdS1ib290KSwgd2UgaGF2ZSB0byBidWls ZCBEVEIgaW50byBYZW4gYmluYXJ5Lg0KPiA+ID4NCj4gPiA+IENPTkZJR19EVEIgc2hvdWxkIHRy aWdnZXIgcnVudGltZSBzdXBwb3J0IGZvciBkZXZpY2UgdHJlZSwgd2hpbGUgaGVyZQ0KPiB3ZQ0K PiA+ID4gYXJlIHRhbGtpbmcgYWJvdXQgYnVpbGQgdGltZSBzdXBwb3J0IGZvciBkZXZpY2UgdHJl ZS4gSXQgaXMgdmVyeQ0KPiA+ID4gZGlmZmVyZW50Lg0KPiA+ID4NCj4gPiA+IEp1c3QgdG8gbWFr ZSBhbiBleGFtcGxlLCB0aGUgd2hvbGUgYnVpbGQtdGltZSBkZXZpY2UgdHJlZSBjb3VsZCBiZQ0K PiA+ID4gc2Nhbm5lZCBieSBNYWtlZmlsZXMgYW5kIG90aGVyIHNjcmlwdHMsIGxlYWRpbmcgdG8g QyBoZWFkZXIgZmlsZXMNCj4gPiA+IGdlbmVyYXRpb25zLCBidXQgbm8gY29kZSBpbiBYZW4gdG8g cGFyc2UgZGV2aWNlIHRyZWUgYXQgYWxsLg0KPiA+ID4NCj4gPiA+IERUQiAtLS0+IE1ha2VmaWxl cy9zY3JpcHRzIC0tLT4gLmggZmlsZXMgLS0tPiBNYWtlZmlsZXMvc2NyaXB0cyAtLS0+DQo+IHhl bg0KPiA+ID4NCj4gPg0KPiA+IFllcywgdGhpcyBpcyBmZWFzaWJsZS4NCj4gPg0KPiA+ID4NCj4g PiA+IEkgYW0gbm90IHNheWluZyB0aGlzIGlzIHRoZSBiZXN0IHdheSB0byBkbyBpdCwgSSBhbSBv bmx5IHBvaW50aW5nIG91dA0KPiA+ID4gdGhhdCBidWlsZC10aW1lIGRldmljZSB0cmVlIGRvZXMg bm90IGltcGx5IHJ1bi10aW1lIGRldmljZSB0cmVlLiBBbHNvLA0KPiA+ID4gaXQgZG9lc24ndCBp bXBseSBhIERUQiBidWlsdC1pbiB0aGUgWGVuIGJpbmFyeSAoYWx0aG91Z2ggdGhhdCBpcyBhbHNv DQo+IGFuDQo+ID4gPiBvcHRpb24pLg0KPiA+ID4NCj4gPg0KPiA+IEkgYWdyZWUuDQo+ID4NCj4g PiA+IFRoZSB3YXkgbWFueSBiYXJlbWV0YWwgT1NlcyBhbmQgUlRPU2VzIHdvcmsgaXMgdGhhdCB0 aGV5IHRha2UgYSBEVEIgYXMNCj4gPiA+IGlucHV0IHRvIHRoZSBidWlsZCAqb25seSouIEZyb20g dGhlIERUQiwgdGhlIGJ1aWxkLXRpbWUgbWFrZSBzeXN0ZW0NCj4gPiA+IGdlbmVyYXRlcyAjZGVm aW5lcyBhbmQgaGVhZGVyIGZpbGVzIHRoYXQgYXJlIGltcG9ydGVkIGluIEMuDQo+ID4gPg0KPiA+ ID4gVGhlIHJlc3VsdGluZyBSVE9TIGJpbmFyeSBkb2Vzbid0IG5lZWQgc3VwcG9ydCBmb3IgRFRC LCBiZWNhdXNlIGFsbA0KPiB0aGUNCj4gPiA+IHJpZ2h0IGFkZHJlc3NlcyBoYXZlIGFscmVhZHkg YmVlbiBwcm92aWRlZCBhcyAjZGVmaW5lIGJ5IHRoZSBNYWtlDQo+ID4gPiBzeXN0ZW0uDQo+ID4g Pg0KPiA+ID4gSSBkb24ndCB0aGluayB3ZSBuZWVkIHRvIGdvIHRvIHRoZSBleHRyZW1lIG9mIHJl bW92aW5nIERUQiBzdXBwb3J0DQo+IGZyb20NCj4gPiA+IFhlbiBvbiBBUk12OC1SLiBJIGFtIG9u bHkgc2F5aW5nIHRoYXQgaWYgd2UgYWRkIGJ1aWxkLXRpbWUgZGV2aWNlIHRyZWUNCj4gPiA+IHN1 cHBvcnQgaXQgd291bGQgbWFrZSBpdCBlYXNpZXIgdG8gc3VwcG9ydCBtdWx0aXBsZSBib2FyZHMg d2l0aG91dA0KPiA+ID4gaGF2aW5nIHRvIGhhdmUgcGxhdGZvcm0gZmlsZXMgaW4gWGVuIGZvciBl YWNoIG9mIHRoZW0sIGFuZCB3ZSBjYW4gZG8NCj4gPiA+IHRoYXQgd2l0aG91dCBhbnkgaW1wYWN0 IG9uIHJ1bnRpbWUgZGV2aWNlIHRyZWUgcGFyc2luZy4NCj4gPiA+DQo+ID4NCj4gPiBBcyBWOFIn cyB1c2UgY2FzZXMgbWF5YmUgbWFpbmx5IGZvY3VzIG9uIHNvbWUgcmVhbC10aW1lL2NyaXRpY2Fs DQo+IHNjZW5hcmlvcywNCj4gPiB0aGlzIG1heSBiZSBhIGJldHRlciBtZXRob2QgdGhhbiBwbGF0 Zm9ybSBmaWxlcy4gV2UgZG9uJ3QgbmVlZCB0bw0KPiBtYWludGFpbg0KPiA+IHRoZSBwbGF0Zm9y bSByZWxhdGVkIGRlZmluaXRpb25zIGhlYWRlciBmaWxlcy4gWGVuIGFsc28gY2FuIHNraXAgdGhl DQo+IHNvbWUNCj4gPiBwbGF0Zm9ybSBpbmZvcm1hdGlvbiBwYXJzaW5nIGluIGJvb3QgdGltZS4g VGhpcyB3aWxsIGluY3JlYXNlIHRoZSBib290DQo+IHNwZWVkDQo+ID4gb2YgWGVuIGluIHJlYWwt dGltZS9jcml0aWNhbCBzY2VuYXJpb3MuDQo+IA0KPiArMQ0KPiANCj4gDQo+ID4gPiA+ICAgIFRo aXMNCj4gPiA+ID4gwqDCoCBjYW4gZ3VhcmFudGVlIGJ1aWxkLXRpbWUgRFRCIGlzIHRoZSBzYW1l IGFzIHJ1bnRpbWUgRFRCLiBCdXQNCj4gPiA+IGV2ZW50dWFsbHksDQo+ID4gPiA+IMKgwqAgd2Ug d2lsbCBoYXZlIGZpcm13YXJlIGFuZCBib290bG9hZGVyIGJlZm9yZSBYZW4gbGF1bmNoIChhcyBB cm0NCj4gRUJCUidzDQo+ID4gPiA+IMKgwqAgcmVxdWlyZW1lbnQpLiBJbiB0aGlzIGNhc2UsIHdl IG1heSBub3QgYnVpbGQgRFRCIGludG8gWGVuIGltYWdlLg0KPiBBbmQNCj4gPiA+ID4gwqDCoCB3 ZSBjYW4ndCBndWFyYW50ZWUgYnVpbGQtdGltZSBEVEIgaXMgdGhlIHNhbWUgYXMgcnVudGltZSBE VEIuDQo+ID4gPg0KPiA+ID4gQXMgbWVudGlvbmVkLCBpZiB3ZSBoYXZlIGEgYnVpbGQtdGltZSBE VEIgd2UgbWlnaHQgbm90IG5lZWQgYSBydW4tdGltZQ0KPiA+ID4gRFRCLiBTZWNvbmRseSwgSSB0 aGluayBpdCBpcyBlbnRpcmVseSByZWFzb25hYmxlIHRvIGV4cGVjdCB0aGF0IHRoZQ0KPiA+ID4g YnVpbGQtdGltZSBEVEIgYW5kIHRoZSBydW4tdGltZSBEVEIgYXJlIHRoZSBzYW1lLg0KPiA+ID4N Cj4gPg0KPiA+IFllcywgaWYgd2UgaW1wbGVtZW50IGluIHRoaXMgd2F5LCB3ZSBzaG91bGQgZGVz Y3JpYmUgaXQgaW4gbGltaXRhdGlvbg0KPiA+IG9mIHY4ciBYZW4uDQo+ID4NCj4gPiA+IEl0IGlz IHRoZSBzYW1lIHByb2JsZW0gd2l0aCBwbGF0Zm9ybSBmaWxlczogd2UgaGF2ZSB0byBhc3N1bWUg dGhhdCB0aGUNCj4gPiA+IGluZm9ybWF0aW9uIGluIHRoZSBwbGF0Zm9ybSBmaWxlcyBtYXRjaGVz IHRoZSBydW50aW1lIERUQi4NCj4gPiA+DQo+ID4NCj4gPiBpbmRlZWQuDQo+ID4NCj4gPiA+DQo+ ID4gPiA+IDIuIElmIGJ1aWxkLXRpbWUgRFRCIGlzIHRoZSBzYW1lIGFzIHJ1bnRpbWUgRFRCLCBo b3cgY2FuIHdlDQo+IGRldGVybWluZQ0KPiA+ID4gPiDCoMKgIHRoZSBYRU5fU1RBUlRfQUREUkVT UyBpbiBEVEIgZGVzY3JpYmUgbWVtb3J5IHJhbmdlPyBTaG91bGQgd2UNCj4gYWx3YXlzDQo+ID4g PiA+IMKgwqAgbGltaXQgWGVuIHRvIGJvb3QgZnJvbSBsb3dlc3QgYWRkcmVzcz8gT3Igd2lsbCB3 ZSBpbnRyb2R1Y2Ugc29tZQ0KPiBuZXcNCj4gPiA+ID4gwqDCoCBEVCBwcm9wZXJ0eSB0byBzcGVj aWZ5IHRoZSBYZW4gc3RhcnQgYWRkcmVzcz8gSSB0aGluayB0aGlzIERUDQo+ID4gPiBwcm9wZXJ0 eQ0KPiA+ID4gPiDCoMKgIGFsc28gY2FuIHNvbHZlIGFib3ZlIHF1ZXN0aW9uIzEuDQo+ID4gPg0K PiA+ID4gVGhlIGxvYWRpbmcgYWRkcmVzcyBzaG91bGQgYmUgYXV0b21hdGljYWxseSBjaG9zZW4g YnkgdGhlIGJ1aWxkDQo+IHNjcmlwdHMuDQo+ID4gPiBXZSBjYW4gZG8gdGhhdCBub3cgd2l0aCBJ bWFnZUJ1aWxkZXIgWzFdOiBpdCBzZWxlY3RzIGEgMk1CLWFsaWduZWQNCj4gPiA+IGFkZHJlc3Mg Zm9yIGVhY2ggYmluYXJ5IHRvIGxvYWQsIG9uZSBieSBvbmUgc3RhcnRpbmcgZnJvbSBhIDJNQiBv ZmZzZXQNCj4gPiA+IGZyb20gc3RhcnQgb2YgbWVtb3J5Lg0KPiA+ID4NCj4gPiA+IFsxXSBodHRw czovL2dpdGxhYi5jb20vVmlyeWFPUy9pbWFnZWJ1aWxkZXIvLQ0KPiAvYmxvYi9tYXN0ZXIvc2Ny aXB0cy91Ym9vdC0NCj4gPiA+IHNjcmlwdC1nZW4jTDM5MA0KPiA+ID4NCj4gPiA+IFNvIHRoZSBi dWlsZCBzY3JpcHRzIGNhbiBzZWxlY3QgWEVOX1NUQVJUX0FERFJFU1MgYmFzZWQgb24gdGhlDQo+ ID4gPiBtZW1vcnkgbm9kZSBpbmZvcm1hdGlvbiBvbiB0aGUgYnVpbGQtdGltZSBkZXZpY2UgdHJl ZS4gQW5kIHRoZXJlDQo+IHNob3VsZA0KPiA+ID4gYmUgbm8gbmVlZCB0byBhZGQgWEVOX1NUQVJU X0FERFJFU1MgdG8gdGhlIHJ1bnRpbWUgZGV2aWNlIHRyZWUuDQo+ID4gPg0KPiA+DQo+ID4gVGhp cyBpcyBmaW5lIGlmIHRoZXJlIGFyZSBubyBleHBsaWNpdCByZXN0cmljdGlvbnMgb24gdGhlIHBs YXRmb3JtLg0KPiA+IFNvbWUgcGxhdGZvcm0gbWF5IHJlc2VydmUgc29tZSBtZW1vcnkgYXJlYSBm b3Igc29tZXRoaW5nIGxpa2UgZmlybXdhcmUsDQo+ID4gQnV0IEkgdGhpbmsgaXQncyBPSywgaW4g dGhlIHdvcnN0IGNhc2UsIHdlIGNhbiBoaWRlIHRoaXMgYXJlYSBmcm9tDQo+ID4gYnVpbGQgRFRC Lg0KPiA+DQo+ID4gPg0KPiA+ID4gPiA+IFRoZSBkZXZpY2UgdHJlZSBjYW4gYmUgZ2l2ZW4gYXMg aW5wdXQgdG8gdGhlIGJ1aWxkIHN5c3RlbSwgYW5kIHRoZQ0KPiA+ID4gPiA+IE1ha2VmaWxlcyB3 b3VsZCB0YWtlIGNhcmUgb2YgZ2VuZXJhdGluZyBYRU5fU1RBUlRfQUREUkVTUyBhbmQNCj4gPiA+ ID4gPiBBUk1fTVBVXypfTUVNT1JZX1NUQVJUL0VORCBiYXNlZCBvbiAvbWVtb3J5IGFuZCBvdGhl ciBpbnRlcmVzdGluZw0KPiA+ID4gbm9kZXMuDQo+ID4gPiA+ID4NCj4gPiA+ID4NCj4gPiA+ID4g SWYgd2UgY2FuIHNvbHZlIGFib3ZlIHF1ZXN0aW9ucywgeWVzLCBkZXZpY2UgdHJlZSBpcyBhIGdv b2QgaWRlYSBmb3INCj4gPiA+ID4gWEVOX1NUQVJUX0FERFJFU1MuIEZvciBBUk1fTVBVX05PUk1B TF9NRU1PUllfKiwgd2UgY2FuIGdldCB0aGVtIGZyb20NCj4gPiA+ID4gbWVtb3J5IG5vZGVzLCBi dXQgZm9yIEFSTV9NUFVfREVWSUNFX01FTU9SWV8qLCB0aGV5IGFyZSBub3QgZWFzeSBmb3INCj4g PiA+ID4gdXMgdG8gc2NhbiBhbGwgZGV2aWNlcycgbm9kZXMuIEFuZCBpdCdzIHZlcnkgdHJpY2t5 LCBpZiB0aGUgbWVtb3J5DQo+ID4gPiA+IHJlZ2lvbnMgYXJlIGludGVybGVhdmVkLiBTbyBpbiBv dXIgY3VycmVudCBSRkMgY29kZSwgd2Ugc2VsZWN0IHRvDQo+IHVzZQ0KPiA+ID4gPiB0aGUgb3B0 aW9uYWwgaWRlYToNCj4gPiA+ID4gV2UgbWFwIGBYRU5fU1RBUlRfQUREUkVTU2AgdG8gYFhFTl9T VEFSVF9BRERSRVNTICsgMk1CYCBmb3IgTVBVDQo+IG5vcm1hbA0KPiA+ID4gbWVtb3J5Lg0KPiA+ ID4gPiBCdXQgd2UgdXNlIG1wdSxkZXZpY2UtbWVtb3J5LXNlY3Rpb24gaW4gRFQgZm9yIE1QVSBk ZXZpY2UgbWVtb3J5Lg0KPiA+ID4NCj4gPiA+IEtlZXAgaW4gbWluZCB0aGF0IHdlIGFyZSB0YWxr aW5nIGFib3V0IGJ1aWxkLXRpbWUgc2NyaXB0czogaXQgZG9lc24ndA0KPiA+ID4gbWF0dGVyIGlm IHRoZXkgYXJlIHNsb3cuIFdlIGNhbiBzY2FuIHRoZSBidWlsZC10aW1lIGR0YiBhcyBtYW55IHRp bWUNCj4gYXMNCj4gPiA+IG5lZWRlZCBhbmQgZ2VuZXJhdGUgQVJNX01QVV9ERVZJQ0VfTUVNT1JZ XyogYXMgYXBwcm9wcmlhdGUuIEl0IG1pZ2h0DQo+ID4gPiBtYWtlICJtYWtlIHhlbiIgc2xvd2Vy IGJ1dCBydW50aW1lIHdpbGwgYmUgdW5hZmZlY3RlZC4NCj4gPiA+DQo+ID4gPiBTbywgSSBkb24n dCB0aGluayB0aGlzIGlzIGEgcHJvYmxlbS4NCj4gPiA+DQo+ID4NCj4gPiBPSy4NCj4gPg0KPiA+ ID4NCj4gPiA+ID4gPiA+IC0gKioqRGVmaW5lIG5ldyBzeXN0ZW0gcmVnaXN0ZXJzIGZvciBjb21w aWxlcnMqKio6DQo+ID4gPiA+ID4gPsKgwqAgQXJtdjgtUjY0IGlzIGJhc2VkIG9uIEFybXY4LjQu IFRoYXQgbWVhbnMgd2Ugd2lsbCB1c2Ugc29tZQ0KPiBBcm12OC40DQo+ID4gPiA+ID4gPsKgwqAg c3BlY2lmaWMgc3lzdGVtIHJlZ2lzdGVycy4gQXMgQXJtdjgtUjY0IG9ubHkgaGF2ZSBzZWN1cmUg c3RhdGUsDQo+IHNvDQo+ID4gPiA+ID4gPsKgwqAgYXQgbGVhc3QsIGBWU1RDUl9FTDJgIGFuZCBg VlNDVExSX0VMMmAgd2lsbCBiZSB1c2VkIGZvciBYZW4uDQo+IEFuZA0KPiA+ID4gdGhlDQo+ID4g PiA+ID4gPsKgwqAgZmlyc3QgR0NDIHZlcnNpb24gdGhhdCBzdXBwb3J0cyBBcm12OC40IGlzIEdD QyA4LjEuIEluDQo+IGFkZGl0aW9uIHRvDQo+ID4gPiA+ID4gPsKgwqAgdGhlc2UsIFBNU0Egb2Yg QXJtdjgtUjY0IGludHJvZHVjZWQgbG90cyBvZiBNUFUgcmVsYXRlZCBzeXN0ZW0NCj4gPiA+ID4g PiByZWdpc3RlcnM6DQo+ID4gPiA+ID4gPsKgwqAgYFBSQkFSX0VMeGAsIGBQUkJBUnhfRUx4YCwg YFBSTEFSX0VMeGAsIGBQUkxBUnhfRUx4YCwNCj4gYFBSRU5SX0VMeGANCj4gPiA+IGFuZA0KPiA+ ID4gPiA+ID7CoMKgIGBNUFVJUl9FTHhgLiBCdXQgdGhlIGZpcnN0IEdDQyB2ZXJzaW9uIHRvIHN1 cHBvcnQgdGhlc2Ugc3lzdGVtDQo+ID4gPiA+ID4gcmVnaXN0ZXJzDQo+ID4gPiA+ID4gPsKgwqAg aXMgR0NDIDExLiBTbyB3ZSBoYXZlIHR3byB3YXlzIHRvIG1ha2UgY29tcGlsZXJzIHRvIHdvcmsN Cj4gcHJvcGVybHkNCj4gPiA+IHdpdGgNCj4gPiA+ID4gPiA+wqDCoCB0aGVzZSBzeXN0ZW0gcmVn aXN0ZXJzLg0KPiA+ID4gPiA+ID7CoMKgIDEuIEJ1bXAgR0NDIHZlcnNpb24gdG8gR0NDIDExLg0K PiA+ID4gPiA+ID7CoMKgwqDCoMKgIFRoZSBwcm9zIG9mIHRoaXMgbWV0aG9kIGlzIHRoYXQsIHdl IGRvbid0IG5lZWQgdG8gZW5jb2RlDQo+IHRoZXNlDQo+ID4gPiA+ID4gPsKgwqDCoMKgwqAgc3lz dGVtIHJlZ2lzdGVycyBpbiBtYWNyb3MgYnkgb3Vyc2VsdmVzLiBCdXQgdGhlIGNvbnMgYXJlDQo+ IHRoYXQsDQo+ID4gPiA+ID4gPsKgwqDCoMKgwqAgd2UgaGF2ZSB0byB1cGRhdGUgTWFrZWZpbGVz IHRvIHN1cHBvcnQgR0NDIDExIGZvciBBcm12OC1SNjQuDQo+ID4gPiA+ID4gPsKgwqDCoMKgwqAg MS4xLiBDaGVjayB0aGUgR0NDIHZlcnNpb24gMTEgZm9yIEFybXY4LVI2NC4NCj4gPiA+ID4gPiA+ wqDCoMKgwqDCoCAxLjIuIEFkZCBtYXJjaD1hcm12OHIgdG8gQ0ZMQUdTIGZvciBBcm12OC1SNjQu DQo+ID4gPiA+ID4gPsKgwqDCoMKgwqAgMS4zLiBTb2x2ZSB0aGUgY29uZmxpY3Rpb24gb2YgbWFy Y2g9YXJtdjhyIGFuZCBtY3B1PWdlbmVyaWMNCj4gPiA+ID4gPiA+wqDCoMKgwqAgVGhlc2UgY2hh bmdlcyB3aWxsIGFmZmVjdCBjb21tb24gTWFrZWZpbGVzLCBub3Qgb25seSBBcm0NCj4gPiA+IE1h a2VmaWxlcy4NCj4gPiA+ID4gPiA+wqDCoMKgwqAgQW5kIEdDQyAxMSBpcyBuZXcsIGxvdHMgb2Yg dG9vbGNoYWlucyBhbmQgRGlzdHJvIGhhdmVuJ3QNCj4gPiA+IHN1cHBvcnRlZA0KPiA+ID4gPiA+ IGl0Lg0KPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+wqDCoCAyLiBFbmNvZGUgbmV3IHN5c3RlbSBy ZWdpc3RlcnMgaW4gbWFjcm9zICoqKihwcmVmZXJyZWQpKioqDQo+ID4gPiA+ID4gPsKgwqDCoMKg wqDCoMKgwqAgYGBgDQo+ID4gPiA+ID4gPsKgwqDCoMKgwqDCoMKgwqAgLyogVmlydHVhbGl6YXRp b24gU2VjdXJlIFRyYW5zbGF0aW9uIENvbnRyb2wgUmVnaXN0ZXIgKi8NCj4gPiA+ID4gPiA+wqDC oMKgwqDCoMKgwqDCoCAjZGVmaW5lIFZTVENSX0VMMsKgIFMzXzRfQzJfQzZfMg0KPiA+ID4gPiA+ ID7CoMKgwqDCoMKgwqDCoMKgIC8qIFZpcnR1YWxpemF0aW9uIFN5c3RlbSBDb250cm9sIFJlZ2lz dGVyICovDQo+ID4gPiA+ID4gPsKgwqDCoMKgwqDCoMKgwqAgI2RlZmluZSBWU0NUTFJfRUwyIFMz XzRfQzJfQzBfMA0KPiA+ID4gPiA+ID7CoMKgwqDCoMKgwqDCoMKgIC8qIEVMMSBNUFUgUHJvdGVj dGlvbiBSZWdpb24gQmFzZSBBZGRyZXNzIFJlZ2lzdGVyDQo+IGVuY29kZSAqLw0KPiA+ID4gPiA+ ID7CoMKgwqDCoMKgwqDCoMKgICNkZWZpbmUgUFJCQVJfRUwxwqAgUzNfMF9DNl9DOF8wDQo+ID4g PiA+ID4gPsKgwqDCoMKgwqDCoMKgwqAgLi4uDQo+ID4gPiA+ID4gPsKgwqDCoMKgwqDCoMKgwqAg LyogRUwyIE1QVSBQcm90ZWN0aW9uIFJlZ2lvbiBCYXNlIEFkZHJlc3MgUmVnaXN0ZXINCj4gZW5j b2RlICovDQo+ID4gPiA+ID4gPsKgwqDCoMKgwqDCoMKgwqAgI2RlZmluZSBQUkJBUl9FTDLCoCBT M180X0M2X0M4XzANCj4gPiA+ID4gPiA+wqDCoMKgwqDCoMKgwqDCoCAuLi4NCj4gPiA+ID4gPiA+ wqDCoMKgwqDCoMKgwqDCoCBgYGANCj4gPiA+ID4gPiA+wqDCoMKgwqDCoCBJZiB3ZSBlbmNvZGUg YWxsIGFib3ZlIHN5c3RlbSByZWdpc3RlcnMsIHdlIGRvbid0IG5lZWQgdG8NCj4gYnVtcA0KPiA+ ID4gR0NDDQo+ID4gPiA+ID4gPsKgwqDCoMKgwqAgdmVyc2lvbi4gQW5kIHRoZSBjb21tb24gQ0ZM QUdTIFhlbiBpcyB1c2luZyBzdGlsbCBjYW4gYmUNCj4gPiA+IGFwcGxpZWQgdG8NCj4gPiA+ID4g PiA+wqDCoMKgwqDCoCBBcm12OC1SNjQuIFdlIGRvbid0IG5lZWQgdG8gbW9kaWZ5IE1ha2VmaWxl cyB0byBhZGQNCj4gc3BlY2lmaWMNCj4gPiA+IENGTEFHUy4NCj4gPiA+ID4gPg0KPiA+ID4gPiA+ IEkgdGhpbmsgdGhhdCdzIGZpbmUgYW5kIHdlIGRpZCBzb21ldGhpbmcgc2ltaWxhciB3aXRoIHRo ZSBvcmlnaW5hbA0KPiA+ID4gQVJNdjctQQ0KPiA+ID4gPiA+IHBvcnQgaWYgSSByZW1lbWJlciBj b3JyZWN0bHkuDQo+ID4gPiA+ID4NCj4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gIyMjICoqMi4yLiBD aGFuZ2VzIG9mIHRoZSBpbml0aWFsaXphdGlvbiBwcm9jZXNzKioNCj4gPiA+ID4gPiA+IEluIGdl bmVyYWwsIHdlIHN0aWxsIGV4cGVjdCBBcm12OC1SNjQgYW5kIEFybXY4LUE2NCB0byBoYXZlIGEN Cj4gPiA+IGNvbnNpc3RlbnQNCj4gPiA+ID4gPiA+IGluaXRpYWxpemF0aW9uIHByb2Nlc3MuIElu IGFkZGl0aW9uIHRvIHNvbWUgYXJjaGl0ZWN0dXJlDQo+IGRpZmZlcmVuY2VzLA0KPiA+ID4gPiA+ IHRoZXJlDQo+ID4gPiA+ID4gPiBpcyBubyBtb3JlIHRoYW4gcmV1c2FibGUgY29kZSB0aGF0IHdl IHdpbGwgZGlzdGluZ3Vpc2ggdGhyb3VnaA0KPiA+ID4gPiA+IENPTkZJR19BUk1fTVBVDQo+ID4g PiA+ID4gPiBvciBDT05GSUdfQVJNNjRfVjhSLiBXZSB3YW50IG1vc3Qgb2YgdGhlIGluaXRpYWxp emF0aW9uIGNvZGUgdG8NCj4gYmUNCj4gPiA+ID4gPiByZXVzYWJsZQ0KPiA+ID4gPiA+ID4gYmV0 d2VlbiBBcm12OC1SNjQgYW5kIEFybXY4LUE2NC4NCj4gPiA+ID4gPg0KPiA+ID4gPiA+ICsxDQo+ ID4gPiA+ID4NCj4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gLSBXZSB3aWxsIHJldXNlIHRoZSBvcmln aW5hbCBoZWFkLnMgYW5kIHNldHVwLmMgb2YgQXJtLiBCdXQNCj4gcmVwbGFjZQ0KPiA+ID4gdGhl DQo+ID4gPiA+ID4gPsKgwqAgTU1VIGFuZCBwYWdlIHRhYmxlIG9wZXJhdGlvbnMgaW4gdGhlc2Ug ZmlsZXMgd2l0aA0KPiBjb25maWd1cmF0aW9uDQo+ID4gPiA+ID4gb3BlcmF0aW9ucw0KPiA+ID4g PiA+ID7CoMKgIGZvciBNUFUgYW5kIE1QVSByZWdpb25zLg0KPiA+ID4gPiA+ID4NCj4gPiA+ID4g PiA+IC0gV2UgcHJvdmlkZSBhIGJvb3QtdGltZSBNUFUgY29uZmlndXJhdGlvbi4gVGhpcyBNUFUN Cj4gY29uZmlndXJhdGlvbg0KPiA+ID4gd2lsbA0KPiA+ID4gPiA+ID7CoMKgIHN1cHBvcnQgWGVu IHRvIGZpbmlzaCBpdHMgaW5pdGlhbGl6YXRpb24uIEFuZCB0aGlzIGJvb3QtdGltZQ0KPiBNUFUN Cj4gPiA+ID4gPiA+wqDCoCBjb25maWd1cmF0aW9uIHdpbGwgcmVjb3JkIHRoZSBtZW1vcnkgcmVn aW9ucyB0aGF0IHdpbGwgYmUNCj4gcGFyc2VkDQo+ID4gPiBmcm9tDQo+ID4gPiA+ID4gPsKgwqAg ZGV2aWNlIHRyZWUuDQo+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID7CoMKgIEluIHRoZSBlbmQgb2Yg WGVuIGluaXRpYWxpemF0aW9uLCB3ZSB3aWxsIHVzZSBhIHJ1bnRpbWUgTVBVDQo+ID4gPiA+ID4g Y29uZmlndXJhdGlvbg0KPiA+ID4gPiA+ID7CoMKgIHRvIHJlcGxhY2UgYm9vdC10aW1lIE1QVSBj b25maWd1cmF0aW9uLiBUaGUgcnVudGltZSBNUFUNCj4gPiA+IGNvbmZpZ3VyYXRpb24NCj4gPiA+ ID4gPiB3aWxsDQo+ID4gPiA+ID4gPsKgwqAgbWVyZ2UgYW5kIHJlb3JkZXIgbWVtb3J5IHJlZ2lv bnMgdG8gc2F2ZSBtb3JlIE1QVSByZWdpb25zIGZvcg0KPiA+ID4gZ3Vlc3RzLg0KPiA+ID4gPiA+ ID7CoMKgICFbaW1nXShodHRwczovL2RyaXZlLmdvb2dsZS5jb20vdWM/ZXhwb3J0PXZpZXcmaWQ9 MXdURnlLMlhmVTNsDQo+IFRsSDENCj4gPiA+IFBxUkQNCj4gPiA+ID4gPiBvYWNRVlR3VXRXSUdV KQ0KPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+IC0gRGVmZXIgc3lzdGVtIHVucGF1c2luZyBkb21h aW4uDQo+ID4gPiA+ID4gPsKgwqAgV2hlbiBYZW4gaW5pdGlhbGl6YXRpb24gaXMgYWJvdXQgdG8g ZW5kLCBYZW4gdW5wYXVzZSBndWVzdHMNCj4gPiA+IGNyZWF0ZWQNCj4gPiA+ID4gPiA+wqDCoCBk dXJpbmcgaW5pdGlhbGl6YXRpb24uIEJ1dCB0aGlzIHdpbGwgY2F1c2Ugc29tZSBpc3N1ZXMuIFRo ZQ0KPiA+ID4gdW5wYXVzZQ0KPiA+ID4gPiA+ID7CoMKgIGFjdGlvbiBvY2N1cnMgYmVmb3JlIGZy ZWVfaW5pdF9tZW1vcnksIGhvd2V2ZXIgdGhlIHJ1bnRpbWUgTVBVDQo+ID4gPiA+ID4gY29uZmln dXJhdGlvbg0KPiA+ID4gPiA+ID7CoMKgIGlzIGJ1aWx0IGFmdGVyIGZyZWVfaW5pdF9tZW1vcnku DQo+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID7CoMKgIFNvIGlmIHRoZSB1bnBhdXNlZCBndWVzdHMg c3RhcnQgZXhlY3V0aW5nIHRoZSBjb250ZXh0IHN3aXRjaA0KPiBhdA0KPiA+ID4gdGhpcw0KPiA+ ID4gPiA+ID7CoMKgIHBvaW50LCB0aGVuIGl0cyBNUFUgY29udGV4dCB3aWxsIGJhc2Ugb24gdGhl IGJvb3QtdGltZSBNUFUNCj4gPiA+ID4gPiBjb25maWd1cmF0aW9uLg0KPiA+ID4gPiA+ID7CoMKg IFByb2JhYmx5IGl0IHdpbGwgYmUgaW5jb25zaXN0ZW50IHdpdGggcnVudGltZSBNUFUNCj4gY29u ZmlndXJhdGlvbiwNCj4gPiA+IHRoaXMNCj4gPiA+ID4gPiA+wqDCoCB3aWxsIGNhdXNlIHVuZXhw ZWN0ZWQgcHJvYmxlbXMgKFRoaXMgbWF5IG5vdCBoYXBwZW4gaW4gYQ0KPiBzaW5nbGUNCj4gPiA+ IGNvcmUNCj4gPiA+ID4gPiA+wqDCoCBzeXN0ZW0sIGJ1dCBvbiBTTVAgc3lzdGVtcywgdGhpcyBw cm9ibGVtIGlzIGZvcmVzZWVhYmxlLCBzbyB3ZQ0KPiA+ID4gaG9wZSB0bw0KPiA+ID4gPiA+ID7C oMKgIHNvbHZlIGl0IGF0IHRoZSBiZWdpbm5pbmcpLg0KPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ ICMjIyAqKjIuMy4gQ2hhbmdlcyB0byByZWR1Y2UgbWVtb3J5IGZyYWdtZW50YXRpb24qKg0KPiA+ ID4gPiA+ID4NCj4gPiA+ID4gPiA+IEluIGdlbmVyYWwsIG1lbW9yeSBpbiBYZW4gc3lzdGVtIGNh biBiZSBjbGFzc2lmaWVkIHRvIDQgY2xhc3NlczoNCj4gPiA+ID4gPiA+IGBpbWFnZSBzZWN0aW9u c2AsIGBoZWFwIHNlY3Rpb25zYCwgYGd1ZXN0IFJBTWAsIGBib290IG1vZHVsZXMNCj4gKGd1ZXN0 DQo+ID4gPiA+ID4gS2VybmVsLA0KPiA+ID4gPiA+ID4gaW5pdHJkIGFuZCBkdGIpYA0KPiA+ID4g PiA+ID4NCj4gPiA+ID4gPiA+IEN1cnJlbnRseSwgWGVuIGRvZXNuJ3QgaGF2ZSBhbnkgcmVzdHJp Y3Rpb24gZm9yIHVzZXJzIGhvdyB0bw0KPiA+ID4gYWxsb2NhdGUNCj4gPiA+ID4gPiA+IG1lbW9y eSBmb3IgZGlmZmVyZW50IGNsYXNzZXMuIFRoYXQgbWVhbnMgdXNlcnMgY2FuIHBsYWNlIGJvb3QN Cj4gPiA+IG1vZHVsZXMNCj4gPiA+ID4gPiA+IGFueXdoZXJlLCBjYW4gcmVzZXJ2ZSBYZW4gaGVh cCBtZW1vcnkgYW55d2hlcmUgYW5kIGNhbiBhbGxvY2F0ZQ0KPiA+ID4gZ3Vlc3QNCj4gPiA+ID4g PiA+IG1lbW9yeSBhbnl3aGVyZS4NCj4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiBJbiBhIFZNU0Eg c3lzdGVtLCB0aGlzIHdvdWxkIG5vdCBiZSB0b28gbXVjaCBvZiBhIHByb2JsZW0sIHNpbmNlDQo+ IHRoZQ0KPiA+ID4gPiA+ID4gTU1VIGNhbiBtYW5hZ2UgbWVtb3J5IGF0IGEgZ3JhbnVsYXJpdHkg b2YgNEtCIGFmdGVyIGFsbC4gQnV0IGluDQo+IGENCj4gPiA+ID4gPiA+IFBNU0Egc3lzdGVtLCB0 aGlzIHdpbGwgYmUgYSBiaWcgcHJvYmxlbS4gT24gQXJtdjgtUjY0LCB0aGUgbWF4DQo+IE1QVQ0K PiA+ID4gPiA+ID4gcHJvdGVjdGlvbiByZWdpb25zIG51bWJlciBoYXMgYmVlbiBsaW1pdGVkIHRv IDI1Ni4gQnV0IGluDQo+IHR5cGljYWwNCj4gPiA+ID4gPiA+IHByb2Nlc3NvciBpbXBsZW1lbnRh dGlvbnMsIGZldyBwcm9jZXNzb3JzIHdpbGwgZGVzaWduIG1vcmUgdGhhbg0KPiAzMg0KPiA+ID4g PiA+ID4gTVBVIHByb3RlY3Rpb24gcmVnaW9ucy4gQWRkIGluIHRoZSBmYWN0IHRoYXQgWGVuIHNo YXJlcyBNUFUNCj4gPiA+IHByb3RlY3Rpb24NCj4gPiA+ID4gPiA+IHJlZ2lvbnMgd2l0aCBndWVz dCdzIEVMMSBTdGFnZSAyLiBJdCBiZWNvbWVzIGV2ZW4gbW9yZSBpbXBvcnRhbnQNCj4gPiA+ID4g PiA+IHRvIHByb3Blcmx5IHBsYW4gdGhlIHVzZSBvZiBNUFUgcHJvdGVjdGlvbiByZWdpb25zLg0K PiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+IC0gQW4gaWRlYWwgb2YgbWVtb3J5IHVzYWdlIGxheW91 dCByZXN0cmljdGlvbjoNCj4gPiA+ID4gPiA+ICFbaW1nXShodHRwczovL2RyaXZlLmdvb2dsZS5j b20vdWM/ZXhwb3J0PXZpZXcmaWQ9MWtpck9MMFR4MmFBeXANCj4gVHRkMw0KPiA+ID4ga1hBdA0K PiA+ID4gPiA+IGQ3NVh0cm5nY25XKQ0KPiA+ID4gPiA+ID4gMS4gUmVzZXJ2ZSBwcm9wZXIgTVBV IHJlZ2lvbnMgZm9yIFhlbiBpbWFnZSAoY29kZSwgcm9kYXRhIGFuZA0KPiBkYXRhICsNCj4gPiA+ ID4gPiBic3MpLg0KPiA+ID4gPiA+ID4gMi4gUmVzZXJ2ZSBvbmUgTVBVIHJlZ2lvbiBmb3IgYm9v dCBtb2R1bGVzLg0KPiA+ID4gPiA+ID7CoMKgwqAgVGhhdCBtZWFucyB0aGUgcGxhY2VtZW50IG9m IGFsbCBib290IG1vZHVsZXMsIGluY2x1ZGUgZ3Vlc3QNCj4gPiA+IGtlcm5lbCwNCj4gPiA+ID4g PiA+wqDCoMKgIGluaXRyZCBhbmQgZHRiLCB3aWxsIGJlIGxpbWl0ZWQgdG8gdGhpcyBNUFUgcmVn aW9uIHByb3RlY3RlZA0KPiBhcmVhLg0KPiA+ID4gPiA+ID4gMy4gUmVzZXJ2ZSBvbmUgb3IgbW9y ZSBNUFUgcmVnaW9ucyBmb3IgWGVuIGhlYXAuDQo+ID4gPiA+ID4gPsKgwqDCoCBPbiBBcm12OC1S NjQsIHRoZSBndWVzdCBtZW1vcnkgaXMgcHJlZGVmaW5lZCBpbiBkZXZpY2UgdHJlZSwNCj4gaXQN Cj4gPiA+IHdpbGwNCj4gPiA+ID4gPiA+wqDCoMKgIG5vdCBiZSBhbGxvY2F0ZWQgZnJvbSBoZWFw LiBVbmxpa2UgQXJtdjgtQTY0LCB3ZSB3aWxsIG5vdA0KPiBtb3ZlDQo+ID4gPiBhbGwNCj4gPiA+ ID4gPiA+wqDCoMKgIGZyZWUgbWVtb3J5IHRvIGhlYXAuIFdlIHdhbnQgWGVuIGhlYXAgaXMgZGVy dGVybWlzdGljIHRvbywgc28NCj4gWGVuDQo+ID4gPiBvbg0KPiA+ID4gPiA+ID7CoMKgwqAgQXJt djgtUjY0IGFsc28gcmVseSBvbiBYZW4gc3RhdGljIGhlYXAgZmVhdHVyZS4gVGhlIG1lbW9yeQ0K PiBmb3INCj4gPiA+IFhlbg0KPiA+ID4gPiA+ID7CoMKgwqAgaGVhcCB3aWxsIGJlIGRlZmluZWQg aW4gdHJlZSB0b28uIENvbnNpZGVyaW5nIHRoYXQgcGh5c2ljYWwNCj4gPiA+IG1lbW9yeQ0KPiA+ ID4gPiA+ID7CoMKgwqAgY2FuIGFsc28gYmUgZGlzY29udGludW91cywgb25lIG9yIG1vcmUgTVBV IHByb3RlY3Rpb24gcmVnaW9ucw0KPiA+ID4gbmVlZHMNCj4gPiA+ID4gPiA+wqDCoMKgIHRvIGJl IHJlc2VydmVkIGZvciBYZW4gSEVBUC4NCj4gPiA+ID4gPiA+IDQuIElmIHdlIG5hbWUgYWJvdmUg dXNlZCBNUFUgcHJvdGVjdGlvbiByZWdpb25zIFBBUlRfQSwgYW5kIG5hbWUNCj4gPiA+IGxlZnQN Cj4gPiA+ID4gPiA+wqDCoMKgIE1QVSBwcm90ZWN0aW9uIHJlZ2lvbnMgUEFSVF9COg0KPiA+ID4g PiA+ID7CoMKgwqAgNC4xLiBJbiBoeXBlcnZpc29yIGNvbnRleHQsIFhlbiB3aWxsIG1hcCBsZWZ0 IFJBTSBhbmQgZGV2aWNlcw0KPiB0bw0KPiA+ID4gPiA+IFBBUlRfQi4NCj4gPiA+ID4gPiA+wqDC oMKgwqDCoMKgwqDCoCBUaGlzIHdpbGwgZ2l2ZSBYZW4gdGhlIGFiaWxpdHkgdG8gYWNjZXNzIHdo b2xlIG1lbW9yeS4NCj4gPiA+ID4gPiA+wqDCoMKgIDQuMi4gSW4gZ3Vlc3QgY29udGV4dCwgWGVu IHdpbGwgY3JlYXRlIEVMMSBzdGFnZSAyIG1hcHBpbmcgaW4NCj4gPiA+IFBBUlRfQi4NCj4gPiA+ ID4gPiA+wqDCoMKgwqDCoMKgwqDCoCBJbiB0aGlzIGNhc2UsIFhlbiBqdXN0IG5lZWQgdG8gdXBk YXRlIFBBUlRfQiBpbiBjb250ZXh0DQo+ID4gPiBzd2l0Y2gsDQo+ID4gPiA+ID4gPsKgwqDCoMKg wqDCoMKgwqAgYnV0IGtlZXAgUEFSVF9BIGFzIGZpeGVkLg0KPiA+ID4gPiA+DQo+ID4gPiA+ID4g SSB0aGluayB0aGF0IHRoZSBtZW1vcnkgbGF5b3V0IGFuZCByZXN0cmljdGlvbnMgdGhhdCB5b3Ug d3JvdGUNCj4gYWJvdmUNCj4gPiA+ID4gPiBtYWtlIHNlbnNlLiBJIGhhdmUgc29tZSBjb21tZW50 cyBvbiB0aGUgd2F5IHRoZXkgYXJlIHJlcHJlc2VudGVkDQo+IGluDQo+ID4gPiA+ID4gZGV2aWNl IHRyZWUsIGJ1dCB0aGF0J3MgZGlmZmVyZW50Lg0KPiA+ID4gPiA+DQo+ID4gPiA+ID4NCj4gPiA+ ID4gPiA+ICoqKk5vdGVzOiBTdGF0aWMgYWxsb2NhdGlvbiB3aWxsIGJlIG1hbmRhdG9yeSBvbiBN UFUgYmFzZWQNCj4gPiA+IHN5c3RlbXMqKioNCj4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiAqKkEg c2FtcGxlIGRldmljZSB0cmVlIG9mIG1lbW9yeSBsYXlvdXQgcmVzdHJpY3Rpb24qKjoNCj4gPiA+ ID4gPiA+IGBgYA0KPiA+ID4gPiA+ID4gY2hvc2VuIHsNCj4gPiA+ID4gPiA+wqDCoMKgwqAgLi4u DQo+ID4gPiA+ID4gPsKgwqDCoMKgIC8qDQo+ID4gPiA+ID4gPsKgwqDCoMKgwqAgKiBEZWZpbmUg YSBzZWN0aW9uIHRvIHBsYWNlIGJvb3QgbW9kdWxlcywNCj4gPiA+ID4gPiA+wqDCoMKgwqDCoCAq IGFsbCBib290IG1vZHVsZXMgbXVzdCBiZSBwbGFjZWQgaW4gdGhpcyBzZWN0aW9uLg0KPiA+ID4g PiA+ID7CoMKgwqDCoMKgICovDQo+ID4gPiA+ID4gPsKgwqDCoMKgIG1wdSxib290LW1vZHVsZS1z ZWN0aW9uID0gPDB4MTAwMDAwMDAgMHgxMDAwMDAwMD47DQo+ID4gPiA+ID4gPsKgwqDCoMKgIC8q DQo+ID4gPiA+ID4gPsKgwqDCoMKgwqAgKiBEZWZpbmUgYSBzZWN0aW9uIHRvIGNvdmVyIGFsbCBn dWVzdCBSQU0uIEFsbCBndWVzdCBSQU0NCj4gbXVzdA0KPiA+ID4gYmUNCj4gPiA+ID4gPiBsb2Nh dGVkDQo+ID4gPiA+ID4gPsKgwqDCoMKgwqAgKiB3aXRoaW4gdGhpcyBzZWN0aW9uLiBUaGUgcHJv cyBpcyB0aGF0LCBpbiBiZXN0IGNhc2UsIHdlDQo+IGNhbg0KPiA+ID4gb25seQ0KPiA+ID4gPiA+ IGhhdmUNCj4gPiA+ID4gPiA+wqDCoMKgwqDCoCAqIG9uZSBNUFUgcHJvdGVjdGlvbiByZWdpb24g dG8gbWFwIGFsbCBndWVzdCBSQU0gZm9yIFhlbi4NCj4gPiA+ID4gPiA+wqDCoMKgwqDCoCAqLw0K PiA+ID4gPiA+ID7CoMKgwqDCoCBtcHUsZ3Vlc3QtbWVtb3J5LXNlY3Rpb24gPSA8MHgyMDAwMDAw MCAweDMwMDAwMDAwPjsNCj4gPiA+ID4gPiA+wqDCoMKgwqAgLyoNCj4gPiA+ID4gPiA+wqDCoMKg wqDCoCAqIERlZmluZSBhIG1lbW9yeSBzZWN0aW9uIHRoYXQgY2FuIGNvdmVyIGFsbCBkZXZpY2Ug bWVtb3J5DQo+IHRoYXQNCj4gPiA+ID4gPiA+wqDCoMKgwqDCoCAqIHdpbGwgYmUgdXNlZCBpbiBY ZW4uDQo+ID4gPiA+ID4gPsKgwqDCoMKgwqAgKi8NCj4gPiA+ID4gPiA+wqDCoMKgwqAgbXB1LGRl dmljZS1tZW1vcnktc2VjdGlvbiA9IDwweDgwMDAwMDAwIDB4N2ZmZmYwMDA+Ow0KPiA+ID4gPiA+ ID7CoMKgwqDCoCAvKiBEZWZpbmUgYSBzZWN0aW9uIGZvciBYZW4gaGVhcCAqLw0KPiA+ID4gPiA+ ID7CoMKgwqDCoCB4ZW4sc3RhdGljLW1lbSA9IDwweDUwMDAwMDAwIDB4MjAwMDAwMDA+Ow0KPiA+ ID4gPiA+DQo+ID4gPiA+ID4gQXMgbWVudGlvbmVkIGFib3ZlLCBJIHVuZGVyc3RhbmQgdGhlIG5l ZWQgZm9yIHRoZXNlIHNlY3Rpb25zLCBidXQNCj4gd2h5DQo+ID4gPiBkbw0KPiA+ID4gPiA+IHdl IG5lZWQgdG8gZGVzY3JpYmUgdGhlbSBpbiBkZXZpY2UgdHJlZSBhdCBhbGw/IENvdWxkIFhlbiBz ZWxlY3QNCj4gdGhlbQ0KPiA+ID4gYnkNCj4gPiA+ID4gPiBpdHNlbGYgZHVyaW5nIGJvb3Q/DQo+ ID4gPiA+DQo+ID4gPiA+IEkgdGhpbmsgd2l0aG91dCBzb21lIGlucHV0cywgWGVuIGNvdWxkIG5v dCBkbyB0aGlzIG9yIHdpbGwgZG8gaXQgaW4NCj4gc29tZQ0KPiA+ID4gPiBhc3N1bXB0aW9uLiBG b3IgZXhhbXBsZSwgYXNzdW1lIHRoZSBmaXJzdCB0aGUgYm9vdC1tb2R1bGUtc2VjdGlvbg0KPiA+ ID4gZGV0ZXJtaW5lZA0KPiA+ID4gPiBieSBsb3dlc3QgYWRkcmVzcyBhbmQgaGlnaGVzdCBhZGRy ZXNzIG9mIGFsbCBtb2R1bGVzLiBBbmQgdGhlIHNhbWUNCj4gZm9yDQo+ID4gPiA+IGd1ZXN0LW1l bW9yeS1zZWN0aW9uLCBjYWxjdWxhdGVkIGZyb20gYWxsIGd1ZXN0IGFsbG9jYXRlZCBtZW1vcnkN Cj4gcmVnaW9ucy4NCj4gPiA+DQo+ID4gPiBSaWdodCwgSSB0aGluayB0aGF0IHRoZSBtcHUsYm9v dC1tb2R1bGUtc2VjdGlvbiBzaG91bGQgYmUgZ2VuZXJhdGVkIGJ5DQo+IGENCj4gPiA+IHNldCBv ZiBzY3JpcHRzIGxpa2UgSW1hZ2VCdWlsZGVyLiBTb21ldGhpbmcgd2l0aCBhIGxpc3Qgb2YgYWxs IHRoZQ0KPiA+ID4gYmluYXJpZXMgdGhhdCBuZWVkIHRvIGJlIGxvYWRlZCBhbmQgYWxzbyB0aGUg RFRCIGF0IGJ1aWxkLXRpbWUuDQo+ID4gPiBTb21ldGhpbmcgbGlrZSBJbWFnZUJ1aWxkZXIgd291 bGQgaGF2ZSB0aGUgYWJpbGl0ecKgdG8gYWRkDQo+ID4gPiAibXB1LGJvb3QtbW9kdWxlLXNlY3Rp b24iIHRvIGRldmljZSB0cmVlIGF1dG9tYXRpY2FsbHkgYW5kDQo+IGF1dG9tYXRpY2FsbHkNCj4g PiA+IGNob29zZSBhIGdvb2QgYWRkcmVzcyBmb3IgaXQuDQo+ID4gPg0KPiA+ID4gQXMgYW4gZXhh bXBsZSwgdG9kYXkgSW1hZ2VCdWlsZGVyIHRha2VzIGFzIGlucHV0IGEgY29uZmlnIGZpbGUgbGlr ZQ0KPiB0aGUNCj4gPiA+IGZvbGxvd2luZzoNCj4gPiA+DQo+ID4gPiAtLS0NCj4gPiA+IE1FTU9S WV9TVEFSVD0iMHgwIg0KPiA+ID4gTUVNT1JZX0VORD0iMHg4MDAwMDAwMCINCj4gPiA+DQo+ID4g PiBERVZJQ0VfVFJFRT0iNC4xNi0yMDIyLjEvbXBzb2MuZHRiIg0KPiA+ID4gWEVOPSI0LjE2LTIw MjIuMS94ZW4iDQo+ID4gPiBET00wX0tFUk5FTD0iNC4xNi0yMDIyLjEvSW1hZ2UtZG9tMC01LjE2 Ig0KPiA+ID4gRE9NMF9SQU1ESVNLPSI0LjE2LTIwMjIuMS94ZW4tcm9vdGZzLmNwaW8uZ3oiDQo+ ID4gPg0KPiA+ID4gTlVNX0RPTVVTPTENCj4gPiA+IERPTVVfS0VSTkVMWzBdPSI0LjE2LTIwMjIu MS9JbWFnZS1kb21VIg0KPiA+ID4gRE9NVV9SQU1ESVNLWzBdPSI0LjE2LTIwMjIuMS9pbml0cmQu Y3BpbyINCj4gPiA+IERPTVVfUEFTU1RIUk9VR0hfRFRCWzBdPSI0LjE2LTIwMjIuMS9wYXNzdGhy b3VnaC1leGFtcGxlLXNyYW0uZHRiIg0KPiA+ID4gLS0tDQo+ID4gPg0KPiA+ID4gQW5kIGdlbmVy YXRlcyBhIFUtQm9vdCBib290LnNjciBzY3JpcHQgd2l0aDoNCj4gPiA+IC0gbG9hZCBhZGRyZXNz ZXMgZm9yIGVhY2ggYmluYXJ5DQo+ID4gPiAtIGNvbW1hbmRzIHRvIGVkaXQgdGhlIERUQiB0byBh ZGQgdGhvc2UgYWRkcmVzc2VzIHRvIGRldmljZSB0cmVlIChlLmcuDQo+ID4gPiAgIGRvbTBsZXNz IGtlcm5lbHMgYWRkcmVzc2VzKQ0KPiA+ID4NCj4gPiA+IEltYWdlQnVpbGRlciBjYW4gYWxzbyBt b2RpZnkgdGhlIERUQiBhdCBidWlsZCB0aW1lIGluc3RlYWQgKGluc3RlYWQgb2YNCj4gPiA+IGRv aW5nIGl0IGZyb20gYm9vdC5zY3IuKSBTZWUgRkRURURJVC4NCj4gPiA+DQo+ID4gPiBJIGFtIG5v dCBzYXlpbmcgd2Ugc2hvdWxkIHVzZSBJbWFnZUJ1aWxkZXIsIGJ1dCBpdCBzb3VuZHMgbGlrZSB3 ZSBuZWVkDQo+ID4gPiBzb21ldGhpbmcgc2ltaWxhci4NCj4gPiA+DQo+ID4gPg0KPiA+DQo+ID4g WWVzLCBleGFjdGx5LiBJIGhhdmUgY29tbWVudCBvbiBIZW5yeSdzIHN0YWNrIGhlYXAgUkZDIHRv IHNhaWQgd2UgbmVlZA0KPiA+IGEgc2ltaWxhciB0b29sLiBOb3csIGhlcmUgaXQgaXMgOiApDQo+ IA0KPiBBaGFoIHllcyA6LSkNCj4gDQo+IEluaXRpYWxseSBJIHdyb3RlIEltYWdlQnVpbGRlciBi ZWNhdXNlIHBlb3BsZSBrZXB0IHNlbmRpbmcgbWUgZW1haWxzIHRvDQo+IGFzayBtZSBmb3IgaGVs cCB3aXRoIGRvbTBsZXNzIGFuZCBhbG1vc3QgYWx3YXlzIGl0IHdhcyBhbiBhZGRyZXNzDQo+IGxv YWRpbmcgZXJyb3IuDQo+IA0KDQpZZXMsIGF0IHByZXNlbnQsIGl0IGlzIG5vdCB2ZXJ5IGNvbnZl bmllbnQsIG1hbnkgcHJvYmxlbXMgYXJlIGNhdXNlZCBieSBEVFMNCmNvbmZpZ3VyYXRpb24gZXJy b3JzDQoNCj4gSSB3b3VsZCBiZSBoYXBweSB0byB0dXJuIEltYWdlQnVpbGRlciBpbnRvIHNvbWV0 aGluZyB1c2VmdWwgZm9yIEFSTXY4LVINCj4gYXMgd2VsbCBhbmQgYWRkIG1vcmUgbWFpbnRhaW5l cnMgZnJvbSBBUk0gYW5kIG90aGVyIGNvbXBhbmllcy4NCj4gDQoNCisxIDogKQ0KDQo+IA0KPiA+ ID4gPiA+IElmIG5vdCwgYW5kIGNvbnNpZGVyaW5nIHRoYXQgd2UgaGF2ZSB0byBnZW5lcmF0ZQ0K PiA+ID4gPiA+IEFSTV9NUFVfKl9NRU1PUllfU1RBUlQvRU5EIGFueXdheSBhdCBidWlsZCB0aW1l LCB3b3VsZCBpdCBtYWtlDQo+IHNlbnNlDQo+ID4gPiB0bw0KPiA+ID4gPiA+IGFsc28gZ2VuZXJh dGUgbXB1LGd1ZXN0LW1lbW9yeS1zZWN0aW9uLCB4ZW4sc3RhdGljLW1lbSwgZXRjLiBhdA0KPiBi dWlsZA0KPiA+ID4gPiA+IHRpbWUgcmF0aGVyIHRoYW4gcGFzc2luZyBpdCB2aWEgZGV2aWNlIHRy ZWUgdG8gWGVuIGF0IHJ1bnRpbWU/DQo+ID4gPiA+ID4NCj4gPiA+ID4NCj4gPiA+ID4gRGlkIHlv dSBtZWFuIHdlIHN0aWxsIGFkZCB0aGVzZSBpbmZvcm1hdGlvbiBpbiBkZXZpY2UgdHJlZSwgYnV0 IGZvcg0KPiA+ID4gYnVpbGQNCj4gPiA+ID4gdGltZSBvbmx5LiBJbiBydW50aW1lIHdlIGRvbid0 IHBhcnNlIHRoZW0/DQo+ID4gPg0KPiA+ID4gWWVzLCBzb21ldGhpbmcgbGlrZSB0aGF0LCBidXQg c2VlIGJlbG93Lg0KPiA+ID4NCj4gPiA+DQo+ID4gPiA+ID4gV2hhdCdzIHRoZSB2YWx1ZSBvZiBk b2luZyBBUk1fTVBVXypfTUVNT1JZX1NUQVJUL0VORCBhdCBidWlsZCB0aW1lDQo+IGFuZA0KPiA+ ID4gPiA+IGV2ZXJ5dGhpbmcgZWxzZSBhdCBydW50aW1lPw0KPiA+ID4gPg0KPiA+ID4gPiBBUk1f TVBVXypfTUVNT1JZX1NUQVJUL0VORCBpcyBkZWZpbmVkIGJ5IHBsYXRmb3JtLiBCdXQgb3RoZXIg dGhpbmdzDQo+IGFyZQ0KPiA+ID4gPiB1c2VycyBjdXN0b21pemVkLiBUaGV5IGNhbiBjaGFuZ2Ug dGhlaXIgdXNhZ2Ugd2l0aG91dCByZWJ1aWxkIHRoZQ0KPiBpbWFnZS4NCj4gPiA+DQo+ID4gPiBH b29kIHBvaW50Lg0KPiA+ID4NCj4gPiA+IFdlIGRvbid0IHdhbnQgdG8gaGF2ZSB0byByZWJ1aWxk IFhlbiBpZiB0aGUgdXNlciB1cGRhdGVkIGEgZ3Vlc3QNCj4ga2VybmVsLA0KPiA+ID4gcmVzdWx0 aW5nIGluIGEgbGFyZ2VyIGJvb3QtbW9kdWxlLXNlY3Rpb24uDQo+ID4gPg0KPiA+ID4gU28gSSB0 aGluayBpdCBtYWtlcyBzZW5zZSB0aGF0ICJtcHUsYm9vdC1tb2R1bGUtc2VjdGlvbiIgaXMgZ2Vu ZXJhdGVkDQo+IGJ5DQo+ID4gPiB0aGUgc2NyaXB0cyAoZS5nLiBJbWFnZUJ1aWxkZXIpIGF0IGJ1 aWxkIHRpbWUsIGFuZCBYZW4gcmVhZHMgdGhlDQo+ID4gPiBwcm9wZXJ0eSBhdCBib290IGZyb20g dGhlIHJ1bnRpbWUgZGV2aWNlIHRyZWUuDQo+ID4gPg0KPiA+ID4gSSB0aGluayB3ZSBuZWVkIHRv IGRpdmlkZSB0aGUgaW5mb3JtYXRpb24gaW50byB0d28gZ3JvdXBzOg0KPiA+ID4NCj4gPiA+DQo+ ID4gPiAjIEdyb3VwMTogYm9hcmQgaW5mbw0KPiA+ID4NCj4gPiA+IFRoaXMgaW5mb3JtYXRpb24g aXMgcGxhdGZvcm0gc3BlY2lmaWMgYW5kIGl0IGlzIG5vdCBtZWFudCB0byBjaGFuZ2UNCj4gPiA+ IGRlcGVuZGluZyBvbiB0aGUgVk0gY29uZmlndXJhdGlvbi4gSWRlYWxseSwgd2UgYnVpbGQgWGVu IGZvciBhDQo+IHBsYXRmb3JtDQo+ID4gPiBvbmNlLCB0aGVuIHdlIGNhbiB1c2UgdGhlIHNhbWUg WGVuIGJpbmFyeSB0b2dldGhlciB3aXRoIGFueQ0KPiBjb21iaW5hdGlvbg0KPiA+ID4gb2YgZG9t MC9kb21VIGtlcm5lbHMgYW5kIHJhbWRpc2tzLg0KPiA+ID4NCj4gPiA+IFRoaXMga2luZCBvZiBp bmZvcm1hdGlvbiBkb2Vzbid0IG5lZWQgdG8gYmUgZXhwb3NlZCB0byB0aGUgcnVudGltZQ0KPiA+ ID4gZGV2aWNlIHRyZWUuIEJ1dCB3ZSBjYW4gc3RpbGwgdXNlIGEgYnVpbGQtdGltZSBkZXZpY2Ug dHJlZSB0byBnZW5lcmF0ZQ0KPiA+ID4gdGhlIGFkZHJlc3NlcyBpZiBpdCBpcyBjb252ZW5pZW50 Lg0KPiA+ID4NCj4gPiA+IFhFTl9TVEFSVF9BRERSRVNTLCBBUk1fTVBVX0RFVklDRV9NRU1PUllf KiwgYW5kDQo+IEFSTV9NUFVfTk9STUFMX01FTU9SWV8qDQo+ID4gPiBzZWVtIHRvIGJlIHBhcnQg b2YgdGhpcyBncm91cC4NCj4gPiA+DQo+ID4NCj4gPiBZZXMuDQo+ID4NCj4gPiA+DQo+ID4gPiAj IEdyb3VwMjogYm9vdCBjb25maWd1cmF0aW9uDQo+ID4gPg0KPiA+ID4gVGhpcyBpbmZvcm1hdGlv biBpcyBhYm91dCB0aGUgc3BlY2lmaWMgc2V0IG9mIGJpbmFyaWVzIGFuZCBWTXMgdGhhdCB3ZQ0K PiA+ID4gbmVlZCB0byBib290LiBJdCBpcyBjb25jZXB0dWFsbHkgc2ltaWxhciB0byB0aGUgZG9t MGxlc3MgZGV2aWNlIHRyZWUNCj4gPiA+IG5vZGVzIHRoYXQgd2UgYWxyZWFkeSBoYXZlLiBJZiB3 ZSBjaGFuZ2Ugb25lIG9mIHRoZSBWTSBiaW5hcmllcywgd2UNCj4gPiA+IGxpa2VseSBoYXZlIHRv IHJlZnJlc2ggdGhlIGluZm9ybWF0aW9uIGhlcmUuDQo+ID4gPg0KPiA+ID4gIm1wdSxib290LW1v ZHVsZS1zZWN0aW9uIiBwcm9iYWJseSBiZWxvbmdzIHRvIHRoaXMgZ3JvdXAgKHVubGVzcyB3ZQ0K PiBmaW5kDQo+ID4gPiBhIHdheSB0byBkZWZpbmUgIm1wdSxib290LW1vZHVsZS1zZWN0aW9uIiBn ZW5lcmljYWxseSBzbyB0aGF0IHdlIGRvbid0DQo+ID4gPiBuZWVkIHRvIGNoYW5nZSBpdCBhbnkg dGltZSB0aGUgc2V0IG9mIGJvb3QgbW9kdWxlcyBjaGFuZ2UuKQ0KPiA+ID4NCj4gPiA+DQo+ID4N Cj4gPiBJIGFncmVlLg0KPiA+DQo+ID4gPiA+ID4gSXQgbG9va3MgbGlrZSB3ZSBhcmUgZm9yY2Vk IHRvIGhhdmUgdGhlIHNlY3Rpb25zIGRlZmluaXRpb25zIGF0DQo+IGJ1aWxkDQo+ID4gPiA+ID4g dGltZSBiZWNhdXNlIHdlIG5lZWQgdGhlbSBiZWZvcmUgd2UgY2FuIHBhcnNlIGRldmljZSB0cmVl LiBJbiB0aGF0DQo+ID4gPiBjYXNlLA0KPiA+ID4gPiA+IHdlIG1pZ2h0IGFzIHdlbGwgZGVmaW5l IGFsbCB0aGUgc2VjdGlvbnMgYXQgYnVpbGQgdGltZS4NCj4gPiA+ID4gPg0KPiA+ID4gPiA+IEJ1 dCBJIHRoaW5rIGl0IHdvdWxkIGJlIGV2ZW4gYmV0dGVyIGlmIFhlbiBjb3VsZCBhdXRvbWF0aWNh bGx5DQo+IGNob29zZQ0KPiA+ID4gPiA+IHhlbixzdGF0aWMtbWVtLCBtcHUsZ3Vlc3QtbWVtb3J5 LXNlY3Rpb24sIGV0Yy4gb24gaXRzIG93biBiYXNlZCBvbg0KPiB0aGUNCj4gPiA+ID4gPiByZWd1 bGFyIGRldmljZSB0cmVlIGluZm9ybWF0aW9uICgvbWVtb3J5LCAvYW1iYSwgZXRjLiksIHdpdGhv dXQNCj4gYW55DQo+ID4gPiBuZWVkDQo+ID4gPiA+ID4gZm9yIGV4cGxpY2l0bHkgZGVzY3JpYmlu ZyBlYWNoIHJhbmdlIHdpdGggdGhlc2UgbmV3IHByb3BlcnRpZXMuDQo+ID4gPiA+ID4NCj4gPiA+ ID4NCj4gPiA+ID4gZm9yIG1wdSxndWVzdC1tZW1vcnktc2VjdGlvbiwgd2l0aCB0aGUgbGltaXRh dGlvbnM6IG5vIG90aGVyIHVzYWdlDQo+ID4gPiBiZXR3ZWVuDQo+ID4gPiA+IGRpZmZlcmVudCBn dWVzdCcgbWVtb3J5IG5vZGVzLCB0aGlzIGlzIE9LLiBCdXQgZm9yIHhlbixzdGF0aWMtbWVtDQo+ IChoZWFwKSwNCj4gPiA+ID4gd2UganVzdCB3YW50IGV2ZXJ5dGhpbmcgb24gYSBNUFUgc3lzdGVt IGlzIGRlcnRlcm1pc3RpYy4gQnV0LCBvZg0KPiBjb3Vyc2UNCj4gPiA+IFhlbg0KPiA+ID4gPiBj YW4gc2VsZWN0IGxlZnQgbWVtb3J5IGZvciBoZWFwIHdpdGhvdXQgc3RhdGljLW1lbS4NCj4gPiA+ DQo+ID4gPiBJdCBpcyBnb29kIHRoYXQgeW91IHRoaW5rIHRoZXkgY2FuIGJlIGNob3NlbiBieSBY ZW4uDQo+ID4gPg0KPiA+ID4gRGlmZmVyZW50bHkgZnJvbSAiYm9vdC1tb2R1bGUtc2VjdGlvbiIs IHdoaWNoIGhhcyB0byBkbyB3aXRoIHRoZSBib290DQo+ID4gPiBtb2R1bGVzIHNlbGVjdGVkIGJ5 IHRoZSB1c2VyIGZvciBhIHNwZWNpZmljIGV4ZWN1dGlvbiwNCj4gPiA+IGd1ZXN0LW1lbW9yeS1z ZWN0aW9uIGFuZCBzdGF0aWMtbWVtIGFyZSBYZW4gc3BlY2lmaWMgbWVtb3J5DQo+ID4gPiBwb2xp Y2llcy9hbGxvY2F0aW9ucy4NCj4gPiA+DQo+ID4gPiBBIHVzZXIgd291bGRuJ3Qga25vdyBob3cg dG8gZmlsbCB0aGVtIGluLiBBbmQgSSB3b3JyeSB0aGF0IGV2ZW4gYQ0KPiBzY3JpcHQNCj4gPg0K PiA+IEJ1dCB1c2VycyBzaG91bGQga25vdyBpdCwgYmVjYXVzZSBzdGF0aWMtbWVtIGZvciBndWVz dCBtdXN0IGJlIGFsbG9jYXRlZA0KPiA+IGluIHRoaXMgcmFuZ2UuIEFuZCB1c2VycyB0YWtlIHRo ZSByZXNwb25zaWJpbGl0eSB0byBzZXQgdGhlIERvbVUncw0KPiA+IHN0YXRpYyBhbGxvY2F0ZSBt ZW1vcnkgcmFuZ2VzLg0KPiANCj4gTGV0IG1lIHByZW1pc2UgdGhhdCBteSBnb2FsIGlzIHRvIGF2 b2lkIGhhdmluZyBtYW55IHVzZXJzIHJlcG9ydGluZw0KPiBlcnJvcnMgdG8geGVuLWRldmVsIGFu ZCB4ZW4tdXNlcnMgd2hlbiBhY3R1YWxseSBpdCBpcyBqdXN0IGEgd3JvbmcNCj4gY2hvaWNlIG9m IGFkZHJlc3Nlcy4NCj4gDQo+IEkgdGhpbmsgd2UgbmVlZCB0byBtYWtlIGEgZGlzdGluY3Rpb24g YmV0d2VlbiBhZGRyZXNzZXMgZm9yIHRoZSBib290DQo+IG1vZHVsZXMsIGUuZy4gYWRkcmVzc2Vz IHdoZXJlIHRvIGxvYWQgeGVuLCB0aGUgZG9tMC9VIGtlcm5lbCwgZG9tMC9VDQo+IHJhbWRpc2sg aW4gbWVtb3J5IGF0IGJvb3QgdGltZSwgYW5kIFZNIHN0YXRpYyBtZW1vcnkgYWRkcmVzc2VzLg0K PiANCj4gVGhlIGJvb3QgbW9kdWxlcyBhZGRyZXNzZXMgYXJlIHBhcnRpY3VsYXJseSBkaWZmaWN1 bHQgdG8gZmlsbCBpbiBiZWNhdXNlDQo+IHRoZXkgYXJlIG1hbnkgYW5kIGEgc21hbGwgdXBkYXRl IGluIG9uZSBvZiB0aGUgbW9kdWxlcyBjb3VsZCBpbnZhbGlkYXRlDQo+IGFsbCB0aGUgb3RoZXIg YWRkcmVzc2VzLiBUaGlzIGlzIHdoeSBJIGVuZGVkIHVwIHdyaXRpbmcgSW1hZ2VCdWlsZGVyLg0K PiBTaW5jZSB0aGVtLCBJIHJlY2VpdmVkIHNldmVyYWwgZW1haWxzIGZyb20gdXNlcnMgdGhhbmtp bmcgbWUgZm9yDQo+IEltYWdlQnVpbGRlciA6LSkNCj4gDQoNClRoYW5rcyArOTk5IPCfmIoNCg0K DQo+IFRoZSBzdGF0aWMgVk0gbWVtb3J5IGFkZHJlc3NlcyAoeGVuLHN0YXRpYy1tZW0pIHNob3Vs ZCBiZSBhIGJpdCBlYXNpZXINCj4gdG8gZmlsbCBpbiBjb3JyZWN0bHkuIFRoZXkgYXJlIG1lYW50 IHRvIGJlIGNob3NlbiBvbmNlLCBhbmQgaXQgc2hvdWxkbid0DQo+IGhhcHBlbiB0aGF0IGFuIHVw ZGF0ZSBvbiBhIGtlcm5lbCBmb3JjZXMgdGhlIHVzZXIgdG8gY2hhbmdlIGFsbCB0aGUgVk0NCj4g c3RhdGljIG1lbW9yeSBhZGRyZXNzZXMuIEFsc28sIEkga25vdyB0aGF0IHNvbWUgdXNlcnMgYWN0 dWFsbHkgd2FudCB0bw0KPiBiZSBhYmxlIHRvIGNob29zZSB0aGUgZG9tVSBhZGRyZXNzZXMgYnkg aGFuZCBiZWNhdXNlIHRoZXkgaGF2ZSBzcGVjaWZpYw0KPiBuZWVkcy4gU28gaXQgaXMgZ29vZCB0 aGF0IHdlIGNhbiBsZXQgdGhlIHVzZXIgY2hvb3NlIHRoZSBhZGRyZXNzZXMgaWYNCj4gdGhleSB3 YW50IHRvLg0KPiANCg0KWWVzLg0KDQo+IFdpdGggYWxsIG9mIHRoYXQgc2FpZCwgSSBkbyB0aGlu ayB0aGF0IG1hbnkgdXNlcnMgd29uJ3QgaGF2ZSBhbiBvcGluaW9uDQo+IG9uIHRoZSBWTSBzdGF0 aWMgbWVtb3J5IGFkZHJlc3NlcyBhbmQgd29uJ3Qga25vdyBob3cgdG8gY2hvb3NlIHRoZW0uDQo+ IEl0IHdvdWxkIGJlIGVycm9yIHByb25lIHRvIGxldCB0aGVtIHRyeSB0byBmaWxsIHRoZW0gaW4g YnkgaGFuZC4gU28gSQ0KPiB3YXMgYWxyZWFkeSBwbGFubmluZyBvbiBhZGRpbmcgc3VwcG9ydCB0 byBJbWFnZUJ1aWxkZXIgdG8gYXV0b21hdGljYWxseQ0KPiBnZW5lcmF0ZSB4ZW4sc3RhdGljLW1l bSBmb3IgZG9tMGxlc3MgZG9tYWlucy4NCj4gDQoNCkxldCBtZSBtYWtlIHN1cmUgdGhhdCdzIHdo YXQgeW91IHNhaWQ6IFVzZXJzIGdpdmUgYW4gVk0gbWVtb3J5IHNpemUgdG8NCkltYWdlQnVpbGRl ciwgYW5kIEltYWdlQnVpbGRlciB3aWxsIGdlbmVyYXRlIHhlbixzdGF0aWMtbWVtID0gPHN0YXJ0 LCBzaXplPi4NCkZvciBzcGVjaWZpYyBWTSwgSW1hZ2VCdWlsZGVyIGFsc28gY2FuIGFjY2VwdCBz dGFydCBhbmQgc2l6ZSBhcyBpbnB1dHM/DQoNCkRvIEkgdW5kZXJzdGFuZCB0aGlzIGNvcnJlY3Rs eT8NCg0KPiANCj4gR29pbmcgYmFjayB0byB0aGlzIHNwZWNpZmljIGRpc2N1c3Npb24gYWJvdXQg Ym9vdC1tb2R1bGUtc2VjdGlvbjogSSBjYW4NCj4gc2VlIG5vdyB0aGF0LCBnaXZlbiB4ZW4sc3Rh dGljLW1lbSBpcyBjaG9zZW4gYnkgSW1hZ2VCdWlsZGVyIChvcg0KDQpCeSBoYW5kIDogKQ0KDQo+ IHNpbWlsYXIpIGFuZCBub3QgWGVuLCB0aGVuIGl0IG1ha2VzIHNlbnNlIHRvIGhhdmUgSW1hZ2VC dWlsZGVyIChvcg0KPiBzaW1pbGFyKSBhbHNvIGdlbmVyYXRlIGJvb3QtbW9kdWxlLXNlY3Rpb24u DQo+IA0KDQpJZiBteSBhYm92ZSB1bmRlcnN0YW5kaW5nIGlzIHJpZ2h0LCB0aGVuIHllcy4NCg0K PiANCj4gDQo+ID4gPiBsaWtlIEltYWdlQnVpbGRlciB3b3VsZG4ndCBiZSB0aGUgYmVzdCBwbGFj ZSB0byBwaWNrIHRoZXNlIHZhbHVlcyAtLQ0KPiA+ID4gdGhleSBzZWVtIHRvbyAiaW1wb3J0YW50 IiB0byBsZWF2ZSB0byBhIHNjcmlwdC4NCj4gPiA+DQo+ID4gPiBCdXQgaXQgc2VlbXMgcG9zc2li bGUgdG8gY2hvb3NlIHRoZSB2YWx1ZXMgaW4gWGVuOg0KPiA+ID4gLSBYZW4ga25vd3MgQVJNX01Q VV9OT1JNQUxfTUVNT1JZXyogYmVjYXVzZSBpdCB3YXMgZGVmaW5lZCBhdCBidWlsZA0KPiB0aW1l DQo+ID4gPiAtIFhlbiByZWFkcyBib290LW1vZHVsZS1zZWN0aW9uIGZyb20gZGV2aWNlIHRyZWUN Cj4gPiA+DQo+ID4gPiBJdCBzaG91bGQgYmUgcG9zc2libGUgYXQgdGhpcyBwb2ludCBmb3IgWGVu IHRvIHBpY2sgdGhlIGJlc3QgdmFsdWVzDQo+IGZvcg0KPiA+ID4gZ3Vlc3QtbWVtb3J5LXNlY3Rp b24gYW5kIHN0YXRpYy1tZW0gYmFzZWQgb24gdGhlIG1lbW9yeSBhdmFpbGFibGUuDQo+ID4gPg0K PiA+DQo+ID4gSG93IFhlbiB0byBwaWNrPyBEb2VzIGl0IG1lYW4gaW4gc3RhdGljIGFsbG9jYXRp b24gRG9tVSBEVCBub2RlLCB3ZSBqdXN0DQo+ID4gbmVlZCBhIHNpemUsIGJ1dCBkb24ndCByZXF1 aXJlIGEgc3RhcnQgYWRkcmVzcyBmb3Igc3RhdGljLW1lbT8NCj4gDQo+IFllcyB0aGUgaWRlYSB3 YXMgdGhhdCB0aGUgdXNlciB3b3VsZCBvbmx5IHByb3ZpZGUgdGhlIHNpemUgKGUuZy4NCj4gRE9N VV9TVEFUSUNfTUVNWzFdPTEwMjQpIGFuZCB0aGUgYWRkcmVzc2VzIHdvdWxkIGJlIGF1dG9tYXRp Y2FsbHkNCj4gY2FsY3VsYXRlZC4gQnV0IEkgZGlkbid0IG1lYW4gdG8gY2hhbmdlIHRoZSBleGlz dGluZyB4ZW4sc3RhdGljLW1lbQ0KPiBkZXZpY2UgdHJlZSBiaW5kaW5ncy4gU28gaXQgaXMgYmVz dCBpZiB0aGUgeGVuLHN0YXRpYy1tZW0gYWRkcmVzc2VzDQo+IGdlbmVyYXRpb24gaXMgZG9uZSBi eSBJbWFnZUJ1aWxkZXIgKG9yIHNpbWlsYXIgdG9vbCkgaW5zdGVhZCBvZiBYZW4uDQo+IA0KDQpJ ZiB3ZSBzdGlsbCBrZWVwIHRoZSBvcHRpb24gZm9yIHVzZXIgdG8gc3BlY2lmeSB0aGUgc3RhcnQg YW5kIHNpemUNCnBhcmFtZXRlcnMgZm9yIFZNIG1lbW9yeSwgYmVjYXVzZSBpdCBtYXliZSB2ZXJ5 IGltcG9ydGFudCBmb3IgYQ0KZGV0ZXJtaW5pc3RpYyBzeXN0ZW0gKGZ1bGx5IHN0YXRpYyBzeXN0 ZW0pLCBJIGFncmVlIHdpdGggeW91Lg0KDQpBbmQgaW4gY3VycmVudCBzdGF0aWMtYWxsb2NhdGlv biwgSSB0aGluayBYZW4gZG9lc24ndCBnZW5lcmF0ZQ0KeGVuLHN0YXRpYy1tZW0gYWRkcmVzc2Vz LCBhbGwgYnkgaGFuZHMuLi4NCg0KPiBTb3JyeSBmb3IgdGhlIGNvbmZ1c2lvbiENCj4gDQoNCk5Q IDsgKQ0KDQo+IA0KPiA+ID4gPiA+ID7CoMKgwqDCoCBkb21VMSB7DQo+ID4gPiA+ID4gPsKgwqDC oMKgwqDCoMKgwqAgLi4uDQo+ID4gPiA+ID4gPsKgwqDCoMKgwqDCoMKgwqAgI3hlbixzdGF0aWMt bWVtLWFkZHJlc3MtY2VsbHMgPSA8MHgwMT47DQo+ID4gPiA+ID4gPsKgwqDCoMKgwqDCoMKgwqAg I3hlbixzdGF0aWMtbWVtLXNpemUtY2VsbHMgPSA8MHgwMT47DQo+ID4gPiA+ID4gPsKgwqDCoMKg wqDCoMKgwqAgLyogU3RhdGljYWxseSBhbGxvY2F0ZWQgZ3Vlc3QgbWVtb3J5LCB3aXRoaW4gbXB1 LGd1ZXN0LQ0KPiA+ID4gbWVtb3J5LQ0KPiA+ID4gPiA+IHNlY3Rpb24gKi8NCj4gPiA+ID4gPiA+ wqDCoMKgwqDCoMKgwqDCoCB4ZW4sc3RhdGljLW1lbSA9IDwweDMwMDAwMDAwIDB4MWYwMDAwMDA+ Ow0KPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+wqDCoMKgwqDCoMKgwqDCoCBtb2R1bGVAMTEwMDAw MDAgew0KPiA+ID4gPiA+ID7CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgY29tcGF0aWJsZSA9ICJt dWx0aWJvb3Qsa2VybmVsXDBtdWx0aWJvb3QsbW9kdWxlIjsNCj4gPiA+ID4gPiA+wqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgIC8qIEJvb3QgbW9kdWxlIGFkZHJlc3MsIHdpdGhpbiBtcHUsYm9vdC1t b2R1bGUtDQo+IHNlY3Rpb24NCj4gPiA+ICovDQo+ID4gPiA+ID4gPsKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoCByZWcgPSA8MHgxMTAwMDAwMCAweDMwMDAwMDA+Ow0KPiA+ID4gPiA+ID7CoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqAgLi4uDQo+ID4gPiA+ID4gPsKgwqDCoMKgwqDCoMKgwqAgfTsNCj4g PiA+ID4gPiA+DQo+ID4gPiA+ID4gPsKgwqDCoMKgwqDCoMKgwqAgbW9kdWxlQDEwRkYwMDAwIHsN Cj4gPiA+ID4gPiA+wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgY29tcGF0aWJsZSA9 ICJtdWx0aWJvb3QsZGV2aWNlLQ0KPiA+ID4gdHJlZVwwbXVsdGlib290LG1vZHVsZSI7DQo+ID4g PiA+ID4gPsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIC8qIEJvb3QgbW9kdWxlIGFk ZHJlc3MsIHdpdGhpbiBtcHUsYm9vdC1tb2R1bGUtDQo+ID4gPiBzZWN0aW9uDQo+ID4gPiA+ID4g Ki8NCj4gPiA+ID4gPiA+wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcmVnID0gPDB4 MTBmZjAwMDAgMHgxMDAwMD47DQo+ID4gPiA+ID4gPsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgIC4uLg0KPiA+ID4gPiA+ID7CoMKgwqDCoMKgwqDCoMKgIH07DQo+ID4gPiA+ID4gPsKg wqDCoMKgIH07DQo+ID4gPiA+ID4gPiB9Ow0KPiA+ID4gPiA+ID4gYGBgDQo= From xen-devel-bounces@lists.xenproject.org Wed Mar 02 07:22:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 07:22:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.281995.480545 (Exim 4.92) (envelope-from ) id 1nPJJB-0001WH-3O; Wed, 02 Mar 2022 07:22:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 281995.480545; Wed, 02 Mar 2022 07:22:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPJJB-0001WA-0I; Wed, 02 Mar 2022 07:22:01 +0000 Received: by outflank-mailman (input) for mailman id 281995; Wed, 02 Mar 2022 07:21:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPJJ8-0001W3-S3 for xen-devel@lists.xenproject.org; Wed, 02 Mar 2022 07:21:59 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2062a.outbound.protection.outlook.com [2a01:111:f400:7e1a::62a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 70df1c7b-99f9-11ec-8eba-a37418f5ba1a; Wed, 02 Mar 2022 08:21:56 +0100 (CET) Received: from AM6PR10CA0082.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:8c::23) by DBBPR08MB4710.eurprd08.prod.outlook.com (2603:10a6:10:f3::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.26; Wed, 2 Mar 2022 07:21:53 +0000 Received: from VE1EUR03FT022.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:8c:cafe::55) by AM6PR10CA0082.outlook.office365.com (2603:10a6:209:8c::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.14 via Frontend Transport; Wed, 2 Mar 2022 07:21:53 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT022.mail.protection.outlook.com (10.152.18.64) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22 via Frontend Transport; Wed, 2 Mar 2022 07:21:52 +0000 Received: ("Tessian outbound 826a6d8e58c3:v113"); Wed, 02 Mar 2022 07:21:52 +0000 Received: from d1d4b9c45f5d.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id A294619C-7D67-443A-AF6F-6AE5ED5F9717.1; Wed, 02 Mar 2022 07:21:51 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d1d4b9c45f5d.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 02 Mar 2022 07:21:51 +0000 Received: from DU2PR08MB7325.eurprd08.prod.outlook.com (2603:10a6:10:2e4::7) by HE1PR0802MB2474.eurprd08.prod.outlook.com (2603:10a6:3:e2::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.14; Wed, 2 Mar 2022 07:21:39 +0000 Received: from DU2PR08MB7325.eurprd08.prod.outlook.com ([fe80::b84f:d66b:13a7:245]) by DU2PR08MB7325.eurprd08.prod.outlook.com ([fe80::b84f:d66b:13a7:245%7]) with mapi id 15.20.5017.027; Wed, 2 Mar 2022 07:21:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 70df1c7b-99f9-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Tw+q6GjRMtOYcdH4Q4SF3TG4OIRNlxJCmmtJJHK5DlA=; b=J4zE/Gs+1UlIu8Z/FbynXE/wQpIDU/ZNS2GiZ6ETkat8dA8pBtx/3or7EHg8vh4q6cX6KgckFi07JwH1jE4lq4QqNFsYNBz32yXdJllHxNwJHSyZtRa0SV9p+lXUJE/e9QqFC420/6e6ZWjLwkSToJ9HbHBtCCytZUCWVQ8WLaw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 6dccadcbce57e4f2 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bhLVn0mVZwjEOUW2c0SFsjfd8fUjKEXKB9JkU8ST7HDhl0j8gwBC2GbDTFNKacesh+A9sGpyL4iZNtD0nWmGRbkCsrRnXiaFyKdrpCbX529K12lPooeqh3gmdgiczB09WGuDpv+JTTNGdK3VKONXjvPKYb+02RDTfS75ZxAbwTYswE3BvIHgFq7AzHiobsEjVZ4yjP1ILJ/u2lRzIrOMlxVZwS7LW5vpEp7MG5OeyR/C9LnoHY9ZH45hZZHxUmW+lmadZQrJDMyTLN7j96UGrUQYiBAmUQ2x/fHykMJaNHufYIcJ/OMBQNajA9izgLOsRizcLLIGCBVzK9Es5RzdoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Tw+q6GjRMtOYcdH4Q4SF3TG4OIRNlxJCmmtJJHK5DlA=; b=MvG6UdvAAeAcFm9U01pa/DJK9fbuNfODtkBBlp/2ObXVXsTaVaJeRA+A+M9+TLmEJHKlgklkZjY3dYG3ZfB6xsRYj+7nWrVliSG7KfauuYxg3H9LBbd2JqfBA3CL9WIJHRbU30GTkobkjKXv4Gu6uhWt2UWEUSwAiZ3VBcAyaGUnADKWitx8MITRek1q37lwVf3cWCxIDjm5AA69FgXUcQas5BoYjr/yULxLHOrdXgbQaaudnAM6hBW0EYttSk+dHXpb6waoOC7H/H2ghsM9mnqwrqWaM6iBBn9APa3QAM54U5rf+B99srjKWRKtfCg8P+5TrlIW+Jk6z3O3idfRVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Tw+q6GjRMtOYcdH4Q4SF3TG4OIRNlxJCmmtJJHK5DlA=; b=J4zE/Gs+1UlIu8Z/FbynXE/wQpIDU/ZNS2GiZ6ETkat8dA8pBtx/3or7EHg8vh4q6cX6KgckFi07JwH1jE4lq4QqNFsYNBz32yXdJllHxNwJHSyZtRa0SV9p+lXUJE/e9QqFC420/6e6ZWjLwkSToJ9HbHBtCCytZUCWVQ8WLaw= From: Penny Zheng To: Wei Chen , Julien Grall , "xen-devel@lists.xenproject.org" , Stefano Stabellini CC: Bertrand Marquis , Henry Wang , nd Subject: RE: Proposal for Porting Xen to Armv8-R64 - DraftA Thread-Topic: Proposal for Porting Xen to Armv8-R64 - DraftA Thread-Index: AdgpQxtXwh7LkfydTgiYk9bhMgU+ogBRt1sAAKse4VAAMaCKcA== Date: Wed, 2 Mar 2022 07:21:39 +0000 Message-ID: References: <04db7e8b-2f04-41d7-1deb-d8bda3625c04@xen.org> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: a6ec88ea-47ec-4d5a-1f49-08d9fc1d531e x-ms-traffictypediagnostic: HE1PR0802MB2474:EE_|VE1EUR03FT022:EE_|DBBPR08MB4710:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: xMC1Vs7/N7OuM5Uc4+NTD6JxWsjR4uX/BDTfZdzGBbegCuIORxDLbNMsDbGprJMtmo7xQBNR/MdKsu5t9OOoUfufLcWpYqV7Pu4QsOUlXR22JMEMeYjPcBsYdysmIAkAGWKBXnYq+PFIGTSMd1TmZDy5A8TqJiaSUaTegX00OlpcxDHHGPHIsNK9f1E036cT11M5eJxuBw9wOFUGNUwfZTTp1d6AyVvCWC1aYISBB/QzpQdEAC6i4SRW3QiMrR2WIUWYTbsNO11ZaeAr8LQvXTzioIPV+GIJTZWv/mWKA9lqKPl4Qzjlx3CvzUl9pMwSLn+zFIvJGQ1Td/gMg0VMl6lvWv/0E3Hag0ZXMPuNMwFEqC27UZGgo7mSGmdPJ2lGVDTMIbP7FIbFCvZgGUg9oVFfdlHhNJjAMcHWSAgKh0ceZxD7pDNUKMZF38yvXplyeEiHjHQyg27C+Rh6EUYipIZB0YuHmRKwelh7KeEoBr6CX+rUahxNT8npA+lhKsTmQQ+LJtWfVLjf46WsOuaqNdePS3uzGXe/r0FqXLGeDRfpuVS0I8VU51ArJKdAFLtzRzhI5D56bWi7HdbYo5EU24cSbnhKc6k438h5jwOOab3ni6utp43drVomX5EAQ+qYbpHl0Vf7RXgxoDjSK2InWh3NBcFLxuVuiLRYHlRKenIi/t8Vxs5Twc280/kQeQBAGxQcpKXs+/8xVJ3y/5Jqjnmno9VRhjRENHsz5RyChQxmCduemQ62Dugq0b+RegUyV0AlzWfmSXYK7Q39pJnM4g== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR08MB7325.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(83380400001)(54906003)(110136005)(8936002)(4326008)(71200400001)(76116006)(316002)(66946007)(66556008)(66476007)(66446008)(64756008)(55016003)(33656002)(86362001)(8676002)(52536014)(26005)(186003)(9686003)(38100700002)(30864003)(38070700005)(5660300002)(508600001)(6506007)(7696005)(53546011)(2906002)(122000001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0802MB2474 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT022.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 459cfe3b-188c-4858-ef5f-08d9fc1d4b38 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ls/ivsYFzY/cU4Tw8lkcFvgmzSQC9JLf5oMk7e9vH2kztCBgIPNlk3XJCZhV0qJaROeOSUlh/wtz5eOxJzTFjNHAf0NCCgAFm3b2KUCoKe1nsJ0rNZVRXOUf9WVt7rn/62e0yTzD9voWnWWDOg5yrvHosAfZS0lxhXOXLDS/e0p3Th8VGb6rLqtsyv9ekFGzloe7la4BLpIj+PngWMJPZ03Q9cSb8DAQE72ubnWIAwOTXFyU9ragSAOnLoaxLKOeEIMadO8yE//kUM42iKTM1x091vCNc7LeDVLdzrX5TaP5S+eWOFw2k2sxK1p54vhBGexvhDW+CYG+FSZgCveCr9ezDU1m0emH6VDLASXC5wyPwkmyQFB0/EICDhIRMPeSNh+dEOeYOky0L153slFikmqF8ELL3THU/WuGoMqtsuYeP1CRmtEnz5j6OJbyMidxerIpJky2ovmaW/avDU0zfDB4E5BiTwRik0ohBD1jihQbUxN3XjfzBx8A6nB348GAHScNcvoQuI8p6m4u9kwpNHbyiatiQxiL9ustM9t1DuM63EaK5TKwlYQBGGARFZb7FzqlZG//weh/cWXRSjE7/KQC99hCUIektVWRkMBJNU/joCe0hsDM7sDuUhIfNFtT25m6ZV2c0WsaHl/5Ru12I3KVF/0k97XSmEZTYKFRh8fpg95G9hVRJJnWbL5jSQ3ih4kqrYJcl1N1cZW/qEujzP6qI4+3ZFlHffWQzxmBCM7Lu0szcxgsmxR2EHFMxH4cEpqLtuWd/IlqdUsazbPUMg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(26005)(336012)(9686003)(356005)(81166007)(86362001)(33656002)(186003)(83380400001)(316002)(110136005)(30864003)(2906002)(54906003)(82310400004)(5660300002)(4326008)(36860700001)(55016003)(508600001)(6506007)(8676002)(70206006)(52536014)(47076005)(7696005)(8936002)(70586007)(40460700003)(53546011);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2022 07:21:52.6963 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a6ec88ea-47ec-4d5a-1f49-08d9fc1d531e X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT022.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4710 SGkganVsaWVuDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogV2VpIENo ZW4gPFdlaS5DaGVuQGFybS5jb20+DQo+IFNlbnQ6IFR1ZXNkYXksIE1hcmNoIDEsIDIwMjIgMzo1 MiBQTQ0KPiBUbzogSnVsaWVuIEdyYWxsIDxqdWxpZW5AeGVuLm9yZz47IHhlbi1kZXZlbEBsaXN0 cy54ZW5wcm9qZWN0Lm9yZzsgU3RlZmFubw0KPiBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJu ZWwub3JnPg0KPiBDYzogQmVydHJhbmQgTWFycXVpcyA8QmVydHJhbmQuTWFycXVpc0Bhcm0uY29t PjsgUGVubnkgWmhlbmcNCj4gPFBlbm55LlpoZW5nQGFybS5jb20+OyBIZW5yeSBXYW5nIDxIZW5y eS5XYW5nQGFybS5jb20+OyBuZA0KPiA8bmRAYXJtLmNvbT4NCj4gU3ViamVjdDogUkU6IFByb3Bv c2FsIGZvciBQb3J0aW5nIFhlbiB0byBBcm12OC1SNjQgLSBEcmFmdEENCj4gDQo+IEhpIEp1bGll biwNCj4gDQo+ID4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gPiBGcm9tOiBKdWxpZW4g R3JhbGwgPGp1bGllbkB4ZW4ub3JnPg0KPiA+IFNlbnQ6IDIwMjLlubQy5pyIMjbml6UgNDo1NQ0K PiA+IFRvOiBXZWkgQ2hlbiA8V2VpLkNoZW5AYXJtLmNvbT47IHhlbi1kZXZlbEBsaXN0cy54ZW5w cm9qZWN0Lm9yZzsNCj4gPiBTdGVmYW5vIFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5v cmc+DQo+ID4gQ2M6IEJlcnRyYW5kIE1hcnF1aXMgPEJlcnRyYW5kLk1hcnF1aXNAYXJtLmNvbT47 IFBlbm55IFpoZW5nDQo+ID4gPFBlbm55LlpoZW5nQGFybS5jb20+OyBIZW5yeSBXYW5nIDxIZW5y eS5XYW5nQGFybS5jb20+OyBuZA0KPiA+IDxuZEBhcm0uY29tPg0KPiA+IFN1YmplY3Q6IFJlOiBQ cm9wb3NhbCBmb3IgUG9ydGluZyBYZW4gdG8gQXJtdjgtUjY0IC0gRHJhZnRBDQo+ID4NCj4gPiBI aSBXZWksDQo+ID4NCj4gPiBUaGFuayB5b3UgZm9yIHNlbmRpbmcgdGhlIHByb3Bvc2FsLiBQbGVh c2UgZmluZCBzb21lIGNvbW1lbnRzIGJlbG93Lg0KPiA+DQo+ID4gT24gMjQvMDIvMjAyMiAwNjow MSwgV2VpIENoZW4gd3JvdGU6DQo+ID4gPiAjIFByb3Bvc2FsIGZvciBQb3J0aW5nIFhlbiB0byBB cm12OC1SNjQNCj4gPiA+DQo+ID4gPiBUaGlzIHByb3Bvc2FsIHdpbGwgaW50cm9kdWNlIHRoZSBQ b0Mgd29yayBvZiBwb3J0aW5nIFhlbiB0bw0KPiA+ID4gQXJtdjgtUjY0LCB3aGljaCBpbmNsdWRl czoNCj4gPiA+IC0gVGhlIGNoYW5nZXMgb2YgY3VycmVudCBYZW4gY2FwYWJpbGl0eSwgbGlrZSBY ZW4gYnVpbGQgc3lzdGVtLCBtZW1vcnkNCj4gPiA+ICAgIG1hbmFnZW1lbnQsIGRvbWFpbiBtYW5h Z2VtZW50LCB2Q1BVIGNvbnRleHQgc3dpdGNoLg0KPiA+ID4gLSBUaGUgZXhwYW5kZWQgWGVuIGNh cGFiaWxpdHksIGxpa2Ugc3RhdGljLWFsbG9jYXRpb24gYW5kIGRpcmVjdC1tYXAuDQo+ID4gPg0K PiA+ID4gKioqTm90ZXM6KioqDQo+ID4gPiAxLiAqKipUaGlzIHByb3Bvc2FsIG9ubHkgY292ZXJz IHRoZSB3b3JrIG9mIHBvcnRpbmcgWGVuIHRvIEFybXY4LVI2NCoqKg0KPiA+ID4gICAgICoqKnNp bmdsZSBDUFUuIFhlbiBTTVAgc3VwcG9ydCBvbiBBcm12OC1SNjQgcmVsYXRlcyB0byBBcm12OC1S KioqDQo+ID4gPiAgICAgKioqVHJ1c3RlZC1Gcmltd2FyZSAoVEYtUikuIFRoaXMgaXMgYW4gZXh0 ZXJuYWwgZGVwZW5kZW5jeSwqKioNCj4gPiA+ICAgICAqKipzbyB3ZSB0aGluayB0aGUgZGlzY3Vz c2lvbiBvZiBYZW4gU01QIHN1cHBvcnQgb24gQXJtdjgtUjY0KioqDQo+ID4gPiAgICAgKioqc2hv dWxkIGJlIHN0YXJ0ZWQgd2hlbiBzaW5nbGUtQ1BVIHN1cHBvcnQgaXMgY29tcGxldGUuKioqDQo+ ID4NCj4gPiBJIGFncmVlIHRoYXQgd2Ugc2hvdWxkIGZpcnN0IGZvY3VzIG9uIHNpbmdsZS1DUFUg c3VwcG9ydC4NCj4gPg0KPiANCj4gYWNrLg0KPiANCj4gPiA+IDIuICoqKlRoaXMgcHJvcG9zYWwg d2lsbCBub3QgdG91Y2ggeGVuLXRvb2xzLiBJbiBjdXJyZW50IHN0YWdlLCoqKg0KPiA+ID4gICAg ICoqKlhlbiBvbiBBcm12OC1SNjQgb25seSBzdXBwb3J0IGRvbTBsZXNzLCBhbGwgZ3Vlc3RzIHNo b3VsZCoqKg0KPiA+ID4gICAgICoqKmJlIGJvb3RlZCBmcm9tIGRldmljZSB0cmVlLioqKg0KPiA+ DQo+ID4gTWFrZSBzZW5zZS4gSSBhY3R1YWxseSBleHBlY3Qgc29tZSBpc3N1ZXMgaW4gdGhlIHdh eSB4ZW4tdG9vbHMgd291bGQNCj4gPiBuZWVkIHRvIGFjY2VzcyBtZW1vcnkgb2YgdGhlIGRvbWFp biB0aGF0IGlzIGJlZW4gY3JlYXRlZC4NCj4gPg0KPiANCj4gWWVzLCB3ZSBhbHNvIGZlZWwgdGhh dCBjaGFuZ2VzIHRvIHhlbi10b29scyBjb3VsZCBiZSBhIGJpZyBqb2IgaW4gdGhlIGZ1dHVyZQ0K PiAoYm90aCB4ZW4gY29tbW9uIGltcGxlbWVudGF0aW9uIGFuZCB0b29scyBuZWVkIGNoYW5nZXMp Lg0KPiANCj4gPiBbLi4uXQ0KPiA+DQo+ID4gPiAjIyMgMS4yLiBYZW4gQ2hhbGxlbmdlcyB3aXRo IFBNU0EgVmlydHVhbGl6YXRpb24gWGVuIGlzIFBNU0EgdW5hd2FyZQ0KPiA+ID4gVHlwZS0xIEh5 cGVydmlzb3IsIGl0IHdpbGwgbmVlZCBtb2RpZmljYXRpb25zIHRvIHJ1biB3aXRoIGFuIE1QVSBh bmQNCj4gPiA+IGhvc3QgbXVsdGlwbGUgZ3Vlc3QgT1Nlcy4NCj4gPiA+DQo+ID4gPiAtIE5vIE1N VSBhdCBFTDI6DQo+ID4gPiAgICAgIC0gTm8gRUwyIFN0YWdlIDEgYWRkcmVzcyB0cmFuc2xhdGlv bg0KPiA+ID4gICAgICAgICAgLSBYZW4gcHJvdmlkZXMgZml4ZWQgQVJNNjQgdmlydHVhbCBtZW1v cnkgbGF5b3V0IGFzIGJhc2lzDQo+ID4gPiBvZg0KPiA+IEVMMg0KPiA+ID4gICAgICAgICAgICBz dGFnZSAxIGFkZHJlc3MgdHJhbnNsYXRpb24sIHdoaWNoIGlzIG5vdCBhcHBsaWNhYmxlIG9uDQo+ ID4gPiBNUFUNCj4gPiBzeXN0ZW0sDQo+ID4gPiAgICAgICAgICAgIHdoZXJlIHRoZXJlIGlzIG5v IHZpcnR1YWwgYWRkcmVzc2luZy4gQXMgYSByZXN1bHQsIGFueQ0KPiA+IG9wZXJhdGlvbg0KPiA+ ID4gICAgICAgICAgICBpbnZvbHZpbmcgdHJhbnNpdGlvbiBmcm9tIFBBIHRvIFZBLCBsaWtlIGlv cmVtYXAsIG5lZWRzDQo+ID4gbW9kaWZpY2F0aW9uDQo+ID4gPiAgICAgICAgICAgIG9uIE1QVSBz eXN0ZW0uDQo+ID4gPiAgICAgIC0gWGVuJ3MgcnVuLXRpbWUgYWRkcmVzc2VzIGFyZSB0aGUgc2Ft ZSBhcyB0aGUgbGluayB0aW1lIGFkZHJlc3Nlcy4NCj4gPiA+ICAgICAgICAgIC0gRW5hYmxlIFBJ QyAocG9zaXRpb24taW5kZXBlbmRlbnQgY29kZSkgb24gYSByZWFsLXRpbWUgdGFyZ2V0DQo+ID4g PiAgICAgICAgICAgIHByb2Nlc3NvciBwcm9iYWJseSB2ZXJ5IHJhcmUuDQo+ID4NCj4gPiBBc2lk ZSB0aGUgYXNzZW1ibHkgYm9vdCBjb2RlIGFuZCBVRUZJIHN0dWIsIFhlbiBhbHJlYWR5IHJ1bnMg YXQgdGhlDQo+ID4gc2FtZSBhZGRyZXNzIGFzIGl0IHdhcyBsaW5rZWQuDQo+ID4NCj4gDQo+IEJ1 dCB0aGUgZGlmZmVyZW5jZSBpcyB0aGF0LCBiYXNlIG9uIE1NVSwgd2UgY2FuIHVzZSB0aGUgc2Ft ZSBsaW5rIGFkZHJlc3MNCj4gZm9yIGFsbCBwbGF0Zm9ybXMuIEJ1dCBvbiBNUFUgc3lzdGVtLCB3 ZSBjYW4ndCBkbyBpdCBpbiB0aGUgc2FtZSB3YXkuDQo+IA0KPiA+ID4gICAgICAtIFhlbiB3aWxs IG5lZWQgdG8gdXNlIHRoZSBFTDIgTVBVIG1lbW9yeSByZWdpb24gZGVzY3JpcHRvcnMgdG8NCj4g PiBtYW5hZ2UNCj4gPiA+ICAgICAgICBhY2Nlc3MgcGVybWlzc2lvbnMgYW5kIGF0dHJpYnV0ZXMg Zm9yIGFjY2Vzc2VzIG1hZGUgYnkgVk1zIGF0DQo+ID4gRUwxLzAuDQo+ID4gPiAgICAgICAgICAt IFhlbiBjdXJyZW50bHkgcmVsaWVzIG9uIE1NVSBFTDEgc3RhZ2UgMiB0YWJsZSB0byBtYW5hZ2Ug dGhlc2UNCj4gPiA+ICAgICAgICAgICAgYWNjZXNzZXMuDQo+ID4gPiAtIE5vIE1NVSBTdGFnZSAy IHRyYW5zbGF0aW9uIGF0IEVMMToNCj4gPiA+ICAgICAgLSBBIGd1ZXN0IGRvZXNuJ3QgaGF2ZSBh biBpbmRlcGVuZGVudCBndWVzdCBwaHlzaWNhbCBhZGRyZXNzIHNwYWNlDQo+ID4gPiAgICAgIC0g QSBndWVzdCBjYW4gbm90IHJldXNlIHRoZSBjdXJyZW50IEludGVybWVkaWF0ZSBQaHlzaWNhbCBB ZGRyZXNzDQo+ID4gPiAgICAgICAgbWVtb3J5IGxheW91dA0KPiA+ID4gICAgICAtIEEgZ3Vlc3Qg dXNlcyBwaHlzaWNhbCBhZGRyZXNzZXMgdG8gYWNjZXNzIG1lbW9yeSBhbmQgZGV2aWNlcw0KPiA+ ID4gICAgICAtIFRoZSBNUFUgYXQgRUwyIG1hbmFnZXMgRUwxIHN0YWdlIDIgYWNjZXNzIHBlcm1p c3Npb25zIGFuZA0KPiA+IGF0dHJpYnV0ZXMNCj4gPiA+IC0gVGhlcmUgYXJlIGEgbGltaXRlZCBu dW1iZXIgb2YgTVBVIHByb3RlY3Rpb24gcmVnaW9ucyBhdCBib3RoIEVMMg0KPiA+ID4gYW5kDQo+ ID4gRUwxOg0KPiA+ID4gICAgICAtIEFyY2hpdGVjdHVyYWxseSwgdGhlIG1heGltdW0gbnVtYmVy IG9mIHByb3RlY3Rpb24gcmVnaW9ucyBpcyAyNTYsDQo+ID4gPiAgICAgICAgdHlwaWNhbCBpbXBs ZW1lbnRhdGlvbnMgaGF2ZSAzMi4NCj4gPiA+ICAgICAgLSBCeSBjb250cmFzdCwgWGVuIGRvZXMg bm90IG5lZWQgdG8gY29uc2lkZXIgdGhlIG51bWJlciBvZiBwYWdlDQo+ID4gdGFibGUNCj4gPiA+ ICAgICAgICBlbnRyaWVzIGluIHRoZW9yeSB3aGVuIHVzaW5nIE1NVS4NCj4gPiA+IC0gVGhlIE1Q VSBwcm90ZWN0aW9uIHJlZ2lvbnMgYXQgRUwyIG5lZWQgdG8gYmUgc2hhcmVkIGJldHdlZW4gdGhl DQo+ID4gaHlwZXJ2aXNvcg0KPiA+ID4gICAgYW5kIHRoZSBndWVzdCBzdGFnZSAyLg0KPiA+ID4g ICAgICAtIFJlcXVpcmVzIGNhcmVmdWwgY29uc2lkZXJhdGlvbiAtIG1heSBpbXBhY3QgZmVhdHVy ZQ0KPiA+ID4gJ2Z1bGxuZXNzJyBvZg0KPiA+IGJvdGgNCj4gPiA+ICAgICAgICB0aGUgaHlwZXJ2 aXNvciBhbmQgdGhlIGd1ZXN0DQo+ID4gPiAgICAgIC0gQnkgY29udHJhc3QsIHdoZW4gdXNpbmcg TU1VLCBYZW4gaGFzIHN0YW5kYWxvbmUgUDJNIHRhYmxlIGZvcg0KPiA+IGd1ZXN0DQo+ID4gPiAg ICAgICAgc3RhZ2UgMiBhY2Nlc3Nlcy4NCj4gPg0KPiA+IFsuLi5dDQo+ID4NCj4gPiA+IC0gKioq RGVmaW5lIG5ldyBzeXN0ZW0gcmVnaXN0ZXJzIGZvciBjb21waWxlcnMqKio6DQo+ID4gPiAgICBB cm12OC1SNjQgaXMgYmFzZWQgb24gQXJtdjguNC4gVGhhdCBtZWFucyB3ZSB3aWxsIHVzZSBzb21l IEFybXY4LjQNCj4gPiA+ICAgIHNwZWNpZmljIHN5c3RlbSByZWdpc3RlcnMuIEFzIEFybXY4LVI2 NCBvbmx5IGhhdmUgc2VjdXJlIHN0YXRlLCBzbw0KPiA+ID4gICAgYXQgbGVhc3QsIGBWU1RDUl9F TDJgIGFuZCBgVlNDVExSX0VMMmAgd2lsbCBiZSB1c2VkIGZvciBYZW4uIEFuZCB0aGUNCj4gPiA+ ICAgIGZpcnN0IEdDQyB2ZXJzaW9uIHRoYXQgc3VwcG9ydHMgQXJtdjguNCBpcyBHQ0MgOC4xLiBJ biBhZGRpdGlvbiB0bw0KPiA+ID4gICAgdGhlc2UsIFBNU0Egb2YgQXJtdjgtUjY0IGludHJvZHVj ZWQgbG90cyBvZiBNUFUgcmVsYXRlZCBzeXN0ZW0NCj4gPiByZWdpc3RlcnM6DQo+ID4gPiAgICBg UFJCQVJfRUx4YCwgYFBSQkFSeF9FTHhgLCBgUFJMQVJfRUx4YCwgYFBSTEFSeF9FTHhgLCBgUFJF TlJfRUx4YA0KPiBhbmQNCj4gPiA+ICAgIGBNUFVJUl9FTHhgLiBCdXQgdGhlIGZpcnN0IEdDQyB2 ZXJzaW9uIHRvIHN1cHBvcnQgdGhlc2Ugc3lzdGVtDQo+ID4gcmVnaXN0ZXJzDQo+ID4gPiAgICBp cyBHQ0MgMTEuIFNvIHdlIGhhdmUgdHdvIHdheXMgdG8gbWFrZSBjb21waWxlcnMgdG8gd29yayBw cm9wZXJseQ0KPiA+IHdpdGgNCj4gPiA+ICAgIHRoZXNlIHN5c3RlbSByZWdpc3RlcnMuDQo+ID4g PiAgICAxLiBCdW1wIEdDQyB2ZXJzaW9uIHRvIEdDQyAxMS4NCj4gPiA+ICAgICAgIFRoZSBwcm9z IG9mIHRoaXMgbWV0aG9kIGlzIHRoYXQsIHdlIGRvbid0IG5lZWQgdG8gZW5jb2RlIHRoZXNlDQo+ ID4gPiAgICAgICBzeXN0ZW0gcmVnaXN0ZXJzIGluIG1hY3JvcyBieSBvdXJzZWx2ZXMuIEJ1dCB0 aGUgY29ucyBhcmUgdGhhdCwNCj4gPiA+ICAgICAgIHdlIGhhdmUgdG8gdXBkYXRlIE1ha2VmaWxl cyB0byBzdXBwb3J0IEdDQyAxMSBmb3IgQXJtdjgtUjY0Lg0KPiA+ID4gICAgICAgMS4xLiBDaGVj ayB0aGUgR0NDIHZlcnNpb24gMTEgZm9yIEFybXY4LVI2NC4NCj4gPiA+ICAgICAgIDEuMi4gQWRk IG1hcmNoPWFybXY4ciB0byBDRkxBR1MgZm9yIEFybXY4LVI2NC4NCj4gPiA+ICAgICAgIDEuMy4g U29sdmUgdGhlIGNvbmZsaWN0aW9uIG9mIG1hcmNoPWFybXY4ciBhbmQgbWNwdT1nZW5lcmljDQo+ ID4gPiAgICAgIFRoZXNlIGNoYW5nZXMgd2lsbCBhZmZlY3QgY29tbW9uIE1ha2VmaWxlcywgbm90 IG9ubHkgQXJtIE1ha2VmaWxlcy4NCj4gPiA+ICAgICAgQW5kIEdDQyAxMSBpcyBuZXcsIGxvdHMg b2YgdG9vbGNoYWlucyBhbmQgRGlzdHJvIGhhdmVuJ3QNCj4gPiA+IHN1cHBvcnRlZA0KPiA+IGl0 Lg0KPiA+DQo+ID4gSSBhZ3JlZSB0aGF0IGZvcmNpbmcgdG8gdXNlIEdDQzExIGlzIG5vdCBhIGdv b2QgaWRlYS4gQnV0IEkgYW0gbm90DQo+ID4gc3VyZSB0byB1bmRlcnN0YW5kIHRoZSBwcm9ibGVt IHdpdGggdGhlIC1tYXJjaD0uLi4uIFVsdGltYXRlbHksDQo+ID4gc2hvdWxkbid0IHdlIGFpbSB0 byBidWlsZCBYZW4gQVJNdjgtUiB3aXRoIC1tYXJjaD1hcm12OHI/DQo+ID4NCj4gDQo+IEFjdHVh bGx5LCB3ZSBoYWQgZG9uZSwgYnV0IHdlIHJldmVydGVkIGl0IGZyb20gUkZDIHBhdGNoIHNlcmll cy4gVGhlIHJlYXNvbg0KPiBoYXMgYmVlbiBsaXN0ZWQgYWJvdmUuIEJ1dCB0aGF0IGlzIG5vdCB0 aGUgbWFqb3IgcmVhc29uLiBUaGUgbWFpbiByZWFzb24gaXMNCj4gdGhhdDoNCj4gQXJtdjgtUiBB QXJjaDY0IHN1cHBvcnRzIHRoZSBBNjQgSVNBIGluc3RydWN0aW9uIHNldCB3aXRoIHNvbWUNCj4g bW9kaWZpY2F0aW9uczoNCj4gUmVkZWZpbmVzIERNQiwgRFNCLCBhbmQgYWRkcyBhbiBERkIuIEJ1 dCBhY3R1YWxseSwgdGhlIGVuY29kaW5ncyBvZiBETUINCj4gYW5kIERTQiBhcmUgc3RpbGwgdGhl IHNhbWUgd2l0aCBBNjQuIEFuZCBERkIgaXMgYSBhbGlhcyBvZiBEU0IgIzEyLg0KPiANCj4gSW4g dGhpcyBjYXNlLCB3ZSBkb24ndCB0aGluayB3ZSBuZWVkIGEgbmV3IGFyY2ggZmxhZyB0byBnZW5l cmF0ZSBuZXcNCj4gaW5zdHJ1Y3Rpb25zIGZvciBBcm12OC1SLiBBbmQgd2UgaGF2ZSBkaXNjdXNz ZWQgd2l0aCBBcm0ga2VybmVsIGd1eXMsIHRoZXkNCj4gd2lsbCBub3QgdXBkYXRlIHRoZSBidWls ZCBzeXN0ZW0gdG8gYnVpbGQgTGludXggdGhhdCB3aWxsIGJlIHJ1bm5pbmcgb24NCj4gQXJtdjgt UjY0IEVMMSBlaXRoZXIuDQo+IA0KPiANCj4gPiBbLi4uXQ0KPiA+DQo+ID4gPiAjIyMgKioyLjIu IENoYW5nZXMgb2YgdGhlIGluaXRpYWxpemF0aW9uIHByb2Nlc3MqKiBJbiBnZW5lcmFsLCB3ZQ0K PiA+ID4gc3RpbGwgZXhwZWN0IEFybXY4LVI2NCBhbmQgQXJtdjgtQTY0IHRvIGhhdmUgYSBjb25z aXN0ZW50DQo+ID4gPiBpbml0aWFsaXphdGlvbiBwcm9jZXNzLiBJbiBhZGRpdGlvbiB0byBzb21l IGFyY2hpdGVjdHVyZQ0KPiA+ID4gZGlmZmVyZW5jZXMsDQo+ID4gdGhlcmUNCj4gPiA+IGlzIG5v IG1vcmUgdGhhbiByZXVzYWJsZSBjb2RlIHRoYXQgd2Ugd2lsbCBkaXN0aW5ndWlzaCB0aHJvdWdo DQo+ID4gQ09ORklHX0FSTV9NUFUNCj4gPiA+IG9yIENPTkZJR19BUk02NF9WOFIuIFdlIHdhbnQg bW9zdCBvZiB0aGUgaW5pdGlhbGl6YXRpb24gY29kZSB0byBiZQ0KPiA+IHJldXNhYmxlDQo+ID4g PiBiZXR3ZWVuIEFybXY4LVI2NCBhbmQgQXJtdjgtQTY0Lg0KPiA+ID4NCj4gPiA+IC0gV2Ugd2ls bCByZXVzZSB0aGUgb3JpZ2luYWwgaGVhZC5zIGFuZCBzZXR1cC5jIG9mIEFybS4gQnV0IHJlcGxh Y2UgdGhlDQo+ID4gPiAgICBNTVUgYW5kIHBhZ2UgdGFibGUgb3BlcmF0aW9ucyBpbiB0aGVzZSBm aWxlcyB3aXRoIGNvbmZpZ3VyYXRpb24NCj4gPiBvcGVyYXRpb25zDQo+ID4gPiAgICBmb3IgTVBV IGFuZCBNUFUgcmVnaW9ucy4NCj4gPiA+DQo+ID4gPiAtIFdlIHByb3ZpZGUgYSBib290LXRpbWUg TVBVIGNvbmZpZ3VyYXRpb24uIFRoaXMgTVBVIGNvbmZpZ3VyYXRpb24gd2lsbA0KPiA+ID4gICAg c3VwcG9ydCBYZW4gdG8gZmluaXNoIGl0cyBpbml0aWFsaXphdGlvbi4gQW5kIHRoaXMgYm9vdC10 aW1lIE1QVQ0KPiA+ID4gICAgY29uZmlndXJhdGlvbiB3aWxsIHJlY29yZCB0aGUgbWVtb3J5IHJl Z2lvbnMgdGhhdCB3aWxsIGJlIHBhcnNlZCBmcm9tDQo+ID4gPiAgICBkZXZpY2UgdHJlZS4NCj4g PiA+DQo+ID4gPiAgICBJbiB0aGUgZW5kIG9mIFhlbiBpbml0aWFsaXphdGlvbiwgd2Ugd2lsbCB1 c2UgYSBydW50aW1lIE1QVQ0KPiA+IGNvbmZpZ3VyYXRpb24NCj4gPiA+ICAgIHRvIHJlcGxhY2Ug Ym9vdC10aW1lIE1QVSBjb25maWd1cmF0aW9uLiBUaGUgcnVudGltZSBNUFUNCj4gPiA+IGNvbmZp Z3VyYXRpb24NCj4gPiB3aWxsDQo+ID4gPiAgICBtZXJnZSBhbmQgcmVvcmRlciBtZW1vcnkgcmVn aW9ucyB0byBzYXZlIG1vcmUgTVBVIHJlZ2lvbnMgZm9yDQo+IGd1ZXN0cy4NCj4gPiA+DQo+ID4g PiAhW2ltZ10oaHR0cHM6Ly9kcml2ZS5nb29nbGUuY29tL3VjP2V4cG9ydD12aWV3JmlkPTF3VEZ5 SzJYZlUzbFRsSDFQDQo+IHENCj4gPiA+IFINCj4gPiBEb2FjUVZUd1V0V0lHVSkNCj4gPiA+DQo+ ID4gPiAtIERlZmVyIHN5c3RlbSB1bnBhdXNpbmcgZG9tYWluLg0KPiA+ID4gICAgV2hlbiBYZW4g aW5pdGlhbGl6YXRpb24gaXMgYWJvdXQgdG8gZW5kLCBYZW4gdW5wYXVzZSBndWVzdHMgY3JlYXRl ZA0KPiA+ID4gICAgZHVyaW5nIGluaXRpYWxpemF0aW9uLiBCdXQgdGhpcyB3aWxsIGNhdXNlIHNv bWUgaXNzdWVzLiBUaGUgdW5wYXVzZQ0KPiA+ID4gICAgYWN0aW9uIG9jY3VycyBiZWZvcmUgZnJl ZV9pbml0X21lbW9yeSwgaG93ZXZlciB0aGUgcnVudGltZSBNUFUNCj4gPiBjb25maWd1cmF0aW9u DQo+ID4gPiAgICBpcyBidWlsdCBhZnRlciBmcmVlX2luaXRfbWVtb3J5Lg0KPiA+DQo+ID4gSSB3 YXMgaGFsZiBleHBlY3RpbmcgdGhhdCBmcmVlX2luaXRfbWVtb3J5KCkgd291bGQgbm90IGJlIGNh bGxlZCBmb3INCj4gPiBYZW4gQXJtdjhSLg0KPiA+DQo+IA0KPiBXZSBoYWQgY2FsbGVkIGZyZWVf aW5pdF9tZW1vcnkgZm9yIFhlbiBBcm12OFIsIGJ1dCBpdCBkb2Vzbid0IHJlYWxseSBtZWFuDQo+ IG11Y2guIEFzIHdlIGhhdmUgc3RhdGljIGhlYXAsIHNvIHdlIGRvbid0IHJlY2xhaW0gaW5pdCBt ZW1vcnkgdG8gaGVhcC4gQW5kDQo+IHRoaXMgcmVjbGFpbWVkIG1lbW9yeSBjb3VsZCBub3QgYmUg dXNlZCBieSBYZW4gZGF0YSBhbmQgYnNzIGVpdGhlci4gQnV0DQo+IGZyb20gdGhlIHNlY3VyaXR5 IHBlcnNwZWN0aXZlLCBmcmVlX2luaXRfbWVtb3J5IHdpbGwgZHJvcCB0aGUgWGVuIGluaXQgY29k ZSAmDQo+IGRhdGEsIHRoaXMgd2lsbCByZWR1Y2UgdGhlIGNvZGUgYW4gYXR0YWNrZXIgY2FuIGV4 cGxvaXQuDQo+IA0KPiA+ID4NCj4gPiA+ICAgIFNvIGlmIHRoZSB1bnBhdXNlZCBndWVzdHMgc3Rh cnQgZXhlY3V0aW5nIHRoZSBjb250ZXh0IHN3aXRjaCBhdCB0aGlzDQo+ID4gPiAgICBwb2ludCwg dGhlbiBpdHMgTVBVIGNvbnRleHQgd2lsbCBiYXNlIG9uIHRoZSBib290LXRpbWUgTVBVDQo+ID4g Y29uZmlndXJhdGlvbi4NCj4gPg0KPiA+IENhbiB5b3UgZXhwbGFpbiB3aHkgeW91IHdhbnQgdG8g c3dpdGNoIHRoZSBNUFUgY29uZmlndXJhdGlvbiB0aGF0IGxhdGU/DQo+ID4NCj4gDQoNCkl0IGlz IG1vcmUgcmVsYXRlZCB0byB0aGUgaW1wbGVtZW50YXRpb24uDQoNCkluIHRoZSBib290IHN0YWdl LCB3ZSBhbGxvY2F0ZSBNUFUgcmVnaW9ucyBpbiBzZXF1ZW5jZSB1bnRpbCB0aGUgbWF4LiANClNp bmNlIGEgZmV3IE1QVSByZWdpb24gd2lsbCBnZXQgcmVtb3ZlZCBhbG9uZyB0aGUgd2F5LCBpdCBs ZWF2ZXMgaG9sZSB0aGVyZS4NClN1Y2ggbGlrZSB3aGVuIGhlYXAgaXMgcmVhZHksIGZkdCB3aWxs IGJlIHJlYWxsb2NhdGVkIGluIHRoZSBoZWFwLCB3aGljaCBtZWFucyB0aGUNCk1QVSByZWdpb24g Zm9yIGRldmljZSB0cmVlIGlzIGluIG5vIG5lZWQuIEFuZCBhbHNvIGluIGZyZWVfaW5pdF9tZW1v cnksIGFsdGhvdWdoIHdlDQpkbyBub3QgZ2l2ZSBiYWNrIGluaXQgbWVtb3J5IHRvIHRoZSBoZWFw LCB3ZSB3aWxsIGFsc28gZGVzdHJveSBhY2NvcmRpbmcgTVBVDQpyZWdpb25zIHRvIG1ha2UgdGhl bSBpbmFjY2Vzc2libGUuDQpXaXRob3V0IG9yZGVyaW5nLCB3ZSBuZWVkIGEgYml0bWFwIHRvIHJl Y29yZCBzdWNoIGluZm9ybWF0aW9uLg0KDQpJbiBjb250ZXh0IHN3aXRjaCwgdGhlIG1lbW9yeSBs YXlvdXQgaXMgcXVpdGUgZGlmZmVyZW50IGZvciBndWVzdCBtb2RlIGFuZA0KaHlwZXJ2aXNvciBt b2RlLiBXaGVuIHN3aXRjaGluZyB0byBndWVzdCBtb2RlLCBvbmx5IGd1ZXN0IFJBTSwgZW11bGF0 ZWQvcGFzc3Rocm91Z2gNCmRldmljZXMsIGV0YyBjb3VsZCBiZSBzZWVuLCBidXQgaW4gaHlwZXJ2 aXNvciBtb2RlLCBhbGwgZ3Vlc3RzIFJBTSBhbmQgZGV2aWNlIG1lbW9yeQ0Kc2hhbGwgYmUgc2Vl bi4gQW5kIHdpdGhvdXQgcmVvcmRlcmluZywgd2UgbmVlZCB0byBpdGVyYXRlIGFsbCBNUFUgcmVn aW9ucyB0byBmaW5kDQphY2NvcmRpbmcgcmVnaW9ucyB0byBkaXNhYmxlIGR1cmluZyBydW50aW1l IGNvbnRleHQgc3dpdGNoLCB0aGF0J3MgZGVmaW5pdGVseSBhIG92ZXJoZWFkLg0KDQpTbyB3ZSBw cm9wb3NlIGFuIG9yZGVyaW5nIGF0IHRoZSB0YWlsIG9mIHRoZSBib290IHRpbWUsIHRvIHB1dCBh bGwgZml4ZWQgTVBVIHJlZ2lvbg0KaW4gdGhlIGhlYWQsIGxpa2UgeGVuIHRleHQvZGF0YSwgZXRj LCBhbmQgcHV0IGFsbCBmbGV4aWJsZSBvbmVzIGF0IHRhaWwsIGxpa2UgZGV2aWNlIG1lbW9yeSwN Cmd1ZXN0cyBSQU0uDQpUaGVuIGxhdGVyIGluIGNvbnRleHQgc3dpdGNoLCAgd2UgY291bGQgZWFz aWx5IGp1c3QgZGlzYWJsZSBvbmVzIGZyb20gdGFpbCBhbmQgaW5zZXJ0cyBuZXcNCm9uZXMgaW4g dGhlIHRhaWwuICAgIA0KDQo+IEluIHRoZSBib290IHN0YWdlLCBYZW4gaXMgdGhlIG9ubHkgdXNl ciBvZiBNUFUuIEl0IG1heSBhZGQgc29tZSBtZW1vcnkNCj4gbm9kZXMgb3IgZGV2aWNlIG1lbW9y eSB0byBNUFUgcmVnaW9ucyBmb3IgdGVtcG9yYXJ5IHVzYWdlLiBBZnRlciBmcmVlIGluaXQNCj4g bWVtb3J5LCB3ZSB3YW50IHRvIHJlY2xhaW0gdGhlc2UgTVBVIHJlZ2lvbnMgdG8gZ2l2ZSBtb3Jl IE1QVSByZWdpb25zDQo+IGNhbiBiZSB1c2VkIGZvciBndWVzdHMuIEFsc28gd2Ugd2lsbCBkbyBz b21lIG1lcmdlIGFuZCByZW9yZGVyIHdvcmsuIFRoaXMNCj4gd29yayBjYW4gbWFrZSBNUFUgcmVn aW9ucyB0byBiZSBlYXNpZXIgbWFuYWdlZCBpbiBndWVzdCBjb250ZXh0IHN3aXRjaC4NCj4gDQo+ ID4gPiAgICBQcm9iYWJseSBpdCB3aWxsIGJlIGluY29uc2lzdGVudCB3aXRoIHJ1bnRpbWUgTVBV IGNvbmZpZ3VyYXRpb24sIHRoaXMNCj4gPiA+ICAgIHdpbGwgY2F1c2UgdW5leHBlY3RlZCBwcm9i bGVtcyAoVGhpcyBtYXkgbm90IGhhcHBlbiBpbiBhIHNpbmdsZSBjb3JlDQo+ID4gPiAgICBzeXN0 ZW0sIGJ1dCBvbiBTTVAgc3lzdGVtcywgdGhpcyBwcm9ibGVtIGlzIGZvcmVzZWVhYmxlLCBzbyB3 ZQ0KPiA+ID4gaG9wZQ0KPiA+IHRvDQo+ID4gPiAgICBzb2x2ZSBpdCBhdCB0aGUgYmVnaW5uaW5n KS4NCj4gPg0KPiA+IFsuLi5dDQo+ID4NCj4gPiA+ICMjIyAqKjIuNC4gQ2hhbmdlcyBvZiBtZW1v cnkgbWFuYWdlbWVudCoqIFhlbiBpcyBjb3VwbGVkIHdpdGggVk1TQSwNCj4gPiA+IGluIG9yZGVy IHRvIHBvcnQgWGVuIHRvIEFybXY4LVI2NCwgd2UgaGF2ZSB0byBkZWNvdXBsZSBYZW4gZnJvbQ0K PiA+ID4gVk1TQS4gQW5kIGdpdmUgWGVuIHRoZSBhYmlsaXR5IHRvIG1hbmFnZSBtZW1vcnkgaW4N Cj4gPiBQTVNBLg0KPiA+ID4NCj4gPiA+IDEuICoqKlVzZSBidWRkeSBhbGxvY2F0b3IgdG8gbWFu YWdlIHBoeXNpY2FsIHBhZ2VzIGZvciBQTVNBKioqDQo+ID4gPiAgICAgRnJvbSB0aGUgdmlldyBv ZiBwaHlzaWNhbCBwYWdlLCBQTVNBIGFuZCBWTVNBIGRvbid0IGhhdmUgYW55DQo+ID4gZGlmZmVy ZW5jZS4NCj4gPiA+ICAgICBTbyB3ZSBjYW4gcmV1c2UgYnVkZHkgYWxsb2NhdG9yIG9uIEFybXY4 LVI2NCB0byBtYW5hZ2UgcGh5c2ljYWwNCj4gPiBwYWdlcy4NCj4gPiA+ICAgICBUaGUgZGlmZmVy ZW5jZSBpcyB0aGF0LCBpbiBWTVNBLCBYZW4gd2lsbCBtYXAgYWxsb2NhdGVkIHBhZ2VzIHRvDQo+ ID4gdmlydHVhbA0KPiA+ID4gICAgIGFkZHJlc3Nlcy4gQnV0IGluIFBNU0EsIFhlbiBqdXN0IGNv bnZlcnQgdGhlIHBhZ2VzIHRvIHBoeXNpY2FsDQo+ID4gYWRkcmVzcy4NCj4gPiA+DQo+ID4gPiAy LiAqKipDYW4gbm90IHVzZSB2aXJ0dWFsIGFkZHJlc3MgZm9yIG1lbW9yeSBtYW5hZ2VtZW50Kioq DQo+ID4gPiAgICAgQXMgQXJtdjgtUjY0IG9ubHkgaGFzIFBNU0EgaW4gRUwyLCBYZW4gbG9zZXMg dGhlIGFiaWxpdHkgb2YNCj4gPiA+IHVzaW5nDQo+ID4gdmlydHVhbA0KPiA+ID4gICAgIGFkZHJl c3MgdG8gbWFuYWdlIG1lbW9yeS4gVGhpcyBicmluZ3Mgc29tZSBwcm9ibGVtcywgc29tZQ0KPiA+ ID4gdmlydHVhbA0KPiA+IGFkZHJlc3MNCj4gPiA+ICAgICBiYXNlZCBmZWF0dXJlcyBjb3VsZCBu b3Qgd29yayB3ZWxsIG9uIEFybXY4LVI2NCwgbGlrZSBgRklYTUFQYCwNCj4gPiBgdm1hcC92dW1h cGAsDQo+ID4gPiAgICAgYGlvcmVtYXBgIGFuZCBgYWx0ZXJuYXRpdmVgLg0KPiA+ID4NCj4gPiA+ ICAgICBCdXQgdGhlIGZ1bmN0aW9ucyBvciBtYWNyb3Mgb2YgdGhlc2UgZmVhdHVyZXMgYXJlIHVz ZWQgaW4gbG90cw0KPiA+ID4gb2YNCj4gPiBjb21tb24NCj4gPiA+ICAgICBjb2RlLiBTbyBpdCdz IG5vdCBnb29kIHRvIHVzZSBgI2lmZGVmIENPTkZJR19BUk1fTVBVYCB0byBnYXRlDQo+ID4gPiBy ZWxhdGUNCj4gPiBjb2RlDQo+ID4gPiAgICAgZXZlcnl3aGVyZS4gSW4gdGhpcyBjYXNlLCB3ZSBw cm9wb3NlIHRvIHVzZSBzdHViIGhlbHBlcnMgdG8gbWFrZQ0KPiA+ID4gdGhlDQo+ID4gY2hhbmdl cw0KPiA+ID4gICAgIHRyYW5zcGFyZW50bHkgdG8gY29tbW9uIGNvZGUuDQo+ID4gPiAgICAgMS4g Rm9yIGBGSVhNQVBgLCB3ZSB3aWxsIHVzZSBgMGAgaW4gYEZJWE1BUF9BRERSYCBmb3IgYWxsIGZp eG1hcA0KPiA+IG9wZXJhdGlvbnMuDQo+ID4gPiAgICAgICAgVGhpcyB3aWxsIHJldHVybiBwaHlz aWNhbCBhZGRyZXNzIGRpcmVjdGx5IG9mIGZpeG1hcHBlZCBpdGVtLg0KPiA+ID4gICAgIDIuIEZv ciBgdm1hcC92dW1hcGAsIHdlIHdpbGwgdXNlIHNvbWUgZW1wdHkgaW5saW5lIHN0dWIgaGVscGVy czoNCj4gPiA+ICAgICAgICAgIGBgYA0KPiA+ID4gICAgICAgICAgc3RhdGljIGlubGluZSB2b2lk IHZtX2luaXRfdHlwZSguLi4pIHt9DQo+ID4gPiAgICAgICAgICBzdGF0aWMgaW5saW5lIHZvaWQg Kl9fdm1hcCguLi4pDQo+ID4gPiAgICAgICAgICB7DQo+ID4gPiAgICAgICAgICAgICAgcmV0dXJu IE5VTEw7DQo+ID4gPiAgICAgICAgICB9DQo+ID4gPiAgICAgICAgICBzdGF0aWMgaW5saW5lIHZv aWQgdnVubWFwKGNvbnN0IHZvaWQgKnZhKSB7fQ0KPiA+ID4gICAgICAgICAgc3RhdGljIGlubGlu ZSB2b2lkICp2bWFsbG9jKHNpemVfdCBzaXplKQ0KPiA+ID4gICAgICAgICAgew0KPiA+ID4gICAg ICAgICAgICAgIHJldHVybiBOVUxMOw0KPiA+ID4gICAgICAgICAgfQ0KPiA+ID4gICAgICAgICAg c3RhdGljIGlubGluZSB2b2lkICp2bWFsbG9jX3hlbihzaXplX3Qgc2l6ZSkNCj4gPiA+ICAgICAg ICAgIHsNCj4gPiA+ICAgICAgICAgICAgICByZXR1cm4gTlVMTDsNCj4gPiA+ICAgICAgICAgIH0N Cj4gPiA+ICAgICAgICAgIHN0YXRpYyBpbmxpbmUgdm9pZCB2ZnJlZSh2b2lkICp2YSkge30NCj4g PiA+ICAgICAgICAgIGBgYA0KPiA+ID4NCj4gPiA+ICAgICAzLiBGb3IgYGlvcmVtYXBgLCBpdCBk ZXBlbmRzIG9uIGB2bWFwYC4gQXMgd2UgaGF2ZSBtYWtlIGB2bWFwYA0KPiA+ID4gdG8NCj4gPiBh bHdheXMNCj4gPiA+ICAgICAgICByZXR1cm4gYE5VTExgLCB0aGV5IGNvdWxkIG5vdCB3b3JrIHdl bGwgb24gQXJtdjgtUjY0IHdpdGhvdXQNCj4gPiBjaGFuZ2VzLg0KPiA+ID4gICAgICAgIGBpb3Jl bWFwYCB3aWxsIHJldHVybiBpbnB1dCBhZGRyZXNzIGRpcmVjdGx5Lg0KPiA+ID4gICAgICAgICAg YGBgDQo+ID4gPiAgICAgICAgICBzdGF0aWMgaW5saW5lIHZvaWQgKmlvcmVtYXBfYXR0ciguLi4p DQo+ID4gPiAgICAgICAgICB7DQo+ID4gPiAgICAgICAgICAgICAgLyogV2UgZG9uJ3QgaGF2ZSB0 aGUgYWJpbGl0eSB0byBjaGFuZ2UgaW5wdXQgUEEgY2FjaGUNCj4gPiBhdHRyaWJ1dGVzICovDQo+ ID4gT09JLCB3aG8gd2lsbCBzZXQgdGhlbT8NCj4gDQo+IFNvbWUgY2FsbGVycyB0aGF0IHdhbnQg dG8gY2hhbmdlIGEgbWVtb3J5J3MgYXR0cmlidXRlIHdpbGwgc2V0IHRoZW0uDQo+IFNvbWV0aGlu ZyBsaWtlIGlvcmVtYXBfbm9jYWNoZS4gSSBhbSBub3Qgc3VyZSBpcyB0aGlzIHdoYXQgeW91IGhh ZCBhc2tlZCA6ICkNCj4gDQo+ID4NCj4gPiA+ICAgICAgICAgICAgICBpZiAoIENBQ0hFX0FUVFJf bmVlZF9jaGFuZ2UgKQ0KPiA+ID4gICAgICAgICAgICAgICAgICByZXR1cm4gTlVMTDsNCj4gPiA+ ICAgICAgICAgICAgICByZXR1cm4gKHZvaWQgKilwYTsNCj4gPiA+ICAgICAgICAgIH0NCj4gPiA+ ICAgICAgICAgIHN0YXRpYyBpbmxpbmUgdm9pZCBfX2lvbWVtICppb3JlbWFwX25vY2FjaGUoLi4u KQ0KPiA+ID4gICAgICAgICAgew0KPiA+ID4gICAgICAgICAgICAgIHJldHVybiBpb3JlbWFwX2F0 dHIoc3RhcnQsIGxlbiwgUEFHRV9IWVBFUlZJU09SX05PQ0FDSEUpOw0KPiA+ID4gICAgICAgICAg fQ0KPiA+ID4gICAgICAgICAgc3RhdGljIGlubGluZSB2b2lkIF9faW9tZW0gKmlvcmVtYXBfY2Fj aGUoLi4uKQ0KPiA+ID4gICAgICAgICAgew0KPiA+ID4gICAgICAgICAgICAgIHJldHVybiBpb3Jl bWFwX2F0dHIoc3RhcnQsIGxlbiwgUEFHRV9IWVBFUlZJU09SKTsNCj4gPiA+ICAgICAgICAgIH0N Cj4gPiA+ICAgICAgICAgIHN0YXRpYyBpbmxpbmUgdm9pZCBfX2lvbWVtICppb3JlbWFwX3djKC4u LikNCj4gPiA+ICAgICAgICAgIHsNCj4gPiA+ICAgICAgICAgICAgICByZXR1cm4gaW9yZW1hcF9h dHRyKHN0YXJ0LCBsZW4sIFBBR0VfSFlQRVJWSVNPUl9XQyk7DQo+ID4gPiAgICAgICAgICB9DQo+ ID4gPiAgICAgICAgICB2b2lkICppb3JlbWFwKC4uLikNCj4gPiA+ICAgICAgICAgIHsNCj4gPiA+ ICAgICAgICAgICAgICByZXR1cm4gaW9yZW1hcF9hdHRyKHBhLCBsZW4sIFBBR0VfSFlQRVJWSVNP Ul9OT0NBQ0hFKTsNCj4gPiA+ICAgICAgICAgIH0NCj4gPiA+DQo+ID4gPiAgICAgICAgICBgYGAN Cj4gPiA+ICAgICAgNC4gRm9yIGBhbHRlcm5hdGl2ZWAsIGl0IGRlcGVuZHMgb24gYHZtYXBgIHRv by4NCj4gPg0KPiA+IFRoZSBvbmx5IHJlYXNvbiB3ZSBkZXBlbmQgb24gdm1hcCgpIGlzIGJlY2F1 c2UgdGhlIG1hcCB0aGUgc2VjdGlvbnMNCj4gPiAqdGV4dCByZWFkLW9ubHkgYW5kIHdlIGVuZm9y Y2UgV25YLiBGb3IgVk1TQSwgaXQgd291bGQgYmUgcG9zc2libGUgdG8NCj4gPiBhdm9pZCB2bWFw KCkgd2l0aCBzb21lIHJld29yay4gSSBkb24ndCBrbm93IGZvciBQTVNBLg0KPiA+DQo+IA0KPiBG b3IgUE1TQSwgd2Ugc3RpbGwgZW5mb3JjZSBXblguIEZvciB5b3VyIHVzZSBjYXNlLCBJIGFzc3Vt ZSBpdCdzIGFsdGVybmF0aXZlLg0KPiBJdCBzdGlsbCBtYXkgaGF2ZSBzb21lIHBvc3NpYmlsaXR5 IHRvIGF2b2lkIHZtYXAoKS4gQnV0IHRoZXJlIG1heSBiZSBzb21lDQo+IHNlY3VyaXR5IGlzc3Vl cy4gV2UgaGFkIHRob3VnaHQgdG8gZGlzYWJsZSBNUFUgLT4gdXBkYXRlIHhlbiB0ZXh0IC0+IGVu YWJsZQ0KPiBNUFUgdG8gY29weSBWTVNBIGFsdGVybmF0aXZlJ3MgYmVoYXZpb3IuIFRoZSBwcm9i bGVtIHdpdGggdGhpcywgaG93ZXZlciwNCj4gaXMgdGhhdCBhdCBzb21lIHBvaW50LCBhbGwgbWVt b3J5IGlzIFJXWC4gVGhlcmUgbWF5YmUgc29tZSBzZWN1cml0eSByaXNrLg0KPiBCdXQgYmVjYXVz ZSBpdCdzIGluIGluaXQgc3RhZ2UsIGl0IHByb2JhYmx5IGRvZXNuJ3QgbWF0dGVyIGFzIG11Y2gg YXMgSSB0aG91Z2h0Lg0KPiANCg0KSW4gTU1VIHN5c3RlbSwgd2UgdXNlIHZtYXAoKSB0byBjaGFu Z2UgcmVxdWVzdGVkIHhlbiB0ZXh0IGNvZGVzKGEgZmV3IGxpbmVzKSB0ZW1wb3JhcmlseQ0KdG8g UlcgdG8gYXBwbHkgdGhlIGFsdGVybmF0aXZlIGNvZGVzLCB0aGUgZ3JhbnVsYXJpdHkgZm9yIGl0 IGNvdWxkIGJlIDRLQi4NCg0KQnV0IG9uIE1QVSBzeXN0ZW0sIHdlIGdpdmUgdGhlIHdob2xlIFhF TiB0ZXh0IGNvZGUgYSBNUFUgcmVnaW9uLCBzbyBvdGhlcndpc2Ugd2UgZGlzYWJsZQ0KdGhlIHdo b2xlIE1QVSB0byBtYWtlIGl0IGhhcHBlbiwgd2hpY2ggbGVhZHMgdG8gYSBsaXR0bGUgcmlzayBm b3IgcnVubmluZyBjIGNvZGVzIHdoZXJlIE1QVQ0KZGlzYWJsZWQsIG9yIGFsbCB0ZXh0IG1lbW9y eSBiZWNvbWluZyBSV1ggYXQgdGhpcyBhbHRlcm5hdGl2ZSB0aW1lLg0KIA0KPiA+ID4gV2Ugd2ls bCBzaW1wbHkgZGlzYWJsZQ0KPiA+ID4gICAgICAgICBpdCBvbiBBcm12OC1SNjQgaW4gY3VycmVu dCBzdGFnZS4gSG93IHRvIGltcGxlbWVudCBgYWx0ZXJuYXRpdmVgDQo+ID4gPiAgICAgICAgIG9u IEFybXY4LVI2NCBpcyBiZXR0ZXIgdG8gYmUgZGlzY3Vzc2VkIGFmdGVyIGJhc2ljIGZ1bmN0aW9u cw0KPiA+ID4gb2YNCj4gPiBYZW4NCj4gPiA+ICAgICAgICAgb24gQXJtdjgtUjY0IHdvcmsgd2Vs bC4NCj4gPiBhbHRlcm5hdGl2ZSBhcmUgbW9zdGx5IGhlbHBmdWwgdG8gaGFuZGxlIGVycmF0YSBv ciBlbmFibGUgZmVhdHVyZXMNCj4gPiB0aGF0IGFyZSBub3QgcHJlc2VudCBvbiBhbGwgQ1BVcy4g SSB3b3VsZG4ndCBleHBlY3QgdGhpcyB0byBiZQ0KPiA+IG5lY2Vzc2FyeSBhdCB0aGUgYmVnaW5u aW5nLiBJbiBmYWN0LCBvbiBBcm0sIGl0IHdhcyBpbnRyb2R1Y2VkID4gNA0KPiA+IHllYXJzIGFm dGVyIHRoZSBpbml0aWFsIHBvcnQgOikuDQo+IA0KPiBJIGhvcGUgaXQgd29uJ3QgdGFrZSB1cyBz byBsb25nLCB0aGlzIHRpbWUgOiApDQo+IA0KPiA+DQo+ID4gWy4uLl0NCj4gPg0KPiA+ID4gIyMj ICoqMi41LiBDaGFuZ2VzIG9mIGRldmljZSBkcml2ZXIqKiAxLiBCZWNhdXNlIEFybXY4LVI2NCBv bmx5IGhhcw0KPiA+ID4gc2luZ2xlIHNlY3VyZSBzdGF0ZSwgdGhpcyB3aWxsIGFmZmVjdCBzb21l IGRldmljZXMgdGhhdCBoYXZlIHR3bw0KPiA+ID4gc2VjdXJlIHN0YXRlLCBsaWtlIEdJQy4gQnV0 IGZvcnR1bmF0ZWx5LCBtb3N0IHZlbmRvcnMgd2lsbCBub3QgbGluaw0KPiA+ID4gYSB0d28gc2Vj dXJlIHN0YXRlIEdJQyB0byBBcm12OC1SNjQgcHJvY2Vzc29ycy4NCj4gPiA+IEN1cnJlbnQgR0lD IGRyaXZlciBjYW4gd29yayB3ZWxsIHdpdGggc2luZ2xlIHNlY3VyZSBzdGF0ZSBHSUMgZm9yDQo+ ID4gPiBBcm12OC0NCj4gPiBSNjQuDQo+ID4gPiAyLiBYZW4gc2hvdWxkIHVzZSBzZWN1cmUgaHlw ZXJ2aXNvciB0aW1lciBpbiBTZWN1cmUgRUwyLiBXZSB3aWxsDQo+ID4gaW50cm9kdWNlDQo+ID4g PiBhIENPTkZJR19BUk1fU0VDVVJFX1NUQVRFIHRvIG1ha2UgWGVuIHRvIHVzZSBzZWN1cmUgcmVn aXN0ZXJzIGZvcg0KPiB0aW1lci4NCj4gPiA+DQo+ID4gPiAjIyMgKioyLjcuIENoYW5nZXMgb2Yg dmlydHVhbCBkZXZpY2UqKiBDdXJyZW50bHksIHdlIG9ubHkgc3VwcG9ydA0KPiA+ID4gcGFzcy10 aHJvdWdoIGRldmljZXMgaW4gZ3Vlc3QuIEJlY2F1c2UgZXZlbnQgY2hhbm5lbCwgeGVuLWJ1cywN Cj4gPiA+IHhlbi1zdG9yYWdlIGFuZCBvdGhlciBhZHZhbmNlZCBYZW4gZmVhdHVyZXMgaGF2ZW4n dA0KPiA+IGJlZW4NCj4gPiA+IGVuYWJsZWQgaW4gQXJtdjgtUjY0Lg0KPiA+DQo+ID4gVGhhdCdz IGZpbmUuIEkgZXhwZWN0IHRvIHJlcXVpcmUgcXVpdGUgYSBiaXQgb2Ygd29yayB0byBtb3ZlIGZy b20gWGVuDQo+ID4gc2hhcmluZyB0aGUgcGFnZXMgKGUuZy4gbGlrZSBmb3IgZ3JhbnQtdGFibGVz KSB0byB0aGUgZ3Vlc3Qgc2hhcmluZyBwYWdlcy4NCj4gPg0KPiANCj4gWWVzLg0KPiANCj4gPiBD aGVlcnMsDQo+ID4NCj4gPiAtLQ0KPiA+IEp1bGllbiBHcmFsbA0KDQo= From xen-devel-bounces@lists.xenproject.org Wed Mar 02 07:36:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 07:36:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282004.480555 (Exim 4.92) (envelope-from ) id 1nPJX2-0003WW-Ew; Wed, 02 Mar 2022 07:36:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282004.480555; Wed, 02 Mar 2022 07:36:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPJX2-0003WP-Bc; Wed, 02 Mar 2022 07:36:20 +0000 Received: by outflank-mailman (input) for mailman id 282004; Wed, 02 Mar 2022 07:36:19 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPJX1-0003WF-0h; Wed, 02 Mar 2022 07:36:19 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPJX0-0007Xa-TN; Wed, 02 Mar 2022 07:36:18 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPJX0-00006h-9Q; Wed, 02 Mar 2022 07:36:18 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nPJX0-0007k3-7N; Wed, 02 Mar 2022 07:36:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=5w0k3nOm44d1NslJDqQUF63MfGVwOFgxhiwXLZV9x88=; b=3Q9YnopX2VHyFqz6R3Dzfl/hZJ CAe5CLFHK0jlxFfiGf6r01ysAyf9wQCN8IhbeuRVQKxXvUyiwY1kursDjUIBd029SvxdE3IWSmg9+ 6G5ZuY2ciJpUMCUSEgVrXZh+R/OiYCTD71HbiqDQ7VS8hIZRLe0QgispT67t3Veout9c=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 168300: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-dom0pvh-xl-intel:guest-localmigrate:fail:heisenbug qemu-mainline:test-armhf-armhf-xl-rtds:guest-start:fail:allowable qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=99c53410bc9d50e556f565b0960673cccb566452 X-Osstest-Versions-That: qemuu=a8d39f5b5ae899b1c872f128f82959158cfce048 From: osstest service owner Date: Wed, 02 Mar 2022 07:36:18 +0000 flight 168300 qemu-mainline real [real] flight 168325 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/168300/ http://logs.test-lab.xenproject.org/osstest/logs/168325/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-dom0pvh-xl-intel 18 guest-localmigrate fail pass in 168325-retest Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 14 guest-start fail REGR. vs. 168289 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 168289 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 168289 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168289 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 168289 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 168289 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 168289 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 168289 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 168289 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu 99c53410bc9d50e556f565b0960673cccb566452 baseline version: qemuu a8d39f5b5ae899b1c872f128f82959158cfce048 Last test of basis 168289 2022-03-01 11:07:45 Z 0 days Testing same since 168300 2022-03-01 17:39:30 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: David Miller Fabian Holler Greg Kurz Halil Pasic John Snow Markus Armbruster Nico Boehr Peter Maydell Thomas Huth jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git a8d39f5b5a..99c53410bc 99c53410bc9d50e556f565b0960673cccb566452 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Wed Mar 02 08:08:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 08:08:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282024.480567 (Exim 4.92) (envelope-from ) id 1nPK1Z-0007yz-6Z; Wed, 02 Mar 2022 08:07:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282024.480567; Wed, 02 Mar 2022 08:07:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPK1Z-0007ys-38; Wed, 02 Mar 2022 08:07:53 +0000 Received: by outflank-mailman (input) for mailman id 282024; Wed, 02 Mar 2022 08:07:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPK1X-0007ym-Vb for xen-devel@lists.xenproject.org; Wed, 02 Mar 2022 08:07:51 +0000 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id da8fb3f7-99ff-11ec-8539-5f4723681683; Wed, 02 Mar 2022 09:07:50 +0100 (CET) Received: by verein.lst.de (Postfix, from userid 2407) id F380B68AFE; Wed, 2 Mar 2022 09:07:46 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: da8fb3f7-99ff-11ec-8539-5f4723681683 Date: Wed, 2 Mar 2022 09:07:46 +0100 From: Christoph Hellwig To: Konrad Rzeszutek Wilk Cc: Christoph Hellwig , iommu@lists.linux-foundation.org, x86@kernel.org, Anshuman Khandual , Stefano Stabellini , Boris Ostrovsky , Juergen Gross , Joerg Roedel , David Woodhouse , Lu Baolu , Robin Murphy , linux-arm-kernel@lists.infradead.org, xen-devel@lists.xenproject.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-hyperv@vger.kernel.org, tboot-devel@lists.sourceforge.net, linux-pci@vger.kernel.org Subject: Re: [PATCH 07/11] x86: remove the IOMMU table infrastructure Message-ID: <20220302080746.GA23075@lst.de> References: <20220227143055.335596-1-hch@lst.de> <20220227143055.335596-8-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) On Tue, Mar 01, 2022 at 01:20:22PM -0500, Konrad Rzeszutek Wilk wrote: > I think you also need to check for IBM Calgary? The IBM Calgary IOMMU support is long gone. From xen-devel-bounces@lists.xenproject.org Wed Mar 02 08:10:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 08:10:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282030.480578 (Exim 4.92) (envelope-from ) id 1nPK4O-0000vu-Kj; Wed, 02 Mar 2022 08:10:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282030.480578; Wed, 02 Mar 2022 08:10:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPK4O-0000vn-HR; Wed, 02 Mar 2022 08:10:48 +0000 Received: by outflank-mailman (input) for mailman id 282030; Wed, 02 Mar 2022 08:10:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPK4N-0000vh-CI for xen-devel@lists.xenproject.org; Wed, 02 Mar 2022 08:10:47 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4297d0a7-9a00-11ec-8eba-a37418f5ba1a; Wed, 02 Mar 2022 09:10:45 +0100 (CET) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04lp2059.outbound.protection.outlook.com [104.47.13.59]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-39-dneQYi25NdGpaypgy7WPXg-1; Wed, 02 Mar 2022 09:10:43 +0100 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by DB8PR04MB6444.eurprd04.prod.outlook.com (2603:10a6:10:102::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.14; Wed, 2 Mar 2022 08:10:42 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5038.014; Wed, 2 Mar 2022 08:10:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4297d0a7-9a00-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1646208644; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YxYYx4qSTYeI5IcFW5GReI7x1E1NMhFusMjW6vzmXSE=; b=KJnnCFr06QfgHbtHtfkuxgsrmtf4Za5kLnY578XpdrxljA+Csq3jkiHHNCJcHglXaNhoK4 LUIjiI4YKKL/4tdmaRmDpVLTKEK77jPRxUg0AakAE95GxxNuvVOoCpUuQgxQYcRn1NiMhe 4h4CrPXDvzRz9JSq3Sa/Wdk9bQMhiD4= X-MC-Unique: dneQYi25NdGpaypgy7WPXg-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KHpnm1KTGSWq6AYPuy9F9SMhI+NwGszJpXpVoyOjNZISkvQsdK4l6goM4JFp5hcj4Tkx8hj7CXiTBZuN78SjUCD6tbrAE1/sZPGNiygXkCC6BRYvWvi1GZxIk1JnyO8LFXvrxEQBGkv5YKV78qtzrfQEQAkZzesmm7QtkkHlEN+EqZHkfJhhUtt1Hwax7sCBP93grNBAR/ajWX1HFUX2TUy+zOi8/zePdWD/nfzJPQgk1VZToGdqxEZiHlPO17AsbRqNhhf/JkppvePAUiYMibFAarornrBfBorY1a0PcmCCyI3KhWV2IJg1dscAMZPp1cP//xUF22DKQk2PcEl5JQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YxYYx4qSTYeI5IcFW5GReI7x1E1NMhFusMjW6vzmXSE=; b=XpIxGTpTJ5o0GSrVeThD4+7625JzfxmPcN/MmYiLLiB04nkZPa/yf/qOzJSRfh0H/suWttE/bQJBIUu8N8T3slD2Lk7kepui8FPZwCnQ+dNUtjQ3wEpAXhSd84S13EUTNM6syTUmdvZk1IeARyXjnXKc9AbKqublK7+B/jAbv4AWXJzcl0zvp3Y6u/CqeXoOn1qjG7jVo6YfvbjXO3bBbICQMGRt4kKuv/yOmbb76zXDKdRmryBL/ldKdKsT9SKVhV3hAdysxXrzZDpaDE9KyvJj06guXCWaFDtNZnKaQXiNHY0YDJ0yf3mpJ8yiS6CIhONz6BuA9OA8tpGlONatLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <60f3c942-3822-87dd-df6e-8b64ed4d17c4@suse.com> Date: Wed, 2 Mar 2022 09:10:40 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH v2.2 8/7] x86/IOMMU: Use altcall, and __initconst_cf_clobber Content-Language: en-US To: Andrew Cooper Cc: Roger Pau Monne , Wei Liu , Xen-devel References: <20220214125632.24563-1-andrew.cooper3@citrix.com> <20220222114711.19209-1-andrew.cooper3@citrix.com> <5fae516a-17c1-0ce4-c46e-909a83c0e273@citrix.com> From: Jan Beulich In-Reply-To: <5fae516a-17c1-0ce4-c46e-909a83c0e273@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6PR04CA0037.eurprd04.prod.outlook.com (2603:10a6:20b:f0::14) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1ff42c47-9d7e-4d48-0f90-08d9fc2424f1 X-MS-TrafficTypeDiagnostic: DB8PR04MB6444:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8asC/Dke2BAyD2jRZmFKdvO51D3C+y0jW/7+WTLgP05WSk+LPC4VWCsPhkvf5kyHoTHdpBmUHXP7+wWmvK6hSHZE0dZzujHdVRBOv7PlpARXUtQXxqWkYYFJWlSzlbtDttOyfDvddNKXR1rGDfp5GdQjoGXW69FZ+v/8mng1aJ+qOOCHmxjGEHbcxC/cPHjq8z+SfqWjPQMjt+g3AhlSO6c+jGRmMt9PFfDIhwpIPRKK75eDT5DKM78z0vyxkjf/Pj/UPWkHgHCTqI4xu6xGHC45MeLMUr2jLWcSoCAXBl5hVjFD0JNaafswIlqOyNPn8NLoHf+Viy+ohipciYjpiJH9puQ7wPlOz0RIWrkqJ9Yk8rWgLKTB8O5N9D/zwRdjM28Brk8KYCdUQHHFPmiJwn+rckjb9/BHJ5j9OT82kxmB2LCUTd6WFwaqAoI3SPEhcWALfcrEMaqAvaBZR7ASI0FRyy5s6JhNyqTk4yQnRgaosY0GJNipMPsg2oV68GCoKiKS3b962wMREOROP/mVAagMWrlRBZVmkcoWCiduFjWInxg386QpeisHcQrS7nR18u3bowNdmuXBx34T6ucmLNB6YZCxutUzASVMEWuIO4ouZbaGPQ9rlfdD5h0Meu55pX321PR/7zZ491BYASAmENugX1WSib4vLH27ZWVIyheqJDIdBijDOCAvuoYRO9HVGrzJlIcJSn0V5Y0YZzXPjakRz11r2VjIbQ7LdxaZ8iw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(38100700002)(86362001)(66476007)(66556008)(8676002)(66946007)(36756003)(5660300002)(4326008)(316002)(6916009)(54906003)(31686004)(2906002)(8936002)(2616005)(186003)(26005)(53546011)(31696002)(83380400001)(508600001)(6486002)(6512007)(6506007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?enMwMDNyNkFRd1NWSUlpK1RaZkkwWFE2Z01reVFPYjBCUUFBcWxzbEdVVVM4?= =?utf-8?B?SGkrZlNBejlJSmtlTjBwdEVVTjlSbjY3bytsL2pDWDVDc1BmQWdTTXAzUFhY?= =?utf-8?B?N3pwem15MHE2djJiVis5YmY3dDN2eDQ3cmlMdEtreHNHczdNemJjQWs0S2w2?= =?utf-8?B?cVRORWdqRDVqWW95ekt0ZmpHd0RyeE9sWVRpVHFkQmZJMHVoVklnOWJPK21l?= =?utf-8?B?RE1zTXovcVEzTDF4bWdVSEl0VktpYWgrdk9aNnJ5QVRaNTg4WGdRdmJUaEZT?= =?utf-8?B?NkxNTDJjZFlyR0RHU2R6cGZkbkZFSURQeFBHdVlGczJXaDd4b0ZZYVNHVHR2?= =?utf-8?B?R3pwaUNacngyTjZORnhDa0tKNDhYUUNrUHJaWjdlRmVhdTltZDFYT09BNmls?= =?utf-8?B?M3FQNlRPcDZKakZVVlJ6NVVtaHYrNC9MNUF1UVZTeFMrT3JsK0FnSDM3TkNp?= =?utf-8?B?dy84NnFpQjVMdnFha2lLRDQxS0IrMk1SYzIrYkJDMWdkdTREa0JpNlhTQ00y?= =?utf-8?B?aU1oU1lETXhKMWd1VXpXSEFqdmpxdHJ5VzduV1VIYUlYQnEzUkdVQlpoR1lZ?= =?utf-8?B?TVA1ZkVyNVNBaWxsTTliWnhMV08xWFFGSi8rY0hzL1Vhb0FSb1FwL1MxVE95?= =?utf-8?B?U1ZkUmdYSU9aWGJyWjhMUnRaL1NaNWZsMkx5ZVNUV1l4U05hRFJjUkxFY2Jo?= =?utf-8?B?ZnNtcXA4c3pQV1h3S0tmSkY5dlJyK0taeVlZRGJKWFg5RHVhWCt3OGNKOGVJ?= =?utf-8?B?UWdjeGREUWlqakQ0VFczNnZkT3NDZFhVYnNzcFVmblRZaEc5emZqRlpwZnBW?= =?utf-8?B?Wko5RXR1TTZSR3kxMkYveGtxQWlQSnZpOVlQbFRZbjEwZ01iOHN4NkwzTjNL?= =?utf-8?B?ZzU0V2ozblNGbExGdy9yb2RjVzdrZGNFWjM5T3UwTmdXbFZQUkJWVmNyeEM2?= =?utf-8?B?UWtvTHBKeEJyQWRtM0V2ejV4U1JucVBkMmIrQVVSVXBCRUd2RVhsMXFGczB0?= =?utf-8?B?TWx6UFdpRzdCSjNJRkRadU04b3VleGd4blhXU0dvU3F3djUrdkxuS3B1cXRh?= =?utf-8?B?aldhQXJjMmJIS2paaWZPUW04cFR6clJ2ZnJzbmNxY2djS1ZaVlU0dytocWs4?= =?utf-8?B?M0ZRSm1vOEVZR1U4Tlk3WkpPV1ZQakhrNzQzRDRFT2tEZ21mblNpYlo3bEYv?= =?utf-8?B?bDNzcndFNlFvdGRmbGhSMTRkUDk4eTJSMVhldmZ3MlJjVGpMMFA0VEtIY1l1?= =?utf-8?B?bHRlTkJva2IycGlTQ2x3TXR5Wm4vMkxZRDlVK2g1c3dCa0duTmwyYTZuZVdX?= =?utf-8?B?TGNPL1Yrc2pxZGhHQUpWa2E1RENxbWFoNzNJZlgvSlNkOXAyenIzOFZSQ1ho?= =?utf-8?B?Z0Zmb3RGNkYxMjkyRjJvQjhDQlFESFk1T25Bd3hUVVZYUVh4TmJNL2oxaU9r?= =?utf-8?B?cFg5RFl3UGNVSHpoTS9Ed1B2Y0t2YTArcERqM1lOeDFoTnJSZDdadFE3Z014?= =?utf-8?B?K1FaMXpwUU4vbmdOMjIzTW1xYTh3S3NrV3FEK2dCcUM5ajVvM05Gak1hdms3?= =?utf-8?B?TzMrU2ZBd25tYVpzcWh5aTJHaVhmT2tXa0l6NE9SWFY5SHhOeUloKzhaZ0Fn?= =?utf-8?B?Zkc2V1ppK0VERURNWDBadFR5Q1VBelFzc3dFeUZDNXhpYXBhYXJ4RTVzck1Z?= =?utf-8?B?bC85cFczb2RSWC9Qekh6c1htQ3BJc1pvcXpldjBuZGN6OExXODJaeVVYY1Ba?= =?utf-8?B?TlF1VjJsU0NMbFowdjZVMXd5OGJJY3hYZFZRQTI0amNUckJvNktGR1BBYm9G?= =?utf-8?B?Z1JscTVWZ08rL2lRdWRQVzhaMmZQaks0OGlPemRrYXdGZHNlMkNoN3BkOGxv?= =?utf-8?B?UFExUVNKRm9RSFZDeFo0NWh4OVMrb0JnYmJWS0U4TE9LS01JM1JtQWQxbm4x?= =?utf-8?B?SmJkckFOdjlCZVd4UC9UeGtVWlFieTh4a1V3UWlNeFdrcTRLZVdkWGZMODQ5?= =?utf-8?B?T3YvWFExamlxTDcyN0ZZUWNoeHBoYndPNUY0NWhpeVNYcmVqRkFLMnZSVEFS?= =?utf-8?B?SlBkaVYrSi9xSysxVDc1MjJ2a25ja0h1ZVR6cjBnK2p3aVlzWTNOdTF5MzJp?= =?utf-8?B?MlBVY0VRbjgyN2lEUlkxakxjT0lhQU5BcmE0YzVkdFJTUXNGbi9pZjlMZGhS?= =?utf-8?Q?InD/gLOuK0IBvKBpnMB0Saw=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1ff42c47-9d7e-4d48-0f90-08d9fc2424f1 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2022 08:10:42.1873 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FN91kbL4ZCZlkafdZJYiNuY6IdhF4nlOoeVYJRroazkymhm2HyVXq2ZX0cW2PqbJEDQg5Yn3nnY8Ine2/Ac0cQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6444 On 01.03.2022 15:58, Andrew Cooper wrote: > On 25/02/2022 08:24, Jan Beulich wrote: >> On 22.02.2022 12:47, Andrew Cooper wrote: >>> --- a/xen/drivers/passthrough/amd/pci_amd_iommu.c >>> +++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c >>> @@ -628,7 +628,7 @@ static void cf_check amd_dump_page_tables(struct domain *d) >>> hd->arch.amd.paging_mode, 0, 0); >>> } >>> >>> -static const struct iommu_ops __initconstrel _iommu_ops = { >>> +static const struct iommu_ops __initconst_cf_clobber _iommu_ops = { >> Following my initcall related remark on x86'es time.c I'm afraid I don't >> see how this and ... >> >>> @@ -2794,7 +2793,7 @@ static int __init cf_check intel_iommu_quarantine_init(struct domain *d) >>> return rc; >>> } >>> >>> -static struct iommu_ops __initdata vtd_ops = { >>> +static const struct iommu_ops __initconst_cf_clobber vtd_ops = { >> ... this actually works. But I guess I must be overlooking something, as >> I'm sure that you did test the change. >> >> Both ops structures reference a function, through .adjust_irq_affinities, >> which isn't __init but which is used (besides here) for an initcall. With >> the ENDBR removed by the time initcalls are run, these should cause #CP. > > This doesn't explode because the indirect calls are resolved to direct > calls before the ENDBR's are clobbered to NOP4. I'm afraid I don't understand: The problematic call is in do_initcalls(): for ( call = __presmp_initcall_end; call < __initcall_end; call++ ) (*call)(); I don't see how this could be converted to a direct call. Afaics only pre-SMP initcalls are safe in this regard: do_presmp_initcalls() is called immediately ahead of alternative_branches(). Isn't this (previously?) working related to your "x86/spec-ctrl: Disable retpolines with CET-IBT"? With full retpoline, there wouldn't be an indirect branch, but RET. But with JMP or LFENCE thunks this ought to fault (already before depending on thunk selection, but unconditionally now that your change was committed), I would think. Jan From xen-devel-bounces@lists.xenproject.org Wed Mar 02 08:15:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 08:15:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282040.480588 (Exim 4.92) (envelope-from ) id 1nPK8c-0001dm-B3; Wed, 02 Mar 2022 08:15:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282040.480588; Wed, 02 Mar 2022 08:15:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPK8c-0001df-7d; Wed, 02 Mar 2022 08:15:10 +0000 Received: by outflank-mailman (input) for mailman id 282040; Wed, 02 Mar 2022 08:15:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPK8b-0001dZ-JU for xen-devel@lists.xenproject.org; Wed, 02 Mar 2022 08:15:09 +0000 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id df9e52f2-9a00-11ec-8539-5f4723681683; Wed, 02 Mar 2022 09:15:08 +0100 (CET) Received: by verein.lst.de (Postfix, from userid 2407) id 527A368BEB; Wed, 2 Mar 2022 09:15:01 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: df9e52f2-9a00-11ec-8539-5f4723681683 Date: Wed, 2 Mar 2022 09:15:00 +0100 From: Christoph Hellwig To: Stefano Stabellini Cc: Christoph Hellwig , iommu@lists.linux-foundation.org, x86@kernel.org, Anshuman Khandual , Tom Lendacky , Konrad Rzeszutek Wilk , Boris Ostrovsky , Juergen Gross , Joerg Roedel , David Woodhouse , Lu Baolu , Robin Murphy , linux-arm-kernel@lists.infradead.org, xen-devel@lists.xenproject.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-hyperv@vger.kernel.org, tboot-devel@lists.sourceforge.net, linux-pci@vger.kernel.org Subject: Re: [PATCH 11/12] swiotlb: merge swiotlb-xen initialization into swiotlb Message-ID: <20220302081500.GB23075@lst.de> References: <20220301105311.885699-1-hch@lst.de> <20220301105311.885699-12-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) On Tue, Mar 01, 2022 at 06:55:47PM -0800, Stefano Stabellini wrote: > Unrelated to this specific patch series: now that I think about it, if > io_tlb_default_mem.nslabs is already allocated by the time xen_mm_init > is called, wouldn't we potentially have an issue with the GFP flags used > for the earlier allocation (e.g. GFP_DMA32 not used)? Maybe something > for another day. swiotlb_init allocates low memory from meblock, which is roughly equivalent to GFP_DMA allocations, so we'll be fine. > > @@ -143,10 +141,15 @@ static int __init xen_mm_init(void) > > if (!xen_swiotlb_detect()) > > return 0; > > > > - rc = xen_swiotlb_init(); > > /* we can work with the default swiotlb */ > > - if (rc < 0 && rc != -EEXIST) > > - return rc; > > + if (!io_tlb_default_mem.nslabs) { > > + if (!xen_initial_domain()) > > + return -EINVAL; > > I don't think we need this xen_initial_domain() check. It is all > already sorted out by the xen_swiotlb_detect() check above. Is it? static inline int xen_swiotlb_detect(void) { if (!xen_domain()) return 0; if (xen_feature(XENFEAT_direct_mapped)) return 1; /* legacy case */ if (!xen_feature(XENFEAT_not_direct_mapped) && xen_initial_domain()) return 1; return 0; } I think I'd keep it as-is for now, as my planned next step would be to fold xen-swiotlb into swiotlb entirely. From xen-devel-bounces@lists.xenproject.org Wed Mar 02 08:30:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 08:30:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282048.480602 (Exim 4.92) (envelope-from ) id 1nPKNV-0004Mf-NF; Wed, 02 Mar 2022 08:30:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282048.480602; Wed, 02 Mar 2022 08:30:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPKNV-0004MY-KE; Wed, 02 Mar 2022 08:30:33 +0000 Received: by outflank-mailman (input) for mailman id 282048; Wed, 02 Mar 2022 08:30:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPKNU-0004MN-34; Wed, 02 Mar 2022 08:30:32 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPKNT-0000Zw-W3; Wed, 02 Mar 2022 08:30:31 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPKNT-0003Bd-KW; Wed, 02 Mar 2022 08:30:31 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nPKNT-0000pI-I4; Wed, 02 Mar 2022 08:30:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Cn7cXvYD0PUPe49CMJjCvLPKTdDgAlMschvZ58nB5Cc=; b=N6+MoqAe5M7POOyYeedzvp287q ZnPhG278hLbDkpndbIKsCseoxJyR88Y47gyC9mk0Gw2pUemf9nUIQBmaq5Yct2k6GHitV7zLBHiTj Ho3PtvL16/Ld41Zi01kagGA41QWiEmdWzNDH1fvExDvP4+ErNFAlF1EL8nSU2Y6DcBNs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [seabios test] 168315: tolerable FAIL - PUSHED X-Osstest-Failures: seabios:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking seabios:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking seabios:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking seabios:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking seabios:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking seabios:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking seabios:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: seabios=d239552ce7220e448ae81f41515138f7b9e3c4db X-Osstest-Versions-That: seabios=829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd From: osstest service owner Date: Wed, 02 Mar 2022 08:30:31 +0000 flight 168315 seabios real [real] http://logs.test-lab.xenproject.org/osstest/logs/168315/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 168003 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168003 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 168003 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 168003 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 168003 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass version targeted for testing: seabios d239552ce7220e448ae81f41515138f7b9e3c4db baseline version: seabios 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd Last test of basis 168003 2022-02-03 23:10:24 Z 26 days Testing same since 168315 2022-03-02 02:40:13 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Kevin O'Connor jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/seabios.git 829b0f1..d239552 d239552ce7220e448ae81f41515138f7b9e3c4db -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Wed Mar 02 08:37:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 08:37:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282064.480634 (Exim 4.92) (envelope-from ) id 1nPKUT-0005V5-OU; Wed, 02 Mar 2022 08:37:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282064.480634; Wed, 02 Mar 2022 08:37:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPKUT-0005Uy-LM; Wed, 02 Mar 2022 08:37:45 +0000 Received: by outflank-mailman (input) for mailman id 282064; Wed, 02 Mar 2022 08:37:44 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPKUS-0005Uo-HR; Wed, 02 Mar 2022 08:37:44 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPKUS-0000h0-DV; Wed, 02 Mar 2022 08:37:44 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPKUR-0003pr-Vp; Wed, 02 Mar 2022 08:37:44 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nPKUR-0000AU-VI; Wed, 02 Mar 2022 08:37:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=UdAtQmwwfM/qcqwA4DuvAIDLJ1REP3HlDUzQObH1dj0=; b=vU+Teysct1cIPI+6dtSjL7cq5t bKRjXrQCuDXhrnFT/IKf0c7YHWlA47yJr3R4ZO8o7OnxUo5b1Y+v9PhptsWAchboOmw3UMs6/asjT /3GKhL6GuJd69MUJkwAlhwkcpBdyp0gZCKn3YEroc6jcqlrhZ27o0VeIvwUqESTmrmCU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 168310: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=6e3f36387de566b09aa4145ea0e3bfe4814d68b4 X-Osstest-Versions-That: xen=e0a514d2f4b2fcb51835aa9a9b02653b491a61fc From: osstest service owner Date: Wed, 02 Mar 2022 08:37:43 +0000 flight 168310 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/168310/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 168294 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168294 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 168294 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 168294 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 168294 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 168294 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 168294 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 168294 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 168294 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 168294 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 168294 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 168294 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 6e3f36387de566b09aa4145ea0e3bfe4814d68b4 baseline version: xen e0a514d2f4b2fcb51835aa9a9b02653b491a61fc Last test of basis 168294 2022-03-01 13:07:32 Z 0 days Testing same since 168310 2022-03-01 23:38:41 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git e0a514d2f4..6e3f36387d 6e3f36387de566b09aa4145ea0e3bfe4814d68b4 -> master From xen-devel-bounces@lists.xenproject.org Wed Mar 02 08:38:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 08:38:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282074.480645 (Exim 4.92) (envelope-from ) id 1nPKUs-00062B-70; Wed, 02 Mar 2022 08:38:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282074.480645; Wed, 02 Mar 2022 08:38:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPKUs-000622-3t; Wed, 02 Mar 2022 08:38:10 +0000 Received: by outflank-mailman (input) for mailman id 282074; Wed, 02 Mar 2022 08:38:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPKUr-00061h-2s; Wed, 02 Mar 2022 08:38:09 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPKUr-0000hM-1H; Wed, 02 Mar 2022 08:38:09 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPKUq-0003rw-NH; Wed, 02 Mar 2022 08:38:08 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nPKUq-00018I-Mo; Wed, 02 Mar 2022 08:38:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Q5BKYTF7sphgyzvyeCixbjbmJ4SpN5g9twrnbhDUwQk=; b=1Zhe/dKVJvc/gYcoLSe0NmX9dK Jw9TZdMhYniQhIjrvTNYkfIqqwePFclw7Kbh91iA7BATYi80yqxOR9LPCKYMh1cQn0/f7UVFdaJTJ LsWGlKdYKqdnmcn43ipiKvxS275p+/l7Xz8ZO2g5Dx0Sir/D8/oiwhpqUcAUUWdgyZu4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 168320: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=dc39554d58af4a50b50eca1f57c49415a12b0c98 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Wed, 02 Mar 2022 08:38:08 +0000 flight 168320 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/168320/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf dc39554d58af4a50b50eca1f57c49415a12b0c98 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 1 days Failing since 168258 2022-03-01 01:55:31 Z 1 days 14 attempts Testing same since 168316 2022-03-02 02:50:20 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Guomin Jiang Jason Jason Lou Xiaolu.Jiang jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit dc39554d58af4a50b50eca1f57c49415a12b0c98 Author: Xiaolu.Jiang Date: Tue Feb 22 22:14:05 2022 +0800 edk2/MdeModulePkg/Debuglib: Add Standalone MM support https://bugzilla.tianocore.org/show_bug.cgi?id=3844 This change added Standalone MM instance of DebugLib. Reviewd-by: Jian J Wang Reviewd-by: Liming Gao Signed-off-by: Xiaolu.Jiang commit 497ac7b6d7f9750f48f137db244931a5728b1968 Author: Guomin Jiang Date: Sat Jan 29 16:28:02 2022 +0800 UefiPayloadPkg/PayloadLoaderPeim: Use INT64 as input parameter REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3818 It will have some potential issue when memory larger than 2G because the high memory address will be fill with 0xFFFFFFFF when do the operation of INTN + INT64 but it is 32 bit normal data in fact. Should use same data type INT64 + INT64. V3: 1. Use INT64 as input parameter because all date type is 64 bit V2: 1. Force the data type to UINTN to avoid high dword be filled with 0xFFFFFFFF 2. Keep INTN because the offset may postive or negative. Reviewed-by: Guo Dong Reviewed-by: Ray Ni Signed-off-by: Guomin Jiang commit 6a890db161cd6d378bec3499a1e774db3f5a27a7 Author: Jason Date: Mon Jan 10 22:30:29 2022 +0800 BaseTools: Upgrade the version of NASM tool REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Upgrade the version of NASM tool to avoid compilation errors when compiling NASM code change. Signed-off-by: Jason Lou Cc: Bob Feng Cc: Liming Gao Reviewed-by: Yuwei Chen commit bbaa00dd01ed0df30e43a5a89fd2b0433d858b73 Author: Jason Date: Mon Jan 10 22:05:47 2022 +0800 MdePkg: Remove the macro definitions regarding Opcode. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Remove the macro definitions regarding Opcode because new version of NASM tool(e.g. v2.15.05) supports the corresponding instructions. Note: This patch need to be merged after other NASM code change to avoid compilation errors. Signed-off-by: Jason Lou Cc: Michael D Kinney Reviewed-by: Liming Gao Cc: Zhiguang Liu commit 2aa107c0aa2e1375651867c8df1b81ff64b67fce Author: Jason Date: Mon Jan 10 22:01:18 2022 +0800 UefiCpuPkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Reviewed-by: Ray Ni Cc: Eric Dong Cc: Laszlo Ersek Cc: Rahul Kumar commit 7bc8b1d9f412507d579f21ea9af56fced81e7827 Author: Jason Date: Mon Jan 10 21:52:52 2022 +0800 SourceLevelDebugPkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Reviewed-by: Hao A Wu commit d3febfd9ade35dc552df6b3607c2b15d26b82867 Author: Jason Date: Mon Jan 10 21:46:27 2022 +0800 MdePkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Cc: Michael D Kinney Reviewed-by: Liming Gao Cc: Zhiguang Liu commit 84338c0d498555f860a480693ee8647a1795fba3 Author: Jason Date: Mon Jan 10 21:04:09 2022 +0800 MdeModulePkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Reviewed-by: Ray Ni Cc: Dandan Bi Reviewed-by: Liming Gao From xen-devel-bounces@lists.xenproject.org Wed Mar 02 08:39:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 08:39:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282086.480656 (Exim 4.92) (envelope-from ) id 1nPKVy-0006jA-Iu; Wed, 02 Mar 2022 08:39:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282086.480656; Wed, 02 Mar 2022 08:39:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPKVy-0006j3-Fc; Wed, 02 Mar 2022 08:39:18 +0000 Received: by outflank-mailman (input) for mailman id 282086; Wed, 02 Mar 2022 08:39:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPKVx-0006ir-DZ; Wed, 02 Mar 2022 08:39:17 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPKVx-0000it-C5; Wed, 02 Mar 2022 08:39:17 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPKVw-0003xx-Rw; Wed, 02 Mar 2022 08:39:16 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nPKVw-0003QI-RL; Wed, 02 Mar 2022 08:39:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=lbBKoW0UA528ZK7ykpL0N6umpy3Jcdy9zefl3Zfnp+M=; b=h4soAt6PFvNnOspIM0sOsBBt0n dR3z5LmGwED8LygzBADs35Pybfj1LJ6w04l3D0mlidRFxrIVZYQby8JTxUp1z7NV9v5Ft1MgiK/og NdlrFLueCK2jDzv1W7KKoz+f7D/pYpPJgFp5yPE+f+Rd1SzVPAHvyPmuKQ/SUYpbP1gE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 168321: regressions - FAIL X-Osstest-Failures: libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=44ea7749f82c093a3387b94d1e40a5fe48609244 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Wed, 02 Mar 2022 08:39:16 +0000 flight 168321 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/168321/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt 44ea7749f82c093a3387b94d1e40a5fe48609244 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 600 days Failing since 151818 2020-07-11 04:18:52 Z 599 days 581 attempts Testing same since 168321 2022-03-02 04:18:56 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Andika Triwidada Andrea Bolognani Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe Fergeau Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Luke Yue Luyao Zhong Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Olaf Hering Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle SeongHyun Jo Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Thomas Huth Tim Wiederhake Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 99143 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Mar 02 08:51:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 08:51:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282099.480667 (Exim 4.92) (envelope-from ) id 1nPKhE-0000p2-NU; Wed, 02 Mar 2022 08:50:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282099.480667; Wed, 02 Mar 2022 08:50:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPKhE-0000ov-KJ; Wed, 02 Mar 2022 08:50:56 +0000 Received: by outflank-mailman (input) for mailman id 282099; Wed, 02 Mar 2022 08:50:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPKhD-0000op-NO for xen-devel@lists.xenproject.org; Wed, 02 Mar 2022 08:50:55 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id de36c30c-9a05-11ec-8539-5f4723681683; Wed, 02 Mar 2022 09:50:54 +0100 (CET) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-am5eur02lp2050.outbound.protection.outlook.com [104.47.4.50]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-12-G16L7S_qOj-x9ubuqs-uAA-1; Wed, 02 Mar 2022 09:50:53 +0100 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB7085.eurprd04.prod.outlook.com (2603:10a6:800:122::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.24; Wed, 2 Mar 2022 08:50:52 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5038.014; Wed, 2 Mar 2022 08:50:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: de36c30c-9a05-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1646211054; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ph1jqQjQ+iHkLFanw2O34MPA/R256UiuFBkCKVgbnfg=; b=B/q7hmiuNqWlChFN3KqqTztC13xUv3dmhX4JJAQdOtD98Sjb2RcITja0edTx0Bh6+KBbtx p/6QB9vY1ZqSI8wCK7eDM1zmEijTDNBRxF3D2xNValIWaSaozTsNDNFv91CkX8m0R2l9Go VBXGceFQ/RsACAyH09YsjkzBPoNjXlg= X-MC-Unique: G16L7S_qOj-x9ubuqs-uAA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CJ0kvufu/B5fFzDYMrIdIha2ItQosEjTSwhJlSpoAZ3z52dwJX1QF3TmKaR6F9gNcA9hn0sn+z8YX1EY1t67lNANVvqA58+xSQJl4W8GRy5wRksNcBZJX7pZc6xtI2YwEwuy/DAws4XR+dYnCjZCqX1zcD8eTMTyTl01d5s7TjVH59a4ppharV1vLKOlfKt80fCZoC+zboXXg5q5JQmrCEYxMUtGO5NRUFFwMoKNWBXHVry1yKcfDbuiEVKUc8TW9s9zP41hPKYDuUQaMgGlCjZpc0/IhvGtZvPmDlxUP4ICO28grPTsz9as5MpwKZwNhqu7CALbkmp3vAg4BWR72g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ph1jqQjQ+iHkLFanw2O34MPA/R256UiuFBkCKVgbnfg=; b=IdkADF/tK290uX/mEwXJZrjmXZRRGW1w4wG2ZU8uqLVE7me4Nyb/n2w3wSB2cCTs5D9wvkX0v3RVJq/uPc8QkHrIqupLXXSbvs6ThM/PpdQdidd1EArUYNgxuwG0IUcrsBgWxySoqVLy7aNC3fCNHW92uud2DF89wBJmcMoO27YU5j8ibP67sK9atCQjmdQNngUrXD2gQr4UjfSfvsh435/ibeP5OpEMK12t045OmVcgVczd6w2PbqJX8Mj9kF7CeNTa+si6suYse4e21Pns5l/GBiTDWJ92zwHVMdunwDi8LUyyaXzlIUGw3aaV3UpPo6FN7GqvsWBHURkb3IcXMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <4726b683-3739-f96d-ff74-45894865a6e0@suse.com> Date: Wed, 2 Mar 2022 09:50:50 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH] x86: fold sections in final binaries Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <03851bd4-9202-385f-d991-c9720185c946@suse.com> In-Reply-To: <03851bd4-9202-385f-d991-c9720185c946@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0057.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::8) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 259644de-1d6a-4ae0-b80a-08d9fc29c195 X-MS-TrafficTypeDiagnostic: VI1PR04MB7085:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HqVTkQevpFKyE0UFY/o8IbWUBHcO5v34MP1JIE9idnLdeYj1APlGkRrArRY9H043O7Z4quAJugdKf3nXMvkBY9eoXK1L/OiqgzodivSEFF1R5PRDNEbEVfQbxK7O71IL3vB2XzDiXss+eVCUqStj+aKEhEVSyOuUY1j08bKLL+wQxPmJLX72AMqO/MyXrR1fYCLUln6ln0G02NvA0696SjNMXK/AxlWVasHAYGW7r3LqLiXQiTLsGENSbv9NBiI/8IOH5+fpG8js6H19xJMs4GzVSRZXcUWQ8BSTTvp7Lpe/I4Lt63CCZeaOJvI9qJ4lyRomYv2BBbjHDxhL2RagGLHI/j2OQLAB9OtfneQgRc1bDieAZecccn1HBwCLLqJAIf8cIH/u4lLf36ALurG7TBZtZCPiQ4yMrUA+r8Rbcn5cQENsLgSfAmC5zCvYC7lGTMtLZgEMfTuXs1SDPW/DHL0BkQH37W+w4IYFgWvuWg3z7rmMDe9MLLs4z2pOIpHfdPWr3+FjYDvfNTA0eNe42GwbaDQol1BZbScXvlUnATXxZwMm9GpDuFav6dX3NhgTKW+vuGSifScfM++lAzbuE5IJsoGCELQ8J3r+tLp+ULocqf+R4zmkmeWZ0eP4X4VcPm8TSrxGyB9mQDgWSFzhp0TtJ1xix0AYRmKXj96Km+osuysLPOC8kpnTZfCdjaDk6c1pcK906lkQqe0G+IQudAZ1atDMTXltURszj4SMoaU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(53546011)(6506007)(6512007)(6486002)(31696002)(8936002)(316002)(6916009)(508600001)(54906003)(83380400001)(86362001)(5660300002)(31686004)(2906002)(38100700002)(2616005)(66556008)(66476007)(26005)(4326008)(8676002)(66946007)(36756003)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T0xoaE9wdWh0RzEvUndkUFZ3disrS2ExZ1U3NUhqMWxKMkkvSWJYalhHbDJO?= =?utf-8?B?dW9QMmFONm9nVG5xNlNhNUNtU01WNzV6bzdRb25vVXowRXFqRnhzdFJzODVN?= =?utf-8?B?MXFqaXBnd1QwcXdKb0xBWnR3b3Q5b2tIcm4rL01EWHJ5eVRBUFRZWEJGcjZE?= =?utf-8?B?Z0VEUHA3SG9jODJwY2xFNjJvLzVGbEJvMytRd1BVeFVoWFk3cTFjR2gzeHBX?= =?utf-8?B?T3BmN1pEbktmUzBSSzZGMkxGaFZXZWNlOVpCenMxalVBdGZ5S1dsbE1HMTRh?= =?utf-8?B?dnV5cG9BcGtjWDhVRDNPaEx5NXpCc0tGbEZkZHFlWnhoMWpmWVdxdDV2dCtS?= =?utf-8?B?U3dwNGVFOWNPZWJWQUlUZ1YwL3NlM1RuL3RRRjVFdmR5c3o5RjJ3YUxEWVhn?= =?utf-8?B?YkVhQzdQLzdLU0NGbGZqSW0vTDJvM2VUTEpyd3ZqVXF0dE5nWDRBeGZ3aEtt?= =?utf-8?B?V1o0QTJQVVRtS1gvSUxTcHM1Z1F4YTQ0UzM0K2s4TmNybStFajJGREhDZGNT?= =?utf-8?B?MmlsajJRRkRET3pJL0ppTDhlVGRCNnVMUHVNMEZUMW4zYnBWekNsazJ5TkNs?= =?utf-8?B?eE5BMkFkNWFHbGZYQXNVZjRBVVBaMXlvSmx5UVFnZEc3Y2RsNEIybnIrMWVR?= =?utf-8?B?Zm1ZSnZBRmIrcXR3eFUyL3p5L1h3TnNTaHQrZnllUXhsRUdhdVpQbndlMU9x?= =?utf-8?B?eit6dXhuc1gxSkZBMVdwYlRoQ1VHTElIYXh4NFRYRFFoMWYrNjd2bStmRUtD?= =?utf-8?B?ODJnMGdEUlhFVlByZCtoZWNPRzZVVXFGTGJPWm9lUGtiYm1YQzhUendoRVlh?= =?utf-8?B?NHJEL0RsSjNlVE5qVTNyUHN6T25pczRURENhNFJCUzB0NjRsczNheCsrSWZy?= =?utf-8?B?MCt4R0JLV0ZYeURmaFpZcXRjRy8yTGErZDF1dHdNTC9TZ05Sc082blhGZU9q?= =?utf-8?B?ekU0S1FzRnFzT3FSNGZLUjgrNjg5bHd3UGZOOFJlL2NCNWMzMlpNSmczN0tG?= =?utf-8?B?ciszbjhOZ3BUUHlnc2RWM1pjQUp6b3h6T2FuK01WUEF3ZWYvWndsa3lCYmJM?= =?utf-8?B?K2RYVHp4ZVVrdGVrZ2lqbHlhSjBVZVdpaDVGRStPbHdGcDBxSFlHYkZmUTJm?= =?utf-8?B?Yk9UTHRLN3BSZTY4Sm05OHE4YXJhWlVRelN5ZkFpWTdVSXViL2ZEaGYyMWpY?= =?utf-8?B?VTEvd3RjdEwvQUkreVpsbFVaR0VPMEw3Uk9qTGZISW9JZ3pocFVEZlEwUDNI?= =?utf-8?B?dERTUnU1RHN4cjBuelZTRk1jTFNoUHZBMUxTK3ZHTEZEYjNJOXE5ZTVWSGZq?= =?utf-8?B?WGtmUllIc1N0T1JyL2Ixd2hNenNSc3pJTk9FZmgzSTRNdmloWmQwZmJyaWYv?= =?utf-8?B?YmNkSnhMYUoybUplYTI2ejNsaUc3b3RjM2hzYUZWaUs1eENyalk5cWtSU2tz?= =?utf-8?B?N3lUSlNxZUh3NVZNQ0RxeUU2WXdNalFtclhDVTJiT2VFQVlRR2h5T1RWVHpk?= =?utf-8?B?djFIbE5YUmNaTUxVV0pSRUF5djM0R1V3akZFVndxSkh2a0ZVMXZ2TEFRUGxv?= =?utf-8?B?VkpJK25qT0pXbmJwMHkwNzVJTkdXakhnNDI2dEk3QllLeGhiYkl3b0N0TkxW?= =?utf-8?B?dEtJWk9JRXRKd3picHRBR2VnYTFlL1Y3QkdEUEFCM2NoSUU3L0ZjemdqdmxK?= =?utf-8?B?amp2MytvTzA1K2h3OWRoNjdranAxa1NlbWZNWk5vczZIVkdYQ3g2TEdPUzY1?= =?utf-8?B?djBMbUVWcWZGQ2hNcFR4d2RpVUtrWDJkSWtuR2pEZVI4VUNXQklVS29JN2RW?= =?utf-8?B?YTJpczRIZjhjblVTbmZnQWZOUmltckhsZzUxTTB0cFdWeGxDUE5rYmI2QXdj?= =?utf-8?B?aEMwSEh1cW5oUEhiWGwxVnNMejZzZVVWeDE5aUxPQ1lQL1JjeVB1aDZXN2xJ?= =?utf-8?B?dDVWR3lIbDU3ekNpVjYydTFMelRFcmZ6Y3BGZ0ZrTWp4eVFpZDJoakpjeHpz?= =?utf-8?B?eE82Sy80MjNlc2htczUxaHptRUdtcGN1aW1nKzVBdTAxcDVPb090OW4wa3FZ?= =?utf-8?B?VUswQ2V6dDJlSVg2cnVRaUNRcENHSFYvNkh6U2pSRnVxbXRWVHVzSGIxdmI2?= =?utf-8?B?NkVSeGVWYXVVb1pqcnNNdjk5ZzI3cUYzMHNsZm1OL0JDOFRMdy9JZDJkZUVY?= =?utf-8?Q?8TsQMuHynNNflhC3Igp+q04=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 259644de-1d6a-4ae0-b80a-08d9fc29c195 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2022 08:50:52.3965 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EIbffbWcUgh0wbNQEJ2rTBKrORwBun6ACGMrSTNH9qkmqTJ4QcuFW/MpMXwBThC+ZajkYNeiSQnd8lVvYbuLKg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7085 On 01.03.2022 09:55, Jan Beulich wrote: > --- a/xen/arch/x86/xen.lds.S > +++ b/xen/arch/x86/xen.lds.S > @@ -194,6 +194,7 @@ SECTIONS > #endif > _sinittext = .; > *(.init.text) > + *(.text.startup) > _einittext = .; > /* > * Here are the replacement instructions. The linker sticks them > @@ -258,9 +259,10 @@ SECTIONS > > . = ALIGN(8); > __ctors_start = .; > - *(.ctors) > + *(SORT_BY_INIT_PRIORITY(.init_array.*)) > + *(SORT_BY_INIT_PRIORITY(.ctors.*)) > *(.init_array) > - *(SORT(.init_array.*)) > + *(.ctors) > __ctors_end = .; > } PHDR(text) While I did commit the change with Roger's R-b, on the basis that it's not going to make things worse, I don't think what we have here and what we do in init_constructors() is quite right: For one .init_array and .ctors are supposed to be processed in, respectively, opposite order - the former forwards, the latter backwards. See e.g. gcc's libgcc/gbl-ctors.h. And then both variants also shouldn't be intermixed; we ought to expect only one of the two kinds, and aiui for now it's always going to be .ctors. The processing in wrong order looks to not be a problem in the builds I can check, as there's only ever a single priority used. But we're at risk of this breaking down the road ... Finally, if we consider .init_array might appear, we ought to also discard (rather than leaving orphaned) .fini_array. Jan From xen-devel-bounces@lists.xenproject.org Wed Mar 02 09:02:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 09:02:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282110.480684 (Exim 4.92) (envelope-from ) id 1nPKsM-0002e9-0F; Wed, 02 Mar 2022 09:02:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282110.480684; Wed, 02 Mar 2022 09:02:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPKsL-0002e2-TI; Wed, 02 Mar 2022 09:02:25 +0000 Received: by outflank-mailman (input) for mailman id 282110; Wed, 02 Mar 2022 09:02:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPKsK-0002dw-AV for xen-devel@lists.xenproject.org; Wed, 02 Mar 2022 09:02:24 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 789055a9-9a07-11ec-8eba-a37418f5ba1a; Wed, 02 Mar 2022 10:02:22 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 74D4B1396; Wed, 2 Mar 2022 01:02:21 -0800 (PST) Received: from e129167.arm.com (unknown [10.57.71.82]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1FB6D3F66F; Wed, 2 Mar 2022 01:02:19 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 789055a9-9a07-11ec-8eba-a37418f5ba1a From: Michal Orzel To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH] xen/arm: gic: Introduce GIC_PRI_{IRQ/IPI}_ALL Date: Wed, 2 Mar 2022 10:02:12 +0100 Message-Id: <20220302090212.115922-1-michal.orzel@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Introduce macros GIC_PRI_IRQ_ALL and GIC_PRI_IPI_ALL to be used in all the places where we want to set default priority for all the offsets in interrupt priority register. This will improve readability and allow to get rid of introducing variables just to store this value. Take the opportunity to mark GIC_PRI_{IRQ/IPI} as unsigned values to suppress static analyzer warnings as they are used in expressions exceeding integer range (shifting into signed bit). Modify also other priority related macros to be coherent. Signed-off-by: Michal Orzel --- xen/arch/arm/gic-v2.c | 12 +++--------- xen/arch/arm/gic-v3.c | 16 +++------------- xen/arch/arm/include/asm/gic.h | 12 ++++++++---- 3 files changed, 14 insertions(+), 26 deletions(-) diff --git a/xen/arch/arm/gic-v2.c b/xen/arch/arm/gic-v2.c index b2adc8ec9a..2cc2f6bc18 100644 --- a/xen/arch/arm/gic-v2.c +++ b/xen/arch/arm/gic-v2.c @@ -373,9 +373,7 @@ static void __init gicv2_dist_init(void) /* Default priority for global interrupts */ for ( i = 32; i < nr_lines; i += 4 ) - writel_gicd(GIC_PRI_IRQ << 24 | GIC_PRI_IRQ << 16 | - GIC_PRI_IRQ << 8 | GIC_PRI_IRQ, - GICD_IPRIORITYR + (i / 4) * 4); + writel_gicd(GIC_PRI_IRQ_ALL, GICD_IPRIORITYR + (i / 4) * 4); /* Disable all global interrupts */ for ( i = 32; i < nr_lines; i += 32 ) @@ -403,15 +401,11 @@ static void gicv2_cpu_init(void) /* Set SGI priorities */ for ( i = 0; i < 16; i += 4 ) - writel_gicd(GIC_PRI_IPI << 24 | GIC_PRI_IPI << 16 | - GIC_PRI_IPI << 8 | GIC_PRI_IPI, - GICD_IPRIORITYR + (i / 4) * 4); + writel_gicd(GIC_PRI_IPI_ALL, GICD_IPRIORITYR + (i / 4) * 4); /* Set PPI priorities */ for ( i = 16; i < 32; i += 4 ) - writel_gicd(GIC_PRI_IRQ << 24 | GIC_PRI_IRQ << 16 | - GIC_PRI_IRQ << 8 | GIC_PRI_IRQ, - GICD_IPRIORITYR + (i / 4) * 4); + writel_gicd(GIC_PRI_IRQ_ALL, GICD_IPRIORITYR + (i / 4) * 4); /* Local settings: interface controller */ /* Don't mask by priority */ diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c index 9a3a175ad7..3c472ed768 100644 --- a/xen/arch/arm/gic-v3.c +++ b/xen/arch/arm/gic-v3.c @@ -594,7 +594,6 @@ static void gicv3_set_irq_priority(struct irq_desc *desc, static void __init gicv3_dist_init(void) { uint32_t type; - uint32_t priority; uint64_t affinity; unsigned int nr_lines; int i; @@ -621,11 +620,7 @@ static void __init gicv3_dist_init(void) /* Default priority for global interrupts */ for ( i = NR_GIC_LOCAL_IRQS; i < nr_lines; i += 4 ) - { - priority = (GIC_PRI_IRQ << 24 | GIC_PRI_IRQ << 16 | - GIC_PRI_IRQ << 8 | GIC_PRI_IRQ); - writel_relaxed(priority, GICD + GICD_IPRIORITYR + (i / 4) * 4); - } + writel_relaxed(GIC_PRI_IRQ_ALL, GICD + GICD_IPRIORITYR + (i / 4) * 4); /* Disable/deactivate all global interrupts */ for ( i = NR_GIC_LOCAL_IRQS; i < nr_lines; i += 32 ) @@ -806,7 +801,6 @@ static int __init gicv3_populate_rdist(void) static int gicv3_cpu_init(void) { int i, ret; - uint32_t priority; /* Register ourselves with the rest of the world */ if ( gicv3_populate_rdist() ) @@ -826,16 +820,12 @@ static int gicv3_cpu_init(void) } /* Set priority on PPI and SGI interrupts */ - priority = (GIC_PRI_IPI << 24 | GIC_PRI_IPI << 16 | GIC_PRI_IPI << 8 | - GIC_PRI_IPI); for (i = 0; i < NR_GIC_SGI; i += 4) - writel_relaxed(priority, + writel_relaxed(GIC_PRI_IPI_ALL, GICD_RDIST_SGI_BASE + GICR_IPRIORITYR0 + (i / 4) * 4); - priority = (GIC_PRI_IRQ << 24 | GIC_PRI_IRQ << 16 | GIC_PRI_IRQ << 8 | - GIC_PRI_IRQ); for (i = NR_GIC_SGI; i < NR_GIC_LOCAL_IRQS; i += 4) - writel_relaxed(priority, + writel_relaxed(GIC_PRI_IRQ_ALL, GICD_RDIST_SGI_BASE + GICR_IPRIORITYR0 + (i / 4) * 4); /* diff --git a/xen/arch/arm/include/asm/gic.h b/xen/arch/arm/include/asm/gic.h index c7f0c343d1..69ceac36b1 100644 --- a/xen/arch/arm/include/asm/gic.h +++ b/xen/arch/arm/include/asm/gic.h @@ -143,10 +143,14 @@ * * A GIC must support a mimimum of 16 priority levels. */ -#define GIC_PRI_LOWEST 0xf0 -#define GIC_PRI_IRQ 0xa0 -#define GIC_PRI_IPI 0x90 /* IPIs must preempt normal interrupts */ -#define GIC_PRI_HIGHEST 0x80 /* Higher priorities belong to Secure-World */ +#define GIC_PRI_LOWEST 0xf0U +#define GIC_PRI_IRQ 0xa0U +#define GIC_PRI_IRQ_ALL ((GIC_PRI_IRQ << 24) | (GIC_PRI_IRQ << 16) |\ + (GIC_PRI_IRQ << 8) | GIC_PRI_IRQ) +#define GIC_PRI_IPI 0x90U /* IPIs must preempt normal interrupts */ +#define GIC_PRI_IPI_ALL ((GIC_PRI_IPI << 24) | (GIC_PRI_IPI << 16) |\ + (GIC_PRI_IPI << 8) | GIC_PRI_IPI) +#define GIC_PRI_HIGHEST 0x80U /* Higher priorities belong to Secure-World */ #define GIC_PRI_TO_GUEST(pri) (pri >> 3) /* GICH_LR and GICH_VMCR only support 5 bits for guest irq priority */ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 02 09:19:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 09:19:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282117.480697 (Exim 4.92) (envelope-from ) id 1nPL8t-0004gj-JI; Wed, 02 Mar 2022 09:19:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282117.480697; Wed, 02 Mar 2022 09:19:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPL8t-0004gc-GK; Wed, 02 Mar 2022 09:19:31 +0000 Received: by outflank-mailman (input) for mailman id 282117; Wed, 02 Mar 2022 09:18:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPL83-0004eI-Kf for xen-devel@lists.xenproject.org; Wed, 02 Mar 2022 09:18:39 +0000 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [2a00:1450:4864:20::636]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id be961074-9a09-11ec-8eba-a37418f5ba1a; Wed, 02 Mar 2022 10:18:38 +0100 (CET) Received: by mail-ej1-x636.google.com with SMTP id kt27so2410887ejb.0 for ; Wed, 02 Mar 2022 01:18:38 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: be961074-9a09-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4LuLQynsRS5ZDdiypHmCRhWOSK0fPQgMoxmBubsA8FA=; b=YwA2Tp9/WRHVf+AhpCscraLQ5YZMBIbTnjRD9qXALixvArniZHwws+D5eKFYJ4w9RG r5YPECm/lP0oAUKfe9WRJhv6+FML2S+XIXHKeVDBXWzTRzpq8V5VyDtMBBLt+RgC4uif rGbJjiYJ+RaebcdTWE+lgavU2sjB3KE2oYMSI2g0SnLEMM8BFRLk6tjS00Xev2qK5BZV 5Ssf9EZ0tsmaxYSBGN+JYRBhKcBJnRtyUIj9fj+nmKF1+vj7CNwKABPlCEiIkg4HqhVl prjve+Nrt6ySEZf00Hzlz9gQ4nrt4ykYynGeggVTPypi2WOB4Q0/x8pbTwKWJmRWzNiw F8UA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4LuLQynsRS5ZDdiypHmCRhWOSK0fPQgMoxmBubsA8FA=; b=GFGvPjlOUFn81xPWkrRxENldqejC22oH5+Nut87e/EZM2cQ0YsLtjDGTvdjVW7VIlA +k354Ma2Vtia76dtDDjJnchsF3YNj0mts1dm/rrKnpNsuAas/8NvK4xpJf42v5kVSFp9 dTWYaSJEjKk0SosP9UzQglDrV17xHDGMX30XHC8k/mAMnbNxCmSigXR+G/2v93lUj5JE vlW4zFJMO1TBXk44rXBn29OP8TIlGrGZ5xGtPG1W0oOWQZxAZ3mrtHBz370BHxiplWvG IKYkXLmHy0VGo2fz+3JNS/mYwaX1WHVQ6Fu5sGmX+jyzb/yCUhhUlni4MwwB+NX3phsr BTvw== X-Gm-Message-State: AOAM532F5s+U+InXC7jogGwIoQIEDEFtezY5Msr3gVYTVxuaM1Y22bwn CYNbWXxf+R1cWYg+r6Wf1dDJDOeNMa8UyZPgRzY= X-Google-Smtp-Source: ABdhPJxefZcxfzkkMgbjOK8FTIKDUrSjhwIhlbq76ukZRP/HPSQoF7TsleylqvSIE+LRhSKcwrjAT6lGtFvgDJjKhNk= X-Received: by 2002:a17:906:9f06:b0:6ce:36da:8247 with SMTP id fy6-20020a1709069f0600b006ce36da8247mr21813101ejc.651.1646212718008; Wed, 02 Mar 2022 01:18:38 -0800 (PST) MIME-Version: 1.0 References: <20220227143055.335596-1-hch@lst.de> <20220227143055.335596-8-hch@lst.de> In-Reply-To: <20220227143055.335596-8-hch@lst.de> From: Anatoly Pugachev Date: Wed, 2 Mar 2022 12:18:26 +0300 Message-ID: Subject: Re: [PATCH 07/11] x86: remove the IOMMU table infrastructure To: Christoph Hellwig Cc: iommu@lists.linux-foundation.org, x86@kernel.org, Anshuman Khandual , Konrad Rzeszutek Wilk , Stefano Stabellini , Boris Ostrovsky , Juergen Gross , Joerg Roedel , David Woodhouse , Lu Baolu , Robin Murphy , linux-arm-kernel@lists.infradead.org, xen-devel@lists.xenproject.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390 , linux-hyperv@vger.kernel.org, tboot-devel@lists.sourceforge.net, linux-pci@vger.kernel.org Content-Type: text/plain; charset="UTF-8" On Sun, Feb 27, 2022 at 7:31 PM Christoph Hellwig wrote: > > The IOMMU table tries to separate the different IOMMUs into different > backends, but actually requires various cross calls. > > Rewrite the code to do the generic swiotlb/swiotlb-xen setup directly > in pci-dma.c and then just call into the IOMMU drivers. ... > --- a/arch/x86/include/asm/iommu_table.h > +++ /dev/null > @@ -1,102 +0,0 @@ > -/* SPDX-License-Identifier: GPL-2.0 */ > -#ifndef _ASM_X86_IOMMU_TABLE_H > -#define _ASM_X86_IOMMU_TABLE_H > - > -#include > - > -/* > - * History lesson: > - * The execution chain of IOMMUs in 2.6.36 looks as so: > - * > - * [xen-swiotlb] > - * | > - * +----[swiotlb *]--+ > - * / | \ > - * / | \ > - * [GART] [Calgary] [Intel VT-d] > - * / > - * / > - * [AMD-Vi] > - * > - * *: if SWIOTLB detected 'iommu=soft'/'swiotlb=force' it would skip > - * over the rest of IOMMUs and unconditionally initialize the SWIOTLB. > - * Also it would surreptitiously initialize set the swiotlb=1 if there were > - * more than 4GB and if the user did not pass in 'iommu=off'. The swiotlb > - * flag would be turned off by all IOMMUs except the Calgary one. > - * > - * The IOMMU_INIT* macros allow a similar tree (or more complex if desired) > - * to be built by defining who we depend on. > - * > - * And all that needs to be done is to use one of the macros in the IOMMU > - * and the pci-dma.c will take care of the rest. > - */ Christoph, Is it possible to keep documentation comments in source files? Or are they completely irrelevant now? Thanks. From xen-devel-bounces@lists.xenproject.org Wed Mar 02 09:22:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 09:22:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282126.480709 (Exim 4.92) (envelope-from ) id 1nPLBS-00062W-2b; Wed, 02 Mar 2022 09:22:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282126.480709; Wed, 02 Mar 2022 09:22:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPLBR-00062P-VS; Wed, 02 Mar 2022 09:22:09 +0000 Received: by outflank-mailman (input) for mailman id 282126; Wed, 02 Mar 2022 09:22:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPLBR-00062H-5W for xen-devel@lists.xenproject.org; Wed, 02 Mar 2022 09:22:09 +0000 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3b4681cf-9a0a-11ec-8eba-a37418f5ba1a; Wed, 02 Mar 2022 10:22:08 +0100 (CET) Received: by verein.lst.de (Postfix, from userid 2407) id 745BC68AFE; Wed, 2 Mar 2022 10:22:04 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3b4681cf-9a0a-11ec-8eba-a37418f5ba1a Date: Wed, 2 Mar 2022 10:22:04 +0100 From: Christoph Hellwig To: Anatoly Pugachev Cc: Christoph Hellwig , iommu@lists.linux-foundation.org, x86@kernel.org, Anshuman Khandual , Konrad Rzeszutek Wilk , Stefano Stabellini , Boris Ostrovsky , Juergen Gross , Joerg Roedel , David Woodhouse , Lu Baolu , Robin Murphy , linux-arm-kernel@lists.infradead.org, xen-devel@lists.xenproject.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390 , linux-hyperv@vger.kernel.org, tboot-devel@lists.sourceforge.net, linux-pci@vger.kernel.org Subject: Re: [PATCH 07/11] x86: remove the IOMMU table infrastructure Message-ID: <20220302092204.GA24139@lst.de> References: <20220227143055.335596-1-hch@lst.de> <20220227143055.335596-8-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) On Wed, Mar 02, 2022 at 12:18:26PM +0300, Anatoly Pugachev wrote: > Is it possible to keep documentation comments in source files? Or are > they completely irrelevant now? That ones you quoted are very much irrelevant now. And the behaviour of the swiotlb disabling will have to change (this patchset is a bit of a preparation for now) as we now use per-device dma_ops and the dma-iommu can dip into the swiotlb pool for untrusted devices. In practive we'll basically have to always initialize the swiotlb buffer now. From xen-devel-bounces@lists.xenproject.org Wed Mar 02 09:40:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 09:40:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282133.480719 (Exim 4.92) (envelope-from ) id 1nPLTU-0000Rd-L4; Wed, 02 Mar 2022 09:40:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282133.480719; Wed, 02 Mar 2022 09:40:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPLTU-0000RW-Hw; Wed, 02 Mar 2022 09:40:48 +0000 Received: by outflank-mailman (input) for mailman id 282133; Wed, 02 Mar 2022 09:40:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPLTT-0000RQ-3Z for xen-devel@lists.xenproject.org; Wed, 02 Mar 2022 09:40:47 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPLTS-0001oO-Q3; Wed, 02 Mar 2022 09:40:46 +0000 Received: from 54-240-197-224.amazon.com ([54.240.197.224] helo=[192.168.10.166]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nPLTS-0006xZ-JJ; Wed, 02 Mar 2022 09:40:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=DworUVLnm+WsZhrtNGRNQBJu4kjIywM//Yy1Ai7wovs=; b=rnsLdRfCzpB0irb1GZ+hIGGzIv +u3u+uC5CJ+1i1R7B/odSzkaYFeeFwKnNC5aNMwMrKoX0CuS4+sHiSjQNMRLLLdb1Re6c4p5+RcMP CRSRNMnX1UEBnwPVEC/GhGQZ7zwngBHnQsIw0++kZ/o73hdVtPruecKTdBWVu9AnfwnY=; Message-ID: <2243c7f9-b0c7-83be-9ac0-5538436e4d6c@xen.org> Date: Wed, 2 Mar 2022 09:40:44 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH] xen/arm: gic: Introduce GIC_PRI_{IRQ/IPI}_ALL To: Michal Orzel , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20220302090212.115922-1-michal.orzel@arm.com> From: Julien Grall In-Reply-To: <20220302090212.115922-1-michal.orzel@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Michal, On 02/03/2022 09:02, Michal Orzel wrote: > Introduce macros GIC_PRI_IRQ_ALL and GIC_PRI_IPI_ALL to be used in all > the places where we want to set default priority for all the offsets > in interrupt priority register. This will improve readability and > allow to get rid of introducing variables just to store this value. > > Take the opportunity to mark GIC_PRI_{IRQ/IPI} as unsigned values > to suppress static analyzer warnings as they are used in expressions > exceeding integer range (shifting into signed bit). Modify also other > priority related macros to be coherent. > > Signed-off-by: Michal Orzel > --- > xen/arch/arm/gic-v2.c | 12 +++--------- > xen/arch/arm/gic-v3.c | 16 +++------------- > xen/arch/arm/include/asm/gic.h | 12 ++++++++---- > 3 files changed, 14 insertions(+), 26 deletions(-) > > diff --git a/xen/arch/arm/gic-v2.c b/xen/arch/arm/gic-v2.c > index b2adc8ec9a..2cc2f6bc18 100644 > --- a/xen/arch/arm/gic-v2.c > +++ b/xen/arch/arm/gic-v2.c > @@ -373,9 +373,7 @@ static void __init gicv2_dist_init(void) > > /* Default priority for global interrupts */ > for ( i = 32; i < nr_lines; i += 4 ) > - writel_gicd(GIC_PRI_IRQ << 24 | GIC_PRI_IRQ << 16 | > - GIC_PRI_IRQ << 8 | GIC_PRI_IRQ, > - GICD_IPRIORITYR + (i / 4) * 4); > + writel_gicd(GIC_PRI_IRQ_ALL, GICD_IPRIORITYR + (i / 4) * 4); > > /* Disable all global interrupts */ > for ( i = 32; i < nr_lines; i += 32 ) > @@ -403,15 +401,11 @@ static void gicv2_cpu_init(void) > > /* Set SGI priorities */ > for ( i = 0; i < 16; i += 4 ) > - writel_gicd(GIC_PRI_IPI << 24 | GIC_PRI_IPI << 16 | > - GIC_PRI_IPI << 8 | GIC_PRI_IPI, > - GICD_IPRIORITYR + (i / 4) * 4); > + writel_gicd(GIC_PRI_IPI_ALL, GICD_IPRIORITYR + (i / 4) * 4); > > /* Set PPI priorities */ > for ( i = 16; i < 32; i += 4 ) > - writel_gicd(GIC_PRI_IRQ << 24 | GIC_PRI_IRQ << 16 | > - GIC_PRI_IRQ << 8 | GIC_PRI_IRQ, > - GICD_IPRIORITYR + (i / 4) * 4); > + writel_gicd(GIC_PRI_IRQ_ALL, GICD_IPRIORITYR + (i / 4) * 4); > > /* Local settings: interface controller */ > /* Don't mask by priority */ > diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c > index 9a3a175ad7..3c472ed768 100644 > --- a/xen/arch/arm/gic-v3.c > +++ b/xen/arch/arm/gic-v3.c > @@ -594,7 +594,6 @@ static void gicv3_set_irq_priority(struct irq_desc *desc, > static void __init gicv3_dist_init(void) > { > uint32_t type; > - uint32_t priority; > uint64_t affinity; > unsigned int nr_lines; > int i; > @@ -621,11 +620,7 @@ static void __init gicv3_dist_init(void) > > /* Default priority for global interrupts */ > for ( i = NR_GIC_LOCAL_IRQS; i < nr_lines; i += 4 ) > - { > - priority = (GIC_PRI_IRQ << 24 | GIC_PRI_IRQ << 16 | > - GIC_PRI_IRQ << 8 | GIC_PRI_IRQ); > - writel_relaxed(priority, GICD + GICD_IPRIORITYR + (i / 4) * 4); > - } > + writel_relaxed(GIC_PRI_IRQ_ALL, GICD + GICD_IPRIORITYR + (i / 4) * 4); > > /* Disable/deactivate all global interrupts */ > for ( i = NR_GIC_LOCAL_IRQS; i < nr_lines; i += 32 ) > @@ -806,7 +801,6 @@ static int __init gicv3_populate_rdist(void) > static int gicv3_cpu_init(void) > { > int i, ret; > - uint32_t priority; > > /* Register ourselves with the rest of the world */ > if ( gicv3_populate_rdist() ) > @@ -826,16 +820,12 @@ static int gicv3_cpu_init(void) > } > > /* Set priority on PPI and SGI interrupts */ > - priority = (GIC_PRI_IPI << 24 | GIC_PRI_IPI << 16 | GIC_PRI_IPI << 8 | > - GIC_PRI_IPI); > for (i = 0; i < NR_GIC_SGI; i += 4) > - writel_relaxed(priority, > + writel_relaxed(GIC_PRI_IPI_ALL, > GICD_RDIST_SGI_BASE + GICR_IPRIORITYR0 + (i / 4) * 4); > > - priority = (GIC_PRI_IRQ << 24 | GIC_PRI_IRQ << 16 | GIC_PRI_IRQ << 8 | > - GIC_PRI_IRQ); > for (i = NR_GIC_SGI; i < NR_GIC_LOCAL_IRQS; i += 4) > - writel_relaxed(priority, > + writel_relaxed(GIC_PRI_IRQ_ALL, > GICD_RDIST_SGI_BASE + GICR_IPRIORITYR0 + (i / 4) * 4); > > /* > diff --git a/xen/arch/arm/include/asm/gic.h b/xen/arch/arm/include/asm/gic.h > index c7f0c343d1..69ceac36b1 100644 > --- a/xen/arch/arm/include/asm/gic.h > +++ b/xen/arch/arm/include/asm/gic.h > @@ -143,10 +143,14 @@ > * > * A GIC must support a mimimum of 16 priority levels. > */ > -#define GIC_PRI_LOWEST 0xf0 > -#define GIC_PRI_IRQ 0xa0 > -#define GIC_PRI_IPI 0x90 /* IPIs must preempt normal interrupts */ > -#define GIC_PRI_HIGHEST 0x80 /* Higher priorities belong to Secure-World */ > +#define GIC_PRI_LOWEST 0xf0U > +#define GIC_PRI_IRQ 0xa0U > +#define GIC_PRI_IRQ_ALL ((GIC_PRI_IRQ << 24) | (GIC_PRI_IRQ << 16) |\ > + (GIC_PRI_IRQ << 8) | GIC_PRI_IRQ) > +#define GIC_PRI_IPI 0x90U /* IPIs must preempt normal interrupts */ > +#define GIC_PRI_IPI_ALL ((GIC_PRI_IPI << 24) | (GIC_PRI_IPI << 16) |\ > + (GIC_PRI_IPI << 8) | GIC_PRI_IPI) This is matter of taste. I think it would read better to keep GIC_PRI_{LOWEST, IRQ, IPI, HIGHEST} defined together and then define *_ALL separately. > +#define GIC_PRI_HIGHEST 0x80U /* Higher priorities belong to Secure-World */ NIT: While you are there, I would suggest to add a newline here. So we separate priority definitions from handy helpers. > #define GIC_PRI_TO_GUEST(pri) (pri >> 3) /* GICH_LR and GICH_VMCR only support > 5 bits for guest irq priority */ Other than that. The patch itself looks good to me. So: Acked-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Mar 02 09:46:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 09:46:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282142.480737 (Exim 4.92) (envelope-from ) id 1nPLYZ-00017a-Bq; Wed, 02 Mar 2022 09:46:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282142.480737; Wed, 02 Mar 2022 09:46:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPLYZ-00017T-7g; Wed, 02 Mar 2022 09:46:03 +0000 Received: by outflank-mailman (input) for mailman id 282142; Wed, 02 Mar 2022 09:46:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPLYX-00017N-Ho for xen-devel@lists.xenproject.org; Wed, 02 Mar 2022 09:46:01 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 90d100f5-9a0d-11ec-8539-5f4723681683; Wed, 02 Mar 2022 10:45:59 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 29DCD1042; Wed, 2 Mar 2022 01:45:59 -0800 (PST) Received: from [10.57.71.82] (unknown [10.57.71.82]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E0FF93F66F; Wed, 2 Mar 2022 01:45:57 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 90d100f5-9a0d-11ec-8539-5f4723681683 Message-ID: <8ee87286-6e35-ddb7-9216-b663f3290570@arm.com> Date: Wed, 2 Mar 2022 10:45:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] xen/arm: gic: Introduce GIC_PRI_{IRQ/IPI}_ALL Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20220302090212.115922-1-michal.orzel@arm.com> <2243c7f9-b0c7-83be-9ac0-5538436e4d6c@xen.org> From: Michal Orzel In-Reply-To: <2243c7f9-b0c7-83be-9ac0-5538436e4d6c@xen.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi Julien, On 3/2/22 10:40, Julien Grall wrote: > Hi Michal, > > On 02/03/2022 09:02, Michal Orzel wrote: >> Introduce macros GIC_PRI_IRQ_ALL and GIC_PRI_IPI_ALL to be used in all >> the places where we want to set default priority for all the offsets >> in interrupt priority register. This will improve readability and >> allow to get rid of introducing variables just to store this value. >> >> Take the opportunity to mark GIC_PRI_{IRQ/IPI} as unsigned values >> to suppress static analyzer warnings as they are used in expressions >> exceeding integer range (shifting into signed bit). Modify also other >> priority related macros to be coherent. >> >> Signed-off-by: Michal Orzel >> --- >>   xen/arch/arm/gic-v2.c          | 12 +++--------- >>   xen/arch/arm/gic-v3.c          | 16 +++------------- >>   xen/arch/arm/include/asm/gic.h | 12 ++++++++---- >>   3 files changed, 14 insertions(+), 26 deletions(-) >> >> diff --git a/xen/arch/arm/gic-v2.c b/xen/arch/arm/gic-v2.c >> index b2adc8ec9a..2cc2f6bc18 100644 >> --- a/xen/arch/arm/gic-v2.c >> +++ b/xen/arch/arm/gic-v2.c >> @@ -373,9 +373,7 @@ static void __init gicv2_dist_init(void) >>         /* Default priority for global interrupts */ >>       for ( i = 32; i < nr_lines; i += 4 ) >> -        writel_gicd(GIC_PRI_IRQ << 24 | GIC_PRI_IRQ << 16 | >> -                    GIC_PRI_IRQ << 8 | GIC_PRI_IRQ, >> -                    GICD_IPRIORITYR + (i / 4) * 4); >> +        writel_gicd(GIC_PRI_IRQ_ALL, GICD_IPRIORITYR + (i / 4) * 4); >>         /* Disable all global interrupts */ >>       for ( i = 32; i < nr_lines; i += 32 ) >> @@ -403,15 +401,11 @@ static void gicv2_cpu_init(void) >>         /* Set SGI priorities */ >>       for ( i = 0; i < 16; i += 4 ) >> -        writel_gicd(GIC_PRI_IPI << 24 | GIC_PRI_IPI << 16 | >> -                    GIC_PRI_IPI << 8 | GIC_PRI_IPI, >> -                    GICD_IPRIORITYR + (i / 4) * 4); >> +        writel_gicd(GIC_PRI_IPI_ALL, GICD_IPRIORITYR + (i / 4) * 4); >>         /* Set PPI priorities */ >>       for ( i = 16; i < 32; i += 4 ) >> -        writel_gicd(GIC_PRI_IRQ << 24 | GIC_PRI_IRQ << 16 | >> -                    GIC_PRI_IRQ << 8 | GIC_PRI_IRQ, >> -                    GICD_IPRIORITYR + (i / 4) * 4); >> +        writel_gicd(GIC_PRI_IRQ_ALL, GICD_IPRIORITYR + (i / 4) * 4); >>         /* Local settings: interface controller */ >>       /* Don't mask by priority */ >> diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c >> index 9a3a175ad7..3c472ed768 100644 >> --- a/xen/arch/arm/gic-v3.c >> +++ b/xen/arch/arm/gic-v3.c >> @@ -594,7 +594,6 @@ static void gicv3_set_irq_priority(struct irq_desc *desc, >>   static void __init gicv3_dist_init(void) >>   { >>       uint32_t type; >> -    uint32_t priority; >>       uint64_t affinity; >>       unsigned int nr_lines; >>       int i; >> @@ -621,11 +620,7 @@ static void __init gicv3_dist_init(void) >>         /* Default priority for global interrupts */ >>       for ( i = NR_GIC_LOCAL_IRQS; i < nr_lines; i += 4 ) >> -    { >> -        priority = (GIC_PRI_IRQ << 24 | GIC_PRI_IRQ << 16 | >> -                    GIC_PRI_IRQ << 8 | GIC_PRI_IRQ); >> -        writel_relaxed(priority, GICD + GICD_IPRIORITYR + (i / 4) * 4); >> -    } >> +        writel_relaxed(GIC_PRI_IRQ_ALL, GICD + GICD_IPRIORITYR + (i / 4) * 4); >>         /* Disable/deactivate all global interrupts */ >>       for ( i = NR_GIC_LOCAL_IRQS; i < nr_lines; i += 32 ) >> @@ -806,7 +801,6 @@ static int __init gicv3_populate_rdist(void) >>   static int gicv3_cpu_init(void) >>   { >>       int i, ret; >> -    uint32_t priority; >>         /* Register ourselves with the rest of the world */ >>       if ( gicv3_populate_rdist() ) >> @@ -826,16 +820,12 @@ static int gicv3_cpu_init(void) >>       } >>         /* Set priority on PPI and SGI interrupts */ >> -    priority = (GIC_PRI_IPI << 24 | GIC_PRI_IPI << 16 | GIC_PRI_IPI << 8 | >> -                GIC_PRI_IPI); >>       for (i = 0; i < NR_GIC_SGI; i += 4) >> -        writel_relaxed(priority, >> +        writel_relaxed(GIC_PRI_IPI_ALL, >>                   GICD_RDIST_SGI_BASE + GICR_IPRIORITYR0 + (i / 4) * 4); >>   -    priority = (GIC_PRI_IRQ << 24 | GIC_PRI_IRQ << 16 | GIC_PRI_IRQ << 8 | >> -                GIC_PRI_IRQ); >>       for (i = NR_GIC_SGI; i < NR_GIC_LOCAL_IRQS; i += 4) >> -        writel_relaxed(priority, >> +        writel_relaxed(GIC_PRI_IRQ_ALL, >>                   GICD_RDIST_SGI_BASE + GICR_IPRIORITYR0 + (i / 4) * 4); >>         /* >> diff --git a/xen/arch/arm/include/asm/gic.h b/xen/arch/arm/include/asm/gic.h >> index c7f0c343d1..69ceac36b1 100644 >> --- a/xen/arch/arm/include/asm/gic.h >> +++ b/xen/arch/arm/include/asm/gic.h >> @@ -143,10 +143,14 @@ >>    * >>    * A GIC must support a mimimum of 16 priority levels. >>    */ >> -#define GIC_PRI_LOWEST     0xf0 >> -#define GIC_PRI_IRQ        0xa0 >> -#define GIC_PRI_IPI        0x90 /* IPIs must preempt normal interrupts */ >> -#define GIC_PRI_HIGHEST    0x80 /* Higher priorities belong to Secure-World */ >> +#define GIC_PRI_LOWEST     0xf0U >> +#define GIC_PRI_IRQ        0xa0U >> +#define GIC_PRI_IRQ_ALL    ((GIC_PRI_IRQ << 24) | (GIC_PRI_IRQ << 16) |\ >> +                            (GIC_PRI_IRQ << 8) | GIC_PRI_IRQ) >> +#define GIC_PRI_IPI        0x90U /* IPIs must preempt normal interrupts */ >> +#define GIC_PRI_IPI_ALL    ((GIC_PRI_IPI << 24) | (GIC_PRI_IPI << 16) |\ >> +                            (GIC_PRI_IPI << 8) | GIC_PRI_IPI) > This is matter of taste. I think it would read better to keep GIC_PRI_{LOWEST, IRQ, IPI, HIGHEST} defined together and then define *_ALL separately. > Ok, I will do this in v2. >> +#define GIC_PRI_HIGHEST    0x80U /* Higher priorities belong to Secure-World */ > > NIT: While you are there, I would suggest to add a newline here. So we separate priority definitions from handy helpers. > Ok. >>   #define GIC_PRI_TO_GUEST(pri) (pri >> 3) /* GICH_LR and GICH_VMCR only support >>                                               5 bits for guest irq priority */ > > Other than that. The patch itself looks good to me. So: > > Acked-by: Julien Grall > > Cheers, > Cheers, Michal From xen-devel-bounces@lists.xenproject.org Wed Mar 02 09:59:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 09:59:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282151.480747 (Exim 4.92) (envelope-from ) id 1nPLlW-00039v-MD; Wed, 02 Mar 2022 09:59:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282151.480747; Wed, 02 Mar 2022 09:59:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPLlW-00039o-JI; Wed, 02 Mar 2022 09:59:26 +0000 Received: by outflank-mailman (input) for mailman id 282151; Wed, 02 Mar 2022 09:59:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPLlV-00039i-2m for xen-devel@lists.xenproject.org; Wed, 02 Mar 2022 09:59:25 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 6f87a080-9a0f-11ec-8eba-a37418f5ba1a; Wed, 02 Mar 2022 10:59:23 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5F4E2139F; Wed, 2 Mar 2022 01:59:22 -0800 (PST) Received: from e129167.arm.com (unknown [10.57.71.82]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9A09B3F66F; Wed, 2 Mar 2022 01:59:20 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6f87a080-9a0f-11ec-8eba-a37418f5ba1a From: Michal Orzel To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Julien Grall Subject: [PATCH v2] xen/arm: gic: Introduce GIC_PRI_{IRQ/IPI}_ALL Date: Wed, 2 Mar 2022 10:59:11 +0100 Message-Id: <20220302095911.161259-1-michal.orzel@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Introduce macros GIC_PRI_IRQ_ALL and GIC_PRI_IPI_ALL to be used in all the places where we want to set default priority for all the offsets in interrupt priority register. This will improve readability and allow to get rid of introducing variables just to store this value. Take the opportunity to mark GIC_PRI_{IRQ/IPI} as unsigned values to suppress static analyzer warnings as they are used in expressions exceeding integer range (shifting into signed bit). Modify also other priority related macros to be coherent. Signed-off-by: Michal Orzel Acked-by: Julien Grall --- Changes since v1: -separate priority definitions from handy helpers --- xen/arch/arm/gic-v2.c | 12 +++--------- xen/arch/arm/gic-v3.c | 16 +++------------- xen/arch/arm/include/asm/gic.h | 13 +++++++++---- 3 files changed, 15 insertions(+), 26 deletions(-) diff --git a/xen/arch/arm/gic-v2.c b/xen/arch/arm/gic-v2.c index b2adc8ec9a..2cc2f6bc18 100644 --- a/xen/arch/arm/gic-v2.c +++ b/xen/arch/arm/gic-v2.c @@ -373,9 +373,7 @@ static void __init gicv2_dist_init(void) /* Default priority for global interrupts */ for ( i = 32; i < nr_lines; i += 4 ) - writel_gicd(GIC_PRI_IRQ << 24 | GIC_PRI_IRQ << 16 | - GIC_PRI_IRQ << 8 | GIC_PRI_IRQ, - GICD_IPRIORITYR + (i / 4) * 4); + writel_gicd(GIC_PRI_IRQ_ALL, GICD_IPRIORITYR + (i / 4) * 4); /* Disable all global interrupts */ for ( i = 32; i < nr_lines; i += 32 ) @@ -403,15 +401,11 @@ static void gicv2_cpu_init(void) /* Set SGI priorities */ for ( i = 0; i < 16; i += 4 ) - writel_gicd(GIC_PRI_IPI << 24 | GIC_PRI_IPI << 16 | - GIC_PRI_IPI << 8 | GIC_PRI_IPI, - GICD_IPRIORITYR + (i / 4) * 4); + writel_gicd(GIC_PRI_IPI_ALL, GICD_IPRIORITYR + (i / 4) * 4); /* Set PPI priorities */ for ( i = 16; i < 32; i += 4 ) - writel_gicd(GIC_PRI_IRQ << 24 | GIC_PRI_IRQ << 16 | - GIC_PRI_IRQ << 8 | GIC_PRI_IRQ, - GICD_IPRIORITYR + (i / 4) * 4); + writel_gicd(GIC_PRI_IRQ_ALL, GICD_IPRIORITYR + (i / 4) * 4); /* Local settings: interface controller */ /* Don't mask by priority */ diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c index 9a3a175ad7..3c472ed768 100644 --- a/xen/arch/arm/gic-v3.c +++ b/xen/arch/arm/gic-v3.c @@ -594,7 +594,6 @@ static void gicv3_set_irq_priority(struct irq_desc *desc, static void __init gicv3_dist_init(void) { uint32_t type; - uint32_t priority; uint64_t affinity; unsigned int nr_lines; int i; @@ -621,11 +620,7 @@ static void __init gicv3_dist_init(void) /* Default priority for global interrupts */ for ( i = NR_GIC_LOCAL_IRQS; i < nr_lines; i += 4 ) - { - priority = (GIC_PRI_IRQ << 24 | GIC_PRI_IRQ << 16 | - GIC_PRI_IRQ << 8 | GIC_PRI_IRQ); - writel_relaxed(priority, GICD + GICD_IPRIORITYR + (i / 4) * 4); - } + writel_relaxed(GIC_PRI_IRQ_ALL, GICD + GICD_IPRIORITYR + (i / 4) * 4); /* Disable/deactivate all global interrupts */ for ( i = NR_GIC_LOCAL_IRQS; i < nr_lines; i += 32 ) @@ -806,7 +801,6 @@ static int __init gicv3_populate_rdist(void) static int gicv3_cpu_init(void) { int i, ret; - uint32_t priority; /* Register ourselves with the rest of the world */ if ( gicv3_populate_rdist() ) @@ -826,16 +820,12 @@ static int gicv3_cpu_init(void) } /* Set priority on PPI and SGI interrupts */ - priority = (GIC_PRI_IPI << 24 | GIC_PRI_IPI << 16 | GIC_PRI_IPI << 8 | - GIC_PRI_IPI); for (i = 0; i < NR_GIC_SGI; i += 4) - writel_relaxed(priority, + writel_relaxed(GIC_PRI_IPI_ALL, GICD_RDIST_SGI_BASE + GICR_IPRIORITYR0 + (i / 4) * 4); - priority = (GIC_PRI_IRQ << 24 | GIC_PRI_IRQ << 16 | GIC_PRI_IRQ << 8 | - GIC_PRI_IRQ); for (i = NR_GIC_SGI; i < NR_GIC_LOCAL_IRQS; i += 4) - writel_relaxed(priority, + writel_relaxed(GIC_PRI_IRQ_ALL, GICD_RDIST_SGI_BASE + GICR_IPRIORITYR0 + (i / 4) * 4); /* diff --git a/xen/arch/arm/include/asm/gic.h b/xen/arch/arm/include/asm/gic.h index c7f0c343d1..b3c6c67933 100644 --- a/xen/arch/arm/include/asm/gic.h +++ b/xen/arch/arm/include/asm/gic.h @@ -143,10 +143,15 @@ * * A GIC must support a mimimum of 16 priority levels. */ -#define GIC_PRI_LOWEST 0xf0 -#define GIC_PRI_IRQ 0xa0 -#define GIC_PRI_IPI 0x90 /* IPIs must preempt normal interrupts */ -#define GIC_PRI_HIGHEST 0x80 /* Higher priorities belong to Secure-World */ +#define GIC_PRI_LOWEST 0xf0U +#define GIC_PRI_IRQ 0xa0U +#define GIC_PRI_IPI 0x90U /* IPIs must preempt normal interrupts */ +#define GIC_PRI_HIGHEST 0x80U /* Higher priorities belong to Secure-World */ +#define GIC_PRI_IRQ_ALL ((GIC_PRI_IRQ << 24) | (GIC_PRI_IRQ << 16) |\ + (GIC_PRI_IRQ << 8) | GIC_PRI_IRQ) +#define GIC_PRI_IPI_ALL ((GIC_PRI_IPI << 24) | (GIC_PRI_IPI << 16) |\ + (GIC_PRI_IPI << 8) | GIC_PRI_IPI) + #define GIC_PRI_TO_GUEST(pri) (pri >> 3) /* GICH_LR and GICH_VMCR only support 5 bits for guest irq priority */ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 02 10:13:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 10:13:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282158.480759 (Exim 4.92) (envelope-from ) id 1nPLyb-0005ik-UE; Wed, 02 Mar 2022 10:12:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282158.480759; Wed, 02 Mar 2022 10:12:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPLyb-0005id-Qo; Wed, 02 Mar 2022 10:12:57 +0000 Received: by outflank-mailman (input) for mailman id 282158; Wed, 02 Mar 2022 10:12:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPLya-0005iX-Ks for xen-devel@lists.xenproject.org; Wed, 02 Mar 2022 10:12:56 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5232b3ad-9a11-11ec-8539-5f4723681683; Wed, 02 Mar 2022 11:12:54 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5232b3ad-9a11-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1646215974; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=KShpUDFeDNO7NDkerg4z+iS5J1YnB7SYSH43894WEo4=; b=Olxy2OD5EDpyefGdqwVuYziXWnyUgmiNmjgRqMajjh8UFRIoublLwcQC FR2guR4SUJst7OYohpi3wvOeetKOJO8b4VAv7JfvVr7PA2TUvIBqoAr/x j4dEJpjJYPMTkbxG8h8bgh5EjCU/ckRaifYM0ISipFfaO8T2JdWxQ2ZCt 4=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com X-SBRS: 5.1 X-MesageID: 64740714 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:cBgmYqNJ6RddtijvrR24l8FynXyQoLVcMsEvi/4bfWQNrUom0TRTn GUfXW2DOfmJZmf1fd92bYnj8R8PvMDWn4BhSAto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFcMpBsJ00o5wbZi2tQw27BVPivW0 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z6 o535cC+RzkVZIbjh8A7dxVfL3sgMvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr 7pCcmlLN03dwbLtqF64YrAEasALBc/nJo4A/FpnyinUF60OSpHfWaTao9Rf2V/cg+gQQamCP 5VANVKDajycej93Cg89M64vwuCxr13fazpxjwis8P9fD2/7k1UqjemF3MDuUsyHQ4BZk1iVo krC/n/lGVcKOdqH0z2H/3mwwOjVkkvTR4Y6BLC+sPlwjzW7xGYeFRkXXluTuuSihwi1XNc3F qAP0nNw9+5orhXtF4SjGU3jyJKZgvICc/gLKb1m5g+z9vD/zBm9IEwISQIbNtNz4afaWgcW/ lOOmtroAxlmv7uUVW+R+9+okN+iBcQGBTRcPHFZFGPp9/Gm+dhu1UyXEr6PBYbo1oWdJN3m/ 9ydQMHSbZ03hNVD6ai09Euvb9mE9smQFV5dCuk6swuYAuJFiGyNOtTABbvzt68owGOlor+p5 iJsdy+2tr1mMH11vHbRKNjh5Znwjxp/DBXSgER0A74q/Cm39niocOh4uW8ieh43ap5VJ2a4O ic/XD+9ArcJZhNGioctPuqM5zkCl/C8RbwJqNiOBjaxXnSBXFDep3w/DaJh92vsjFItgckC1 WSzKq6R4YIhIf0/llKeHr5FuZdyn3xW7T6DFPjTkkX8uZLDNSH9dFvwGAbXBgzPxPjf+1u9H hc2H5bi9iizp8WlOniHqdNIdAtSRZX5bLivw/Fqmie4ClMOMEkqCuPLwKNnfIpgnq9PkfzP8 G37UUhdoGcTT1WeQelWQhiPsI/SYKs= IronPort-HdrOrdr: A9a23:BufCV6AT2g61TAblHegMsceALOsnbusQ8zAXPh9KJyC9I/b2qy nxppgmPEfP+UossHFJo6HlBEEZKUmsu6KdkrNhQotKOzOW+VdATbsSorcKpgeAJ8SQzJ8k6U 4NSdkdNDS0NykGsS+Y2nj5Lz9D+qj9zEnAv463pB0BLXAIV0gj1XYCNu/yKDwteOAsP+tfKH Po3Ls/m9PWQwVwUi3UPAhhY8Hz4/nw0L72ax8PABAqrCOUiymz1bL8Gx+Emj8DTjJm294ZgC v4uj28wp/mn+Cwyxfa2WOWxY9RgsHdxtxKA9HJotQJKw/rlh2jaO1aKv+/VXEO0aSSAWQR4Z 7xSiQbToJOArTqDziISC7Wqk3dOfAVmiffIBGj8CDeSIfCNUwH4oJ69PNkm13imhcdVZhHod F2NyjyjesmMTrQ2Cv6/NTGTBdsiw69pmcji/caizhFXZIZc6I5l/1UwKp5KuZJIMvB0vFtLA CuNrCq2N9GNVeBK3zJtGhmx9KhGnw1AxedW0AH/siYySJfknx1x1YRgJV3pAZNyLstD51fo+ jUOKVhk79DCscQcKJmHe8EBc+6EHbETx7AOH+bZV7nCKYEMXTQrIOf2sR52Mi6PJgTiJcikp XIV11V8WY0ZkL1EMWLmIZG9xjcKV/NFAgFCvsukaSRloeMMYYDaxfzOmzGu/HQ18kiPg== X-IronPort-AV: E=Sophos;i="5.90,148,1643691600"; d="scan'208";a="64740714" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=feUIOFZZOYllMcP8kQO0pJchqjnMXh1QD6b1l4fLjAJYJ6Uh2TSbySRkG4Oawoitgmh8E42ZRqT3hDnBtOUCTqaw271nfH3RAMYIIK5Wi3U/XRDRGpO8Ul1PVj2jxTh1Jtk2DkTMtx7RS4mrpuzS0K7AguXf97gnID6YrA0EKZvYZs9XQdJU+Hns1y13siDiCmcNUAuln3Pu1vd5hoUm0bDeIu8hlj3h8IsdnKxg7+f/s0CINd7Y2cL0nooLgzZ/bfBR8n/YYTaEcMWRtixBSL8x2JFwW2e+akMdPCuOUhA8TXIaORzWFDnsguOPybFzO6XWn7Gx5rBcjWjN6GER9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KShpUDFeDNO7NDkerg4z+iS5J1YnB7SYSH43894WEo4=; b=ksVc2mEyuF2uRKC/i9aRiQXxlA1VN/w3uaRAIsir+RYDmLF12g76zmNbWon3uESUy7iQp4HuoYAVbdJirOkQmGygyIkKtshL1vuS8rJx8Q7nu6chLg2RZX9oSj0xWxOcq/+XS0/TyfyzmuZMuxxsFMhWro7o4qcDeazO1hJ9RP2Gv1sd7ZFVGQM8XoObJTOSN6Orht6MB0KZPR2hRP7+AvB+Fsrw5JOaUO8NzPQ4CQrsSuh6oXFUhf6ig57qNRUhQwxiTMi/D0rbWy1iZMbAzc8kqPBAayajudOAI6CBFJeuDfbZ89yHNZllGpp8CgWktRearyMpGBeAw2S5+9myzA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KShpUDFeDNO7NDkerg4z+iS5J1YnB7SYSH43894WEo4=; b=lnVXKnwMm8QBFDoF+y9h+zsohRKIXvN8GAENuH6kGynHuKkf13h0Y0m3Qh/I/a1RydTJKSpNnsz3Ao0J9EjGEmncGirncdAQaP6G+oIQAAvNHJ6wN/HT9UjbRDfXhDpndBrwID2ffLDvpPkhY6PghbcVbnTQF7zKeeiEW4fqmuE= From: Andrew Cooper To: Jan Beulich CC: Roger Pau Monne , Wei Liu , Xen-devel Subject: Re: [PATCH v2.2 8/7] x86/IOMMU: Use altcall, and __initconst_cf_clobber Thread-Topic: [PATCH v2.2 8/7] x86/IOMMU: Use altcall, and __initconst_cf_clobber Thread-Index: AQHYJ+IV6PtRJY8p5U2wBnUH9jKzdqyj8n0AgAa3aoCAASBXAIAAIhyA Date: Wed, 2 Mar 2022 10:12:45 +0000 Message-ID: References: <20220214125632.24563-1-andrew.cooper3@citrix.com> <20220222114711.19209-1-andrew.cooper3@citrix.com> <5fae516a-17c1-0ce4-c46e-909a83c0e273@citrix.com> <60f3c942-3822-87dd-df6e-8b64ed4d17c4@suse.com> In-Reply-To: <60f3c942-3822-87dd-df6e-8b64ed4d17c4@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 77f4eecc-774e-4f7f-a884-08d9fc353263 x-ms-traffictypediagnostic: BYAPR03MB3813:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: mKF1N7NkrnkWl0W52NB6IOqPV6YO3DsnWUaqunhugCsEKPxWJzvvxyWbOimTll8P3dDruFHl9NGZ1jG1YVLfh+dTLiwkB2fky7gHAZ53NiQKgYNbkrRsz2/Vdf3oRUpfpY2ya2r4vqSRQN3HspVyT3xOR4k+aaAQPoDnDp9xK+ggdukf6/XK+qZG7VlGUOyOZJzxXXofa0bqR7mWzhoehz7pD9qNpHElGNfosMJu4/6XOGozlaWZpO2UkQTC6LYAUTd2Y2AD9JvNoDtbox833Q2XxZN2BPk1opy5Kkb0wzw/91l+3BLGngn6FBPjEs4L2lvOXPQxWyFgZ2AxjF47Iqd3LLi16PMJmV1AmSv1cPdwej2OFQ29slVRD34ne/VktNAWl9u6R+QpxkBhxbzN5SEq+X5383/NabvZI5VEvJe/ETV8j226xj6nXgRRhF4FTkvFzt4ka63sTSArzyyPM9K/Z3vrqszpz8Ls3bLxwi50iOpgBENNHdTBshFET+5KLn8vbQreWzP87TyZ5nu2gVQm0o8ckeja7DhDv0WnQbVob5DirIDPt1c1/oTIiV4mqc2s2u/AEFaPTQm8jCnyjwjhfSsAfWDHNK13Lu32KrmwwZO/RGV1njyhYIDI7FQDIHvw5FR8fl8QuPj+R1xkQGmYN5gyPP+unMjFyxGXvKFml3CmE1QDdxrDhH2w0ZG7UPr0VYn1r5os5Pu6sOcmtdUKkoPCjB+ZOwaNFDh3WQH33LsmTWtkW7vrM8WDkz/gdblFNu53l9lRoQBn7xnF2A== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(54906003)(76116006)(186003)(8936002)(31686004)(91956017)(66946007)(6916009)(64756008)(8676002)(316002)(66476007)(2616005)(86362001)(66556008)(66446008)(26005)(82960400001)(36756003)(6512007)(53546011)(2906002)(31696002)(122000001)(38100700002)(6486002)(5660300002)(4326008)(71200400001)(38070700005)(6506007)(83380400001)(508600001)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Z1pLV0lKYUZWY0xFMElGTzIrWVJ6YnRhVUxlRmlDUHdRNHRrUC9rVWVrU2Fo?= =?utf-8?B?SDdCemNTNjRGS2xpWkNGcVNSNWJkK1I5R1JzN0hlczNEMU96VExlMDZXcERB?= =?utf-8?B?Q3BrSnBaMEkxWVM2SG1lRkdEWFI1SUVBdjdPMUV1S1RwS04wd3VvNW5TbFo5?= =?utf-8?B?aUkvOE40MHNBV1ROS0UxdGhxY2gySlZHakh5bVNSOWkxR08zenR1NFBvVkR3?= =?utf-8?B?MDNGTnlISjF6a0M3RWFwcGc2NlBaSDkwK0xWd1NtQndWVFZ2bG42NUZWQXo0?= =?utf-8?B?UGdvSTJxUlJrcWtMbWNtN3hwUk5EVW5MUmsxK2s5akovNlR4N2c3Si9LcC9i?= =?utf-8?B?ZGYrekdIYnNpZis1dkdBWkQ2M2krWkRYelA3U1BCd055MXRDcGlwRm5HNkpT?= =?utf-8?B?L3VKZWFWdWpsOEtCK3h2S1ZMaytjRUxiVzY4NlBZU01reG1RU21QY0g1OG1Y?= =?utf-8?B?K1krdEhtamYwWlRTRnU1K2c2Um9Ea1hFYk9CWmtVaFlnNFZNZmVEZFU3eG13?= =?utf-8?B?V1dIUW1TV3NrR2Q2Z2F6cDFjVk0yREJiOFk3aFpPUGh6d3BJekMwQzc0dVAw?= =?utf-8?B?ZEpaaE8wWmthcWozZ0ExalM1Z0Y4NGJtUFNHUHBIb2lyRVhORldEdy9nTmFM?= =?utf-8?B?V0wrTDJQa3cwZjZpR0ZZamU2TEkyMXZMb3cxNVpTRURsQ3hPWmNJSFpYaTJC?= =?utf-8?B?eDB1QnpMYVRVcURLanZtSm9mcGFvR0xvalJHbExWVUFDNDFPeFd2ZGY5RU5K?= =?utf-8?B?cjJuOWRRQ2l0MmswZXRnaG9WN1A5ZFI4bHlvS2FBeWpId0xnWDM1YThTVjkv?= =?utf-8?B?eW8xVzdtVE0xOTRoRDNaZXhJeks1S3p2STRDTGtidS9Jdi9yV1BjM3JFaEFN?= =?utf-8?B?UDV1a3ZUeTRzTEo1NkRZRWZVR3ExSUdsY0NzUDhQMHNvdXZPam1BM1BraFdM?= =?utf-8?B?aHpXV3lPeVZZTHJwbEs1Vk9zL2tWaDlraU1hZGhBQWJ0Y2FYdzZSTWlkcUtS?= =?utf-8?B?MW9rYnhxUjlJaWVVUkNJdGhpK3N1NHRyTmR5YXphRmRRV0hrbTdBbFR2UjNL?= =?utf-8?B?bUhyVktMYjliL0NPSjhpK2JGTmFDcmplNFMzTVZieHgxV0pXWWRqTko4V3Ny?= =?utf-8?B?OFpqUyszVUhYRXpJQ3QxWk9rdDBrZTlrUDZVcWg4YXdYRUVCQ1VqYXlwNzRN?= =?utf-8?B?Z0ltY1FpWHBZSktPSnhMS1ZJTXNJcmNpaTF3WFRieWxZZ2JzNlJlYysxWmc0?= =?utf-8?B?L3gyRHE0eVE0a0Jwd1Z6L0MwdUlXNkRhS3M0WGVnaHA0bVExemY3RVVzdzIz?= =?utf-8?B?MnBod2VyaGpWQjZsQWEySjRHNk5FMVFCMlVSZGJyMkhlV3UxNGRZTUhPTFpZ?= =?utf-8?B?QW9HWE1odGhHYWpxeDk0ZW8yMWhZVmd0dWgwMExtalZLUVZ0KzJLM0t2dG52?= =?utf-8?B?ZmJrY296VzZWMXFRNU1wWHFYTThHRDRmTHlhNGR5d3QxbHFWNWtFNFFRM0Zr?= =?utf-8?B?WU15RzFBOEtGZDdsYU1pdTFpMHliL1BReCtHZFFQdkxvY2tIOThzOFRIdklr?= =?utf-8?B?UkhKTG1BQjdHSi9oaFJLYmYvSE80Z1RKUWoxWVpTVmhHemhUQmNCYUZxUGd2?= =?utf-8?B?TVU5UEhCdE5JVFdLWFBCMWVMZldjeG1yeVhoQWNlaFdvdWFTb0VvdTlXNnR0?= =?utf-8?B?UEJHaHluQkk3ZG9WeTUzTmJ1K2hUQmZDQnNpODNlTW9yV3IvckV5YnVMU1k2?= =?utf-8?B?a2RTaEEvYW1CUDZYNldMWWJZenhlbkhpeU1sUWsvTHlQTTNxYXY0amhjbUNm?= =?utf-8?B?T2dHeWJhZHJDbTBEVXpaMVRSVWRBNXBVOXEybm5zaWxnMFFxeEVsSHJLcDc5?= =?utf-8?B?amhHYjlXd1JIaHhPdWMvNDZqcWNrdjhYMzNxMGNpS0E4Vzd6ejJENm5udmF1?= =?utf-8?B?ajExNUk3WWphbURBZ2JWV3d5c3QzWURtbXNPNDNXSENOZStNbFo2YVFWUnd3?= =?utf-8?B?NmxCcGlPVlF2NFQ4VWQ0czV0Y1ZTRGxsd09lSi9mdTk2Ly9GektkVnk4VEdN?= =?utf-8?B?b09MVnBSKzg0cEkrRER3bFZ0V1BxNmdLdFcyc0RmVUZvZlE4VGZGaHBNTmkv?= =?utf-8?B?b3hwb1VuanRmZElhSStqZmdhTlJHRG43SCswWW5PeUNFU2xFNDdtbWdPOHg3?= =?utf-8?B?ZzUzQW9qc09CZWZxdXZYOUIyVXRMY0VUZks3WXFyQU5VVGdLYmxBM09aMHhv?= =?utf-8?B?MHdPcTczb2tlYUdSV0lhZEhvV2xBPT0=?= Content-Type: text/plain; charset="utf-8" Content-ID: <4F5A7A79D5E24F4286B04841F4144DB5@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 77f4eecc-774e-4f7f-a884-08d9fc353263 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Mar 2022 10:12:45.7400 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ucXagEDUjHnz81FjuwX4PEGV3CqW7cX913e0LUeCy8SviAWl6Ox4mQ/Imib1zB7GP4D9i9YxEKrXuiqX+URu4je+YzjUSAuoxw2K7BTyPhI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB3813 X-OriginatorOrg: citrix.com T24gMDIvMDMvMjAyMiAwODoxMCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDAxLjAzLjIwMjIg MTU6NTgsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBPbiAyNS8wMi8yMDIyIDA4OjI0LCBKYW4g QmV1bGljaCB3cm90ZToNCj4+PiBPbiAyMi4wMi4yMDIyIDEyOjQ3LCBBbmRyZXcgQ29vcGVyIHdy b3RlOg0KPj4+PiAtLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9hbWQvcGNpX2FtZF9pb21t dS5jDQo+Pj4+ICsrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL2FtZC9wY2lfYW1kX2lvbW11 LmMNCj4+Pj4gQEAgLTYyOCw3ICs2MjgsNyBAQCBzdGF0aWMgdm9pZCBjZl9jaGVjayBhbWRfZHVt cF9wYWdlX3RhYmxlcyhzdHJ1Y3QgZG9tYWluICpkKQ0KPj4+PiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgaGQtPmFyY2guYW1kLnBhZ2luZ19tb2RlLCAwLCAwKTsNCj4+Pj4gIH0NCj4+ Pj4gIA0KPj4+PiAtc3RhdGljIGNvbnN0IHN0cnVjdCBpb21tdV9vcHMgX19pbml0Y29uc3RyZWwg X2lvbW11X29wcyA9IHsNCj4+Pj4gK3N0YXRpYyBjb25zdCBzdHJ1Y3QgaW9tbXVfb3BzIF9faW5p dGNvbnN0X2NmX2Nsb2JiZXIgX2lvbW11X29wcyA9IHsNCj4+PiBGb2xsb3dpbmcgbXkgaW5pdGNh bGwgcmVsYXRlZCByZW1hcmsgb24geDg2J2VzIHRpbWUuYyBJJ20gYWZyYWlkIEkgZG9uJ3QNCj4+ PiBzZWUgaG93IHRoaXMgYW5kIC4uLg0KPj4+DQo+Pj4+IEBAIC0yNzk0LDcgKzI3OTMsNyBAQCBz dGF0aWMgaW50IF9faW5pdCBjZl9jaGVjayBpbnRlbF9pb21tdV9xdWFyYW50aW5lX2luaXQoc3Ry dWN0IGRvbWFpbiAqZCkNCj4+Pj4gICAgICByZXR1cm4gcmM7DQo+Pj4+ICB9DQo+Pj4+ICANCj4+ Pj4gLXN0YXRpYyBzdHJ1Y3QgaW9tbXVfb3BzIF9faW5pdGRhdGEgdnRkX29wcyA9IHsNCj4+Pj4g K3N0YXRpYyBjb25zdCBzdHJ1Y3QgaW9tbXVfb3BzIF9faW5pdGNvbnN0X2NmX2Nsb2JiZXIgdnRk X29wcyA9IHsNCj4+PiAuLi4gdGhpcyBhY3R1YWxseSB3b3Jrcy4gQnV0IEkgZ3Vlc3MgSSBtdXN0 IGJlIG92ZXJsb29raW5nIHNvbWV0aGluZywgYXMNCj4+PiBJJ20gc3VyZSB0aGF0IHlvdSBkaWQg dGVzdCB0aGUgY2hhbmdlLg0KPj4+DQo+Pj4gQm90aCBvcHMgc3RydWN0dXJlcyByZWZlcmVuY2Ug YSBmdW5jdGlvbiwgdGhyb3VnaCAuYWRqdXN0X2lycV9hZmZpbml0aWVzLA0KPj4+IHdoaWNoIGlz bid0IF9faW5pdCBidXQgd2hpY2ggaXMgdXNlZCAoYmVzaWRlcyBoZXJlKSBmb3IgYW4gaW5pdGNh bGwuIFdpdGgNCj4+PiB0aGUgRU5EQlIgcmVtb3ZlZCBieSB0aGUgdGltZSBpbml0Y2FsbHMgYXJl IHJ1biwgdGhlc2Ugc2hvdWxkIGNhdXNlICNDUC4NCj4+IFRoaXMgZG9lc24ndCBleHBsb2RlIGJl Y2F1c2UgdGhlIGluZGlyZWN0IGNhbGxzIGFyZSByZXNvbHZlZCB0byBkaXJlY3QNCj4+IGNhbGxz IGJlZm9yZSB0aGUgRU5EQlIncyBhcmUgY2xvYmJlcmVkIHRvIE5PUDQuDQo+IEknbSBhZnJhaWQg SSBkb24ndCB1bmRlcnN0YW5kOiBUaGUgcHJvYmxlbWF0aWMgY2FsbCBpcyBpbiBkb19pbml0Y2Fs bHMoKToNCj4NCj4gICAgIGZvciAoIGNhbGwgPSBfX3ByZXNtcF9pbml0Y2FsbF9lbmQ7IGNhbGwg PCBfX2luaXRjYWxsX2VuZDsgY2FsbCsrICkNCj4gICAgICAgICAoKmNhbGwpKCk7DQo+DQo+IEkg ZG9uJ3Qgc2VlIGhvdyB0aGlzIGNvdWxkIGJlIGNvbnZlcnRlZCB0byBhIGRpcmVjdCBjYWxsLg0K DQpPaC7CoCBpb3ZfYWRqdXN0X2lycV9hZmZpbml0aWVzKCkncyBkb3VibGUgdXNlIGlzIGhpZGlu ZyBoZXJlLg0KDQpUaGUgc2FmZXR5IHJ1bGUgZm9yIGNmX2Nsb2JiZXIgaXMgdGhhdCB0aGVyZSBt dXN0IG5vdCBiZSBhbnkNCm5vbi1hbHQtY2FsbGVkIGNhbGxlcnMuwqAgV2UgbmVlZCB0byBmaXgg aXQ6DQoNCmRpZmYgLS1naXQgYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9hbWQvaW9tbXVfaW5p dC5jDQpiL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL2FtZC9pb21tdV9pbml0LmMNCmluZGV4IDY1 N2M3ZjYxOWE1MS4uYjFhZjUwODVlZmRhIDEwMDY0NA0KLS0tIGEveGVuL2RyaXZlcnMvcGFzc3Ro cm91Z2gvYW1kL2lvbW11X2luaXQuYw0KKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvYW1k L2lvbW11X2luaXQuYw0KQEAgLTgzMSw3ICs4MzEsMTIgQEAgaW50IGNmX2NoZWNrIGlvdl9hZGp1 c3RfaXJxX2FmZmluaXRpZXModm9pZCkNCsKgDQrCoMKgwqDCoCByZXR1cm4gMDsNCsKgfQ0KLV9f aW5pdGNhbGwoaW92X2FkanVzdF9pcnFfYWZmaW5pdGllcyk7DQorDQoraW50IGNmX2NoZWNrIF9f aW5pdCBpbml0Y2FsbF9pb3ZfYWRqdXN0X2lycV9hZmZpbml0aWVzKHZvaWQpDQorew0KK8KgwqDC oCByZXR1cm4gaW9tbXVfY2FsbCgmaW9tbXVfb3BzLCBhZGp1c3RfaXJxX2FmZmluaXRpZXMpOw0K K30NCitfX2luaXRjYWxsKGluaXRjYWxsX2lvdl9hZGp1c3RfaXJxX2FmZmluaXRpZXMpOw0KwqAN CsKgLyoNCsKgICogRmFtaWx5MTVoIE1vZGVsIDEwaC0xZmggZXJyYXR1bSA3NDYgKElPTU1VIExv Z2dpbmcgTWF5IFN0YWxsDQpUcmFuc2xhdGlvbnMpDQoNCg0KPiBBZmFpY3Mgb25seSBwcmUtU01Q IGluaXRjYWxscyBhcmUgc2FmZSBpbiB0aGlzIHJlZ2FyZDogZG9fcHJlc21wX2luaXRjYWxscygp DQo+IGlzIGNhbGxlZCBpbW1lZGlhdGVseSBhaGVhZCBvZiBhbHRlcm5hdGl2ZV9icmFuY2hlcygp Lg0KPg0KPiBJc24ndCB0aGlzIChwcmV2aW91c2x5Pykgd29ya2luZyByZWxhdGVkIHRvIHlvdXIg Ing4Ni9zcGVjLWN0cmw6IERpc2FibGUNCj4gcmV0cG9saW5lcyB3aXRoIENFVC1JQlQiPw0KDQpO by7CoCBJdCdzIGJlY2F1c2UgQU1EIENQVXMgZG9uJ3QgaGF2ZSBDRVQtSUJUIGF0IHRoaXMganVu Y3R1cmUsIGFuZCB3aWxsDQpuZXZlciBlbmNvdW50ZXIgYSBmYXVsdGluZyBzaXR1YXRpb24uDQoN ClRoaXMgaXMgZXhhY3RseSB3aGF0IHRoZSBVRDEgYWRqdXN0bWVudCBpbiBMaW51eCBhcmUgaW50 ZW5kZWQgdG8gc3BvdCwNCmJlY2F1c2UgdGhhdCB3b3VsZCBjYXVzZSBhbGwgQU1EIGhhcmR3YXJl IHRvIGV4cGxvZGUsIG5vdCBqdXN0IHRoZQ0KSUJULWVuYWJsZWQgb25lcy4NCg0KfkFuZHJldw0K From xen-devel-bounces@lists.xenproject.org Wed Mar 02 10:25:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 10:25:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282165.480770 (Exim 4.92) (envelope-from ) id 1nPMAH-0007RC-2T; Wed, 02 Mar 2022 10:25:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282165.480770; Wed, 02 Mar 2022 10:25:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPMAG-0007R5-Tt; Wed, 02 Mar 2022 10:25:00 +0000 Received: by outflank-mailman (input) for mailman id 282165; Wed, 02 Mar 2022 10:24:58 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPMAE-0007Qy-SV for xen-devel@lists.xenproject.org; Wed, 02 Mar 2022 10:24:58 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPMAE-0002k9-F7; Wed, 02 Mar 2022 10:24:58 +0000 Received: from 54-240-197-224.amazon.com ([54.240.197.224] helo=[192.168.10.166]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nPMAE-0001tM-9S; Wed, 02 Mar 2022 10:24:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=4uvfLopOFXXpP9IPakmYMMfm7KZs0MhHhWTR090+4PY=; b=t1uqdmYuEq/lslnZigPZmri9E6 RAV/Qo4NQjyBjeCHVoA059EDu3ro28VecxJxkUUsOd51ROQnJUS/0yR9LN46PPPe05WSXPmAHSOoa Va1Zh2/Nuw/bAuD6Qj/D6D3hpti9HFzLTog/RP6lIVfnSKdJDGUbOpdtixAsLss0L2uo=; Message-ID: <5eb5fe51-9ef7-affe-06e1-b15da512a76c@xen.org> Date: Wed, 2 Mar 2022 10:24:56 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: Proposal for Porting Xen to Armv8-R64 - DraftA To: Wei Chen , Stefano Stabellini Cc: "xen-devel@lists.xenproject.org" , Bertrand Marquis , Penny Zheng , Henry Wang , nd References: <4c558f8f-56d4-0445-32d4-169bc5d0a3bc@xen.org> <7260f050-9022-4adf-618b-a8b271aca8c3@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Wei, On 02/03/2022 06:43, Wei Chen wrote: >> -----Original Message----- >> From: Julien Grall >> Sent: 2022年3月1日 21:17 >> To: Wei Chen ; Stefano Stabellini >> >> Cc: xen-devel@lists.xenproject.org; Bertrand Marquis >> ; Penny Zheng ; Henry Wang >> ; nd >> Subject: Re: Proposal for Porting Xen to Armv8-R64 - DraftA >> >> On 01/03/2022 06:29, Wei Chen wrote: >>> Hi Julien, >> >> Hi, >> >>>> -----Original Message----- >>>> From: Julien Grall >>>> Sent: 2022年2月26日 4:12 >>>> To: Wei Chen ; Stefano Stabellini >>>> >>>> Cc: xen-devel@lists.xenproject.org; Bertrand Marquis >>>> ; Penny Zheng ; Henry >> Wang >>>> ; nd >>>> Subject: Re: Proposal for Porting Xen to Armv8-R64 - DraftA >>>> >>>> Hi Wei, >>>> >>>> On 25/02/2022 10:48, Wei Chen wrote: >>>>>>>      Armv8-R64 can support max to 256 MPU regions. But that's just >>>>>> theoretical. >>>>>>>      So we don't want to define `pr_t mpu_regions[256]`, this is a >>>> memory >>>>>> waste >>>>>>>      in most of time. So we decided to let the user specify through >> a >>>>>> Kconfig >>>>>>>      option. `CONFIG_ARM_MPU_EL1_PROTECTION_REGIONS` default value >> can >>>> be >>>>>> `32`, >>>>>>>      it's a typical implementation on Armv8-R64. Users will >> recompile >>>> Xen >>>>>> when >>>>>>>      their platform changes. So when the MPU changes, respecifying >> the >>>>>> MPU >>>>>>>      protection regions number will not cause additional problems. >>>>>> >>>>>> I wonder if we could probe the number of MPU regions at runtime and >>>>>> dynamically allocate the memory needed to store them in arch_vcpu. >>>>>> >>>>> >>>>> We have considered to used a pr_t mpu_regions[0] in arch_vcpu. But it >>>> seems >>>>> we will encounter some static allocated arch_vcpu problems and sizeof >>>> issue. >>>> >>>> Does it need to be embedded in arch_vcpu? If not, then we could >> allocate >>>> memory outside and add a pointer in arch_vcpu. >>>> >>> >>> We had thought to use a pointer in arch_vcpu instead of embedding >> mpu_regions >>> into arch_vcpu. But we noticed that arch_vcpu has a __cacheline_aligned >>> attribute, this may be because of arch_vcpu will be used very frequently >>> in some critical path. So if we use the pointer for mpu_regions, may >> cause >>> some cache miss in these critical path, for example, in context_swtich. >> >> From my understanding, the idea behind ``cacheline_aligned`` is to >> avoid the struct vcpu to be shared with other datastructure. Otherwise >> you may end up to have two pCPUs to frequently write the same cacheline >> which is not ideal. >> >> arch_vcpu should embbed anything that will be accessed often (e.g. >> entry/exit) to certain point. For instance, not everything related to >> the vGIC are embbed in the vCPU/Domain structure. >> >> I am a bit split regarding the mpu_regions. If they are mainly used in >> the context_switch() then I would argue this is a premature optimization >> because the scheduling decision is probably going to take a lot more >> time than the context switch itself. > > mpu_regions in arch_vcpu are used to save guest's EL1 MPU context. So, yes, > they are mainly used in context_switch. In terms of the number of registers, > it will save/restore more work than the original V8A. And on V8R we also need > to keep most of the original V8A save/restore work. So it will take longer > than the original V8A context_switch. And I think this is due to architecture's > difference. So it's impossible for us not to save/restore EL1 MPU region > registers in context_switch. And we have done some optimization for EL1 MPU > save/restore: > 1. Assembly code for EL1 MPU context_switch This discussion reminds me when KVM decided to rewrite their context switch from assembly to C. The outcome was the compiler is able to do a better job than us when it comes to optimizing. With a C version, we could also share the save/restore code with 32-bit and it is easier to read/maintain. So I would suggest to run some numbers to check if it really worth implementing the MPU save/restore in assembly. > 2. Use real MPU regions number instead of CONFIG_ARM_MPU_EL1_PROTECTION_REGIONS > in context_switch. CONFIG_ARM_MPU_EL1_PROTECTION_REGIONS is defined the Max > supported EL1 MPU regions for this Xen image. All platforms that implement > EL1 MPU regions in this range can work well with this Xen Image. But if the > implemented EL1 MPU region number exceeds CONFIG_ARM_MPU_EL1_PROTECTION_REGIONS, > this Xen image could not work well on this platform. This sounds similar to the GICv3. The number of LRs depends on the hardware. See how we dealt with it in gicv3_save_lrs(). > >> >> Note that for the P2M we already have that indirection because it is >> embbed in the struct domain. > > It's different with V8A P2M case. In V8A context_switch we just need to > save/restore VTTBR, we don't need to do P2M table walk. But on V8R, we > need to access valid mpu_regions for save/restore. The save/restore for the P2M is a bit more complicated than simply save/restore the VTTBR. But yes, I agree the code for the MPU will likely be more complicated. > >> >> This raises one question, why is the MPUs regions will be per-vCPU >> rather per domain? >> > > Because there is a EL1 MPU component for each pCPU. We can't assume guest > to use the same EL1 MPU configuration for all vCPU. Ah. Sorry, I thought you were referring to whatever Xen will use to prevent the guest accessing outside of its designated region. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Mar 02 10:28:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 10:28:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282174.480781 (Exim 4.92) (envelope-from ) id 1nPMDS-0008O9-K0; Wed, 02 Mar 2022 10:28:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282174.480781; Wed, 02 Mar 2022 10:28:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPMDS-0008O2-Go; Wed, 02 Mar 2022 10:28:18 +0000 Received: by outflank-mailman (input) for mailman id 282174; Wed, 02 Mar 2022 10:28:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPMDR-0008Ns-OK; Wed, 02 Mar 2022 10:28:17 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPMDR-0002oW-Jw; Wed, 02 Mar 2022 10:28:17 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPMDR-00083N-9m; Wed, 02 Mar 2022 10:28:17 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nPMDR-0005WM-9I; Wed, 02 Mar 2022 10:28:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=kyjf7Cxxrs3a4Eo224DHZ09y++qDmbO5WamKgM2RasA=; b=u08Up/KWWsHaeNIZhHqDz0MWY4 z5dzVxocK5enEH50OQEzdwc1SBi7MPzxrQI6ppISnpRewuJzzZpvHRnnkZZudokkdOzDkMc3lFPWw 3B6jwvDQUpGq9VrAB+t6lJg7zpD3KTyKu6kfUthjuq/acJUyAbRtisewc340YmX+PjMg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 168329: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=dc39554d58af4a50b50eca1f57c49415a12b0c98 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Wed, 02 Mar 2022 10:28:17 +0000 flight 168329 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/168329/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf dc39554d58af4a50b50eca1f57c49415a12b0c98 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 1 days Failing since 168258 2022-03-01 01:55:31 Z 1 days 15 attempts Testing same since 168316 2022-03-02 02:50:20 Z 0 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Guomin Jiang Jason Jason Lou Xiaolu.Jiang jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit dc39554d58af4a50b50eca1f57c49415a12b0c98 Author: Xiaolu.Jiang Date: Tue Feb 22 22:14:05 2022 +0800 edk2/MdeModulePkg/Debuglib: Add Standalone MM support https://bugzilla.tianocore.org/show_bug.cgi?id=3844 This change added Standalone MM instance of DebugLib. Reviewd-by: Jian J Wang Reviewd-by: Liming Gao Signed-off-by: Xiaolu.Jiang commit 497ac7b6d7f9750f48f137db244931a5728b1968 Author: Guomin Jiang Date: Sat Jan 29 16:28:02 2022 +0800 UefiPayloadPkg/PayloadLoaderPeim: Use INT64 as input parameter REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3818 It will have some potential issue when memory larger than 2G because the high memory address will be fill with 0xFFFFFFFF when do the operation of INTN + INT64 but it is 32 bit normal data in fact. Should use same data type INT64 + INT64. V3: 1. Use INT64 as input parameter because all date type is 64 bit V2: 1. Force the data type to UINTN to avoid high dword be filled with 0xFFFFFFFF 2. Keep INTN because the offset may postive or negative. Reviewed-by: Guo Dong Reviewed-by: Ray Ni Signed-off-by: Guomin Jiang commit 6a890db161cd6d378bec3499a1e774db3f5a27a7 Author: Jason Date: Mon Jan 10 22:30:29 2022 +0800 BaseTools: Upgrade the version of NASM tool REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Upgrade the version of NASM tool to avoid compilation errors when compiling NASM code change. Signed-off-by: Jason Lou Cc: Bob Feng Cc: Liming Gao Reviewed-by: Yuwei Chen commit bbaa00dd01ed0df30e43a5a89fd2b0433d858b73 Author: Jason Date: Mon Jan 10 22:05:47 2022 +0800 MdePkg: Remove the macro definitions regarding Opcode. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Remove the macro definitions regarding Opcode because new version of NASM tool(e.g. v2.15.05) supports the corresponding instructions. Note: This patch need to be merged after other NASM code change to avoid compilation errors. Signed-off-by: Jason Lou Cc: Michael D Kinney Reviewed-by: Liming Gao Cc: Zhiguang Liu commit 2aa107c0aa2e1375651867c8df1b81ff64b67fce Author: Jason Date: Mon Jan 10 22:01:18 2022 +0800 UefiCpuPkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Reviewed-by: Ray Ni Cc: Eric Dong Cc: Laszlo Ersek Cc: Rahul Kumar commit 7bc8b1d9f412507d579f21ea9af56fced81e7827 Author: Jason Date: Mon Jan 10 21:52:52 2022 +0800 SourceLevelDebugPkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Reviewed-by: Hao A Wu commit d3febfd9ade35dc552df6b3607c2b15d26b82867 Author: Jason Date: Mon Jan 10 21:46:27 2022 +0800 MdePkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Cc: Michael D Kinney Reviewed-by: Liming Gao Cc: Zhiguang Liu commit 84338c0d498555f860a480693ee8647a1795fba3 Author: Jason Date: Mon Jan 10 21:04:09 2022 +0800 MdeModulePkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Reviewed-by: Ray Ni Cc: Dandan Bi Reviewed-by: Liming Gao From xen-devel-bounces@lists.xenproject.org Wed Mar 02 10:34:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 10:34:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282185.480792 (Exim 4.92) (envelope-from ) id 1nPMJn-0001Nt-Bz; Wed, 02 Mar 2022 10:34:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282185.480792; Wed, 02 Mar 2022 10:34:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPMJn-0001Nm-8M; Wed, 02 Mar 2022 10:34:51 +0000 Received: by outflank-mailman (input) for mailman id 282185; Wed, 02 Mar 2022 10:34:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPMJm-0001Ng-Ae for xen-devel@lists.xenproject.org; Wed, 02 Mar 2022 10:34:50 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6282b247-9a14-11ec-8eba-a37418f5ba1a; Wed, 02 Mar 2022 11:34:48 +0100 (CET) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05lp2110.outbound.protection.outlook.com [104.47.17.110]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-40-conUHcwJOCa4Df_h8YlQlQ-1; Wed, 02 Mar 2022 11:34:47 +0100 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by DB7PR04MB4299.eurprd04.prod.outlook.com (2603:10a6:5:23::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.26; Wed, 2 Mar 2022 10:34:46 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5038.014; Wed, 2 Mar 2022 10:34:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6282b247-9a14-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1646217288; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dmtRXkNm8o6QvTiZB5cYk8DL7WcNj2rLA6YWCfutXt4=; b=Mc4R7d1W1+kzuXOBqBddO16lqDLs2OgCTnFNnj1EMycI6J/HGUblURHNL0owB1i8Q/wgLp mVGhB+KDuUKLJR6Q+dRwRxqKUIkgUuqG59JcW1zmo4wvtLm0D7k0GDaAG0ufVc0yHiQb+B JsbF+awrhKjz/ui5ThSic36otHigOEc= X-MC-Unique: conUHcwJOCa4Df_h8YlQlQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G0FZlPMbRNXySYYnbPD68a19cNjPiFKYwnq43HTwSENA11ZcQ5BU7i90ouFQuN5LoKmqj7tF1pkFAtqbjeBTRkVAbJs9n687yc3iL+JofhTBUW0vFNVzawJFtPHO/hu3bc7tPKY6MVvL2zmDnaBWJqAvE53kNkrGLRe96Fg0p617PYsgEEYzL5JIMSNk2RWxTw8uAYdu/rzsv7f51IFsdjCCXVA2WhI9sosenLAClXHtpyoHmY0jRKRSD4Yj+dkAKIIjlhBEpF29DLPoy6DPaCHgW+M7z3qNwxgdvbB4a0wTE/SvSDBfjZTnRkcnXo7jHk9+oPvMpTUfexLLxcb1sQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0Lf0OBWBxnjnxgVBYGzhfgzUzdicXERsBIsCzj8mHTw=; b=Wh0irMgyVHkj7m0gD6TL9G/OR98alJx0H/im0u9IdcBKx8jSEqJwSrk3JlIKLc5+1YredQYADVoShEFmSOhJB7KhhYr6/FJRISVMsj8QUU/tL96iTk6dsCbxuwV5kxultVLR7oldJbXWPfhbIrShQAy4d4+4dYPM2BKdWjWRyi/K3KxvQio/RYi8+yKYCx74vPcSkyr2Hi9eOQCZ/jp3A/oQThU7SjW8/wlzXKr61Qw57kPEdPyvCayQdPHAe8wQOqpHUavORjl7aBf6iHXCjd/05ThmCAO9cXGeI7RRvQObUt9keK33DKTPmhtnln02QaZfsEFyEE9Rjc+8W4EcAg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <67ff91f4-e5fe-47d5-fdb8-9a302beb6e2a@suse.com> Date: Wed, 2 Mar 2022 11:34:44 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH v2.2 8/7] x86/IOMMU: Use altcall, and __initconst_cf_clobber Content-Language: en-US To: Andrew Cooper CC: Roger Pau Monne , Wei Liu , Xen-devel References: <20220214125632.24563-1-andrew.cooper3@citrix.com> <20220222114711.19209-1-andrew.cooper3@citrix.com> <5fae516a-17c1-0ce4-c46e-909a83c0e273@citrix.com> <60f3c942-3822-87dd-df6e-8b64ed4d17c4@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM6P193CA0124.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:85::29) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b58e2113-41c5-4442-a05e-08d9fc384541 X-MS-TrafficTypeDiagnostic: DB7PR04MB4299:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ROkGjCv/3qqLgQzt/vfADxM/ZAKeL6a+QFddZLZqj9VlLo0UqjMi3tVpK9xqW5kXm3dRDdTErsX8aZF3s2Y3PbiE6EqL5Toq5iGEu6AlZ1BLrp1HO2y+CVhDU4Dm524RKb0soCl1ui4uvEP3lkb9HbE/N3b7v72CSFxYd1+FE/t1De8g/vzBx1x+hs641jkE7WEzPQAyQ+iJO0+OiZe82dwkEqBR+Kn7yHTJWoHMFrVJhlqRWuIIbQFsfErg9AonTK7XcVidbq2bRQ5LpDs3iwtenfkOLybnLltEVr56clhlPfPvjVmBlgoaIFzvwdwSt1MpMG7QFkllTSBi1YMlr3i9GlVsFFpHAISaa0V/5Ulv01YdMttioOOJ4+nhf+xrsu4r+a1lyr3ZXrRz9ZXiBtw9hMmw7+87H46whJjZwvevNP+/w+ZxiAQugCp9dnPptaePMJ1rHq16jWI0c2OncjU0YUHgsIdMAwrw051206tl1MXUmou28j7G+gFDS/N2AnrsDVi7vUyrb4j/Qc1V780Ro0g9kjH3qxNr90kMmr1hOEIqmQrMVEpdN7pAli53zgRCOOMnPcF6WUxr5XzzeSgYbZl4/aSiAEBs09DQDZIMoGqv9h3TfR8bK2LIjnSWl5PaVe1gOsE3FxRizNLq1dukl+ieb77MnfxmUBnKw5wyQ1Ah/xLqdQTeCsycnSnPU0woK8jlSYX8nB+N+ghbq37qXN7gnHqWo04YfyALbMpiGh2NOz3Wl5yaJPEFTbmm X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6916009)(508600001)(5660300002)(26005)(6486002)(86362001)(31696002)(54906003)(2906002)(36756003)(38100700002)(8936002)(2616005)(4326008)(8676002)(66946007)(66476007)(66556008)(186003)(83380400001)(53546011)(6506007)(6512007)(316002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?biXtyQKcZEQXs4+eImQ9jidNE2OmBpTMPQJLwe6PvlaLrSMcey3SpRd9FQUd?= =?us-ascii?Q?punwx0sRMT+YqzcZ6hcL36gTjWJODtHT1P+upW2rKRFS8QxpAB3acLC9ZtA8?= =?us-ascii?Q?BNUiv9WbtJDaVlCsjqSTra0k2241AZzqxwX5J5Yq8KoO2wqFBpFIMYRVEKkI?= =?us-ascii?Q?588YknxqrpqU5jM8BvO05E/gIPstlFRE14EXR+oG9tjDjABcow8ADlwJq9Ob?= =?us-ascii?Q?uFZISc4NNtT7MYm3T8y3uKauUJjqdQv6blhn5ZMnNRfsa3KxcZ/WHrTzYz73?= =?us-ascii?Q?WvPNzR0MADrIzIP76y0fo2F5/uax/uJtKI+q0q11r7MbSwrwkne1mIrwaWNr?= =?us-ascii?Q?P5kyINlEfIcmwHkD+CRXOccV07nrdGBLx2QxTxNczRxgzLuli6qqhFHOtnMm?= =?us-ascii?Q?izp+QzFrMf/4isJ3WlClIFgxdz3CbqhJlBRZ7+LeTRNbTtH4O4ZwIGfSArY3?= =?us-ascii?Q?0dVNsl8lAN+D6kfaP/3Oy7vBh4m7/Sfqn7NvFbnWS2XYIEN9q+yXeNynCGzR?= =?us-ascii?Q?VQWOpb+9LY+WKh7scY9Q0XRylGXx3R3/O9AG0L/rYPf7dq008ptMCWvCBLh0?= =?us-ascii?Q?w7frA9D6DTvfmARqCCARmxYXAD+yjgOHueGR4vOzGnID2Z7qjw+sLHIZpF9b?= =?us-ascii?Q?1p1sdDgtKGDXObu/FNQzv6aNY3i+hzdN/0pDtvS5cUKpIhKZf4Ic3wMNCQit?= =?us-ascii?Q?tv6Yd2bLokPb17kkprWTi31QZZjK4T9aWiZQWLRQaPMUZT/JIiuMVLAiCgQk?= =?us-ascii?Q?rcv3MkcVJYY+bbEp+tSLRikFxqur5fLCKtl38qXZa9QpW1OQx/ZhMXEEFr+p?= =?us-ascii?Q?dzWULiyrG2GerCgJzolA83U4WzjYCNIv/+9d9NcR1DAiiMT4izn4OzRQuTM8?= =?us-ascii?Q?r0XAhtDr519bp/sXRoAuOQ4WUERCU/kwALPrwofP95rYMNJRUauvLfODpeZs?= =?us-ascii?Q?fCmy/+a95v8DD//yHjeHKniO5JvTjshJA60YnSfYiVV6SWRdw9qwDaX/EfHl?= =?us-ascii?Q?OjTfO/zdMhP9Sa5TQuLjejOwseB81CYUBNT8rgVZ+SgW90xqVwRZuqWxHvN0?= =?us-ascii?Q?D4hNSNoLc7HHELW5bPwAj8R/ntTRcmwDnGgE6qJBtBlABRduTPQl3pkHH5Rc?= =?us-ascii?Q?JwVR8Ua/M+RtMeLRfumrxYvrFOfGVVw/iWsOuZFafzCJZ2AYNo8P0XDR9tDG?= =?us-ascii?Q?DDuZocFqH74uCvbTVHsMdUdUmHdlNhEuiSpK3Cndlwa01lmwibjXWv66LW+/?= =?us-ascii?Q?gfD9D1qxsMAvkP7kI8ou0fbomHWYfuY3XtrOyA411Qd1t8LrCo3NLmbyuHHZ?= =?us-ascii?Q?hpEddPvph7+XvmIvccb8q1/3IcbzU/hzDOVb0mkvsF3FrIgqhhor64RrR1pm?= =?us-ascii?Q?/0VeXnoPr2nFSfWB//qACxmlP3wzbTg8gUnpIq9DSS+yIG3Xgcd/o/2J+lxL?= =?us-ascii?Q?8nW6ilvNrCUm7q7XOL3GMjnk5pJEMC+rrc2aqfTq+LfE0YERIx0/YFw/nBlR?= =?us-ascii?Q?3RGAOxnq9pOccSeO9Z0IcWqio5EjWQ/z7tAlqb+vrAp+CkxlpChsHeWj9YHZ?= =?us-ascii?Q?1WzkfxSi/ii/2K4rCAbAf3dXN6/lJB3jRh7sTziBQszpdykejgfA7fGZKHSR?= =?us-ascii?Q?FIsg1yciZS1U2ypVmw+CLVA=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b58e2113-41c5-4442-a05e-08d9fc384541 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2022 10:34:46.2276 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5H/Y5hMAnz++Hc9G6rlrZwfwb3H9+CGIVCvIBDadSDorA8KRfn9TnsjECcSZfqaEjGGIpv84kqTw6jsbEAnw2A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4299 On 02.03.2022 11:12, Andrew Cooper wrote: > On 02/03/2022 08:10, Jan Beulich wrote: >> On 01.03.2022 15:58, Andrew Cooper wrote: >>> On 25/02/2022 08:24, Jan Beulich wrote: >>>> On 22.02.2022 12:47, Andrew Cooper wrote: >>>>> --- a/xen/drivers/passthrough/amd/pci_amd_iommu.c >>>>> +++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c >>>>> @@ -628,7 +628,7 @@ static void cf_check amd_dump_page_tables(struct = domain *d) >>>>> hd->arch.amd.paging_mode, 0, 0); >>>>> } >>>>> =20 >>>>> -static const struct iommu_ops __initconstrel _iommu_ops =3D { >>>>> +static const struct iommu_ops __initconst_cf_clobber _iommu_ops =3D = { >>>> Following my initcall related remark on x86'es time.c I'm afraid I don= 't >>>> see how this and ... >>>> >>>>> @@ -2794,7 +2793,7 @@ static int __init cf_check intel_iommu_quaranti= ne_init(struct domain *d) >>>>> return rc; >>>>> } >>>>> =20 >>>>> -static struct iommu_ops __initdata vtd_ops =3D { >>>>> +static const struct iommu_ops __initconst_cf_clobber vtd_ops =3D { >>>> ... this actually works. But I guess I must be overlooking something, = as >>>> I'm sure that you did test the change. >>>> >>>> Both ops structures reference a function, through .adjust_irq_affiniti= es, >>>> which isn't __init but which is used (besides here) for an initcall. W= ith >>>> the ENDBR removed by the time initcalls are run, these should cause #C= P. >>> This doesn't explode because the indirect calls are resolved to direct >>> calls before the ENDBR's are clobbered to NOP4. >> I'm afraid I don't understand: The problematic call is in do_initcalls()= : >> >> for ( call =3D __presmp_initcall_end; call < __initcall_end; call++ = ) >> (*call)(); >> >> I don't see how this could be converted to a direct call. >=20 > Oh.=C2=A0 iov_adjust_irq_affinities()'s double use is hiding here. >=20 > The safety rule for cf_clobber is that there must not be any > non-alt-called callers.=C2=A0 We need to fix it: >=20 > diff --git a/xen/drivers/passthrough/amd/iommu_init.c > b/xen/drivers/passthrough/amd/iommu_init.c > index 657c7f619a51..b1af5085efda 100644 > --- a/xen/drivers/passthrough/amd/iommu_init.c > +++ b/xen/drivers/passthrough/amd/iommu_init.c > @@ -831,7 +831,12 @@ int cf_check iov_adjust_irq_affinities(void) > =C2=A0 > =C2=A0=C2=A0=C2=A0=C2=A0 return 0; > =C2=A0} > -__initcall(iov_adjust_irq_affinities); > + > +int cf_check __init initcall_iov_adjust_irq_affinities(void) > +{ > +=C2=A0=C2=A0=C2=A0 return iommu_call(&iommu_ops, adjust_irq_affinities); > +} > +__initcall(initcall_iov_adjust_irq_affinities); > =C2=A0 > =C2=A0/* > =C2=A0 * Family15h Model 10h-1fh erratum 746 (IOMMU Logging May Stall > Translations) >=20 >=20 >> Afaics only pre-SMP initcalls are safe in this regard: do_presmp_initcal= ls() >> is called immediately ahead of alternative_branches(). >> >> Isn't this (previously?) working related to your "x86/spec-ctrl: Disable >> retpolines with CET-IBT"? >=20 > No.=C2=A0 It's because AMD CPUs don't have CET-IBT at this juncture, and = will > never encounter a faulting situation. I'm still lost. An exactly matching construct exists in VT-d code (and my initial comment also was on VT-d). The AMD one is actually a clone of that much older one. The initcall really wants to move to vendor independent code, but I'd still like to understand why no fault was ever observed. Jan From xen-devel-bounces@lists.xenproject.org Wed Mar 02 12:00:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 12:00:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282196.480809 (Exim 4.92) (envelope-from ) id 1nPNeW-0003um-Rk; Wed, 02 Mar 2022 12:00:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282196.480809; Wed, 02 Mar 2022 12:00:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPNeW-0003uf-Ol; Wed, 02 Mar 2022 12:00:20 +0000 Received: by outflank-mailman (input) for mailman id 282196; Wed, 02 Mar 2022 12:00:19 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPNeV-0003uT-Lu for xen-devel@lists.xenproject.org; Wed, 02 Mar 2022 12:00:19 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPNeV-0004SV-HR; Wed, 02 Mar 2022 12:00:19 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=[192.168.10.166]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nPNeV-0000K5-7o; Wed, 02 Mar 2022 12:00:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=YAS5UOQ8z3rEa1UpoVW7pu31r+dIUJh8yplNI6smjvg=; b=FREl4boX0BKuoZcSfqt7S71fre kBRjOFt9FJQ53MGR+XSBUxFafLRDv8ZhMtDqFtVd1Wu9nbF8wrBI2R6FVcCvUXAmeLJXGDXo/Bu9I gGQvGtnaQx8MT7l2UYXmWVIOuGr9/AgDERrG7ApQ/Rcl6tKA5FDHuhoTY8IlnQ2qDQzA=; Message-ID: <1f0bba54-158b-d171-6f99-0c29e0547f8a@xen.org> Date: Wed, 2 Mar 2022 12:00:17 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: Proposal for Porting Xen to Armv8-R64 - DraftA To: Wei Chen , "xen-devel@lists.xenproject.org" , Stefano Stabellini Cc: Bertrand Marquis , Penny Zheng , Henry Wang , nd References: <04db7e8b-2f04-41d7-1deb-d8bda3625c04@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 01/03/2022 07:51, Wei Chen wrote: > Hi Julien, Hi Wei, >> -----Original Message----- >> From: Julien Grall >> Sent: 2022年2月26日 4:55 >> To: Wei Chen ; xen-devel@lists.xenproject.org; Stefano >> Stabellini >> Cc: Bertrand Marquis ; Penny Zheng >> ; Henry Wang ; nd >> Subject: Re: Proposal for Porting Xen to Armv8-R64 - DraftA >>> ### 1.2. Xen Challenges with PMSA Virtualization >>> Xen is PMSA unaware Type-1 Hypervisor, it will need modifications to run >>> with an MPU and host multiple guest OSes. >>> >>> - No MMU at EL2: >>> - No EL2 Stage 1 address translation >>> - Xen provides fixed ARM64 virtual memory layout as basis of >> EL2 >>> stage 1 address translation, which is not applicable on MPU >> system, >>> where there is no virtual addressing. As a result, any >> operation >>> involving transition from PA to VA, like ioremap, needs >> modification >>> on MPU system. >>> - Xen's run-time addresses are the same as the link time addresses. >>> - Enable PIC (position-independent code) on a real-time target >>> processor probably very rare. >> >> Aside the assembly boot code and UEFI stub, Xen already runs at the same >> address as it was linked. >> > > But the difference is that, base on MMU, we can use the same link address > for all platforms. But on MPU system, we can't do it in the same way. I agree that we currently use the same link address for all the platforms. But this is also a problem when using MMU because EL2 has a single TTBR. At the moment we are switching page-tables with the MMU which is not safe. Instead we need to turn out the MMU off, switch page-tables and then turn on the MMU. This means we need to have an identity mapping of Xen in the page-tables. Assuming Xen is not relocated, the identity mapping may clash with Xen (or the rest of the virtual address map). My initial idea was to enable PIC and update the relocation at boot time. But this is a bit cumbersome to do. So now I am looking to have a semi-dynamic virtual layout and find some place to relocate part of Xen to use for CPU bring-up. Anyway, my point is we possibly could look at PIC if that could allow generic Xen image. >>> - Xen will need to use the EL2 MPU memory region descriptors to >> manage >>> access permissions and attributes for accesses made by VMs at >> EL1/0. >>> - Xen currently relies on MMU EL1 stage 2 table to manage these >>> accesses. >>> - No MMU Stage 2 translation at EL1: >>> - A guest doesn't have an independent guest physical address space >>> - A guest can not reuse the current Intermediate Physical Address >>> memory layout >>> - A guest uses physical addresses to access memory and devices >>> - The MPU at EL2 manages EL1 stage 2 access permissions and >> attributes >>> - There are a limited number of MPU protection regions at both EL2 and >> EL1: >>> - Architecturally, the maximum number of protection regions is 256, >>> typical implementations have 32. >>> - By contrast, Xen does not need to consider the number of page >> table >>> entries in theory when using MMU. >>> - The MPU protection regions at EL2 need to be shared between the >> hypervisor >>> and the guest stage 2. >>> - Requires careful consideration - may impact feature 'fullness' of >> both >>> the hypervisor and the guest >>> - By contrast, when using MMU, Xen has standalone P2M table for >> guest >>> stage 2 accesses. >> >> [...] >> >>> - ***Define new system registers for compilers***: >>> Armv8-R64 is based on Armv8.4. That means we will use some Armv8.4 >>> specific system registers. As Armv8-R64 only have secure state, so >>> at least, `VSTCR_EL2` and `VSCTLR_EL2` will be used for Xen. And the >>> first GCC version that supports Armv8.4 is GCC 8.1. In addition to >>> these, PMSA of Armv8-R64 introduced lots of MPU related system >> registers: >>> `PRBAR_ELx`, `PRBARx_ELx`, `PRLAR_ELx`, `PRLARx_ELx`, `PRENR_ELx` and >>> `MPUIR_ELx`. But the first GCC version to support these system >> registers >>> is GCC 11. So we have two ways to make compilers to work properly >> with >>> these system registers. >>> 1. Bump GCC version to GCC 11. >>> The pros of this method is that, we don't need to encode these >>> system registers in macros by ourselves. But the cons are that, >>> we have to update Makefiles to support GCC 11 for Armv8-R64. >>> 1.1. Check the GCC version 11 for Armv8-R64. >>> 1.2. Add march=armv8r to CFLAGS for Armv8-R64. >>> 1.3. Solve the confliction of march=armv8r and mcpu=generic >>> These changes will affect common Makefiles, not only Arm Makefiles. >>> And GCC 11 is new, lots of toolchains and Distro haven't supported >> it. >> >> I agree that forcing to use GCC11 is not a good idea. But I am not sure >> to understand the problem with the -march=.... Ultimately, shouldn't we >> aim to build Xen ARMv8-R with -march=armv8r? >> > > Actually, we had done, but we reverted it from RFC patch series. The reason > has been listed above. But that is not the major reason. The main reason > is that: > Armv8-R AArch64 supports the A64 ISA instruction set with some modifications: > Redefines DMB, DSB, and adds an DFB. But actually, the encodings of DMB and > DSB are still the same with A64. And DFB is a alias of DSB #12. > > In this case, we don't think we need a new arch flag to generate new > instructions for Armv8-R. And we have discussed with Arm kernel guys, they > will not update the build system to build Linux that will be running on > Armv8-R64 EL1 either. Good to know that the kernel folks plan to do the same. Thanks for the explanation! > > >> [...] >> >>> ### **2.2. Changes of the initialization process** >>> In general, we still expect Armv8-R64 and Armv8-A64 to have a consistent >>> initialization process. In addition to some architecture differences, >> there >>> is no more than reusable code that we will distinguish through >> CONFIG_ARM_MPU >>> or CONFIG_ARM64_V8R. We want most of the initialization code to be >> reusable >>> between Armv8-R64 and Armv8-A64. >>> >>> - We will reuse the original head.s and setup.c of Arm. But replace the >>> MMU and page table operations in these files with configuration >> operations >>> for MPU and MPU regions. >>> >>> - We provide a boot-time MPU configuration. This MPU configuration will >>> support Xen to finish its initialization. And this boot-time MPU >>> configuration will record the memory regions that will be parsed from >>> device tree. >>> >>> In the end of Xen initialization, we will use a runtime MPU >> configuration >>> to replace boot-time MPU configuration. The runtime MPU configuration >> will >>> merge and reorder memory regions to save more MPU regions for guests. >>> ![img](https://drive.google.com/uc?export=view&id=1wTFyK2XfU3lTlH1PqR >> DoacQVTwUtWIGU) >>> >>> - Defer system unpausing domain. >>> When Xen initialization is about to end, Xen unpause guests created >>> during initialization. But this will cause some issues. The unpause >>> action occurs before free_init_memory, however the runtime MPU >> configuration >>> is built after free_init_memory. >> >> I was half expecting that free_init_memory() would not be called for Xen >> Armv8R. >> > > We had called free_init_memory for Xen Armv8R, but it doesn't really mean > much. As we have static heap, so we don't reclaim init memory to heap. And > this reclaimed memory could not be used by Xen data and bss either. But > from the security perspective, free_init_memory will drop the Xen init > code & data, this will reduce the code an attacker can exploit. IIUC, zero-ing the region (or something) similar will be sufficient here. IOW, you don't necessarily need to remove the mappings. >>> >>> So if the unpaused guests start executing the context switch at this >>> point, then its MPU context will base on the boot-time MPU >> configuration. >> >> Can you explain why you want to switch the MPU configuration that late? >> > > In the boot stage, Xen is the only user of MPU. It may add some memory > nodes or device memory to MPU regions for temporary usage. After free > init memory, we want to reclaim these MPU regions to give more MPU regions > can be used for guests. Also we will do some merge and reorder work. This > work can make MPU regions to be easier managed in guest context switch. Do you have any example of such regions? > >>> Probably it will be inconsistent with runtime MPU configuration, this >>> will cause unexpected problems (This may not happen in a single core >>> system, but on SMP systems, this problem is foreseeable, so we hope >> to >>> solve it at the beginning). >> >> [...] >> >>> ### **2.4. Changes of memory management** >>> Xen is coupled with VMSA, in order to port Xen to Armv8-R64, we have to >>> decouple Xen from VMSA. And give Xen the ability to manage memory in >> PMSA. >>> >>> 1. ***Use buddy allocator to manage physical pages for PMSA*** >>> From the view of physical page, PMSA and VMSA don't have any >> difference. >>> So we can reuse buddy allocator on Armv8-R64 to manage physical >> pages. >>> The difference is that, in VMSA, Xen will map allocated pages to >> virtual >>> addresses. But in PMSA, Xen just convert the pages to physical >> address. >>> >>> 2. ***Can not use virtual address for memory management*** >>> As Armv8-R64 only has PMSA in EL2, Xen loses the ability of using >> virtual >>> address to manage memory. This brings some problems, some virtual >> address >>> based features could not work well on Armv8-R64, like `FIXMAP`, >> `vmap/vumap`, >>> `ioremap` and `alternative`. >>> >>> But the functions or macros of these features are used in lots of >> common >>> code. So it's not good to use `#ifdef CONFIG_ARM_MPU` to gate relate >> code >>> everywhere. In this case, we propose to use stub helpers to make the >> changes >>> transparently to common code. >>> 1. For `FIXMAP`, we will use `0` in `FIXMAP_ADDR` for all fixmap >> operations. >>> This will return physical address directly of fixmapped item. >>> 2. For `vmap/vumap`, we will use some empty inline stub helpers: >>> ``` >>> static inline void vm_init_type(...) {} >>> static inline void *__vmap(...) >>> { >>> return NULL; >>> } >>> static inline void vunmap(const void *va) {} >>> static inline void *vmalloc(size_t size) >>> { >>> return NULL; >>> } >>> static inline void *vmalloc_xen(size_t size) >>> { >>> return NULL; >>> } >>> static inline void vfree(void *va) {} >>> ``` >>> >>> 3. For `ioremap`, it depends on `vmap`. As we have make `vmap` to >> always >>> return `NULL`, they could not work well on Armv8-R64 without >> changes. >>> `ioremap` will return input address directly. >>> ``` >>> static inline void *ioremap_attr(...) >>> { >>> /* We don't have the ability to change input PA cache >> attributes */ >> OOI, who will set them? > > Some callers that want to change a memory's attribute will set them. Something like > ioremap_nocache. I am not sure is this what you had asked : ) I am a bit confused. If ioremap_nocache() can change the attribute, then why would ioremap_attr() not be able to do it? > >> >>> if ( CACHE_ATTR_need_change ) >>> return NULL; >>> return (void *)pa; >>> } >>> static inline void __iomem *ioremap_nocache(...) >>> { >>> return ioremap_attr(start, len, PAGE_HYPERVISOR_NOCACHE); >>> } >>> static inline void __iomem *ioremap_cache(...) >>> { >>> return ioremap_attr(start, len, PAGE_HYPERVISOR); >>> } >>> static inline void __iomem *ioremap_wc(...) >>> { >>> return ioremap_attr(start, len, PAGE_HYPERVISOR_WC); >>> } >>> void *ioremap(...) >>> { >>> return ioremap_attr(pa, len, PAGE_HYPERVISOR_NOCACHE); >>> } >>> >>> ``` >>> 4. For `alternative`, it depends on `vmap` too. >> >> The only reason we depend on vmap() is because the map the sections >> *text read-only and we enforce WnX. For VMSA, it would be possible to >> avoid vmap() with some rework. I don't know for PMSA. >> > > For PMSA, we still enforce WnX. For your use case, I assume it's alternative. > It still may have some possibility to avoid vmap(). But there may be some > security issues. We had thought to disable MPU -> update xen text -> enable > MPU to copy VMSA alternative's behavior. The problem with this, however, > is that at some point, all memory is RWX. There maybe some security risk. > But because it's in init stage, it probably doesn't matter as much as I thought. For boot code, we need to ensure the code is compliant to the Arm Arm. Other than that, it is OK to have the memory RWX for a short period of time. In fact, when we originally boot Xen, we don't enforce WnX. We will start to enforce when initializing the memory. But there are no blocker to delay it (other than writing the code :)). Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Mar 02 12:06:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 12:06:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282205.480821 (Exim 4.92) (envelope-from ) id 1nPNk6-0004c6-Gi; Wed, 02 Mar 2022 12:06:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282205.480821; Wed, 02 Mar 2022 12:06:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPNk6-0004bz-Bi; Wed, 02 Mar 2022 12:06:06 +0000 Received: by outflank-mailman (input) for mailman id 282205; Wed, 02 Mar 2022 12:06:04 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPNk4-0004br-5V for xen-devel@lists.xenproject.org; Wed, 02 Mar 2022 12:06:04 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPNk3-0004YF-UH; Wed, 02 Mar 2022 12:06:03 +0000 Received: from 54-240-197-224.amazon.com ([54.240.197.224] helo=[192.168.10.166]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nPNk3-0000nK-Ob; Wed, 02 Mar 2022 12:06:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=EZTvUrI4SHfZq+qVhAYlWXuSyOijr38hSdYkgsbLe2Y=; b=xRm3kzE2FzQrxrYg4xtUcV/yqb BPA1JqbzqAqjBVDkx02v0dY/4AqDhnSNeAPf4APksTLNyH7K+0RpH4coTGAhI3ghiPbmLhVT6avUX sRnZvCzS8y7X5KfNuqKkDcsigK4VRddwHghLP2ZsU9q20zR4k0gBi8aVUKeFFx2YXq5Y=; Message-ID: <8b24027f-b659-098b-6faa-3591621fa0a1@xen.org> Date: Wed, 2 Mar 2022 12:06:01 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: Proposal for Porting Xen to Armv8-R64 - DraftA To: Penny Zheng , Wei Chen , "xen-devel@lists.xenproject.org" , Stefano Stabellini Cc: Bertrand Marquis , Henry Wang , nd References: <04db7e8b-2f04-41d7-1deb-d8bda3625c04@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 02/03/2022 07:21, Penny Zheng wrote: > Hi julien Hi Penny, >>>> >>>> So if the unpaused guests start executing the context switch at this >>>> point, then its MPU context will base on the boot-time MPU >>> configuration. >>> >>> Can you explain why you want to switch the MPU configuration that late? >>> >> > > It is more related to the implementation. > > In the boot stage, we allocate MPU regions in sequence until the max. > Since a few MPU region will get removed along the way, it leaves hole there. > Such like when heap is ready, fdt will be reallocated in the heap, which means the > MPU region for device tree is in no need. And also in free_init_memory, although we > do not give back init memory to the heap, we will also destroy according MPU > regions to make them inaccessible. > Without ordering, we need a bitmap to record such information. > > In context switch, the memory layout is quite different for guest mode and > hypervisor mode. When switching to guest mode, only guest RAM, emulated/passthrough > devices, etc could be seen, but in hypervisor mode, all guests RAM and device memory > shall be seen. And without reordering, we need to iterate all MPU regions to find > according regions to disable during runtime context switch, that's definitely a overhead. > > So we propose an ordering at the tail of the boot time, to put all fixed MPU region > in the head, like xen text/data, etc, and put all flexible ones at tail, like device memory, > guests RAM. > Then later in context switch, we could easily just disable ones from tail and inserts new > ones in the tail. Thank you for the clarification. This makes sense to me. I would suggest to update the proposal to reflect this decision. >> For PMSA, we still enforce WnX. For your use case, I assume it's alternative. >> It still may have some possibility to avoid vmap(). But there may be some >> security issues. We had thought to disable MPU -> update xen text -> enable >> MPU to copy VMSA alternative's behavior. The problem with this, however, >> is that at some point, all memory is RWX. There maybe some security risk. >> But because it's in init stage, it probably doesn't matter as much as I thought. >> > > In MMU system, we use vmap() to change requested xen text codes(a few lines) temporarily > to RW to apply the alternative codes, the granularity for it could be 4KB. > > But on MPU system, we give the whole XEN text code a MPU region, so otherwise we disable > the whole MPU to make it happen, which leads to a little risk for running c codes where MPU > disabled, or all text memory becoming RWX at this alternative time. See my answer to Wei. So long the code is compliant with the Arm Arm, it would be acceptable to have boot code running with RWX for a short period of time. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Mar 02 13:16:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 13:16:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282215.480840 (Exim 4.92) (envelope-from ) id 1nPOq0-0004zu-Ro; Wed, 02 Mar 2022 13:16:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282215.480840; Wed, 02 Mar 2022 13:16:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPOq0-0004zn-O0; Wed, 02 Mar 2022 13:16:16 +0000 Received: by outflank-mailman (input) for mailman id 282215; Wed, 02 Mar 2022 13:16:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPOpy-0004zh-I2 for xen-devel@lists.xenproject.org; Wed, 02 Mar 2022 13:16:15 +0000 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ed745b61-9a2a-11ec-8eba-a37418f5ba1a; Wed, 02 Mar 2022 14:16:11 +0100 (CET) Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 222CTDQM017661; Wed, 2 Mar 2022 13:15:15 GMT Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by mx0b-00069f02.pphosted.com with ESMTP id 3eh15anmgj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 02 Mar 2022 13:15:14 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 222Cq3wi138590; Wed, 2 Mar 2022 13:15:13 GMT Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2102.outbound.protection.outlook.com [104.47.58.102]) by userp3030.oracle.com with ESMTP id 3ef9b0vcbr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 02 Mar 2022 13:15:13 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) by SJ0PR10MB5533.namprd10.prod.outlook.com (2603:10b6:a03:3f7::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.14; Wed, 2 Mar 2022 13:15:10 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::6d20:6694:a16:56f7]) by BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::6d20:6694:a16:56f7%3]) with mapi id 15.20.5038.015; Wed, 2 Mar 2022 13:15:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ed745b61-9a2a-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=+H8jEbxRAjH5LJGh19NFnoJv1mnvS0Fd8stoMxTA0w0=; b=sGVPTxIXrSbagJ6ynSSDe816afmmTUjiMiZbnKewSSIpJkSoge6xG7EHhHCPgSidbgpG vy9fLOYAgrIbJlZ3WThbY1UyLw86tr1NTwwQLU/Q6GjO/6jXhqTH2Kk2QEAWSPWZc7pr DYAxABYfQCSLm9dGK5z+vOyKao+ColXnRe/UK1m7SVW5y1IwfBa1C8uzi4ohVaRmNQaD CEMNz8tJ1tpqvReQOy1MQbD8DBrk5UIw68/+c+i2mQOYkO0EcMh83nN2Ka2Joys2rDmU IsHaqAW1Z4liia9hOoIRI8ScirCJ9XYd5PcFmZUhfN8u0pPRmKUUgno+cCLigFz2k/yB GQ== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kgHvmPUaOKjmTgFDRNyH2JK/nxIxKkD4elHWKwQzktzYLmilMNAijcf33DQQKQboEe07+iBVmL1MGbCLbJZlx3aZXjtbwmFKEoACvzg8YbahcPIE7FxRitBNV+KiWD34U7mYc5clIeXbd9rWfC8ESwhp9s9lbwKIrf8Y6OJ6IRXs566pG2Lsm5mhhsSCpLnEhUTD5vE/5IHLNdArFBlxN097/VAVLhnsR7wqfanCDgr8hU1dlCaZfeJIgOn06RHOqqoct/IJ89PUSA+7xbHF5NIgjdRJU3eyJzapVGbiI9ZIWp3almvhuQy5CTVIPO7S0IhGeFwMYTlKkaaCd0TcNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+H8jEbxRAjH5LJGh19NFnoJv1mnvS0Fd8stoMxTA0w0=; b=YamrgLVX9B/qDq9QzF6II8wlZNthJKbW5iq53COtqYiKrf0HrhczdS3GUOwEHGNuw1wuUXG09BDIRYnB+Rx+5/RfiVASEFCd0JFbNPnPDJtHTEkZzT9fdnQHIUKTA86ouTSqUS7MxVFXQrpCMcUOLCujcX/uKEAbYbZ8fNrtZpUAzVKBXSmcCZNzPoqZelLCVA6se8VX7b0y8Y95bZz+ycb3+82QmPMqtQoTtOdrAI39CoABSuXcfLpcDBW9Ojbiovsz5qyACOrqLkmrWEscr+0V2slJMTUWMb/1R1gdfDs89mwQYFyJO4WY74wYO5ARLaztGM8UpRhz0zvBwWYMJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+H8jEbxRAjH5LJGh19NFnoJv1mnvS0Fd8stoMxTA0w0=; b=xWpNRvFCMKQ+b7r+RN5bpz74Dv63CfBbIf5apoeBrlba9WYOtJvPEmZt911JQ/HoMTtAaZamyB/xb5VID0ghzq7PaGjs4cx1ivaDw6RjirQaH8PPg6U1qBuygmIv0TK/8eMScWB9rcnmB4/nQAEbGkhtkaGRvmlhTgOQwjmHveE= Message-ID: Date: Wed, 2 Mar 2022 08:15:03 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH 11/12] swiotlb: merge swiotlb-xen initialization into swiotlb Content-Language: en-US To: Stefano Stabellini , Christoph Hellwig Cc: iommu@lists.linux-foundation.org, x86@kernel.org, Anshuman Khandual , Tom Lendacky , Konrad Rzeszutek Wilk , Juergen Gross , Joerg Roedel , David Woodhouse , Lu Baolu , Robin Murphy , linux-arm-kernel@lists.infradead.org, xen-devel@lists.xenproject.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-hyperv@vger.kernel.org, tboot-devel@lists.sourceforge.net, linux-pci@vger.kernel.org References: <20220301105311.885699-1-hch@lst.de> <20220301105311.885699-12-hch@lst.de> From: Boris Ostrovsky In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BY5PR03CA0004.namprd03.prod.outlook.com (2603:10b6:a03:1e0::14) To BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 57f1c317-ff3a-4cac-829f-08d9fc4eadcf X-MS-TrafficTypeDiagnostic: SJ0PR10MB5533:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4KJwB9SxCqeLlNQ1Y5kvptorXPIyjzEcwrSw5cMQq4WMGQJNjONg5U4YwqywH3QNElFsQyzE9fDKUvmAFN9eU9jHUA09tJ03eaOHSVl8fLNVzzvhsHDfrk+Xz3sR1h+HGXY7EGF2FS/kILknpvbJavcAcm0nh1qQPE2x/vR/bK8/JlJTPfmDN5FA41H1UBElCjyklbo47P9mqTmvsf2/hZHdelU/U54wobNjybfIYwGOg2BTmP6L9TbRgk6lVBA6cPciiQURffcd0BfHVUIjRwl0TVykSnQ4SKortEMCHF/zt20qc4HUImJQmHhESafU7+m22MUWi3xdzmE2lu9tAl2rtsd6qEPf/JOdO537yBgqeImvORAOz4c0wP23wFtJID/9GR7oGbEPpmDba0G8ulotrUaFlaxvbU4CP8zoOsS74WsUfxYZL1xtNV8g3T4WcXEDz7Fd7MinctXAi8zLZMT5dKQlub7eZoUyqeqXiQJJN+XoVJWG/9zXONQEi544F4OJQFgRtrrckNdgSMcmM+kQH9vSb819Vxw7Q3I86ljT3ZBGezuYvE0zIKvjGdCCLp4CDtBVuy2wRH01e19ig5eQmgH8JHco5Kow6kb6x2+dS6lIJcK1yq6SDCA6crwtD5RnEKTQ9gC+c33149RAVdmASQLiimsze/lwtVAUzn4GUOah0nDN9AoH2Aj5iEt9pVIAB1qD8mkLf39IQt/CioRbyUd9Gf9FVpiCD272Ipk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(26005)(186003)(110136005)(6512007)(53546011)(2906002)(6506007)(2616005)(86362001)(38100700002)(31696002)(54906003)(6666004)(44832011)(4744005)(4326008)(5660300002)(31686004)(8936002)(508600001)(36756003)(6486002)(66556008)(66946007)(66476007)(316002)(7416002)(8676002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Vk03Vk5LOC9NN29RTmV1SStZYWVzYlVVWlhEQ2loT1ZKQmhJZzRRYW42SlUr?= =?utf-8?B?elAzemVjcjJrMS9qN3ZwQ0o1bzhKTUM3a0hoVDZHL0x2c25yQ3g0cXFxeVhl?= =?utf-8?B?c0NSWHlrTkh6NUY2MWNmSFlKOEtqSUNuMENzcnA3QkdlYi9ydjJpazk1SGxW?= =?utf-8?B?dlFKQkYxUW9jRmVhMU9CRHlVaXQ4MG9hZ2pVbWZwQjdNTERBTWNzSTFkbjVX?= =?utf-8?B?bk1rTTZBOEwrb01HUjhWUThTUC9SMjVJalNXblFWUmZzSlBpbHZJVnpLNHFM?= =?utf-8?B?bWJpWkVYNnl1Mkp0cmozUlBrQUhlQnNjTFFrMXJzZHo0ZU1BSkhCTVpjTGFN?= =?utf-8?B?ZFZRN25QaGFWZGVTeG5vVjJ4TVc4dmtyR0d2eXdLTXd6TDRtNHliN0dwbFBG?= =?utf-8?B?d2pKTnczRlQrV0NRMSt1Q1dySjI3SzZMK21pOUJVUG5SL1IrVkc4NCtmdFBC?= =?utf-8?B?TnBsMzFqZFh5K25xTUx0RW9NSmhrK1N2RDh0L282a2VNYzdYWnJtZFA2RzJL?= =?utf-8?B?K2hFWklHZURBMEdhMkVuWEw0ZFFyMUhqL2JRMzcwNzY2SlJ5VnBDcG5QeC9x?= =?utf-8?B?ZjFnRmY0dWUzZ0RmRk5XTUhnTW1yNWh3RERvUUw2TWRQc0NuaTFFdTJnclYz?= =?utf-8?B?Slo5WXNreWFaa1ZHM3RjOE5WWEFreVJMRzI5NTNlQTZRTEhISElMSEdRWnBa?= =?utf-8?B?dG9kN1NtcVVqaDJOUFcwNXVNS1pXOVZrTC9SZjBuMVJXVjBtMXZ2Nm5GcFZa?= =?utf-8?B?Z3RSb24zSTYzbm1UcjFWcW9wWlpxVWx6b3lxbUhvdE1SVkIxNnpjU29PS25D?= =?utf-8?B?d0VKdmlEOWRCTitQbVRXZ3FMTGxNQTZPTlJFOU10RndzelFnV011UStBbTJ6?= =?utf-8?B?bHErWEh6VlZMUFJRWnV2QnBwc2pJTmZsWHNLdWxiNUFuV2w4UHZxQkFIOEpS?= =?utf-8?B?aW1WODBsd1pGRis2bUd1R1RZTy95b2hrUktmais2eUNXS3BpSUh0aW5MWkFK?= =?utf-8?B?K0svR2xpMzNvdTN0RnVFdDE4bFRSNXpPTDdUODlDVXBaaGdFaWV5aXdPTWVE?= =?utf-8?B?Vkk4NzlsdG5PU05MVnN1T2pnZnJJaU1QeVFYT01DTTBBT3hqQW5KaWpQQ0pX?= =?utf-8?B?M2kyNzczdEk0QTVIK0pkK25JZnp5Tjc1QWo4SHhQeU93QnFLR3kyQVpqN3Uv?= =?utf-8?B?N1RQbTluYWVXcWhLK0JEWHo0UStoSmtOdTJlMnFkM01sbDAwdFYxSFdVQTRo?= =?utf-8?B?MkcreEFJbFZmNjRUdWhRTVFyTjA3aFR3Z1FkZ3dRcDh3L2VyUlRUZ2ZFYWtv?= =?utf-8?B?RmxiRU02bTRPMzI0V2R0RVorU0VhOGVZY1E1K2twWXlIdTFXeFZ5RFowbEZm?= =?utf-8?B?dTZnUC9XTFdHUUNBbTdEaUowYmJzSXBEZ20vSWVHdnhqWWIyOFZ5WFZFeDhs?= =?utf-8?B?NXFueXdWUGdkRzFxblRjK01nb3FOYnl0K0VMVGpUYkVRclNrM29zc3Y4eE16?= =?utf-8?B?YjNJKzBxTTZQa2ZDMWlyMEVzejVqaEhuQTBBVnVVZ0VVdmJJdXJqTmwvem9P?= =?utf-8?B?Wk83YVl2QmJYZk9YTVZWY2NlV0l0YThCd09Wb1ZYVlR5MjhaRytKcWlnUDNF?= =?utf-8?B?eHAyays0TC9TVm1Pa2FUdTZMaXNJS2FSSnhpYmFrbjlzaWNlQjVPWkoxdEto?= =?utf-8?B?b0RSRElHRnBCTlRydURXamJ0TTZzajI4OGRrc0FySStPVnRMUEtRdkRNVUIv?= =?utf-8?B?OWQvK1ZnNDRFVXEwdy9vRFFIb04xeU9RS2YrZUVZRWNSSFZSN1h4RVdHamli?= =?utf-8?B?cUkwQkxaeGUxT0g4Y3NyNDM2RkJsYTdHbEZ0d3lXUkgySkdMRC94YzhRT1A1?= =?utf-8?B?YWNuVHRTbWhOcjdIUmExckxtdnlIUmpZTmJGWTdjYnJVR3czMGp5ZE9qdlgw?= =?utf-8?B?YTV2d0EybXA2MWhTbHFlMDhvWCtOR1ZaV29tN2NuRXo3LzBlYUsvams5dUU0?= =?utf-8?B?Y3hUblIxeDN0cGlKaW9XY3ZUd0VNZmh3NTRoMUJkY29tTHZPTzNsbEh3OUpM?= =?utf-8?B?MUtERHBla3ZnNjdlWit0K0VzSjJUM3NUNkpwTndXVXA0K3ArNVdESWFnU1BW?= =?utf-8?B?Z1J0T0QvQll0OXFNa091cWo5cmkwQlFCaHBrYTVBSWlvZXZ0UldodnNtMlB5?= =?utf-8?B?bm16bUorTE9zbWxjOEpjYWdGWTZSUm5yc25nK2dnUHEyb2lpMGN1RGdqUUdT?= =?utf-8?B?SEdyWHl2Y2NqN0kyT0U3T1lKcXFRPT0=?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 57f1c317-ff3a-4cac-829f-08d9fc4eadcf X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2022 13:15:10.5529 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: i9IIOBKc6c6QhVKe/5bkfbkaWQSPhPm6GmdCCxj3k9wSiUgOSXNzz6y0YmKoKAg4JLcdXQJpLOfjRQSt7BY9UBTEuprmMHXnOSm3nRiKsCA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB5533 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10273 signatures=685966 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 malwarescore=0 mlxscore=0 phishscore=0 suspectscore=0 adultscore=0 mlxlogscore=939 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000 definitions=main-2203020056 X-Proofpoint-ORIG-GUID: G0FxjF5OpEILlkZGoBX3aG3B-oBasDld X-Proofpoint-GUID: G0FxjF5OpEILlkZGoBX3aG3B-oBasDld On 3/1/22 9:55 PM, Stefano Stabellini wrote: > On Tue, 1 Mar 2022, Christoph Hellwig wrote: >> Allow to pass a remap argument to the swiotlb initialization functions >> to handle the Xen/x86 remap case. ARM/ARM64 never did any remapping >> from xen_swiotlb_fixup, so we don't even need that quirk. >> > Aside from that the rest looks OK. Also, you can add my: > > Tested-by: Stefano Stabellini Not for me, I fail to boot with [ 52.202000] bnxt_en 0000:31:00.0: swiotlb buffer is full (sz: 256 bytes), total 0 (slots), used 0 (slots) (this is iscsi root so I need the NIC). I bisected it to "x86: remove the IOMMU table infrastructure" but haven't actually looked at the code yet. -boris From xen-devel-bounces@lists.xenproject.org Wed Mar 02 13:18:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 13:18:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282224.480851 (Exim 4.92) (envelope-from ) id 1nPOsV-0005eJ-Ce; Wed, 02 Mar 2022 13:18:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282224.480851; Wed, 02 Mar 2022 13:18:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPOsV-0005eC-9V; Wed, 02 Mar 2022 13:18:51 +0000 Received: by outflank-mailman (input) for mailman id 282224; Wed, 02 Mar 2022 13:18:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPOsU-0005e0-4Q for xen-devel@lists.xenproject.org; Wed, 02 Mar 2022 13:18:50 +0000 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4b422ab8-9a2b-11ec-8539-5f4723681683; Wed, 02 Mar 2022 14:18:48 +0100 (CET) Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 222CSxWF018990; Wed, 2 Mar 2022 13:18:03 GMT Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by mx0b-00069f02.pphosted.com with ESMTP id 3ehbk9caq2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 02 Mar 2022 13:18:03 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 222DFgBL188140; Wed, 2 Mar 2022 13:18:02 GMT Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2100.outbound.protection.outlook.com [104.47.55.100]) by userp3020.oracle.com with ESMTP id 3efdnq830r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 02 Mar 2022 13:18:01 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) by SJ0PR10MB4638.namprd10.prod.outlook.com (2603:10b6:a03:2d8::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.14; Wed, 2 Mar 2022 13:17:58 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::6d20:6694:a16:56f7]) by BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::6d20:6694:a16:56f7%3]) with mapi id 15.20.5038.015; Wed, 2 Mar 2022 13:17:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4b422ab8-9a2b-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : from : to : cc : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=h5AZWSbOc0KTtdyh9+8qxRvai+pDBFNH4HZ/HB6BAL8=; b=KUOkXno7EkApM+0MHqwg6YyVzbCFkMbXsXDKyf+Naqjirx33GLBEo6wxDrjZZOOg1oju 9htM+YCJ3eRng9MJHRxpeyBkoiZTl3aniVdrIk/OoEYBaQ+YonxY2PTtWIrmxED6moO5 jpvkkwlgJtm+ZMZzzxgF+tlBKtT+ee621OLcQUbxjlSnevSXRQ9+dkgw12tA9rgcZz3/ GLJch7DX6s3rADXLrcG6akxTsqPDJs/jKpaDeOzTCRb/dLU9rkCQ1jgAhkvYZNBBv51K h90WaBvLAHqhRQYxacK1aypIrTdqsE+F5+mRVKXi+yPC74AbkbOfsGdhIjoM9A/IMSdd 0A== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IqAhL5bqplMBWx1mtMp+PbbkOInJYc9I0Mu6ioVV0Rb11tGzAAmQt4tOOdBrtFfVXdNdvN0cndLJHXYlmOpdce72qRgfSkX9OFWpv3fbaDcE7EjjOqalzGWezrevkEj6jEdA+nFuyumWvEag7w2iiopuGaUzHVuHE/gonC14vOTi12uvT+SrmGIeInDBn8zlwQUXgZ3dfGdk4pH34jBDmmV6Xah0kxC//zUA9peoECc68ze4zGXCFgWsPPYRdgTsb8G6Krf6fEVFArsbzMaueHBcbZQT7AUa3W9trUj5LlJp+VSWheX1A4UzGR7SN9lojaTEg2uC9FN7NqzC8gYSUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=h5AZWSbOc0KTtdyh9+8qxRvai+pDBFNH4HZ/HB6BAL8=; b=isWTqH+pDWOyRcp9oL1Q4s017qgkkEdl5k5h5h5y/N+DwjuwNTCbCrnHsi/4aQPGJBWCFsijuwBy2BQZx48TLJOgYtMDRQeDevRTAwN9N4MX5SzlLlABdXDI6j9Q7GwUR7pq0SYkFTOZJpAl1HWBqkqz+Y6D8+TlnfCIcfoMgi2dSjQ3KY+qG8y5ZMBYXBPLRsLhHT59rLOnnlfo5AwD3HOCwQ6DeAItv64sJIHMAQ829dkuheLcqscauwgkNcSGPCS99e1OI1z9LyXhTVDrNxs9Qb7P8eOKMJh5C91ho2HgbXVtd6pIYUGVDfx4DT3oyIWAY21ipEY/9nVJU3FEaA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h5AZWSbOc0KTtdyh9+8qxRvai+pDBFNH4HZ/HB6BAL8=; b=PJjdzF9TjGobAabBfiYblK9ud/IR5xmGXzkTg/BKBXtFsh6cBFVybzGFBNzOOElhYNORP4YctGBcO7xXTQr2h+YAIN61DqVqYSlAGz1AozPZERD95kfaFkam0CK5Mm3BqvliUIYmDCeZqASw/20BYw/iKpGsglFqsjRb9X62hgY= Message-ID: Date: Wed, 2 Mar 2022 08:17:52 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH 11/12] swiotlb: merge swiotlb-xen initialization into swiotlb Content-Language: en-US From: Boris Ostrovsky To: Stefano Stabellini , Christoph Hellwig Cc: iommu@lists.linux-foundation.org, x86@kernel.org, Anshuman Khandual , Tom Lendacky , Konrad Rzeszutek Wilk , Juergen Gross , Joerg Roedel , David Woodhouse , Lu Baolu , Robin Murphy , linux-arm-kernel@lists.infradead.org, xen-devel@lists.xenproject.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-hyperv@vger.kernel.org, tboot-devel@lists.sourceforge.net, linux-pci@vger.kernel.org References: <20220301105311.885699-1-hch@lst.de> <20220301105311.885699-12-hch@lst.de> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SN4PR0701CA0008.namprd07.prod.outlook.com (2603:10b6:803:28::18) To BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e4932796-e73f-4ab3-a65a-08d9fc4f121a X-MS-TrafficTypeDiagnostic: SJ0PR10MB4638:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GSPrzSH2xlMTDF39TgX04iEiL427bx6ScvIrBm9FKJJ9BdagNMgzrfG7U2X2opM5UG5sb//LklP9IamiJ396TQP8+pzssceq1eK3NegcFCv9Gj9cwtqJ0BGPNZpZBMVaJbsqF4LvCgX1NwLbKwIm2DpExnQhTOKMyqvQEXeJGuJGl0h33phdjMpRckHM2Q0tNvXSC1GZCPNeSCY0TQAfol+yT9ychJNeMBqXj4V+OwbB+yXO4Ig8P6FG80eszfQjiT8DeNXVyJn+rlY3YeYHC9tM0sSW8GS5hgHcHtkY9nM7ZLSvs46PIo8iiqDmAMUGlm8foPIeQyecQFAMK3p7++dPfqDeXIfEAjNTjNv7pEiFN/8m2tTr4zwhxHL9C5e47j66GYAR3/r1QwzLCp/QKYdTbrs3ulJTJK4Df1zu88oueqlgDSNbI+ShBSMS8MZ6iwAWFF4b73snXkFl3czvNFc6k+yUxygaJ9pwt+4HHKLiYqBJqDmyTefgVbZ4UAD/L4Joe6Vn5bB4FNJ366u9gg1yMZrIjTQGuICq8c5oD2CJnCSRoTA0vRNDkGrF8bt3BOQs5IrS2p4xP6bAFIXw77ekzCKiB3cZnLRjnVGPhxzlZ8fbTfTEbrWwnhVimV1FbGzzJH8pijZcJMCihZ+WbVbIcrO9o4tmabsOw8WnTyP7q7NNVjJx5tMZyDLEbIlmcDxCn62aQPkiBziDEwEy72CUXRsv7+XFizXu5W2dSQrNWrSLgdQdf+jTrjGOsssv X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(26005)(186003)(4744005)(2616005)(44832011)(36756003)(8936002)(31686004)(6512007)(316002)(6666004)(6506007)(66556008)(8676002)(66946007)(38100700002)(5660300002)(7416002)(2906002)(66476007)(4326008)(53546011)(508600001)(86362001)(31696002)(6486002)(54906003)(110136005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NldFRjlua0Nya1NYZHg4WGpPMTVOcHVZWHlDQ1NSQjlqRVlYUzZJbVdiaWFV?= =?utf-8?B?Ujk2UjNmangwUm9rbWFtWlkzeU5JMlZLMW9oRGtsTE1rZkhBZzFYTXFjRXJh?= =?utf-8?B?VkJPc0RUeFlpY2R3Q005aldIU3g1QzdUUS9XWnRvVUJtcFc5RFh4SlRqdFVS?= =?utf-8?B?Q2FUbCtiRXg2ZTFaUEZ0S1BaeFZKeUdOdHRyY3FOVXJUM3ZxckUyMzE4Ymhp?= =?utf-8?B?SmJlY2RMOXJZdGdseFFtNEk1b3dsWTRPRHl2UnVLZktEaTdsK2Fmb1M1LzFk?= =?utf-8?B?QmJub3crMFgvUGFaZWFBc2RhSm9qVU9MRUZId2JQUzF0V2toclpPMkM1SlIx?= =?utf-8?B?bkRac1lJZDAyT1J6UEcvMTArYWtHUWt0M0FiZTRNWEo3WnZ5V3EyNUtDaDZv?= =?utf-8?B?QWY1dkpDK1hkc2lWWTY4N2dLM2tudzlvK3lSRUd0MWVEKzVkREVCTllNaHBm?= =?utf-8?B?YmNaN1RQM3M2Tk52aE1Hb1ZhWHd1VGo4aDZLZGU3amRRZ05UcnhmR0xCZ05M?= =?utf-8?B?MmU4eGdPS2NXcmpJQ3I5V2lpQ2lFWU1qSHVkZHorcTQ4amIrdFVpUGlXWklI?= =?utf-8?B?MVF4THBZanljWUFZUmRqWVNFcHk5ODVweEFXTHpGQk1yaGRvcmNaN2Y3dG1n?= =?utf-8?B?SGN2cWtEWGNHS0VBMGYrYUV4Vjd4WmFxOTltK1BWa2s2dnU3MEpla3VBTzhB?= =?utf-8?B?OGJOSnQwYUYxZmpIenZzdEVSdGZoWXJmR3d0c0ZTVEJXa2VyMUFOYW1JRDI2?= =?utf-8?B?bi9ySmhSZENOL0M5NnhIN0IyNmpXMFpXVUJubDZvem0zL2oxZzQyd1owVmlK?= =?utf-8?B?ajBsUEtpSW5CLzU0OUVXcWRFVHhiakpMSlFmbG9QWTg3M3RBTXNzRUI5RUQ5?= =?utf-8?B?ejlnU3pGcUpVUUdjeU1IZGY2R3JoMU5saEZqTi9aNUZDZDdoQXNuMkVHVkpw?= =?utf-8?B?bXUxazRya0FRWUZQem9CdEpVVWQwdTViM00xSzZ3WXNtT3VjQVpwRUhuOW85?= =?utf-8?B?V0Z2ZHRlUlBmNEJjcmx5NDJBVFQ3dkw0czBQdXdqWm9idHpzSW81WTdOQU9s?= =?utf-8?B?NXVEVmxGTmkvdTZuU2N6MkxmUkd1YmhGTHoxMmo5ZXROd0tYNWoyOFA1SHNE?= =?utf-8?B?djlndExlWGxoM2dKNnROcVVrZWV5UmVDK0t3dzk3VmlseUtsNEJTOFk4WGo1?= =?utf-8?B?V0VGblJXbk1lUU9VeWFpOFpUVDRhazFMTS9wK2x2UWNydlJqRnZ6VCtFb0dY?= =?utf-8?B?TmpPU1NMVEpmaE9qSUc1SXFNTXQyMlRNb1RncXAyTm5acGxSZ3NpaVYrZkcz?= =?utf-8?B?aGdtYmRFZkViRmdNNll3UWtlWkZrSWFTcWMyOVBBc3VXeTk0eFlyZWVzZ1Uw?= =?utf-8?B?ZzRFMCtkVFF3RnBmWG9XN1VIUEV2MWwrTHBjeUF2TXZQcWx1Qy9DSTBUS2l2?= =?utf-8?B?cjVWcjNUamMzNXVyNlV0dlNKbmVTTWwyL0daa28xemVTMTFCU0IyUkxjdzcx?= =?utf-8?B?elczeWJDMjRGanQ4dTFua05pMXhxTGwyTkVMUzYzZ1JhbVFqeXdVNjdjS3ox?= =?utf-8?B?anpacUx1TUMvOFp4KzFxQW5RL1pwL2lGRW93OTJIQ0RUSlZ3REUzc0dTdTZp?= =?utf-8?B?NEdraTVxVHp5UXJ4NzYvMG12OUw1cXY1VC9RbVZzc2ErSzVqcTQzcUJXdlJl?= =?utf-8?B?ZW5rcnBVT25PdWxPbURjci9kK3JzR0hRTks1RmlEZFdtSjI3dWg5Vlg1TS9z?= =?utf-8?B?V3JtOWJKWVNxc0pJQjB6a1ZtU1RMNUt5UzhyYVhGYU02SUo0U1J6a2ZrMjBO?= =?utf-8?B?QnNxRGpiTWJzTFQ2emFpR1Y5Z0NhWlpoYWY1dkd5QTFhZXdXOThNcHhicXpw?= =?utf-8?B?a2Zsa1I5a1pjcFVEMUhLWHlvRFhZU2U1SW1qcGEwbVhDWUpmR0xFL1YyZE1k?= =?utf-8?B?MFY3Z2RxU2w4VUdvMFVlclRIcWpleEVhMXBNNmlzNklza2kwRjZXdmZSZnVa?= =?utf-8?B?ZHRHSVZEZjFaMnBoK21mKzgvV3Z4VWJ6ZWRySUMxbUVuUUNDdU0rWTJ0R20w?= =?utf-8?B?QzNBaFRuQzRnZ0xSVm9jMGJ1VWZGTXVDbzFWWTA3bUllUnVQYURnd2xGaVAr?= =?utf-8?B?b2k0SDZFS0M2SEU1MUNGM1VrczNnUzhvanJ2bUMyWTBJWVFLY3ppdDBmUkRa?= =?utf-8?B?L3lHaE1WTjdldlh2b0wxNVU1NTVpcXlkb1g5UkM4bFJXRDVjRUNMeXFnZkhO?= =?utf-8?B?emQzUzlrVDBDNmZHamRRODhwMmZBPT0=?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: e4932796-e73f-4ab3-a65a-08d9fc4f121a X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2022 13:17:58.7382 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Z/beoJh8t1PlWcUcQHqx6za+Kw9gl95udqHLb6qqo0jVoSqA4a35HPHMzUWroiGeh7iird5EjViww4xis1bb7qO+56SROha4g+ITOwXkKGU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4638 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10273 signatures=685966 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=922 bulkscore=0 adultscore=0 phishscore=0 spamscore=0 suspectscore=0 malwarescore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000 definitions=main-2203020057 X-Proofpoint-GUID: BfdmuvdJ22S9UkowXG8e1KsBx8SAEAHX X-Proofpoint-ORIG-GUID: BfdmuvdJ22S9UkowXG8e1KsBx8SAEAHX On 3/2/22 8:15 AM, Boris Ostrovsky wrote: > > > On 3/1/22 9:55 PM, Stefano Stabellini wrote: >> On Tue, 1 Mar 2022, Christoph Hellwig wrote: >>> Allow to pass a remap argument to the swiotlb initialization functions >>> to handle the Xen/x86 remap case.  ARM/ARM64 never did any remapping >>> from xen_swiotlb_fixup, so we don't even need that quirk. >>> > >> Aside from that the rest looks OK. Also, you can add my: >> >> Tested-by: Stefano Stabellini > > > Not for me, I fail to boot with > > [   52.202000] bnxt_en 0000:31:00.0: swiotlb buffer is full (sz: 256 bytes), total 0 (slots), used 0 (slots) > > (this is iscsi root so I need the NIC). > > > I bisected it to "x86: remove the IOMMU table infrastructure" but haven't actually looked at the code yet. > Again, this is as dom0. Baremetal is fine. -boris From xen-devel-bounces@lists.xenproject.org Wed Mar 02 13:26:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 13:26:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282231.480862 (Exim 4.92) (envelope-from ) id 1nPOzX-00075S-4Z; Wed, 02 Mar 2022 13:26:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282231.480862; Wed, 02 Mar 2022 13:26:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPOzX-00075L-1C; Wed, 02 Mar 2022 13:26:07 +0000 Received: by outflank-mailman (input) for mailman id 282231; Wed, 02 Mar 2022 13:26:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPOzV-00075B-Og; Wed, 02 Mar 2022 13:26:05 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPOzV-00064f-Gj; Wed, 02 Mar 2022 13:26:05 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPOzV-0007JK-2r; Wed, 02 Mar 2022 13:26:05 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nPOzV-0005xM-2Q; Wed, 02 Mar 2022 13:26:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=NRnjWD4FlKhxeorf+fbFPvRqvt/g0AkcX1EHSNCNcTc=; b=yRXPyUXqF5q+1XUo2dadydSjla zofrkJrJi78ohwGJ8Jol9hq0FCjS57nVEx0PqV85z/totryDJPvabwjZzYXpw8pugeXisO33cro4T wDHVOnK0NcW9+nYMF/S8rmX91tV3b/ZnJWTJENA1p7MiFljzmRXA4m2QwYgpAOfBqwwc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 168331: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=4b7fd8153ddfe95d6d427ff241abb6fdf37e027b X-Osstest-Versions-That: xen=faecea18d252f97c6ad41f0f457566ff2c125b8d From: osstest service owner Date: Wed, 02 Mar 2022 13:26:05 +0000 flight 168331 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/168331/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 4b7fd8153ddfe95d6d427ff241abb6fdf37e027b baseline version: xen faecea18d252f97c6ad41f0f457566ff2c125b8d Last test of basis 168313 2022-03-02 01:00:26 Z 0 days Testing same since 168331 2022-03-02 09:00:26 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jan Beulich Juergen Gross Julien Grall jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git faecea18d2..4b7fd8153d 4b7fd8153ddfe95d6d427ff241abb6fdf37e027b -> smoke From xen-devel-bounces@lists.xenproject.org Wed Mar 02 13:39:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 13:39:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282242.480872 (Exim 4.92) (envelope-from ) id 1nPPCO-0000gj-CJ; Wed, 02 Mar 2022 13:39:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282242.480872; Wed, 02 Mar 2022 13:39:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPPCO-0000gc-99; Wed, 02 Mar 2022 13:39:24 +0000 Received: by outflank-mailman (input) for mailman id 282242; Wed, 02 Mar 2022 13:39:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPPCN-0000gG-1o for xen-devel@lists.xenproject.org; Wed, 02 Mar 2022 13:39:23 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 294580f1-9a2e-11ec-8eba-a37418f5ba1a; Wed, 02 Mar 2022 14:39:21 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 294580f1-9a2e-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1646228360; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=bPa0UYqeoFtBIxCTPcVqZ7v/KbpZ7TJn1HxTyYytDYk=; b=F2JP5LwaW8tVQi+wdsIGI0lEO97i54cjXq35VCPERlDZQYPMRayDjYNI FlOk6/T5ts1N2jarW0K09Pq+qhb133QnKVoalV8J+EXV9Uos495v73Lwy Ne7I9Qsl+2wlNH9qGNey+ux4Y6KmTIbyVJstCNSZLFxMkv/EE6z4h4HyF g=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com X-SBRS: 5.1 X-MesageID: 65212065 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:lJMfjKlJScLPLGxtcpid4W7o5gycJkRdPkR7XQ2eYbSJt1+Wr1Gzt xJNDGuAaPnfN2vxetB2aI/koUNS65eEyIMxTgtvpHg3QyMWpZLJC+rCIxarNUt+DCFioGGLT Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EoLd9IR2NYy24DiW1nV4 rsenuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ NtxWZOYGSAELrP0o+UnDBBZIj9TOp8eyuXcPi3q2SCT5xWun3rExvxvCAc9PJEC+/YxCmZLn RAaAGlTNFbZ3bvwme/lDLk37iggBJCD0Ic3k3ds1zzGS90hRojOWf7i7t5ExjYgwMtJGJ4yY uJHNGA2NkyePnWjPH87GI4gtsr13kPNbmR3lXCFoI8cv07MmVkZPL/Fb4OOJ43iqd9utlaVo CfK8nr0BjkeNceD0nyV/3S0nOjNkCjnHoUIG9WQ6fpCkFCVgGsJB3U+V1G2vP24gU6WQM9EJ gof/S9GkEQp3BX1FJ+nBUT++SPa+E5HMzZNLwEkwFGq57rK2z2YPDcNTw9fRdsU7P1sXiN/g zdlgOjVLTBotbSUT1eU+bGVsS6+NEApEIMSWcMXZVBbuoe++enfmjqKF48+S/Dt0rUZDBmtm 2jikcQou1kEYSfnPY2f9EuPvT+jr4OhouUdtlSOBTLNAu+UieeYi22UBbrzsK4owGWxFADpU J04dy62trpm4XalznHlfQn1NOv1j8tpyRWF6bKVI7Ev9i6251modp1K7Td1KS9Ba5hYJ2a3O BeC51oAvve/2UdGi4ctOepd7OxwkMDd+SnNDKiIPrKinLArHON4wM2eTRHJhD28+KTduao+J Y2aYa6R4YUyUsxaIM6Nb75Fi9cDn3lmrUuKHMyT50n3gNK2OS/OIZ9YYQTmUwzMxP7dyOkj2 40EbJXiJtQ2eLCWXxQ7BqZIdQFadSVgXMuuwyGVH8baSjdb9KgaI6a56ZsqepB/nrQTkeHN/ 3qnXVRfxka5jnrCQThmoFg6AF8zdf6TdU4GABE= IronPort-HdrOrdr: A9a23:LWbXw60LZ8UVUdc0MhpZpAqjBRxyeYIsimQD101hICG9Lfb2qy n+ppgmPEHP5Qr5AEtQ5OxpOMG7MBbhHQYc2/hfAV7QZnibhILOFvAt0WKC+UytJ8SazIBgPM hbAtFD4bHLfDtHZIPBkXOF+rUbsZi6GcKT9J/jJh5WJGkAAcAB0+46MHfhLqQffngcOXNTLu v52iMznUvHRZ1hVLXdOpBqZZmgm/T70LbdJTIWDR8u7weDyRmy7qThLhSe1hACFxtS3LYL6w H+4kzEz5Tml8v+5g7X1mfV4ZgTssDm0MF/CMuFjdVQAinwizyveJ9qV9S5zXMISaCUmRQXee v30lMd1vdImjTsl6aO0F3QMjzboXMTArnZuAalaDXY0JTErXkBerV8bMpiA2XkAgwbzYtBOe twrhKkX9A8N2KwoA3to9fPTB1kjUyyvD4rlvMSlWVWVc8EZKZWtpF3xjIfLH4sJlOy1GkcKp gnMCgc3ocjTXqKK3TC+mV/yt2lWXo+Wh+AX0gZo8SQlzxbhmpwwUcUzNEW2i5ozuNxd7BUo+ Dfdqh4nrBHScEbKap7GecaWMOyTmjAWwjFPm6eKUnuUKsHJ3XOoZjq56hd3pDhRLUYiJ8p3J jRWlJRsmA/P0roFM2VxZVOtgvARW2sNA6dvP22J6IJzYEUaICbQxFrEmpe4PdIi89vd/HmZw == X-IronPort-AV: E=Sophos;i="5.90,149,1643691600"; d="scan'208";a="65212065" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h3uLcszBbSjFkyR5CVafnaka/jBECvbi3HyOjCHydtJJuj4PbhpZyhRQ8757Gtes7vidKgJkwSl1N87NbR3KggSjyHqvqtMGEdbFcag73WLGaN72QG4vsS9LcjcNQwDg7Ka4LEvd8PoMmbXqA/1qsW5G7xpanLUuiBkZrQbkjqhvsx3cjNyzUxjcI7kLPzJqDv3vB0J2w8vjSHZvcB2fxPK+i4t4/wT2v4Twg7GdiKkEFk+GnbsIKvrz/2T+Snk8BWSIBuMA0ii59z4DgEF09cv+5jVKtgWQ/kTXa2KpmzrYWmefAeK0QHweZnKwYM6edcuxMZ9YavFYHbXQJYV/1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bPa0UYqeoFtBIxCTPcVqZ7v/KbpZ7TJn1HxTyYytDYk=; b=QRwcfv91xtirrKrhpFBl/x+S+C6aypRImiOOTAORrcOPV8T8CvAKGuJv005ii+4wSp0oh6/+sLigdLPQLUMwjGqYVI560jZZDO6hn5IziTQXI+/dGorBW1SPDt8hAktI1qJ0F5sXPCzhm6sHD2K1exDeli0ZgOG9cVDSBzGvfIFliyAvn1mnoxhkn3PhOLvZAQxq9prp7m8WfJGjO8qkZONDIQ1lSWtSC588VuaToJaPXh6TIBjMkajuUIQ21R2eHy94P92mZZsAlIZBjl3iQQWxwMlalak6BYQ3/8PlGZuN+Igm1L52/LPU14YVP/7OMzpUqzAhDfQix9y9fRz6vA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bPa0UYqeoFtBIxCTPcVqZ7v/KbpZ7TJn1HxTyYytDYk=; b=sK82Ruq2gd2MmJlN6+IZLtCnBKRvDsFl+YtZOOlNdLkcdhPOxEgridHyr8Xl3r5cy5We4xMKvqDfzvLLaeoMZ3HQkeoArMj6EfGk4oxhz7RBKrTVXC8f+k3vx4rEgLya/BKQ8oaJ8YAs/fswYuz5aMKgONtg8pn8Cey4I1WK8y8= From: Andrew Cooper To: Jan Beulich CC: Roger Pau Monne , Wei Liu , Xen-devel Subject: Re: [PATCH v2.2 8/7] x86/IOMMU: Use altcall, and __initconst_cf_clobber Thread-Topic: [PATCH v2.2 8/7] x86/IOMMU: Use altcall, and __initconst_cf_clobber Thread-Index: AQHYJ+IV6PtRJY8p5U2wBnUH9jKzdqyj8n0AgAa3aoCAASBXAIAAIhyAgAAGJQCAADOGgA== Date: Wed, 2 Mar 2022 13:39:09 +0000 Message-ID: <15868475-0702-c884-143f-366b9d79a255@citrix.com> References: <20220214125632.24563-1-andrew.cooper3@citrix.com> <20220222114711.19209-1-andrew.cooper3@citrix.com> <5fae516a-17c1-0ce4-c46e-909a83c0e273@citrix.com> <60f3c942-3822-87dd-df6e-8b64ed4d17c4@suse.com> <67ff91f4-e5fe-47d5-fdb8-9a302beb6e2a@suse.com> In-Reply-To: <67ff91f4-e5fe-47d5-fdb8-9a302beb6e2a@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 78d1ccc5-e438-46ea-a916-08d9fc5207c7 x-ms-traffictypediagnostic: CO2PR03MB2341:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: tc+CDrpRyNIhaSIeUwCWZAXB1lvTyBEbh6zL8tRs464Hus4i2tnjZ+x4Mw9fnkcRpLdzP0EQ6oCk/u7OmfbFLa8COGUCfL7aUIZTRWdzNxGu4E7KQ8v2UI0GK5HN3zBc22EraYrTPlMSWXfgUulPlxDKMqTq67qFhuUwHY5r8F0DswxHd0qVFOIRvbq9VLniAWLFZL52psh4KSxKSUrAuep1QZj9ydZKOLko12HDyrWWHu3dVRi6RT2DXUHhS8xBzJwTL+xFpjcHVnqZCOHIjN5Tf2d/1tUEes5cdKkDLXbK5P9+wphhL7UEU9x/gH+IYnEc1vmAVFr4Slil7VCufD62+Vxm7iAIieizw282heFhTJiunWnrpQcQbU6l/muE1bTPCUo6HXRLHhRajkCgDPsaGXDshzrLdWpxLgT0JP/Ivxnliam7UUbj6JK7s3aKOEx8sXiME5Vdb1ifNMj4pA34aBEbHZsx7HPtQa6NmThGb6zH03ig4J3h8Ag4Bo6fNIa1XLojp7DNo/mWyGjaMr3HtzzZBykwwK0YQo36ABGXv9pPREFEr5sfV8qoELEtN0Ot1HfIrUcQ+v8q8KFxSwBZfvIViE7Z9vxPP15CqFmTg7OccVOvV46V/BYkClzGTQ3hdSqelWHBJsZ7uReVW/6AXgSmPuMM27kFoPqvMwUW08J/9kyQbpCEDq4A6tesNqxpnLBy6PvqetgkCrROBDlGzL2hGqPsJK9SsE7DHUQ5YnruDMAPM4OEx1suoSSWWLHl2Qo2J1VtrLsJfW5KJhOzoV8hp1OmtFkpx0NhnQkGVICIbu448SacL/dbJt6x x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38100700002)(2906002)(6512007)(83380400001)(82960400001)(122000001)(6506007)(53546011)(186003)(2616005)(26005)(6916009)(54906003)(316002)(8936002)(71200400001)(4326008)(31686004)(8676002)(6486002)(64756008)(66446008)(66476007)(508600001)(36756003)(91956017)(66946007)(66556008)(76116006)(31696002)(86362001)(38070700005)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?MU5GLy9vYXBZaGNGZU5pQ3ZDKzdDRmNxR2prMERPc08zY0ZGQVl2WnFQTzZB?= =?utf-8?B?ZFNOZ0JPVVpGQ21RMjlvbUZPYjVQazBGQ2xlbE1EYm1NQ2FjdGFlTklKK0Z6?= =?utf-8?B?WGhRK0tid1lSQ2FNMVh5VHQ3Zmg0cm0rOTN6ZFpNd29tSURyM2l3U090VVhv?= =?utf-8?B?cjU1TzdDVzNvazRLY0NtTHpWWmMyZW5LL1o2ZG9NSzlpb2VNUkxIY2dVUDlw?= =?utf-8?B?ZWM2NUxQeDQzcHFPUE5yV09FZFo0a1hGOUdwWisrRlUrUmZ2Um5PM3ZoNXo2?= =?utf-8?B?UkpPREZ5dnd1VUpaOVJocVNyZzZjSWVUQU4rdmRtVHAybVl3d0xTcFJmanhC?= =?utf-8?B?MFJpWGVZcldFRnkxZG9QMWVzN0RnVDNmNXJaSlh4N3IycFkzVWFrWm02d0RZ?= =?utf-8?B?amkwSzdmZWNrU0hxSXRwdFBvZTFObjNka1lGMUhGdDVuYldGQld0dE5Tei8z?= =?utf-8?B?aVhtSnRKREtYRmVnSVBEbnN0bUZzTzdDT005Z0l4L3dQSUhxb1VoalllbEF1?= =?utf-8?B?UkVSNytiTUQzZHlEODU1YlpvQlFOZHUvNFJUekdSa3pRQmtNc2pZbHE4YmF1?= =?utf-8?B?VHV2T0x3ZWJWVWs1cXJtVXlIenJybEtRckxOaGJiSUs0a1hwQ21mNXhQTDkv?= =?utf-8?B?Q2hCMW10b0JBWWtTR1hwRTZkd3JNM01ic0lKMFJaTmJTd3o0bFlCdDBRQ3NN?= =?utf-8?B?RnI1cHVNZWNJQ3NXaVVLazkwVllZeW1EaGVSWnYrV0RrSGN1NjM5QjVFekZx?= =?utf-8?B?OG83NFN6Z2REWTVjVUZhMWR1NW9CS1BxQ3hvN09zTVY0UEdsWlhDNnBHaHIw?= =?utf-8?B?cVNVYUdid1VRVWZjTW1YMy9PNHRDSXcvOEdwM0NrMDhGNyt4enhsZ0FzcFV4?= =?utf-8?B?N3V1ZjZQMzdNSEJ6ZEJlMnVBdXZsM3NVc1o3Z3BjYnRwRHhRbHRIQTI4ZHZ2?= =?utf-8?B?R2lZM0dJWFdLc1A4OHFDbXE3L1Y5ZllGRXExWTBxSHlIcUJjQXVnNEhuM1Zz?= =?utf-8?B?QlV1eVl1SG1RRDY4WXd0KzlNbThrWnllVW5HRDNVQ2dpY0NIRXhqYS9Gd3dz?= =?utf-8?B?cU9uNjIxVUlpZTZNQWVjWmxyZzdIdkZPQzMvcVdEZG1EZUlnZ0lHYWVValQ3?= =?utf-8?B?YzNBUkt0LzNnRmZpOVhGSW5nZkhJV0I0RnRVSEtVNFlndjBWUlROOC8zYXh0?= =?utf-8?B?d2hNY3hRTHpMdElCTzBvUFZJYkhmQlUzK2dORVRtTTRQSWtNZyt4R3pRU0pa?= =?utf-8?B?NVpjNnY3RUgzbDVkaWVnNmxPeFBLRWZqTGx4bHlHbkE2Q3NlU0QrRGNQMUpC?= =?utf-8?B?UHl0R2Z3cGNpVnBVNFdmY3NxRDdhZ2Nrcm9SZDBmS1VzS00zU08ydUsvUXZL?= =?utf-8?B?QkhCYXNXYUF4b2dYdVBSdjRGZVkrTVZtSXVrcitOYlJIcVU4dXZxK3lFTVFF?= =?utf-8?B?YzRXVmYwOFBnRnVYc3ZNRXVvVjN4bk1sdW90ZnNyYi9OVDZSNGJHRU83NlJZ?= =?utf-8?B?VjVFVWZzMUlVSWxCQlpndFBZbURFTXNRcUtDS2g5Rys5N1VwUjBGOVVNZDcw?= =?utf-8?B?dm40L1JxZXN1SzJzRU1SQjhTOW10NVdNc0dLT1BHNVZjQW5ubFR6YVp5U2du?= =?utf-8?B?Umg2VnZLUGpVZWh3SEg2dXRnckNFbks5dG9Va1cyeDVLYnVibFNzdjdWWUUv?= =?utf-8?B?RjNXdy82dUtlOGZLTEZNcFFJenM3anYzT1FjKzF6U3RneDdXUmFmWDNFblUr?= =?utf-8?B?YlZaRXFXYWM4cUs5OG1SekxOcWhaYjREQVAvbG9GRnZsOHNheVRUZkZPOTdN?= =?utf-8?B?MnZQUVRPRmtnbUUxc2JpVUNZdmZiZDcrVkVXeGI4dWdzSVVMQzM4MUR4WmZE?= =?utf-8?B?K0hRQUFqVWNGUUt1bFAyL09QeW0vckpCUlhzSjVTSnFnRmk5NFo3UW5EZFZE?= =?utf-8?B?Mm9ZenliWFJOSlZUTGFBdVJ1N2l5U3l0UjdITU9NVkt3TW5MT2NLZTU0dDYv?= =?utf-8?B?VkIxM0szZU9zMnkvK3hUcTBramJ4dWc3NThKa1R5WSs0TE9lWXZtWkEvRHVk?= =?utf-8?B?WHlKdGwxTlpjZE1QeFZNUDBOaGFDMEU0R2xDSFlqR1J5U3VGOWFPMEV6UVR6?= =?utf-8?B?Q3Z2QVNCdzlXM2E0Sk4xTzFwdEtDTitYYnUvSGlCRHRtNTRUbGt6WEJ2cGU1?= =?utf-8?B?azJ4UkVqKzh6TXBhM2J5RHhkSEVwZ2FhSlRhWkI1a1pYVHc2cWhyWnpqc2w0?= =?utf-8?B?SExBSDRZeXdNYk5rTFhsUFUzU3pBPT0=?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 78d1ccc5-e438-46ea-a916-08d9fc5207c7 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Mar 2022 13:39:09.6429 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1afsKz8bcvosRs2VjI40Tpl+owxZGCzHGhIHMStO8FGtrbZ5lyvkep+CNJEDVHayrZoU+E4ZMVI/BoLyCLTXlv8VyZar0vh6WK+pvPDgTa8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR03MB2341 X-OriginatorOrg: citrix.com T24gMDIvMDMvMjAyMiAxMDozNCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDAyLjAzLjIwMjIg MTE6MTIsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBPbiAwMi8wMy8yMDIyIDA4OjEwLCBKYW4g QmV1bGljaCB3cm90ZToNCj4+PiBPbiAwMS4wMy4yMDIyIDE1OjU4LCBBbmRyZXcgQ29vcGVyIHdy b3RlOg0KPj4+PiBPbiAyNS8wMi8yMDIyIDA4OjI0LCBKYW4gQmV1bGljaCB3cm90ZToNCj4+Pj4+ IE9uIDIyLjAyLjIwMjIgMTI6NDcsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+Pj4+Pj4gLS0tIGEv eGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvYW1kL3BjaV9hbWRfaW9tbXUuYw0KPj4+Pj4+ICsrKyBi L3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL2FtZC9wY2lfYW1kX2lvbW11LmMNCj4+Pj4+PiBAQCAt NjI4LDcgKzYyOCw3IEBAIHN0YXRpYyB2b2lkIGNmX2NoZWNrIGFtZF9kdW1wX3BhZ2VfdGFibGVz KHN0cnVjdCBkb21haW4gKmQpDQo+Pj4+Pj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IGhkLT5hcmNoLmFtZC5wYWdpbmdfbW9kZSwgMCwgMCk7DQo+Pj4+Pj4gIH0NCj4+Pj4+PiAgDQo+ Pj4+Pj4gLXN0YXRpYyBjb25zdCBzdHJ1Y3QgaW9tbXVfb3BzIF9faW5pdGNvbnN0cmVsIF9pb21t dV9vcHMgPSB7DQo+Pj4+Pj4gK3N0YXRpYyBjb25zdCBzdHJ1Y3QgaW9tbXVfb3BzIF9faW5pdGNv bnN0X2NmX2Nsb2JiZXIgX2lvbW11X29wcyA9IHsNCj4+Pj4+IEZvbGxvd2luZyBteSBpbml0Y2Fs bCByZWxhdGVkIHJlbWFyayBvbiB4ODYnZXMgdGltZS5jIEknbSBhZnJhaWQgSSBkb24ndA0KPj4+ Pj4gc2VlIGhvdyB0aGlzIGFuZCAuLi4NCj4+Pj4+DQo+Pj4+Pj4gQEAgLTI3OTQsNyArMjc5Myw3 IEBAIHN0YXRpYyBpbnQgX19pbml0IGNmX2NoZWNrIGludGVsX2lvbW11X3F1YXJhbnRpbmVfaW5p dChzdHJ1Y3QgZG9tYWluICpkKQ0KPj4+Pj4+ICAgICAgcmV0dXJuIHJjOw0KPj4+Pj4+ICB9DQo+ Pj4+Pj4gIA0KPj4+Pj4+IC1zdGF0aWMgc3RydWN0IGlvbW11X29wcyBfX2luaXRkYXRhIHZ0ZF9v cHMgPSB7DQo+Pj4+Pj4gK3N0YXRpYyBjb25zdCBzdHJ1Y3QgaW9tbXVfb3BzIF9faW5pdGNvbnN0 X2NmX2Nsb2JiZXIgdnRkX29wcyA9IHsNCj4+Pj4+IC4uLiB0aGlzIGFjdHVhbGx5IHdvcmtzLiBC dXQgSSBndWVzcyBJIG11c3QgYmUgb3Zlcmxvb2tpbmcgc29tZXRoaW5nLCBhcw0KPj4+Pj4gSSdt IHN1cmUgdGhhdCB5b3UgZGlkIHRlc3QgdGhlIGNoYW5nZS4NCj4+Pj4+DQo+Pj4+PiBCb3RoIG9w cyBzdHJ1Y3R1cmVzIHJlZmVyZW5jZSBhIGZ1bmN0aW9uLCB0aHJvdWdoIC5hZGp1c3RfaXJxX2Fm ZmluaXRpZXMsDQo+Pj4+PiB3aGljaCBpc24ndCBfX2luaXQgYnV0IHdoaWNoIGlzIHVzZWQgKGJl c2lkZXMgaGVyZSkgZm9yIGFuIGluaXRjYWxsLiBXaXRoDQo+Pj4+PiB0aGUgRU5EQlIgcmVtb3Zl ZCBieSB0aGUgdGltZSBpbml0Y2FsbHMgYXJlIHJ1biwgdGhlc2Ugc2hvdWxkIGNhdXNlICNDUC4N Cj4+Pj4gVGhpcyBkb2Vzbid0IGV4cGxvZGUgYmVjYXVzZSB0aGUgaW5kaXJlY3QgY2FsbHMgYXJl IHJlc29sdmVkIHRvIGRpcmVjdA0KPj4+PiBjYWxscyBiZWZvcmUgdGhlIEVOREJSJ3MgYXJlIGNs b2JiZXJlZCB0byBOT1A0Lg0KPj4+IEknbSBhZnJhaWQgSSBkb24ndCB1bmRlcnN0YW5kOiBUaGUg cHJvYmxlbWF0aWMgY2FsbCBpcyBpbiBkb19pbml0Y2FsbHMoKToNCj4+Pg0KPj4+ICAgICBmb3Ig KCBjYWxsID0gX19wcmVzbXBfaW5pdGNhbGxfZW5kOyBjYWxsIDwgX19pbml0Y2FsbF9lbmQ7IGNh bGwrKyApDQo+Pj4gICAgICAgICAoKmNhbGwpKCk7DQo+Pj4NCj4+PiBJIGRvbid0IHNlZSBob3cg dGhpcyBjb3VsZCBiZSBjb252ZXJ0ZWQgdG8gYSBkaXJlY3QgY2FsbC4NCj4+IE9oLsKgIGlvdl9h ZGp1c3RfaXJxX2FmZmluaXRpZXMoKSdzIGRvdWJsZSB1c2UgaXMgaGlkaW5nIGhlcmUuDQo+Pg0K Pj4gVGhlIHNhZmV0eSBydWxlIGZvciBjZl9jbG9iYmVyIGlzIHRoYXQgdGhlcmUgbXVzdCBub3Qg YmUgYW55DQo+PiBub24tYWx0LWNhbGxlZCBjYWxsZXJzLsKgIFdlIG5lZWQgdG8gZml4IGl0Og0K Pj4NCj4+IGRpZmYgLS1naXQgYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9hbWQvaW9tbXVfaW5p dC5jDQo+PiBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL2FtZC9pb21tdV9pbml0LmMNCj4+IGlu ZGV4IDY1N2M3ZjYxOWE1MS4uYjFhZjUwODVlZmRhIDEwMDY0NA0KPj4gLS0tIGEveGVuL2RyaXZl cnMvcGFzc3Rocm91Z2gvYW1kL2lvbW11X2luaXQuYw0KPj4gKysrIGIveGVuL2RyaXZlcnMvcGFz c3Rocm91Z2gvYW1kL2lvbW11X2luaXQuYw0KPj4gQEAgLTgzMSw3ICs4MzEsMTIgQEAgaW50IGNm X2NoZWNrIGlvdl9hZGp1c3RfaXJxX2FmZmluaXRpZXModm9pZCkNCj4+IMKgDQo+PiDCoMKgwqDC oCByZXR1cm4gMDsNCj4+IMKgfQ0KPj4gLV9faW5pdGNhbGwoaW92X2FkanVzdF9pcnFfYWZmaW5p dGllcyk7DQo+PiArDQo+PiAraW50IGNmX2NoZWNrIF9faW5pdCBpbml0Y2FsbF9pb3ZfYWRqdXN0 X2lycV9hZmZpbml0aWVzKHZvaWQpDQo+PiArew0KPj4gK8KgwqDCoCByZXR1cm4gaW9tbXVfY2Fs bCgmaW9tbXVfb3BzLCBhZGp1c3RfaXJxX2FmZmluaXRpZXMpOw0KPj4gK30NCj4+ICtfX2luaXRj YWxsKGluaXRjYWxsX2lvdl9hZGp1c3RfaXJxX2FmZmluaXRpZXMpOw0KPj4gwqANCj4+IMKgLyoN Cj4+IMKgICogRmFtaWx5MTVoIE1vZGVsIDEwaC0xZmggZXJyYXR1bSA3NDYgKElPTU1VIExvZ2dp bmcgTWF5IFN0YWxsDQo+PiBUcmFuc2xhdGlvbnMpDQo+Pg0KPj4NCj4+PiBBZmFpY3Mgb25seSBw cmUtU01QIGluaXRjYWxscyBhcmUgc2FmZSBpbiB0aGlzIHJlZ2FyZDogZG9fcHJlc21wX2luaXRj YWxscygpDQo+Pj4gaXMgY2FsbGVkIGltbWVkaWF0ZWx5IGFoZWFkIG9mIGFsdGVybmF0aXZlX2Jy YW5jaGVzKCkuDQo+Pj4NCj4+PiBJc24ndCB0aGlzIChwcmV2aW91c2x5Pykgd29ya2luZyByZWxh dGVkIHRvIHlvdXIgIng4Ni9zcGVjLWN0cmw6IERpc2FibGUNCj4+PiByZXRwb2xpbmVzIHdpdGgg Q0VULUlCVCI/DQo+PiBOby7CoCBJdCdzIGJlY2F1c2UgQU1EIENQVXMgZG9uJ3QgaGF2ZSBDRVQt SUJUIGF0IHRoaXMganVuY3R1cmUsIGFuZCB3aWxsDQo+PiBuZXZlciBlbmNvdW50ZXIgYSBmYXVs dGluZyBzaXR1YXRpb24uDQo+IEknbSBzdGlsbCBsb3N0LiBBbiBleGFjdGx5IG1hdGNoaW5nIGNv bnN0cnVjdCBleGlzdHMgaW4gVlQtZCBjb2RlIChhbmQNCj4gbXkgaW5pdGlhbCBjb21tZW50IGFs c28gd2FzIG9uIFZULWQpLiBUaGUgQU1EIG9uZSBpcyBhY3R1YWxseSBhIGNsb25lDQo+IG9mIHRo YXQgbXVjaCBvbGRlciBvbmUuIFRoZSBpbml0Y2FsbCByZWFsbHkgd2FudHMgdG8gbW92ZSB0byB2 ZW5kb3INCj4gaW5kZXBlbmRlbnQgY29kZSwgYnV0IEknZCBzdGlsbCBsaWtlIHRvIHVuZGVyc3Rh bmQgd2h5IG5vIGZhdWx0IHdhcw0KPiBldmVyIG9ic2VydmVkLg0KDQpMb3ZlbHkuwqAgSXQncyBn b3QgYSB2dGQgaW5maXggd2hpY2ggaXMgd2h5IGl0IGVzY2FwZWQgbXkgZ3JlcC4NCg0KQW5kIHll cywgSSByZWFsbHkgd291bGQgZXhwZWN0IHRoYXQgdG8gZXhwbG9kZSBvbiBteSB0ZXN0IHN5c3Rl bS4uLg0KDQp+QW5kcmV3DQoNCg0K From xen-devel-bounces@lists.xenproject.org Wed Mar 02 13:45:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 13:45:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282251.480884 (Exim 4.92) (envelope-from ) id 1nPPHp-00028y-2x; Wed, 02 Mar 2022 13:45:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282251.480884; Wed, 02 Mar 2022 13:45:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPPHo-00028r-Vy; Wed, 02 Mar 2022 13:45:00 +0000 Received: by outflank-mailman (input) for mailman id 282251; Wed, 02 Mar 2022 13:45:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPPHn-00028l-Vo for xen-devel@lists.xenproject.org; Wed, 02 Mar 2022 13:45:00 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f23861b8-9a2e-11ec-8539-5f4723681683; Wed, 02 Mar 2022 14:44:58 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f23861b8-9a2e-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1646228697; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=yy95bZc1mafoynhoap3Dua9XOm5rukrDtL8/9mucZuA=; b=N0la9Poldn8bJMGAisj9ekpt6wT1pOPLPDuHumrdp0b54uIXhyAUBSHy kSJt1Q7SfWrz9fpSZJ0Y/tvcSYoeAv+opxMNXe6/qE8y0xfxHEjkDjgBP 03yvKGbzL+Vi5IvhbGELfca6GSWtHu3SXPfqjvIx5nyj4PswKHxips+uU E=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com X-SBRS: 5.1 X-MesageID: 67611185 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:GHsVbq+YRLaz+LUzroUQDrUDdH6TJUtcMsCJ2f8bNWPcYEJGY0x3z TBNXTzVOqvcYTGjLdsgbdzj9UpTsMDQxtRmHAA5qi88E34SpcT7XtnIdU2Y0wF+jyHgoOCLy +1EN7Es+ehtFie0Si+Fa+Sn9T8mvU2xbuKU5NTsY0idfic5DnZ54f5fs7Rh2NQw2oDjW1jlV e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9 DlCna6cYCcPb63HoroidkZAThgvH7RZ1LCSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFJkYtXx6iynQEN4tQIzZQrWM7thdtNs1rp4RQ6+HP ppEAdZpREX9ah91Z2saMrkRgeKOuiKjcB5f72vA8MLb5ECMlVcsgdABKuH9ZdiiVchT2EGCq Qru9WnjHgsTMtDZzDOf62+tncfGhya9U4UXfJWG8fptjEyW13YkIhQcXlumotG0kke7HdlYL iQ84TEypKI/8EiqSNjVXBCipnOA+BkGVLJ4A+A8rQ2A1KfQywKYHXQfCC5MbsQ8s807TiBs0 UWG9/vrDzFytLyeSVqG66yZ6zi1PEA9L3IGZCICZRsI5Z/kuo5bs/7UZo89Sujv1ISzQGyuh WDRxMQju1kNpfwn/oWdrFDMuWyTg8fREzdkxBzIcm3wu2uVe7WZT4Cv7FHa69NJI4CYUkSNs RA4piSO0AwdJcrTzXLQGY3hCJnsvq/Ya2OE3TaDCrF8r2zFxpK1QWxHDNiSzm9NO91MRzLma VS7Veh5tM4KZyvCgUOajuuM5yUWIUrISIyNuhP8NIMmjn1NmOmvpnsGiam4hT2FraTUuftjU ap3iO71ZZrgNYxpzSCtW8AW2qIxyyY1yAv7HM6nkU35ieLPOifEE9/p1WdiiMhjtstoRy2Pr r5i2zaikU0DAIUSnAGNmWLsEbz6BSdiXs2nwyCmXuWCPhBnCAkc5wz5mtscl3het/0NzI/gp yjlMmcBkQaXrSCXeG2iNyE4AJuyDMkXkJ7OFXF1Vbpe8yN4OtjHAWZ2X8ZfQITLA8Q4la8kF 6ReIp7YahmNIxyekwkggVDGhNUKXDyghB6UPjrjZz46fpV6QBfO9MOidQzqnBTixALu3Sfii 9VMDj/mfKc= IronPort-HdrOrdr: A9a23:D3HCQq+sJJCldMirI2Juk+Fldb1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYW4qKQodcdDpAtjifZquz+8O3WBxB8buYOCCggeVxe5ZnOzfKlHbehEWs9QtrZ uIEJIOROEYb2IK6/oSiTPQe7lP/DDEytHQuQ609QYOcegeUdAF0+4PMHf/LqQZfml7LKt8MK DZyttMpjKmd3hSRN+8HGM5U+/KoMCOvI76YDYdbiRXpjWmvHeN0vrXAhKY1hARX3dk2rE561 XIlAT/++GKr+y78BnBzGXehq4m2ecJi+EzRPBkuPJlaAkEuTzYIbiJnIfy+Azdldvfq2rCVu O85CvIcf4DrU85NVvF3CcFkzOQrArGrUWShmNwyEGT3/AQSF8BerV8rJMcfR3D50U6utZglK pNwmKCrpJSSQjNhSLn+rHzJllXf+WP0AgfeMMo/gpiuLElGfZsRE0kjTZoOYZFGDi/5JEsEe FoAs2Z7PFKcUmCZ3ScumV02tSjUnk6Ax/DGyE5y4ao+ikTmGo8w1oTxcQZkHtF/JUhS4Nc7+ CBNqhzjrlBQsIfcKo4DuYcRsm8DHDLXHv3QSmvCEWiELtCN2PGqpbx7rlw7Oa2eIYQxJ93g5 jFWEMwjx9ER6svM7z74HRmyGG8fIzmZ0Wd9ih33ekLhoHB X-IronPort-AV: E=Sophos;i="5.90,149,1643691600"; d="scan'208";a="67611185" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mDqVfh6oljSx4eBGR10x6EWxja3KSGkv7qSLPWofeJed+WEbd6/c86cDvFwQ16HbtPK40sxI2cYZ/q7W6gSWdn95gKgUQI6nJzYqoRpNgQvKajCsNeYztR/3VzUwrfTI7aDuX2pv1swyAtqbOzRcaNOz+5DaB9Guvp+gEDBlwsD9KTO8c5Y2tFObGu3+pzt/TdePvvRzxvsPKyNzmwh5V9CB2odqIVee/VlTWIb9wPi2P1/c8hWTVNxucdX51r9iqu0+54hmeG1axbBb6qUj+GNsAWY79NT0ptgFvDfSddM47tAD1pWO2gPtxoCtsyGkGoGcY1vkncnRovFmAk1Qzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/GuEWfnh7t7WFYhXPlf7lXrB2XILSCmjAhkM/Liht00=; b=F/ERbX3jh3zH9e1ytbr4hAE0/yl0/q5QrJM9F9SVmNPMjPwnEpUlQ7wJVfbZmEywpLmcSNcZMdfSMwkl4TBWPuFRCdrhWrY1A77nkUtALPameFBvUuQ0yMV/1Mb46IYNn8Daol54wBejKDplA14EQsXnU2ixoZfbtrb7mIWfM46E92F0vAzQfUxYkWw/UkWjTmkril+rZ2iVpYPVEvTVv+BuKXn3OTdvLmposYNZvW59XrYsJ3/hfj5ypZcFrshggcichC2xB8H8LnBBmc+Z9uIczZ1xP7GiFbocb/XD6lyy5W06qZHGoLnnRuc9iTX5Fvwpq9QnDVOYaGE6DytKnQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/GuEWfnh7t7WFYhXPlf7lXrB2XILSCmjAhkM/Liht00=; b=SeXgBtTSt8lN6ChEZBGu89htEsjNMe8xX/7VkkvFUz7sT2ZXHyplfrLNtXxazGQXtnba2LI0/lroB4f8sfoQYmwPpZVmpG+TRyVGT0u7vhwswDqA6VwIxVJEE9xBIuEpPvRz2DHi4ckKpvCVunNNTMNf/J4HFrHcfS0Dlp3qdec= From: Roger Pau Monne To: CC: Roger Pau Monne , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH] livepatch: set -f{function,data}-sections compiler option Date: Wed, 2 Mar 2022 14:44:25 +0100 Message-ID: <20220302134425.38465-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.34.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0089.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8::29) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5ac78c45-a56f-4859-078d-08d9fc52d3a9 X-MS-TrafficTypeDiagnostic: CY1PR03MB2251:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Aiii8L2YNGwHzC8H2vhxlbAelxQJ1dgsybLkumfo01AqrG0d+QpdgbLedltfuEtfgWQlzaMp5H5vJxsx8SxHKzb/VSpNsjKNXUv/pE+isszwQZCrEW8L8jvfWfuWSRDsUo9WOO+HxPuNO1krGhIX+u4lB69/VXS0o9x+YRyuyZehku6klcgVwJtpfZ2plaucZtxpCFrJh/mH0Yn2nbDqZ9pKPrRdM54T3CZCmtov6tJE/3R2D4jKpBtGDqd0Pg+C5D07CT+ooP1iOLhRfF5k6/tvm2xMU/PrWzDXEsa7Yb0NZ7nvGwMDZswu1ia1X6o1nmdTKKmh4AUgM2pY2YucHSLCi482fxiHpsH8kItNIQnU+35bFs57yhM8Ds8YXLvysdaFUXSlyREyIjD4MDRIrfoHDKOmTlrwD+ve6LR0CPAtnikHHoz/vP6kJNB7PyXedjXGUGlrqs36JVQPKlC+Rh7yBQ5rz1iqwGAQbYsa6Vs+tQQdcl2Q6Dlcmep2SZXfSK0wGjxW6GMpIxV4L/eMDppsUzuEsTedqshS0WyA0YInnG3D2KczqNQJVJdVcjs8QP01gu5QUAkFx1LYLZRHE9e43lxfI8qwpuWuugP5jE3B/rsVocEhSeufhWz+LP94u26gcxCRCwq9J3NbNQMyHA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6512007)(82960400001)(26005)(6486002)(508600001)(6916009)(54906003)(316002)(38100700002)(4326008)(86362001)(6666004)(66556008)(66946007)(36756003)(6506007)(66476007)(5660300002)(2906002)(8936002)(8676002)(83380400001)(1076003)(2616005)(186003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WmJKREErSzhCaFVxbzAwRWRXSGRGWlhSNmIydDZVWFNLWU5pUzh6cmxQK2oy?= =?utf-8?B?Z3JoUzJ1amZvNlZoWE9aWmwyVHo5cmxKalduczJST2dtR1ZWWTJKU1dwaC8x?= =?utf-8?B?YnY2VmxQbzlWc29kTWJoazhUUzViODRZOUwxYkowSDlMZVVvYXpvOFprbjll?= =?utf-8?B?UVRUZzdHZjRuSGxxWGVIbW9vUkZETmFYUWpVLzVuWkEwUUx5VW15Ny9KZTZ2?= =?utf-8?B?eTU0QTdyTGRraDNJa3hZZjZqQWtROURjaVM1TGFCUVVYcWRWTlI0QzJpeHBU?= =?utf-8?B?aGVUaVVlam9jbjNEMUJKVnEvQmNnWWFGbDNGUzF5SW1TQ3BIN0JtaFIxZktv?= =?utf-8?B?Vm9nZEVwUVh0akV5endmVkxHaUI0S2h6a1o5Vm5JbWpJa1diaFIvRGpmQUhw?= =?utf-8?B?OXVER1BzZ2Y0SENkKzRFVFFNU2VyYS94bnRRcmlCcEpSRU1JUU1yM2xJSTVq?= =?utf-8?B?aVZyOTQ2d20xZ0pCYlVYc1hBRTV5dFdrQ1FId0pNc2grcTIzcURpRVRRQ3hh?= =?utf-8?B?Nk44bWlUN3FVS20rN29heFJCdWZTVkVWS1B3UllYYVZaU0FZVUhtZFBUbTdH?= =?utf-8?B?OHYyKzJJTVNPZ2pKbGk2amdLOG45ZHRJTGV2Z1plcVNYSGhmTGR1Zml4Nmov?= =?utf-8?B?dzJPaXg2MktRUDJMREV0MndEc21BVnNld3hZSk43S1RPeGN2YzAzbGVNOXlI?= =?utf-8?B?MTNvWnFlSHIvWDcxdmVQSFpVVE9PejBpS0REYjlJa1dyRFdmVmdjMHpPNTFM?= =?utf-8?B?NDdUZDZHazIwUlRxZklKUWhLVWxiNUNLOTZZL2d6djNTZ21vQ2FkSmJ2bHRO?= =?utf-8?B?RkhxSmdtZHZkRkczNEd0aVNsTEp6aHE2K0hoRHhMTzhuMWtvdE4rTmRFQVJ6?= =?utf-8?B?SlhSL0Joa3d5SnR0YURBZ3JWZ0V4M0FaRGFheW5RNThvSW1ESnlUQzRuUldp?= =?utf-8?B?VlZzWXZjU1AwQktNeGxLS1NyTGpob01kdHlWYUNlSGRpVmVBRlFFM0JRTW5i?= =?utf-8?B?dWtQbHQrdEM2Tm1UdW1rRjVQZ3FFYngzR2FlUGRzdldvNWpLc1BOUllwdnkw?= =?utf-8?B?OW8rOFRSOTNQa0hYVXZDejdZeGpiYWZJK1NRTUNxVzJpaUlCYUdWOHhxTC8x?= =?utf-8?B?MytoT0NmYi93N1BUSlRvZEpYSjRrSmF1WTJlZ1V5OHkrQmVjdTR3OGwvVURM?= =?utf-8?B?MC9KbzFZVndVdjlBQ0Z4SHpCU3g3dG13T25rWTFCaTJJd084ZGdPa0ZLeXoz?= =?utf-8?B?R2ZQZVFXV2NmdHZGZStJRyt5T0dsRHJOY2UvL25zbWR4OTdYK1hPVVFDVzFH?= =?utf-8?B?RGxQMkdxWUFqTU9zVUhLeGRXbUZXbkRabGdSZEJHTVRnYmZhZ05JaVFQYW9D?= =?utf-8?B?eFV2cXBXNE9PQkM3Y25xd2lLOG03ejJZaTM1ayt2cWFKc0c3STBiclJRckZ4?= =?utf-8?B?Ukd4L1FNK1hqRE5mcnRzbUNHVGhyWWU3UjV4dklTN0ZUVEN6ZmxHME9rcjZx?= =?utf-8?B?V0ZFNnRjNUM5eWtLTDhXMnVFNXB4V3hydm4xMjJQRTVuNEF6Q2tmWHM4WWli?= =?utf-8?B?UVdXK210U0ZUTGhUVThnRVRxd25KREdSQ3FQZlY4SGQ4REYwVFpDcWxsVEJt?= =?utf-8?B?WWk1d01qM3NrTjd0U3RoZU5mV3d0ck5TaGhKNU1BRGVvekR5RndaRlYweXR5?= =?utf-8?B?V0xRMzZRL2VtWjhYcGdNNmhZeFRWdXRxNHU0L1IzNnhGZkh4QXQ0OHZ1MzF1?= =?utf-8?B?OE9RTE9vTk5SdkZxbk5nWEFWY3Z5UjFYWGtjdEF1cytaZGVKUXlHSEpxb3RP?= =?utf-8?B?eGVLR2thNkQxaFdKTStZQjkrUUloRDd1M2tTTFVqWDBzUEdRTWRpZldKNTdl?= =?utf-8?B?M2NiRE1teDYrYUhGYy9hbTh3Wk9JaGljMTF2T0Y0VlRxTjlIZWlHYklBb2E0?= =?utf-8?B?RjhSbWM0MWRCMGZzQk9GQWtubDZhNzVBMjZIc3FiRG0rZ29oRGhuL0l1OUsy?= =?utf-8?B?UWluKzZXT0FtQjJBT0ZaUzVxNzZyb282eTFJcDd4WmRIRmU0ZDAwNmxOcnd0?= =?utf-8?B?V2FaQ0c3RlpCZ1J0UXByODk2Q0dqNUxyTjEzeUdZV2p4L1NnL21YQ3ZtVkpm?= =?utf-8?B?TkN3cXJXcmJVRG1LZHpMMnN1L0tsdS9HRmt1bHE2VmVYeVFyS1NYOGttV0Uz?= =?utf-8?Q?X349z9KpTHpU1zGx5OsMm08=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 5ac78c45-a56f-4859-078d-08d9fc52d3a9 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2022 13:44:51.9942 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: w0oqgrGbcNrhugkfQU61iI3m81yFT09p0vKS0W6ukPbDZHYRjLka9R0nUhGr70TI0SrqiDh285P5cDcfmMj9kg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR03MB2251 X-OriginatorOrg: citrix.com If livepatching support is enabled build the hypervisor with -f{function,data}-sections compiler options, which is required by the livepatching tools to detect changes and create livepatches. This shouldn't result in any functional change on the hypervisor binary image, but does however require some changes in the linker script in order to handle that each function and data item will now be placed into its own section in object files. As a result add catch-all for .text, .data and .bss in order to merge each individual item section into the final image. The main difference will be that .text.startup will end up being part of .text rather than .init, and thus won't be freed. Such section only seems to appear when using -Os, which not the default for debug or production binaries. The benefit of having CONFIG_LIVEPATCH enable those compiler options is that the livepatch build tools no longer need to fiddle with the build system in order to enable them. Note the current livepatch tools are broken after the recent build changes due to the way they attempt to set -f{function,data}-sections. Signed-off-by: Roger Pau Monné --- xen/Makefile | 4 ++++ xen/arch/arm/xen.lds.S | 9 +++++++++ xen/arch/x86/xen.lds.S | 9 +++++++++ xen/common/Kconfig | 4 +++- 4 files changed, 25 insertions(+), 1 deletion(-) diff --git a/xen/Makefile b/xen/Makefile index ed4891daf1..bf14a9bdd2 100644 --- a/xen/Makefile +++ b/xen/Makefile @@ -269,6 +269,10 @@ else CFLAGS += -fomit-frame-pointer endif +ifeq ($(CONFIG_LIVEPATCH),y) +CFLAGS += -ffunction-sections -fdata-sections +endif + CFLAGS += -nostdinc -fno-builtin -fno-common CFLAGS += -Werror -Wredundant-decls -Wno-pointer-arith $(call cc-option-add,CFLAGS,CC,-Wvla) diff --git a/xen/arch/arm/xen.lds.S b/xen/arch/arm/xen.lds.S index 08016948ab..1c7c7d5469 100644 --- a/xen/arch/arm/xen.lds.S +++ b/xen/arch/arm/xen.lds.S @@ -33,6 +33,9 @@ SECTIONS *(.text) *(.text.cold) *(.text.unlikely) +#ifdef CONFIG_LIVEPATCH + *(.text.*) +#endif *(.fixup) *(.gnu.warning) _etext = .; /* End of text section */ @@ -96,6 +99,9 @@ SECTIONS *(.data.rel) *(.data.rel.*) +#ifdef CONFIG_LIVEPATCH + *(.data.*) +#endif CONSTRUCTORS } :text @@ -208,6 +214,9 @@ SECTIONS . = ALIGN(SMP_CACHE_BYTES); __per_cpu_data_end = .; *(.bss) +#ifdef CONFIG_LIVEPATCH + *(.bss.*) +#endif . = ALIGN(POINTER_ALIGN); __bss_end = .; } :text diff --git a/xen/arch/x86/xen.lds.S b/xen/arch/x86/xen.lds.S index 83def6541e..81bb608151 100644 --- a/xen/arch/x86/xen.lds.S +++ b/xen/arch/x86/xen.lds.S @@ -88,6 +88,9 @@ SECTIONS *(.text.cold) *(.text.unlikely) +#ifdef CONFIG_LIVEPATCH + *(.text.*) +#endif *(.fixup) *(.gnu.warning) _etext = .; /* End of text section */ @@ -292,6 +295,9 @@ SECTIONS *(.data) *(.data.rel) *(.data.rel.*) +#ifdef CONFIG_LIVEPATCH + *(.data.*) +#endif CONSTRUCTORS } PHDR(text) @@ -308,6 +314,9 @@ SECTIONS . = ALIGN(SMP_CACHE_BYTES); __per_cpu_data_end = .; *(.bss) +#ifdef CONFIG_LIVEPATCH + *(.bss.*) +#endif . = ALIGN(POINTER_ALIGN); __bss_end = .; } PHDR(text) diff --git a/xen/common/Kconfig b/xen/common/Kconfig index 6443943889..2423d9f490 100644 --- a/xen/common/Kconfig +++ b/xen/common/Kconfig @@ -353,7 +353,9 @@ config CRYPTO config LIVEPATCH bool "Live patching support" default X86 - depends on "$(XEN_HAS_BUILD_ID)" = "y" + depends on "$(XEN_HAS_BUILD_ID)" = "y" && \ + $(cc-option,-ffunction-sections) && \ + $(cc-option,-fdata-sections) ---help--- Allows a running Xen hypervisor to be dynamically patched using binary patches without rebooting. This is primarily used to binarily -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 02 14:15:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 14:15:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282259.480894 (Exim 4.92) (envelope-from ) id 1nPPlR-0006Ha-Db; Wed, 02 Mar 2022 14:15:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282259.480894; Wed, 02 Mar 2022 14:15:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPPlR-0006HT-AU; Wed, 02 Mar 2022 14:15:37 +0000 Received: by outflank-mailman (input) for mailman id 282259; Wed, 02 Mar 2022 14:15:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPPlP-0006HN-Rs for xen-devel@lists.xenproject.org; Wed, 02 Mar 2022 14:15:35 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 39856e33-9a33-11ec-8eba-a37418f5ba1a; Wed, 02 Mar 2022 15:15:34 +0100 (CET) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05lp2176.outbound.protection.outlook.com [104.47.17.176]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-5-G3801V12MoG403ruI3k6uA-1; Wed, 02 Mar 2022 15:15:33 +0100 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by DB9PR04MB8187.eurprd04.prod.outlook.com (2603:10a6:10:24a::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.14; Wed, 2 Mar 2022 14:15:32 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5038.014; Wed, 2 Mar 2022 14:15:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 39856e33-9a33-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1646230534; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=kex8qq4jf+Lazih0UJdwgvdNdQX3ZI+g+eEJI7hKduo=; b=gGQKCj5Z6TKwoiDGDtxQXyTq2ugo9hE66nFjJz0SyzQtTLZK9OGoBIwrDiga6ieufCRXUn uRNGB4U1IgUzN5VvLNgUIy7J0QEyaPkGR0FIgS5O6Cy/JqT/4ibX3ny0vIH4EBKwD7hX3n ERvWuBHW7SwOJF6X6PO1fI2F9W+e0UI= X-MC-Unique: G3801V12MoG403ruI3k6uA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jdlmRpwW61ferpDxv3cwIJ+p7UnEpaxmEe0S9s81QN1Xrlf3HdPZ2FMaMKMEWNH5O5bkXtasBvXf6APMuWnKpsHZNno8N2v13pkl9Wl5Z9bPElmQD2DOoWrbAXn/CndPPvyfVU5SLwo+gbQvC4Lc4tSvFnwca3GrfpBbvnMLh1iDbC7pWeB663iazJGe8s7MYFp/p07iiopuOPcgvFhnvPGJccasVkRDSKpFn1Tf/NDIAr8HUpDmrLJqwnZJwZl4WUqtvah70a+PdL8M9JRc19feJwDFL5J7YvosdDF5BDbwf6qGBsaPkIb+SKN2RCC8VEHop/3E96zaoId+U09WLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kex8qq4jf+Lazih0UJdwgvdNdQX3ZI+g+eEJI7hKduo=; b=mib305QBesE5Q6zjzC7C80gl5Z1OMSKmyvRNhidq53DUovemvPpzpaHfTy2+N5Smp3qWYRobFhGErJKutekOX+V8zs/6VTEyeQ2+ynCr6Lzo0zS4t3wN+qv4fBN72hMt1rPdA0Os4eK21B5lY6reL10MVtLin46/aySiKUixQncf/sAifR39Z0G5bXOCdE0h2ld2rt4LinlZP84YInmcjQ78PfTj3fgcuU1zzEmYpdnS6HWEvwJQieq6BWNUO3+bDbzSjNmY2s/iruB3vi5OC+t6r6LKejW/rPupdVoG9Ezn7MarSN6cGoiM/tCZ0l2IKR7y+32XyhKu7rQLiFemUQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <1791edb8-030f-1009-c392-ce793baace5a@suse.com> Date: Wed, 2 Mar 2022 15:15:29 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= From: Jan Beulich Subject: [PATCH] x86: drop use of CONSTRUCTORS from linker script Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR0301CA0024.eurprd03.prod.outlook.com (2603:10a6:20b:468::31) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8daa964b-8785-4d87-e31b-08d9fc571c27 X-MS-TrafficTypeDiagnostic: DB9PR04MB8187:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fIvHwW24R+cm15+lphyrvIIKb5HUUSs6s/xsq5BUxj2D4GD5VZfziR291b9dYMNvIHVClWyiMaHNDjs2/x7aU77i4qt9YD03UsRGotfeOSQAWV6rXswLX1x/1Ep8MvGORA+gfEA2Z74bPJoDTcqIPZrKZ2goawU7VCPjiDVAEtk0hWiE5lPsl+qny35gYHqJJwRMjRUyyukqBPUUQbYHw0HTBOeBLvQEe5I7yTaPWEExEOxNAxdvPPsRuIQ8Rv3gamr6Leak93E7L1+a52Gmk+UouXobkQE2DzyJvtovendov2oCvEkxEA8UglvQ8fWrPob+HBUxx/+G7tqmhQEJWr7eZfjv00aPQjvzFawgv681PvE7jR+W1SK3WHbRcZnASU7YDSZVot5bZJm+B4Z1atMRNgB8dbJ2JrMT4+lTmALy6zA5qh2tDzwJ2voyumBO0UwQSdKNPWHdOMpW4o43cbv/sPsKnUzVzKgSvOoT4BxoeB+GoKhqiqJdjdzp3ZHjH0sFuQj+W15RvhT36cc6NiHGr/TPx7KoTiasGbsqV7yBjpzJZfDdV2mv3m8njApMXLSS9xTd/jdLNu37QuEzinWo31ISvN5wc9CMJP6R+XcbdMU4Sf9oxS8DF9H18ultJkw/bHuM9LQSdYFkn7Fo0unktAMHbTH4lNDqUMo/m78Pmic4TuzmLRHowmQkJHk07nWKYf9SXURvT0EfcfAQHlL8mzrL1u9gdINpsDix08k= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(4326008)(6916009)(5660300002)(508600001)(2906002)(6506007)(6512007)(38100700002)(66476007)(66556008)(66946007)(31696002)(86362001)(8676002)(54906003)(36756003)(8936002)(4744005)(26005)(186003)(2616005)(31686004)(316002)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cmdOelc0WlJXWUhXQmhmN3h4YWxtd3JWMWV6MjhqeUZDYW4wY01MVzErekxR?= =?utf-8?B?bDQzV1h6bGY5Z0FWUTBiSThGOHAwQzRhYUxHK09JK295ZHVKQ3BJTXZiM0lH?= =?utf-8?B?QXBsOC9nT2RXa0U1cXppN2xKdmRIYzEvZm43N3p2QXUvelQyMU94N0w0L3Jo?= =?utf-8?B?ZlpIRWhqMzdCQnNXV3RJMURtQmFZbFFra3M2QWFRblJRUlZMdUhrNCtoRjhO?= =?utf-8?B?TVZNUWFMYzJTZVNkMjA1S2o5WEFlMXZ6MWpiV3ZCK3VVL3gvRWVIRVpBUVlu?= =?utf-8?B?MzgwTmZLSk5OMXpZd21HeHllWUNUa3FqUzFpS1JveHJIOFQ0dHN0Y1M2R0lE?= =?utf-8?B?N1A1R1pHQVNhdFI0VERWQ09qd2VKM0MyaWpCcEtQYWVPdmRFN3ZxWGFNckh2?= =?utf-8?B?MC9IR0c2c09ZeEYzWkhuVWEvbVNQRFd0clJBZlRJQWtjbTF3M1c0VDhQTnl0?= =?utf-8?B?V05SMklmbyt1Tnp4OUVpVDhiZVlITFBzbmFGOU1UOW9lejF3aW52eGsyMUtC?= =?utf-8?B?S1VCdi9CYzBWYXVUS3NRaGVjdXdOaC9QcjUrckN1TVplSEVOenNTa0RsL29L?= =?utf-8?B?TFZrNHVtNFRQWmVzTzhnMGlKY0RDRm14NHdpMEl0aEdHaTlWMitTVTNvTzR2?= =?utf-8?B?TnR6Q3ZyL01ST0paZjVsN01nSmdONXRYQ3hUTHIvRGNPMzJ1ajZLUnc1UTVH?= =?utf-8?B?MzJMQkxLNGJPaXVjanl1Q0ZyRGR6aFdtanNKckp0Wi9XQzM2bnZUVDVJb0xV?= =?utf-8?B?UFMxMVlkUWgwQW0rc2Z1cFE1QjVPZFVwQ0JzdjFBRFAwK0JGS2FUMnIwYW1V?= =?utf-8?B?N2o5cW9kUGppRlk3V2VqbUEwcklXMTVkcnY5QnJsOEVoa3YwOUxhVjdoZjB6?= =?utf-8?B?K1dyeXN5OFNqSEROSFp0ME9zczdtZW4rclFOSFdoR2czdWdxVXFBMW5CcVJx?= =?utf-8?B?aDByRCt6OU5aeXU1c2FGVGZ1eFBUUEdaSVFMa2laNmdxd1Q3QkI3NHBHc0kz?= =?utf-8?B?d3pncTFyamluRUxxRnFpUkVDdUV3VGdzYnJYQlBMY0hicFd5Ky9jWGV1bU5o?= =?utf-8?B?V2NralFBSDRPQ1pLWjBrTWtnK01DU2dvQiszWExlQVZkVGNHOXovcUtFQlR5?= =?utf-8?B?NWJXb0FUcFRacjNxTStRcmRzM3JVVEFabTJrQ2VZZGpIMUc4VzRMWmJsTEN3?= =?utf-8?B?UHk1SEFOaldzM0hMTWdNRXNOTGdrRnJybkU4UlV2eDRoUE15SU8xaUVtYXpB?= =?utf-8?B?dnh5endsdE80d3NXYS9LQ0pzS0ZZMUtQZzBMZnR0NDZwMmhnZ2R2dGlsTmtQ?= =?utf-8?B?U2NQNDNteGVEZmFQOHFqeHU1N096SDhkM003Qy9PWTUvNGltRUJHcmFCN2Vi?= =?utf-8?B?d2d3Y2UwZzFoc1NOTUlTZDJFTWhHSWVodXNUWTdwMjFNWlVBUExpQ1VwL1R3?= =?utf-8?B?b240UlFZNldSdFRtdDZlUXFJQWpNT3ZMWUN3dWE2b05PV0V5NGdibnJBODQx?= =?utf-8?B?SDFRQnpSQTRLeUl1Smhob1NFYmR4OGtlLzd5U3EvNjRENWxlTXhjWnBmL1B3?= =?utf-8?B?UXpJTXowbDFNTmdVU1JpWnFmdXllS05sekdKcU9CS3dUVlB3WldwQXRTLy9t?= =?utf-8?B?U0h5YkFIa1RFUU1mNW9jbFBiQ3pzUlBRWGIwVlhWM2h5dEFoenlNY0M4c3Ba?= =?utf-8?B?SjlrR29KR0JpWUYwdzBGN2VUWGVaNDY0alR2d3plMng0QzhkanlaYUdzc2Ja?= =?utf-8?B?cWR3VUtkd2RCOFhZV1FRVktubENJQlNrbkIranZIY2FYbERleDRnOTNHQlpz?= =?utf-8?B?SlVqaFp4UGFRK29VV25wSWdmYVpyZEFYVFNhN0s4WVpOcTNYVjMrakYrZzBv?= =?utf-8?B?UW5SdTVITzVGMzVteHZYWFVYSHcvMXB6RnVsS3JneFExMEJDdnlRVGo5ZDBm?= =?utf-8?B?TG1zUUE0OXMySUdPMGJ3SGpVQ0dqdkduVE1sNHZ1cTFzV0tBY1pCenBFc01N?= =?utf-8?B?Ujgrd3pzdy9LMDVzRzI1VTVYaGt1SndnMDZQNzloeVN2aS9DdmVBcG1NQWVK?= =?utf-8?B?RHdSV1U3WU5aUm0yUFhNek0vaG5GTk9TMmQzV3l6bE9UWWpjVFQ4am5iTWZq?= =?utf-8?B?dWlUcURXZmtMRkw3dVdicEliak9INnU5ZnN1b2RLZnhsMWNQc3RqcTJzeEVo?= =?utf-8?Q?jU4Sf2/84P/7PRbMcDJNh4o=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8daa964b-8785-4d87-e31b-08d9fc571c27 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2022 14:15:31.8428 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AyiMN36iK/9p08eBRJyiGrYeKSTYRhkeWFmCEQYup6Pbj7FTQATPOTz9W6wlX69lD1yioZZpenvwXc01pH9XHw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8187 Current binutils document this for use by a.out only. Plus we deal with .ctors and alike sections elsewhere in the script anyway. Signed-off-by: Jan Beulich --- a/xen/arch/x86/xen.lds.S +++ b/xen/arch/x86/xen.lds.S @@ -292,7 +292,6 @@ SECTIONS *(.data) *(.data.rel) *(.data.rel.*) - CONSTRUCTORS } PHDR(text) DECL_SECTION(.bss) { From xen-devel-bounces@lists.xenproject.org Wed Mar 02 14:19:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 14:19:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282267.480909 (Exim 4.92) (envelope-from ) id 1nPPpR-0007BI-1k; Wed, 02 Mar 2022 14:19:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282267.480909; Wed, 02 Mar 2022 14:19:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPPpQ-0007BB-TK; Wed, 02 Mar 2022 14:19:44 +0000 Received: by outflank-mailman (input) for mailman id 282267; Wed, 02 Mar 2022 14:19:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPPpO-0007Az-SN for xen-devel@lists.xenproject.org; Wed, 02 Mar 2022 14:19:43 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cc37cc6f-9a33-11ec-8539-5f4723681683; Wed, 02 Mar 2022 15:19:40 +0100 (CET) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05lp2111.outbound.protection.outlook.com [104.47.17.111]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-41-oPQJonF3NW-Iuaxebzt89Q-1; Wed, 02 Mar 2022 15:19:39 +0100 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by DBAPR04MB7317.eurprd04.prod.outlook.com (2603:10a6:10:1b3::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.26; Wed, 2 Mar 2022 14:19:36 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5038.014; Wed, 2 Mar 2022 14:19:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cc37cc6f-9a33-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1646230780; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=kelBkq07elBsYoool1T4WiBB6X/D8ea/mBgL1h/Su9k=; b=g3g/zGhVgO9rYDhyDS6UbOIHkDULNetPcO9cwYgPrklHljO/Oke24LXvSB+EPlvlIn8Bgv xqBMTq8eWqxbCjA4+PBH5TiWZH8znoa6r8ZC6V5l0DQPFzDNwgokNdVaxv+vX1M+zaZoMq COZUTibnPXPSVMff7GyAQN+lL4ACm30= X-MC-Unique: oPQJonF3NW-Iuaxebzt89Q-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I9wzWLkUF+zHlg2L8XHA86sUirSPvl1VYHJfFn18ivZ3XgOJnON0Axk5VZJeiwkQOWNuBWYHfZtwhn33xrptTr+QSgcaxefWrocvox0RHnKqQHrKempjmFxAX4gNrf+jjNn14CgV8vNe+3JgLdwMSanygCA908eyYgZSzd4sId+0IzqnLQJPa8t068xbyljnc6Iw3sSzGesPSl67oCMJ0b3Lhj6mfYhMvmL2QvxuIYDRqzhiOawH/X19/u5YQOqOMVaIckLZTJT2WEoKNSjtYCpEL5XCAyuoUY3f5bG/oXjlCSxs7zZzsBdEk0sxsnYu57fHn1mjq7CAovLd3iIF7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Chofcp21Zt4lwYIAQLwleWr03SoVKieQ1Dr41FdW3rY=; b=IRKPwUcHuzm9MfLJ7PCXlGsjqxT8jGAxmycoexCaGxaSQkMPGu5Ge4PgQIZOIAAtnbEC8CmxkLnI3C0TunpeirsT3blcnD5ZSCRKkpXagsQLY4bl6hXOpQn7D99jyHHaBhjwXzX/hTZI9R2+UphgKhcr+CKdHKGm0hThBA8DAYWU6X2TW8a5co2FSDX/suBoKvYzlUWgMdiB7krXBh8XVjqGQsHOQ2e7Hd1A5Cq4t2opYEao6Ns3SoHo7h+VVLxZHIyQtVi2JFdfu7OpDToIjKlY+5fLZXXqOWgxAM6vgnU2vB274NyefiYOz9Ny3K5TIlRf07njkR224LaIkwMvbg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <5c374fd3-017d-3c40-4ded-25a3b1c978a6@suse.com> Date: Wed, 2 Mar 2022 15:19:35 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Content-Language: en-US To: "xen-devel@lists.xenproject.org" CC: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= From: Jan Beulich Subject: [PATCH] x86/build: use --orphan-handling linker option if available Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS9PR04CA0075.eurprd04.prod.outlook.com (2603:10a6:20b:48b::24) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a84bb868-6893-4d55-c649-08d9fc57ae34 X-MS-TrafficTypeDiagnostic: DBAPR04MB7317:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WkglUsYHAj4shxRskNVC68KxLB8Ge3qgW2pAPUXabVgsY8skjQTdrS8HyLujEv3QEBfFcKhSbqeSBulLIe00dy4VFlCKubAZEBjUX3DpH+KjaC3/lEozwV7Uj1lOX7SgFioCQiMGMsxxboFi9uGKh95TAlLz+Kzry6kthYsy1f1n5KwfYuhM/tUZKqM3HHZup9LUnkDcz5D1y+Dx4EOOHVUDoluCW/n4F6RqOu/RQf1TsxKcKidOroDDahcrNrIqFrEHY6+XsK7w8uaV9hzwJMftQ8PEzdE/twZ/DbTYqcwmbkLHOwSCyUDHHujdqE5qlZkDtB65xad0ybir7pXKcpd0+yDMOQuABLT83lSeyTt84tQKZkNxZsA7shXpcdGiwmaKBX8SLLLxmh8y9WVq2cq90houG4uFeh5Pcld6d6EinBShfZ9k2EqPgibb6niWVji9lOD6GBTGTTNB5n+L0bkSiHXKZIlt6YB6AriNJjRHGRPOh62R2TSDtH2SCm9PZDnn9CayqKMwkcR8rbZmUqa11Y2wFXKFDXIbNlAi2tlq65z6VcgtvuSQK/tk83ObyBtp1Ggsvt79+Z7fOAyy88E9+MRu/TxNYiNatAEx+3Ps5LslysfI+PwprjLh+4jgYmMbF68b4cyFJRQ/d2v4vGc+dWJPcsC3R5EHI5TVyvztS/6ZyCyDxhvp1lmv6/7NlurlZGI+XFZ6Tfzc89NRQAksdCntEUsgiOIyhIJdUbByvyAxV6Pu7RdlE8/ibRCLPEVaxJgPtbVmysKC+mRIbtavh6BTy60aIV0j+1LBDY/0LMryS+m21nmu+SgfQSJJEdKsE+zkiubV9qOmYestUw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(36756003)(54906003)(8676002)(66476007)(66946007)(316002)(2616005)(966005)(66556008)(8936002)(31696002)(508600001)(4326008)(31686004)(6486002)(2906002)(6506007)(5660300002)(6916009)(38100700002)(6512007)(83380400001)(86362001)(186003)(26005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?To4REdV5EGtXAKvVaymZ05dRjeDyJNpM2BIpoi/0G+6aAzC1TwKNx5TuH7sg?= =?us-ascii?Q?9XH5C9p7Qf8CtuKIBQPdcMyqC1jEpbvf+0Jv2sxTba2DSdSel0TnKA7xJ9i1?= =?us-ascii?Q?Se82wnf+jPYx/AVK3DTmJG5cU7ztiYEuJYVPZXMOi4j5NIPzIHu4Fpn7wDss?= =?us-ascii?Q?GJLP4FR84MZOyTmHOIHyrI4DzWk4bRGQJKxPLmmL5Oabwr7ZP06APy7CPraH?= =?us-ascii?Q?1xrwt4BfeQmQXLc01VlFSUS0DTTnQWbz7Wx+Nt9qjqQc2EMXPuhzi+Kv1oBo?= =?us-ascii?Q?oZUn172SsbZOqIUFwU9Q2Z8x3WHgICyy1j4WqyWP5BPAP/WHNoPj7F3u7c41?= =?us-ascii?Q?KbV6y0BqR8CT+Eul0TtgHzPFokn+dYZwFDQ2rgyn6KAvzD3Y87PZFmOgXcYb?= =?us-ascii?Q?QMiw5ksWmsX4+72lgI1lLdaDSb71Nh8k2lGkY6/qMCOy1goRy+lTiZrRC7hI?= =?us-ascii?Q?aoFi5ncJyMyaVFsirNuDWNdQ1I/VEjP9+6KGPhBMD51OaOldZeuQImboFFwK?= =?us-ascii?Q?qzYoWBJzLrvhVQ/YSZshIgHcm1OQep4NE2J3T8AYalfQ4Nsy7goWSg+SYbJ7?= =?us-ascii?Q?6e5QPDWMxevrmhk0G3XQmQ2Q0H8HnZpcaQk+jaDQHIAQfMmzXTkm12hi8F8z?= =?us-ascii?Q?cIX2tOiAMuhSLLpFDXG1puZpSrAf0T+gjMYpboZPw4TrqA7kletYMR0cV83r?= =?us-ascii?Q?3131H0UQkfZ8iL4hZc9qNcCrgM+BAJDj4Uxl8zNaG2Z/oIIFGxVIBGu+AS9i?= =?us-ascii?Q?940BgfWIWp/Xe8zVQu76pwrxyT+0nW3mbRri/xQXvHUWAZaSbS4nVHo1DADR?= =?us-ascii?Q?uzn9KXvqq1nmAwt4aGUhT5nmMs9trE9Gw0xYEqDbUvlM+Ddwe3Dwgkf/Ez5e?= =?us-ascii?Q?tAL/rQ0SyAFHrre0TV/+KlN/Z1hkkG0wkYIHEiPZ41VP2oX/t1RVaO2vLjeF?= =?us-ascii?Q?iZF3oBqdBgSpPyotefi9uqMMfDZGZW8YLUXC6UcQTuyX9tUxSkuNe0PsslA/?= =?us-ascii?Q?9quw3SzH+w/ZzUIVlcl7jLyOI6U4y4IUk1pN1zPTRUpfBcI3xS7uS6Hjym5y?= =?us-ascii?Q?rZaywNHi7ogoGLXvdrD0BuLlYySGxh95fhpTBzWjZggEJhOSfqDPx1aOS3/D?= =?us-ascii?Q?HJaQgKRjxdIxdHcFw9Nm8z7Uw42+hPa+AsA0vDY98Jf9yX2WiYclPN29q1Ht?= =?us-ascii?Q?schwLo321o93nd8j1QHej49XfTND8NQPsykSbT7XQBk/+WS9LCQhQky/+PYc?= =?us-ascii?Q?JaKrdq6nnWLQRUnPTR+75oJnlCJbqrLgsZerVCq+bVfkaLOJEhvmcbOkvTeW?= =?us-ascii?Q?e8h73UnEajRWfzI1SiA+gAdbWcZWewjzSC0RaFqP3CQrzxIb4FXXs+NYwIww?= =?us-ascii?Q?DeeNn3Ir6Xp1k6GqrNXk+pfoYOpXxUrhNKxILMOPNYEtGsTaspBTAT0wHLOb?= =?us-ascii?Q?p8E8rWMGRGPtltM1UDqrtpdjTxbRK7EXt3Z37sg7FfRWZqLru10jdwynAdvy?= =?us-ascii?Q?6NSJyL1dKAsIa0x1ePOm2gZIwGKrhF+4IlU5nIw/yilQQCnSj4zyQ08CEwse?= =?us-ascii?Q?Vky/GQFnC5Z7djGE/7z9GfZ0w0k8WPihznNu4zws3bmv3rbPe/bPsrFz+dxy?= =?us-ascii?Q?MPFvs9JQ7DVWl0U/5iFnlh8=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a84bb868-6893-4d55-c649-08d9fc57ae34 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2022 14:19:36.5778 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +nzK4bHKYmd1cqt/6d0NEKq5BfZrLEJJu+E5O1c4KExPcZ9M1i6VbTJcyzhechZ3SAmSIKW9mO/SLmkLJr5Ygg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7317 As was e.g. making necessary 4b7fd8153ddf ("x86: fold sections in final binaries"), arbitrary sections appearing without our linker script placing them explicitly can be a problem. Have the linker make us aware of such sections, so we would know that the script needs adjusting. To deal with the resulting warnings: - Retain .note.* explicitly for ELF, and discard all of them (except the earlier consumed .note.gnu.build-id) for PE/COFF. - Have explicit statements for .got, .plt, and alike and add assertions that they're empty. No output sections will be created for these as long as they remain empty (or else the assertions would cause early failure anyway). - Collect all .rela.* into a single section, with again an assertion added for the resulting section to be empty. - Extend the enumerating of .debug_* to ELF. Note that for Clang adding of .debug_macinfo is necessary. Amend this by its Dwarf5 counterpart, .debug_macro, then as well (albeit more may need adding for full coverage). Suggested-by: Roger Pau Monn=C3=A9 Signed-off-by: Jan Beulich --- I would have wanted to make this generic (by putting it in xen/Makefile), but the option cannot be added to LDFLAGS, or else there'll be a flood of warnings with $(LD) -r. (Besides, adding to LDFLAGS would mean use of the option on every linker pass rather than just the last one.) Retaining of .note in xen-syms is under question. Plus if we want to retain all notes, the question is whether they wouldn't better go into .init.rodata. But .note.gnu.build-id shouldn't move there, and when notes are discontiguous all intermediate space will also be assigned to the NOTE segment, thus making the contents useless for tools going just by program headers. Newer Clang may require yet more .debug_* to be added. I've only played with versions 5 and 7 so far. Unless we would finally drop all mentioning of Stabs sections, we may want to extend to there what is done for Dwarf here (allowing the EFI conditional around the section to also go away). See also https://sourceware.org/pipermail/binutils/2022-March/119922.html. --- a/xen/arch/x86/Makefile +++ b/xen/arch/x86/Makefile @@ -120,6 +120,8 @@ syms-warn-dup-y :=3D --warn-dup syms-warn-dup-$(CONFIG_SUPPRESS_DUPLICATE_SYMBOL_WARNINGS) :=3D syms-warn-dup-$(CONFIG_ENFORCE_UNIQUE_SYMBOLS) :=3D --error-dup =20 +orphan-handling-$(call ld-option,--orphan-handling=3Dwarn) +=3D --orphan-h= andling=3Dwarn + $(TARGET): TMP =3D $(@D)/.$(@F).elf32 $(TARGET): $(TARGET)-syms $(efi-y) $(obj)/boot/mkelf32 $(obj)/boot/mkelf32 $(notes_phdrs) $(TARGET)-syms $(TMP) $(XEN_IMG_OFFSET= ) \ @@ -146,7 +148,7 @@ $(TARGET)-syms: $(BASEDIR)/prelink.o $(o >$(@D)/.$(@F).1.S $(MAKE) $(build)=3D$(@D) $(@D)/.$(@F).1.o $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds -N $< $(build_id_linker) \ - $(@D)/.$(@F).1.o -o $@ + $(orphan-handling-y) $(@D)/.$(@F).1.o -o $@ $(NM) -pa --format=3Dsysv $(@D)/$(@F) \ | $(BASEDIR)/tools/symbols --all-symbols --xensyms --sysv --sort \ >$(@D)/$(@F).map @@ -220,7 +222,7 @@ endif | $(BASEDIR)/tools/symbols $(all_symbols) --sysv --sort >$(@D)/.$(@F).1s= .S $(MAKE) $(build)=3D$(@D) .$(@F).1r.o .$(@F).1s.o $(LD) $(call EFI_LDFLAGS,$(VIRT_BASE)) -T $(obj)/efi.lds -N $< \ - $(@D)/.$(@F).1r.o $(@D)/.$(@F).1s.o $(note_file_option) -= o $@ + $(@D)/.$(@F).1r.o $(@D)/.$(@F).1s.o $(orphan-handling-y) $(note_fil= e_option) -o $@ $(NM) -pa --format=3Dsysv $(@D)/$(@F) \ | $(BASEDIR)/tools/symbols --all-symbols --xensyms --sysv --sort >$(@D)/= $(@F).map rm -f $(@D)/.$(@F).[0-9]* $(@D)/..$(@F).[0-9]* --- a/xen/arch/x86/xen.lds.S +++ b/xen/arch/x86/xen.lds.S @@ -12,6 +12,12 @@ #undef __XEN_VIRT_START #define __XEN_VIRT_START __image_base__ #define DECL_SECTION(x) x : +/* + * Use the NOLOAD directive, despite currently ignored by ld for PE output= , in + * order to record that we'd prefer these sections to not be loaded into m= emory. + */ +#define DECL_DEBUG(x, a) #x ALIGN(a) (NOLOAD) : { *(x) } +#define DECL_DEBUG2(x, y, a) #x ALIGN(a) (NOLOAD) : { *(x) *(y) } =20 ENTRY(efi_start) =20 @@ -19,6 +25,8 @@ ENTRY(efi_start) =20 #define FORMAT "elf64-x86-64" #define DECL_SECTION(x) #x : AT(ADDR(#x) - __XEN_VIRT_START) +#define DECL_DEBUG(x, a) #x 0 (NOLOAD) : { *(x) } +#define DECL_DEBUG2(x, y, a) #x 0 (NOLOAD) : { *(x) *(y) } =20 ENTRY(start_pa) =20 @@ -179,6 +187,13 @@ SECTIONS #endif #endif =20 +#ifndef EFI + /* Retain these just for the purpose of possible analysis tools. */ + DECL_SECTION(.note) { + *(.note.*) + } PHDR(note) PHDR(text) +#endif + _erodata =3D .; =20 . =3D ALIGN(SECTION_ALIGN); @@ -266,6 +281,32 @@ SECTIONS __ctors_end =3D .; } PHDR(text) =20 +#ifndef EFI + /* + * With --orphan-sections=3Dwarn (or =3Derror) we need to handle certain= linker + * generated sections. These are all expected to be empty; respective + * ASSERT()s can be found towards the end of this file. + */ + DECL_SECTION(.got) { + *(.got) + } PHDR(text) + DECL_SECTION(.got.plt) { + *(.got.plt) + } PHDR(text) + DECL_SECTION(.igot.plt) { + *(.igot.plt) + } PHDR(text) + DECL_SECTION(.iplt) { + *(.iplt) + } PHDR(text) + DECL_SECTION(.plt) { + *(.plt) + } PHDR(text) + DECL_SECTION(.rela) { + *(.rela.*) + } PHDR(text) +#endif + . =3D ALIGN(SECTION_ALIGN); __init_end =3D .; __2M_init_end =3D .; @@ -321,71 +362,6 @@ SECTIONS *(.reloc) __base_relocs_end =3D .; } - /* - * Explicitly list debug section for the PE output so that they don't en= d - * up at VA 0 which is below image base and thus invalid. Also use the - * NOLOAD directive, despite currently ignored by ld for PE output, in - * order to record that we'd prefer these sections to not be loaded into - * memory. - * - * Note that we're past _end here, so if these sections get loaded they'= ll - * be discarded at runtime anyway. - */ - .debug_abbrev ALIGN(1) (NOLOAD) : { - *(.debug_abbrev) - } - .debug_info ALIGN(1) (NOLOAD) : { - *(.debug_info) - *(.gnu.linkonce.wi.*) - } - .debug_types ALIGN(1) (NOLOAD) : { - *(.debug_types) - } - .debug_str ALIGN(1) (NOLOAD) : { - *(.debug_str) - } - .debug_line ALIGN(1) (NOLOAD) : { - *(.debug_line) - *(.debug_line.*) - } - .debug_line_str ALIGN(1) (NOLOAD) : { - *(.debug_line_str) - } - .debug_names ALIGN(4) (NOLOAD) : { - *(.debug_names) - } - .debug_frame ALIGN(4) (NOLOAD) : { - *(.debug_frame) - } - .debug_loc ALIGN(1) (NOLOAD) : { - *(.debug_loc) - } - .debug_loclists ALIGN(4) (NOLOAD) : { - *(.debug_loclists) - } - .debug_ranges ALIGN(8) (NOLOAD) : { - *(.debug_ranges) - } - .debug_rnglists ALIGN(4) (NOLOAD) : { - *(.debug_rnglists) - } - .debug_addr ALIGN(8) (NOLOAD) : { - *(.debug_addr) - } - .debug_aranges ALIGN(1) (NOLOAD) : { - *(.debug_aranges) - } - .debug_pubnames ALIGN(1) (NOLOAD) : { - *(.debug_pubnames) - } - .debug_pubtypes ALIGN(1) (NOLOAD) : { - *(.debug_pubtypes) - } - /* Trick the linker into setting the image size to no less than 16Mb. */ - __image_end__ =3D .; - .pad ALIGN(__section_alignment__) : { - . =3D __image_end__ < __image_base__ + MB(16) ? ALIGN(MB(16)) : .; - } #elif defined(XEN_BUILD_EFI) /* * Due to the way EFI support is currently implemented, these two symbol= s @@ -400,6 +376,42 @@ SECTIONS efi =3D .; #endif =20 + /* + * Explicitly list debug sections, first of all to avoid these sections = being + * viewed as "orphan" by the linker. + * + * For the PE output this is further necessary so that they don't end up= at + * VA 0, which is below image base and thus invalid. Note that we're pas= t + * _end here, so if these sections get loaded they'll be discarded at ru= ntime + * anyway. + */ + DECL_DEBUG(.debug_abbrev, 1) + DECL_DEBUG2(.debug_info, .gnu.linkonce.wi.*, 1) + DECL_DEBUG(.debug_types, 1) + DECL_DEBUG(.debug_str, 1) + DECL_DEBUG2(.debug_line, .debug_line.*, 1) + DECL_DEBUG(.debug_line_str, 1) + DECL_DEBUG(.debug_names, 4) + DECL_DEBUG(.debug_frame, 4) + DECL_DEBUG(.debug_loc, 1) + DECL_DEBUG(.debug_loclists, 4) + DECL_DEBUG(.debug_macinfo, 1) + DECL_DEBUG(.debug_macro, 1) + DECL_DEBUG(.debug_ranges, 8) + DECL_DEBUG(.debug_rnglists, 4) + DECL_DEBUG(.debug_addr, 8) + DECL_DEBUG(.debug_aranges, 1) + DECL_DEBUG(.debug_pubnames, 1) + DECL_DEBUG(.debug_pubtypes, 1) + +#ifdef EFI + /* Trick the linker into setting the image size to no less than 16Mb. */ + __image_end__ =3D .; + .pad ALIGN(__section_alignment__) : { + . =3D __image_end__ < __image_base__ + MB(16) ? ALIGN(MB(16)) : .; + } +#endif + #ifdef CONFIG_HYPERV_GUEST hv_hcall_page =3D ABSOLUTE(HV_HCALL_PAGE - XEN_VIRT_START + __XEN_VIRT_S= TART); #endif @@ -418,8 +430,7 @@ SECTIONS #ifdef EFI *(.comment) *(.comment.*) - *(.note.Xen) - *(.note.gnu.*) + *(.note.*) #endif } =20 @@ -465,6 +476,15 @@ ASSERT(IS_ALIGNED(trampoline_end, 4), ASSERT(IS_ALIGNED(__bss_start, 8), "__bss_start misaligned") ASSERT(IS_ALIGNED(__bss_end, 8), "__bss_end misaligned") =20 +#ifndef EFI +ASSERT(!SIZEOF(.got), ".got non-empty") +ASSERT(!SIZEOF(.got.plt), ".got.plt non-empty") +ASSERT(!SIZEOF(.igot.plt), ".igot.plt non-empty") +ASSERT(!SIZEOF(.iplt), ".iplt non-empty") +ASSERT(!SIZEOF(.plt), ".plt non-empty") +ASSERT(!SIZEOF(.rela), "leftover relocations") +#endif + ASSERT((trampoline_end - trampoline_start) < TRAMPOLINE_SPACE - MBI_SPACE_= MIN, "not enough room for trampoline and mbi data") ASSERT((wakeup_stack - wakeup_stack_start) >=3D WAKEUP_STACK_MIN, From xen-devel-bounces@lists.xenproject.org Wed Mar 02 14:29:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 14:29:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282279.480945 (Exim 4.92) (envelope-from ) id 1nPPyN-00012K-Km; Wed, 02 Mar 2022 14:28:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282279.480945; Wed, 02 Mar 2022 14:28:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPPyN-000122-GE; Wed, 02 Mar 2022 14:28:59 +0000 Received: by outflank-mailman (input) for mailman id 282279; Wed, 02 Mar 2022 14:28:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPPyM-0000Xm-3E for xen-devel@lists.xenproject.org; Wed, 02 Mar 2022 14:28:58 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1807c870-9a35-11ec-8539-5f4723681683; Wed, 02 Mar 2022 15:28:57 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1807c870-9a35-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1646231337; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=+2Ei8EBR9EXf62Akrk8b2opcb3IwuX8/9v9H3NAEkMw=; b=WI7WAmhK6GtvoM5e5DvoTWKt2tcUAKshQh0CQQ2XX0Sz6bb+QRgZLUkd LyL3230EwEzCRClrTMszUUXuxrlqMIZN33j7kda91o1ycvA+TBoh7i5i+ TeY2f/Mr4ivTZWyZjdUxJRcVrlHa7GVid6xlT0S31aYg16tFH8l5AcRwe I=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com X-SBRS: 5.1 X-MesageID: 65302964 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:5zgw/asgTawbLPKrt6yY5HsbuufnVJZeMUV32f8akzHdYApBsoF/q tZmKW+OOP7ZajOgeNB+a4izo0IHuMOAzYRmSVBqqC01Hykb+JbJXdiXEBz9bniYRiHhoOOLz Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQyw4bVvqYy2YLjW1jV4 4upyyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo Oihu6BcRi8GBZ/3gsoFeSBSAiguL614x+bgMHKw5Jn7I03uKxMAwt1rBUAye4YZ5vx2ESdF8 vlwxDIlN07ZwbjsmfTiF7cq1p9LwMrDZevzvll6yj7UF7A+SI3rSKTW/95Imjw3g6iiGN6AO pFBM2sxMHwsZTVLZngMC5sxnNyxpX7/WmEJtAK/tYsotj27IAtZj+G2bYu9lsaxbcdImkeVo ErW8mK/BQsVXPSFzjWI6DS0j/LnliLnQpgTBPuz8fsCqFGUy2YeDDUfUFKppv//hkPWc8JSL QkY9zQjqYA29Ve3VZ/tUhugunmGsxUAHd1KHIUS6waL0KPYpRmYAmssSSRIY9gr8sQxQFQXO kShxo2zQ2Y16fvMFCzbpuz8QS6O1TY9AlQwXjUqVSE86cjq8JMzsC2WacdpH/vg5jHqIg3Yz zePpSk4orwci88Xyqm2lWz6byKQSovhFVBsuFiONo6xxkYgPdP+OdT0gbTOxasYdO6kok+9U G/ociR0xMQHFtmzmSOEW43h95n5tq/eYFUwbbOCdqTNFghBGVb+Jei8AxkkfS+F1/ronxezO ic/XisLufdu0IOCN/MfXm5II51CIVLcPdrkTOvISdFFf4J8cgSKlAk3OxLOhj61yBlyyPBlU Xt+TSpKJSxAYUiA5GDrL9rxLJdxnnxurY8tbcqTI+ubPUq2OyfOFOZt3KqmZeEl9qKUyDg5A P4EX/ZmPy53CbWkCgGOqNZ7BQlTcRATWMCnw+QKJ7XrClc3Rwkc5wr5nOpJl3pNxP8OyI8lP xiVBydl9bYIrSafeFXSNys6M+uHsFQWhStTABHA9G2AghALSY2u8L0eZ90we7wm//Zk1vl6U 78OfMDoPxiFYm2vF+g1BXUlkLFfSQ== IronPort-HdrOrdr: A9a23:niDfga5jbz13fQLliAPXwSqBI+orL9Y04lQ7vn2ZFiY7TiXIra yTdaoguCMc6AxxZJkh8erwXJVoJkmsiaKdgLNhQItKOTOJhILGFvAF0WKP+UyDJ8S6zJ8n6U 4CSdkONDSTNykCsS+S2mDReLxBsbq6GeKT9J3jJh9WPH9XgspbnmBE42igYyhLrF4sP+tHKH PQ3LsOmxOQPVAsKuirDHgMWObO4/XNiZLdeBYDQzoq8hOHgz+E4KPzV0Hw5GZVbxp/hZMZtU TVmQ3w4auu99m91x/nzmfWq7BbgsHoxNdvDNGFzuIVNjLvoAC1Y5kJYczIgBkF5MWUrHo6mt jFpBkte+x19nPqZ2mw5SDg3gHxuQxenEPK+Bu9uz/OsMb5TDU1B45qnoRCaCbU7EImoZVVzL 9L93jxjesZMTrw2ADGo/TYXRBjkUS55VA4l/QIsnBZWYwCLJdMsI0k+l9PGptoJlO31GkeKp guMCjg3ocXTbvDBEqp/VWHgebcE0jbJy32DHTr4aeuonprdHMQ9Tpt+CVQpAZEyHsHceg22w 31CNUZqFhwdL5lUUsEPpZ4fSKWMB26ffueChPaHbzYfJt3Tk4l7aSHpIkI2A== X-IronPort-AV: E=Sophos;i="5.90,149,1643691600"; d="scan'208";a="65302964" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PPV0nWT7i7y75krwemeZicgBtQF1mEe3PWNQglr/q/FJ1fsnJhtaJfsUvSah2mvRnfHHUIVxZQqznZ8zU3jTlPGWpCgb9vhuYhyDl8NMpDQuVdg6HiUJycoMh/jMPP0EnBm+FmSJ1iVyPpVrer7bp2CiHjr3iSQjs7c6OGrxg7UmxwlKmCnHcjGlR0v5gjbhe+eHrHpV74yST1y7wqgFr6Gph9n2KZb9mr3ePRT8ARXzVVVUqrQ+AvyEuXkhgwnHaAchSII0wplUgkeIwpDn/C+0FVkihwK81imopDHsgleCVm09DruV4dDJ9yWu4OU44AEBF7X3maJXnMcSsul13Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UVs0N4lrLYXtidMdZMljGcSKcwUkd/vbtt8k48wXfUA=; b=oKUI65qG/dP+o/mz5NhWujjQ9uJwLtAtyErfytgAC+TWjuW4KaD5ZYeCCfMFIhhREJNLEMSrQfawQ0WdxYbXFh+NnsOVtVubTyOmFvDwopX/H2LGqXPjCQSgyG3XmH9rzhrMAuIQgJVXRLw8g6xBE/nWefQkzklzwrIHvzfHn+ZvDVHJ8WUAQYoNCarlbJRG519VHt7+Aqa0sYVN8GuOEwiCcDfUEZIT4yqaMuht3VPfFs42tmS+d4kJLSPsRijdSc7sgVLu34stnnHSp6KIRQ2KIxzcbk6s3VrY82GXqeGbj8QjDRTq9RXfhxZyfUw/kDlclrscP6m2eJFcV8F+wQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UVs0N4lrLYXtidMdZMljGcSKcwUkd/vbtt8k48wXfUA=; b=ij3Y8I/ggRgq8NQSGNeGQK1s9zrOK5FDDgD+rKr3OqYlR4ISSADi18H24SQzngr76kgd6W49RXX9JdASnBi+YH+OOz77MS5QL8gArS4fgFq5FeC1UdRXexTSpGYQ2YFx4imtcM7vgooKtSZ12rh7ASF+XplkdiPrxL6ty2daP9E= From: Roger Pau Monne To: CC: , , , , , Roger Pau Monne , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH 2/4] livepatch: improve rune for fetching of Build ID Date: Wed, 2 Mar 2022 15:27:09 +0100 Message-ID: <20220302142711.38953-3-roger.pau@citrix.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220302142711.38953-1-roger.pau@citrix.com> References: <20220302142711.38953-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0027.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:61::15) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2e0fd313-af34-4a09-514a-08d9fc58fa85 X-MS-TrafficTypeDiagnostic: BN6PR03MB3330:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GHxr/jeYeXBVgkmZf2KqO+MKOrRLQaY2KLg7oSCQjiuRN2PLPcZyItshcg0OSn0C7ppDBfGSUWvkTAHChc4/byvM/8tZJOjdJeMUn/ObVJno0io2NnG2GZATJpLIlW/j7a06/hSvcY1EK50PcmsV5Ky23iJmws5iJKDdsMPGdNxgT5YMvXUeP5K1yq4gG210TCCdpjIdFSr7SD271AqbWQ5J03lwUCusydoiEDg82u5qQffXecu9WeG6olrQIov+66dLVR/pgTuQrBh1nfUdeIWyF6DI3MAmct0tBqgRWKLMrhrV24KRcBF8NrebbBYl/C6Ckh5P/9V2slEuBizuSSxPFsThncjD79GK6fmdkts+j5pjj2nsCQ8JfUuxkvj+N+EQuRAfJN8K+dqcfZrt1V1YyQqbUPGmMx0XceMCaRzcXX+jvctHJl/KvHjt9/mcbCg/aXXLp86q72/BUPsWKojhlQ1N127QReXskXbngiUAFM/7r5AviRxmTSUROUw71Y6rPN+P8rMZm5zgZ+P2kW64Wu3CDgth9n5Mb30E6C0Jz9txXajKC/y24yB0EoqbkZ7m/dYxKlZgUZSvEUtnF+eIVdKESofFLAUR4JHjO/Yf8OuRGXt9YYi6MH/kLlB/Z6kX7tgmhNlWuFnNqHRNoQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6506007)(6512007)(6666004)(38100700002)(66476007)(66556008)(86362001)(66946007)(508600001)(54906003)(316002)(6916009)(4744005)(82960400001)(5660300002)(6486002)(8936002)(8676002)(36756003)(2906002)(83380400001)(26005)(186003)(2616005)(1076003)(4326008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VElsWkJDbmp1WHRZMlZES3h0WG5yd3RBb0VBb1h4OG5TZmpkck0yOVkydnNL?= =?utf-8?B?TG02K0ZvSEZ5QW9qNXpVbzg0U0dOUndZSGR3YlZSeElpOWR0WGhkcFhhcTlx?= =?utf-8?B?UXV5WllobFFPTk5nbytNTnJQV1NsZzUzZ2c4S1pnbUVOMTVSUWFzZVNPN2k5?= =?utf-8?B?NlZoMTVaeXA2SE5ZUmhkRldDWXZxVUJrSFkzQjVCUjJ0ZFJhSDM5dncrMFZW?= =?utf-8?B?NlVMemdMcFNmZXBNV0lTSzRJYVZKVmlqdXVKa3VuWWxoNUdTYzZuaDFCSmFs?= =?utf-8?B?SVIxMS9tSUpOUWw4R2pRa1lmenJJR0RJN3pHcjJKU1A1bDVkMnRtKzBuL3F5?= =?utf-8?B?VlhPa1ZDQWsvTTBpM3kwYXRzN09iOUNDemZMa1BOSkFWTnF3clkvZzEwUkZk?= =?utf-8?B?ZWQ1SEhQUEZFbG1nT2VBZGJYN3dGeW5TZlQydStnT3MvOU8wVDQ4WUEvMzVE?= =?utf-8?B?cTZjNlY1NExpeERmeWZrVVllRk1EYVBmaTZ6WTZsNFhMNVUxc1VYWWV6eTZN?= =?utf-8?B?YWcxbUtESENmWkxQeFVlTGJRcWlHVGV5bXN1bHl4Z0RlTTRQMzNNTVJyTjYx?= =?utf-8?B?VzZiTHVvNGVZaStRQnkvSkVWQStBVmlyVXdsY3VDSGpuaytYcFpkT3FzNkR2?= =?utf-8?B?YU1icHFCYTJPTzBOU3VwU0RJMG1Qb2RLK3JnaGhjNVNUS0ZYcDVxVE9CS1hu?= =?utf-8?B?MWloQUhMMTJYcFV0blFLdis5aFBNdkFEam82UmRsRDlsSlZ6R25yQTNTZk1l?= =?utf-8?B?d2FLa1Nzc281ZW1aOWM2cFF0aEI4UWY0TmVQdVR4U1F6UkdpNFFPRDhLV0p6?= =?utf-8?B?ckRkT0tsdnNXL3FBVGI2NTd0d3JTVnBhTXpFRlVUa29weTlRRHYybkh5TXk5?= =?utf-8?B?L3c2OUhPU2tERC9paE84UEFFZytYK3hQbklIbGp4YVJkeHFyVVNyTGhqWVEy?= =?utf-8?B?bGpMN3U2Rnc1NlBWRFFBaVdrOWZGK2tRcHNtM1lEWXNSbm9pdnI2TDJIdWhT?= =?utf-8?B?VTBlOVVNVWJubTFLNHBMOGhZR2NNcTlJTDMycFduWTRTSFg1bllmT21lZzU4?= =?utf-8?B?SzlZOUlNYnpKdjR1TGNtNlZFVGM3SHVTQm9kVUpTK3RxczQyZVZFa3hqV1pB?= =?utf-8?B?eVZBaGQ3ZkY4WkFNKzdxNGJMWjllY1lncmZoUUVnSVdqdmhZeWRhYS9HYWNK?= =?utf-8?B?elN5Y3JsZ0NITll0SFhHRXRHMWxhQ202QkE0MVZJdTFwZytDZWJtNjQ3OGdl?= =?utf-8?B?WmJaVURGVmFVYUFBekQvZndFTUE2ZTJwRVJhdlNRQWtubk9tZXdESWh0UGdD?= =?utf-8?B?REFweDVOQmszakRFL3ZaY21hbXpvaGRUUnVUMTg1WDBUZEszckZBVUhmdVA5?= =?utf-8?B?T2RFTFhzaERXR0ErODJsN3NtaGkzbzV0MnJFRXFlb3dmeGlGSStWSyswKzlY?= =?utf-8?B?a3IybWN1M1hyM2ZJemliTHBJNUJ2aEkrRmhKeGg5MDRSVHZkU3ZidlVXYkw5?= =?utf-8?B?N2NZUE9EdUNwK3pGTzNPdXJINzlveUc0SHJKa0JnL2JtZ0Y2L3JiaUJCNVps?= =?utf-8?B?citlWjAzRFlFRnFRanprTnRoRHhHdWltUHJzc010NWFvTnpLYmhuMVpabE9F?= =?utf-8?B?QW1zUUFNNFJsMmJYTTlqTy94dldLOFpUOTVFK0t6enVnUFdoRWhFaVpKeDlP?= =?utf-8?B?cE1HTDV3cjcraWV6T2Q1NUVSWGZ6TkR5V25VUUc2UzZtcSswVzZWMDJ6VTNi?= =?utf-8?B?cG0zSTRISWlpVlg0dVdZUDhUNW1UcURJaVlHTzA0K3BBZG5MeHJlTUVHUlhB?= =?utf-8?B?TXk5ODFUMThkOEE4VXYvTmsxbzBnUkw4TlRoRk5UM09BQ1g2cUNkVzRsSFRV?= =?utf-8?B?eDdYMjdVVmtDR2d3VEFMVlNXdW9vNGxMQzRhNXB6QVlLbU1UTlZLZ1E0TU5T?= =?utf-8?B?a0IzdVlEWGxGeC9TUTQ1UjNyQk42RTN0ZkM5MzNzT3E0RG9rZkJjTk5kRVlo?= =?utf-8?B?RURscUVqL3VNVE5ROERPQ2NqOU9tMnJsQUdSOG1NQjlJREdqNUdDcGF0bTVE?= =?utf-8?B?QjlMZW51NnpSVk5zSHNBUFFGbmVJMHZwTU03ZFVIeVhoUlUwNUtUTExIMFFs?= =?utf-8?B?NWxXNnZxVkQ5cTMvQUg1M1BMc1FYelhLcEZtTk9mbnZEdVBudmNIK1krNFRu?= =?utf-8?Q?oprTZ5Go66GW/lgWyfWWSo8=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 2e0fd313-af34-4a09-514a-08d9fc58fa85 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2022 14:28:54.1092 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QaSaXaRePQGkcG0cwoIQKEJyGsOB7kqo+W2a6RYpSzDq/xsBLtnRsQTeQsqaz/D2BKwGO6dTYj62YzPgWl4g7w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB3330 X-OriginatorOrg: citrix.com The current one is broken with my version of readelf and returns 'NT_GNU_BUILD_ID'. Signed-off-by: Roger Pau Monné --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index b48a3df..948a7de 100644 --- a/README.md +++ b/README.md @@ -16,7 +16,7 @@ $ cp -r ~/src/xen ~/src/xenbuild $ cd ~/src/xen/xen $ make nconfig # Make sure to set CONFIG_LIVEPATCH=y $ make -$ BUILDID=$(readelf -Wn xen-syms | awk '/Build ID:/ {print $3}') +$ BUILDID=$(readelf -Wn xen-syms | sed -n -e 's/^.*Build ID: //p') ``` Next, build a live patch, using a patch and the source, build ID, and -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 02 14:29:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 14:29:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282278.480927 (Exim 4.92) (envelope-from ) id 1nPPyM-0000aK-DS; Wed, 02 Mar 2022 14:28:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282278.480927; Wed, 02 Mar 2022 14:28:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPPyM-0000a1-8D; Wed, 02 Mar 2022 14:28:58 +0000 Received: by outflank-mailman (input) for mailman id 282278; Wed, 02 Mar 2022 14:28:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPPyL-0000Xm-AX for xen-devel@lists.xenproject.org; Wed, 02 Mar 2022 14:28:57 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 165621bb-9a35-11ec-8539-5f4723681683; Wed, 02 Mar 2022 15:28:55 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 165621bb-9a35-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1646231335; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=Uv6+k4P+pq/NsyHUUBb3gegl0iO3HUiZOvNvr/hkT1s=; b=EmHrMjtiumErP4dK43Z+n6EJpc8p5ropFmAmL/NLxaIZnhAz2bYK8vct dBElmz9ZkyeoyBfiYLLFdv0YcpIyzH2ABetqNf5+FXpRhyb+5cmLKqWxg JCwEeYVEkabeMqQBba0uVLxHk21/86f8uL3hZeZCWr19QOfD75Vm90bUt k=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com X-SBRS: 5.1 X-MesageID: 65302961 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:pxiJ26oHSCjSw/44ffkVUe3SPfdeBmIzZRIvgKrLsJaIsI4StFCzt garIBnVO/aJY2SkKNB+Po229B5XvMfRyNNiTQRlriBnEC5H8ZuZCYyVIHmrMnLJJKUvbq7GA +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8lyrZRbrJA24DjWVvW4 Ymq+KUzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk b1wWZKMpQgBHJfjv9hNWglhOR5aGvVU+bbpGHKurpnGp6HGWyOEL/RGCUg3OcsT+/ptAHEI/ vsdQNwPRknd3aTsmuv9E7QywJR4RCXoFNp3VnVI1zbWAOxgWZnea67L+cVZzHE7gcUm8fP2O ZdCMWA+Mk2ojxtnGg8qCasZge2RpFLbSzhYmmi7u7Y8/D2GpOB2+Oe0a4eEEjCQfu1ZmUuSq 2bu9mHwEBYcctCSoRKH73ati+nnjS79HoUIG9WQ5vNsxVGe2GEXIBkXTkeg5+m0jFakXNBSI FBS/TAhxYAx80qxR9W7QBy8o1aDpBcXX9cWGOo/gDxh0YKNvVzfXDJdCGccNpp276faWADGy HerpfzOOWxmoIS/dla6rqWVpB2LMzkKeDpqiTA/cSMJ5NzqoYcWhx3JT8p+HKPdsuAZCQ0c0 BjR8nFg2ux7YdojkvzioAuZ227ESo3hE1Ztjjg7SF5J+e+QiGSNQ4WzoWbW4v9bRGpyZgnQ5 SNU8yRyAQ1nMH1sqMBvaLhVdF1Kz6zcWNE5vbKJN8N7n9hK0yT+Fb28GBkkeC9U3j8sIFcFm nP7twJL/4N0N3C3d6JxaI/ZI510kfa5S4y9B66NP4Amjn1NmOmvpnsGiam4hT2FraTRuftnZ cfznTiEVx729piLPBLpHrxAgNfHNwg1xH/JRICT8vhU+eH2WZJhcp9caAHmRrlgtMus+VyJm /4CZ5ri40gOC4XWP3iImbP/2HhXdBDX87it8JcJHgNCSyI7cFwc5wj5mutwK9Q4xP0Ozo8lP BiVAydl9bY2vlWeQS2iYXF/crL/G5F5qHMwJys3Oli0nXMkZO6SAG03LfPboZFPGDRf8MNJ IronPort-HdrOrdr: A9a23:ok4bvKgwAR1gvhTT75pcEoxmgnBQXzh13DAbv31ZSRFFG/FwyP rAoB1L73PJYWgqNU3I+ergBEGBKUmskaKdhrNhQYtKPTOWxVdASbsN0WKM+UyHJ8STzJ8+6U 4kSdkENDSSNykKsS+Z2njALz9I+rDum8rJ9ITjJjVWPHtXgslbnnlE422gYypLrWd9dP8E/M 323Ls5m9PsQwVeUu2LQl0+G8TTrdzCk5zrJTYAGh4c8QGLyRel8qTzHRS01goXF2on+8ZpzU H11yjCoomzufCyzRHRk0fV8pRtgdPkjv9OHtaFhMQ5IijlziyoeINicbufuy1dmpDl1H8a1P 335zswNcV67H3cOkmzvBvWwgHllA0j7nfzoGXo9kfLkIjcfnYXGsBBjYVWfl/y8Ew7puxx16 pNwiawq4dXJQmoplWz2/H4EzVR0makq3srluAey1ZFV5EFVbNXpYsDuGtIDZY7Gj7g4oxPKp gjMCjl3ocWTbqmVQGYgoE2q+bcHUjbXy32D3Tqg/blnQS/xxtCvgklLM92pAZ1yHtycegA2w 3+CNUaqFh/dL5nUUtDPpZyfSLOMB20ffvtChPlHb21LtBPB5ryw6SHlYndotvaPKA18A== X-IronPort-AV: E=Sophos;i="5.90,149,1643691600"; d="scan'208";a="65302961" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DoLDk55JAlb6DWt9Lc5jdbn3zekeMF3gnDdYE+ZZOrHyGWK1iWOpSo9By1jCvobYNTdMyncHxT5nt7YUumwfmwycwLR6mxE3PDx08neO2IAgGwJnGAA+MWJLBf+LUMLgYbGLEuEDyyg5e23s80/Uim7Qd4oGmBYD9+pgNCQExxkHs9Aup1wB1TRJCM71Sbe27ZdSeS8Hdk1SuuM4ghTscB7y1E/H9Zr1oFahTrA7Domf6W+rcswPH9SWQprt3b5VjQe/B61oK3/oamDKhIngQy0DOb48uq0hrVePBEXSLFt+FwqvuI2PWRGLYV6/t1D3693blDfKKvpZv5gQ7aM6hQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mXqJC3FYz1zgAzycpIM3RwRbyRXV+eqnGOl8ZN4IR7w=; b=mtXokVnSmQlbFSWEnVeVR/wd9R/tRfpI9LGLDEOAEZq7+qrRMNhBPT1YNoI8n7tFmmpw9IDluxazPAk/8Ezynl0v20RSzTws1w4lfrC7DgiyHRids5tqNY8sbRHsxAExtMPQSpXy+xDFB67sadcDl0DoF4F5bh8q4awGpOAbV5xYGGbwvEDqlFUKNCyChoeageLfhnEt5zYBoFgclJsUZxWWtW4iICyzV4na1MuSahAu/1n27I/rKFJBAqq9irtJXCcBGg9uN2RB5RswHQfQpKV6uP5CBOUIRl5Tqk2PvM5WHhAZ6a+c56v9WQ0FrGqYIi76Fjf5oCTZWKICtAAUAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mXqJC3FYz1zgAzycpIM3RwRbyRXV+eqnGOl8ZN4IR7w=; b=m7J2xEqvcnJb4RgQu2GQBgGEnY4hZ0sCLtqjRXwuCKhzrXBo/MqrvvmGK5d0kzsDzBwKyar0vI3zMQAD08pt6RWBtnSZkcT29XCTeV4WoDyeLKRD1aOCXub8lIfmFIgxzNOid8SBr485TaDjB/tv18OyTmoP3VC9PEnbqvIa0+Y= From: Roger Pau Monne To: CC: , , , , , Roger Pau Monne Subject: [PATCH 1/4] livepatch: update readme to mention --xen-depends Date: Wed, 2 Mar 2022 15:27:08 +0100 Message-ID: <20220302142711.38953-2-roger.pau@citrix.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220302142711.38953-1-roger.pau@citrix.com> References: <20220302142711.38953-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0125.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9f::17) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f516a324-02bf-45bd-1132-08d9fc58f815 X-MS-TrafficTypeDiagnostic: BN6PR03MB3330:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hX2dYJKiUMp6U8u9xSRYboAp0tZg1AvPN/1qN6dX1iZKUO7urCAsLCJCG71s7G4ONvTJhNVMeOmIUkUmz5RNl/DIVfClTwehihxAaXoRkzey3jFW09SZrodcD/JqzVMiTGH6u3oP2CV6o6QjeItgczQe+U4VciSg+U9x8kc9edblyBlweLaD31kO5dx47wnVUwbpPIrZLKgbhLInVxdSWaeJ9WEOiLzDm7yCrfJ8PfrJm18sQoMH2iiEruGqoQGU8uuNp8IkGWWVj1NDS+WEMdXsHwUmN/v+Z2r2UVEd3mPasoAM6wbDBZY+vc+LPbIAMREDb9nxFw2RYuLY3qFABkA5KuyiCI0q5RgxohjGyoh3zvUekZIT5Na2ip14bQ/AALh5Ao1fFFpfiVA5r6sU7ojN5VYb596KDpbzHVe3MpkkwwlbqHKFevYYCjlp2mW74mC231MD/RC4np99cj32BDtJox0jIzQ37FR08F2KUUblkdtFMav9J6egp116qs0+wlR32ywJ4UN2VryBfM/G4xCNjTRhBLN4b8zOg3ZPl0yEyx5fwitiri+NgFNzXyVm80Kg9pHu/HwLUb3iGGt5yzFDGiAH76ghCFQyV4hl+5kBI/BwiveY/BaPYFk0akX79k1Is60EnU1ZFmnja3IYOQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6506007)(6512007)(6666004)(38100700002)(66476007)(66556008)(86362001)(66946007)(508600001)(316002)(6916009)(4744005)(82960400001)(5660300002)(6486002)(8936002)(8676002)(36756003)(2906002)(83380400001)(26005)(186003)(2616005)(1076003)(107886003)(4326008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MVBYb2g3SlU5L3BpYXl5M09DemJvRjd6aG9yRGdLaFVmMGNpMUF5WnB6Q25R?= =?utf-8?B?VldxN21SQ2RFRzFyTHpNbmt2U2UvZFlGYlBMQmhNdDdYV3ozbmdxNXFVZGtv?= =?utf-8?B?cWE4SDY3amVmbmJmMzNyeEpRZWZXWjE5d2RCN1ZkMnM3aC9zQ0wvWE45aXhs?= =?utf-8?B?Snk1QktCQlE5eDY4S0xWVjdkUVdFVnh5bm90UlRmMXZKQ0VSSW9haEhTdExK?= =?utf-8?B?YTVHOWxFajFtM1EvR2VwT01acUo4WDVKRUNCZmpLcmRaQVF3Yy92QVE2Y2JZ?= =?utf-8?B?R0RaRVhZSnhHTXV1U045eTducnV0VUxoNlJUSzhQN1NxeldqdDZHUVN1TEtY?= =?utf-8?B?WHNSVlJmNTNRWGhoRm5kYXJKcU9EWW13bk5WR0E0Q1R2ekJqRmtzeDE2dHM5?= =?utf-8?B?WW54c2lxWDN3R1Y2ai9RTkVyZjZCN0VrSE9Ia3MxM1prM2ZDMm90ckJMR0lL?= =?utf-8?B?OGgzTzAxR21Ebm9sYzFRUDRVSThVK2NyMnNXMUpOVkZGajVONTZxVUdzZi9N?= =?utf-8?B?aHVadUpIYVY5WEVHWVJPUTl3bStlcTBVUXBXY3oyb05Md0lZTVM2ZSs0K2pJ?= =?utf-8?B?VS81aUY1RHA1WldtTTJ2SG5lWE5DdkIxeVhMY1huNlcwS0Z4T0xseDYyYmZh?= =?utf-8?B?clcwd2xpbzRVaktEdTUxQlk4STh1R1Nsam5KZjdieWcveFlJbC9ycDRtNzVx?= =?utf-8?B?QXZTcVVqWGdUUWhSa3VsS25FaWtTbHB3ZmMzR2ZabzJML2tsRHcwUzI5b1kw?= =?utf-8?B?WmxZeWwwVnBLNnI5TmpjN2tERXlvK2dmcWM2SXg5cks2dU81R1Y2VENRMU5E?= =?utf-8?B?cUtzZmNLckFmdDF3S1EwemVjVU55UlkrT2dzNmRMMzJzSUZCeVlNTlp4MUxX?= =?utf-8?B?ZjlqYm90NnI1RGtuVVF0VU5xL09lWEFOcTdMZ1huNC9nZ0NvaGJGNXgzVE5P?= =?utf-8?B?VDFFbkUvWGFvait4R2FFRytJcUNzdndpNURuYnFNckQzMnVhRUN3b0hFai81?= =?utf-8?B?SXAxSVNWNXR5T0J3ZXNnSHNibWNhMytZNCtBajl6b3FFRVZKbitHb2ExdGlw?= =?utf-8?B?OWhOZmdFM09GWHI3cFZQUTFBaVYzaUpKNWd0RW5ZUy9reDJyL1J0Vjk1RTBY?= =?utf-8?B?c2VlaTkzYkQ5YXRzdnBpS2NaMkQxNDQ0UlJDRDd2eERvdnYvenoxUFhmOUl0?= =?utf-8?B?OHZqeWo4QmQyVEJUK1FaYTlzcTNVc2kxYUdWYkROWWoxZWJFSTRqNGJrYkpw?= =?utf-8?B?WHFxMUQ2b0JFOThBUXNtdzRpaG9JL29sSGFsQWwzQjdGY3BZczlaNmtLeng1?= =?utf-8?B?VWkvRVNDVFNla2ord0phOGtLWXNhUVRrekIyUWVDYUtMVWFyK0RYUGRESi9m?= =?utf-8?B?bnNlczd5V1BTWGszbUxJdHc1bmlaNUM1SWRCQk43enhDNUIwNUE3Ym9HMGVP?= =?utf-8?B?TDRBa0J2VFNzaklGVi9nYlBkUkZGbldEL1lWOXdmcDVoRlBDWW9yQmNESnhq?= =?utf-8?B?MEwzb1AvVENKQUpGS0ppY0FhTlA3ODI2WWVTUkorNGlDTkhLcm1LaWh6ZzJE?= =?utf-8?B?OE5rUW9pQ1VXb2pGbGJnQzR3M3FoaUpIUHRwdTNodytlZStSK2ZZaGxDbjVs?= =?utf-8?B?SlhkZ25jclFmUmM1UmhqeGt0eFRuVFk5c1FjdHdYUGdhUEpFeHg5UnVwV3VH?= =?utf-8?B?d2FJL2x1MjlXSldoL09DbzJPQStnQTlKOEVpaHhEYTAyWWxPb1JxamtZam9U?= =?utf-8?B?ZTQzT0xiZkFMaTRVRXo0VmpjSHR0YUMwMXdiWG1sbFhud1RLMlV2L0NYekVv?= =?utf-8?B?blJubkh4Ky81Rzd6V1VpbGk5V3piallZaTNrWUU2ZVA4MXpsb1F6QXBwbEtu?= =?utf-8?B?RkNmdHRoYkttS1Myc1VENnRsQ2Q4UXd5NmNqb2ZnYzFkSXVZamZ4SWYzSGpx?= =?utf-8?B?TlZUY3JVUzJtM3Q5MEJ3VjBHa3ZBS0FqTDUzYkNxK0h5Zi91cU84Njg3VXNN?= =?utf-8?B?bEh0QkcycVhOSnh4aU1ZYkJmYko1a0FLaHQ5ZjByNjI1d0NocngzTllPeFNi?= =?utf-8?B?VGNiNWlwMW1UZHYwbFY2WEEvWnZCOW9XSG1jL3F1UmNFSE5NbWJLRnU5eHg5?= =?utf-8?B?SCtIQXh2cHhHZWJoZnZGMXJ4QUZld1hQanI3U0JpaTdSQWFEV21YQ0YxaXhZ?= =?utf-8?Q?V29x7qL8cpwjQJW2VqXuj48=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: f516a324-02bf-45bd-1132-08d9fc58f815 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2022 14:28:50.0280 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: U3N4Gy76DFa2vPVCOKFgb94DZ1fA8UEVonjjLzsIxcT4oJV8Byu68/sDv7nW6Ae+p3jG/uPk+5QNyHsadNoHjw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB3330 X-OriginatorOrg: citrix.com Fixes: b19df7b2c05e ('livepatch-build: Embed hypervisor build id into every hotpatch') Signed-off-by: Roger Pau Monné --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 653c624..b48a3df 100644 --- a/README.md +++ b/README.md @@ -24,7 +24,7 @@ Next, build a live patch, using a patch and the source, build ID, and ``` $ cd ~/src/livepatch-build $ ./livepatch-build -s ~/src/xenbuild -p ~/src/xsa.patch -o out \ - -c ~/src/xen/xen/.config --depends $BUILDID + -c ~/src/xen/xen/.config --depends $BUILDID --xen-depends $BUILDID Building LivePatch patch: xsa Xen directory: /home/ross/src/xenbuild -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 02 14:29:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 14:29:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282277.480923 (Exim 4.92) (envelope-from ) id 1nPPyM-0000Xz-3w; Wed, 02 Mar 2022 14:28:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282277.480923; Wed, 02 Mar 2022 14:28:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPPyM-0000Xs-0r; Wed, 02 Mar 2022 14:28:58 +0000 Received: by outflank-mailman (input) for mailman id 282277; Wed, 02 Mar 2022 14:28:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPPyK-0000Xg-MB for xen-devel@lists.xenproject.org; Wed, 02 Mar 2022 14:28:56 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 15aed13b-9a35-11ec-8eba-a37418f5ba1a; Wed, 02 Mar 2022 15:28:54 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 15aed13b-9a35-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1646231334; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=oUjLpSae5zo/rJzrNaBLQzS2gfvNUYVpZIh8bPCADF8=; b=aPJ1IO9h3p7OmhT019148ss9hVRSjISYULYiFo1V9GPmMnZeYU0FTldL smMh70mB1Dq2r7DyrZcGVyn/ZGZi1JMXEXjD4EHtF5ZXsleAqqnKIiGnk lpO8/ZvP/aLL7gbja8daQSOKcmPb0R+Lrxm/DJ+sNLa/xiQLX1Q5xcIN6 M=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com X-SBRS: 5.1 X-MesageID: 65714247 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:uVv3Yq69RJWBwSQ/0wBzIwxRtBPHchMFZxGqfqrLsTDasY5as4F+v mdLW22AbPqMamOned8nOYu39khXvsTcydFnTQVq+38xHi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0XqPp8Zj2tQy2YPhWVvW0 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx umhurTreAoLearOyNgnEAtRCyZQPo5ryp7+dC3XXcy7lyUqclPpyvRqSko3IZcZ6qB8BmQmG f4wcW5XKErZ3qTvnez9GrIEascLdaEHOKsFvX5t13fBBOsOSpHfWaTao9Rf2V/cg+gQQKmHO 5BFNlKDajzuQUNGN3EvU6lunb2EmFrhdW0FgVaa8P9fD2/7k1UqjemF3MDuUtCNSM9Ymm6Ro 2vU+GK/DhxyHN6CzTuI9Fq8i+mJmjn0MKoCGbv9+vN0jVm7wm0IFAZQRVa9ueO+iEO1R5RYM UN80ikpq7I7+Aq0T93+dxqiqXWAs1gXXN84LgEhwFjTkOyOuV/fXzVaCG4aADA7iCMobWcb2 33OmNG5OQYsorSNTlye1ZqmjArnbED5MlQ+TSMDSAIE5fzqr4cykg/DQ75fLUKlsjHmMWqum m7X9UDSk51W1JdWjPvjoTgrlhrx/sChc+Ij2unAsotJBCtdbZXtWYGn4EOzAR1ofNfAFQnpU JTpdqGjAAEy4XOlyXTlrAYlRujBCxO53Nv02wQH834JrWnFxpJbVdoMiAyS3W8wWir+RRfnY VXIpSRa74JJMX2hYMdfOtztVZ10lfCxS420DJg4i+aihLArLmdrGwk0OCatM53FyhBwwcnTx 7/BGSpTMZrqIfs+l2fnLwvs+bQq2jo/1QvuqWPTlHyaPU6lTCfNE98taQLWBshgtf/siFiFo r53aprRoz0CAbKWX8Ui2dNKRbz8BSNgXs6eRg0+XrPrHzeK70l6U66Bme56Itc990mX/8+Rl kyAtoZj4AOXrVXMKBmQa2Alb7XqXJ1lqmk8MzBqNlGts0XPq671hEvDX/PbpYUaydE= IronPort-HdrOrdr: A9a23:oBv5HanJBnuSB5yg3Po9j9roWNDpDfPEimdD5ihNYBxZY6Wkfp +V8sjzhCWatN9OYh0dcLC7WJVpQRvnhPlICO4qTMqftWjdyRGVxeRZjLcKrAeQYhEWmtQtsJ uIEJIOduEYb2IK9foSiTPQe71LrajlgcKVbI/lvghQpGpRGsddBmlCe2Km+hocfng7OXN1Lu vU2uN34x6bPVgHZMWyAXcIG8DFut3wjZrjJToLHQQu5gWihS6hrOeSKWnS4j4uFxd0hZsy+2 nMlAL0oo2lrvGA0xfZk0ve9Y5fltfNwsZKQOaMls8WADPxjRvAXvUoZ5Sy+BQO5M2/4lcjl9 fB5z8mIsRI8nvUOlq4pBP8sjOQpAoG2jvH8xu1kHHjqcv2SHYREMxan79UdRPf9g4JoMx8+L gj5RPUi7NnSTf72Ajt7dnBUB9n0mCup2A5rOIVh3tDFaMDdb5qq5AF9k89KuZMIMvD0vFoLA BSNrCc2B4PGmnqL0wx/1MfiuBEZ05DUStvGSM5y4+oOzs/pgEN86JX/r1cop46zuNMd3B13Z W0Dk1WrsA8ciZvV9MHOA4ge7rBNoWfe2O7DIqtSW6XZp3vfUi97qLK3A== X-IronPort-AV: E=Sophos;i="5.90,149,1643691600"; d="scan'208";a="65714247" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DeUq6W7+m62zRoHKL5cEGLvOedvpfMYqZ4QfwfAW0moIjfJfKEIIL4kCIMypnSQiDmREi7K3EM/YXHjPvjaNMl/5UeVr5k9HkBQjRDX9Tb2EIbZNzw24qNxIlut+zcV2dCjkipCm7KiBl3zDqRj94o0mc+SrvtW7i9c/zGVP4KmtW74nP6OX0OIW/+K6XdzonK9GjfM7GLQlGXeWPpyjViaZR8bt7FrxaEjTcAjH0Y2B44ioVwlO5HQLmM9bMSFHt0+tRG5TaF+17r5JMjbPCJwNtMS3PXLsWBMdzrwHFAzf6XHneXHvtbhh4g4LY/eP8FpkrKuWilfE3BCmZLO16A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SzzMi113fMsllfdXNK2EhtX/Jo9shAWDFTXPcifYdio=; b=RFjIJ4MMj31R+G+H7UlQq1a4BVPwtIRud/yxRHFG3Bx7ww3A8+I495GwRxSe9xyFPv2UFve3sA8q5EYyFTXIXzMh5Bv9lhUqBa398QxcFniTRwLt+5I7+0AMgg5eszuWkmVAZ36kRghal6jiuDSifMWCubQtUz+eSUeM8vtI9AFGodKJlQrtTwJBxrFLCld3VzGJWr/0IU0bE2XDpl60E2m+NhBPCd2f3ONczHKxqETvq3XA/VRm3va9LBiTEt6N+L/MwHpGLZcL4mLcr2KIzPRQ/Jaf8jmnENcLszhnjGiSNR58nyVwm7Ku+fX0awL52TKpV/ZoYJ+ok1wuYsONhQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SzzMi113fMsllfdXNK2EhtX/Jo9shAWDFTXPcifYdio=; b=DVfzCUgo0+B+YKaAPPRH8RiqCaYKNHZ3SoZuASGp7G7d1l0TAuWvaW+B2WLn+/Jcjq8K0lu8hXRTQ7jZgxNX+QH52nxruKvTs2AVnyr594ChSp3bS//OYl48POAhD/ZrC0NUYzAV/JZtNpGO07+EmMZMCTOjsi+0b1nqWqfEkRk= From: Roger Pau Monne To: CC: , , , , , Roger Pau Monne Subject: [PATCH 0/4] livepatch: fixes for patch generation Date: Wed, 2 Mar 2022 15:27:07 +0100 Message-ID: <20220302142711.38953-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.34.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LNXP265CA0086.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:76::26) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e1af40ed-e038-41cb-0959-08d9fc58f4f6 X-MS-TrafficTypeDiagnostic: MWHPR03MB3279:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lqYc/PDLexr1HW+zroTxdG60tBaSK1tRaY5EzKKoLc3ruP/Dpf8OOZVz1vyikL6pliwvqumTI9a+2v1WDf3LTXjQpxklae3NWdyPTqfKIb0llreEmBbdahyykiNRJiHrelAJIUrZnBT/ZNTAhcuwvxCkxAmPC4h5myQk9MUQc4f4xISBtf23k2OCUeCuHSf1+zU2GWS9SJPJ8GYZYWr0sOand9mM5S91sh95M1kWecPZtGzvcZ9OmVVfDXjIEj9Czqq49jFXeL87i6gHRnoMzp/6+e6p+zYIAOy+RNEs5q4fwy9i03yd5/2/akWEcCtZW+3c8f9lRUTM57rZuBUbE0dBLpHFuHm991NE/C3+AX9duuMEyVRIvS9XsMT4vQv9jwcMOzvr+YYJsEsPcODSzT+J8ORDgYOuVC/vdLu37hiUaeLCuvjkvPjsa6B8SDjszr3CHVf31NQvEynf+H9Gp7k2nxks2foWvs8RAVYF/lHAuXiNmyYgWiOoRKhf/sJQM/0yk10xiZfyUOc5Z0uR6X5yJhB/D1K+XF1alhxZf080Tx3XtEu+FUvJoWSnBpMu7QBuH/2qv1+BeHKQOFLtIgrrPDG2eFx2CvtXO2GDty8p5tfJPZRqFZLY6c5bvSMb8RpXlny/wl0qt32yBZ3wKFtj9k7qW/iwELPOXrzAVXtxPNJkZjoDo9pY0u/UaUYC05Zh2B0PwheedeSGn49Ou4D3tTR9fTLU98Re9Ry8EoI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(4326008)(86362001)(66556008)(66946007)(8936002)(8676002)(66476007)(1076003)(107886003)(4744005)(83380400001)(5660300002)(186003)(26005)(38100700002)(82960400001)(6486002)(966005)(2906002)(2616005)(6512007)(6666004)(6506007)(6916009)(36756003)(508600001)(316002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VFZNV0tnYzVYNkpmdE9sRU1ZTmVaYjdsM2pGOEpibWsySnlFSXovT0d1Ynh0?= =?utf-8?B?eVlvRDBzelZnS2lmczAwNUJBdVYrVXlMNlRlM1BjbFZYdytzcE5KOE9aR0R4?= =?utf-8?B?NVNwYkVmWnlNQUo5QllMVWtidy9pTEo0K09nUFBadzZTd3BJcWo3MXBadUla?= =?utf-8?B?UlhMb1Z6emlGczV2VUhudy9FcUpWb2hxbkdoNTc4azZBYWtaWGVrV3YrUUll?= =?utf-8?B?YVB3WkpHa0RsdnpQRE1iNFNXeDlVZTJ2dFlqenhoOEhrMEQ1OXB6V2syVFlv?= =?utf-8?B?SXhsQTFybyt6dXNSdW04WVBoS2xRSDJqK240UkU4NUEvY2RtdWFvL1R4VFNk?= =?utf-8?B?ZGFISkd1MVJMdWF3OU5oczRtSjdjRGVzbnNWYXk2d0hFYlU2cUQ5TmIrdThi?= =?utf-8?B?ZVg2TFNUWGlNTGZpOElFN0RiV3RCYlZGTHZ1Tk13Q0ExK1cwa1dadC8zcGJW?= =?utf-8?B?SCt6WnpIQkxibWhmeE1ORUpycmFFWFplQm1Hd1MzL0JLazV6MHA1enM0NUo3?= =?utf-8?B?cDZtRHZZOGtjajVDRHVxay9DejlsR2tTRUx1SWR5ZlJFQzVQK0l2OThzQ1dB?= =?utf-8?B?N29GcW1tWFZqVTFhYkZreWg1SllMY2hpUVRFclFCQkk3ZnpKOHZZWGVnV0J4?= =?utf-8?B?UEU4TWJGN2hCU0FlRytRT3VoK2YyVE5oazltbkVWbytWMXoyeC9ZaDFMSkFn?= =?utf-8?B?ZEJaQ3J3d2x2SWRoQzVzb2R0YXZEbHFDeXNrdlZta3p3RE5UbS9FeGpzZXFt?= =?utf-8?B?OVBmMmd4WUIyR0loalh1V25VbmR2OVlNWGd6VEJGUDVzUUl2ZEUvWWZOWGZr?= =?utf-8?B?SXFlVnBia3ViQmJESHBTMnFqMUE2aUZZQkl4dnptRjd1SEdPWmpEeUtycG9w?= =?utf-8?B?TTh1cjh6WjhnM0JrNXpteGIzN013bWpOVUovTzVhWWx1RFZQNENRdEZLY0h3?= =?utf-8?B?S3JPdHh5UFViMGpQZWtkakZGQU84L2h3QmlPRVBUVUpxUXQ5R3hMTUtWajBE?= =?utf-8?B?YUhNdWl3Y3VWR1FQUTNnamxpUG5wZ2JIcW9KZ05pbCtHSkc2a2h2T25nTnc1?= =?utf-8?B?T1VUSTRrN2FlTkxpL005UW1nM1NUanhMWlNrcnhyL3AyZngrSTNwOGhVN1R6?= =?utf-8?B?MkJCM2NaSFVEQjZlUTJkZ2pkU2lEODMrU0piNzBlSHZ4V1ZUQXpWaDE5N21L?= =?utf-8?B?cjFHd0ZUMXQyaXFmbmFKWUtjM0JRNkJWUnM0NXNEaUl1TVQ4VEdzSDB0S0Nt?= =?utf-8?B?N1NaV3Qwb014S2RtZnNFL0N1dHNEcko2WGliQkkvOUhvV2FuNzMvbE1raXdl?= =?utf-8?B?Y1psaktpbDJ4MCsvVzVISFFKK21WWHBjOVU1TUFpN1p4UTN0aXY2RktEUnEx?= =?utf-8?B?Yi9UaUtndW8vK3hneXNBV0FNd1FudVhkem5QUU5MRmJ4S0xlR0dZcUpyVGJy?= =?utf-8?B?WU1ZQk81Ky9wUSt0MjBqck1xRktCTTFMNS96Um5jOHR5QUdyTU0zTVFvbzhG?= =?utf-8?B?R0gxWFhad0QxWmNzRHRVSWVMT04vWjRIU3hmTHFwRWg5YW1VVDJEenZvdkND?= =?utf-8?B?NVZTL1hxcGV2MHB2Nk1nTFNNNHV5TWlWeTlQOG5hRFN6R0M4VURhbk5MWE9M?= =?utf-8?B?b0Jwc0RlVTdhTVdTWnlXVDlQa2Q3aDhrbjJLRVA0eEkxdGNEaTg3OE9WSXFm?= =?utf-8?B?T3IzREVxR3Bvc3dodHowdnBTTnIvS2dBbE5RTjc5dnI3ZnlmcEFCUzNFdzU5?= =?utf-8?B?cHJ4S0FCcGhWclB5OXM5OXpFbnhpaHBxenQ0MHFIS3BIZkRrT0tOMkFzTWFS?= =?utf-8?B?a0t3UUdSdWJiNERhazE5ZWFCRkgyMmFnL0lxRC9IK0R0SWs4Z3BacTRIcGVj?= =?utf-8?B?ZklUZlA1cTZvS1JmZVh3S3F6R2lyQlFLcjdpUFZMTUR4ZVZJdmNyaitNd3Rn?= =?utf-8?B?YlFBYzlWTWdObk50T05ZNEwzQXVpTlp5RWFUVW41VFgySTU5UlRWUzUxUlh2?= =?utf-8?B?VlFhNElwM1VKOHdmRUlTUUg0S3JVNFB1SUQ2cjBDOWp0cGJjTlFpODY0d3pU?= =?utf-8?B?QVYxbVZtU3B4cFk2WlpYYnQyWVBjSnJRUEtvTmdMR215VEFHUVhyem1QeTZB?= =?utf-8?B?clNRQVRlNFVZNVZyU2EvbFdhZklreEZTdFYxZ3FHZkNjbE9Gc0h3cGxZbVdq?= =?utf-8?Q?S1Ml1suK+gVqVtXEX6vyKh4=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: e1af40ed-e038-41cb-0959-08d9fc58f4f6 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2022 14:28:44.7816 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sQqJGtJwAlNtOcZGPE/EDsycRwDllzU5qET8ProphhYM+9QE79dTNhUoRCdFiEffTA9/eH99YbiXJSjSB7NVSw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB3279 X-OriginatorOrg: citrix.com Hello, THe following series contains the minimum set of fixes require to get the livepatch tools to work again with current Xen version. Note the last patch depends on: https://lore.kernel.org/xen-devel/20220302134425.38465-1-roger.pau@citrix.com/T/#u If that's not considered acceptable a different way to add -f{function,data}-sections will need to be discussed. Thanks, Roger. Roger Pau Monne (4): livepatch: update readme to mention --xen-depends livepatch: improve rune for fetching of Build ID livepatch: do the initial build using CROSS_COMPILE livepatch: differentiate between old and new build systems README.md | 4 ++-- livepatch-build | 25 ++++++++++++++++--------- 2 files changed, 18 insertions(+), 11 deletions(-) -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 02 14:29:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 14:29:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282280.480956 (Exim 4.92) (envelope-from ) id 1nPPyc-0001f3-2i; Wed, 02 Mar 2022 14:29:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282280.480956; Wed, 02 Mar 2022 14:29:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPPyb-0001eu-V1; Wed, 02 Mar 2022 14:29:13 +0000 Received: by outflank-mailman (input) for mailman id 282280; Wed, 02 Mar 2022 14:29:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPPyZ-0000Xg-WC for xen-devel@lists.xenproject.org; Wed, 02 Mar 2022 14:29:12 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1f7b23bb-9a35-11ec-8eba-a37418f5ba1a; Wed, 02 Mar 2022 15:29:10 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1f7b23bb-9a35-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1646231350; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=vvgWKbFjweSwkWyBIVjjASKWnZeI8HuMMPIGjeUSkdE=; b=TloQHp67806FwFFWCBveOXgvAJQR/hSBOOn7RLSGhCm9thEhPrSh+jnv S5UfWgOM2XaJX5eLFiN0h4M1O9XG5LqoZMN/PuA5plaEp7ivxvqXIKNQr w989gdAhHNuNE4auT4Jisg0Ah2rGqWdcD09ZkOwk9jXoS51drLuNXMzPL 8=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com X-SBRS: 5.1 X-MesageID: 65219557 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:VB5y/q0IUXyr+BAHrvbD5fhxkn2cJEfYwER7XKvMYLTBsI5bpzYCn 2NNDWHUPfuNY2Hyfo1zYdzn80tVupTdzdQ3TQRppC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EE/NtTo5w7Rj2tUw24Dia++wk YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx /1HhYCMTV52Apblu8UYEABdGCZ1YrFJreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr KJCbmpXN1ba2rzwkOnTpupE36zPKOHxO4wSoDd4xCzxBvc6W5HTBa7N4Le02R9u25oXTKuDO KL1bxJMTjflehB/am4MEaIZrvbx2nDwdTZx/Qf9Sa0fvDGIkV0ZPKLWGNbSd9aHQe1cm0+Ko WSA82mRKhMHMN2SzxKV/3TqgfXA9QvrVYRXGLCm+/pChFyI2ndVGBAQTUG8o/Sylgi5Qd03A 08T/DAnoe4t9UioZt7nVha8rTiPuRt0ZjZLO7RkskfXkPOSulvHQDhfJtJcVDA4nMUGWQAuj wC1pPrKJDksqbieTnnC6rjB+FteJhMpBWMFYCYFSy4M7N/ivJw/g3rzczpzLEKmpoarQG+tm lhmuAB73uxO1pBTi81X6Hia22rEm3TfcuIiCuw7tEqB5xgxWoOqbpfABbPzvacZd9bxorVsU RE5dymiAAImUMnleM+lGrxl8FSVCxCtame0bblHRcRJythV0yT/Fb28GRknTKuTDu4KeCXyf GjYsh5L6ZlYMROCNPErPdvvU5x7k/GxT7wJs8w4iPIUOPCdkyfdoUlTibO4hTixwCDAb4llU XtkTSpcJSlDUvk2pNZHb+wczaUq1kgDKZD7HvjGI+Cc+ePGPha9EO5dWHPXN7xRxP7U8W39r ocEX+PXmko3bQELSnSOmWLlBQtRdiZT6FGfg5E/S9Nv1SI9QDBxU6KKmOh5E2Gn9owM/tr1E riGchYw4HL0hGHdKBXMbXZmabj1Wo14o259NispVWtEEVB6CWpzxM/zr6cKQIQ= IronPort-HdrOrdr: A9a23:G/RbcaHb+j4qO0NcpLqFCpHXdLJyesId70hD6qkvc3Nom52j+/ xGws536faVslcssHFJo6HlBEDmewKhyXcV2/htAV7GZmfbUQSTXedfBOfZsl/d8mjFh5VgPM RbAtlD4b/LfCFHZK/BiWHSebZQo+VvsprY/9s2p00dMz2CAJsQiDuRZDzrd3GfE2J9dOUE/d enl4J6jgvlXU5SQtWwB3EDUeSGj9rXlKj+aRpDIxI88gGBgR6h9ba/SnGjr10jegIK5Y1n3X nOkgT/6Knmm/anyiXE32uWy5hNgtPuxvZKGcTJoMkILTfHjBquee1aKva/lQFwhNvqxEchkd HKrRtlF8Nv60nJdmXwmhfp0xmI6kdY11bSjXujxVfzq83wQzw3T+Bbg5hCTxff4008+Plhza NixQuixtVqJCKFuB64y8nDVhlsmEbxi2Eli/Qvg3tWVpZbQKNNrLYY4FheHP47bW7HAbgcYa hT5fznlbZrmQvwVQGbgoAv+q3gYp0LJGbJfqBY0fblkQS/nxhCvj8lLYIk7zI9HakGOup5Dt T/Q9RVfY51P70rhNpGdZ88qOuMexrwqEH3QSuvyWqOLtBzB5uKke+y3IkI X-IronPort-AV: E=Sophos;i="5.90,149,1643691600"; d="scan'208";a="65219557" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N7Vr0xe4o12UfpVQba+JI38TboFa2i/hR+M8r2Gppz8QrUuvoEK69T+sFmrZHNjY9t2fxjtn9U9gTRHLmDyYzV3uVKxa322wPS5bBocIe+ZgNdkqxjrlU7vIYi3/bEVFiU/HkhvyLH6sZXcFoZ/P0OfN0mC+SZjhCej7bgcBt2+7s8gGJA4QOU4QfiiZm5gIh1rUez5iyESc+VFLKJkNRiI+Il4FJbgLwhkR6ew1LkuzdOdq03YW4NZTg16XSMcMLh6ZpYl/GBM+UgbInVtqLmm2RgL/5QemJxXIUK1eqp8tLRwZM9sBQCuglek2HmTolFXd7mCbfJA9Bk30qGVmFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=C6+tPn3Vtw/33Pu7XLEt/wmcadDGaOE9Qo6ldxTFLMU=; b=KMH6IhoQv7iETFGZ50psbSW6ZOu16x2MgyazNFB53MxDszlSE6b8pVMxFsMrOCFvfkx8WKf8MrMJm0gjEu/cQ6PAB17kfglhYbqwiwUnWijsywbH5bsIWcr6ztXb6kjj+Wou2TqxFcAskUwf03l+4oW366TvtXvYX2H1CDaTPK1yJWz3YI5vP/wxQRhOkAp7m8+WeAW2oyuIskGgS2lRhsHg5nk4stajvB4jQlvKtiKuMhRu3Taa6gE5dAqdgBhEkxPWvR0xV2oW2/dg0CNF+cyCpG9OpNa6cJX1qf5hepH1xNo9OE4FDSv/x0o1Q0biFVoIRybtY5bru8RzBwYarA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=C6+tPn3Vtw/33Pu7XLEt/wmcadDGaOE9Qo6ldxTFLMU=; b=gma+6fRBGnqAl0A/XmKPzaMFqm12DwqacJ7Yb+34C9t1mQ1Y2UBz5SEB9D82lvpU2FMYCZu6WF2c9lWCPWmkE0ovZ4IpMGK7wRqwpS1Z98dC190IxBKhaFMmF5VAKpbpdGE3ZhtsdXvBmv19SDJ5e+NqnajPfmCdFPgyl3dlYWc= From: Roger Pau Monne To: CC: , , , , , Roger Pau Monne Subject: [PATCH 3/4] livepatch: do the initial build using CROSS_COMPILE Date: Wed, 2 Mar 2022 15:27:10 +0100 Message-ID: <20220302142711.38953-4-roger.pau@citrix.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220302142711.38953-1-roger.pau@citrix.com> References: <20220302142711.38953-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LNXP265CA0033.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5c::21) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7747fad1-8cbd-4cb2-77f1-08d9fc58fe52 X-MS-TrafficTypeDiagnostic: BY5PR03MB5111:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VJUI8FLpJ7Gm84ir5cFBTrE1DnyrV0pGnI6GjsoEs1J+p2/G/SECqQ6pzLfO1K76mFM1mJl3mFbu/GYgnvUNQXmN1j0F6stdGO6+2TZ/Z5SURvpIBYRA1w0JMrqjUMmange1nCajirTsKO41tQCOxg1OFrWwIRWpsee8kFo3T/VRBH48BPigETGz7x/o2wIauR7OUKaq3bsAa15a0EnUYpu/ZMt+fY5NdnkoJJSRvzA5K5kKGYbB5ahAPDT1G8uWVhAaZdFh2wHSLKIS74usKnLWcOH3pAYt38hgEJqdFpGRUMka6M+ZcARePEuzGTVMhZG+Zv6ag08Vol9IWDpMCAlT7hDH2Dzxv3M1jq6knD5typnL5E60TMPTA9AUCrSoYTen8E8gEGklP3yw9xazTMSu0AAn1Ak3OszKNYjYk8/9I+UT+lnxyQfZ1F6/Wxt5tQfuOQXuBcrqCssRpZjssrrHQI2eKOB/WkYXtnOs0ct9yI1f5AYJJC6830reSoOCFU6rbZ9AxKxgXVX3qwX/KuMTxz2Gr23cqTRJWhOPGCz1ho9bY21kmuARCPX1iZn3copaP7xy/iEVGWHFEf7utr8jVNPqBzLG929GDrTflJ/G4QbT2HTrua24lQXdwcpofJXJdUqS5D1wh+pyO1h+gA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38100700002)(2906002)(6512007)(6506007)(82960400001)(83380400001)(186003)(2616005)(26005)(107886003)(6486002)(1076003)(36756003)(508600001)(4326008)(6916009)(316002)(86362001)(8936002)(8676002)(66476007)(66946007)(66556008)(6666004)(5660300002)(4744005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bHNFdUhBekRkeHlqeDFiTVcyNHBXaFdtOG1Ra1NrYndVclVtelF2eExLWEVQ?= =?utf-8?B?QXI2bXA1TC9PaUZzYUlhSGlwcndzalpRNUh2Qm9FdVBFZnhpeDd4aWRaMXhi?= =?utf-8?B?cFFISmpkM21DZW5tbWxUdlZDQ2VVQlN2SGg2YnNMek1TKzlvekVNOXJucitH?= =?utf-8?B?anNTMFlMME1zRGlDZ3NVMXdLSGZZVzI3ZjFLMmtuNVhoWkx5S2l1RjVaSnVx?= =?utf-8?B?RWczREZubXp3VUJyVlZqMk13MmdsRnJlZENqYU1oc0xUQ2haekE0MzZST1Rx?= =?utf-8?B?N3dSWkpSdFlXc2Z1THNpM0x4UXdRcU9FVkFQbTc5V3Y5RTllUmRIYXgvS3pv?= =?utf-8?B?cHV4YlkxOVVyemlXb3FnbVpxQkRpOHBLbWZ6MytXMkZKWG1NWUhONFJFREVC?= =?utf-8?B?c1JpV3FPMkpER2FiQVlMMGEvQ2h3c1MyVkt2Qi9YYkFiYTRxQ3hFQkliUVpJ?= =?utf-8?B?K1oySEhNc1M3S0ZOcDhJM3J3ZTVxam5ZOElib2pITVp2cy9LNzhjNUtETFNP?= =?utf-8?B?MkEzQlVKall2RUFTZjQ0NVdYalZkMDllTjg5dG10amxNOVNZc1pXTWQ2MGdo?= =?utf-8?B?R1UzQ24wMG4yVS9zcEsxOG9FTzFHdEszU3hWUTVpZnF3NlhkQ05kaGMzZ0Jn?= =?utf-8?B?QUdkTWFzUEhCRkJtVU9DYllNRTFPa0FuTUlUS0QrL0g5OFFLMlFFeUdodUtu?= =?utf-8?B?cGhUQmJuWmlWV0k0SWMwbHJkWmY2eVZLdXhZYkxUKzFrL0NMOHJ4dUNyem03?= =?utf-8?B?VVlEOHpwbkZ5UFRCRzJzSjgxYTBYcml4d3dxQ0YybEw3TldwbU5YZlNOcC8r?= =?utf-8?B?dnRnMUQrNzlVTkNEODA5K1VVQTFDUUpRQzBLMzdOL1RWcHhLQ3ZnYUpNUXl3?= =?utf-8?B?cGZodzdqVkVFbHc4bk02aFFUL1pEMHRocGJUVGVQWlpDMWN3YVhwOG1iYy9p?= =?utf-8?B?czVrb2toR2hheVpSY0VxajdVNFhZSENzMFZ0bTl5bEc1T1g0RytwdDRiVWRH?= =?utf-8?B?cEdEc1dFSlp3Q0VQNkZQMEhvandzUmExd0Njd1hXNmZqUkZkMkNyRHk5ZHZM?= =?utf-8?B?c01XRjEvRWpDbkY4TDVndkFGRjJyeXVwOUV2TVFGMm9ndVBDMmZiOUkyM2JJ?= =?utf-8?B?RWN0eTU1QnhhSE8rR2M5K1J5T0RiSVllUU0zY1Zaa250Z2gyU1hvYUN4aWRm?= =?utf-8?B?MVd0ZGU2UDhoSHNVZWNFMmJXdmEzbmpCU1N3UituTXRwOTVQYjJCaEg1Tjhy?= =?utf-8?B?WnN0OVdpbDIrMlFobFp5VSt1WGdydGVEN3BWYWNHMEFQVWRvN3l6SWxvMkl3?= =?utf-8?B?ODV5OFRJd0l1RVNGYk5TazdzY1I2UEZ0bk5ackF5Z2hmNk81RnJid1lVMTdu?= =?utf-8?B?cFluQU43bTNFT2g3VWtZSEhLMUduU3c1YnZGUzd4RVlaUWRUUk9vSkJSOURt?= =?utf-8?B?NHhtUk1BSlUzZ1BMRElNeXJOS25zbm0wZDZ0bXQxOUhIU000VGYrdTdQWU9i?= =?utf-8?B?ZzRlazVDdSt6UTlxZzcyVUFScWNUZ2pKRE9lOEc1Y0hvYWxzSFBuRUlMdytN?= =?utf-8?B?bVpHemRIaVdwUW03bXhIaFdSMTRBdnhMY0I4dSs2ZGVVbTJxYm1yL0pDSjBG?= =?utf-8?B?eEwvUzJRMFNiK1Vua0puQzJEWUwrV25SZDg3TWl1QjVSclc5b2JyUGhpZXFv?= =?utf-8?B?eXJyRkU4ZTFLSnphUDZQSmJjNEp6ZW5seTZZUWI1aklaSkptMDVSZVN3Mkd0?= =?utf-8?B?L2F5dlRUTGJzNk1YNkpEQ0xjV1VZTlM2YklZWSt3K3VBOWQzWWpUNUZzRkxE?= =?utf-8?B?V2lSazRsNzlCaXIyQm5SR0MwZDA5emFxMVpaK1NRRGtJTitTQUhBejdDeGpF?= =?utf-8?B?VEFrbnRYUDhROVEvdUdWSld0TkxLRGxnQTNlZTM1dDMzVHIrSks5c1gxQTFD?= =?utf-8?B?M0ZtME9zRWFmVVRlNzl4STRSS0w2ZWdMV2hhREhoZG9vemhVK2NQblZaRVlu?= =?utf-8?B?NURZRnZKV3VKaGtiWEZ0eVBGZVpCa1pubmVJdXJHTmxaM1VQY0ZkOEZSa1ZT?= =?utf-8?B?L05mNlduZkROMUhEb2F3MEtzM3JiMlVPNk95enNqODk3N0FRbSt5Z1lYbFE0?= =?utf-8?B?YVRVc0R2akhRUVFWMGIvMStlMUR0N2ZtVm9QdjloMllTbFlsRjNxc2hUalVz?= =?utf-8?Q?H9WpTxDGgaY1GJ4uvxQ4Rhw=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 7747fad1-8cbd-4cb2-77f1-08d9fc58fe52 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2022 14:29:00.5649 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ziIp2zxFGKWMBLwuSvzJ42amWF8rK6Osd/fcZFTBC/CmPg2CpAFubxWdzm6cDRg9vq9nRkY6zF3jSYH5NGuArQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB5111 X-OriginatorOrg: citrix.com Setting it afterwards for further builds will cause the build logic to detect a change and thus force a rebuild of all sources. Signed-off-by: Roger Pau Monné --- livepatch-build | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/livepatch-build b/livepatch-build index e1715ea..38a92be 100755 --- a/livepatch-build +++ b/livepatch-build @@ -92,7 +92,6 @@ function build_special() cd "${SRCDIR}" || die # Capture .o files from the patched build - export CROSS_COMPILE="${TOOLSDIR}/livepatch-gcc " export LIVEPATCH_BUILD_DIR="$(pwd)/" export LIVEPATCH_CAPTURE_DIR="$OUTPUT/${name}" mkdir -p "$LIVEPATCH_CAPTURE_DIR" @@ -408,6 +407,8 @@ if [ "${SKIP}" != "build" ]; then XEN_DEBUG="debug=$XEN_DEBUG" fi + export CROSS_COMPILE="${TOOLSDIR}/livepatch-gcc " + echo "Perform full initial build with ${CPUS} CPU(s)..." build_full -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 02 14:29:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 14:29:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282300.480967 (Exim 4.92) (envelope-from ) id 1nPPyv-0002VN-Cv; Wed, 02 Mar 2022 14:29:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282300.480967; Wed, 02 Mar 2022 14:29:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPPyv-0002VG-9O; Wed, 02 Mar 2022 14:29:33 +0000 Received: by outflank-mailman (input) for mailman id 282300; Wed, 02 Mar 2022 14:29:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPPyu-0000Xm-Aw for xen-devel@lists.xenproject.org; Wed, 02 Mar 2022 14:29:32 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2b7d3436-9a35-11ec-8539-5f4723681683; Wed, 02 Mar 2022 15:29:31 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2b7d3436-9a35-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1646231371; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=F212JEjE8ExwUhiwnl1J2kabdh8N5NeS+VZ3pk+r8zo=; b=bLlF2pyyxeLHpuqIPZWdGIi24F0wDHdE/8hfv+LwYQDgpYVgcP4SxSzL /eH+Qx4FJe8lAhr1uLlJcDK8n+mFRO/Khub5rO5OhbHxNWDQhRCrhn2g0 7XAraAYhrbM+uJFij1kd1A669twZ+lU13i84pEjGqJYLi8swUy8QYdHT0 E=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com X-SBRS: 5.1 X-MesageID: 65714265 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:lj14xKvZPaFo725k3SNvI1tLtOfnVHxeMUV32f8akzHdYApBsoF/q tZmKWqEParbMGL0KNB3bti/pEoGuJ/Uz4A1Sgc4/y4zRCMU+JbJXdiXEBz9bniYRiHhoOOLz Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQyw4bVvqYy2YLjW1jV4 4upyyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo Oihu6BcRi8UJo7Cp8lFDyVfFjhTM4Rl5bzEHnaW5Jn7I03uKxMAwt1rBUAye4YZ5vx2ESdF8 vlwxDIlN07ZwbjsmfTiF7cq1p9LwMrDZevzvll6yj7UF7A+SI3rSKTW/95Imjw3g6iiGN6AO pVANWAxMXwsZTV3GWgnV7sdtdyti1PvKx9AqleR/ZIOtj27IAtZj+G2bYu9lsaxbclSk0yVo krP+m3rBRdcONH34TiY9nOhgMffkCW9X5gdfJWo+/gvjFCNy2g7DBwNSUD9sfS/klS5Wd9UN woT4CVGhas18laiQp/iXhm7iHmetxUYVpxbFOhS1e2W4vOKuUDDXDFCF2MfLox93CMredA0/ mKRvN3WKGQzjLqQUF+T35SJrjCNNwFAeAfuehQ4ZQcC5tDipqQ6gRTOUstvHcaJszHlJd3j6 2vU9XZj3t3/meZOjvzmpg6f31pAs7CUFlZd2+nBYo6yAuqVjqaBbpfg11XU5O0owG2xHgjY5 yhsdyRzAYkz4XCxeM6lHb1l8FKBva/t3NjgbbhHRcNJG9OFoSPLQGyoyGsiTHqFy+5dEdMTX GfduBlK+LhYN2awYKl8buqZUpp2k/G+TYy0CKmFNLKih6SdkifdpkmCgmbKggjQfLUEy/lja f93j+72ZZrlNUiX5GXvHLpMuVPa7is/2XnSVfjGI+ePitKjiIquYe5dajOmN7lhhIvd+Vm92 4sPZqOilkQEOMWjM3a/zGLmBQ1TRZTNLcut8JI/my/qClcOJVzN/NeKmeJxI9E+xv8N/goKl 1nkMnJlJJPErSSvAS2Ba2x5aaOpWpB6rHkhOjcrM0ru0H8mCbtDJo9GLPPboZFPGDRf8MNJ IronPort-HdrOrdr: A9a23:mFplOaFAi9Ew1VsBpLqFDJHXdLJyesId70hD6qkvc3Jom52j+P xGws526faVslYssHFJo6HmBEDmewKiyXcV2/hsAV7GZmjbUQSTXfhfBOfZsljd8mjFh5RgPM RbAthD4b/LfCBHZK/BiWHSebtQo6jkzEnrv5ai854Ed3AaV0gK1XYeNu/0KDwTeOEQbqBJaq Z0q/A37AaISDAyVICWF3MFV+/Mq5nik4/nWwcPA1oC5BOVhT2lxbbmG1zAty1uHg9n8PMHyy zoggb57qKsv7WSzQLd7Xba69BzlMH6wtVOKcSQgow+KynqiCyveIN9Mofy9gwdkaWK0hIHgd PMqxAvM4Ba7G7QRHi8pV/X1wzpwF8Vmgnf4G7dpUGmjd3yRTo8BcYEr5leaAHl500pu8w5+L 5X3kqC3qAnQy/orWDY3ZzlRhtqnk27rT4JiugIlUFSVoMYdft4sZEfxkVIC50NdRiKp7zPKN MeTP002cwmMm9zNxvizytSKZ2XLzgO9y69Mwk/Upf/6UkSoJh7p3Fos/D30E1wsK7VcKM0ld gsAp4Y542mcfVmGJ6VfN1xOvdfKla9CC4kY1jiaWgOKsk8SgbwQtjMkfII2N0= X-IronPort-AV: E=Sophos;i="5.90,149,1643691600"; d="scan'208";a="65714265" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TRW+ahLuRH0wQAbwrnfdTFFqYrpkmDWxASA2uB825eLaCdboj3tQsJmd0QoxdVUCaIX3xK19RcvTdETXJJFDR1et7+tUiBs28sV0FIijI3oWRkkHSmDIsnkUtUwiK/VKQYDvxAIS/jYTLmPeTR5SyKewh8t3qjrtFwYmdrJ1aq0JCv5yO2nQkF8BW1LZHCTOJatHYXvoHv+sXesoyamWY8ZPyR6Tt2Bj8Wh8F3dCBr4fV+/QiKCbwKE8Dz1SZreuhwBJAh1QPGF2iwgTUNkjGf5OKU5AG1eufnWXjRCYJe5g10DTr2LSeI5gdgPZdeSt9RXzsUlUUKkL9sUjNUDmUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ju2JmzDTMXMnNqshHl/210cGfKHE694TMbi1tFP55XY=; b=NyB64aYXGKLnKkx+C2kzmiRtLDNJ4ii1w9rKRK5mQchD2wEVoZ6WhaMtBPumvbE5fh0aR8gOPwilNjT70qvvict84fhPm3Lkgcalqd4ZM4SfrLqVTMoodcPUZaIwrmSNSGsQqM9yxpPiEjbBZqrRq/p3wVAcRNS3xaPiHLahKVArB9GBWlZlEwM6WcjahNYCa+qpWeZ7xHth6VrftRAuuaWpJQTVHs5Tcp6O/7JvFbmOjfyHLNxcP6PnMpuZyUX7zCRtWIBn9T1qR0T0ZwW/Zceva7n5rh5XHGcxPXmIbrh4ofZHb0mMCQSObxQBBHpP+tOR8iNn0CNTv2boqxeaVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ju2JmzDTMXMnNqshHl/210cGfKHE694TMbi1tFP55XY=; b=QNc2Q0GbP7TEKhy4HBRVKhpZYkQy/0SeXUgFcDwbE5C4mt73DxyIqKrCzcdB4EniEnoYpsgNa3bbZvYxv667L/aTmw3TiHLWyhjfSlAo2PJoLiKQEEeqOuvgXHZbB83PlIq2kGI9HYH6UKp7a10j9dkanVb5E4fLMKjMn59wswo= From: Roger Pau Monne To: CC: , , , , , Roger Pau Monne Subject: [PATCH 4/4] livepatch: differentiate between old and new build systems Date: Wed, 2 Mar 2022 15:27:11 +0100 Message-ID: <20220302142711.38953-5-roger.pau@citrix.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220302142711.38953-1-roger.pau@citrix.com> References: <20220302142711.38953-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P123CA0086.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:138::19) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2ca53acc-a8a0-4fc0-4ac5-08d9fc590189 X-MS-TrafficTypeDiagnostic: BY5PR03MB5111:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PBi1/X1DU4N/wu046ziwigGuxdf4LUwvJr4s8SyJR5wxuzreL7c16TTH0Bww3qJxGks/9tCFNui8Psiu2Z287Pgbbeu/g2UykZ8SMG65Q7dpxjm6MxblnGh2/LnbITVvax8M06wu9zJdr7SSYaRuyYbPx8aRHeH+71yeVISOdt8/bjTkganefUA4HQGb9eLUJeIwnTPcTddJq7dvIuADupfa4j37ZziQtyb3BhuKA0APD5x0+oUGflDEPu0BlU7I78irxEDs/NlIHOVjX8iNnprHtTFV9Ivx3OUk9RvJOdHSg/CQwZlf5FqC9KKIjJ4CZ6x4cUqbwSxaB8WZw/IEXtdUR7n4duFUhLxNvQpoQ8nuPY2QW3erNghk3Jz8SMmBkySGlQITX2eqMUFt/Y/4dPPfoC1XvZ9l+iLTLyACi6dJQWti76wqRow6sBJODD1OCkCr/txZ96kOmcrl/jfmDhXo/5QJvRhEcsdqyW8uUAcSf/MRJ/LLRtRfRH6GS7/zMNUiSwJc+nOQR7jdMzbKbPWViyITkBuH4brIUgAkX513bFJAmjpZwkRfjlwHV/LiR/fsKvhbNx9hk3Wig6JvnbIHhLi/afjRnoaT4CiXe3yq1W4Z2Ka4PfzvG+zNdPMZWlGVDt0maLL3q5nkV1v/xQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38100700002)(2906002)(6512007)(6506007)(82960400001)(83380400001)(186003)(2616005)(26005)(107886003)(6486002)(1076003)(36756003)(508600001)(4326008)(6916009)(316002)(86362001)(8936002)(8676002)(66476007)(66946007)(66556008)(6666004)(5660300002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SVN0RE8xRndyWFpuQkhNUXA4V3FwcVFxTFh4cm9xVHZaa2Q2WWVhSm1HQ3ll?= =?utf-8?B?aUJ2UnV3blBjVk9hM2JNbEF0QXpibkl6OURjcGtzNG9adUtEbXRmcFh5MytD?= =?utf-8?B?bEo5bmpIZW0ybEpFajJPeUFoVFBKVE9HbDJXdUtvODlIbFg1RXluRVpYcnVN?= =?utf-8?B?UmZGTWVwQ1N2VGcyNkltMXhEaUJPV2VsTnRVck1NTFprTXhYU0oyY0ZML2tm?= =?utf-8?B?UjFVZUZwL1dKNUdPNVpMS0g1YmlpVVUxNytudk1LL2cxYkFvZEZUbmd3dmJO?= =?utf-8?B?TURFQmpma3VTSUx6di9IZWpVWjNwamQvZU9RMmgweGZlTERtc005UHJNZ2V1?= =?utf-8?B?MEV2NUlwRVZ6dmQ4VkdIdkNVRFNmdWtleEE4c0oyVitSa3M0Rk54OGFKK3Zn?= =?utf-8?B?ZUR6VGJKZTJ5OXBtOWkweC9sT2FoQWtuVG04RTZkVEFFbHhuWTRoQUZ5MG56?= =?utf-8?B?QTg1dDg3K3ZRcUZ1Z3hwMGVjZkZFOUZaaDQ1enlmblU2ZFdFMzZaVGhYRUR5?= =?utf-8?B?djZmdTk5OVM3NWhsdmk5U2hkcjVZSmhJS2ZTSmw4cVA5ZDJuRXJZUFlvTzJa?= =?utf-8?B?UU9TUzdoVE5LT25Dc1VlcTlDZGNwTWhaWllTYlIwZWxKcnNPekNReFgvQWM2?= =?utf-8?B?SlJ5cGFtKy9rZnFZVytXTWt0dTdpOHJNNDl0OUtHbjJtcW5jWnROcnIwcmJi?= =?utf-8?B?ditqcHNwaHlZUVZvVmxtSUgvdUl6RTNLUkthSFptYkE1aVdBUGU2cDlIaE1G?= =?utf-8?B?M2ZxT0hVcU1SZkw3ZGdpSmJvZnhXOTZGUW9zbEJhTmtKdjNGbFpoWllSYzd6?= =?utf-8?B?MlVIRStmWjh0Nm5XVkVnWVNaSnZ1d21pU3U2VFBweEdVM0VscFpRYXhuVE9v?= =?utf-8?B?T0VFclBvdmFXZXlJYjQvT2Z6dnBxNFEvUjJsTlBzUXovK3E2WVRaRDQ0VnM0?= =?utf-8?B?QnpPdUlBUm1Nb1lqQnJMbmQ5SEJiTmVnYTMxakZUS29kcnhqYU4yazhCMU53?= =?utf-8?B?SFFtSm9UZS84VkpaczhxdjJuTVBoU2FQaXRHdGdXZ2RkQ2ZGeE1vT0NwcXRi?= =?utf-8?B?a2VqSndKaG9MSmZvRDZ4ei92Qk5RVlpFZ2VybEZwNTBmSUU2L2dMa1JENXRY?= =?utf-8?B?YzNUMEFjVDRhTEVZS2NYT2poTmRQbXRMN2V0UGZQU29XQUg2U21BdTFYcGw4?= =?utf-8?B?ZG5nUVcvMkdRaEF3M2RBRWpIcE9sUjJZc1R1YjBiV2pEYWxUMVg0SmdndzVy?= =?utf-8?B?VjU2cFZudnhpRXJpTmFneG5VdHNvTndudmEwZEU5bDkrWG5Wc0tlUXdNUHY1?= =?utf-8?B?M1dwcGFEVHZvcnhGV1B0UkdteUdwc3lyMisxcnQ4Wkx6cU0yTWhLQitPc3NB?= =?utf-8?B?eXMyRVJvRWNCK0dFNjIvMlR5d0dRSFQzSEs0Qy9nWUp0V3BLcEFwbnQ4YURG?= =?utf-8?B?bWRVcGRpMXRHblRzTGhtYnYwQWgzaFhUU3p1R1A3eFJlaW0zMVQ2ejhrOC9D?= =?utf-8?B?Ny81aHRMSFRGc3ZaZFRBMEgrWXh5T1ZYdXo1Yy93cWgrTGI0Y0tuZmt2MW1y?= =?utf-8?B?cGVwL2R4TDlpR2xzYkg2KzdNN3podG16VUMvLzNLdlI1MmlZeTEyZnJLOFhL?= =?utf-8?B?QjJicHU1UEY2WGcxL29CbkVncytkTE9TYmpZWTFPQ3lTMC9VNkFUMXV3Z2ts?= =?utf-8?B?SC9DTUNrS0IwWFBzbFh3d1VlSGVnck5BMUN5dm42SUVOYkliUlpiTjJKZHRW?= =?utf-8?B?bTBWRUpDb2Q1NU0vL0M3OFRnbHczeXhKU3RMY1E4QUJJNmNFSHJEQm5OM0ZU?= =?utf-8?B?bnZMcjVnYWRJb2xuZ20zUUJoVHlucVJOU2ZMb3cyanhNOHd5YktObzRYMXlX?= =?utf-8?B?a0F0VzM3UWIrL0NlTmoyVVozbWw2RDZkcE5Xc3VuU2pUMmVKb2xJNGdIU09I?= =?utf-8?B?YWRIQWN3dHdHVkVQa3hiZUI2Wnl2VEJ1ZWpYOG02RmIxZmh6R0svQkRSU2RO?= =?utf-8?B?MldBaUlOQXRham9UOTRISXFSeHVrVTBQdXgxWXJSbng0eUhyQkt6MzZRaHJq?= =?utf-8?B?YlVFMjNseitndXhLUktNdFNXZVRQcWE4TnpiQ3RJcDZxaE5jOXgrK29USGts?= =?utf-8?B?QTdjQUd3eW9KNzd5cGxQWm1tZFp6WEcveFo4SEVLY1RwOTM1OHNaZVZLNDEr?= =?utf-8?Q?+Rvq3IVCIylmN2BvQEWKOBc=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 2ca53acc-a8a0-4fc0-4ac5-08d9fc590189 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2022 14:29:07.0533 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LjS7dSGqpEwBJn5id195MVJBByNLwPl0f7nY7yYVWw/v3RytnRUYeFkwdgcs2iox0+xhgM1wiPyjdVgocipsfQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB5111 X-OriginatorOrg: citrix.com Do not attempt to modify the build system if CFLAGS are not set in Rules.mk, and instead rely on CONFIG_LIVEPATCH already setting -f{function,data}-sections. Signed-off-by: Roger Pau Monné --- This depends on getting the patch to add -f{function,data}-sections when using CONFIG_LIVEPATCH accepted. --- livepatch-build | 22 ++++++++++++++-------- 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/livepatch-build b/livepatch-build index 38a92be..656cdac 100755 --- a/livepatch-build +++ b/livepatch-build @@ -98,14 +98,20 @@ function build_special() # Build with special GCC flags cd "${SRCDIR}/xen" || die - sed -i 's/CFLAGS += -nostdinc/CFLAGS += -nostdinc -ffunction-sections -fdata-sections/' Rules.mk - cp -p arch/x86/Makefile arch/x86/Makefile.bak - sed -i 's/--section-alignment=0x200000/--section-alignment=0x1000/' arch/x86/Makefile - # Restore timestamps to prevent spurious rebuilding - touch --reference=arch/x86/Makefile.bak arch/x86/Makefile - make "-j$CPUS" $XEN_DEBUG &> "${OUTPUT}/build_${name}_compile.log" || die - sed -i 's/CFLAGS += -nostdinc -ffunction-sections -fdata-sections/CFLAGS += -nostdinc/' Rules.mk - mv -f arch/x86/Makefile.bak arch/x86/Makefile + if grep -q 'nostdinc' Rules.mk; then + # Support for old build system, attempt to set -f{function,data}-sections and rebuild + sed -i 's/CFLAGS += -nostdinc/CFLAGS += -nostdinc -ffunction-sections -fdata-sections/' Rules.mk + cp -p arch/x86/Makefile arch/x86/Makefile.bak + sed -i 's/--section-alignment=0x200000/--section-alignment=0x1000/' arch/x86/Makefile + # Restore timestamps to prevent spurious rebuilding + touch --reference=arch/x86/Makefile.bak arch/x86/Makefile + make "-j$CPUS" $XEN_DEBUG &> "${OUTPUT}/build_${name}_compile.log" || die + sed -i 's/CFLAGS += -nostdinc -ffunction-sections -fdata-sections/CFLAGS += -nostdinc/' Rules.mk + mv -f arch/x86/Makefile.bak arch/x86/Makefile + else + # -f{function,data}-sections set by CONFIG_LIVEPATCH + make "-j$CPUS" $XEN_DEBUG &> "${OUTPUT}/build_${name}_compile.log" || die + fi unset LIVEPATCH_BUILD_DIR unset LIVEPATCH_CAPTURE_DIR -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 02 14:41:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 14:41:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282314.480978 (Exim 4.92) (envelope-from ) id 1nPQAT-0005T6-Hr; Wed, 02 Mar 2022 14:41:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282314.480978; Wed, 02 Mar 2022 14:41:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPQAT-0005Sz-Du; Wed, 02 Mar 2022 14:41:29 +0000 Received: by outflank-mailman (input) for mailman id 282314; Wed, 02 Mar 2022 14:41:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPQAR-0005Ss-V5 for xen-devel@lists.xenproject.org; Wed, 02 Mar 2022 14:41:27 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d6e23165-9a36-11ec-8539-5f4723681683; Wed, 02 Mar 2022 15:41:26 +0100 (CET) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04lp2058.outbound.protection.outlook.com [104.47.12.58]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-11-_sxWMuvmMQ6j6E66vToC5w-1; Wed, 02 Mar 2022 15:41:25 +0100 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by AM4PR0401MB2276.eurprd04.prod.outlook.com (2603:10a6:200:54::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.14; Wed, 2 Mar 2022 14:41:24 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5038.014; Wed, 2 Mar 2022 14:41:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d6e23165-9a36-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1646232086; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DqA8OqD+yUMC7m6+AcDWe9b9RNpI0QXmhWjntsHZNcY=; b=FNw2VU+M3LY1tuDt48SO51EYIP1SQ0/4Xdo4Pj/hfHdQk57J8WkNwbISldzjpsO9yfZl76 1KeF5vLGFL6MrbG4gvIOiZfw7GhU9h7j0hMQ/YW37FieibYZ2mA1fihv2SfcabXEMq1Utn qDtb6ERaYHoB4TdYHfyyx4Jx9qns7BA= X-MC-Unique: _sxWMuvmMQ6j6E66vToC5w-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V6Zef21ViGf5i1vijMjg9LFhQE1M5ad7tE1NTMdoQxzeJZgdaTB8ERXDUSJR7I20izIeTIt3cD/BRCtudrAbdMaouMraN1cfN4DQ4yaS6xfvmhwa7929gSjd95HAGr74anE6NtKd+ptqvnlcgQDY32NrvYAzUHP9kq3xqKlKahBkAYXvojGJ6XuszXq/XUxJi28sHKO+39dhuWFQZqtLtVUSvhE14h6F73RzqcSOOr0MWJtaUjTXRZxe2x1S/oGiTA+grUIEBMGKSp4Q+KbuGYJwBJnOcSq8SUDEq/ELHno98mU/LmAuMxUfY7otnHbB8g+VWTrFZX/zPcDcPQfswg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DqA8OqD+yUMC7m6+AcDWe9b9RNpI0QXmhWjntsHZNcY=; b=FBLCUEenjy46GfC9ARouQaYPo9p8gYe06rzV6rk7l567Db6E/ridFixGiRdFrrbaV20lkcORctE03HnEGiCcP9vxEuaVGbg2qqxn7Xj3T+4bEZl6KMm83aeBUOsRA6NC/PBossvqDOtfeZFdj7bYDtxWafDYMzeJ9y/pPMxNmTzMxSiepOqXE59D4XBm5KpL++7H1L1NVc4Fd7ze+NoyVU9og8nMWpdxNJz+zBxBVQg0PoAH4/wSgWD/XAnClYQCwRgbvyVV6FBDggYHb7rzdRDfdMa2aIMRvxNwVLNRbCvU9H7BNph5tN5zsLKyS/12Y2D46P+miI08ROxbxBCbPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 2 Mar 2022 15:41:21 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH] livepatch: set -f{function,data}-sections compiler option Content-Language: en-US To: Roger Pau Monne Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org References: <20220302134425.38465-1-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: <20220302134425.38465-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6P191CA0058.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:7f::35) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cb73a5f8-6ff3-4cbe-2f2c-08d9fc5ab952 X-MS-TrafficTypeDiagnostic: AM4PR0401MB2276:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YhiTgDYfZZ2Qtq1iTLry4iPEiXCRrkeVG8qYzAFVCveVayZzws6S0Qd8K/vPS/YjfSxc2bx2Acb3RIR49kyGfC1HKVEc1sKqRs2+CeufTY72DPG3TGMIY2wyLdJepv0YAii/wnO9dG6n39wYuaD5wWEwmK2IgjhgnxxCKA2r7pL1LiVo108jcuahrQ7KobziIvE7AI3QU01TzYbHNXq4RoEuPTSpI8JDREWoS6KEUn3xhW5MQswWLq+ghN/qN9fXqcUqmgBzDWkJh7gkwZ1vtekhrCwzAM4ic0VO4HZDv1DMah78lb/nhPZjKNz1ay1TZXCIkXdw024cgZKMVKQTsDM+zkoKVPPm2eWsqCstbYVndhpKxlgo5iSwie40MCAUv7zMaoGi07z1epSQjE4GhavOTrlqur1V192tIuoRMzoJlvUFreR1tBj1mJlFqgBWLoIv+bDSxxepmlqSVZ6zP1MnEXJVcB1DuJSUYmHP4ig0BodSauNT1vw4appp+zJuzt7UNeBs6yXbTZ8O6Iu3EDakdm4dxxswYRjfkmLvhaT1mvVLh9TETBr0Hlo5wzXPlBQJN5iYEIx66Be6rMR1X+eHNtyw+7huVqvD7vtoqP032d8PnO5SEzILFiTQojOBxGswc5tQpYMu0sLXLmLb0/3awFiC7/MfeLeMsVK4mwFZ+ygNEHpxlVO2C16U9ug1vpedDTY4LpiDmuDpOiOlLH35BIJ1Dh67qFHq37INwoG7g6GYgBnlSspPDQX8PZDP X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66556008)(66476007)(508600001)(38100700002)(66946007)(2616005)(316002)(6916009)(86362001)(31686004)(6486002)(54906003)(6512007)(6506007)(8676002)(186003)(53546011)(26005)(2906002)(5660300002)(8936002)(83380400001)(31696002)(36756003)(4326008)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SnJVWmtIdW9QZWtMK2JUYnpWQk9UQi9sd3dDckRLd01Va2hjMEx1RG5ZSUV1?= =?utf-8?B?anJpSUs0NEFIeUl2eWlONkZmcG9aV3V4Um1DVTlqRE1ZSmx1dElyTjQrdUhy?= =?utf-8?B?WXpXSVZOSHdtME5hV2ZDVThma250OXRCQm5Qak1OaE1mbFhKamw4VXQvamhM?= =?utf-8?B?NXJjZnIzMFBZa3k4VTh5b1VxaFd4NHRucjgvYlFrZHNxKzlwL3Q5eHN5WGJX?= =?utf-8?B?V2VYRE9LYzNmT205akttQmplNjFuYUF4UjlaNEM3OUtBbEtaNTdXSk9OZUNS?= =?utf-8?B?dlkwSFpCRlZYZXphZFo5VHdQZDJ2Y1JEMndscnA2UXJnWDhkQ1hVZWk5NGFZ?= =?utf-8?B?WGVsdk9UckJ4UnF6WnBIZVR1eGhlU25iV0JvbE1MZkg4YUxDTzBqNlNNOTR0?= =?utf-8?B?cWpES3lXOUdHcFIrYUFOTUxCVFJybDJBSmY4eG14ZHAyNEYrL3dhUWhnQ1Yw?= =?utf-8?B?U2NoaE5EaFpZN252ZmIvT0g0M0hoZGorTnc1RitNUU5qdlRGckF1bEF4VFl1?= =?utf-8?B?L1FyUVhSZUU1SFJyMUd2K3I0TExZR0Nta0EvVVMyOWI1MmtwN1VBZHIwM1Ew?= =?utf-8?B?cU5LUFZtNWlrcjJOdnlrZGVtSVR4WHRNMDJSVVd1cEM4T3BOZmEvNG9WVGFn?= =?utf-8?B?ME9wNjVuNlliUlhtcWhoSEdHblJleFlhYW1FdlhSZndxTzRvR0w3ZmdvKy9N?= =?utf-8?B?RlVBWEdocGY5dHVGNDBwRzFPOWFLTTVnSjBZL2J5T1FPU0RYcytMdmVxc081?= =?utf-8?B?cGIvaWF5R0czUkxwSTZsVzU1Z2gzUXhYNTdDVXI0NnE2Z2ZxZWdMUjNJZnFt?= =?utf-8?B?bzN3TVdYUkQ0d0tLbzdEUGRRV2g4VTJPYmRCKzAzUFRsVDVkZWt1T0pEd0oz?= =?utf-8?B?YnEwT2VDODlmY0Y5c3VsVDJSRWFwRFBjaFgwaUdBOXpoMXcwVE9sY1dxaVgy?= =?utf-8?B?eWNoa3R6WStLTk96Q1VCMkF3Y3JLeTZRNFpjZmpBSytQUjlCeUJPZWJlWEZu?= =?utf-8?B?eEpORzc4QUtHVjdGN0lkd3F6VkZSMjI1MHp5b2QwalRkem1kNTJlNzZaZS9Q?= =?utf-8?B?S29naEVGRFRKNHFDejZXNlQ3ekJyUmsrcGJISVZtWHRlSXNoYVVwdXU4TWR6?= =?utf-8?B?QklFeS9LWFpKS3lRaGhuVnlDK0dzLzJGQmhRR3RQczlENVBadlVuWUw1alFN?= =?utf-8?B?Y2RtWTlrbUJZSm40YUx2VElhczZsbEg1aUVsWEZFMS9MUXE0cHZPOTViUkVY?= =?utf-8?B?ZXJmRmwwcGZFNGpjOGw5emNteXV4QnR6VnQ0VjdzRjJ1SWpqQjhBeUhxZTln?= =?utf-8?B?THJuVHlVNFV4cHcyYWtPNVovUE04c0NIRXVxQVVNbnF3S1BQd3phNTh1S3h2?= =?utf-8?B?UnQ2QTBkTDVXZDNwUW1sYTNHMHE4N2RmK2U4bmVnU0d2eG5EUTNWU2RETWY0?= =?utf-8?B?MWN4UEZSajFlTXljc1dpNlZuODVMeGQyNE1rRzFlYTM2ckZRNi94M2FIdkYz?= =?utf-8?B?YjRPVmVLQVJENHJIeXlqaU0ya0J6ejBYNU9EbWtSTE5jMHVWeW0yOUxjbW9T?= =?utf-8?B?c04rcytsUDdHZE1uTlRBRkJkeGFZQ3RlR3V2VUxQOG1PV1FoeTFPVWZhc3Ew?= =?utf-8?B?bWVYMXdzMkRDOS9Tak9EeXdPSUpwVHYrdDR6OEgrUUp5SmV3OU1ralNGVFpI?= =?utf-8?B?Y3B4OXVNVEE2VUxlZFUrdjBMQzlBdVc5ODFmZEtZMCtMV0JydmdHOXY3RU1M?= =?utf-8?B?UUxTQnZybU9OT0lNWWZ1RnN0SkNCcmJBS3BZTVRDcFpobUlTSzZRcTg5MGh3?= =?utf-8?B?NlJtYTNHbjFsYkN4NXlpTXBRRXRDS24zR2crS1JBdTZabUdhdXVBaEhnTEtY?= =?utf-8?B?UURjWENHSTZNZllSSHdPeHhTQk1JOExqbzJ1b2Vlb3cxNjk2Y2czS2Vza2F0?= =?utf-8?B?dWJTa3BMU3N0OE5RcVVNQTExZC9PL1Y5Q2k5am8rQ3VaT1loTmJVNjRmaHZH?= =?utf-8?B?bC9HNUJTOFhOZG5VUy9NWWQ1Q0tLaVY5NEt0WFk2T0hySjdkY0Q4UmYvRWpo?= =?utf-8?B?angvOHU2Wi85a1FxSktscStjOXNLeVN5M3NSSGZQYTdGdjExSm1VZWM3bTVZ?= =?utf-8?B?a0tvV09JMHN4cFl1MC9DTzBTSFBKai9jd2F5MWxtMnRQaTEzU094WStTelF1?= =?utf-8?Q?OIioETKt8hMJOtllfXbRSpA=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: cb73a5f8-6ff3-4cbe-2f2c-08d9fc5ab952 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2022 14:41:23.7469 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DQTxq3nTEeTNcBLVe1CxTW3FlWzX7AfkLm+hgqyCuLuH/Hvz4sZoO7ZvlIUIDJ8JOZIyDGPHtd9kT1y6CLBdCw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0401MB2276 On 02.03.2022 14:44, Roger Pau Monne wrote: > If livepatching support is enabled build the hypervisor with > -f{function,data}-sections compiler options, which is required by the > livepatching tools to detect changes and create livepatches. > > This shouldn't result in any functional change on the hypervisor > binary image, but does however require some changes in the linker > script in order to handle that each function and data item will now be > placed into its own section in object files. As a result add catch-all > for .text, .data and .bss in order to merge each individual item > section into the final image. > > The main difference will be that .text.startup will end up being part > of .text rather than .init, and thus won't be freed. Such section only > seems to appear when using -Os, which not the default for debug or > production binaries. That's too optimistic a statement imo. I've observed it appear with -Os, but looking at gcc's gcc/varasm.c:default_function_section() there's ample room for this appearing for other reasons. Also you don't mention .text.exit, which will no longer be discarded. > --- a/xen/Makefile > +++ b/xen/Makefile > @@ -269,6 +269,10 @@ else > CFLAGS += -fomit-frame-pointer > endif > > +ifeq ($(CONFIG_LIVEPATCH),y) > +CFLAGS += -ffunction-sections -fdata-sections > +endif Perhaps CFLAGS-$(CONFIG_LIVEPATCH) += -ffunction-sections -fdata-sections ? > --- a/xen/arch/x86/xen.lds.S > +++ b/xen/arch/x86/xen.lds.S > @@ -88,6 +88,9 @@ SECTIONS > > *(.text.cold) > *(.text.unlikely) > +#ifdef CONFIG_LIVEPATCH > + *(.text.*) > +#endif This coming after the "cold" and "unlikely" special sections and ahead of .fixup isn't very nice. Also from looking at the linker scripts ld supplies I'm getting the impression that there could/ would then also be e.g. .text.cold.* and .text.unlikely.* which you'd want to separate. We may want to put the entry point in a special .text.head, put that first, and then follow ld in putting cold/unlikely stuff ahead of main .text. For the reason given in the description I can see why a conditional is warranted here. But ... > @@ -292,6 +295,9 @@ SECTIONS > *(.data) > *(.data.rel) > *(.data.rel.*) > +#ifdef CONFIG_LIVEPATCH > + *(.data.*) > +#endif > CONSTRUCTORS > } PHDR(text) > > @@ -308,6 +314,9 @@ SECTIONS > . = ALIGN(SMP_CACHE_BYTES); > __per_cpu_data_end = .; > *(.bss) > +#ifdef CONFIG_LIVEPATCH > + *(.bss.*) > +#endif ... are these two really in need of being conditional? > --- a/xen/common/Kconfig > +++ b/xen/common/Kconfig > @@ -353,7 +353,9 @@ config CRYPTO > config LIVEPATCH > bool "Live patching support" > default X86 > - depends on "$(XEN_HAS_BUILD_ID)" = "y" > + depends on "$(XEN_HAS_BUILD_ID)" = "y" && \ > + $(cc-option,-ffunction-sections) && \ > + $(cc-option,-fdata-sections) Is this for certain Clang versions? Gcc has been supporting this in 4.1.x already (didn't check when it was introduced). Jan From xen-devel-bounces@lists.xenproject.org Wed Mar 02 14:47:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 14:47:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282323.480988 (Exim 4.92) (envelope-from ) id 1nPQG1-0006Sh-8r; Wed, 02 Mar 2022 14:47:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282323.480988; Wed, 02 Mar 2022 14:47:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPQG1-0006Sa-5j; Wed, 02 Mar 2022 14:47:13 +0000 Received: by outflank-mailman (input) for mailman id 282323; Wed, 02 Mar 2022 14:47:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPQFz-0006ST-5W for xen-devel@lists.xenproject.org; Wed, 02 Mar 2022 14:47:11 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a25b5400-9a37-11ec-8eba-a37418f5ba1a; Wed, 02 Mar 2022 15:47:09 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a25b5400-9a37-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1646232429; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=l2fKHUNR8w4EvUvmQuOSeXQW0vDZjPSA79xur+RTt3Y=; b=DP96mbs74YCjZdUO/xFd1RdsqfYwbEo/r9vJAx/d14zVRjactkzbaXyC CV1SArjQ/Jf9eja113F6EGktlLrkbM9zRC41GYyHIgEp7Ez0vrVGO0enY ATFLV4Wa1kzdfebKjjM4ddfgenjoLtsSU6OWKdngBy3pCx9HI8liK7QEO s=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com X-SBRS: 5.1 X-MesageID: 65312074 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:7K5+9arGMsgph6PDNydovq9TJdJeBmIOZRIvgKrLsJaIsI4StFCzt garIBmEaPqMZWv3fNh3PYzi8kxU75bWmoJlSAY+rng2RH8R9puZCYyVIHmrMnLJJKUvbq7GA +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8lyrZRbrJA24DjWVvW4 Ymq+KUzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk b1wWZKMpQgBNbDRlbsjfVphGHt6HrF+2JPgAlG/rpnGp6HGWyOEL/RGCUg3OcsT+/ptAHEI/ vsdQNwPRknd3aTsmuv9E7QywJR4RCXoFNp3VnVI1zbWAOxgWZnea67L+cVZzHE7gcUm8fP2O ZdCMGA3M0iojxtnH3UsDJ55p72R31rbcTRFj3TWpLc52j2GpOB2+Oe0a4eEEjCQfu1Kmm6Iq 2SA+H72ajkKOdraxTeb/3aEgu7UgTi9SI8UDKe/9PNhnBuU3GN7IB8cWEa/oPK5olWjQN8ZI EsRkhfCtoBrqhbtFIOkGUTl/jjU5XbwRua8DcUx9RyAlZT6oD+SXGwnUgZhRPsFnc8pEGlCO kCyo/vlAjlmsbuwQH2b96uJoT7aBRX5PVPudgdfE1JbvoCLTJUby0uWE409SPLdYsjdRGmoq w1muhTSkFn6YSQj86ygtW7KjDu3znQiZl5kv16HNo5JA+4QWWJEW2BKwQWDhRqjBNzAJrVkg JTis5LEhAzpJcvQ/BFhuM1XQNmUCw+taVUwe2JHEZg77CiK8HW+Z41W6zwWDB43bphdJ2exM RGK6Fk5CHpv0J2CN/Ufj2WZUZlC8EQdPY69CqC8giRmOPCdizNrDAkxPBXNjggBYWAnkL0lO IfzTCpfJS1yNEiT9xLvH711+eZynkgWnDqPLbimn0XP+efPPxa9FOZaWGZim8hktctoVi2Oq I0BXyZLoj0CONDDjt7/qtZCfQhXdiFgXfgbaaV/L4a+H+avI0l4Y9f5yrI9YY112aNTk+bD5 HamXUFEjlH4gBX6xc+iMxiPtJuHsU5DkE8G IronPort-HdrOrdr: A9a23:MJgfz6hXZqpj2Chx/Rk5afc70nBQXzh13DAbv31ZSRFFG/FwyP rAoB1L73PJYWgqNU3I+ergBEGBKUmskqKdxbNhR4tKOzOWxVdATbsSlrcKpgePJ8SQzJ8+6U 4NSdkaNDS0NykHsS+Y2njILz9D+qj/zEnAv463pB0MPGJXguNbnn9E426gYzNLrWJ9dPwE/f Snl656T23KQwVpUi33PAhMY8Hz4/nw0L72ax8PABAqrCGIkDOT8bb/VzyVxA0XXT9jyaortT GtqX2y2oyT99WAjjPM3W7a6Jpb3PPn19t4HcSJzuwYMC/lhAqEbJloH5eCoDc2iuey70tCqq iGnz4Qe+BIr1/BdGC8phXgnyHmzTYV8nfnjWSVhHPyyPaJMw4SOo5kv8Z0YxHZ400vsJVXy6 RQxV+UsJJREFfpgDn9z8KgbWAkqmOE5V4Z1cIDhX1WVoUTLJVLq5YEwU9TGJAcWArn9YEcFv V0Bs203ocbTbqjVQGZgoBT+q3tYpxqdS32AXTq+/blngS+pUoJgXfxn6ck7zU9HJFUcegx2w 2LCNUsqFh0dL5kUUtMPpZwfSKJMB2+ffvtChPlHb21LtBPB5ryw6SHlYndotvaPKA18A== X-IronPort-AV: E=Sophos;i="5.90,149,1643691600"; d="scan'208";a="65312074" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TF2wBY0YcSyqQijF9ta4EpDlIrF1BbULCFYzXcZbq2M9puj6CByAh2xZWglTbyRHx/fgeoGqB8NM/XWEjHz0qQ81rmnD+jTmC3Z9ztgqcez/TXt5By8IO2vk7oWtqQ6BsoHOsZ6LQX4qaT4DJ+wcHeTB/BBEA9LrkgeZpCfuFWqyPs+f7PpKmlYJT/Sp/MISRBNkpVRpeVKCw01NiAlLa8PcZplvCLpzBuo1UI/x54AA1UvqAUAATIOqaHd1QXlZ8YVaVMBvrg9l3EGNR3oydFJHKF5LS+pp0whKyCjKolXHkM749/UGWKRpm7TxNaZaYinCl/J8iCiRJVHRN/w89g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Uc4rH5d68sevqwCU4eAMHZW/2LzR/VzyyWf5hgoFskk=; b=SlO82EZUJgvgANfIzO5T5as6j/X8Md2Kv64SmwxBMzHUj2EBaj/zOjI0miRFhnyzfvBWfPWkWVWqBoV0R47AZnBmHFBIdqDtIJaE0ul0zREhcxrwGqCTqPLtMyZCK90mX3k7eiXB8EnCI5Fu0zG3QKd8UM7DJbDJyreyiotyYqWFdKgrSXaBuZB5p182LKCUxP0YnG7a5JFCt5Mx82HxU5LBkf8PZJlhXohiIxYkKx9/kEUAN4J7UfEjwBhI7ALU/Nt6o7UdQN5rh5aYewV/jDrnlWxE0NV016nFHb+jSS6KxhL3Iqj5XqJV/Xa42Plh1eBSJiOLPfOxSJX/qMELFg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Uc4rH5d68sevqwCU4eAMHZW/2LzR/VzyyWf5hgoFskk=; b=pq8iZ1C+WUkk/Ihq67HQGLKpvlBVfvVGkSiL4P/Ko7+iU6xKMNn/DyrQvtER3YjPpSNUHXSAYZR453DDYuedtxreeSncw+34PA/DFozm/IMgDeCr1zQmK9UlPUplx9WrBzj0e3wmu3/cpyLDlDdh0T/8Aa8xrztwQDiPoPe2LIU= Date: Wed, 2 Mar 2022 15:46:56 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich CC: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu Subject: Re: [PATCH] x86: drop use of CONSTRUCTORS from linker script Message-ID: References: <1791edb8-030f-1009-c392-ce793baace5a@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1791edb8-030f-1009-c392-ce793baace5a@suse.com> X-ClientProxiedBy: LO4P123CA0219.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a6::8) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f51223b7-429d-4e3c-67a9-08d9fc5b82b4 X-MS-TrafficTypeDiagnostic: BN7PR03MB3586:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IXVlCtRsI5N+sflfPVC6t5PIvLdW/GYuCHET/dxSRx9tbisLme26hw4TUP8wMgmQaBEbVemN1ba9x2/hGB1LwLkbuEwk8e0TWLLT8q7iRQ0DHziJgu2jFShN9r0DhfmMcSGFrVyBCZA8BwYIoJxviAFxSf+iT4gbms4x5Gx9qiXxptgVz+t2pgVb8T1FsdMHsdTkcyIEbdW3hTLoDYMdRyZSVmyvouIUc8HJUKOpAuzrPjOSwK/4r7yBQi6vJMW3MCpuftQOYXZW0yN/R3uzeERVtino5OzWgpEaC76xP2B1kGbJUuv6nSdC8JB240Ugi+FdcWXdS1vPaMwAoKZLqPLXssSbQlDxwsWXDPTpnx5bkLwsumg1zN0dXf1yh4+quoUYqDJRhtuCwZrPC3KKGpc70aNzHQ5kZv3aDV7bHbeVdfm7fcNxdJm76CqajfRNXtKdf3I3SrCzNUi98ycEUYBgMwCJ34tmsuBLTBNYTMY7FX6qp5l7TMez5X7MbN6eRdgkkYq5APoon/ABUhI1i9AsokpIs1XuOosmKdYmuGOeKOxq2krtOqxyI+xEsAs7K9f4nY3AAvqDcD3ApJlMIgfTh6PQ3QEXW/pUFommbrC1e8zAXlsYDPvhB7WYciI87433gbxEt0nnYuKXd3Pqvw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(38100700002)(2906002)(6512007)(9686003)(82960400001)(6506007)(33716001)(186003)(26005)(6916009)(54906003)(316002)(8936002)(4326008)(8676002)(6486002)(66476007)(85182001)(508600001)(66946007)(66556008)(6666004)(4744005)(86362001)(5660300002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U2Q3UjdpODcySyt5RWN1NXNkemovWE9pWUFOTUE5TVFmYk0xazFwL0ZRaEtB?= =?utf-8?B?NUFxQ0FmTzNJbGRrdDh6bmRLd3V2MFY3VzY0cWNMb3NHMmpMYmExU0VXRnJQ?= =?utf-8?B?TDFzUk9RNjdqTXpRaEVlUm9QOXBWdVhaTDVlT2p3OE4rT0xvbytWMzZZdkxm?= =?utf-8?B?U0JDd21UR1pvbEY0Y1kvMVNOR2cxUElQZklMZUg4bk9UbXhlTmFVUnRuVU5s?= =?utf-8?B?QXh0Y3lSZkJnZk5UWDhKTjRTN2dxeHBEUHgrM0gxQWtVVk94K2tXNjBMeU5G?= =?utf-8?B?aW5IWUMwWWRJaG1SZWR1c2dEWTFDalpHMTU3dlRwNENhRHptZ2xSWVFlSGw3?= =?utf-8?B?U2U2K1VINTY5SWwzYzRWeDkzUXRJY2VBRGNDbkZTTWZiTVFPN1Z4TnRHNnNG?= =?utf-8?B?MW1uN2RKa25iVE94dG56WXcvWmg0SGpkSnVvUytCQ2VjS1ByWTJkeDRxY3BL?= =?utf-8?B?YlJJOWJnUmZpZm1MWU0rWUkyWFIwMTF6L0EyTkxFTFM1Q0JlclpnanJjOURE?= =?utf-8?B?LzY0eGZVUWhNOFdWSUlWTi9hYTM1dTZnc3l4MS9yZEg5UTdJcEltVG9oNTFD?= =?utf-8?B?SGpxOUV1SnUybG1WaWIxdVBiRCtqb2FnNUNwdWlLMXlFbjh5Q1B1cmZobTln?= =?utf-8?B?cmZlOHNNWjBaUWZsaGJ5UXU0Z2lTVWlZWU1tUXZKUmtHZjIvMHFzSTJRci9M?= =?utf-8?B?TlRZc1hrMFZKelE2QllEMnYyaDM1UUZFZUd0S3VVVmNaZ2VkT0oydDcvdWI4?= =?utf-8?B?RWROQTFqN05RVmV4aVl2eFpPTWdMbituSVZ6NXBQZkJHQm1ZMDM3Y2tiQVB2?= =?utf-8?B?Z2JxTnI1bmRVS1Q3TURVVlZBbTVDZFJsa0VXWVVzUVlpZ01kQ0l6SzhjNjly?= =?utf-8?B?MW5MZ1RjaFoyMXZFUFozTU5naTlIOEtFWFVnVUtOYjJ4MWdOS210QzJyTjV1?= =?utf-8?B?WmZKVEtqVzQ5ZVRRL2RSZlFyVnFiVXJ2LytGU1c3RmtOdnBrZCtoRWsxQXZH?= =?utf-8?B?ajR5OHpPTjJqRW1ST1FUbkVHWnRLZ2dTR2FFNzZhcnhZZVJmMWJuNGhKSTZh?= =?utf-8?B?L3BBRHcrYnZBTi91OEE4bmNjbytqNmpCNlFLd0FDK2N0dUoxSUp3OGo4c2Yr?= =?utf-8?B?QjhFVWFPTkN2UFdodHNuVzBtRFVXbm1LYlpIOUw3c1gvNGJ6MEpGTEk3RTdv?= =?utf-8?B?SEVDMWtEWmFCU3ZuMnBuTmswZXVvQjBPV2pKQTFyL2Q4TFQ2UzJDY2lIT2tz?= =?utf-8?B?RlowQUpSU0xSMVNlOUV4OEN6Vm9ObnNxMHNTYU95ckNOUW1xQVFVSHR0Z2JC?= =?utf-8?B?S2FmOTAzT0dHelFERzlFbVZzRnZRbWJUUm9BZzNvR0JhM2lMVTRvR1pwQm94?= =?utf-8?B?MWtxMkh4cHFOcTZhamJVaVFRRUNCQ3k1SFZGSkZYcDBLV2pGdWhsempKT2JQ?= =?utf-8?B?UFhNbzBUaEVCMHdKSE0zd2JMNEVBYU1CMnBzaE5ISkFtYkd0MWh1TFBXQnR0?= =?utf-8?B?NHl4d0h0MC9uOWxVYVFIU0wwWitLNnpaQzU0YjV4K0dyaFNKcERNcTkvVzhn?= =?utf-8?B?cTZpS1VXN0pUOWNramh3Q0NRTjhNSTBkNnpLZFpMU1l2U0lUN2hWUEVVbTQv?= =?utf-8?B?cGV2TVVRUXdJS3h3QlhMYWQ3VzBlY2lxZTZ4M2lVSDNMU3ZWOGdUcVlRNWpE?= =?utf-8?B?UGthTFRMZ09xdUFiUnBNSitYb1hiazlUbDhDK01wc2l2VlJwTmVwS2cxL1VM?= =?utf-8?B?T0E1alNSRG5tb3B0TVNKcFN5SWIvUnE1eGtiVGFPMzdqOEJVQkpGRGNLeWVt?= =?utf-8?B?OWpRd0ljS0drWVlBQlUrd3FWY2lIQTdFRXk2QXRFZFlIb2xhV2QxRGZGRFBR?= =?utf-8?B?M1ZBVjlib01Jd0h0SEJqajlpRUZmUlJKWkFsQzVXM0padFRCcnArNnRRL0V4?= =?utf-8?B?RjBvcjllWUFRMkVHOW5qbHZ5YTVwQWlzZHQ0d1N2QWhJcmFINUJ3TUNzUzE4?= =?utf-8?B?c2g4UkdlbGVtS08wblpzUFgxNmRING95eUllYzJnTkZ5QzB2R1NMQmZDUkpp?= =?utf-8?B?R05qV1VzZUpuZmU4Syt0RVEvYzNqSlBXZWhkRzdlNHRMUHIybWFxbGx0eXRw?= =?utf-8?B?Smo1dmx1bXBqeDEzZVB2NVRSNERRbWg4aWEyVE9VVGEyVUZucW5UZWxMUm0y?= =?utf-8?Q?xL8oYMuVx8n9xkTDMDvDub0=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: f51223b7-429d-4e3c-67a9-08d9fc5b82b4 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2022 14:47:01.5813 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kQ9w+R8qRrUFEEjV+hNlisAhho7FbV+bCWSVwm/okFpcwIqkXAyJ5qeUsfNt85/YRC+GedoqJGvFvr//OldpmA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB3586 X-OriginatorOrg: citrix.com On Wed, Mar 02, 2022 at 03:15:29PM +0100, Jan Beulich wrote: > Current binutils document this for use by a.out only. Plus we deal with > .ctors and alike sections elsewhere in the script anyway. > > Signed-off-by: Jan Beulich Acked-by: Roger Pau Monné Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed Mar 02 15:01:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 15:01:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282330.480999 (Exim 4.92) (envelope-from ) id 1nPQU3-0000bB-He; Wed, 02 Mar 2022 15:01:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282330.480999; Wed, 02 Mar 2022 15:01:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPQU3-0000b4-Ec; Wed, 02 Mar 2022 15:01:43 +0000 Received: by outflank-mailman (input) for mailman id 282330; Wed, 02 Mar 2022 15:01:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPQU1-0000as-Dt for xen-devel@lists.xenproject.org; Wed, 02 Mar 2022 15:01:41 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a9127ac9-9a39-11ec-8539-5f4723681683; Wed, 02 Mar 2022 16:01:40 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a9127ac9-9a39-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1646233300; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=5KcxhijTDRSq6JWWwTlcwnD9VXMmCwU9rJErCFz1CI0=; b=W+laNnovRASbArDK1Bs7v0xAxuXdbNgp99kM8mVKhkgHDcRAR08/nF7K /gZvohof0Qn3k8EeHaVxg0DOD5OOVzNWpXAA/DHn0nPiAeVahlEJPJkdp b3iR8D2+asqZGqNzY61YIuNCXRmBrKYygRhBjjB0xCCVCcUS6WGZjNHWq Y=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 64766513 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:nkfro6+Ww23y4RDBtJTEDrUD5H6TJUtcMsCJ2f8bNWPcYEJGY0x3y zBOXG6Ba/vZN2fwfY12O42yoENT78LVmoJhHQZl+yw8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy +1EN7Es+ehtFie0Si+Fa+Sn9T8mvU2xbuKU5NTsY0idfic5DnZ54f5fs7Rh2NQw2oDjW1jlV e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9 DlCna2bSEQuIrPgpLgYTyFDOS1gbZdUo5aSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFKEWvHwm6DjdBPIvR53rSKTW/95Imjw3g6iiGN6AO 5VHN2c2N3wsZTUVOmU6Us4guduUjyjSVRdXtHvPpu04tj27IAtZj+G2bYu9lsaxbdVYmAOUq 3zL+0z9AwoGL5qPxDyd6HWui+TT2yThV+ov+KaQr6AwxgfJnypKVUNQBQDTTeSFZlCWavlea EsI5AYS8a0uzFeBQsetZQ/jiSvR1vIDYOZ4H+o/4QCL76Pb5QeFG2QJJgJ8hMwaWNweHmJzi ALQ9z/9LXk26eDOFyrBnluBhW7qYUAowXk+iTjopOfvy/3qu8kNgx3GVb6P+4bl34SuSVkcL 91nxRXSZon/b+ZWj81XHnid2lpAQ6QlqCZvvG07uUr/s2tEiHaNPdDA1LQixa8owHylZleAp mMYvMOV8foDC5qA/ATUHrlTRe/xv6fbaWyG6bKKI3XH3273k5JEVdoNiAyS2W8zappUEdMXS BW7VfxtCG97YyLxMP4fj3OZAMU216nwfekJpdiPBueilqNZLVfdlAk3PBb49zm0zCAEzPFuU b/GIJ3EJStLVsxaIM+eGr51PUkDnXtlmws+hPnTknya7FZpTCXNGOddbQDXNbhRAWHtiFy9z uuz/vCik313ONASqAGMmWLPBTjm9UQGOK0= IronPort-HdrOrdr: A9a23:48gkAK7sq8gn1GfzDwPXwMTXdLJyesId70hD6qhwISY6TiX+rb HIoB17726RtN9/YhEdcLy7VJVoIkmskKKdg7NhXotKNTOO0ADDQb2KhbGSpQEIcBeeygcy78 hdmtBFeb/NMWQ= X-IronPort-AV: E=Sophos;i="5.90,149,1643691600"; d="scan'208";a="64766513" From: Jane Malalane To: Xen-devel CC: Jane Malalane Subject: [PATCH v4 0/2] xen: Report and use hardware APIC virtualization capabilities Date: Wed, 2 Mar 2022 15:00:54 +0000 Message-ID: <20220302150056.14381-1-jane.malalane@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Jane Malalane (2): xen+tools: Report Interrupt Controller Virtualization capabilities on x86 x86/xen: Allow per-domain usage of hardware virtualized APIC docs/man/xl.cfg.5.pod.in | 19 ++++++++++++++++ docs/man/xl.conf.5.pod.in | 12 ++++++++++ tools/golang/xenlight/helpers.gen.go | 16 +++++++++++++ tools/golang/xenlight/types.gen.go | 4 ++++ tools/include/libxl.h | 14 ++++++++++++ tools/libs/light/libxl.c | 3 +++ tools/libs/light/libxl_arch.h | 9 ++++++-- tools/libs/light/libxl_arm.c | 12 ++++++++-- tools/libs/light/libxl_create.c | 22 ++++++++++-------- tools/libs/light/libxl_types.idl | 4 ++++ tools/libs/light/libxl_x86.c | 39 ++++++++++++++++++++++++++++++-- tools/ocaml/libs/xc/xenctrl.ml | 7 ++++++ tools/ocaml/libs/xc/xenctrl.mli | 7 ++++++ tools/ocaml/libs/xc/xenctrl_stubs.c | 16 +++++++++---- tools/xl/xl.c | 8 +++++++ tools/xl/xl.h | 2 ++ tools/xl/xl_info.c | 6 +++-- tools/xl/xl_parse.c | 16 +++++++++++++ xen/arch/x86/domain.c | 28 ++++++++++++++++++++++- xen/arch/x86/hvm/vmx/vmcs.c | 14 ++++++++++++ xen/arch/x86/hvm/vmx/vmx.c | 40 +++++++++++++-------------------- xen/arch/x86/include/asm/domain.h | 3 +++ xen/arch/x86/include/asm/hvm/domain.h | 6 +++++ xen/arch/x86/include/asm/hvm/vmx/vmcs.h | 3 +++ xen/arch/x86/sysctl.c | 7 ++++++ xen/arch/x86/traps.c | 6 ++--- xen/include/public/arch-x86/xen.h | 2 ++ xen/include/public/sysctl.h | 11 ++++++++- 28 files changed, 285 insertions(+), 51 deletions(-) -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Wed Mar 02 15:01:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 15:01:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282332.481022 (Exim 4.92) (envelope-from ) id 1nPQU5-000174-8D; Wed, 02 Mar 2022 15:01:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282332.481022; Wed, 02 Mar 2022 15:01:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPQU5-00016x-4N; Wed, 02 Mar 2022 15:01:45 +0000 Received: by outflank-mailman (input) for mailman id 282332; Wed, 02 Mar 2022 15:01:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPQU3-0000ay-JO for xen-devel@lists.xenproject.org; Wed, 02 Mar 2022 15:01:43 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a8f740e1-9a39-11ec-8eba-a37418f5ba1a; Wed, 02 Mar 2022 16:01:39 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a8f740e1-9a39-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1646233300; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=dLkO0tmIaYPJe2fT+HcfrZyx5zmyRYHHcDp5UxV8Npg=; b=MUv2czl9OJdRPGmqBhVtjZpVA75eE7EeZqpLgCsfq/lE94Fs+xUG12hA ivQST79t3gJSycOiTPphjJ4xouzvLyt/vj2ORXZb27hEICxyyhhPAKqSC yC9ZsRWQgYTG8MkNuu8DG1RJfi/2l6lW2+fz+KIDfQHepg5SecDEc3dhL I=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 67621795 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:LYTCGaIO2qMHdqnxFE+RM5UlxSXFcZb7ZxGr2PjKsXjdYENS0jYGn 2EYCm7UPPbYYGPyKd8lO4S0/R5XvpLczd9mGwNlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA148IMsdoUg7wbRh2dYy2YPR7z6l4 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4 Nxhk8C/aFYiBL/rg79HeQNYPT9nJqITrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq 6ZecmpUKEne2aTmm9pXScE17ignBOviOo5Zn3hkxDXQC/sOSpHfWaTao9Rf2V/cg+gQQqiEP pVINFKDajzPSj5dORAWJ6sDxsiYjXXSdj1ToUi88P9fD2/7k1UqjemF3MDuUseRWcxfk0Kcp 2TH12f0GBcXMJqY0zXt2nCxgu7CmwvrVYRUE6e3ntZUh1mUyn0WGQchf1KxqvmkiWazQ9tab UcT/0IGoaEs+WSxQ9L6Xhn+p2SL1jYeVMBXCPYS8xyWx+zf5APxLngJSHtNZcIrsOcyRCc2z RmZktXxHzttvbaJD3WH+d+8sjeaKSUTa2gYakcsTwEI/t3iq4EblQ/UQ5BoF6vdszHuMWium XbQ9nF43uhNy55Qv0mmwbzZqzuAgMTGb18+3BfwRTn/xBl5SpC8fIP9vDA38s18BIqeS1CAu l0NlM6f8P0CAPmxqcCdfAkeNOr3vqjYaVUwlXYqRsB8rGr1pxZPaKgNuGkWGat/DioTldYFi mf3sBgZ2pJcNWDCgURfM9PoUJRCIUQN+L3YuhHogjhmP8AZmOyvpngGiausM4bFyhJEfUYXY 8rzTCpUJSxGYZmLNRLvLwvn7Zclxzol2UTYTo3hwhKs3NK2PSDJF+5baAPfMLlotstoRTk5F f4FbaNmLD0FDYXDjtT/q9ZPfTjm01BhbXwJlyCnXrHaeVc3cI3QI/TQ3akga+RYc1d9zY/1E oWGchYAkjLX3CSfQS3TMywLQO6/DP5X8CNgVQRxbAnA5pTWSdv2hEvpX8BsJudPGS0K5aMcc sTpjO3bWqUfEmmcom9FBXQ/xaQ7HCmWacu1F3LNSFACk1RIHl2hFgPMFuc3yBQzMw== IronPort-HdrOrdr: A9a23:NFLOf6NsO3zrIMBcTvmjsMiBIKoaSvp037Eqv3oedfUzSL3gqy nOpoV86faaslYssR0b9exofZPwJE80lqQFhrX5X43SPzUO0VHAROoJgLcKgQeQfxEWntQtrZ uIGJIeNDSfNzdHZL7BkWuFL+o= X-IronPort-AV: E=Sophos;i="5.90,149,1643691600"; d="scan'208";a="67621795" From: Jane Malalane To: Xen-devel CC: Jane Malalane , Wei Liu , "Anthony PERARD" , Juergen Gross , "Andrew Cooper" , George Dunlap , Jan Beulich , Julien Grall , "Stefano Stabellini" , Christian Lindig , David Scott , "Volodymyr Babchuk" , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH v4 2/2] x86/xen: Allow per-domain usage of hardware virtualized APIC Date: Wed, 2 Mar 2022 15:00:56 +0000 Message-ID: <20220302150056.14381-3-jane.malalane@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20220302150056.14381-1-jane.malalane@citrix.com> References: <20220302150056.14381-1-jane.malalane@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Introduce a new per-domain creation x86 specific flag to select whether hardware assisted virtualization should be used for x{2}APIC. A per-domain option is added to xl in order to select the usage of x{2}APIC hardware assisted vitualization, as well as a global configuration option. Having all APIC interaction exit to Xen for emulation is slow and can induce much overhead. Hardware can speed up x{2}APIC by decoding the APIC access and providing a VM exit with a more specific exit reason than a regular EPT fault or by altogether avoiding a VM exit. On the other hand, being able to disable x{2}APIC hardware assisted vitualization can be useful for testing and debugging purposes. Note: - vmx_install_vlapic_mapping doesn't require modifications regardless of whether the guest has "Virtualize APIC accesses" enabled or not, i.e., setting the the APIC_ACCESS_ADDR VMCS field is fine so long as virtualize_apic_accesses is supported by the CPU. - XEN_HVM_CPUID_XAPIC_VIRT will now also depend on HW supporting virtualize_apic_accesses but this addition has no effect since apic_reg_virt support, which is currently a requirement for setting this CPUID bit, without virtualize_apic_accesses has no effect on xAPIC accesses anyway. Suggested-by: Andrew Cooper Signed-off-by: Jane Malalane --- CC: Wei Liu CC: Anthony PERARD CC: Juergen Gross CC: Andrew Cooper CC: George Dunlap CC: Jan Beulich CC: Julien Grall CC: Stefano Stabellini CC: Christian Lindig CC: David Scott CC: Volodymyr Babchuk CC: "Roger Pau Monné" v4: * Add has_assisted_x{2}apic macros and use them where appropriate * Replace CPU checks with per-domain assisted_x{2}apic control options in vmx_vlapic_msr_changed() and cpuid_hypervisor_leaves(), following edits to assisted_x{2}apic_available definitions in patch 1 Note: new assisted_x{2}apic_available definitions make later cpu_has_vmx_apic_reg_virt and cpu_has_vmx_virtual_intr_delivery checks redundant in vmx_vlapic_msr_changed() v3: * Change info in xl.cfg to better express reality and fix capitalization of x{2}apic * Move "physinfo" variable definition to the beggining of libxl__domain_build_info_setdefault() * Reposition brackets in if statement to match libxl coding style * Shorten logic in libxl__arch_domain_build_info_setdefault() * Correct dprintk message in arch_sanitise_domain_config() * Make appropriate changes in vmx_vlapic_msr_changed() and cpuid_hypervisor_leaves() for amended "assisted_x2apic" bit * Remove unneeded parantheses v2: * Add a LIBXL_HAVE_ASSISTED_APIC macro * Pass xcpyshinfo as a pointer in libxl__arch_get_physinfo * Add a return statement in now "int" libxl__arch_domain_build_info_setdefault() * Preserve libxl__arch_domain_build_info_setdefault 's location in libxl_create.c * Correct x{2}apic default setting logic in libxl__arch_domain_prepare_config() * Correct logic for parsing assisted_x{2}apic host/guest options in xl_parse.c and initialize them to -1 in xl.c * Use guest options directly in vmx_vlapic_msr_changed * Fix indentation of bool assisted_x{2}apic in struct hvm_domain * Add a change in xenctrl_stubs.c to pass xenctrl ABI checks --- docs/man/xl.cfg.5.pod.in | 19 ++++++++++++++++ docs/man/xl.conf.5.pod.in | 12 ++++++++++ tools/golang/xenlight/helpers.gen.go | 12 ++++++++++ tools/golang/xenlight/types.gen.go | 2 ++ tools/include/libxl.h | 7 ++++++ tools/libs/light/libxl_arch.h | 5 +++-- tools/libs/light/libxl_arm.c | 7 ++++-- tools/libs/light/libxl_create.c | 22 +++++++++++-------- tools/libs/light/libxl_types.idl | 2 ++ tools/libs/light/libxl_x86.c | 28 +++++++++++++++++++++-- tools/ocaml/libs/xc/xenctrl.ml | 2 ++ tools/ocaml/libs/xc/xenctrl.mli | 2 ++ tools/ocaml/libs/xc/xenctrl_stubs.c | 2 +- tools/xl/xl.c | 8 +++++++ tools/xl/xl.h | 2 ++ tools/xl/xl_parse.c | 16 ++++++++++++++ xen/arch/x86/domain.c | 28 ++++++++++++++++++++++- xen/arch/x86/hvm/vmx/vmcs.c | 4 ++++ xen/arch/x86/hvm/vmx/vmx.c | 39 +++++++++++++-------------------- xen/arch/x86/include/asm/hvm/domain.h | 6 +++++ xen/arch/x86/include/asm/hvm/vmx/vmcs.h | 3 +++ xen/arch/x86/traps.c | 6 ++--- xen/include/public/arch-x86/xen.h | 2 ++ 23 files changed, 191 insertions(+), 45 deletions(-) diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in index b98d161398..dcca564a23 100644 --- a/docs/man/xl.cfg.5.pod.in +++ b/docs/man/xl.cfg.5.pod.in @@ -1862,6 +1862,25 @@ firmware tables when using certain older guest Operating Systems. These tables have been superseded by newer constructs within the ACPI tables. +=item B + +B<(x86 only)> Enables or disables hardware assisted virtualization for +xAPIC. With this option enabled, a memory-mapped APIC access will be +decoded by hardware and either issue a more specific VM exit than just +an EPT fault, or altogether avoid a VM exit. Notice full +virtualization for xAPIC can only be achieved if hardware supports +“APIC-register virtualization” and “virtual-interrupt delivery”. The +default is settable via L. + +=item B + +B<(x86 only)> Enables or disables hardware assisted virtualization for +x2APIC. With this option enabled, an MSR-Based APIC access will +either issue a VM exit or altogether avoid one. Notice full +virtualization for x2APIC can only be achieved if hardware supports +“APIC-register virtualization” and “virtual-interrupt delivery”. The +default is settable via L. + =item B B<(x86 only)> Hides or exposes the No-eXecute capability. This allows a guest diff --git a/docs/man/xl.conf.5.pod.in b/docs/man/xl.conf.5.pod.in index df20c08137..95d136d1ea 100644 --- a/docs/man/xl.conf.5.pod.in +++ b/docs/man/xl.conf.5.pod.in @@ -107,6 +107,18 @@ Sets the default value for the C domain config value. Default: maximum grant version supported by the hypervisor. +=item B + +If enabled, domains will use xAPIC hardware assisted virtualization by default. + +Default: enabled if supported. + +=item B + +If enabled, domains will use x2APIC hardware assisted virtualization by default. + +Default: enabled if supported. + =item B Configures the default hotplug script used by virtual network devices. diff --git a/tools/golang/xenlight/helpers.gen.go b/tools/golang/xenlight/helpers.gen.go index dd4e6c9f14..dece545ee0 100644 --- a/tools/golang/xenlight/helpers.gen.go +++ b/tools/golang/xenlight/helpers.gen.go @@ -1120,6 +1120,12 @@ x.ArchArm.Vuart = VuartType(xc.arch_arm.vuart) if err := x.ArchX86.MsrRelaxed.fromC(&xc.arch_x86.msr_relaxed);err != nil { return fmt.Errorf("converting field ArchX86.MsrRelaxed: %v", err) } +if err := x.ArchX86.AssistedXapic.fromC(&xc.arch_x86.assisted_xapic);err != nil { +return fmt.Errorf("converting field ArchX86.AssistedXapic: %v", err) +} +if err := x.ArchX86.AssistedX2Apic.fromC(&xc.arch_x86.assisted_x2apic);err != nil { +return fmt.Errorf("converting field ArchX86.AssistedX2Apic: %v", err) +} x.Altp2M = Altp2MMode(xc.altp2m) x.VmtraceBufKb = int(xc.vmtrace_buf_kb) if err := x.Vpmu.fromC(&xc.vpmu);err != nil { @@ -1605,6 +1611,12 @@ xc.arch_arm.vuart = C.libxl_vuart_type(x.ArchArm.Vuart) if err := x.ArchX86.MsrRelaxed.toC(&xc.arch_x86.msr_relaxed); err != nil { return fmt.Errorf("converting field ArchX86.MsrRelaxed: %v", err) } +if err := x.ArchX86.AssistedXapic.toC(&xc.arch_x86.assisted_xapic); err != nil { +return fmt.Errorf("converting field ArchX86.AssistedXapic: %v", err) +} +if err := x.ArchX86.AssistedX2Apic.toC(&xc.arch_x86.assisted_x2apic); err != nil { +return fmt.Errorf("converting field ArchX86.AssistedX2Apic: %v", err) +} xc.altp2m = C.libxl_altp2m_mode(x.Altp2M) xc.vmtrace_buf_kb = C.int(x.VmtraceBufKb) if err := x.Vpmu.toC(&xc.vpmu); err != nil { diff --git a/tools/golang/xenlight/types.gen.go b/tools/golang/xenlight/types.gen.go index 87be46c745..253c9ad93d 100644 --- a/tools/golang/xenlight/types.gen.go +++ b/tools/golang/xenlight/types.gen.go @@ -520,6 +520,8 @@ Vuart VuartType } ArchX86 struct { MsrRelaxed Defbool +AssistedXapic Defbool +AssistedX2Apic Defbool } Altp2M Altp2MMode VmtraceBufKb int diff --git a/tools/include/libxl.h b/tools/include/libxl.h index 94e6355822..cdcccd6d01 100644 --- a/tools/include/libxl.h +++ b/tools/include/libxl.h @@ -535,6 +535,13 @@ #define LIBXL_HAVE_PHYSINFO_ASSISTED_APIC 1 /* + * LIBXL_HAVE_ASSISTED_APIC indicates that libxl_domain_build_info has + * assisted_xapic and assisted_x2apic fields for enabling hardware + * assisted virtualization for x{2}apic per domain. + */ +#define LIBXL_HAVE_ASSISTED_APIC 1 + +/* * libxl ABI compatibility * * The only guarantee which libxl makes regarding ABI compatibility diff --git a/tools/libs/light/libxl_arch.h b/tools/libs/light/libxl_arch.h index 207ceac6a1..03b89929e6 100644 --- a/tools/libs/light/libxl_arch.h +++ b/tools/libs/light/libxl_arch.h @@ -71,8 +71,9 @@ void libxl__arch_domain_create_info_setdefault(libxl__gc *gc, libxl_domain_create_info *c_info); _hidden -void libxl__arch_domain_build_info_setdefault(libxl__gc *gc, - libxl_domain_build_info *b_info); +int libxl__arch_domain_build_info_setdefault(libxl__gc *gc, + libxl_domain_build_info *b_info, + const libxl_physinfo *physinfo); _hidden int libxl__arch_passthrough_mode_setdefault(libxl__gc *gc, diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c index 39fdca1b49..ba5b8f433f 100644 --- a/tools/libs/light/libxl_arm.c +++ b/tools/libs/light/libxl_arm.c @@ -1384,8 +1384,9 @@ void libxl__arch_domain_create_info_setdefault(libxl__gc *gc, } } -void libxl__arch_domain_build_info_setdefault(libxl__gc *gc, - libxl_domain_build_info *b_info) +int libxl__arch_domain_build_info_setdefault(libxl__gc *gc, + libxl_domain_build_info *b_info, + const libxl_physinfo *physinfo) { /* ACPI is disabled by default */ libxl_defbool_setdefault(&b_info->acpi, false); @@ -1399,6 +1400,8 @@ void libxl__arch_domain_build_info_setdefault(libxl__gc *gc, memset(&b_info->u, '\0', sizeof(b_info->u)); b_info->type = LIBXL_DOMAIN_TYPE_INVALID; libxl_domain_build_info_init_type(b_info, LIBXL_DOMAIN_TYPE_PVH); + + return 0; } int libxl__arch_passthrough_mode_setdefault(libxl__gc *gc, diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_create.c index 15ed021f41..88d08d7277 100644 --- a/tools/libs/light/libxl_create.c +++ b/tools/libs/light/libxl_create.c @@ -75,6 +75,7 @@ int libxl__domain_build_info_setdefault(libxl__gc *gc, libxl_domain_build_info *b_info) { int i, rc; + libxl_physinfo info; if (b_info->type != LIBXL_DOMAIN_TYPE_HVM && b_info->type != LIBXL_DOMAIN_TYPE_PV && @@ -264,7 +265,18 @@ int libxl__domain_build_info_setdefault(libxl__gc *gc, if (!b_info->event_channels) b_info->event_channels = 1023; - libxl__arch_domain_build_info_setdefault(gc, b_info); + rc = libxl_get_physinfo(CTX, &info); + if (rc) { + LOG(ERROR, "failed to get hypervisor info"); + return rc; + } + + rc = libxl__arch_domain_build_info_setdefault(gc, b_info, &info); + if (rc) { + LOG(ERROR, "unable to set domain arch build info defaults"); + return rc; + } + libxl_defbool_setdefault(&b_info->dm_restrict, false); if (b_info->iommu_memkb == LIBXL_MEMKB_DEFAULT) @@ -457,14 +469,6 @@ int libxl__domain_build_info_setdefault(libxl__gc *gc, } if (b_info->max_grant_version == LIBXL_MAX_GRANT_DEFAULT) { - libxl_physinfo info; - - rc = libxl_get_physinfo(CTX, &info); - if (rc) { - LOG(ERROR, "failed to get hypervisor info"); - return rc; - } - if (info.cap_gnttab_v2) b_info->max_grant_version = 2; else if (info.cap_gnttab_v1) diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl index 42ac6c357b..db5eb0a0b3 100644 --- a/tools/libs/light/libxl_types.idl +++ b/tools/libs/light/libxl_types.idl @@ -648,6 +648,8 @@ libxl_domain_build_info = Struct("domain_build_info",[ ("vuart", libxl_vuart_type), ])), ("arch_x86", Struct(None, [("msr_relaxed", libxl_defbool), + ("assisted_xapic", libxl_defbool), + ("assisted_x2apic", libxl_defbool), ])), # Alternate p2m is not bound to any architecture or guest type, as it is # supported by x86 HVM and ARM support is planned. diff --git a/tools/libs/light/libxl_x86.c b/tools/libs/light/libxl_x86.c index e0a06ecfe3..c377d13b19 100644 --- a/tools/libs/light/libxl_x86.c +++ b/tools/libs/light/libxl_x86.c @@ -23,6 +23,14 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, if (libxl_defbool_val(d_config->b_info.arch_x86.msr_relaxed)) config->arch.misc_flags |= XEN_X86_MSR_RELAXED; + if (d_config->c_info.type != LIBXL_DOMAIN_TYPE_PV) + { + if (libxl_defbool_val(d_config->b_info.arch_x86.assisted_xapic)) + config->arch.misc_flags |= XEN_X86_ASSISTED_XAPIC; + + if (libxl_defbool_val(d_config->b_info.arch_x86.assisted_x2apic)) + config->arch.misc_flags |= XEN_X86_ASSISTED_X2APIC; + } return 0; } @@ -819,11 +827,27 @@ void libxl__arch_domain_create_info_setdefault(libxl__gc *gc, { } -void libxl__arch_domain_build_info_setdefault(libxl__gc *gc, - libxl_domain_build_info *b_info) +int libxl__arch_domain_build_info_setdefault(libxl__gc *gc, + libxl_domain_build_info *b_info, + const libxl_physinfo *physinfo) { libxl_defbool_setdefault(&b_info->acpi, true); libxl_defbool_setdefault(&b_info->arch_x86.msr_relaxed, false); + + if (b_info->type != LIBXL_DOMAIN_TYPE_PV) { + libxl_defbool_setdefault(&b_info->arch_x86.assisted_xapic, + physinfo->cap_assisted_xapic); + libxl_defbool_setdefault(&b_info->arch_x86.assisted_x2apic, + physinfo->cap_assisted_x2apic); + } + + else if (!libxl_defbool_is_default(b_info->arch_x86.assisted_xapic) || + !libxl_defbool_is_default(b_info->arch_x86.assisted_x2apic)) { + LOG(ERROR, "Interrupt Controller Virtualization not supported for PV"); + return ERROR_INVAL; + } + + return 0; } int libxl__arch_passthrough_mode_setdefault(libxl__gc *gc, diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.ml index 21783d3622..672a11ceb6 100644 --- a/tools/ocaml/libs/xc/xenctrl.ml +++ b/tools/ocaml/libs/xc/xenctrl.ml @@ -50,6 +50,8 @@ type x86_arch_emulation_flags = type x86_arch_misc_flags = | X86_MSR_RELAXED + | X86_ASSISTED_XAPIC + | X86_ASSISTED_X2APIC type xen_x86_arch_domainconfig = { diff --git a/tools/ocaml/libs/xc/xenctrl.mli b/tools/ocaml/libs/xc/xenctrl.mli index af6ba3d1a0..f9a6aa3a0f 100644 --- a/tools/ocaml/libs/xc/xenctrl.mli +++ b/tools/ocaml/libs/xc/xenctrl.mli @@ -44,6 +44,8 @@ type x86_arch_emulation_flags = type x86_arch_misc_flags = | X86_MSR_RELAXED + | X86_ASSISTED_XAPIC + | X86_ASSISTED_X2APIC type xen_x86_arch_domainconfig = { emulation_flags: x86_arch_emulation_flags list; diff --git a/tools/ocaml/libs/xc/xenctrl_stubs.c b/tools/ocaml/libs/xc/xenctrl_stubs.c index e0d49b18d2..ecfc7125d5 100644 --- a/tools/ocaml/libs/xc/xenctrl_stubs.c +++ b/tools/ocaml/libs/xc/xenctrl_stubs.c @@ -239,7 +239,7 @@ CAMLprim value stub_xc_domain_create(value xch, value wanted_domid, value config cfg.arch.misc_flags = ocaml_list_to_c_bitmap /* ! x86_arch_misc_flags X86_ none */ - /* ! XEN_X86_ XEN_X86_MSR_RELAXED all */ + /* ! XEN_X86_ XEN_X86_ASSISTED_X2APIC max */ (VAL_MISC_FLAGS); #undef VAL_MISC_FLAGS diff --git a/tools/xl/xl.c b/tools/xl/xl.c index 2d1ec18ea3..31eb223309 100644 --- a/tools/xl/xl.c +++ b/tools/xl/xl.c @@ -57,6 +57,8 @@ int max_grant_frames = -1; int max_maptrack_frames = -1; int max_grant_version = LIBXL_MAX_GRANT_DEFAULT; libxl_domid domid_policy = INVALID_DOMID; +int assisted_xapic = -1; +int assisted_x2apic = -1; xentoollog_level minmsglevel = minmsglevel_default; @@ -201,6 +203,12 @@ static void parse_global_config(const char *configfile, if (!xlu_cfg_get_long (config, "claim_mode", &l, 0)) claim_mode = l; + if (!xlu_cfg_get_long (config, "assisted_xapic", &l, 0)) + assisted_xapic = l; + + if (!xlu_cfg_get_long (config, "assisted_x2apic", &l, 0)) + assisted_x2apic = l; + xlu_cfg_replace_string (config, "remus.default.netbufscript", &default_remus_netbufscript, 0); xlu_cfg_replace_string (config, "colo.default.proxyscript", diff --git a/tools/xl/xl.h b/tools/xl/xl.h index c5c4bedbdd..528deb3feb 100644 --- a/tools/xl/xl.h +++ b/tools/xl/xl.h @@ -286,6 +286,8 @@ extern libxl_bitmap global_vm_affinity_mask; extern libxl_bitmap global_hvm_affinity_mask; extern libxl_bitmap global_pv_affinity_mask; extern libxl_domid domid_policy; +extern int assisted_xapic; +extern int assisted_x2apic; enum output_format { OUTPUT_FORMAT_JSON, diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c index 117fcdcb2b..0ab9b145fe 100644 --- a/tools/xl/xl_parse.c +++ b/tools/xl/xl_parse.c @@ -1681,6 +1681,22 @@ void parse_config_data(const char *config_source, xlu_cfg_get_defbool(config, "vpt_align", &b_info->u.hvm.vpt_align, 0); xlu_cfg_get_defbool(config, "apic", &b_info->apic, 0); + e = xlu_cfg_get_long(config, "assisted_xapic", &l , 0); + if ((e == ESRCH && assisted_xapic != -1)) /* use global default if present */ + libxl_defbool_set(&b_info->arch_x86.assisted_xapic, assisted_xapic); + else if (!e) + libxl_defbool_set(&b_info->arch_x86.assisted_xapic, l); + else + exit(1); + + e = xlu_cfg_get_long(config, "assisted_x2apic", &l, 0); + if ((e == ESRCH && assisted_x2apic != -1)) /* use global default if present */ + libxl_defbool_set(&b_info->arch_x86.assisted_x2apic, assisted_x2apic); + else if (!e) + libxl_defbool_set(&b_info->arch_x86.assisted_x2apic, l); + else + exit(1); + switch (xlu_cfg_get_list(config, "viridian", &viridian, &num_viridian, 1)) { diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c index a5048ed654..bcca0dc900 100644 --- a/xen/arch/x86/domain.c +++ b/xen/arch/x86/domain.c @@ -619,6 +619,8 @@ int arch_sanitise_domain_config(struct xen_domctl_createdomain *config) bool hvm = config->flags & XEN_DOMCTL_CDF_hvm; bool hap = config->flags & XEN_DOMCTL_CDF_hap; bool nested_virt = config->flags & XEN_DOMCTL_CDF_nested_virt; + bool assisted_xapic = config->arch.misc_flags & XEN_X86_ASSISTED_XAPIC; + bool assisted_x2apic = config->arch.misc_flags & XEN_X86_ASSISTED_X2APIC; unsigned int max_vcpus; if ( hvm ? !hvm_enabled : !IS_ENABLED(CONFIG_PV) ) @@ -685,13 +687,31 @@ int arch_sanitise_domain_config(struct xen_domctl_createdomain *config) } } - if ( config->arch.misc_flags & ~XEN_X86_MSR_RELAXED ) + if ( config->arch.misc_flags & ~(XEN_X86_MSR_RELAXED | + XEN_X86_ASSISTED_XAPIC | + XEN_X86_ASSISTED_X2APIC) ) { dprintk(XENLOG_INFO, "Invalid arch misc flags %#x\n", config->arch.misc_flags); return -EINVAL; } + if ( (assisted_xapic || assisted_x2apic) && !hvm ) + { + dprintk(XENLOG_INFO, + "Interrupt Controller Virtualization not supported for PV\n"); + return -EINVAL; + } + + if ( (assisted_xapic && !assisted_xapic_available) || + (assisted_x2apic && !assisted_x2apic_available) ) + { + dprintk(XENLOG_INFO, + "Hardware assisted x%sAPIC requested but not available\n", + assisted_xapic && !assisted_xapic_available ? "" : "2"); + return -EINVAL; + } + return 0; } @@ -864,6 +884,12 @@ int arch_domain_create(struct domain *d, d->arch.msr_relaxed = config->arch.misc_flags & XEN_X86_MSR_RELAXED; + d->arch.hvm.assisted_xapic = + config->arch.misc_flags & XEN_X86_ASSISTED_XAPIC; + + d->arch.hvm.assisted_x2apic = + config->arch.misc_flags & XEN_X86_ASSISTED_X2APIC; + return 0; fail: diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c index 6f1fec49b9..e8cb7792dc 100644 --- a/xen/arch/x86/hvm/vmx/vmcs.c +++ b/xen/arch/x86/hvm/vmx/vmcs.c @@ -1158,6 +1158,10 @@ static int construct_vmcs(struct vcpu *v) __vmwrite(PLE_WINDOW, ple_window); } + if ( !has_assisted_xapic(v->domain) ) + v->arch.hvm.vmx.secondary_exec_control &= + ~SECONDARY_EXEC_VIRTUALIZE_APIC_ACCESSES; + if ( cpu_has_vmx_secondary_exec_control ) __vmwrite(SECONDARY_VM_EXEC_CONTROL, v->arch.hvm.vmx.secondary_exec_control); diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c index c075370f64..73c7ae1e84 100644 --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -3344,16 +3344,11 @@ static void vmx_install_vlapic_mapping(struct vcpu *v) void vmx_vlapic_msr_changed(struct vcpu *v) { - int virtualize_x2apic_mode; struct vlapic *vlapic = vcpu_vlapic(v); unsigned int msr; - virtualize_x2apic_mode = ( (cpu_has_vmx_apic_reg_virt || - cpu_has_vmx_virtual_intr_delivery) && - cpu_has_vmx_virtualize_x2apic_mode ); - - if ( !cpu_has_vmx_virtualize_apic_accesses && - !virtualize_x2apic_mode ) + if ( !has_assisted_xapic(v->domain) && + !has_assisted_x2apic(v->domain) ) return; vmx_vmcs_enter(v); @@ -3363,28 +3358,24 @@ void vmx_vlapic_msr_changed(struct vcpu *v) if ( !vlapic_hw_disabled(vlapic) && (vlapic_base_address(vlapic) == APIC_DEFAULT_PHYS_BASE) ) { - if ( virtualize_x2apic_mode && vlapic_x2apic_mode(vlapic) ) + if ( has_assisted_x2apic(v->domain) && vlapic_x2apic_mode(vlapic) ) { v->arch.hvm.vmx.secondary_exec_control |= SECONDARY_EXEC_VIRTUALIZE_X2APIC_MODE; - if ( cpu_has_vmx_apic_reg_virt ) - { - for ( msr = MSR_X2APIC_FIRST; - msr <= MSR_X2APIC_FIRST + 0xff; msr++ ) - vmx_clear_msr_intercept(v, msr, VMX_MSR_R); - vmx_set_msr_intercept(v, MSR_X2APIC_PPR, VMX_MSR_R); - vmx_set_msr_intercept(v, MSR_X2APIC_TMICT, VMX_MSR_R); - vmx_set_msr_intercept(v, MSR_X2APIC_TMCCT, VMX_MSR_R); - } - if ( cpu_has_vmx_virtual_intr_delivery ) - { - vmx_clear_msr_intercept(v, MSR_X2APIC_TPR, VMX_MSR_W); - vmx_clear_msr_intercept(v, MSR_X2APIC_EOI, VMX_MSR_W); - vmx_clear_msr_intercept(v, MSR_X2APIC_SELF, VMX_MSR_W); - } + for ( msr = MSR_X2APIC_FIRST; + msr <= MSR_X2APIC_FIRST + 0xff; msr++ ) + vmx_clear_msr_intercept(v, msr, VMX_MSR_R); + + vmx_set_msr_intercept(v, MSR_X2APIC_PPR, VMX_MSR_R); + vmx_set_msr_intercept(v, MSR_X2APIC_TMICT, VMX_MSR_R); + vmx_set_msr_intercept(v, MSR_X2APIC_TMCCT, VMX_MSR_R); + + vmx_clear_msr_intercept(v, MSR_X2APIC_TPR, VMX_MSR_W); + vmx_clear_msr_intercept(v, MSR_X2APIC_EOI, VMX_MSR_W); + vmx_clear_msr_intercept(v, MSR_X2APIC_SELF, VMX_MSR_W); } - else + else if ( has_assisted_xapic(v->domain) ) v->arch.hvm.vmx.secondary_exec_control |= SECONDARY_EXEC_VIRTUALIZE_APIC_ACCESSES; } diff --git a/xen/arch/x86/include/asm/hvm/domain.h b/xen/arch/x86/include/asm/hvm/domain.h index 698455444e..92bf53483c 100644 --- a/xen/arch/x86/include/asm/hvm/domain.h +++ b/xen/arch/x86/include/asm/hvm/domain.h @@ -117,6 +117,12 @@ struct hvm_domain { bool is_s3_suspended; + /* xAPIC hardware assisted virtualization. */ + bool assisted_xapic; + + /* x2APIC hardware assisted virtualization. */ + bool assisted_x2apic; + /* hypervisor intercepted msix table */ struct list_head msixtbl_list; diff --git a/xen/arch/x86/include/asm/hvm/vmx/vmcs.h b/xen/arch/x86/include/asm/hvm/vmx/vmcs.h index 9119aa8536..5b7d662ed7 100644 --- a/xen/arch/x86/include/asm/hvm/vmx/vmcs.h +++ b/xen/arch/x86/include/asm/hvm/vmx/vmcs.h @@ -220,6 +220,9 @@ void vmx_vmcs_reload(struct vcpu *v); #define CPU_BASED_ACTIVATE_SECONDARY_CONTROLS 0x80000000 extern u32 vmx_cpu_based_exec_control; +#define has_assisted_xapic(d) ((d)->arch.hvm.assisted_xapic) +#define has_assisted_x2apic(d) ((d)->arch.hvm.assisted_x2apic) + #define PIN_BASED_EXT_INTR_MASK 0x00000001 #define PIN_BASED_NMI_EXITING 0x00000008 #define PIN_BASED_VIRTUAL_NMIS 0x00000020 diff --git a/xen/arch/x86/traps.c b/xen/arch/x86/traps.c index a2278d9499..577c1a3b21 100644 --- a/xen/arch/x86/traps.c +++ b/xen/arch/x86/traps.c @@ -1121,7 +1121,7 @@ void cpuid_hypervisor_leaves(const struct vcpu *v, uint32_t leaf, if ( !is_hvm_domain(d) || subleaf != 0 ) break; - if ( cpu_has_vmx_apic_reg_virt ) + if ( has_assisted_xapic(d) ) res->a |= XEN_HVM_CPUID_APIC_ACCESS_VIRT; /* @@ -1130,9 +1130,7 @@ void cpuid_hypervisor_leaves(const struct vcpu *v, uint32_t leaf, * and wrmsr in the guest will run without VMEXITs (see * vmx_vlapic_msr_changed()). */ - if ( cpu_has_vmx_virtualize_x2apic_mode && - cpu_has_vmx_apic_reg_virt && - cpu_has_vmx_virtual_intr_delivery ) + if ( has_assisted_x2apic(d) ) res->a |= XEN_HVM_CPUID_X2APIC_VIRT; /* diff --git a/xen/include/public/arch-x86/xen.h b/xen/include/public/arch-x86/xen.h index 7acd94c8eb..9da32c6239 100644 --- a/xen/include/public/arch-x86/xen.h +++ b/xen/include/public/arch-x86/xen.h @@ -317,6 +317,8 @@ struct xen_arch_domainconfig { * doesn't allow the guest to read or write to the underlying MSR. */ #define XEN_X86_MSR_RELAXED (1u << 0) +#define XEN_X86_ASSISTED_XAPIC (1u << 1) +#define XEN_X86_ASSISTED_X2APIC (1u << 2) uint32_t misc_flags; }; -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Wed Mar 02 15:01:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 15:01:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282331.481005 (Exim 4.92) (envelope-from ) id 1nPQU3-0000ek-RT; Wed, 02 Mar 2022 15:01:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282331.481005; Wed, 02 Mar 2022 15:01:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPQU3-0000dW-M1; Wed, 02 Mar 2022 15:01:43 +0000 Received: by outflank-mailman (input) for mailman id 282331; Wed, 02 Mar 2022 15:01:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPQU2-0000as-O5 for xen-devel@lists.xenproject.org; Wed, 02 Mar 2022 15:01:42 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a9f09c2e-9a39-11ec-8539-5f4723681683; Wed, 02 Mar 2022 16:01:41 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a9f09c2e-9a39-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1646233301; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=eOsDeAg0hCgIMJz4xzrvECZpxvwHo6VnrvDHVT6JGB0=; b=cQrN0+hZicbHzG+/8IrlD49Ib60Y21ToyuGL5fcwgGdHGX8DB3xVQFuf JCgsic26KaP90BySVPZaRUwHE3zGOAErkwZ760KEvHFQf8O7TrkSN2h0V R92LveXeXSG/BQWN2z2yYCpmDsuguIreASqUL0VotxZ6f7HydDyaQ6E3p A=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 64766525 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:vwMIyq5MPwgW0n+I3Kz9NgxRtKDHchMFZxGqfqrLsTDasY5as4F+v jFNDWyDbv3famCnKIx1a9uw8B4DvpPQy4QwHFBprXxmHi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0XqPp8Zj2tQy2YPhWVvW0 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx umhurSLaCE2MqySmd0RUkhfSiokJupr073+dC3XXcy7lyUqclPpyvRqSko3IZcZ6qB8BmQmG f4wcW5XKErZ3qTvnez9GrIEascLdaEHOKs9s3dtixTQCf8iSJbOa67L+cVZzHE7gcUm8fP2O ZZGN2QyNkmojxtnOVAGUJkMuOiUpV7UTRd+s2yzi5gx7D2GpOB2+Oe0a4eEEjCQfu1rmUKfq nPD7n7OKBgQP9yCyhKI6nupwOTImEvTQ5kOHbe18vprhly7xWEJDhASE1yhrpGRgEOkR8hWL UBS/yM0tLUz72SiVNy7VBq9yFaHswAdXZxMEuQ8wACL1qfQpQ2eAwAsTCNHLtovt8Y0RDkj/ l6Pg97tQzdotdW9S32H8ayPhSivIiVTJmgHDQcUQA1A79T9rYUbihPUUs0lAKOzlsfyGzz73 3aNtidWr7cZgNMP1q671UvamD/qrZ/MJiY3+wHWU2SN/g5/Iom/aOSA9lzz/ftGaoGDQTG8U GMswpbEqrpUVNfUyXLLEL5l8KyVC+itCxz6nlJuQZgY+zX8/CeoJ5sXzRp8HRI8WiobQgPBb EjWsAJXwZZcOnq2cKN6C76M59QWIbvIToq8CK2NBjZaSt0oLVLconkyDaKF9z21yCARfbcD1 YB3mCpGJVITEuxZwTW/XI/xOpd7l3lllQs/qX0WpilLMIZyhlbIEd/p03PUN4jVCZ9oRi2Pq b6z0OPQln1ivBXWOHW/zGLqBQliwYIHLZ73sddLUeWIPxBrHmosY9eIn+9/ItI9x/ULz7aSl p1YZqO+4ACl7ZEgAV/XAk2PlZu1BcovxZ7FFXZE0amUN4gLPt/0sfZ3m2ofdrg77u1zpcOYv NFeE/hs9s9nE2ydkxxENMGVhNU7KHyD2FLfVwL4MWNXV8MxGGT0FirMI1KHGN8mVXHs66PTY tSIi2vmfHb0b186XZaONan2lAvZULp0sLsaYnYk6+J7IC3EmLWG4QSu5hPrC6ng8Sn++wY= IronPort-HdrOrdr: A9a23:k3GAkq7iR7zinbCWsgPXwPDXdLJyesId70hD6qhwISY6TiX+rb HWoB17726TtN9/YhEdcLy7VJVoBEmskKKdgrNhWotKPjOW21dARbsKheCJrgEIWReOktK1vZ 0QC5SWY+eQMbEVt6nHCXGDYrQd/OU= X-IronPort-AV: E=Sophos;i="5.90,149,1643691600"; d="scan'208";a="64766525" From: Jane Malalane To: Xen-devel CC: Jane Malalane , Wei Liu , "Anthony PERARD" , Juergen Gross , "Andrew Cooper" , George Dunlap , Jan Beulich , Julien Grall , "Stefano Stabellini" , Volodymyr Babchuk , Bertrand Marquis , Jun Nakajima , Kevin Tian , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH v4 1/2] xen+tools: Report Interrupt Controller Virtualization capabilities on x86 Date: Wed, 2 Mar 2022 15:00:55 +0000 Message-ID: <20220302150056.14381-2-jane.malalane@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20220302150056.14381-1-jane.malalane@citrix.com> References: <20220302150056.14381-1-jane.malalane@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Add XEN_SYSCTL_PHYSCAP_ARCH_ASSISTED_xapic and XEN_SYSCTL_PHYSCAP_ARCH_ASSISTED_x2apic to report accelerated xapic and x2apic, on x86 hardware. No such features are currently implemented on AMD hardware. For that purpose, also add an arch-specific "capabilities" parameter to struct xen_sysctl_physinfo. Note that this interface is intended to be compatible with AMD so that AVIC support can be introduced in a future patch. Unlike Intel that has multiple controls for APIC Virtualization, AMD has one global 'AVIC Enable' control bit, so fine-graining of APIC virtualization control cannot be done on a common interface. Therefore, for xAPIC HW assisted virtualization support to be reported, HW must support virtualize_apic_accesses as well as apic_reg_virt. For x2APIC HW assisted virtualization reporting, virtualize_x2apic_mode must be supported alongside apic_reg_virt and virtual_intr_delivery. Suggested-by: Andrew Cooper Signed-off-by: Jane Malalane --- CC: Wei Liu CC: Anthony PERARD CC: Juergen Gross CC: Andrew Cooper CC: George Dunlap CC: Jan Beulich CC: Julien Grall CC: Stefano Stabellini CC: Volodymyr Babchuk CC: Bertrand Marquis CC: Jun Nakajima CC: Kevin Tian CC: "Roger Pau Monné" v4: * Fallback to the original v2/v1 conditions for setting assisted_xapic_available and assisted_x2apic_available so that in the future APIC virtualization can be exposed on AMD hardware since fine-graining of "AVIC" is not supported, i.e., AMD solely uses "AVIC Enable". This also means that sysctl mimics what's exposed in CPUID. v3: * Define XEN_SYSCTL_PHYSCAP_ARCH_MAX for ABI checking and actually set "arch_capbilities", via a call to c_bitmap_to_ocaml_list() * Have assisted_x2apic_available only depend on cpu_has_vmx_virtualize_x2apic_mode v2: * Use one macro LIBXL_HAVE_PHYSINFO_ASSISTED_APIC instead of two * Pass xcpyshinfo as a pointer in libxl__arch_get_physinfo * Set assisted_x{2}apic_available to be conditional upon "bsp" and annotate it with __ro_after_init * Change XEN_SYSCTL_PHYSCAP_ARCH_ASSISTED_X{2}APIC to _X86_ASSISTED_X{2}APIC * Keep XEN_SYSCTL_PHYSCAP_X86_ASSISTED_X{2}APIC contained within sysctl.h * Fix padding introduced in struct xen_sysctl_physinfo and bump XEN_SYSCTL_INTERFACE_VERSION --- tools/golang/xenlight/helpers.gen.go | 4 ++++ tools/golang/xenlight/types.gen.go | 2 ++ tools/include/libxl.h | 7 +++++++ tools/libs/light/libxl.c | 3 +++ tools/libs/light/libxl_arch.h | 4 ++++ tools/libs/light/libxl_arm.c | 5 +++++ tools/libs/light/libxl_types.idl | 2 ++ tools/libs/light/libxl_x86.c | 11 +++++++++++ tools/ocaml/libs/xc/xenctrl.ml | 5 +++++ tools/ocaml/libs/xc/xenctrl.mli | 5 +++++ tools/ocaml/libs/xc/xenctrl_stubs.c | 14 +++++++++++--- tools/xl/xl_info.c | 6 ++++-- xen/arch/x86/hvm/vmx/vmcs.c | 10 ++++++++++ xen/arch/x86/include/asm/domain.h | 3 +++ xen/arch/x86/sysctl.c | 7 +++++++ xen/include/public/sysctl.h | 11 ++++++++++- 16 files changed, 93 insertions(+), 6 deletions(-) diff --git a/tools/golang/xenlight/helpers.gen.go b/tools/golang/xenlight/helpers.gen.go index b746ff1081..dd4e6c9f14 100644 --- a/tools/golang/xenlight/helpers.gen.go +++ b/tools/golang/xenlight/helpers.gen.go @@ -3373,6 +3373,8 @@ x.CapVmtrace = bool(xc.cap_vmtrace) x.CapVpmu = bool(xc.cap_vpmu) x.CapGnttabV1 = bool(xc.cap_gnttab_v1) x.CapGnttabV2 = bool(xc.cap_gnttab_v2) +x.CapAssistedXapic = bool(xc.cap_assisted_xapic) +x.CapAssistedX2Apic = bool(xc.cap_assisted_x2apic) return nil} @@ -3407,6 +3409,8 @@ xc.cap_vmtrace = C.bool(x.CapVmtrace) xc.cap_vpmu = C.bool(x.CapVpmu) xc.cap_gnttab_v1 = C.bool(x.CapGnttabV1) xc.cap_gnttab_v2 = C.bool(x.CapGnttabV2) +xc.cap_assisted_xapic = C.bool(x.CapAssistedXapic) +xc.cap_assisted_x2apic = C.bool(x.CapAssistedX2Apic) return nil } diff --git a/tools/golang/xenlight/types.gen.go b/tools/golang/xenlight/types.gen.go index b1e84d5258..87be46c745 100644 --- a/tools/golang/xenlight/types.gen.go +++ b/tools/golang/xenlight/types.gen.go @@ -1014,6 +1014,8 @@ CapVmtrace bool CapVpmu bool CapGnttabV1 bool CapGnttabV2 bool +CapAssistedXapic bool +CapAssistedX2Apic bool } type Connectorinfo struct { diff --git a/tools/include/libxl.h b/tools/include/libxl.h index 51a9b6cfac..94e6355822 100644 --- a/tools/include/libxl.h +++ b/tools/include/libxl.h @@ -528,6 +528,13 @@ #define LIBXL_HAVE_MAX_GRANT_VERSION 1 /* + * LIBXL_HAVE_PHYSINFO_ASSISTED_APIC indicates that libxl_physinfo has + * cap_assisted_xapic and cap_assisted_x2apic fields, which indicates + * the availability of x{2}APIC hardware assisted virtualization. + */ +#define LIBXL_HAVE_PHYSINFO_ASSISTED_APIC 1 + +/* * libxl ABI compatibility * * The only guarantee which libxl makes regarding ABI compatibility diff --git a/tools/libs/light/libxl.c b/tools/libs/light/libxl.c index a0bf7d186f..6d699951e2 100644 --- a/tools/libs/light/libxl.c +++ b/tools/libs/light/libxl.c @@ -15,6 +15,7 @@ #include "libxl_osdeps.h" #include "libxl_internal.h" +#include "libxl_arch.h" int libxl_ctx_alloc(libxl_ctx **pctx, int version, unsigned flags, xentoollog_logger * lg) @@ -410,6 +411,8 @@ int libxl_get_physinfo(libxl_ctx *ctx, libxl_physinfo *physinfo) physinfo->cap_gnttab_v2 = !!(xcphysinfo.capabilities & XEN_SYSCTL_PHYSCAP_gnttab_v2); + libxl__arch_get_physinfo(physinfo, &xcphysinfo); + GC_FREE; return 0; } diff --git a/tools/libs/light/libxl_arch.h b/tools/libs/light/libxl_arch.h index 1522ecb97f..207ceac6a1 100644 --- a/tools/libs/light/libxl_arch.h +++ b/tools/libs/light/libxl_arch.h @@ -86,6 +86,10 @@ int libxl__arch_extra_memory(libxl__gc *gc, uint64_t *out); _hidden +void libxl__arch_get_physinfo(libxl_physinfo *physinfo, + const xc_physinfo_t *xcphysinfo); + +_hidden void libxl__arch_update_domain_config(libxl__gc *gc, libxl_domain_config *dst, const libxl_domain_config *src); diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c index eef1de0939..39fdca1b49 100644 --- a/tools/libs/light/libxl_arm.c +++ b/tools/libs/light/libxl_arm.c @@ -1431,6 +1431,11 @@ int libxl__arch_passthrough_mode_setdefault(libxl__gc *gc, return rc; } +void libxl__arch_get_physinfo(libxl_physinfo *physinfo, + const xc_physinfo_t *xcphysinfo) +{ +} + void libxl__arch_update_domain_config(libxl__gc *gc, libxl_domain_config *dst, const libxl_domain_config *src) diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl index 2a42da2f7d..42ac6c357b 100644 --- a/tools/libs/light/libxl_types.idl +++ b/tools/libs/light/libxl_types.idl @@ -1068,6 +1068,8 @@ libxl_physinfo = Struct("physinfo", [ ("cap_vpmu", bool), ("cap_gnttab_v1", bool), ("cap_gnttab_v2", bool), + ("cap_assisted_xapic", bool), + ("cap_assisted_x2apic", bool), ], dir=DIR_OUT) libxl_connectorinfo = Struct("connectorinfo", [ diff --git a/tools/libs/light/libxl_x86.c b/tools/libs/light/libxl_x86.c index 1feadebb18..e0a06ecfe3 100644 --- a/tools/libs/light/libxl_x86.c +++ b/tools/libs/light/libxl_x86.c @@ -866,6 +866,17 @@ int libxl__arch_passthrough_mode_setdefault(libxl__gc *gc, return rc; } +void libxl__arch_get_physinfo(libxl_physinfo *physinfo, + const xc_physinfo_t *xcphysinfo) +{ + physinfo->cap_assisted_xapic = + !!(xcphysinfo->arch_capabilities & + XEN_SYSCTL_PHYSCAP_X86_ASSISTED_XAPIC); + physinfo->cap_assisted_x2apic = + !!(xcphysinfo->arch_capabilities & + XEN_SYSCTL_PHYSCAP_X86_ASSISTED_X2APIC); +} + void libxl__arch_update_domain_config(libxl__gc *gc, libxl_domain_config *dst, const libxl_domain_config *src) diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.ml index 7503031d8f..21783d3622 100644 --- a/tools/ocaml/libs/xc/xenctrl.ml +++ b/tools/ocaml/libs/xc/xenctrl.ml @@ -127,6 +127,10 @@ type physinfo_cap_flag = | CAP_Gnttab_v1 | CAP_Gnttab_v2 +type physinfo_arch_cap_flag = + | CAP_X86_ASSISTED_XAPIC + | CAP_X86_ASSISTED_X2APIC + type physinfo = { threads_per_core : int; @@ -139,6 +143,7 @@ type physinfo = scrub_pages : nativeint; (* XXX hw_cap *) capabilities : physinfo_cap_flag list; + arch_capabilities : physinfo_arch_cap_flag list; max_nr_cpus : int; } diff --git a/tools/ocaml/libs/xc/xenctrl.mli b/tools/ocaml/libs/xc/xenctrl.mli index d1d9c9247a..af6ba3d1a0 100644 --- a/tools/ocaml/libs/xc/xenctrl.mli +++ b/tools/ocaml/libs/xc/xenctrl.mli @@ -112,6 +112,10 @@ type physinfo_cap_flag = | CAP_Gnttab_v1 | CAP_Gnttab_v2 +type physinfo_arch_cap_flag = + | CAP_X86_ASSISTED_XAPIC + | CAP_X86_ASSISTED_X2APIC + type physinfo = { threads_per_core : int; cores_per_socket : int; @@ -122,6 +126,7 @@ type physinfo = { free_pages : nativeint; scrub_pages : nativeint; capabilities : physinfo_cap_flag list; + arch_capabilities : physinfo_arch_cap_flag list; max_nr_cpus : int; (** compile-time max possible number of nr_cpus *) } type version = { major : int; minor : int; extra : string; } diff --git a/tools/ocaml/libs/xc/xenctrl_stubs.c b/tools/ocaml/libs/xc/xenctrl_stubs.c index 5b4fe72c8d..e0d49b18d2 100644 --- a/tools/ocaml/libs/xc/xenctrl_stubs.c +++ b/tools/ocaml/libs/xc/xenctrl_stubs.c @@ -712,7 +712,7 @@ CAMLprim value stub_xc_send_debug_keys(value xch, value keys) CAMLprim value stub_xc_physinfo(value xch) { CAMLparam1(xch); - CAMLlocal2(physinfo, cap_list); + CAMLlocal3(physinfo, cap_list, arch_cap_list); xc_physinfo_t c_physinfo; int r; @@ -730,8 +730,15 @@ CAMLprim value stub_xc_physinfo(value xch) /* ! physinfo_cap_flag CAP_ lc */ /* ! XEN_SYSCTL_PHYSCAP_ XEN_SYSCTL_PHYSCAP_MAX max */ (c_physinfo.capabilities); + /* + * arch_capabilities: physinfo_arch_cap_flag list; + */ + arch_cap_list = c_bitmap_to_ocaml_list + /* ! physinfo_arch_cap_flag CAP_ none */ + /* ! XEN_SYSCTL_PHYSCAP_ XEN_SYSCTL_PHYSCAP_X86_MAX max */ + (c_physinfo.arch_capabilities); - physinfo = caml_alloc_tuple(10); + physinfo = caml_alloc_tuple(11); Store_field(physinfo, 0, Val_int(c_physinfo.threads_per_core)); Store_field(physinfo, 1, Val_int(c_physinfo.cores_per_socket)); Store_field(physinfo, 2, Val_int(c_physinfo.nr_cpus)); @@ -741,7 +748,8 @@ CAMLprim value stub_xc_physinfo(value xch) Store_field(physinfo, 6, caml_copy_nativeint(c_physinfo.free_pages)); Store_field(physinfo, 7, caml_copy_nativeint(c_physinfo.scrub_pages)); Store_field(physinfo, 8, cap_list); - Store_field(physinfo, 9, Val_int(c_physinfo.max_cpu_id + 1)); + Store_field(physinfo, 9, arch_cap_list); + Store_field(physinfo, 10, Val_int(c_physinfo.max_cpu_id + 1)); CAMLreturn(physinfo); } diff --git a/tools/xl/xl_info.c b/tools/xl/xl_info.c index 712b7638b0..3205270754 100644 --- a/tools/xl/xl_info.c +++ b/tools/xl/xl_info.c @@ -210,7 +210,7 @@ static void output_physinfo(void) info.hw_cap[4], info.hw_cap[5], info.hw_cap[6], info.hw_cap[7] ); - maybe_printf("virt_caps :%s%s%s%s%s%s%s%s%s%s%s\n", + maybe_printf("virt_caps :%s%s%s%s%s%s%s%s%s%s%s%s%s\n", info.cap_pv ? " pv" : "", info.cap_hvm ? " hvm" : "", info.cap_hvm && info.cap_hvm_directio ? " hvm_directio" : "", @@ -221,7 +221,9 @@ static void output_physinfo(void) info.cap_vmtrace ? " vmtrace" : "", info.cap_vpmu ? " vpmu" : "", info.cap_gnttab_v1 ? " gnttab-v1" : "", - info.cap_gnttab_v2 ? " gnttab-v2" : "" + info.cap_gnttab_v2 ? " gnttab-v2" : "", + info.cap_assisted_xapic ? " assisted_xapic" : "", + info.cap_assisted_x2apic ? " assisted_x2apic" : "" ); vinfo = libxl_get_version_info(ctx); diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c index e1e1fa14e6..6f1fec49b9 100644 --- a/xen/arch/x86/hvm/vmx/vmcs.c +++ b/xen/arch/x86/hvm/vmx/vmcs.c @@ -343,6 +343,16 @@ static int vmx_init_vmcs_config(bool bsp) MSR_IA32_VMX_PROCBASED_CTLS2, &mismatch); } + /* Check whether hardware supports accelerated xapic and x2apic. */ + if ( bsp ) + { + assisted_xapic_available = (cpu_has_vmx_virtualize_apic_accesses && + cpu_has_vmx_apic_reg_virt); + assisted_x2apic_available = (cpu_has_vmx_virtualize_x2apic_mode && + cpu_has_vmx_apic_reg_virt && + cpu_has_vmx_virtual_intr_delivery); + } + /* The IA32_VMX_EPT_VPID_CAP MSR exists only when EPT or VPID available */ if ( _vmx_secondary_exec_control & (SECONDARY_EXEC_ENABLE_EPT | SECONDARY_EXEC_ENABLE_VPID) ) diff --git a/xen/arch/x86/include/asm/domain.h b/xen/arch/x86/include/asm/domain.h index e62e109598..72431df26d 100644 --- a/xen/arch/x86/include/asm/domain.h +++ b/xen/arch/x86/include/asm/domain.h @@ -756,6 +756,9 @@ static inline void pv_inject_sw_interrupt(unsigned int vector) : is_pv_32bit_domain(d) ? PV32_VM_ASSIST_MASK \ : PV64_VM_ASSIST_MASK) +extern bool assisted_xapic_available; +extern bool assisted_x2apic_available; + #endif /* __ASM_DOMAIN_H__ */ /* diff --git a/xen/arch/x86/sysctl.c b/xen/arch/x86/sysctl.c index f82abc2488..ad95c86aef 100644 --- a/xen/arch/x86/sysctl.c +++ b/xen/arch/x86/sysctl.c @@ -69,6 +69,9 @@ struct l3_cache_info { unsigned long size; }; +bool __ro_after_init assisted_xapic_available; +bool __ro_after_init assisted_x2apic_available; + static void cf_check l3_cache_get(void *arg) { struct cpuid4_info info; @@ -135,6 +138,10 @@ void arch_do_physinfo(struct xen_sysctl_physinfo *pi) pi->capabilities |= XEN_SYSCTL_PHYSCAP_hap; if ( IS_ENABLED(CONFIG_SHADOW_PAGING) ) pi->capabilities |= XEN_SYSCTL_PHYSCAP_shadow; + if ( assisted_xapic_available ) + pi->arch_capabilities |= XEN_SYSCTL_PHYSCAP_X86_ASSISTED_XAPIC; + if ( assisted_x2apic_available ) + pi->arch_capabilities |= XEN_SYSCTL_PHYSCAP_X86_ASSISTED_X2APIC; } long arch_do_sysctl( diff --git a/xen/include/public/sysctl.h b/xen/include/public/sysctl.h index 55252e97f2..7fe05be0c9 100644 --- a/xen/include/public/sysctl.h +++ b/xen/include/public/sysctl.h @@ -35,7 +35,7 @@ #include "domctl.h" #include "physdev.h" -#define XEN_SYSCTL_INTERFACE_VERSION 0x00000014 +#define XEN_SYSCTL_INTERFACE_VERSION 0x00000015 /* * Read console content from Xen buffer ring. @@ -111,6 +111,13 @@ struct xen_sysctl_tbuf_op { /* Max XEN_SYSCTL_PHYSCAP_* constant. Used for ABI checking. */ #define XEN_SYSCTL_PHYSCAP_MAX XEN_SYSCTL_PHYSCAP_gnttab_v2 +/* The platform supports x{2}apic hardware assisted emulation. */ +#define XEN_SYSCTL_PHYSCAP_X86_ASSISTED_XAPIC (1u << 0) +#define XEN_SYSCTL_PHYSCAP_X86_ASSISTED_X2APIC (1u << 1) + +/* Max XEN_SYSCTL_PHYSCAP_X86__* constant. Used for ABI checking. */ +#define XEN_SYSCTL_PHYSCAP_X86_MAX XEN_SYSCTL_PHYSCAP_X86_ASSISTED_X2APIC + struct xen_sysctl_physinfo { uint32_t threads_per_core; uint32_t cores_per_socket; @@ -120,6 +127,8 @@ struct xen_sysctl_physinfo { uint32_t max_node_id; /* Largest possible node ID on this host */ uint32_t cpu_khz; uint32_t capabilities;/* XEN_SYSCTL_PHYSCAP_??? */ + uint32_t arch_capabilities;/* XEN_SYSCTL_PHYSCAP_X86{ARM}_??? */ + uint32_t pad; uint64_aligned_t total_pages; uint64_aligned_t free_pages; uint64_aligned_t scrub_pages; -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Wed Mar 02 15:33:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 15:33:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282355.481033 (Exim 4.92) (envelope-from ) id 1nPQya-0005wc-UE; Wed, 02 Mar 2022 15:33:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282355.481033; Wed, 02 Mar 2022 15:33:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPQya-0005wV-RD; Wed, 02 Mar 2022 15:33:16 +0000 Received: by outflank-mailman (input) for mailman id 282355; Wed, 02 Mar 2022 15:33:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPQyX-0005wP-Qr for xen-devel@lists.xenproject.org; Wed, 02 Mar 2022 15:33:15 +0000 Received: from smtp-fw-2101.amazon.com (smtp-fw-2101.amazon.com [72.21.196.25]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 10bdcd0e-9a3e-11ec-8eba-a37418f5ba1a; Wed, 02 Mar 2022 16:33:11 +0100 (CET) Received: from iad12-co-svc-p1-lb1-vlan2.amazon.com (HELO email-inbound-relay-iad-1e-98691110.us-east-1.amazon.com) ([10.43.8.2]) by smtp-border-fw-2101.iad2.amazon.com with ESMTP; 02 Mar 2022 15:32:58 +0000 Received: from EX13D03EUC004.ant.amazon.com (iad12-ws-svc-p26-lb9-vlan3.iad.amazon.com [10.40.163.38]) by email-inbound-relay-iad-1e-98691110.us-east-1.amazon.com (Postfix) with ESMTPS id 12D2C852FD; Wed, 2 Mar 2022 15:32:56 +0000 (UTC) Received: from EX13D03EUC002.ant.amazon.com (10.43.164.60) by EX13D03EUC004.ant.amazon.com (10.43.164.33) with Microsoft SMTP Server (TLS) id 15.0.1497.28; Wed, 2 Mar 2022 15:32:56 +0000 Received: from EX13D03EUC002.ant.amazon.com ([10.43.164.60]) by EX13D03EUC002.ant.amazon.com ([10.43.164.60]) with mapi id 15.00.1497.028; Wed, 2 Mar 2022 15:32:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-Inumbo-ID: 10bdcd0e-9a3e-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.de; i=@amazon.de; q=dns/txt; s=amazon201209; t=1646235192; x=1677771192; h=from:to:cc:date:message-id:references:in-reply-to: content-id:mime-version:content-transfer-encoding:subject; bh=roP0bwPivzOGjJjDU7tKd3dkm1SoTU4LrZ3IvYjnY38=; b=heVug5jcnjX4VDHtg5+ScqSD+wSiKPWwvYOh4IaKtXSzEakwQCm9UD6u hgK+NlLqmElAbUlo7sDmhGSorRVb47Nc7K+lgqIHAhMtiGOn4xXm7s70B HNycSmZIFZt1Pdn1K+dRKdu6NkYjr3zScMv4lD6VGFC3m3uKVSFca4OQ2 Q=; X-IronPort-AV: E=Sophos;i="5.90,149,1643673600"; d="scan'208";a="177884295" Subject: Re: [PATCH 1/4] livepatch: update readme to mention --xen-depends Thread-Topic: [PATCH 1/4] livepatch: update readme to mention --xen-depends From: "Doebel, Bjoern" To: Roger Pau Monne , "xen-devel@lists.xenproject.org" CC: "ross.lagerwall@citrix.com" , "konrad.wilk@oracle.com" , "julien@xen.org" , "Andrew.Cooper3@citrix.com" Thread-Index: AQHYLkHpkyqw0otv8UqarS2xkvT+RKysSdKA Date: Wed, 2 Mar 2022 15:32:55 +0000 Message-ID: <1C97765C-3A3A-4FB5-9242-1F9DB3E9DDF6@amazon.com> References: <20220302142711.38953-1-roger.pau@citrix.com> <20220302142711.38953-2-roger.pau@citrix.com> In-Reply-To: <20220302142711.38953-2-roger.pau@citrix.com> Accept-Language: en-US, de-DE Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.43.164.30] Content-Type: text/plain; charset="utf-8" Content-ID: <2A601BFA200C02489496C652D79A876D@amazon.com> MIME-Version: 1.0 Precedence: Bulk Content-Transfer-Encoding: base64 ICAgIEZpeGVzOiBiMTlkZjdiMmMwNWUgKCdsaXZlcGF0Y2gtYnVpbGQ6IEVtYmVkIGh5cGVydmlz b3IgYnVpbGQgaWQgaW50byBldmVyeSBob3RwYXRjaCcpDQogICAgU2lnbmVkLW9mZi1ieTogUm9n ZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+DQogICAgLS0tDQogICAgIFJFQURN RS5tZCB8IDIgKy0NCiAgICAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0 aW9uKC0pDQoNCiAgICBkaWZmIC0tZ2l0IGEvUkVBRE1FLm1kIGIvUkVBRE1FLm1kDQogICAgaW5k ZXggNjUzYzYyNC4uYjQ4YTNkZiAxMDA2NDQNCiAgICAtLS0gYS9SRUFETUUubWQNCiAgICArKysg Yi9SRUFETUUubWQNCiAgICBAQCAtMjQsNyArMjQsNyBAQCBOZXh0LCBidWlsZCBhIGxpdmUgcGF0 Y2gsIHVzaW5nIGEgcGF0Y2ggYW5kIHRoZSBzb3VyY2UsIGJ1aWxkIElELCBhbmQNCiAgICAgYGBg DQogICAgICQgY2Qgfi9zcmMvbGl2ZXBhdGNoLWJ1aWxkDQogICAgICQgLi9saXZlcGF0Y2gtYnVp bGQgLXMgfi9zcmMveGVuYnVpbGQgLXAgfi9zcmMveHNhLnBhdGNoIC1vIG91dCBcDQogICAgLSAg ICAtYyB+L3NyYy94ZW4veGVuLy5jb25maWcgLS1kZXBlbmRzICRCVUlMRElEDQogICAgKyAgICAt YyB+L3NyYy94ZW4veGVuLy5jb25maWcgLS1kZXBlbmRzICRCVUlMRElEIC0teGVuLWRlcGVuZHMg JEJVSUxESUQNCiAgICAgQnVpbGRpbmcgTGl2ZVBhdGNoIHBhdGNoOiB4c2ENCg0KDQpSZXZpZXdl ZC1ieTogQmpvZXJuIERvZWJlbCA8ZG9lYmVsQGFtYXpvbi5kZT4NCg0KCgoKQW1hem9uIERldmVs b3BtZW50IENlbnRlciBHZXJtYW55IEdtYkgKS3JhdXNlbnN0ci4gMzgKMTAxMTcgQmVybGluCkdl c2NoYWVmdHNmdWVocnVuZzogQ2hyaXN0aWFuIFNjaGxhZWdlciwgSm9uYXRoYW4gV2Vpc3MKRWlu Z2V0cmFnZW4gYW0gQW10c2dlcmljaHQgQ2hhcmxvdHRlbmJ1cmcgdW50ZXIgSFJCIDE0OTE3MyBC ClNpdHo6IEJlcmxpbgpVc3QtSUQ6IERFIDI4OSAyMzcgODc5CgoK From xen-devel-bounces@lists.xenproject.org Wed Mar 02 15:33:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 15:33:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282360.481043 (Exim 4.92) (envelope-from ) id 1nPQzB-0006PL-6F; Wed, 02 Mar 2022 15:33:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282360.481043; Wed, 02 Mar 2022 15:33:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPQzB-0006PE-3K; Wed, 02 Mar 2022 15:33:53 +0000 Received: by outflank-mailman (input) for mailman id 282360; Wed, 02 Mar 2022 15:33:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPQz9-0006Ox-VV for xen-devel@lists.xenproject.org; Wed, 02 Mar 2022 15:33:51 +0000 Received: from smtp-fw-6002.amazon.com (smtp-fw-6002.amazon.com [52.95.49.90]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 27be76b3-9a3e-11ec-8539-5f4723681683; Wed, 02 Mar 2022 16:33:49 +0100 (CET) Received: from iad12-co-svc-p1-lb1-vlan2.amazon.com (HELO email-inbound-relay-iad-1a-b27d4a00.us-east-1.amazon.com) ([10.43.8.2]) by smtp-border-fw-6002.iad6.amazon.com with ESMTP; 02 Mar 2022 15:33:38 +0000 Received: from EX13D03EUC002.ant.amazon.com (iad12-ws-svc-p26-lb9-vlan3.iad.amazon.com [10.40.163.38]) by email-inbound-relay-iad-1a-b27d4a00.us-east-1.amazon.com (Postfix) with ESMTPS id DC28D810B9; Wed, 2 Mar 2022 15:33:36 +0000 (UTC) Received: from EX13D03EUC002.ant.amazon.com (10.43.164.60) by EX13D03EUC002.ant.amazon.com (10.43.164.60) with Microsoft SMTP Server (TLS) id 15.0.1497.28; Wed, 2 Mar 2022 15:33:35 +0000 Received: from EX13D03EUC002.ant.amazon.com ([10.43.164.60]) by EX13D03EUC002.ant.amazon.com ([10.43.164.60]) with mapi id 15.00.1497.028; Wed, 2 Mar 2022 15:33:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-Inumbo-ID: 27be76b3-9a3e-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.de; i=@amazon.de; q=dns/txt; s=amazon201209; t=1646235230; x=1677771230; h=from:to:cc:date:message-id:references:in-reply-to: content-id:mime-version:content-transfer-encoding:subject; bh=ibqaci7WSd3i0zZKWuTdO5RE4KcOfudQ884kPSuzPf4=; b=A8CYEy2GJvtzKBfHQBx01TiBQgWhNPuzkeLMUx/9FpGavsffTVMu4xKI 5C4mAzEIy88rKQ7QeNtr7S/AMAICGZgW4YQgbhnhA5KA4LjDGvkLafmSr l4KiBEjRP/yOgGsJtqtwI7cV7w0dTfC9lefai61Kl0RatUGbkRnBN1n/d A=; X-IronPort-AV: E=Sophos;i="5.90,149,1643673600"; d="scan'208";a="181121017" Subject: Re: [PATCH 2/4] livepatch: improve rune for fetching of Build ID Thread-Topic: [PATCH 2/4] livepatch: improve rune for fetching of Build ID From: "Doebel, Bjoern" To: Roger Pau Monne , "xen-devel@lists.xenproject.org" CC: "ross.lagerwall@citrix.com" , "konrad.wilk@oracle.com" , "julien@xen.org" , "Andrew.Cooper3@citrix.com" , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= Thread-Index: AQHYLkHj9LWrV4sIVU2Vyf7rjRMtcqysSgEA Date: Wed, 2 Mar 2022 15:33:34 +0000 Message-ID: <041F8844-D0C8-448B-9126-F5B3EADD2B8C@amazon.com> References: <20220302142711.38953-1-roger.pau@citrix.com> <20220302142711.38953-3-roger.pau@citrix.com> In-Reply-To: <20220302142711.38953-3-roger.pau@citrix.com> Accept-Language: en-US, de-DE Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.43.164.30] Content-Type: text/plain; charset="utf-8" Content-ID: <4671759490103F4D9F65A9763A6AB787@amazon.com> MIME-Version: 1.0 Precedence: Bulk Content-Transfer-Encoding: base64 ICAgIFRoZSBjdXJyZW50IG9uZSBpcyBicm9rZW4gd2l0aCBteSB2ZXJzaW9uIG9mIHJlYWRlbGYg YW5kIHJldHVybnMNCiAgICAnTlRfR05VX0JVSUxEX0lEJy4NCg0KICAgIFNpZ25lZC1vZmYtYnk6 IFJvZ2VyIFBhdSBNb25uw6kgPHJvZ2VyLnBhdUBjaXRycml4LmNvbT4NCiAgICAtLS0NCiAgICAg UkVBRE1FLm1kIHwgMiArLQ0KICAgICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEg ZGVsZXRpb24oLSkNCg0KICAgIGRpZmYgLS1naXQgYS9SRUFETUUubWQgYi9SRUFETUUubWQNCiAg ICBpbmRleCBiNDhhM2RmLi45NDhhN2RlIDEwMDY0NA0KICAgIC0tLSBhL1JFQURNRS5tZA0KICAg ICsrKyBiL1JFQURNRS5tZA0KICAgIEBAIC0xNiw3ICsxNiw3IEBAICQgY3AgLXIgfi9zcmMveGVu IH4vc3JjL3hlbmJ1aWxkDQogICAgICQgY2Qgfi9zcmMveGVuL3hlbg0KICAgICAkIG1ha2UgbmNv bmZpZyAjIE1ha2Ugc3VyZSB0byBzZXQgQ09ORklHX0xJVkVQQVRDSD15DQogICAgICQgbWFrZQ0K ICAgIC0kIEJVSUxESUQ9JChyZWFkZWxmIC1XbiB4ZW4tc3ltcyB8IGF3ayAnL0J1aWxkIElEOi8g e3ByaW50ICQzfScpDQogICAgKyQgQlVJTERJRD0kKHJlYWRlbGYgLVduIHhlbi1zeW1zIHwgc2Vk IC1uIC1lICdzL14uKkJ1aWxkIElEOiAvL3AnKQ0KICAgICBgYGANCg0KICAgICBOZXh0LCBidWls ZCBhIGxpdmUgcGF0Y2gsIHVzaW5nIGEgcGF0Y2ggYW5kIHRoZSBzb3VyY2UsIGJ1aWxkIElELCBh bmQNCiANCg0KUmV2aWV3ZWQtYnk6IEJqb2VybiBEb2ViZWwgPGRvZWJlbEBhbWF6b24uZGU+DQoN CgoKCkFtYXpvbiBEZXZlbG9wbWVudCBDZW50ZXIgR2VybWFueSBHbWJICktyYXVzZW5zdHIuIDM4 CjEwMTE3IEJlcmxpbgpHZXNjaGFlZnRzZnVlaHJ1bmc6IENocmlzdGlhbiBTY2hsYWVnZXIsIEpv bmF0aGFuIFdlaXNzCkVpbmdldHJhZ2VuIGFtIEFtdHNnZXJpY2h0IENoYXJsb3R0ZW5idXJnIHVu dGVyIEhSQiAxNDkxNzMgQgpTaXR6OiBCZXJsaW4KVXN0LUlEOiBERSAyODkgMjM3IDg3OQoKCg== From xen-devel-bounces@lists.xenproject.org Wed Mar 02 15:35:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 15:35:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282367.481055 (Exim 4.92) (envelope-from ) id 1nPR0X-00077C-Hg; Wed, 02 Mar 2022 15:35:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282367.481055; Wed, 02 Mar 2022 15:35:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPR0X-000775-E5; Wed, 02 Mar 2022 15:35:17 +0000 Received: by outflank-mailman (input) for mailman id 282367; Wed, 02 Mar 2022 15:35:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPR0W-00076x-OS for xen-devel@lists.xenproject.org; Wed, 02 Mar 2022 15:35:16 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 595688dc-9a3e-11ec-8eba-a37418f5ba1a; Wed, 02 Mar 2022 16:35:14 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 595688dc-9a3e-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1646235315; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=pj0Y4LdJ1nEakHOg/9BV7BcLzHgHTL9R/Sw4x3+t2Oc=; b=GFjzjMgaozgG0Dj4ACkrLR9MqQZ298W+fiHE7AoCN1x3x8rnsu6RdlBA bKgJ+QTFZfCxkM+DBf8anNssrNVAaz0nZTGjMcNX8VUMd1j+ImZaE+vkU vzIxeNQpVo8528EB3AP/tZ3ttlLUh++VOVoetA7RdOKnwUv4NVmArVD8Q A=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com X-SBRS: 5.1 X-MesageID: 65309310 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:2lUqXK2VKNMJsfZ2N/bD5SBxkn2cJEfYwER7XKvMYLTBsI5bpzAGn WQfD2qOPviLZGeheth2bou3/UsFvMLTn9JlTAA5pC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EE/NtTo5w7Rj2tUw24Dia++wk YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx /1Su4K5bBUyLJHs27sfYjJZOWZsEZNvreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr KJCbmpXN1ba2rzwkOnTpupE36zPKOHCOo8Ft24m5jbeFfs8GrjIQrnQ5M8e1zA17ixLNaiDP JJIMmM3BPjGS15RIUk1Jo8vpf6PiHbUWBFzrl6Ir5NitgA/yyQuieOwYbI5YOeiWsF9jkue4 GXc8AzRCBwAKMaWzzbD93u2n/LOhgvyQodUH7q9ntZUh1mUyn0WGQchf1KxqvmkiWazQ9tab UcT/0IGtrMu/UamSt38WRyQo3OeuBMYHd1KHIUS+AyLj6bZ/QudLmwFVSJaLswrstcsQj4n3 UPPmMnmbRRturCITXOW9p+PsCi/fyMSKAcqZzIATAYDy8nupsc0lB2nczp4OPfr1JuvQ2i2m m3U6nhl71kOsSIV/7q141nikSm+mriKEQwEzQT9GXCJ0CosMeZJeLeUwVTc6P9BKqOQQV+Ao GUIlqCi0QweMX2evHfTGbtQRdlF897AaWSB2gA3Q/HN4hzwoybLQGxG3N1pyK6F2O4gcCShX kLcsBg5CHR7bCrzNv8fj25c5q0XIUnc+TbNC6i8gjlmOMEZmOq7EMdGPxT4M4fFyhVErE3HE c3HGftA9F5DYUid8BK4Rv0GzZggzT0kyGXYSPjTlkr7j+PAPCbEF+5UajNii9zVCove+m05F P4FaqO3J+h3CrWiMkE7D6ZJRbz1EZTLLc+v8JEGHgJyCgFnBHsgG5fsLUAJIORYc1Buvr6Qp BmVAxYAoHKm3CGvAVjaOxhLNeK0Nb4i/C1TAMDZFQvxs5TVSd30t/l3mlpeVeRPydGPOtYvF 6hVI5jbW68XItkFkhxEBaTAQEVZXE3DrSqFPja/YSh5eJhlRgfT/cTjcBep/y4LZhdbf+Nny 1F8/ms3maY+ejk= IronPort-HdrOrdr: A9a23:/sc4PqoDnyJrcuCp5PqMXlUaV5uFL9V00zEX/kB9WHVpm5Oj+P xGzc526farslsssSkb6K290KnpewK4yXbsibNhcotKLzOWxFdAS7sSo7cKogeQVxEWk9Qy6U 4OSdkGNDSdNykYsS++2njDLz9C+qjHzEnLv5an854Fd2gDAMsAjzuRSDzraXGeLDM2XqbRf6 Dsgvav0gDQH0j/Gf7LYUXtMdKzxeHjpdbDW1orFhQn4A6BgXeD87jhCSWV2R8YTndm3aoi2X KtqX242oyT99WAjjPM3W7a6Jpb3PH7zMFYOcCKgs8Jbh3xlweTYph7UbHqhkF3nAjv0idprD D/mWZlAy1B0QKXQohzm2qq5+DU6kdq15Yl8y7AvZKsm72geNtwMbs/uWsQSGqm16NnhqAn7E sD5RPoi3IcZymw7RjV9pzGUQpnmVGzpmdnmekPj2ZHWY9bc7NJq5cDlXklW6voMRiKobzPKt MeRP00JcwmBW+yfjTcpC1i0dasVnM8ElOPRVUDoNWc13xTkGpix0UVycQDljNYnahNBqVs9q DBKOBlhbtORsgZYeZ0A/oAW9K+DijITQjXOGyfLFz7HOUMOm7LqZTw/LIpjdvaMqAg3d83gt DMQVlYvWk9dwbnDtCPxoRC9lTXTGC0TV3Wu7djDlhCy8rBrZbQQF++oQoV4ridSt0kc7jmZ8 o= X-IronPort-AV: E=Sophos;i="5.90,149,1643691600"; d="scan'208";a="65309310" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m7SqQJ/IhdlTEbCiPW6YEjLlArtZTldka9r/o0eo/wiIf3mdlkp5lpFBYlovVZI2UmNvLsIqEzY7UZYXvVkWF4ea1Q1iFWNKWHM9c8T6wpUkvQSgG9PN+FBCzx7Rh1OLui7yCJ+ALk94QdYNcUxZ5VaQV3psOsyrURy5BSEVmEFo9sumxJiIZG3k5QYlGmYFXZjn+/DApwwItdaK2mTaUO7SDj25NOJP/BD/lZ6AqL+In6mKMf8TxZQs/kG5YYONNZMMQhdv/04lksE+9KhEW4cAqW7k3Rm590twGN1GkxD6jlsvgmj8lRfywerpbmzPA3sBsp9uXcdRm4wBnDHfdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pj0Y4LdJ1nEakHOg/9BV7BcLzHgHTL9R/Sw4x3+t2Oc=; b=jpjfIpzZjHBd1D0lCM50vBPi5TLt3x2uQbMFSIxEtbrX5Ue7BIuYY9x7AHFyFpYBi7uHv6Zw8u1W+I2+bzKu1Y1TAwEivHlvpmIYbbYcbpRfyFo+JzdNg3TvR15wZAz4ih4ye2GKt9bFORVB9ZZfct8Ra8zyaXRcCKe4qNgJlsKg3usZqbQZPFTjuC6jWDQGciiOS6716drSPyc9MDh4vap4uyzeVNca12tt/cjQEjrX8IQIP67axMsPWtUHatGpWpmzq0g/AP291gP9A0xIfwjAYTskDeldt83Nli72OH1J28AzNmDq4Mh0GAplpaM0pCdYVx5JS6XXw+U9/lqG+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pj0Y4LdJ1nEakHOg/9BV7BcLzHgHTL9R/Sw4x3+t2Oc=; b=T4xtgktQcgBT06+f66Ps+Do+eA9CYZx54FtgIXOs0U24EmTHprhwYuwPtxc+lSiAiQMxhbHpiDewjXNaLo3ZqphFA/VlHQWvrYxvOv3Bpwe5FRUa2XXcgJNhJeoIe4KYQlN04gY1iAJwInmHLjejLOo6En6mUyrQw+05o3SnIYw= From: Andrew Cooper To: Roger Pau Monne , "xen-devel@lists.xenproject.org" CC: George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , "Volodymyr Babchuk" Subject: Re: [PATCH] livepatch: set -f{function,data}-sections compiler option Thread-Topic: [PATCH] livepatch: set -f{function,data}-sections compiler option Thread-Index: AQHYLjuyHNmMpGp0pEK3C688krS2saysObiA Date: Wed, 2 Mar 2022 15:35:07 +0000 Message-ID: References: <20220302134425.38465-1-roger.pau@citrix.com> In-Reply-To: <20220302134425.38465-1-roger.pau@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 23290885-31a7-4fdd-c282-08d9fc623b13 x-ms-traffictypediagnostic: CH0PR03MB5954:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8orlaSIDFj22BkIZ6wu9X83kXu3FfGphi9PgP1bv7QrPgsdtOa5mjKLkxC71p1C8SuJw8Xtd3r8iI2xO4wNknjE0xDzb7xQg1+QC1daxdDf8xhIEj0W3q/lqEN9HEWy0JGoX2f7+FtniHHodGX3xZ7S7rHVBCjyx6+Iq9HezyNejjfIxFx6J6IFRkp8mEhtZmwLwlVVbO1TB5b1KVml3alhoG3IscExxkSOdIgvjnoLyCC+ygcr6BsItn3J5OaVff3+J0ey9jm0+lCt9N9A1SF1XjlzsR1wHN4B/BjN1WMQtsXDdJIFpl92kXzclaN6qW12BO2xDDUG2sfB57lkoA6d5XTriVNxnrXKkyexPBybFPRlRhtJADH6vGYN9hHB5RostZPxCQkqy6el6JZMts8R8p9qLqRr/VVKRZZrAW1lN9TqCbuw6AxcHf4N3YFs8d45V+yECbmJItttH5Apk138dWdHA9FwuYxlLWZe/va6NoijUo4BV43Uo2eQbX017B+f9AC0u4cloGHU4ttDe76sqczN9mio0YJL8biuEz9vp7GKHUqo5RXom1Bay2dxrbgtc0X1sPnDkPQGN2LJ3pq6JrUos+ttQcyGOw2BWNrvTeuI3qgy33ZdJ6xFFzpfEBmiKKeGokxt1IJyv0LRMOTnzGkfp63/EyS93AP8hKKvek7v/36tz7O6JLHRIsy9h8wCePzVR9SzVzYnoQcdnz7yNR2dmG7QDBQuwcyy1S/gr028/u+/f66KLUdIvoL5VVFcFKtsSHaxiuxnDe2y9Yw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(186003)(26005)(38070700005)(110136005)(6512007)(53546011)(2906002)(6506007)(2616005)(86362001)(38100700002)(31696002)(82960400001)(122000001)(54906003)(71200400001)(4744005)(5660300002)(4326008)(31686004)(91956017)(8936002)(508600001)(64756008)(6486002)(66556008)(66446008)(66946007)(66476007)(36756003)(316002)(76116006)(8676002)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?WWFhMlA0NG5RcnZYNE5zaXpWSzZWTXcyMHZidzFic05ya3RaMG1Ca24xQk5r?= =?utf-8?B?YzdsSHZaK3Myc01nZ0loSVJxZENhZHo1TDJkYURaRWFQOHM2TmM3YXg0MkxX?= =?utf-8?B?enhONUpVWDllM3JJYVdzN3crazExTTc5eHRXcURUTUtEWDFHdENaNTY1ckFs?= =?utf-8?B?OW9XcllsTm5BSEhnYURPTU5abFNqL25pclVkUStXdlh0RFE2ak9pS3RBQm9D?= =?utf-8?B?VkQvVDNJaTNiRkx2TWdHSWU1cEp2UDk2dE5DSEUrT2xVUTAxUUxhZFBzZWY5?= =?utf-8?B?ZHRtZmRTbER1czRSSjZ2QWg2bXVMRzdrc0UxeTRndlUxYXlRZCt6Z1YvTHlR?= =?utf-8?B?L3pNTU5oT0t0WjZ5cmRueklvRmR4OE96K2QvWDArRkxUSkRXdzNyM1p0eFdi?= =?utf-8?B?djZhL1liYW1WUzNYWThMcmNsQmpIUUNsenB5K1o0eVB2TCtLNEMxTXFibzFw?= =?utf-8?B?WTlzRTNBbFZZSEhCTW9nemU3Q2JhWEpQUEdIM0RKWm5mUERKK1RONG8wL3Rh?= =?utf-8?B?TjIrUlRZVVViWDhNT2xJZ2xWdElLUkZlUUhKNzVtNWhVUmVaU1ZhdDVkb0pD?= =?utf-8?B?SUxFdktEUnU4RjZTRjlWK0QxNHJhL1lzVDNnYndOT1Z0Z1MvVnRZMlB4TWRa?= =?utf-8?B?VEhMMXU4SDdBZ1ZDT1JqUjF5cHZyOUlHMzJ2ZGpwdVcxYWlsSStSZ3lxakQ4?= =?utf-8?B?bDBtb25uc1dSeVZrZVd1OWgzc1IzWmNuRXNaTkFaeXJ0c29oUmRiZ3IxUU5z?= =?utf-8?B?b1VUakl0RjUzVFJRbmJqSmVZS3NKNllQU3dhVEV5U050TVVmc0tESVlxRnVr?= =?utf-8?B?cVRZREhIVTVSM0w2dFBnU3RUdWE0UkVHVWFwbVBqS0FXK0NGaHcweFMzaURU?= =?utf-8?B?aUNHQzdpbytrTkQrN2VxSFRhclY3dHNRNDluRUl2S21jWEdOVG1jbWVHTFV3?= =?utf-8?B?VmZzWGNpTHB2eFNCRFFsUnhOL09DZjFxb3NXaTcyRUR3MjVGYXU5VFMwaEJx?= =?utf-8?B?NXc0QU5kUldzV2VGTDRaNzB5NDdXd2RFSFUxOXNnUjBCejh0SDdNZHA4YjNM?= =?utf-8?B?V3RlODNVQXhVc3BaVHQxRzhaTyszWTZTSTBQUi9HVlNFVG1YYUpyaDRrbitz?= =?utf-8?B?WGJhbzJicDl4NnZ2bEtmdjZMcHBUK2VXa2ZScVJpT1FpdS9QRitmOGcwQ1Zq?= =?utf-8?B?MDQ2U3FnQjVUb3RqS1VvbGpIcklqZDNRU0VSVVB6MlpYYVR0OTBpK2o4d20y?= =?utf-8?B?QnBMeFd0cnAvTW1zbVN2Y0MyaDBST0c3dkx4ZnFVNTJZRDFkdG8zMCtnVXBW?= =?utf-8?B?Qys4ZnI2V211cmFRa3RNMVllV3M2RzZkWWc4Tlh1SnpUNlN3TC9XWk4xYnVR?= =?utf-8?B?WG41LzFVa2ZZTi8xSGdQaisrT09pZDV6eEtIR2RzM0lFcnpidGVFZ0ZGYTY2?= =?utf-8?B?eGRqcE5MeHNxSXZkY1gxdm9xdEs4aUF5ZXJTbXR2STFkM05ZTmpWZmUxNTFC?= =?utf-8?B?eFJoZ096Q2wzNlIxZStOQjZla0xTK1JLWWsvSmFFb1F0aTZRUW4xajNCeU9n?= =?utf-8?B?TUR0d3E5aHhTMXY0Z0NYWmpwbEljcUEvci9tcmJ0Q0hOZllTQU1FN1ZLVkNl?= =?utf-8?B?NGZSSFFma1JVVU4vU1Q1Z2FGZXgvQnJlakYxbUJzZDF0aDJZVEM4ZlNWcWpM?= =?utf-8?B?Q1FqUnpjTGk3QzVEdFRzYkhHcjZ0ZWJaTnpOdFdBYk1JVDZJR3djUm5IMS9L?= =?utf-8?B?NFl5bzRPMWQyZDZuaHYvMG1tUXpnVVhSK1JDSW5zL3ZBZTRrN1BxWVNLdCsx?= =?utf-8?B?MTJDNEZIRFhpTG0rRDU5Y2xKRGtyVEIrVjFwc3QyRVcxQjNLVHNwT2ZUb2w0?= =?utf-8?B?aHJOempQYlEvMitxUDBiaW8rM3ZnWEZJRlJ0UzdiSHZJZkNwR2cyempWMGoy?= =?utf-8?B?ZHIxZ1FnMTZkSmRjN2Z0V1lIZXMvcTRyb3N1TWg1R3VsTUh1bFFBUjZ1R283?= =?utf-8?B?YStpcFNOSk1JQ3dRS1QrWTA2K2I5cUhCODVYRm8rczlianovOEEzUkMrNE9N?= =?utf-8?B?VTY4elA4YThuQWx6Ty9DdzVCQ3JueFpkM3RpM0ZaZXZzalZjUlRsdkhlMVJC?= =?utf-8?B?WEs3S1BaZmp2T1d0WFRrSU1vSVArNzYvK2NRTC9RLzJRVEFJZ3pNNWY2MzJ2?= =?utf-8?B?c1hLUktibkxKOUFNRHd2YVhDdnNKazhId1lTYzlrR3BFbnJBZ2dZQXpUY1Bj?= =?utf-8?B?VkZSTzZxSVBKbXVpU1RvMkZCSnVBPT0=?= Content-Type: text/plain; charset="utf-8" Content-ID: <72454B80150A934AA0FD3674976F1FA8@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 23290885-31a7-4fdd-c282-08d9fc623b13 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Mar 2022 15:35:07.6687 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9EkGWP3uaTMdPEDeTMHrqQO+9E2FCA7Mq1Zpdx+CPWCLwL7AP6nDZ1DQbZwcIohFWm/UcqxlMKlVa6SDj/yMVfe9Ue+N8HZ/2f8kCVrfD6E= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR03MB5954 X-OriginatorOrg: citrix.com T24gMDIvMDMvMjAyMiAxMzo0NCwgUm9nZXIgUGF1IE1vbm5lIHdyb3RlOg0KPiBkaWZmIC0tZ2l0 IGEveGVuL2NvbW1vbi9LY29uZmlnIGIveGVuL2NvbW1vbi9LY29uZmlnDQo+IGluZGV4IDY0NDM5 NDM4ODkuLjI0MjNkOWY0OTAgMTAwNjQ0DQo+IC0tLSBhL3hlbi9jb21tb24vS2NvbmZpZw0KPiAr KysgYi94ZW4vY29tbW9uL0tjb25maWcNCj4gQEAgLTM1Myw3ICszNTMsOSBAQCBjb25maWcgQ1JZ UFRPDQo+ICBjb25maWcgTElWRVBBVENIDQo+ICAJYm9vbCAiTGl2ZSBwYXRjaGluZyBzdXBwb3J0 Ig0KPiAgCWRlZmF1bHQgWDg2DQo+IC0JZGVwZW5kcyBvbiAiJChYRU5fSEFTX0JVSUxEX0lEKSIg PSAieSINCj4gKwlkZXBlbmRzIG9uICIkKFhFTl9IQVNfQlVJTERfSUQpIiA9ICJ5IiAmJiBcDQo+ ICsJICAgICAgICAgICAkKGNjLW9wdGlvbiwtZmZ1bmN0aW9uLXNlY3Rpb25zKSAmJiBcDQo+ICsJ ICAgICAgICAgICAkKGNjLW9wdGlvbiwtZmRhdGEtc2VjdGlvbnMpDQoNCmNjLW9wdGlvbiBjYW4g dGFrZSBtdWx0aXBsZSwgc28ganVzdCAkKGNjLW9wdGlvbiwtZmZ1bmN0aW9uLXNlY3Rpb25zDQot ZmRhdGEtc2VjdGlvbnMpDQoNCkhvd2V2ZXIsIHdlIGluIHByYWN0aWNlIHdhbnQgdGhlc2UgaW4g Y29tYmluYXRpb24gd2l0aCAkKExEKQ0KLS1nYy1zZWN0aW9ucyBhbnl3YXkgYWx0aG91Z2ggdGhh dCB3YW50cyB0byBiZSBzZXBhcmF0ZWx5IGNvbmZpZ3VyYWJsZS4NCg0KVGhlcmVmb3JlLCB3ZSBw cm9iYWJseSB3YW50IHNvbWV0aGluZyBsaWtlOg0KDQpjb25maWcgRlVOQ19TRUNUSU9OUw0KwqDC oMKgIGJvb2wNCg0KY29uZmlnIExJVkVQQVRDSA0KwqDCoMKgIHNlbGVjdHMgRlVOQ19TRUNUSU9O Uw0KDQpvciBzbywgc28gaW4gdGhlIGZ1dHVyZSB3ZSBjYW4gYWRkICJjb25maWcgTERfR0NfU0VD VElPTlMiIHdoaWNoIGFsc28NCnNlbGVjdHMgRlVOQ19TRUNUSU9OUy4NCg0KVGhvdWdodHM/DQoN Cn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Wed Mar 02 15:41:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 15:41:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282376.481065 (Exim 4.92) (envelope-from ) id 1nPR6o-0000Pg-7V; Wed, 02 Mar 2022 15:41:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282376.481065; Wed, 02 Mar 2022 15:41:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPR6o-0000PZ-4R; Wed, 02 Mar 2022 15:41:46 +0000 Received: by outflank-mailman (input) for mailman id 282376; Wed, 02 Mar 2022 15:41:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPR6n-0000PT-5I for xen-devel@lists.xenproject.org; Wed, 02 Mar 2022 15:41:45 +0000 Received: from smtp-fw-2101.amazon.com (smtp-fw-2101.amazon.com [72.21.196.25]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4264face-9a3f-11ec-8539-5f4723681683; Wed, 02 Mar 2022 16:41:44 +0100 (CET) Received: from iad12-co-svc-p1-lb1-vlan2.amazon.com (HELO email-inbound-relay-pdx-2c-7d0c7241.us-west-2.amazon.com) ([10.43.8.2]) by smtp-border-fw-2101.iad2.amazon.com with ESMTP; 02 Mar 2022 15:41:42 +0000 Received: from EX13D03EUC002.ant.amazon.com (pdx1-ws-svc-p6-lb9-vlan3.pdx.amazon.com [10.236.137.198]) by email-inbound-relay-pdx-2c-7d0c7241.us-west-2.amazon.com (Postfix) with ESMTPS id 527CF41870; Wed, 2 Mar 2022 15:41:39 +0000 (UTC) Received: from [10.85.98.33] (10.43.164.197) by EX13D03EUC002.ant.amazon.com (10.43.164.60) with Microsoft SMTP Server (TLS) id 15.0.1497.28; Wed, 2 Mar 2022 15:41:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-Inumbo-ID: 4264face-9a3f-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.de; i=@amazon.de; q=dns/txt; s=amazon201209; t=1646235704; x=1677771704; h=message-id:date:mime-version:to:cc:references:from: in-reply-to:content-transfer-encoding:subject; bh=1uk/DSu/NPJuNzMKyaxe3cqibXXxR+rj5TpFZV0/LKE=; b=RZbTI3aWoEVH6BBuKyh2aI2g6WJUjMSzo5yOru7yUUBsEIjsdVLWcDGt fF5IprU50/kSQwB7v1xgiDnY360VZ+pohUPTEG8tqCQwZiLVTnOoZodQM bmpKWG9EWptkg6Zy5JqDWCiT0/vLp8VynTdhdtbpzhwzxQfzAmWlHT5zE k=; X-IronPort-AV: E=Sophos;i="5.90,149,1643673600"; d="scan'208";a="177887057" Subject: Re: [PATCH 4/4] livepatch: differentiate between old and new build systems Message-ID: <459241b5-d412-d2e3-0f23-6094db87535a@amazon.de> Date: Wed, 2 Mar 2022 16:41:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Content-Language: en-US To: Roger Pau Monne , CC: , , , References: <20220302142711.38953-1-roger.pau@citrix.com> <20220302142711.38953-5-roger.pau@citrix.com> From: "Doebel, Bjoern" In-Reply-To: <20220302142711.38953-5-roger.pau@citrix.com> X-Originating-IP: [10.43.164.197] X-ClientProxiedBy: EX13D02EUC004.ant.amazon.com (10.43.164.117) To EX13D03EUC002.ant.amazon.com (10.43.164.60) Precedence: Bulk Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Transfer-Encoding: base64 T24gMDIuMDMuMjIgMTU6MjcsIFJvZ2VyIFBhdSBNb25uZSB3cm90ZToKPiBDQVVUSU9OOiBUaGlz IGVtYWlsIG9yaWdpbmF0ZWQgZnJvbSBvdXRzaWRlIG9mIHRoZSBvcmdhbml6YXRpb24uIERvIG5v dCBjbGljayBsaW5rcyBvciBvcGVuIGF0dGFjaG1lbnRzIHVubGVzcyB5b3UgY2FuIGNvbmZpcm0g dGhlIHNlbmRlciBhbmQga25vdyB0aGUgY29udGVudCBpcyBzYWZlLgo+IAo+IAo+IAo+IERvIG5v dCBhdHRlbXB0IHRvIG1vZGlmeSB0aGUgYnVpbGQgc3lzdGVtIGlmIENGTEFHUyBhcmUgbm90IHNl dCBpbgo+IFJ1bGVzLm1rLCBhbmQgaW5zdGVhZCByZWx5IG9uIENPTkZJR19MSVZFUEFUQ0ggYWxy ZWFkeSBzZXR0aW5nCj4gLWZ7ZnVuY3Rpb24sZGF0YX0tc2VjdGlvbnMuCj4gCj4gU2lnbmVkLW9m Zi1ieTogUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+Cj4gLS0tCj4gVGhp cyBkZXBlbmRzIG9uIGdldHRpbmcgdGhlIHBhdGNoIHRvIGFkZCAtZntmdW5jdGlvbixkYXRhfS1z ZWN0aW9ucwo+IHdoZW4gdXNpbmcgQ09ORklHX0xJVkVQQVRDSCBhY2NlcHRlZC4KPiAtLS0KPiAg IGxpdmVwYXRjaC1idWlsZCB8IDIyICsrKysrKysrKysrKysrLS0tLS0tLS0KPiAgIDEgZmlsZSBj aGFuZ2VkLCAxNCBpbnNlcnRpb25zKCspLCA4IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQg YS9saXZlcGF0Y2gtYnVpbGQgYi9saXZlcGF0Y2gtYnVpbGQKPiBpbmRleCAzOGE5MmJlLi42NTZj ZGFjIDEwMDc1NQo+IC0tLSBhL2xpdmVwYXRjaC1idWlsZAo+ICsrKyBiL2xpdmVwYXRjaC1idWls ZAo+IEBAIC05OCwxNCArOTgsMjAgQEAgZnVuY3Rpb24gYnVpbGRfc3BlY2lhbCgpCj4gCj4gICAg ICAgIyBCdWlsZCB3aXRoIHNwZWNpYWwgR0NDIGZsYWdzCj4gICAgICAgY2QgIiR7U1JDRElSfS94 ZW4iIHx8IGRpZQo+IC0gICAgc2VkIC1pICdzL0NGTEFHUyArPSAtbm9zdGRpbmMvQ0ZMQUdTICs9 IC1ub3N0ZGluYyAtZmZ1bmN0aW9uLXNlY3Rpb25zIC1mZGF0YS1zZWN0aW9ucy8nIFJ1bGVzLm1r Cj4gLSAgICBjcCAtcCBhcmNoL3g4Ni9NYWtlZmlsZSBhcmNoL3g4Ni9NYWtlZmlsZS5iYWsKPiAt ICAgIHNlZCAtaSAncy8tLXNlY3Rpb24tYWxpZ25tZW50PTB4MjAwMDAwLy0tc2VjdGlvbi1hbGln bm1lbnQ9MHgxMDAwLycgYXJjaC94ODYvTWFrZWZpbGUKPiAtICAgICMgUmVzdG9yZSB0aW1lc3Rh bXBzIHRvIHByZXZlbnQgc3B1cmlvdXMgcmVidWlsZGluZwo+IC0gICAgdG91Y2ggLS1yZWZlcmVu Y2U9YXJjaC94ODYvTWFrZWZpbGUuYmFrIGFyY2gveDg2L01ha2VmaWxlCj4gLSAgICBtYWtlICIt aiRDUFVTIiAkWEVOX0RFQlVHICY+ICIke09VVFBVVH0vYnVpbGRfJHtuYW1lfV9jb21waWxlLmxv ZyIgfHwgZGllCj4gLSAgICBzZWQgLWkgJ3MvQ0ZMQUdTICs9IC1ub3N0ZGluYyAtZmZ1bmN0aW9u LXNlY3Rpb25zIC1mZGF0YS1zZWN0aW9ucy9DRkxBR1MgKz0gLW5vc3RkaW5jLycgUnVsZXMubWsK PiAtICAgIG12IC1mIGFyY2gveDg2L01ha2VmaWxlLmJhayBhcmNoL3g4Ni9NYWtlZmlsZQo+ICsg ICAgaWYgZ3JlcCAtcSAnbm9zdGRpbmMnIFJ1bGVzLm1rOyB0aGVuCgpUaGlzIG1lYW5zIHdlIGFy ZSBzdGlsbCBicmVha2luZyBsaXZlcGF0Y2ggYnVpbGRzIGZvciBhbGwgWGVuIHZlcnNpb25zIApi ZXR3ZWVuIHlvdXIgcmVjZW50IHBhdGNoIGFuZCB0aGUgb3JpZ2luYWwgcGF0Y2ggdGhhdCBtb3Zl ZCBDRkxBR1MgdG8gCnhlbi9NYWtlZmlsZSAoY29tbWl0IDI3NDBkOTZlZmRkMzAwOWY4YWRiNDBh YWNkYmNmMDVjZmU4ZDFiYmIsIEZyaSBBcHIgCjI0IDE0OjU3OjEwIDIwMjAgKzAyMDApLgoKSXMg dGhpcyBhY2NlcHRhYmxlPyAoSSBtZWFuLCBubyBvbmUgc2VlbXMgdG8gaGF2ZSBub3RpY2VkLi4u KQoKPiArICAgICAgICAgIyBTdXBwb3J0IGZvciBvbGQgYnVpbGQgc3lzdGVtLCBhdHRlbXB0IHRv IHNldCAtZntmdW5jdGlvbixkYXRhfS1zZWN0aW9ucyBhbmQgcmVidWlsZAo+ICsgICAgICAgIHNl ZCAtaSAncy9DRkxBR1MgKz0gLW5vc3RkaW5jL0NGTEFHUyArPSAtbm9zdGRpbmMgLWZmdW5jdGlv bi1zZWN0aW9ucyAtZmRhdGEtc2VjdGlvbnMvJyBSdWxlcy5tawo+ICsgICAgICAgIGNwIC1wIGFy Y2gveDg2L01ha2VmaWxlIGFyY2gveDg2L01ha2VmaWxlLmJhawo+ICsgICAgICAgIHNlZCAtaSAn cy8tLXNlY3Rpb24tYWxpZ25tZW50PTB4MjAwMDAwLy0tc2VjdGlvbi1hbGlnbm1lbnQ9MHgxMDAw LycgYXJjaC94ODYvTWFrZWZpbGUKPiArICAgICAgICAjIFJlc3RvcmUgdGltZXN0YW1wcyB0byBw cmV2ZW50IHNwdXJpb3VzIHJlYnVpbGRpbmcKPiArICAgICAgICB0b3VjaCAtLXJlZmVyZW5jZT1h cmNoL3g4Ni9NYWtlZmlsZS5iYWsgYXJjaC94ODYvTWFrZWZpbGUKPiArICAgICAgICBtYWtlICIt aiRDUFVTIiAkWEVOX0RFQlVHICY+ICIke09VVFBVVH0vYnVpbGRfJHtuYW1lfV9jb21waWxlLmxv ZyIgfHwgZGllCj4gKyAgICAgICAgc2VkIC1pICdzL0NGTEFHUyArPSAtbm9zdGRpbmMgLWZmdW5j dGlvbi1zZWN0aW9ucyAtZmRhdGEtc2VjdGlvbnMvQ0ZMQUdTICs9IC1ub3N0ZGluYy8nIFJ1bGVz Lm1rCj4gKyAgICAgICAgbXYgLWYgYXJjaC94ODYvTWFrZWZpbGUuYmFrIGFyY2gveDg2L01ha2Vm aWxlCj4gKyAgICBlbHNlCj4gKyAgICAgICAgIyAtZntmdW5jdGlvbixkYXRhfS1zZWN0aW9ucyBz ZXQgYnkgQ09ORklHX0xJVkVQQVRDSAo+ICsgICAgICAgIG1ha2UgIi1qJENQVVMiICRYRU5fREVC VUcgJj4gIiR7T1VUUFVUfS9idWlsZF8ke25hbWV9X2NvbXBpbGUubG9nIiB8fCBkaWUKPiArICAg IGZpCj4gCj4gICAgICAgdW5zZXQgTElWRVBBVENIX0JVSUxEX0RJUgo+ICAgICAgIHVuc2V0IExJ VkVQQVRDSF9DQVBUVVJFX0RJUgoKQmpvZXJuCgoKCkFtYXpvbiBEZXZlbG9wbWVudCBDZW50ZXIg R2VybWFueSBHbWJICktyYXVzZW5zdHIuIDM4CjEwMTE3IEJlcmxpbgpHZXNjaGFlZnRzZnVlaHJ1 bmc6IENocmlzdGlhbiBTY2hsYWVnZXIsIEpvbmF0aGFuIFdlaXNzCkVpbmdldHJhZ2VuIGFtIEFt dHNnZXJpY2h0IENoYXJsb3R0ZW5idXJnIHVudGVyIEhSQiAxNDkxNzMgQgpTaXR6OiBCZXJsaW4K VXN0LUlEOiBERSAyODkgMjM3IDg3OQoKCg== From xen-devel-bounces@lists.xenproject.org Wed Mar 02 15:47:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 15:47:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282385.481077 (Exim 4.92) (envelope-from ) id 1nPRC7-0001Qh-Um; Wed, 02 Mar 2022 15:47:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282385.481077; Wed, 02 Mar 2022 15:47:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPRC7-0001Qa-RU; Wed, 02 Mar 2022 15:47:15 +0000 Received: by outflank-mailman (input) for mailman id 282385; Wed, 02 Mar 2022 15:47:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPRC6-0001QU-Dz for xen-devel@lists.xenproject.org; Wed, 02 Mar 2022 15:47:14 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0615fc1c-9a40-11ec-8eba-a37418f5ba1a; Wed, 02 Mar 2022 16:47:12 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0615fc1c-9a40-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1646236033; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=eWoL7UDnr+ihWShPPBPohlYN5Bdv4KC6XwMw/0KfhW4=; b=OTbRdJNRordlgdoQRdNrt3uMey6RdsZAdb7tv5JpN1jAbRT5pxv29RzL U2A+JldKtV9Qugpxk3foqTKrEl5ET3nS+0XQHs0OfmVf+ypCNOhSFIkux r1oSQ7zVAI+UdXbO1/yfiB3tgSKOaXPvL0C8Y3i8pmO9b8bchJtuapw+I U=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com X-SBRS: 5.1 X-MesageID: 67627776 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:4fp476vUfLCwsjqhOvP3UxnaPOfnVKJeMUV32f8akzHdYApBsoF/q tZmKWCDP66NZmL0L9x2aN628U1VupDRzIBnGgNtpXw0EiwT+JbJXdiXEBz9bniYRiHhoOOLz Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQyw4bVvqYy2YLjW1jV4 4upyyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo Oihu6BcRi8FHrbov88PVyVFGntwfpIX1o3KIV2W5Jn7I03uKxMAwt1rBUAye4YZ5vx2ESdF8 vlwxDIlN07ZwbjsmfTiF7cq1p9LwMrDZevzvll6yj7UF7A+SI3rSKTW/95Imjw3g6iiGN6AO JRDNmUwMnwsZTVOJ2VOOYw7g9zyqVj+Kw9ktE6xnoUetj27IAtZj+G2bYu9lsaxbc9YhFqCr 2TKuWHwGAgHNce3wCCAtHmrg4fnoyT/X44DEayiwdRjilaT2287BQUfUB2wpvzRol6zXZdTJ lIZ/gIqrLMu7wq7Q9/lRRq6rXWY+BkGVLJ4DOkS+AyLjK3O7G6xBGIJUzpAY9wOr9ItSHoh0 Vrht9H0AT1itpWFRHTb8a2bxRupIjQcJ2IGYS4CTCMG7sPlrYV1iQjAJuuPC4bs0IezQ2uph WnX8m5u3N3/kPLnyY2X3UvjpBm+oqTUR1Q7pTqGcFCo7iZQMdvNi5OT1XDX6vNJLYC8R1aHv WQZl8X20N3iHa1hhwTWHrxTQejBC+KtdWSF3AUxR8VJGyGFpib7Fb289g2SM6uA3iwsXTbyK HHetgpKjHO4FCv7NPQnC25d5ilD8EQBKTgHfq2MBjatSsIoHONiwM2ITRTKt4wKuBJx+ZzTw b/BLa6R4Y8yUMyLNgaeSeYHyqMMzSsj327VTp2T5035jeTHOibNGOlcYQHmggUFAEWs+l+9H zF3bZbi9vmieLemPnm/HXA7dzjm0kTX9bip8pcKJ4Zv0yJtGX07Cu+5/F/SU9cNokihrc+Rp ivVchYBkDLX3CSbQS3XOiELQO6+Bv5X8CNkVRHAyH71ghDPl670t/xBH3b2FJF6nNFeIQlcF KFUK53dWa0UElwqOV01NPHAkWCrTzzy7SqmNCu5ejkvOZlmQg3C4Nj/eQXzsiIJC0KKWQEW+ dVMCiuzrUI/ejlf IronPort-HdrOrdr: A9a23:MHZ7TavR6tTR/bbOMn3acnrp7skCmoMji2hC6mlwRA09TyXGra +TdaUguSMc1gx9ZJhBo7G90KnpewK6yXdQ2/hqAV7CZnichILMFu9fBOTZsl/d8kHFh4tgPO JbAtVD4b7LfCZHZKTBkXCF+r8bqbHtmsDY5ts2jU0dNT2CA5sQkDuRYTzrdHGeKjM2YabQQ/ Gnl7Z6TnebCD0qR/X+IkNAc/nIptXNmp6jSRkaByQ/4A3LqT+z8rb1HzWRwx9bClp0sPwf2F mAtza8yrSosvm9xBOZ/2jP765OkN+k7tdYHsSDhuUcNz2poAe1Y4ZKXaGEoVkO0amSwWdvtO OJjwYrPsx15X+UVmapoSH10w2l6zoq42+K8y7tvVLT5ejCAB4qActIgoxUNjHD7VA7gd162K VXm0qEqpt+F3r77WjAzumNcysvulu/oHIkn+JWpWdYS5EiZLhYqpFa1F9JEa0HADnx5OkcYa RT5fnnlbhrmG6hHjHkVjEF+q3tYp1zJGbNfqE6gL3b79AM90oJjHfxx6Qk7wI9HdwGOtt5Dt //Q9RVfYF1P74rhJ1GdZQ8qOuMexvwqEH3QRSvyWqOLtB0B5uKke+z3IkI X-IronPort-AV: E=Sophos;i="5.90,149,1643691600"; d="scan'208";a="67627776" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mF9FOsK0xUCvHfsMQVgfsaPZso9/WzbZRHGTB+Ta58SKhtg28NRQ6ZY9fFa0n9btDZ1DN3AO/KYnFUO4zMQ/TpbYSOe14vzuIzR9it9ElAhUWrIL19ki8xJjX3/aBHOW4z2z/8LuEYBfg/uD01OwWjHWz/ZTlAc0/9kf/PgiqkhQPZh7s/nkK7kQWNn2rTvAjJoUpjVrMRJx49E5xElM19rPm1QGJYsRDB4AfJr1zfSWW0JZIiXwukXEjbOv4LWYd+BEXNTJRjSMo9s1PqzIlgO7xFzfqszud/Spo4/dmx33LfOB7eD0fwiAEMKbvMxVVCemhxq5XvJdTjM89cr8hw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iXEjprna9Jcvu5WW2tEEXwGRoTegWZp6yiwvPEdU6Uw=; b=AjTn6PXVxRylaOObRJ73zk64z/mqjYSXgYkQWTd/BIoFBUcSfY44RSSB0HyqEANeJUcE2sz7g2iT270fwACuvsM6laxBA3IE7Gg52exlPLTe56KWDpkclgAnsgfoqSzWNCrqWpWZG7XSDqVPiTR6yswDj8goOw8VBCJnRmh2PQf8KPht6B+SUc0SkasPtj4pb4EKRk6L1V/cHnMcKp5t3kWXtbJTMqZVZ9pJYSz8QJ3VZaacjZYaw4M2qu1CUxfJtZTqLoTnsGyoVIVedvJuyJ7D3Urhi1JleHWZNGZHiYJDen30hYLVsCwfMnbhc0LF61uVF1TAtiRe9+0Atv6Qsw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iXEjprna9Jcvu5WW2tEEXwGRoTegWZp6yiwvPEdU6Uw=; b=SmgHrNdp6aECngpBf0wvcGfrDoL3kC8i4jTkr6lltZWnod83vBtkzAZ3JhCM70ktN7BC75tB4ZOsAkaufECWkeEJ7yQj8GD+mD/EPEGo0G3/PAydXJcatf0YA1ynRDOKhUTlVmWJr+r/oUN5UVjD5uNRS6kp0vYESWaYqsoKQkU= Date: Wed, 2 Mar 2022 16:46:56 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich CC: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , Volodymyr Babchuk , Subject: Re: [PATCH] livepatch: set -f{function,data}-sections compiler option Message-ID: References: <20220302134425.38465-1-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: LO4P265CA0073.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2bd::6) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: aaaafc78-43fd-422b-b748-08d9fc63e4b8 X-MS-TrafficTypeDiagnostic: SN6PR03MB4032:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2vJa8OynzevG/AMoJx9f8PbTrsjiy77X07V7n7wt3nXQL3IlgXq7Fg/883K/Q5WPKinqFoICVXfzhMWKxoF0Pu7WZObedvZ+FoJeOo3F9BSH941I3c5MQJd3wBrbtwrIfTw6TYQ6bM4fQdx3TTBnPUThsQAqkuhWBEakbJj72v27XYi3mXN/NrGMOGK/yI+gT+AgQonT30X97PDF+t51EOyQChi/JzJL5iWIrZitYKysSnKKugrEOxBKmIABNVSsaWvyiJ/Kx9qBeeZVGJoGCg6cIEPljJCh4KWRjECB2ZdmfVhC4MMDkM8YrYkDtY0YWx/fB4dehMTXGzXtnon8sGdfoXUE6iijggmwfYENWbYE0/nKZBWAM6LwVT8/aZ9fyT7Qt4KYy+7Uw4CJN8dkqXa6eHegPHXMiszINf7r+C76WPxdgmizF51YsKKjB2tpktcJYOOI9Cmu3oIGhbyihh5gGhbWxN0V4nDzkjCxMRlfT2DUbn2XwC5cEMkApN0wFoPcCfFtJPH4xf7rV2vg77PfhlmtdES0k/dWe2No/tjJILIENZrjkZ+vdhhLzOEYKQj8ZgkUhSuBjEhPwQZQgbJSSL5lhms5wfs6QBeI0rkIqLo6TguwNvAVNTh6NysLgVcwtBzpbwWNdjJAcS1UDA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(8676002)(66476007)(5660300002)(2906002)(66946007)(66556008)(8936002)(26005)(186003)(85182001)(83380400001)(6486002)(508600001)(6916009)(54906003)(6512007)(9686003)(82960400001)(33716001)(53546011)(38100700002)(4326008)(86362001)(6666004)(316002)(6506007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WnE0SHJZc1NxWjhLRXowT3NEdzVOZ1k0bmZ6TmwrYVZJUjhxeDB6S0h4Rm5i?= =?utf-8?B?anZCWWxEKzNyLzFwYWgvZ0MzaUwyallwN21vcFBFSy91ZEx4TVBsSm9CWlhw?= =?utf-8?B?dEZXa2MvSWVaUHV3Q04xaE1MeitmTW5ZWE1DR3RtaGVsS2Z1dlB0aEZKQ1kz?= =?utf-8?B?ZDdEQnpkaUxVUFh6VHBoT0dPdUhrdmZqUndjcHloNnhzMndNSXhzRWdzWkQ5?= =?utf-8?B?K3ZPWjZLdVpENFROeUY3L3A5emxpMHBTQVJ2c2pNeGZ2VGtKLzJvTi9qOExD?= =?utf-8?B?THhUREZWckUrc1huRDJvQU9ZK2xyUUJqdHAwK2VxaVdocjVOU3VSRngrSnlR?= =?utf-8?B?M3FXVWI4SjFPNXFRN3R0ZkE4eStrdWxWL0NDNUMycE8wZDc4a0RkUU1pS1Vl?= =?utf-8?B?czRPK24rcFhLY2pwVVFxSU0zRGgxR3dZMHU1TkdQcHJsVisrR0ttSE1EYjJz?= =?utf-8?B?TFhCeEJZaENHTy93ZzIwNlhWeFMrNmpEY1JsNS8yUVg0VnpDVmhjTXhaOGIx?= =?utf-8?B?VHhSSEduMzA2NTdBMm5CYmpoT1hNbjVQdnMyc0t4d1lEeGRmK1ltaWdob2VS?= =?utf-8?B?WTVDTXpZZTdIMGRyNTVETFgvWnJJQWRONE9LaUlUdFRsYUtQbXpuREVGa2F2?= =?utf-8?B?RWlxejlKR2FOdTREYkdHc0d2cENzOENIOE5uZFFpdEFWQlZ3WjN0U0EwRlZt?= =?utf-8?B?OUlYZitMNDZCdWNSR1JET1lEaTFGb1A4cDR5ZzdxV1IrZzg2UTYzQlM4Q1Mx?= =?utf-8?B?ZmlFektocU8wRFVmQlpsZXNOVkVLT21ZUWZldmMxcHRUZml5RTdWUUVEYTN5?= =?utf-8?B?cEtPOENpNCtMOVd0bEgwZDBMTWhKK3g1dHVSSE5zWXdXTFpsS3hONVRreG0y?= =?utf-8?B?NjVCTE14RkU1MmJHd0x6NDdHeHRUMUFQeTJLMlpacmdrSmxvSUt1YVlwSzNK?= =?utf-8?B?RzZuU25JRFRycjdCS2J2QWd0M21RaTBTV2k1WG5PcU9GUmpKd0RQclpoVXl6?= =?utf-8?B?S3BrTWNROERrWE1TYnN2RCtlMkRaODQyUXlLY2FUR2RYQUJEU2pyT2RTUWc0?= =?utf-8?B?R1FGaENQblN1Z0JjOVFaa2FHYjZnUXJHTGdpVjFKR0k3YitRem8vOXdrcVA4?= =?utf-8?B?NEI0WDNRVXVtcGE5TXlZRzl0SHBEQ21adDJUM2pVdTJXeDJwMHY4R1Z0WEtX?= =?utf-8?B?LzJPTFZYZUlpNWphcUkrVmRHYkVkZnMxc2daTVd3NmMyMndxNXRoWENRVmJ6?= =?utf-8?B?R2dNSFdqOWFvd1lOWGcvLzVYRGZXSVQrTHZSdkpwLzJ4QkNYUEs0Yzc5Q3V3?= =?utf-8?B?czdFNGVmV1JPaHdSd1BNQnlZRTRkaVZ1RFVDYS8yekwwbVdReUtYSWs3ZnNR?= =?utf-8?B?ZXFzU0pXR2dhSGhHRHRKbHFPVUd1QlQ4cm4rYnV0eVZRdWM2TG81a1dTSDM0?= =?utf-8?B?aURjTzBKTEpLQ08vd2N5ZGJlakxhQjAzOUxVQWtINGo1SDdHWlRpRDVyWXdT?= =?utf-8?B?QU5UR3NNU1VZbVY1Wklzc2I5SEx4S3I5dUt6QU1WSE9HaDFiRWJMN204MlJn?= =?utf-8?B?VzFoeWlnLzhPTFN1UVg3Q1Bmb1p1QmhDdmlpbjl4cy9aNFJzTmpUNVZpVzhF?= =?utf-8?B?cndJQlBrVmpad1ZFdEtVbHdQRXVPKy95V0xZeU5WSmx6UkJWdkVTeHJpV1dT?= =?utf-8?B?TGFvVmlVU0hkRnZUZndVQTBiTkM5RlBYRlBwWGRyUzBJZzdhS3NVUU9iVG4y?= =?utf-8?B?NmJoQUQ3ODFDMmw0Tkxrek5PSVVBNkJSOUdWdTJGU1JIK1dZQ1pBZnMxa2tt?= =?utf-8?B?cjQrMzFuWitObHBXbHlSZVNNaml1bmc3R28xZEpqSVU1enBVa3VOUzRGUW9D?= =?utf-8?B?bHdzMjFqc2NyOWhRb3JObnljNFRZWTJ3Q0crNjczV1ZjWUlrRExFUGg1dmgx?= =?utf-8?B?Q2tDRGhOcHM3QjRoa201YkgxbDl0OXZYMFJvNU5QVXdORE5BcUlnQ2ZjbGVO?= =?utf-8?B?Rnl3bjJoUG54Q2ppakh2WTdxc3Q5OGs0OUlGQkJsZ2RGcTNYRTZMZHpPY29D?= =?utf-8?B?Rlhqd1JHaGV6aUFkbHBHUG11VVdBVzZwUmZua1dHVzFQZk1LUFlObWp3N3dw?= =?utf-8?B?WTlKeXNWYjJ2aGZmd0hjeHBjYU44YlVadjlBaU90eDJuWCt3UmZtcnA1TFdM?= =?utf-8?Q?8Qr9cVz1T5rYWRs87ip/DsE=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: aaaafc78-43fd-422b-b748-08d9fc63e4b8 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2022 15:47:02.0158 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gdDqZvfxT1jZBKV4kSNl2E0/ZO4Qseb3ooAEAcXsGRORoVGlv/Uia6Ard8RMOIWhWLt/wX9Vl4GjyDzDeV0rUQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR03MB4032 X-OriginatorOrg: citrix.com On Wed, Mar 02, 2022 at 03:41:21PM +0100, Jan Beulich wrote: > On 02.03.2022 14:44, Roger Pau Monne wrote: > > If livepatching support is enabled build the hypervisor with > > -f{function,data}-sections compiler options, which is required by the > > livepatching tools to detect changes and create livepatches. > > > > This shouldn't result in any functional change on the hypervisor > > binary image, but does however require some changes in the linker > > script in order to handle that each function and data item will now be > > placed into its own section in object files. As a result add catch-all > > for .text, .data and .bss in order to merge each individual item > > section into the final image. > > > > The main difference will be that .text.startup will end up being part > > of .text rather than .init, and thus won't be freed. Such section only > > seems to appear when using -Os, which not the default for debug or > > production binaries. > > That's too optimistic a statement imo. I've observed it appear with -Os, > but looking at gcc's gcc/varasm.c:default_function_section() there's > ample room for this appearing for other reasons. Also you don't mention > .text.exit, which will no longer be discarded. > > > --- a/xen/Makefile > > +++ b/xen/Makefile > > @@ -269,6 +269,10 @@ else > > CFLAGS += -fomit-frame-pointer > > endif > > > > +ifeq ($(CONFIG_LIVEPATCH),y) > > +CFLAGS += -ffunction-sections -fdata-sections > > +endif > > Perhaps > > CFLAGS-$(CONFIG_LIVEPATCH) += -ffunction-sections -fdata-sections > > ? Sure. > > --- a/xen/arch/x86/xen.lds.S > > +++ b/xen/arch/x86/xen.lds.S > > @@ -88,6 +88,9 @@ SECTIONS > > > > *(.text.cold) > > *(.text.unlikely) > > +#ifdef CONFIG_LIVEPATCH > > + *(.text.*) > > +#endif > > This coming after the "cold" and "unlikely" special sections and > ahead of .fixup isn't very nice. Also from looking at the linker > scripts ld supplies I'm getting the impression that there could/ > would then also be e.g. .text.cold.* and .text.unlikely.* which > you'd want to separate. > > We may want to put the entry point in a special .text.head, put > that first, and then follow ld in putting cold/unlikely stuff ahead > of main .text. I can give that a try. > For the reason given in the description I can see why a conditional > is warranted here. But ... > > > @@ -292,6 +295,9 @@ SECTIONS > > *(.data) > > *(.data.rel) > > *(.data.rel.*) > > +#ifdef CONFIG_LIVEPATCH > > + *(.data.*) > > +#endif > > CONSTRUCTORS > > } PHDR(text) > > > > @@ -308,6 +314,9 @@ SECTIONS > > . = ALIGN(SMP_CACHE_BYTES); > > __per_cpu_data_end = .; > > *(.bss) > > +#ifdef CONFIG_LIVEPATCH > > + *(.bss.*) > > +#endif > > ... are these two really in need of being conditional? Will drop if you agree. I didn't want to risk introducing unwanted changes in the !CONFIG_LIVEPATCH case. > > --- a/xen/common/Kconfig > > +++ b/xen/common/Kconfig > > @@ -353,7 +353,9 @@ config CRYPTO > > config LIVEPATCH > > bool "Live patching support" > > default X86 > > - depends on "$(XEN_HAS_BUILD_ID)" = "y" > > + depends on "$(XEN_HAS_BUILD_ID)" = "y" && \ > > + $(cc-option,-ffunction-sections) && \ > > + $(cc-option,-fdata-sections) > > Is this for certain Clang versions? Gcc has been supporting this in > 4.1.x already (didn't check when it was introduced). I've checked clang and it seems to be prevent in at least Clang 5, which is likely enough? I've added the check just to be on the safe side. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed Mar 02 15:48:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 15:48:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282391.481088 (Exim 4.92) (envelope-from ) id 1nPRD2-0001z6-8u; Wed, 02 Mar 2022 15:48:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282391.481088; Wed, 02 Mar 2022 15:48:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPRD2-0001y6-5W; Wed, 02 Mar 2022 15:48:12 +0000 Received: by outflank-mailman (input) for mailman id 282391; Wed, 02 Mar 2022 15:48:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPRD1-0001xf-Qj; Wed, 02 Mar 2022 15:48:11 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPRD1-0002vB-Mn; Wed, 02 Mar 2022 15:48:11 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPRD1-000704-4l; Wed, 02 Mar 2022 15:48:11 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nPRD1-0001LL-4L; Wed, 02 Mar 2022 15:48:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=mZb0C0Yzcc6M4DD7GPLHhcSUVwbiBgGU9Qrq8NJMZGU=; b=woPvMkMMbHYMp1NJuKsRtypIIH j19vYQfrREoO3QtnqdQ7zwrRWz15pOGq7K9X6ifXKVMCOyzkUMjDVLeW8zoOREYJyLKgHuj/2d/r8 wDosQFsdMAxbfLxUIXd3woKLSV+M2yLKNyF2ZSj4Zcxyx4DvnMCEB1k3JE3+Q2X3XeIs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 168326: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-freebsd11-amd64:guest-start/freebsd.repeat:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=fb184c4af9b9f4563e7a126219389986a71d5b5b X-Osstest-Versions-That: linux=575115360652e9920cc56a028a286ebe9bf82694 From: osstest service owner Date: Wed, 02 Mar 2022 15:48:11 +0000 flight 168326 linux-linus real [real] flight 168338 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/168326/ http://logs.test-lab.xenproject.org/osstest/logs/168338/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-freebsd11-amd64 21 guest-start/freebsd.repeat fail pass in 168338-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 168306 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 168306 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 168306 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 168306 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 168306 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 168306 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 168306 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168306 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: linux fb184c4af9b9f4563e7a126219389986a71d5b5b baseline version: linux 575115360652e9920cc56a028a286ebe9bf82694 Last test of basis 168306 2022-03-01 20:09:49 Z 0 days Testing same since 168326 2022-03-02 06:22:48 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Lai Jiangshan Linus Torvalds Marc Zyngier Mark Brown Oliver Upton Paolo Bonzini Ricardo Koller Sean Christopherson jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 575115360652..fb184c4af9b9 fb184c4af9b9f4563e7a126219389986a71d5b5b -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Wed Mar 02 15:51:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 15:51:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282404.481098 (Exim 4.92) (envelope-from ) id 1nPRGO-0003TF-UY; Wed, 02 Mar 2022 15:51:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282404.481098; Wed, 02 Mar 2022 15:51:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPRGO-0003T8-RP; Wed, 02 Mar 2022 15:51:40 +0000 Received: by outflank-mailman (input) for mailman id 282404; Wed, 02 Mar 2022 15:51:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPRGN-0003T1-81 for xen-devel@lists.xenproject.org; Wed, 02 Mar 2022 15:51:39 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a3fed988-9a40-11ec-8539-5f4723681683; Wed, 02 Mar 2022 16:51:37 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a3fed988-9a40-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1646236297; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=/YOCe5K3tQIXUPWQ1qMihfC3Au6yPpUOdn+IZy8nftQ=; b=Zw/7aCffPIgEJuEDyhMvdF8JtqDNtpw9vx9S305YbdZolF+MFFIJVx6p UwSjmpElC3ejQJpqkwyeRgog0JONAo/SXoF7Xi34mGWecGeYstDW0np8M CYkOFetRCRDHcyrjFIbhElF6BhdDptGbiUMKdffYvG5sAOoZ17jT8F8uy g=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com X-SBRS: 5.1 X-MesageID: 64772009 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:CdZL5qKna0rAAFe0FE+R+pUlxSXFcZb7ZxGr2PjKsXjdYENS0GEBn 2NLDDvUbKuONDemf4gjOdjkoU1UsZ+BztBmHQNlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA148IMsdoUg7wbRh2dYy2YPR7z6l4 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4 Md0vrC9VSw7Bb3Nl9sESCt/PgNAPJQTrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq 6ZecmpUKEne2aTmm9pXScE17ignBNPsM44F/Glp0BnSDOo8QICFSKLPjTNd9Gls2Z8URa6PD yYfQSEzYAyHIABpBmg8N80R3/vxg1/kaTIN/Tp5ooJoujOOnWSdyoPFM93TYNWGA9pUmkWwo XjP9GD0RBodMbS3yyeB83+qrv/Cm2X8Qo16PLG/+/RnhHWaw2UBDxtQWVbTiem0jAuyVsxSL 2QQ+zEytu4i+UqzVN7/Uhak5nmesXYht8F4SrNgrlvXk+yNvljfVjNsoiN9hMIOpvY9aTE2/ U2yj9LmOiV0gpq4a0ycz+LBxd+tAhQ9IWgHbC4CaAIK5dj/vY0+5i7yosZf/L2d1YOsR2ypq 9yehG1n3uhI05ZXv0mu1Q2f21qRSo71ohnZD+k9dkas9UtHaYGsfOREAnCLvK8bfO51orRs1 UXoevRyDshTVflhdwTXGY3h+Y1FAd7falUwZnY1QvEcG8yFoSLLQGypyGgWyL1VGsgFYyT1R 0TYpBlc4pReVFPzM/MpOtzpU5V0lPm6fTgAahwyRoAUCnSWXFXalByCmGbKhzy9+KTSuftX1 WinnTaEUi9BVPUPIMueTOYBy747rh3SNkuILa0XOy+PiOLEDFbMEO9tGALXMogRsfPVyC2Io o03H5bblH1ivBjWP3C/HXg7dgtRcxDWxPne9qRqSwJ0ClE+STF5VqSImutJlk4Mt/09q9okN 0qVAydw4FH+mWfGOUONbHViY6noRpFxsTQwOilEALpi8yVLjVqHhEvHS6YKQA== IronPort-HdrOrdr: A9a23:yh+3Fav2Fve8YyUn2nYyJQUC7skDWNV00zEX/kB9WHVpm5Sj5q STdYcgpHjJYVcqKQsdcL+7WJVoLUmwyXcx2/h1AV7AZniahILLFvAA0WKK+VSJcEfDH6xmpM VdmsNFZ+EYeGIasS+M2meF+rgbrOVvu5rY49s2h00dND2Dfclbnn9E4yigYzZLeDU= X-IronPort-AV: E=Sophos;i="5.90,149,1643691600"; d="scan'208";a="64772009" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M6xHYHx/g3ewSPetgZBV9FMuMwvaSUG8PON+ltxmPypusIeiq+fly8gkKYT2YUur5R/4GoSLj5gCTCDT4S4oL0YGOj8Qcy+8FZothtnLRc8I2ZH/7GZiWk2AHwQ0K53Gf1q6gVj1WzGTDKunnijta7jWi8fiQNcEfnsb8j2YWy3uHUvSzHY2Ex+yBtOVd4qDsKMB4DyHkbJjKfAaJdKheu+e3G7fKAEhXPsTqLo5OLG6jMmS2juBl95nsEupWbTWYH3y2eQa9ye1e96VSkME2ArbMd6/Md4aIBTKttZ0QeTxh5Tu6ccWg1bOmvTJv2uv469sb6681+NwzEJbEZO36w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tp7BP6YDX7sYiHsbnawkPE+zGuVmcllsQOjveyqMa0o=; b=OvIfXr7ckNPIByUqtrqveMg/UUOezTSE/2CmCzHr1WPshxC6g32uXANl8GidgFQhNo9Snn180IDTfpTyc1zCgCeQAjk+3CutRTDE8Jn/y/21okobe0NtGDPq0S7ayd/ScNYpi9KYctqF/P4Ompxgb4Ti5Zay1JqMp8kopUkqDeo90BDk2ofo+z9coJCBLpPyTEMAMNTrlGhJaiy+IMH2aq/1ZlHzjvsNrDTf5h9ae2XfiSYiWbxlrNS9y7uSVF614q7d8vpLfZeREdpYpEvvK3UhXfYXzxxL2YM9+osmO//4xLd8P/t3mLbjCQQx7iv+Hb27cTFfsSuhDSsR5sfPRQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tp7BP6YDX7sYiHsbnawkPE+zGuVmcllsQOjveyqMa0o=; b=QPuRQoiGwtIBV1ItBzusaCifrBFVUda5RfWnD4g1T2fAA5S1CkLjxYKx5RhcBjAOgfWeFEWObqrF5Na7vGuBTBAGQe5WtuV1vOuoF2Hn0Ld0fHBasST1aA7tbku715YfKtQFUiT3aQXZHFidy1NlEwet45uodiaOtnBgmrHRpfo= Date: Wed, 2 Mar 2022 16:51:29 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: "Doebel, Bjoern" CC: , , , , Subject: Re: [PATCH 4/4] livepatch: differentiate between old and new build systems Message-ID: References: <20220302142711.38953-1-roger.pau@citrix.com> <20220302142711.38953-5-roger.pau@citrix.com> <459241b5-d412-d2e3-0f23-6094db87535a@amazon.de> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <459241b5-d412-d2e3-0f23-6094db87535a@amazon.de> X-ClientProxiedBy: LO4P123CA0311.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:197::10) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4af408f1-ac5f-49f0-7c88-08d9fc648655 X-MS-TrafficTypeDiagnostic: SA1PR03MB6451:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wW6nBEZIjwUf0ZGua8N10ehIVXWgb/yuXYhOdJcSWhkT0HhlT1HV62dTBZWIjJbHjMRI4Uxz/I6cpDA8lPV8uk43zptVXw6IcRoYgBbkQe9aQBmjZZqp8LKSzixPeZ7R0EwvPccMpTjnNQr7vMorLu/zpZjibgbewqX84In9vLEKLPviIJw41CqFQLw/WvvVJOcrfYjwqiJfGJQ5C4H4jieyhlpaIM5spNnsV/RuKvPZLJzgcIYmFEXW1BHa9OGyTtnNYgFI/qGoTGzDMbh9KFVgwXdp26deVZA0jLe9VX5nMRwdhI7wDZOjsRkALx67KNFSFcqFMCuF8X/ZgRS38PHeB16aBEKUvGr22QZJYwyxG0+wk931stAYRoqG5g0MYNB5ApJ2JG+R+dVnOmJYdI6Z5UCvHT1FVUmmRR1biUtFGE72Kiw/jQN7+VROFsDGticI7tELBUonQORtVf+cxMmgb3Ug9f/On2p6dSZhbwO7vKF3dvqJWONgymXZgKMTw9S2bGqz2QVxEEXvrCS7ZHyRR/HOS6XkDDPwDcxVik5YQecWHxU/9nOHaHu5HfCraqoWVFW1CDB6irGw5wc33ZxCeJ1rWLMLH2hZNi2HA8ZKHXwFjqOocNEmMSXzAqYHswgwB7EFRIdMBUOcBwPFf8BfngVQ1AR9zT9eUDDZ5hORschkqRTNOQN0SxPJfGNkSdVmVv8khKY1tg5mqsMiVA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(82960400001)(6506007)(6666004)(53546011)(186003)(26005)(107886003)(83380400001)(9686003)(6512007)(33716001)(85182001)(86362001)(66476007)(66946007)(66556008)(8936002)(8676002)(4326008)(5660300002)(38100700002)(316002)(6916009)(2906002)(6486002)(508600001)(67856001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QXJoOWJqNHo3R3dPb2cwbm9wcS9rUE10TGU2UmtoY2pJY0paZ1lRVCt1c0Vw?= =?utf-8?B?bGlUTWdLMTJEWWtZZjZoc2dFUU5jYmMyQjZVZCtZS1kxYVVSaEFYYytHSEtU?= =?utf-8?B?aVh0cTZTTENOL3VCTzhOVWRDVDN4VzJRSHN5NEEyMUlXTHZQbjltckphZjQ4?= =?utf-8?B?QUc4TDhobGVIZ0YrTXdJSGl6ZFZuRVlQTXl6L2hvblUxZUFDdkxDcE1YamND?= =?utf-8?B?WnpCbHlMbDQ2YXdRY3pkMllMZ0tkMHdkM2d3VWN4dFd4R0U1MkJJOWZWY09S?= =?utf-8?B?M3pwbm5rNTBaQzdvVDhJVXljVHBZVTd2QTdFeHMyaTBNSGxpaklrMXFrKzQ1?= =?utf-8?B?VzE1VG1VUUxTY2d0UW1NMkMrMDVGZDZmSkxUZm1jQnVzeEVvQlBOUTJpQ0k1?= =?utf-8?B?TGptVlg3aWxvSG0rdWdSMkhPRHdzeHVya2ozS2hOMlZEWmRZb1o5Y2RTVVdK?= =?utf-8?B?MmlXdWFSTzhCamdxVU1TVSswalc1VllpdXFCVlh4K05hSWFaWTBITW5XU2Zr?= =?utf-8?B?RHBMTTVmY3htc2l5WUVpVjluWGNRM0Z1WjRYbVF6Qnc3SVlNdFhLRDFubStz?= =?utf-8?B?Sk14YVpweXc1Y2dkUUdIQ3NYY3JXMFBzcVBrS3lnVnpsS3ZwTEpxdVYrdVo1?= =?utf-8?B?ckx0dU4wUFpzMHREN2ZVNkFFUFZOMDNBZk5jcERyQ1RraW1EUEpEeTF2eHVP?= =?utf-8?B?ajZGNkJkTzY0ZVFmVTVVRmEwY2VyVTdSbnV5K1B4RTBlYStrQU04YklmUEFo?= =?utf-8?B?cGFYTXlMVTRCSS9VMFdRUmw2UU56bTRMaUNLOWR4dk5DL1NtL2VjaFVTdXF5?= =?utf-8?B?U1N2ZWdyR3daQlVhK25yMVozSWRxb3ZFSFNEWDJLWGxMOTl4bG9lYWljNVBw?= =?utf-8?B?QnA5bXMzVkYrUkFkdUl2YWxPci93TFl0R3hoNFZHLzhrQVhFVGUxZ1B3ZXZZ?= =?utf-8?B?b3pPNmJsSllRMW1IQzd5d3ZHcnYxSTRudm96M2hmMVkwcmpWYzI0RGF0TzUy?= =?utf-8?B?VlYvUXEzL0VabjlzMmZvUURod0ZrRnZRelo4NDEzWXVMRld3TGZ6RHViUXBu?= =?utf-8?B?ZG1LUVkzZ1p6RTQ2QmxtOWMxU252b2o2RWJIeElGalNseUtxUmQyS1FLRzdo?= =?utf-8?B?WUNBczdJWG9DaTVMNDlRU0dNNlo5RG02WTdRTGxBbEJMQ0hLRXR0MG5Ycld6?= =?utf-8?B?Q01kMkg3OXlKNDExN2FtK3UyeHFBZUtoeXNWTVNRMGIzckdWamhwN1RMeE5V?= =?utf-8?B?cEE2U2kvckNhOGttVktHK2Q2RnpXNDRIaU82bllCQnBvT1hKYnhud2FLMWJp?= =?utf-8?B?NW5tS2Rxb25lUlEvb1ZUcGZGckUrZUIwNUpIcEdTVkJXRnYvOFcyNjZNUEdq?= =?utf-8?B?bTdzRDhrUzYxb3NPbDZGSmVDRW02Rkt6T2NzZlRDamk3QmtFdDRxR29MVm5O?= =?utf-8?B?M1hHOWY2UXVid25qdU9vcERSNUtlWGh6N1BpZlczUVhOMU1UNmZPVC9tVTUv?= =?utf-8?B?Z2prejBZRGFMNXBTbnBmL05qRUhuQzR4dUlnVVdNeDRtcTZ5L0lhZDNrNWtC?= =?utf-8?B?ejBzNnpaMHhnVUFoRDZDb05USmVRWE51Mmk4L3pGWmdTM3luRnFaYTVCRjF6?= =?utf-8?B?dTYzTVZXcFdFK2M5a05VcldTTmxWelRxMHN5d1pVM1N4OFhUUWlDTHJoUi9B?= =?utf-8?B?eld5ZlZKcXhsenAvRVIrejZEUk9HbHNjRWRqQjNuMlIzM1JnS2t0aXdKeVp5?= =?utf-8?B?ZG5qOFlOczUxZm8rWmtOZWlaVWI2VkhxcUY5Ulc4VFhGN2tIREdvZHVsYlNL?= =?utf-8?B?YnlTbm5rSDZ1Y29XYXAzOURaaFhlb3JYWkdWc2g0Z3F1RDl3QVJqWmlab3NQ?= =?utf-8?B?T0x0bFM1NGp1T0NkNUpXS3YveTZsUDBvYUx3SnhacXIxVHNWMjJiMEhKRStT?= =?utf-8?B?Q1Q5elA3QVZvNHNMc3RXN3N0WWV4QnhRRmx6bmJYQ0owd3NpQkRienRSWk0w?= =?utf-8?B?R1VBVTBVOXhRc2JIc0IwcEVsL1lCamdFVXVwcVYzVTc2UDZhT0lLdHp0WjV4?= =?utf-8?B?cU1kZ3E2WlRiQjdWaG9RZ0EwZk5yakVSRFc3Nk9MQWpCN25pcVBQQzZ0c0Mz?= =?utf-8?B?Z3pJZ3p1Vk9DdWJmd2pZV2pwVXhZc0dIQWVXbDQ0anhWQWtyVVVaYjJtZzlV?= =?utf-8?Q?y0feLbD2FEo8yDGM0ymp1fg=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 4af408f1-ac5f-49f0-7c88-08d9fc648655 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2022 15:51:33.2501 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: latmaGpQ2V01dB+qWsXKBi0StrcArP0Lmc8rb2RTblbUwVICkmwMtKehN9zHeTiCYNXjmhDA7eEfk2ALX7h69A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR03MB6451 X-OriginatorOrg: citrix.com On Wed, Mar 02, 2022 at 04:41:36PM +0100, Doebel, Bjoern wrote: > On 02.03.22 15:27, Roger Pau Monne wrote: > > CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. > > > > > > > > Do not attempt to modify the build system if CFLAGS are not set in > > Rules.mk, and instead rely on CONFIG_LIVEPATCH already setting > > -f{function,data}-sections. > > > > Signed-off-by: Roger Pau Monné > > --- > > This depends on getting the patch to add -f{function,data}-sections > > when using CONFIG_LIVEPATCH accepted. > > --- > > livepatch-build | 22 ++++++++++++++-------- > > 1 file changed, 14 insertions(+), 8 deletions(-) > > > > diff --git a/livepatch-build b/livepatch-build > > index 38a92be..656cdac 100755 > > --- a/livepatch-build > > +++ b/livepatch-build > > @@ -98,14 +98,20 @@ function build_special() > > > > # Build with special GCC flags > > cd "${SRCDIR}/xen" || die > > - sed -i 's/CFLAGS += -nostdinc/CFLAGS += -nostdinc -ffunction-sections -fdata-sections/' Rules.mk > > - cp -p arch/x86/Makefile arch/x86/Makefile.bak > > - sed -i 's/--section-alignment=0x200000/--section-alignment=0x1000/' arch/x86/Makefile > > - # Restore timestamps to prevent spurious rebuilding > > - touch --reference=arch/x86/Makefile.bak arch/x86/Makefile > > - make "-j$CPUS" $XEN_DEBUG &> "${OUTPUT}/build_${name}_compile.log" || die > > - sed -i 's/CFLAGS += -nostdinc -ffunction-sections -fdata-sections/CFLAGS += -nostdinc/' Rules.mk > > - mv -f arch/x86/Makefile.bak arch/x86/Makefile > > + if grep -q 'nostdinc' Rules.mk; then > > This means we are still breaking livepatch builds for all Xen versions > between your recent patch and the original patch that moved CFLAGS to > xen/Makefile (commit 2740d96efdd3009f8adb40aacdbcf05cfe8d1bbb, Fri Apr 24 > 14:57:10 2020 +0200). > > Is this acceptable? (I mean, no one seems to have noticed...) I've also wondered. I think a reasonable approach would be for interested parties (ie: using livepatch) to backport the commit that sets -f{function,data}-sections in their Xen build for that broken window. I think we could also consider it as a candidate for backport to stable branches, but that won't fix versions we have already shipped. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed Mar 02 15:56:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 15:56:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282412.481110 (Exim 4.92) (envelope-from ) id 1nPRKc-000474-HP; Wed, 02 Mar 2022 15:56:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282412.481110; Wed, 02 Mar 2022 15:56:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPRKc-00046x-Co; Wed, 02 Mar 2022 15:56:02 +0000 Received: by outflank-mailman (input) for mailman id 282412; Wed, 02 Mar 2022 15:56:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPRKb-00046r-8k for xen-devel@lists.xenproject.org; Wed, 02 Mar 2022 15:56:01 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4008e297-9a41-11ec-8eba-a37418f5ba1a; Wed, 02 Mar 2022 16:55:59 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4008e297-9a41-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1646236559; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=Gm3wwbiISZCoda9GpT6wD0gAiqyct7+qGSdyQx3eVUg=; b=RQFEJFVofQRFlVYVF2xB7lwGQ4l9ZcSE7TwZzZRJiDsjCQYN6yYi0AvK GnsC7vfowaQnnKPp/bgBb35GJE5NUUNwvKp3ZdjYw8fBbM/siKqwqt5gE oYubYZgpdunFCxO1OCjyq0O0Pjtmx5+aUdG9OTBNxMqkwuVVbJLRBqcbQ I=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com X-SBRS: 5.1 X-MesageID: 65722028 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:J49Ftak+o6RZWqQ31iZ468Do5gy3JkRdPkR7XQ2eYbSJt1+Wr1Gzt xIeW2jSOayPYjHzfIhzb4Sw8R9Qu8PXnYRhTFQ4qCozESMWpZLJC+rCIxarNUt+DCFioGGLT Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EoLd9IR2NYy24DiW1nV4 rsenuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ NtxWZOYaCYyJerT3+4nWUcHCgtdDKRL/4bpCC3q2SCT5xWun3rExvxvCAc9PJEC+/YxCmZLn RAaAGlTNFbZ3bvwme/lDLk37iggBJCD0Ic3k3ds1zzGS90hRojOWf7i7t5ExjYgwMtJGJ4yY uJHNGU1NkyaM3WjPH9GF5sVgLulj0Cvah17qVW1lfRovTTqmVkZPL/Fb4OOJ43iqd9utkWfo HjP8yLmAxUZHNuFwDGB/zSngeqntSHmXIMfEpWo+/gsh0ecrkQfDxAcWF+TqPywmEm4Hd5SQ 2QE9yxroaUs+UiDStjmQwb+sHOCpgQbWddbD6s98g7l90bPy1/HXC5eFGcHMYF48p9tLdA36 rOXt/LIHicor/qfc3jDqa6+jgK7NC8sA0ZXMEfoUjA5y9XkpYgyiDfGQdBiDLO5g7XJJN3g/ 9yZhHNg3utO1Kbnw43+pAma2Gz0+vAlWyZovl2/Y46z0u9uiGdJjaSM4EOT0/tPJZ3xorKp7 CldwJj2AAzj4PiweM2xrAclQenBCxWtamS0bbtT838JrW7FF5mLJ9043d2GDB01WvvogBewC KMphStf5YVIIFyhZrJtboS6BqwClPa8S427DqiFMIMfOPCdkTNrGgk0PyZ8OEi3zSARfVwXY 8/HIa5A815AYUiY8NZGb7hEiuJ6rszP7WjSWYr633yaPUm2PxaopUM+GALWNIgRtfrcyC2Mq oo3H5bamn13DbylCgGKoNF7ELz/BSVibXwAg5cMLbDrz8sPMDxJNsI9Npt6I901x/kOz7yQl px/M2cBoGfCabT8AVziQlhoaa/1XIY5qnQ+PCc2Ok2v1WRlaoGqhJrzvbNtFVX73ISPFcJJc sQ= IronPort-HdrOrdr: A9a23:VtZ3SahU3BvWWBsbYOZL4QAmcHBQXt4ji2hC6mlwRA09TyX+rb HIoB17726RtN91YhodcL+7VJVoLUmyyXcX2+ks1NWZMjUO0VHAROsO0WKI+VzdMhy72ulB1b pxN4hSYeeAaGSSVPyKgzVQxexQouW6zA== X-IronPort-AV: E=Sophos;i="5.90,149,1643691600"; d="scan'208";a="65722028" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QzxeH899AWirUGWS7X1tM+Krki4chAzLD9DGKACu/jkgU19aMeIQyt8qixU4yzd2wVEFmvACAY/fhYz9SSqX4a9jJZyVHjaibn52O3iz8iseW09H5A5tEg4mtnA2eD5RxBA1Jc0pGbyWAX2VK6sQqfNYEN1GWQbIk9aGzbaPr/sx5M5H3Y1wOaiU59rps9zaAekXkb7efQ3RDmIgV6+mEtm2oIgwnqH7hER5Kp3T7dG/J68lKkl7ZyvYyxrac74UpiTmWtsa9Mx3F7bojWsNGJryDnhtUks7rhsDk+7R3tqhzjz8h1hA6iq2SzBYdgZ/RxBVWgMH6Gek7/XMuMezLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Gm3wwbiISZCoda9GpT6wD0gAiqyct7+qGSdyQx3eVUg=; b=P/YTuCX8I5CvBJt1fV1lNs/eT9Z8e7FU03+TPMdVlcgfYSezFnNrh/ixOI58qSmqS0j4Jn/r7Vk+Vbx81ycdcWyP+PHrsGM1wYKG8muSY/qYg3ZkRvob4aDLdiHQvxcKpO8hqMvUPPtkhwL3eGsMHzqVfm8vLfTgu9kqRxlVSv8IUXVpw/8GGZg1Yp9WaJ3c1zXCs6Ww2EA47lSOvp1d/3lOl5PnYu6hrmne81Wx3ClXRjTJ0On5JY+ALmJgFbCbxJaSi2ySES0h6sq8PdNoXnym3WR5iC+N1wzlK/dCBNGTLQ+3sjMqUTGLTV+mpBeeAb3RQONRUR12lSdS5q1sjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Gm3wwbiISZCoda9GpT6wD0gAiqyct7+qGSdyQx3eVUg=; b=aEqI+IypFQW77w7rpdHJKq+Nmk/CclTT+YQBu91oD6NF3n3y4bktzUYx6x4O5M1wm44s2YRIQn8ArruheGivdV3SgYAR2k4oBtdHOhdXZiK5IUVaz3NSYL0VJ07uHwgtJn4i6qW9Cp9WoFbyZHxUMx0iEO0Y/Ua6j2r9irX7agE= From: Andrew Cooper To: "Doebel, Bjoern" , Roger Pau Monne , "xen-devel@lists.xenproject.org" CC: Ross Lagerwall , "konrad.wilk@oracle.com" , "julien@xen.org" Subject: Re: [PATCH 4/4] livepatch: differentiate between old and new build systems Thread-Topic: [PATCH 4/4] livepatch: differentiate between old and new build systems Thread-Index: AQHYLkHgSrb/iAL0mEi291/GjB3zE6ysO3wAgAAD/YA= Date: Wed, 2 Mar 2022 15:55:54 +0000 Message-ID: <437bce05-a3c4-8177-0a58-fb9ead961231@citrix.com> References: <20220302142711.38953-1-roger.pau@citrix.com> <20220302142711.38953-5-roger.pau@citrix.com> <459241b5-d412-d2e3-0f23-6094db87535a@amazon.de> In-Reply-To: <459241b5-d412-d2e3-0f23-6094db87535a@amazon.de> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6b408463-e6a1-4d49-3a9f-08d9fc652214 x-ms-traffictypediagnostic: CY1PR03MB2250:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: gnAe6goX86AGnZgZrAvTNeSzAhGT7dyozkJBmWsJS3Z1G6QaGErYoGSyOPkjE8wZieJTNgdRXPOGeeawZ6AMK0UQOQd/BjEK87t0nOl20+TEUI6YP+LSQ5yJSrKBDGerDCYCgQ+h2GWYgX7g1GOyJt89qR2J4DewrimsVEdB2ItRfcDjPqUQpfbQ2+WaQLU0TmbO0fqwixNLfU4eC7nUFV7NgMTZb3KNuPdnvmNWEcIuZ0jrcTBGZCKsI/jS465qhwUH4UQS69yIho8m50u5oR4irtJvAE2lqfIqV4vy3ke0M0SEZpFB1bN0tWGy5ohu53GGcjTl8WEqLgkUWY45Jb3ZEAnGt6Hh2hzzuhMiFoFQjegiD3dAkzLPd5G19l7EfgY2sGr5tQIIlDR+2CACIfCPBpKCWPM4OnH37+ToIaTIsPHAUZ/OMRcDa7T1j8EJ4r713jb7I4VwdfXgClugO1xLCZIZJ4it/OCThbNXuZkw+1lAjAOfrsFDW+nAIn0QCr3E6kquRwHBgAc6KGAcSyegdAHGa22zWBMkzKQLRg0vIanpjJWBcCZpDuXShjoNqg6WzBjpZDfdew1H62qjmGTN+xHuwYAryZXS/IoVsBYC7GyZj7nfOuiSNNqFC6k9RFsTkzcX/JtaLNIt/izVpRmgy8sCrpfC96afZVxRzrzOumg9bJSY4wYp0Nnbo77QuMBq/Qs2ILT9v4S9gIYryYZ++QOj9sA4bT3Na5H74SCKND0CgnlI2CH6fhzZDKUDfgYKKp7bxKAE5xwDRTlehg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(86362001)(36756003)(2616005)(71200400001)(6512007)(31696002)(4326008)(31686004)(2906002)(6486002)(508600001)(5660300002)(83380400001)(26005)(8936002)(186003)(316002)(54906003)(122000001)(6506007)(8676002)(38100700002)(110136005)(91956017)(82960400001)(66476007)(64756008)(38070700005)(66946007)(66556008)(66446008)(53546011)(76116006)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?LzR0c1lVZUtBRTl0bEhNVkF2MTUwWWttZ1BiRHRvSGVzSGRsT1Z2N0lrWitp?= =?utf-8?B?Q01vem1ZR2Z3cE1CUUkzMXdCdTdvS0tVc0VmWTZwYTBEQmd4Q0lmMmF6Wk9C?= =?utf-8?B?YTlKbEhpbzc1SDNUSEw5ZmJsbmdndEZoSGdyOWY0cXJybXBrM25Cc09EbTVC?= =?utf-8?B?NlpNcFJkSWpITXlzUkZKTUJSUnNiTmFNOGprQ2pFaWtpeEE1Y0l4V1J6dnJG?= =?utf-8?B?QlE0MENOVVBReDErTjA2UmVZaVhaVUw4NGIyWHR6a2M3aHhwUjYvMnVqZERm?= =?utf-8?B?OGJ3bllaS2N4Z0t2V29JYmpRaXB2bWU1KzhtMEw0WjdLVjBmZk5wdUZjbWpI?= =?utf-8?B?dWdtbFMwQ1E1YkJSOVg2N0NPY282RW0wbXVOd3phQlZhOVVqVTlJY1MxQlVJ?= =?utf-8?B?NHpIUkJtYnF1RHJXQWh2a3drYzFuS3ZLYm5WRkU5UmVYYTFsMkU4VnY3N24z?= =?utf-8?B?RVBjODRRaGpoU3YrYzVJOE1BQ3VEV1VweC9UWHpNNTJHNCtVc2NLUVdTVi9I?= =?utf-8?B?R092Ylo5V0ZHbHpiUTdMemRlaE9FeG82RVdVTURNM2pzYXA3aFNiNFY1L0hx?= =?utf-8?B?djVFVzlvWmg3VXB3OWFaazhINkRtQ2hEcEVjU2o5ZE1zNmorNU1aYTk1K2Rz?= =?utf-8?B?cFIrZThzOFg0SnU2c0J5akU1RWk1M01LeGZHK25jZm1lUmd4TXc2OG1NNC84?= =?utf-8?B?bG5TVVA1ekRtWSsvVU1JcXl1dzdLRXhGcytFQkpBVFg3RFE0TGlROWVoVDJW?= =?utf-8?B?NGVacmllUDN1OVBzTHpIZW51am1WNXBzSXkwK2tnVTJrazlsQzU0N2pHRzdE?= =?utf-8?B?eGpoam4rQkJHTlVkZi9BN21VclhRZFJpQWxMOFdtcFR5NWhGbFpIdUtuQmRO?= =?utf-8?B?aE5WS3g3c0tNbkV1M09CVlZMUmFQZGRRRlVVMlRNY292Uk9lZ1BzWGNvYlJO?= =?utf-8?B?Y2lOcjkvN3lYUlVPckFtT2lpb3Q4RDUzc3BMaGFjRnBIVStHMmc3cEFwQUJw?= =?utf-8?B?RHZ5UWR0WmxMM3VXSjA5dkl6SzdnOXFmUGNoYWRocERDd2hTNjBFcFhBT1Mz?= =?utf-8?B?ZERSQm94UjdlbWcxTWUxVENKTVZwR3I5VGdnWjBVZTZQRW4vdXNhdHRyRlRo?= =?utf-8?B?Vm5vRjFyaU1ZMGxiMlR3azErY2V5a0J1aFRYMmdkUVlmTHJKcEZGUjhrcjJC?= =?utf-8?B?ZE9pMFhOK2E1T0hMOUczRkttZHFCVzllVnY5Q1dXZUxOK05Jc3A4OTR2bStm?= =?utf-8?B?TUxqNlJZdWNCRXZHaEJORWU0a25FR1BoL0NSSHBwNUY5QWxkUk1HcjlXcHF3?= =?utf-8?B?NW1hZEZ2RS9HK092SHo0YlhOdTFXUmkxZTNNMUs5R2RRcXZZMnhYaUJYWEQx?= =?utf-8?B?N0FBcWpBdzI1Nnc1dGtTOTBlV3IzOU9HblZZUWJ0VDlTWU8xcjBBWmg0ME9D?= =?utf-8?B?ZFpKU2txZy9tRWxmYnlSUDZ6VmZTUld6TGJnWnFuMml3MGxRRHhwT0xqMGJX?= =?utf-8?B?eFVvUEhYVW1abUp1Z0hCdmZmWEVyOEUrZUNxNkFDcFp6Z0FkM04yL3Q2SXRE?= =?utf-8?B?MlU0Mkx1MGNudkswUnA2SjJUcm92ZEhVeVRZN0RxcmRaQ3ltT0Z1WStXYkFF?= =?utf-8?B?Yjk0OTd3SkNVOHAyZmsxODJwdWFrZzVPazBlVzgrdElDRHQxamxTVWtNVW10?= =?utf-8?B?eGRwQlNwKysyUXUvUWFCSEk5OGtWb0pYdmtDclJObVl5Mi95NmdRT1AxVDhw?= =?utf-8?B?dmdXRHBxREhYR2NYTlNEWEpEMzNLRnp6aysxWnBnbDExbWR4S1lRMmtJMEhv?= =?utf-8?B?Mk1ZcXJ6amZyTU03anJpcGlwKzA0UTBTcWEwN1dVZUpVM0plY1ZoZVVXLzVx?= =?utf-8?B?V0pXWld0VmF1MTBvY0RIWkFKYzBvR0dGbHNlSzE5dHNPbitaZk96dGxJT1Ax?= =?utf-8?B?cHpYMVAwZFRMbUtlMmhXUFJaQTA1V2xqWVVhNUtaUWVGOW9LQWErdlhjVGJV?= =?utf-8?B?VnZDRmo4MFpSVGw1eDdJSHorZ2czRHRJMFE2L282QzJ6M1NvMERCUjdNY0NH?= =?utf-8?B?S2RmMk8yZ0J2b0s1VGprZHJmN1A5NnNkWE5pcWpjSmoySExCWENSejVrR25S?= =?utf-8?B?SmQ0TDRMZCt0ZTg5UG9QaHRMS1gyU0kzYlBjM0VKVXROREs4WmJjRDROS1Nv?= =?utf-8?B?L3Izb0FUR0ZTU2hLNFU2aTV3eFZFdHB0QndOMHZFYkFZckN5Nk82Mi9VdEd3?= =?utf-8?B?ZS9VQTc0SlpaOVMydmVvbDdnWXZBPT0=?= Content-Type: text/plain; charset="utf-8" Content-ID: <7FA05D7961391E40BE4D827D9A6940E7@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6b408463-e6a1-4d49-3a9f-08d9fc652214 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Mar 2022 15:55:54.2033 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: RNJXyqCR5Q7gRET4OW8nDmfiz6/eSP7drB2DTj367GPnTGdMYVsKc3KdxfMgulP2RtePwp2k0P1dQPOoEpxGI+rUlfg2X2KDyg2BfEhLJjI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR03MB2250 X-OriginatorOrg: citrix.com T24gMDIvMDMvMjAyMiAxNTo0MSwgRG9lYmVsLCBCam9lcm4gd3JvdGU6DQo+IE9uIDAyLjAzLjIy IDE1OjI3LCBSb2dlciBQYXUgTW9ubmUgd3JvdGU6DQo+PiBDQVVUSU9OOiBUaGlzIGVtYWlsIG9y aWdpbmF0ZWQgZnJvbSBvdXRzaWRlIG9mIHRoZSBvcmdhbml6YXRpb24uIERvDQo+PiBub3QgY2xp Y2sgbGlua3Mgb3Igb3BlbiBhdHRhY2htZW50cyB1bmxlc3MgeW91IGNhbiBjb25maXJtIHRoZSBz ZW5kZXINCj4+IGFuZCBrbm93IHRoZSBjb250ZW50IGlzIHNhZmUuDQo+Pg0KPj4NCj4+DQo+PiBE byBub3QgYXR0ZW1wdCB0byBtb2RpZnkgdGhlIGJ1aWxkIHN5c3RlbSBpZiBDRkxBR1MgYXJlIG5v dCBzZXQgaW4NCj4+IFJ1bGVzLm1rLCBhbmQgaW5zdGVhZCByZWx5IG9uIENPTkZJR19MSVZFUEFU Q0ggYWxyZWFkeSBzZXR0aW5nDQo+PiAtZntmdW5jdGlvbixkYXRhfS1zZWN0aW9ucy4NCj4+DQo+ PiBTaWduZWQtb2ZmLWJ5OiBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT4N Cj4+IC0tLQ0KPj4gVGhpcyBkZXBlbmRzIG9uIGdldHRpbmcgdGhlIHBhdGNoIHRvIGFkZCAtZntm dW5jdGlvbixkYXRhfS1zZWN0aW9ucw0KPj4gd2hlbiB1c2luZyBDT05GSUdfTElWRVBBVENIIGFj Y2VwdGVkLg0KPj4gLS0tDQo+PiDCoCBsaXZlcGF0Y2gtYnVpbGQgfCAyMiArKysrKysrKysrKysr Ky0tLS0tLS0tDQo+PiDCoCAxIGZpbGUgY2hhbmdlZCwgMTQgaW5zZXJ0aW9ucygrKSwgOCBkZWxl dGlvbnMoLSkNCj4+DQo+PiBkaWZmIC0tZ2l0IGEvbGl2ZXBhdGNoLWJ1aWxkIGIvbGl2ZXBhdGNo LWJ1aWxkDQo+PiBpbmRleCAzOGE5MmJlLi42NTZjZGFjIDEwMDc1NQ0KPj4gLS0tIGEvbGl2ZXBh dGNoLWJ1aWxkDQo+PiArKysgYi9saXZlcGF0Y2gtYnVpbGQNCj4+IEBAIC05OCwxNCArOTgsMjAg QEAgZnVuY3Rpb24gYnVpbGRfc3BlY2lhbCgpDQo+Pg0KPj4gwqDCoMKgwqDCoCAjIEJ1aWxkIHdp dGggc3BlY2lhbCBHQ0MgZmxhZ3MNCj4+IMKgwqDCoMKgwqAgY2QgIiR7U1JDRElSfS94ZW4iIHx8 IGRpZQ0KPj4gLcKgwqDCoCBzZWQgLWkgJ3MvQ0ZMQUdTICs9IC1ub3N0ZGluYy9DRkxBR1MgKz0g LW5vc3RkaW5jDQo+PiAtZmZ1bmN0aW9uLXNlY3Rpb25zIC1mZGF0YS1zZWN0aW9ucy8nIFJ1bGVz Lm1rDQo+PiAtwqDCoMKgIGNwIC1wIGFyY2gveDg2L01ha2VmaWxlIGFyY2gveDg2L01ha2VmaWxl LmJhaw0KPj4gLcKgwqDCoCBzZWQgLWkNCj4+ICdzLy0tc2VjdGlvbi1hbGlnbm1lbnQ9MHgyMDAw MDAvLS1zZWN0aW9uLWFsaWdubWVudD0weDEwMDAvJw0KPj4gYXJjaC94ODYvTWFrZWZpbGUNCj4+ IC3CoMKgwqAgIyBSZXN0b3JlIHRpbWVzdGFtcHMgdG8gcHJldmVudCBzcHVyaW91cyByZWJ1aWxk aW5nDQo+PiAtwqDCoMKgIHRvdWNoIC0tcmVmZXJlbmNlPWFyY2gveDg2L01ha2VmaWxlLmJhayBh cmNoL3g4Ni9NYWtlZmlsZQ0KPj4gLcKgwqDCoCBtYWtlICItaiRDUFVTIiAkWEVOX0RFQlVHICY+ DQo+PiAiJHtPVVRQVVR9L2J1aWxkXyR7bmFtZX1fY29tcGlsZS5sb2ciIHx8IGRpZQ0KPj4gLcKg wqDCoCBzZWQgLWkgJ3MvQ0ZMQUdTICs9IC1ub3N0ZGluYyAtZmZ1bmN0aW9uLXNlY3Rpb25zDQo+ PiAtZmRhdGEtc2VjdGlvbnMvQ0ZMQUdTICs9IC1ub3N0ZGluYy8nIFJ1bGVzLm1rDQo+PiAtwqDC oMKgIG12IC1mIGFyY2gveDg2L01ha2VmaWxlLmJhayBhcmNoL3g4Ni9NYWtlZmlsZQ0KPj4gK8Kg wqDCoCBpZiBncmVwIC1xICdub3N0ZGluYycgUnVsZXMubWs7IHRoZW4NCj4NCj4gVGhpcyBtZWFu cyB3ZSBhcmUgc3RpbGwgYnJlYWtpbmcgbGl2ZXBhdGNoIGJ1aWxkcyBmb3IgYWxsIFhlbiB2ZXJz aW9ucw0KPiBiZXR3ZWVuIHlvdXIgcmVjZW50IHBhdGNoIGFuZCB0aGUgb3JpZ2luYWwgcGF0Y2gg dGhhdCBtb3ZlZCBDRkxBR1MgdG8NCj4geGVuL01ha2VmaWxlIChjb21taXQgMjc0MGQ5NmVmZGQz MDA5ZjhhZGI0MGFhY2RiY2YwNWNmZThkMWJiYiwgRnJpIEFwcg0KPiAyNCAxNDo1NzoxMCAyMDIw ICswMjAwKS4NCj4NCj4gSXMgdGhpcyBhY2NlcHRhYmxlPyAoSSBtZWFuLCBubyBvbmUgc2VlbXMg dG8gaGF2ZSBub3RpY2VkLi4uKQ0KDQpTbyB5ZWFoIC0gbm90IHB1dHRpbmcgdGhpcyBpbnRvIE9T U1Rlc3QgaGFzIGhhZCBleGFjdGx5IHRoZSBmb3JzZWVuIG91dGNvbWUuDQoNClRoZSBzdGVwcyBu b3cgYXJlIHRvIHVuYnJlYWsgaXQgYnkgd2hhdGV2ZXIgbWVhbnMgYXJlIG5lY2Vzc2FyeSwgdGhl bg0KZ2V0IENJIGluIHBsYWNlIHNvIHdlIGNhbid0IHJlZ3Jlc3MgaXQgYWdhaW4uDQoNClRoZSB0 aXAgb2YgbGl2ZXBhdGNoLWJ1aWxkLXRvb2xzIHNob3VsZCB3b3JrIHdpdGggYWxsIHZlcnNpb25z IG9mIFhlbi7CoA0KSWYgdGhpcyBtZWFucyB3ZSBuZWVkIHRvIGJhY2twb3J0IGZpeGVzIGludG8g dGhlIHN0YWdpbmctKiBicmFuY2hlcywNCnRoZW4gc28gYmUgaXQuDQoNClRoZSBkb3duc3RyZWFt IHVzZXJzIG9mIGxpdmVwYXRjaGluZyBoYXZlIHBhdGNocXVldWVzIGFueXdheSwgYW5kIHRoZXNl DQpicmVha2FnZXMgYXJlIG5vdCB0aGUga2luZCBvZiB0aGluZyB3aGljaCBjb3VsZCBzbGlwIHRo b3VnaCBldmVuIGEgdG9rZW4NCnRlc3RpbmcgYXR0ZW1wdC4NCg0KQXMgZmFyIGFzIHRoaXMgaXNz dWUgZ29lcywgSSBzdWdnZXN0IHRoYXQgd2UgZG8gd2hhdCB3ZSBjYW4gdG8gYXZvaWQNCmxpdmVw YXRjaC1idWlsZC10b29scyBuZWVkaW5nIHRvIGRvIHN1cmdlcnkgbGlrZSB0aGF0IG9uIHRoZSBi dWlsZA0Kc3lzdGVtLCB0aGVuIGJhY2twb3J0IGl0IGV2ZXJ5d2hlcmUuwqAgVGhlIGFib3ZlIGlz IHRoZSBraW5kIG9mIGZyYWdpbGl0eQ0Kd2hpY2ggcmVhbGx5IHNob3VsZG4ndCBleGlzdCA6LS8N Cg0KfkFuZHJldw0K From xen-devel-bounces@lists.xenproject.org Wed Mar 02 16:09:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 16:09:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282419.481121 (Exim 4.92) (envelope-from ) id 1nPRXS-0006lL-Mf; Wed, 02 Mar 2022 16:09:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282419.481121; Wed, 02 Mar 2022 16:09:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPRXS-0006lE-JW; Wed, 02 Mar 2022 16:09:18 +0000 Received: by outflank-mailman (input) for mailman id 282419; Wed, 02 Mar 2022 16:09:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPRXR-0006l8-9W for xen-devel@lists.xenproject.org; Wed, 02 Mar 2022 16:09:17 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1bbc13ee-9a43-11ec-8539-5f4723681683; Wed, 02 Mar 2022 17:09:16 +0100 (CET) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-am5eur02lp2055.outbound.protection.outlook.com [104.47.4.55]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-26-bdrnTJ4eNVi5eUKVwytlsw-1; Wed, 02 Mar 2022 17:09:14 +0100 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by HE1PR04MB3227.eurprd04.prod.outlook.com (2603:10a6:7:1a::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.25; Wed, 2 Mar 2022 16:09:13 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5038.014; Wed, 2 Mar 2022 16:09:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1bbc13ee-9a43-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1646237355; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XZykFcKb3JJr/peGJH2wR36sZrRVU6Oip/yrt7jtnrY=; b=mIA1cfK9pydb06x9GP3jhtrMQXZKRGc7TN4odwywUvfXfAzyqI90nxkXprszkvHItFKL+h 4ODN86zrchK4DNmmHR9vnar/8GR4eVIaHKTc7YdGyL8cdOpX6lN3HXriIjbOENbyAhUcpc tUc3QZyKpnXnW0rLXOcaJEkei5xjfpU= X-MC-Unique: bdrnTJ4eNVi5eUKVwytlsw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K+M2QGEZNvDXOpaKo48VUMruwLMnbvjcsTeBGxME5jB6RtsMOaj2IQNwpDO5IPJd5kctnFNFGAYfcLBbvD5/cB0jabuVJ1JRP0dweGcMi+1CofFLPYY5Xl6EvYEEUi5wfKfArs4a4Nbg1SfuToNaA4lJpGmug0GAbs1KzvHeKyEVAYTXtRWzeiQKY5Islfx1RsYuq5APQrJglUIkpJNEEusH3ERDOv5eHMo6+brxbfOoGsP87rhk6TT4Ee5Apk3jPo9Ez8qDrGEbr8Za+wpV4SZcQr24CQ2YlJsxF5aPtoJK0Rpyy3ji50rD8/C9Ee91ySoUuInb7/DThNlKBFGcJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nQNCvubhZW4ZvndGWUbmmG7haHcJKGdcAU+Z1OTWR0Y=; b=JoMRap4r6vFzodH4aIj1WmkBAc4riS4mIjdt2idAFkC41u3uaJQ5WzjHwAPLyuYpujDKF0/g9ax65Gmh6wCSY+eNeBPpsFxhdvnEQiV26cD+E1hx5CaZVllFE2vnCgjaEkyZ/Cu7fdQbBWMuWATXCcgMpKmZbNfUM1enrhhy5EwlQ9PITIkU0a5Y2Ddm8TEybWGkMJsWqvm/t1cju7cC/rEM8UoU6F5UQKonNyEZRrr7+uFIOg2MxYsWz5Ummd9zq3/SUjq+mtba0xsmo49z/NKvTcLWf8gNWZk6XtO5n5vSVibD1f8aghKUeIXbqA5T2A5DB3mE3y9+G3a3/sOfSg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <4636a0d9-a96f-fa7b-3e08-595420b506e4@suse.com> Date: Wed, 2 Mar 2022 17:09:10 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH] livepatch: set -f{function,data}-sections compiler option Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org References: <20220302134425.38465-1-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS9PR06CA0324.eurprd06.prod.outlook.com (2603:10a6:20b:45b::13) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3099834e-dbbb-49ae-4125-08d9fc66fe1d X-MS-TrafficTypeDiagnostic: HE1PR04MB3227:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pusCafFJWTh5nYsYkBXXgID2EVoOysTgWraRKTNusWqiA8GUtpoae1TMOEoA0o3eVG+pYQIHZ996yuYUa9fNKdgV4a66MnAMoEBmouzkiItc1mdQa8obI5p0ssNpUKQJJ4OnBwtoJm93REwfC0y79Poa//+zpJCR6ycPWpS5EVG6HNc/Ed8y5nCl0uvZy8aNSahTucm0Ire5EIcx/ZWfJnvHptP+ZrPBPm1vW3QsMlVyFyqwbpkBAPcGjSwW4pgYL8eqvbeTGsGBUklx6PhQ47PWTGx5BPNQus7XqdHyLc40wjnGHi5n19KvwxzOdM79WSFABhe1giM30XDv1Ky4D/ao3GYPMYOUiQlUGJbvQajnFw6177uIcBeloo16lG70ad1cF+uWlmJ78V8XDYtNiG6lgoX2PAZM37SWLyG6Mk5TWZkERtZWzM6nXqT2pwahuKOAXYFu2dHv2GTf14Oy9CXpyNfGfuX4J66rvHGFbMNGpQPfRO8OKqlNZhHHS+VKjBA0V2GX6anPA5ZQwQhQVml3jrHhNUiE4OiUoU/yx3f5yWRC/azKcOS0AZEhNYq3PBtUzn/JHLDQf71lKszOqVcml7yCGpD4xNtj+5kshjufLHDjmIE777a5/ZIDIeevIZQwlp+kjsijQZy87fW7lxA7T6HVRbXGB0fAN2Kh2bkX1bFZtkZetEn1NtkoZS3g7fBxtOsQ+7N9n4/75ZM5MTGb2UhBdbgX56gj1J5l6uLkAgqT6mL0mJrbbFn4B+21 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6486002)(316002)(38100700002)(6916009)(31696002)(66556008)(66946007)(8676002)(31686004)(508600001)(4326008)(6506007)(36756003)(66476007)(8936002)(5660300002)(54906003)(186003)(2906002)(26005)(6512007)(53546011)(86362001)(83380400001)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?MdpqXoxW7KHBik7GEcyBA/mSnfbRK6lzJR564v5Cb0AlaMLUgV8Xetl1u0o5?= =?us-ascii?Q?ZSpKRxbwU1MYpCCt+v2Id+JA/ADIrLYGBEMDC9nfuTBNKhcG4v7bvxmzo9Cm?= =?us-ascii?Q?3A2eHgjtgWH7IhhBYu4rBScO/7OQTa6AzrAUEWCgszBBP00QfPwUHdD2j7S+?= =?us-ascii?Q?Uy3JjAZ5O8ZlwF4PPgrt+mCAcJP3ZuVXgZJ4yVs6GWh5gmotEEUcqKygkjtx?= =?us-ascii?Q?H9/kNbm2Ux14DN9+MtVCpdqpl30MnMwm8AsGxxqgCUp5vflkSSJ0roP8QOGF?= =?us-ascii?Q?/wH90UVRmkxJ+ISOnpHTehG8TO0Z+wb96JCknWErCdN8LCIl7Xlr+vyaS6+i?= =?us-ascii?Q?8R06OStv3ZCxTGjtGIH8L6eYNCcDc/R2hGCbV7obr8Oe8ODJsVewggTZqKy2?= =?us-ascii?Q?EYXAOyMAIAOSQrcq4Pyr9k5hbqNf0lNowgd37fVvN8AcPSk80WXx7okN+Qvn?= =?us-ascii?Q?EJ3j76/A7+LoBs4XISmLBUyri3Q0BCBD0LGRJ6L1hgXBEm8ZNMWLggZN8Ukc?= =?us-ascii?Q?rN27s6unKl0+cxjSreUeP6gKlbF4mJCHYxVcWwY3S9WFG8QOUHZ75g3oV0LR?= =?us-ascii?Q?8DmsHDtgqks9KQKtaYTZYCO5rQYGh7rLdMQyfpVo/wyWXJjqT5bx7Cb177O4?= =?us-ascii?Q?+kP+pmWhDivgaz+yViY/6SUCXtnPoLlgTvyrkDx/5P4UtB+iXVhvR8lHzQge?= =?us-ascii?Q?0qdkmaIAbAdhPxFB27+ZQ60mc4xWu0rTxag/Ji+5aqw1aNOrPDzbhMrSrYpu?= =?us-ascii?Q?M5Xaar9YpAI5D2NokEaFgqVrQ/2/PVtD/lQcvSTfUwjGuYiUr3uCjQR1zopb?= =?us-ascii?Q?kUu+xBHPLlRc2eV5dKjWIHIwRjr12+sypHWamq/EwLLoV3r3WNJE2S9IHlvD?= =?us-ascii?Q?kvfqowoI+FsHaQaXsAUROmooKV/DLina9Aw7G72X6b7HWytM8jrdebhOxKEt?= =?us-ascii?Q?7T2yksaH4u7OYLSlI/Hz/l8/dnVhUrI7X8BOeXJ3iAuIBCm43C7jABtX2roJ?= =?us-ascii?Q?mfhr1UKV+sPOvuijjJZy+sK62gB2sY9Jp7oqpbBTCnuGhcGH7scG1pnqGCkx?= =?us-ascii?Q?HYScL9rnl2I54QauUicd3w+hg7UBRH/QQLm+0gDSHPdj1NtHQVxPUHMLmtX3?= =?us-ascii?Q?VFav7UFKwwvdHcGYHCvhDzQPaUCkTam3ikm/mfqpM0laeYm5iQd+ecEDTwu9?= =?us-ascii?Q?lYfKgGtmPxJczbBp23mKCKWr5Mh55oIOiDunlgWghHflypV4yBYP0rNZUvVR?= =?us-ascii?Q?NurtRF/CueoX9kvQYleOcZ08iVfbhmqV6EpW3fBeqpB15CbMEryeYPXX7Kzu?= =?us-ascii?Q?EzEsViNfzeIEjLuJuIll7aoRqSIy3kiANtwoKKKy5eWIpYxNKYhLBYAOFw8G?= =?us-ascii?Q?o+smwJGJT2bh1Qz2Xa35D/GPkN+9vsgjcmV4lzl2b7GwRCpiAdoeuQfI1of8?= =?us-ascii?Q?jcoms6ekVg6upPaExYA17y57uzHjI12+SAoVmAE6IRLDRnZXZ5O7wtRyadpp?= =?us-ascii?Q?nIf2w/0OOTEXXLLaWOLrn6+yVw437ORf+lr9ZZ1ygEeLaYVFnwXtY+xAK7i4?= =?us-ascii?Q?syahhLHhf9MpSsVhIBc+CAmAjftsrZq9J2pI/VkUijtAHrqVeZRiDmWJ3Vfh?= =?us-ascii?Q?HtA+g4Uf16/5auVArBbxKXo=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3099834e-dbbb-49ae-4125-08d9fc66fe1d X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2022 16:09:13.1548 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IJo/4ihmM9itFufNunTi5YXq5YXgMhwqOjeVUk1QK4EQ6nmkHAw/2sldAeWWa4XjTYNki7em5BNe53ECZd3GyQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR04MB3227 On 02.03.2022 16:46, Roger Pau Monn=C3=A9 wrote: > On Wed, Mar 02, 2022 at 03:41:21PM +0100, Jan Beulich wrote: >> On 02.03.2022 14:44, Roger Pau Monne wrote: >>> @@ -292,6 +295,9 @@ SECTIONS >>> *(.data) >>> *(.data.rel) >>> *(.data.rel.*) >>> +#ifdef CONFIG_LIVEPATCH >>> + *(.data.*) >>> +#endif >>> CONSTRUCTORS >>> } PHDR(text) >>> =20 >>> @@ -308,6 +314,9 @@ SECTIONS >>> . =3D ALIGN(SMP_CACHE_BYTES); >>> __per_cpu_data_end =3D .; >>> *(.bss) >>> +#ifdef CONFIG_LIVEPATCH >>> + *(.bss.*) >>> +#endif >> >> ... are these two really in need of being conditional? >=20 > Will drop if you agree. I didn't want to risk introducing unwanted > changes in the !CONFIG_LIVEPATCH case. The only "unwanted" change I can imagine here would be that we place a section which the linker would otherwise need to guess how to place, for being "orphan". >>> --- a/xen/common/Kconfig >>> +++ b/xen/common/Kconfig >>> @@ -353,7 +353,9 @@ config CRYPTO >>> config LIVEPATCH >>> bool "Live patching support" >>> default X86 >>> - depends on "$(XEN_HAS_BUILD_ID)" =3D "y" >>> + depends on "$(XEN_HAS_BUILD_ID)" =3D "y" && \ >>> + $(cc-option,-ffunction-sections) && \ >>> + $(cc-option,-fdata-sections) >> >> Is this for certain Clang versions? Gcc has been supporting this in >> 4.1.x already (didn't check when it was introduced). >=20 > I've checked clang and it seems to be prevent in at least Clang 5, > which is likely enough? Clang5 accepts the options fine here. But that wouldn't be enough, ./README says "Clang/LLVM 3.5 or later". > I've added the check just to be on the safe side. Well, yes, if you're unsure and the old version can't be checked, then perhaps indeed better to probe. Jan From xen-devel-bounces@lists.xenproject.org Wed Mar 02 16:10:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 16:10:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282427.481132 (Exim 4.92) (envelope-from ) id 1nPRYY-00089O-3c; Wed, 02 Mar 2022 16:10:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282427.481132; Wed, 02 Mar 2022 16:10:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPRYY-00089H-0f; Wed, 02 Mar 2022 16:10:26 +0000 Received: by outflank-mailman (input) for mailman id 282427; Wed, 02 Mar 2022 16:10:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPRYX-000895-Bm; Wed, 02 Mar 2022 16:10:25 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPRYX-0003rB-7u; Wed, 02 Mar 2022 16:10:25 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPRYW-0007s3-It; Wed, 02 Mar 2022 16:10:24 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nPRYW-0005Ik-IT; Wed, 02 Mar 2022 16:10:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=LwTUqoXhP+QOP8Ddl72kDkzS3WZIW9AJ33lUOc17XfA=; b=UKDV4Of9AP9rWoHu49eLLp9ahD /R9PohZjRDFSaJyQ1GJyAhn7SwhglVieXAMndaw/HbCwrQlD27m/2IRIwAGzqe2Z3yBuFJubOQyx5 mnQVnGGzrLfVlIcSlOmuhT9YsEUjTigkMftA7/qr/qGL8EcdTfvTAC+0BJOq0iDnZNiw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 168333: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=dc39554d58af4a50b50eca1f57c49415a12b0c98 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Wed, 02 Mar 2022 16:10:24 +0000 flight 168333 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/168333/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf dc39554d58af4a50b50eca1f57c49415a12b0c98 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 2 days Failing since 168258 2022-03-01 01:55:31 Z 1 days 16 attempts Testing same since 168316 2022-03-02 02:50:20 Z 0 days 4 attempts ------------------------------------------------------------ People who touched revisions under test: Guomin Jiang Jason Jason Lou Xiaolu.Jiang jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit dc39554d58af4a50b50eca1f57c49415a12b0c98 Author: Xiaolu.Jiang Date: Tue Feb 22 22:14:05 2022 +0800 edk2/MdeModulePkg/Debuglib: Add Standalone MM support https://bugzilla.tianocore.org/show_bug.cgi?id=3844 This change added Standalone MM instance of DebugLib. Reviewd-by: Jian J Wang Reviewd-by: Liming Gao Signed-off-by: Xiaolu.Jiang commit 497ac7b6d7f9750f48f137db244931a5728b1968 Author: Guomin Jiang Date: Sat Jan 29 16:28:02 2022 +0800 UefiPayloadPkg/PayloadLoaderPeim: Use INT64 as input parameter REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3818 It will have some potential issue when memory larger than 2G because the high memory address will be fill with 0xFFFFFFFF when do the operation of INTN + INT64 but it is 32 bit normal data in fact. Should use same data type INT64 + INT64. V3: 1. Use INT64 as input parameter because all date type is 64 bit V2: 1. Force the data type to UINTN to avoid high dword be filled with 0xFFFFFFFF 2. Keep INTN because the offset may postive or negative. Reviewed-by: Guo Dong Reviewed-by: Ray Ni Signed-off-by: Guomin Jiang commit 6a890db161cd6d378bec3499a1e774db3f5a27a7 Author: Jason Date: Mon Jan 10 22:30:29 2022 +0800 BaseTools: Upgrade the version of NASM tool REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Upgrade the version of NASM tool to avoid compilation errors when compiling NASM code change. Signed-off-by: Jason Lou Cc: Bob Feng Cc: Liming Gao Reviewed-by: Yuwei Chen commit bbaa00dd01ed0df30e43a5a89fd2b0433d858b73 Author: Jason Date: Mon Jan 10 22:05:47 2022 +0800 MdePkg: Remove the macro definitions regarding Opcode. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Remove the macro definitions regarding Opcode because new version of NASM tool(e.g. v2.15.05) supports the corresponding instructions. Note: This patch need to be merged after other NASM code change to avoid compilation errors. Signed-off-by: Jason Lou Cc: Michael D Kinney Reviewed-by: Liming Gao Cc: Zhiguang Liu commit 2aa107c0aa2e1375651867c8df1b81ff64b67fce Author: Jason Date: Mon Jan 10 22:01:18 2022 +0800 UefiCpuPkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Reviewed-by: Ray Ni Cc: Eric Dong Cc: Laszlo Ersek Cc: Rahul Kumar commit 7bc8b1d9f412507d579f21ea9af56fced81e7827 Author: Jason Date: Mon Jan 10 21:52:52 2022 +0800 SourceLevelDebugPkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Reviewed-by: Hao A Wu commit d3febfd9ade35dc552df6b3607c2b15d26b82867 Author: Jason Date: Mon Jan 10 21:46:27 2022 +0800 MdePkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Cc: Michael D Kinney Reviewed-by: Liming Gao Cc: Zhiguang Liu commit 84338c0d498555f860a480693ee8647a1795fba3 Author: Jason Date: Mon Jan 10 21:04:09 2022 +0800 MdeModulePkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Reviewed-by: Ray Ni Cc: Dandan Bi Reviewed-by: Liming Gao From xen-devel-bounces@lists.xenproject.org Wed Mar 02 16:13:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 16:13:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282439.481142 (Exim 4.92) (envelope-from ) id 1nPRb9-0000My-Id; Wed, 02 Mar 2022 16:13:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282439.481142; Wed, 02 Mar 2022 16:13:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPRb9-0000Mr-FW; Wed, 02 Mar 2022 16:13:07 +0000 Received: by outflank-mailman (input) for mailman id 282439; Wed, 02 Mar 2022 16:13:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPRb8-0000Ml-Kr for xen-devel@lists.xenproject.org; Wed, 02 Mar 2022 16:13:06 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a45dfb53-9a43-11ec-8539-5f4723681683; Wed, 02 Mar 2022 17:13:05 +0100 (CET) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05lp2104.outbound.protection.outlook.com [104.47.18.104]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-16-JtyBaiPVO9-E1eUDdsuP0g-1; Wed, 02 Mar 2022 17:13:04 +0100 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by AM0PR04MB5713.eurprd04.prod.outlook.com (2603:10a6:208:125::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.26; Wed, 2 Mar 2022 16:13:02 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5038.014; Wed, 2 Mar 2022 16:13:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a45dfb53-9a43-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1646237585; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cqoLkMoWyHeuz/lWQmvZFCNhfMIrDkR3sLW0gFYsbNo=; b=ZDbe13pb7cbEw8PT5u3NbhvWG+HGf5Ma096yVgQTI5nLvI5oQgqJnNNFL2rz6HiBhX6g5B LIg5bWmI2VcJBkSTUVVfY3WgomtOdi2gPKEiLwxBhrfIpNsB75xYZf2ataFI1jrlnJUroj XMAKJ5+THyHv9H0r/wx0HH2jngSaPR0= X-MC-Unique: JtyBaiPVO9-E1eUDdsuP0g-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E2UGXSyUYanDtn+lR8+rfwf0f6d08nvCmC66zvmQvoNkyyombixfmE83I8aWw52AJgaHGNxs4zqmyWQo1zIgHBZNAJwUfrrLZNpO3Gb0SCfWot7kkJgVg6v3sf8ShMGk0F3AhFJR+waFi6ZCZfnxoXH0d2++ulXyaNjzYJJ+NWpCjXmTIItF/JvfvMrVY7x/zShhGYmmwVzX0dLlYrtgTY9/EK9+TqqQzRwdR+IE1T3e9ROWj2SS0iadeKCtsThUaEj0ztfJjyZE+c9/lwKd06XPY38YzQ89uDhoLvv72VHMOY+0DN5a4d1Ta9XeFPVZdKt6eXYzsSe55ps1vJmGog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cqoLkMoWyHeuz/lWQmvZFCNhfMIrDkR3sLW0gFYsbNo=; b=nCxYQMnkKA+yv9jZYmlVjyvd09db2mAQY+g7p5Pjf+gq0MAEEMIHvIkPqfJsT42PfswCFEfO8rHWq/bqqceEcgj/uBdaaD0J5g+oJa5P5Roa3lnGvHAsmJdWUPeqhcEAZ60gqQjnEplwUYlknKP62ozhke5zB87tYWFLa8s3n1HoBlJC4mhvKsWXYIz27olgd0e481gBAzTg4NewocLhjJHBJsaJTvEO8S0KkOnJ1RnD70+nVU5xEPFraIKZ36ani/8BM8/xe9xRQJvvNZio0G8ViWFN6CSOA8nI59Uu4YKDSAEyUH43m+qnS0xHZDNF6JQKF2RLnPsC9o42OROiIw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 2 Mar 2022 17:13:00 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH] livepatch: set -f{function,data}-sections compiler option Content-Language: en-US From: Jan Beulich To: Roger Pau Monne Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org References: <20220302134425.38465-1-roger.pau@citrix.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM5PR0602CA0018.eurprd06.prod.outlook.com (2603:10a6:203:a3::28) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d8023d84-6795-449a-0dde-08d9fc6786da X-MS-TrafficTypeDiagnostic: AM0PR04MB5713:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7XZUePl9WPKh+QLjhuzSK6c9Z7XQHg4SY8UWCJ0Hj52BCdy4TVleOmWN25vwrtDneOgqcMzUn8Hf8PAn24p48X52KGqTKr2AAJnsxbuuAmrv+NUILxcc9r1bX7+gz0ckTVDuLA846xBxyBt5ZiIxdojwizX7p6jzuQnppAP8rPSaJqWxBUG865tKAQ/zD/GZRX9cq1diwGWmwBpVIc2dyiiFTjHD+MkEvwA/0oeKE57oISzUcfVZwt7j6TVO8T9CHoIc8lkN5dp2yNU0B6e8V3AqvaIp/ACX8wfytMd9T+TJ8iet2PHz+ASozSTpF2N1hicOintYtXdwxC3ELBkFF1uUljDDPXLeBK3BnNxLJCp9s+mhqOXyQnNLOfe5AbaNBQkMWyS9oRWdu+v6W4jUeriLXJfanqJGfSQkC1q4wQdsgaJjFvxAFBkt7yLpQVcZUfQ3uS2Gn0mziHylXn/oMOtmBXZINoobvoQuBFSgNL9j8Qvi2xYVIiu5pVUl0m3ILK8Ea0FKYkM9lc15eOcMFMC3OLMCndTl6oaGlOu2615/Q651y2HvXVeo45SbzF1Smz9rOenBMIESs1zJtxxg7M9JrUsCcIQtExSeNGUUGdRnrIOGIDM2LUmQGHeTcbCXF9TFETU3+B0z2KWqhNu7OFjkKatfD+UHT5aXMUkLIkFX64lCJek8W90lcXC/f8bOFI+T4nWEhtuYlgf+ta1UdYAmXZpZvDjpk3H3gEYGjIsnZOjOVSNdtNC2rLxkKFZJ X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(36756003)(31686004)(8936002)(31696002)(66476007)(66556008)(66946007)(8676002)(4326008)(6916009)(54906003)(316002)(53546011)(508600001)(86362001)(6486002)(6512007)(6506007)(2616005)(26005)(186003)(38100700002)(4744005)(5660300002)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M0o4ZkczRFU0dWVOTzRRZ1pJaDZ3NW4xS1J3RlRrbVpCVFltRHBGdWQyOXBj?= =?utf-8?B?NFdVYXJaeU9NcnVkWFNKOHlPMHhPMUV1elRWM2dsVzJUdHA4ei80RjArOUFI?= =?utf-8?B?cXN3SnE4T3k2Zkt0K1VKTm84c2Q2eFJ3U3lzL3NtV2xrdU9iWlRjRmlwcE5S?= =?utf-8?B?disvRmFPSHo4dHJUaVd4ZXFoajJReC9ydDZXYzRWMW5tdTRvL1E1RlI0aXYw?= =?utf-8?B?UUVsK0liaXdQMHpLOEF1Qkk5bkx4S2d3Q2R0czluR0ZmTnlGbkNkZ1FPeFFt?= =?utf-8?B?UmRFbEg2RnJUR1BUa0wvU0dVckNPZkJySzcrZEI4OTh6SytWa0JaTnl6N3c3?= =?utf-8?B?YWdOVThYeVZPVktzeENKREh6eEFYYnE0MjU5L1hobUliY3BvTjJGT3hlNjFr?= =?utf-8?B?d0NZalYvY1lDMUJ1bnUvSTlJa254VVJBYyt5VnpUVjNMRDlGcFhkblJIQzI3?= =?utf-8?B?YWRMUDJpY2RhN09KdjJxMmRUa2hZMCs5RGhJd3g3aGxXRDBJMHg0K25XRUFo?= =?utf-8?B?eXhIdkV0TXJUVDM3YkJvaDZXTkgxMGV4WWxZY0hGcTZydC96bmRUQmJWdURk?= =?utf-8?B?Uk1rZXBncGtKL3dRZHNyZVkvZTFvUUlPNDI4bXJhcE5mdEprcVVWalNVWlBW?= =?utf-8?B?VUNEVzN4eHEzc3dJcE93eTAxNlRNOGUvMVl0dnJ4Y3doTjQ4bVFhUDkzakFw?= =?utf-8?B?YldFOXQ1b05DcGhYYXdRVmhQZExuSlF3QXBjTHNzM09JUUtjTXJQK2dBbmxC?= =?utf-8?B?T0dpR2hyWDh1UEcvSWxGRU0wc29kR0NXL0VDM1F3NnZrWWRJOGYyaEU5SXIv?= =?utf-8?B?MWJXS1ZZUEl5RlU0bnJWcjJFZUxtVkVZNDVhdlUxbGI1L2VVUjFhcmh2Q1c3?= =?utf-8?B?blpvTmszazhybzFhNlhlYUhuTTZIa0N6cS94VEJsUlBFYjRGV25kb2dweWRF?= =?utf-8?B?U3czRXNjaTBYbXlzRlN4UDJvVFJibzFZYTYyMUZEUlY4L2piaHIvQlFvMytC?= =?utf-8?B?R09XU3ovYThlcTJOaDJVZXFQZTVGTkdRTUZlbzc1NDlOQ3E4ZW9pdEJmdlVm?= =?utf-8?B?Y3NMR2kxRmJtR2FWUjFvRWFHc1J3WG9Yc1hWYzQxRHl4Y01CN1l6S2VXaVRw?= =?utf-8?B?bzAxOVNET0ZPbWtQbC9MNXF3Q0ZuSUc3a0pERXZ3TEg4bU11WjVPV0puYXUv?= =?utf-8?B?d3hmVmRsNmcxNnJJV0ZteDJrTEpDZDEyOWhORDJ6anRES0QyMlV6UXk5TTZE?= =?utf-8?B?TW9lYXBzWlUvbFo5Z2JSL3NZS1pyRkxvYThMWG9jQUZBeWQwVkNjdVh5eWo1?= =?utf-8?B?dHN1Q21aT3lFZlYyQzdyUzYzMVhCbFR5QnAvYWNmcVFwaWkwTHN5RS9CdWlh?= =?utf-8?B?TU1vR3BtOXUwWW1VMmhnNTJXVEZDNXdVQWdtaGRJNThacnd5TVUzczc3Vmxz?= =?utf-8?B?Y3oyOEdPRUxzZVUzMVZxeVAwaU5kalBmK1JQZWRPSmVvNWRDYUdzTDM5OUFY?= =?utf-8?B?bERuMWRnY0pjSHdKTVBhUXRKTlB6a0R4UmdrUHZHakt0OEI0NVZSd3ZCM3Zz?= =?utf-8?B?TWZkdW10ZzZVNFBUa0g4VXgwQjR5djV2QmxSM0hIOFJKQk1QcGMwUFNiblF6?= =?utf-8?B?M1FjcDU3QXlob0t3blk0Yi91bEJpbUdiZ3lWU3hMVFJadm9pZTM0Y2hzM2N4?= =?utf-8?B?enQzTDFEelFoVEhWU2p0dVFYNzVEbEhoVHE0NzM2RUx3a3FheFVoMHluVGpG?= =?utf-8?B?NFp1NExMdWc3ZzhCN0hVSHpVYUthT3l2SFdQdmxhNXI0Q1dUUkxaakY4a0xZ?= =?utf-8?B?TjR4dDZyMWpMZVVoQ3NHU3NEUWdNTkxWUzFoeHhTYnY0cE5xZlRpVVdnZkdW?= =?utf-8?B?ZlhoNkVJaEs0bEhJRyswbTl1dzhTT203M2RKc0JUbm1UUmFjbFRFRnFrMjBa?= =?utf-8?B?MXU4eHNTbnI0c1NUc1g2YXovQWZOa3FrSkVnYXpOdXVxM0hhNkJERTlaMDhR?= =?utf-8?B?MGRTdXFXRFlLWFBlcGc0U2lQTVJIT3JGOXFyQk1IQTJJQStmYUhicnhtSmVu?= =?utf-8?B?Nk4yRGN5d0NjNVJQblBVSnhNOGVIUmV2N2RIZGFPTTRscjdRalVuUTZLWlpn?= =?utf-8?B?MHJBUVlFM05ZakdHeG5xS3dpRmQ1MDNHUUNwL2ZzVHZHaTFBR01RT3l0bVRB?= =?utf-8?Q?1FITbm7T1sWjgDXK0qyiDw0=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d8023d84-6795-449a-0dde-08d9fc6786da X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2022 16:13:02.5154 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3DIpVxkL/k+YmMUU7N+8LhFQ9OzhlPwYH/2BE33Pui/+dT/0DD4+Re6MljIAXxqdcb/IOI7TyP9he6p5isSKdQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5713 On 02.03.2022 15:41, Jan Beulich wrote: > On 02.03.2022 14:44, Roger Pau Monne wrote: >> --- a/xen/arch/x86/xen.lds.S >> +++ b/xen/arch/x86/xen.lds.S >> @@ -88,6 +88,9 @@ SECTIONS >> >> *(.text.cold) >> *(.text.unlikely) >> +#ifdef CONFIG_LIVEPATCH >> + *(.text.*) >> +#endif > > This coming after the "cold" and "unlikely" special sections and > ahead of .fixup isn't very nice. Also from looking at the linker > scripts ld supplies I'm getting the impression that there could/ > would then also be e.g. .text.cold.* and .text.unlikely.* which > you'd want to separate. Thinking about it, with -ffunction-sections startup code cannot reasonably be placed in .text.startup, or else there would be confusion with code originating from a function named startup(). But of course .text.startup.* is similarly difficult to arrange for not ending up in the output's main .text, so adding .text.startup.* and .text.exit.* later in the script wouldn't gain us anything. Jan From xen-devel-bounces@lists.xenproject.org Wed Mar 02 16:14:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 16:14:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282444.481154 (Exim 4.92) (envelope-from ) id 1nPRbz-0000wX-SX; Wed, 02 Mar 2022 16:13:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282444.481154; Wed, 02 Mar 2022 16:13:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPRbz-0000wQ-PU; Wed, 02 Mar 2022 16:13:59 +0000 Received: by outflank-mailman (input) for mailman id 282444; Wed, 02 Mar 2022 16:13:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPRbx-0000pX-U0 for xen-devel@lists.xenproject.org; Wed, 02 Mar 2022 16:13:58 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c230ad94-9a43-11ec-8eba-a37418f5ba1a; Wed, 02 Mar 2022 17:13:56 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c230ad94-9a43-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1646237636; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=GH9/GwB4NZ0RyLKXE7KDqf7hyTsMOnpNMm3LMLELNFA=; b=NpJCKCnJMSy0EX0gUQc+j/jHqTR18Kh8Yta6RyYHDNXOe+I60xWYI9ty 9ElRvMiNuG4yITsuQsW+E1McgTOgImapu6i3zrKLGs9MjYWZFLgFg3bFJ ckGN7FpTpCI2zq0kAzm91KU3Qj4rfyGAF2hk7nACjrZDjBDXyKPoxgrr3 Y=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com X-SBRS: 5.1 X-MesageID: 65313117 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:s5E2Naq3QR7CbfZFGE9m/rPX1IleBmLsZRIvgKrLsJaIsI4StFCzt garIBmEP/vYYGf1KownPIrkpE4EsMDcz9ZmQQRlpH9kQioU9ZuZCYyVIHmrMnLJJKUvbq7GA +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8lyrZRbrJA24DjWVvW4 Ymq+KUzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk b1wWZKMpQgBEYbth/UhShdiIjxlevV8353GGEa4rpnGp6HGWyOEL/RGCUg3OcsT+/ptAHEI/ vsdQNwPRknd3aTsmuv9E7QywJR4RCXoFNp3VnVI1zbWAOxgWZnea67L+cVZzHE7gcUm8fP2O ZdCMGE2NUuojxtnAQhMV5QlveKSwTrmWWN39wmMgKsQ7D2GpOB2+Oe0a4eEEjCQfu1Kmm6Iq 2SA+H72ajkQOcaD0zOD/jSpj/XWgCLgcIsIEfuz8fsCqGOUwmsfGRgHT2yRqPOyilO9c99HI klS8S0rxYAp71CiRNT5Wxy+oVaHswQaVt4WFPc1gCmdx6yR7wuHC2wsSj9adMdgpMIwXSYt1 FKCg5XuHzMHmL+fRG+Z97yUhSivIiVTJmgHDQcGUA8E7t/LsIw1yBXVQb5e/LWd14OvX2uqm nbT8XZ41+57YdM3O7uT0nvmnCOQv5bzfxMuoV3teUCk1z1+e9vwD2C30mTz4fFFJYefa1COu nkYhsSThNwz4YGxeD+lG7tUQuzwjxqRGHiF2AM0QcF9n9i40yP7JehtDCdCyFCF2yruURvge wfttAxY//e/11P6PPYsM+pd5ynHpJUM9OgJtNiJNrKigbArLWdrGR2Cg2bKhQgBd2B2zMkC1 W+zK5rEMJrjIf0PIMCKb+kcy6Q34Ss12HneQ5v2pzz+j+bAPSDNEeZbaQrUBgzc0E9iiF+Pm zq4H5HXoyizrcWkOnWHmWLtBQpiwYcH6WDe9JUMK7/rzvtOE2A9Ef7BqY7NiKQ+95m5Ytzgp ynnMmcBkQKXrSSedW2iNyAyAJuyDM0XhS9qYkQR0aOAhiFLjXCHt/xEKfPavNAPqYRe8BKDZ 6JdKpXYX68WEWyvFvZ0RcCVkbGOvS+D3GqmFyGkfCI+b9hnQQnI8cXjZQzh6G8FCS/fiCf0i +TIOt/zKXbbezlfMQ== IronPort-HdrOrdr: A9a23:dl74rKtpKYIfjwwlfWlzSkFp7skDSNV00zEX/kB9WHVpm6uj5q eTdZUgpHvJYVkqKRMdcLy7WJVoIkm8yXcW2/h2AV7KZmCP0gbFEGgL1/qa/9SKIVyaygcy79 YCT0FWMqyJMbAk5vyQ3ODDKbgdKXO8gduVbJzloEtQcQ== X-IronPort-AV: E=Sophos;i="5.90,149,1643691600"; d="scan'208";a="65313117" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CjyFURgjNEZMcitvdr0/FYITJagHIy+U7ACbsLsoi9pfAbv01Mrk+v9C9s1NfMAzaDeYrmpOv8Oz4Pv/UXMlSuBv1oEVxD0iteEs3yWb74r3hIQ2D616oPropgETvBw3X7zT6wRCcU3WUF4EKsLspDIEHm+gsNq4CRxPE6v0OlE7jKO5FclB01iQ8IFMFDshQj1Ge5bvqKDBasnIKTbetXFAhaCKc9/zoZmViJ9h97byrFFK8oNfsN3xBVkkFLo0RMYrdbdW8wE+ljfDypo1bMNk3EMQcvqtriDM7/N3MLMRUKvcskvTUy/+SiT95Ut//O9otXu3mAtM8+ov119iQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2hervgjJMGhuzaYXWXwQM/fbWQrktTuhnNCgLrvmR/E=; b=CrtzXVfbug4RA17Np0p5jM+H2R56soQtIsrU8vio+ThhQdnGw5SmMEGCz9JSDXjCDb1+qmY+s6A+tZu5BMT8HA9kY1ql/nRZRyiuZ4fX4tH/cadGyqisC4z5nO5MqusBFcsfnEgjpC8AduGRvhOd9cAtxobH9t2nqZLCLcqK4K7VH4leWkc1XdE4kQ2eeBk77+DtVylBQbqTu84fInspWmBaXTCy62LcSLXTNZ12ZeZetOX5cxgtgXiI59+UF0O9/WrYU/dWMSa02mriVHs8S94DpEoNyShP5SSDCWY/5E2/tW8zp+eWBee+UhoO0D/3Hbih9uVegICGszn3XAq/Zg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2hervgjJMGhuzaYXWXwQM/fbWQrktTuhnNCgLrvmR/E=; b=BazZVYo+xCRZ315ezuvm6QdvzbVZLVH4mb5mXjJmiqHSMNCy9bXNlM5jGxOQBS1FEs3CrG1L0pkq+oO50qsOqhmm1sNpenoPvhxW2VwL8REOB0uos/goAdQ08tlcKNif70tSIAXKyxlt2uus4yYIs54syDiIfrPlP+dOYsH8cEA= Date: Wed, 2 Mar 2022 17:13:46 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper CC: "xen-devel@lists.xenproject.org" , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [PATCH] livepatch: set -f{function,data}-sections compiler option Message-ID: References: <20220302134425.38465-1-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO2P123CA0091.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:139::6) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 467357b8-378e-4832-5ff1-08d9fc67a3d0 X-MS-TrafficTypeDiagnostic: SJ0PR03MB6357:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hNrU3RhSBbjMTpctlaEyBmqqlZRW4V9jLSHZALDD3u4TCUT0Txrm4C7Xtbqe06fBGrNNbpUJ7cK0bvpxjty00tcbAaM7o0N0D5RoZeYnxwxLj/mVZLXwpAylbRTiJAipD2ifa4bp9AvCki4zE7rx4Y6PIVz/cWdxbBrOQ5+9zEwcaTLdkZyKQ3vNTz/mmpiMv9grs4FfmI61zjj+X9zejJFETsFZzIJx1n/+P1euLzRRbGMz99eQwaPtg9cCl7bEvPLz1gzLgVMzjTqrqIuyc9CV7+Aa5wVSjRz4IzrnPTtcZlJKwtJup4iaX2tWaWR5M9CD+SZuYMu6Y8wXKA9Muz7AfSXVbFMhGWsUhXxJMP6UQPszH6dgLFOJKktoRJBBi1wmLZIwttSyDAd2gByFI4qWYGNb0kx/kBhJaRJ1bBGTMgaYG584gp0QCs9hNCkXR5lAsTpSq8rE7GR/WBlBiap+HA/T+RpD7judwgdiwhuN8p+wc2OHvwi1kSfdQAhWM/GmFHiG8Dn3loM+IUzK3t9y43sFR/0RUClUrjJgoz3jq6YpkBUuvP1FIywovjLr8MfccGzjJwqvJ//p4kK+DLYZdqp1xYrUnpXfiYOkefdq1SN9u83dhdhYw/UIY2D0jVilEQqV8VWC0yRt8And4FuVyWPEuLEopUoXKnKqg0N1j2rdZ0Kt/GaK6oWiDIqc1JNFbGmnJLtyLQdio9xqbw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(54906003)(85182001)(38100700002)(82960400001)(6486002)(6512007)(9686003)(6506007)(86362001)(26005)(186003)(66946007)(316002)(53546011)(33716001)(66476007)(5660300002)(4326008)(6862004)(8676002)(2906002)(6666004)(508600001)(8936002)(66556008)(6636002)(67856001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZzJkaysxcEFBVTZwTVA3WE50bU1PUHprL1JDNXJQSHNiMUEwbWFkSzY4dHdH?= =?utf-8?B?a3dyTUJwUXFpeGNtVHoyRDFkakNja05pclRMKzFoWXJINlFUZ2xXYlc2TWtR?= =?utf-8?B?NHRZN3VraHQvSWhHTXlIbUZkQ3BlVHN0eTJHZDZsSjg1dUFNZnlGQjN6bGND?= =?utf-8?B?Wm5hUktaaVVXNDAxS1QyVll0RDE0TzcyZlNUbFJFOGw2RkNsQXQ1ZGJMSkNo?= =?utf-8?B?VWhwNlJGU21Gc1pqL0hZdVZkUkN3Nm8vOVk2dS9tU1dQR2pHZjJ6eGhaMHdN?= =?utf-8?B?UmcrUFhkM2hLTDY1SlFtbEZ2VjJjdXVNZnJWa3p4Z0lrYjRuUXl4NXl5YUpG?= =?utf-8?B?cDVwZ2xVMVpFcFhVbDdXY1hGMHAwZUxIaXd5UWZOakptWStqdHNiT0ovcGZp?= =?utf-8?B?MEFENzBNbmM0NXpJNzVvNFBETmZTdE03aUdZL1FLMEhQYlRwUVQ0d2tXQTM0?= =?utf-8?B?OWxMMVMvdlJHYUxaMERvVU9EMnZRK3VjRnVETVhmcjk1bU1ZTTcyS0pUd3ZX?= =?utf-8?B?VUMzMTJpc2N0Z1ZBek1vc3VMVEU4ajFHZFZuZlBTVG9pWXg3RHpBWU1mYmZa?= =?utf-8?B?Tmx3SWQ1VHpDdGtadHpJRVRhZWpuZEpDMzNzUTNoc0NOcUlYUUNFYnFqMVcw?= =?utf-8?B?bHZ6SDBvSzdBK1EzYzA0U3lzbUtMdm5pT3RHaVlaKzJhTWpJUVBqak4wYkVT?= =?utf-8?B?OGtteDVwYUZubHU1U1RGOEJnYWc3Z2xySGwxU2RndEcrQmJ2LzFIODdYdU5V?= =?utf-8?B?aUFqK0MrdGN4dThxcktWZ1JoVExmNHlyT0JvejIzdzl5NWlqbERJTG1qdzJW?= =?utf-8?B?NjZCek9GczRuS0FzeHNSc0JPZUpiRXZkdmsyYUhUdnIvUExieFM4YmU3UUxE?= =?utf-8?B?YzhnWkltOFFxaGNXTzF4cUdYc2xhNHIwK0FBVEhVZC9KRlVGeUM4MVZqU3gy?= =?utf-8?B?clNlU01tazhOWDZmQmlYT1lBUjkrSDB0SkxRdDNyWlF5K1JrcHlTTGc1LzdC?= =?utf-8?B?RzFrMHJhaFd0djl3a2hWVWNKQ2tmY3EzRnd1OFY4UDF3aHdRMndaZzJObGVN?= =?utf-8?B?bU51aUZkWTRMNHIwS3J5N0cxditleitmbUZrMXVGYmgzNGZXMjRLSWErcjlF?= =?utf-8?B?bGhJV1hxTEFuOS9NMGpsRDBTb3cwZ3NQVW1PNWFEOTMrYVdMUTlLSlhHaVk2?= =?utf-8?B?UXFwY1hkNTlpOHVQSzZoYzk0QllEb3FXSjc0VHNpL1dmRUQreHZKTkJKanBZ?= =?utf-8?B?TUlnQVJwSENGV1VNK3RYM29ZclpESS9XemtIaHhIM0VWa0FhQnZhWlk5MmxB?= =?utf-8?B?NVpxUFUrOGdzWGNFSW1sa1NReXF1WWVpV0VIbHVZS04vUk9VYXVjVlZsTnJu?= =?utf-8?B?RS9sblFGNkdabVNJUGR2OEpRa2N3NEcwWU5Vb3JCQmRWUWNZWlBSb1d0OXkv?= =?utf-8?B?S1hCTTNzMHRKVHVFWXR5ZFFnZjRFNERwR0tYZk51ZE52ZHVtdFVmWTBMbWNP?= =?utf-8?B?K3NPN1VuOEtrNTNrNzk3R3E4UWJPZFhTNlFkbWtxbG5Ia2NKZEQvUit1NnBC?= =?utf-8?B?a2Zzd1VWYVdaL2lKQmtxTTVVZnNveWFIbzFDYlZ5N0lKYUg1Wkt1NGdTbS9Y?= =?utf-8?B?em1YbjZGSzNsWnB5WkFKbHd2MU05T2taa2JyeHVOZDdwZU9kRHlsZFpxL3Vq?= =?utf-8?B?aWFZUGhGYXR0UVRYbXNlaTA1STQ5NFZEdGVDeXNQSlk1OHQxMThPdUlOalA5?= =?utf-8?B?NWlqRjVtcWVNY3JlK1NkVFJqNzRSbzFmM0h6MUlrTTJmemVuVUNvZ1ZLYkZx?= =?utf-8?B?b0RaU2ZhUVVFd2YvK0IyQURKd3RmZzhpM2Z3RksvMmkza05tZitNVDl0STJz?= =?utf-8?B?d2JVR0Z3N2JVNm91QmVzclNZVXJIVDlMSVRNaEtUQSs5NGlnSHFEaXhEZWt0?= =?utf-8?B?c3djNDlhQ2xZMnREZjNyajdubnMvUVpvZ1Q2azcyLzg2NWppR0NwRU5zdGdw?= =?utf-8?B?NUdwaHl3UVVTaEZLYzNKZEE1YWR0ZVliVzhCVGppL3hlRkxxb1ZDMGNHN2Ri?= =?utf-8?B?cEJzMXdDQU1UL1FZWE5ST3ltSWRHNnJ5MFQ1UHlvb1J1blB0b005Mzl3N1d2?= =?utf-8?B?NjFQcjhzTW1hL0F3a0VYQzRST0tRazhnVE9FamRmL0ZaYnRvTEFRTmJUcmtk?= =?utf-8?Q?4cieLkiPJv0haMjA/8Uj8gk=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 467357b8-378e-4832-5ff1-08d9fc67a3d0 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2022 16:13:51.1371 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GUKq7iVU3v7nPSqMJEzT7oE5Hp+MajKDi4vQ/HUwT754IBinxEsIwfJS/oLqW1a9TG9NoIOLWqJx1Tk0olIcMQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6357 X-OriginatorOrg: citrix.com On Wed, Mar 02, 2022 at 03:35:07PM +0000, Andrew Cooper wrote: > On 02/03/2022 13:44, Roger Pau Monne wrote: > > diff --git a/xen/common/Kconfig b/xen/common/Kconfig > > index 6443943889..2423d9f490 100644 > > --- a/xen/common/Kconfig > > +++ b/xen/common/Kconfig > > @@ -353,7 +353,9 @@ config CRYPTO > > config LIVEPATCH > > bool "Live patching support" > > default X86 > > - depends on "$(XEN_HAS_BUILD_ID)" = "y" > > + depends on "$(XEN_HAS_BUILD_ID)" = "y" && \ > > + $(cc-option,-ffunction-sections) && \ > > + $(cc-option,-fdata-sections) > > cc-option can take multiple, so just $(cc-option,-ffunction-sections > -fdata-sections) > > However, we in practice want these in combination with $(LD) > --gc-sections anyway although that wants to be separately configurable. > > Therefore, we probably want something like: > > config FUNC_SECTIONS >     bool > > config LIVEPATCH >     selects FUNC_SECTIONS > > or so, so in the future we can add "config LD_GC_SECTIONS" which also > selects FUNC_SECTIONS. > > Thoughts? Do we want separate options for ffunction-sections and fdata-sections options, or is FUNC_SECTIONS supposed to cover them both? I assume you are fine with Jan's suggestion to not check for the option presence, since it should be in all supported versions. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed Mar 02 16:21:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 16:21:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282455.481165 (Exim 4.92) (envelope-from ) id 1nPRjB-0002V3-Pl; Wed, 02 Mar 2022 16:21:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282455.481165; Wed, 02 Mar 2022 16:21:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPRjB-0002Uw-M6; Wed, 02 Mar 2022 16:21:25 +0000 Received: by outflank-mailman (input) for mailman id 282455; Wed, 02 Mar 2022 16:21:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPRjA-0002Ua-LN for xen-devel@lists.xenproject.org; Wed, 02 Mar 2022 16:21:24 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cc0670af-9a44-11ec-8539-5f4723681683; Wed, 02 Mar 2022 17:21:22 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cc0670af-9a44-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1646238082; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=ujXqZwAfA+8GTDK8Ti/0+OUd7Q1Au1G+zo9WP3I37rI=; b=CH6/rmHd/WhJX2T2jA88ikR5V0hBimdu+yUGLh48FRoLNqkWAittdj+L Y2+Lkx1A4kgoC9/Fuo4AZ3a90fURcpoWkl7ZNnZQs6oJELxuyimRES9q+ osamUX7x1ZjN4v8haTSlWDSmhWoaJBDuthoYc9ND6j0BTwgTsSdJT20uP M=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com X-SBRS: 5.1 X-MesageID: 65321239 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:zFcgoa/aCYBQXn1Dem0IDrUDdH6TJUtcMsCJ2f8bNWPcYEJGY0x3m GZNDG7QOv7ZMDSjLd0nb9++9k0A78SDzdEySANqqCs8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy +1EN7Es+ehtFie0Si+Fa+Sn9T8mvU2xbuKU5NTsY0idfic5DnZ54f5fs7Rh2NQw2oDjW1jlV e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9 DlCnbC1CiIYFI/oo946fEQHFXt/PoZn6KCSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFJkYtXx6iynQEN4tQIzZQrWM7thdtNs1rp4TRqyHP ZFIAdZpRC3COxxjCGgnMtUBs/yarCbieTtitU3A8MLb5ECMlVcsgdABKuH9cNGQWd9cmEreo 2vc5nn4GTkTLtnZwj2AmlqSgevIkTL+SZglPrSy/f53g3We3mUWThYRUDOTsfS/z0KzRd9bA 0gV4TY167g/8lSxSdvwVAH+p2SL1jYDX/JAHut87xuCooLW6QuEAmkPThZadccr8sQxQFQC1 EKNnt7vLSxitvuSU3313qyPsTq4NCwRLGkDTSwJVw0I55/kuo5bs/7UZo89Sujv1ISzQGyuh WDRxMQju1kNpeIOlICK13LjuAiLicWWSFQ05S72Tn3wu2uVe7WZT4Cv7FHa69NJI4CYUkSNs RA4piSO0AwdJcrTzXLQGY3hCJnsvq/Ya2OE3TaDCrF8r2zFxpK1QWxHDNiSzm9NO91MRzLma VS7Veh5tM4KZyvCgUOajuuM5yUWIUrISIyNuhP8NIMmjn1NmOmvpnsGiam4hT2FraTUuftjU ap3iO71ZZrgNYxpzSCtW8AW2qIxyyY1yAv7HM6nkU35ieLPOifEE9/p1WdiiMhjtstoRy2Pr r5i2zaikU0DAIUSnAGNmWLsEbz6BSdiXs2nwyCmXuWCPhBnCAkc5wz5mtscl3het/0NzI/gp yjlMmcBkQaXrSCXeG2iNyE4AJuyDMkXkJ7OFXF1Vbpe8yN4OtjHAWZ2X8ZfQITLA8Q4la8kF 6ReIp7YahmNIxyekwkggVDGhNUKXDyghB6UPjrjZz46fpV6QBfO9MOidQzqnBTixALr3Sfii 9VMDj/mfKc= IronPort-HdrOrdr: A9a23:7wGUea2bc3lglMzVZJdGUQqjBVByeYIsimQD101hICG9Lfb2qy n+ppgmPEHP5Qr5OEtApTiBUJPwJk800aQFm7X5Wo3SITUO2VHYV72KiLGN/9SOIVydygcw79 YET0E6MqyNMbEYt7eK3ODbKadY/DDvysnB7o2/vhRQpENRGtldBm9Ce3im+yZNNW977PQCZf 6hDp0tnUveRZ1bVLXyOlA1G8z44/HbnpPvZhALQzYh9Qm1lDutrJr3CQKR0BsyWy5Ghe5Kyx mOryXJooGY992rwB7V0GHeq7xQhdva09NGQOiBkNIcJDnAghuhIK5hR7qBljYop/zH0idgrP D85zMbe+hj4XLYeW+45TPrxgnbyT4rr0TvzFeJ6EGT1vDRdXYfMY5slIhZehzW5w4Lp9dnyp 9G2Gqfqt5+EQ7AtD6V3amGazha0m6P5VYym+8aiHJSFaEEbqVKkIAZ9ERJVL8dASPB7pw9Gu UGNrCR2B9vSyLaU5nlhBgu/DT1NU5DXStuA3Jy9/B96gIm0kyQlCAjtY4idnRpzuNId3AL3Z WADk1SrsA8ciYnV9MMOA4/e7rENoXse2O7DIvAGyWvKEk4U0i93qIfpo9FoN2XRA== X-IronPort-AV: E=Sophos;i="5.90,149,1643691600"; d="scan'208";a="65321239" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i5SttxiP6IjiZ4p/Gzh6mG8YawtIWJNO0V0haso10zw79lHgE3Ia9j9+X8mKcCa9FIc7XY0LrrMS6eK6L3Eg0M10ZOmw5PZna1ezzSdHQVfsMWMbHVaXqiMpVnkxB9jjapSwaQZqQ0BfFnKpwZzvv2whPD/Lwn0AUiyU/irjSPIcktnaQVwXWekCxcZgim52up/223OEkZlx2m/I8u5KskkNn3lHrsqUoawpYOZQ1YXQvegPvEnfIfnANn9cWOds7qbLmeGF6SJ7RLpKbwvYqKG/jr5lx6kSvWh7F9o2HvHgUCTs8Dc8UXuxCVFpENpCs1wiJwoE6mW0PDBkDjBrWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pZpyGQ8H+L7AQnCTzm0R4LjWbwQk+nOrsSEUT6rC4ds=; b=OYXuBW85MqzgqKtTY4rA1JNDotF0b0sk7O5bwkas1j+XsZPPMpNwNnc+iBnhyvdLUeLOuxvP8qN+LfqFwJGBCbaIDPXL0zUlaFjRhqjYJuMhXxYGxI8692AxaO3xTO/lnzCTWRKK+10ZytBPWjHsKdPq7+gDcs1FZ69GA+nTnFJjlhSVS5pPyLWegK17tJF2Lj1BGfcqgDKRXFMBjIJKVV7ZBMRV7Zd+W6i3267uvWJ4CTxhmYQFnok8F00Ih9eZtW0h7F1kihhTtJYWgqQO5hUJ/7Qb0T9FWRNJX/eoWQRxR2tyryGAF028CHUnmrPP9fNcmdXVwNWuNNWqaFbPSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pZpyGQ8H+L7AQnCTzm0R4LjWbwQk+nOrsSEUT6rC4ds=; b=dbfe7Vv+sjOL7zVbk3rjw6mplaothXYGM7XxUJF6OHZVAzp17JZbWUSheVdwljeyzBvDQlxU9gYcztNVHaPLYb8dgtfYapRRJS717IqSGI1qpWNMzYOh50l/2+c7StNjjnzy6CZMf6wH0l/OJ7xot6cI0NldwoTyydMDFYO0SpE= Date: Wed, 2 Mar 2022 17:20:49 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich CC: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , Volodymyr Babchuk , Subject: Re: [PATCH] livepatch: set -f{function,data}-sections compiler option Message-ID: References: <20220302134425.38465-1-roger.pau@citrix.com> <4636a0d9-a96f-fa7b-3e08-595420b506e4@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4636a0d9-a96f-fa7b-3e08-595420b506e4@suse.com> X-ClientProxiedBy: LO4P265CA0052.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ac::15) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0fe3fcc4-15e0-46f1-2d2a-08d9fc689f80 X-MS-TrafficTypeDiagnostic: DM5PR03MB2940:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: U7S41yYkfx7xlNDZkN/pFmyn/FzfIWVUnMnlIcGlUdFSS1g/VIUNjgDRgaennV2YSBIwmAjyjX61tGNOJ36WroyGPoogvfR/bhPeRrdDHWh2CXd2nIIlvadoU92PNpvIKglqZiv31+QzKoRVj+hqqK+AeZKWJB2I5NaXHbyWrMoi7k6tCaILg4HIPWXnhfl2LBPk8ILzcHbbiM9kKRUGgJPMM1ongZ3Y8yDGhBMtZNhDGDJd0Wbxhp7sDE3+RUQzmCowokHD7OdM9KM6sLsc73uqqLpr5Wa5Uhr2Jk6WwGl6f1wVd7cLRfjr++xNxfRSeiN/O7eMiQBANjVsejHLD6OzvUy54L4GSPJEwqQ2IxA5CTs80CgvNKAXWFHzXh5p7qt5ZkNeTyu1G3ezil7kRfjrj8hRS867TsovVmXAQ+Tw8gOZ8o/87y6gOsVJ9x6WC93LvP9blRo3am0GAdOjnMPcVXUTzn7TqNCFQRDFC65EfVPpblQnxqQYq0uIghMl4iOCNe1HAkpOZyJVBBLjPoHRblyXnxSxMqakDQskUbcaqxVMUoqnRIXpopz93dxDJSNKnesKj3lc11FkvUfz+NAtff9LjJ+tDN0WsUmrTyz6VmNaewQQODHiFBmx41U1a0Q0GrLtpO7VJqBAA9EutvYlCc89dVtxi4N7+k8UAvCFAxghnMlHVrZzVUkfEYqgL8667w1eQhD/Wa5FzrXylg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(86362001)(8936002)(8676002)(4326008)(66476007)(66946007)(66556008)(33716001)(85182001)(2906002)(6486002)(508600001)(6916009)(5660300002)(38100700002)(316002)(6666004)(6506007)(53546011)(82960400001)(83380400001)(9686003)(6512007)(54906003)(26005)(186003)(67856001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OWRSSXpzQ2RpMGRhZllmVGRGWHhkeW5EVVhDNmhpUEViM1BZbEVBbTFQTmZr?= =?utf-8?B?OVIzUXJMRGNxUGoyc3RxeENacCtxNlRaZTJRWlRVN1RMK0NQRGVSdDNjdE1K?= =?utf-8?B?MnlrUjBPTktWM2xDN3QyN1hPL2cwQTkvd1l1RkhVVnhUNTFhdXVJQ2dJdU1Y?= =?utf-8?B?Z2E1NFllUzI0MjBPWUsvUGdXbW54U2F5ZWtCVVIzZ0dIYVFCaS9LVU80U2wz?= =?utf-8?B?VW1WQWk5dnZEcmtJaFJFL3grZS8wZ2txWEpDNGdoWUpNYVNTeXQ4UFZmVEVQ?= =?utf-8?B?SnNIdEpEUHBJVm5FblhPRy9QMjVKZk5OcFV5SzdYc2w4Y1JTaHhYSXZRWHhx?= =?utf-8?B?WWtQYzZMb1pXc0ZvTmhKQlRrMnpGZkk4VWY5eFBNRUQ4b1VnSGdMV1hWZkVI?= =?utf-8?B?WjZNN3VqQWQ1NUsydTFpKzJ3TzAwSVJDTllqUWFhRGt1c09IT2M1NDNsb091?= =?utf-8?B?aTZ2dUpVdGdtdzVKNkZhbVhwT0Y5Slo1eGFSVHgwc0FoU1pDZjV3ZWFFa3gw?= =?utf-8?B?aTVqTWJraVUrbHNRYWxqOUFRZmdHSGJrMno0U1JHc2dBS0R6dEQzSVcrTWEx?= =?utf-8?B?a0p2V0RCRUgvazhLdVVwalBBdFM5RUpnSUdJaVlJaWptY0gvZ3FSVEVaYnZq?= =?utf-8?B?WTZiQUNOQk4ydG5vK3c2Wk1DQmNXN0J4RHM4WDdPNCtvdzZFTkdvTk02ZUln?= =?utf-8?B?RWRhVWJlTXdhS3JpLzcyL0NnbEtJZ0JsMDVpRm5kTUM1YXdtbjd5MWdlRnNQ?= =?utf-8?B?cTZ2L1ZodTJqYzBhN2dBLzA2eFN4YnI3bmRVdEY4djhOc1hNZGtncU9sY3FO?= =?utf-8?B?MDBxaGZsbjcxZVZTOGdRbXB5MXZ2WjdFSS9Sc1lOdHhpdytjaEhyeEpmSHYy?= =?utf-8?B?QzhYY29VZUNyaEVPUGJHSytOSmJaRzF1aytMMnVUUVhtYkN5Sm1TTWEvM1hE?= =?utf-8?B?UFFqTFptNHY2YU8vQUMzQTYvK0lCY0hhM3dabnd5QXdybWtiSWd1MXpzVmJN?= =?utf-8?B?cFA1aGd5RnVTV0pWb25rN2hITHUrYktZV2NJVlFZN0RmdGhaaUlFRnhkenlw?= =?utf-8?B?aHkyRDhRakw2cUIxbStrb0dGWkYrZ0swS0dTOFE0VFhpWVJSSHBCL0lmbmJ0?= =?utf-8?B?TWpiWWVkZ3d5NENwT3FZNGxNOEw0bUVybUZTdnhYVzJWY25tTHhVVTJtSTY3?= =?utf-8?B?SXRjbGIyWkhIMlBzaklNbWRvZmRENUkwYkZFVERWeGw5bkoxR2xRU1FTQkln?= =?utf-8?B?WEhjWjRLZGJER1NtNUFKMnFNbmpVTWdCQ3dBMDF4ZzZaR25UZFlBL0hReDll?= =?utf-8?B?MUg1SitFRUdKTDFjZjB1dWpsMEVGZVdrMkM1MXprYXJLdk45blY2ekVwWW5C?= =?utf-8?B?Nk1SR3Z0Y01NSGtOcVU0SEF2aEQrdGcrVy9pMXZReHBDVUJDdnNkWmVONUFz?= =?utf-8?B?bG5kNVl1bk9lYWxvcWFzSXdyYXl6cG1SLzRvcjJqL1luUVd0aVNBYktyamRY?= =?utf-8?B?bW9GZHVvVTdCZ1I4bmRPeDVIZlk3YWFoU20va2RUdWhSZFdOcUptU1ZqQnpv?= =?utf-8?B?Z1dMb0tKazRnckoxWStvUnJwdUlCdFBGYWVZZktScUgxM3ZlVXgrTkJMOHFq?= =?utf-8?B?L1lKS0lzSTFXWUppQmRNWE82dEVuMmtjcEJReHR5b2hTRnBPaTJqTDhSSFYv?= =?utf-8?B?VkcxcCtOYy9jT0FmOXlnb2c5dHBsUWVmR1pPc1VndnBqNUo2REo4OFl6cW5o?= =?utf-8?B?TTNpOHljWFpRRzQ0Wm4zYkt3c1BzY3BVdDZKaW01TVNMZTZLYitBQjI5dGZu?= =?utf-8?B?Q3ZHelJFbi8zVW5DcE1RWDYrVzlZai82UnFVcHRNbFVteER4NkxJZlBYODd4?= =?utf-8?B?NTZEUGtpSGZudk5OeUM2OFdsUGlMODltY2RWTlFxRmxrVWNaNW52a1R5Y0VI?= =?utf-8?B?Nk9QV3ZFN2NjOFFNR3ZWa3VoYTVHVTVzOTZwUC9CeFRMUWNuaEthVjNCWGVP?= =?utf-8?B?cElleGhMaXVIU05uMjhnYmQzVnA3N3hHRTFKdWw1cC9GSTBIWU55MVJzaExx?= =?utf-8?B?cmx1cUZIbk5odkdGMWx6RzBnRlRZUFN4bDdObFRQeTdXd1o0K2R0dTBjNHJQ?= =?utf-8?B?ZHAzdUllTGM4blBVa1BJZGMycHdsN2d1T0lsYW45V2QzaWZqMkVabm9LdXFC?= =?utf-8?Q?6f4iTIGgb7tLJaBNeJyBSj8=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 0fe3fcc4-15e0-46f1-2d2a-08d9fc689f80 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2022 16:20:53.4286 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6iijZYmnzvfvN7xeb5Upx72ycujhQBkMzE+Fv79CFvNWG1vX33rik7BMTg/gNGzygkSn0D/Mm1F2RWX01YB5qw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2940 X-OriginatorOrg: citrix.com On Wed, Mar 02, 2022 at 05:09:10PM +0100, Jan Beulich wrote: > On 02.03.2022 16:46, Roger Pau Monné wrote: > > On Wed, Mar 02, 2022 at 03:41:21PM +0100, Jan Beulich wrote: > >> On 02.03.2022 14:44, Roger Pau Monne wrote: > >>> @@ -292,6 +295,9 @@ SECTIONS > >>> *(.data) > >>> *(.data.rel) > >>> *(.data.rel.*) > >>> +#ifdef CONFIG_LIVEPATCH > >>> + *(.data.*) > >>> +#endif > >>> CONSTRUCTORS > >>> } PHDR(text) > >>> > >>> @@ -308,6 +314,9 @@ SECTIONS > >>> . = ALIGN(SMP_CACHE_BYTES); > >>> __per_cpu_data_end = .; > >>> *(.bss) > >>> +#ifdef CONFIG_LIVEPATCH > >>> + *(.bss.*) > >>> +#endif > >> > >> ... are these two really in need of being conditional? > > > > Will drop if you agree. I didn't want to risk introducing unwanted > > changes in the !CONFIG_LIVEPATCH case. > > The only "unwanted" change I can imagine here would be that we place a > section which the linker would otherwise need to guess how to place, > for being "orphan". > > >>> --- a/xen/common/Kconfig > >>> +++ b/xen/common/Kconfig > >>> @@ -353,7 +353,9 @@ config CRYPTO > >>> config LIVEPATCH > >>> bool "Live patching support" > >>> default X86 > >>> - depends on "$(XEN_HAS_BUILD_ID)" = "y" > >>> + depends on "$(XEN_HAS_BUILD_ID)" = "y" && \ > >>> + $(cc-option,-ffunction-sections) && \ > >>> + $(cc-option,-fdata-sections) > >> > >> Is this for certain Clang versions? Gcc has been supporting this in > >> 4.1.x already (didn't check when it was introduced). > > > > I've checked clang and it seems to be prevent in at least Clang 5, > > which is likely enough? > > Clang5 accepts the options fine here. But that wouldn't be enough, > ./README says "Clang/LLVM 3.5 or later". > > > I've added the check just to be on the safe side. > > Well, yes, if you're unsure and the old version can't be checked, > then perhaps indeed better to probe. OK, so I've managed to probe clang 3.5.0 and it does support -f{function,data}-sections so we can drop the check. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed Mar 02 16:24:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 16:24:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282462.481176 (Exim 4.92) (envelope-from ) id 1nPRmM-00036a-80; Wed, 02 Mar 2022 16:24:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282462.481176; Wed, 02 Mar 2022 16:24:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPRmM-00036T-4n; Wed, 02 Mar 2022 16:24:42 +0000 Received: by outflank-mailman (input) for mailman id 282462; Wed, 02 Mar 2022 16:24:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPRmK-00036N-Op for xen-devel@lists.xenproject.org; Wed, 02 Mar 2022 16:24:41 +0000 Received: from smtp-fw-9102.amazon.com (smtp-fw-9102.amazon.com [207.171.184.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 40887a91-9a45-11ec-8eba-a37418f5ba1a; Wed, 02 Mar 2022 17:24:38 +0100 (CET) Received: from pdx4-co-svc-p1-lb2-vlan3.amazon.com (HELO email-inbound-relay-iad-1a-2d7489a4.us-east-1.amazon.com) ([10.25.36.214]) by smtp-border-fw-9102.sea19.amazon.com with ESMTP; 02 Mar 2022 16:24:23 +0000 Received: from EX13D03EUC002.ant.amazon.com (iad12-ws-svc-p26-lb9-vlan2.iad.amazon.com [10.40.163.34]) by email-inbound-relay-iad-1a-2d7489a4.us-east-1.amazon.com (Postfix) with ESMTPS id 7BB7C81640; Wed, 2 Mar 2022 16:24:20 +0000 (UTC) Received: from [10.85.98.33] (10.43.166.127) by EX13D03EUC002.ant.amazon.com (10.43.164.60) with Microsoft SMTP Server (TLS) id 15.0.1497.28; Wed, 2 Mar 2022 16:24:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-Inumbo-ID: 40887a91-9a45-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.de; i=@amazon.de; q=dns/txt; s=amazon201209; t=1646238279; x=1677774279; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=/RXTr240dq8/dXMZX9Q5X7Ekf4Q0aMl1fc6FKE5Dphg=; b=EaTbCgBKwA5LV/moJaIAoZSt+Yf0D+zCvsrzsUCFZ0QGC5Pml/OQVRxb RDHD81uWrvetuUYW+A2wY2CifWLmaJfgQ2XIv7mdGz/rmb0Cmj6UzQ5Pi Dw++xuWvoyg6/yWKNPNHw7vvAJcXWQg45uR3M95nLeUqopEk/ANwWnszp g=; X-IronPort-AV: E=Sophos;i="5.90,149,1643673600"; d="scan'208";a="198951410" Message-ID: <667db455-737b-47c9-bc4b-5729687b384f@amazon.de> Date: Wed, 2 Mar 2022 17:24:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH 3/4] livepatch: do the initial build using CROSS_COMPILE Content-Language: en-US To: Roger Pau Monne , CC: , , , References: <20220302142711.38953-1-roger.pau@citrix.com> <20220302142711.38953-4-roger.pau@citrix.com> From: "Doebel, Bjoern" In-Reply-To: <20220302142711.38953-4-roger.pau@citrix.com> X-Originating-IP: [10.43.166.127] X-ClientProxiedBy: EX13D45EUC001.ant.amazon.com (10.43.164.107) To EX13D03EUC002.ant.amazon.com (10.43.164.60) Precedence: Bulk Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Transfer-Encoding: base64 CgpPbiAwMi4wMy4yMiAxNToyNywgUm9nZXIgUGF1IE1vbm5lIHdyb3RlOgo+IENBVVRJT046IFRo aXMgZW1haWwgb3JpZ2luYXRlZCBmcm9tIG91dHNpZGUgb2YgdGhlIG9yZ2FuaXphdGlvbi4gRG8g bm90IGNsaWNrIGxpbmtzIG9yIG9wZW4gYXR0YWNobWVudHMgdW5sZXNzIHlvdSBjYW4gY29uZmly bSB0aGUgc2VuZGVyIGFuZCBrbm93IHRoZSBjb250ZW50IGlzIHNhZmUuCj4gCj4gCj4gCj4gU2V0 dGluZyBpdCBhZnRlcndhcmRzIGZvciBmdXJ0aGVyIGJ1aWxkcyB3aWxsIGNhdXNlIHRoZSBidWls ZCBsb2dpYyB0bwo+IGRldGVjdCBhIGNoYW5nZSBhbmQgdGh1cyBmb3JjZSBhIHJlYnVpbGQgb2Yg YWxsIHNvdXJjZXMuCj4gCj4gU2lnbmVkLW9mZi1ieTogUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIu cGF1QGNpdHJpeC5jb20+Cj4gLS0tCj4gICBsaXZlcGF0Y2gtYnVpbGQgfCAzICsrLQo+ICAgMSBm aWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQo+IAo+IGRpZmYgLS1n aXQgYS9saXZlcGF0Y2gtYnVpbGQgYi9saXZlcGF0Y2gtYnVpbGQKPiBpbmRleCBlMTcxNWVhLi4z OGE5MmJlIDEwMDc1NQo+IC0tLSBhL2xpdmVwYXRjaC1idWlsZAo+ICsrKyBiL2xpdmVwYXRjaC1i dWlsZAo+IEBAIC05Miw3ICs5Miw2IEBAIGZ1bmN0aW9uIGJ1aWxkX3NwZWNpYWwoKQo+ICAgICAg IGNkICIke1NSQ0RJUn0iIHx8IGRpZQo+IAo+ICAgICAgICMgQ2FwdHVyZSAubyBmaWxlcyBmcm9t IHRoZSBwYXRjaGVkIGJ1aWxkCj4gLSAgICBleHBvcnQgQ1JPU1NfQ09NUElMRT0iJHtUT09MU0RJ Un0vbGl2ZXBhdGNoLWdjYyAiCj4gICAgICAgZXhwb3J0IExJVkVQQVRDSF9CVUlMRF9ESVI9IiQo cHdkKS8iCj4gICAgICAgZXhwb3J0IExJVkVQQVRDSF9DQVBUVVJFX0RJUj0iJE9VVFBVVC8ke25h bWV9Igo+ICAgICAgIG1rZGlyIC1wICIkTElWRVBBVENIX0NBUFRVUkVfRElSIgo+IEBAIC00MDgs NiArNDA3LDggQEAgaWYgWyAiJHtTS0lQfSIgIT0gImJ1aWxkIiBdOyB0aGVuCj4gICAgICAgICAg IFhFTl9ERUJVRz0iZGVidWc9JFhFTl9ERUJVRyIKPiAgICAgICBmaQo+IAo+ICsgICAgZXhwb3J0 IENST1NTX0NPTVBJTEU9IiR7VE9PTFNESVJ9L2xpdmVwYXRjaC1nY2MgIgo+ICsKPiAgICAgICBl Y2hvICJQZXJmb3JtIGZ1bGwgaW5pdGlhbCBidWlsZCB3aXRoICR7Q1BVU30gQ1BVKHMpLi4uIgo+ ICAgICAgIGJ1aWxkX2Z1bGwKPiAKClJldmlld2VkLWJ5OiBCam9lcm4gRG9lYmVsIDxkb2ViZWxA YW1hem9uLmRlPgoKCgpBbWF6b24gRGV2ZWxvcG1lbnQgQ2VudGVyIEdlcm1hbnkgR21iSApLcmF1 c2Vuc3RyLiAzOAoxMDExNyBCZXJsaW4KR2VzY2hhZWZ0c2Z1ZWhydW5nOiBDaHJpc3RpYW4gU2No bGFlZ2VyLCBKb25hdGhhbiBXZWlzcwpFaW5nZXRyYWdlbiBhbSBBbXRzZ2VyaWNodCBDaGFybG90 dGVuYnVyZyB1bnRlciBIUkIgMTQ5MTczIEIKU2l0ejogQmVybGluClVzdC1JRDogREUgMjg5IDIz NyA4NzkKCgo= From xen-devel-bounces@lists.xenproject.org Wed Mar 02 16:25:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 16:25:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282468.481186 (Exim 4.92) (envelope-from ) id 1nPRnV-0003he-HR; Wed, 02 Mar 2022 16:25:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282468.481186; Wed, 02 Mar 2022 16:25:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPRnV-0003hX-EY; Wed, 02 Mar 2022 16:25:53 +0000 Received: by outflank-mailman (input) for mailman id 282468; Wed, 02 Mar 2022 16:25:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPRnU-0003hN-0S for xen-devel@lists.xenproject.org; Wed, 02 Mar 2022 16:25:52 +0000 Received: from smtp-fw-9103.amazon.com (smtp-fw-9103.amazon.com [207.171.188.200]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6b785e72-9a45-11ec-8eba-a37418f5ba1a; Wed, 02 Mar 2022 17:25:50 +0100 (CET) Received: from pdx4-co-svc-p1-lb2-vlan2.amazon.com (HELO email-inbound-relay-iad-1a-1ac2810f.us-east-1.amazon.com) ([10.25.36.210]) by smtp-border-fw-9103.sea19.amazon.com with ESMTP; 02 Mar 2022 16:25:21 +0000 Received: from EX13D03EUC002.ant.amazon.com (iad12-ws-svc-p26-lb9-vlan3.iad.amazon.com [10.40.163.38]) by email-inbound-relay-iad-1a-1ac2810f.us-east-1.amazon.com (Postfix) with ESMTPS id 1CD6181313; Wed, 2 Mar 2022 16:25:19 +0000 (UTC) Received: from [10.85.98.33] (10.43.166.127) by EX13D03EUC002.ant.amazon.com (10.43.164.60) with Microsoft SMTP Server (TLS) id 15.0.1497.28; Wed, 2 Mar 2022 16:25:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-Inumbo-ID: 6b785e72-9a45-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.de; i=@amazon.de; q=dns/txt; s=amazon201209; t=1646238350; x=1677774350; h=message-id:date:mime-version:to:cc:references:from: in-reply-to:content-transfer-encoding:subject; bh=IShwUKZBNS2hmzlTxIY7r401dk03n4mPa9d2S0msMZc=; b=ZGYXXs5BBwWyrRP+qrCLHGpjkMia4OHv3sT6unA5kRmxAF2r4zdkFbwH SiywB8Qx1EUJo7GO45pvZNzFCqnk8Cb9+ZDzrofjLGf78x3jYsj4j5Jdz S0L3mtOKAo2EqcH+3rrJhrLCwetoyoHVrFOowlZdf4GUXWgDAvbxzISm7 Q=; X-IronPort-AV: E=Sophos;i="5.90,149,1643673600"; d="scan'208";a="996183590" Subject: Re: [PATCH 4/4] livepatch: differentiate between old and new build systems Message-ID: Date: Wed, 2 Mar 2022 17:25:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Content-Language: en-US To: Roger Pau Monne , CC: , , , References: <20220302142711.38953-1-roger.pau@citrix.com> <20220302142711.38953-5-roger.pau@citrix.com> From: "Doebel, Bjoern" In-Reply-To: <20220302142711.38953-5-roger.pau@citrix.com> X-Originating-IP: [10.43.166.127] X-ClientProxiedBy: EX13D51EUC001.ant.amazon.com (10.43.164.111) To EX13D03EUC002.ant.amazon.com (10.43.164.60) Precedence: Bulk Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Transfer-Encoding: base64 CgpPbiAwMi4wMy4yMiAxNToyNywgUm9nZXIgUGF1IE1vbm5lIHdyb3RlOgo+IENBVVRJT046IFRo aXMgZW1haWwgb3JpZ2luYXRlZCBmcm9tIG91dHNpZGUgb2YgdGhlIG9yZ2FuaXphdGlvbi4gRG8g bm90IGNsaWNrIGxpbmtzIG9yIG9wZW4gYXR0YWNobWVudHMgdW5sZXNzIHlvdSBjYW4gY29uZmly bSB0aGUgc2VuZGVyIGFuZCBrbm93IHRoZSBjb250ZW50IGlzIHNhZmUuCj4gCj4gCj4gCj4gRG8g bm90IGF0dGVtcHQgdG8gbW9kaWZ5IHRoZSBidWlsZCBzeXN0ZW0gaWYgQ0ZMQUdTIGFyZSBub3Qg c2V0IGluCj4gUnVsZXMubWssIGFuZCBpbnN0ZWFkIHJlbHkgb24gQ09ORklHX0xJVkVQQVRDSCBh bHJlYWR5IHNldHRpbmcKPiAtZntmdW5jdGlvbixkYXRhfS1zZWN0aW9ucy4KPiAKPiBTaWduZWQt b2ZmLWJ5OiBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT4KPiAtLS0KPiBU aGlzIGRlcGVuZHMgb24gZ2V0dGluZyB0aGUgcGF0Y2ggdG8gYWRkIC1me2Z1bmN0aW9uLGRhdGF9 LXNlY3Rpb25zCj4gd2hlbiB1c2luZyBDT05GSUdfTElWRVBBVENIIGFjY2VwdGVkLgo+IC0tLQo+ ICAgbGl2ZXBhdGNoLWJ1aWxkIHwgMjIgKysrKysrKysrKysrKystLS0tLS0tLQo+ICAgMSBmaWxl IGNoYW5nZWQsIDE0IGluc2VydGlvbnMoKyksIDggZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdp dCBhL2xpdmVwYXRjaC1idWlsZCBiL2xpdmVwYXRjaC1idWlsZAo+IGluZGV4IDM4YTkyYmUuLjY1 NmNkYWMgMTAwNzU1Cj4gLS0tIGEvbGl2ZXBhdGNoLWJ1aWxkCj4gKysrIGIvbGl2ZXBhdGNoLWJ1 aWxkCj4gQEAgLTk4LDE0ICs5OCwyMCBAQCBmdW5jdGlvbiBidWlsZF9zcGVjaWFsKCkKPiAKPiAg ICAgICAjIEJ1aWxkIHdpdGggc3BlY2lhbCBHQ0MgZmxhZ3MKPiAgICAgICBjZCAiJHtTUkNESVJ9 L3hlbiIgfHwgZGllCj4gLSAgICBzZWQgLWkgJ3MvQ0ZMQUdTICs9IC1ub3N0ZGluYy9DRkxBR1Mg Kz0gLW5vc3RkaW5jIC1mZnVuY3Rpb24tc2VjdGlvbnMgLWZkYXRhLXNlY3Rpb25zLycgUnVsZXMu bWsKPiAtICAgIGNwIC1wIGFyY2gveDg2L01ha2VmaWxlIGFyY2gveDg2L01ha2VmaWxlLmJhawo+ IC0gICAgc2VkIC1pICdzLy0tc2VjdGlvbi1hbGlnbm1lbnQ9MHgyMDAwMDAvLS1zZWN0aW9uLWFs aWdubWVudD0weDEwMDAvJyBhcmNoL3g4Ni9NYWtlZmlsZQo+IC0gICAgIyBSZXN0b3JlIHRpbWVz dGFtcHMgdG8gcHJldmVudCBzcHVyaW91cyByZWJ1aWxkaW5nCj4gLSAgICB0b3VjaCAtLXJlZmVy ZW5jZT1hcmNoL3g4Ni9NYWtlZmlsZS5iYWsgYXJjaC94ODYvTWFrZWZpbGUKPiAtICAgIG1ha2Ug Ii1qJENQVVMiICRYRU5fREVCVUcgJj4gIiR7T1VUUFVUfS9idWlsZF8ke25hbWV9X2NvbXBpbGUu bG9nIiB8fCBkaWUKPiAtICAgIHNlZCAtaSAncy9DRkxBR1MgKz0gLW5vc3RkaW5jIC1mZnVuY3Rp b24tc2VjdGlvbnMgLWZkYXRhLXNlY3Rpb25zL0NGTEFHUyArPSAtbm9zdGRpbmMvJyBSdWxlcy5t awo+IC0gICAgbXYgLWYgYXJjaC94ODYvTWFrZWZpbGUuYmFrIGFyY2gveDg2L01ha2VmaWxlCj4g KyAgICBpZiBncmVwIC1xICdub3N0ZGluYycgUnVsZXMubWs7IHRoZW4KPiArICAgICAgICAgIyBT dXBwb3J0IGZvciBvbGQgYnVpbGQgc3lzdGVtLCBhdHRlbXB0IHRvIHNldCAtZntmdW5jdGlvbixk YXRhfS1zZWN0aW9ucyBhbmQgcmVidWlsZAo+ICsgICAgICAgIHNlZCAtaSAncy9DRkxBR1MgKz0g LW5vc3RkaW5jL0NGTEFHUyArPSAtbm9zdGRpbmMgLWZmdW5jdGlvbi1zZWN0aW9ucyAtZmRhdGEt c2VjdGlvbnMvJyBSdWxlcy5tawo+ICsgICAgICAgIGNwIC1wIGFyY2gveDg2L01ha2VmaWxlIGFy Y2gveDg2L01ha2VmaWxlLmJhawo+ICsgICAgICAgIHNlZCAtaSAncy8tLXNlY3Rpb24tYWxpZ25t ZW50PTB4MjAwMDAwLy0tc2VjdGlvbi1hbGlnbm1lbnQ9MHgxMDAwLycgYXJjaC94ODYvTWFrZWZp bGUKPiArICAgICAgICAjIFJlc3RvcmUgdGltZXN0YW1wcyB0byBwcmV2ZW50IHNwdXJpb3VzIHJl YnVpbGRpbmcKPiArICAgICAgICB0b3VjaCAtLXJlZmVyZW5jZT1hcmNoL3g4Ni9NYWtlZmlsZS5i YWsgYXJjaC94ODYvTWFrZWZpbGUKPiArICAgICAgICBtYWtlICItaiRDUFVTIiAkWEVOX0RFQlVH ICY+ICIke09VVFBVVH0vYnVpbGRfJHtuYW1lfV9jb21waWxlLmxvZyIgfHwgZGllCj4gKyAgICAg ICAgc2VkIC1pICdzL0NGTEFHUyArPSAtbm9zdGRpbmMgLWZmdW5jdGlvbi1zZWN0aW9ucyAtZmRh dGEtc2VjdGlvbnMvQ0ZMQUdTICs9IC1ub3N0ZGluYy8nIFJ1bGVzLm1rCj4gKyAgICAgICAgbXYg LWYgYXJjaC94ODYvTWFrZWZpbGUuYmFrIGFyY2gveDg2L01ha2VmaWxlCj4gKyAgICBlbHNlCj4g KyAgICAgICAgIyAtZntmdW5jdGlvbixkYXRhfS1zZWN0aW9ucyBzZXQgYnkgQ09ORklHX0xJVkVQ QVRDSAo+ICsgICAgICAgIG1ha2UgIi1qJENQVVMiICRYRU5fREVCVUcgJj4gIiR7T1VUUFVUfS9i dWlsZF8ke25hbWV9X2NvbXBpbGUubG9nIiB8fCBkaWUKPiArICAgIGZpCj4gCj4gICAgICAgdW5z ZXQgTElWRVBBVENIX0JVSUxEX0RJUgo+ICAgICAgIHVuc2V0IExJVkVQQVRDSF9DQVBUVVJFX0RJ UgoKUmV2aWV3ZWQtYnk6IEJqb2VybiBEb2ViZWwgPGRvZWJlbEBhbWF6b24uZGU+CgpDb25maXJt aW5nIHRoYXQgSSBjYW4gYnVpbGQgYSBsaXZlcGF0Y2ggYWdhaW5zdCB1cHN0cmVhbSBtYXN0ZXIg d2l0aCAKeW91ciBzZXJpZXMgYW5kIHRoZSBvdGhlciBDT05GSUdfTElWRVBBVENIIHBhdGNoLgoK CgpBbWF6b24gRGV2ZWxvcG1lbnQgQ2VudGVyIEdlcm1hbnkgR21iSApLcmF1c2Vuc3RyLiAzOAox MDExNyBCZXJsaW4KR2VzY2hhZWZ0c2Z1ZWhydW5nOiBDaHJpc3RpYW4gU2NobGFlZ2VyLCBKb25h dGhhbiBXZWlzcwpFaW5nZXRyYWdlbiBhbSBBbXRzZ2VyaWNodCBDaGFybG90dGVuYnVyZyB1bnRl ciBIUkIgMTQ5MTczIEIKU2l0ejogQmVybGluClVzdC1JRDogREUgMjg5IDIzNyA4NzkKCgo= From xen-devel-bounces@lists.xenproject.org Wed Mar 02 16:42:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 16:42:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282484.481215 (Exim 4.92) (envelope-from ) id 1nPS36-0007B5-D5; Wed, 02 Mar 2022 16:42:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282484.481215; Wed, 02 Mar 2022 16:42:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPS36-0007Ax-8t; Wed, 02 Mar 2022 16:42:00 +0000 Received: by outflank-mailman (input) for mailman id 282484; Wed, 02 Mar 2022 16:41:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPS33-0006uy-5E for xen-devel@lists.xenproject.org; Wed, 02 Mar 2022 16:41:57 +0000 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ab1d5ade-9a47-11ec-8eba-a37418f5ba1a; Wed, 02 Mar 2022 17:41:55 +0100 (CET) Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 222EqFaW002562; Wed, 2 Mar 2022 16:41:38 GMT Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by mx0b-00069f02.pphosted.com with ESMTP id 3ehdayvpj0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 02 Mar 2022 16:41:37 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 222GM3eM163335; Wed, 2 Mar 2022 16:41:36 GMT Received: from nam02-dm3-obe.outbound.protection.outlook.com (mail-dm3nam07lp2040.outbound.protection.outlook.com [104.47.56.40]) by userp3030.oracle.com with ESMTP id 3ef9b18d4v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 02 Mar 2022 16:41:35 +0000 Received: from BYAPR10MB2663.namprd10.prod.outlook.com (2603:10b6:a02:a9::20) by MWHPR1001MB2144.namprd10.prod.outlook.com (2603:10b6:301:2b::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Wed, 2 Mar 2022 16:41:33 +0000 Received: from BYAPR10MB2663.namprd10.prod.outlook.com ([fe80::a0d5:610d:bcf:9b47]) by BYAPR10MB2663.namprd10.prod.outlook.com ([fe80::a0d5:610d:bcf:9b47%4]) with mapi id 15.20.5017.027; Wed, 2 Mar 2022 16:41:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ab1d5ade-9a47-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : content-type : mime-version; s=corp-2021-07-09; bh=JFdbPhdDPlCnQK0SS45U+jf4D54W/mP1h4d1i5XCiso=; b=l00W2czR5wnYc9ncNjUd9Pz1aWoXlXZr4kRBper4U7vCsZWzEttMguUob9UbftbbERfV ZQjT11RTnkpVIJpyD7SzR12YAuhDAyYWOQJmTCdpOWRsKSNfDbWiopF13k9PRDBF2NOV MgyVxiHVGpQ7qigbgHRVoBIljrDFtKgxu+EXG0ZPKcCK0kS0DAKJ1BHwDKwymPS6cRmP dkml3yl4nrCAUPizJlXhbaAvTpRL8IpR+Aff13fK/trPmxWDtn46icRXtwa8hLiLhGyE YGTyM8WN8ls6x7X8ONpPc40VTgvdYc2U5504XHbzSjOW2coRFzPx2msZOsiOJ1v9ZpVV EQ== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fsyudh48df6LQOGMRHAjNgml41B7eUX8m51hWVCv9q3K9L931Kh3QSyGwEZavglJe//2DbTZGUedc9KEqPJT0TOe9jnXv+2YDHD82vjHmlMzbA5N/9SqPOZE/upVaXGoJz4EVfRYbJWL29A8buJn5vLjx8u0G7wu7mb874GQgWsYkI6jf+lci6zdoNL76e2+4b+I43P5GbuTloNS3qygXDtdJ79/ag6o7yr8tcBpx6zBHs8EEuy5F6eEw6UT6C1NU+VEerTRB/qX5HtKU/p+mdytQW1q1x2Or3p2mOzT/lYM0a/T4uH+AB738qpe8PM6d/YVJ76mODU4IBbO2uOU7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JFdbPhdDPlCnQK0SS45U+jf4D54W/mP1h4d1i5XCiso=; b=FOv5okjTRxrqLshJ5XLt3eMonAp6rQs7lXXXjyBlRbVdoWGIXhIAm/lHMHZCHq00dyOMKU75a4YE3yimksVxDsOacyFhDh+1wjzgtYeRuC8SyIcQhb7hRzpUrXbeju55pNe9cjxExVq97cQLRRwmLg9RABCy53aLUFz7DD10lc+BAWyId6Qb9ew6IdszR+tikU86JdR4Rw+6cIVFCknYg0XOZm3MAo9DW3l8kv31IdNbyTOOeR6+/sJSuH+Q7r5i6fQm4wubn1fhLnVVvNz7fnC4v+MinSZTshxlW+JWIdfx0A5gEsVUt5Ha/eSQQg7/YafhIi9Z/yb04v0xGJvwCQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JFdbPhdDPlCnQK0SS45U+jf4D54W/mP1h4d1i5XCiso=; b=JUABIpk19itXwjdpv+Fy6EtcFTtO7M8cW5k7VYefpo4jZDeDMwazEEGdSVPxizWOkEcb7tcb5VcBfA0I/BtTjE+pWIrsTX3LcNeQ0ObxZK5CO+TAyT61Y9wPfHO31Xqw/Z8KnahcsSfXYN7TCGjILOkRWdQaYd24QjglhhfcjZM= From: Dongli Zhang To: xen-devel@lists.xenproject.org, x86@kernel.org Cc: linux-kernel@vger.kernel.org, boris.ostrovsky@oracle.com, jgross@suse.com, sstabellini@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, joe.jin@oracle.com Subject: [PATCH v4 0/2] xen: fix HVM kexec kernel panic Date: Wed, 2 Mar 2022 08:40:30 -0800 Message-Id: <20220302164032.14569-1-dongli.zhang@oracle.com> X-Mailer: git-send-email 2.17.1 Content-Type: text/plain X-ClientProxiedBy: BYAPR21CA0019.namprd21.prod.outlook.com (2603:10b6:a03:114::29) To BYAPR10MB2663.namprd10.prod.outlook.com (2603:10b6:a02:a9::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9f6f9cf3-e299-4c77-f530-08d9fc6b8245 X-MS-TrafficTypeDiagnostic: MWHPR1001MB2144:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cMoE7EI0lVtJ+y+qcFexp1j63RV38JqdXLLcW5hFr/SZw/zPd0sMTBT7/erz1RbhgsapuG5CXDzC8oFlHe0giy95VcwuuSEGT4EItMOpYReENuu5G08OepCcIZ8df855H90AmxrhfjG1uPt3NUTQcHHy05C1taSx5Kc/sey0O5GWrVJprkbF2zBNjr6soSr/ZUQKfbMun1iVFiWcTcO7c7tcVUcVNPk7cpI28PFSsmF57v/nx58Tog16jTHSohcSaSO2d3VDnOBLJ8cKSRj++8EG8EKYRzKGRk2wcAq1aWguqjSq+qbSxWUj5jGgKru4BvRgQa46PAF27WiDctKAtaBnG8HyWjZnE9MVAEs2aHloX6oVCyVZmakmxDdBrFOXSc7QmaMlXsBcXFXSiuwrAOKuQsOUiwwko6F6dA1uxM8+9xbPkRlHOZNJ3dF0Jmpw4aW8hcqCEsSXI65Kk0veukGuLOkRbRuD2CVaD1uj7/BS4jXnzFsKG3/AozpAhdesLu5QDCN7evtyIW7PYH580P1FyPczuAJY7q5HJNR8jAcEBWLexWUFK8l6N5opD5uOSgdPShdJo7HrQuBGYJKDTSByS3B2OYr055sqqG7gSJ78qNP1c6IuYQYoS8BZxx7nfdHBAltY1C4r/EpCSIKEjfbhgVQhIsudSeE0SPgjoAxxZA7+NwiKSKqUgIBhbEpIoEPnm0C83pRbBmnx5ERemcfQHocjfRdfnvalDUC8UWHky8RPXbiZyZSIk9dD2hhu8qg8z9DBQ24EGpHzx5c1TYSULMUcjKLggymVpe6DCZo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB2663.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(83380400001)(66556008)(36756003)(2906002)(44832011)(5660300002)(38100700002)(107886003)(6486002)(38350700002)(966005)(86362001)(508600001)(8936002)(1076003)(186003)(316002)(26005)(6512007)(6506007)(66946007)(8676002)(52116002)(66476007)(4326008)(2616005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?lHfiFVwIpOfWVnOLp++aqrzKojSKhWU9PBhlaEpeMdpLQDmmMHgO7kpIyH09?= =?us-ascii?Q?bkcDcrTFZfecrxCzel9vJOtNDFgdflfflNDU+sz3hAH8WQuGkOzW2XfxXCDh?= =?us-ascii?Q?rXRlCRjOYtKvHxloEkubA7KK3xOx8KJjVCRHtdTtfDWJW82IQ/P7sPHBwp89?= =?us-ascii?Q?PGKUxJIlH8Zdaf6K9Bwenf5Rt4plizNpRr9J9+ZQervmbueVkOzLtZbNOf5u?= =?us-ascii?Q?JfSt3o2UMVwTvXQ77fUvj3oKO3A9htrGaFUwS+xwugWXyMHZpPfHi0hz1beE?= =?us-ascii?Q?AbipwOxx+4iYdoGx20PtOLwHqERwsZtgHdjP5oPcnmbLBbO4fNmEeMylZEEC?= =?us-ascii?Q?rxGTPXat9C/r4zJ9eA6EqEF09lK7Ae6lQsu8pKrMQW0ykDuVA3AbJimhFfyk?= =?us-ascii?Q?dqqdv8t8Kl8m4UI1AibZiZBU2Ikc76W+h6B1b56AeS9WqUooM8IzbzUwWvKs?= =?us-ascii?Q?FeZ7Ct1CXZpohOMJkINuWjftJTQdn/BQ3RusaisJL63uYW0QWRIzYrg21sLv?= =?us-ascii?Q?NlXYZA5vi+MvQ97aKpjadrJCPTJdoOwDP1feOmr5T+Kw2T2IWJZgbqX6rPgk?= =?us-ascii?Q?gysoT/YURmc2C9TrUmjQdhZVhEdhLXHMEDPqa+cLHJ3h1JRxIlTQiJBD2f/I?= =?us-ascii?Q?eqIOZhPUsumPlPHQxCCHZyJL5qQV2w10fDQo0McDVGFhOEMMAk8eAz/9m5bZ?= =?us-ascii?Q?tLIuWeKzVPRWXDspKR1e6xOFs31fXlreVSHTjTiP/tzr8OAnKp5mDcTytUAb?= =?us-ascii?Q?10EM9gwx5TSjiZNF3dgDejAJsFow6/tFTnWNaxMMCwAR+RquId+OeJt/1mNv?= =?us-ascii?Q?1x3nFxxwL6Q0oYDpPrXA8OlF4dQS+xd/VWpYHezbwYpat5qZuPHtdTCORRur?= =?us-ascii?Q?Of7dTofsV4W0edXt1L4kACdPkl6bjp6uV+GJDgZBwaVImPMRml9uqNGQxSX6?= =?us-ascii?Q?Kxf/6YWVn4X6whXcVhK0WqGz4WqtnBJaeKVoqzXIUqQpWqC9EP9UuZSZHhjP?= =?us-ascii?Q?vhYcU/foYRrT0TTO/bjRXgKvh7/1l6IN+ifb4BdhJMLqgbX5jnNp5y8AE51j?= =?us-ascii?Q?lJBpGFqYlo8nsQoCcTukcxMWfLO0Wx7b4yYQkvXZAiHxLUYuLCUlbzM1NSLH?= =?us-ascii?Q?mOOkWYKWWxLROV4P3O5xpWjJEUPFQTFOCSXMJhPSCsbRtWcXm/0p0bZQB1PL?= =?us-ascii?Q?tWEcr58uMgswcaJpmXGvj9Rc+rAEuSggLyHCPtp7s2cjLwSUPP8rG7EvxMl+?= =?us-ascii?Q?NRb2OHW72/jHAmLmjkLwdhgQs0Ojl+vHvhhi4B42hVoa/g/6APA21aQUNLhp?= =?us-ascii?Q?N5256UZMOluewH6COVtSIYSKy8mpuD6qCxcJVSoYkM7yEN6bU22+wkFBbti7?= =?us-ascii?Q?p3b0S3saiv+x2TLrzu/5arqDGoDHH5ln6s0qWJpzPH1NuG+3dWT1B8pvHreB?= =?us-ascii?Q?g4NGQKY5Jh+J65pZizMOX96JxGJopehZX+mJVsnSb2cJCaha0q2MkvKzNLiJ?= =?us-ascii?Q?yE2c5iHLHnB/LdUOYoD1dIV0cXjSNf99qzrT4C4nIZjz2TzCk+7Od8Edyr1O?= =?us-ascii?Q?X6Wjra+9CGn5tBLJpm3Ah/rWYVydNeXq7CK7caYfLetJ4PEHiGvJwGQeuOn+?= =?us-ascii?Q?kf8Ied06QBgQItJ7bThZg/g=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9f6f9cf3-e299-4c77-f530-08d9fc6b8245 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2663.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2022 16:41:32.8990 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SKOZdcl3103R+IM5Y/Xtux7FgltL7Z+mXnoZtzIbYIBTpk+mD9OaM+5CNxx8glN6iUhyk7F/bdSsQ8Hq0WHGcQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1001MB2144 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10274 signatures=686787 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 malwarescore=0 mlxscore=0 phishscore=0 suspectscore=0 adultscore=0 mlxlogscore=884 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000 definitions=main-2203020073 X-Proofpoint-GUID: xXDSAq_1d6cwUWbM5pPTW0sa8aJxUnex X-Proofpoint-ORIG-GUID: xXDSAq_1d6cwUWbM5pPTW0sa8aJxUnex This is the v4 of the patch to fix xen kexec kernel panic issue when the kexec is triggered on VCPU >= 32. PANIC: early exception 0x0e IP 10:ffffffffa96679b6 error 0 cr2 0x20 [ 0.000000] CPU: 0 PID: 0 Comm: swapper Not tainted 5.17.0-rc4xen-00054-gf71077a4d84b-dirty #1 ... ... [ 0.000000] RIP: 0010:pvclock_clocksource_read+0x6/0xb0 ... ... [ 0.000000] RSP: 0000:ffffffffaae03e10 EFLAGS: 00010082 ORIG_RAX: 0000000000000000 [ 0.000000] RAX: 0000000000000000 RBX: 0000000000010000 RCX: 0000000000000002 [ 0.000000] RDX: 0000000000000003 RSI: ffffffffaac37515 RDI: 0000000000000020 [ 0.000000] RBP: 0000000000011000 R08: 0000000000000000 R09: 0000000000000001 [ 0.000000] R10: ffffffffaae03df8 R11: ffffffffaae03c68 R12: 0000000040000004 [ 0.000000] R13: ffffffffaae03e50 R14: 0000000000000000 R15: 0000000000000000 [ 0.000000] FS: 0000000000000000(0000) GS:ffffffffab588000(0000) knlGS:0000000000000000 [ 0.000000] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 0.000000] CR2: 0000000000000020 CR3: 00000000ea410000 CR4: 00000000000406a0 [ 0.000000] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 0.000000] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ 0.000000] Call Trace: [ 0.000000] [ 0.000000] ? xen_clocksource_read+0x24/0x40 [ 0.000000] ? xen_init_time_common+0x5/0x49 [ 0.000000] ? xen_hvm_init_time_ops+0x23/0x45 [ 0.000000] ? xen_hvm_guest_init+0x221/0x25c [ 0.000000] ? 0xffffffffa9600000 [ 0.000000] ? setup_arch+0x440/0xbd6 [ 0.000000] ? start_kernel+0x6c/0x695 [ 0.000000] ? secondary_startup_64_no_verify+0xd5/0xdb [ 0.000000] Changed since v1: - Add commit message to explain why xen_hvm_init_time_ops() is delayed for any vcpus. (Suggested by Boris Ostrovsky) - Add a comment in xen_hvm_smp_prepare_boot_cpu() referencing the related code in xen_hvm_guest_init(). (suggested by Juergen Gross) Changed since v2: - Delay for all VCPUs. (Suggested by Boris Ostrovsky) - Add commit message that why PVM is not supported by this patch - Test if kexec/kdump works with mainline xen (HVM and PVM) Changed since v3: - Re-use v2 but move the login into xen_hvm_init_time_ops() (Suggested by Boris Ostrovsky) I have tested with HVM VM on both old xen and mainline xen. About the mainline xen, the 'soft_reset' works after I reset d->creation_reset as suggested by Jan Beulich. https://lore.kernel.org/all/d3814109-f4ba-9edb-1575-ab94faaeba08@suse.com/ Thank you very much! Dongli Zhang From xen-devel-bounces@lists.xenproject.org Wed Mar 02 16:42:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 16:42:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282483.481203 (Exim 4.92) (envelope-from ) id 1nPS34-0006vG-0a; Wed, 02 Mar 2022 16:41:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282483.481203; Wed, 02 Mar 2022 16:41:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPS33-0006v9-Tu; Wed, 02 Mar 2022 16:41:57 +0000 Received: by outflank-mailman (input) for mailman id 282483; Wed, 02 Mar 2022 16:41:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPS31-0006uy-SM for xen-devel@lists.xenproject.org; Wed, 02 Mar 2022 16:41:56 +0000 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a94a1cd7-9a47-11ec-8eba-a37418f5ba1a; Wed, 02 Mar 2022 17:41:53 +0100 (CET) Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 222EqN0j005345; Wed, 2 Mar 2022 16:41:38 GMT Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by mx0b-00069f02.pphosted.com with ESMTP id 3eh14bxe2c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 02 Mar 2022 16:41:38 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 222GM3eO163335; Wed, 2 Mar 2022 16:41:37 GMT Received: from nam02-dm3-obe.outbound.protection.outlook.com (mail-dm3nam07lp2040.outbound.protection.outlook.com [104.47.56.40]) by userp3030.oracle.com with ESMTP id 3ef9b18d4v-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 02 Mar 2022 16:41:37 +0000 Received: from BYAPR10MB2663.namprd10.prod.outlook.com (2603:10b6:a02:a9::20) by MWHPR1001MB2144.namprd10.prod.outlook.com (2603:10b6:301:2b::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Wed, 2 Mar 2022 16:41:34 +0000 Received: from BYAPR10MB2663.namprd10.prod.outlook.com ([fe80::a0d5:610d:bcf:9b47]) by BYAPR10MB2663.namprd10.prod.outlook.com ([fe80::a0d5:610d:bcf:9b47%4]) with mapi id 15.20.5017.027; Wed, 2 Mar 2022 16:41:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a94a1cd7-9a47-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-type : mime-version; s=corp-2021-07-09; bh=NLQhFdDbco3Q7cD64mKoFgRLbwwsjMsi9EPxf+xOeIU=; b=I3SFkg9PLeyuuNe0xp5w7RO5vlTDIbeoeYTrn+gPlNCByBEOBEktUrbAbV/WKSjShAum 1Uc62fXb8x8H0EJeSaHi7Jjj0nfYqkhTl0nzJLajIygaWkGB5Sq0g09TxG9A/5kq3res li/VJSBpPlsQYrPcMFFT7mLnotEOeUhXQ0u/pz0CyPRQYX1qxLVlv5Sx1S8CbbIRVmmf nNGDRiEz7jbnpw34Pon7MQ2tq1wcQyDxSy9ULb0vTnc+XIbpBMUvu4nRMB/BB8erf1rl Uy/j+6BSpLub7XzZjirfVNoTKgksyxOdr3EtcWdwIpTZWFmzCHR+56rh5KQJcIbw68KC Aw== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D//FRXBpoeZGoDH7GlMR2v+ZnbKbfRnVvleWRNeGTUdg/RKmpqSrhrDlCvQaNKyZKzUNzwL0ZnrARIBRumkSWIoBTXP7nJ6/htvKRsv4ke3I5jN8uHVtUts8njQJ4UbbitOwiP097oSaDHDwEu8vHHnQtPYl1lFvUochaQk2HcuNxv5P2G94HqjeYs88GrdKtIaHPfu3cZTaAHU6K3Ljv7eVfWooui/AQayCA4Y1SbFUMKn+HT2zaC4ldotszHa+OWyFQt1bSZwJuz1Tt4RsfhsI6kvGEh3/wzEjbEnKgdLVSbC9HZ5k05TXHhbhXolo/pkPokoUSTtq7ny3u/ZLaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NLQhFdDbco3Q7cD64mKoFgRLbwwsjMsi9EPxf+xOeIU=; b=ZLejBnI3k8TcrSOOqG6QrkWmlpFQU6qtCRsDk0Jz11fwgXC0nuYWYow4ryvVhi4zKtORShkKO3OWTvt4+l8z+ZWIB++GMOcihhLfQyWp98j30DvgFM/+JbkURcc+8d1t2sijH2XbHLcwK4uX61KrVGwoiKi5PaWlNGIKEFm/MqM9Js288lM+K/bcYY+HmTX2DOBkZm+TXFXalIdfO23BEEDQmxwSfXNypyqfQc1ocPSXOHQCsA7TASfHlcEPxMj7Lm+PDJBv2/r7xPnsYqtQfrcXi6cNXXg8Du1Fu8g3obtKCEfHM0q6gviEo5YsFtUjK9DsWxYuKiv2coLk7i/dEQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NLQhFdDbco3Q7cD64mKoFgRLbwwsjMsi9EPxf+xOeIU=; b=B4ahnZvHX78AknjNaklHE9TJT0Rpfr90yKbe/0vkDcedGZu3n8LrRc1KpcnyI+TyX2JFZFl5iYLclg2Bu9EOHMgXEB5UbNYSUn3ex/7dhL8sv+7t0lFNLgl20Y/gliNXNx6S1hIxm6D1deaTNwJxhvLDEH3Fw+9HbtoVlD5pO/8= From: Dongli Zhang To: xen-devel@lists.xenproject.org, x86@kernel.org Cc: linux-kernel@vger.kernel.org, boris.ostrovsky@oracle.com, jgross@suse.com, sstabellini@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, joe.jin@oracle.com Subject: [PATCH v4 1/2] x86/xen/time: fix indentation issue Date: Wed, 2 Mar 2022 08:40:31 -0800 Message-Id: <20220302164032.14569-2-dongli.zhang@oracle.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220302164032.14569-1-dongli.zhang@oracle.com> References: <20220302164032.14569-1-dongli.zhang@oracle.com> Content-Type: text/plain X-ClientProxiedBy: BYAPR21CA0019.namprd21.prod.outlook.com (2603:10b6:a03:114::29) To BYAPR10MB2663.namprd10.prod.outlook.com (2603:10b6:a02:a9::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1b9d917c-880d-4ecc-8cf0-08d9fc6b82a0 X-MS-TrafficTypeDiagnostic: MWHPR1001MB2144:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BOAOOwEnXtxf/3GBye9xL1e1O08uocpcqxFhwv0M4vQjWVskdHzqqhcVJkAJ4g4G5eech8HlXL0wiKvtZVeCg/c7dA5LtR5kkWXiMKyu04VgbP7/U+HDZADt7ow4bwdggzF6v6MGhZSwEpsunz/qmAd4rPEtk5C2DL9r/EwWDfgVhWyWAuQ92BLVImIDCwDDHPgEDYkLLxeNuD4ME48jNQpwKSXRDlLLsXai3v4ewWqTYW3INB3wKoQBdyoqdmxJ1wdyEhBu3hnPayYWoifvUGK5vwSTP+gAsw+4itD8XpC7jzP2MG9I/tBO1OoJuObIQGEhvcKkNXRI4AndSmJjm2zqDh3oMYIP7i6g5LcsZjlTfXlk6VOX7WR4i0UQmGVcGT//zOr6AlH1xwLC7wCrJ5FwurGUYgkC61UYnD/XoMTOf6UTMhx18+IKJn4FLIr5N3KY2RmRbWlvJktEm404gni7eYW6fc3xdgVePUAng7+YPMHz0Zzkl4S6RbYsnYlqU61RgzwX0k1v39u9udJgLHO1qk6Z9eeKrlVH0pSjBRrkbGT//ojwkTo6DNuTt+HnAtTAyuznavDKOCccAs0rpIE4M3Zjv8nzqQ6BmvN2KvoDVT/RsAcTsUslGCMkg/ZFRZ4utrBHPgGUeDyaieeWJ+bt80u4THW2QSByZKi6J9oVtBGDjo2RZ/ItgImz9ECwb6pvRSCm7LLtrGCEY/g08A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB2663.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(83380400001)(66556008)(36756003)(4744005)(2906002)(44832011)(5660300002)(38100700002)(107886003)(6486002)(38350700002)(86362001)(508600001)(8936002)(1076003)(186003)(316002)(26005)(6512007)(6506007)(66946007)(8676002)(52116002)(66476007)(4326008)(2616005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?vKJCryAhZW3FKQFev2LQFqrIPC+QtMGFsOWVlSPJUXBAP7O+m95iX76HZ4aE?= =?us-ascii?Q?c4OlSNA6mim5h0L44N+CCSHX4SvY+urV7xmsaQOhkZVy9zijuhESdgMfRsXl?= =?us-ascii?Q?Mdxf6idSZTG6NO+ujf7Ca8GcSMbHUI74QnxPyLXPfWHFTpTNEoV8e43DKV70?= =?us-ascii?Q?xPm8APAH9Qm51No8zBtP/VBibNnr2Ec1TMHWzCmEtawUqrIvFWmuV84EVVjk?= =?us-ascii?Q?PIj7F50M1r+LuKx9ydUoG3AuKFqgqzYRQz3BdFFRnHgCZF683DrzwPEdZ1pq?= =?us-ascii?Q?ZgZjfgeQHpDlRr+3LfTb2JZNUZ2IITSlCCo2tVYyI3pSuapnD4jyFvo20Q2S?= =?us-ascii?Q?oSq2iscBKnDV8o4Poe7XQUzOEgYaPQr1yAuj71jee8sFBmSYaxPVEKrFaMn+?= =?us-ascii?Q?qJYyCLBFZ8WmnjmnCWuQ2jfcXF0NNjn+51AjiV19ghBcwz9mIXaoStAIMi3C?= =?us-ascii?Q?+YhvuqlurEzExMoatda1qG8Df5GtvbYvgaoTQnx4v13snuh7wZNmuH5qcwPh?= =?us-ascii?Q?43+SjjAbB+fnnjQDTB8FLiHcobx9tgrILQN6SfMwocm0SSxv7nvNSaA1ogf8?= =?us-ascii?Q?IBgTwqakggICggsSWkUK/4fs1KatSRPIXS2rkcTMDUlFbWlZ8Q46ZG9eF3kl?= =?us-ascii?Q?69ecuxOSxb+DXGNzQUPtQBj1TqcU9mO92i8DRrReiKlMwu8tXlDpxIYMdJhQ?= =?us-ascii?Q?qYsg51TTeYJoexLeHJIPJTlB4WE19Sl1wzwAqenIAFBMP7pag/ySSMge18z3?= =?us-ascii?Q?BnUlUoXT4Vi98l11GTw1rKNKONMykpixMssadvUUIJLzh0jLq0Jqs+mw9Wry?= =?us-ascii?Q?rtEMQPI+DIcuKd++JCAjZF6xohjlNqO0STJT17VneGiNyLvdeeptvXrTfqC7?= =?us-ascii?Q?a6pkY2ftwin7sfemDhNbAsNKfB6254kPv2CHLfKLCb7X+9NOgTewwxwKVGiQ?= =?us-ascii?Q?2RAwtESY9OgeXS1K4UWx5OI6C2agYY+gFzq81DxEz2bCm7OaLY4WD46oi0su?= =?us-ascii?Q?k2Q9DE22EzZ/kotTa9hm/igtPQtvcGrbDhShOkoZzd1PzMqrhmywikhiDUeQ?= =?us-ascii?Q?FCBnl6N/OL96VKTR7snImx7iooMMk0qEqLar7sN24FPKlPNz05wxWvFvdRS/?= =?us-ascii?Q?OeXVTdoqmBjmNlCTWUp26MH1iwrHk5PuW9aNR3vOKz/H7WxbH4L6QPQeSe+v?= =?us-ascii?Q?ZcxUYTPV81dcX/0msyIhKxN+H8y3y/N45ymYCNgoXMLPLtttA72baGOI95gw?= =?us-ascii?Q?Iv3jw/+Cl5Gb9Wbx9ziDhWmwPPlSq4rH6R2rzvbftdBC2dwOTKcHpoHdQOLv?= =?us-ascii?Q?vHJzrqumlA8vRdFmFsCJHx1HQuiQiHBGn8ztMOObWsK2N3rTVIsRctKeOFTu?= =?us-ascii?Q?t1aSuQOLdoGlgMbmIqToFiw9gOKvrCLunEAOieBeF6tFEBow0tdr9GApUL12?= =?us-ascii?Q?G4bFHRXbjNBNvgQgkvZwaE2z1qgzGQwWzukj8Tx5HS99EXjc32ePlVU3efIP?= =?us-ascii?Q?Ya8zC6IIOYcWb5BZEWAJKT2lL+ORhL3VvRa2NXSyo3YC7c1aoBXwVxr4uYNH?= =?us-ascii?Q?eqmkey9vuSy2sJcnI+NqgvHGiLuf/Qg4MqMwonWc94Rr02mZ9Q3vztxTetd/?= =?us-ascii?Q?b/bOoxExoMTaACZRBblJ76M=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1b9d917c-880d-4ecc-8cf0-08d9fc6b82a0 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2663.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2022 16:41:33.3989 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: a7tealzHKi2/Y4MUQ6jZSpoZBmB2kqqrTwCwXcX8MgfQpHBReBLJlAyfYrSQnPkRWlifeiHXD2sb2wnxJegnpQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1001MB2144 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10274 signatures=686787 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 malwarescore=0 mlxscore=0 phishscore=0 suspectscore=0 adultscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000 definitions=main-2203020073 X-Proofpoint-GUID: xPsxU6gPkrmz3Wlg0gwV9WTg5hs2wqHP X-Proofpoint-ORIG-GUID: xPsxU6gPkrmz3Wlg0gwV9WTg5hs2wqHP No functional change. Signed-off-by: Dongli Zhang --- arch/x86/xen/time.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/xen/time.c b/arch/x86/xen/time.c index d9c945ee1100..55b3407358a9 100644 --- a/arch/x86/xen/time.c +++ b/arch/x86/xen/time.c @@ -45,7 +45,7 @@ static unsigned long xen_tsc_khz(void) static u64 xen_clocksource_read(void) { - struct pvclock_vcpu_time_info *src; + struct pvclock_vcpu_time_info *src; u64 ret; preempt_disable_notrace(); -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 02 16:42:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 16:42:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282497.481225 (Exim 4.92) (envelope-from ) id 1nPS3z-00082C-M2; Wed, 02 Mar 2022 16:42:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282497.481225; Wed, 02 Mar 2022 16:42:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPS3z-000825-J5; Wed, 02 Mar 2022 16:42:55 +0000 Received: by outflank-mailman (input) for mailman id 282497; Wed, 02 Mar 2022 16:42:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPS3y-00081z-66 for xen-devel@lists.xenproject.org; Wed, 02 Mar 2022 16:42:54 +0000 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cd72a3d4-9a47-11ec-8eba-a37418f5ba1a; Wed, 02 Mar 2022 17:42:53 +0100 (CET) Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 222Eq6mO010129; Wed, 2 Mar 2022 16:41:39 GMT Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by mx0b-00069f02.pphosted.com with ESMTP id 3ehbk9cwys-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 02 Mar 2022 16:41:38 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 222GM3eP163335; Wed, 2 Mar 2022 16:41:37 GMT Received: from nam02-dm3-obe.outbound.protection.outlook.com (mail-dm3nam07lp2040.outbound.protection.outlook.com [104.47.56.40]) by userp3030.oracle.com with ESMTP id 3ef9b18d4v-3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 02 Mar 2022 16:41:37 +0000 Received: from BYAPR10MB2663.namprd10.prod.outlook.com (2603:10b6:a02:a9::20) by MWHPR1001MB2144.namprd10.prod.outlook.com (2603:10b6:301:2b::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Wed, 2 Mar 2022 16:41:34 +0000 Received: from BYAPR10MB2663.namprd10.prod.outlook.com ([fe80::a0d5:610d:bcf:9b47]) by BYAPR10MB2663.namprd10.prod.outlook.com ([fe80::a0d5:610d:bcf:9b47%4]) with mapi id 15.20.5017.027; Wed, 2 Mar 2022 16:41:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cd72a3d4-9a47-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-type : mime-version; s=corp-2021-07-09; bh=lg9XKOy6opyS7UrsVBPxdV8zBBRDaWAGpVrxi52azCg=; b=00BS+lc8ZMiwhpP2fb0nb3d23jpNDzyk7ONwLFmIITJ1y5fv3V9oqYIIej9nogJnM0AC FwWfPaGgUxqgrBCKGIWPbmutZwSa4xzPqqrMlQLQY0V7+J8RdxKjaGrsCdHLt3HuzYDD AOxkka/U9/P3YbWKW3O25fpNTsFjmJsvCjcIwaELlOrMMz5rSdilfSE3KikNi2aUKZQ7 OKpFL5SfWe1Mg5ZI1dC6RMSwT6BRLxxhCbyDutP9bWeiP1Pboz7r3liocWaUgcjylba3 9oZW13HIznpD4k2dNv5GAchaMXyr0CXpyqnBxVeT91h9fMf2ys0RPRaSzoPAlOdgx4Fu 7g== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MItzig8dWH9dnsScU1iZAdeug144LM7aW/IP4SUsLyF+MVzbqjWtvMc7HVWgtYxRjLG5r+Qg1x+wXVEwoE1ncIx8fmSMpJj9EOFX764PZCZ1/1pskytPRV4lxjlx/cEtlDM9fQx3mhGfFiIZBylVIlNMMOcpQ2GH0v5GJvANq+V4EQ9v9qdJ5hdUbG5g/Rc1bhfcC2aaTq/houPecpCOjV4yw3X3ZCdDeZWZlu1bIWfm90rftzW47ijhDjt+DnP5e6rSm2CXIQNza200oFDBqUiaMOwxT1iVIsO3giPV7od8iwtu+i7R6OoMTcRK/G4E90rhuelEfr5jPExsvmX5ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lg9XKOy6opyS7UrsVBPxdV8zBBRDaWAGpVrxi52azCg=; b=lqjd5CcCsoFb6NgayGM2l5P4+N8CjHdVjA2b54akAC3PfXYo94jIByx2VTLqmk/wK33Ian03Gws4tOEFqTraQlOvnbpUTXebaJg6E/os6z+nQuzKecOkHgzF0a6vuWDLli+gteYJNvlhKjp5CqNfWXUubA8ndzHw+r15FaYBXR1gOr/3BwmFZUaMTj5SuewQtkHW8F4VbfqF8PCiQXSqpajbF3FYRCI8A5KxviTUDVNZNbnl4NxCWwoCOFajK1FmO1k4xhHd6p3M4w3/oLvedZ/Emj4ul3Up7rMqlrFozi60Y5h06h7D8ZPjqJYJlt+ajtGPF4FsvnonfhXwjwZiZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lg9XKOy6opyS7UrsVBPxdV8zBBRDaWAGpVrxi52azCg=; b=Phq7eGknBjDCXWbVofHPUZ/QGKXTZNhyct0qFmqI2mbMWkGSNieOB9b9CPP8t+KIIRvyQqYXzv4HcbYeOYWoJMQjvD/faRU4i6S2rfmlfa61j0K1acpwVTEQ7VIUSeA++3v+BYzbcyIvmHZ0yIG2SvKgyMKMvBIag0rD2BrHTVg= From: Dongli Zhang To: xen-devel@lists.xenproject.org, x86@kernel.org Cc: linux-kernel@vger.kernel.org, boris.ostrovsky@oracle.com, jgross@suse.com, sstabellini@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, joe.jin@oracle.com Subject: [PATCH v4 2/2] xen: delay xen_hvm_init_time_ops() if kdump is boot on vcpu>=32 Date: Wed, 2 Mar 2022 08:40:32 -0800 Message-Id: <20220302164032.14569-3-dongli.zhang@oracle.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220302164032.14569-1-dongli.zhang@oracle.com> References: <20220302164032.14569-1-dongli.zhang@oracle.com> Content-Type: text/plain X-ClientProxiedBy: BYAPR21CA0019.namprd21.prod.outlook.com (2603:10b6:a03:114::29) To BYAPR10MB2663.namprd10.prod.outlook.com (2603:10b6:a02:a9::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e6c7a851-a288-4101-9d60-08d9fc6b82d2 X-MS-TrafficTypeDiagnostic: MWHPR1001MB2144:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cXzcLtN367nYb75mjgBNknNLsWj9dDgUUPKuW34dBXyRfAXX4F0sAMGb9LZU+sI75WUkgUuc5abpViiqN4kL2HCHSNXS/4WFlUSZZhhPqtIH50QaO3YSPPnm5iKyJstlMJ5P8KQDdf+2/y8tZsIULi4wo8S0TP76zIerCVtXI6OOAMuXQt9sZ/sGq3R75SdhOQhgRJVmRdDSYSR1El4GT+hiasArpdgXZ+K6O7J/d2s4sLL1yF2A8EtYuDeV+RkS5PWZexV+Qz20Pd4yOO0KE7bk8cIzNpHXSA9AhM7ySBtt4BE1p/qYeE5kATOVrdlRA+IbKJpA9s8MgCVed1DpLscD/0Xl6u8cXSjBVu5pOfJFi6or6T9da1kLIEVBNlir1s7Nf09dj7o5ZywuYJUsC9C3KZmU/OPWqRqd4EDbftQ7YkQooP7VPU2VXB4xo3KIeMpVKVN1mW709oGLNgXhPyzeSidh2Qx7wwmr7XaB9AQRqjSdwWkEWD37QXkktohwwo+swpFAlLFHKtKMRngUqgTvDRaYBpn1VLEWZ61U1wje6Knj0QVBOGqFxTjJB6F5yFN7hjxpkBpNYejOuJwB9F6NGBMAos9Sl38Ialvm2txIljFo+T/mSSsiyzG9+pAN3moiXrQKisfoMAoxDD4DjMpFTMJhraCr47OzLAOQFmUMfqpLNeLbrZqynIGTBoa79HReMoVkXoYrm6HPx9Fg7w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB2663.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(83380400001)(66556008)(36756003)(2906002)(44832011)(5660300002)(38100700002)(107886003)(6486002)(38350700002)(86362001)(508600001)(8936002)(1076003)(186003)(316002)(26005)(6512007)(6506007)(66946007)(8676002)(52116002)(66476007)(4326008)(2616005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?dOP///kj3fAaOgnhY7LTb31y6qH/A3m0+YO1aKOod7OIRuieNNMitZODQ1yt?= =?us-ascii?Q?YO3IIzFOb610lRl3MBrE0UOBPCldK70iQVIDa5Bv46yQLnHflde/6n/3zwsR?= =?us-ascii?Q?DKD3xO40OsUfFPh+AWWakQHqS31RB/pmn/cFAfGHQFPhglofbq+GUzqIHpXc?= =?us-ascii?Q?pFmRbWSN+0ngplFtuTqnEAymp3X0Sp2IhC+xksSJ4xHLRMTOiJDsdIUKlNWg?= =?us-ascii?Q?yY/qopm4Dafr8ODhvCl8iQKk/Cgh6QvQz2StFSRTps4vzwoRtQNg4RSKetQM?= =?us-ascii?Q?7U2bRK3RnTlOHmBQG9OxdHgZVBPA6If9HjDotySzIy/JZkugchpwDr261hqI?= =?us-ascii?Q?KYz7OnWQ2L63Qo3ybV0hL5MKqXv/0ZbwT7un8hdKRdkyMEoDiMgUwbZdzsw6?= =?us-ascii?Q?5IRrhrUqYYKq5FvGrFFC9tpcVy5xiKX8ROTxE5WTG56uUQjEsjtzl4oZhynx?= =?us-ascii?Q?LYcg0G57VAzxF8WNzA0tOvg7i49pzOWI6ox7X21JiIyieJnoOtZGI5Vkiv/R?= =?us-ascii?Q?Exrju77OGuXPLRlqaGD7qlAmNdVHk9OmhDHur2FuXYnM8uIE1iawhsCSHAXO?= =?us-ascii?Q?+e2V/88i1VrFm5A0z747bqRTIkHqCBJis8mbLdhg+UejCSmcR8hW3o0b+6qz?= =?us-ascii?Q?8TOyI9caH/qLZA3yZneykNz9vo82v89ts7XOFMy5yk2jVcB6lXFQL0+NUCNW?= =?us-ascii?Q?4zUIbXAKcsgDIl5cE/hMVm0EHNL90pypnigBJ+klUBI/ZreoCJkM6w1lWxc3?= =?us-ascii?Q?UvTYTWiIPzgkLyVqp0T3teVzzTiKFMr5xnS6RPX4JBRzBM0+v/oHxrU4KG68?= =?us-ascii?Q?fg3zzW9PWkMOn4te9uEIuIKhwAfVqT2UyjYpj3Pt0y9BoqfWkIH5thmoNURl?= =?us-ascii?Q?dC6e46xLYMQ2jkYnsicYSBBWdw5J59zmyYyDjI1HynLCDrxb155Nm54qInr2?= =?us-ascii?Q?qYSkisxfHLueFRFswiOH1e902e/cIO7cup1YmzmQNJ/CC1yO+QuJDnKV+4/r?= =?us-ascii?Q?pbyjBAUtlOV15kfFKE35OPCJHc8km2GGQTlnxftoXXTPa/3iwVsq6aJSVnC4?= =?us-ascii?Q?QVg32erY6n6dR11RTp6yGoP2hkLe0hT7EZQHQ+qiI0Fj46VJOc+81J5HUD4x?= =?us-ascii?Q?UTRIi/Z2+lClX/xaWy+xkZk5otKRmi4S29+JZNXMLCrt2SL66TzbtwcHl3qS?= =?us-ascii?Q?kyDxoS5+RlSnpYmz4JmBQveJDas4QvtFIO3rQY9UDKlpSskNm24PtTRSn1Un?= =?us-ascii?Q?aTXV7MB48g0yRCw2aNctyn+zVEuz+PrMH/sjTTY7FKbb8XuZD7Rd8Qc8mOoC?= =?us-ascii?Q?oOswq4T3o675mv+iU34C1RBvlpbTuNYD0vtW1ONpdvYZQ/KP96qLrnCaKWp6?= =?us-ascii?Q?TqWNK6Js9PfvyoEyqYMIUrqeJW9ta3Ukg3i/UHCBjLPT7KULX/7b7sHNUmg4?= =?us-ascii?Q?/RYVV1rg44rqpk9pctMvJqBbGPgiqKFdAv3/GNTnPf1kAflxq3wZjDz7juLL?= =?us-ascii?Q?GZ3EAbUGzg29ya/IeZfmOzIdONq+2VewlDaQKinHgKKrecVIzOP/3C1CaqUe?= =?us-ascii?Q?X06WRAy0MdPrOgWFla2wuR/l72yQE2zvjktcCdZWYSAxWrkyVf/CZI0E0jQi?= =?us-ascii?Q?Quxs3Zl5CmZZaQRkXe9gZ80=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: e6c7a851-a288-4101-9d60-08d9fc6b82d2 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2663.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2022 16:41:33.7114 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +1TgDRK4ve3mXHKXq/401zlsOIroDpALX/dfar9kXhL/HxH9/6/IK3CgJgUpVd9areO02m/3TYxAvtB4nlsExg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1001MB2144 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10274 signatures=686787 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 malwarescore=0 mlxscore=0 phishscore=0 suspectscore=0 adultscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000 definitions=main-2203020073 X-Proofpoint-GUID: qkEPK_YnsbroMSihPPrq00FLhgwsaZjL X-Proofpoint-ORIG-GUID: qkEPK_YnsbroMSihPPrq00FLhgwsaZjL The sched_clock() can be used very early since commit 857baa87b642 ("sched/clock: Enable sched clock early"). In addition, with commit 38669ba205d1 ("x86/xen/time: Output xen sched_clock time from 0"), kdump kernel in Xen HVM guest may panic at very early stage when accessing &__this_cpu_read(xen_vcpu)->time as in below: setup_arch() -> init_hypervisor_platform() -> x86_init.hyper.init_platform = xen_hvm_guest_init() -> xen_hvm_init_time_ops() -> xen_clocksource_read() -> src = &__this_cpu_read(xen_vcpu)->time; This is because Xen HVM supports at most MAX_VIRT_CPUS=32 'vcpu_info' embedded inside 'shared_info' during early stage until xen_vcpu_setup() is used to allocate/relocate 'vcpu_info' for boot cpu at arbitrary address. However, when Xen HVM guest panic on vcpu >= 32, since xen_vcpu_info_reset(0) would set per_cpu(xen_vcpu, cpu) = NULL when vcpu >= 32, xen_clocksource_read() on vcpu >= 32 would panic. This patch calls xen_hvm_init_time_ops() again later in xen_hvm_smp_prepare_boot_cpu() after the 'vcpu_info' for boot vcpu is registered when the boot vcpu is >= 32. This issue can be reproduced on purpose via below command at the guest side when kdump/kexec is enabled: "taskset -c 33 echo c > /proc/sysrq-trigger" The bugfix for PVM is not implemented due to the lack of testing environment. Cc: Joe Jin Signed-off-by: Dongli Zhang --- Changed since v1: - Add commit message to explain why xen_hvm_init_time_ops() is delayed for any vcpus. (Suggested by Boris Ostrovsky) - Add a comment in xen_hvm_smp_prepare_boot_cpu() referencing the related code in xen_hvm_guest_init(). (suggested by Juergen Gross) Changed since v2: - Delay for all VCPUs. (Suggested by Boris Ostrovsky) - Add commit message that why PVM is not supported by this patch - Test if kexec/kdump works with mainline xen (HVM and PVM) Changed since v3: - Re-use v2 but move the login into xen_hvm_init_time_ops() (Suggested by Boris Ostrovsky) arch/x86/xen/smp_hvm.c | 6 ++++++ arch/x86/xen/time.c | 25 ++++++++++++++++++++++++- 2 files changed, 30 insertions(+), 1 deletion(-) diff --git a/arch/x86/xen/smp_hvm.c b/arch/x86/xen/smp_hvm.c index 6ff3c887e0b9..b70afdff419c 100644 --- a/arch/x86/xen/smp_hvm.c +++ b/arch/x86/xen/smp_hvm.c @@ -19,6 +19,12 @@ static void __init xen_hvm_smp_prepare_boot_cpu(void) */ xen_vcpu_setup(0); + /* + * Called again in case the kernel boots on vcpu >= MAX_VIRT_CPUS. + * Refer to comments in xen_hvm_init_time_ops(). + */ + xen_hvm_init_time_ops(); + /* * The alternative logic (which patches the unlock/lock) runs before * the smp bootup up code is activated. Hence we need to set this up diff --git a/arch/x86/xen/time.c b/arch/x86/xen/time.c index 55b3407358a9..dcf292cc859e 100644 --- a/arch/x86/xen/time.c +++ b/arch/x86/xen/time.c @@ -558,16 +558,36 @@ static void xen_hvm_setup_cpu_clockevents(void) void __init xen_hvm_init_time_ops(void) { + static bool hvm_time_initialized; + + if (hvm_time_initialized) + return; + /* * vector callback is needed otherwise we cannot receive interrupts * on cpu > 0 and at this point we don't know how many cpus are * available. */ if (!xen_have_vector_callback) - return; + goto exit; if (!xen_feature(XENFEAT_hvm_safe_pvclock)) { pr_info("Xen doesn't support pvclock on HVM, disable pv timer"); + goto exit; + } + + /* + * Only MAX_VIRT_CPUS 'vcpu_info' are embedded inside 'shared_info'. + * The __this_cpu_read(xen_vcpu) is still NULL when Xen HVM guest + * boots on vcpu >= MAX_VIRT_CPUS (e.g., kexec), To access + * __this_cpu_read(xen_vcpu) via xen_clocksource_read() will panic. + * + * The xen_hvm_init_time_ops() should be called again later after + * __this_cpu_read(xen_vcpu) is available. + */ + if (!__this_cpu_read(xen_vcpu)) { + pr_info("Delay xen_init_time_common() as kernel is running on vcpu=%d\n", + xen_vcpu_nr(0)); return; } @@ -577,6 +597,9 @@ void __init xen_hvm_init_time_ops(void) x86_cpuinit.setup_percpu_clockev = xen_hvm_setup_cpu_clockevents; x86_platform.set_wallclock = xen_set_wallclock; + +exit: + hvm_time_initialized = true; } #endif -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Wed Mar 02 17:27:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 17:27:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282511.481243 (Exim 4.92) (envelope-from ) id 1nPSlH-0005ZS-7E; Wed, 02 Mar 2022 17:27:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282511.481243; Wed, 02 Mar 2022 17:27:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPSlH-0005ZL-42; Wed, 02 Mar 2022 17:27:39 +0000 Received: by outflank-mailman (input) for mailman id 282511; Wed, 02 Mar 2022 17:27:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPSlF-0005ZF-Ve for xen-devel@lists.xenproject.org; Wed, 02 Mar 2022 17:27:38 +0000 Received: from mail-qk1-x732.google.com (mail-qk1-x732.google.com [2607:f8b0:4864:20::732]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0d50143b-9a4e-11ec-8539-5f4723681683; Wed, 02 Mar 2022 18:27:37 +0100 (CET) Received: by mail-qk1-x732.google.com with SMTP id c7so1854202qka.7 for ; Wed, 02 Mar 2022 09:27:36 -0800 (PST) Received: from development (c-73-166-253-254.hsd1.tx.comcast.net. [73.166.253.254]) by smtp.gmail.com with ESMTPSA id s7-20020a05622a018700b002dfed15c9edsm10771985qtw.74.2022.03.02.09.27.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Mar 2022 09:27:35 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0d50143b-9a4e-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:user-agent:mime-version :content-transfer-encoding; bh=dOu3W6e1lek9NwlGWMLe7xTNjeA/SvvKHqYQ9IVp8XI=; b=HM6LFXYfHo8XVEcJFPXRhorVFo29a9DE5gnPfOFbcJI+eo7KG4MUeGOXoxQeK7yUX1 eb+Y5LcX2CtoqnxlXbkc4s53O/E9ksNse34HEY7qJVKvc0C03YPLg8X603b4d0QXHBFt lH+fnWeyVJP7YCHj26Ha+oy7sDhMxDlKXm/i0fRCvMnElrNga1eV+pvK+gKQK2iXsk9A 87p8MWIfuJmqRaGLMv8rl3LULtsShACZPc/kJ88XHr/He+bS4NbEZx7E/bshI+Uplwju l1+v1bd/a0ah4HGAg6irP/aT2tevRlyEG0eszzvalcxeBNFz5TtBm43fOEZlwIhEA8Aj MIZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:user-agent :mime-version:content-transfer-encoding; bh=dOu3W6e1lek9NwlGWMLe7xTNjeA/SvvKHqYQ9IVp8XI=; b=PEU9k+eQTlYDt2t9l+RRw9mkjK1zO9uF5BYyfBl2LYEWDGS/Tche2nu3u1uQ+gV8oY tksNDiSwXJ+9l0bcszCXYsppqMNO09mTPifBf6JVqrKIFicZXj3PpB2s7wZtehOI8c/C mtnX/pGGxLgqn4cbLU1pgay3Q5xd6dmGECAqBAs1UBqCX/FtQ3sPMQLPsM0Uhvrl1j3Z kH8+Q+7cwymXOlMtRF/eholtct81eWehWyLDHG9QxUftBGeGkI31mvGC/PNqhmlMAHwQ csDRm/gkSpR9OL7wtLo0qhEeH8QBL6CZ2Yl/yM74IsOsxPzoo6Ow1cO/0ew5nwiKKDAO KJVA== X-Gm-Message-State: AOAM532ig5KMDOTD+5RkKAox5Truz3Djlgbj9URZsvHST8XldBmwAVWw j8dMoe1BwsTZRWwKzr+NRQ4GKl/haN4Mkw== X-Google-Smtp-Source: ABdhPJwxOg+54g5Insc2YbzwC8vhdiweJDDX7i1NDm4rut/DNJkC+dsUslLc8zBHw7l+Ai9pnBCaag== X-Received: by 2002:a37:80b:0:b0:508:b7e5:e47e with SMTP id 11-20020a37080b000000b00508b7e5e47emr17061461qki.80.1646242055670; Wed, 02 Mar 2022 09:27:35 -0800 (PST) Message-ID: <7c85d28831f3f30fb61bb359a23f570c34b4d31a.camel@gmail.com> Subject: PIRQ handling and PVH dom0? From: Alex Olson To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne Date: Wed, 02 Mar 2022 11:27:33 -0600 Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit I further attempted to see how far PVH dom0 can get but had a general question regarding what is not yet implemented... With an initial version of Roger's recent "vpci/msix: fix PBA access" patches and after refreshing his earlier 2018 patchset "vpci: add support for SR-IOV capability" regarding SR-IOV support for PVH dom0, I was able to get both physical functions and virtual functions of an SR-IOV network card to operate correctly in PVH dom0. However, it looks like any PCI-passthrough for HVM domUs with PVH dom0 is not yet implemented. I see the "PHYSDEVOP_map_pirq" call fails since the "emulation_flags" for dom0 do not include "XEN_X86_EMU_USE_PIRQ"... libxl: error: libxl_pci.c:1461:pci_add_dm_done: Domain 1:xc_physdev_map_pirq irq=17 (error=-1): Function not implemented libxl: error: libxl_pci.c:1781:device_pci_add_done: Domain 1:libxl__device_pci_add failed for PCI device 0:5:0.1 (rc -3) libxl: error: libxl_create.c:1895:domcreate_attach_devices: Domain 1:unable to add pci devices What is PVH dom0 missing at a conceptual level for PCI passthrough to domUs? I naively assumed that an HVM domU guest wouldn't care much whether dom0 was PV or PVH in terms of passthrough device IRQ handling... Thanks -Alex From xen-devel-bounces@lists.xenproject.org Wed Mar 02 17:46:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 17:46:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282520.481254 (Exim 4.92) (envelope-from ) id 1nPT3X-00007a-Tk; Wed, 02 Mar 2022 17:46:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282520.481254; Wed, 02 Mar 2022 17:46:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPT3X-00007S-Pk; Wed, 02 Mar 2022 17:46:31 +0000 Received: by outflank-mailman (input) for mailman id 282520; Wed, 02 Mar 2022 17:46:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPT3X-00007F-7g; Wed, 02 Mar 2022 17:46:31 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPT3X-0005X7-3m; Wed, 02 Mar 2022 17:46:31 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPT3W-0004gf-NI; Wed, 02 Mar 2022 17:46:30 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nPT3W-0001Vj-Mo; Wed, 02 Mar 2022 17:46:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=B3Dz/NDkwzx3W/ImFuw8spFgXSs0PUy3VWZTGdsdKU8=; b=o5h4k3Mnt4lksrGOvh/dqwZ59A f1jvmjqInC7RGzf6akRlweGEdybTnzORwnzos07RnOS3rVpKBdyCzZhSz0DrCybQBXFYAq9Skqy9+ w8p/JAnBVIFEDBqXKSOIPrHLQy1sf0DExcR6GqRVw0VomqdrF2k6OrynMTsluiRbL4Ms=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 168327: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=09591fcf6eb3157ab9c50a9fbbef5f8a567fb49f X-Osstest-Versions-That: qemuu=99c53410bc9d50e556f565b0960673cccb566452 From: osstest service owner Date: Wed, 02 Mar 2022 17:46:30 +0000 flight 168327 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/168327/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 168300 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 168300 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168300 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 168300 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 168300 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 168300 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 168300 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 168300 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu 09591fcf6eb3157ab9c50a9fbbef5f8a567fb49f baseline version: qemuu 99c53410bc9d50e556f565b0960673cccb566452 Last test of basis 168300 2022-03-01 17:39:30 Z 1 days Testing same since 168327 2022-03-02 07:38:29 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Christian Ehrhardt Keith Packard Luc Michel Peter Maydell Richard Henderson jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 99c53410bc..09591fcf6e 09591fcf6eb3157ab9c50a9fbbef5f8a567fb49f -> upstream-tested From xen-devel-bounces@lists.xenproject.org Wed Mar 02 17:49:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 17:49:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282531.481265 (Exim 4.92) (envelope-from ) id 1nPT6m-0000lP-DW; Wed, 02 Mar 2022 17:49:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282531.481265; Wed, 02 Mar 2022 17:49:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPT6m-0000lI-9a; Wed, 02 Mar 2022 17:49:52 +0000 Received: by outflank-mailman (input) for mailman id 282531; Wed, 02 Mar 2022 17:49:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPT6k-0000lC-NN for xen-devel@lists.xenproject.org; Wed, 02 Mar 2022 17:49:50 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2672eac7-9a51-11ec-8eba-a37418f5ba1a; Wed, 02 Mar 2022 18:49:48 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2672eac7-9a51-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1646243388; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=jV+HGttWRMg/h9om4MtM6jMgMtGYDbiSm1WHHdoSZ5E=; b=JHhB3CG+nyUZyf/HxVL+Txfnj9j8YBoMwjY8oBRXmg/V3cRFO/KdYPwh wRznVj5s1UTgbzXZdp4b0cc/IQnQDQPtiAX651zOnMtqDwUMmw69kqXIM TU9mASRAAEYbfm/8TPqxIvpQ67GgqOFKxU3VxQxE63r+55UYnT5LclBGt I=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com X-SBRS: 5.1 X-MesageID: 65731401 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:NRy+MauTIJm4bto1RnNrUb8PDufnVEBeMUV32f8akzHdYApBsoF/q tZmKTzQM62OYmSgLt9/OYq38x4Hv8DTzd9lTFY5qiFjRnlB+JbJXdiXEBz9bniYRiHhoOOLz Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQyw4bVvqYy2YLjW1jV4 4upyyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo Oihu6BcRi8HMZTLuMQ2fSV4KCBkep8bypGeGT+g5Jn7I03uKxMAwt1rBUAye4YZ5vx2ESdF8 vlwxDIlN07ZwbjsmfTiF7cq1p9LwMrDZevzvllJyz3DAOlgapfEW6jQvvdT3Ssqh9AIFvHbD yYcQWQyM0+ZP0UWUrsRIIwRk+uKp3XiSCxFklTLq4E86mXv5QMkhdABN/KKI4fXFK25hH2wt m/Aumj0HBweHNie0iaetGKhgPfVmiH2U55UE6e3ntZ2gFyIgG0IThROUUC8p9G2j0e/X5RUL El8x8Y1hfFsrgrxFIC7BkDm5i7f1vIBZzZOO8M10Qat6oH63yaiB3JDfGNzRoUe89BjEFTGy WS1t9/uADVutpicRnSc6qqYoFuOBMQFEYMRTXRaFFVYurEPtKl210uSFYg7TMZZm/WoQWmY/ tyckMQpa1z/Z+Yv3r7zw13IiinESnPhHl9svVW/so5IA2pEiG+Zi26AtACzARVodt/xory9U J4swZL2AAcmV8zlqcB1aL9RdIxFHt7cWNEmvXZhHoM66xOm8GO5cIZb7VlWfRk1bJ9aIWe4P haC42u9AaO/2lPwN8ebhKrrVqwXIVXIT4y5Bpg4kPIUCnSOSON31H43PhPBt4wcuEMtjbs+K f+mnTWEVh4n5VBc5GPuHY81iOZzrghnnD+7bc2rnnyPjOvFDFbIGOhtDbd7Rr1ghE9yiF6Oq Ig32grj40g3bdASlQGMqd9DdQ1RdCNjbX00wuQOHtO+zsNdMDhJI9fawK87epwjmKJQl+zS+ Wq6VFMew1367UAr4y3VApy/QNsDhapCkE8= IronPort-HdrOrdr: A9a23:Det6j6vM5lwIRdFCyHMEVZ5O7skC1oMji2hC6mlwRA09TyXGra 6TdaUguiMc1gx8ZJh5o6H9BEGBKUmskaKceeEqTPmftXrdyRSVxeZZnMrfKlzbamLDH4tmtJ uIHJIOcOEYYWIK7/oSpTPIburIo+P3sJxA592utEuFJDsCA8oLgmcJaTpzUHcGPjWubaBJTq Z0jfA3wAZIDE5nF/hTcUN1OdQryee78a7OUFojPVoK+QOOhTSn5PrRCB6DxCoTVDtJ3PML7X XFuxaR3NThj9iLjjvnk0PD5ZVfn9XsjvFZAtaXt8QTIjLwzi61eYVaXaGYtjxdmpDs1L9qqq iIn/4TBbU115rjRBDynfIr4Xi47N8a0Q6n9bZfuwq6nSW2fkNgNyMLv/MmTvKQ0TtQgDg76t MX44vRjeslMfuL9h6Nl+TgRlVkkFG5rmEllvNWh3tDUZEGYLsUtoAH+lhJea1wVh4SxbpXWN WGNvusr8q+sGnqGEzxry1q2pihT34zFhCJTgwLvdGUySFfmDR8w1EDzMISk38c/NZlIqM0q9 jsI+BtjvVDX8UWZaVyCKMIRta2EHXERVbJPHiJKVrqGakbMzbGqoLx4r8y+Oa2EaZ4gacaid DEShdVpGQyc0XhBYmH24BK6AnERCGnUTHk2qhlltFEU33HNczW2AG4OSUTepGb0oci6+XgKo KOBK4= X-IronPort-AV: E=Sophos;i="5.90,149,1643691600"; d="scan'208";a="65731401" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BxWHlRa4/0ZxsI2LKm/aSXIPLjtfc9m/FG7Xu8YxFJw1MqgIkf4FN2X8zBBk/NAerPqSBIrKhI2C6zdb3SzS65wqNj4K7op4F3WqVV0NbiS3k3pIBZRkgKg9rxVCxErCrUqaiP8syU6iIQHdzrw2efNAzfv/k15Z23bJA19Su12zvdltt4IdphjmomHoi634NY+WgjEYc8an4VmGC2+BFt8n0tOwVc9bhpUPxK3PNlh/hH6ZUFgt76XGoGY5ibQPB/sIcqa5l7SUGJt5ee2EJh4/uqXkixPjCutJCdZcD45GpqCFvhxgWcMA+Zay/kUDTos8sXnZ3IS4ND3Us3OJeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jV+HGttWRMg/h9om4MtM6jMgMtGYDbiSm1WHHdoSZ5E=; b=Ghkx1yYj2RHQpLvU+Cl1SyF9AsJW2ZnMWBHTjfo1cBsK85PLJLV+AK1emB+p2DorGC5pBCd9DL1xzwrbiEg7FAK0PAKoqTikd1Yq0Sp92zIqe8AMGK7854PPYFxxck0OFEv/J4jUV1B/FkSzAsGrD0oegSliUKz/vllY1xMmX65QUXf7LL1awyTfrkonRt1JPA2KbhEMYC4STpbxyNmdz+FQNC7+TOURJ2HbbNsNsigWc2Vviq4xClt0Rqe4xOhlyATyiaMW64Q2wmZ3Zt+zmxSNk0OyCI0fpuL0Dc1PCydcu/zYEvouFcxjgFX0T/Xc3N2y6sbKTKTMXzxj8JkFsQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jV+HGttWRMg/h9om4MtM6jMgMtGYDbiSm1WHHdoSZ5E=; b=taQvnmJUKxgqS+t1/py4Yjp4IOeSkZzIhq+vKhPiPzFZDHdY5eU+KUlGj+uKA8ONpi+03DD/jGfp7cWuzlGODob3M+kduQSug3j48fwxtlo5I8XTTTaZrVI0duBqfZBrY3L7cGwlqydaHEFeGR58/NQDlWMwlurqr74LaO/V3y4= From: Andrew Cooper To: Alex Olson , "xen-devel@lists.xenproject.org" CC: Roger Pau Monne Subject: Re: PIRQ handling and PVH dom0? Thread-Topic: PIRQ handling and PVH dom0? Thread-Index: AQHYLlrY/dua2GHNF0yeezsM7bCSAKysXvKA Date: Wed, 2 Mar 2022 17:49:14 +0000 Message-ID: <6ad3e3f9-0d3d-4223-0951-0f8ee7fa4b8b@citrix.com> References: <7c85d28831f3f30fb61bb359a23f570c34b4d31a.camel@gmail.com> In-Reply-To: <7c85d28831f3f30fb61bb359a23f570c34b4d31a.camel@gmail.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c0ddbe0d-7167-43fb-3b1f-08d9fc74f74d x-ms-traffictypediagnostic: MWHPR03MB3005:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: V/ospENK9Oo3zuTfdTPiF9gJVodypaNkAQv2nYMP630xrxPz0JLG3oR54avlnCPMgND6oT2lUcxhGCij/6o3N4zFDqKlA0oDFQ7PV9VkM1CT/V/2rYdFbY0u4OJFC3+klz5azKoA6EEArJM5VlAD3JB3FVezcubloH2fPtUKxGPrSTfVPm/Rn51RPY8M37XiVpLxQUzFhsp4mTP2yxDSxreLlQX8+OCDHZLlY/DBsNI7KUBvlMZ54dR4w/SR4nEv+Qtiu8qrrb9QD9cupvGjMxz6LUmWkqerWAz/ICGVapGVvWSmnTqazTerqi5+JfEAdOZgR97dpUM2qHBZ+W4cLCDtaKuKIriiRUBeriHQfJtk89wsyLL6O9gyERLug5n6mXGeE4nWxoqZqZzev0QXFN/18p0LjGzzdGgEUlPV/zLDtat3mr6ZGN363jGGgi1ZpsRZgWo5ltxMIkJsyrLnOfYnXybMpfqLSvkq3u+JL7xns+2n5Y9kZuJHSofA35Qc3VfeEhRiZt0dV7YTUBTzTojqiewcEI9H1eoHp1opxJtfmddbun1DU1wMTfP9cnaYPyaL4L5qJFga+6loMd+zdkb6IYvoAOSyE55Qs+bS92ZdB5m/AYR0n4dgiTXUVSFvwAp7g0dTHjLo6BVD9qC8ic0hIq8mKYJ9G/+PdjfUGqGs42Kxgq4zjCfvyv+DT5O+H4ugD7fNslcNpYRke6sk5EgtdvU3yxGy/O6k3pwAlNqxhZzRz86ObEXnzwuSkjgp1f73te+TZU9rWtl7IAQ+0w== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(71200400001)(38100700002)(8936002)(86362001)(31686004)(53546011)(2616005)(316002)(6512007)(6506007)(26005)(186003)(110136005)(83380400001)(107886003)(8676002)(66556008)(4326008)(66446008)(122000001)(66476007)(64756008)(31696002)(2906002)(508600001)(91956017)(82960400001)(66946007)(76116006)(6486002)(5660300002)(36756003)(38070700005)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?RkpwbGFDNVZHVWNvZHdjM1duK0FVTVhrODJBSlVxMVNTZUdoaDNUQm5oVVE2?= =?utf-8?B?N1Frd29oUy9iUG8wckRnYTRPYkZWMU1rWk8rUjJuTWNPTXdROW5qM1pFbVJT?= =?utf-8?B?SVlOV1U1TDJjeFVOT1dxTkdTT2xCQndQNnptTE1zUGx0b3lQSWRiU3Y5eENG?= =?utf-8?B?R20rMVNkcHRMejMrd2FGb2dydlJ1SlRvNzNsRVhsNkhrRUc3SUJ4c2d0aGpy?= =?utf-8?B?ZnNFZzJqZEtxbVhZc2x5cEl2Z2pnZXV6UnBZQ0RTZkNRS0tPRW9MMFhoWURP?= =?utf-8?B?NzZTYnlwQS8vdzc0SmJJWVFuRHpoSVhYWHpxR1NjbGlWUWxXRHJEM3Fmb0RO?= =?utf-8?B?TVBVRjNySmlzK2ZCY3h3Z0dxOE45K1gxVHhYYUd2OG4xaGU0NWxSait2bzg5?= =?utf-8?B?QVlEWGNKTEY0QjZ5NlllcmNLdFcwOE1oRkJUcDNMbWg3MzlXMUpxalNMVFlk?= =?utf-8?B?angwdzlLbmlPRjZLbWJjR01ubzJkaHZQT09lQzhDYndvNTZ2UHo0N0xnODZT?= =?utf-8?B?QjN3VUp3OHFBby8rQ1Z4dnRXaGFVeDNMKy9FTW9hai81b3NsZG92bUxXVTBa?= =?utf-8?B?TXQ4YytoaG00TnVKUm5xOEFubUpkbVVyZ0YvTWhxT0NkUFd4c1ZYSmRUUFV6?= =?utf-8?B?YWhNYXUxbEkraVJPNm5kMnFGdmJoYUNIcUFMNXp5aGhYTzYxTldwY3hRbW4x?= =?utf-8?B?b2U1NTIwb2hjT0YzSldhVkFOcDJ6S0psQ25GN25PMHUvNjZQMDN5aUFnZFc5?= =?utf-8?B?dFd0b3d6Nk5VeXdVMElLM09UQVZFK3hIUzBRaERoaDh1b1h5RnQ2c1FVK0M1?= =?utf-8?B?bVlGTVgxUm9SbjRoZWtKREhKazFORDB4cllxWW56NVYrR0U0R2tnVW1DNGEx?= =?utf-8?B?QkVuOHd3ejd3dUVBZlI4OWdPT3dDRVgwbGFhSG9rMjJUampZbWJPeHNtS0Nr?= =?utf-8?B?aFQ5ams5cHlCMHBQQnJXcHIvN0pPR2NYZWZ4UFA2SGxQZnFFdFlvTGd4UFcw?= =?utf-8?B?WkpVckx0OUdyU1BVclhMR1RyS0FKeFdoVmxxeWpaUlJkRUxIWWVhdTQ0KzZR?= =?utf-8?B?YW4wVm1DSzBoV3gxaEtNWkdFTU80bDc5YmFkNmQ0VkxYZG8ya3JvUXpSczBn?= =?utf-8?B?YkxLLzgvU09UZ3JCV3ZMUDFXc3dIYjJFT1B1cWxtOUREYk5sZGg3bU9WTXhL?= =?utf-8?B?SHZZWnl2THhCYS94cHk0WGw4ZVA5cUZ4ak9RdzgyNWVlVVl5WjFsd3liOXJ5?= =?utf-8?B?bnZOZzFWK0x6SlV3SkxnS3RWdkt1YjB5T0NKTk9BR3RENHljQTI1dnJzZ20w?= =?utf-8?B?Z1VnVmFWbjFtcSttVnVyYVR1T2tjUzdkc2RQR0MwZTZ5a0JPTXFPYm03dnIw?= =?utf-8?B?bVdNeWhnSjVGYUo0bGE0bGVrT0FuWmZRb2xkWEdIMEk5NGszbGZwbjRzamxo?= =?utf-8?B?Q0FDelloNy9aVFNPeTgySkVIMkpXaUxZSEJ3ODRnd3Z6VWtLZTRQKy9uVTJV?= =?utf-8?B?WlZLUXpkbkdhdlNzelNMbEJIeC9PT3A4OEI2eG4vQ1d0TWUyQjhRMzgvNXpS?= =?utf-8?B?WnluM1V2bmFUblhzNEZXTFFYS1ovWnYzY1c1NGRqeUIyZW1qamNjN0FWLzdo?= =?utf-8?B?cmNWMDR0SFVtblRFbUo2cHE5OTJ0UDJOVTYyemNiMU5wTkZXdXJYYkpxdmNZ?= =?utf-8?B?VHVzUG5wK1o0TTJiSDZJQmkzM1BBRDZMZ2VXQ1dzRWdWSFJ4ZThHT09ZUVhG?= =?utf-8?B?S3E4cTdXM3ZHR2pLb2RMc0JBVU1LRXFUOHhSaVJReCsxSmZ4bHZvZUVyeWV0?= =?utf-8?B?K1lnQld3TityS0o3cXBnR3czRGpVdXFGQmhnQ1R6em9RRHRvUTlXUTJtVDNV?= =?utf-8?B?RDVJRzRkYjd0S1MyU1F4aVA4YTlNMWtZMk91WlllRWM5d2haMG12Zm51dVdn?= =?utf-8?B?Z3ZwcUdqaVBlY2M0Y3RNQ0F1VUxmR1lsZUFkYzNrOFBzY3UxSFg5S2NKVEl3?= =?utf-8?B?OGhrd3VTYWx5djF5ME9JMUJrVEpHdXQ5UzJ1RzgvRFNaTGxmVW90RWN3ZVBt?= =?utf-8?B?U0xnMDF2Vlpsa29qNktXcHRWSzg2NTRhVnJmR0hEeUlvZlpDczRBTTdidWQ5?= =?utf-8?B?cVFQcThNYmoweGVyeWpGS3FOd0p4Mllwbk5LeFF4RTNRNkZHdHZMYWRLaEgv?= =?utf-8?B?elo3eHY1T1ZyOXVUM0xFUVhUMXJXNGkrNXhJOXhXRkJ2dFV6bHQ2eGVkT2ty?= =?utf-8?B?dzF5M0ZrTEZUZERYMXVpdENPQjF3PT0=?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c0ddbe0d-7167-43fb-3b1f-08d9fc74f74d X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Mar 2022 17:49:14.4294 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: OuO71YkAHWUMnmzqVljyxVdGR8C0oOJ/CPmH1Jnx2K7LNFlO/yitRnoEKUos+3NItDCxfR5yuEFEXZQkB8SaXeA4bF0LGjpGDSmuJkuiIDU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB3005 X-OriginatorOrg: citrix.com T24gMDIvMDMvMjAyMiAxNzoyNywgQWxleCBPbHNvbiB3cm90ZToNCj4gSSBmdXJ0aGVyIGF0dGVt cHRlZCB0byBzZWUgaG93IGZhciBQVkggZG9tMCBjYW4gZ2V0IGJ1dCBoYWQgYSBnZW5lcmFsIHF1 ZXN0aW9uIHJlZ2FyZGluZyB3aGF0IGlzIG5vdCB5ZXQgaW1wbGVtZW50ZWQuLi4gDQo+DQo+IFdp dGggYW4gaW5pdGlhbCB2ZXJzaW9uIG9mIFJvZ2VyJ3MgcmVjZW50ICJ2cGNpL21zaXg6IGZpeCBQ QkEgYWNjZXNzIiBwYXRjaGVzIGFuZCBhZnRlciByZWZyZXNoaW5nIGhpcyBlYXJsaWVyIDIwMTgg cGF0Y2hzZXQgInZwY2k6IGFkZCBzdXBwb3J0IGZvciBTUi1JT1YgY2FwYWJpbGl0eSIgcmVnYXJk aW5nIFNSLUlPViBzdXBwb3J0IGZvciBQVkggZG9tMCwgSSB3YXMgYWJsZSB0byBnZXQgYm90aCBw aHlzaWNhbCBmdW5jdGlvbnMgYW5kIHZpcnR1YWwgZnVuY3Rpb25zIG9mIGFuIFNSLUlPViBuZXR3 b3JrIGNhcmQgdG8gb3BlcmF0ZSBjb3JyZWN0bHkgaW4gUFZIIGRvbTAuDQo+DQo+IEhvd2V2ZXIs IGl0IGxvb2tzIGxpa2UgYW55IFBDSS1wYXNzdGhyb3VnaCBmb3IgSFZNIGRvbVVzIHdpdGggUFZI IGRvbTAgaXMgbm90IHlldCBpbXBsZW1lbnRlZC4gSSBzZWUgdGhlICJQSFlTREVWT1BfbWFwX3Bp cnEiIGNhbGwgZmFpbHMgc2luY2UgdGhlICJlbXVsYXRpb25fZmxhZ3MiIGZvciBkb20wIGRvIG5v dCBpbmNsdWRlICJYRU5fWDg2X0VNVV9VU0VfUElSUSIuLi4NCj4NCj4gCWxpYnhsOiBlcnJvcjog bGlieGxfcGNpLmM6MTQ2MTpwY2lfYWRkX2RtX2RvbmU6IERvbWFpbiAxOnhjX3BoeXNkZXZfbWFw X3BpcnEgaXJxPTE3IChlcnJvcj0tMSk6IEZ1bmN0aW9uIG5vdCBpbXBsZW1lbnRlZCAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIA0KPiAJbGlieGw6IGVycm9yOiBsaWJ4bF9wY2kuYzoxNzgxOmRldmljZV9wY2lfYWRkX2Rv bmU6IERvbWFpbiAxOmxpYnhsX19kZXZpY2VfcGNpX2FkZCBmYWlsZWQgZm9yIFBDSSBkZXZpY2Ug MDo1OjAuMSAocmMgLTMpICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgDQo+IAlsaWJ4bDogZXJyb3I6IGxpYnhsX2NyZWF0 ZS5jOjE4OTU6ZG9tY3JlYXRlX2F0dGFjaF9kZXZpY2VzOiBEb21haW4gMTp1bmFibGUgdG8gYWRk IHBjaSBkZXZpY2VzICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IA0KPg0KPg0KPiBXaGF0IGlzIFBWSCBkb20wIG1pc3NpbmcgYXQgYSBjb25jZXB0dWFsIGxldmVs IGZvciBQQ0kgcGFzc3Rocm91Z2ggdG8gZG9tVXM/ICBJIG5haXZlbHkgYXNzdW1lZCB0aGF0IGFu IEhWTSBkb21VIGd1ZXN0IHdvdWxkbid0IGNhcmUgbXVjaCB3aGV0aGVyIGRvbTAgd2FzIFBWIG9y IFBWSCBpbiB0ZXJtcyBvZiBwYXNzdGhyb3VnaCBkZXZpY2UgSVJRIGhhbmRsaW5nLi4uDQo+DQo+ IFRoYW5rcw0KDQpIbW0uwqAgeGVuL2FyY2gveDg2L2h2bS9oeXBlcmNhbGwuYyBodm1fcGh5c2Rl dl9vcCgpIGZpbHRlcnMgbWFwL3VubWFwDQpwaXJxIGJhc2VkIG9uIGN1cnJkLg0KDQpCdXQgdGhp cyBpcyBidWdneS7CoCBJdCBzaG91bGQgcmVhZCB0aGUgcGh5c2Rldl9tYXBfcGlycV90IHBhcmFt ZXRlciBhbmQNCmxvb2sgYXQgdGhlIGRvbWlkIHBhcmFtZXRlci7CoCBXaGF0IHFlbXUgaGVyZSBp cyBkb2luZyBpcyB0cnlpbmcgdG8gbWFwIGENCnBpcnEgb24gYmVoYWxmIG9mIHRoZSB0YXJnZXQg ZG9tYWluLCBub3Qgb24gYmVoYWxmIG9mIGRvbTAuDQoNCn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Wed Mar 02 17:57:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 17:57:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282540.481276 (Exim 4.92) (envelope-from ) id 1nPTDp-0002bf-9s; Wed, 02 Mar 2022 17:57:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282540.481276; Wed, 02 Mar 2022 17:57:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPTDp-0002bY-6G; Wed, 02 Mar 2022 17:57:09 +0000 Received: by outflank-mailman (input) for mailman id 282540; Wed, 02 Mar 2022 17:57:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPTDn-0002bO-Kz; Wed, 02 Mar 2022 17:57:07 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPTDn-0005iy-Gm; Wed, 02 Mar 2022 17:57:07 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPTDn-00053K-1J; Wed, 02 Mar 2022 17:57:07 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nPTDn-0001Ap-0q; Wed, 02 Mar 2022 17:57:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=c4sAMBuntjUDi+b3WJkQS82H5Wb2b2cKZzGK8bUjVzA=; b=PM/n5UmHvIUoTRSE2CkUWPVdjM 6wOaFLMJE6h+PRP3V4xrRHa1AEzs0oiH00I4vMs6yQhd1JnfFHYnSe9EA7W4hmpGLRkZfABjVQfqa PcN6N+mB7MwRp4uunS/ySnqIkxNCjSQVUiKzeiCb4T2FzyT62X7DwTEWGqFplqWQ09Xs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 168340: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=dc39554d58af4a50b50eca1f57c49415a12b0c98 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Wed, 02 Mar 2022 17:57:07 +0000 flight 168340 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/168340/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf dc39554d58af4a50b50eca1f57c49415a12b0c98 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 2 days Failing since 168258 2022-03-01 01:55:31 Z 1 days 17 attempts Testing same since 168316 2022-03-02 02:50:20 Z 0 days 5 attempts ------------------------------------------------------------ People who touched revisions under test: Guomin Jiang Jason Jason Lou Xiaolu.Jiang jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit dc39554d58af4a50b50eca1f57c49415a12b0c98 Author: Xiaolu.Jiang Date: Tue Feb 22 22:14:05 2022 +0800 edk2/MdeModulePkg/Debuglib: Add Standalone MM support https://bugzilla.tianocore.org/show_bug.cgi?id=3844 This change added Standalone MM instance of DebugLib. Reviewd-by: Jian J Wang Reviewd-by: Liming Gao Signed-off-by: Xiaolu.Jiang commit 497ac7b6d7f9750f48f137db244931a5728b1968 Author: Guomin Jiang Date: Sat Jan 29 16:28:02 2022 +0800 UefiPayloadPkg/PayloadLoaderPeim: Use INT64 as input parameter REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3818 It will have some potential issue when memory larger than 2G because the high memory address will be fill with 0xFFFFFFFF when do the operation of INTN + INT64 but it is 32 bit normal data in fact. Should use same data type INT64 + INT64. V3: 1. Use INT64 as input parameter because all date type is 64 bit V2: 1. Force the data type to UINTN to avoid high dword be filled with 0xFFFFFFFF 2. Keep INTN because the offset may postive or negative. Reviewed-by: Guo Dong Reviewed-by: Ray Ni Signed-off-by: Guomin Jiang commit 6a890db161cd6d378bec3499a1e774db3f5a27a7 Author: Jason Date: Mon Jan 10 22:30:29 2022 +0800 BaseTools: Upgrade the version of NASM tool REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Upgrade the version of NASM tool to avoid compilation errors when compiling NASM code change. Signed-off-by: Jason Lou Cc: Bob Feng Cc: Liming Gao Reviewed-by: Yuwei Chen commit bbaa00dd01ed0df30e43a5a89fd2b0433d858b73 Author: Jason Date: Mon Jan 10 22:05:47 2022 +0800 MdePkg: Remove the macro definitions regarding Opcode. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Remove the macro definitions regarding Opcode because new version of NASM tool(e.g. v2.15.05) supports the corresponding instructions. Note: This patch need to be merged after other NASM code change to avoid compilation errors. Signed-off-by: Jason Lou Cc: Michael D Kinney Reviewed-by: Liming Gao Cc: Zhiguang Liu commit 2aa107c0aa2e1375651867c8df1b81ff64b67fce Author: Jason Date: Mon Jan 10 22:01:18 2022 +0800 UefiCpuPkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Reviewed-by: Ray Ni Cc: Eric Dong Cc: Laszlo Ersek Cc: Rahul Kumar commit 7bc8b1d9f412507d579f21ea9af56fced81e7827 Author: Jason Date: Mon Jan 10 21:52:52 2022 +0800 SourceLevelDebugPkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Reviewed-by: Hao A Wu commit d3febfd9ade35dc552df6b3607c2b15d26b82867 Author: Jason Date: Mon Jan 10 21:46:27 2022 +0800 MdePkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Cc: Michael D Kinney Reviewed-by: Liming Gao Cc: Zhiguang Liu commit 84338c0d498555f860a480693ee8647a1795fba3 Author: Jason Date: Mon Jan 10 21:04:09 2022 +0800 MdeModulePkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Reviewed-by: Ray Ni Cc: Dandan Bi Reviewed-by: Liming Gao From xen-devel-bounces@lists.xenproject.org Wed Mar 02 19:58:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 19:58:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282553.481292 (Exim 4.92) (envelope-from ) id 1nPV6Y-0000ix-UN; Wed, 02 Mar 2022 19:57:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282553.481292; Wed, 02 Mar 2022 19:57:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPV6Y-0000iq-RR; Wed, 02 Mar 2022 19:57:46 +0000 Received: by outflank-mailman (input) for mailman id 282553; Wed, 02 Mar 2022 19:57:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPV6W-0000ik-DE for xen-devel@lists.xenproject.org; Wed, 02 Mar 2022 19:57:44 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 03933411-9a63-11ec-8539-5f4723681683; Wed, 02 Mar 2022 20:57:41 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 03933411-9a63-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1646251061; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=5HBJfX/YI4/vonTzojph5TRBFlUVz4e8zsRbbwbPR6Q=; b=U8EPnKQKGarEYwcrbdx7rwza2nEa6n1lkmf7dC+woBt301O2SXmT73hD iwWlfa7A7IUhPOkCmk1qU3E43o8AY9YwZeCXlMa2lSsTD97k1bXcDhVNg aGmxXb55CuX/9+BqdryiBKwv9f2rIKT5Ws7H2aMQ/kCBKdZpRQpOptZ/G 4=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com X-SBRS: 5.1 X-MesageID: 64794685 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:LF8u6K4sr3evZ9a//ldKsAxRtCXHchMFZxGqfqrLsTDasY5as4F+v moeWz2BOquKYTb3eYpzao7g804Oup+AzNRjQVNrr31jHi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0XqPp8Zj2tQy2YPhWVvR0 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx umhurShTT8xP7/Uod0MCUdFCnh0PJxcoK3IdC3XXcy7lyUqclPpyvRqSko3IZcZ6qB8BmQmG f4wcW5XKErZ3qTvnez9GrIEascLdaEHOKs2vH16wC6fJvEhWZ3ZGI3B5MNC3Sd2jcdLdRrbT 5RFNmszMkSdC/FJEkYaN64/ntuDv3/YdjxkkBWQnYgY22eGmWSd15CyaYGIK7RmX/59jkue4 27L4Wn9KhUbL8CEjyqI9Gq2ge3Clj+9X5gdfJWn8tZ6jVvVwXYcYDUUX1ampfiyimalRslSb UcT/0ITQbMarRLxCIOnBlvh/SDC7kV0t8ds//MS+QW10qvG+z+gFzJaUycYYt0XrpckSml/v rOWpO/BCTtqubyTbHuS8LaIsD+/URQowX8+iTwsFlVcvYS6yG0npleWF4s4Tvbp5jHgMWyom 1i3QD4Ca6L/ZCLh/4Gy5hj5jj2lvfAlpSZlt1yMDgpJAu6UDbNJhrBEC3CGtZ6sz67DFzFtW UTofeDEtoji6rnXyUSwrB0lRu3B2hp8GGS0baRTN5cg7S+x3HWoYJpd5jpzTG8wbJpaIGGxO B6N4FILjHO2AJdMRfUtC25WI553pZUM6Py/DqyEBjawSsIZmPC7ENFGOhfLgjGFfLkEmqAjI 5aLGftA/l5BYZmLOAGeHr9HuZdyn3hW7TqKGfjTkkT2uZLDNSX9YepUbzOzghURsfrsTPP9q I0EaaNnCnx3DYXDX8Ug2dVLfABScCNiXsieRg4+XrfrHzeK0VoJUpf56bggZ5Zkj+JSkOLJ9 Wu6QUhW1Bz0gnivFOlAQikLhG/HNXqnkU8GAA== IronPort-HdrOrdr: A9a23:15tRM6Dycq/OoBLlHegCsceALOsnbusQ8zAXPh9KJiC9I/b1qy nxppkmPEfP+UsssHFJo6HkBEEZKUmsuqKdkrNhQYtKOzOW9ldATbsSobcKpgePJ8SQzJ8l6U 4NSdkcNDS0NykBsS+Y2nj4Lz9D+qj+zEnAv463pB0NLT2CKZsQlDuRYjzrSXGeLzM2YabRYa DsgPav0ADQHkj/AP7LZEUtbqzmnZnmhZjmaRkJC1oM8w+Vlw6l77b8Dlyxwgoeeykn+8ZjzU H11yjCoomzufCyzRHRk0XJ6Y5NpdfnwtxfQOSRl8kuLCn2gArAXvUjZ1TChkF2nAic0idvrD D+mWZmAy210QKWQoiBm2qp5+An6kd215at8y7BvZKpm72HeNtzMbs+uWseSGqC16NohqAN7E oAtVjpxqZ/HFfOmj/w6MPPUAwvnk2ooWA6mepWlHBHV5ACAYUh5rD30XklWavoJhiKoLzP0d MeeP309bJTaxeXfnrZtm5gzJilWWkyBA6PRgwHttaO2zZbkXhlxw9ArfZv00so5dY4Ud1J9u 7EOqNnmPVHSdIXd7t0AKMETdGsAmLATBrQOCaZIEjhFqsAJ3XRwqSHqokd9aWvYtgF3ZEykJ POXBdRsnMzYVvnDYmU0JhC4nn2MROAtPTWu7ZjDrRCy8/BreDQQF6+oXgV4r6dn8k= X-IronPort-AV: E=Sophos;i="5.90,150,1643691600"; d="scan'208";a="64794685" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FqFFYSfXJ2RTFFVgjwgPt8jHwTEc+YJHxlV+YLRCITtiq8FngBgcrRAa74KvN8R7CSWTVDhC8AtPcjRy4HWA/SPMhy01a08uer/jeD2ck5MNRm0cFDBwJ4vOfRnqcdneHgur0BNAd+aUk7ZcUqztgF7s9xSX+BeiTdQs+wWdyWg+CT3x5LxMV1qg3yhLXpXTjVAbN20qmq/RHMqCHkPWDAezQmHCD974RA6Do/lJ6ng2BN6fM/lNTr0NbbqhV4ygCDeoGWOqYcv5UXugtPFHUJmw5HOH+WiODirwymHSugG4GWYHnUHQvgckXYQnTYv36kC93pGBi2qIMjDKvrWcyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5HBJfX/YI4/vonTzojph5TRBFlUVz4e8zsRbbwbPR6Q=; b=oXRRmP6McKywJlMhD1HWcRlhxhAPHe3HygErfK8AgC7yK+gn4JQFhnDaz5IgY4Vb9Yv0Rlfsk9v3yfbDx6vIncRVoWnKqK2mhSuiQz098vSMZM5Sm/0/K3MAamdFfyYQVXZtVHpJ1rBwQduwCWTgzIhxNPzFwaVf2927ilW9QsT6x+W+brw8ptzH26GVhpXkxDAMW0N7pWf1sEG5yXRO/7iwscClXFc4U/WVK1ni6RhnY/Ppw1/qGrsjqC5QabkLALlv3V+LghZGSA4PkH6+vT654LrDyGSt/WrLw3KrposUlveKHzjlYdWMi4LWYHX+hDHPrrk+5KprrkHpFdoYcg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5HBJfX/YI4/vonTzojph5TRBFlUVz4e8zsRbbwbPR6Q=; b=Opxd6GWn4Zauuge8NiY0Ri7jv/sifdaAeB1ZPAo+GvjgMTp05u+fTLTuguL+fV+ImH4pj5O3bii8YDcZdeSpOBjt1yu6qiY49tUdqYa5qwrq9ayXPg67u5Gkh0JYKR5tm+8klLsKTsd8Hey9Y3un9isPoPky4bhgviq0bCWVtsA= From: Andrew Cooper To: Jan Beulich CC: Roger Pau Monne , Wei Liu , Xen-devel Subject: Re: [PATCH v2.2 8/7] x86/IOMMU: Use altcall, and __initconst_cf_clobber Thread-Topic: [PATCH v2.2 8/7] x86/IOMMU: Use altcall, and __initconst_cf_clobber Thread-Index: AQHYJ+IV6PtRJY8p5U2wBnUH9jKzdqyj8n0AgAa3aoCAASBXAIAAIhyAgAAGJQCAADOGgIAAabgA Date: Wed, 2 Mar 2022 19:57:33 +0000 Message-ID: <160eb824-fc30-6d0c-a03f-dda2951aa930@citrix.com> References: <20220214125632.24563-1-andrew.cooper3@citrix.com> <20220222114711.19209-1-andrew.cooper3@citrix.com> <5fae516a-17c1-0ce4-c46e-909a83c0e273@citrix.com> <60f3c942-3822-87dd-df6e-8b64ed4d17c4@suse.com> <67ff91f4-e5fe-47d5-fdb8-9a302beb6e2a@suse.com> <15868475-0702-c884-143f-366b9d79a255@citrix.com> In-Reply-To: <15868475-0702-c884-143f-366b9d79a255@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4364fbb7-6541-4156-38cc-08d9fc86e460 x-ms-traffictypediagnostic: BN6PR03MB3202:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3u0i+42OjFk5JwyOHCbJdR5O01uSeFJPHTzH0qi1/CS2Tc4cK5Cu3Dkd4AueXNaXqXKpm/0zADk63TkNe4cjLz4DUoUj3K7GKFEP3ipBeSUPMGfPAtsn0vJORpiHBogz3a/WEzuU/fmxsov4Daty+JChqds2TPuh+s9eko9M2XGayt+mTj87RgebjZye8OkwSIKi37p8R55eHMruj69Lpr+QlzQTSonLblzn+dGOMf0CINXigkyvF2oFEv2NpzCCNQ/qLFOyfSDSGJvO1g7JUesz0uOXqeOHO9lbyp6QdpqAcekmxd/zDMgQ5fCtc52lEKPPZT5nh0qq+qM6HzWKfigwNTeeh4gNSXHQTVL7XrTf+kqmXwX/wbRMX3o0s8plBcGbb36Q9YIMSQvhG71SSPxrhW2jQDREfSZCBMiooSNlFsDqnC+CpMYmSnMVdcXgaUuibbLZzuKbUl8GZimGTgCP6XvTf1sNmQyx/hAeAAUnEPSydWcTim3v8/Z5ynx0wt1oz65cPpKkTKW20hyjkVitX6w7X0EOGvjsJSBvxWpDJpZaIlJd09sZ/57gJBXyOooz2JhAnLa1FFcjhnXl4voBBT/lG0SKbjb8K1opULzzng0V+Wa687G0zwHkqtQAIiQUvqktyfoElUGhK2C/ib7ZIe9KTcq8VaX6yAsj1T49wIUkPLMM/U5sLCizgH3paHQQOtlUBQmfQ+RithgNOylfWFb2RcqjBSdvv+cALpXdZBb+7x0g4fnxJQhse5up5+QCJCU94TNW3mBBVFDemQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(36756003)(316002)(82960400001)(122000001)(31686004)(2906002)(8936002)(38100700002)(5660300002)(83380400001)(2616005)(508600001)(38070700005)(6486002)(4326008)(91956017)(66556008)(26005)(6506007)(186003)(31696002)(76116006)(8676002)(86362001)(71200400001)(6512007)(6916009)(53546011)(54906003)(66476007)(66446008)(64756008)(66946007)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?U1pCdFMyWkdZNXp6dk1RREZVOG9UOUFtbkZNaTFYYXJzSEVpanoycDNLWE1q?= =?utf-8?B?WlM1UUpmaThtK3M5KzRFZExod2N3VXVpTnZWMjU4cHJPZFoxRHpDUUlmQ21M?= =?utf-8?B?cHBvaUhZbHcrc0IxRHRkaG5hakRlNUJTNzdMYjFuVEFqSlNuSFh6aHVxREtu?= =?utf-8?B?S3l6bnd3eGVGSnF2Ym9vVzYrUE1KWG1wY3ZpRGV5dEYyakg4VjJLZG5MSFFI?= =?utf-8?B?ODQvYTVQM1gzTHFzOGNsV012OERYaklGRU1JKysrdHJQRHBZRFNsVkovaklC?= =?utf-8?B?WmFybTYybmRSREYrc08yaitRRkNPVjB0YWFSZTRJdEpocDI4QlNPMktnZ0N6?= =?utf-8?B?ODcxcjhzTWZNeW9Zdjk5ZE91cElvMEZIb0xsQlZEY0hyeVBQUC9JZDBOWWYy?= =?utf-8?B?WDJPOVpaMGp1bFdTV2NoYW1tUGdrZGl1OVpvVVdDayswTWxWMWZ5WGhyWUgx?= =?utf-8?B?cTZiRWNHZjRabkJ4ZmxKeWZua1lFbHF5M0IzYUVRaGFQSjRnZ2gzbXJJR3F1?= =?utf-8?B?bjFkUXZSMUdkd0FqbDN6bjNYM1JRSDAxUG82WkpmYWRZMmxJaWlKMThwK3dR?= =?utf-8?B?QjNUc2tMM2pMd0NTTW1EVGMrbnJ2Mnd3TUt3YjF5Mjk3RkpMeE5JTVVHNkU3?= =?utf-8?B?bURDMzVNZ0pqYnVBSnNNMzh2b0lHby8xcDZwekhmbTdNZ2tYZGU3SWVvK01M?= =?utf-8?B?Z1FtTDIybU9Pb1VGeHVqMHlGbVltajRWS0tSRnhvbnBkUnNTeU9SZHd4eU54?= =?utf-8?B?blUzSzVIaFpSUmNMdVROS0ZySlVJdHZFcFBKZHBjaEQyT1dUK3YwdnFCQVpW?= =?utf-8?B?ZmVCdU1lcytMalp3R1F4VzU1SDZ1bmc5ZEJMY3JzLzdqNjdXSEc1bmNzaHFV?= =?utf-8?B?TUp0VGVaQWpLWHRZSWVrcVhicWdVRE5Vbk1WRzJwT001aUZldlJOU0RXdHp5?= =?utf-8?B?azZsQWhpc2had1hFV2FaZWg3REd1VGUzU1kzRkkxalBvaHIxOUJWM1VBZEs2?= =?utf-8?B?a2J0THBKVjdxLzNENWprT3JIMGVRamtSVkF5RkJHOGd6Q1FzYmFRSi83MkFN?= =?utf-8?B?bUJIby9yU2wwQ2E5RFZDbkY0UVgweU5wVTUraExvTTlNem5GdUdDWlM5cVB6?= =?utf-8?B?TWlCR2NVdlF0ZXBuaUxOeG9CMm51UERKTmhPRnNwYXFJYlZEOThXREo5WkRy?= =?utf-8?B?RGlVVW9kenIvMmdYeVBJeFg0R1JteGFiRXQzYjdsR1ROVjBkRWxCaWo4UE84?= =?utf-8?B?Mi80Q3l3NFNZUVdRVkRIb29uZDFvc2duL0tvUXk1NmVoZ2FkdWl3K0hFdDJt?= =?utf-8?B?RnRPL00yNFlyaklhaHE0ditJK0swMTJXUVNaRGJvdGhlWWRvYXJPUGZvZVln?= =?utf-8?B?VlJvejZnM2QvVFFZZERZYWpqeGFHV2hlV2JvODE4QjJ6a3RoVnhGZzN3dFpU?= =?utf-8?B?V1MxWGc1VE9wamo3TTVzZFdwNFdveERtWXl3WmQxMG5xUDNUeXFjaVBiajY2?= =?utf-8?B?RzRzYXBlYkprbEs3WnBPbXIzd2FaMUgrRHhLZVZHclNkRkk0TmtoVE1sMTV2?= =?utf-8?B?OWl0UjVOZ0ZlOHhaRHUxRi9rY0NJYmNLVkFkQ1c1b0UvalhUaW51aGZTRERx?= =?utf-8?B?Z1ptOHI0UGF1YU50RTZvNXBRc290a0RVWkdFKzVMZC9wSFpTLzV0ZitRSWJl?= =?utf-8?B?UVh6WWxjYVA4aHZzcVNac3NoQUFJUFd6b093SDJoRnpjMW4vSDBYUGRtOTI1?= =?utf-8?B?MnRDbm1qbDIvVHU4a2t6c0JzbFVuSGtnZUlTRVg3WW11c3dyNktobkEwMVJS?= =?utf-8?B?dVgxQzBadWdnTVljZHVXY1dETVkvc1dYQlFoK01BU3dHZkxDcHlDTmNlb3Vi?= =?utf-8?B?K3l2TzlCRDZIczNPRVFZQkl3Q0J6VWtaQ2VmRFd0S2laRVhTNUg4K2FYWUR4?= =?utf-8?B?TkNZd0xDbFhDb3VlRnJRT2dkMlljMkhra3dLOUlLZzJ0T1gxK0wyZUNXMVRJ?= =?utf-8?B?YzhTOGRBcHVnOHpTN0NFZ2dGdnppNndGN2E5TmQ3bEE1Yk1zRXhWNjQraEpS?= =?utf-8?B?TFZDdXcyL08zR1BEOS95bGM4cnJUL3crMjRiVVNBS254aTY4eDdVRElzdlF0?= =?utf-8?B?dnZ5WlBtWEd0SmxwTDBSV1VwZVFreUtVSzlGc1ZLOVJOL3JldjJuUEJhRjJK?= =?utf-8?B?Z210ak1GRWtiWXFYbWhPUFV1dzV6QnBSbElNeDZNQm1LWFhsTmVURFV4U3pq?= =?utf-8?B?eVRpWnBHczhEa1hoemVlbFN0RUp3PT0=?= Content-Type: text/plain; charset="utf-8" Content-ID: <93236820C34A00458C8CE349781DBEF8@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4364fbb7-6541-4156-38cc-08d9fc86e460 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Mar 2022 19:57:33.4933 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 21L8zkkc+Cf35Pk0XDZn5k66TfmzKfNr8B2DEu8y9AdkGaJ+ibnaTnvDBq5yNHIPYanYMcmsLYet3EfYQgGUUT5SjT/Xp0Sn+fwQUf1k2Kc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB3202 X-OriginatorOrg: citrix.com T24gMDIvMDMvMjAyMiAxMzozOSwgQW5kcmV3IENvb3BlciB3cm90ZToNCj4gT24gMDIvMDMvMjAy MiAxMDozNCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+PiBPbiAwMi4wMy4yMDIyIDExOjEyLCBBbmRy ZXcgQ29vcGVyIHdyb3RlOg0KPj4+IE9uIDAyLzAzLzIwMjIgMDg6MTAsIEphbiBCZXVsaWNoIHdy b3RlOg0KPj4+PiBPbiAwMS4wMy4yMDIyIDE1OjU4LCBBbmRyZXcgQ29vcGVyIHdyb3RlOg0KPj4+ Pj4gT24gMjUvMDIvMjAyMiAwODoyNCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+Pj4+Pj4gT24gMjIu MDIuMjAyMiAxMjo0NywgQW5kcmV3IENvb3BlciB3cm90ZToNCj4+Pj4+Pj4gLS0tIGEveGVuL2Ry aXZlcnMvcGFzc3Rocm91Z2gvYW1kL3BjaV9hbWRfaW9tbXUuYw0KPj4+Pj4+PiArKysgYi94ZW4v ZHJpdmVycy9wYXNzdGhyb3VnaC9hbWQvcGNpX2FtZF9pb21tdS5jDQo+Pj4+Pj4+IEBAIC02Mjgs NyArNjI4LDcgQEAgc3RhdGljIHZvaWQgY2ZfY2hlY2sgYW1kX2R1bXBfcGFnZV90YWJsZXMoc3Ry dWN0IGRvbWFpbiAqZCkNCj4+Pj4+Pj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGhk LT5hcmNoLmFtZC5wYWdpbmdfbW9kZSwgMCwgMCk7DQo+Pj4+Pj4+ICB9DQo+Pj4+Pj4+ICANCj4+ Pj4+Pj4gLXN0YXRpYyBjb25zdCBzdHJ1Y3QgaW9tbXVfb3BzIF9faW5pdGNvbnN0cmVsIF9pb21t dV9vcHMgPSB7DQo+Pj4+Pj4+ICtzdGF0aWMgY29uc3Qgc3RydWN0IGlvbW11X29wcyBfX2luaXRj b25zdF9jZl9jbG9iYmVyIF9pb21tdV9vcHMgPSB7DQo+Pj4+Pj4gRm9sbG93aW5nIG15IGluaXRj YWxsIHJlbGF0ZWQgcmVtYXJrIG9uIHg4NidlcyB0aW1lLmMgSSdtIGFmcmFpZCBJIGRvbid0DQo+ Pj4+Pj4gc2VlIGhvdyB0aGlzIGFuZCAuLi4NCj4+Pj4+Pg0KPj4+Pj4+PiBAQCAtMjc5NCw3ICsy NzkzLDcgQEAgc3RhdGljIGludCBfX2luaXQgY2ZfY2hlY2sgaW50ZWxfaW9tbXVfcXVhcmFudGlu ZV9pbml0KHN0cnVjdCBkb21haW4gKmQpDQo+Pj4+Pj4+ICAgICAgcmV0dXJuIHJjOw0KPj4+Pj4+ PiAgfQ0KPj4+Pj4+PiAgDQo+Pj4+Pj4+IC1zdGF0aWMgc3RydWN0IGlvbW11X29wcyBfX2luaXRk YXRhIHZ0ZF9vcHMgPSB7DQo+Pj4+Pj4+ICtzdGF0aWMgY29uc3Qgc3RydWN0IGlvbW11X29wcyBf X2luaXRjb25zdF9jZl9jbG9iYmVyIHZ0ZF9vcHMgPSB7DQo+Pj4+Pj4gLi4uIHRoaXMgYWN0dWFs bHkgd29ya3MuIEJ1dCBJIGd1ZXNzIEkgbXVzdCBiZSBvdmVybG9va2luZyBzb21ldGhpbmcsIGFz DQo+Pj4+Pj4gSSdtIHN1cmUgdGhhdCB5b3UgZGlkIHRlc3QgdGhlIGNoYW5nZS4NCj4+Pj4+Pg0K Pj4+Pj4+IEJvdGggb3BzIHN0cnVjdHVyZXMgcmVmZXJlbmNlIGEgZnVuY3Rpb24sIHRocm91Z2gg LmFkanVzdF9pcnFfYWZmaW5pdGllcywNCj4+Pj4+PiB3aGljaCBpc24ndCBfX2luaXQgYnV0IHdo aWNoIGlzIHVzZWQgKGJlc2lkZXMgaGVyZSkgZm9yIGFuIGluaXRjYWxsLiBXaXRoDQo+Pj4+Pj4g dGhlIEVOREJSIHJlbW92ZWQgYnkgdGhlIHRpbWUgaW5pdGNhbGxzIGFyZSBydW4sIHRoZXNlIHNo b3VsZCBjYXVzZSAjQ1AuDQo+Pj4+PiBUaGlzIGRvZXNuJ3QgZXhwbG9kZSBiZWNhdXNlIHRoZSBp bmRpcmVjdCBjYWxscyBhcmUgcmVzb2x2ZWQgdG8gZGlyZWN0DQo+Pj4+PiBjYWxscyBiZWZvcmUg dGhlIEVOREJSJ3MgYXJlIGNsb2JiZXJlZCB0byBOT1A0Lg0KPj4+PiBJJ20gYWZyYWlkIEkgZG9u J3QgdW5kZXJzdGFuZDogVGhlIHByb2JsZW1hdGljIGNhbGwgaXMgaW4gZG9faW5pdGNhbGxzKCk6 DQo+Pj4+DQo+Pj4+ICAgICBmb3IgKCBjYWxsID0gX19wcmVzbXBfaW5pdGNhbGxfZW5kOyBjYWxs IDwgX19pbml0Y2FsbF9lbmQ7IGNhbGwrKyApDQo+Pj4+ICAgICAgICAgKCpjYWxsKSgpOw0KPj4+ Pg0KPj4+PiBJIGRvbid0IHNlZSBob3cgdGhpcyBjb3VsZCBiZSBjb252ZXJ0ZWQgdG8gYSBkaXJl Y3QgY2FsbC4NCj4+PiBPaC7CoCBpb3ZfYWRqdXN0X2lycV9hZmZpbml0aWVzKCkncyBkb3VibGUg dXNlIGlzIGhpZGluZyBoZXJlLg0KPj4+DQo+Pj4gVGhlIHNhZmV0eSBydWxlIGZvciBjZl9jbG9i YmVyIGlzIHRoYXQgdGhlcmUgbXVzdCBub3QgYmUgYW55DQo+Pj4gbm9uLWFsdC1jYWxsZWQgY2Fs bGVycy7CoCBXZSBuZWVkIHRvIGZpeCBpdDoNCj4+Pg0KPj4+IGRpZmYgLS1naXQgYS94ZW4vZHJp dmVycy9wYXNzdGhyb3VnaC9hbWQvaW9tbXVfaW5pdC5jDQo+Pj4gYi94ZW4vZHJpdmVycy9wYXNz dGhyb3VnaC9hbWQvaW9tbXVfaW5pdC5jDQo+Pj4gaW5kZXggNjU3YzdmNjE5YTUxLi5iMWFmNTA4 NWVmZGEgMTAwNjQ0DQo+Pj4gLS0tIGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvYW1kL2lvbW11 X2luaXQuYw0KPj4+ICsrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL2FtZC9pb21tdV9pbml0 LmMNCj4+PiBAQCAtODMxLDcgKzgzMSwxMiBAQCBpbnQgY2ZfY2hlY2sgaW92X2FkanVzdF9pcnFf YWZmaW5pdGllcyh2b2lkKQ0KPj4+IMKgDQo+Pj4gwqDCoMKgwqAgcmV0dXJuIDA7DQo+Pj4gwqB9 DQo+Pj4gLV9faW5pdGNhbGwoaW92X2FkanVzdF9pcnFfYWZmaW5pdGllcyk7DQo+Pj4gKw0KPj4+ ICtpbnQgY2ZfY2hlY2sgX19pbml0IGluaXRjYWxsX2lvdl9hZGp1c3RfaXJxX2FmZmluaXRpZXMo dm9pZCkNCj4+PiArew0KPj4+ICvCoMKgwqAgcmV0dXJuIGlvbW11X2NhbGwoJmlvbW11X29wcywg YWRqdXN0X2lycV9hZmZpbml0aWVzKTsNCj4+PiArfQ0KPj4+ICtfX2luaXRjYWxsKGluaXRjYWxs X2lvdl9hZGp1c3RfaXJxX2FmZmluaXRpZXMpOw0KPj4+IMKgDQo+Pj4gwqAvKg0KPj4+IMKgICog RmFtaWx5MTVoIE1vZGVsIDEwaC0xZmggZXJyYXR1bSA3NDYgKElPTU1VIExvZ2dpbmcgTWF5IFN0 YWxsDQo+Pj4gVHJhbnNsYXRpb25zKQ0KPj4+DQo+Pj4NCj4+Pj4gQWZhaWNzIG9ubHkgcHJlLVNN UCBpbml0Y2FsbHMgYXJlIHNhZmUgaW4gdGhpcyByZWdhcmQ6IGRvX3ByZXNtcF9pbml0Y2FsbHMo KQ0KPj4+PiBpcyBjYWxsZWQgaW1tZWRpYXRlbHkgYWhlYWQgb2YgYWx0ZXJuYXRpdmVfYnJhbmNo ZXMoKS4NCj4+Pj4NCj4+Pj4gSXNuJ3QgdGhpcyAocHJldmlvdXNseT8pIHdvcmtpbmcgcmVsYXRl ZCB0byB5b3VyICJ4ODYvc3BlYy1jdHJsOiBEaXNhYmxlDQo+Pj4+IHJldHBvbGluZXMgd2l0aCBD RVQtSUJUIj8NCj4+PiBOby7CoCBJdCdzIGJlY2F1c2UgQU1EIENQVXMgZG9uJ3QgaGF2ZSBDRVQt SUJUIGF0IHRoaXMganVuY3R1cmUsIGFuZCB3aWxsDQo+Pj4gbmV2ZXIgZW5jb3VudGVyIGEgZmF1 bHRpbmcgc2l0dWF0aW9uLg0KPj4gSSdtIHN0aWxsIGxvc3QuIEFuIGV4YWN0bHkgbWF0Y2hpbmcg Y29uc3RydWN0IGV4aXN0cyBpbiBWVC1kIGNvZGUgKGFuZA0KPj4gbXkgaW5pdGlhbCBjb21tZW50 IGFsc28gd2FzIG9uIFZULWQpLiBUaGUgQU1EIG9uZSBpcyBhY3R1YWxseSBhIGNsb25lDQo+PiBv ZiB0aGF0IG11Y2ggb2xkZXIgb25lLiBUaGUgaW5pdGNhbGwgcmVhbGx5IHdhbnRzIHRvIG1vdmUg dG8gdmVuZG9yDQo+PiBpbmRlcGVuZGVudCBjb2RlLCBidXQgSSdkIHN0aWxsIGxpa2UgdG8gdW5k ZXJzdGFuZCB3aHkgbm8gZmF1bHQgd2FzDQo+PiBldmVyIG9ic2VydmVkLg0KPiBMb3ZlbHkuwqAg SXQncyBnb3QgYSB2dGQgaW5maXggd2hpY2ggaXMgd2h5IGl0IGVzY2FwZWQgbXkgZ3JlcC4NCj4N Cj4gQW5kIHllcywgSSByZWFsbHkgd291bGQgZXhwZWN0IHRoYXQgdG8gZXhwbG9kZSBvbiBteSB0 ZXN0IHN5c3RlbS4uLg0KDQpBbmQgdGhlIGFuc3dlciBpcyB0aGF0IHRoZSBsaW5rZXIgc2NyaXB0 IGNvbGxlY3RzIC5pbml0LnJvZGF0YS4qIGFoZWFkDQpvZiB0aGUgZGVkaWNhdGVkIC5pbml0LnJv ZGF0YS5jZl9jbG9iYmVyIHNlY3Rpb24uDQoNCk1lYW5pbmcgdGhhdCBfX2luaXRkYXRhX2NmX2Ns b2JiZXIgd29ya3MgYXMgZXhwZWN0ZWQgYnV0DQpfX2luaXRjb25zdF9jZl9jbG9iYmVyIGlzIGEg bm8tb3AuDQoNCn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Wed Mar 02 20:49:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 20:49:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282564.481320 (Exim 4.92) (envelope-from ) id 1nPVun-0007Vs-QF; Wed, 02 Mar 2022 20:49:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282564.481320; Wed, 02 Mar 2022 20:49:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPVun-0007Vl-MK; Wed, 02 Mar 2022 20:49:41 +0000 Received: by outflank-mailman (input) for mailman id 282564; Wed, 02 Mar 2022 20:49:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPVum-0007Vb-MF; Wed, 02 Mar 2022 20:49:40 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPVum-0001hS-HD; Wed, 02 Mar 2022 20:49:40 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPVum-0006dF-3U; Wed, 02 Mar 2022 20:49:40 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nPVum-0008GK-2g; Wed, 02 Mar 2022 20:49:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=CHeAOHiM6z01wVb9qfdSSzRpi4XmBbF7nRrn/m18pEA=; b=gRqLYLMjpiNu42GO7YEiHl+Xwq 5tcX/DAFlZO/tgesagRY89X1AvwF/IIMvAobhs5qoc05et4hdEs+a3SOYPs4HUoCKoU+0UnLUblTh WvdIaxgJMkXpsdVFTYTHyHOWJc5EWr0P4dCq+2siEVCqaYwr+PhdRoyfXp8NsG7YpAqo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 168328: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:guest-start/debianhvm.repeat:fail:heisenbug xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=faecea18d252f97c6ad41f0f457566ff2c125b8d X-Osstest-Versions-That: xen=6e3f36387de566b09aa4145ea0e3bfe4814d68b4 From: osstest service owner Date: Wed, 02 Mar 2022 20:49:40 +0000 flight 168328 xen-unstable real [real] flight 168345 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/168328/ http://logs.test-lab.xenproject.org/osstest/logs/168345/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 14 guest-start/debianhvm.repeat fail pass in 168345-retest Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail REGR. vs. 168310 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 168310 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168310 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 168310 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 168310 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 168310 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 168310 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 168310 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 168310 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 168310 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 168310 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 168310 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 168310 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen faecea18d252f97c6ad41f0f457566ff2c125b8d baseline version: xen 6e3f36387de566b09aa4145ea0e3bfe4814d68b4 Last test of basis 168310 2022-03-01 23:38:41 Z 0 days Testing same since 168328 2022-03-02 08:41:59 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Julien Grall Julien Grall jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 6e3f36387d..faecea18d2 faecea18d252f97c6ad41f0f457566ff2c125b8d -> master From xen-devel-bounces@lists.xenproject.org Wed Mar 02 22:10:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 22:10:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282586.481348 (Exim 4.92) (envelope-from ) id 1nPXAz-0001r3-E4; Wed, 02 Mar 2022 22:10:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282586.481348; Wed, 02 Mar 2022 22:10:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPXAz-0001qw-Ax; Wed, 02 Mar 2022 22:10:29 +0000 Received: by outflank-mailman (input) for mailman id 282586; Wed, 02 Mar 2022 22:10:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPXAy-0001qX-Ol for xen-devel@lists.xenproject.org; Wed, 02 Mar 2022 22:10:28 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8f5572a2-9a75-11ec-8eba-a37418f5ba1a; Wed, 02 Mar 2022 23:10:26 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8f5572a2-9a75-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1646259026; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=tnU5OZzouBn4AHcK0NyTMJDBZStBopfGXyfAs2tmiog=; b=OUTdXBGKaGN7BI8QVdC3SFeAIfPbttct5BA09yeFA1J7z1fv+zU8uhlP weZ4C2koiOzupg+BHHNKKb1XutmjfY06zprTRO/QzXXAbzZf3LzmgqraT gEfmj0velXjdTRvQrLABsKnx5tpLG3wEIsZRtJYqGZ47WPzSe68dSpbbY A=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 65749612 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:vknyQ6O+x1hxyVjvrR2il8FynXyQoLVcMsEvi/4bfWQNrUongjRTy jQWCjiCaK6IYWWmKNt0YISy8EhQuMTQn9ZhGwto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFcMpBsJ00o5wbZi2tQw3bBVPivW0 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z+ Ox3sbKNeD8TffPXhOhBbRwFTT9UIvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr 7pCcmlLN03dwbLtqF64YrAEasALBc/nJo4A/FpnyinUF60OSpHfWaTao9Rf2V/cg+gQQKmCN pRAM1KDajz6ewYMZ1EIAq4YlfmKrGjRQhtE9Aqs8P9fD2/7k1UqjemF3MDuUsOObdVYmACfv G2u10bTDwweNdef4SGY6X/qjejK9QvrVYRXGLCm+/pChFyI2ndVGBAQTUG8o/Sylgi5Qd03F qAP0nNw9+5orhXtF4SjGU3jyJKZgvICc+ppKekU1TC18OmK+BqVWlYBE2BfQsNz4afaWgcW/ lOOmtroAxlmv7uUVW+R+9+okN+iBcQGBTRcPHFZFGPp9/Gm+dhu1UyXEr6PBYbo1oWdJN3m/ 9ydQMHSbZ03hNVD6ai09Euvb9mE9smQFV5dCuk6swuYAuJFiGyNOtTABbvzt68owGOlor+p5 iJsdy+2tr1mMH11vHbRKNjh5Znwjxp/DBXSgER0A74q/Cm39niocOh4uW8ieh01bJpVImC0O Sc/XD+9ArcJZhNGioctPuqM5zkCl/C8RbwJqNiOBjaxXnSBXFDep3w/DaJh92vsjFItgckC1 WSzKq6R4YIhIf0/llKeHr5FuZdyn3xW7T6DFPjTkkX8uZLDNSH9dFvwGAbXBgzPxPjf+1u9H hc2H5bi9iizp8WlOniHqdNIdAtSRZX5bLivw/Fqmie4ClIOMAkc5zX5m+tJl1BN90iNqtr1w w== IronPort-HdrOrdr: A9a23:OrKnj67gQx2x6VzUHgPXwMTXdLJyesId70hD6qhwISY6TiX+rb HIoB17726RtN9/YhEdcLy7VJVoIkmskKKdg7NhXotKNTOO0ADDQb2KhbGSpQEIcBeeygcy78 hdmtBFeb/NMWQ= X-IronPort-AV: E=Sophos;i="5.90,150,1643691600"; d="scan'208";a="65749612" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH] xen/CET: Fix __initconst_cf_clobber Date: Wed, 2 Mar 2022 22:10:05 +0000 Message-ID: <20220302221005.16636-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit The linker script collecting .init.rodata.* ahead of .init.rodata.cf_clobber accidentally causes __initconst_cf_clobber to be a no-op. Rearrange the linker script to unbreak this. The IOMMU adjust_irq_affinities() hooks currently violate the safety requirement for being cf_clobber, by also being __initcall(). Consolidate to a single initcall using iommu_call() (satisfying the cf_clobber safety requirement), and also removes the dubious property that we'd call into both vendors IOMMU drivers on boot, relying on the for_each_*() loops to be empty for safety. With this fixed, an all-enabled build of Xen has 1681 endbr64's (1918 including .init.text) with 382 (23%) being clobbered during boot. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu I was unsure whether to go common or x86 spefific IOMMU code, so went with the conservative option. The final hunk can trivially move if preferred. --- xen/arch/x86/xen.lds.S | 12 ++++++------ xen/drivers/passthrough/amd/iommu_init.c | 1 - xen/drivers/passthrough/vtd/iommu.c | 1 - xen/drivers/passthrough/x86/iommu.c | 6 ++++++ 4 files changed, 12 insertions(+), 8 deletions(-) diff --git a/xen/arch/x86/xen.lds.S b/xen/arch/x86/xen.lds.S index 83def6541ebd..b15e5b67e4a4 100644 --- a/xen/arch/x86/xen.lds.S +++ b/xen/arch/x86/xen.lds.S @@ -210,6 +210,12 @@ SECTIONS DECL_SECTION(.init.data) { #endif + . = ALIGN(POINTER_ALIGN); + __initdata_cf_clobber_start = .; + *(.init.data.cf_clobber) + *(.init.rodata.cf_clobber) + __initdata_cf_clobber_end = .; + *(.init.rodata) *(.init.rodata.*) @@ -224,12 +230,6 @@ SECTIONS *(.initcall1.init) __initcall_end = .; - . = ALIGN(POINTER_ALIGN); - __initdata_cf_clobber_start = .; - *(.init.data.cf_clobber) - *(.init.rodata.cf_clobber) - __initdata_cf_clobber_end = .; - *(.init.data) *(.init.data.rel) *(.init.data.rel.*) diff --git a/xen/drivers/passthrough/amd/iommu_init.c b/xen/drivers/passthrough/amd/iommu_init.c index 657c7f619a51..2e5bffa732e7 100644 --- a/xen/drivers/passthrough/amd/iommu_init.c +++ b/xen/drivers/passthrough/amd/iommu_init.c @@ -831,7 +831,6 @@ int cf_check iov_adjust_irq_affinities(void) return 0; } -__initcall(iov_adjust_irq_affinities); /* * Family15h Model 10h-1fh erratum 746 (IOMMU Logging May Stall Translations) diff --git a/xen/drivers/passthrough/vtd/iommu.c b/xen/drivers/passthrough/vtd/iommu.c index 6a65ba1d8271..f70d51580657 100644 --- a/xen/drivers/passthrough/vtd/iommu.c +++ b/xen/drivers/passthrough/vtd/iommu.c @@ -2119,7 +2119,6 @@ static int cf_check adjust_vtd_irq_affinities(void) return 0; } -__initcall(adjust_vtd_irq_affinities); static int __must_check init_vtd_hw(bool resume) { diff --git a/xen/drivers/passthrough/x86/iommu.c b/xen/drivers/passthrough/x86/iommu.c index 58a422fb5f88..6ef580215bc2 100644 --- a/xen/drivers/passthrough/x86/iommu.c +++ b/xen/drivers/passthrough/x86/iommu.c @@ -462,6 +462,12 @@ bool arch_iommu_use_permitted(const struct domain *d) likely(!p2m_get_hostp2m(d)->global_logdirty)); } +static int cf_check __init adjust_irq_affinities(void) +{ + return iommu_call(&iommu_ops, adjust_irq_affinities); +} +__initcall(adjust_irq_affinities); + /* * Local variables: * mode: C -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Wed Mar 02 22:12:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 22:12:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282592.481359 (Exim 4.92) (envelope-from ) id 1nPXCe-0002Pg-Oq; Wed, 02 Mar 2022 22:12:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282592.481359; Wed, 02 Mar 2022 22:12:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPXCe-0002PY-Lw; Wed, 02 Mar 2022 22:12:12 +0000 Received: by outflank-mailman (input) for mailman id 282592; Wed, 02 Mar 2022 22:12:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPXCd-0002PM-Ni for xen-devel@lists.xenproject.org; Wed, 02 Mar 2022 22:12:11 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cd87aa3f-9a75-11ec-8539-5f4723681683; Wed, 02 Mar 2022 23:12:10 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cd87aa3f-9a75-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1646259130; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=5eGfzPlndsyxVp6HYgFFniaJdsIB1nKCNPpAEM/imv0=; b=Qc9RMl+65nu9EfkNVKXs7N2We27q13FvofBUuEXqkJQmqgWdbqETrR5s qxPaP/rOXVFH2luXahyBzWzfelw10pQk9P540YJBSau5rkcRATwLi19DK V0aR+tuoYniszNn8CdG6vBmEG0e9CJBcneDu8TR1xKgXsoATgjFOfYckd 4=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 65749704 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:VCx5+a+r0u8JpVNxPNI7DrUDhH6TJUtcMsCJ2f8bNWPcYEJGY0x3n 2QcXW7Qb/3fZzCke4t+PI+w/UpU7Z7Xy9ZiGVRvpXw8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy +1EN7Es+ehtFie0Si+Fa+Sn9T8mvU2xbuKU5NTsY0idfic5DnZ54f5fs7Rh2NQw2oDjW1/lV e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9 DlCnaeJTRwKYabIo9gyY0l6Ti9cL5RixIaSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFKoZtmtt0nfyCvE+TIqYa67L+cVZzHE7gcUm8fP2O ZdGNWswNEiojxtnIXxNMdEgguKRh1rRbxRSsAyJibsw7D2GpOB2+Oe0a4eEEjCQfu1Kmm6Iq 2SA+H72ajk4HtGCzTuO8lq3m/TC2yj8Xeo6BLC+s/JnnlCX7mgSEwENE0u2p+GjjUyzUM4ZL FYbkhfCtoBrqhbtFIOkGUTl/jjU5XbwRua8DcUB0QWW6fXf5z2lKVhUbGNPSs4fkPMPEGlCO kCyo/vlAjlmsbuwQH2b96uJoT7aBRX5PVPudgdfE1JbvoCLTJUby0uWE409SPLdYsjdRGmoq w1muhTSkFn6YSQj86ygtW7KjDu3znQiZl5kv16HNo5JA+4QWWJEW2BKwQWDhRqjBNzAJrVkg JTis5LEhAzpJcvQ/BFhuM1XQNmUCw+taVUwe2JHEZg77CiK8HW+Z41W6zwWDB43bpheJWG1M RSM5Fo5CHpv0J2CN/Ufj2WZUZlC8EQdPY69CqC8giRmOPCdizNrDAkxPBXNjggBYWAnkL0lO IfzTCpfJS1yNEiT9xLvH711+eZynkgWnDqPLbimn0XP+efPPxa9FOZaWGZim8hktctoVi2Oq I0BXyZLoj0CONDDjt7/qtZCfQhXdiFgXfgbaaV/L4a+H+avI0l5Y9e5/F/rU9UNc3h9/gsQw kyAZw== IronPort-HdrOrdr: A9a23:A3qI5KNZ1gn/68BcTsWjsMiBIKoaSvp037BN7TEXdfU1SL39qy nKpp8mPHDP5Ar5NEtOpTniAsm9qBHnm6KdiLN5Vd3OYOCMggqVBbAnwYz+wyDxXw3Sn9QtsJ uIqpIOa+EY22IK7/rH3A== X-IronPort-AV: E=Sophos;i="5.90,150,1643691600"; d="scan'208";a="65749704" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH] x86/cmdline: Interpret 'vpmu' as a positive boolean Date: Wed, 2 Mar 2022 22:11:57 +0000 Message-ID: <20220302221157.17246-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit This makes it behave slightly more like a regular boolean option. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu Slightly RFC, because there is no easy way of making the opposite "normal boolean" case work for no-vpmu. --- xen/arch/x86/cpu/vpmu.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/xen/arch/x86/cpu/vpmu.c b/xen/arch/x86/cpu/vpmu.c index 4fedc7c57012..501d4f0af94e 100644 --- a/xen/arch/x86/cpu/vpmu.c +++ b/xen/arch/x86/cpu/vpmu.c @@ -66,7 +66,9 @@ static int __init cf_check parse_vpmu_params(const char *s) if ( !ss ) ss = strchr(s, '\0'); - if ( (val = parse_bool(s, ss)) >= 0 ) + if ( s == ss ) + opt_vpmu_enabled = true; + else if ( (val = parse_bool(s, ss)) >= 0 ) { opt_vpmu_enabled = val; if ( !val ) -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Wed Mar 02 22:55:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 22:55:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282602.481371 (Exim 4.92) (envelope-from ) id 1nPXsH-0007vo-7J; Wed, 02 Mar 2022 22:55:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282602.481371; Wed, 02 Mar 2022 22:55:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPXsH-0007vh-3X; Wed, 02 Mar 2022 22:55:13 +0000 Received: by outflank-mailman (input) for mailman id 282602; Wed, 02 Mar 2022 22:55:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPXsF-0007vS-8p; Wed, 02 Mar 2022 22:55:11 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPXsF-0003p4-5E; Wed, 02 Mar 2022 22:55:11 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPXsE-0004BU-O0; Wed, 02 Mar 2022 22:55:10 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nPXsE-0001vZ-Na; Wed, 02 Mar 2022 22:55:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=GnHVIMZBMDZf32W09tBha3IcH3MWPapPhaQXkggP2Zk=; b=kGJxlqfVe53nI/KAhWmI09Yx2n UEjezoZyJkhxCS1nYBPwrPmPfV09nrL9kS2mxR40YeEZJCutVF7/vSJO2x1QP0t/ACoo9bXxy4y05 mI/s+lYFUP3cWgphgcwVcgKyo7MCcCLNQZEvO45gMcjys/yIE8XHlNitIaGGwnVr4t/M=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 168344: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=dc39554d58af4a50b50eca1f57c49415a12b0c98 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Wed, 02 Mar 2022 22:55:10 +0000 flight 168344 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/168344/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf dc39554d58af4a50b50eca1f57c49415a12b0c98 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 2 days Failing since 168258 2022-03-01 01:55:31 Z 1 days 18 attempts Testing same since 168316 2022-03-02 02:50:20 Z 0 days 6 attempts ------------------------------------------------------------ People who touched revisions under test: Guomin Jiang Jason Jason Lou Xiaolu.Jiang jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit dc39554d58af4a50b50eca1f57c49415a12b0c98 Author: Xiaolu.Jiang Date: Tue Feb 22 22:14:05 2022 +0800 edk2/MdeModulePkg/Debuglib: Add Standalone MM support https://bugzilla.tianocore.org/show_bug.cgi?id=3844 This change added Standalone MM instance of DebugLib. Reviewd-by: Jian J Wang Reviewd-by: Liming Gao Signed-off-by: Xiaolu.Jiang commit 497ac7b6d7f9750f48f137db244931a5728b1968 Author: Guomin Jiang Date: Sat Jan 29 16:28:02 2022 +0800 UefiPayloadPkg/PayloadLoaderPeim: Use INT64 as input parameter REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3818 It will have some potential issue when memory larger than 2G because the high memory address will be fill with 0xFFFFFFFF when do the operation of INTN + INT64 but it is 32 bit normal data in fact. Should use same data type INT64 + INT64. V3: 1. Use INT64 as input parameter because all date type is 64 bit V2: 1. Force the data type to UINTN to avoid high dword be filled with 0xFFFFFFFF 2. Keep INTN because the offset may postive or negative. Reviewed-by: Guo Dong Reviewed-by: Ray Ni Signed-off-by: Guomin Jiang commit 6a890db161cd6d378bec3499a1e774db3f5a27a7 Author: Jason Date: Mon Jan 10 22:30:29 2022 +0800 BaseTools: Upgrade the version of NASM tool REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Upgrade the version of NASM tool to avoid compilation errors when compiling NASM code change. Signed-off-by: Jason Lou Cc: Bob Feng Cc: Liming Gao Reviewed-by: Yuwei Chen commit bbaa00dd01ed0df30e43a5a89fd2b0433d858b73 Author: Jason Date: Mon Jan 10 22:05:47 2022 +0800 MdePkg: Remove the macro definitions regarding Opcode. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Remove the macro definitions regarding Opcode because new version of NASM tool(e.g. v2.15.05) supports the corresponding instructions. Note: This patch need to be merged after other NASM code change to avoid compilation errors. Signed-off-by: Jason Lou Cc: Michael D Kinney Reviewed-by: Liming Gao Cc: Zhiguang Liu commit 2aa107c0aa2e1375651867c8df1b81ff64b67fce Author: Jason Date: Mon Jan 10 22:01:18 2022 +0800 UefiCpuPkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Reviewed-by: Ray Ni Cc: Eric Dong Cc: Laszlo Ersek Cc: Rahul Kumar commit 7bc8b1d9f412507d579f21ea9af56fced81e7827 Author: Jason Date: Mon Jan 10 21:52:52 2022 +0800 SourceLevelDebugPkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Reviewed-by: Hao A Wu commit d3febfd9ade35dc552df6b3607c2b15d26b82867 Author: Jason Date: Mon Jan 10 21:46:27 2022 +0800 MdePkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Cc: Michael D Kinney Reviewed-by: Liming Gao Cc: Zhiguang Liu commit 84338c0d498555f860a480693ee8647a1795fba3 Author: Jason Date: Mon Jan 10 21:04:09 2022 +0800 MdeModulePkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Reviewed-by: Ray Ni Cc: Dandan Bi Reviewed-by: Liming Gao From xen-devel-bounces@lists.xenproject.org Wed Mar 02 22:55:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Mar 2022 22:55:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282610.481382 (Exim 4.92) (envelope-from ) id 1nPXsr-0008Qi-Gl; Wed, 02 Mar 2022 22:55:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282610.481382; Wed, 02 Mar 2022 22:55:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPXsr-0008QZ-DL; Wed, 02 Mar 2022 22:55:49 +0000 Received: by outflank-mailman (input) for mailman id 282610; Wed, 02 Mar 2022 22:55:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPXsq-0008P6-I1 for xen-devel@lists.xenproject.org; Wed, 02 Mar 2022 22:55:48 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [2604:1380:4601:e00::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e4ef41db-9a7b-11ec-8539-5f4723681683; Wed, 02 Mar 2022 23:55:46 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9BAEFB82285; Wed, 2 Mar 2022 22:55:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 09738C004E1; Wed, 2 Mar 2022 22:55:42 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e4ef41db-9a7b-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646261743; bh=eGkVgzszDtV57fApPBexl0TVZ6WfXQmp/zCtiK77G5w=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=J14599mDBY6SiAecIHYOPw+47kA1RD3vf61XWWDduDghgViWRsCH5LCJT9klF6nWM 20xTyw20PC9hgjfpGrd02+fhJy+Brw5Tp4HsD1NVZwdTbrPg7Elb+018j1OtRv8gui Sq15JI/SX44J6Xi+ON5mKXlavVCpKmZ+/4JPtuJg9KJy83SFyNm0iatezO7AbYD2jU qU7f+QJvVy303DmGLlJ2cAQxPoRxZ1733TwA9Mx0sy675VEp5Z06KAOlLjoIj/4cSg t4YL3fxEcItHzjdX19tUwV+0KskdEA3SDKZoMAO/0c/j7v22ZqBNki13ufEEIb5hpk JvL8wMmRM1NMQ== Date: Wed, 2 Mar 2022 14:55:42 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Wei Chen cc: Stefano Stabellini , "xen-devel@lists.xenproject.org" , "julien@xen.org" , Bertrand Marquis , Penny Zheng , Henry Wang , nd Subject: RE: Proposal for Porting Xen to Armv8-R64 - DraftA In-Reply-To: Message-ID: References: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-615912675-1646261743=:3261" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-615912675-1646261743=:3261 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Wed, 2 Mar 2022, Wei Chen wrote: > > > > > > If not, and considering that we have to generate > > > > > > ARM_MPU_*_MEMORY_START/END anyway at build time, would it make > > sense > > > > to > > > > > > also generate mpu,guest-memory-section, xen,static-mem, etc. at > > build > > > > > > time rather than passing it via device tree to Xen at runtime? > > > > > > > > > > > > > > > > Did you mean we still add these information in device tree, but for > > > > build > > > > > time only. In runtime we don't parse them? > > > > > > > > Yes, something like that, but see below. > > > > > > > > > > > > > > What's the value of doing ARM_MPU_*_MEMORY_START/END at build time > > and > > > > > > everything else at runtime? > > > > > > > > > > ARM_MPU_*_MEMORY_START/END is defined by platform. But other things > > are > > > > > users customized. They can change their usage without rebuild the > > image. > > > > > > > > Good point. > > > > > > > > We don't want to have to rebuild Xen if the user updated a guest > > kernel, > > > > resulting in a larger boot-module-section. > > > > > > > > So I think it makes sense that "mpu,boot-module-section" is generated > > by > > > > the scripts (e.g. ImageBuilder) at build time, and Xen reads the > > > > property at boot from the runtime device tree. > > > > > > > > I think we need to divide the information into two groups: > > > > > > > > > > > > # Group1: board info > > > > > > > > This information is platform specific and it is not meant to change > > > > depending on the VM configuration. Ideally, we build Xen for a > > platform > > > > once, then we can use the same Xen binary together with any > > combination > > > > of dom0/domU kernels and ramdisks. > > > > > > > > This kind of information doesn't need to be exposed to the runtime > > > > device tree. But we can still use a build-time device tree to generate > > > > the addresses if it is convenient. > > > > > > > > XEN_START_ADDRESS, ARM_MPU_DEVICE_MEMORY_*, and > > ARM_MPU_NORMAL_MEMORY_* > > > > seem to be part of this group. > > > > > > > > > > Yes. > > > > > > > > > > > # Group2: boot configuration > > > > > > > > This information is about the specific set of binaries and VMs that we > > > > need to boot. It is conceptually similar to the dom0less device tree > > > > nodes that we already have. If we change one of the VM binaries, we > > > > likely have to refresh the information here. > > > > > > > > "mpu,boot-module-section" probably belongs to this group (unless we > > find > > > > a way to define "mpu,boot-module-section" generically so that we don't > > > > need to change it any time the set of boot modules change.) > > > > > > > > > > > > > > I agree. > > > > > > > > > It looks like we are forced to have the sections definitions at > > build > > > > > > time because we need them before we can parse device tree. In that > > > > case, > > > > > > we might as well define all the sections at build time. > > > > > > > > > > > > But I think it would be even better if Xen could automatically > > choose > > > > > > xen,static-mem, mpu,guest-memory-section, etc. on its own based on > > the > > > > > > regular device tree information (/memory, /amba, etc.), without > > any > > > > need > > > > > > for explicitly describing each range with these new properties. > > > > > > > > > > > > > > > > for mpu,guest-memory-section, with the limitations: no other usage > > > > between > > > > > different guest' memory nodes, this is OK. But for xen,static-mem > > (heap), > > > > > we just want everything on a MPU system is dertermistic. But, of > > course > > > > Xen > > > > > can select left memory for heap without static-mem. > > > > > > > > It is good that you think they can be chosen by Xen. > > > > > > > > Differently from "boot-module-section", which has to do with the boot > > > > modules selected by the user for a specific execution, > > > > guest-memory-section and static-mem are Xen specific memory > > > > policies/allocations. > > > > > > > > A user wouldn't know how to fill them in. And I worry that even a > > script > > > > > > But users should know it, because static-mem for guest must be allocated > > > in this range. And users take the responsibility to set the DomU's > > > static allocate memory ranges. > > > > Let me premise that my goal is to avoid having many users reporting > > errors to xen-devel and xen-users when actually it is just a wrong > > choice of addresses. > > > > I think we need to make a distinction between addresses for the boot > > modules, e.g. addresses where to load xen, the dom0/U kernel, dom0/U > > ramdisk in memory at boot time, and VM static memory addresses. > > > > The boot modules addresses are particularly difficult to fill in because > > they are many and a small update in one of the modules could invalidate > > all the other addresses. This is why I ended up writing ImageBuilder. > > Since them, I received several emails from users thanking me for > > ImageBuilder :-) > > > > Thanks +999 😊 > > > > The static VM memory addresses (xen,static-mem) should be a bit easier > > to fill in correctly. They are meant to be chosen once, and it shouldn't > > happen that an update on a kernel forces the user to change all the VM > > static memory addresses. Also, I know that some users actually want to > > be able to choose the domU addresses by hand because they have specific > > needs. So it is good that we can let the user choose the addresses if > > they want to. > > > > Yes. > > > With all of that said, I do think that many users won't have an opinion > > on the VM static memory addresses and won't know how to choose them. > > It would be error prone to let them try to fill them in by hand. So I > > was already planning on adding support to ImageBuilder to automatically > > generate xen,static-mem for dom0less domains. > > > > Let me make sure that's what you said: Users give an VM memory size to > ImageBuilder, and ImageBuilder will generate xen,static-mem = . > For specific VM, ImageBuilder also can accept start and size as inputs? > > Do I understand this correctly? Yes, exactly > > Going back to this specific discussion about boot-module-section: I can > > see now that, given xen,static-mem is chosen by ImageBuilder (or > > By hand : ) > > > similar) and not Xen, then it makes sense to have ImageBuilder (or > > similar) also generate boot-module-section. > > > > If my above understanding is right, then yes. Yes, I think we are on the same page > > > > like ImageBuilder wouldn't be the best place to pick these values -- > > > > they seem too "important" to leave to a script. > > > > > > > > But it seems possible to choose the values in Xen: > > > > - Xen knows ARM_MPU_NORMAL_MEMORY_* because it was defined at build > > time > > > > - Xen reads boot-module-section from device tree > > > > > > > > It should be possible at this point for Xen to pick the best values > > for > > > > guest-memory-section and static-mem based on the memory available. > > > > > > > > > > How Xen to pick? Does it mean in static allocation DomU DT node, we just > > > need a size, but don't require a start address for static-mem? > > > > Yes the idea was that the user would only provide the size (e.g. > > DOMU_STATIC_MEM[1]=1024) and the addresses would be automatically > > calculated. But I didn't mean to change the existing xen,static-mem > > device tree bindings. So it is best if the xen,static-mem addresses > > generation is done by ImageBuilder (or similar tool) instead of Xen. > > > > If we still keep the option for user to specify the start and size > parameters for VM memory, because it maybe very important for a > deterministic system (fully static system), I agree with you. > > And in current static-allocation, I think Xen doesn't generate > xen,static-mem addresses, all by hands... Yeah > > Sorry for the confusion! > > > > NP ; ) --8323329-615912675-1646261743=:3261-- From xen-devel-bounces@lists.xenproject.org Thu Mar 03 00:21:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Mar 2022 00:21:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282625.481399 (Exim 4.92) (envelope-from ) id 1nPZDY-0003nn-6N; Thu, 03 Mar 2022 00:21:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282625.481399; Thu, 03 Mar 2022 00:21:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPZDY-0003ng-2B; Thu, 03 Mar 2022 00:21:16 +0000 Received: by outflank-mailman (input) for mailman id 282625; Thu, 03 Mar 2022 00:21:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPZDV-0003na-Nb for xen-devel@lists.xenproject.org; Thu, 03 Mar 2022 00:21:14 +0000 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d2c6ac0e-9a87-11ec-8539-5f4723681683; Thu, 03 Mar 2022 01:21:10 +0100 (CET) Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 222LxCpl028857; Thu, 3 Mar 2022 00:20:48 GMT Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by mx0b-00069f02.pphosted.com with ESMTP id 3eh14bye8g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 03 Mar 2022 00:20:47 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 2230FK8p058469; Thu, 3 Mar 2022 00:20:46 GMT Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2168.outbound.protection.outlook.com [104.47.56.168]) by aserp3030.oracle.com with ESMTP id 3efa8h1t10-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 03 Mar 2022 00:20:46 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) by BY5PR10MB4225.namprd10.prod.outlook.com (2603:10b6:a03:20f::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Thu, 3 Mar 2022 00:20:44 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::6d20:6694:a16:56f7]) by BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::6d20:6694:a16:56f7%3]) with mapi id 15.20.5038.015; Thu, 3 Mar 2022 00:20:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d2c6ac0e-9a87-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=NFC70BiF9kXdxPXApLojElkpvB7Fub06OPV7fhkw2GY=; b=K45CXekakFKaF401RaG4CbLTQpA60u6PELkQLEaW767pqGE40YDE6AbmPCQaEZwzVD/Z hrOuG1GeXWsD2Hngkv3AiGbxkESdLaW1gDdixQIW0vCE7wAplW3G7LU3p4G1B6W0Y3s0 dbOWTnkQVuUX8FOs0q3lPM8H+EYgynidgicBneRlg0b/zjyYZKitUvLTSTWJRVFQc0vQ P3Z8wa7vexGOyGKt5ug/MocKI7hanZ9Zx72gzL55hQmD8NsLX7hmRJ9vIlCuot1IAh0e SxIMSvNYDSAMTUsK8rYJ8wyLtoue0Y0WCI9aH/fZ6w0xLXJZxL5WAd4jBd03TMcO0r9p NA== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ATJ3mRXWSVjXLKWkiYE0eHj8cr5Mfn0UHMNuEDQHph/uhaxJnbh+LZaxt5OrsQOAh6iVU4htyU1103jmeWAKeKsfjb8Bn4ZUP7T4AiWbeihfKZJIoji1k2SVVZmiq4uvGtBIHr0iHeoQVR3lwx13nNMyQJGyqcQcjxQCjZj6LUxXDeNhJdvtCQwHUCD/hwuPMCp7oVkeF37tuVrYl5bNCc/sj9BwNCsIrz9RW6ZTyLdTFMiXaNk6IZT5O1oE/FlouvzrNeAnxiq68gz1dW3a0flQ04RcN4g4yS13kBJEbD/DTSa/6feYO5Bs9hV/iKZ6DUZ6CAISSZnvHCrYzJLQqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NFC70BiF9kXdxPXApLojElkpvB7Fub06OPV7fhkw2GY=; b=KmC7IVTs1y2qALM9OwiyU0q/qYdMtaiWCkM6VzA5BqIdC2+7RBm65/pVGp0hi/RM9Py2DZbhJTZClJraQTfVlzx7xmQnBWT8QXoA17daAJoBTzUdj0C2mfLztIf3sbXlH5zL6YrF7EocgDEcr0QX4Fg+d0N/9vCzdYmmGauQRsrH1Cd4B16+fSB9DCjELs0QsKofI5MQgBqvwfcNLKtvYTvDMRYENFr5hFFFXiaDD+3wmeF9TnGnIrnQba+Ut2TBrdxLHLritZtbhWdZER0sOK14Vy0duqYj2ZlwWrLfskGOelfIOSAdze9GbpebCx87MKdtEkhCeiT1BRExXdoKhw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NFC70BiF9kXdxPXApLojElkpvB7Fub06OPV7fhkw2GY=; b=XgxL1hUkMet8KLa8aUaI8NFOoajUKw67wxe+XJrdk4YeCm0+b4C+1gdL6XJnB6bRS5iNDw5i3owM2RnvItEUdNgzB5QayPd6gPzhSLoF5EZwgR0OOV5U52BeqyOgpS4s+LL0Iu34soGWR1rHQGwoF3WDyc2ll95riiyoAUmWyf4= Message-ID: Date: Wed, 2 Mar 2022 19:20:38 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH v4 2/2] xen: delay xen_hvm_init_time_ops() if kdump is boot on vcpu>=32 Content-Language: en-US To: Dongli Zhang , xen-devel@lists.xenproject.org, x86@kernel.org Cc: linux-kernel@vger.kernel.org, jgross@suse.com, sstabellini@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, joe.jin@oracle.com References: <20220302164032.14569-1-dongli.zhang@oracle.com> <20220302164032.14569-3-dongli.zhang@oracle.com> From: Boris Ostrovsky In-Reply-To: <20220302164032.14569-3-dongli.zhang@oracle.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SN2PR01CA0047.prod.exchangelabs.com (2603:10b6:800::15) To BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d98bc3ed-e527-4c71-c59a-08d9fcaba80f X-MS-TrafficTypeDiagnostic: BY5PR10MB4225:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TohYRNj8TreF5p3lAxguGZdkAVJPUL9RvZn6bYkBzZk86MgmrLF5CrpbmruTFx3Qn8SNXgIWa6bZR/8m2mDJMfjV+ArzqUhWZPhFNcu+Y3eF+dMHCHEEfTpUOnRwAegQVeVy6qL9FDCSnNwUl+H1961FdM8gSkTxw5f6Kw98hUywtjaE/IoPkHRtH4cg6xTz5pfjNkokG8MVrjERtaBVOuicHSK1npvfOHtgt72ywOP1pKWRNwQ+ooaLP4h+X77hUaHhaI0rDHzQAsZtnfYXCCgM20AN0FlQHjEDR1FS6E31dyfFRIMl6F6007uNbnyt3xvhR/lpYNkc7AvDcyAt2BvAZqNJf30F3QwwReb2qQ9eBjaEUozeFSCJPyD7RzQKWisqJpvhYFPpSgrvw5Y7QfuF0Wy3Tcg8Ge8FkKKALGuK/fyZiAw1Bm+6NMU3sKD3dky/ybTh8Fhm+gcCrIT/UOih93V21pejAdlSTT92UD7rewWYy4WC776MRMZ15J6ZqxfYGuGv6jbazO4KIlf46/pzsNLmp7e7OAhefQAs9CNneVjA6pufkhr36Y7cMKI9P0Iub+6F4GaB5imKgpO4vFK27uck8w132umhnrwDEhhzd5zBW/eud31//FvMjmNRhofpCPLBdT25c688/hCEMm4nDfp92WofBPvS/qZFDdKNH2tQQwGcx2nueR6PiFMlHYBA6PzDPxw8tz4FTvIHlRIWufIelSbaNS+hi5V1cYlNSPbLzKyDo9ftsKCZjQaJ X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6666004)(36756003)(66476007)(66556008)(31686004)(31696002)(53546011)(26005)(186003)(8676002)(508600001)(2616005)(6512007)(6506007)(86362001)(6486002)(38100700002)(316002)(83380400001)(66946007)(44832011)(8936002)(107886003)(2906002)(5660300002)(4326008)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NkE5UVRaQ0lqdjY4VVE0K3pVeXVtZDM3dkhWQ3VzR1E3cU9Xb1RCWHpaendn?= =?utf-8?B?cS9mYmtwdHFTSmtnK2NNbUN4ZzhEbDRtNGM3R1NrUWFPUUtRU2dhR3JSWTlL?= =?utf-8?B?Y2RrYTR5WURabm1wbVlVUGZteU1rQkxYQzBudGROdUJaU243L3BBUGhrQkdD?= =?utf-8?B?R0t0czIvaWV6VkVPZzBQVVZ6MkRQbVZhUTVHNU9lVlpNWHlnZ3FpV0wwR2RC?= =?utf-8?B?TzFTNXFQcU1BOHhZc0JRbHUyMjZkakg4a3g0anNHWGVxNDE2S01VS20yOUEy?= =?utf-8?B?VWh3UVo4R1BaeHdlSTJkR3dwV1pmb09CUHlEaFhlcmcxQjhtOHZLaytkYmVt?= =?utf-8?B?TTA3NEFCZHUvRWxtWW54MmRRa0FuYWZXTmdKVWJvZ3JmNkwxSjR2ZU1MQTc4?= =?utf-8?B?dmt2UlVKSUdBdENvdjJGZk5TeFFQWG16RGtqSEdPUmU0ZHhGSHd3STVrNXE2?= =?utf-8?B?TG1FeW93aUFuellHdE9IMk15SHVWY2k1Q3RYR3pMT2gxc3huNlVqK0JWZDNX?= =?utf-8?B?MHhqSmtEU1BCbVlXbithUVNCTjFJS1pFZHFLdnFVSm1oSXpUOFdLaVQ5RDl0?= =?utf-8?B?bFV0aVFpWFI1OG1Ka0VmVEpBSTFCaXZpcWEvcEI0OHlJblh1bHZpMzBsNXFQ?= =?utf-8?B?a1QrRnUzOWhJWUhCdmhvTkliZG0zU1dXVFhzVFVFWnhGZnhSNEp6TS9QQkdu?= =?utf-8?B?V1NxejhxYTA1ZC9SbDlITXV2MEluZVdnMjhod09YRnY3N3NZR3d0R3h3a1BG?= =?utf-8?B?S0pndTk2WmUraGdNaUJQY0QwTmMvUEJQUE1kek9jS2F2NEdlTEtlMkd3c2hr?= =?utf-8?B?V3B1VE42NjB3MStYT0h4dGlNMTdBaDVBdiszQ0pqR1lRdFliaFQ4TThXUTZB?= =?utf-8?B?R1BtZDlFY1R4SkRMQ1NQcTNRVHFuSnZLbC93REF3QWlvbExMUGZNWHk5WGlD?= =?utf-8?B?a3JKRHZRRXpBTUlaa014eTB0ZGVuc2x3TkRyYm9paXJ3c0VaTkpYTmZEbGh2?= =?utf-8?B?N2Q1bnpyWGRESnV0cFphb21zcTdJZnB6Y3FNd1IzMmM3Z3poaTAwRVVPWi9t?= =?utf-8?B?bDZXWkdKTGx3bjZpUlI4Q0pLNy9mVEY5c0VPcXpHRHRGMDczME9qcFRYdTJz?= =?utf-8?B?ZmlLMVB1cndGUGVmTjk1dDhvZVdsMU53dTA3bjBYOFFDYVJHSWhaYkZFcXVT?= =?utf-8?B?T2x3ZXU4dnBqSmE4MlZ2MzE3T2tPak1nc1JwbkFvWHBVeElUcWVLOEY2VzVS?= =?utf-8?B?V04ySWJodHFVQm5HU1AvWEZlblMzdzB6OFRxOHpjeWpaYzROZXB5cE04eTJz?= =?utf-8?B?cW92aW45Vnd4WVpCZUlEdytWY0ZmeGMwdXBua2Q5MjQzc3BKVXBwQ3d3c1Y1?= =?utf-8?B?cmJSdUNUR2w0ZHp6a2xxRVVJcm5YbFBkMkQxS1BFTG9NWXZNR0RqZUtNampz?= =?utf-8?B?Vk9OajhoSHNyb1ZqTzZFNThibksvSEFZMkZaWjB6bUZVL3RlcnhxdWpsTE9S?= =?utf-8?B?UkozcGhXY0crWWdHWmQ2Zy95S3pFNnN4eC9xcGxFRmJldU8rbDhtd0FQWGZj?= =?utf-8?B?UU5ySFRpQTJrQUluamN6bkRyc2tMNVFkVmZuYXh5OUlDaVJNbVpkVEhBMDRn?= =?utf-8?B?V09yT0llaTFVNXFRN1dYSWc2RDgyeCtIemVFYTZGa3AyWGllMVpheERqR0o5?= =?utf-8?B?T1dzRG83QkNXYTIrWklaQVRoVHRGRlJWNm5ySkh4QThFanZwNnhhaUE1bmd5?= =?utf-8?B?TSsvRCtBalVhdjBUK1R4Z3l5VkJ3dkJuYWJoajhyWThndDFqVVcvMjdtUkl6?= =?utf-8?B?MzF6cGEyc2pva0lpdzlPdHIvdHhLeldZU1I2SlgyZWg0bEpiYmIzdzZzSjN1?= =?utf-8?B?TXcwbW5xcW9ScldpTFdzbjBTMkxuRTk4RjVaZFFWcTRFVFlXa0NCSi9hQjBq?= =?utf-8?B?ckFxVHR1empkelBOMXFFbnNpcjhsZUZ3d0NHYW8xeGhYbTZvQmVSNVV2ZXhp?= =?utf-8?B?clUwYmlOTWFNajdPNnc4bmxGa3o0QmNLSmU1QXUrdVptd0g1eDhJbTBscHp5?= =?utf-8?B?YkNjNUxlUk40RkIvZlhUbVpYVWN5eVFXOXkrbFZZTWpxSFltYWRxSGpsUmRv?= =?utf-8?B?KzVxZDBpYU55cS83eE5IeVpmcWVqeWdmL2NJb2hzRE10RmptbVVOMi9weGRz?= =?utf-8?B?YkZaaysrblE1MHdnSnRXN1pNUFhidHNZbndhcDJZb3cvRFBNc0MycTdyNzhH?= =?utf-8?B?Z1crYnNJU3FkYzdZUWk2UDUxK2dRPT0=?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: d98bc3ed-e527-4c71-c59a-08d9fcaba80f X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2022 00:20:43.9942 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hWCjmova3d4zTuCrrEKG9VfCssDqhkx5x71FMioIHZ7XFIkbbTh4yFrpnuIfbLWAIwsae42I+G9YMOQctCniaHeGLkY+FDjuRgWxIfhCgY8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB4225 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10274 signatures=686787 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 bulkscore=0 phishscore=0 malwarescore=0 mlxscore=0 suspectscore=0 spamscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000 definitions=main-2203030000 X-Proofpoint-GUID: AqtJ6_hgO6k6EjG8lvbXH9wk7Kf5d7O5 X-Proofpoint-ORIG-GUID: AqtJ6_hgO6k6EjG8lvbXH9wk7Kf5d7O5 On 3/2/22 11:40 AM, Dongli Zhang wrote: > void __init xen_hvm_init_time_ops(void) > { > + static bool hvm_time_initialized; > + > + if (hvm_time_initialized) > + return; > + > /* > * vector callback is needed otherwise we cannot receive interrupts > * on cpu > 0 and at this point we don't know how many cpus are > * available. > */ > if (!xen_have_vector_callback) > - return; > + goto exit; Why not just return? Do we expect the value of xen_have_vector_callback to change? -boris > > if (!xen_feature(XENFEAT_hvm_safe_pvclock)) { > pr_info("Xen doesn't support pvclock on HVM, disable pv timer"); > + goto exit; > + } > + > + /* > + * Only MAX_VIRT_CPUS 'vcpu_info' are embedded inside 'shared_info'. > + * The __this_cpu_read(xen_vcpu) is still NULL when Xen HVM guest > + * boots on vcpu >= MAX_VIRT_CPUS (e.g., kexec), To access > + * __this_cpu_read(xen_vcpu) via xen_clocksource_read() will panic. > + * > + * The xen_hvm_init_time_ops() should be called again later after > + * __this_cpu_read(xen_vcpu) is available. > + */ > + if (!__this_cpu_read(xen_vcpu)) { > + pr_info("Delay xen_init_time_common() as kernel is running on vcpu=%d\n", > + xen_vcpu_nr(0)); > return; > } > > @@ -577,6 +597,9 @@ void __init xen_hvm_init_time_ops(void) > x86_cpuinit.setup_percpu_clockev = xen_hvm_setup_cpu_clockevents; > > x86_platform.set_wallclock = xen_set_wallclock; > + > +exit: > + hvm_time_initialized = true; > } > #endif > From xen-devel-bounces@lists.xenproject.org Thu Mar 03 00:33:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Mar 2022 00:33:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282632.481410 (Exim 4.92) (envelope-from ) id 1nPZPO-0005c5-9M; Thu, 03 Mar 2022 00:33:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282632.481410; Thu, 03 Mar 2022 00:33:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPZPO-0005bi-6E; Thu, 03 Mar 2022 00:33:30 +0000 Received: by outflank-mailman (input) for mailman id 282632; Thu, 03 Mar 2022 00:33:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPZPM-0005bc-O1 for xen-devel@lists.xenproject.org; Thu, 03 Mar 2022 00:33:28 +0000 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8a0a64ee-9a89-11ec-8eba-a37418f5ba1a; Thu, 03 Mar 2022 01:33:26 +0100 (CET) Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 222Lx0Qb009253; Thu, 3 Mar 2022 00:32:00 GMT Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by mx0b-00069f02.pphosted.com with ESMTP id 3ehbk9e0aa-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 03 Mar 2022 00:32:00 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 2230GIU7113107; Thu, 3 Mar 2022 00:31:59 GMT Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2102.outbound.protection.outlook.com [104.47.70.102]) by userp3030.oracle.com with ESMTP id 3ef9b21s9t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 03 Mar 2022 00:31:59 +0000 Received: from BYAPR10MB2663.namprd10.prod.outlook.com (2603:10b6:a02:a9::20) by CY4PR10MB1541.namprd10.prod.outlook.com (2603:10b6:903:26::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.14; Thu, 3 Mar 2022 00:31:56 +0000 Received: from BYAPR10MB2663.namprd10.prod.outlook.com ([fe80::a0d5:610d:bcf:9b47]) by BYAPR10MB2663.namprd10.prod.outlook.com ([fe80::a0d5:610d:bcf:9b47%4]) with mapi id 15.20.5017.027; Thu, 3 Mar 2022 00:31:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8a0a64ee-9a89-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=bneHbRqEhwaWmn2AAsUC2F8vjj3KwmMr1Ijt7yZsINQ=; b=FetpJ9d07hxgnA+7F4yr8oABtIhJqjjksV6Lh+lXgd6YiomAScZiVurJCOE3sXctgCmG 5Eo+UwoCAxIRFyO8KoovtleBVQInlOcHXsCXmox4Q5MijkHHfE06KEcvUW+wgd9UCQ0j hjrlv+Gd2DPtV2EqpB37p1oFvB1x+04+9Jd8HRUa8meqx0O6bw7uD5gy7vjb0gO4M8nf 9/QmN/vjyyqOdov0YMOiWrm99lycVzlpmXgzjrFiRISRXPmfOzjKbQRa3vDppKT/Eve/ +ObTnODEhD7BzlODwnZ3jAzh2bXvJbyrbvSSmcdxbQS4HvnVVSPBEKIpEvFFGicTIjrC Iw== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HLqG/wDT5iomSPucBdOhILRPILaKr5nrt2vLmSewKISyMXEWV7oBLTKs8F3OZCJ7HdOWzaWyay2JyzfRx8Ny4zneDM/SXKblhV6ZcsLNOJa9CRrGG+/1jww3DaiXk/PqEIO7QsJ7qmtBmtqyqup7EXf1wtcEmhdKBk9qjv20oNaM3u7yAzCQQ/gmIoBbPs22+7QV4Em/TTEtvAmBWvNqMdArocGZhPz8JIUUHEXcjMrBluFnbDnvxVcG9PpGMOQuC7ULTOT9HccutruKtBl16ynaLyPDnafSvpa0hNYdjknooAIxt02RhaZe8H/LZwA/E4hTun8yiBrl3ETbs64f/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bneHbRqEhwaWmn2AAsUC2F8vjj3KwmMr1Ijt7yZsINQ=; b=NqVNdp1gaAotCL86aPA6a2uVfIU3V0G0T2dYVFTePGrFw4gpER+nGzOSNUE682V0pSMzpKYNioLOFX7o+0ASlJXK1MpxktARR968wQk7NMPViBaulUrPxlUflDJIncWueqI3XUL3DxCJy2AbU5ONC48P5weKOu9R/T1Myuh/Eu7fotzD8Iptu4nPXsXDdyChClntHonNmkhnO5K6q5mqYvEdEmtEstS+9ZVjzuZmrKx+CSjcby+2taslybxfoXttauqa5vBdUJi0sr+DPmd5Qg2B+3WjUBBfqsEucSCbvdsX0oXmf7ap5vxJqfTkMLO5moopBXwLSj1BILfZ3PZnmw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bneHbRqEhwaWmn2AAsUC2F8vjj3KwmMr1Ijt7yZsINQ=; b=eVkvMu5dyUuehXSjeonzSb1e4g8W6mjyzbmJaaj/3yXet+UPxXkG/uEWtKQfCgVt3/YUfYOR0/kuVwmMu32LtZvtjLupVmhAp2Bc+wzL2JfZJdRHe5bFpFq+hstqXEh0g9Pt0hPqyrrgglGMYFdcCkA3wY8C+Oyz/lXZ+mYVnkA= Subject: Re: [PATCH v4 2/2] xen: delay xen_hvm_init_time_ops() if kdump is boot on vcpu>=32 To: Boris Ostrovsky , xen-devel@lists.xenproject.org, x86@kernel.org Cc: linux-kernel@vger.kernel.org, jgross@suse.com, sstabellini@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, joe.jin@oracle.com References: <20220302164032.14569-1-dongli.zhang@oracle.com> <20220302164032.14569-3-dongli.zhang@oracle.com> From: Dongli Zhang Message-ID: <0ac50fb6-0aca-e61a-1f38-8badbc8c967a@oracle.com> Date: Wed, 2 Mar 2022 16:31:51 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DS7PR03CA0206.namprd03.prod.outlook.com (2603:10b6:5:3b6::31) To BYAPR10MB2663.namprd10.prod.outlook.com (2603:10b6:a02:a9::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a167a91b-32cd-475f-c16e-08d9fcad3855 X-MS-TrafficTypeDiagnostic: CY4PR10MB1541:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: y3myXNqkmDa9+8lYQHagGpjMPUYOE+7DKM2aHMH3H8nGkYyK8PYHp2SYW24l1gYJIQLiWVh87zSMpEs+rdUzEl/q/rDXCbDKCzhmW7fv/8ZzJY0P8jQoqMczDHDdXdp0OjKoDKA3+7n2PmjgyTN91TBGN+BRfxeVzwR5z/uwiOzsae8yA/pJSOQtowI64e2rIMCXFbc2rcrwY0pS/F6wiUTehZI7Y0hzHDU/AyRqi7uiZPCdFFZVDVEWm7Mu4i5uZaQNmjW+hWhJYrsOMxrTY8ok1nt7zMqke46kGj88mu64Hr4mgqzv2uoNYsC9Lc88e3UBgxe+6JXHizSx4BUic2wqfdThAyeWyGiZAQ8v2TJPBfiL+g82UjxfBKk/ltnnchpZhnkpb6XCkRk8YQQvD7pbOhHQ29DToQId9IsXaTeDIjyfXAAEpD48RFwg3L+AriC7c+9Z0zhl+MeFf7N8O/M5jrsQn01WitAkwqEFUVn3XuXrmIfzwtWOSRXeaftBb/F9TprbbzPrRWNW03QsFu3CGpZuxxtXas4Gu4LyeEMNbv4uF8n//OY7LpDTFO+dErlg+0xu5q3K417jv7PaAxKCetNy7OIYYeE6MG8glHL+icZzoU7ZA+KicCV1FWLq6iRuYz5SiV+k3mYQ/LGD6I1n9+dPikX6IehQh5AVkNxZhSzUCANyzoB/wUdxfb5XYOCaLTkmI7ZZEE0arUxEJ8StwDAQgvaTrWZAX39rGI8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB2663.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6666004)(2906002)(6512007)(38100700002)(53546011)(316002)(86362001)(6506007)(4326008)(8676002)(66556008)(66476007)(66946007)(44832011)(6486002)(5660300002)(31696002)(508600001)(8936002)(83380400001)(186003)(36756003)(2616005)(31686004)(107886003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RzdZdGh6b2dIUGk0L2EyZmI2RHJmZHAzTE1nQ2RXRFoxMlgvbEFIeFF4R1hV?= =?utf-8?B?RzFTaHNLOE1xNlRXUHQyaG9wSmNjWDk5MDZRaWhCSElvVHZpbzRlaUpyNkFS?= =?utf-8?B?MFZQMHFKWXd2SjlvU1FoaWVQZGJMVS9KWVNpT3BDSnFOVlFEUEM4UmhZYml5?= =?utf-8?B?MzF4N0JHNzUybEd5TnVEc0RwY01IOHdscEZHWFBYTkd0cUQ3TFAvMGtzVC82?= =?utf-8?B?MHQ0ZzRITVhsckEveDRCRi9QejduZFlzeFpGVVA3aHNHYWRPTzd1QXlyT1hR?= =?utf-8?B?S1NPS2ovYWswRG1LZXVmNHNUVG5SUTBrQWNzNHd0SWNQMWk2S2hrNFhnMEpC?= =?utf-8?B?cVpSWW9UYXdTOGgrdkQ4U3NLTkNKY3JEYUdoYnpJWXVjMklEZ0VzV0xwY2xa?= =?utf-8?B?Sk9xNm9NdzJjWWIwb0JJREx3WTFsNjNLaTVvU3dxREczRkNBT00xZ2lLd3Bj?= =?utf-8?B?TDlrdmNtcDZuUjZmWUlKbkNtZmtzODA5c0czSnRRMzRBN2VOdmRiTFJ1SWNW?= =?utf-8?B?UTkzNVhMYm8rSlhhK3VFbllMNmwwTENhZzBTR2s3MDdmQlJqMURCaWpBeWpV?= =?utf-8?B?dzM2ZUpMNnNvTy9CU2hPS1hEaXp0ZzlaaXgvaHg3bXJYa3pZTWtlZkwraHlI?= =?utf-8?B?QXdsbjR0YXB0aHZ6YVJnSjZuVW55bzVoYms5T29nVkRXa1BNMExDZm5MeU41?= =?utf-8?B?UDhNSmxwR1luVTVsbmVsYldyT21VTllwb2VLQmZndUViOHZkOWRZWHZ3ZWFm?= =?utf-8?B?NW5hOG11cDIvdk04SkJqMk9vRUFGZ2RkRjJ3M3FOVVNBQjN6NFVQdGdnUGRN?= =?utf-8?B?eG5qTHAzNXN5dkl3c0k1aGpISDE1OXprSGpJZExxNW5OS3dpSXNQVmJQa1hr?= =?utf-8?B?SjRIRzJKRGQ3ZWRNeXFCa0s3ZG1oQWhOeTlHUlZTU3BMbVR1MWN5V1FNakxZ?= =?utf-8?B?QVBtclVMdVExWVJHcXA5TDhrbUVsRzhHOHdPMGVobVA0MllUcm96WThPWEJa?= =?utf-8?B?UnEwVUFoc3hSM2dMSFd0cHNKWU1odjJxRlJic0dGWXpneDBkeXpEODBKVU1W?= =?utf-8?B?YnlzcjlFVXZiRnVNRlROeW1nRHIydk9UUXNRdHRTN3BPZlpvR1gwdUxxMWIx?= =?utf-8?B?alBMNkRiWVEvU0dLYzRIMlhTelg4aVpxbFN5Nys3WGYzUWdyc2x5Q2ZCek1J?= =?utf-8?B?TFdmRjdocXVnZDlnRjI3aEFSZndpdmtVdUhITk9NZUVPL0xieE5ka0ExdVZt?= =?utf-8?B?cUpiQnk2dldxZUFta055Tkc2emVyS2FZMUEwWG9meXFjeC92WG52UnZlYlQw?= =?utf-8?B?RlhvbDhPcklJeGQ1dWRIdGNUZ2VMb3Y4bGNPVit0aGxMbVkzbEkvMXowa01Y?= =?utf-8?B?NmltN1hnb1JIcGJzaEVTSEIvUlVxVTM3VExwaVk5VEkzbFIydnowMTdKNjN2?= =?utf-8?B?V3Y5Wk9pOG9FWUdRT0F1MDlvUjJ1dmZSZTV4c1gxcHB1bG9JTU1NaTNRRGFm?= =?utf-8?B?NldIOUFtK2s2M0YxZHdWZkxxQ001ZHhtMXhKTWFHYzBYYm0rVHNESytEanZu?= =?utf-8?B?YTU5Ny9tOTBiRzFtbDVrMHdYWTgzMzZ3YjFwMmN2UElWZExxdUhHWldWSG5r?= =?utf-8?B?dHFYL1pqakxremVkVEV4OUR1N3FFSDYwYTFvQlprMUhFZVhBbHByejNMUi9M?= =?utf-8?B?dG1wWjBMYWlMU0QvbzhJamRJOG1yM1JlSlJ0VUgxa0NMaUdTeFFDYVBYWXVB?= =?utf-8?B?U0JTdm5kM3ppdmJOQWk4OG9EY1hBM0Y1MkkxYTJJbWNyZjhUdmxCQ0pwdTZR?= =?utf-8?B?SUJTOU9oWStHZk9lSEd1Zk5Cd3FxU3lwcGxIN202anZQVlhjQzhici90Rk1j?= =?utf-8?B?bDI0aUxtRUlDc1BhNFIwc004dHVEVklOMjF0VTQ3T250NEhLeUFYYk5nK2Nn?= =?utf-8?B?VkhHUENKRXJDYm90MUR5dks2TnZMZTM2UHkvMG03ZXN5M2ZmVDdUTk55SjZh?= =?utf-8?B?cUNtSkJEaGNSa0IwTzBLbWRpYXZ5ejB6czlHRkdhOTFwSnY2aU1QeFIwY2ZJ?= =?utf-8?B?MkhFdWhyVDJUem5hR09sZWV2ZFFqNDBNV1lNanlGTktOTzVrRkZnbm5PQXRD?= =?utf-8?B?ell1aVM5UTJPeVVSYmVqUU82aEtQL25zNXFJWWM1OFo1SXhxZ2pRMSticy8w?= =?utf-8?Q?lACELUOc5FlO9udYys3e6+8eEfvlEtF2MTrj7ego1HRl?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: a167a91b-32cd-475f-c16e-08d9fcad3855 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2663.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2022 00:31:55.7759 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 82ogWqIU52jMnOI++7J/NYkGd8BouS7un0/Ay/OEGZzh5QmfGmqFpmS5iKp2gEOwEua1OrCR5qHoC7eJl+drSw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR10MB1541 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10274 signatures=686787 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 malwarescore=0 mlxscore=0 phishscore=0 suspectscore=0 adultscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000 definitions=main-2203030000 X-Proofpoint-GUID: 7Mx52FzyCmKMcO_eKudYMl6iPTCprjHJ X-Proofpoint-ORIG-GUID: 7Mx52FzyCmKMcO_eKudYMl6iPTCprjHJ Hi Boris, On 3/2/22 4:20 PM, Boris Ostrovsky wrote: > > On 3/2/22 11:40 AM, Dongli Zhang wrote: >>   void __init xen_hvm_init_time_ops(void) >>   { >> +    static bool hvm_time_initialized; >> + >> +    if (hvm_time_initialized) >> +        return; >> + >>       /* >>        * vector callback is needed otherwise we cannot receive interrupts >>        * on cpu > 0 and at this point we don't know how many cpus are >>        * available. >>        */ >>       if (!xen_have_vector_callback) >> -        return; >> +        goto exit; > > > Why not just return? Do we expect the value of xen_have_vector_callback to change? I just want to keep above sync with .... > > > -boris > > >>         if (!xen_feature(XENFEAT_hvm_safe_pvclock)) { >>           pr_info("Xen doesn't support pvclock on HVM, disable pv timer"); >> +        goto exit; >> +    } ... here. That is, I want the main logic of xen_hvm_init_time_ops() to run for at most once. Both of above two if statements will "go to exit". Thank you very much! Dongli Zhang >> + >> +    /* >> +     * Only MAX_VIRT_CPUS 'vcpu_info' are embedded inside 'shared_info'. >> +     * The __this_cpu_read(xen_vcpu) is still NULL when Xen HVM guest >> +     * boots on vcpu >= MAX_VIRT_CPUS (e.g., kexec), To access >> +     * __this_cpu_read(xen_vcpu) via xen_clocksource_read() will panic. >> +     * >> +     * The xen_hvm_init_time_ops() should be called again later after >> +     * __this_cpu_read(xen_vcpu) is available. >> +     */ >> +    if (!__this_cpu_read(xen_vcpu)) { >> +        pr_info("Delay xen_init_time_common() as kernel is running on >> vcpu=%d\n", >> +            xen_vcpu_nr(0)); >>           return; >>       } >>   @@ -577,6 +597,9 @@ void __init xen_hvm_init_time_ops(void) >>       x86_cpuinit.setup_percpu_clockev = xen_hvm_setup_cpu_clockevents; >>         x86_platform.set_wallclock = xen_set_wallclock; >> + >> +exit: >> +    hvm_time_initialized = true; >>   } >>   #endif >>   From xen-devel-bounces@lists.xenproject.org Thu Mar 03 00:40:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Mar 2022 00:40:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282639.481421 (Exim 4.92) (envelope-from ) id 1nPZWW-0007OP-0p; Thu, 03 Mar 2022 00:40:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282639.481421; Thu, 03 Mar 2022 00:40:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPZWV-0007OI-TU; Thu, 03 Mar 2022 00:40:51 +0000 Received: by outflank-mailman (input) for mailman id 282639; Thu, 03 Mar 2022 00:40:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPZWV-0007OC-1T for xen-devel@lists.xenproject.org; Thu, 03 Mar 2022 00:40:51 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 910642e1-9a8a-11ec-8eba-a37418f5ba1a; Thu, 03 Mar 2022 01:40:48 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 910642e1-9a8a-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1646268048; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=3wDk5sjgceGIpGYWpd8sSIy5+b30C+/+xACaZX5XfAo=; b=UOqxcTXsRdtc3RiOXdQxbP+xjLGGWxeI7NeuthA+KYLVxn3ujrlQeRaY 0y/hv6XTZHqxZ3Ba3Q9bl6SRBjR7DsOgIlt9VHNqpCKudx+02RZDNvZIR fAezV6LvZSp7m9cohGzTXgGCYe+zVJF3ArJCRnhgc7gbp6HRAChb66eJ6 8=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 65355541 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:etSnw6CDt5MBOxVW/wrjw5YqxClBgxIJ4kV8jS/XYbTApGsn0zRSy zBOWmyGaaqCMWL2eot0PYXi8UxX657cx4U3QQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHWeIdA970Ug5w7Vh2NY06TSEK1jlV e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPh1z vBilLmLSjwbEbfLisRAaBZdNTtXaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us 6ZCcXZUM07F17neLLGTE4GAguwKKsXxMZxZkXZn1TzDVt4tQIzZQrWM7thdtNs1rp4TRquDO pZAAdZpRCqbUjBMZBAdMb8zmuyHoCWmcSRYjU3A8MLb5ECMlVcsgdABKuH9eNOQQt5Otl2Fv W+A9GP8ajkWOtWQxjuC9nOEnfLUkGXwX4d6PJ+S++NugVaT7ncOExBQXly+ydGph0j7V99BJ kg8/is1sbN05EGtVsP6XRCzvDiDpBF0c8VUO/037keK0KW83uqCLjFaFHgbMoVg7ZJoA2xxv rOUoz/3LThplZK0bEmezYW7tzSgGXUuImokfwZRGGPp/OLfiI00ixvOSPNqH6i0ksD5FFnM/ tyakMQtr+5N1JBWjs1X6XiC2mvx/caREmbZ8y2KBjrN0+9vWGKyi2VEA3D/5O0IEouWR0LpU JMsy5nHt7Bm4X1geUWwrAQx8FOBuq7t3N702wcH83wdG9KFoSTLkWd4umwWGauRGpxYEQIFm WeK0e+r2LddPWGxcYh8aJ+rBsIhwMDITIq5CKqIMIYfOccsLWdrGR2Cg2bKhQgBd2B2zMkC1 WqzK57wXR7294w9pNZJewvt+eBynX1vrY8ibZv60w6mwdKjiI29Et843K+1Rrlhtsus+VyNm /4Gbpfi40gPAYXWP3iMmaZOfA9iEJTOLc2vwyChXrXYeVQO9aBII6K5/I7NjKQ+x/UFzrqTp yrlMqKaoXKm7UD6xcyxQigLQNvSsVxX9BrX4QRE0Y6U5kUe IronPort-HdrOrdr: A9a23:ZD9e1qrazpyTbYVHTa/HV0oaV5oleYIsimQD101hICG8cqSj9v xG+85rsyMc6QxhP03I9urwW5VoLUmyyXcX2/h0AV7BZniFhILAFugLhuGOrwEIcxeOj9K1vp 0BT0ERMrPN5CBB/KPH3DU= X-IronPort-AV: E=Sophos;i="5.90,150,1643691600"; d="scan'208";a="65355541" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Juergen Gross , Dario Faggioli Subject: [PATCH RFC] xen/sched: Optimise when only one scheduler is compiled in Date: Thu, 3 Mar 2022 00:40:15 +0000 Message-ID: <20220303004015.17688-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit When only one scheduler is compiled in, function pointers can be optimised to direct calls, and the hooks hardened against controlflow hijacking. RFC for several reasons. 1) There's an almost beautiful way of not introducing MAYBE_SCHED() and hiding the magic in REGISTER_SCHEDULER(), except it falls over https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91765 which has no comment or resolution at all. 2) A different alternative which almost works is to remove the indirection in .data.schedulers, but the singleton scheduler object can't be both there and in .init.rodata.cf_clobber. 3) I can't think of a way of build time check to enforce that new schedulers get added to the preprocessor magic. And the blocker: 4) This isn't compatible with how sched_idle_ops get used for granularity > 1. Suggestions very welcome. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu CC: Juergen Gross CC: Dario Faggioli --- xen/common/sched/arinc653.c | 2 +- xen/common/sched/core.c | 4 +- xen/common/sched/credit.c | 2 +- xen/common/sched/credit2.c | 2 +- xen/common/sched/null.c | 2 +- xen/common/sched/private.h | 91 ++++++++++++++++++++++++++++++++------------- xen/common/sched/rt.c | 2 +- 7 files changed, 72 insertions(+), 33 deletions(-) diff --git a/xen/common/sched/arinc653.c b/xen/common/sched/arinc653.c index a82c0d7314a1..73738b007e7d 100644 --- a/xen/common/sched/arinc653.c +++ b/xen/common/sched/arinc653.c @@ -694,7 +694,7 @@ a653sched_adjust_global(const struct scheduler *ops, * callback functions. * The symbol must be visible to the rest of Xen at link time. */ -static const struct scheduler sched_arinc653_def = { +const struct scheduler MAYBE_SCHED(sched_arinc653_def) = { .name = "ARINC 653 Scheduler", .opt_name = "arinc653", .sched_id = XEN_SCHEDULER_ARINC653, diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c index 19ab67818106..020a5741ca31 100644 --- a/xen/common/sched/core.c +++ b/xen/common/sched/core.c @@ -2263,7 +2263,7 @@ static struct sched_unit *do_schedule(struct sched_unit *prev, s_time_t now, struct sched_unit *next; /* get policy-specific decision on scheduling... */ - sched->do_schedule(sched, prev, now, sched_tasklet_check(cpu)); + sched_vcall(sched, do_schedule, sched, prev, now, sched_tasklet_check(cpu)); next = prev->next_task; @@ -2975,7 +2975,7 @@ void __init scheduler_init(void) #undef sched_test_func - if ( schedulers[i]->global_init && schedulers[i]->global_init() < 0 ) + if ( sched_global_init(schedulers[i]) < 0 ) { printk("scheduler %s failed initialization, dropped\n", schedulers[i]->opt_name); diff --git a/xen/common/sched/credit.c b/xen/common/sched/credit.c index 4d3bd8cba6fc..8b85e9617fc0 100644 --- a/xen/common/sched/credit.c +++ b/xen/common/sched/credit.c @@ -2230,7 +2230,7 @@ csched_deinit(struct scheduler *ops) } } -static const struct scheduler sched_credit_def = { +const struct scheduler MAYBE_SCHED(sched_credit_def) = { .name = "SMP Credit Scheduler", .opt_name = "credit", .sched_id = XEN_SCHEDULER_CREDIT, diff --git a/xen/common/sched/credit2.c b/xen/common/sched/credit2.c index 0e3f89e5378e..fda3812d7ac1 100644 --- a/xen/common/sched/credit2.c +++ b/xen/common/sched/credit2.c @@ -4199,7 +4199,7 @@ csched2_deinit(struct scheduler *ops) xfree(prv); } -static const struct scheduler sched_credit2_def = { +const struct scheduler MAYBE_SCHED(sched_credit2_def) = { .name = "SMP Credit Scheduler rev2", .opt_name = "credit2", .sched_id = XEN_SCHEDULER_CREDIT2, diff --git a/xen/common/sched/null.c b/xen/common/sched/null.c index 65a0a6c5312d..907a8ae1ca50 100644 --- a/xen/common/sched/null.c +++ b/xen/common/sched/null.c @@ -1025,7 +1025,7 @@ static void cf_check null_dump(const struct scheduler *ops) spin_unlock_irqrestore(&prv->lock, flags); } -static const struct scheduler sched_null_def = { +const struct scheduler MAYBE_SCHED(sched_null_def) = { .name = "null Scheduler", .opt_name = "null", .sched_id = XEN_SCHEDULER_NULL, diff --git a/xen/common/sched/private.h b/xen/common/sched/private.h index a870320146ef..f3ba0101ecc7 100644 --- a/xen/common/sched/private.h +++ b/xen/common/sched/private.h @@ -271,6 +271,33 @@ static inline spinlock_t *pcpu_schedule_trylock(unsigned int cpu) return NULL; } +#if 1 == \ + defined(CONFIG_SCHED_CREDIT) + defined(CONFIG_SCHED_CREDIT2) + \ + defined(CONFIG_SCHED_RTDS) + defined(CONFIG_SCHED_ARINC653) + \ + defined(CONFIG_SCHED_NULL) + +extern const struct scheduler sched_ops; +#define MAYBE_SCHED(x) __initdata_cf_clobber sched_ops +#define REGISTER_SCHEDULER(x) static const struct scheduler *x##_entry \ + __used_section(".data.schedulers") = &sched_ops; + +#define sched_call(s, fn, ...) \ + alternative_call(sched_ops.fn, ##__VA_ARGS__) + +#define sched_vcall(s, fn, ...) \ + alternative_vcall(sched_ops.fn, ##__VA_ARGS__) + +#else + +#define MAYBE_SCHED(x) static x +#define REGISTER_SCHEDULER(x) static const struct scheduler *x##_entry \ + __used_section(".data.schedulers") = &x; + +#define sched_call(s, fn, ...) (s)->fn(__VA_ARGS__) +#define sched_vcall(s, fn, ...) (s)->fn(__VA_ARGS__) + +#endif + struct scheduler { const char *name; /* full name for this scheduler */ const char *opt_name; /* option name for this scheduler */ @@ -333,39 +360,48 @@ struct scheduler { void (*dump_cpu_state) (const struct scheduler *, int); }; +static inline int sched_global_init(const struct scheduler *s) +{ + if ( s->global_init ) + return sched_call(s, global_init); + return 0; +} + static inline int sched_init(struct scheduler *s) { - return s->init(s); + return sched_call(s, init, s); } static inline void sched_deinit(struct scheduler *s) { - s->deinit(s); + sched_vcall(s, deinit, s); } static inline spinlock_t *sched_switch_sched(struct scheduler *s, unsigned int cpu, void *pdata, void *vdata) { - return s->switch_sched(s, cpu, pdata, vdata); + return sched_call(s, switch_sched, s, cpu, pdata, vdata); } static inline void sched_dump_settings(const struct scheduler *s) { if ( s->dump_settings ) - s->dump_settings(s); + sched_vcall(s, dump_settings, s); } static inline void sched_dump_cpu_state(const struct scheduler *s, int cpu) { if ( s->dump_cpu_state ) - s->dump_cpu_state(s, cpu); + sched_vcall(s, dump_cpu_state, s, cpu); } static inline void *sched_alloc_domdata(const struct scheduler *s, struct domain *d) { - return s->alloc_domdata ? s->alloc_domdata(s, d) : NULL; + if ( s->alloc_domdata ) + return sched_call(s, alloc_domdata, s, d); + return NULL; } static inline void sched_free_domdata(const struct scheduler *s, @@ -373,12 +409,14 @@ static inline void sched_free_domdata(const struct scheduler *s, { ASSERT(s->free_domdata || !data); if ( s->free_domdata ) - s->free_domdata(s, data); + sched_vcall(s, free_domdata, s, data); } static inline void *sched_alloc_pdata(const struct scheduler *s, int cpu) { - return s->alloc_pdata ? s->alloc_pdata(s, cpu) : NULL; + if ( s->alloc_pdata ) + return sched_call(s, alloc_pdata, s, cpu); + return NULL; } static inline void sched_free_pdata(const struct scheduler *s, void *data, @@ -386,74 +424,74 @@ static inline void sched_free_pdata(const struct scheduler *s, void *data, { ASSERT(s->free_pdata || !data); if ( s->free_pdata ) - s->free_pdata(s, data, cpu); + sched_vcall(s, free_pdata, s, data, cpu); } static inline void sched_deinit_pdata(const struct scheduler *s, void *data, int cpu) { if ( s->deinit_pdata ) - s->deinit_pdata(s, data, cpu); + sched_vcall(s, deinit_pdata, s, data, cpu); } static inline void *sched_alloc_udata(const struct scheduler *s, struct sched_unit *unit, void *dom_data) { - return s->alloc_udata(s, unit, dom_data); + return sched_call(s, alloc_udata, s, unit, dom_data); } static inline void sched_free_udata(const struct scheduler *s, void *data) { - s->free_udata(s, data); + sched_vcall(s, free_udata, s, data); } static inline void sched_insert_unit(const struct scheduler *s, struct sched_unit *unit) { if ( s->insert_unit ) - s->insert_unit(s, unit); + sched_vcall(s, insert_unit, s, unit); } static inline void sched_remove_unit(const struct scheduler *s, struct sched_unit *unit) { if ( s->remove_unit ) - s->remove_unit(s, unit); + sched_vcall(s, remove_unit, s, unit); } static inline void sched_sleep(const struct scheduler *s, struct sched_unit *unit) { if ( s->sleep ) - s->sleep(s, unit); + sched_vcall(s, sleep, s, unit); } static inline void sched_wake(const struct scheduler *s, struct sched_unit *unit) { if ( s->wake ) - s->wake(s, unit); + sched_vcall(s, wake, s, unit); } static inline void sched_yield(const struct scheduler *s, struct sched_unit *unit) { if ( s->yield ) - s->yield(s, unit); + sched_vcall(s, yield, s, unit); } static inline void sched_context_saved(const struct scheduler *s, struct sched_unit *unit) { if ( s->context_saved ) - s->context_saved(s, unit); + sched_vcall(s, context_saved, s, unit); } static inline void sched_migrate(const struct scheduler *s, struct sched_unit *unit, unsigned int cpu) { if ( s->migrate ) - s->migrate(s, unit, cpu); + sched_vcall(s, migrate, s, unit, cpu); else sched_set_res(unit, get_sched_res(cpu)); } @@ -461,7 +499,7 @@ static inline void sched_migrate(const struct scheduler *s, static inline struct sched_resource *sched_pick_resource( const struct scheduler *s, const struct sched_unit *unit) { - return s->pick_resource(s, unit); + return sched_call(s, pick_resource, s, unit); } static inline void sched_adjust_affinity(const struct scheduler *s, @@ -470,19 +508,23 @@ static inline void sched_adjust_affinity(const struct scheduler *s, const cpumask_t *soft) { if ( s->adjust_affinity ) - s->adjust_affinity(s, unit, hard, soft); + sched_vcall(s, adjust_affinity, s, unit, hard, soft); } static inline int sched_adjust_dom(const struct scheduler *s, struct domain *d, struct xen_domctl_scheduler_op *op) { - return s->adjust ? s->adjust(s, d, op) : 0; + if ( s->adjust ) + return sched_call(s, adjust, s, d, op); + return 0; } static inline int sched_adjust_cpupool(const struct scheduler *s, struct xen_sysctl_scheduler_op *op) { - return s->adjust_global ? s->adjust_global(s, op) : 0; + if ( s->adjust_global ) + return sched_call(s, adjust_global, s, op); + return 0; } static inline void sched_unit_pause_nosync(const struct sched_unit *unit) @@ -501,9 +543,6 @@ static inline void sched_unit_unpause(const struct sched_unit *unit) vcpu_unpause(v); } -#define REGISTER_SCHEDULER(x) static const struct scheduler *x##_entry \ - __used_section(".data.schedulers") = &x; - struct cpupool { unsigned int cpupool_id; diff --git a/xen/common/sched/rt.c b/xen/common/sched/rt.c index d6de25531b3c..9b42852b2de5 100644 --- a/xen/common/sched/rt.c +++ b/xen/common/sched/rt.c @@ -1529,7 +1529,7 @@ static void cf_check repl_timer_handler(void *data) spin_unlock_irq(&prv->lock); } -static const struct scheduler sched_rtds_def = { +const struct scheduler MAYBE_SCHED(sched_rtds_def) = { .name = "SMP RTDS Scheduler", .opt_name = "rtds", .sched_id = XEN_SCHEDULER_RTDS, -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Thu Mar 03 01:06:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Mar 2022 01:06:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282648.481432 (Exim 4.92) (envelope-from ) id 1nPZum-00047M-6O; Thu, 03 Mar 2022 01:05:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282648.481432; Thu, 03 Mar 2022 01:05:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPZul-00046v-Uf; Thu, 03 Mar 2022 01:05:55 +0000 Received: by outflank-mailman (input) for mailman id 282648; Thu, 03 Mar 2022 01:05:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPZuk-00046p-DL for xen-devel@lists.xenproject.org; Thu, 03 Mar 2022 01:05:54 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20631.outbound.protection.outlook.com [2a01:111:f400:7e1a::631]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 11377db3-9a8e-11ec-8eba-a37418f5ba1a; Thu, 03 Mar 2022 02:05:51 +0100 (CET) Received: from AS9PR04CA0045.eurprd04.prod.outlook.com (2603:10a6:20b:46a::15) by AM6PR08MB4023.eurprd08.prod.outlook.com (2603:10a6:20b:a6::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.26; Thu, 3 Mar 2022 01:05:49 +0000 Received: from VE1EUR03FT012.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:46a:cafe::2e) by AS9PR04CA0045.outlook.office365.com (2603:10a6:20b:46a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.14 via Frontend Transport; Thu, 3 Mar 2022 01:05:48 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT012.mail.protection.outlook.com (10.152.18.211) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22 via Frontend Transport; Thu, 3 Mar 2022 01:05:48 +0000 Received: ("Tessian outbound 63bb5eb69ee8:v113"); Thu, 03 Mar 2022 01:05:48 +0000 Received: from 88c9726fdbe2.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 9875AD53-326C-4885-980F-8AF02F8EFAA1.1; Thu, 03 Mar 2022 01:05:42 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 88c9726fdbe2.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 03 Mar 2022 01:05:42 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by AM0PR08MB4339.eurprd08.prod.outlook.com (2603:10a6:208:142::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.14; Thu, 3 Mar 2022 01:05:40 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::89b3:80a2:2b58:f1aa]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::89b3:80a2:2b58:f1aa%4]) with mapi id 15.20.5038.014; Thu, 3 Mar 2022 01:05:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 11377db3-9a8e-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7RTWfZctXhAoa06mMdMsSAwm5WCA7tHVDO1sXwXRxRo=; b=eVJoRjvFp1ebH5VodMZbV/HsjzT2cFjIYZvqUgPsh8udpTHVBj0JDujHMzrFza7+okmCQ/CMbdxO1eb60x5LmzWyA6N7H20jX+jcMnoBdwfp+1u1DCYQYR3YhMD0/LUtNiYrVUR5ER+pXYJy9VqXxoMPfd9W5Z+f0Vdka7vj7Hs= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L7GQwkWNRKumhGvPk4YbZ0ELjyrwd/wxmQimaRGXhSQnrr+uvbWQWFSBIWaBcpaubkNq6o84X6uKo87DpC1fCUPOpQuKSlUW/56OOkjGPa+KcOpLOIgO3YuyXQ97asGaer4FM/XDKmliVteMVGQHett0xLP+J+w/Lh/HY482ZI6wPpc2tRSWiJwvMKgo9ssprlsiCR7A8HNcVqvDW2SxTk6uPvoxNFRSzMXRHkQ8qnLiopSeFiTVArHE6eJBhN0fQycE4P939lzGtaBSzZAtN5qQwaJjkWqAd4YCrAOe8EZe5cH4D/wE5ayTLXF2XFtX9RO4fd8p6TGsbnE8U5oivw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7RTWfZctXhAoa06mMdMsSAwm5WCA7tHVDO1sXwXRxRo=; b=nNgByuHo/QuJtgDbVfALyinqSHBbWy14p89NBi2P8ody7kIqBRWXloNEZGpNJxnjImWxd7DiwhFPbbL70Qbv/cnSz/ayAEChUfwCnusM2YRjMTZgEQwBhps85I3EDv58ne5vJPnvfAFksEzJOfwHY0Sknfj7LsYzy2K2WJceXd8agos2o+2/s/ryHHr5n4yaQHZJ+ojs2cfT5pMJ+evET65j0+TYvSgDJvaeju982MwUIegsG/zAjNZwBW+//61VxNbl4thuxg5YMboHCZpYhiwj4iH2npyLVLAFxOzCuMwX9NTJnidAnskbY/x+FJHcZsGdc2J3islbXmfd9eUrnw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7RTWfZctXhAoa06mMdMsSAwm5WCA7tHVDO1sXwXRxRo=; b=eVJoRjvFp1ebH5VodMZbV/HsjzT2cFjIYZvqUgPsh8udpTHVBj0JDujHMzrFza7+okmCQ/CMbdxO1eb60x5LmzWyA6N7H20jX+jcMnoBdwfp+1u1DCYQYR3YhMD0/LUtNiYrVUR5ER+pXYJy9VqXxoMPfd9W5Z+f0Vdka7vj7Hs= From: Wei Chen To: Stefano Stabellini CC: "xen-devel@lists.xenproject.org" , "julien@xen.org" , Bertrand Marquis , Penny Zheng , Henry Wang , nd Subject: RE: Proposal for Porting Xen to Armv8-R64 - DraftA Thread-Topic: Proposal for Porting Xen to Armv8-R64 - DraftA Thread-Index: AdgpQxtXwh7LkfydTgiYk9bhMgU+ogAn0mUAABEK2UAAHxozAACs/mTQABukuQAADud+gAAh4EYAAARjx9A= Date: Thu, 3 Mar 2022 01:05:38 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 5F30937351ED27478F2F62DFDCB73C5F.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 7e829b67-e16c-464c-9c0a-08d9fcb1f42a x-ms-traffictypediagnostic: AM0PR08MB4339:EE_|VE1EUR03FT012:EE_|AM6PR08MB4023:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: RHEZNvhE1sSn85W1xyMNjVfFtMHEPkjOgMH1zua8PNvaWQJGF9vA0x/Z330ZhGXWfZcM1wWs/0n6/hqyqrL2u1VUlNERY62LdbRvoSKMHcLofAwrJlMNW4DcdxIPDKKeuCgqTyO0cGsXCl9mauGKdgGYUDq/n1gAUq/DbVxE6NpCD1zdjY75q/WvbNI8ZiZqykGBCUnup9EAxBYFnf558PzGnEjBXZtfcGxfYVkPMMI2noJmMNUs+tU9GI6LDZorhDUvtYIZpmYyBRXVWqCe2aAKBzWHeeCjhba31GiN9/CIqGQssLEZ4v91rX6HMP0CEjXlt8KFiXJ7JZpF1RmRRo0mjQ6gB7OMNAodUSIKD0ZuS1VRxjVW9ni/tBsovffZrcViLkKu+JLMuUXgTg7pa8mXCjDsJnTsYRYI7UC2K5Vg9EVMF64twDgrmOjdXtA8UrRDUUS3YnD0QLQJnOCwMzuS96P9gFctsgzKvuB4BF0q33gkdbj6OFSj2Vgzh/31Ldvlk5GwZbYhIFApMfjzEpfhq0YAlUaDmtzWRAHdfoKzD5RWwUQzafhjsSnU+Ot4p3SejWe1eOdS/K/G+HaJm07N1GiFx9ia07qjznn1MF1VFQGxmtw4SkKPBK1OdQesQ9pgToeby2OrFirxAr2B8sJHbA4dScCKR+7xVMfF/cFnt0Udya+Juep2b4OO3uCZt1cfjhIWUN+ZyWUiWwKHYw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(8936002)(52536014)(5660300002)(38100700002)(186003)(122000001)(4326008)(55016003)(8676002)(2906002)(66946007)(76116006)(66476007)(66556008)(66446008)(64756008)(26005)(53546011)(6506007)(7696005)(83380400001)(316002)(38070700005)(86362001)(6916009)(54906003)(71200400001)(9686003)(33656002)(508600001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4339 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT012.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 9e3c3d70-6073-41f8-31a6-08d9fcb1eef8 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lym0qVbSUt1ChKa+JIjj7CBN9zQUI5IdLfp1f1XrzR5aoda2hsoA9e97F7OztPtdoxyWJ9a6fWFdXpcJ0kuXRtel0xK8Dv4GGOOMXQCqI8BWgx7huwGilRcotwNkK0CGDRDh2qqXmhgpU+0CK1uBwneWWXsbcyvudf07aAzMi/pUWsINmFs5fKeK4WYWPSY2dOcnjhlaDpnx25FOygmW/Kf7ddPPZSIWgZ0ImfReZFFqjXFGmtcHIF067amG66OI41+1RWFA+XI9gluwFNe3ujUnykpiTnVYlK9L077GrSR6denuIvB2oSTysbORXGobdp2K5jT+ZH9xb7F0IXE7Wq1FiKfJ5245UWnAMBAGJiufvkdJ0Wuri6GVMRbl+OyhEKXlFFBNNvNyUef2yXpMP0aMsjE6sOHS3DpWotoFyFekA0AR3eGsLCopIDlqVTN4zU1owp/5dkNJf6oewUHaIhI8MgKGVR+Xb1FxtL6/6pScB8khC6EeBw4IAslRZRfu776vFodp/xCzn98NQ2EUVzyp9XgyRMER1IHFR4Cxs1BxDGqUB1Xva73s5/N/4OppK8DCPWiVxuksqRxH4e8V7tMbOR6Cv/cN7+ZJZammbu9W2P7US+LKVuwRiB7bi0UxDBK8LwDu2rf5tP9y5/lV8hsNBAPaX35PXQrft0n3uevEULIipvvST4htTNCTi19I X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(53546011)(9686003)(356005)(81166007)(336012)(7696005)(6506007)(47076005)(36860700001)(2906002)(40460700003)(186003)(33656002)(26005)(82310400004)(5660300002)(70206006)(70586007)(52536014)(8676002)(4326008)(6862004)(86362001)(55016003)(508600001)(8936002)(83380400001)(54906003)(316002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2022 01:05:48.4073 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7e829b67-e16c-464c-9c0a-08d9fcb1f42a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT012.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4023 SGkgU3RlZmFubywNCg0KPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBTdGVm YW5vIFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+DQo+IFNlbnQ6IDIwMjLlubQz 5pyIM+aXpSA2OjU2DQo+IFRvOiBXZWkgQ2hlbiA8V2VpLkNoZW5AYXJtLmNvbT4NCj4gQ2M6IFN0 ZWZhbm8gU3RhYmVsbGluaSA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz47IHhlbi0NCj4gZGV2ZWxA bGlzdHMueGVucHJvamVjdC5vcmc7IGp1bGllbkB4ZW4ub3JnOyBCZXJ0cmFuZCBNYXJxdWlzDQo+ IDxCZXJ0cmFuZC5NYXJxdWlzQGFybS5jb20+OyBQZW5ueSBaaGVuZyA8UGVubnkuWmhlbmdAYXJt LmNvbT47IEhlbnJ5IFdhbmcNCj4gPEhlbnJ5LldhbmdAYXJtLmNvbT47IG5kIDxuZEBhcm0uY29t Pg0KPiBTdWJqZWN0OiBSRTogUHJvcG9zYWwgZm9yIFBvcnRpbmcgWGVuIHRvIEFybXY4LVI2NCAt IERyYWZ0QQ0KPiANCj4gT24gV2VkLCAyIE1hciAyMDIyLCBXZWkgQ2hlbiB3cm90ZToNCj4gPiA+ ID4gPiA+ID4gSWYgbm90LCBhbmQgY29uc2lkZXJpbmcgdGhhdCB3ZSBoYXZlIHRvIGdlbmVyYXRl DQo+ID4gPiA+ID4gPiA+IEFSTV9NUFVfKl9NRU1PUllfU1RBUlQvRU5EIGFueXdheSBhdCBidWls ZCB0aW1lLCB3b3VsZCBpdCBtYWtlDQo+ID4gPiBzZW5zZQ0KPiA+ID4gPiA+IHRvDQo+ID4gPiA+ ID4gPiA+IGFsc28gZ2VuZXJhdGUgbXB1LGd1ZXN0LW1lbW9yeS1zZWN0aW9uLCB4ZW4sc3RhdGlj LW1lbSwgZXRjLg0KPiBhdA0KPiA+ID4gYnVpbGQNCj4gPiA+ID4gPiA+ID4gdGltZSByYXRoZXIg dGhhbiBwYXNzaW5nIGl0IHZpYSBkZXZpY2UgdHJlZSB0byBYZW4gYXQgcnVudGltZT8NCj4gPiA+ ID4gPiA+ID4NCj4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiBEaWQgeW91IG1lYW4gd2Ugc3RpbGwg YWRkIHRoZXNlIGluZm9ybWF0aW9uIGluIGRldmljZSB0cmVlLCBidXQNCj4gZm9yDQo+ID4gPiA+ ID4gYnVpbGQNCj4gPiA+ID4gPiA+IHRpbWUgb25seS4gSW4gcnVudGltZSB3ZSBkb24ndCBwYXJz ZSB0aGVtPw0KPiA+ID4gPiA+DQo+ID4gPiA+ID4gWWVzLCBzb21ldGhpbmcgbGlrZSB0aGF0LCBi dXQgc2VlIGJlbG93Lg0KPiA+ID4gPiA+DQo+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gV2hhdCdz IHRoZSB2YWx1ZSBvZiBkb2luZyBBUk1fTVBVXypfTUVNT1JZX1NUQVJUL0VORCBhdCBidWlsZA0K PiB0aW1lDQo+ID4gPiBhbmQNCj4gPiA+ID4gPiA+ID4gZXZlcnl0aGluZyBlbHNlIGF0IHJ1bnRp bWU/DQo+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gQVJNX01QVV8qX01FTU9SWV9TVEFSVC9FTkQg aXMgZGVmaW5lZCBieSBwbGF0Zm9ybS4gQnV0IG90aGVyDQo+IHRoaW5ncw0KPiA+ID4gYXJlDQo+ ID4gPiA+ID4gPiB1c2VycyBjdXN0b21pemVkLiBUaGV5IGNhbiBjaGFuZ2UgdGhlaXIgdXNhZ2Ug d2l0aG91dCByZWJ1aWxkDQo+IHRoZQ0KPiA+ID4gaW1hZ2UuDQo+ID4gPiA+ID4NCj4gPiA+ID4g PiBHb29kIHBvaW50Lg0KPiA+ID4gPiA+DQo+ID4gPiA+ID4gV2UgZG9uJ3Qgd2FudCB0byBoYXZl IHRvIHJlYnVpbGQgWGVuIGlmIHRoZSB1c2VyIHVwZGF0ZWQgYSBndWVzdA0KPiA+ID4ga2VybmVs LA0KPiA+ID4gPiA+IHJlc3VsdGluZyBpbiBhIGxhcmdlciBib290LW1vZHVsZS1zZWN0aW9uLg0K PiA+ID4gPiA+DQo+ID4gPiA+ID4gU28gSSB0aGluayBpdCBtYWtlcyBzZW5zZSB0aGF0ICJtcHUs Ym9vdC1tb2R1bGUtc2VjdGlvbiIgaXMNCj4gZ2VuZXJhdGVkDQo+ID4gPiBieQ0KPiA+ID4gPiA+ IHRoZSBzY3JpcHRzIChlLmcuIEltYWdlQnVpbGRlcikgYXQgYnVpbGQgdGltZSwgYW5kIFhlbiBy ZWFkcyB0aGUNCj4gPiA+ID4gPiBwcm9wZXJ0eSBhdCBib290IGZyb20gdGhlIHJ1bnRpbWUgZGV2 aWNlIHRyZWUuDQo+ID4gPiA+ID4NCj4gPiA+ID4gPiBJIHRoaW5rIHdlIG5lZWQgdG8gZGl2aWRl IHRoZSBpbmZvcm1hdGlvbiBpbnRvIHR3byBncm91cHM6DQo+ID4gPiA+ID4NCj4gPiA+ID4gPg0K PiA+ID4gPiA+ICMgR3JvdXAxOiBib2FyZCBpbmZvDQo+ID4gPiA+ID4NCj4gPiA+ID4gPiBUaGlz IGluZm9ybWF0aW9uIGlzIHBsYXRmb3JtIHNwZWNpZmljIGFuZCBpdCBpcyBub3QgbWVhbnQgdG8N Cj4gY2hhbmdlDQo+ID4gPiA+ID4gZGVwZW5kaW5nIG9uIHRoZSBWTSBjb25maWd1cmF0aW9uLiBJ ZGVhbGx5LCB3ZSBidWlsZCBYZW4gZm9yIGENCj4gPiA+IHBsYXRmb3JtDQo+ID4gPiA+ID4gb25j ZSwgdGhlbiB3ZSBjYW4gdXNlIHRoZSBzYW1lIFhlbiBiaW5hcnkgdG9nZXRoZXIgd2l0aCBhbnkN Cj4gPiA+IGNvbWJpbmF0aW9uDQo+ID4gPiA+ID4gb2YgZG9tMC9kb21VIGtlcm5lbHMgYW5kIHJh bWRpc2tzLg0KPiA+ID4gPiA+DQo+ID4gPiA+ID4gVGhpcyBraW5kIG9mIGluZm9ybWF0aW9uIGRv ZXNuJ3QgbmVlZCB0byBiZSBleHBvc2VkIHRvIHRoZSBydW50aW1lDQo+ID4gPiA+ID4gZGV2aWNl IHRyZWUuIEJ1dCB3ZSBjYW4gc3RpbGwgdXNlIGEgYnVpbGQtdGltZSBkZXZpY2UgdHJlZSB0bw0K PiBnZW5lcmF0ZQ0KPiA+ID4gPiA+IHRoZSBhZGRyZXNzZXMgaWYgaXQgaXMgY29udmVuaWVudC4N Cj4gPiA+ID4gPg0KPiA+ID4gPiA+IFhFTl9TVEFSVF9BRERSRVNTLCBBUk1fTVBVX0RFVklDRV9N RU1PUllfKiwgYW5kDQo+ID4gPiBBUk1fTVBVX05PUk1BTF9NRU1PUllfKg0KPiA+ID4gPiA+IHNl ZW0gdG8gYmUgcGFydCBvZiB0aGlzIGdyb3VwLg0KPiA+ID4gPiA+DQo+ID4gPiA+DQo+ID4gPiA+ IFllcy4NCj4gPiA+ID4NCj4gPiA+ID4gPg0KPiA+ID4gPiA+ICMgR3JvdXAyOiBib290IGNvbmZp Z3VyYXRpb24NCj4gPiA+ID4gPg0KPiA+ID4gPiA+IFRoaXMgaW5mb3JtYXRpb24gaXMgYWJvdXQg dGhlIHNwZWNpZmljIHNldCBvZiBiaW5hcmllcyBhbmQgVk1zDQo+IHRoYXQgd2UNCj4gPiA+ID4g PiBuZWVkIHRvIGJvb3QuIEl0IGlzIGNvbmNlcHR1YWxseSBzaW1pbGFyIHRvIHRoZSBkb20wbGVz cyBkZXZpY2UNCj4gdHJlZQ0KPiA+ID4gPiA+IG5vZGVzIHRoYXQgd2UgYWxyZWFkeSBoYXZlLiBJ ZiB3ZSBjaGFuZ2Ugb25lIG9mIHRoZSBWTSBiaW5hcmllcywNCj4gd2UNCj4gPiA+ID4gPiBsaWtl bHkgaGF2ZSB0byByZWZyZXNoIHRoZSBpbmZvcm1hdGlvbiBoZXJlLg0KPiA+ID4gPiA+DQo+ID4g PiA+ID4gIm1wdSxib290LW1vZHVsZS1zZWN0aW9uIiBwcm9iYWJseSBiZWxvbmdzIHRvIHRoaXMg Z3JvdXAgKHVubGVzcw0KPiB3ZQ0KPiA+ID4gZmluZA0KPiA+ID4gPiA+IGEgd2F5IHRvIGRlZmlu ZSAibXB1LGJvb3QtbW9kdWxlLXNlY3Rpb24iIGdlbmVyaWNhbGx5IHNvIHRoYXQgd2UNCj4gZG9u J3QNCj4gPiA+ID4gPiBuZWVkIHRvIGNoYW5nZSBpdCBhbnkgdGltZSB0aGUgc2V0IG9mIGJvb3Qg bW9kdWxlcyBjaGFuZ2UuKQ0KPiA+ID4gPiA+DQo+ID4gPiA+ID4NCj4gPiA+ID4NCj4gPiA+ID4g SSBhZ3JlZS4NCj4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gSXQgbG9va3MgbGlrZSB3ZSBhcmUgZm9y Y2VkIHRvIGhhdmUgdGhlIHNlY3Rpb25zIGRlZmluaXRpb25zDQo+IGF0DQo+ID4gPiBidWlsZA0K PiA+ID4gPiA+ID4gPiB0aW1lIGJlY2F1c2Ugd2UgbmVlZCB0aGVtIGJlZm9yZSB3ZSBjYW4gcGFy c2UgZGV2aWNlIHRyZWUuIEluDQo+IHRoYXQNCj4gPiA+ID4gPiBjYXNlLA0KPiA+ID4gPiA+ID4g PiB3ZSBtaWdodCBhcyB3ZWxsIGRlZmluZSBhbGwgdGhlIHNlY3Rpb25zIGF0IGJ1aWxkIHRpbWUu DQo+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+IEJ1dCBJIHRoaW5rIGl0IHdvdWxkIGJlIGV2 ZW4gYmV0dGVyIGlmIFhlbiBjb3VsZCBhdXRvbWF0aWNhbGx5DQo+ID4gPiBjaG9vc2UNCj4gPiA+ ID4gPiA+ID4geGVuLHN0YXRpYy1tZW0sIG1wdSxndWVzdC1tZW1vcnktc2VjdGlvbiwgZXRjLiBv biBpdHMgb3duDQo+IGJhc2VkIG9uDQo+ID4gPiB0aGUNCj4gPiA+ID4gPiA+ID4gcmVndWxhciBk ZXZpY2UgdHJlZSBpbmZvcm1hdGlvbiAoL21lbW9yeSwgL2FtYmEsIGV0Yy4pLA0KPiB3aXRob3V0 DQo+ID4gPiBhbnkNCj4gPiA+ID4gPiBuZWVkDQo+ID4gPiA+ID4gPiA+IGZvciBleHBsaWNpdGx5 IGRlc2NyaWJpbmcgZWFjaCByYW5nZSB3aXRoIHRoZXNlIG5ldyBwcm9wZXJ0aWVzLg0KPiA+ID4g PiA+ID4gPg0KPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+IGZvciBtcHUsZ3Vlc3QtbWVtb3J5LXNl Y3Rpb24sIHdpdGggdGhlIGxpbWl0YXRpb25zOiBubyBvdGhlcg0KPiB1c2FnZQ0KPiA+ID4gPiA+ IGJldHdlZW4NCj4gPiA+ID4gPiA+IGRpZmZlcmVudCBndWVzdCcgbWVtb3J5IG5vZGVzLCB0aGlz IGlzIE9LLiBCdXQgZm9yIHhlbixzdGF0aWMtDQo+IG1lbQ0KPiA+ID4gKGhlYXApLA0KPiA+ID4g PiA+ID4gd2UganVzdCB3YW50IGV2ZXJ5dGhpbmcgb24gYSBNUFUgc3lzdGVtIGlzIGRlcnRlcm1p c3RpYy4gQnV0LCBvZg0KPiA+ID4gY291cnNlDQo+ID4gPiA+ID4gWGVuDQo+ID4gPiA+ID4gPiBj YW4gc2VsZWN0IGxlZnQgbWVtb3J5IGZvciBoZWFwIHdpdGhvdXQgc3RhdGljLW1lbS4NCj4gPiA+ ID4gPg0KPiA+ID4gPiA+IEl0IGlzIGdvb2QgdGhhdCB5b3UgdGhpbmsgdGhleSBjYW4gYmUgY2hv c2VuIGJ5IFhlbi4NCj4gPiA+ID4gPg0KPiA+ID4gPiA+IERpZmZlcmVudGx5IGZyb20gImJvb3Qt bW9kdWxlLXNlY3Rpb24iLCB3aGljaCBoYXMgdG8gZG8gd2l0aCB0aGUNCj4gYm9vdA0KPiA+ID4g PiA+IG1vZHVsZXMgc2VsZWN0ZWQgYnkgdGhlIHVzZXIgZm9yIGEgc3BlY2lmaWMgZXhlY3V0aW9u LA0KPiA+ID4gPiA+IGd1ZXN0LW1lbW9yeS1zZWN0aW9uIGFuZCBzdGF0aWMtbWVtIGFyZSBYZW4g c3BlY2lmaWMgbWVtb3J5DQo+ID4gPiA+ID4gcG9saWNpZXMvYWxsb2NhdGlvbnMuDQo+ID4gPiA+ ID4NCj4gPiA+ID4gPiBBIHVzZXIgd291bGRuJ3Qga25vdyBob3cgdG8gZmlsbCB0aGVtIGluLiBB bmQgSSB3b3JyeSB0aGF0IGV2ZW4gYQ0KPiA+ID4gc2NyaXB0DQo+ID4gPiA+DQo+ID4gPiA+IEJ1 dCB1c2VycyBzaG91bGQga25vdyBpdCwgYmVjYXVzZSBzdGF0aWMtbWVtIGZvciBndWVzdCBtdXN0 IGJlDQo+IGFsbG9jYXRlZA0KPiA+ID4gPiBpbiB0aGlzIHJhbmdlLiBBbmQgdXNlcnMgdGFrZSB0 aGUgcmVzcG9uc2liaWxpdHkgdG8gc2V0IHRoZSBEb21VJ3MNCj4gPiA+ID4gc3RhdGljIGFsbG9j YXRlIG1lbW9yeSByYW5nZXMuDQo+ID4gPg0KPiA+ID4gTGV0IG1lIHByZW1pc2UgdGhhdCBteSBn b2FsIGlzIHRvIGF2b2lkIGhhdmluZyBtYW55IHVzZXJzIHJlcG9ydGluZw0KPiA+ID4gZXJyb3Jz IHRvIHhlbi1kZXZlbCBhbmQgeGVuLXVzZXJzIHdoZW4gYWN0dWFsbHkgaXQgaXMganVzdCBhIHdy b25nDQo+ID4gPiBjaG9pY2Ugb2YgYWRkcmVzc2VzLg0KPiA+ID4NCj4gPiA+IEkgdGhpbmsgd2Ug bmVlZCB0byBtYWtlIGEgZGlzdGluY3Rpb24gYmV0d2VlbiBhZGRyZXNzZXMgZm9yIHRoZSBib290 DQo+ID4gPiBtb2R1bGVzLCBlLmcuIGFkZHJlc3NlcyB3aGVyZSB0byBsb2FkIHhlbiwgdGhlIGRv bTAvVSBrZXJuZWwsIGRvbTAvVQ0KPiA+ID4gcmFtZGlzayBpbiBtZW1vcnkgYXQgYm9vdCB0aW1l LCBhbmQgVk0gc3RhdGljIG1lbW9yeSBhZGRyZXNzZXMuDQo+ID4gPg0KPiA+ID4gVGhlIGJvb3Qg bW9kdWxlcyBhZGRyZXNzZXMgYXJlIHBhcnRpY3VsYXJseSBkaWZmaWN1bHQgdG8gZmlsbCBpbg0K PiBiZWNhdXNlDQo+ID4gPiB0aGV5IGFyZSBtYW55IGFuZCBhIHNtYWxsIHVwZGF0ZSBpbiBvbmUg b2YgdGhlIG1vZHVsZXMgY291bGQNCj4gaW52YWxpZGF0ZQ0KPiA+ID4gYWxsIHRoZSBvdGhlciBh ZGRyZXNzZXMuIFRoaXMgaXMgd2h5IEkgZW5kZWQgdXAgd3JpdGluZyBJbWFnZUJ1aWxkZXIuDQo+ ID4gPiBTaW5jZSB0aGVtLCBJIHJlY2VpdmVkIHNldmVyYWwgZW1haWxzIGZyb20gdXNlcnMgdGhh bmtpbmcgbWUgZm9yDQo+ID4gPiBJbWFnZUJ1aWxkZXIgOi0pDQo+ID4gPg0KPiA+DQo+ID4gVGhh bmtzICs5OTkg8J+Yig0KPiA+DQo+ID4NCj4gPiA+IFRoZSBzdGF0aWMgVk0gbWVtb3J5IGFkZHJl c3NlcyAoeGVuLHN0YXRpYy1tZW0pIHNob3VsZCBiZSBhIGJpdCBlYXNpZXINCj4gPiA+IHRvIGZp bGwgaW4gY29ycmVjdGx5LiBUaGV5IGFyZSBtZWFudCB0byBiZSBjaG9zZW4gb25jZSwgYW5kIGl0 DQo+IHNob3VsZG4ndA0KPiA+ID4gaGFwcGVuIHRoYXQgYW4gdXBkYXRlIG9uIGEga2VybmVsIGZv cmNlcyB0aGUgdXNlciB0byBjaGFuZ2UgYWxsIHRoZSBWTQ0KPiA+ID4gc3RhdGljIG1lbW9yeSBh ZGRyZXNzZXMuIEFsc28sIEkga25vdyB0aGF0IHNvbWUgdXNlcnMgYWN0dWFsbHkgd2FudCB0bw0K PiA+ID4gYmUgYWJsZSB0byBjaG9vc2UgdGhlIGRvbVUgYWRkcmVzc2VzIGJ5IGhhbmQgYmVjYXVz ZSB0aGV5IGhhdmUNCj4gc3BlY2lmaWMNCj4gPiA+IG5lZWRzLiBTbyBpdCBpcyBnb29kIHRoYXQg d2UgY2FuIGxldCB0aGUgdXNlciBjaG9vc2UgdGhlIGFkZHJlc3NlcyBpZg0KPiA+ID4gdGhleSB3 YW50IHRvLg0KPiA+ID4NCj4gPg0KPiA+IFllcy4NCj4gPg0KPiA+ID4gV2l0aCBhbGwgb2YgdGhh dCBzYWlkLCBJIGRvIHRoaW5rIHRoYXQgbWFueSB1c2VycyB3b24ndCBoYXZlIGFuDQo+IG9waW5p b24NCj4gPiA+IG9uIHRoZSBWTSBzdGF0aWMgbWVtb3J5IGFkZHJlc3NlcyBhbmQgd29uJ3Qga25v dyBob3cgdG8gY2hvb3NlIHRoZW0uDQo+ID4gPiBJdCB3b3VsZCBiZSBlcnJvciBwcm9uZSB0byBs ZXQgdGhlbSB0cnkgdG8gZmlsbCB0aGVtIGluIGJ5IGhhbmQuIFNvIEkNCj4gPiA+IHdhcyBhbHJl YWR5IHBsYW5uaW5nIG9uIGFkZGluZyBzdXBwb3J0IHRvIEltYWdlQnVpbGRlciB0bw0KPiBhdXRv bWF0aWNhbGx5DQo+ID4gPiBnZW5lcmF0ZSB4ZW4sc3RhdGljLW1lbSBmb3IgZG9tMGxlc3MgZG9t YWlucy4NCj4gPiA+DQo+ID4NCj4gPiBMZXQgbWUgbWFrZSBzdXJlIHRoYXQncyB3aGF0IHlvdSBz YWlkOiBVc2VycyBnaXZlIGFuIFZNIG1lbW9yeSBzaXplIHRvDQo+ID4gSW1hZ2VCdWlsZGVyLCBh bmQgSW1hZ2VCdWlsZGVyIHdpbGwgZ2VuZXJhdGUgeGVuLHN0YXRpYy1tZW0gPSA8c3RhcnQsDQo+ IHNpemU+Lg0KPiA+IEZvciBzcGVjaWZpYyBWTSwgSW1hZ2VCdWlsZGVyIGFsc28gY2FuIGFjY2Vw dCBzdGFydCBhbmQgc2l6ZSBhcyBpbnB1dHM/DQo+ID4NCj4gPiBEbyBJIHVuZGVyc3RhbmQgdGhp cyBjb3JyZWN0bHk/DQo+IA0KPiBZZXMsIGV4YWN0bHkNCj4gDQo+IA0KPiA+ID4gR29pbmcgYmFj ayB0byB0aGlzIHNwZWNpZmljIGRpc2N1c3Npb24gYWJvdXQgYm9vdC1tb2R1bGUtc2VjdGlvbjog SQ0KPiBjYW4NCj4gPiA+IHNlZSBub3cgdGhhdCwgZ2l2ZW4geGVuLHN0YXRpYy1tZW0gaXMgY2hv c2VuIGJ5IEltYWdlQnVpbGRlciAob3INCj4gPg0KPiA+IEJ5IGhhbmQgOiApDQo+ID4NCj4gPiA+ IHNpbWlsYXIpIGFuZCBub3QgWGVuLCB0aGVuIGl0IG1ha2VzIHNlbnNlIHRvIGhhdmUgSW1hZ2VC dWlsZGVyIChvcg0KPiA+ID4gc2ltaWxhcikgYWxzbyBnZW5lcmF0ZSBib290LW1vZHVsZS1zZWN0 aW9uLg0KPiA+ID4NCj4gPg0KPiA+IElmIG15IGFib3ZlIHVuZGVyc3RhbmRpbmcgaXMgcmlnaHQs IHRoZW4geWVzLg0KPiANCj4gWWVzLCBJIHRoaW5rIHdlIGFyZSBvbiB0aGUgc2FtZSBwYWdlDQo+ IA0KPiANCj4gPiA+ID4gPiBsaWtlIEltYWdlQnVpbGRlciB3b3VsZG4ndCBiZSB0aGUgYmVzdCBw bGFjZSB0byBwaWNrIHRoZXNlIHZhbHVlcw0KPiAtLQ0KPiA+ID4gPiA+IHRoZXkgc2VlbSB0b28g ImltcG9ydGFudCIgdG8gbGVhdmUgdG8gYSBzY3JpcHQuDQo+ID4gPiA+ID4NCj4gPiA+ID4gPiBC dXQgaXQgc2VlbXMgcG9zc2libGUgdG8gY2hvb3NlIHRoZSB2YWx1ZXMgaW4gWGVuOg0KPiA+ID4g PiA+IC0gWGVuIGtub3dzIEFSTV9NUFVfTk9STUFMX01FTU9SWV8qIGJlY2F1c2UgaXQgd2FzIGRl ZmluZWQgYXQNCj4gYnVpbGQNCj4gPiA+IHRpbWUNCj4gPiA+ID4gPiAtIFhlbiByZWFkcyBib290 LW1vZHVsZS1zZWN0aW9uIGZyb20gZGV2aWNlIHRyZWUNCj4gPiA+ID4gPg0KPiA+ID4gPiA+IEl0 IHNob3VsZCBiZSBwb3NzaWJsZSBhdCB0aGlzIHBvaW50IGZvciBYZW4gdG8gcGljayB0aGUgYmVz dA0KPiB2YWx1ZXMNCj4gPiA+IGZvcg0KPiA+ID4gPiA+IGd1ZXN0LW1lbW9yeS1zZWN0aW9uIGFu ZCBzdGF0aWMtbWVtIGJhc2VkIG9uIHRoZSBtZW1vcnkgYXZhaWxhYmxlLg0KPiA+ID4gPiA+DQo+ ID4gPiA+DQo+ID4gPiA+IEhvdyBYZW4gdG8gcGljaz8gRG9lcyBpdCBtZWFuIGluIHN0YXRpYyBh bGxvY2F0aW9uIERvbVUgRFQgbm9kZSwgd2UNCj4ganVzdA0KPiA+ID4gPiBuZWVkIGEgc2l6ZSwg YnV0IGRvbid0IHJlcXVpcmUgYSBzdGFydCBhZGRyZXNzIGZvciBzdGF0aWMtbWVtPw0KPiA+ID4N Cj4gPiA+IFllcyB0aGUgaWRlYSB3YXMgdGhhdCB0aGUgdXNlciB3b3VsZCBvbmx5IHByb3ZpZGUg dGhlIHNpemUgKGUuZy4NCj4gPiA+IERPTVVfU1RBVElDX01FTVsxXT0xMDI0KSBhbmQgdGhlIGFk ZHJlc3NlcyB3b3VsZCBiZSBhdXRvbWF0aWNhbGx5DQo+ID4gPiBjYWxjdWxhdGVkLiBCdXQgSSBk aWRuJ3QgbWVhbiB0byBjaGFuZ2UgdGhlIGV4aXN0aW5nIHhlbixzdGF0aWMtbWVtDQo+ID4gPiBk ZXZpY2UgdHJlZSBiaW5kaW5ncy4gU28gaXQgaXMgYmVzdCBpZiB0aGUgeGVuLHN0YXRpYy1tZW0g YWRkcmVzc2VzDQo+ID4gPiBnZW5lcmF0aW9uIGlzIGRvbmUgYnkgSW1hZ2VCdWlsZGVyIChvciBz aW1pbGFyIHRvb2wpIGluc3RlYWQgb2YgWGVuLg0KPiA+ID4NCj4gPg0KPiA+IElmIHdlIHN0aWxs IGtlZXAgdGhlIG9wdGlvbiBmb3IgdXNlciB0byBzcGVjaWZ5IHRoZSBzdGFydCBhbmQgc2l6ZQ0K PiA+IHBhcmFtZXRlcnMgZm9yIFZNIG1lbW9yeSwgYmVjYXVzZSBpdCBtYXliZSB2ZXJ5IGltcG9y dGFudCBmb3IgYQ0KPiA+IGRldGVybWluaXN0aWMgc3lzdGVtIChmdWxseSBzdGF0aWMgc3lzdGVt KSwgSSBhZ3JlZSB3aXRoIHlvdS4NCj4gPg0KPiA+IEFuZCBpbiBjdXJyZW50IHN0YXRpYy1hbGxv Y2F0aW9uLCBJIHRoaW5rIFhlbiBkb2Vzbid0IGdlbmVyYXRlDQo+ID4geGVuLHN0YXRpYy1tZW0g YWRkcmVzc2VzLCBhbGwgYnkgaGFuZHMuLi4NCj4gDQo+IFllYWgNCj4gDQo+IA0KDQpJIHdpbGwg dXBkYXRlIG15IHByb3Bvc2FsIHRvIGNvdmVyIG91ciBhYm92ZSBkaXNjdXNzaW9uLCBidXQgSSBm b3Jnb3Qgb25lDQp0aGluZy4gQXMgdGhlIHBsYXRmb3JtIGhlYWRlciBmaWxlcyB3aWxsIGJlIGdl bmVyYXRlZCBmcm9tIERUUywgZG9lcyBpdA0KbWVhbiB3ZSBoYXZlIHRvIG1haW50YWluIHBsYXRm b3JtIGR0cyBmaWxlcyBpbiBYZW4gbGlrZSB3aGF0IFplcGh5ciBoYXMNCmRvbmU/IEFuZCBkbyB5 b3UgaGF2ZSBzb21lIGlkZWEgdG8gaW50ZWdyYXRlIHRoZSAiSW1hZ2VCdWlsZGVyIj8gTWFrZSBp dA0KYXMgYSBzdWJtb2R1bGUgb2YgWGVuIG9yIGludGVncmF0ZSB0byB4ZW4tdG9vbHM/DQoNCg0K PiA+ID4gU29ycnkgZm9yIHRoZSBjb25mdXNpb24hDQo+ID4gPg0KPiA+DQo+ID4gTlAgOyApDQo= From xen-devel-bounces@lists.xenproject.org Thu Mar 03 01:25:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Mar 2022 01:25:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282655.481443 (Exim 4.92) (envelope-from ) id 1nPaDX-00076b-Ls; Thu, 03 Mar 2022 01:25:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282655.481443; Thu, 03 Mar 2022 01:25:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPaDX-00076U-If; Thu, 03 Mar 2022 01:25:19 +0000 Received: by outflank-mailman (input) for mailman id 282655; Thu, 03 Mar 2022 01:25:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPaDV-00076O-Pv for xen-devel@lists.xenproject.org; Thu, 03 Mar 2022 01:25:17 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c6fbc765-9a90-11ec-8539-5f4723681683; Thu, 03 Mar 2022 02:25:14 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7F309B82358; Thu, 3 Mar 2022 01:25:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2074AC340F2; Thu, 3 Mar 2022 01:25:11 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c6fbc765-9a90-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646270712; bh=OIWkR7Zp9BS5KcWgPGvH+7lGxsauASKPDzT5dWHRzcg=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=fyTcnY079RGVSWj1/bqnWf9UBPrXZmiZ32cJHGCuHKFrvhhlGSoeO8XnjyAULGbxy xuEeYIRqhVQfty7l070VwdiiUBm+vhQMOyp1/UPCRCwJW1H8chwVFdTWSqF8JxQ7i6 pmngu4i/qw99iSRs7nF8V/KUQPfZMnX0OhdBfoyB3K0uXmVGkSCue1VhFC37hRyoHl lqT9JrJPLf0sbQoGpagSmC+bBJdDfAOOQZXY1qQ2kFojarLkPJJigndyp3UGVx/CEp 1XnqlJ8dDyOAxVpGwUR+l8DwgqcaHVrJmCy/f+O96VijhpAG5o/2FbsTqBKQIZTLrT qEo+TADXZ7B8A== Date: Wed, 2 Mar 2022 17:25:10 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Christoph Hellwig cc: Stefano Stabellini , iommu@lists.linux-foundation.org, x86@kernel.org, Anshuman Khandual , Tom Lendacky , Konrad Rzeszutek Wilk , Boris Ostrovsky , Juergen Gross , Joerg Roedel , David Woodhouse , Lu Baolu , Robin Murphy , linux-arm-kernel@lists.infradead.org, xen-devel@lists.xenproject.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-hyperv@vger.kernel.org, tboot-devel@lists.sourceforge.net, linux-pci@vger.kernel.org Subject: Re: [PATCH 11/12] swiotlb: merge swiotlb-xen initialization into swiotlb In-Reply-To: <20220302081500.GB23075@lst.de> Message-ID: References: <20220301105311.885699-1-hch@lst.de> <20220301105311.885699-12-hch@lst.de> <20220302081500.GB23075@lst.de> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 2 Mar 2022, Christoph Hellwig wrote: > On Tue, Mar 01, 2022 at 06:55:47PM -0800, Stefano Stabellini wrote: > > Unrelated to this specific patch series: now that I think about it, if > > io_tlb_default_mem.nslabs is already allocated by the time xen_mm_init > > is called, wouldn't we potentially have an issue with the GFP flags used > > for the earlier allocation (e.g. GFP_DMA32 not used)? Maybe something > > for another day. > > swiotlb_init allocates low memory from meblock, which is roughly > equivalent to GFP_DMA allocations, so we'll be fine. > > > > @@ -143,10 +141,15 @@ static int __init xen_mm_init(void) > > > if (!xen_swiotlb_detect()) > > > return 0; > > > > > > - rc = xen_swiotlb_init(); > > > /* we can work with the default swiotlb */ > > > - if (rc < 0 && rc != -EEXIST) > > > - return rc; > > > + if (!io_tlb_default_mem.nslabs) { > > > + if (!xen_initial_domain()) > > > + return -EINVAL; > > > > I don't think we need this xen_initial_domain() check. It is all > > already sorted out by the xen_swiotlb_detect() check above. > > Is it? > > static inline int xen_swiotlb_detect(void) > { > if (!xen_domain()) > return 0; > if (xen_feature(XENFEAT_direct_mapped)) > return 1; > /* legacy case */ > if (!xen_feature(XENFEAT_not_direct_mapped) && xen_initial_domain()) > return 1; > return 0; > } It used to be that we had a if (!xen_initial_domain()) return -EINVAL; check in the initialization of swiotlb-xen on ARM. Then we replaced it with the more sophisticated xen_swiotlb_detect(). The reason is that swiotlb-xen on ARM relies on Dom0 being 1:1 mapped (guest physical addresses == physical addresses). Recent changes in Xen allowed also DomUs to be 1:1 mapped. Changes still under discussion will allow Dom0 not to be 1:1 mapped. So, before all the Xen-side changes, knowing what was going to happen, I introduced a clearer interface: XENFEAT_direct_mapped and XENFEAT_not_direct_mapped tell us whether the guest (Linux) is 1:1 mapped or not. If it is 1:1 mapped then Linux can take advantage of swiotlb-xen. Now xen_swiotlb_detect() returns true if Linux is 1:1 mapped. Then of course there is the legacy case. That's taken care of by: if (!xen_feature(XENFEAT_not_direct_mapped) && xen_initial_domain()) return 1; The intention is to say that if XENFEAT_direct_mapped/XENFEAT_not_direct_mapped are not present, then use xen_initial_domain() like we did before. So if xen_swiotlb_detect() returns true we know that Linux is either dom0 (xen_initial_domain() == true) or we have very good reasons to think we should initialize swiotlb-xen anyway (xen_feature(XENFEAT_direct_mapped) == true). > I think I'd keep it as-is for now, as my planned next step would be to > fold xen-swiotlb into swiotlb entirely. Thinking more about it we actually need to drop the xen_initial_domain() check otherwise some cases won't be functional (Dom0 not 1:1 mapped, or DomU 1:1 mapped). From xen-devel-bounces@lists.xenproject.org Thu Mar 03 01:36:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Mar 2022 01:36:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282664.481455 (Exim 4.92) (envelope-from ) id 1nPaO4-0000dm-UG; Thu, 03 Mar 2022 01:36:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282664.481455; Thu, 03 Mar 2022 01:36:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPaO4-0000d9-NV; Thu, 03 Mar 2022 01:36:12 +0000 Received: by outflank-mailman (input) for mailman id 282664; Thu, 03 Mar 2022 01:36:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPaO3-0000XN-A2 for xen-devel@lists.xenproject.org; Thu, 03 Mar 2022 01:36:11 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on062d.outbound.protection.outlook.com [2a01:111:f400:fe0c::62d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 49475f57-9a92-11ec-8eba-a37418f5ba1a; Thu, 03 Mar 2022 02:36:02 +0100 (CET) Received: from DB6PR0802CA0035.eurprd08.prod.outlook.com (2603:10a6:4:a3::21) by VI1PR0802MB2221.eurprd08.prod.outlook.com (2603:10a6:800:9a::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.25; Thu, 3 Mar 2022 01:36:00 +0000 Received: from DB5EUR03FT029.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:a3:cafe::5c) by DB6PR0802CA0035.outlook.office365.com (2603:10a6:4:a3::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4823.21 via Frontend Transport; Thu, 3 Mar 2022 01:36:00 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT029.mail.protection.outlook.com (10.152.20.131) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22 via Frontend Transport; Thu, 3 Mar 2022 01:35:59 +0000 Received: ("Tessian outbound 63bb5eb69ee8:v113"); Thu, 03 Mar 2022 01:35:59 +0000 Received: from 0ab8b9c61e81.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 74C92DCE-74BC-408E-8456-B35EB1F17433.1; Thu, 03 Mar 2022 01:35:54 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0ab8b9c61e81.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 03 Mar 2022 01:35:54 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by AM6PR08MB3575.eurprd08.prod.outlook.com (2603:10a6:20b:48::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.13; Thu, 3 Mar 2022 01:35:51 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::89b3:80a2:2b58:f1aa]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::89b3:80a2:2b58:f1aa%4]) with mapi id 15.20.5038.014; Thu, 3 Mar 2022 01:35:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 49475f57-9a92-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RcsEOKu715kcgR7lt6oNR1CEjCILmSXWRmq1U6wvokQ=; b=vUDphmIicYpI3lDYXdJSJ+fgsCuN9wpuLldTt4RP3IIUcT5k+3CAUmFaJYtnDfdj0mJfAgyw4eaiuN0N4Ue+gZRBj8hIBOZs5uG62OS7sza9iehY7/IID6dhjEEBnO5HNyo+O41p7ps2pThLzQJaa9R/9bnL1neS5JcfPA+6OL4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SfjgsUR573a7ReE5gDJI5M84e4hQsotJL407fSh/54LmM1GCtW0aIxQ9dsMkwRfepDCs5fzt0DxUPwLNQjRJ6egIMtPlHVF4SjW9bM8AMLTVRgJM1Vr58LmLpp12/+0kEYI0xd4zIefe431xUcfvE6/V0dkw6te6Y9ySdWSxmesEb76j5xBZF2ScQ1223LNHeuAgV0pqGhfn8SQnuLNnUnqJRZZaTnq4Q/9JZQaVDh3y2/rMP987Uhks7rp3cXxx4yfC0Oz9qEEeR6LmTPUKgPfnIlquUPFh+cjCdpvNGDfbkHBPBsckLk81QoQC1oIpup7a2TGofwGoTjasTgK8yQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RcsEOKu715kcgR7lt6oNR1CEjCILmSXWRmq1U6wvokQ=; b=bFc0FcRj885C8ktvpZFb2KcVS57dAq3qFhuk2cCWcQpsyQriNyTEltnle0m23YThuj50PzTBrXWrbMYVCELep8ty4t5+HBy6FZsV3UinDnghIhLna0USPcaUNnbgubKO6NFIsHZqO9F/TrVD/BAeEcFkC41psltMHLZhZbs0q6QWcV6HIklqG00NM7iO3H8mcZGcGdrvBMrGxKUFgNy9ZTIg3hGrdtuv0b/k4PDUZ8W8d3lTKsDU9jYZ/R9m1W9JDH0iD2Zk7EXngflT2UJ8IrZrPuANJGxCjzSsF36ztsCPx/3j8WxC71StTZ9xUcBVk9SZRIaCG8rNPRYfy0FH5A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RcsEOKu715kcgR7lt6oNR1CEjCILmSXWRmq1U6wvokQ=; b=vUDphmIicYpI3lDYXdJSJ+fgsCuN9wpuLldTt4RP3IIUcT5k+3CAUmFaJYtnDfdj0mJfAgyw4eaiuN0N4Ue+gZRBj8hIBOZs5uG62OS7sza9iehY7/IID6dhjEEBnO5HNyo+O41p7ps2pThLzQJaa9R/9bnL1neS5JcfPA+6OL4= From: Wei Chen To: Julien Grall , Stefano Stabellini CC: "xen-devel@lists.xenproject.org" , Bertrand Marquis , Penny Zheng , Henry Wang , nd Subject: RE: Proposal for Porting Xen to Armv8-R64 - DraftA Thread-Topic: Proposal for Porting Xen to Armv8-R64 - DraftA Thread-Index: AdgpQxtXwh7LkfydTgiYk9bhMgU+ogAn0mUAABEK2UAAF1ylAACsO9YwAA5uZgAAI3g7sAAIzZgAAB9QTKA= Date: Thu, 3 Mar 2022 01:35:50 +0000 Message-ID: References: <4c558f8f-56d4-0445-32d4-169bc5d0a3bc@xen.org> <7260f050-9022-4adf-618b-a8b271aca8c3@xen.org> <5eb5fe51-9ef7-affe-06e1-b15da512a76c@xen.org> In-Reply-To: <5eb5fe51-9ef7-affe-06e1-b15da512a76c@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 6E58D46329831C48A482985C7259F316.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 0f9ad8ba-9e7a-4af1-57a4-08d9fcb62bcb x-ms-traffictypediagnostic: AM6PR08MB3575:EE_|DB5EUR03FT029:EE_|VI1PR0802MB2221:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: z8SWODiUvI4dvyEPcsUn3RU8L3R9zSYpt9zqRVFQ1U2EXocSJaiHwRk1x3VfIJ0Smo43o5fqHz28VxeE2aIt1vDyxxj1eGRG1Utd9G188cG4xnYT6uc+Z1x4b04/fNSRuodqEL176TP2Ceu1lJqK73ypMmmjBNnFfphN+xVrAWG0bM/Ypkhy6y9yXO6zf/H6LI/Gx21z/ulqZLYcbaq5ROrgx78jV6HLCuRtplQGT2JNcLQX53+JY9lLzwB+rfhSZW7me3SUWOC3QtwAcAA6dFgOARmB+DrI8aC4RIbOpHFLYWwWMGZjZTPt0QvrjSD9s0BBJia7oTX7Fm0vBFRXbWQbos0aS/V/2VymEGezrWZpEIjIBGNKwGERR7ln4ePSX0CMCn7aax19L8ut6LapV1yEWj8Pn27liCa9EEQfOyS507kRm5iSNelUsIxKjgI5DCknpDHTyVEj4OP6KkkmUaOYdevOF3KOUpMf4OBTwqYououpE6qCFLSB4s/mNsJ9M2m6CxCru3pMHRFwUbR4fs1lrnOohw6dZME4WOYCmo0EmFI4bv3QjXsL2zJNyoMZ/DZ8WOT4FS53jPrwsNCN49bco70wLA/hKQOwvhQ/ROmfa9jeJ1qjrR/SQV4KjWT5EhbhLSia6qyVqxH9o3TL26lSzr7FkB6wSO6doebbjmsp3KpL/vIJMbfwZsVk/jMAzeU/HaXGNMVFIfpgOPcwww== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6506007)(38100700002)(5660300002)(86362001)(9686003)(2906002)(7696005)(122000001)(53546011)(83380400001)(186003)(33656002)(54906003)(26005)(55016003)(110136005)(8936002)(316002)(71200400001)(64756008)(4326008)(8676002)(52536014)(66446008)(66476007)(66556008)(508600001)(76116006)(66946007)(38070700005);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3575 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT029.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 565a5345-eb47-46c5-6365-08d9fcb62668 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qweVjo0zDOyxn+Lt6kWGbfgsV5vfmoWmhGvUzccAmhy1+0W+I7EU81+Yu+8ClA8NXTlgz+bpIYwhZMIIgcyp8UQIRunRiLsL8KZhOAhTg6JJKbF3pPTik3LU30JoS125qBd8WaZqV0SkbbypoUWFl1+f7SNCzMmZ/gx4aaAogwB0H9qWo0KNZUIGv4XsRvIVQjDoZQ1YITnAO0YTzftF9NX/Z8xBQ/DWqq99dKFr0IMP57fEKd+NDf4KTYVUHoLr48Qi/YBZ8p0eSraWh0CLNW37Zn3A4rvnFfxc5IMgDM/2WdYT+eggi1TATwicnCm+cKnk69zAVy5rLJ6tUodMyWqIxRDMsrmTBTFvesSfMRPyhKycOltZglKUVcjiggomgWr3GWRyKCQyLNBlct7uVekwKCgdfKuSS3bQmZ1jjd6PDOvH4omnjJlv1gQj+RQ2SXnom7Y6R2nTAnWN5n9xxdzlEcg8MNWrym5XUc5AuCN57FHCyrUj1WMZSS2SIswS1Te482rLHWats5Ke5tXzr/GiaCSeR9WWMozP0+QeyFE+weJn89BRNiAy954TAv3R1pqMeMoOnqPF0YKrpBO4i6jdUYRhECRbzptLWZiC3M2KrSPxQxMKFhT6tWu8wGILWVsQAy3NVfoWJVU29tPNizSApwZaQpNFkXXA7xrn6aBsr50zaa46k9Ozn9EIkIbf X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(70586007)(70206006)(316002)(81166007)(55016003)(36860700001)(2906002)(47076005)(8676002)(4326008)(40460700003)(82310400004)(52536014)(8936002)(33656002)(186003)(508600001)(336012)(53546011)(26005)(356005)(5660300002)(6506007)(7696005)(86362001)(9686003)(83380400001)(110136005)(54906003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2022 01:35:59.8473 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0f9ad8ba-9e7a-4af1-57a4-08d9fcb62bcb X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT029.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2221 SGkgSnVsaWVuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEp1bGll biBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+IFNlbnQ6IDIwMjLlubQz5pyIMuaXpSAxODoyNQ0K PiBUbzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+OyBTdGVmYW5vIFN0YWJlbGxpbmkNCj4g PHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+DQo+IENjOiB4ZW4tZGV2ZWxAbGlzdHMueGVucHJvamVj dC5vcmc7IEJlcnRyYW5kIE1hcnF1aXMNCj4gPEJlcnRyYW5kLk1hcnF1aXNAYXJtLmNvbT47IFBl bm55IFpoZW5nIDxQZW5ueS5aaGVuZ0Bhcm0uY29tPjsgSGVucnkgV2FuZw0KPiA8SGVucnkuV2Fu Z0Bhcm0uY29tPjsgbmQgPG5kQGFybS5jb20+DQo+IFN1YmplY3Q6IFJlOiBQcm9wb3NhbCBmb3Ig UG9ydGluZyBYZW4gdG8gQXJtdjgtUjY0IC0gRHJhZnRBDQo+IA0KPiBIaSBXZWksDQo+IA0KPiBP biAwMi8wMy8yMDIyIDA2OjQzLCBXZWkgQ2hlbiB3cm90ZToNCj4gPj4gLS0tLS1PcmlnaW5hbCBN ZXNzYWdlLS0tLS0NCj4gPj4gRnJvbTogSnVsaWVuIEdyYWxsIDxqdWxpZW5AeGVuLm9yZz4NCj4g Pj4gU2VudDogMjAyMuW5tDPmnIgx5pelIDIxOjE3DQo+ID4+IFRvOiBXZWkgQ2hlbiA8V2VpLkNo ZW5AYXJtLmNvbT47IFN0ZWZhbm8gU3RhYmVsbGluaQ0KPiA+PiA8c3N0YWJlbGxpbmlAa2VybmVs Lm9yZz4NCj4gPj4gQ2M6IHhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZzsgQmVydHJhbmQg TWFycXVpcw0KPiA+PiA8QmVydHJhbmQuTWFycXVpc0Bhcm0uY29tPjsgUGVubnkgWmhlbmcgPFBl bm55LlpoZW5nQGFybS5jb20+OyBIZW5yeQ0KPiBXYW5nDQo+ID4+IDxIZW5yeS5XYW5nQGFybS5j b20+OyBuZCA8bmRAYXJtLmNvbT4NCj4gPj4gU3ViamVjdDogUmU6IFByb3Bvc2FsIGZvciBQb3J0 aW5nIFhlbiB0byBBcm12OC1SNjQgLSBEcmFmdEENCj4gPj4NCj4gPj4gT24gMDEvMDMvMjAyMiAw NjoyOSwgV2VpIENoZW4gd3JvdGU6DQo+ID4+PiBIaSBKdWxpZW4sDQo+ID4+DQo+ID4+IEhpLA0K PiA+Pg0KPiA+Pj4+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+ID4+Pj4gRnJvbTogSnVs aWVuIEdyYWxsIDxqdWxpZW5AeGVuLm9yZz4NCj4gPj4+PiBTZW50OiAyMDIy5bm0MuaciDI25pel IDQ6MTINCj4gPj4+PiBUbzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+OyBTdGVmYW5vIFN0 YWJlbGxpbmkNCj4gPj4+PiA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz4NCj4gPj4+PiBDYzogeGVu LWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnOyBCZXJ0cmFuZCBNYXJxdWlzDQo+ID4+Pj4gPEJl cnRyYW5kLk1hcnF1aXNAYXJtLmNvbT47IFBlbm55IFpoZW5nIDxQZW5ueS5aaGVuZ0Bhcm0uY29t PjsgSGVucnkNCj4gPj4gV2FuZw0KPiA+Pj4+IDxIZW5yeS5XYW5nQGFybS5jb20+OyBuZCA8bmRA YXJtLmNvbT4NCj4gPj4+PiBTdWJqZWN0OiBSZTogUHJvcG9zYWwgZm9yIFBvcnRpbmcgWGVuIHRv IEFybXY4LVI2NCAtIERyYWZ0QQ0KPiA+Pj4+DQo+ID4+Pj4gSGkgV2VpLA0KPiA+Pj4+DQo+ID4+ Pj4gT24gMjUvMDIvMjAyMiAxMDo0OCwgV2VpIENoZW4gd3JvdGU6DQo+ID4+Pj4+Pj4gICDCoMKg wqDCoCBBcm12OC1SNjQgY2FuIHN1cHBvcnQgbWF4IHRvIDI1NiBNUFUgcmVnaW9ucy4gQnV0IHRo YXQncw0KPiBqdXN0DQo+ID4+Pj4+PiB0aGVvcmV0aWNhbC4NCj4gPj4+Pj4+PiAgIMKgwqDCoMKg IFNvIHdlIGRvbid0IHdhbnQgdG8gZGVmaW5lIGBwcl90IG1wdV9yZWdpb25zWzI1Nl1gLCB0aGlz IGlzDQo+IGENCj4gPj4+PiBtZW1vcnkNCj4gPj4+Pj4+IHdhc3RlDQo+ID4+Pj4+Pj4gICDCoMKg wqDCoCBpbiBtb3N0IG9mIHRpbWUuIFNvIHdlIGRlY2lkZWQgdG8gbGV0IHRoZSB1c2VyIHNwZWNp ZnkNCj4gdGhyb3VnaA0KPiA+PiBhDQo+ID4+Pj4+PiBLY29uZmlnDQo+ID4+Pj4+Pj4gICDCoMKg wqDCoCBvcHRpb24uIGBDT05GSUdfQVJNX01QVV9FTDFfUFJPVEVDVElPTl9SRUdJT05TYCBkZWZh dWx0DQo+IHZhbHVlDQo+ID4+IGNhbg0KPiA+Pj4+IGJlDQo+ID4+Pj4+PiBgMzJgLA0KPiA+Pj4+ Pj4+ICAgwqDCoMKgwqAgaXQncyBhIHR5cGljYWwgaW1wbGVtZW50YXRpb24gb24gQXJtdjgtUjY0 LiBVc2VycyB3aWxsDQo+ID4+IHJlY29tcGlsZQ0KPiA+Pj4+IFhlbg0KPiA+Pj4+Pj4gd2hlbg0K PiA+Pj4+Pj4+ICAgwqDCoMKgwqAgdGhlaXIgcGxhdGZvcm0gY2hhbmdlcy4gU28gd2hlbiB0aGUg TVBVIGNoYW5nZXMsDQo+IHJlc3BlY2lmeWluZw0KPiA+PiB0aGUNCj4gPj4+Pj4+IE1QVQ0KPiA+ Pj4+Pj4+ICAgwqDCoMKgwqAgcHJvdGVjdGlvbiByZWdpb25zIG51bWJlciB3aWxsIG5vdCBjYXVz ZSBhZGRpdGlvbmFsDQo+IHByb2JsZW1zLg0KPiA+Pj4+Pj4NCj4gPj4+Pj4+IEkgd29uZGVyIGlm IHdlIGNvdWxkIHByb2JlIHRoZSBudW1iZXIgb2YgTVBVIHJlZ2lvbnMgYXQgcnVudGltZSBhbmQN Cj4gPj4+Pj4+IGR5bmFtaWNhbGx5IGFsbG9jYXRlIHRoZSBtZW1vcnkgbmVlZGVkIHRvIHN0b3Jl IHRoZW0gaW4gYXJjaF92Y3B1Lg0KPiA+Pj4+Pj4NCj4gPj4+Pj4NCj4gPj4+Pj4gV2UgaGF2ZSBj b25zaWRlcmVkIHRvIHVzZWQgYSBwcl90IG1wdV9yZWdpb25zWzBdIGluIGFyY2hfdmNwdS4gQnV0 DQo+IGl0DQo+ID4+Pj4gc2VlbXMNCj4gPj4+Pj4gd2Ugd2lsbCBlbmNvdW50ZXIgc29tZSBzdGF0 aWMgYWxsb2NhdGVkIGFyY2hfdmNwdSBwcm9ibGVtcyBhbmQNCj4gc2l6ZW9mDQo+ID4+Pj4gaXNz dWUuDQo+ID4+Pj4NCj4gPj4+PiBEb2VzIGl0IG5lZWQgdG8gYmUgZW1iZWRkZWQgaW4gYXJjaF92 Y3B1PyBJZiBub3QsIHRoZW4gd2UgY291bGQNCj4gPj4gYWxsb2NhdGUNCj4gPj4+PiBtZW1vcnkg b3V0c2lkZSBhbmQgYWRkIGEgcG9pbnRlciBpbiBhcmNoX3ZjcHUuDQo+ID4+Pj4NCj4gPj4+DQo+ ID4+PiBXZSBoYWQgdGhvdWdodCB0byB1c2UgYSBwb2ludGVyIGluIGFyY2hfdmNwdSBpbnN0ZWFk IG9mIGVtYmVkZGluZw0KPiA+PiBtcHVfcmVnaW9ucw0KPiA+Pj4gaW50byBhcmNoX3ZjcHUuIEJ1 dCB3ZSBub3RpY2VkIHRoYXQgYXJjaF92Y3B1IGhhcyBhDQo+IF9fY2FjaGVsaW5lX2FsaWduZWQN Cj4gPj4+IGF0dHJpYnV0ZSwgdGhpcyBtYXkgYmUgYmVjYXVzZSBvZiBhcmNoX3ZjcHUgd2lsbCBi ZSB1c2VkIHZlcnkNCj4gZnJlcXVlbnRseQ0KPiA+Pj4gaW4gc29tZSBjcml0aWNhbCBwYXRoLiBT byBpZiB3ZSB1c2UgdGhlIHBvaW50ZXIgZm9yIG1wdV9yZWdpb25zLCBtYXkNCj4gPj4gY2F1c2UN Cj4gPj4+IHNvbWUgY2FjaGUgbWlzcyBpbiB0aGVzZSBjcml0aWNhbCBwYXRoLCBmb3IgZXhhbXBs ZSwgaW4gY29udGV4dF9zd3RpY2guDQo+ID4+DQo+ID4+ICAgRnJvbSBteSB1bmRlcnN0YW5kaW5n LCB0aGUgaWRlYSBiZWhpbmQgYGBjYWNoZWxpbmVfYWxpZ25lZGBgIGlzIHRvDQo+ID4+IGF2b2lk IHRoZSBzdHJ1Y3QgdmNwdSB0byBiZSBzaGFyZWQgd2l0aCBvdGhlciBkYXRhc3RydWN0dXJlLiBP dGhlcndpc2UNCj4gPj4geW91IG1heSBlbmQgdXAgdG8gaGF2ZSB0d28gcENQVXMgdG8gZnJlcXVl bnRseSB3cml0ZSB0aGUgc2FtZSBjYWNoZWxpbmUNCj4gPj4gd2hpY2ggaXMgbm90IGlkZWFsLg0K PiA+Pg0KPiA+PiBhcmNoX3ZjcHUgc2hvdWxkIGVtYmJlZCBhbnl0aGluZyB0aGF0IHdpbGwgYmUg YWNjZXNzZWQgb2Z0ZW4gKGUuZy4NCj4gPj4gZW50cnkvZXhpdCkgdG8gY2VydGFpbiBwb2ludC4g Rm9yIGluc3RhbmNlLCBub3QgZXZlcnl0aGluZyByZWxhdGVkIHRvDQo+ID4+IHRoZSB2R0lDIGFy ZSBlbWJiZWQgaW4gdGhlIHZDUFUvRG9tYWluIHN0cnVjdHVyZS4NCj4gPj4NCj4gPj4gSSBhbSBh IGJpdCBzcGxpdCByZWdhcmRpbmcgdGhlIG1wdV9yZWdpb25zLiBJZiB0aGV5IGFyZSBtYWlubHkg dXNlZCBpbg0KPiA+PiB0aGUgY29udGV4dF9zd2l0Y2goKSB0aGVuIEkgd291bGQgYXJndWUgdGhp cyBpcyBhIHByZW1hdHVyZQ0KPiBvcHRpbWl6YXRpb24NCj4gPj4gYmVjYXVzZSB0aGUgc2NoZWR1 bGluZyBkZWNpc2lvbiBpcyBwcm9iYWJseSBnb2luZyB0byB0YWtlIGEgbG90IG1vcmUNCj4gPj4g dGltZSB0aGFuIHRoZSBjb250ZXh0IHN3aXRjaCBpdHNlbGYuDQo+ID4NCj4gPiBtcHVfcmVnaW9u cyBpbiBhcmNoX3ZjcHUgYXJlIHVzZWQgdG8gc2F2ZSBndWVzdCdzIEVMMSBNUFUgY29udGV4dC4g U28sDQo+IHllcywNCj4gPiB0aGV5IGFyZSBtYWlubHkgdXNlZCBpbiBjb250ZXh0X3N3aXRjaC4g SW4gdGVybXMgb2YgdGhlIG51bWJlciBvZg0KPiByZWdpc3RlcnMsDQo+ID4gaXQgd2lsbCBzYXZl L3Jlc3RvcmUgbW9yZSB3b3JrIHRoYW4gdGhlIG9yaWdpbmFsIFY4QS4gQW5kIG9uIFY4UiB3ZSBh bHNvDQo+IG5lZWQNCj4gPiB0byBrZWVwIG1vc3Qgb2YgdGhlIG9yaWdpbmFsIFY4QSBzYXZlL3Jl c3RvcmUgd29yay4gU28gaXQgd2lsbCB0YWtlDQo+IGxvbmdlcg0KPiA+IHRoYW4gdGhlIG9yaWdp bmFsIFY4QSBjb250ZXh0X3N3aXRjaC4gQW5kIEkgdGhpbmsgdGhpcyBpcyBkdWUgdG8NCj4gYXJj aGl0ZWN0dXJlJ3MNCj4gPiBkaWZmZXJlbmNlLiBTbyBpdCdzIGltcG9zc2libGUgZm9yIHVzIG5v dCB0byBzYXZlL3Jlc3RvcmUgRUwxIE1QVSByZWdpb24NCj4gPiByZWdpc3RlcnMgaW4gY29udGV4 dF9zd2l0Y2guIEFuZCB3ZSBoYXZlIGRvbmUgc29tZSBvcHRpbWl6YXRpb24gZm9yIEVMMQ0KPiBN UFUNCj4gPiBzYXZlL3Jlc3RvcmU6DQo+ID4gMS4gQXNzZW1ibHkgY29kZSBmb3IgRUwxIE1QVSBj b250ZXh0X3N3aXRjaA0KPiANCj4gVGhpcyBkaXNjdXNzaW9uIHJlbWluZHMgbWUgd2hlbiBLVk0g ZGVjaWRlZCB0byByZXdyaXRlIHRoZWlyIGNvbnRleHQNCj4gc3dpdGNoIGZyb20gYXNzZW1ibHkg dG8gQy4gVGhlIG91dGNvbWUgd2FzIHRoZSBjb21waWxlciBpcyBhYmxlIHRvIGRvIGENCj4gYmV0 dGVyIGpvYiB0aGFuIHVzIHdoZW4gaXQgY29tZXMgdG8gb3B0aW1pemluZy4NCj4gDQo+IFdpdGgg YSBDIHZlcnNpb24sIHdlIGNvdWxkIGFsc28gc2hhcmUgdGhlIHNhdmUvcmVzdG9yZSBjb2RlIHdp dGggMzItYml0DQo+IGFuZCBpdCBpcyBlYXNpZXIgdG8gcmVhZC9tYWludGFpbi4NCj4gDQo+IFNv IEkgd291bGQgc3VnZ2VzdCB0byBydW4gc29tZSBudW1iZXJzIHRvIGNoZWNrIGlmIGl0IHJlYWxs eSB3b3J0aA0KPiBpbXBsZW1lbnRpbmcgdGhlIE1QVSBzYXZlL3Jlc3RvcmUgaW4gYXNzZW1ibHku DQo+IA0KDQpJdCdzIGludGVyZXN0aW5nIHRvIGhlYXIgS1ZNIGd1eXMgaGF2ZSBzaW1pbGFyIGRp c2N1c3Npb24uIFllcywgaWYgdGhlDQpnYWlucyBvZiBhc3NlbWJseSBjb2RlIGlzIG5vdCB2ZXJ5 IG9idmlvdXMsIHRoZW4gcmV1c2luZyB0aGUgY29kZSBmb3IgMzItYml0DQp3b3VsZCBiZSBtb3Jl IGltcG9ydGFudC4gQXMgb3VyIGN1cnJlbnQgcGxhdGZvcm0gKEZWUCkgY291bGQgbm90IGRvIHZl cnkNCnByZWNpc2UgcGVyZm9ybWFuY2UgbWVhc3VyZW1lbnQuIEkgd2FudCB0byBrZWVwIGN1cnJl bnQgYXNzZW1ibHkgY29kZSB0aGVyZSwNCndoZW4gd2UgaGF2ZSBhIHBsYXRmb3JtIHRoYXQgY2Fu IGRvIHN1Y2ggbWVhc3VyZW1lbnQgd2UgY2FuIGhhdmUgYSB0aHJlYWQNCnRvIGRpc2N1c3MgaXQu DQoNCj4gPiAyLiBVc2UgcmVhbCBNUFUgcmVnaW9ucyBudW1iZXIgaW5zdGVhZCBvZg0KPiBDT05G SUdfQVJNX01QVV9FTDFfUFJPVEVDVElPTl9SRUdJT05TDQo+ID4gICAgIGluIGNvbnRleHRfc3dp dGNoLiBDT05GSUdfQVJNX01QVV9FTDFfUFJPVEVDVElPTl9SRUdJT05TIGlzIGRlZmluZWQNCj4g dGhlIE1heA0KPiA+ICAgICBzdXBwb3J0ZWQgRUwxIE1QVSByZWdpb25zIGZvciB0aGlzIFhlbiBp bWFnZS4gQWxsIHBsYXRmb3JtcyB0aGF0DQo+IGltcGxlbWVudA0KPiA+ICAgICBFTDEgTVBVIHJl Z2lvbnMgaW4gdGhpcyByYW5nZSBjYW4gd29yayB3ZWxsIHdpdGggdGhpcyBYZW4gSW1hZ2UuIEJ1 dA0KPiBpZiB0aGUNCj4gPiAgICAgaW1wbGVtZW50ZWQgRUwxIE1QVSByZWdpb24gbnVtYmVyIGV4 Y2VlZHMNCj4gQ09ORklHX0FSTV9NUFVfRUwxX1BST1RFQ1RJT05fUkVHSU9OUywNCj4gPiAgICAg dGhpcyBYZW4gaW1hZ2UgY291bGQgbm90IHdvcmsgd2VsbCBvbiB0aGlzIHBsYXRmb3JtLg0KPiAN Cj4gVGhpcyBzb3VuZHMgc2ltaWxhciB0byB0aGUgR0lDdjMuIFRoZSBudW1iZXIgb2YgTFJzIGRl cGVuZHMgb24gdGhlDQo+IGhhcmR3YXJlLiBTZWUgaG93IHdlIGRlYWx0IHdpdGggaXQgaW4gZ2lj djNfc2F2ZV9scnMoKS4NCj4NCg0KVGhpcyBpcyBhIGdvb2Qgc3VnZ2VzdGlvbiwgd2Ugd2lsbCBj aGVjayB0aGUgR0lDIGNvZGUuDQoNCj4gPg0KPiA+Pg0KPiA+PiBOb3RlIHRoYXQgZm9yIHRoZSBQ Mk0gd2UgYWxyZWFkeSBoYXZlIHRoYXQgaW5kaXJlY3Rpb24gYmVjYXVzZSBpdCBpcw0KPiA+PiBl bWJiZWQgaW4gdGhlIHN0cnVjdCBkb21haW4uDQo+ID4NCj4gPiBJdCdzIGRpZmZlcmVudCB3aXRo IFY4QSBQMk0gY2FzZS4gSW4gVjhBIGNvbnRleHRfc3dpdGNoIHdlIGp1c3QgbmVlZCB0bw0KPiA+ IHNhdmUvcmVzdG9yZSBWVFRCUiwgd2UgZG9uJ3QgbmVlZCB0byBkbyBQMk0gdGFibGUgd2Fsay4g QnV0IG9uIFY4Uiwgd2UNCj4gPiBuZWVkIHRvIGFjY2VzcyB2YWxpZCBtcHVfcmVnaW9ucyBmb3Ig c2F2ZS9yZXN0b3JlLg0KPiANCj4gVGhlIHNhdmUvcmVzdG9yZSBmb3IgdGhlIFAyTSBpcyBhIGJp dCBtb3JlIGNvbXBsaWNhdGVkIHRoYW4gc2ltcGx5DQo+IHNhdmUvcmVzdG9yZSB0aGUgVlRUQlIu IEJ1dCB5ZXMsIEkgYWdyZWUgdGhlIGNvZGUgZm9yIHRoZSBNUFUgd2lsbA0KPiBsaWtlbHkgYmUg bW9yZSBjb21wbGljYXRlZC4NCj4gDQo+ID4NCj4gPj4NCj4gPj4gVGhpcyByYWlzZXMgb25lIHF1 ZXN0aW9uLCB3aHkgaXMgdGhlIE1QVXMgcmVnaW9ucyB3aWxsIGJlIHBlci12Q1BVDQo+ID4+IHJh dGhlciBwZXIgZG9tYWluPw0KPiA+Pg0KPiA+DQo+ID4gQmVjYXVzZSB0aGVyZSBpcyBhIEVMMSBN UFUgY29tcG9uZW50IGZvciBlYWNoIHBDUFUuIFdlIGNhbid0IGFzc3VtZQ0KPiBndWVzdA0KPiA+ IHRvIHVzZSB0aGUgc2FtZSBFTDEgTVBVIGNvbmZpZ3VyYXRpb24gZm9yIGFsbCB2Q1BVLg0KPiAN Cj4gQWguIFNvcnJ5LCBJIHRob3VnaHQgeW91IHdlcmUgcmVmZXJyaW5nIHRvIHdoYXRldmVyIFhl biB3aWxsIHVzZSB0bw0KPiBwcmV2ZW50IHRoZSBndWVzdCBhY2Nlc3Npbmcgb3V0c2lkZSBvZiBp dHMgZGVzaWduYXRlZCByZWdpb24uDQo+IA0KDQpOUCA6ICkNCg0KVGhhbmtzLA0KV2VpIENoZW4N Cg0KPiBDaGVlcnMsDQo+IA0KPiAtLQ0KPiBKdWxpZW4gR3JhbGwNCg== From xen-devel-bounces@lists.xenproject.org Thu Mar 03 02:03:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Mar 2022 02:03:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282671.481466 (Exim 4.92) (envelope-from ) id 1nPaol-0005B9-2s; Thu, 03 Mar 2022 02:03:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282671.481466; Thu, 03 Mar 2022 02:03:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPaok-0005B2-Sq; Thu, 03 Mar 2022 02:03:46 +0000 Received: by outflank-mailman (input) for mailman id 282671; Thu, 03 Mar 2022 02:03:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPaoj-0005Av-0L for xen-devel@lists.xenproject.org; Thu, 03 Mar 2022 02:03:45 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 264c4724-9a96-11ec-8539-5f4723681683; Thu, 03 Mar 2022 03:03:42 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 95872615AF; Thu, 3 Mar 2022 02:03:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8CC70C004E1; Thu, 3 Mar 2022 02:03:40 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 264c4724-9a96-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646273021; bh=T1iP5fE/2UNwxXMXrlhOXhv48Tublx8Glo1H8C+/fxY=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=TRdpd7hG75g3jtq27BF+i8NNtOe2Tgx0icL7b47/KesPC8Eom3YhNeq8So8/kzCfQ 52i3cbUJRPF/IuYb5A9c2jGhZeJKKeYgn5nHkgBGoOd86H9dYuBc0ahc25yuIitfg8 UAppCiT5H8ubZ5izb6lY4z4n/w2MveZuNjlaF85BJ8Pgu800eOT2YJDa0PuerT1YRA tPYD0lE0tuhpAmix3m2jinwYgh5bascA4TYIUhFEmJIHAwPmDKL1GgD6aoDdh8b57K cnvbbIUWL1r58PzIMWUA51I/OB7m9tRyN1wcR4fWI3XAugy+auGMZ4CExrZHuSpMVK heqaAKUCk+7ow== Date: Wed, 2 Mar 2022 18:03:39 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Wei Chen cc: Stefano Stabellini , "xen-devel@lists.xenproject.org" , "julien@xen.org" , Bertrand Marquis , Penny Zheng , Henry Wang , nd , George.Dunlap@citrix.com Subject: RE: Proposal for Porting Xen to Armv8-R64 - DraftA In-Reply-To: Message-ID: References: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-15056552-1646272522=:3261" Content-ID: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-15056552-1646272522=:3261 Content-Type: text/plain; CHARSET=UTF-8 Content-Transfer-Encoding: 8BIT Content-ID: On Thu, 3 Mar 2022, Wei Chen wrote: > > On Wed, 2 Mar 2022, Wei Chen wrote: > > > > > > > > If not, and considering that we have to generate > > > > > > > > ARM_MPU_*_MEMORY_START/END anyway at build time, would it make > > > > sense > > > > > > to > > > > > > > > also generate mpu,guest-memory-section, xen,static-mem, etc. > > at > > > > build > > > > > > > > time rather than passing it via device tree to Xen at runtime? > > > > > > > > > > > > > > > > > > > > > > Did you mean we still add these information in device tree, but > > for > > > > > > build > > > > > > > time only. In runtime we don't parse them? > > > > > > > > > > > > Yes, something like that, but see below. > > > > > > > > > > > > > > > > > > > > What's the value of doing ARM_MPU_*_MEMORY_START/END at build > > time > > > > and > > > > > > > > everything else at runtime? > > > > > > > > > > > > > > ARM_MPU_*_MEMORY_START/END is defined by platform. But other > > things > > > > are > > > > > > > users customized. They can change their usage without rebuild > > the > > > > image. > > > > > > > > > > > > Good point. > > > > > > > > > > > > We don't want to have to rebuild Xen if the user updated a guest > > > > kernel, > > > > > > resulting in a larger boot-module-section. > > > > > > > > > > > > So I think it makes sense that "mpu,boot-module-section" is > > generated > > > > by > > > > > > the scripts (e.g. ImageBuilder) at build time, and Xen reads the > > > > > > property at boot from the runtime device tree. > > > > > > > > > > > > I think we need to divide the information into two groups: > > > > > > > > > > > > > > > > > > # Group1: board info > > > > > > > > > > > > This information is platform specific and it is not meant to > > change > > > > > > depending on the VM configuration. Ideally, we build Xen for a > > > > platform > > > > > > once, then we can use the same Xen binary together with any > > > > combination > > > > > > of dom0/domU kernels and ramdisks. > > > > > > > > > > > > This kind of information doesn't need to be exposed to the runtime > > > > > > device tree. But we can still use a build-time device tree to > > generate > > > > > > the addresses if it is convenient. > > > > > > > > > > > > XEN_START_ADDRESS, ARM_MPU_DEVICE_MEMORY_*, and > > > > ARM_MPU_NORMAL_MEMORY_* > > > > > > seem to be part of this group. > > > > > > > > > > > > > > > > Yes. > > > > > > > > > > > > > > > > > # Group2: boot configuration > > > > > > > > > > > > This information is about the specific set of binaries and VMs > > that we > > > > > > need to boot. It is conceptually similar to the dom0less device > > tree > > > > > > nodes that we already have. If we change one of the VM binaries, > > we > > > > > > likely have to refresh the information here. > > > > > > > > > > > > "mpu,boot-module-section" probably belongs to this group (unless > > we > > > > find > > > > > > a way to define "mpu,boot-module-section" generically so that we > > don't > > > > > > need to change it any time the set of boot modules change.) > > > > > > > > > > > > > > > > > > > > > > I agree. > > > > > > > > > > > > > It looks like we are forced to have the sections definitions > > at > > > > build > > > > > > > > time because we need them before we can parse device tree. In > > that > > > > > > case, > > > > > > > > we might as well define all the sections at build time. > > > > > > > > > > > > > > > > But I think it would be even better if Xen could automatically > > > > choose > > > > > > > > xen,static-mem, mpu,guest-memory-section, etc. on its own > > based on > > > > the > > > > > > > > regular device tree information (/memory, /amba, etc.), > > without > > > > any > > > > > > need > > > > > > > > for explicitly describing each range with these new properties. > > > > > > > > > > > > > > > > > > > > > > for mpu,guest-memory-section, with the limitations: no other > > usage > > > > > > between > > > > > > > different guest' memory nodes, this is OK. But for xen,static- > > mem > > > > (heap), > > > > > > > we just want everything on a MPU system is dertermistic. But, of > > > > course > > > > > > Xen > > > > > > > can select left memory for heap without static-mem. > > > > > > > > > > > > It is good that you think they can be chosen by Xen. > > > > > > > > > > > > Differently from "boot-module-section", which has to do with the > > boot > > > > > > modules selected by the user for a specific execution, > > > > > > guest-memory-section and static-mem are Xen specific memory > > > > > > policies/allocations. > > > > > > > > > > > > A user wouldn't know how to fill them in. And I worry that even a > > > > script > > > > > > > > > > But users should know it, because static-mem for guest must be > > allocated > > > > > in this range. And users take the responsibility to set the DomU's > > > > > static allocate memory ranges. > > > > > > > > Let me premise that my goal is to avoid having many users reporting > > > > errors to xen-devel and xen-users when actually it is just a wrong > > > > choice of addresses. > > > > > > > > I think we need to make a distinction between addresses for the boot > > > > modules, e.g. addresses where to load xen, the dom0/U kernel, dom0/U > > > > ramdisk in memory at boot time, and VM static memory addresses. > > > > > > > > The boot modules addresses are particularly difficult to fill in > > because > > > > they are many and a small update in one of the modules could > > invalidate > > > > all the other addresses. This is why I ended up writing ImageBuilder. > > > > Since them, I received several emails from users thanking me for > > > > ImageBuilder :-) > > > > > > > > > > Thanks +999 😊 > > > > > > > > > > The static VM memory addresses (xen,static-mem) should be a bit easier > > > > to fill in correctly. They are meant to be chosen once, and it > > shouldn't > > > > happen that an update on a kernel forces the user to change all the VM > > > > static memory addresses. Also, I know that some users actually want to > > > > be able to choose the domU addresses by hand because they have > > specific > > > > needs. So it is good that we can let the user choose the addresses if > > > > they want to. > > > > > > > > > > Yes. > > > > > > > With all of that said, I do think that many users won't have an > > opinion > > > > on the VM static memory addresses and won't know how to choose them. > > > > It would be error prone to let them try to fill them in by hand. So I > > > > was already planning on adding support to ImageBuilder to > > automatically > > > > generate xen,static-mem for dom0less domains. > > > > > > > > > > Let me make sure that's what you said: Users give an VM memory size to > > > ImageBuilder, and ImageBuilder will generate xen,static-mem = > size>. > > > For specific VM, ImageBuilder also can accept start and size as inputs? > > > > > > Do I understand this correctly? > > > > Yes, exactly > > > > > > > > Going back to this specific discussion about boot-module-section: I > > can > > > > see now that, given xen,static-mem is chosen by ImageBuilder (or > > > > > > By hand : ) > > > > > > > similar) and not Xen, then it makes sense to have ImageBuilder (or > > > > similar) also generate boot-module-section. > > > > > > > > > > If my above understanding is right, then yes. > > > > Yes, I think we are on the same page > > > > > > > > > > like ImageBuilder wouldn't be the best place to pick these values > > -- > > > > > > they seem too "important" to leave to a script. > > > > > > > > > > > > But it seems possible to choose the values in Xen: > > > > > > - Xen knows ARM_MPU_NORMAL_MEMORY_* because it was defined at > > build > > > > time > > > > > > - Xen reads boot-module-section from device tree > > > > > > > > > > > > It should be possible at this point for Xen to pick the best > > values > > > > for > > > > > > guest-memory-section and static-mem based on the memory available. > > > > > > > > > > > > > > > > How Xen to pick? Does it mean in static allocation DomU DT node, we > > just > > > > > need a size, but don't require a start address for static-mem? > > > > > > > > Yes the idea was that the user would only provide the size (e.g. > > > > DOMU_STATIC_MEM[1]=1024) and the addresses would be automatically > > > > calculated. But I didn't mean to change the existing xen,static-mem > > > > device tree bindings. So it is best if the xen,static-mem addresses > > > > generation is done by ImageBuilder (or similar tool) instead of Xen. > > > > > > > > > > If we still keep the option for user to specify the start and size > > > parameters for VM memory, because it maybe very important for a > > > deterministic system (fully static system), I agree with you. > > > > > > And in current static-allocation, I think Xen doesn't generate > > > xen,static-mem addresses, all by hands... > > > > Yeah > > > > I will update my proposal to cover our above discussion, but I forgot one > thing. As the platform header files will be generated from DTS, does it > mean we have to maintain platform dts files in Xen like what Zephyr has > done? I would prefer not to have to maintain platform dts files in Xen like Zephyr is doing. Ideally, the user should be able to take any spec-compliant device tree file and use it. I would say: let's start without adding the dts files to Xen (we might have one under docs/ but just as an example.) We can add them later if the need arise. > And do you have some idea to integrate the "ImageBuilder"? Make it > as a submodule of Xen or integrate to xen-tools? I think it would be best if ImageBuilder was kept as a separate repository because there should be no strong ties between ImageBuilder versions and Xen versions. It is more convenient to handle it in a separate repository, especially as Yocto and other build systems might clone ImageBuilder during the build to generate boot.scr (it is already the case). That said, it might be good to make it more "official" but moving it to Xen Project. I can talk to George about creating http://xenbits.xen.org/git-http/imagebuilder.git or https://gitlab.com/xen-project/imagebuilder. --8323329-15056552-1646272522=:3261-- From xen-devel-bounces@lists.xenproject.org Thu Mar 03 02:06:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Mar 2022 02:06:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282680.481475 (Exim 4.92) (envelope-from ) id 1nParo-0006Ew-Hf; Thu, 03 Mar 2022 02:06:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282680.481475; Thu, 03 Mar 2022 02:06:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nParo-0006Ep-EN; Thu, 03 Mar 2022 02:06:56 +0000 Received: by outflank-mailman (input) for mailman id 282680; Thu, 03 Mar 2022 02:06:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nParn-0006Ej-1H for xen-devel@lists.xenproject.org; Thu, 03 Mar 2022 02:06:55 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20607.outbound.protection.outlook.com [2a01:111:f400:7e1b::607]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9789d680-9a96-11ec-8eba-a37418f5ba1a; Thu, 03 Mar 2022 03:06:52 +0100 (CET) Received: from AM6PR0202CA0056.eurprd02.prod.outlook.com (2603:10a6:20b:3a::33) by AM6PR08MB3878.eurprd08.prod.outlook.com (2603:10a6:20b:8b::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.25; Thu, 3 Mar 2022 02:06:44 +0000 Received: from VE1EUR03FT037.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:3a:cafe::55) by AM6PR0202CA0056.outlook.office365.com (2603:10a6:20b:3a::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.14 via Frontend Transport; Thu, 3 Mar 2022 02:06:44 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT037.mail.protection.outlook.com (10.152.19.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22 via Frontend Transport; Thu, 3 Mar 2022 02:06:44 +0000 Received: ("Tessian outbound 2877e54fe176:v113"); Thu, 03 Mar 2022 02:06:43 +0000 Received: from 8463b0d2cdb5.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id BAD1F1D2-1DBF-4D84-9E63-B27451E9578F.1; Thu, 03 Mar 2022 02:06:37 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8463b0d2cdb5.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 03 Mar 2022 02:06:37 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by VI1PR08MB3631.eurprd08.prod.outlook.com (2603:10a6:803:85::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.14; Thu, 3 Mar 2022 02:06:34 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::89b3:80a2:2b58:f1aa]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::89b3:80a2:2b58:f1aa%4]) with mapi id 15.20.5038.014; Thu, 3 Mar 2022 02:06:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9789d680-9a96-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=L7ass8AaR0DkOrMmIHcWf+VyphZU8Uk/3h5xCdKMKm8=; b=Q7IfOYZoysPcDYVI9iuXzL6C/t7qIrDIljLhCCHW3yBlqM+E1AxWQ0ognGt+WerurvX+N1Ws6f2pckwcaGIbslgKbdUdERlORWouMrFn6dTxvWGmyr35RqqT9vxONe5E4I4VLsXUoFS9OgEb5PrZbap3T47adFHKW7P0aOwq6a8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SShghBuVA7PHHvVOpVRlEluvhSiX/D4bTUj/tT83DvO3yfwVAHnBW2UKGvYl3SJOjecycz5s01IK8xKBgxComN+W2LUuF88fhptkuxNoGBTiAwtdIVCg/gBOMso5DlavfWt2pfDJXh2io+deJaDxgKBTjcQnL3EnJ5gV55DTjm6gu//Ejoz4jYOACd/e8Plosx4xDz2ei9nlfx7k33F13XlHKKMsmiZe820n9a3qu6oBs5fxISq0DGrWEW2WkOqGAdRn6g3BhKR2Xgm6EN6qQzAH0WGXtzk/m6qw6ur2glZDip7JIFLOJesp9ARpQPm+sPsp8D/Za9erQgB/HTr4bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=L7ass8AaR0DkOrMmIHcWf+VyphZU8Uk/3h5xCdKMKm8=; b=R7n8irmGIaKkyxXbIxORi8fUw6Quot/O0wDPxDbxar6cW9jXtjsR5x8JgNbQxDsIXTys2V11tf8f532hje9z6KO/5R7CPRS43PdEEUfM8jvIAL46XC/OUyWYk9wjMZbiYxALPd88SKjEbewJBOMFKzkiWbmKBK7LG7f9WqagMGRbsbj7a0Mufye3LMjkUuevlWQ305dGgupaKd6ixkRTguzjikFXckSyNsqsSzhECljePy3vD8Fg1jiy6vVzVvK7QcvzDPEFYgdaWyian0RFR/Tc7CSx0YD69cseQpBj6irg/g+wA+cKa83hjolH66SD+03f7uCd5Xa9eoWWSdA+Pg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=L7ass8AaR0DkOrMmIHcWf+VyphZU8Uk/3h5xCdKMKm8=; b=Q7IfOYZoysPcDYVI9iuXzL6C/t7qIrDIljLhCCHW3yBlqM+E1AxWQ0ognGt+WerurvX+N1Ws6f2pckwcaGIbslgKbdUdERlORWouMrFn6dTxvWGmyr35RqqT9vxONe5E4I4VLsXUoFS9OgEb5PrZbap3T47adFHKW7P0aOwq6a8= From: Wei Chen To: Julien Grall , "xen-devel@lists.xenproject.org" , Stefano Stabellini CC: Bertrand Marquis , Penny Zheng , Henry Wang , nd Subject: RE: Proposal for Porting Xen to Armv8-R64 - DraftA Thread-Topic: Proposal for Porting Xen to Armv8-R64 - DraftA Thread-Index: AdgpQxtXwh7LkfydTgiYk9bhMgU+ogBRt1sAAKse4VAAPag1gAAckyvA Date: Thu, 3 Mar 2022 02:06:34 +0000 Message-ID: References: <04db7e8b-2f04-41d7-1deb-d8bda3625c04@xen.org> <1f0bba54-158b-d171-6f99-0c29e0547f8a@xen.org> In-Reply-To: <1f0bba54-158b-d171-6f99-0c29e0547f8a@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: A65CE69BD1303548811D0CC54A01930D.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: d30ea2b8-8f56-4253-b22b-08d9fcba7727 x-ms-traffictypediagnostic: VI1PR08MB3631:EE_|VE1EUR03FT037:EE_|AM6PR08MB3878:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: uIsx5KyOWJnWagSmdU7jEQfhP8MN7ZtleCBtTibJP39fxXvn+iOdtGp6nqrDrIHpUV0+XRWREn1n5gDxPgOUlTSTnoW8JZmfWbitB6YMilvsb/DFP+rBdUaPaHi7xxi7rQuNUfCUfYRu0Q9bcSnvAPAyEp6NDCOg4EbJ+5RLUGgaWhfuo5Eu24nmNGH41aMoF+IpcKeCZXd6y2ZGXqbiaEQgjja2fEjI95Lcg8OwZY/zXFJVk2Cd6FiZozy6Tar1Rkmmy7b+tK/DbnjVAwX9bHL+pL35y+fyIbRJ446F7pmSFhG2gxU1NMAVgz5lPO2/uBIHF7tu5R2TTmvfQK/2D0FKbM2cmDrCYh0Sb9aRUPiDXzIBVUWJ50quP4+7hT/0jhE/3Qj1WvSOpgzr9KBY9/cxYPTEbBEWwMkU4P1/GoYpluzcc4Z3IHR+gDPLSHNPw6HTkSgayd1uInef4nvJQ+G5Z5yLFPJQgvkZt2Iu4qV+M7QNLbJcNPv44Aa6F5iq6QoyGUNPT/J+DaYJBOQpF0Qc4Wnz/KcgTw1aWrsdMwLT1qn24H2lyVnFbXCfeYG7sEffwZtESJwQ0nHmxA7Jdx7nQQKviUJLf+bNpXRR0Qr9DI8pqGTTGL2qyFynbHMBZi9xF3aA0101h41MihuH8wfOL5Yuz7SOWK1cvzdGzWkIFINoXFEoWe9rlUMc07eMEnUm/an6w1S/cuM/DXuNtJzl0i7kcBhPA8l5wtyAEnqlYPMG8O2vGNdx0hhwikK085jWe3JAqSgZS/iNCuKZTAqw28n+Lm93TK8xtCqfuwk= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(122000001)(5660300002)(7696005)(86362001)(9686003)(8936002)(110136005)(316002)(54906003)(33656002)(6506007)(66476007)(30864003)(52536014)(53546011)(55016003)(76116006)(83380400001)(8676002)(64756008)(4326008)(66556008)(66446008)(66946007)(38100700002)(508600001)(26005)(186003)(2906002)(71200400001)(38070700005);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3631 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT037.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: aa40c1d1-bbc0-4c01-c2d7-08d9fcba7147 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: T8Xv85+l2+qRRGVb1Wp4AaR9NN+yDEwqQVvAtPtv+4KHjQTi+XQvYGh3pGPWDVPl9HXq1OynNcPHUjN6IwPj+s8s4NsO84NNS25PUbdyrSsh3qsXvF5ueK0LMu9GCUY5v1s2awkjANtqAo85r2cUawBq0hyq6fLUDgUDDju09kHGUGztTrTzDrhhIFkxfTXJHMgd2DwZacAtAZ8+CN5PVGsjQnIMym/A5K1fhzsc2oAgfAGLgh8elhzZK5P6VkdAaOrH6i5S9Z/E1VtIATwzO9t+CXcINJspTB8vGuhW5t5/s67AjfTdkWzYlHXl/IKmz0FNldJqRJV0JUHn25KYq8TlmMoeIIwSsJNfDNtOyLZaJlKAvzfK2YH1BtNiIiOYd0Flq/KtIQIiWPp4FfI1OOFNE5lA62fzDBHkaXjdrv1giUOGVvpuMug6hbiiAcwiuZAjpVgNqP7Cq9rUwcEwDvxAR/Rq55ttC61nXP5be0a1cLDZE73y/L955Sf0mngch2bm3W10l0qB/tAIb0kS3aPjCFak6BG/uXiYOPZExkPSSdjUI6c1XlMvi5oCo4jkbrsuANhPGIZZ8X642Eo1CQsFtlOpEkqvDP6JvxXfjPqWM8sf4UqbMYC3AYrnbOsKD0r/C5pQ8Uup3WJgJMDH+MGxBd/vlMe58QxA2Lf2QIOh11iiJW/KKy5qsv8GRhOSwkUbBmuXGRlNIWptXaTJ8pUbbgjYaZqEVPwnMNExHH8kVvVNYoFV7/kMaAywoxWUQ40Dwxt6tU8oziT6QgKvaQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(336012)(33656002)(26005)(81166007)(356005)(9686003)(86362001)(53546011)(5660300002)(186003)(83380400001)(316002)(54906003)(30864003)(2906002)(110136005)(82310400004)(36860700001)(55016003)(4326008)(508600001)(6506007)(70206006)(8676002)(52536014)(47076005)(7696005)(8936002)(40460700003)(70586007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2022 02:06:44.1450 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d30ea2b8-8f56-4253-b22b-08d9fcba7727 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT037.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3878 SGkgSnVsaWVuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEp1bGll biBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+IFNlbnQ6IDIwMjLlubQz5pyIMuaXpSAyMDowMA0K PiBUbzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+OyB4ZW4tZGV2ZWxAbGlzdHMueGVucHJv amVjdC5vcmc7IFN0ZWZhbm8NCj4gU3RhYmVsbGluaSA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz4N Cj4gQ2M6IEJlcnRyYW5kIE1hcnF1aXMgPEJlcnRyYW5kLk1hcnF1aXNAYXJtLmNvbT47IFBlbm55 IFpoZW5nDQo+IDxQZW5ueS5aaGVuZ0Bhcm0uY29tPjsgSGVucnkgV2FuZyA8SGVucnkuV2FuZ0Bh cm0uY29tPjsgbmQgPG5kQGFybS5jb20+DQo+IFN1YmplY3Q6IFJlOiBQcm9wb3NhbCBmb3IgUG9y dGluZyBYZW4gdG8gQXJtdjgtUjY0IC0gRHJhZnRBDQo+IA0KPiANCj4gDQo+IE9uIDAxLzAzLzIw MjIgMDc6NTEsIFdlaSBDaGVuIHdyb3RlOg0KPiA+IEhpIEp1bGllbiwNCj4gDQo+IEhpIFdlaSwN Cj4gDQo+ID4+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+ID4+IEZyb206IEp1bGllbiBH cmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+ID4+IFNlbnQ6IDIwMjLlubQy5pyIMjbml6UgNDo1NQ0K PiA+PiBUbzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+OyB4ZW4tZGV2ZWxAbGlzdHMueGVu cHJvamVjdC5vcmc7DQo+IFN0ZWZhbm8NCj4gPj4gU3RhYmVsbGluaSA8c3N0YWJlbGxpbmlAa2Vy bmVsLm9yZz4NCj4gPj4gQ2M6IEJlcnRyYW5kIE1hcnF1aXMgPEJlcnRyYW5kLk1hcnF1aXNAYXJt LmNvbT47IFBlbm55IFpoZW5nDQo+ID4+IDxQZW5ueS5aaGVuZ0Bhcm0uY29tPjsgSGVucnkgV2Fu ZyA8SGVucnkuV2FuZ0Bhcm0uY29tPjsgbmQgPG5kQGFybS5jb20+DQo+ID4+IFN1YmplY3Q6IFJl OiBQcm9wb3NhbCBmb3IgUG9ydGluZyBYZW4gdG8gQXJtdjgtUjY0IC0gRHJhZnRBDQo+ID4+PiAj IyMgMS4yLiBYZW4gQ2hhbGxlbmdlcyB3aXRoIFBNU0EgVmlydHVhbGl6YXRpb24NCj4gPj4+IFhl biBpcyBQTVNBIHVuYXdhcmUgVHlwZS0xIEh5cGVydmlzb3IsIGl0IHdpbGwgbmVlZCBtb2RpZmlj YXRpb25zIHRvDQo+IHJ1bg0KPiA+Pj4gd2l0aCBhbiBNUFUgYW5kIGhvc3QgbXVsdGlwbGUgZ3Vl c3QgT1Nlcy4NCj4gPj4+DQo+ID4+PiAtIE5vIE1NVSBhdCBFTDI6DQo+ID4+PiAgICAgICAtIE5v IEVMMiBTdGFnZSAxIGFkZHJlc3MgdHJhbnNsYXRpb24NCj4gPj4+ICAgICAgICAgICAtIFhlbiBw cm92aWRlcyBmaXhlZCBBUk02NCB2aXJ0dWFsIG1lbW9yeSBsYXlvdXQgYXMgYmFzaXMgb2YNCj4g Pj4gRUwyDQo+ID4+PiAgICAgICAgICAgICBzdGFnZSAxIGFkZHJlc3MgdHJhbnNsYXRpb24sIHdo aWNoIGlzIG5vdCBhcHBsaWNhYmxlIG9uDQo+IE1QVQ0KPiA+PiBzeXN0ZW0sDQo+ID4+PiAgICAg ICAgICAgICB3aGVyZSB0aGVyZSBpcyBubyB2aXJ0dWFsIGFkZHJlc3NpbmcuIEFzIGEgcmVzdWx0 LCBhbnkNCj4gPj4gb3BlcmF0aW9uDQo+ID4+PiAgICAgICAgICAgICBpbnZvbHZpbmcgdHJhbnNp dGlvbiBmcm9tIFBBIHRvIFZBLCBsaWtlIGlvcmVtYXAsIG5lZWRzDQo+ID4+IG1vZGlmaWNhdGlv bg0KPiA+Pj4gICAgICAgICAgICAgb24gTVBVIHN5c3RlbS4NCj4gPj4+ICAgICAgIC0gWGVuJ3Mg cnVuLXRpbWUgYWRkcmVzc2VzIGFyZSB0aGUgc2FtZSBhcyB0aGUgbGluayB0aW1lDQo+IGFkZHJl c3Nlcy4NCj4gPj4+ICAgICAgICAgICAtIEVuYWJsZSBQSUMgKHBvc2l0aW9uLWluZGVwZW5kZW50 IGNvZGUpIG9uIGEgcmVhbC10aW1lDQo+IHRhcmdldA0KPiA+Pj4gICAgICAgICAgICAgcHJvY2Vz c29yIHByb2JhYmx5IHZlcnkgcmFyZS4NCj4gPj4NCj4gPj4gQXNpZGUgdGhlIGFzc2VtYmx5IGJv b3QgY29kZSBhbmQgVUVGSSBzdHViLCBYZW4gYWxyZWFkeSBydW5zIGF0IHRoZQ0KPiBzYW1lDQo+ ID4+IGFkZHJlc3MgYXMgaXQgd2FzIGxpbmtlZC4NCj4gPj4NCj4gPg0KPiA+IEJ1dCB0aGUgZGlm ZmVyZW5jZSBpcyB0aGF0LCBiYXNlIG9uIE1NVSwgd2UgY2FuIHVzZSB0aGUgc2FtZSBsaW5rDQo+ IGFkZHJlc3MNCj4gPiBmb3IgYWxsIHBsYXRmb3Jtcy4gQnV0IG9uIE1QVSBzeXN0ZW0sIHdlIGNh bid0IGRvIGl0IGluIHRoZSBzYW1lIHdheS4NCj4gDQo+IEkgYWdyZWUgdGhhdCB3ZSBjdXJyZW50 bHkgdXNlIHRoZSBzYW1lIGxpbmsgYWRkcmVzcyBmb3IgYWxsIHRoZQ0KPiBwbGF0Zm9ybXMuIEJ1 dCB0aGlzIGlzIGFsc28gYSBwcm9ibGVtIHdoZW4gdXNpbmcgTU1VIGJlY2F1c2UgRUwyIGhhcyBh DQo+IHNpbmdsZSBUVEJSLg0KPiANCj4gQXQgdGhlIG1vbWVudCB3ZSBhcmUgc3dpdGNoaW5nIHBh Z2UtdGFibGVzIHdpdGggdGhlIE1NVSB3aGljaCBpcyBub3QNCj4gc2FmZS4gSW5zdGVhZCB3ZSBu ZWVkIHRvIHR1cm4gb3V0IHRoZSBNTVUgb2ZmLCBzd2l0Y2ggcGFnZS10YWJsZXMgYW5kDQo+IHRo ZW4gdHVybiBvbiB0aGUgTU1VLiBUaGlzIG1lYW5zIHdlIG5lZWQgdG8gaGF2ZSBhbiBpZGVudGl0 eSBtYXBwaW5nIG9mDQo+IFhlbiBpbiB0aGUgcGFnZS10YWJsZXMuIEFzc3VtaW5nIFhlbiBpcyBu b3QgcmVsb2NhdGVkLCB0aGUgaWRlbnRpdHkNCj4gbWFwcGluZyBtYXkgY2xhc2ggd2l0aCBYZW4g KG9yIHRoZSByZXN0IG9mIHRoZSB2aXJ0dWFsIGFkZHJlc3MgbWFwKS4NCj4gDQoNCklzIHRoaXMg dGhlIHNhbWUgcmVhc29uIHdlIGNyZWF0ZSBhIGR1bW15IHJlbG9jIHNlY3Rpb24gZm9yIEVGSSBs b2FkZXI/DQoNCj4gTXkgaW5pdGlhbCBpZGVhIHdhcyB0byBlbmFibGUgUElDIGFuZCB1cGRhdGUg dGhlIHJlbG9jYXRpb24gYXQgYm9vdA0KPiB0aW1lLiBCdXQgdGhpcyBpcyBhIGJpdCBjdW1iZXJz b21lIHRvIGRvLiBTbyBub3cgSSBhbSBsb29raW5nIHRvIGhhdmUgYQ0KPiBzZW1pLWR5bmFtaWMg dmlydHVhbCBsYXlvdXQgYW5kIGZpbmQgc29tZSBwbGFjZSB0byByZWxvY2F0ZSBwYXJ0IG9mIFhl bg0KPiB0byB1c2UgZm9yIENQVSBicmluZy11cC4NCj4gDQo+IEFueXdheSwgbXkgcG9pbnQgaXMg d2UgcG9zc2libHkgY291bGQgbG9vayBhdCBQSUMgaWYgdGhhdCBjb3VsZCBhbGxvdw0KPiBnZW5l cmljIFhlbiBpbWFnZS4NCj4gDQoNCkkgdW5kZXJzdGFuZCB5b3VyIGNvbmNlcm4uIElNTywgUElD IGlzIHBvc3NpYmxlIHRvIGRvIHRoaXMsIGJ1dCBvYnZpb3VzbHksDQppdCdzIG5vdCBhIHNtYWxs IGFtb3VudCBvZiB3b3JrLiBBbmQgSSB3YW50IHRvIGhlYXIgc29tZSBzdWdnZXN0aW9ucyBmcm9t DQpTdGVmYW5vLCBiZWNhdXNlIGhlIGFsc28gaGFzIHNvbWUgc29sdXRpb25zIGluIHByZXZpb3Vz IHRocmVhZC4gDQoNCj4gPj4+ICAgICAgIC0gWGVuIHdpbGwgbmVlZCB0byB1c2UgdGhlIEVMMiBN UFUgbWVtb3J5IHJlZ2lvbiBkZXNjcmlwdG9ycyB0bw0KPiA+PiBtYW5hZ2UNCj4gPj4+ICAgICAg ICAgYWNjZXNzIHBlcm1pc3Npb25zIGFuZCBhdHRyaWJ1dGVzIGZvciBhY2Nlc3NlcyBtYWRlIGJ5 IFZNcyBhdA0KPiA+PiBFTDEvMC4NCj4gPj4+ICAgICAgICAgICAtIFhlbiBjdXJyZW50bHkgcmVs aWVzIG9uIE1NVSBFTDEgc3RhZ2UgMiB0YWJsZSB0byBtYW5hZ2UNCj4gdGhlc2UNCj4gPj4+ICAg ICAgICAgICAgIGFjY2Vzc2VzLg0KPiA+Pj4gLSBObyBNTVUgU3RhZ2UgMiB0cmFuc2xhdGlvbiBh dCBFTDE6DQo+ID4+PiAgICAgICAtIEEgZ3Vlc3QgZG9lc24ndCBoYXZlIGFuIGluZGVwZW5kZW50 IGd1ZXN0IHBoeXNpY2FsIGFkZHJlc3MNCj4gc3BhY2UNCj4gPj4+ICAgICAgIC0gQSBndWVzdCBj YW4gbm90IHJldXNlIHRoZSBjdXJyZW50IEludGVybWVkaWF0ZSBQaHlzaWNhbA0KPiBBZGRyZXNz DQo+ID4+PiAgICAgICAgIG1lbW9yeSBsYXlvdXQNCj4gPj4+ICAgICAgIC0gQSBndWVzdCB1c2Vz IHBoeXNpY2FsIGFkZHJlc3NlcyB0byBhY2Nlc3MgbWVtb3J5IGFuZCBkZXZpY2VzDQo+ID4+PiAg ICAgICAtIFRoZSBNUFUgYXQgRUwyIG1hbmFnZXMgRUwxIHN0YWdlIDIgYWNjZXNzIHBlcm1pc3Np b25zIGFuZA0KPiA+PiBhdHRyaWJ1dGVzDQo+ID4+PiAtIFRoZXJlIGFyZSBhIGxpbWl0ZWQgbnVt YmVyIG9mIE1QVSBwcm90ZWN0aW9uIHJlZ2lvbnMgYXQgYm90aCBFTDIgYW5kDQo+ID4+IEVMMToN Cj4gPj4+ICAgICAgIC0gQXJjaGl0ZWN0dXJhbGx5LCB0aGUgbWF4aW11bSBudW1iZXIgb2YgcHJv dGVjdGlvbiByZWdpb25zIGlzDQo+IDI1NiwNCj4gPj4+ICAgICAgICAgdHlwaWNhbCBpbXBsZW1l bnRhdGlvbnMgaGF2ZSAzMi4NCj4gPj4+ICAgICAgIC0gQnkgY29udHJhc3QsIFhlbiBkb2VzIG5v dCBuZWVkIHRvIGNvbnNpZGVyIHRoZSBudW1iZXIgb2YgcGFnZQ0KPiA+PiB0YWJsZQ0KPiA+Pj4g ICAgICAgICBlbnRyaWVzIGluIHRoZW9yeSB3aGVuIHVzaW5nIE1NVS4NCj4gPj4+IC0gVGhlIE1Q VSBwcm90ZWN0aW9uIHJlZ2lvbnMgYXQgRUwyIG5lZWQgdG8gYmUgc2hhcmVkIGJldHdlZW4gdGhl DQo+ID4+IGh5cGVydmlzb3INCj4gPj4+ICAgICBhbmQgdGhlIGd1ZXN0IHN0YWdlIDIuDQo+ID4+ PiAgICAgICAtIFJlcXVpcmVzIGNhcmVmdWwgY29uc2lkZXJhdGlvbiAtIG1heSBpbXBhY3QgZmVh dHVyZSAnZnVsbG5lc3MnDQo+IG9mDQo+ID4+IGJvdGgNCj4gPj4+ICAgICAgICAgdGhlIGh5cGVy dmlzb3IgYW5kIHRoZSBndWVzdA0KPiA+Pj4gICAgICAgLSBCeSBjb250cmFzdCwgd2hlbiB1c2lu ZyBNTVUsIFhlbiBoYXMgc3RhbmRhbG9uZSBQMk0gdGFibGUgZm9yDQo+ID4+IGd1ZXN0DQo+ID4+ PiAgICAgICAgIHN0YWdlIDIgYWNjZXNzZXMuDQo+ID4+DQo+ID4+IFsuLi5dDQo+ID4+DQo+ID4+ PiAtICoqKkRlZmluZSBuZXcgc3lzdGVtIHJlZ2lzdGVycyBmb3IgY29tcGlsZXJzKioqOg0KPiA+ Pj4gICAgIEFybXY4LVI2NCBpcyBiYXNlZCBvbiBBcm12OC40LiBUaGF0IG1lYW5zIHdlIHdpbGwg dXNlIHNvbWUgQXJtdjguNA0KPiA+Pj4gICAgIHNwZWNpZmljIHN5c3RlbSByZWdpc3RlcnMuIEFz IEFybXY4LVI2NCBvbmx5IGhhdmUgc2VjdXJlIHN0YXRlLCBzbw0KPiA+Pj4gICAgIGF0IGxlYXN0 LCBgVlNUQ1JfRUwyYCBhbmQgYFZTQ1RMUl9FTDJgIHdpbGwgYmUgdXNlZCBmb3IgWGVuLiBBbmQN Cj4gdGhlDQo+ID4+PiAgICAgZmlyc3QgR0NDIHZlcnNpb24gdGhhdCBzdXBwb3J0cyBBcm12OC40 IGlzIEdDQyA4LjEuIEluIGFkZGl0aW9uIHRvDQo+ID4+PiAgICAgdGhlc2UsIFBNU0Egb2YgQXJt djgtUjY0IGludHJvZHVjZWQgbG90cyBvZiBNUFUgcmVsYXRlZCBzeXN0ZW0NCj4gPj4gcmVnaXN0 ZXJzOg0KPiA+Pj4gICAgIGBQUkJBUl9FTHhgLCBgUFJCQVJ4X0VMeGAsIGBQUkxBUl9FTHhgLCBg UFJMQVJ4X0VMeGAsIGBQUkVOUl9FTHhgDQo+IGFuZA0KPiA+Pj4gICAgIGBNUFVJUl9FTHhgLiBC dXQgdGhlIGZpcnN0IEdDQyB2ZXJzaW9uIHRvIHN1cHBvcnQgdGhlc2Ugc3lzdGVtDQo+ID4+IHJl Z2lzdGVycw0KPiA+Pj4gICAgIGlzIEdDQyAxMS4gU28gd2UgaGF2ZSB0d28gd2F5cyB0byBtYWtl IGNvbXBpbGVycyB0byB3b3JrIHByb3Blcmx5DQo+ID4+IHdpdGgNCj4gPj4+ICAgICB0aGVzZSBz eXN0ZW0gcmVnaXN0ZXJzLg0KPiA+Pj4gICAgIDEuIEJ1bXAgR0NDIHZlcnNpb24gdG8gR0NDIDEx Lg0KPiA+Pj4gICAgICAgIFRoZSBwcm9zIG9mIHRoaXMgbWV0aG9kIGlzIHRoYXQsIHdlIGRvbid0 IG5lZWQgdG8gZW5jb2RlIHRoZXNlDQo+ID4+PiAgICAgICAgc3lzdGVtIHJlZ2lzdGVycyBpbiBt YWNyb3MgYnkgb3Vyc2VsdmVzLiBCdXQgdGhlIGNvbnMgYXJlIHRoYXQsDQo+ID4+PiAgICAgICAg d2UgaGF2ZSB0byB1cGRhdGUgTWFrZWZpbGVzIHRvIHN1cHBvcnQgR0NDIDExIGZvciBBcm12OC1S NjQuDQo+ID4+PiAgICAgICAgMS4xLiBDaGVjayB0aGUgR0NDIHZlcnNpb24gMTEgZm9yIEFybXY4 LVI2NC4NCj4gPj4+ICAgICAgICAxLjIuIEFkZCBtYXJjaD1hcm12OHIgdG8gQ0ZMQUdTIGZvciBB cm12OC1SNjQuDQo+ID4+PiAgICAgICAgMS4zLiBTb2x2ZSB0aGUgY29uZmxpY3Rpb24gb2YgbWFy Y2g9YXJtdjhyIGFuZCBtY3B1PWdlbmVyaWMNCj4gPj4+ICAgICAgIFRoZXNlIGNoYW5nZXMgd2ls bCBhZmZlY3QgY29tbW9uIE1ha2VmaWxlcywgbm90IG9ubHkgQXJtDQo+IE1ha2VmaWxlcy4NCj4g Pj4+ICAgICAgIEFuZCBHQ0MgMTEgaXMgbmV3LCBsb3RzIG9mIHRvb2xjaGFpbnMgYW5kIERpc3Ry byBoYXZlbid0DQo+IHN1cHBvcnRlZA0KPiA+PiBpdC4NCj4gPj4NCj4gPj4gSSBhZ3JlZSB0aGF0 IGZvcmNpbmcgdG8gdXNlIEdDQzExIGlzIG5vdCBhIGdvb2QgaWRlYS4gQnV0IEkgYW0gbm90IHN1 cmUNCj4gPj4gdG8gdW5kZXJzdGFuZCB0aGUgcHJvYmxlbSB3aXRoIHRoZSAtbWFyY2g9Li4uLiBV bHRpbWF0ZWx5LCBzaG91bGRuJ3Qgd2UNCj4gPj4gYWltIHRvIGJ1aWxkIFhlbiBBUk12OC1SIHdp dGggLW1hcmNoPWFybXY4cj8NCj4gPj4NCj4gPg0KPiA+IEFjdHVhbGx5LCB3ZSBoYWQgZG9uZSwg YnV0IHdlIHJldmVydGVkIGl0IGZyb20gUkZDIHBhdGNoIHNlcmllcy4gVGhlDQo+IHJlYXNvbg0K PiA+IGhhcyBiZWVuIGxpc3RlZCBhYm92ZS4gQnV0IHRoYXQgaXMgbm90IHRoZSBtYWpvciByZWFz b24uIFRoZSBtYWluIHJlYXNvbg0KPiA+IGlzIHRoYXQ6DQo+ID4gQXJtdjgtUiBBQXJjaDY0IHN1 cHBvcnRzIHRoZSBBNjQgSVNBIGluc3RydWN0aW9uIHNldCB3aXRoIHNvbWUNCj4gbW9kaWZpY2F0 aW9uczoNCj4gPiBSZWRlZmluZXMgRE1CLCBEU0IsIGFuZCBhZGRzIGFuIERGQi4gQnV0IGFjdHVh bGx5LCB0aGUgZW5jb2RpbmdzIG9mIERNQg0KPiBhbmQNCj4gPiBEU0IgYXJlIHN0aWxsIHRoZSBz YW1lIHdpdGggQTY0LiBBbmQgREZCIGlzIGEgYWxpYXMgb2YgRFNCICMxMi4NCj4gPg0KPiA+IElu IHRoaXMgY2FzZSwgd2UgZG9uJ3QgdGhpbmsgd2UgbmVlZCBhIG5ldyBhcmNoIGZsYWcgdG8gZ2Vu ZXJhdGUgbmV3DQo+ID4gaW5zdHJ1Y3Rpb25zIGZvciBBcm12OC1SLiBBbmQgd2UgaGF2ZSBkaXNj dXNzZWQgd2l0aCBBcm0ga2VybmVsIGd1eXMsDQo+IHRoZXkNCj4gPiB3aWxsIG5vdCB1cGRhdGUg dGhlIGJ1aWxkIHN5c3RlbSB0byBidWlsZCBMaW51eCB0aGF0IHdpbGwgYmUgcnVubmluZyBvbg0K PiA+IEFybXY4LVI2NCBFTDEgZWl0aGVyLg0KPiANCj4gR29vZCB0byBrbm93IHRoYXQgdGhlIGtl cm5lbCBmb2xrcyBwbGFuIHRvIGRvIHRoZSBzYW1lLiBUaGFua3MgZm9yIHRoZQ0KPiBleHBsYW5h dGlvbiENCj4gDQo+ID4NCj4gPg0KPiA+PiBbLi4uXQ0KPiA+Pg0KPiA+Pj4gIyMjICoqMi4yLiBD aGFuZ2VzIG9mIHRoZSBpbml0aWFsaXphdGlvbiBwcm9jZXNzKioNCj4gPj4+IEluIGdlbmVyYWws IHdlIHN0aWxsIGV4cGVjdCBBcm12OC1SNjQgYW5kIEFybXY4LUE2NCB0byBoYXZlIGENCj4gY29u c2lzdGVudA0KPiA+Pj4gaW5pdGlhbGl6YXRpb24gcHJvY2Vzcy4gSW4gYWRkaXRpb24gdG8gc29t ZSBhcmNoaXRlY3R1cmUgZGlmZmVyZW5jZXMsDQo+ID4+IHRoZXJlDQo+ID4+PiBpcyBubyBtb3Jl IHRoYW4gcmV1c2FibGUgY29kZSB0aGF0IHdlIHdpbGwgZGlzdGluZ3Vpc2ggdGhyb3VnaA0KPiA+ PiBDT05GSUdfQVJNX01QVQ0KPiA+Pj4gb3IgQ09ORklHX0FSTTY0X1Y4Ui4gV2Ugd2FudCBtb3N0 IG9mIHRoZSBpbml0aWFsaXphdGlvbiBjb2RlIHRvIGJlDQo+ID4+IHJldXNhYmxlDQo+ID4+PiBi ZXR3ZWVuIEFybXY4LVI2NCBhbmQgQXJtdjgtQTY0Lg0KPiA+Pj4NCj4gPj4+IC0gV2Ugd2lsbCBy ZXVzZSB0aGUgb3JpZ2luYWwgaGVhZC5zIGFuZCBzZXR1cC5jIG9mIEFybS4gQnV0IHJlcGxhY2UN Cj4gdGhlDQo+ID4+PiAgICAgTU1VIGFuZCBwYWdlIHRhYmxlIG9wZXJhdGlvbnMgaW4gdGhlc2Ug ZmlsZXMgd2l0aCBjb25maWd1cmF0aW9uDQo+ID4+IG9wZXJhdGlvbnMNCj4gPj4+ICAgICBmb3Ig TVBVIGFuZCBNUFUgcmVnaW9ucy4NCj4gPj4+DQo+ID4+PiAtIFdlIHByb3ZpZGUgYSBib290LXRp bWUgTVBVIGNvbmZpZ3VyYXRpb24uIFRoaXMgTVBVIGNvbmZpZ3VyYXRpb24NCj4gd2lsbA0KPiA+ Pj4gICAgIHN1cHBvcnQgWGVuIHRvIGZpbmlzaCBpdHMgaW5pdGlhbGl6YXRpb24uIEFuZCB0aGlz IGJvb3QtdGltZSBNUFUNCj4gPj4+ICAgICBjb25maWd1cmF0aW9uIHdpbGwgcmVjb3JkIHRoZSBt ZW1vcnkgcmVnaW9ucyB0aGF0IHdpbGwgYmUgcGFyc2VkDQo+IGZyb20NCj4gPj4+ICAgICBkZXZp Y2UgdHJlZS4NCj4gPj4+DQo+ID4+PiAgICAgSW4gdGhlIGVuZCBvZiBYZW4gaW5pdGlhbGl6YXRp b24sIHdlIHdpbGwgdXNlIGEgcnVudGltZSBNUFUNCj4gPj4gY29uZmlndXJhdGlvbg0KPiA+Pj4g ICAgIHRvIHJlcGxhY2UgYm9vdC10aW1lIE1QVSBjb25maWd1cmF0aW9uLiBUaGUgcnVudGltZSBN UFUNCj4gY29uZmlndXJhdGlvbg0KPiA+PiB3aWxsDQo+ID4+PiAgICAgbWVyZ2UgYW5kIHJlb3Jk ZXIgbWVtb3J5IHJlZ2lvbnMgdG8gc2F2ZSBtb3JlIE1QVSByZWdpb25zIGZvcg0KPiBndWVzdHMu DQo+ID4+PiAgICAgIVtpbWddKGh0dHBzOi8vZHJpdmUuZ29vZ2xlLmNvbS91Yz9leHBvcnQ9dmll dyZpZD0xd1RGeUsyWGZVM2xUbEgxDQo+IFBxUg0KPiA+PiBEb2FjUVZUd1V0V0lHVSkNCj4gPj4+ DQo+ID4+PiAtIERlZmVyIHN5c3RlbSB1bnBhdXNpbmcgZG9tYWluLg0KPiA+Pj4gICAgIFdoZW4g WGVuIGluaXRpYWxpemF0aW9uIGlzIGFib3V0IHRvIGVuZCwgWGVuIHVucGF1c2UgZ3Vlc3RzDQo+ IGNyZWF0ZWQNCj4gPj4+ICAgICBkdXJpbmcgaW5pdGlhbGl6YXRpb24uIEJ1dCB0aGlzIHdpbGwg Y2F1c2Ugc29tZSBpc3N1ZXMuIFRoZQ0KPiB1bnBhdXNlDQo+ID4+PiAgICAgYWN0aW9uIG9jY3Vy cyBiZWZvcmUgZnJlZV9pbml0X21lbW9yeSwgaG93ZXZlciB0aGUgcnVudGltZSBNUFUNCj4gPj4g Y29uZmlndXJhdGlvbg0KPiA+Pj4gICAgIGlzIGJ1aWx0IGFmdGVyIGZyZWVfaW5pdF9tZW1vcnku DQo+ID4+DQo+ID4+IEkgd2FzIGhhbGYgZXhwZWN0aW5nIHRoYXQgZnJlZV9pbml0X21lbW9yeSgp IHdvdWxkIG5vdCBiZSBjYWxsZWQgZm9yDQo+IFhlbg0KPiA+PiBBcm12OFIuDQo+ID4+DQo+ID4N Cj4gPiBXZSBoYWQgY2FsbGVkIGZyZWVfaW5pdF9tZW1vcnkgZm9yIFhlbiBBcm12OFIsIGJ1dCBp dCBkb2Vzbid0IHJlYWxseQ0KPiBtZWFuDQo+ID4gbXVjaC4gQXMgd2UgaGF2ZSBzdGF0aWMgaGVh cCwgc28gd2UgZG9uJ3QgcmVjbGFpbSBpbml0IG1lbW9yeSB0byBoZWFwLg0KPiBBbmQNCj4gPiB0 aGlzIHJlY2xhaW1lZCBtZW1vcnkgY291bGQgbm90IGJlIHVzZWQgYnkgWGVuIGRhdGEgYW5kIGJz cyBlaXRoZXIuIEJ1dA0KPiA+IGZyb20gdGhlIHNlY3VyaXR5IHBlcnNwZWN0aXZlLCBmcmVlX2lu aXRfbWVtb3J5IHdpbGwgZHJvcCB0aGUgWGVuIGluaXQNCj4gPiBjb2RlICYgZGF0YSwgdGhpcyB3 aWxsIHJlZHVjZSB0aGUgY29kZSBhbiBhdHRhY2tlciBjYW4gZXhwbG9pdC4NCj4gSUlVQywgemVy by1pbmcgdGhlIHJlZ2lvbiAob3Igc29tZXRoaW5nKSBzaW1pbGFyIHdpbGwgYmUgc3VmZmljaWVu dA0KPiBoZXJlLiBJT1csIHlvdSBkb24ndCBuZWNlc3NhcmlseSBuZWVkIHRvIHJlbW92ZSB0aGUg bWFwcGluZ3MuDQo+IA0KPiA+Pj4NCj4gPj4+ICAgICBTbyBpZiB0aGUgdW5wYXVzZWQgZ3Vlc3Rz IHN0YXJ0IGV4ZWN1dGluZyB0aGUgY29udGV4dCBzd2l0Y2ggYXQNCj4gdGhpcw0KPiA+Pj4gICAg IHBvaW50LCB0aGVuIGl0cyBNUFUgY29udGV4dCB3aWxsIGJhc2Ugb24gdGhlIGJvb3QtdGltZSBN UFUNCj4gPj4gY29uZmlndXJhdGlvbi4NCj4gPj4NCj4gPj4gQ2FuIHlvdSBleHBsYWluIHdoeSB5 b3Ugd2FudCB0byBzd2l0Y2ggdGhlIE1QVSBjb25maWd1cmF0aW9uIHRoYXQgbGF0ZT8NCj4gPj4N Cj4gPg0KPiA+IEluIHRoZSBib290IHN0YWdlLCBYZW4gaXMgdGhlIG9ubHkgdXNlciBvZiBNUFUu IEl0IG1heSBhZGQgc29tZSBtZW1vcnkNCj4gPiBub2RlcyBvciBkZXZpY2UgbWVtb3J5IHRvIE1Q VSByZWdpb25zIGZvciB0ZW1wb3JhcnkgdXNhZ2UuIEFmdGVyIGZyZWUNCj4gPiBpbml0IG1lbW9y eSwgd2Ugd2FudCB0byByZWNsYWltIHRoZXNlIE1QVSByZWdpb25zIHRvIGdpdmUgbW9yZSBNUFUN Cj4gcmVnaW9ucw0KPiA+IGNhbiBiZSB1c2VkIGZvciBndWVzdHMuIEFsc28gd2Ugd2lsbCBkbyBz b21lIG1lcmdlIGFuZCByZW9yZGVyIHdvcmsuDQo+IFRoaXMNCj4gPiB3b3JrIGNhbiBtYWtlIE1Q VSByZWdpb25zIHRvIGJlIGVhc2llciBtYW5hZ2VkIGluIGd1ZXN0IGNvbnRleHQgc3dpdGNoLg0K PiANCj4gRG8geW91IGhhdmUgYW55IGV4YW1wbGUgb2Ygc3VjaCByZWdpb25zPw0KPiA+DQo+ID4+ PiAgICAgUHJvYmFibHkgaXQgd2lsbCBiZSBpbmNvbnNpc3RlbnQgd2l0aCBydW50aW1lIE1QVSBj b25maWd1cmF0aW9uLA0KPiB0aGlzDQo+ID4+PiAgICAgd2lsbCBjYXVzZSB1bmV4cGVjdGVkIHBy b2JsZW1zIChUaGlzIG1heSBub3QgaGFwcGVuIGluIGEgc2luZ2xlDQo+IGNvcmUNCj4gPj4+ICAg ICBzeXN0ZW0sIGJ1dCBvbiBTTVAgc3lzdGVtcywgdGhpcyBwcm9ibGVtIGlzIGZvcmVzZWVhYmxl LCBzbyB3ZQ0KPiBob3BlDQo+ID4+IHRvDQo+ID4+PiAgICAgc29sdmUgaXQgYXQgdGhlIGJlZ2lu bmluZykuDQo+ID4+DQo+ID4+IFsuLi5dDQo+ID4+DQo+ID4+PiAjIyMgKioyLjQuIENoYW5nZXMg b2YgbWVtb3J5IG1hbmFnZW1lbnQqKg0KPiA+Pj4gWGVuIGlzIGNvdXBsZWQgd2l0aCBWTVNBLCBp biBvcmRlciB0byBwb3J0IFhlbiB0byBBcm12OC1SNjQsIHdlIGhhdmUNCj4gdG8NCj4gPj4+IGRl Y291cGxlIFhlbiBmcm9tIFZNU0EuIEFuZCBnaXZlIFhlbiB0aGUgYWJpbGl0eSB0byBtYW5hZ2Ug bWVtb3J5IGluDQo+ID4+IFBNU0EuDQo+ID4+Pg0KPiA+Pj4gMS4gKioqVXNlIGJ1ZGR5IGFsbG9j YXRvciB0byBtYW5hZ2UgcGh5c2ljYWwgcGFnZXMgZm9yIFBNU0EqKioNCj4gPj4+ICAgICAgRnJv bSB0aGUgdmlldyBvZiBwaHlzaWNhbCBwYWdlLCBQTVNBIGFuZCBWTVNBIGRvbid0IGhhdmUgYW55 DQo+ID4+IGRpZmZlcmVuY2UuDQo+ID4+PiAgICAgIFNvIHdlIGNhbiByZXVzZSBidWRkeSBhbGxv Y2F0b3Igb24gQXJtdjgtUjY0IHRvIG1hbmFnZSBwaHlzaWNhbA0KPiA+PiBwYWdlcy4NCj4gPj4+ ICAgICAgVGhlIGRpZmZlcmVuY2UgaXMgdGhhdCwgaW4gVk1TQSwgWGVuIHdpbGwgbWFwIGFsbG9j YXRlZCBwYWdlcyB0bw0KPiA+PiB2aXJ0dWFsDQo+ID4+PiAgICAgIGFkZHJlc3Nlcy4gQnV0IGlu IFBNU0EsIFhlbiBqdXN0IGNvbnZlcnQgdGhlIHBhZ2VzIHRvIHBoeXNpY2FsDQo+ID4+IGFkZHJl c3MuDQo+ID4+Pg0KPiA+Pj4gMi4gKioqQ2FuIG5vdCB1c2UgdmlydHVhbCBhZGRyZXNzIGZvciBt ZW1vcnkgbWFuYWdlbWVudCoqKg0KPiA+Pj4gICAgICBBcyBBcm12OC1SNjQgb25seSBoYXMgUE1T QSBpbiBFTDIsIFhlbiBsb3NlcyB0aGUgYWJpbGl0eSBvZiB1c2luZw0KPiA+PiB2aXJ0dWFsDQo+ ID4+PiAgICAgIGFkZHJlc3MgdG8gbWFuYWdlIG1lbW9yeS4gVGhpcyBicmluZ3Mgc29tZSBwcm9i bGVtcywgc29tZSB2aXJ0dWFsDQo+ID4+IGFkZHJlc3MNCj4gPj4+ICAgICAgYmFzZWQgZmVhdHVy ZXMgY291bGQgbm90IHdvcmsgd2VsbCBvbiBBcm12OC1SNjQsIGxpa2UgYEZJWE1BUGAsDQo+ID4+ IGB2bWFwL3Z1bWFwYCwNCj4gPj4+ICAgICAgYGlvcmVtYXBgIGFuZCBgYWx0ZXJuYXRpdmVgLg0K PiA+Pj4NCj4gPj4+ICAgICAgQnV0IHRoZSBmdW5jdGlvbnMgb3IgbWFjcm9zIG9mIHRoZXNlIGZl YXR1cmVzIGFyZSB1c2VkIGluIGxvdHMgb2YNCj4gPj4gY29tbW9uDQo+ID4+PiAgICAgIGNvZGUu IFNvIGl0J3Mgbm90IGdvb2QgdG8gdXNlIGAjaWZkZWYgQ09ORklHX0FSTV9NUFVgIHRvIGdhdGUN Cj4gcmVsYXRlDQo+ID4+IGNvZGUNCj4gPj4+ICAgICAgZXZlcnl3aGVyZS4gSW4gdGhpcyBjYXNl LCB3ZSBwcm9wb3NlIHRvIHVzZSBzdHViIGhlbHBlcnMgdG8gbWFrZQ0KPiB0aGUNCj4gPj4gY2hh bmdlcw0KPiA+Pj4gICAgICB0cmFuc3BhcmVudGx5IHRvIGNvbW1vbiBjb2RlLg0KPiA+Pj4gICAg ICAxLiBGb3IgYEZJWE1BUGAsIHdlIHdpbGwgdXNlIGAwYCBpbiBgRklYTUFQX0FERFJgIGZvciBh bGwgZml4bWFwDQo+ID4+IG9wZXJhdGlvbnMuDQo+ID4+PiAgICAgICAgIFRoaXMgd2lsbCByZXR1 cm4gcGh5c2ljYWwgYWRkcmVzcyBkaXJlY3RseSBvZiBmaXhtYXBwZWQgaXRlbS4NCj4gPj4+ICAg ICAgMi4gRm9yIGB2bWFwL3Z1bWFwYCwgd2Ugd2lsbCB1c2Ugc29tZSBlbXB0eSBpbmxpbmUgc3R1 YiBoZWxwZXJzOg0KPiA+Pj4gICAgICAgICAgIGBgYA0KPiA+Pj4gICAgICAgICAgIHN0YXRpYyBp bmxpbmUgdm9pZCB2bV9pbml0X3R5cGUoLi4uKSB7fQ0KPiA+Pj4gICAgICAgICAgIHN0YXRpYyBp bmxpbmUgdm9pZCAqX192bWFwKC4uLikNCj4gPj4+ICAgICAgICAgICB7DQo+ID4+PiAgICAgICAg ICAgICAgIHJldHVybiBOVUxMOw0KPiA+Pj4gICAgICAgICAgIH0NCj4gPj4+ICAgICAgICAgICBz dGF0aWMgaW5saW5lIHZvaWQgdnVubWFwKGNvbnN0IHZvaWQgKnZhKSB7fQ0KPiA+Pj4gICAgICAg ICAgIHN0YXRpYyBpbmxpbmUgdm9pZCAqdm1hbGxvYyhzaXplX3Qgc2l6ZSkNCj4gPj4+ICAgICAg ICAgICB7DQo+ID4+PiAgICAgICAgICAgICAgIHJldHVybiBOVUxMOw0KPiA+Pj4gICAgICAgICAg IH0NCj4gPj4+ICAgICAgICAgICBzdGF0aWMgaW5saW5lIHZvaWQgKnZtYWxsb2NfeGVuKHNpemVf dCBzaXplKQ0KPiA+Pj4gICAgICAgICAgIHsNCj4gPj4+ICAgICAgICAgICAgICAgcmV0dXJuIE5V TEw7DQo+ID4+PiAgICAgICAgICAgfQ0KPiA+Pj4gICAgICAgICAgIHN0YXRpYyBpbmxpbmUgdm9p ZCB2ZnJlZSh2b2lkICp2YSkge30NCj4gPj4+ICAgICAgICAgICBgYGANCj4gPj4+DQo+ID4+PiAg ICAgIDMuIEZvciBgaW9yZW1hcGAsIGl0IGRlcGVuZHMgb24gYHZtYXBgLiBBcyB3ZSBoYXZlIG1h a2UgYHZtYXBgIHRvDQo+ID4+IGFsd2F5cw0KPiA+Pj4gICAgICAgICByZXR1cm4gYE5VTExgLCB0 aGV5IGNvdWxkIG5vdCB3b3JrIHdlbGwgb24gQXJtdjgtUjY0IHdpdGhvdXQNCj4gPj4gY2hhbmdl cy4NCj4gPj4+ICAgICAgICAgYGlvcmVtYXBgIHdpbGwgcmV0dXJuIGlucHV0IGFkZHJlc3MgZGly ZWN0bHkuDQo+ID4+PiAgICAgICAgICAgYGBgDQo+ID4+PiAgICAgICAgICAgc3RhdGljIGlubGlu ZSB2b2lkICppb3JlbWFwX2F0dHIoLi4uKQ0KPiA+Pj4gICAgICAgICAgIHsNCj4gPj4+ICAgICAg ICAgICAgICAgLyogV2UgZG9uJ3QgaGF2ZSB0aGUgYWJpbGl0eSB0byBjaGFuZ2UgaW5wdXQgUEEg Y2FjaGUNCj4gPj4gYXR0cmlidXRlcyAqLw0KPiA+PiBPT0ksIHdobyB3aWxsIHNldCB0aGVtPw0K PiA+DQo+ID4gU29tZSBjYWxsZXJzIHRoYXQgd2FudCB0byBjaGFuZ2UgYSBtZW1vcnkncyBhdHRy aWJ1dGUgd2lsbCBzZXQgdGhlbS4NCj4gU29tZXRoaW5nIGxpa2UNCj4gPiBpb3JlbWFwX25vY2Fj aGUuIEkgYW0gbm90IHN1cmUgaXMgdGhpcyB3aGF0IHlvdSBoYWQgYXNrZWQgOiApDQo+IA0KPiBJ IGFtIGEgYml0IGNvbmZ1c2VkLiBJZiBpb3JlbWFwX25vY2FjaGUoKSBjYW4gY2hhbmdlIHRoZSBh dHRyaWJ1dGUsIHRoZW4NCj4gd2h5IHdvdWxkIGlvcmVtYXBfYXR0cigpIG5vdCBiZSBhYmxlIHRv IGRvIGl0Pw0KPiANCg0KTU1VIGJhc2VkIGlvcmVwbWFwX3h4eHggY2FuIHVzZSBhIG5ldyBWQSBh bmQgbmV3IFBURSB0byBkbyB0aGlzLiBCdXQgZm9yDQpNUFUsIHdlIGNhbid0IGRvIGl0LCBleGNl cHQgeW91IGNoYW5nZSB0aGUgd2hvbGUgTVBVIHJlZ2lvbidzIGF0dHJpYnV0ZS4NClRoZSByZWFz b25zIGFyZToNCjEuIEZvciBWOFIgUE1TQSwgb25lIHBoeXNpY2FsIGFkZHJlc3Mgb25seSBiZSBl eGlzdGVkIG9uZSBNUFUgcmVnaW9uLg0KMi4gVGhlcmUncyBub3QgZW5vdWdoIE1QVSByZWdpb25z IGZvciB1cyB0byBzcGxpdCBvbmUgTVBVIHJlZ2lvbiB0bw0KICAgbXVsdGlwbGUgTVBVIHJlZ2lv bnMgKGNoYW5nZWQgcGFnZXMgcmVnaW9uIGFuZCB1bm1vZGlmaWVkIHBhZ2VzIHJlZ2lvbnMpLg0K DQo+ID4NCj4gPj4NCj4gPj4+ICAgICAgICAgICAgICAgaWYgKCBDQUNIRV9BVFRSX25lZWRfY2hh bmdlICkNCj4gPj4+ICAgICAgICAgICAgICAgICAgIHJldHVybiBOVUxMOw0KPiA+Pj4gICAgICAg ICAgICAgICByZXR1cm4gKHZvaWQgKilwYTsNCj4gPj4+ICAgICAgICAgICB9DQo+ID4+PiAgICAg ICAgICAgc3RhdGljIGlubGluZSB2b2lkIF9faW9tZW0gKmlvcmVtYXBfbm9jYWNoZSguLi4pDQo+ ID4+PiAgICAgICAgICAgew0KPiA+Pj4gICAgICAgICAgICAgICByZXR1cm4gaW9yZW1hcF9hdHRy KHN0YXJ0LCBsZW4sIFBBR0VfSFlQRVJWSVNPUl9OT0NBQ0hFKTsNCj4gPj4+ICAgICAgICAgICB9 DQo+ID4+PiAgICAgICAgICAgc3RhdGljIGlubGluZSB2b2lkIF9faW9tZW0gKmlvcmVtYXBfY2Fj aGUoLi4uKQ0KPiA+Pj4gICAgICAgICAgIHsNCj4gPj4+ICAgICAgICAgICAgICAgcmV0dXJuIGlv cmVtYXBfYXR0cihzdGFydCwgbGVuLCBQQUdFX0hZUEVSVklTT1IpOw0KPiA+Pj4gICAgICAgICAg IH0NCj4gPj4+ICAgICAgICAgICBzdGF0aWMgaW5saW5lIHZvaWQgX19pb21lbSAqaW9yZW1hcF93 YyguLi4pDQo+ID4+PiAgICAgICAgICAgew0KPiA+Pj4gICAgICAgICAgICAgICByZXR1cm4gaW9y ZW1hcF9hdHRyKHN0YXJ0LCBsZW4sIFBBR0VfSFlQRVJWSVNPUl9XQyk7DQo+ID4+PiAgICAgICAg ICAgfQ0KPiA+Pj4gICAgICAgICAgIHZvaWQgKmlvcmVtYXAoLi4uKQ0KPiA+Pj4gICAgICAgICAg IHsNCj4gPj4+ICAgICAgICAgICAgICAgcmV0dXJuIGlvcmVtYXBfYXR0cihwYSwgbGVuLCBQQUdF X0hZUEVSVklTT1JfTk9DQUNIRSk7DQo+ID4+PiAgICAgICAgICAgfQ0KPiA+Pj4NCj4gPj4+ICAg ICAgICAgICBgYGANCj4gPj4+ICAgICAgIDQuIEZvciBgYWx0ZXJuYXRpdmVgLCBpdCBkZXBlbmRz IG9uIGB2bWFwYCB0b28uDQo+ID4+DQo+ID4+IFRoZSBvbmx5IHJlYXNvbiB3ZSBkZXBlbmQgb24g dm1hcCgpIGlzIGJlY2F1c2UgdGhlIG1hcCB0aGUgc2VjdGlvbnMNCj4gPj4gKnRleHQgcmVhZC1v bmx5IGFuZCB3ZSBlbmZvcmNlIFduWC4gRm9yIFZNU0EsIGl0IHdvdWxkIGJlIHBvc3NpYmxlIHRv DQo+ID4+IGF2b2lkIHZtYXAoKSB3aXRoIHNvbWUgcmV3b3JrLiBJIGRvbid0IGtub3cgZm9yIFBN U0EuDQo+ID4+DQo+ID4NCj4gPiBGb3IgUE1TQSwgd2Ugc3RpbGwgZW5mb3JjZSBXblguIEZvciB5 b3VyIHVzZSBjYXNlLCBJIGFzc3VtZSBpdCdzDQo+IGFsdGVybmF0aXZlLg0KPiA+IEl0IHN0aWxs IG1heSBoYXZlIHNvbWUgcG9zc2liaWxpdHkgdG8gYXZvaWQgdm1hcCgpLiBCdXQgdGhlcmUgbWF5 IGJlDQo+IHNvbWUNCj4gPiBzZWN1cml0eSBpc3N1ZXMuIFdlIGhhZCB0aG91Z2h0IHRvIGRpc2Fi bGUgTVBVIC0+IHVwZGF0ZSB4ZW4gdGV4dCAtPg0KPiBlbmFibGUNCj4gPiBNUFUgdG8gY29weSBW TVNBIGFsdGVybmF0aXZlJ3MgYmVoYXZpb3IuIFRoZSBwcm9ibGVtIHdpdGggdGhpcywgaG93ZXZl ciwNCj4gPiBpcyB0aGF0IGF0IHNvbWUgcG9pbnQsIGFsbCBtZW1vcnkgaXMgUldYLiBUaGVyZSBt YXliZSBzb21lIHNlY3VyaXR5DQo+IHJpc2suID4gQnV0IGJlY2F1c2UgaXQncyBpbiBpbml0IHN0 YWdlLCBpdCBwcm9iYWJseSBkb2Vzbid0IG1hdHRlciBhcyBtdWNoDQo+IGFzDQo+IEkgdGhvdWdo dC4NCj4gDQo+IEZvciBib290IGNvZGUsIHdlIG5lZWQgdG8gZW5zdXJlIHRoZSBjb2RlIGlzIGNv bXBsaWFudCB0byB0aGUgQXJtIEFybS4NCj4gT3RoZXIgdGhhbiB0aGF0LCBpdCBpcyBPSyB0byBo YXZlIHRoZSBtZW1vcnkgUldYIGZvciBhIHNob3J0IHBlcmlvZCBvZg0KPiB0aW1lLg0KPiANCj4g SW4gZmFjdCwgd2hlbiB3ZSBvcmlnaW5hbGx5IGJvb3QgWGVuLCB3ZSBkb24ndCBlbmZvcmNlIFdu WC4gV2Ugd2lsbA0KPiBzdGFydCB0byBlbmZvcmNlIHdoZW4gaW5pdGlhbGl6aW5nIHRoZSBtZW1v cnkuIEJ1dCB0aGVyZSBhcmUgbm8gYmxvY2tlcg0KPiB0byBkZWxheSBpdCAob3RoZXIgdGhhbiB3 cml0aW5nIHRoZSBjb2RlIDopKS4NCg0KQWgsIG9rLCBpdCBzZWVtcyB3ZSBzdGlsbCBjYW4gaW1w bGVtZW50IGFsdGVybmF0aXZlIG9uIE1QVSBzeXN0ZW0uDQpJIHdpbGwgdXBkYXRlIGl0IGluIG5l dyB2ZXJzaW9uIHByb3Bvc2FsLCBidXQgcGxhY2UgaXQgaW4gVE9ETywgSSBkb24ndA0Kd2FudCB0 byBpbmNsdWRlIGl0IGJlZm9yZSBzaW5nbGUgQ1BVIHN1cHBvcnQgYmUgbWVyZ2VkLiBCZWNhdXNl IGN1cnJlbnQNCnBhdGNoIHNlcmllcyBpcyBodWdlIGVub3VnaCA6ICkNCg0KPiANCj4gQ2hlZXJz LA0KPiANCj4gLS0NCj4gSnVsaWVuIEdyYWxsDQo= From xen-devel-bounces@lists.xenproject.org Thu Mar 03 02:11:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Mar 2022 02:11:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282688.481486 (Exim 4.92) (envelope-from ) id 1nPawb-0007gb-7U; Thu, 03 Mar 2022 02:11:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282688.481486; Thu, 03 Mar 2022 02:11:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPawb-0007gU-4Z; Thu, 03 Mar 2022 02:11:53 +0000 Received: by outflank-mailman (input) for mailman id 282688; Thu, 03 Mar 2022 02:11:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPawZ-0007gO-Jw for xen-devel@lists.xenproject.org; Thu, 03 Mar 2022 02:11:51 +0000 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 47f312d1-9a97-11ec-8eba-a37418f5ba1a; Thu, 03 Mar 2022 03:11:49 +0100 (CET) Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 222LxL1H013834; Thu, 3 Mar 2022 02:11:33 GMT Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by mx0b-00069f02.pphosted.com with ESMTP id 3eh1k47jgu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 03 Mar 2022 02:11:33 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 2231jMFU057160; Thu, 3 Mar 2022 02:11:32 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2043.outbound.protection.outlook.com [104.47.66.43]) by aserp3030.oracle.com with ESMTP id 3efa8h5mmv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 03 Mar 2022 02:11:32 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) by MN2PR10MB3360.namprd10.prod.outlook.com (2603:10b6:208:130::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.26; Thu, 3 Mar 2022 02:11:29 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::6d20:6694:a16:56f7]) by BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::6d20:6694:a16:56f7%3]) with mapi id 15.20.5038.015; Thu, 3 Mar 2022 02:11:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 47f312d1-9a97-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=7Cp9J//bQQUjc+F/H7wFhBgQLPh2oU3W65xAyFcURaU=; b=Tu3/mKpao5BDA9dIpCyC/haDg0nMNtXb21F0b59geZeEQRmzKlJfpE0pSy+uimAyzpz3 qB48g9p03/2Tc7oyfD5ZMYhe/T+poQjlPsb/oGoI7uQB/9KfhJ7B9HeJYX9etn4rI0y4 NLzTpqVSqhNOTHrWyW5vwBgF3pMtIecDxWa/2ipFeI9fK0oUsSeCmcUqUrgJbDyKZG31 mb5D4UMeb7IGSm9OWhR3YCUszufQ3Qeu5+AQ1sBoXz0q7CQaewQjPneBjcvzmP1enF45 3qlFfJKbZVKbM3jZTGHeFmkqq55ahhH+pYd8TEmEUM5RAtuso2bp5TACrlAE0XbnkVDv Ng== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kE0kR4lmsVCKea8ALDlasw9bh7yJ+1TVg2rKUt8AUKGpfCQPROSU/85PPyeXFnUymcQT1+xoj/3vNgmfwUwh8RshEW0zXcClxcKUmljA3u2/ai+NMcuqt1o5CNteh7OO4XKCOFXgGoN3LVtwfs3tALC0u3Iny4MwY0ieCggz7ibJYQ4NeLnV5NVxL0rcWUeaWMBm++SwI+DAtUENIW62D2CscunPZW5yhEHWP0IRxS2J25N9qP/IY7OEbI+Oeii0dSk162tPhzpk4JJKUTD3KFg4qPj5vBOieK92rACS80ufgFAp8pFfzr4Qb4TGNIyYQlWr76dasJHKBfQxXyoLaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7Cp9J//bQQUjc+F/H7wFhBgQLPh2oU3W65xAyFcURaU=; b=EePiwM2cYi467hhCc4Tr3739HmniYUrYerZO4b+iUQO8s2SVyYnANS3GUMxcHDpeDxDMC4gTttD9e7ybK1X35iZlHUHbUyRaBvcbz/Bq/yD3TJHf7kfcYrVLk7dJgGFWx0g9mWYuC5H4gSGcr696ucOtseDsxMfCa54APcEROLtjhbbVEjJgG+UbRCDE+FIJRX3BLWaEgPLfVITkJTWq6ZjW8NJ7nMA+dnGTrXpUsxs7v8/6lwCM76N1+yzKI5wWVBqVJK4DOJKoOPzjoBHcpACKIewo2FNXn13kWeESlWeJ92C7DW3ISGDs/X2pWQdLKlXT99MlLB5GilKyqZfP4g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7Cp9J//bQQUjc+F/H7wFhBgQLPh2oU3W65xAyFcURaU=; b=OlNZsbifN9GNqFbo7IqmM62ZmkIZdyuQfbAfIT3zjfRs9nfaTwpO+0i1T+g/OF6c82xpBZ51g9TQIlBQv4ZW9vFbj3Fansw60a+QJv6Hn7K9tliFjPXtNUBWqvYFW90pz4utkbyMIUENjqqR1DN4yxzeChmku/Xn1ivdM9om7Ww= Message-ID: <272a69ec-4cc8-f282-8499-88b24b61f130@oracle.com> Date: Wed, 2 Mar 2022 21:11:24 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH v4 2/2] xen: delay xen_hvm_init_time_ops() if kdump is boot on vcpu>=32 Content-Language: en-US To: Dongli Zhang , xen-devel@lists.xenproject.org, x86@kernel.org Cc: linux-kernel@vger.kernel.org, jgross@suse.com, sstabellini@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, joe.jin@oracle.com References: <20220302164032.14569-1-dongli.zhang@oracle.com> <20220302164032.14569-3-dongli.zhang@oracle.com> <0ac50fb6-0aca-e61a-1f38-8badbc8c967a@oracle.com> From: Boris Ostrovsky In-Reply-To: <0ac50fb6-0aca-e61a-1f38-8badbc8c967a@oracle.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: BYAPR05CA0106.namprd05.prod.outlook.com (2603:10b6:a03:e0::47) To BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 77bca3cd-1fc9-401d-842f-08d9fcbb2124 X-MS-TrafficTypeDiagnostic: MN2PR10MB3360:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bpxySLVN1oHHz8FMWcZnnC6iJZ/ONFFLBYUcbPT/sBgc2MTTdRvTa+tzXITym/9Che9mNBgChLyNuAbacAAH7NAKlCpHcNP3vWN7PognlTldO1Zo/kwJVSmab30BiQOdS6AgF86NIEa+LLzeuMwd3rcIuGSUhRRgkXXg8tRLLqXTbnn0JqX0z3a2x6XlDGAPxZ6RxckDqZnsqr1QzyJLR+ZMHDrQDiOfTLPDzrtds/9/nBXZ42ToPw8S6cdFLXIB1dooxA0EKDecjWhkmw0JRdJa++k8ls9TJ1Xrdiogq6CIwcZUGh/9GOB3qNYDEubLFm7ItHzcWdWxS1L6pmtW96Txvuab2iAOWR1QCAWOKX4bZdFEeXfIPYZmi7JaUnBNeZoaCFkJxfpjkGbbymsACpcxaF3aERQW692rpOOHJYMfaMK1+HfiwpsoxQeVKDyYsmho11s58GacpfM03ntps3O1B+UywTKo/i262/nmfmtbToxpMVEguMcbRpNVs0TXH7AEc1yBEez8dTS68itaNe5OeKxhAePdCcp7jNbwE7pM92u4bjB1O3b9f0BDNP6XrKveBNqSTJcTrCpxq3fPJBumvFmNU5lRCRh/u374g/uMA2w4w1kO7rU/tuhUPbDJJI/XDpVFNEeXPyMhioJAx5G5NPBVGQaCojZ1hF7W8qp0YbfBDut9QyfR+CHTW2yktWKTD25NujSxV177bdebCciFXiB1AgZvaoqmrxypSXHB385kK2ChiSbIwfEtbWQ4 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6486002)(6666004)(38100700002)(36756003)(6506007)(6512007)(31686004)(4326008)(508600001)(83380400001)(53546011)(44832011)(316002)(8936002)(86362001)(5660300002)(2616005)(107886003)(2906002)(26005)(66946007)(186003)(66556008)(66476007)(31696002)(8676002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YWdhcUVjU2k1c2pvWHp5bjJoRklMUCs0Ni9JQmVGS2tWT2NGV3NlbnhjT1RE?= =?utf-8?B?SG5wVEIxTkRRc1MwMlhXVHBYUWdYdnRCUkM0VmtjeEF2ZzRUc2szYTFGM3ht?= =?utf-8?B?ZWRWRW8xRTZZMDJIdGdwRnhtN1BqMHpDMzFmN01yNFNPZ0htYnZqM3M1WnRh?= =?utf-8?B?RkdoYmYvdnpON0J3WStDUEhFYWJ2U2pYRTF6dWh6MndQcnVYRGtLSzRJZDhk?= =?utf-8?B?QXR3MzhtZnY1M3FBR3lKdGEzQ0pZV1Jkc0dGS1lGdW13TzFGNzFBVkl5WXl0?= =?utf-8?B?WnBzY3E0eS8zV0JlTnNmYjZQQlN3OW1RYW15QU9Ubmd3ZE5xZDNyWndTeEdV?= =?utf-8?B?LzEydGZCQVVzcyticlJ1Q0tkemxBSlBrcWNEQys5bncvZ2hDL3YrTU5JMTlG?= =?utf-8?B?Ris3aHA0OTd2V0JCZG5zc3dDNlJZQ0pRVWVOVlQ1WnNBRmdNVHlsV3FOMmJr?= =?utf-8?B?V29rKy9Qd2FSSG9ZZ0RHTXIyNHlTeUkweW83aGp6eUt6NjBCZ1E1ZUFDYjll?= =?utf-8?B?RG5PNGtoMWJmVHp2TTV0Wmc4SGp4eTJEakc1VFdlWUswN0pUWWxEejJZazBr?= =?utf-8?B?aC9UNnBSc2dFTjVld2l0OWRNQXNCSmd1YnNCMWVHanJuYXpKUkRObkcwWStv?= =?utf-8?B?a1FmT09oOGtPYWZubjZyZGd1SDQ2THRkMWszZStSajNuWWNYYjlTRTVVUTI4?= =?utf-8?B?dGVVZVJmUzZFQ1JxQTZqcG5Hb2UvWFdGb2dWTEFBRXVEVnZvaHB6UTllMnhx?= =?utf-8?B?RTYvc0FsMzc0OU5KUnQxcDFhUW9pMXpKVm1PeEYrN05LQnFVOFRTU0JvOGxC?= =?utf-8?B?ZmRMalFGMXIxRFUzanN1TTZBSnBpTUJjbGowOHpzZnB0ZnFLSGlmeEs4cVp1?= =?utf-8?B?WkFMaXdZR1VhV0hDdTAyT29Va0YwTkpHc3FIY0t4RVZLenA5Z0ZKVERhZ1dq?= =?utf-8?B?V2UvNVBlYWl0UlVnbVVLNStyWkVvck5GQUV3dHJUTGt1Yms0TEh6aGZRVlor?= =?utf-8?B?MnNRS3B6bzVCZ1o2ZGdVYlBCdzBkUk4xSEEwQ3VnU08yU0pDb2JrUmNGVU5M?= =?utf-8?B?MVVadkFGcldaR25aaEJnMzAvMjhUTFBOQ09PYnA2bzB3UWNZKy96R2FGeVpq?= =?utf-8?B?MTRrcEdsWGNzeEJtWllGUUl0V0xuZ3lFYUJGd3J1L3gzOGthNVBpWHhYZm02?= =?utf-8?B?Q1BoR2N1WWsweFc5T1NVek0yMWFpSHpKL2l3RFBxRE52ZWZkMFY4YjdsYjUw?= =?utf-8?B?TGJDMnB0M3cxQi9CQ0lneWJHdlo0ZjFlSDAzU1BhY210c1F5MTN6QVhyYjky?= =?utf-8?B?Sk9pcE4rM3FOcmZpSEdqejk1NUFXYUszS2t4SFRKN2xwbHdzNHlWSzRoMlV3?= =?utf-8?B?dUFpbFE3ckhrQ1VsL01oNVdlMXNtUWViSWJVVzNzTWZnWmdYN2VKRU0wQVBs?= =?utf-8?B?VUFnZHc0bHh6Z0tMUDJSRjhvckUwTjQ1Q1FhVHpVQ0Z5QTRVcnMzS040d3Vq?= =?utf-8?B?WXdTZlR4UVpOSUNtOHlBWGdLUTdBRitaSEx4WXNSbWNLblZncUJ2bmhpcFAw?= =?utf-8?B?WHF4blluNjRZOU1Xa1RNSlEzTThncGQzek1EeERhWkF5RUg1WUE1YTRZVGp6?= =?utf-8?B?RGVreWwyTGIwUjdsam5XM1pmZkY3eG55d3hBZnVpejFwYXV3WEJIbm9zWWJP?= =?utf-8?B?dHdZM0IrM1VSNWlONWplR1NSU3MxNHltUFpvU0RFc2F1L1dzWHo0V1JWWXFO?= =?utf-8?B?TmJVYUtVYjRTMlB5WkVzZlQ0bytTYmhxa3VGREJ1MlE5OWVFVGVwZ1dUZ0lk?= =?utf-8?B?TzVzbVZqN0d1MXVQWmxOZ1p0cVJjdXBkczlhRm9zd2l1c0MyMmllZm4xN2RL?= =?utf-8?B?WkFmYWhCZ29jRVd1eS80cXljeERzMzlSUGxlRksyQU90emFkRnBOL2tudTJU?= =?utf-8?B?SzIzaEdSMnVURG5lL2IvV25VMW5qVGRLTmVsTDNrYXR4NmcvdGVtNTVoZC80?= =?utf-8?B?bVRyRWFvQnpZZk82amsrd2VnU3ZIUFdQUjZkOW93UjZselpnZmcrTlQxSWU0?= =?utf-8?B?YzFZUmtXbkgzVUZHZUtXZ0hxOHF0MzZnRzByK3JMYU5kalRLMm1qNmVNeitY?= =?utf-8?B?a1A3dHRNWWx1ZmFaNCtIL0pyUEVObXpwUnMrZ3RlUTRLK3ZaQ3VlR01KYnlu?= =?utf-8?B?VmVmbmQzNDNGd3BrVytpaVIrM0FrdU5hOWRES3ZiY0djL0YvT282d2cyOW8z?= =?utf-8?Q?3syYcK7kTc2R05D0bAp+fFSqYBOLw87GV/PDt1rOZc=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 77bca3cd-1fc9-401d-842f-08d9fcbb2124 X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2022 02:11:29.6492 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: U0rI+WAK6xuLOk0GDXL9fWju2Y7G1Ur7TCVRYgCYWv0xvrobka8FDblNFf5QYMtVeD4M8beVJC602mJZCCcuBfQp7LLpbf3JnTYl6Pa96EY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB3360 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10274 signatures=686787 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 bulkscore=0 phishscore=0 malwarescore=0 mlxscore=0 suspectscore=0 spamscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000 definitions=main-2203030007 X-Proofpoint-ORIG-GUID: DttzqhjGrek8svkoc2W8lyuqerD0Kmc1 X-Proofpoint-GUID: DttzqhjGrek8svkoc2W8lyuqerD0Kmc1 On 3/2/22 7:31 PM, Dongli Zhang wrote: > Hi Boris, > > On 3/2/22 4:20 PM, Boris Ostrovsky wrote: >> On 3/2/22 11:40 AM, Dongli Zhang wrote: >>>   void __init xen_hvm_init_time_ops(void) >>>   { >>> +    static bool hvm_time_initialized; >>> + >>> +    if (hvm_time_initialized) >>> +        return; >>> + >>>       /* >>>        * vector callback is needed otherwise we cannot receive interrupts >>>        * on cpu > 0 and at this point we don't know how many cpus are >>>        * available. >>>        */ >>>       if (!xen_have_vector_callback) >>> -        return; >>> +        goto exit; >> >> Why not just return? Do we expect the value of xen_have_vector_callback to change? > I just want to keep above sync with .... > >> >> -boris >> >> >>>         if (!xen_feature(XENFEAT_hvm_safe_pvclock)) { >>>           pr_info("Xen doesn't support pvclock on HVM, disable pv timer"); >>> +        goto exit; >>> +    } > ... here. > > That is, I want the main logic of xen_hvm_init_time_ops() to run for at most > once. Both of above two if statements will "go to exit". I didn't notice this actually. I think both of them should return early, there is no reason to set hvm_time_initialized to true when, in fact, we have not initialized anything. And to avoid printing the warning twice we can just replace it with pr_info_once(). I can fix it up when committing so no need to resend. So unless you disagree Reviewed-by: Boris Ostrovsky > Thank you very much! > > Dongli Zhang > >>> + >>> +    /* >>> +     * Only MAX_VIRT_CPUS 'vcpu_info' are embedded inside 'shared_info'. >>> +     * The __this_cpu_read(xen_vcpu) is still NULL when Xen HVM guest >>> +     * boots on vcpu >= MAX_VIRT_CPUS (e.g., kexec), To access >>> +     * __this_cpu_read(xen_vcpu) via xen_clocksource_read() will panic. >>> +     * >>> +     * The xen_hvm_init_time_ops() should be called again later after >>> +     * __this_cpu_read(xen_vcpu) is available. >>> +     */ >>> +    if (!__this_cpu_read(xen_vcpu)) { >>> +        pr_info("Delay xen_init_time_common() as kernel is running on >>> vcpu=%d\n", >>> +            xen_vcpu_nr(0)); >>>           return; >>>       } >>>   @@ -577,6 +597,9 @@ void __init xen_hvm_init_time_ops(void) >>>       x86_cpuinit.setup_percpu_clockev = xen_hvm_setup_cpu_clockevents; >>>         x86_platform.set_wallclock = xen_set_wallclock; >>> + >>> +exit: >>> +    hvm_time_initialized = true; >>>   } >>>   #endif >>> From xen-devel-bounces@lists.xenproject.org Thu Mar 03 02:12:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Mar 2022 02:12:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282694.481498 (Exim 4.92) (envelope-from ) id 1nPaxU-0008Ek-I9; Thu, 03 Mar 2022 02:12:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282694.481498; Thu, 03 Mar 2022 02:12:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPaxU-0008Ed-Eh; Thu, 03 Mar 2022 02:12:48 +0000 Received: by outflank-mailman (input) for mailman id 282694; Thu, 03 Mar 2022 02:12:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPaxT-0008EP-ES for xen-devel@lists.xenproject.org; Thu, 03 Mar 2022 02:12:47 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-ve1eur03on062d.outbound.protection.outlook.com [2a01:111:f400:fe09::62d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 69bdf03b-9a97-11ec-8eba-a37418f5ba1a; Thu, 03 Mar 2022 03:12:45 +0100 (CET) Received: from AM6P193CA0128.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:85::33) by VI1PR08MB2799.eurprd08.prod.outlook.com (2603:10a6:802:19::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.14; Thu, 3 Mar 2022 02:12:30 +0000 Received: from VE1EUR03FT023.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:85:cafe::11) by AM6P193CA0128.outlook.office365.com (2603:10a6:209:85::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.14 via Frontend Transport; Thu, 3 Mar 2022 02:12:30 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT023.mail.protection.outlook.com (10.152.18.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22 via Frontend Transport; Thu, 3 Mar 2022 02:12:29 +0000 Received: ("Tessian outbound 1f399c739551:v113"); Thu, 03 Mar 2022 02:12:28 +0000 Received: from ec8e0ad5cd7e.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 25B6611A-C7F6-4CAE-8669-1212A4B22BB3.1; Thu, 03 Mar 2022 02:12:22 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ec8e0ad5cd7e.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 03 Mar 2022 02:12:22 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by DB9PR08MB7006.eurprd08.prod.outlook.com (2603:10a6:10:2c7::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.14; Thu, 3 Mar 2022 02:12:20 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::89b3:80a2:2b58:f1aa]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::89b3:80a2:2b58:f1aa%4]) with mapi id 15.20.5038.014; Thu, 3 Mar 2022 02:12:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 69bdf03b-9a97-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uIf3DprJ7pAAnylsAjvRp7di/U2IiOMoLYRiDUKBxMY=; b=1ZMe/umpJEF1CsIDC8gfEiP0kilfxGmjTY4l+gKHbPozGhUuqos7K8GCFZ09TYcarkJl/fPkaZEVdkw8gSv3pkIAO8sLbb2FGCT2DNMFPOUyrcSoaiR5MsWrn8iKegKGS5MZy01EfUM+zA/ynQmVo4CoAGPGYe9t1lhj8p6Cg2w= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FXAUcx0KwgHqps/OaslhDqJtkH0QtHIsDwUrao3sk97kiBTkY+Q/EQh516QzmXlWXibGfHf5hkqrM5EHC0QvlNVqlqaG4SI3jx9g72pC/myN40r0xm8xpbbEDQ8/u5bOH2DwmBMEg6Jnr83vgRM7nKy1ajfHe9eZGFysT1hdogL31Oo4HFEnxVssSxlXYaTUVqapb0F+fk9XzclzwIii1uKd8aNsdMOxysdxxfoR7EacaoDCMjzajrwkbwopUrMB0v5XRqd9bI3RUemjRWAr91nj0na9KnKj65gLN/AWIRGa+ZOYb5WXu7YKCQiwLu4V3z730SrTwK+WjsEiFN5nPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uIf3DprJ7pAAnylsAjvRp7di/U2IiOMoLYRiDUKBxMY=; b=W/n5InJzJAaGsevCicPdmCOaiOy9huhz5KOSsie9YG84FW74BfOff5tA708PBl87AWei5lfAkQeiAlpizKc59OxyFPg7tiXJSsgH7M9/b+gzCfFed9ygf+DhoZl5My9QVDr9SOyCYqPrYK/1W57s0gbAds+xC5hg+aGjKUS3pDAhL+YlfHNuuaabsNosZ1fEaKJDZcoKIcTg0+ak3/x1OEuIUegHmLdIbEjCRF6WZrMR4plSxQzrpLhCwnX1F/xV0GK5uwzzhGxAfHAPAqUd4kANMiRm1kpX2iN8EuEXBmp80ZoCEiQ+GZqKKd/06WUgKLvjRMYzlaxKdgEzidm7zw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uIf3DprJ7pAAnylsAjvRp7di/U2IiOMoLYRiDUKBxMY=; b=1ZMe/umpJEF1CsIDC8gfEiP0kilfxGmjTY4l+gKHbPozGhUuqos7K8GCFZ09TYcarkJl/fPkaZEVdkw8gSv3pkIAO8sLbb2FGCT2DNMFPOUyrcSoaiR5MsWrn8iKegKGS5MZy01EfUM+zA/ynQmVo4CoAGPGYe9t1lhj8p6Cg2w= From: Wei Chen To: Stefano Stabellini CC: "xen-devel@lists.xenproject.org" , "julien@xen.org" , Bertrand Marquis , Penny Zheng , Henry Wang , nd , "George.Dunlap@citrix.com" Subject: RE: Proposal for Porting Xen to Armv8-R64 - DraftA Thread-Topic: Proposal for Porting Xen to Armv8-R64 - DraftA Thread-Index: AdgpQxtXwh7LkfydTgiYk9bhMgU+ogAn0mUAABEK2UAAHxozAACs/mTQABukuQAADud+gAAh4EYAAARjx9AAAiyhgAAAI+eQ Date: Thu, 3 Mar 2022 02:12:19 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: B81200423215694F95CEC5FA6F335A6A.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 06bff5a4-147d-46e6-400e-08d9fcbb44bc x-ms-traffictypediagnostic: DB9PR08MB7006:EE_|VE1EUR03FT023:EE_|VI1PR08MB2799:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: A8qWI6crxEKmM9mHMMxo+NH+vtOVJKMkliQ9wJSMGfu8iAUUPHtNtFQhoO+k8m7pDLq/njh7H+Re3NsBnm5KZOitdif8VLpW2xh8XNPk6xFTlMYau5j93UuK9p6UBSDv+uneRDE+P9jVS69jbG1ceU878vDJ0JnJOnqs68/apwxG6Kr+pQetJr/1VMFFaCVj9J6J67WlmP4ioduLUk4R8O0/5Fq7aCD91f7XDz0S46oOuOQ8YDV+3EF3ZyKlc7M/wSV5L+nNAOqBMcHMTvpLcwyn5PrsMqNHsp2Q2xWrFoSrtg+HVfhj1qI0pyeCT0YetIrGftTkFgyfACayhMp9VpUAzgunhES4pZ9JAD8W6TdEIrBlZBuOQqXi9D7sZvqRBMFu1Aq5Do8qDM/xrImKzijvWeW5zLLNIOcVvB/Jr1iQK9/ig+zaZKDLOCDdcl2Xnh4tgI8bFmvYd3BXEIUnGECyUj02q9etK5hIFY5wSCMMgcF56iEUSBi4Hv0QJAocVkIsziCqBzXIDw9fiOosiVrfeA6VhQ/LQlNpUYfv8EZXiAXKqXVKd+zKyrX5tx28Z3XB22FPGTTlmJOkirKOEMpJ2tplSoG/qpVSXeTTfQUGvZmoWyQzIxhjM/x0DseBrzg7z5nfVoB1CDYfp/xL27RXIUaVxWzsHi3AEJ2oEbJQl+YmnnfGvrBEACc74I+y2AFryGvAIsXnbYQB7DOesdbeyBQPsqWtxZDro3ox+y4ldmdHgPrh3QKGW07VFJFh35Zowvhd4uSxqk441VBoAwE61ClDfXN04b6GTfyUHSTMPshRIQL+BQDk3JxSNUnt X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(8936002)(38070700005)(5660300002)(66946007)(4326008)(76116006)(508600001)(30864003)(966005)(52536014)(7696005)(186003)(26005)(33656002)(38100700002)(122000001)(64756008)(8676002)(66476007)(66446008)(6506007)(2906002)(55016003)(66556008)(53546011)(9686003)(71200400001)(316002)(6916009)(86362001)(54906003)(83380400001)(139555002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7006 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: dec5d061-a3ff-4e2c-4757-08d9fcbb3f5e X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: prc0oQOt6wBlYybQ9r+kNmQOYe0ko8Sap937+3TXhz/J5QeDHcpr/RhJFq2RDFgtB0xz7bhY1GT4hFN62wTauLcDNiKP14PH1E/KTlChMUbmxRgZawWWkzKoCKEvGAkSRzUuUxSyjTjs7bpOd6TmfqZoGGEZoJwUoD/f6zD+A/Kdhwarmr/QCi6Rfp0m2JhtqrIdTjLtEVoP7njVBiwTYF7nwZ+qH0jUU+ztYd+cjD5EBqF+Q9Zvg+nRBdEtBOOUgk4Cnsl9xpm07+DSQFJ1iTF/PZKaCiCVbsRwZkpKsG4yZTB6MIFUMmCag0S+gq5BB6Zh+4bFPyFXg+HFgTSaaIKIdyiB7triv0eo1XajhmMk03vB8rjtTg3T8n+aEhTUbh3GHpw6kxfuGlk+1X7bPDIx4fj3uoh6GnRQLBmhmuSqbpaSytguI6+PHOeif+FxL+bKNrtE79aXuYbHdcHzb7rRTkNQYGE4zmQtXu0nHr1n1H40gV5pRbfrEDqGzMTD6ob9bUpTg6cuMB827z2VoDA+NH0CdMDjQrlp8BtIf7zrwhmgNaIrf22bZTj/FI3Sh8q1dBxPFC76ksDFH4sriugfWfORk8XRETkwyraOVj/1eOTtKa/rcNffSEAF8STbWYklS1K+WhxXjQARLB1+dJ0Oc3XeNqDArb7n6dkJ1nSaIkyT13pfghLKQJ4nIEVkFLyA5MrIBI5ScAoFl9mSjCvL7dOhKmCDJIJUy019HG4oJn/hbOL1b5veBCb6wvXHP789Ta2uZAId4NLTqsjGzAb0s/n60MLpgZPcIjGQS+M= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(6862004)(8676002)(33656002)(4326008)(36860700001)(966005)(81166007)(70206006)(2906002)(82310400004)(70586007)(53546011)(356005)(6506007)(7696005)(9686003)(107886003)(52536014)(508600001)(83380400001)(336012)(8936002)(86362001)(54906003)(30864003)(26005)(186003)(5660300002)(40460700003)(316002)(47076005)(55016003)(139555002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2022 02:12:29.0501 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 06bff5a4-147d-46e6-400e-08d9fcbb44bc X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB2799 SGkgU3RlZmFubywNCg0KPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBTdGVm YW5vIFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+DQo+IFNlbnQ6IDIwMjLlubQz 5pyIM+aXpSAxMDowNA0KPiBUbzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+DQo+IENjOiBT dGVmYW5vIFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+OyB4ZW4tDQo+IGRldmVs QGxpc3RzLnhlbnByb2plY3Qub3JnOyBqdWxpZW5AeGVuLm9yZzsgQmVydHJhbmQgTWFycXVpcw0K PiA8QmVydHJhbmQuTWFycXVpc0Bhcm0uY29tPjsgUGVubnkgWmhlbmcgPFBlbm55LlpoZW5nQGFy bS5jb20+OyBIZW5yeSBXYW5nDQo+IDxIZW5yeS5XYW5nQGFybS5jb20+OyBuZCA8bmRAYXJtLmNv bT47IEdlb3JnZS5EdW5sYXBAY2l0cml4LmNvbQ0KPiBTdWJqZWN0OiBSRTogUHJvcG9zYWwgZm9y IFBvcnRpbmcgWGVuIHRvIEFybXY4LVI2NCAtIERyYWZ0QQ0KPiANCj4gT24gVGh1LCAzIE1hciAy MDIyLCBXZWkgQ2hlbiB3cm90ZToNCj4gPiA+IE9uIFdlZCwgMiBNYXIgMjAyMiwgV2VpIENoZW4g d3JvdGU6DQo+ID4gPiA+ID4gPiA+ID4gPiBJZiBub3QsIGFuZCBjb25zaWRlcmluZyB0aGF0IHdl IGhhdmUgdG8gZ2VuZXJhdGUNCj4gPiA+ID4gPiA+ID4gPiA+IEFSTV9NUFVfKl9NRU1PUllfU1RB UlQvRU5EIGFueXdheSBhdCBidWlsZCB0aW1lLCB3b3VsZCBpdA0KPiBtYWtlDQo+ID4gPiA+ID4g c2Vuc2UNCj4gPiA+ID4gPiA+ID4gdG8NCj4gPiA+ID4gPiA+ID4gPiA+IGFsc28gZ2VuZXJhdGUg bXB1LGd1ZXN0LW1lbW9yeS1zZWN0aW9uLCB4ZW4sc3RhdGljLW1lbSwNCj4gZXRjLg0KPiA+ID4g YXQNCj4gPiA+ID4gPiBidWlsZA0KPiA+ID4gPiA+ID4gPiA+ID4gdGltZSByYXRoZXIgdGhhbiBw YXNzaW5nIGl0IHZpYSBkZXZpY2UgdHJlZSB0byBYZW4gYXQNCj4gcnVudGltZT8NCj4gPiA+ID4g PiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiBEaWQgeW91IG1lYW4g d2Ugc3RpbGwgYWRkIHRoZXNlIGluZm9ybWF0aW9uIGluIGRldmljZSB0cmVlLA0KPiBidXQNCj4g PiA+IGZvcg0KPiA+ID4gPiA+ID4gPiBidWlsZA0KPiA+ID4gPiA+ID4gPiA+IHRpbWUgb25seS4g SW4gcnVudGltZSB3ZSBkb24ndCBwYXJzZSB0aGVtPw0KPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ ID4gPiBZZXMsIHNvbWV0aGluZyBsaWtlIHRoYXQsIGJ1dCBzZWUgYmVsb3cuDQo+ID4gPiA+ID4g PiA+DQo+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+ID4gPiBXaGF0J3MgdGhlIHZhbHVlIG9m IGRvaW5nIEFSTV9NUFVfKl9NRU1PUllfU1RBUlQvRU5EIGF0DQo+IGJ1aWxkDQo+ID4gPiB0aW1l DQo+ID4gPiA+ID4gYW5kDQo+ID4gPiA+ID4gPiA+ID4gPiBldmVyeXRoaW5nIGVsc2UgYXQgcnVu dGltZT8NCj4gPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+IEFSTV9NUFVfKl9NRU1PUllf U1RBUlQvRU5EIGlzIGRlZmluZWQgYnkgcGxhdGZvcm0uIEJ1dCBvdGhlcg0KPiA+ID4gdGhpbmdz DQo+ID4gPiA+ID4gYXJlDQo+ID4gPiA+ID4gPiA+ID4gdXNlcnMgY3VzdG9taXplZC4gVGhleSBj YW4gY2hhbmdlIHRoZWlyIHVzYWdlIHdpdGhvdXQNCj4gcmVidWlsZA0KPiA+ID4gdGhlDQo+ID4g PiA+ID4gaW1hZ2UuDQo+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+IEdvb2QgcG9pbnQuDQo+ ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+IFdlIGRvbid0IHdhbnQgdG8gaGF2ZSB0byByZWJ1 aWxkIFhlbiBpZiB0aGUgdXNlciB1cGRhdGVkIGENCj4gZ3Vlc3QNCj4gPiA+ID4gPiBrZXJuZWws DQo+ID4gPiA+ID4gPiA+IHJlc3VsdGluZyBpbiBhIGxhcmdlciBib290LW1vZHVsZS1zZWN0aW9u Lg0KPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiBTbyBJIHRoaW5rIGl0IG1ha2VzIHNlbnNl IHRoYXQgIm1wdSxib290LW1vZHVsZS1zZWN0aW9uIiBpcw0KPiA+ID4gZ2VuZXJhdGVkDQo+ID4g PiA+ID4gYnkNCj4gPiA+ID4gPiA+ID4gdGhlIHNjcmlwdHMgKGUuZy4gSW1hZ2VCdWlsZGVyKSBh dCBidWlsZCB0aW1lLCBhbmQgWGVuIHJlYWRzDQo+IHRoZQ0KPiA+ID4gPiA+ID4gPiBwcm9wZXJ0 eSBhdCBib290IGZyb20gdGhlIHJ1bnRpbWUgZGV2aWNlIHRyZWUuDQo+ID4gPiA+ID4gPiA+DQo+ ID4gPiA+ID4gPiA+IEkgdGhpbmsgd2UgbmVlZCB0byBkaXZpZGUgdGhlIGluZm9ybWF0aW9uIGlu dG8gdHdvIGdyb3VwczoNCj4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ ID4gIyBHcm91cDE6IGJvYXJkIGluZm8NCj4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gVGhp cyBpbmZvcm1hdGlvbiBpcyBwbGF0Zm9ybSBzcGVjaWZpYyBhbmQgaXQgaXMgbm90IG1lYW50IHRv DQo+ID4gPiBjaGFuZ2UNCj4gPiA+ID4gPiA+ID4gZGVwZW5kaW5nIG9uIHRoZSBWTSBjb25maWd1 cmF0aW9uLiBJZGVhbGx5LCB3ZSBidWlsZCBYZW4gZm9yIGENCj4gPiA+ID4gPiBwbGF0Zm9ybQ0K PiA+ID4gPiA+ID4gPiBvbmNlLCB0aGVuIHdlIGNhbiB1c2UgdGhlIHNhbWUgWGVuIGJpbmFyeSB0 b2dldGhlciB3aXRoIGFueQ0KPiA+ID4gPiA+IGNvbWJpbmF0aW9uDQo+ID4gPiA+ID4gPiA+IG9m IGRvbTAvZG9tVSBrZXJuZWxzIGFuZCByYW1kaXNrcy4NCj4gPiA+ID4gPiA+ID4NCj4gPiA+ID4g PiA+ID4gVGhpcyBraW5kIG9mIGluZm9ybWF0aW9uIGRvZXNuJ3QgbmVlZCB0byBiZSBleHBvc2Vk IHRvIHRoZQ0KPiBydW50aW1lDQo+ID4gPiA+ID4gPiA+IGRldmljZSB0cmVlLiBCdXQgd2UgY2Fu IHN0aWxsIHVzZSBhIGJ1aWxkLXRpbWUgZGV2aWNlIHRyZWUgdG8NCj4gPiA+IGdlbmVyYXRlDQo+ ID4gPiA+ID4gPiA+IHRoZSBhZGRyZXNzZXMgaWYgaXQgaXMgY29udmVuaWVudC4NCj4gPiA+ID4g PiA+ID4NCj4gPiA+ID4gPiA+ID4gWEVOX1NUQVJUX0FERFJFU1MsIEFSTV9NUFVfREVWSUNFX01F TU9SWV8qLCBhbmQNCj4gPiA+ID4gPiBBUk1fTVBVX05PUk1BTF9NRU1PUllfKg0KPiA+ID4gPiA+ ID4gPiBzZWVtIHRvIGJlIHBhcnQgb2YgdGhpcyBncm91cC4NCj4gPiA+ID4gPiA+ID4NCj4gPiA+ ID4gPiA+DQo+ID4gPiA+ID4gPiBZZXMuDQo+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPg0KPiA+ ID4gPiA+ID4gPiAjIEdyb3VwMjogYm9vdCBjb25maWd1cmF0aW9uDQo+ID4gPiA+ID4gPiA+DQo+ ID4gPiA+ID4gPiA+IFRoaXMgaW5mb3JtYXRpb24gaXMgYWJvdXQgdGhlIHNwZWNpZmljIHNldCBv ZiBiaW5hcmllcyBhbmQgVk1zDQo+ID4gPiB0aGF0IHdlDQo+ID4gPiA+ID4gPiA+IG5lZWQgdG8g Ym9vdC4gSXQgaXMgY29uY2VwdHVhbGx5IHNpbWlsYXIgdG8gdGhlIGRvbTBsZXNzDQo+IGRldmlj ZQ0KPiA+ID4gdHJlZQ0KPiA+ID4gPiA+ID4gPiBub2RlcyB0aGF0IHdlIGFscmVhZHkgaGF2ZS4g SWYgd2UgY2hhbmdlIG9uZSBvZiB0aGUgVk0NCj4gYmluYXJpZXMsDQo+ID4gPiB3ZQ0KPiA+ID4g PiA+ID4gPiBsaWtlbHkgaGF2ZSB0byByZWZyZXNoIHRoZSBpbmZvcm1hdGlvbiBoZXJlLg0KPiA+ ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiAibXB1LGJvb3QtbW9kdWxlLXNlY3Rpb24iIHByb2Jh Ymx5IGJlbG9uZ3MgdG8gdGhpcyBncm91cA0KPiAodW5sZXNzDQo+ID4gPiB3ZQ0KPiA+ID4gPiA+ IGZpbmQNCj4gPiA+ID4gPiA+ID4gYSB3YXkgdG8gZGVmaW5lICJtcHUsYm9vdC1tb2R1bGUtc2Vj dGlvbiIgZ2VuZXJpY2FsbHkgc28gdGhhdA0KPiB3ZQ0KPiA+ID4gZG9uJ3QNCj4gPiA+ID4gPiA+ ID4gbmVlZCB0byBjaGFuZ2UgaXQgYW55IHRpbWUgdGhlIHNldCBvZiBib290IG1vZHVsZXMgY2hh bmdlLikNCj4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+DQo+ID4gPiA+ ID4gPiBJIGFncmVlLg0KPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+IEl0IGxvb2tzIGxp a2Ugd2UgYXJlIGZvcmNlZCB0byBoYXZlIHRoZSBzZWN0aW9ucw0KPiBkZWZpbml0aW9ucw0KPiA+ ID4gYXQNCj4gPiA+ID4gPiBidWlsZA0KPiA+ID4gPiA+ID4gPiA+ID4gdGltZSBiZWNhdXNlIHdl IG5lZWQgdGhlbSBiZWZvcmUgd2UgY2FuIHBhcnNlIGRldmljZSB0cmVlLg0KPiBJbg0KPiA+ID4g dGhhdA0KPiA+ID4gPiA+ID4gPiBjYXNlLA0KPiA+ID4gPiA+ID4gPiA+ID4gd2UgbWlnaHQgYXMg d2VsbCBkZWZpbmUgYWxsIHRoZSBzZWN0aW9ucyBhdCBidWlsZCB0aW1lLg0KPiA+ID4gPiA+ID4g PiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+IEJ1dCBJIHRoaW5rIGl0IHdvdWxkIGJlIGV2ZW4gYmV0 dGVyIGlmIFhlbiBjb3VsZA0KPiBhdXRvbWF0aWNhbGx5DQo+ID4gPiA+ID4gY2hvb3NlDQo+ID4g PiA+ID4gPiA+ID4gPiB4ZW4sc3RhdGljLW1lbSwgbXB1LGd1ZXN0LW1lbW9yeS1zZWN0aW9uLCBl dGMuIG9uIGl0cyBvd24NCj4gPiA+IGJhc2VkIG9uDQo+ID4gPiA+ID4gdGhlDQo+ID4gPiA+ID4g PiA+ID4gPiByZWd1bGFyIGRldmljZSB0cmVlIGluZm9ybWF0aW9uICgvbWVtb3J5LCAvYW1iYSwg ZXRjLiksDQo+ID4gPiB3aXRob3V0DQo+ID4gPiA+ID4gYW55DQo+ID4gPiA+ID4gPiA+IG5lZWQN Cj4gPiA+ID4gPiA+ID4gPiA+IGZvciBleHBsaWNpdGx5IGRlc2NyaWJpbmcgZWFjaCByYW5nZSB3 aXRoIHRoZXNlIG5ldw0KPiBwcm9wZXJ0aWVzLg0KPiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4g PiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+IGZvciBtcHUsZ3Vlc3QtbWVtb3J5LXNlY3Rpb24sIHdp dGggdGhlIGxpbWl0YXRpb25zOiBubyBvdGhlcg0KPiA+ID4gdXNhZ2UNCj4gPiA+ID4gPiA+ID4g YmV0d2Vlbg0KPiA+ID4gPiA+ID4gPiA+IGRpZmZlcmVudCBndWVzdCcgbWVtb3J5IG5vZGVzLCB0 aGlzIGlzIE9LLiBCdXQgZm9yDQo+IHhlbixzdGF0aWMtDQo+ID4gPiBtZW0NCj4gPiA+ID4gPiAo aGVhcCksDQo+ID4gPiA+ID4gPiA+ID4gd2UganVzdCB3YW50IGV2ZXJ5dGhpbmcgb24gYSBNUFUg c3lzdGVtIGlzIGRlcnRlcm1pc3RpYy4gQnV0LA0KPiBvZg0KPiA+ID4gPiA+IGNvdXJzZQ0KPiA+ ID4gPiA+ID4gPiBYZW4NCj4gPiA+ID4gPiA+ID4gPiBjYW4gc2VsZWN0IGxlZnQgbWVtb3J5IGZv ciBoZWFwIHdpdGhvdXQgc3RhdGljLW1lbS4NCj4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4g SXQgaXMgZ29vZCB0aGF0IHlvdSB0aGluayB0aGV5IGNhbiBiZSBjaG9zZW4gYnkgWGVuLg0KPiA+ ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiBEaWZmZXJlbnRseSBmcm9tICJib290LW1vZHVsZS1z ZWN0aW9uIiwgd2hpY2ggaGFzIHRvIGRvIHdpdGgNCj4gdGhlDQo+ID4gPiBib290DQo+ID4gPiA+ ID4gPiA+IG1vZHVsZXMgc2VsZWN0ZWQgYnkgdGhlIHVzZXIgZm9yIGEgc3BlY2lmaWMgZXhlY3V0 aW9uLA0KPiA+ID4gPiA+ID4gPiBndWVzdC1tZW1vcnktc2VjdGlvbiBhbmQgc3RhdGljLW1lbSBh cmUgWGVuIHNwZWNpZmljIG1lbW9yeQ0KPiA+ID4gPiA+ID4gPiBwb2xpY2llcy9hbGxvY2F0aW9u cy4NCj4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gQSB1c2VyIHdvdWxkbid0IGtub3cgaG93 IHRvIGZpbGwgdGhlbSBpbi4gQW5kIEkgd29ycnkgdGhhdA0KPiBldmVuIGENCj4gPiA+ID4gPiBz Y3JpcHQNCj4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiBCdXQgdXNlcnMgc2hvdWxkIGtub3cgaXQs IGJlY2F1c2Ugc3RhdGljLW1lbSBmb3IgZ3Vlc3QgbXVzdCBiZQ0KPiA+ID4gYWxsb2NhdGVkDQo+ ID4gPiA+ID4gPiBpbiB0aGlzIHJhbmdlLiBBbmQgdXNlcnMgdGFrZSB0aGUgcmVzcG9uc2liaWxp dHkgdG8gc2V0IHRoZQ0KPiBEb21VJ3MNCj4gPiA+ID4gPiA+IHN0YXRpYyBhbGxvY2F0ZSBtZW1v cnkgcmFuZ2VzLg0KPiA+ID4gPiA+DQo+ID4gPiA+ID4gTGV0IG1lIHByZW1pc2UgdGhhdCBteSBn b2FsIGlzIHRvIGF2b2lkIGhhdmluZyBtYW55IHVzZXJzDQo+IHJlcG9ydGluZw0KPiA+ID4gPiA+ IGVycm9ycyB0byB4ZW4tZGV2ZWwgYW5kIHhlbi11c2VycyB3aGVuIGFjdHVhbGx5IGl0IGlzIGp1 c3QgYSB3cm9uZw0KPiA+ID4gPiA+IGNob2ljZSBvZiBhZGRyZXNzZXMuDQo+ID4gPiA+ID4NCj4g PiA+ID4gPiBJIHRoaW5rIHdlIG5lZWQgdG8gbWFrZSBhIGRpc3RpbmN0aW9uIGJldHdlZW4gYWRk cmVzc2VzIGZvciB0aGUNCj4gYm9vdA0KPiA+ID4gPiA+IG1vZHVsZXMsIGUuZy4gYWRkcmVzc2Vz IHdoZXJlIHRvIGxvYWQgeGVuLCB0aGUgZG9tMC9VIGtlcm5lbCwNCj4gZG9tMC9VDQo+ID4gPiA+ ID4gcmFtZGlzayBpbiBtZW1vcnkgYXQgYm9vdCB0aW1lLCBhbmQgVk0gc3RhdGljIG1lbW9yeSBh ZGRyZXNzZXMuDQo+ID4gPiA+ID4NCj4gPiA+ID4gPiBUaGUgYm9vdCBtb2R1bGVzIGFkZHJlc3Nl cyBhcmUgcGFydGljdWxhcmx5IGRpZmZpY3VsdCB0byBmaWxsIGluDQo+ID4gPiBiZWNhdXNlDQo+ ID4gPiA+ID4gdGhleSBhcmUgbWFueSBhbmQgYSBzbWFsbCB1cGRhdGUgaW4gb25lIG9mIHRoZSBt b2R1bGVzIGNvdWxkDQo+ID4gPiBpbnZhbGlkYXRlDQo+ID4gPiA+ID4gYWxsIHRoZSBvdGhlciBh ZGRyZXNzZXMuIFRoaXMgaXMgd2h5IEkgZW5kZWQgdXAgd3JpdGluZw0KPiBJbWFnZUJ1aWxkZXIu DQo+ID4gPiA+ID4gU2luY2UgdGhlbSwgSSByZWNlaXZlZCBzZXZlcmFsIGVtYWlscyBmcm9tIHVz ZXJzIHRoYW5raW5nIG1lIGZvcg0KPiA+ID4gPiA+IEltYWdlQnVpbGRlciA6LSkNCj4gPiA+ID4g Pg0KPiA+ID4gPg0KPiA+ID4gPiBUaGFua3MgKzk5OSDwn5iKDQo+ID4gPiA+DQo+ID4gPiA+DQo+ ID4gPiA+ID4gVGhlIHN0YXRpYyBWTSBtZW1vcnkgYWRkcmVzc2VzICh4ZW4sc3RhdGljLW1lbSkg c2hvdWxkIGJlIGEgYml0DQo+IGVhc2llcg0KPiA+ID4gPiA+IHRvIGZpbGwgaW4gY29ycmVjdGx5 LiBUaGV5IGFyZSBtZWFudCB0byBiZSBjaG9zZW4gb25jZSwgYW5kIGl0DQo+ID4gPiBzaG91bGRu J3QNCj4gPiA+ID4gPiBoYXBwZW4gdGhhdCBhbiB1cGRhdGUgb24gYSBrZXJuZWwgZm9yY2VzIHRo ZSB1c2VyIHRvIGNoYW5nZSBhbGwNCj4gdGhlIFZNDQo+ID4gPiA+ID4gc3RhdGljIG1lbW9yeSBh ZGRyZXNzZXMuIEFsc28sIEkga25vdyB0aGF0IHNvbWUgdXNlcnMgYWN0dWFsbHkNCj4gd2FudCB0 bw0KPiA+ID4gPiA+IGJlIGFibGUgdG8gY2hvb3NlIHRoZSBkb21VIGFkZHJlc3NlcyBieSBoYW5k IGJlY2F1c2UgdGhleSBoYXZlDQo+ID4gPiBzcGVjaWZpYw0KPiA+ID4gPiA+IG5lZWRzLiBTbyBp dCBpcyBnb29kIHRoYXQgd2UgY2FuIGxldCB0aGUgdXNlciBjaG9vc2UgdGhlIGFkZHJlc3Nlcw0K PiBpZg0KPiA+ID4gPiA+IHRoZXkgd2FudCB0by4NCj4gPiA+ID4gPg0KPiA+ID4gPg0KPiA+ID4g PiBZZXMuDQo+ID4gPiA+DQo+ID4gPiA+ID4gV2l0aCBhbGwgb2YgdGhhdCBzYWlkLCBJIGRvIHRo aW5rIHRoYXQgbWFueSB1c2VycyB3b24ndCBoYXZlIGFuDQo+ID4gPiBvcGluaW9uDQo+ID4gPiA+ ID4gb24gdGhlIFZNIHN0YXRpYyBtZW1vcnkgYWRkcmVzc2VzIGFuZCB3b24ndCBrbm93IGhvdyB0 byBjaG9vc2UNCj4gdGhlbS4NCj4gPiA+ID4gPiBJdCB3b3VsZCBiZSBlcnJvciBwcm9uZSB0byBs ZXQgdGhlbSB0cnkgdG8gZmlsbCB0aGVtIGluIGJ5IGhhbmQuDQo+IFNvIEkNCj4gPiA+ID4gPiB3 YXMgYWxyZWFkeSBwbGFubmluZyBvbiBhZGRpbmcgc3VwcG9ydCB0byBJbWFnZUJ1aWxkZXIgdG8N Cj4gPiA+IGF1dG9tYXRpY2FsbHkNCj4gPiA+ID4gPiBnZW5lcmF0ZSB4ZW4sc3RhdGljLW1lbSBm b3IgZG9tMGxlc3MgZG9tYWlucy4NCj4gPiA+ID4gPg0KPiA+ID4gPg0KPiA+ID4gPiBMZXQgbWUg bWFrZSBzdXJlIHRoYXQncyB3aGF0IHlvdSBzYWlkOiBVc2VycyBnaXZlIGFuIFZNIG1lbW9yeSBz aXplDQo+IHRvDQo+ID4gPiA+IEltYWdlQnVpbGRlciwgYW5kIEltYWdlQnVpbGRlciB3aWxsIGdl bmVyYXRlIHhlbixzdGF0aWMtbWVtID0gPHN0YXJ0LA0KPiA+ID4gc2l6ZT4uDQo+ID4gPiA+IEZv ciBzcGVjaWZpYyBWTSwgSW1hZ2VCdWlsZGVyIGFsc28gY2FuIGFjY2VwdCBzdGFydCBhbmQgc2l6 ZSBhcw0KPiBpbnB1dHM/DQo+ID4gPiA+DQo+ID4gPiA+IERvIEkgdW5kZXJzdGFuZCB0aGlzIGNv cnJlY3RseT8NCj4gPiA+DQo+ID4gPiBZZXMsIGV4YWN0bHkNCj4gPiA+DQo+ID4gPg0KPiA+ID4g PiA+IEdvaW5nIGJhY2sgdG8gdGhpcyBzcGVjaWZpYyBkaXNjdXNzaW9uIGFib3V0IGJvb3QtbW9k dWxlLXNlY3Rpb246DQo+IEkNCj4gPiA+IGNhbg0KPiA+ID4gPiA+IHNlZSBub3cgdGhhdCwgZ2l2 ZW4geGVuLHN0YXRpYy1tZW0gaXMgY2hvc2VuIGJ5IEltYWdlQnVpbGRlciAob3INCj4gPiA+ID4N Cj4gPiA+ID4gQnkgaGFuZCA6ICkNCj4gPiA+ID4NCj4gPiA+ID4gPiBzaW1pbGFyKSBhbmQgbm90 IFhlbiwgdGhlbiBpdCBtYWtlcyBzZW5zZSB0byBoYXZlIEltYWdlQnVpbGRlciAob3INCj4gPiA+ ID4gPiBzaW1pbGFyKSBhbHNvIGdlbmVyYXRlIGJvb3QtbW9kdWxlLXNlY3Rpb24uDQo+ID4gPiA+ ID4NCj4gPiA+ID4NCj4gPiA+ID4gSWYgbXkgYWJvdmUgdW5kZXJzdGFuZGluZyBpcyByaWdodCwg dGhlbiB5ZXMuDQo+ID4gPg0KPiA+ID4gWWVzLCBJIHRoaW5rIHdlIGFyZSBvbiB0aGUgc2FtZSBw YWdlDQo+ID4gPg0KPiA+ID4NCj4gPiA+ID4gPiA+ID4gbGlrZSBJbWFnZUJ1aWxkZXIgd291bGRu J3QgYmUgdGhlIGJlc3QgcGxhY2UgdG8gcGljayB0aGVzZQ0KPiB2YWx1ZXMNCj4gPiA+IC0tDQo+ ID4gPiA+ID4gPiA+IHRoZXkgc2VlbSB0b28gImltcG9ydGFudCIgdG8gbGVhdmUgdG8gYSBzY3Jp cHQuDQo+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+IEJ1dCBpdCBzZWVtcyBwb3NzaWJsZSB0 byBjaG9vc2UgdGhlIHZhbHVlcyBpbiBYZW46DQo+ID4gPiA+ID4gPiA+IC0gWGVuIGtub3dzIEFS TV9NUFVfTk9STUFMX01FTU9SWV8qIGJlY2F1c2UgaXQgd2FzIGRlZmluZWQgYXQNCj4gPiA+IGJ1 aWxkDQo+ID4gPiA+ID4gdGltZQ0KPiA+ID4gPiA+ID4gPiAtIFhlbiByZWFkcyBib290LW1vZHVs ZS1zZWN0aW9uIGZyb20gZGV2aWNlIHRyZWUNCj4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4g SXQgc2hvdWxkIGJlIHBvc3NpYmxlIGF0IHRoaXMgcG9pbnQgZm9yIFhlbiB0byBwaWNrIHRoZSBi ZXN0DQo+ID4gPiB2YWx1ZXMNCj4gPiA+ID4gPiBmb3INCj4gPiA+ID4gPiA+ID4gZ3Vlc3QtbWVt b3J5LXNlY3Rpb24gYW5kIHN0YXRpYy1tZW0gYmFzZWQgb24gdGhlIG1lbW9yeQ0KPiBhdmFpbGFi bGUuDQo+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gSG93IFhlbiB0byBw aWNrPyBEb2VzIGl0IG1lYW4gaW4gc3RhdGljIGFsbG9jYXRpb24gRG9tVSBEVCBub2RlLA0KPiB3 ZQ0KPiA+ID4ganVzdA0KPiA+ID4gPiA+ID4gbmVlZCBhIHNpemUsIGJ1dCBkb24ndCByZXF1aXJl IGEgc3RhcnQgYWRkcmVzcyBmb3Igc3RhdGljLW1lbT8NCj4gPiA+ID4gPg0KPiA+ID4gPiA+IFll cyB0aGUgaWRlYSB3YXMgdGhhdCB0aGUgdXNlciB3b3VsZCBvbmx5IHByb3ZpZGUgdGhlIHNpemUg KGUuZy4NCj4gPiA+ID4gPiBET01VX1NUQVRJQ19NRU1bMV09MTAyNCkgYW5kIHRoZSBhZGRyZXNz ZXMgd291bGQgYmUgYXV0b21hdGljYWxseQ0KPiA+ID4gPiA+IGNhbGN1bGF0ZWQuIEJ1dCBJIGRp ZG4ndCBtZWFuIHRvIGNoYW5nZSB0aGUgZXhpc3RpbmcgeGVuLHN0YXRpYy0NCj4gbWVtDQo+ID4g PiA+ID4gZGV2aWNlIHRyZWUgYmluZGluZ3MuIFNvIGl0IGlzIGJlc3QgaWYgdGhlIHhlbixzdGF0 aWMtbWVtDQo+IGFkZHJlc3Nlcw0KPiA+ID4gPiA+IGdlbmVyYXRpb24gaXMgZG9uZSBieSBJbWFn ZUJ1aWxkZXIgKG9yIHNpbWlsYXIgdG9vbCkgaW5zdGVhZCBvZg0KPiBYZW4uDQo+ID4gPiA+ID4N Cj4gPiA+ID4NCj4gPiA+ID4gSWYgd2Ugc3RpbGwga2VlcCB0aGUgb3B0aW9uIGZvciB1c2VyIHRv IHNwZWNpZnkgdGhlIHN0YXJ0IGFuZCBzaXplDQo+ID4gPiA+IHBhcmFtZXRlcnMgZm9yIFZNIG1l bW9yeSwgYmVjYXVzZSBpdCBtYXliZSB2ZXJ5IGltcG9ydGFudCBmb3IgYQ0KPiA+ID4gPiBkZXRl cm1pbmlzdGljIHN5c3RlbSAoZnVsbHkgc3RhdGljIHN5c3RlbSksIEkgYWdyZWUgd2l0aCB5b3Uu DQo+ID4gPiA+DQo+ID4gPiA+IEFuZCBpbiBjdXJyZW50IHN0YXRpYy1hbGxvY2F0aW9uLCBJIHRo aW5rIFhlbiBkb2Vzbid0IGdlbmVyYXRlDQo+ID4gPiA+IHhlbixzdGF0aWMtbWVtIGFkZHJlc3Nl cywgYWxsIGJ5IGhhbmRzLi4uDQo+ID4gPg0KPiA+ID4gWWVhaA0KPiA+ID4NCj4gPg0KPiA+IEkg d2lsbCB1cGRhdGUgbXkgcHJvcG9zYWwgdG8gY292ZXIgb3VyIGFib3ZlIGRpc2N1c3Npb24sIGJ1 dCBJIGZvcmdvdA0KPiBvbmUNCj4gPiB0aGluZy4gQXMgdGhlIHBsYXRmb3JtIGhlYWRlciBmaWxl cyB3aWxsIGJlIGdlbmVyYXRlZCBmcm9tIERUUywgZG9lcyBpdA0KPiA+IG1lYW4gd2UgaGF2ZSB0 byBtYWludGFpbiBwbGF0Zm9ybSBkdHMgZmlsZXMgaW4gWGVuIGxpa2Ugd2hhdCBaZXBoeXIgaGFz DQo+ID4gZG9uZT8NCj4gDQo+IEkgd291bGQgcHJlZmVyIG5vdCB0byBoYXZlIHRvIG1haW50YWlu IHBsYXRmb3JtIGR0cyBmaWxlcyBpbiBYZW4gbGlrZQ0KPiBaZXBoeXIgaXMgZG9pbmcuIElkZWFs bHksIHRoZSB1c2VyIHNob3VsZCBiZSBhYmxlIHRvIHRha2UgYW55DQo+IHNwZWMtY29tcGxpYW50 IGRldmljZSB0cmVlIGZpbGUgYW5kIHVzZSBpdC4gSSB3b3VsZCBzYXk6IGxldCdzIHN0YXJ0DQo+ IHdpdGhvdXQgYWRkaW5nIHRoZSBkdHMgZmlsZXMgdG8gWGVuICh3ZSBtaWdodCBoYXZlIG9uZSB1 bmRlciBkb2NzLyBidXQNCj4ganVzdCBhcyBhbiBleGFtcGxlLikgV2UgY2FuIGFkZCB0aGVtIGxh dGVyIGlmIHRoZSBuZWVkIGFyaXNlLg0KPiANCg0KQnV0IHdpdGhvdXQgYW55IGRlZmF1bHQgZHRz LCB0aGF0IG1lYW5zIHdlIGNhbid0IHN0YXJ0IHRvIGJ1aWxkIFhlbiBmb3INCnY4Uj8gSXQgc2Vl bXMgaW4gdGhpcyBjYXNlLCB3ZSBuZWVkIE1ha2VmaWxlIHRvIHByaW50IHNvbWUgbWVzc2FnZSB0 bw0KdGVsbCB1c2VycyB0byBzcGVjaWZpYyBoaXMvaGVyIGR0cyBwYXRoLg0KDQo+IA0KPiA+IEFu ZCBkbyB5b3UgaGF2ZSBzb21lIGlkZWEgdG8gaW50ZWdyYXRlIHRoZSAiSW1hZ2VCdWlsZGVyIj8g TWFrZSBpdA0KPiA+IGFzIGEgc3VibW9kdWxlIG9mIFhlbiBvciBpbnRlZ3JhdGUgdG8geGVuLXRv b2xzPw0KPiANCj4gSSB0aGluayBpdCB3b3VsZCBiZSBiZXN0IGlmIEltYWdlQnVpbGRlciB3YXMg a2VwdCBhcyBhIHNlcGFyYXRlDQo+IHJlcG9zaXRvcnkgYmVjYXVzZSB0aGVyZSBzaG91bGQgYmUg bm8gc3Ryb25nIHRpZXMgYmV0d2VlbiBJbWFnZUJ1aWxkZXINCj4gdmVyc2lvbnMgYW5kIFhlbiB2 ZXJzaW9ucy4gSXQgaXMgbW9yZSBjb252ZW5pZW50IHRvIGhhbmRsZSBpdCBpbiBhDQo+IHNlcGFy YXRlIHJlcG9zaXRvcnksIGVzcGVjaWFsbHkgYXMgWW9jdG8gYW5kIG90aGVyIGJ1aWxkIHN5c3Rl bXMgbWlnaHQNCj4gY2xvbmUgSW1hZ2VCdWlsZGVyIGR1cmluZyB0aGUgYnVpbGQgdG8gZ2VuZXJh dGUgYm9vdC5zY3IgKGl0IGlzIGFscmVhZHkNCj4gdGhlIGNhc2UpLg0KPiANCj4gVGhhdCBzYWlk LCBpdCBtaWdodCBiZSBnb29kIHRvIG1ha2UgaXQgbW9yZSAib2ZmaWNpYWwiIGJ1dCBtb3Zpbmcg aXQgdG8NCj4gWGVuIFByb2plY3QuIEkgY2FuIHRhbGsgdG8gR2VvcmdlIGFib3V0IGNyZWF0aW5n DQo+IGh0dHA6Ly94ZW5iaXRzLnhlbi5vcmcvZ2l0LWh0dHAvaW1hZ2VidWlsZGVyLmdpdCBvcg0K PiBodHRwczovL2dpdGxhYi5jb20veGVuLXByb2plY3QvaW1hZ2VidWlsZGVyLg0KDQpUaGF0J3Mg Z29vZCA6ICkNCg0K From xen-devel-bounces@lists.xenproject.org Thu Mar 03 02:13:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Mar 2022 02:13:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282703.481509 (Exim 4.92) (envelope-from ) id 1nPayA-0000RG-Vw; Thu, 03 Mar 2022 02:13:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282703.481509; Thu, 03 Mar 2022 02:13:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPayA-0000R9-SZ; Thu, 03 Mar 2022 02:13:30 +0000 Received: by outflank-mailman (input) for mailman id 282703; Thu, 03 Mar 2022 02:13:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPay9-0000Qv-2d; Thu, 03 Mar 2022 02:13:29 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPay8-0001Ry-WA; Thu, 03 Mar 2022 02:13:29 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPay8-00050C-EJ; Thu, 03 Mar 2022 02:13:28 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nPay8-00022s-C3; Thu, 03 Mar 2022 02:13:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=wpUMiwfdr2+KuIUORRAEzpjtpbYCXBafGJxpKRWJGHU=; b=Cm65CCfWgOXbm0abKIPI4C/WJ4 Djh2rrbIFLhqWLFAG399Kb2TAqlDfzaYCr4XEicSUAIuCQ9yW99JBJtiOt2tlII1njw9mMCiOtB38 e7K6dJBTOK+3EtdihVvFMISOKsZGM1EAHhZbdVudktVAsqkg06j4GdN9sAR/ZLc8WT98=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 168334: tolerable FAIL - PUSHED X-Osstest-Failures: linux-5.4:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=866ae42cf4788c8b18de6bda0a522362702861d7 X-Osstest-Versions-That: linux=b6e8856b8a5f7fb8b2fc10636aa05cffed1781b9 From: osstest service owner Date: Thu, 03 Mar 2022 02:13:28 +0000 flight 168334 linux-5.4 real [real] flight 168353 linux-5.4 real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/168334/ http://logs.test-lab.xenproject.org/osstest/logs/168353/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 168353-retest Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail REGR. vs. 168206 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 168206 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 168206 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 168206 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 168206 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168206 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 168206 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 168206 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 168206 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 168206 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 168206 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 168206 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 168206 test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: linux 866ae42cf4788c8b18de6bda0a522362702861d7 baseline version: linux b6e8856b8a5f7fb8b2fc10636aa05cffed1781b9 Last test of basis 168206 2022-02-23 11:14:00 Z 7 days Testing same since 168334 2022-03-02 11:11:31 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Al Viro Alessandro B Maurici Alex Deucher Alexey Bayduraev Ariel Levkovich Arnaldo Carvalho de Melo Baokun Li Bart Van Assche Brian Geffon Carel Si ChenXiaoSong Christoph Hellwig Christophe JAILLET Christophe Leroy Cosmin Tanislav Cosmin Tanislav Daehwan Jung Damien Le Moal Dan Carpenter Daniel Borkmann Daniel Bristot de Oliveira Daniel Starke daniel.starke@siemens.com Daniele Palmas dann frazier Dave Hansen David S. Miller Dmytro Bagrii Eric Dumazet Evan Quan Felix Maurer Florian Fainelli Florian Westphal Gal Pressman Greg Kroah-Hartman Guenter Roeck Hans de Goede Heiner Kallweit Helge Deller Hongyu Xie Jakub Kicinski Jason Gunthorpe Jason Wang Jens Wiklander Jiri Olsa Johan Hovold John Fastabend Jon Hunter Jonathan Cameron Karol Herbst Laibin Qiu Linus Torvalds Linus Walleij Linux Kernel Functional Testing Maor Gottlieb Marc Zyngier Marek Szyprowski Mark Brown Mathias Nyman Maxime Ripard Miaohe Lin Miaoqian Lin Mike Rapoport Oliver Neukum Pablo Neira Ayuso Paul Blakey Puma Hsu Saeed Mahameed Sasha Levin Sebastian Andrzej Siewior Sergey Shtylyov Shuah Khan Siarhei Volkau Simon Horman Slade Watkins Slark Xiao Stefano Garzarella Stephen Boyd Steven Rostedt (Google) Sudip Mukherjee Szymon Heidrich Tao Liu Tejun Heo Waiman Long Willis Kung Xiaoke Wang Xin Long Yonghong Song Zhang Qiao Zhou Qingyang jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git b6e8856b8a5f..866ae42cf478 866ae42cf4788c8b18de6bda0a522362702861d7 -> tested/linux-5.4 From xen-devel-bounces@lists.xenproject.org Thu Mar 03 02:15:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Mar 2022 02:15:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282715.481520 (Exim 4.92) (envelope-from ) id 1nPb0T-00019S-Dt; Thu, 03 Mar 2022 02:15:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282715.481520; Thu, 03 Mar 2022 02:15:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPb0T-00019L-Au; Thu, 03 Mar 2022 02:15:53 +0000 Received: by outflank-mailman (input) for mailman id 282715; Thu, 03 Mar 2022 02:15:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPb0R-00019F-VB for xen-devel@lists.xenproject.org; Thu, 03 Mar 2022 02:15:52 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d68a1c65-9a97-11ec-8539-5f4723681683; Thu, 03 Mar 2022 03:15:50 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A17F961633; Thu, 3 Mar 2022 02:15:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 94134C004E1; Thu, 3 Mar 2022 02:15:45 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d68a1c65-9a97-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646273746; bh=GGYDsx7d7bMm8qAaVR61BYim2Ltllkah0XdFKmQRotM=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=tLA9k2CVLSFEW94D8J7G6RKmNhL39bextTr8GzUeqiFczISoJ+gHbeCD5CTrjzsdC sDrzcFeKI5tMJJ0BOQi1apOiT/Iv8ogySL5P+lMkTPLfNZ8A7mkhXSAWhz4BOSygVa 8++LrqXkgLyI9tS3DgghD8JCrvTjiwYdTCYfuqUAFCRn57UtMTGAQn5IKdzriOhX6Y CMkzazpYvENEQT/9FRDTQGI+wN5MDp7ZjaCQo4BNAA9fZZ38OJ8L0IOCLVV3ewuTOQ hu3JXsxs6swEdFhmwCK5R/8WKU9+ZO0vme3YrCItVhLh2jUSrc2Q0bvCoAulRyrBqi arPWUMTdqQniA== Date: Wed, 2 Mar 2022 18:15:44 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Wei Chen cc: Stefano Stabellini , "xen-devel@lists.xenproject.org" , "julien@xen.org" , Bertrand Marquis , Penny Zheng , Henry Wang , nd , "George.Dunlap@citrix.com" Subject: RE: Proposal for Porting Xen to Armv8-R64 - DraftA In-Reply-To: Message-ID: References: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-832106708-1646273746=:3261" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-832106708-1646273746=:3261 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Thu, 3 Mar 2022, Wei Chen wrote: > > On Thu, 3 Mar 2022, Wei Chen wrote: > > > > On Wed, 2 Mar 2022, Wei Chen wrote: > > > > > > > > > > If not, and considering that we have to generate > > > > > > > > > > ARM_MPU_*_MEMORY_START/END anyway at build time, would it > > make > > > > > > sense > > > > > > > > to > > > > > > > > > > also generate mpu,guest-memory-section, xen,static-mem, > > etc. > > > > at > > > > > > build > > > > > > > > > > time rather than passing it via device tree to Xen at > > runtime? > > > > > > > > > > > > > > > > > > > > > > > > > > > > Did you mean we still add these information in device tree, > > but > > > > for > > > > > > > > build > > > > > > > > > time only. In runtime we don't parse them? > > > > > > > > > > > > > > > > Yes, something like that, but see below. > > > > > > > > > > > > > > > > > > > > > > > > > > What's the value of doing ARM_MPU_*_MEMORY_START/END at > > build > > > > time > > > > > > and > > > > > > > > > > everything else at runtime? > > > > > > > > > > > > > > > > > > ARM_MPU_*_MEMORY_START/END is defined by platform. But other > > > > things > > > > > > are > > > > > > > > > users customized. They can change their usage without > > rebuild > > > > the > > > > > > image. > > > > > > > > > > > > > > > > Good point. > > > > > > > > > > > > > > > > We don't want to have to rebuild Xen if the user updated a > > guest > > > > > > kernel, > > > > > > > > resulting in a larger boot-module-section. > > > > > > > > > > > > > > > > So I think it makes sense that "mpu,boot-module-section" is > > > > generated > > > > > > by > > > > > > > > the scripts (e.g. ImageBuilder) at build time, and Xen reads > > the > > > > > > > > property at boot from the runtime device tree. > > > > > > > > > > > > > > > > I think we need to divide the information into two groups: > > > > > > > > > > > > > > > > > > > > > > > > # Group1: board info > > > > > > > > > > > > > > > > This information is platform specific and it is not meant to > > > > change > > > > > > > > depending on the VM configuration. Ideally, we build Xen for a > > > > > > platform > > > > > > > > once, then we can use the same Xen binary together with any > > > > > > combination > > > > > > > > of dom0/domU kernels and ramdisks. > > > > > > > > > > > > > > > > This kind of information doesn't need to be exposed to the > > runtime > > > > > > > > device tree. But we can still use a build-time device tree to > > > > generate > > > > > > > > the addresses if it is convenient. > > > > > > > > > > > > > > > > XEN_START_ADDRESS, ARM_MPU_DEVICE_MEMORY_*, and > > > > > > ARM_MPU_NORMAL_MEMORY_* > > > > > > > > seem to be part of this group. > > > > > > > > > > > > > > > > > > > > > > Yes. > > > > > > > > > > > > > > > > > > > > > > > # Group2: boot configuration > > > > > > > > > > > > > > > > This information is about the specific set of binaries and VMs > > > > that we > > > > > > > > need to boot. It is conceptually similar to the dom0less > > device > > > > tree > > > > > > > > nodes that we already have. If we change one of the VM > > binaries, > > > > we > > > > > > > > likely have to refresh the information here. > > > > > > > > > > > > > > > > "mpu,boot-module-section" probably belongs to this group > > (unless > > > > we > > > > > > find > > > > > > > > a way to define "mpu,boot-module-section" generically so that > > we > > > > don't > > > > > > > > need to change it any time the set of boot modules change.) > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > I agree. > > > > > > > > > > > > > > > > > It looks like we are forced to have the sections > > definitions > > > > at > > > > > > build > > > > > > > > > > time because we need them before we can parse device tree. > > In > > > > that > > > > > > > > case, > > > > > > > > > > we might as well define all the sections at build time. > > > > > > > > > > > > > > > > > > > > But I think it would be even better if Xen could > > automatically > > > > > > choose > > > > > > > > > > xen,static-mem, mpu,guest-memory-section, etc. on its own > > > > based on > > > > > > the > > > > > > > > > > regular device tree information (/memory, /amba, etc.), > > > > without > > > > > > any > > > > > > > > need > > > > > > > > > > for explicitly describing each range with these new > > properties. > > > > > > > > > > > > > > > > > > > > > > > > > > > > for mpu,guest-memory-section, with the limitations: no other > > > > usage > > > > > > > > between > > > > > > > > > different guest' memory nodes, this is OK. But for > > xen,static- > > > > mem > > > > > > (heap), > > > > > > > > > we just want everything on a MPU system is dertermistic. But, > > of > > > > > > course > > > > > > > > Xen > > > > > > > > > can select left memory for heap without static-mem. > > > > > > > > > > > > > > > > It is good that you think they can be chosen by Xen. > > > > > > > > > > > > > > > > Differently from "boot-module-section", which has to do with > > the > > > > boot > > > > > > > > modules selected by the user for a specific execution, > > > > > > > > guest-memory-section and static-mem are Xen specific memory > > > > > > > > policies/allocations. > > > > > > > > > > > > > > > > A user wouldn't know how to fill them in. And I worry that > > even a > > > > > > script > > > > > > > > > > > > > > But users should know it, because static-mem for guest must be > > > > allocated > > > > > > > in this range. And users take the responsibility to set the > > DomU's > > > > > > > static allocate memory ranges. > > > > > > > > > > > > Let me premise that my goal is to avoid having many users > > reporting > > > > > > errors to xen-devel and xen-users when actually it is just a wrong > > > > > > choice of addresses. > > > > > > > > > > > > I think we need to make a distinction between addresses for the > > boot > > > > > > modules, e.g. addresses where to load xen, the dom0/U kernel, > > dom0/U > > > > > > ramdisk in memory at boot time, and VM static memory addresses. > > > > > > > > > > > > The boot modules addresses are particularly difficult to fill in > > > > because > > > > > > they are many and a small update in one of the modules could > > > > invalidate > > > > > > all the other addresses. This is why I ended up writing > > ImageBuilder. > > > > > > Since them, I received several emails from users thanking me for > > > > > > ImageBuilder :-) > > > > > > > > > > > > > > > > Thanks +999 😊 > > > > > > > > > > > > > > > > The static VM memory addresses (xen,static-mem) should be a bit > > easier > > > > > > to fill in correctly. They are meant to be chosen once, and it > > > > shouldn't > > > > > > happen that an update on a kernel forces the user to change all > > the VM > > > > > > static memory addresses. Also, I know that some users actually > > want to > > > > > > be able to choose the domU addresses by hand because they have > > > > specific > > > > > > needs. So it is good that we can let the user choose the addresses > > if > > > > > > they want to. > > > > > > > > > > > > > > > > Yes. > > > > > > > > > > > With all of that said, I do think that many users won't have an > > > > opinion > > > > > > on the VM static memory addresses and won't know how to choose > > them. > > > > > > It would be error prone to let them try to fill them in by hand. > > So I > > > > > > was already planning on adding support to ImageBuilder to > > > > automatically > > > > > > generate xen,static-mem for dom0less domains. > > > > > > > > > > > > > > > > Let me make sure that's what you said: Users give an VM memory size > > to > > > > > ImageBuilder, and ImageBuilder will generate xen,static-mem = > > > size>. > > > > > For specific VM, ImageBuilder also can accept start and size as > > inputs? > > > > > > > > > > Do I understand this correctly? > > > > > > > > Yes, exactly > > > > > > > > > > > > > > Going back to this specific discussion about boot-module-section: > > I > > > > can > > > > > > see now that, given xen,static-mem is chosen by ImageBuilder (or > > > > > > > > > > By hand : ) > > > > > > > > > > > similar) and not Xen, then it makes sense to have ImageBuilder (or > > > > > > similar) also generate boot-module-section. > > > > > > > > > > > > > > > > If my above understanding is right, then yes. > > > > > > > > Yes, I think we are on the same page > > > > > > > > > > > > > > > > like ImageBuilder wouldn't be the best place to pick these > > values > > > > -- > > > > > > > > they seem too "important" to leave to a script. > > > > > > > > > > > > > > > > But it seems possible to choose the values in Xen: > > > > > > > > - Xen knows ARM_MPU_NORMAL_MEMORY_* because it was defined at > > > > build > > > > > > time > > > > > > > > - Xen reads boot-module-section from device tree > > > > > > > > > > > > > > > > It should be possible at this point for Xen to pick the best > > > > values > > > > > > for > > > > > > > > guest-memory-section and static-mem based on the memory > > available. > > > > > > > > > > > > > > > > > > > > > > How Xen to pick? Does it mean in static allocation DomU DT node, > > we > > > > just > > > > > > > need a size, but don't require a start address for static-mem? > > > > > > > > > > > > Yes the idea was that the user would only provide the size (e.g. > > > > > > DOMU_STATIC_MEM[1]=1024) and the addresses would be automatically > > > > > > calculated. But I didn't mean to change the existing xen,static- > > mem > > > > > > device tree bindings. So it is best if the xen,static-mem > > addresses > > > > > > generation is done by ImageBuilder (or similar tool) instead of > > Xen. > > > > > > > > > > > > > > > > If we still keep the option for user to specify the start and size > > > > > parameters for VM memory, because it maybe very important for a > > > > > deterministic system (fully static system), I agree with you. > > > > > > > > > > And in current static-allocation, I think Xen doesn't generate > > > > > xen,static-mem addresses, all by hands... > > > > > > > > Yeah > > > > > > > > > > I will update my proposal to cover our above discussion, but I forgot > > one > > > thing. As the platform header files will be generated from DTS, does it > > > mean we have to maintain platform dts files in Xen like what Zephyr has > > > done? > > > > I would prefer not to have to maintain platform dts files in Xen like > > Zephyr is doing. Ideally, the user should be able to take any > > spec-compliant device tree file and use it. I would say: let's start > > without adding the dts files to Xen (we might have one under docs/ but > > just as an example.) We can add them later if the need arise. > > > > But without any default dts, that means we can't start to build Xen for > v8R? It seems in this case, we need Makefile to print some message to > tell users to specific his/her dts path. Yes, exactly. > > > And do you have some idea to integrate the "ImageBuilder"? Make it > > > as a submodule of Xen or integrate to xen-tools? > > > > I think it would be best if ImageBuilder was kept as a separate > > repository because there should be no strong ties between ImageBuilder > > versions and Xen versions. It is more convenient to handle it in a > > separate repository, especially as Yocto and other build systems might > > clone ImageBuilder during the build to generate boot.scr (it is already > > the case). > > > > That said, it might be good to make it more "official" but moving it to > > Xen Project. I can talk to George about creating > > http://xenbits.xen.org/git-http/imagebuilder.git or > > https://gitlab.com/xen-project/imagebuilder. > > That's good : ) --8323329-832106708-1646273746=:3261-- From xen-devel-bounces@lists.xenproject.org Thu Mar 03 03:08:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Mar 2022 03:08:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282725.481531 (Exim 4.92) (envelope-from ) id 1nPbpa-0008JX-Ks; Thu, 03 Mar 2022 03:08:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282725.481531; Thu, 03 Mar 2022 03:08:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPbpa-0008JQ-Hb; Thu, 03 Mar 2022 03:08:42 +0000 Received: by outflank-mailman (input) for mailman id 282725; Thu, 03 Mar 2022 03:08:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPbpZ-0008JK-7f for xen-devel@lists.xenproject.org; Thu, 03 Mar 2022 03:08:41 +0000 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 37a20954-9a9f-11ec-8eba-a37418f5ba1a; Thu, 03 Mar 2022 04:08:39 +0100 (CET) Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 222LxKVP003862; Thu, 3 Mar 2022 03:08:19 GMT Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by mx0b-00069f02.pphosted.com with ESMTP id 3ehh2enhec-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 03 Mar 2022 03:08:18 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 2233644T090987; Thu, 3 Mar 2022 03:08:17 GMT Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2171.outbound.protection.outlook.com [104.47.58.171]) by userp3030.oracle.com with ESMTP id 3ef9b295es-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 03 Mar 2022 03:08:17 +0000 Received: from BYAPR10MB2663.namprd10.prod.outlook.com (2603:10b6:a02:a9::20) by BLAPR10MB5266.namprd10.prod.outlook.com (2603:10b6:208:331::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.14; Thu, 3 Mar 2022 03:08:15 +0000 Received: from BYAPR10MB2663.namprd10.prod.outlook.com ([fe80::a0d5:610d:bcf:9b47]) by BYAPR10MB2663.namprd10.prod.outlook.com ([fe80::a0d5:610d:bcf:9b47%4]) with mapi id 15.20.5017.027; Thu, 3 Mar 2022 03:08:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 37a20954-9a9f-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=0JKAGs3MiNxef5GYhfLD8+bmnlGOpcQDgUTuRCZOkVk=; b=XusE4418O5AjnPl6RSRLx2MWuuij592HiHb0iB2zb8omhfXULsQ++1b/tnnrVEgSjlFJ rQhiLFbQvT8Dw5+BHPnrxCHwZDC8FbKGHr9RSh/Dy/YdANXn8yCduaL1R6Af9+1FGJB+ qNOEww3XYNkH9nLKIBSTDesrhcpnI4M6jBTvzHsGFhxaUtNAysZ+lKwyh/GkTqcEnJXF wobT+uo/a9U2JcTvtbA0eZsG8yuenAEKI95EIQSxqxbfAr3c10s7Qu6BcU1WJV7dso93 8Z5C77qYPPtPWL5ZTwGb4N9pIP7G9iR+UxEIpsO+3yU0RpENe23gPNXZtcBLxL1/xkSV vw== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dQUfFNJgq+r4bL4YenYyxXOEwMsqlAX83ZK052o1N+lKF8WbxUAA/5OXcZUx7kLxrfGiUQmrKDeOLrAgeZskPGEXnG7Dtz0Px4qRCdGNCHqmEMOay0QQKeIKzIAHjyR4CwyMCeZXf5off2/aClgYrIlvh63V3c2gvymFynXtnMlBVrlGJzw1LlmkueMUEnXDNd4Jn4V82cChJ1fdoGSkboHyyvdM8NVO9wRNxvbwD70kLohaIWnla59uT/aHsgEzQ5TMSozjkY5zQthi+ZxwuubTJeNovYFWlFkJbmLXqIoNaYJedZy7yqkbb1NR4V7okmv1CDD1iakNnrtH+nVZvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0JKAGs3MiNxef5GYhfLD8+bmnlGOpcQDgUTuRCZOkVk=; b=g9vZ60U9ynTe6fB6dYOjiy59KGaPYx3vJB2sgsBQpVKkXKfYv67Yjf7jJG7DxRU9jvKsAM7FAQqmLDEMVIFKqo29mi6OLKT1rYr3vFAw2aeWS+zXz3WaHQ6DSQqyiiD4TxjsS3ZT6Va6XqcU5yDHg8R00jXIlGI1jLY4HgXG5FJ2eoQq1lqXp+seRkLIpirMesi7SUl6BllLD9ozfrkTNbwC7C78+NVRUU1Qr1j6UrMtDzhPr6Gn9laMpnBn49+0ZWLohzPu3r6uOQW67J1w5A82bIs3mg4dsVaAKbQzOqPR8qKPQg5H6xQlqbUtYD+Obs/ZsOESbTZKDi1sy7KPkA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0JKAGs3MiNxef5GYhfLD8+bmnlGOpcQDgUTuRCZOkVk=; b=VyxphKp39ENkdx0Ia7xDhDBo1KfP/Z849Ltmzom8tn+QM5oadxPwXLSo+Q0Ye9v4k3/1y2qzhYuz1A1YvWXm+mCrN4WiZCXGHLSqltsM8a8wdcfIbUtPmeILokxs6Az/eusvWxyhWgqkjBuIZxqQlhMjyDZAyeaGchTqjL8GxfY= Subject: Re: [PATCH v4 2/2] xen: delay xen_hvm_init_time_ops() if kdump is boot on vcpu>=32 To: Boris Ostrovsky , xen-devel@lists.xenproject.org, x86@kernel.org Cc: linux-kernel@vger.kernel.org, jgross@suse.com, sstabellini@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, joe.jin@oracle.com References: <20220302164032.14569-1-dongli.zhang@oracle.com> <20220302164032.14569-3-dongli.zhang@oracle.com> <0ac50fb6-0aca-e61a-1f38-8badbc8c967a@oracle.com> <272a69ec-4cc8-f282-8499-88b24b61f130@oracle.com> From: Dongli Zhang Message-ID: Date: Wed, 2 Mar 2022 19:08:11 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 In-Reply-To: <272a69ec-4cc8-f282-8499-88b24b61f130@oracle.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DS7PR03CA0349.namprd03.prod.outlook.com (2603:10b6:8:55::24) To BYAPR10MB2663.namprd10.prod.outlook.com (2603:10b6:a02:a9::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0dd4993f-b93a-4d1d-c0a3-08d9fcc30f2b X-MS-TrafficTypeDiagnostic: BLAPR10MB5266:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qXXVbXnt1iqnTFIJaF6PAe1n1Sluxi1QDWvw4OXG4mW4sV1zO0xNARs0SRI2MD5TDnVoIegdET/t3LfyI1M+s+EMBd1PbCn/CBXu7UJCFH1upYtjRhwfUl1tSAQItRW2G7fb/yygM+X1sjz1/6BKT2HYnFVjy3hvCHXlTCbhmxQNL14M+YNXP8aYzdISXMVazoB7OI8L3+i6K15OWQVNBw1ycU3M/GVlDNe45wlGHbLgfmiFqkYzeUVlsgwjZ4N3Jm37/ta72AduAZVk1ajYLbc82XeFK+5ohCGq7tS9vFcrWZgNmVpkYW/Y890ByiLtfOC3kthZ8iz+sllBI7BvfAxVhIsUzDV5io5wI7FQ0Ed27LNPDHqRYK35XTO7WMhppaklYGSXfdQEY771QjOTSvq0mIDaFw0AGWa/Uh6TItW38a5vmEHM8aW+1hE3ShGRRrg5jbMt2g23oo5ePwPhxZTiR0UtWaIDN1f6YUnU9vYnHPKMdVz0Mj2glViY/Ti/Qpa+V7mPxbmNurq1XGdCcMHUeOnPnCpRlz5PB4VX2/yjoB97Y+AH2NFLrPJZaQEM5yp7vG/wSPpaznQWV52uKaz8qui44C/lxqD9eivnjXGGXy9rb+RXiNWhyPhy4A/0ZlMdEd2GxhIp3H9LH5DFIQnzMrK+quKG4JrZdNWlv+R/2sFTOOHRWfaPNtjGvAj3FZ2QD8FfxyDNg0pjYIaGreeEbgO+jN8z/kh7mzJvQSQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB2663.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2906002)(38100700002)(5660300002)(6512007)(86362001)(6506007)(53546011)(186003)(83380400001)(2616005)(316002)(8936002)(8676002)(4326008)(31686004)(6486002)(66476007)(66556008)(107886003)(508600001)(36756003)(6666004)(66946007)(44832011)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TjhTYVlZQkZVYS9pZjlGdWdtT3R2V01XUm5YQkFNZEVQTGhaMHNEcG1DMC9w?= =?utf-8?B?TkFONm1qenVRWHFSNXRmZWsrWElZRW9BamlRM0NSNHQ0eGRkZmlkaEQ5S01I?= =?utf-8?B?RTY4QzFWUktzdXJhYnJ0YmNyVlUrdHpVWXdTZkFZQnk3ZXBES3VTM3dvc3JL?= =?utf-8?B?ck82aWM4Y1lSejEyUDFNSmpkZHdvWjl1OC8wOGlpcHk0Y1lJZEpXUkhmc1c5?= =?utf-8?B?Tk9lYUdFWnlkWnUyazBsRW9Ua1YxSlFFQ1k1dW9laWZQV0RTa0xJaE1wR3ND?= =?utf-8?B?Qjk0cTlxQVlLenNhekVCdUhFbWdnNGxKdk9oa0svaHFsUnNSc2dvYWdDRFJV?= =?utf-8?B?TmhGSjhzNWVJTzl4TWRRYmVwNXVpcjZMaTh1bEkzbGVTS1NLS0dzajdhNGpl?= =?utf-8?B?Um55TDkrYlJybDJwWDlRelZQTDBZNXJOUnZGVXo4cnFRdnJBMEN4OGZUSEsv?= =?utf-8?B?b1pwTEM0c3ZLNWp5cTUxZ0FIdmZQVVZ3QWVYZ0RkemVhVWVhQ2IxREJkc3JF?= =?utf-8?B?YXpxTUYyWldQK2twUU8yOCtzNHRlRXJCdVp0U2NVaTlVcW1reGh5M0g5eWxQ?= =?utf-8?B?dS9kV21FVk0vTGlxajMzNmQvUkVrMFdmNlZvdDJEVW01SHkvenRFa09uODRx?= =?utf-8?B?Q2VsYVEvSkppcFJ1WWFoT1pRZVZHeHBPbk56VkU1NUVZSmQ0enB0VVZPQlF5?= =?utf-8?B?OHozV05DNnNoWDMwdWluZG1WVm5qejZOZjRtc3ZXVDVhdURUaG9UVFlrVDdn?= =?utf-8?B?WWdiVHFobzMwSDc3Q2F3ZTJENEM2ZlhmZS9UOThrZmJkdy8vT0pEdWNTcmx5?= =?utf-8?B?aWxLOFp0VHdRUjZYUm42cHVXVFRKdVRXRVI2UnpHWE55UEcxZHY1YkpsYkdq?= =?utf-8?B?U1BwTDRDQXVNVTJQcndaekZ5Ri9IWWJISHpycjA1S0Zac240MXorL0pGeGlS?= =?utf-8?B?bTBHdmlCc2V1SmdNUXZ6WTZGcjNWNFl0YVRyaWtsYWY2SWh6ZGpaTmF5cEUy?= =?utf-8?B?UW5MSDh4WmlyRENlMjBpai84N1lHZ2lzV2x4NE5ZSDRoODVHTmdKWElRNlZI?= =?utf-8?B?UTFrWXBZa0ZlU1c0R1ZhSEU0K1pVblFBSFhsb1VJbkZmWDBYRUlheXRDVmEw?= =?utf-8?B?TDVXWHFwSXlDMHRmWEs5SW5FdnhFY3FOUmdTbE1QUzlUQ3hTdU15NlB2Mytt?= =?utf-8?B?YVNZSHRzcll3ZjEyMGFKMkttdE5ycG9iTlhnRGF4VUJXaVdPeEJpSHUwLzZL?= =?utf-8?B?azJCOTB4OG9KMlpZelFzTGxPS2RreDVwcTVwRmVhSzJWUW5uWWFLNE84QTA3?= =?utf-8?B?QnUrdXNEY1NuMmhsdmVwWFhNUnNERnFJeFB2N2k4NXU2WUpaQjBDN1AzSjVR?= =?utf-8?B?b2xNY3pueGdXMi9Nb1ExVzRhd2FqazQ1akc3SUhjcXRjaFBLbjhKZmZienhv?= =?utf-8?B?YVkwOTVRaFVZOEVsZkJjd0lETk0raE1YR1BYNVhybmNERjY4NDdBY00xOXFQ?= =?utf-8?B?SUtDWkVNSXRXMTlsZ3UxOGdmRkYzTmF1OUdxbVBpOGtHdnc1UUhXMnpzclZv?= =?utf-8?B?UVZ2Q0hocGVJZkI0TUFzaHIwZll3eEJPNmppNHE4VmwrV1FUVmgySWtyV01H?= =?utf-8?B?TS9MVERpR0M4K2pTSGVMNm5DaFcrdlRZWUxZSklMUkV0MHo3cUZLeGFFTzJr?= =?utf-8?B?RmRnQTYxTUxVVFVFUHI2RUl5V3NxU0s3VkdqdGpXZTZjS2llWmdRVzVsa1hW?= =?utf-8?B?RTg5R3hDWlVMb2ZUTnAwUWJhOS93YXg5azFuQmNVaGgrTDhRUllZeDhCSWFB?= =?utf-8?B?c1piTHVSY0VidDNsTWF2aVB2UWJzRDNQMjRhWWJKblRwc0JkZjZNamlPQlBH?= =?utf-8?B?dXNwcVM5bTNJLzlaS0xoeXBnTWV3REdiMjkxdFB4SzNoZmExOGtBTzJBMXZk?= =?utf-8?B?alJ2Zk5kMnJ2ZzYxYllvT3g5VlA5K2tkL0pycytvc0E2Z0ZCMUdRM3VMckRE?= =?utf-8?B?cWllSHhGRWEwN3NpS2VIS1lSQVpIQ3ZabmwwcEQ0TmhnUWlkemoyd29DL1A2?= =?utf-8?B?dGFBK2JoMU5VWS9DYlNpdW9wMWR5Yk5sb0RtK3FxdCtybVdjcENOV3o4R0VD?= =?utf-8?B?TUViTmMyVk5FMnRlYnB0eTRCdk8wSDJzUHdWRVRES2NqbDJlYmZsV1ZGWHEz?= =?utf-8?Q?YLJSMCbGyYczwRnpZ8ylwURsCrwqL6OsQjO+/o2YL32K?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0dd4993f-b93a-4d1d-c0a3-08d9fcc30f2b X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2663.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2022 03:08:15.4389 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zbpf01CTvl83xg083UnYxM6arfRYKrx/snxv6Nq2+2pJtSJbsbV6Z9CIR4JcbdivwxSBRavh9pbg3xoZ6Et2Tg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5266 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10274 signatures=686787 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 malwarescore=0 mlxscore=0 phishscore=0 suspectscore=0 adultscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000 definitions=main-2203030012 X-Proofpoint-ORIG-GUID: RB8ru-RFzQv-fnzFJG3-adb2CHHvpdIW X-Proofpoint-GUID: RB8ru-RFzQv-fnzFJG3-adb2CHHvpdIW Hi Boris, On 3/2/22 6:11 PM, Boris Ostrovsky wrote: > > On 3/2/22 7:31 PM, Dongli Zhang wrote: >> Hi Boris, >> >> On 3/2/22 4:20 PM, Boris Ostrovsky wrote: >>> On 3/2/22 11:40 AM, Dongli Zhang wrote: >>>>    void __init xen_hvm_init_time_ops(void) >>>>    { >>>> +    static bool hvm_time_initialized; >>>> + >>>> +    if (hvm_time_initialized) >>>> +        return; >>>> + >>>>        /* >>>>         * vector callback is needed otherwise we cannot receive interrupts >>>>         * on cpu > 0 and at this point we don't know how many cpus are >>>>         * available. >>>>         */ >>>>        if (!xen_have_vector_callback) >>>> -        return; >>>> +        goto exit; >>> >>> Why not just return? Do we expect the value of xen_have_vector_callback to >>> change? >> I just want to keep above sync with .... >> >>> >>> -boris >>> >>> >>>>          if (!xen_feature(XENFEAT_hvm_safe_pvclock)) { >>>>            pr_info("Xen doesn't support pvclock on HVM, disable pv timer"); >>>> +        goto exit; >>>> +    } >> ... here. >> >> That is, I want the main logic of xen_hvm_init_time_ops() to run for at most >> once. Both of above two if statements will "go to exit". > > > I didn't notice this actually. > > > I think both of them should return early, there is no reason to set > hvm_time_initialized to true when, in fact, we have not initialized anything. > And to avoid printing the warning twice we can just replace it with pr_info_once(). > > > I can fix it up when committing so no need to resend. So unless you disagree Thank you very much for fixing it during committing. Dongli Zhang From xen-devel-bounces@lists.xenproject.org Thu Mar 03 03:54:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Mar 2022 03:54:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282733.481541 (Exim 4.92) (envelope-from ) id 1nPcY0-0006Ae-0R; Thu, 03 Mar 2022 03:54:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282733.481541; Thu, 03 Mar 2022 03:54:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPcXz-0006AX-Tp; Thu, 03 Mar 2022 03:54:35 +0000 Received: by outflank-mailman (input) for mailman id 282733; Thu, 03 Mar 2022 03:54:35 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPcXy-0006AR-SR for xen-devel@lists.xenproject.org; Thu, 03 Mar 2022 03:54:35 +0000 Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [2607:f8b0:4864:20::102e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a174f243-9aa5-11ec-8539-5f4723681683; Thu, 03 Mar 2022 04:54:32 +0100 (CET) Received: by mail-pj1-x102e.google.com with SMTP id k5-20020a17090a3cc500b001befa0d3102so2383137pjd.1 for ; Wed, 02 Mar 2022 19:54:31 -0800 (PST) Received: from localhost ([47.251.4.198]) by smtp.gmail.com with ESMTPSA id mu1-20020a17090b388100b001bedddf2000sm537800pjb.14.2022.03.02.19.54.29 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 02 Mar 2022 19:54:30 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a174f243-9aa5-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=V2/ej5DrRdUXhbTtL7As/s+7H+Hg/qh6D0nKyde9b4I=; b=Cf6C+jFzvaQJqp+87aHDyXKn1AnopM3mxsZXXVve5nRwKAHyoEW6RWZ82BxB1/MpAs YBeLSbTIABdPihhCBaQaZsH8HO4BpyuxMiloaRGq75Q5JXATrMsGuFrephWtRRSjs0d0 AP8Ob0+dxLcisk1yC6u47FptP4V+sB38bpPne1a+RruGrkn+5HAvkGofli4prSWlKBOk VY/TjCZNnz8fjIVkgNqx9yrwJT2Df9mWqoPIpIhEMtK4vr/RX1QVkozI+4TLCweH6z0C 6S5+8I7OuILJGTyjV4G8zHIXKeFnGVL+oaiF5ViG74XDU5C/o5tq6C3NiluQPvx+9TjH 10+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=V2/ej5DrRdUXhbTtL7As/s+7H+Hg/qh6D0nKyde9b4I=; b=c6uSIUARr3PpdfesYws6uJOnwhLcFMuoNilyjTXivDvypdhrCR33Ij+NUTwpfPPC5b 7I7X1oiNnRD2D0JDmZb8Dme7KqBQkALJZZwSWHUOXv+Kc1qAXiuVCkEY64HJ2NR6idMO ZRT/qb4pWq9MTVfdNsHQsypIfMfTchX9TV4Ug0fyRPOIQWkLzeS77R/7IY/nw48RLKDe v1k7KOt3jdFpf+fG54px2orCFdd60iInDoC/zJLOlxbBKGOOzTqlDdPC8DA8pQTp7JyO lChztkutO+nu84eQx+4XV9ieAFnxigXfpKdEUoBqxoggpcuB+sdHpHYlYfQfizJU8Kd6 pUrQ== X-Gm-Message-State: AOAM531Av+6dgPTD9G0JidMbxfXIfIRVZ0Pa7gYr+JWlbzh4NZXR/9v4 cCVo99Pzt6slsGlyImMvMik= X-Google-Smtp-Source: ABdhPJwMqYGzS+07MgSD+XrJLZC6tb4GmJcD1c0Voe27uz+8Clqe4zPHlwkCb0iXztvSKqT4uzsfvw== X-Received: by 2002:a17:902:e945:b0:14e:b8d9:aa07 with SMTP id b5-20020a170902e94500b0014eb8d9aa07mr33517195pll.163.1646279670545; Wed, 02 Mar 2022 19:54:30 -0800 (PST) From: Lai Jiangshan To: linux-kernel@vger.kernel.org Cc: x86@kernel.org, Lai Jiangshan , xen-devel@lists.xenproject.org, Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" Subject: [PATCH V2 5/7] x86/entry: Don't call error_entry for XENPV Date: Thu, 3 Mar 2022 11:54:32 +0800 Message-Id: <20220303035434.20471-6-jiangshanlai@gmail.com> X-Mailer: git-send-email 2.19.1.6.gb485710b In-Reply-To: <20220303035434.20471-1-jiangshanlai@gmail.com> References: <20220303035434.20471-1-jiangshanlai@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Lai Jiangshan When in XENPV, it is already in the task stack, and it can't fault for native_iret() nor native_load_gs_index() since XENPV uses its own pvops for iret and load_gs_index(). And it doesn't need to switch CR3. So there is no reason to call error_entry() in XENPV. Cc: xen-devel@lists.xenproject.org Signed-off-by: Lai Jiangshan --- arch/x86/entry/entry_64.S | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/arch/x86/entry/entry_64.S b/arch/x86/entry/entry_64.S index 630bf8164a09..adc9f7619d1b 100644 --- a/arch/x86/entry/entry_64.S +++ b/arch/x86/entry/entry_64.S @@ -325,8 +325,17 @@ SYM_CODE_END(ret_from_fork) PUSH_AND_CLEAR_REGS ENCODE_FRAME_POINTER - call error_entry - movq %rax, %rsp /* switch stack settled by sync_regs() */ + /* + * Call error_entry and switch stack settled by sync_regs(). + * + * When in XENPV, it is already in the task stack, and it can't fault + * for native_iret() nor native_load_gs_index() since XENPV uses its + * own pvops for iret and load_gs_index(). And it doesn't need to + * switch CR3. So it can skip invoking error_entry(). + */ + ALTERNATIVE "call error_entry; movq %rax, %rsp", \ + "", X86_FEATURE_XENPV + ENCODE_FRAME_POINTER UNWIND_HINT_REGS -- 2.19.1.6.gb485710b From xen-devel-bounces@lists.xenproject.org Thu Mar 03 03:54:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Mar 2022 03:54:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282734.481552 (Exim 4.92) (envelope-from ) id 1nPcYE-0006Uf-8P; Thu, 03 Mar 2022 03:54:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282734.481552; Thu, 03 Mar 2022 03:54:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPcYE-0006UY-5I; Thu, 03 Mar 2022 03:54:50 +0000 Received: by outflank-mailman (input) for mailman id 282734; Thu, 03 Mar 2022 03:54:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPcYD-0006U6-Ej for xen-devel@lists.xenproject.org; Thu, 03 Mar 2022 03:54:49 +0000 Received: from mail-pg1-x52e.google.com (mail-pg1-x52e.google.com [2607:f8b0:4864:20::52e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ab1d001e-9aa5-11ec-8eba-a37418f5ba1a; Thu, 03 Mar 2022 04:54:48 +0100 (CET) Received: by mail-pg1-x52e.google.com with SMTP id w37so3419279pga.7 for ; Wed, 02 Mar 2022 19:54:48 -0800 (PST) Received: from localhost ([47.251.4.198]) by smtp.gmail.com with ESMTPSA id u9-20020a17090a450900b001b9b5ca299esm6563740pjg.54.2022.03.02.19.54.45 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 02 Mar 2022 19:54:46 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ab1d001e-9aa5-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=AOa0Ei1g6e4VlPBDw15RL007lSMOSrMvUzhJPGj9XAI=; b=eCXzMPrvm0QclKJ/8ESlhGV7ol/xxd0jxpeS+MvgphVnb3ojFQ+gK3KpzVzxxo+qxL bSwolL7L4dDMj29c6jcEc1th4JLA9CD7t1+M9csTffdIwf8P2wU9ny44rUGuPNQniOI1 pnMvB/X0OUgGWfcOq34wjA3TelHnDUsNdSgJySjD8a/FFtMMAYcsRWDohcAX9uOVozdE QrdI+LUylMbE4ZX7ar5lagHtuezvvHoHZ3nhwbj9fTS2Y5BS9QJyh0TX3yGTc18iUKBh 5WIINkssRb+sUqfobVqg4UU1pYTHt8iJmT0HEoIu94SMlrTbnDDdR9kGa4WLB7noP1qy HDTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=AOa0Ei1g6e4VlPBDw15RL007lSMOSrMvUzhJPGj9XAI=; b=hSLXxBw3Rpd9h9BO89ImV38vboK6TS0UPI+K87bMh/U5BHTA/JPfv0Cit9dxCeh3qz 3t6IsX9krF6bxLMB61r4z09rHkgvxjVyt0rR971U1qx63tOyHjI1v9/3v9qXhgyuBOlr nARkMqLmdCk18O2E/o4QUpf04Eymi5GxBmM9Ft2k5bRCPs7swd0qnt2kVUez+Uriyh/C /SBj6JvTHEa1N9YHZ9cYzWhpDseapARrrIX/4Etcz49j0bEWA8OG6UICySXHriOClEQG CpuOlwibxOQJQxkob6YYxuYSbbz2wrxgw3zWHvMLgR/zJcdi41XHkuquyYRDW9Svyp9o kbIw== X-Gm-Message-State: AOAM532yhGiS2hFJev2kcpBfJ0XopBFi8TmT2x47ReBo5DXy0Y3SYwQd Sb/iF13Xk36JwXjeSei4Skc= X-Google-Smtp-Source: ABdhPJwuPPW+OW04xR5tRD6ZiwBqHBvxNWZMWDjet+tD/wstzrZ9p5WcmL5uWKiurXsOsVmlNtqIuQ== X-Received: by 2002:a63:6b42:0:b0:37c:4e5c:a903 with SMTP id g63-20020a636b42000000b0037c4e5ca903mr2183734pgc.463.1646279686726; Wed, 02 Mar 2022 19:54:46 -0800 (PST) From: Lai Jiangshan To: linux-kernel@vger.kernel.org Cc: x86@kernel.org, Lai Jiangshan , xen-devel@lists.xenproject.org, Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Juergen Gross , "Peter Zijlstra (Intel)" , "Kirill A. Shutemov" Subject: [PATCH V2 7/7] x86/entry: Convert SWAPGS to swapgs and remove the definition of SWAPGS Date: Thu, 3 Mar 2022 11:54:34 +0800 Message-Id: <20220303035434.20471-8-jiangshanlai@gmail.com> X-Mailer: git-send-email 2.19.1.6.gb485710b In-Reply-To: <20220303035434.20471-1-jiangshanlai@gmail.com> References: <20220303035434.20471-1-jiangshanlai@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Lai Jiangshan XENPV doesn't use swapgs_restore_regs_and_return_to_usermode(), error_entry() and entry_SYSENTER_compat(), so the PV-awared SWAPGS in them can be changed to swapgs. There is no user of the SWAPGS anymore after this change. The INTERRUPT_RETURN in swapgs_restore_regs_and_return_to_usermode() is also converted. Cc: xen-devel@lists.xenproject.org Reviewed-by: Juergen Gross Signed-off-by: Lai Jiangshan --- arch/x86/entry/entry_64.S | 10 +++++----- arch/x86/entry/entry_64_compat.S | 2 +- arch/x86/include/asm/irqflags.h | 2 -- 3 files changed, 6 insertions(+), 8 deletions(-) diff --git a/arch/x86/entry/entry_64.S b/arch/x86/entry/entry_64.S index 88b61f310289..d9c885400034 100644 --- a/arch/x86/entry/entry_64.S +++ b/arch/x86/entry/entry_64.S @@ -644,8 +644,8 @@ SYM_INNER_LABEL(swapgs_restore_regs_and_return_to_usermode, SYM_L_GLOBAL) /* Restore RDI. */ popq %rdi - SWAPGS - INTERRUPT_RETURN + swapgs + jmp native_iret SYM_INNER_LABEL(restore_regs_and_return_to_kernel, SYM_L_GLOBAL) @@ -1007,7 +1007,7 @@ SYM_CODE_START_LOCAL(error_entry) * We entered from user mode or we're pretending to have entered * from user mode due to an IRET fault. */ - SWAPGS + swapgs FENCE_SWAPGS_USER_ENTRY /* We have user CR3. Change to kernel CR3. */ SWITCH_TO_KERNEL_CR3 scratch_reg=%rax @@ -1039,7 +1039,7 @@ SYM_CODE_START_LOCAL(error_entry) * gsbase and proceed. We'll fix up the exception and land in * .Lgs_change's error handler with kernel gsbase. */ - SWAPGS + swapgs /* * Issue an LFENCE to prevent GS speculation, regardless of whether it is a @@ -1060,7 +1060,7 @@ SYM_CODE_START_LOCAL(error_entry) * We came from an IRET to user mode, so we have user * gsbase and CR3. Switch to kernel gsbase and CR3: */ - SWAPGS + swapgs FENCE_SWAPGS_USER_ENTRY SWITCH_TO_KERNEL_CR3 scratch_reg=%rax diff --git a/arch/x86/entry/entry_64_compat.S b/arch/x86/entry/entry_64_compat.S index a4fcea0cab14..72e017c3941f 100644 --- a/arch/x86/entry/entry_64_compat.S +++ b/arch/x86/entry/entry_64_compat.S @@ -49,7 +49,7 @@ SYM_CODE_START(entry_SYSENTER_compat) UNWIND_HINT_EMPTY /* Interrupts are off on entry. */ - SWAPGS + swapgs pushq %rax SWITCH_TO_KERNEL_CR3 scratch_reg=%rax diff --git a/arch/x86/include/asm/irqflags.h b/arch/x86/include/asm/irqflags.h index 87761396e8cc..ac2e4cc47210 100644 --- a/arch/x86/include/asm/irqflags.h +++ b/arch/x86/include/asm/irqflags.h @@ -140,13 +140,11 @@ static __always_inline void arch_local_irq_restore(unsigned long flags) #else #ifdef CONFIG_X86_64 #ifdef CONFIG_XEN_PV -#define SWAPGS ALTERNATIVE "swapgs", "", X86_FEATURE_XENPV #define INTERRUPT_RETURN \ ANNOTATE_RETPOLINE_SAFE; \ ALTERNATIVE_TERNARY("jmp *paravirt_iret(%rip);", \ X86_FEATURE_XENPV, "jmp xen_iret;", "jmp native_iret;") #else -#define SWAPGS swapgs #define INTERRUPT_RETURN jmp native_iret #endif #endif -- 2.19.1.6.gb485710b From xen-devel-bounces@lists.xenproject.org Thu Mar 03 05:17:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Mar 2022 05:17:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282747.481563 (Exim 4.92) (envelope-from ) id 1nPdpa-0001Hm-1b; Thu, 03 Mar 2022 05:16:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282747.481563; Thu, 03 Mar 2022 05:16:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPdpZ-0001Hf-Ut; Thu, 03 Mar 2022 05:16:49 +0000 Received: by outflank-mailman (input) for mailman id 282747; Thu, 03 Mar 2022 05:16:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPdpZ-0001HV-2I; Thu, 03 Mar 2022 05:16:49 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPdpY-00052g-VP; Thu, 03 Mar 2022 05:16:48 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPdpY-000691-Dv; Thu, 03 Mar 2022 05:16:48 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nPdpY-0004Ex-DT; Thu, 03 Mar 2022 05:16:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=xOt5Qr8jQ+5agXz6uouZ9ARHPeVRPS39qMZZxcyFn5k=; b=yhWYXUBWvhbs5/Q1GJ7oys9AZQ Y57La6f9/gj11uUwL2b8ApQw6HD4QXqH0AwIN70KT8wu/KKvgmXY9MCKipSh1UQg6XUOqMy+BySU7 IfZ/pHtS8i7wS0WQ1pckSQvP+AemiW2SbFHKIY5ecRMOgZZAOQUX0tjiVgMeVpgm3L7c=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 168346: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=92ebf5f91b4dd5156886d2509202be0fb4230dfd X-Osstest-Versions-That: linux=fb184c4af9b9f4563e7a126219389986a71d5b5b From: osstest service owner Date: Thu, 03 Mar 2022 05:16:48 +0000 flight 168346 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/168346/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 168326 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 168326 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 168326 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 168326 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 168326 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 168326 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 168326 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168326 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: linux 92ebf5f91b4dd5156886d2509202be0fb4230dfd baseline version: linux fb184c4af9b9f4563e7a126219389986a71d5b5b Last test of basis 168326 2022-03-02 06:22:48 Z 0 days Testing same since 168346 2022-03-02 20:40:06 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Dave Jiang Gao Xiang Gustavo A. R. Silva Jerry Dai Jon Mason Linus Torvalds jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git fb184c4af9b9..92ebf5f91b4d 92ebf5f91b4dd5156886d2509202be0fb4230dfd -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Thu Mar 03 05:25:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Mar 2022 05:25:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282760.481575 (Exim 4.92) (envelope-from ) id 1nPdyD-0002nU-2N; Thu, 03 Mar 2022 05:25:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282760.481575; Thu, 03 Mar 2022 05:25:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPdyC-0002nN-VT; Thu, 03 Mar 2022 05:25:44 +0000 Received: by outflank-mailman (input) for mailman id 282760; Thu, 03 Mar 2022 05:25:43 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPdyB-0002nD-Ak; Thu, 03 Mar 2022 05:25:43 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPdyB-0005BT-8I; Thu, 03 Mar 2022 05:25:43 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPdyA-0006s3-QN; Thu, 03 Mar 2022 05:25:42 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nPdyA-0003QB-Pw; Thu, 03 Mar 2022 05:25:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=L3mk3bcaFDESHTmfalqOEWL1uoASix9TIjK6Sx8He7Y=; b=V5Q0QvV2qwSCT8cgO/AagiowmY 6OJjrllX6zlIlbB+JfO/4fHkYKYvJQXV7d6BHSt51cQY1p/HK/uBmAvL6/M5hPPiniJYGhm0PF1KZ eVPKWMHq6VCiPoVreUhLOt1YTLCkVLQiYSS+Q0dKAlk+eNw6LHdCpRCaBOn0KPaVBr+0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 168343: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=64ada298b98a51eb2512607f6e6180cb330c47b1 X-Osstest-Versions-That: qemuu=09591fcf6eb3157ab9c50a9fbbef5f8a567fb49f From: osstest service owner Date: Thu, 03 Mar 2022 05:25:42 +0000 flight 168343 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/168343/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 168327 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 168327 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168327 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 168327 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 168327 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 168327 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 168327 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 168327 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu 64ada298b98a51eb2512607f6e6180cb330c47b1 baseline version: qemuu 09591fcf6eb3157ab9c50a9fbbef5f8a567fb49f Last test of basis 168327 2022-03-02 07:38:29 Z 0 days Testing same since 168343 2022-03-02 18:07:05 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alex Bennée Bernhard Beschow Christian Borntraeger Cornelia Huck Cédric Le Goater Daniel Henrique Barboza Greg Kurz Kyle Evans Leandro Lupori Lucas Coutinho Lucas Mateus Castro (alqotel) Lucas Mateus Castro (alqotel) Luis Pires Matheus Ferst Peter Maydell Richard Henderson Stacey Son Thomas Huth Víctor Colombo Warner Losh jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 09591fcf6e..64ada298b9 64ada298b98a51eb2512607f6e6180cb330c47b1 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Thu Mar 03 06:01:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Mar 2022 06:01:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282772.481586 (Exim 4.92) (envelope-from ) id 1nPeWp-0008Sg-Ox; Thu, 03 Mar 2022 06:01:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282772.481586; Thu, 03 Mar 2022 06:01:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPeWp-0008SZ-Lc; Thu, 03 Mar 2022 06:01:31 +0000 Received: by outflank-mailman (input) for mailman id 282772; Thu, 03 Mar 2022 06:01:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPeWn-0008SP-In; Thu, 03 Mar 2022 06:01:29 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPeWn-0005qM-GP; Thu, 03 Mar 2022 06:01:29 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPeWn-0000vk-5i; Thu, 03 Mar 2022 06:01:29 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nPeWn-0004qO-5F; Thu, 03 Mar 2022 06:01:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=uSkNyaFzJKrNSdYw0/UghRP7gq5ZnusPuuLfapNlxLk=; b=BOSPmrPKqiYiJ40xsZsyxZt/50 ZgKugjBc24LVNCCx7lS54Q4GVHzZ4rQaqWn2FylUQ0I7kPl4sHndaaSaiDoYs6/n81L78FBHXKRLP iAna9RtwhF1tD6C9q0lCT7/+/AZ4Y1FZ4jY72ZYGksidW/80nnMhtYx0W5x8M1T4RpD8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 168352: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=dc39554d58af4a50b50eca1f57c49415a12b0c98 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Thu, 03 Mar 2022 06:01:29 +0000 flight 168352 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/168352/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf dc39554d58af4a50b50eca1f57c49415a12b0c98 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 2 days Failing since 168258 2022-03-01 01:55:31 Z 2 days 19 attempts Testing same since 168316 2022-03-02 02:50:20 Z 1 days 7 attempts ------------------------------------------------------------ People who touched revisions under test: Guomin Jiang Jason Jason Lou Xiaolu.Jiang jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit dc39554d58af4a50b50eca1f57c49415a12b0c98 Author: Xiaolu.Jiang Date: Tue Feb 22 22:14:05 2022 +0800 edk2/MdeModulePkg/Debuglib: Add Standalone MM support https://bugzilla.tianocore.org/show_bug.cgi?id=3844 This change added Standalone MM instance of DebugLib. Reviewd-by: Jian J Wang Reviewd-by: Liming Gao Signed-off-by: Xiaolu.Jiang commit 497ac7b6d7f9750f48f137db244931a5728b1968 Author: Guomin Jiang Date: Sat Jan 29 16:28:02 2022 +0800 UefiPayloadPkg/PayloadLoaderPeim: Use INT64 as input parameter REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3818 It will have some potential issue when memory larger than 2G because the high memory address will be fill with 0xFFFFFFFF when do the operation of INTN + INT64 but it is 32 bit normal data in fact. Should use same data type INT64 + INT64. V3: 1. Use INT64 as input parameter because all date type is 64 bit V2: 1. Force the data type to UINTN to avoid high dword be filled with 0xFFFFFFFF 2. Keep INTN because the offset may postive or negative. Reviewed-by: Guo Dong Reviewed-by: Ray Ni Signed-off-by: Guomin Jiang commit 6a890db161cd6d378bec3499a1e774db3f5a27a7 Author: Jason Date: Mon Jan 10 22:30:29 2022 +0800 BaseTools: Upgrade the version of NASM tool REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Upgrade the version of NASM tool to avoid compilation errors when compiling NASM code change. Signed-off-by: Jason Lou Cc: Bob Feng Cc: Liming Gao Reviewed-by: Yuwei Chen commit bbaa00dd01ed0df30e43a5a89fd2b0433d858b73 Author: Jason Date: Mon Jan 10 22:05:47 2022 +0800 MdePkg: Remove the macro definitions regarding Opcode. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Remove the macro definitions regarding Opcode because new version of NASM tool(e.g. v2.15.05) supports the corresponding instructions. Note: This patch need to be merged after other NASM code change to avoid compilation errors. Signed-off-by: Jason Lou Cc: Michael D Kinney Reviewed-by: Liming Gao Cc: Zhiguang Liu commit 2aa107c0aa2e1375651867c8df1b81ff64b67fce Author: Jason Date: Mon Jan 10 22:01:18 2022 +0800 UefiCpuPkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Reviewed-by: Ray Ni Cc: Eric Dong Cc: Laszlo Ersek Cc: Rahul Kumar commit 7bc8b1d9f412507d579f21ea9af56fced81e7827 Author: Jason Date: Mon Jan 10 21:52:52 2022 +0800 SourceLevelDebugPkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Reviewed-by: Hao A Wu commit d3febfd9ade35dc552df6b3607c2b15d26b82867 Author: Jason Date: Mon Jan 10 21:46:27 2022 +0800 MdePkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Cc: Michael D Kinney Reviewed-by: Liming Gao Cc: Zhiguang Liu commit 84338c0d498555f860a480693ee8647a1795fba3 Author: Jason Date: Mon Jan 10 21:04:09 2022 +0800 MdeModulePkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Reviewed-by: Ray Ni Cc: Dandan Bi Reviewed-by: Liming Gao From xen-devel-bounces@lists.xenproject.org Thu Mar 03 07:35:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Mar 2022 07:35:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282789.481603 (Exim 4.92) (envelope-from ) id 1nPfzi-0003Zg-Rn; Thu, 03 Mar 2022 07:35:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282789.481603; Thu, 03 Mar 2022 07:35:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPfzi-0003ZZ-Oh; Thu, 03 Mar 2022 07:35:26 +0000 Received: by outflank-mailman (input) for mailman id 282789; Thu, 03 Mar 2022 07:35:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPfzh-0003ZT-Df for xen-devel@lists.xenproject.org; Thu, 03 Mar 2022 07:35:25 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7b42c798-9ac4-11ec-8539-5f4723681683; Thu, 03 Mar 2022 08:35:24 +0100 (CET) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04lp2056.outbound.protection.outlook.com [104.47.13.56]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-17-7nupT1WJOrij8C13BCW-EQ-1; Thu, 03 Mar 2022 08:35:19 +0100 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by AM0PR0402MB3860.eurprd04.prod.outlook.com (2603:10a6:208:7::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.26; Thu, 3 Mar 2022 07:35:18 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5038.014; Thu, 3 Mar 2022 07:35:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7b42c798-9ac4-11ec-8539-5f4723681683 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1646292921; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VbeiCm2e1x/yLymCk0s7vQDaAs+AoczwFGivaOIU1IU=; b=iTqj0Cg9Xm/NIX0gbutHYIqBsHBklP09JFiEqvD3xKWToKvoXeBJP/NkZr3WYCtiSJNgzI L0jdrbY701ETvLhIjSJqhHuY46kGIHWTW5KtvUDEf/qbbchzw8KIvS/lYEAS5VbCB0Q78U kCblEAz6bUrgBApukkxguEW+lVKYkDQ= X-MC-Unique: 7nupT1WJOrij8C13BCW-EQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h6w8Par4tztUlh96tKk6ol+FFWGwBnLuTZi5zoDZd87i2RwnJY1gWTWE8ycpGGLf7APgzM6yWgyXJfrhFHpI6ML+oqqgKzzhOSOwpEiQXLO5s4W9P8ZwQLz51RuK1TFufjG37uHpHLNM8bbcFqw5V9R5XBL3Mv/cMT5YQFoXgP0LeYwx0G6Jv15SqIlob9xuKO+ROINPumWuiI7WaxsCggRqfVtZKqAyhztCfb4+4zLi2TMbDFbmxUXhq3TAai4gjRgxz/KBVcsOI87ZD6DLwh8zEHPAwJkA7qCVKdNZCdDgnwafS8dDcIxUb70Azb2QpP9f+nIsRBNY0lrs0MD/Ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VbeiCm2e1x/yLymCk0s7vQDaAs+AoczwFGivaOIU1IU=; b=UlN563YoiJnCDWyE0YDlk01gARZvvr34BgxhUBNzidipWWHBfCwqmf07jw2V0GoW5uV2QL6xg100TW0wjEj/wzjXQjxaWuL1ACyuGjyjEhEvp656WHLBbwqNeePzvhhBHH/usaY6H06B4jb/OsHtwcgqFCpODdUR1khRaA1uHJeDL9yxOy3//09ivYcnZNbRyPgdOWTFEKHpyHlg4b5Md7aXbJlrfbA7kvmZ7hkSIbtgsOjoI+pO3KXhKBHYzN8ZOKFPMmsxQzOiuRSRzEtL/bOhl01FxhiLKnI8JAVUjih3LjjIvuaWGcq3cVSA6ajk4o79vc/pVyIQ729VHtopww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <8eb7d30e-32de-fdee-43c9-3500fb10e6ee@suse.com> Date: Thu, 3 Mar 2022 08:35:16 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH] xen/CET: Fix __initconst_cf_clobber Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20220302221005.16636-1-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20220302221005.16636-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6PR0202CA0055.eurprd02.prod.outlook.com (2603:10a6:20b:3a::32) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0e652828-cdcf-4ef4-9602-08d9fce85d53 X-MS-TrafficTypeDiagnostic: AM0PR0402MB3860:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: c9Ii8fRtOMM1BzOEB0QRCNSr1U/n9MJG187XIOLnFMbvS0P6nhnbXzMB3bgcZ+qseygrUpN0ujVm4vk+wujM9q472moNuEHydIokurf6XIhmsocQ1CifsRNbTpoxi7P1mYOkQeHLsDfnKpsOzYAZBy0Aqv5VolfZ/tMFuBkgDsmksC/PVEaIVdFO7JOD/YE9X+HIi6tfVy7rpfzUvpTMxYU/hrFplVPP4v7I8OpBc7GRo8Aielx0ORPTad8wiJ81JmFQo4AZnh3NC23/p4npAPRwTp1yIHBddRpqpRcesRbViAo8CSECkRdqQNrxzjjJydIIhLdwVoOj+56yEvVyUKTeWfEXv8icSflaBvRu+7UJILbEfvwRo96byG4Up/29vApySmt9kitI7W39f5b2UVcfKbciVw3J9Tba6SFwkQkbc6RtpO78/oDc4WdE1jRNygf1OcilEWSVR9s3oe60NB67bRgqafasSGP31/XVVjhYN4gBkEhKzWdTHbXTgQGZQm5t6IEsHVnkjkDPzxxQ4Dz8JmslYpF4E+PGqJNjntBoqlh4QuiYnA/2RZnCseFT4kN4XFf0R1FdIecrPJ6C2s0QvKdFs6yc/AC5u3LGIB3ff46HiR5bd2uMZtXmmMaHHkLK9bj6OeLZCio186v0WfQwCCmehyTkve9GpNvY+4dmO2suhePDQHfQzhkIi6+66AzUuY5rhjpGPavC22JtHixyh1E9YwmwrGfGEBy4nqs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(5660300002)(8936002)(31696002)(2906002)(86362001)(38100700002)(8676002)(4326008)(66556008)(66476007)(26005)(186003)(66946007)(6506007)(316002)(6512007)(2616005)(53546011)(36756003)(54906003)(6916009)(508600001)(31686004)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TzN0dzFBNkU2K2t0cVN1VG1jVmRSWllKbk1sekhQaW9KazFCZGpWYkRNNlk1?= =?utf-8?B?cllxYndVRFg5WnpHTk00c051U25sRXpjT3V2Ri9FckFWclFWZFFkRVNmRlgr?= =?utf-8?B?N0MzRkNxNExOcGFHSWVKaW4vbHErYTRVT0R0ZEpvSGtvNFp0MkRzRkI0SHdS?= =?utf-8?B?ekc0OHFKREhveWtzN0gvNmU2RHM0VVJZOFZRZkVtMW41dm4zN0I3VmZlL05I?= =?utf-8?B?ZFRZQngzaVFSTUM0WGpuRElHT28wblhWeWRPcHRlN2h4K25BZ285aVBNMUly?= =?utf-8?B?c0NsdEJwcEZQWlZUYmQ2WHdxM01qeU9EVFd1aHNYckl3T0Ruc0gzVklhdnh4?= =?utf-8?B?eEt4TXVkdXlYelBZK3JWamFGOXROdHFqbkE4MllJOXJhelNWc0o5WGRCd2xD?= =?utf-8?B?YkphWGRPeXk4SmI4bzVvY2o4SHFTbWVCNGhEM1hMN2hWeWl0ZmhIbmF5ZGdk?= =?utf-8?B?bG5pbXJYZzRVL05CT0dvZm1oRDg1ZUI0d3FXK3VtZEdlVHEwS2VTQnRMUENJ?= =?utf-8?B?MGRZUkNnK2NPakc2bXJzN1Q3S2RBbzJDbENnc2FVVVpoL3AwQ3QyWjhndnVW?= =?utf-8?B?RnlNeXNmT21RVXVwUVVrZ0Vyb01nWWxKT3QyYXMwcXNnOXlTS0hFWWVaZlpi?= =?utf-8?B?Nll4dU1MSTdkYWhQWThsVzMvb0NzQjYyZjdiL0tFRkNCcFhlU1lyQnFTOVZ3?= =?utf-8?B?TnA5c3Z3SnllZWxaQ2FhdDhKYm1ob1psSmpjdXJGaW9seUZTcS9sVk9rV3Bx?= =?utf-8?B?VHFzcldqbnR5Mk4wQkNHQnJlUE5PUGZqbGdsY3JCTU1SZ1pqcDNkbE8yYzQy?= =?utf-8?B?dEhOSXlBNGkwMXNkejFyeFJVMXY2ZU5iYkNodysrR09MRnJVNEtsck5LTVpj?= =?utf-8?B?VzRleW94Q1FmVDJPcWVidzZYU2J2NEthaTl0VnJUQ2ZyRjhHMnRndmJOdysr?= =?utf-8?B?ZjE0RG01dVM4d0YycWlDNDNQRDNOWHpzYnNTZisycFF2SEozby9PTEU0djhP?= =?utf-8?B?YnRka0hOWW1YWnVDYTd2WVlUUFZ3eGRwR0tZK29SM3RPZDV1YnEyZFdMZUxv?= =?utf-8?B?YVIvc3dwYWtuOEFTcER5a2xQMUc0YlR5bEtkWjF4c2JKOHBjL2ExYmpLdkwx?= =?utf-8?B?dlZZUFVTUTlnYnU5NGtlb1VOcVlFWElNZ2FtUFJ5WDdoUU5lVmV5ckYzMHJj?= =?utf-8?B?dlpqTE9aakI0V0RZN3VDdzBEYWpXdVRqUmQ5V2VDbGZ2YS9mRjJ3SjBoS0FI?= =?utf-8?B?b0RUankzTHFyd052VVdKNUxGQ0xNcW5JeDlmMWJaZ1ZJenhPSnFFVXhXTThV?= =?utf-8?B?MUVBQ0h5SFNUci9jaURNenhYNHFwYU9uQkxTc0MxNDI2QUR5bHNzNmQ4R3Jm?= =?utf-8?B?cWNNZjI5K25KYllyZmNDMVZlSHhqMzIrZWhFOEJna2xaVDVOVlkzd04wQXJw?= =?utf-8?B?UlRMYVl6ak5BanpWWlZBd3E5eFNoaE05Mk5STXhsc1R6TkpxTVRsWlZEVDFC?= =?utf-8?B?dzV6SlFTeUVUMnhjTzByaG1STUh3Z1lJczRxNERBalRFTWRRenVtY1pRMU1D?= =?utf-8?B?TWNZTlkyRzV6ZzZHcXRoWG43YnFoQU1vNmVEWlQ1V2FKWE13NU5UcWtvNVB5?= =?utf-8?B?OXU3MSswczV2bnY1c1NBdkhtSE9aT1V2Q1lrdjBnZHVybm43MUNkU0h4REs3?= =?utf-8?B?d2pzUWF4RUljVEZCZ3RrdVgrMkUwRzUxNU1VQ3h2WkVFcEVCN2FxU0c2NnBt?= =?utf-8?B?dVhBRGtpdk5US0xyN2ZDSlFmcFhTckY3ZjJSNXNBRUtNOWxhKzhLdm84WTdo?= =?utf-8?B?U3FhZ1UxcnF6bUZmMEF2RVNSaS9pVGpXdlVkVnpJb0VDcll2QjA3VFhLRDJo?= =?utf-8?B?TWRLSkFnYWNQQllzN2czMERhNGhxZnk3NURnc0E5U20veS8xNWlIdFRZSmFN?= =?utf-8?B?ZjNWTHhlQzhuNEQ1RlNkSjJRTndQd3dBMG54cE9sMU5uR21FTUtteW9aLzBO?= =?utf-8?B?amNVMnRNcU1URHJoZkdzTk5GeEZ4cW9jd1U0c0dOa3NvNjBoZGdMRjAxS0Rn?= =?utf-8?B?cVVWR1dmYjR2OCswODhZTEtOcGJpNDlIOHJvZFpENzgvRXBGVmkxb1hoQmpz?= =?utf-8?B?VzdESkZPRmlLTUNtODFHenNGRmQ1VmJMeWwyQm8rRWo4MThFNDBGNDd5NGll?= =?utf-8?Q?Ay2RYIclpLDQBO37I+OBda0=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0e652828-cdcf-4ef4-9602-08d9fce85d53 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2022 07:35:18.0506 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QjRwahwClgnZR6410qIx7iQFaVn6NOsEdhWB0bBOG2fRGb7bSMOcd8XM5b7cZhuY977cQv6DYpL/B4bsoK9tcw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0402MB3860 On 02.03.2022 23:10, Andrew Cooper wrote: > The linker script collecting .init.rodata.* ahead of .init.rodata.cf_clobber > accidentally causes __initconst_cf_clobber to be a no-op. > > Rearrange the linker script to unbreak this. > > The IOMMU adjust_irq_affinities() hooks currently violate the safety > requirement for being cf_clobber, by also being __initcall(). > > Consolidate to a single initcall using iommu_call() (satisfying the cf_clobber > safety requirement), and also removes the dubious property that we'd call into > both vendors IOMMU drivers on boot, relying on the for_each_*() loops to be > empty for safety. > > With this fixed, an all-enabled build of Xen has 1681 endbr64's (1918 > including .init.text) with 382 (23%) being clobbered during boot. > > Signed-off-by: Andrew Cooper This will do for the immediate purpose, so: Reviewed-by: Jan Beulich > I was unsure whether to go common or x86 spefific IOMMU code, so went with the > conservative option. The final hunk can trivially move if preferred. The hook is x86-specific, so the wrapper should be too (and the existing inline wrapper also is). > --- a/xen/arch/x86/xen.lds.S > +++ b/xen/arch/x86/xen.lds.S > @@ -210,6 +210,12 @@ SECTIONS > DECL_SECTION(.init.data) { > #endif > > + . = ALIGN(POINTER_ALIGN); > + __initdata_cf_clobber_start = .; > + *(.init.data.cf_clobber) > + *(.init.rodata.cf_clobber) > + __initdata_cf_clobber_end = .; > + > *(.init.rodata) > *(.init.rodata.*) I wonder if this shouldn't really be two sections. Live-patching will need to supply two ranges to apply_alternatives() anyway (one for each section, unless you want to start requiring to pass a linker script to "$(LD) -r" when generating live patches, just to fold the two sections), so in the core hypervisor we may want to follow suit. > --- a/xen/drivers/passthrough/x86/iommu.c > +++ b/xen/drivers/passthrough/x86/iommu.c > @@ -462,6 +462,12 @@ bool arch_iommu_use_permitted(const struct domain *d) > likely(!p2m_get_hostp2m(d)->global_logdirty)); > } > > +static int cf_check __init adjust_irq_affinities(void) > +{ > + return iommu_call(&iommu_ops, adjust_irq_affinities); > +} > +__initcall(adjust_irq_affinities); I assume it is intentional that you didn't re-use the inline wrapper, to avoid its (then non-__init) instantiation to stay with an ENDBR. Yet then you could at least _call_ that wrapper here, instead of open- coding it. And I further think the iommu_enabled checks should move out of the vendor functions, plus the hook also has no need anymore to have a return type of int. I guess I'll make a follow-on patch if you don't want to fold this in here. Jan From xen-devel-bounces@lists.xenproject.org Thu Mar 03 07:44:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Mar 2022 07:44:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.282796.481613 (Exim 4.92) (envelope-from ) id 1nPg8D-0005LL-Mn; Thu, 03 Mar 2022 07:44:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 282796.481613; Thu, 03 Mar 2022 07:44:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPg8D-0005LE-Jn; Thu, 03 Mar 2022 07:44:13 +0000 Received: by outflank-mailman (input) for mailman id 282796; Thu, 03 Mar 2022 07:44:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nPg8B-0005L8-V3 for xen-devel@lists.xenproject.org; Thu, 03 Mar 2022 07:44:11 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b66066de-9ac5-11ec-8eba-a37418f5ba1a; Thu, 03 Mar 2022 08:44:10 +0100 (CET) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04lp2057.outbound.protection.outlook.com [104.47.14.57]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-15-KPeLBl7DPn-pAsEc1wTLJQ-1; Thu, 03 Mar 2022 08:44:08 +0100 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB4207.eurprd04.prod.outlook.com (2603:10a6:803:3d::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.14; Thu, 3 Mar 2022 07:44:08 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5038.014; Thu, 3 Mar 2022 07:44:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b66066de-9ac5-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1646293450; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8jC6mGHn2Ad2BGiJFLUZjUmDowOsvazMP52tFaHd/OY=; b=IKnNeAnCAcLtroDzvLWxLV1pgBoLhGE4FPLswEH7L2xs3X40mjEP+QeMaMXLoJbJmqiUUF /OZuxmp01pMwsBPmv7+FwFbirtSJ3PkFbbPZbUv4Kdae15LFdTVx4VRlf7vSw0zExyIiKO T/1KyBDY3nXtLU3kxw6gtJUdhd1jbas= X-MC-Unique: KPeLBl7DPn-pAsEc1wTLJQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O++pxZVD18kVLigntuum7ViPVR+tfhWPJXMUlNuxu3OTaT6GHAfCvYQ2btrIYjDvTWEOmfK708WoDQWRif0xghMVaQ7N1EPVir4H40VrYTP6PrSfIKWjKg9eoB5XEyvEZoENlPQhmd/3LSHk0vCOUDqfakF4GWPK5m/08p/okpt+QInPGJ7m7lwJFHaWj0/GaIb0wUDrfYmDFr48Bh7nlTzsS37kmXIvVWFX/OPpi7FCT5GKDWxyMl4btSNlBJZNXYrOfZLo7u4UdSETKGIWzfwmvcrR/4ZRZ7v5u0ihVX4LiTwLTA9tbUu8QkB/Pl8LI1aMj6b/u3FcUdn8HzsDzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8jC6mGHn2Ad2BGiJFLUZjUmDowOsvazMP52tFaHd/OY=; b=a/yTGpCd/+hsIy/lL5lslSpFO0NwEDkY4mFa+xLr7ZHPBMwxhfwk+egKNF27R9iFBszHDJrZ12zmFsVn6sCayXIhoxdvCZ3g1Pt6fHp9RRVEk9wGBpVm1Btz1STovJWkunag0qfNBUctUMKOtqFoIzxtImjoctm18uwczgH+OBD6AIsTxXsKp6bLFFrN6oTYK2tehOF2Uakp7TuzyuknT3TgcOznNH4jtrVxNV07QYPbCJYIYdSekDnfzVU6Y77oBU2oD676dtkkqNubgQWsdqvnhv9USqUOxLNEYoO2bSDXHl8W+kp98i2K1WSrrxdWuV3uMiEuBKsVtBJAOH5Tmg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <6ffbc025-758e-bb7e-4e87-0b6b9e1bc2e5@suse.com> Date: Thu, 3 Mar 2022 08:44:05 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH] x86/cmdline: Interpret 'vpmu' as a positive boolean Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20220302221157.17246-1-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20220302221157.17246-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6PR0202CA0068.eurprd02.prod.outlook.com (2603:10a6:20b:3a::45) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4b6e1a75-036d-4a20-db66-08d9fce99908 X-MS-TrafficTypeDiagnostic: VI1PR04MB4207:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: T+mH58AeWmPraN1MRdAOpuhPZip9LlnznMPch6BHcCP/H0E8k0WsAWF+3FBatWW8SDKT/MwdHIxArZmark1wCBaQH1Wza548B4tiBoBFFzy9Yvvaev1jQavEBm6TsdYJAVXiIRS2RzRpYn1aQSUAR4x5x+9uSAb+ErEgVBVoeHA9IBsr5NmhlCW5Yduy81fEFcYm60ESw/L/xCVb5PKCBoVWhwsTxYupyYk5/nrUY0VtakO0IhxMXI/H1EZFHdnH+ZCo8Ccop7MRzGCT1M4zOjtHcDwPUstlrl/smryxCjDu5cLo8+0yaEP0kER7MS9zjMSqI3syJ5WfqY8w6Awg3AiWqDSj6vsQXfcez4FewKx9iu1kkdHn9TiqFjcLLU8vN6LJde5vJ+HWyxVwSFkTHvszQNxYJUZVNlRNTJnr05sg1L4+D4ft0bySz2jDhpcWNk2cTWD975y5QN2lMZ4/SNtqipAQo4XQ2874LPppnynWUIAo2xRlHMVg5XeRoVgBkrgXsroIacvyD2O7geSQ6P+pQaFoQf751NoQhmlJcmJAiBI5rCO6rpd9Z6fXPam6B6brfNddc4v/U7k3hddGHeu52qh6dfxWndW5di5w6rNeG8ABVM6+jmJ0ClUtby2elVrIck9GhWr+c4fWle4p7dF4tqUbkhv2CYkIJMqR9ke9cR7aaptl/P92JrX/AAaY8lV95pOypXAxRDUK3d/Zce0RfRtKIY/63gdpDMT1LDuukWrd3ftrDsqRfLoxYWQ/ X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6486002)(4326008)(31696002)(6666004)(36756003)(86362001)(53546011)(4744005)(54906003)(31686004)(26005)(186003)(6916009)(6506007)(316002)(8936002)(38100700002)(66946007)(66556008)(66476007)(2906002)(8676002)(5660300002)(6512007)(2616005)(508600001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eTN1VjRveFJwaVAyc3Y5OE0yTWU1ZEQ0V0tiWFRoNTl3WlpDYm1XaTFQZWlu?= =?utf-8?B?ckdIUk9LL2VpVnFwZmp3STRjK2MzUURaV2JSbldUTEdNM2RtWXhmYTlrSG5a?= =?utf-8?B?a3FYQ0RyU3ZHUjBJV0h2cE1FNHUwYjJIMTYrTm5DQjhQWFFHeHoyeUtCWEZj?= =?utf-8?B?UWptdWxzWXdwRlZOOVdZUFVUTXplMEsrdmthNnpadVJaNjdWTUpuOU92MWJM?= =?utf-8?B?UStWaVA4aFlka1FWL3FTOWt0WENYWVRvbmR5aTZVY0c1cmJoa1NRZ0dlY3Ur?= =?utf-8?B?c3FySEY0Ykx4aUFCOTZ2Nml3MUFPNHozK3pvK3RZQ1FmZWRzaWxiV2FxQzZX?= =?utf-8?B?ZWl5SDdaOHN3NDNiNUZ5MVN2VHZ5cXdRUmQyU0pFU2NwWkw2WkRaQ1krSnJy?= =?utf-8?B?bTJQYStZT0E5cUdCNldZL0dmR0NNdmQvSEd5dGRSQmpwcFBONEZwNTNYc3Vt?= =?utf-8?B?UUYxVFVIL2xWL3MyTnRNQUFmWTRhc0ZzQko0QUQ4SDdvSEw5WGZJdldDbm40?= =?utf-8?B?bnBhaDdLYVU0R3BobGJTN3FVZUs2OTBZUkk5cTNUdTg4WGhmOStZVmNBc3N1?= =?utf-8?B?eDJOeGN1Y0Y4WEd6bnhKUCtLbFpXVVE0SlRmUGY2NlBmYndJMlRHVGp0bjZi?= =?utf-8?B?bGZjOFdpaXI3c3NGOUwwaFVlR3drcEZ4L2VTZU5wczRkN2M5Z0UySTk4Qktj?= =?utf-8?B?aHc4UXhLRlZKOEhtV1pOTU5PNk9OcER5RDM5em5YSlFUZ2M0eVNCTTlzVzhB?= =?utf-8?B?REJTbmVQcDZqYVpXa0IyQTZzbTlOVk1oQ01LendINUdaa3I1WFk1QWdDTXlE?= =?utf-8?B?ai9EMGxkaS95aWJscEdmZDlwekpEVXBDMTNjYXl5LzBaMm9zV3ZZdlVCNlZQ?= =?utf-8?B?VHArTEwvYjBaYkxxOXR2MlBGeUtlUVZralFJMnlySkxHa3BZRU9naFNJdVlN?= =?utf-8?B?cCtnSlduQjAzLzM4RnNyZWJNQUdqbTFnMFQzZG52ckk5d1hRTUc4WXdsWlVq?= =?utf-8?B?RUsyOTFGeVRzRG1NN1c4VmN5Mk0zWEFnbjFpVnZwT2NzN0F2VWxZcUpJcHRr?= =?utf-8?B?a2JXdysxU0JUSk1JWFhjZHE4SmE1ajV3YUozQWgrMXdQUzVhOStsNVBOektO?= =?utf-8?B?emY1aTU3dzhERHdDRmZqdHdyQ3JlZHhhSnowZ29HN0dxTmFTQXl6WVNQbmph?= =?utf-8?B?ZFc5NlpjUHhHdWYxRkVWQ2ZleXFWTVlxNVIyQldZZGpiRjZ6dXMyWmM5Uk9k?= =?utf-8?B?RG5lUitLdy9TaE9XR3F3VW5oVVhtS1VYUUZId3c1bkNkUFV4UncvTkdFb2Rz?= =?utf-8?B?SHA0cFYwQUNtS0ZyZFlzcjRUTEpkRmRPVDR6WS8rY1NyVjVlZzlCZ1RWM2Ey?= =?utf-8?B?T3JieFk0di9VcnZBUU9mS3FjTUsvRnpmWUJIazRDWmg1amZlb0hiQjkvVUxz?= =?utf-8?B?QWloaXRUT3I5UGcxWjZYbjJzSXhIMzFRWUE5bE1BUzNSZXB2ZEhqbVFBaHpZ?= =?utf-8?B?WnRNTGlmWUVvMVJacnR4ZEtOM09KTlJKRG1mblg4ZnhFSUx3b2hxOG1ndWxx?= =?utf-8?B?MC8ySTZ1MU1yeUtWS0NzYno2dWpveWtXUDIwdFgzQVdGS0ZTcVNXcE55N3V3?= =?utf-8?B?RGxRUjVKSytMUWZXYndNeTFQOWxJdUpOYlo1aWdkOW5QVVBHT0lFeWRtS1VZ?= =?utf-8?B?US94YmlaSFI2d0FPTVh4Ny9RelB4dzJBQWdHNmtDS3hzTW9TTzhUaWp4ZHdS?= =?utf-8?B?MWV0b2k3ckc0RHNURkJJTVVTamYwWG5IU1hOakc1YlUrKzJ1WWZkdW9Lbzl3?= =?utf-8?B?NUFkSnpZNWNkKzVxZVFzZ1BzRUU1bjVzTWxaUmhsdnRDb2JpeGRDU0x0RUxP?= =?utf-8?B?TFVkR3UyY2xPM1g1c3Vzbk0xczc3T0VOcVZmK1E4SVhMZjRqS3llUW93ZFZM?= =?utf-8?B?OWYwS3BzZnQ1UnRQbVVXVzUwTnA1VTVmSUR5RUROT0dwenE2eHpqMi9DTG55?= =?utf-8?B?SnAxZ3V2N0lpWkdvVGM5RWU3bUxNREY2eDBoV2hacXFHWHBsRVR0TzMwSGZl?= =?utf-8?B?OFhRZk4zL0hhbmdDQm8xZEZ6c2g4L0cxSWZuUXROczROaExQMUQ0eW9FN3Rr?= =?utf-8?B?TDZYWXVHVytXK29sVHJPQWtFUnFheXZheEpHK3UwdlZRYkVZK2NiUzBlS0kx?= =?utf-8?Q?lWmMWNSGDBeYm4i1SuD4rLs=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4b6e1a75-036d-4a20-db66-08d9fce99908 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2022 07:44:07.9865 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Z9oyrF3YVWpox2XOu2fu/N4g9ihw3MKPZYBPiP5wo/8iQeVzj+lu1kGG6EypjMFR7WTdMvJMewfsO+k6qzDhAQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4207 On 02.03.2022 23:11, Andrew Cooper wrote: > This makes it behave slightly more like a regular boolean option. > > Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich > Slightly RFC, because there is no easy way of making the opposite "normal > boolean" case work for no-vpmu. There's nothing to do to make this work afaict: Generic command line handling converts "no-